Packages/TYPO3.CMS.git
8 years ago[FEATURE] Rounding functionality in stdWrap
Kilian Hann [Sat, 9 Jul 2011 10:01:10 +0000 (12:01 +0200)]
[FEATURE] Rounding functionality in stdWrap

Provides rounding functionality (round, ceil, floor) to stdWrap.

Change-Id: Iec4dd4df61e3e0dcb0556fa4ddeb34adaffa9823
Resolves: #28027
Reviewed-on: http://review.typo3.org/3178
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
8 years ago[TASK][!!!] Improve Backend search
Dmitry Dulepov [Wed, 18 May 2011 11:52:59 +0000 (14:52 +0300)]
[TASK][!!!] Improve Backend search

There are several problems with current Backend search:
* it searches far more fields than necessary (for example, TSConfig)
* it searches "uid" and other numeric fields even if the value is not
  numeric
* it uses LIKE x search on numeric fields and forces DAM to make an
  XCLASS
* it searches all tables even if they do not make sense to be searched
* it is too slow
* it searches only first four levels deep in the page tree

All these problems come from the [wrong] idea that TYPO3 can detect
where it can search. Instead, tables should be marked as "searchable"
and provide a list of fields that make sense to search. Also it makes
sense to search some fields as case insensitive. This task solves all
described issues.

After this change extensions will need to explicitely mark their tables
as searchable. Until that, those table will not be searched.

Search by default is NOT case sensitive. If the developer wants a case
sensitive search on the column, (s)he should ensure proper locale on
that column (as described at http://bit.ly/1zw8dC) and mark the column
as case-sensitive for search (see TYPO3 core API for more details).

Change-Id: I2b194dc1c746a4fc3f7663358ed08d7c9f6e11a8
Resolves: #26829
Releases: 4.6
Reviewed-on: http://review.typo3.org/2189
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Markus Klein
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Kay Strobach
Tested-by: Kay Strobach
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
Reviewed-by: Xavier Perseguers
8 years ago[BUGFIX] BE: remove tag-fragments from text-version of a richtext-field
Stefan Neufeind [Tue, 28 Jun 2011 14:45:47 +0000 (16:45 +0200)]
[BUGFIX] BE: remove tag-fragments from text-version of a richtext-field

The text-version contains the "first attribute of empty tags".
While this might make sense for <LINK ...>-tags it is quite
pointless for all other HTML-tags.

Change-Id: If56dbe3682173e0b4144749430cce6b11e99edcf
Resolves: #27743
Reviewed-on: http://review.typo3.org/2952
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
8 years ago[BUGFIX][Cache] File backend: Create directory after flush()
Christian Kuhn [Mon, 11 Jul 2011 10:32:38 +0000 (12:32 +0200)]
[BUGFIX][Cache] File backend: Create directory after flush()

The file backend does not re-create the cache directory on
flush() which leads to problems if calling flush() and set()
afterwards again. One unit test had to manually clear cache
files because of that and can be simplified now.
This is an issue in TYPO3 v4 only, FLOW3 is not affected.

Change-Id: Ic7756b2c14641789696f10c223d76439ca7e9602
Resolves: #28090
Reviewed-on: http://review.typo3.org/3249
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[TASK] Move XLIFF handling to t3lib
Xavier Perseguers [Thu, 7 Jul 2011 23:29:41 +0000 (01:29 +0200)]
[TASK] Move XLIFF handling to t3lib

All XLIFF code should better be located within t3lib.

Change-Id: I2bad66f9e2c92015e9aab4a06e8c92e96762ab9a
Resolves: #28055
Reviewed-on: http://review.typo3.org/3217
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[TASK] Clean up phpDoc comments in t3lib_div
Sebastian Michaelsen [Mon, 11 Jul 2011 09:11:21 +0000 (11:11 +0200)]
[TASK] Clean up phpDoc comments in t3lib_div

Clean phpDoc comments are important to make the API understandable to
users and IDEs. t3lib_div is a good point to start with.

Lots of comment changes to comply with CGL especially:
* Provide the variable name in the @param line
* Unify white spaces between @-command, datatype, varname and description
* Correct wrong datatype declarations (default 0/1 to TRUE/FALSE for booleans)
* Add some missing / incomplete phpDoc comments
* Correct some spelling issues

Change-Id: I5265e172b5787a78b2598406eb40b8bcc68e07dc
Resolves: #28087
Releases: 4.6
Reviewed-on: http://review.typo3.org/3242
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] t3lib_div::debugRows doesn't return data
Sebastian Michaelsen [Mon, 11 Jul 2011 08:48:40 +0000 (10:48 +0200)]
[BUGFIX] t3lib_div::debugRows doesn't return data

In TYPO3 4.5 t3lib_div::debugRows() was deprecated
and moved to t3lib_utility_Debug::debugRows().
The problem is, that t3lib_utility_Debug::debugRows()
is just called but not returned, despite the fact
that debugRows() offers an option $returnHTML to
return an HTML table.
So in the (a bit unlikely) case someone relies on
values returned by t3lib_div::debugRows(), 4.5 broke
his code.

Adding a simple "return" will solve this problem.

Change-Id: I4e328db1b78975a7baed386a316dc50f00a0ac40
Resolves: #28085
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/3238
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[TASK] Update information in INSTALL.txt to meet requirements
Markus Bucher [Sat, 9 Jul 2011 10:36:12 +0000 (12:36 +0200)]
[TASK] Update information in INSTALL.txt to meet requirements

Change-Id: Ib296b19d98ed1de1830d479a04224f16e660a7b1
Resolves: #28031
Reviewed-on: http://review.typo3.org/3183
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Kilian Hann
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[TASK] Refactor TYPO3.l10n localize handling
Laurent Cherpit [Sat, 9 Jul 2011 20:41:14 +0000 (22:41 +0200)]
[TASK] Refactor TYPO3.l10n localize handling

- Change inclusion Order of the sysext/lang/res/js/be/typo3lang.js jsFile.
- Change TYPO3.l10n to sanitize TYPO3.lang array to store only string on it.
  Therefore use a private array to store a copy of lang objects with will
  be accessed via TYPO3.l10n.localize.

Change-Id: Ie05cd5baf39d8366328f8aa6193e39816721ee1c
Resolves: #28057
Reviewed-on: http://review.typo3.org/3227
Reviewed-by: Sebastian Kurfuerst
Tested-by: Sebastian Kurfuerst
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] locallangXMLOverride hook has been removed
Dominique Feyer [Thu, 7 Jul 2011 23:29:41 +0000 (01:29 +0200)]
[BUGFIX] locallangXMLOverride hook has been removed

This feature is back with a small addition. We can now override
a specific language only, with this configuration:

$GLOBALS['TYPO3_CONF_VARS']['SYS']['locallangXMLOverride']
['fr']['EXT:aboutmodules/mod/locallang_mod.xml'][] = 'fileadmin/fr.locallang_mod.xml';

Change-Id: I0f92542305594c08d883462a4ce504da820e74dc
Resolves: #27923
Reviewed-on: http://review.typo3.org/3120
Reviewed-by: Stefan Neufeind
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] Correct icon for edit page settings
Stefan Galinski [Sat, 9 Jul 2011 21:01:04 +0000 (23:01 +0200)]
[BUGFIX] Correct icon for edit page settings

Change-Id: I612ad31c2e9ac31b76459f81121028fd0630e5e6
Resolves: #28060
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/3228
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
8 years ago[BUGFIX] Fix broken cleanup in t3lib_autoloadTest
Christian Kuhn [Sat, 9 Jul 2011 21:01:30 +0000 (23:01 +0200)]
[BUGFIX] Fix broken cleanup in t3lib_autoloadTest

Change-Id: I275a1ba8abe9f56f940ba3441d8c7e10253cb0e5
Follows: #28037
Reviewed-on: http://review.typo3.org/3226
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[TASK] Deprecate functions in page module
Georg [Thu, 7 Jul 2011 12:18:00 +0000 (14:18 +0200)]
[TASK] Deprecate functions in page module

The page module has a direct a support for extensions
like tt_calendar, tt_guest and others.

Those extensions can use other ways to show records
in page module and no need for it in core.

Change-Id: I037e7ce6e912e7fdf1416747eb9f54353266632b
Resolves: #27940
Reviewed-on: http://review.typo3.org/3104
Reviewed-by: Stefan Neufeind
Reviewed-by: Tolleiv Nietsch
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[TASK] Add unit test for t3lib_autoloader
Andreas Wolf [Sat, 9 Jul 2011 14:10:22 +0000 (16:10 +0200)]
[TASK] Add unit test for t3lib_autoloader

Change-Id: Id8b4d1c50ab17bd0cd4278dd6e6e487937b1c66d
Resolves: #28037
Releases: 4.6
Reviewed-on: http://review.typo3.org/3196
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[TASK] Add security information to INSTALL.txt
Markus Bucher [Sat, 9 Jul 2011 10:06:53 +0000 (12:06 +0200)]
[TASK] Add security information to INSTALL.txt

Change-Id: I1bfe301a1b7bc5c39d0193ac6d306b447557ba6f
Resolves: #28022
Reviewed-on: http://review.typo3.org/3180
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[TASK] Decouple extMgm::extPath from TYPO3_LOADED_EXT
Christian Kuhn [Sat, 9 Jul 2011 13:22:53 +0000 (15:22 +0200)]
[TASK] Decouple extMgm::extPath from TYPO3_LOADED_EXT

To simplify the bootstrap it is required to make
t3lib_extMgm::extList() work more early. This is achieved
by removing the dependency to $GLOBALS['TYPO3_LOADED_EXT']

Change-Id: I73aa8c3a72979c85bf6f34cf027565199e380920
Resolves: #28034
Reviewed-on: http://review.typo3.org/3191
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[FEATURE] Add PHP code cache
Christian Kuhn [Sat, 9 Jul 2011 14:30:12 +0000 (16:30 +0200)]
[FEATURE] Add PHP code cache

Change-Id: If0f089a749123bce339df900d58c5f310969b1ea
Resolves: #28054
Reviewed-on: http://review.typo3.org/3216
Reviewed-by: Philipp Gampe
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[CLEANUP] Remove deprecated hook XLLfile
Steffen Gebert [Sat, 9 Jul 2011 19:50:27 +0000 (21:50 +0200)]
[CLEANUP] Remove deprecated hook XLLfile

Change-Id: Ic3cbd9ed35423081c713d3144d3cbbbed79e3d7f
Resolves: #28053
Relates: #21496
Reviewed-on: http://review.typo3.org/3214
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[TASK] Remove deprecated usages of intInRange, intval_positive and int_from_ver
Susanne Moog [Sat, 9 Jul 2011 10:05:34 +0000 (12:05 +0200)]
[TASK] Remove deprecated usages of intInRange, intval_positive and int_from_ver

This is part of the t3lib_div refactoring started at T3DD11.

With #28019 these methods have been moved to own utility
classes, now the Core should uses these.

Change-Id: Ib5b0d8f9a4322e5489b148e280993a3579fc21af
Resolves: #28026
Reviewed-on: http://review.typo3.org/3179
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Stefan Neufeind
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[TASK] Move intInRange, intval_positive and int_from_ver
Susanne Moog [Sat, 9 Jul 2011 09:25:49 +0000 (11:25 +0200)]
[TASK] Move intInRange, intval_positive and int_from_ver

Adds Unit tests for intInRange, intval_positive
and int_from_ver and move them to suitable locations.

Change-Id: Iddcf80ce2e65f686a8e9057a962a4ed2f842d017
Resolves: #28019
Reviewed-on: http://review.typo3.org/3173
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[FEATURE] New caching framework implementation for l10n
Dominique Feyer [Sun, 26 Jun 2011 22:39:15 +0000 (00:39 +0200)]
[FEATURE] New caching framework implementation for l10n

Add custom caching table for parsed l10n file.

Change-Id: Ia59a77757112bccbf7a53ebeec71928f06ebe02a
Resolves: #25397
Reviewed-on: http://review.typo3.org/2930
Reviewed-by: Stefan Neufeind
Reviewed-by: Björn Pedersen
Tested-by: Björn Pedersen
Reviewed-by: Peter Beernink
Tested-by: Peter Beernink
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUG] t3lib_div::devLog - PHPDoc Comment does not match method signature
Sebastian Michaelsen [Sat, 9 Jul 2011 18:14:22 +0000 (20:14 +0200)]
[BUG] t3lib_div::devLog - PHPDoc Comment does not match method signature

Change-Id: Iba6222bdd79d62057ba0338ac0a88614583c1690
Resolves: #28050
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/3206
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[TASK] Extension Cache Behaviour is messy
Benjamin Mack [Sat, 9 Jul 2011 14:30:52 +0000 (16:30 +0200)]
[TASK] Extension Cache Behaviour is messy

The cache files in typo3conf/temp_CACHED_* were by default set to a hash that
was based on the extensionlist, but this is quite unnecessary, so the extCache
option was removed to be only used once in the typo3conf/ directory in order
to prevent hundreds of temp_CACHED_* files that don't get cleaned up
automatically. From now on the option $TYPO3_CONF_VARS['EXT']['extCache'] can
only be set to 0 or 1.

Change-Id: Ic6081deeb306d8a7ef8b5f3d358c1d63ddb74ae8
Resolves: #28040
Reviewed-on: http://review.typo3.org/3197
Reviewed-by: Georg Ringer
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[BUGFIX] Skip t3lib_divTest::fixPermissionsSetsGroup on MacOS
Oliver Klee [Sat, 9 Jul 2011 09:02:21 +0000 (11:02 +0200)]
[BUGFIX] Skip t3lib_divTest::fixPermissionsSetsGroup on MacOS

This test makes use of posix_getegid which on Mac OS always returns -1,
thus making it useless for getting the effective group ID.

Change-Id: Ic16e52c462429401342f5a5f9705353b48dac1e9
Resolves: #28017
Releases: 4.6, 4.5, 4.4, 4.3
Reviewed-on: http://review.typo3.org/3172
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Localization: Editing in TCEforms shows unstyled original value
Benjamin Mack [Sat, 9 Jul 2011 08:22:50 +0000 (10:22 +0200)]
[BUGFIX] Localization: Editing in TCEforms shows unstyled original value

When editing a translated record in the TCEforms backend, the original
language label is shown below, in a green box. The green box is
definitively from the old skin (3.x) and should be changed.

Change-Id: I1974fa39353ee82f11ef31a1ae8f49a6b5cd1c02
Resolves: #28012
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/3169
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Stefan Neufeind
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
8 years ago[BUGFIX] Add removed deprecation message again
Christian Kuhn [Sat, 9 Jul 2011 13:31:04 +0000 (15:31 +0200)]
[BUGFIX] Add removed deprecation message again

Change-Id: I4e099e31e5f8a5b6541fe98bbbedc4e237cf3fc4
Follows: #27985
Reviewed-on: http://review.typo3.org/3192
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[CLEANUP] make TCEmain::getInlineFieldType() more understandable
Andreas Wolf [Sat, 9 Jul 2011 11:24:36 +0000 (13:24 +0200)]
[CLEANUP] make TCEmain::getInlineFieldType() more understandable

With 933254e2e69df05b41ae1f3b026a8f4c6f8fc09d, the method was made more
complicated without an obvious need for that. This patch reverts these
change, plus moving the guard clause to the beginning with an early
return in it, thus making the structure even more obvious.

This change has been integrated into the original patch for 4.5.

Change-Id: I9e7d987158adad089880c2185467555659b1827c
Releases: 4.6
Reviewed-on: http://review.typo3.org/3186
Reviewed-by: Steffen Ritter
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
8 years ago[TASK] Space and tab cleanup for the BE log module
Dominique Feyer [Sat, 9 Jul 2011 10:08:51 +0000 (12:08 +0200)]
[TASK] Space and tab cleanup for the BE log module

Just a cleanup mainly CGL, comment identation, space and tab related

Change-Id: I7ee89ae7be1b3911bae1b90ca9634d2e75bf3466
Reviewed-on: http://review.typo3.org/3182
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
8 years ago[FEATURE] Improve Backend Logging module
Dominique Feyer [Sat, 9 Jul 2011 07:53:10 +0000 (09:53 +0200)]
[FEATURE] Improve Backend Logging module

- Remove the error sign after the error icons

Resolves: #28014
Change-Id: Ibdcfd7e951ec59fed69e42726422169bf05e3684
Reviewed-on: http://review.typo3.org/3168
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
8 years ago[TASK][Install] Move sql handling to own class
Christian Kuhn [Fri, 8 Jul 2011 17:03:20 +0000 (19:03 +0200)]
[TASK][Install] Move sql handling to own class

Decouple sql parsing, compare and update code from
t3lib_install to own t3lib_install_Sql class.

Change-Id: I60b8342f8c0041dddb64da7f48b0aec544dfbe32
Resolves: #27998
Reviewed-on: http://review.typo3.org/3156
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[FEATURE] pagetree dataprovider should enable node postprocessing
Tolleiv Nietsch [Tue, 5 Jul 2011 06:57:21 +0000 (08:57 +0200)]
[FEATURE] pagetree dataprovider should enable node postprocessing

In order to change pagetree node properties the dataprovider should enable
postprocessing of the node-collections. Used e.g. to highlight nodes
when tt_content elements have changed on a page.

Change-Id: I128ece4f659212978b06b65d5486c1124c4bf81e
Resolves: #25255
Reviewed-on: http://review.typo3.org/1037
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[TASK] Unit tests for extMgm::extPath()
Christian Kuhn [Sat, 9 Jul 2011 07:58:51 +0000 (09:58 +0200)]
[TASK] Unit tests for extMgm::extPath()

Change-Id: I42ecefc082f98d899dfa712e9addea9ba2bade17
Resolves: #28011
Reviewed-on: http://review.typo3.org/3167
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] htmlArea RTE: TV CE editing not possible
stan [Sat, 9 Jul 2011 02:42:13 +0000 (22:42 -0400)]
[BUGFIX] htmlArea RTE: TV CE editing not possible

TV CE editing not possible as class.tx_staticinfotables_div.php is required by htmlArea RTE but apparently does not exist, despite the fact that extension Static Info Tables is loaded. No idea how to reproduce such an error.

Change-Id: I6a86c9c22c04488ad7fec3c2cc6b7b90e4f43fac
Fixes: #27819
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/3164
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[BUGFIX] BE User module allows switching to CLI users
Andreas Wolf [Fri, 8 Jul 2011 22:34:15 +0000 (00:34 +0200)]
[BUGFIX] BE User module allows switching to CLI users

The backend user module shows two icons to switch to a given user (with
and without possibility to go back). This is also enabled for CLI users,
which can effectively render the session unusable.

This patch removes the icons if the username starts with _cli_.

Change-Id: Ic99e0ef0bacc6092f0073b5be28b4755e652bbc2
Resolves: #28008
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/3162
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
8 years ago[BUGFIX] Remove editing restriction for elements in workspace-stages
Tolleiv Nietsch [Wed, 22 Jun 2011 12:38:29 +0000 (14:38 +0200)]
[BUGFIX] Remove editing restriction for elements in workspace-stages

Fix bug where a (workspace) element which left the "editing" state can't be edited anymore if the editor doesn't have appropriate permission
for the current stage of the element. Now everyone can edit if they
are member within the workspace.

Change-Id: I172fe8e3f04fbc06ce1d33481032eaeae9532b6b
Resolves: #27643
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/2873
Reviewed-by: Michael Klapper
Tested-by: Michael Klapper
Reviewed-by: Stefan Neufeind
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Susanne Moog
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
8 years ago[BUGFIX] Unit tests for dbbackend throw db errors
Philipp Gampe [Fri, 8 Jul 2011 17:18:10 +0000 (19:18 +0200)]
[BUGFIX] Unit tests for dbbackend throw db errors

When running the unit test for t3lib_cache_backend_dbbackend
eight sql errors are thrown. This could happen if TYPO3_DB is
mocked.

Change-Id: Ie7c55321f2d7825e7af269515ea2b655b581e031
Resolves: #28000
Reviewed-on: http://review.typo3.org/3158
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Localization of child records fails when using MM type relations
Oliver Hader [Tue, 14 Jun 2011 15:35:45 +0000 (17:35 +0200)]
[BUGFIX] Localization of child records fails when using MM type relations

Regular MM references are not localized, however if Inline Relational
Record Editing (IRRE) is used here, it would be the expected behaviour.

Unit tests are available in the irre_tutorial:
http://forge.typo3.org/projects/show/extension-irre_tutorial

Change-Id: I4c1b7254ff48b592e96c0ac584ab3a79d2b7bfce
Resolves: #25131
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1244
Reviewed-by: Stefan Neufeind
Tested-by: Philipp Gampe
Reviewed-by: Xavier Perseguers
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
8 years ago[BUGFIX] htmlArea RTE: Remove reference to deleted object
stan [Fri, 8 Jul 2011 16:22:51 +0000 (12:22 -0400)]
[BUGFIX] htmlArea RTE: Remove reference to deleted object

HTMLArea.Plugin refers to deleted HTMLArea.Dialog.

Change-Id: Ic16f1a5e953d84bf083972e3a3d60767bf8f10e4
Fixes: #27997
Related: #25009
Releases: 4.6
Reviewed-on: http://review.typo3.org/3155
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[BUGFIX] htmlArea RTE: Text indicator refers to deleted color conversion function...
stan [Fri, 8 Jul 2011 15:34:32 +0000 (11:34 -0400)]
[BUGFIX] htmlArea RTE: Text indicator refers to deleted color conversion function aliases

The function aliases were deleted as part of TYPO3 4.6 cleanup.

Change-Id: I5f386cbd1c7e32e46440b4621fc9279ba1aa7cf8
Resolves: #27994
Related: #25093
Releases: 4.6
Reviewed-on: http://review.typo3.org/3154
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[BUGFIX] Hide versioning icon in list when workspaces is installed
Tolleiv Nietsch [Thu, 7 Jul 2011 05:34:13 +0000 (07:34 +0200)]
[BUGFIX] Hide versioning icon in list when workspaces is installed

Following #25962 the versioning icon in the
list module should be hidden whenever "workspaces" is installed.

Change-Id: Iaeb41a36131568716eeb8a23f54b0b5bf1b7a1df
Resolves: #27969
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/3118
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Philipp Gampe
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
8 years ago[TASK] TTFdpi should default to 96
Xavier Perseguers [Fri, 8 Jul 2011 08:59:24 +0000 (10:59 +0200)]
[TASK] TTFdpi should default to 96

Use 96 dpi instead of 72 as default value for
$TYPO3_CONF_VARS['GFX']['TTFdpi']

Change-Id: Ib668537cbd9f0acf25011b453ad60121f1a5376c
Resolves: #27978
Reviewed-on: http://review.typo3.org/3121
Reviewed-by: Dominique Feyer
Tested-by: Dominique Feyer
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] getLLL needs to fallback to default language
Dominique Feyer [Fri, 8 Jul 2011 10:36:35 +0000 (12:36 +0200)]
[BUGFIX] getLLL needs to fallback to default language

Change-Id: I592cbcbbfa60d08ddd7ebf928136a8b9c4fbe1da
Resolves: #27673
Reviewed-on: http://review.typo3.org/3127
Reviewed-by: Georg Ringer
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] TCA Tree should respect requestUpdate and type
Marco Huber [Thu, 24 Mar 2011 08:50:04 +0000 (09:50 +0100)]
[BUGFIX] TCA Tree should respect requestUpdate and type

TCA Tree should respect $TCA['myTable']['ctrl']['requestUpdate']
and $TCA['myTable']['type'], but the onChange Javascript is missing.

Change-Id: I46b9513413cbb61660609bbf73eb3551c5ce7a24
Resolves: #25382
Reviewed-on: http://review.typo3.org/1251
Reviewed-by: Stefan Neufeind
Reviewed-by: Fabien Udriot
Reviewed-by: Steffen Ritter
Tested-by: Thorsten Kahler
Tested-by: Steffen Ritter
8 years ago[TASK] Cleanup draft workspace usages
Tolleiv Nietsch [Wed, 6 Jul 2011 21:53:08 +0000 (23:53 +0200)]
[TASK] Cleanup draft workspace usages

The draft workspace is deprecated since 4.4, this patch
makes sure nobody is able to continue using it and
cleans up the related codes.

Change-Id: I9f3a51a822e3af5a80a6fede24ed5f94bd7fbee4
Resolves: #27947
Releases: 4.6
Reviewed-on: http://review.typo3.org/3105
Reviewed-by: Benjamin Mack
Reviewed-by: Oliver Klee
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
8 years ago[TASK] Remove function index
Christian Kuhn [Fri, 8 Jul 2011 11:29:03 +0000 (13:29 +0200)]
[TASK] Remove function index

The function index in the head of core classes is not maintained
and not useful in the time of powerful IDE's anymore.

Change-Id: If4e327b4e78f3b6fb74a3011d8c2eb5090abe690
Resolves: #27985
Reviewed-on: http://review.typo3.org/3128
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] LLXML Parser does not support localized label in the main LLXML
Dominique Feyer [Thu, 7 Jul 2011 22:21:46 +0000 (00:21 +0200)]
[BUGFIX] LLXML Parser does not support localized label in the main LLXML

Many extension use the main LLXML file to provide default language and
others languages (fr, de, ...). The parser must support that.

This patch add this support. The priority is always given to the
language pack found in typo3conf/l10n. If a language pack is found
the localized label in the main LLXML file are not parsed.

Change-Id: I27e2ba03679ed4cf00c23c6140d243cf6aba2256
Resolves: #27972
Reviewed-on: http://review.typo3.org/3119
Reviewed-by: Björn Pedersen
Tested-by: Björn Pedersen
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] Wrong usage of Ext.encodeURL in TBE_EDITOR.rawurlencode
Marco Huber [Thu, 2 Jun 2011 19:22:23 +0000 (21:22 +0200)]
[BUGFIX] Wrong usage of Ext.encodeURL in TBE_EDITOR.rawurlencode

If we want to use Ext.encodeURL() here, we have to change many other
things, too. Better use encodeURIComponent() here.
Ext.encodeURL() was introduced with #25350.

Change-Id: I1f5df4abe014e61ac463d5c12b9c240a6f2b7ccc
Resolves: #27028
Reviewed-on: http://review.typo3.org/2509
Reviewed-by: Stefan Neufeind
Reviewed-by: Stefan Aebischer
Tested-by: Stefan Aebischer
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
8 years ago[TASK] lang: hscAndCharConv is not needed anymore.
Benjamin Mack [Thu, 7 Jul 2011 20:40:23 +0000 (22:40 +0200)]
[TASK] lang: hscAndCharConv is not needed anymore.

The functionality is not needed anymore, and is
now only a wrapper for htmlspecialchars().

Change-Id: I71d4fc210105d128de315d5777abbc555067deaf
Resolves: #27965
Reviewed-on: http://review.typo3.org/3115
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Philipp Gampe
Reviewed-by: Stefan Neufeind
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
8 years ago[TASK] Adhere to CGL: t3lib_div::getUrl() instead of t3lib_div::getURL()
Ernesto Baschny [Thu, 7 Jul 2011 18:55:11 +0000 (20:55 +0200)]
[TASK] Adhere to CGL: t3lib_div::getUrl() instead of t3lib_div::getURL()

Change-Id: If9ad418a4a70985cd661d1dd9c6f07498e833d95
Resolves: #24551
Releases: 4.6
Reviewed-on: http://review.typo3.org/3111
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] Date of 1970-01-01 is shown in unset date fields
Benjamin Mack [Thu, 7 Jul 2011 09:34:43 +0000 (11:34 +0200)]
[BUGFIX] Date of 1970-01-01 is shown in unset date fields

The backend shows 1970-01-01 since TYPO3 4.3, even though this
value is empty. I know that there is a problem with mySQL that
cannot differentiate between "0" and NULL, and that this is a
more difficult problem. In any case, even though showing
1970-01-01 is "valid", this is just a bad thing in terms of
usability and user-friendly-ness.

Change-Id: I780cd5e500378c06ddc680db6015a124b66820ca
Resolves: #27936
Releases: 4.6, 4.5, 4.4, 4.3
Reviewed-on: http://review.typo3.org/3098
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] Exclude E_DEPRECATED from exceptionalErrors
Helmut Hummel [Thu, 7 Jul 2011 08:26:40 +0000 (10:26 +0200)]
[BUGFIX] Exclude E_DEPRECATED from exceptionalErrors

To avoid exceptions in case an extension uses PHP functions
that have been deprecated in PHP 5.3, E_DEPRECATED messages have to
also be excluded from $TYPO3_CONF_VARS['SYS']['exceptionalErrors']

Change-Id: I3b5b4c8ec1738f9a3a9be146bb7e3a8a005087f3
Resolves: #27935
Reviewed-on: http://review.typo3.org/3088
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[TASK] Remove tslib/publish.php
Christian Kuhn [Wed, 6 Jul 2011 19:12:41 +0000 (21:12 +0200)]
[TASK] Remove tslib/publish.php

The patch removes the script itself, together with the 'publish'
section in the admin panel since these features have been unmaintained
for the last few TYPO3 versions. Besides that it relies on the system
extension simulatestatic and is not compatible with e.g. RealURL.

Change-Id: I46b11e79431d60eb594a60f46abaa28ec200b014
Resolves: #27927
Reviewed-on: http://review.typo3.org/3069
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[TASK] Remove global declarations inside methods
Stefan Neufeind [Tue, 14 Jun 2011 07:15:55 +0000 (09:15 +0200)]
[TASK] Remove global declarations inside methods

Global declaration such as global $TCA or global $BE_USER should
be changed to $GLOBALS['TCA'], $GLOBALS['BE_USER'], ...

(And applied minor CGL-fixes which appeared on the way.)

Change-Id: Ic75c591bcf8433ca520d6860b8615d106d63db82
Relates: #25334
Reviewed-on: http://review.typo3.org/2730
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] Installer: Filesize column of "Edit files" too small.
Markus Klein [Thu, 7 Jul 2011 14:43:06 +0000 (16:43 +0200)]
[BUGFIX] Installer: Filesize column of "Edit files" too small.

Filesize column size of "Edit files" listing is too small.

Change-Id: Ie8f5a06223e3781597e199e0de4ab724d4a4834c
Resolves: #27949
Releases: 4.6
Reviewed-on: http://review.typo3.org/3107
Reviewed-by: Qitec
Tested-by: Qitec
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[TASK] Change usage of t3lib_DB->sql_pconnect to t3lib_DB->connectDB
Thomas Maroschik [Wed, 6 Jul 2011 16:35:44 +0000 (18:35 +0200)]
[TASK] Change usage of t3lib_DB->sql_pconnect to t3lib_DB->connectDB

Currently many entry points that connect to the database use sql_pconnect
for that. This method is a low level sql method that skips hook initialization.
Also duplicate code was spread all over the entry points and are rewritten
to use the exceptions from t3lib_DB->connectDB.

Change-Id: I5b3cdecfed018be43236d1d54feac47a29333213
Resolves: #27954
Reviewed-on: http://review.typo3.org/3059
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Björn Pedersen
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[TASK] Rename reference to php locallang files
Georg [Wed, 6 Jul 2011 15:32:36 +0000 (17:32 +0200)]
[TASK] Rename reference to php locallang files

Even when the locallang file is a xml file
already, there are still the references to php
files.

Change-Id: Idf89a90c3f0dc865fc829c8e9f374776e9286214
Resolves: #27918
Reviewed-on: http://review.typo3.org/3052
Reviewed-by: Stefan Neufeind
Tested-by: Björn Pedersen
Reviewed-by: Björn Pedersen
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[TASK] Frontend: BE User Initialization should be encapsulated
Benjamin Mack [Wed, 6 Jul 2011 15:06:37 +0000 (17:06 +0200)]
[TASK] Frontend: BE User Initialization should be encapsulated

The handling of the Backend User initialization should be encapsulated
into TSFE.
This way, it's easier to extend it - and to exchange this code.

Change-Id: If28fcb7123ed0fc3bd34682e4a686eecb5178d3b
Resolves: #27917
Releases: 4.6
Reviewed-on: http://review.typo3.org/3051
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[TASK] Raise submodule pointer
Oliver Hader [Thu, 7 Jul 2011 12:20:09 +0000 (14:20 +0200)]
[TASK] Raise submodule pointer

Change-Id: I69e4c8aec330493a48c5ea70ffe33911dc273cab
Reviewed-on: http://review.typo3.org/3103
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[TASK] Add information for DBAL users
Xavier Perseguers [Thu, 7 Jul 2011 07:50:26 +0000 (09:50 +0200)]
[TASK] Add information for DBAL users

When using DBAL, hook INSERTmultipleRows_preProcessAction() will
not be called. Add relevant information to ease proper fallback
implementation.

Change-Id: Iee30a78a0a65889be9291fc7dba0f8535912f7d7
Reviewed-on: http://review.typo3.org/3081
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] Make the t3lib_DB interfaces usable
Thomas Maroschik [Wed, 6 Jul 2011 15:04:35 +0000 (17:04 +0200)]
[BUGFIX] Make the t3lib_DB interfaces usable

The pre- and postprocess interfaces introduced into t3lib_db were not
usable at moment due to the fact that the given parameters couldn't be
modified.

This change changes the signature of the interfaces and introduces
passing the arguments by reference.

Change-Id: Id4923f89a013e9479eb39348b2a3bdf9fcc0c30c
Resolves: #13579
Reviewed-on: http://review.typo3.org/3037
Reviewed-by: Philipp Gampe
Reviewed-by: Björn Pedersen
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[FEATURE][htmlArea RTE] Better Remove Format for MS Word
stan [Thu, 7 Jul 2011 05:52:43 +0000 (01:52 -0400)]
[FEATURE][htmlArea RTE] Better Remove Format for MS Word

Remove some additional MS-specific elements.

Change-Id: I80d3589f47653e2a83f1e0173a5bd43421fca349
Resolves: #25895
Releases: 4.6
Reviewed-on: http://review.typo3.org/3071
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[BUGFIX][htmlArea RTE] Localization is broken
stan [Thu, 7 Jul 2011 05:28:19 +0000 (01:28 -0400)]
[BUGFIX][htmlArea RTE] Localization is broken

As a result of Feature #25397: Adding XLIFF support as the default format for translation

Change-Id: Id9ad26a43ca46418a78692fbb11db351243a6851
Resolves: #27928
Releases: 4.6
Reviewed-on: http://review.typo3.org/3070
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[BUGFIX] Cache table layout - Intermediate fix
Christian Kuhn [Wed, 6 Jul 2011 16:27:45 +0000 (18:27 +0200)]
[BUGFIX] Cache table layout - Intermediate fix

Intermediate patch to fix current broken backend login
if upgrading to latest 4.6

Change-Id: Id78b98ee413e425e8c9908ffbbb3bf72446a341f
Resolves: #27921
Reviewed-on: http://review.typo3.org/3057
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
8 years ago[TASK] Raise submodule pointer
TYPO3 v4 Release Team [Wed, 6 Jul 2011 15:13:14 +0000 (17:13 +0200)]
[TASK] Raise submodule pointer

Change-Id: I8def28e353e671cbc71f7d456465eb1171bf5b97
Reviewed-on: http://review.typo3.org/3047
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
8 years ago[API][CONF][!!!] Make the name of cookies configurable
Christian Jul Jensen [Wed, 25 May 2011 14:11:00 +0000 (16:11 +0200)]
[API][CONF][!!!] Make the name of cookies configurable

To avoid different scenarios with clashing cookies on same-domain
sites, make the name of cookies used for BE and FE login
configurable.
To achieve this:
* add configuration options
* add setting of name in relevant classes with proper fallback
* change all uses of the names to API calls
* change time tracking start algorithm to detect BE user login

Change-Id: I8078bd284cdf5d1413ddce8bc004e25f855ba6c5
Resolves: #23872
Reviewed-on: http://review.typo3.org/2373
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Stefan Neufeind
Reviewed-by: Christian Jul Jensen
Tested-by: Christian Jul Jensen
8 years ago[FEATURE] Add Parser for PHP locallang array
Xavier Perseguers [Fri, 24 Jun 2011 07:01:41 +0000 (09:01 +0200)]
[FEATURE] Add Parser for PHP locallang array

Implement the parser to support LLPHP file as localization file format.

Change-Id: I4e4d66e73d92eae57663b8e905db33a17da5cb2a
Resolves: #27673
Reviewed-on: http://review.typo3.org/2903
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
8 years ago[BUGFIX] Backend doctype 'xhtml_trans' is broken
Steffen Gebert [Wed, 29 Jun 2011 17:40:32 +0000 (19:40 +0200)]
[BUGFIX] Backend doctype 'xhtml_trans' is broken

Since introducing HTML5 as default backend doctype (#23639), two
mistakes make it impossible to use 'xhtml_trans' as doctype for the
Backend output.

Change-Id: Icf66e03903ab07b56fec7fb12a7401b1818f4c1d
Resolves: #27774
Resolves: #27745
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/2990
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Oliver Klee
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
8 years ago[BUGFIX] Translation handling module broken
Steffen Gebert [Mon, 4 Jul 2011 15:25:09 +0000 (17:25 +0200)]
[BUGFIX] Translation handling module broken

Since introduction of XLIFF translations, the Translation Module of the
Extension Manager is broken.

Change-Id: I5d87a52af33b589462c429522b17361494a9bcde
Resolves: #27832
Reviewed-on: http://review.typo3.org/3036
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] Re-Introduce removed API method and mark it deprecated
Helmut Hummel [Sat, 2 Jul 2011 12:54:44 +0000 (14:54 +0200)]
[BUGFIX] Re-Introduce removed API method and mark it deprecated

After the refactoring of the form protection framework the API method persitTokens()
has been removed.

To not break existing extensions, re-introduce this method and
mark it as deprecated.

Change-Id: I2ef23724a3be8d3266d884506b066c587e332d9b
Fixes: #27809
Related: #25359
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/3016
Reviewed-by: Oliver Klee
Reviewed-by: Stefan Neufeind
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
8 years ago[FEATURE] Show the faulty URL when an extension cannot be fetched
Xavier Perseguers [Wed, 29 Jun 2011 07:01:43 +0000 (09:01 +0200)]
[FEATURE] Show the faulty URL when an extension cannot be fetched

When EM fails to fetch an extension, it returns an error message
without showing the faulty URL which makes it difficult to adapt
firewall configuration if needed.

Change-Id: I9cf5a49f2e2bcf4ca4b367903e86cd0aa1e0b22d
Resolves: #27753
Reviewed-on: http://review.typo3.org/2975
Reviewed-by: Andy Grunwald
Reviewed-by: Mario Rimann
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] Mirror selection is not respected
Xavier Perseguers [Wed, 29 Jun 2011 07:42:03 +0000 (09:42 +0200)]
[BUGFIX] Mirror selection is not respected

When a specific mirror is selected in Extension Manager,
the method used to return it fails.

Change-Id: I6beffd665e28f5e5061bcc55be1632641fd29224
Resolves: #27755
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/2976
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[TASK] Remove override of authentication fields
Xavier Perseguers [Sun, 15 May 2011 14:12:41 +0000 (16:12 +0200)]
[TASK] Remove override of authentication fields

Many class fields in tslib_feUserAuth override the ones from
parent class t3lib_userAuth. This makes refactoring complicated.
Change default value inside a constructor instead.

Change-Id: I61d2ba24e9ea9917acbd1ec6e56252f13be9ffdf
Resolves: #26826
Reviewed-on: http://review.typo3.org/2114
Reviewed-by: Oliver Klee
Reviewed-by: Dmitry Dulepov
Reviewed-by: Georg Ringer
Reviewed-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] Caching framework: Improve configuration handling
Christian Kuhn [Fri, 24 Jun 2011 19:54:14 +0000 (21:54 +0200)]
[BUGFIX] Caching framework: Improve configuration handling

The cache manager takes care of correct cache configurations
given to the cache factory. The patch improves the handling of
default configuration for lazy cache setups.

Registration of new cache frontends or backends in TYPO3_CONF_VARS
is removed, new cache frontends or backends of extensions can be
defined by registering them to the autoloader only.

Change-Id: I62fd755b16d84dae2d13f0aab0062c95df2232c7
Resolves: #27689
Reviewed-on: http://review.typo3.org/2921
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Susanne Moog
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] Fix warnings in db backend unit tests
Christian Kuhn [Fri, 24 Jun 2011 22:03:18 +0000 (00:03 +0200)]
[BUGFIX] Fix warnings in db backend unit tests

Change-Id: I2e83a0ec6c81c07b0b051d7074ee2ac928a6beb5
Resolves: #27693
Reviewed-on: http://review.typo3.org/2922
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] Fix warning in file backend unit tests
Steffen Gebert [Fri, 24 Jun 2011 22:05:01 +0000 (00:05 +0200)]
[BUGFIX] Fix warning in file backend unit tests

Change-Id: Ib38f602723826340a5c3afd0a9f79cc9aa1dae66
Resolves: #27692
Reviewed-on: http://review.typo3.org/2923
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[FEATURE] Add random functionality to listNum
Mario Rimann [Mon, 6 Jun 2011 11:20:48 +0000 (13:20 +0200)]
[FEATURE] Add random functionality to listNum

Add the ability to get a random item by setting listNum to "rand".

Change-Id: I55efef8ed714eaa1545f9f179e18260661407de7
Resolves: #16180
Reviewed-on: http://review.typo3.org/2538
Reviewed-by: Georg Ringer
Reviewed-by: Mario Rimann
Reviewed-by: Stefan Neufeind
Tested-by: Georg Ringer
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] Use runtime cache in TCEmain
Christian Kuhn [Fri, 24 Jun 2011 15:34:07 +0000 (17:34 +0200)]
[BUGFIX] Use runtime cache in TCEmain

Change-Id: I675b1998d255ea4b9fda3e7725b9fd9d96a0f1d6
Resolves: #27685
Depends: #27208
Reviewed-on: http://review.typo3.org/2911
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[BUGFIX] Use runtime cache in tslib_fe::get_cache_timeout
Steffen Gebert [Sat, 4 Jun 2011 16:51:56 +0000 (18:51 +0200)]
[BUGFIX] Use runtime cache in tslib_fe::get_cache_timeout

Thanks to #20473, start and stop times of records are now taken into
account during a page's cache lifetime calculation.
To prevent repeated computations, the value is cached inside
tslib_fe::get_cache_timeout(), using a class variable
getCacheTimeoutCache.

The Runtime Cache (#27208) not only offers a cleaner way to do so, it
also provides a remedy against the currently existing problem that
get_cache_timeout() does its job exactly twice: Once during menu
generation (which seems to work with a cloned copy of TSFE) and once
before putting the page contents into the cache. As both class instances
share the runtime cache, the second calculation can be safed.

Change-Id: I0b241749639a678ba6c1addd8d57e2256cf52bc2
Resolves: #27227
Depends: #27208
Reviewed-on: http://review.typo3.org/2531
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[FEATURE] Add a runtime cache
Steffen Gebert [Fri, 24 Jun 2011 15:10:18 +0000 (17:10 +0200)]
[FEATURE] Add a runtime cache

Add a runtime cache (cache_runtime) based on the TransientMemoryBackend
to save and retrieve values, which are required several times during a
single request.

Change-Id: If47420cac6c6bec2f912e6aabcfacf3b93a2cb32
Resolves: #27208
Reviewed-on: http://review.typo3.org/2530
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[BUGFIX] Deprecate initCache* methods in t3lib_cache
Christian Kuhn [Fri, 24 Jun 2011 15:52:20 +0000 (17:52 +0200)]
[BUGFIX] Deprecate initCache* methods in t3lib_cache

They are obsolete since cacheManager->getCache() initializes caches
on its own if needed.

Change-Id: I1684db0405799031beffb29782361061c262a56f
Resolves: #27686
Reviewed-on: http://review.typo3.org/2912
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] Improve deprecation handling of useCachingFramework
Christian Kuhn [Fri, 24 Jun 2011 13:30:00 +0000 (15:30 +0200)]
[BUGFIX] Improve deprecation handling of useCachingFramework

Change-Id: I0578331909143ee646cace697852eb6082a3a19b
Resolves: #27681
Reviewed-on: http://review.typo3.org/2909
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[TASK] Scheduler: Code clean up
Francois Suter [Fri, 24 Jun 2011 16:14:44 +0000 (18:14 +0200)]
[TASK] Scheduler: Code clean up

Clean up code in the Scheduler system extension: phpDoc,
CGLs compliancy, spelling mistakes, type hinting.

Change-Id: I59cb7450fd31f714590b81df33e2986397be2545
Resolves: #27687
Releases: 4.6
Reviewed-on: http://review.typo3.org/2917
Reviewed-by: Francois Suter
Tested-by: Francois Suter
8 years ago[BUGFIX] Use t3lib_cache_frontend_VariableFrontend as fallback frontend
Xavier Perseguers [Fri, 24 Jun 2011 08:39:39 +0000 (10:39 +0200)]
[BUGFIX] Use t3lib_cache_frontend_VariableFrontend as fallback frontend

According to wiki documentation, integrators are told to define both
'frontend' and 'backend' in their caching configuration.

This hardly makes sense as the frontend input format is the responsibility
of the extension developer, not the integrator and should not be forced
to be defined. Instead, it should fallback to the VariableFrontend if not
explicitly set.

Without fallback, t3lib_div::makeInstance() is called with an empty
class name which throws an exception when instantiated using reflection.

Change-Id: Iaf59864d86483e2d0a08b92c54dad579e2f81347
Resolves: #27677
Reviewed-on: http://review.typo3.org/2905
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Susanne Moog
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[FEATURE] Enable caching framework by default
Christian Kuhn [Thu, 23 Jun 2011 22:00:18 +0000 (00:00 +0200)]
[FEATURE] Enable caching framework by default

The caching framework matured and is ready for default use. The patch
defines TYPO3_UseCachingFramework to true, removes old core cache tables
and cleans up current cache usage in the core.

Change-Id: Ib49d8e43f535e9984e8a22ee3a8454392980035b
Resolves: #25106
Reviewed-on: http://review.typo3.org/2902
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[FEATURE] Add task to delete files in recycler folders
Kai Vogel [Mon, 13 Jun 2011 16:31:53 +0000 (18:31 +0200)]
[FEATURE] Add task to delete files in recycler folders

Adds a scheduler task to cleanup old files in _recycler_
directories in fileadmin. Thanks to Guiamo Programming (Yomo Guiamo)
for sponsoring 125 beers during the bug auction on T3BOARD11.

Change-Id: I093550416d2d0f6897c55871c9e4ff3bc628e711
Resolves: #25342
Releases: 4.6
Reviewed-on: http://review.typo3.org/1385
Reviewed-by: Francois Suter
Tested-by: Francois Suter
8 years ago[BUGFIX] Caching framework: Reduce code duplication in db backend
Christian Kuhn [Thu, 23 Jun 2011 20:41:14 +0000 (22:41 +0200)]
[BUGFIX] Caching framework: Reduce code duplication in db backend

Change-Id: I791e7171adedf2737f38adecac52e428ed63da90
Resolves: #27671
Reviewed-on: http://review.typo3.org/2901
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Disabled empty number of days field in table garbage
Kai Vogel [Tue, 21 Jun 2011 21:57:49 +0000 (23:57 +0200)]
[BUGFIX] Disabled empty number of days field in table garbage
collection scheduler task

This patch reactivates the number of days field even if it is
empty if a default number is provided by the selected table.

Change-Id: I58afb4f9c9430802477fd93d8b387497e1dd698b
Resolves: #27632
Reviewed-on: http://review.typo3.org/2868
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Missing parentheses in code break two stdWraps
Markus Klein [Tue, 21 Jun 2011 14:24:51 +0000 (16:24 +0200)]
[BUGFIX] Missing parentheses in code break two stdWraps

Missing parentheses around isset() checks in string concatenation break
functionality.

Change-Id: I2349f8608ab7a1ffc23685c81a394fddce64d427
Resolves: #27409
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/2862
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Stefan Neufeind
Reviewed-by: Christopher
Tested-by: Christopher
Reviewed-by: Tolleiv Nietsch
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] Caching framework db backend: Remove wildcard tag dropping
Christian Kuhn [Sun, 19 Jun 2011 13:38:50 +0000 (15:38 +0200)]
[BUGFIX] Caching framework db backend: Remove wildcard tag dropping

Change-Id: I75fdee1cf996aa21d7c6b71502ade54fd9fa957f
Resolves: #27548
Depends: #27506
Depends: #27536
Depends: #25119
Reviewed-on: http://review.typo3.org/2812
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Stefan Neufeind
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Oliver Klee
Reviewed-by: Björn Pedersen
Tested-by: Björn Pedersen
8 years ago[FEATURE] Caching framework db backend: better db layout
Björn Pedersen [Sun, 19 Jun 2011 13:09:08 +0000 (15:09 +0200)]
[FEATURE] Caching framework db backend: better db layout

Introduce a better indexable database layout that allows
effective use of indices.

Change-Id: Ie97563e1612d64759bcbd2ee4db005a6d5a33812
Resolves: #25119
Depends: #27506
Depends: #27536
Reviewed-on: http://review.typo3.org/1083
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Stefan Neufeind
Reviewed-by: Björn Pedersen
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[TASK] Caching framework db backend: Use own namespace
Christian Kuhn [Sat, 18 Jun 2011 21:00:34 +0000 (23:00 +0200)]
[TASK] Caching framework db backend: Use own namespace

The layout of needed database tables for cache tables is
handled by the caching framework backend internally:
- Extensions using db backend must not define tables in ext_tables.sql anymore
- Updates to table layouts can be handled by the backend itself
- Defining data and tags table in cacheConfigurations is obsolete
- Cache tables start with 'cachingframework_' and are ignored in install tool
- Table handling is fully backwards compatible

Change-Id: Ic522c6ad99752b2f8161c2330e5a764d2f74e58d
Depends: #27506
Resolves: #27536
Related: #25119
Reviewed-on: http://review.typo3.org/2800
Reviewed-by: Stefan Neufeind
Reviewed-by: Björn Pedersen
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Tested-by: Björn Pedersen
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Installer - Wrong value for CGI
Markus Klein [Mon, 23 May 2011 22:59:11 +0000 (00:59 +0200)]
[BUGFIX] Installer - Wrong value for CGI

In "Basic Configuration"->"System Information" the wrong value for
"UNIX/CGI" is displayed, when using fcgid.
The reason is that class.tx_install.php uses an old condition
for determining this.

Thanks to Stephan Grossberndt for discovering this.

Change-Id: I644a50af9cf966d1b8923bb94a8a52a0aba0090d
Resolves: #26913
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/2323
Reviewed-by: Stephan Grossberndt
Tested-by: Stephan Grossberndt
Reviewed-by: Stefan Neufeind
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
8 years ago[FEATURE] Upgrade ExtJS to version 3.4.0
Steffen Gebert [Mon, 13 Jun 2011 14:34:08 +0000 (16:34 +0200)]
[FEATURE] Upgrade ExtJS to version 3.4.0

Change-Id: Ia24cbb72388ad35bdf37b2254c067cec4212630d
Resolves: #27407
Reviewed-on: http://review.typo3.org/2710
Tested-by: Stefan Neufeind
Tested-by: Susanne Moog
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] Caching Framework: Flush all caches in 'clear all caches'
Christian Kuhn [Thu, 16 Jun 2011 22:08:24 +0000 (00:08 +0200)]
[BUGFIX] Caching Framework: Flush all caches in 'clear all caches'

The caching framework Manager method flushCashes() flushs only
instantiated caches. The patch puts the new setCacheConfigurations()
method into use when intializing the caching framework to declare all
available caches to the cache manager. In effect,
typo3_cache_Manager->flushCaches() now calls flush() on all caches,
even if they were not instantiated yet.

Change-Id: I368faf156c5c4898ba62a777d1a5d21edfe4110f
Resolves: #27506
Reviewed-on: http://review.typo3.org/2776
Reviewed-by: Stefan Neufeind
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Tested-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Incompatible call to debug_backtrace() prior to PHP 5.3.5
Oliver Hader [Mon, 20 Jun 2011 11:08:57 +0000 (13:08 +0200)]
[BUGFIX] Incompatible call to debug_backtrace() prior to PHP 5.3.5

The additional parameter to debug_backtrace() was introduced
with PHP 5.3.6. To stay compatible with PHP 5.3.0, it shall be
removed again - besides that the behaviour stays the same.

Change-Id: Icab51963bae4e5f72c14404828cd3c9b9231796f
Resolves: #27348
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/2836
Reviewed-by: Markus Klein
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] FE-Error "NO entry in the $TCA-array..."
Nicole Cordes [Fri, 17 Jun 2011 09:33:56 +0000 (11:33 +0200)]
[BUGFIX] FE-Error "NO entry in the $TCA-array..."

Fix a possible race condition during a FE call if a BE user
'clears all cache' at the same time.

Change-Id: I4fe5e0256093df8190eb6f1a2754edf1e3aba405
Resolves: #22928
Releases: 4.6, 4.5, 4.4, 4.3
Reviewed-on: http://review.typo3.org/2834
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Oliver Klee
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[FEATURE] Add table garbage collection scheduler task
Christian Kuhn [Thu, 31 Mar 2011 21:44:19 +0000 (23:44 +0200)]
[FEATURE] Add table garbage collection scheduler task

This feature was implemented during T3BOARD11 bug auction. It is
kindly sponsored with 100 beers by jweiland.net and is called the
'Schnaps Hans scheduler task'

Change-Id: Id7c58d28e4f6e82a708513a3ce9761baf36c06cd
Resolves: #25343
Releases: 4.6
Reviewed-on: http://review.typo3.org/1376
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Cache toolbar items have incorrect width
Andreas Wolf [Thu, 9 Jun 2011 07:19:17 +0000 (09:19 +0200)]
[BUGFIX] Cache toolbar items have incorrect width

The items in the clear cache toolbar do not span the full width of the
menu. This is because a float:left; that was inserted for the top-level
items of the toolbar also affects these items.

Change-Id: Ic17fc2b00aeba3e150630da6895a18e38b02987a
Releases: 4.6
Resolves: #27323
Reviewed-on: http://review.typo3.org/2593
Reviewed-by: Markus Klein
Reviewed-by: Philipp Gampe
Reviewed-by: Mario Rimann
Tested-by: Mario Rimann
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[FEATURE] Make t3lib_BEfunc::calcAge() support singular/plural
Stefan Neufeind [Fri, 17 Jun 2011 18:34:25 +0000 (20:34 +0200)]
[FEATURE] Make t3lib_BEfunc::calcAge() support singular/plural

This was already supported in tslib_content::calcAge() and is now in
sync with this patch.

Change-Id: Id07a1a4ca1e598c35aff2842a1ae3012adab7cba
Resolves: #21601
Reviewed-on: http://review.typo3.org/2787
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[TASK] Cleanup unnecessary calls to reset() or current()
Stefan Neufeind [Fri, 17 Jun 2011 22:36:55 +0000 (00:36 +0200)]
[TASK] Cleanup unnecessary calls to reset() or current()

Change-Id: I055760fdd1960dbfa8b574523c8b88ea84f619f8
Resolves: #27530
Reviewed-on: http://review.typo3.org/2792
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn