Packages/TYPO3.CMS.git
9 months ago[TASK] ext_emconf.php, composer.json: Allow PHP 7.2 20/54920/2
Christian Kuhn [Sun, 3 Dec 2017 16:40:33 +0000 (17:40 +0100)]
[TASK] ext_emconf.php, composer.json: Allow PHP 7.2

Core v8 contains php restrictions in ext_emconf.php and
extensions composer.json files. Raise them to allow PHP 7.2

Change-Id: I01d36f8779aa5234eac3c72d1efe71b6603d1fd6
Resolves: #83206
Related: #82226
Releases: 8.7
Reviewed-on: https://review.typo3.org/54920
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
9 months ago[TASK] Raise testing-framework to 1.2.2 17/54917/2
Christian Kuhn [Sun, 3 Dec 2017 15:03:45 +0000 (16:03 +0100)]
[TASK] Raise testing-framework to 1.2.2

Contains a bug fix for PHP 7.2 compatible mocking in
ViewHelperBaseTestcase.

Change-Id: I35e71e7a9d77157b1ce81f0889d476c66ccddfd8
Resolves: #83204
Related: #82226
Related: #83203
Releases: 8.7
Reviewed-on: https://review.typo3.org/54917
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
9 months ago[BUGFIX] Use of undefined constant E_DEBUG 13/54913/2
Christian Kuhn [Sun, 3 Dec 2017 14:05:53 +0000 (15:05 +0100)]
[BUGFIX] Use of undefined constant E_DEBUG

Global function debug() initializes its 6th argument
to constant E_DEBUG which does not exist and then defaults
to string 'E_DEBUG'. This raises a PHP 7.2 warning.
Relevant for v8 & v7 only, this argument has been removed
in master already.
Fix by defaulting to string 'E_DEBUG' in method signature.

Change-Id: If04c9e55bb810980b19b924496680ea1758e4b24
Resolves: #83200
Related: #82640
Releases: 8.7, 7.6
Reviewed-on: https://review.typo3.org/54913
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
9 months ago[BUGFIX] Incomplete mock in AbstractViewHelperTest 14/54914/2
Christian Kuhn [Sun, 3 Dec 2017 14:13:29 +0000 (15:13 +0100)]
[BUGFIX] Incomplete mock in AbstractViewHelperTest

Extbase ReflectionService->getMethodParameters() must return
an array, the result is later count()'ed. Properly return an
empty array in one test case.

Change-Id: I8222a3c3d63f2179131fe8cb23499b172b310afd
Resolves: #83201
Releases: 8.7
Reviewed-on: https://review.typo3.org/54914
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
9 months ago[BUGFIX] PreparedStatement: count() must be an array or countable 11/54911/2
Christian Kuhn [Sun, 3 Dec 2017 12:09:08 +0000 (13:09 +0100)]
[BUGFIX] PreparedStatement: count() must be an array or countable

Sanitize a count() call in PreparedStatement (8.7, 7.6 only)
for PHP 7.2 compatibility.

Change-Id: I8d3cac3814093c7223c6be8f8ab8dc8c610d28e1
Resolves: #83196
Releases: 8.7, 7.6
Reviewed-on: https://review.typo3.org/54911
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] ContentObjectRendereTest: Undefined constant NL 08/54908/2
Christian Kuhn [Sat, 2 Dec 2017 23:40:52 +0000 (00:40 +0100)]
[BUGFIX] ContentObjectRendereTest: Undefined constant NL

A data provider uses the not defined constant "NL". PHP 7.2
throws warnings on this. Warnings from data providers do not
lead to failing tests, still this is ugly and pollutes test
runs with warnings in the head part.

Change-Id: I3b09ce51d675cf3097967c074511eaf0a53cf8f9
Resolves: #83194
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54908
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
9 months ago[BUGFIX] Implicit constant to string cast in unit test case 04/54904/2
Christian Kuhn [Sat, 2 Dec 2017 01:24:18 +0000 (02:24 +0100)]
[BUGFIX] Implicit constant to string cast in unit test case

An array key is not used as string but as constant in
two ConfigurationManager test cases. PHP 7.2 is more
picky about this an throws warnings. Fix by creating
proper strings.

Change-Id: I64def6cf9b5d9df7e150d137929c721558c761d7
Resolves: #83190
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/54904
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
9 months ago[TASK] Re-add autolinking RTE feature in CKeditor 79/54879/2
Benni Mack [Fri, 10 Nov 2017 09:45:55 +0000 (10:45 +0100)]
[TASK] Re-add autolinking RTE feature in CKeditor

A missing functionality is added, which happened when introducing CKeditor.

Automatically linking a URL when typing www.typo3.org should happen directly.

A specific plugin is used for that. Base concept was taken from
https://github.com/Gnodiah/ckeditor-autolink

Resolves: #80977
Releases: master, 8.7
Change-Id: I575b63eeb696166b5e3b06047106e26cb68eb7b4
Reviewed-on: https://review.typo3.org/54879
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] Fix injured workspace encapsulation in record localize summary. 90/54890/3
Gleb Levitin [Sun, 4 Dec 2016 09:20:42 +0000 (10:20 +0100)]
[BUGFIX] Fix injured workspace encapsulation in record localize summary.

This patch resolves problem with the injured workspace encapsulation
for removed records while fetching the record localize summary in page
module within a workspace.

Resolves: #78841
Releases: master, 8.7
Change-Id: I734a32c7b52ed4a2a3ab49c63d45df46472a99a4
Reviewed-on: https://review.typo3.org/54890
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
9 months ago[BUGFIX] Make quoting of SQL fragments in TCA possible 89/54889/2
Stephan Großberndt [Fri, 30 Jun 2017 06:35:50 +0000 (08:35 +0200)]
[BUGFIX] Make quoting of SQL fragments in TCA possible

The table and column name quoting method {#tableName}.{#columnName}
introduced for TypoScript in issue #80506 is now used to quote
identifiers in TCA column definitions known to possibly contain SQL
fragments. Missing quotes for identifiers containing e.g. uppercase
letters lead to exceptions when performing a query in PostgreSQL.

In order to achieve this a new Class TcaPreparation is added as this is
not a typical TcaMigration.

Releases: master, 8.7
Resolves: #81751
Related: #80506
Change-Id: I230be317c7088e5de5343634fac507b4ab994b28
(cherry picked from commit 91aa14884b6526dc664b6472baa27e9d802b09fc)
Reviewed-on: https://review.typo3.org/54889
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
9 months ago[BUGFIX] Fix language of placeholder for relations 88/54888/2
Nicole Cordes [Wed, 22 Nov 2017 11:28:37 +0000 (12:28 +0100)]
[BUGFIX] Fix language of placeholder for relations

When a parent record (e.g. tt_content) has inline relations
(e.g. sys_file_reference)and these relations show a placeholder
for records related to them (e.g. sys_file and sys_file_metadata)
then we need to pass the context of the language so that
the placeholders are shown in the correct language.

We now do so by putting the value of the language field
of the parent record into the data set and update it
in case child records are also translatable.

This way when going down the list of children, we always
know the language id of the last applicable parent element,
even if one element in between was not translatable (e.g. sys_file)

If we know the language, we can pick the correct record uid
out of the list of possible related uids, instead of
just picking the first one.

Furthermore the language field for sys_file_metadata is removed from
editor form as the language is set by GET parameter already.

Change-Id: I64c97c8080196599e85b95e09e7eb89701670fa4
Resolves: #75040
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54831
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-on: https://review.typo3.org/54888

9 months ago[FOLLOWUP][BUGFIX] Preview information should not conflict with frontend layout 82/54882/2
Markus Klein [Thu, 30 Nov 2017 09:29:48 +0000 (10:29 +0100)]
[FOLLOWUP][BUGFIX] Preview information should not conflict with frontend layout

Switch order of arguments to implode().

Resolves: #83158
Releases: master, 8.7
Change-Id: I15ff9827418e9d24fefae5f3fa8852a37f5363d0
Reviewed-on: https://review.typo3.org/54881
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
(cherry picked from commit e32bfd6705128117fa7cf775dedc7c7749cbe249)
Reviewed-on: https://review.typo3.org/54882

9 months ago[BUGFIX] Handle docroot relative paths correctly in ResourceCompressor 80/54880/2
Markus Klein [Thu, 26 Oct 2017 22:30:15 +0000 (00:30 +0200)]
[BUGFIX] Handle docroot relative paths correctly in ResourceCompressor

Resolves: #82863
Releases: master, 8.7
Change-Id: Iaf775d83c526017ff882d21c8f6d7c5c1f78a038
Reviewed-on: https://review.typo3.org/54880
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months ago[BUGFIX] Return null value instead of string 'NULL' 77/54877/2
Gernot Leitgab [Fri, 2 Sep 2016 18:59:26 +0000 (20:59 +0200)]
[BUGFIX] Return null value instead of string 'NULL'

Add local getPlainValue method in persistence backend, so a
null value instead of string 'NULL' is written to database.

Resolves: #68994
Related: #57255
Releases: master, 8.7
Change-Id: Idb61caabf5115da4bb818d2ed8bb4faa16f5df2c
Reviewed-on: https://review.typo3.org/54877
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months ago[BUGFIX] Properly handle flexform related exceptions 75/54875/2
Alexander Schnitzler [Thu, 29 Dec 2016 14:24:15 +0000 (15:24 +0100)]
[BUGFIX] Properly handle flexform related exceptions

The FlexFormTools class tries to resolve the datastructure
of flex fields by the given TCA configuration. The flexform
definition can either be set directly in the TCA or it is
fetched from another record.

Example:
TemplaVoilà fetches the data structure from the table
tx_templavoila_datastructure.

When trying to resolve the data structure from another
table and the identifier is invalid (e.g. empty or does
not point to a valid record), several exceptions are
thrown that need to be caught at several points to keep
the user interface accessible.

Other than these mentioned exceptions there are ones
that indicate that the TCA configuration is simply wrong.
These ones are not caught and will still bubble up.

Releases: master, 8.7
Fixes: #79101
Change-Id: I9be921e1425076897a86ebb0b997a998fda7f373
Reviewed-on: https://review.typo3.org/54875
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
9 months ago[BUGFIX] Clarify description of FE|sessionDataLifetime 74/54874/2
Markus Klein [Wed, 29 Nov 2017 17:39:18 +0000 (18:39 +0100)]
[BUGFIX] Clarify description of FE|sessionDataLifetime

The FE|sessionDataLifetime option is solely used for anonymous
frontend sessions. It does not influence any other session(-data).
Document this clearly.

Resolves: #83168
Releases: master, 8.7
Change-Id: I8b16bc73c6d79b5bc6015b4448c6ec4604bdd780
Reviewed-on: https://review.typo3.org/54874
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months ago[BUGFIX] Apply correct button styles on EDITPANEL for pages 68/54868/2
Benjamin Kott [Wed, 29 Nov 2017 11:50:48 +0000 (12:50 +0100)]
[BUGFIX] Apply correct button styles on EDITPANEL for pages

Resolves: #83162
Releases: master, 8.7
Change-Id: I76bc60d9ac94eb1fe510bfe324cf49c0ed3bf896
Reviewed-on: https://review.typo3.org/54868
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
9 months ago[TASK] Use $pathsToProvideInTestInstance in functional import tests 67/54867/2
Oliver Hader [Wed, 29 Nov 2017 12:58:11 +0000 (13:58 +0100)]
[TASK] Use $pathsToProvideInTestInstance in functional import tests

$pathsToProvideInTestInstance offers the possibility to use real
duplicates instead of linked resources in the filesystem - especially
in scenarios when files shall be modified inside a testing instance this
is the better approach and avoid side-effects during test execution.

Resolves: #83163
Releases: master, 8.7
Change-Id: I5e5825d2f999401533afffdf9c6e8d83ac55c94e
Reviewed-on: https://review.typo3.org/54867
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
9 months ago[BUGFIX] Ignore translations from other workspaces 66/54866/2
Markus Goldbach [Mon, 26 Jun 2017 11:42:17 +0000 (13:42 +0200)]
[BUGFIX] Ignore translations from other workspaces

Ignore translations of content elements (tt_content) which are created in
other workspace, so it is able to create a new/other translation in
another workspace even inside the live workspace

Change-Id: Ifef673b8677ae81f238068ed3a0bfdd1ca8e7932
Resolves: #81691
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54866
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
9 months ago[BUGFIX] Determine Chinese simplified Han "Accept-Language" header 65/54865/2
DavidsWONG [Thu, 29 Dec 2016 09:02:30 +0000 (10:02 +0100)]
[BUGFIX] Determine Chinese simplified Han "Accept-Language" header

Internet Explorer (IE11 & Edge) changed the submitted HTTP header
for "Accept-Language" from "zh-cn" to "zh-hans-cn". In order to
determine the Chinese language correctly, this value is added.

Releases: master, 8.7
Resolves: #81858
Change-Id: I477f88950313aa9bf0aeabbf6603bd15247a52ba
Reviewed-on: https://review.typo3.org/54865
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
9 months ago[BUGFIX] Ensure all sys_file_metadata TCA columns have a config section 63/54863/2
Benni Mack [Wed, 29 Nov 2017 09:22:17 +0000 (10:22 +0100)]
[BUGFIX] Ensure all sys_file_metadata TCA columns have a config section

The main issue is that the core ships a TCA column without a config section.

If EXT:filemetadata is available, this is overridden, so no issue here.

Further steps are (not scope of this patch) would be a TCA migration checker
to ensure that all TCA columns have a config section.

Resolves: #73076
Related: #77619
Related: #83152
Releases: master, 8.7
Change-Id: I3454780f1122ee5f4ef2bd65b19a9699daa73f33
Reviewed-on: https://review.typo3.org/54863
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
9 months ago[BUGFIX] Preview information should not conflict with frontend layout 61/54861/2
Benjamin Kott [Wed, 29 Nov 2017 12:25:48 +0000 (13:25 +0100)]
[BUGFIX] Preview information should not conflict with frontend layout

The preview information badge was reworked and now has a fixed
always visible position. Clicks on the preview badge are now prevended
and passed through to the underlaying/covered elements.

Resolves: #83158
Releases: master, 8.7
Change-Id: Idb15547b1ca81e80a1b121a8aeadc832b379d628
Reviewed-on: https://review.typo3.org/54861
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
9 months ago[BUGFIX] Prevent catchable error during workspace publishing 54/54854/3
Benni Mack [Wed, 29 Nov 2017 09:50:58 +0000 (10:50 +0100)]
[BUGFIX] Prevent catchable error during workspace publishing

When publishing a workspace, incorrect TCA might lead to a catchable
fatal error. This happened, when TCA for a field did not contain a
config-entry.

Resolves: #77619
Releases: master, 8.7, 7.6
Change-Id: I81a3b727320ee984908c964d0729551c4c264f8d
Reviewed-on: https://review.typo3.org/54854
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months ago[TASK] Log warning on invalid charset 03/54503/5
Stefan Neufeind [Mon, 30 Oct 2017 16:20:39 +0000 (17:20 +0100)]
[TASK] Log warning on invalid charset

This gives users a clear hint if e.g. config.metaCharset contains
an invalid value instead of showing a blank page.

Change-Id: I9cdb37cc7e61af10e2d1985ef43f488e53b17a48
Resolves: #82852
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54503
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Pawel Cieslik <p.cieslik@macopedia.pl>
Reviewed-by: Pawel Cieslik <p.cieslik@macopedia.pl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
9 months ago[TASK] Add missing delete button for Documentation 45/54845/2
Łukasz Uznański [Tue, 28 Nov 2017 09:22:28 +0000 (10:22 +0100)]
[TASK] Add missing delete button for Documentation

Add a  missing delete button within the Documentation module. Right now,
a user can't delete previously downloaded documentation.

Resolves: #80575
Releases: master, 8.7
Change-Id: I9077270c66ec225f1eb7a26e505da0d98d5f7f0e
Reviewed-on: https://review.typo3.org/54845
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
9 months ago[BUGFIX] Disable column sys_file_reference.sorting 40/54840/2
Stephan Großberndt [Mon, 9 Oct 2017 16:48:39 +0000 (18:48 +0200)]
[BUGFIX] Disable column sys_file_reference.sorting

Disable the column sys_file_reference.sorting by its according TCA
definition as it is not useful and leads to severe performance issues
adding new references when there are already many references.

Releases: master, 8.7
Resolves: #80800
Change-Id: I7b34a1be7efe3cf4818b43919389d9c815e74ec6
Reviewed-on: https://review.typo3.org/54840
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
9 months ago[BUGFIX] Also show port when trustedHosts pattern mismatches 34/54834/3
Oliver Thiele [Tue, 28 Nov 2017 09:34:17 +0000 (10:34 +0100)]
[BUGFIX] Also show port when trustedHosts pattern mismatches

Add the port information to the error message when the
trustedHostsPattern mismatches. This is important as
the SERVER_NAME may match, but the SERVER_PORT might be
different from the default ports.

Releases: master, 8.7
Resolves: #83133
Change-Id: I8a25cc0bd2c9578b611986cea4bb7f270dff927b
Reviewed-on: https://review.typo3.org/54834
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months ago[TASK] Install Tool: Display a warning if PHP fileinfo extension is not loaded 33/54833/3
Jonathan IROULIN [Tue, 28 Nov 2017 10:18:25 +0000 (11:18 +0100)]
[TASK] Install Tool: Display a warning if PHP fileinfo extension is not loaded

Show a warning message during the installation process if
the PHP fileinfo extension is not loaded.
It only displays a warning because the fileinfo extension is just
a suggestions and not required.
The fileinfo extension is useful to extract file metadata.

Resolves: #78702
Releases: master, 8.7
Change-Id: Iea0fa087d96d5615056308b7b2fef082b9154a2d
Reviewed-on: https://review.typo3.org/54833
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months ago[BUGFIX] Check simplexml return type in ImageInfo 28/54828/5
Tim Spiekerkötter [Fri, 17 Feb 2017 10:05:13 +0000 (11:05 +0100)]
[BUGFIX] Check simplexml return type in ImageInfo

According to the php documentation[1] simplexml_load_file may return
false on failure. We need to check for this before we call the
attributes method on the expected SimpleXMLElement.

[1] http://php.net/manual/en/function.simplexml-load-file.php

Resolves: #79881
Releases: master, 8.7
Change-Id: Ic84710ab56796e9aafc5a85c8e41d7b08a676e0c
Reviewed-on: https://review.typo3.org/54828
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months ago[BUGFIX] Set correct HTTP header when page access is denied 14/54814/5
Markus Klein [Sun, 29 Oct 2017 17:37:52 +0000 (18:37 +0100)]
[BUGFIX] Set correct HTTP header when page access is denied

Accessing an existing page with insufficient permissions should
not set a 404 header but a 403 header.

Resolves: #23178
Releases: master, 8.7
Change-Id: I2470434f7600b28eaa613ee4e1669e78ceaaaec3
Reviewed-on: https://review.typo3.org/54814
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months ago[BUGFIX] Disable edit of file metadata without translation 22/54822/2
Łukasz Uznański [Mon, 27 Nov 2017 10:15:00 +0000 (11:15 +0100)]
[BUGFIX] Disable edit of file metadata without translation

This avoids an error in case file metadata is edited through a file
reference and there is no file metadata translation for the current
language.

Resolves: #76262
Resolves: #82178
Releases: master, 8.7
Change-Id: Ifecf659637773c5f3773fc3439b09df9c030cb3f
Reviewed-on: https://review.typo3.org/54822
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
9 months ago[CLEANUP] Move rst changelog docs into correct folder 15/54815/4
Markus Klein [Tue, 28 Nov 2017 08:56:05 +0000 (09:56 +0100)]
[CLEANUP] Move rst changelog docs into correct folder

Resolves: #83130
Releases: master, 8.7
Change-Id: I9b552fcdda64a5a1a9a8c1d1e06d20d0ed43cad0
Reviewed-on: https://review.typo3.org/54815
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
9 months ago[BUGFIX] Use correct language file in element information popup 13/54813/2
Georg Ringer [Tue, 28 Nov 2017 06:59:17 +0000 (07:59 +0100)]
[BUGFIX] Use correct language file in element information popup

Use the correct language file which changed by accident during
the fluid transformation.

Resolves: #83126
Releases: master, 8.7
Change-Id: I9da27976ac3c72a5c1161adf605d10fbf422bf6e
Reviewed-on: https://review.typo3.org/54813
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
9 months ago[BUGFIX] Make category tree filterable for editors with category mounts 25/54725/3
Christoph Lehmann [Wed, 13 Sep 2017 21:34:45 +0000 (23:34 +0200)]
[BUGFIX] Make category tree filterable for editors with category mounts

TCEFORM.pages.categories.config.treeConfig.rootUid should filter
the category tree. Non-Admin users with category mounts currently
need every child category of rootUid in their category mounts
since the rootline of rootUid is not checked against the category
mounts.

Resolves: #78274
Releases: master, 8.7
Change-Id: Id02ae69111df7397207939a034ed05797eb160ad
Reviewed-on: https://review.typo3.org/54725
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
9 months ago[BUGFIX] Validate page error handler result to report wrong configuration 08/54808/2
Markus Klein [Sun, 29 Oct 2017 17:05:15 +0000 (18:05 +0100)]
[BUGFIX] Validate page error handler result to report wrong configuration

Resolves: #50186
Releases: master, 8.7
Change-Id: I082a2d48608d43856cd60076852a19aec8a21a7e
Reviewed-on: https://review.typo3.org/54808
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
9 months ago[BUGFIX] IRRE actions should render error messages from DataHandler 09/54809/2
Benni Mack [Thu, 16 Nov 2017 11:05:03 +0000 (12:05 +0100)]
[BUGFIX] IRRE actions should render error messages from DataHandler

When IRRE actions (localize/synchronize) are triggered that result in a
DataHandler error (e.g. "Localization failed, "languageField" and
"transOrigPointerField" must be defined for the table") because of a missing
configuration, the current implementation does not evaluate DataHandler
results in the JSON response.

The change adds the same functionality as for other DataHandler calls
to evaluate the JSON response.

Resolves: #83011
Releases: master, 8.7
Change-Id: I7a2069b78cd9c3fa031b7ac194ae5b18596b6a3e
Reviewed-on: https://review.typo3.org/54809
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
9 months ago[BUGFIX] Catch Exception while extracting metadata 08/54708/2
rickymk [Tue, 29 Aug 2017 11:18:10 +0000 (16:48 +0530)]
[BUGFIX] Catch Exception while extracting metadata

Catch InsufficientFileAccessPermissionsException while extracting
metadata. Reason for this exception could be that the file extension is
not allowed by the ['BE']['fileDenyPattern'] setting.

This patch makes sure that the indexer doesn't break and is able to
extract the other files from storage.

Resolves: #82060
Release: master, 8.7, 7.6
Change-Id: I37950aa70f4f59b388c6b9203e1922708ad07b71
Reviewed-on: https://review.typo3.org/54708
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
9 months ago[BUGFIX] Don't show “cut” and “cut release” at the same time 33/54733/3
Frank Naegler [Thu, 23 Nov 2017 16:13:35 +0000 (17:13 +0100)]
[BUGFIX] Don't show “cut” and “cut release” at the same time

This patchs prevents showing “cut” and “cut release” at the same time in
the clickmenu of the page tree.

Resolves: #81890
Releases: master, 8.7
Change-Id: Ibfc07efec0f2064ffc9885047fce246cd935d368
Reviewed-on: https://review.typo3.org/54733
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
9 months ago[TASK] Visual tweak of "SelectMultipleSideBySideElement" 07/54807/3
Gianluigi Martino [Mon, 20 Nov 2017 12:47:43 +0000 (13:47 +0100)]
[TASK] Visual tweak of "SelectMultipleSideBySideElement"

The position of the buttons aside the wizard are not correct.

Releases: master, 8.7
Resolves: #83072

Change-Id: Ib60a4015b6a51997ee56381ec63fea79605b16c1
Reviewed-on: https://review.typo3.org/54807
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
9 months ago[BUGFIX] Correctly resolve dots inside flexform field names 06/54806/2
Christian Weiske [Tue, 10 Jan 2017 13:23:34 +0000 (14:23 +0100)]
[BUGFIX] Correctly resolve dots inside flexform field names

When a flexform field index attribute contained a dot, only
the last value was kept.
We now correctly append the new values to the existing ones now.

Change-Id: I73e541e834c143c33ba34f7e3f3ea7a22726b074
Resolves: #79245
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54806
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
9 months ago[BUGFIX] Prepared statement contains too many placeholders 05/54805/2
Pawel Cieslik [Mon, 27 Nov 2017 19:06:31 +0000 (20:06 +0100)]
[BUGFIX] Prepared statement contains too many placeholders

Fix method findInStorageAndNotInUidList where $uidList
contains more then 65536 records in MySQL, 64000 in Oracle,
34464 in PostgreSQL by avoiding using prepared statements
and just passing values directly in query.

Resolves: #82233
Releases: master, 8.7
Change-Id: Ic72fa540936631274ae542d3c02128e159bd3fb1
Reviewed-on: https://review.typo3.org/54805
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months ago[BUGFIX] Add missing initialization of GraphicalFunctions 71/54771/2
Joschi Kuphal [Wed, 22 Nov 2017 09:53:06 +0000 (10:53 +0100)]
[BUGFIX] Add missing initialization of GraphicalFunctions

Add missing initialization of the GraphicalFunctions helper
during image processing.

Resolves: #83058
Releases: master, 8.7
Change-Id: Ic5552c573f866faf3dcb0e0bc11012d83c805033
Reviewed-on: https://review.typo3.org/54771
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
9 months ago[BUGFIX] Colorpicker in irre records 97/54797/2
Frank Naegler [Thu, 23 Nov 2017 16:04:16 +0000 (17:04 +0100)]
[BUGFIX] Colorpicker in irre records

This patch checks if a value is set before writing
a possbile empty value to the field.

Resolves: #83000
Releases: master, 8.7
Change-Id: I3badd9b9ff1a567351d971b5ae0199bf347e0f72
Reviewed-on: https://review.typo3.org/54797
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
9 months ago[BUGFIX] Fix editing a FileStorage from FileTree on PostgreSQL 85/54785/2
Stephan Großberndt [Wed, 18 Oct 2017 14:01:26 +0000 (16:01 +0200)]
[BUGFIX] Fix editing a FileStorage from FileTree on PostgreSQL

Avoid a SQL error on PostgreSQL when editing a FileStorage from FileTree
by passing the UID instead of a combined identifier like '1:/' to
EditDocumentController. Additionally fix the possibility for an SQL
error in BackendUtility::getRecord() by casting the UID.

Releases: master, 8.7
Resolves: #82799
Change-Id: I5cfde8b53767da1166ebd5f778e36ca85825a173
Reviewed-on: https://review.typo3.org/54785
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
9 months ago[BUGFIX] Send correct Cache-Control header if no client side caching 93/54793/2
Łukasz Uznański [Mon, 27 Nov 2017 12:20:45 +0000 (13:20 +0100)]
[BUGFIX] Send correct Cache-Control header if no client side caching

Add 'Cache-Control: no-store' if conditions allowing client caching
are not met. This change will prevent caching content by browser.

Resolves: #81160
Releases: master, 8.7, 7.6
Change-Id: Ia91a339178b8cd8387706679bbea40ed0d1b0548
Reviewed-on: https://review.typo3.org/54793
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months ago[BUGFIX] fix missing l18n fields in blog tag table 92/54792/2
Sebastian Hofer [Mon, 27 Nov 2017 11:47:11 +0000 (12:47 +0100)]
[BUGFIX] fix missing l18n fields in blog tag table

The field l18n_parent was missing in table
tx_blogexample_domain_model_tag, but configured in TCA.
This causes an exception with adding a new tag in BE.
Also the field l18n_diffsource was missing in TCA and database.

* Add the fields l18n_parent and l18_diffsource to
  the databse table tx_blogexample_domain_model_tag
* Add TCA configuration for field l18n_diffsource to
  tx_blogexample_domain_model_tag TCA

Also add missing icon and label for
tx_blogexample_domain_model_dateexample.

Remove "allow tables on standard pages". This is not
necessary.

Fixes: #83113
Releases: master, 8.7
Change-Id: I10f809cc4b00df07c6e5a064bb89018578f3abf3
Reviewed-on: https://review.typo3.org/54792
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months ago[TASK] Use proper PHPdoc type annotations in Extbase error layer 87/54787/2
Oliver Hader [Mon, 27 Nov 2017 10:58:17 +0000 (11:58 +0100)]
[TASK] Use proper PHPdoc type annotations in Extbase error layer

Resolves: #83111
Releases: master, 8.7
Change-Id: Ifde44802b9cf120f1a6ba3490022ccda1458e00d
Reviewed-on: https://review.typo3.org/54787
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
9 months ago[TASK] Ensure introduction package is properly installed 83/54783/2
Andreas Fernandez [Fri, 8 Sep 2017 18:59:28 +0000 (20:59 +0200)]
[TASK] Ensure introduction package is properly installed

Resolves: #83108
Releases: master, 8.7
Change-Id: I72d30fdab6ea3cc72078d5cf50b38915ff388fa2
Reviewed-on: https://review.typo3.org/54783
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
9 months ago[CLEANUP] Alwas put null at the last position 81/54781/5
Alexander Schnitzler [Mon, 27 Nov 2017 10:25:34 +0000 (11:25 +0100)]
[CLEANUP] Alwas put null at the last position

This patch applies the phpdoc_types_order rule of the
php-cs-fixer. See http://cs.sensiolabs.org/ -> phpdoc_types_order

Releases: master, 8.7
Resolves: #83109
Change-Id: I57291fb0b113ad01e2a171c1cfd6a9943d6302ad
Reviewed-on: https://review.typo3.org/54781
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
9 months ago[BUGFIX] bamboo: Label parsing 76/54776/2
Christian Kuhn [Mon, 27 Nov 2017 09:23:05 +0000 (10:23 +0100)]
[BUGFIX] bamboo: Label parsing

The bamboo test setup relies on a funny solution to determine the
gerrit patch id and patch set, used for reporting results back
to gerrit.

The regex based solution started behaving weird with latest
bamboo versions and is now quoted slightly differently to fix that.

Special thanks to atlassian support for being friendly, helpful,
quick and providing a working solution to our issue.

Change-Id: I51ec85be2133033777fac8ff1f12071a81c71efc
Resolves: #83107
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/54776
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
9 months ago[CLEANUP] The correct case must be used for standard PHP types in phpdoc 75/54775/5
Alexander Schnitzler [Mon, 27 Nov 2017 08:10:31 +0000 (09:10 +0100)]
[CLEANUP] The correct case must be used for standard PHP types in phpdoc

This patch applies the phpdoc_types rule of the
php-cs-fixer. See http://cs.sensiolabs.org/ -> phpdoc_types

Releases: master, 8.7
Resolves: #83106
Change-Id: I958b75d85a08169a987afe9eed0baa4d86139770
Reviewed-on: https://review.typo3.org/54775
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
9 months ago[FEATURE] Introduce Yarn and fix dependency handling and downgrade some libs 49/54749/3
Benjamin Kott [Fri, 24 Nov 2017 18:44:17 +0000 (19:44 +0100)]
[FEATURE] Introduce Yarn and fix dependency handling and downgrade some libs

Because of the broken dependency manager logic in NPM this patch introduce
yarn as dependency manager for node modules.
Also this patch downgrade some libs, which was updated accidentally in past.

To install node modules you have to install yarn first and call
`yarn install`, do not use `yarn update` until you really want
update a dependency.

Resolves: #83038
Releases: master, 8.7
Change-Id: I842636241d76b88f2b9e3836230fdb6629d22fc3
Reviewed-on: https://review.typo3.org/54749
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
9 months ago[FOLLOWUP][BUGFIX] Fix some PHP Notices thrown rendering page module 45/54745/3
Jan Helke [Fri, 24 Nov 2017 09:50:40 +0000 (10:50 +0100)]
[FOLLOWUP][BUGFIX] Fix some PHP Notices thrown rendering page module

Refer to the correct LanguageService.
The referenced class is not present in TYPO3 version 8.

Related: #82921
Releases: 8.7
Change-Id: Id68086149170d73e3251beba3653344660f4c55c
Reviewed-on: https://review.typo3.org/54745
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
9 months ago[TASK] Show allowed media sources in "Add media by URL" modal 22/54522/2
Gianluigi Martino [Wed, 18 Oct 2017 15:16:52 +0000 (17:16 +0200)]
[TASK] Show allowed media sources in "Add media by URL" modal

In the modal view of "Add media by URL" the possible sources from where
media can be embedded are now shown.

Resolves: #82545
Releases: master, 8.7
Change-Id: I07ffedcf074b6af1e03113375f3d110916e3b034
Reviewed-on: https://review.typo3.org/54522
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
9 months ago[BUGFIX] Fix some PHP Notices thrown when rendering page module 58/54658/3
Tymoteusz Motylewski [Mon, 6 Nov 2017 08:12:26 +0000 (09:12 +0100)]
[BUGFIX] Fix some PHP Notices thrown when rendering page module

Resolves: #82921
Releases: master, 8.7
Change-Id: Id26239e65321aa3653de849932a0be7e626bd653
Reviewed-on: https://review.typo3.org/54658
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
10 months ago[BUGFIX] Fix broken back button in EXT:form 27/54727/2
Frank Naegler [Tue, 21 Nov 2017 13:04:27 +0000 (14:04 +0100)]
[BUGFIX] Fix broken back button in EXT:form

This patch fix a regression, introduced with #82668

Resolves: #83057
Related: #82668
Releases: master, 8.7
Change-Id: I421be116be6696c52733a77a94a61f81c84864f4
Reviewed-on: https://review.typo3.org/54727
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
10 months ago[BUGFIX] Use correct runtime cache identifier for locked records 29/54729/2
Benni Mack [Wed, 22 Nov 2017 22:44:52 +0000 (23:44 +0100)]
[BUGFIX] Use correct runtime cache identifier for locked records

The runtime cache was re-built wrong by using
a custom identifer, thus being called EVERY time a
record is checked. This puts the pagetree DB queries in half.

A simple check (like done previously with $GLOBALS['LOCKED_RECORDS'])
to a simple identifier solves this issue.

Related: #79345
Resolves: #83068
Releases: master, 8.7
Change-Id: Id422fbc81b145db3559c194774334692863b4699
Reviewed-on: https://review.typo3.org/54729
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
10 months ago[BUGFIX] Page tree nodes can be (un)mounted again 23/54723/4
Andreas Fernandez [Mon, 20 Nov 2017 18:55:06 +0000 (19:55 +0100)]
[BUGFIX] Page tree nodes can be (un)mounted again

(Un)mounting nodes in the page tree is now possible again by fixing calls
to the page tree objects.

Resolves: #83051
Releases: master, 8.7
Change-Id: I978308e301b712fa75d677337d790e4895dc997a
Reviewed-on: https://review.typo3.org/54723
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
10 months ago[BUGFIX] backend formfields: Make boolean fields UI working in Edge/IE 20/54720/2
Stefan Neufeind [Tue, 21 Nov 2017 12:05:42 +0000 (13:05 +0100)]
[BUGFIX] backend formfields: Make boolean fields UI working in Edge/IE

Add for/id so clicking the label toggles the checkbox.

Resolves: #83040
Releases: master, 8.7, 7.6
Change-Id: I3dc08706556e1a95ddc8d96cae705ee968c48326
Reviewed-on: https://review.typo3.org/54720
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
10 months ago[BUGFIX] Fix thrown \InvalidArgumentException in access module 18/54718/2
Andreas Fernandez [Tue, 21 Nov 2017 07:10:55 +0000 (08:10 +0100)]
[BUGFIX] Fix thrown \InvalidArgumentException in access module

The returnUrl is not available if the access module is accessed via
context menu of the page tree. The module now checks whether the
returnUrl is available and renders the close button only in such case.

Resolves: #83053
Releases: master, 8.7
Change-Id: I37c5c65c1505b42acf7ac734fbc7a9f53629a6a1
Reviewed-on: https://review.typo3.org/54718
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
10 months ago[BUGFIX] Fix sorting extensions in "Get Extensions" module 07/54707/2
Nicole Cordes [Mon, 20 Nov 2017 14:33:53 +0000 (15:33 +0100)]
[BUGFIX] Fix sorting extensions in "Get Extensions" module

During some Doctrine cleanup the constraint for fetching extension by
extension key got messed up. This patch removes double named parameter
in search constraint.

Resolves: #80555
Releases: master, 8.7
Change-Id: I84636b4a86d8b3946c552031e3cb23ae69cd3f2a
Reviewed-on: https://review.typo3.org/54707
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
10 months ago[BUGFIX] GIFBUILDER files cannot be delivered via web server 12/54712/2
Oliver Hader [Fri, 17 Nov 2017 13:53:10 +0000 (14:53 +0100)]
[BUGFIX] GIFBUILDER files cannot be delivered via web server

GIFBUILDER uses provided file names and text snippets in order to
generate the final name for files to be written to. In case text
snippets start with a dot, this is also reflected into the file
name - preventing some web servers to deliver the file since it's
considered to be internal.

Resolves: #83029
Releases: master, 8.7
Change-Id: Iebed832c1c2429c7400373a6af4d5ae14a9ea18e
Reviewed-on: https://review.typo3.org/54712
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
10 months ago[BUGFIX] Reload page tree if `extendToSubpages` flag changes 11/54711/2
Andreas Fernandez [Mon, 20 Nov 2017 19:28:05 +0000 (20:28 +0100)]
[BUGFIX] Reload page tree if `extendToSubpages` flag changes

Resolves: #83052
Releases: master, 8.7
Change-Id: I9d86c38f8d1749583e154bd52c77b168d20af7dc
Reviewed-on: https://review.typo3.org/54711
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
10 months ago[BUGFIX] Prevent javascript error in backend 10/54710/2
Markus Günther [Mon, 20 Nov 2017 08:18:27 +0000 (09:18 +0100)]
[BUGFIX] Prevent javascript error in backend

Adding a condition to check if a backend user has permissions on the
search to prevent a JS error while initializing the autocomplete module.

Fixes: #82969
Releases: master, 8.7, 7.6
Change-Id: If2827902443ff7411d9b2c1050213be3e0d78fb6
Reviewed-on: https://review.typo3.org/54710
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
10 months ago[TASK] Example for a RTE Flexform config after migration 00/54700/2
Velletti [Sat, 18 Nov 2017 11:03:23 +0000 (12:03 +0100)]
[TASK] Example for a RTE Flexform config after migration

Releases: master, 8.7
Resolves: #83031
Change-Id: I918ef9ca5ae28f9c605e3c7940cea53b6ed3325a
Reviewed-on: https://review.typo3.org/54700
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
10 months ago[BUGFIX] Fix class name of success button in the install tool 97/54697/2
Markus Günther [Mon, 20 Nov 2017 10:46:09 +0000 (11:46 +0100)]
[BUGFIX] Fix class name of success button in the install tool

Releases: master, 8.7, 7.6
Fixes: #83044
Change-Id: I2c16f160a18f4c0e58b87261b59fbde90aca2f82
Reviewed-on: https://review.typo3.org/54697
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
10 months ago[BUGFIX] ConstantEditor: Make boolean fields UI working in Edge/IE 81/54681/3
Markus Klein [Sun, 19 Nov 2017 01:34:46 +0000 (02:34 +0100)]
[BUGFIX] ConstantEditor: Make boolean fields UI working in Edge/IE

Move the hidden form field out of the label tag to ensure clicking
the label's content (eg. fa icon) really toggles the checkbox.

Resolves: #82998
Releases: master, 8.7, 7.6
Change-Id: Id4293b4109c82a9e6410e113a5b5560ffd1b75d4
Reviewed-on: https://review.typo3.org/54681
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
10 months ago[BUGIFX] Fix JS error in filtering page tree 89/54689/2
Helmut Hummel [Sun, 19 Nov 2017 20:12:18 +0000 (21:12 +0100)]
[BUGIFX] Fix JS error in filtering page tree

While fixing #82877 a mistake was introduced which leads
to a JavaScript error when filtering the page tree.

Problem is that PageTree.select() is called with
the filter tree currently active, but this method
is only functional for the full page tree since quite
a while now.

We now avoid calling this method and document the behavior
properly in method annotations.

Additionally a typo in the variable name is fixed,
which lead to a jquery warning when selecting a page.

Resolves: #83039
Releases: master, 8.7
Change-Id: I6440fb7f6cfd6ead8b5b29dea7c5081dd688a5c3
Reviewed-on: https://review.typo3.org/54689
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
10 months ago[BUGFIX] use included TSconfig files in frontend 80/54680/2
Jigal van Hemert [Tue, 3 Oct 2017 21:47:10 +0000 (23:47 +0200)]
[BUGFIX] use included TSconfig files in frontend

The files included in the field tsconfig_includes are now included
when collecting the page TSconfig in the TypoScriptFrontendController.

Resolves: #82662
Releases: master, 8.7
Change-Id: I226f942045647a3b7c4130b9e5d39b6d982efd1b
Reviewed-on: https://review.typo3.org/54680
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
10 months ago[BUGFIX] Add correct conversion of RTE pageTS config 65/54665/4
Frans Saris [Tue, 31 Oct 2017 15:32:51 +0000 (16:32 +0100)]
[BUGFIX] Add correct conversion of RTE pageTS config

Add all pageTS.RTE options to config without dots appended to the key
to be able to override the RTE config with pageTS like before.

Resolves: #82865
Releases: master, 8.7
Change-Id: Idb7d7d3b39d44ec37be8f93cc9de8b42b9c8a55c
Reviewed-on: https://review.typo3.org/54665
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
10 months ago[BUGFIX] Fix notices in UserAuthentication 66/54666/4
Tymoteusz Motylewski [Thu, 16 Nov 2017 14:38:23 +0000 (15:38 +0100)]
[BUGFIX] Fix notices in UserAuthentication

Resolves: #83003
Releases: master, 8.7
Change-Id: Iceaa7ab9bd436322229e591677c0aee16cd69f5c
Reviewed-on: https://review.typo3.org/54666
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
10 months ago[BUGFIX] Set l10n_state before synchronizing fields 56/54656/9
Helmut Hummel [Wed, 15 Nov 2017 17:17:49 +0000 (18:17 +0100)]
[BUGFIX] Set l10n_state before synchronizing fields

L10nModeUpdater checks whether fields in translated records are
modified, thus not synchronized with the parent record and the
new l10n_state for this field is set to "custom" in this case
or "parent" if the field is empty.

However this is done after the data is synchronized, which
leads to wrong data being written by the DataMapProcessor.

To fix this, we move setting l10n_state upwards in the code,
so that relations and fields from translated records can be
updated correctly.

Resolves: #83006
Releases: master, 8.7
Change-Id: Ibb06eecb6cf743bd6bba1990ca6f9391c983821f
Reviewed-on: https://review.typo3.org/54656
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
10 months ago[BUGFIX] Fix keepItems and removeItems handling with 0 values 26/54626/2
Helmut Hummel [Sun, 12 Nov 2017 18:27:49 +0000 (19:27 +0100)]
[BUGFIX] Fix keepItems and removeItems handling with 0 values

TSConfig properties keepItems and removeItems are checked
with a weak in_array() test (third argument not set to true),
which leads to the situation, that arbitrary string values
are treated equal to integer 0

This is now fixed by flipping the array and check for the
array index. This works nicely because PHP silently
converts strings which look like integer to integer for the keys.

Tests are added which cover these cases and demonstrate
the failure before the change.

Resolves: #82980
Releases: 8.7, master
Change-Id: I544a221674fa89d302cb6c1bcca506847c6f7f0f
Reviewed-on: https://review.typo3.org/54626
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
10 months ago[FOLLOWUP][TASK] FAL-based database fields moved to integer 69/54669/2
Oliver Hader [Thu, 16 Nov 2017 17:19:56 +0000 (18:19 +0100)]
[FOLLOWUP][TASK] FAL-based database fields moved to integer

Remove duplicated "image" field definition in test scenario.

Related: #69909
Releases: master, 8.7
Change-Id: Ie87e2e62e036fa70fb837f9bd05f2c3ba13019fa
Reviewed-on: https://review.typo3.org/54669
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
10 months ago[BUGFIX] Avoid invalid references in DataMapProcessor 67/54667/2
Oliver Hader [Wed, 15 Nov 2017 15:07:57 +0000 (16:07 +0100)]
[BUGFIX] Avoid invalid references in DataMapProcessor

If DataMapProcessor is called with a non-reference id, e.g.
zero (0), this submission is considered as a reference. Since
there is no database record having UID 0, the synchronization
process fails with the following exeception:

#1486233164: Child record was not processed

To solve this behavior, invalid references (empty/zero) are
not considered anymore to compare references. Besides that,
values for localized records that are configured to be
synchronized are sanitized correctly now.

Resolves: #83009
Releases: master, 8.7
Change-Id: Ie370007521c45dac8bca03978a387b4662952b1d
Reviewed-on: https://review.typo3.org/54667
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
10 months ago[BUGFIX] Use correct parameters for trimExplode 62/54662/2
Wouter Wolters [Tue, 14 Nov 2017 18:05:15 +0000 (19:05 +0100)]
[BUGFIX] Use correct parameters for trimExplode

In QueryBuilder::quoteIdentifiersForSelect the 3rd parameter of
trimExplode is inserted. To prevent notices array_pad is added.

Resolves: #82995
Releases: master,8.7
Change-Id: If35efcf5c8c3fd5b0360ae8795f9b92ae87250ab
Reviewed-on: https://review.typo3.org/54662
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
10 months ago[BUGFIX] Remove "[newlog()] " from DataHandler log info 61/54661/2
Benni Mack [Thu, 16 Nov 2017 11:10:55 +0000 (12:10 +0100)]
[BUGFIX] Remove "[newlog()] " from DataHandler log info

DataHandlers' newlog() function is a shorthand method that
should act as a simple API, which it does, but it also adds
a "[newlog()] " info in front of the error message, which is
completely useless and only clutters DB and the log module.

Resolves: #83012
Releases: master, 8.7
Change-Id: I9e1ea083461de9cdf66fad1a30019e51130a0186
Reviewed-on: https://review.typo3.org/54661
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
10 months ago[BUGFIX] Fix allowLanguageSynchronization on pages_language_overlay 50/54650/3
Oliver Hader [Wed, 15 Nov 2017 12:43:06 +0000 (13:43 +0100)]
[BUGFIX] Fix allowLanguageSynchronization on pages_language_overlay

In case a TCA field uses allowLanguageSynchronization (or
l10n_mode=exclude) for table pages_language_overlay, dependencies
(localizations of the initial record) are processed that point to
the according pages_language_overlay. However pages_language_overlay
records cannot be localized further, they always depend on a single
pages record which is the record of the default language.

In case the backend is used as non-admin user that has a language
restriction ("Limit to languages" in backend groups/users settings),
an error message is shown:

    [newlog()] recordEditAccessInternals() check failed.
    [ERROR: Language was not allowed.]

In TYPO3 v8, all pages_language_overlay records are selected which match
the condition pages_language_overlay.pid = pages_language_overlay.uid
(pid is used as transOrigPointerField). In TYPO3 v9 this changed since
pages_language_overlay has been migrated into pages having a distinct
transOrigPointerField in l10n_parent.

Resolves: #83001
Releases: 8.7
Change-Id: Ie4dfdb44c3d6a9b89819f473816f3e062a685027
Reviewed-on: https://review.typo3.org/54650
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
10 months ago[BUGFIX] FileStorageExtractionTask breaks if file not found 47/54647/2
Thomas Hohn [Tue, 7 Mar 2017 07:19:46 +0000 (08:19 +0100)]
[BUGFIX] FileStorageExtractionTask breaks if file not found

Before the file is processed a extra check is done to be sure the file
exists. If the file doesn't exist it's marked as missing.

Resolves: #80061
Releases: master, 8.7
Change-Id: Ifda396b75d2ace0ce126057a4e118856b15c05e0
Reviewed-on: https://review.typo3.org/54647
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
10 months ago[TASK] Allow all fields in felogin hook "forgotPasswordMail" 43/54643/2
Tom Novotny [Mon, 13 Nov 2017 14:56:51 +0000 (15:56 +0100)]
[TASK] Allow all fields in felogin hook "forgotPasswordMail"

Return all fields to ease the work with hooks.
Intention is not having to query again in hook
$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['felogin']['forgotPasswordMail']
to change "Hello [username],..." to "Hello [fist_name] [last_name],..."
in password forgot mail to user.

Resolves: #82996
Releases: master, 8.7
Change-Id: I18e18845e61d36aadd043758f902dc6627ad5f37
Reviewed-on: https://review.typo3.org/54643
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
10 months ago[BUGFIX] Stabilize Language Acceptance tests 39/54639/2
Mathias Schreiber [Mon, 13 Nov 2017 17:57:01 +0000 (18:57 +0100)]
[BUGFIX] Stabilize Language Acceptance tests

Stabilize the acceptance tests to activate and deactivate a language by
checking only for the alerts instead of the enabled/disabled rows.

Additionally make the download a language test fail immediately if the
language is enabled.

Resolves: #82972
Releases: master, 8.7
Change-Id: Ib380b464a24188dbbee37296ddda0f0bb5c44f5e
Reviewed-on: https://review.typo3.org/54639
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
10 months ago[BUGFIX] Handle variadic arguments in Extbase DebuggerUtility 37/54637/2
Mathias Brodala [Thu, 9 Nov 2017 08:42:04 +0000 (09:42 +0100)]
[BUGFIX] Handle variadic arguments in Extbase DebuggerUtility

Variadic arguments are optional but do not have a default value, thus
properly check this.

Also render the variadic operator ("...") in the output.

Resolves: #82956
Releases: master, 8.7
Change-Id: I10e3528d9cffcdd03ae4711b139898f569ac3775
Reviewed-on: https://review.typo3.org/54637
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
10 months ago[BUGFIX] Add label to page ID field in PageLinkHandler 35/54635/2
Georg Ringer [Tue, 7 Nov 2017 07:08:42 +0000 (08:08 +0100)]
[BUGFIX] Add label to page ID field in PageLinkHandler

Add the missing label and adopt styling of the additional
field which allows to link to a page by providing the page ID.

Resolves: #82888
Releases: master, 8.7
Change-Id: I33ab92f235391add5d3da00a0251ee11eb936933
Reviewed-on: https://review.typo3.org/54635
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
10 months ago[BUGFIX] Add FLUIDTEMPLATE to t3editor code completion 36/54636/2
Andreas Fernandez [Sun, 5 Nov 2017 12:09:17 +0000 (13:09 +0100)]
[BUGFIX] Add FLUIDTEMPLATE to t3editor code completion

With this patch t3editor is now aware of `FLUIDTEMPLATE`, thus supported
by code completion.

Resolves: #82967
Releases: master, 8.7
Change-Id: I82cc9bd22a5a0829ea634eb5cfda4bc8e589c1cc
Reviewed-on: https://review.typo3.org/54614
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-on: https://review.typo3.org/54636

10 months ago[TASK] Upgrade chromedriver to 2.33 30/54630/2
Christian Kuhn [Mon, 13 Nov 2017 16:53:48 +0000 (17:53 +0100)]
[TASK] Upgrade chromedriver to 2.33

Use latest chromedriver to deal with youngest chrome
in acceptance tests.

Change-Id: I7d637022fa9e327e771198625943b11b986b5a04
Resolves: #82987
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54630
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
10 months ago[BUGFIX] Fix multi-checkbox/radiobox labels for values containing dots 21/54621/3
Oliver Hader [Fri, 8 Sep 2017 10:43:03 +0000 (12:43 +0200)]
[BUGFIX] Fix multi-checkbox/radiobox labels for values containing dots

If checkbox/radiobox values contain dots, these are falsely evaluated as
array lookup paths. Fix this by passing in separate path segments instead
which may contain dots.

Resolves: #82210
Releases: master, 8.7
Change-Id: Ib3d0d1abbeb4fdf84da427f6bea0d597ba9aade6
Reviewed-on: https://review.typo3.org/54621
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
10 months ago[BUGFIX] Improve performance iterating local files 27/54627/2
Stephan Großberndt [Tue, 7 Nov 2017 08:44:24 +0000 (09:44 +0100)]
[BUGFIX] Improve performance iterating local files

Improve performance iterating local files by avoiding multiple calls to
SplFileInfo.

Releases: master, 8.7
Resolves: #82936
Change-Id: I54b347ad4734d9083b67c7840ff3ab228c07f4bc
Reviewed-on: https://review.typo3.org/54627
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
10 months ago[BUGFIX] Fix path-resolution for template-resource in EXT:felogin 25/54625/2
Daniel Siepmann [Sun, 12 Nov 2017 13:50:40 +0000 (14:50 +0100)]
[BUGFIX] Fix path-resolution for template-resource in EXT:felogin

Do not use frontend inclusion API for private template resource.
Instead resolve to full absolute path for inclusion.

Releases: master, 8.7
Resolves: #82978
Resolves: #82979
Change-Id: Iadd3a8386b967aeb8b5ffdb28baeb73c2a0f2734
Reviewed-on: https://review.typo3.org/54625
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
10 months ago[BUGFIX] Add missing code-block:: php line in feature rst file 13/54613/2
Frans Saris [Fri, 10 Nov 2017 10:54:40 +0000 (11:54 +0100)]
[BUGFIX] Add missing code-block:: php line in feature rst file

Resolves: #82964
Releases: master, 8.7
Change-Id: Iccaae0c2aeefa7c82b3df50956424509acea4233
Reviewed-on: https://review.typo3.org/54613
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
10 months ago[TASK] EXT:form - cache merged YAML settings 99/54599/2
Ralf Zimmermann [Sun, 10 Sep 2017 16:51:35 +0000 (18:51 +0200)]
[TASK] EXT:form - cache merged YAML settings

Cache the merged YAML settings into the assets cache to improve the
performance.

Resolves: #82373
Releases: master, 8.7
Change-Id: I601364d5957f26f1b369b513534936820f72b78e
Reviewed-on: https://review.typo3.org/54599
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
10 months ago[BUGFIX] Show deleted page actions in record history 79/54579/5
Helmut Hummel [Tue, 7 Nov 2017 14:09:08 +0000 (15:09 +0100)]
[BUGFIX] Show deleted page actions in record history

Because users have no access to deleted pages,
the access check always fails, leading to delete page
actions not being shown in the history despite being
properly tracked.

We now check this case and do a more lightweight check
so that we still have the permissions checked,
but can show deleted pages without disclosing unwanted
information.

Resolves: #45056
Releases: 7.6, 8.7, master
Change-Id: Id919a24651c18a351f9723e86610b525a4f4726c
Reviewed-on: https://review.typo3.org/54579
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
10 months ago[TASK] Add Fluid expressions and pre-processors global config 81/54581/3
Claus Due [Sat, 14 Oct 2017 12:19:49 +0000 (14:19 +0200)]
[TASK] Add Fluid expressions and pre-processors global config

This patch moves a previously hardcoded list of Fluid
implementations from the RenderingContext constructor,
to TYPO3_CONF_VARS. Extensions and site administrators
can then add their own implementations to this array and
have them be used in every RenderingContext.

See included RST file for further information on usage.

Change-Id: I6190ceb410e1121ea935a31237cb8bcd0b2f0417
Resolves: #82763
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54581
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
10 months ago[TASK] Update typo3/cms-composer-installers 01/54601/2
Alexander Opitz [Mon, 6 Nov 2017 12:05:21 +0000 (13:05 +0100)]
[TASK] Update typo3/cms-composer-installers

Update the lock file to pull in the latest (1.4.5) release.
This version is marked as PHP 7.2 compatible.
composer command: composer update typo3/cms-composer-installers

Releases: 8.7, master
Resolves: #82898
Change-Id: I6c491ae7e93f656c01a9ef12d88969057b182ba7
Reviewed-on: https://review.typo3.org/54570
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-on: https://review.typo3.org/54601

10 months ago[TASK] Update ext:styleguide to 8.0.13 89/54589/4
Christian Kuhn [Wed, 8 Nov 2017 13:03:51 +0000 (14:03 +0100)]
[TASK] Update ext:styleguide to 8.0.13

This is probably the last version with v8 and v9
in sync before branching off styleguide v8.

Styleguide introduced a new table with 8.0.13, one
of the acceptance tests that uses a rather hard coded
xpath now needs a slightly different selector to cope
with that.

Change-Id: I7ef4f840807963e6a93a90bda394657b8c36c6a0
Resolves: #82951
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54589
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
10 months ago[BUGFIX] TcaMigration should not skip on existing overrideChildTca 82/54582/2
Malte Koitka [Wed, 3 May 2017 07:42:16 +0000 (09:42 +0200)]
[BUGFIX] TcaMigration should not skip on existing overrideChildTca

If an overideChildTca key is already added by a TYPO3 core
function like ExtensionManagementUtility::getFileFieldTCAConfig()
the TCA migration should not be skipped. Otherwise the config will
be incomplete and result in missing fields.

The migration is changed that old "foreign_types",
"foreign_selector_fieldTcaOverride" and "foreign_record_defaults"
are merged into new "overrideChildTca", but the new settings
are keps (take precedence) if given.

Resolves: #80719
Resolves: #81045
Releases: master, 8.7
Change-Id: Ic8a0338e0a9882b3b1e7abcd3123fbd7aa2b3505
Reviewed-on: https://review.typo3.org/54582
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
10 months ago[BUGFIX] Add workspace overlay for translated page title 84/54584/3
Georg Ringer [Tue, 7 Nov 2017 19:40:29 +0000 (20:40 +0100)]
[BUGFIX] Add workspace overlay for translated page title

The title of a translated page must be overlayed with the
workspace version.

Resolves: #65607
Releases: master, 8.7, 7.6
Change-Id: If10260f196776a16a53968b78542827ecbc145fe
Reviewed-on: https://review.typo3.org/54584
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
10 months ago[TASK] Filter duplicate cache commands from CacheQueue 78/54578/2
Benjamin Rannow [Mon, 6 Nov 2017 11:58:49 +0000 (12:58 +0100)]
[TASK] Filter duplicate cache commands from CacheQueue

under the right condition multiple duplicate cache commands are executed

for Example: save a record in Backend can course multiple 'pages'
commands will be executed, if the record has inline records.

flushing '20' times the 'pages' cache is unnecessary.

Resolves: #82930
Releases: master, 8.7
Change-Id: I69e581cb7f12acbd8172b2ca88e89f93ebfbe4b4
Reviewed-on: https://review.typo3.org/54578
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
10 months ago[BUGFIX] Element file browser respects allowedExtensions 73/54573/2
Christian Kuhn [Wed, 1 Nov 2017 13:05:33 +0000 (14:05 +0100)]
[BUGFIX] Element file browser respects allowedExtensions

The type=input, renderType=inputLink field control has an option
"allowedExtensions" to restrict the file element browser to specific
file endings. This option is now correctly considered in file browser.

Change-Id: Ic42bd0de06002f308d7db4098c704ca2574e4018
Resolves: #82861
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54573
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
10 months ago[BUGFIX] Fix PHP Notices in cached ext_localconf.php 65/54565/3
Tymoteusz Motylewski [Mon, 6 Nov 2017 10:02:08 +0000 (11:02 +0100)]
[BUGFIX] Fix PHP Notices in cached ext_localconf.php

Resolves: #82920
Releases: master, 8.7
Change-Id: I7a533f56ec68a119c19aad6c87de9dfc2e59dc6a
Reviewed-on: https://review.typo3.org/54565
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
10 months ago[TASK] Update typo3/cms-composer-installers 67/54567/3
Helmut Hummel [Mon, 6 Nov 2017 11:03:16 +0000 (12:03 +0100)]
[TASK] Update typo3/cms-composer-installers

Update the lock file to pull in the latest release.
composer command: composer update typo3/cms-composer-installers

Releases: 8.7, master
Resolves: #82898
Change-Id: Idde56a61ce718da2d06cc70fc0e53b834ac44981
Reviewed-on: https://review.typo3.org/54567
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>