Packages/TYPO3.CMS.git
5 years ago[BUGFIX] Refine the error message of checkMaximumFileUploadSize 73/31873/3
Markus Klein [Sun, 27 Jul 2014 20:44:50 +0000 (22:44 +0200)]
[BUGFIX] Refine the error message of checkMaximumFileUploadSize

The Install Tool check the PHP configuration for the maximum file
upload size within the checkMaximumFileUploadSize() method.
This method issues an error message in case the values do not fit.
The error message outputs the values in MB which might give a
wrong indication to the user, as the values seem to be equal
although the check complains they are not.

Provide better output by giving those numbers in KB rather than MB,
which will show diverging numbers correctly then.

Resolves: #60627
Releases: 6.3, 6.2
Change-Id: I5faa4ceb4d7279278182716c31bf6d6dcb851052
Reviewed-on: http://review.typo3.org/31873
Reviewed-by: Christian Hünniger <huenniger@mellowmessage.de>
Tested-by: Christian Hünniger <huenniger@mellowmessage.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Transfer curlProxyServer to new HTTP settings 67/31867/2
Ernesto Baschny [Sun, 27 Jul 2014 11:59:20 +0000 (13:59 +0200)]
[BUGFIX] Transfer curlProxyServer to new HTTP settings

Splits up the old curlProxyServer correctly, stripping "http://" and
potentially trailing slashes.

Resolves: #45834
Releases: 6.3, 6.2, 6.1
Change-Id: Ibfefb927b5fd3fe900170870e1093027d4fe34b5
Reviewed-on: http://review.typo3.org/31867
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Admin panel shows wrong cache information 35/27835/3
Dmitry Dulepov [Tue, 25 Feb 2014 11:56:28 +0000 (15:56 +0400)]
[BUGFIX] Admin panel shows wrong cache information

When labels were extracted to translation files, a error was made
that changed the meaning of the admin panel entry. But the code
was not modified to reflect the change of the meaning. Thus the
admin panel shows that the page is cached when it is actually not
cached and vice versa. Additionally, it shows 0 and 1 for the
"Page cached" entry. This should be "yes" or "no", not numbers.

Change-Id: I2519593e7da08b71ccdd5d7dc3dd6ced7ecac3ac
Resolves: #56265
Releases: 6.3, 6.2
Reviewed-on: http://review.typo3.org/27835
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 years ago[BUGFIX] Show loading spinner when Updating TER list on search module 45/31845/2
Sascha Egerer [Sat, 26 Jul 2014 13:02:27 +0000 (15:02 +0200)]
[BUGFIX] Show loading spinner when Updating TER list on search module

When you search for an extension in the Extension manager and then click
on the "Update Now" button to load the newest list from the TER, the
spinner was not displayed.

Also fixed some invalid HTML stuff and repositioned the spinner.

Resolves: #60600
Releases: 6.3, 6.2
Change-Id: I670d821248d14c0c1038b5995fc7daef2ead42d8
Reviewed-on: http://review.typo3.org/31845
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[BUGFIX] Fix Extbase language fallback in query parser 59/31859/4
Helmut Hummel [Sun, 27 Jul 2014 08:55:35 +0000 (10:55 +0200)]
[BUGFIX] Fix Extbase language fallback in query parser

Currently when TYPO3 is configured to do language fallback
and a record is translated in language A, but not
in language B and language B is requested, then this
record is excluded.

This is the case because of a wrong subselect condition.

Extbase selects records in the requested translation
or if no translation is available in the default language.
However the check if translation is available looks
for *any* translation not only for a translation in the
requested language. Thus the record from the default
language is not selected at all if there are translations
available in any other language.

Solution is to change the subselect condition to check
for the currently requested language.

Releases: 6.1, 6.2, master
Resolves: #60613
Change-Id: I8ebd68e1f5741d3557910ae2f8c2d19474548d01
Reviewed-on: http://review.typo3.org/31859
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[!!!][BUGFIX] ConfigurationManager signal information missing 73/31773/4
Susanne Moog [Thu, 24 Jul 2014 17:52:22 +0000 (19:52 +0200)]
[!!!][BUGFIX] ConfigurationManager signal information missing

The signal emitted in the ConfigurationManager of the ExtensionManager
misses crucial information (the extension for which the configuration
was written) and is therefor useless at the moment.

Add the extension key to the signal so that it may be used.

Change-Id: I21d22b10852e9842d9d077eb5dd49ec4518ca4ed
Fixes: #60609
Releases: 6.3
Reviewed-on: http://review.typo3.org/31773
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
5 years ago[BUGFIX] Fix the help message of CLI 06/31106/6
Stefano Kowalke [Tue, 24 Jun 2014 11:26:41 +0000 (13:26 +0200)]
[BUGFIX] Fix the help message of CLI

The help command prints informations about a specific command.
This text is taken from the doc comment by reflection.

Currently the parser expects that type, variable name and comment
are separated by exactly one space, according to our CGL.

Relax the parsing to allow multiple whitespace characters (including tabs)
as separators when fetching the comment for an argument,
to support other coding styles.

Resolves: #59843
Releases: 6.3, 6.2
Change-Id: Id0a9c0ec00bf442adcbd428088744419200a69a0
Reviewed-on: http://review.typo3.org/31106
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
5 years ago[TASK] Add first documentation of breaking changes 53/31853/7
Christian Kuhn [Sat, 26 Jul 2014 14:50:12 +0000 (16:50 +0200)]
[TASK] Add first documentation of breaking changes

For better documentation of important changes a new file structure
is introduced that substitutes the old NEWS.md file. Some recent
changes are already added with this change as examples, but all
patches since 6.2 release need a post-merge review to see which
further patches need documentation. In future, changelog files for
important changes should be provided together with the patch that
introduces the change.

Resolves: #60186
Resolves: #59741
Resolves: #59740
Releases: master
Change-Id: I6e154262ed49542a5b15e7c68313c9f11dea5fe5
Reviewed-on: http://review.typo3.org/31853
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
Reviewed-by: Ernesto Baschny <ernst@cron-it.de>
Tested-by: Ernesto Baschny <ernst@cron-it.de>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
5 years ago[TASK] Use jQuery for IRRE Ajax calls 35/29835/8
Andreas Wolf [Sat, 3 May 2014 18:24:32 +0000 (20:24 +0200)]
[TASK] Use jQuery for IRRE Ajax calls

Change-Id: I5fe2f79ba233e114fb2bfb87c1100eeb8dccbc41
Resolves: #58475
Releases: 6.3
Reviewed-on: http://review.typo3.org/29835
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[CLEANUP] Remove hardcoded valign="top" in FormEngine 33/27833/4
Benjamin Mack [Fri, 25 Jul 2014 18:48:09 +0000 (20:48 +0200)]
[CLEANUP] Remove hardcoded valign="top" in FormEngine

There are several places in the TYPO3 Form Engine
where the styling information about tables (valign)
is hard-coded.

The patch removes that, styling is done via CSS.

Resolves: #56261
Releases: 6.3
Change-Id: Ibcc9bb7df3cf05e791eae7f16d91e0afa60ab65d
Reviewed-on: http://review.typo3.org/27833
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Marcin Sągol <marcin@soee.pl>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[TASK] Remove hardcoded TypoScript setup 79/20279/3
Wouter Wolters [Sun, 28 Apr 2013 21:22:45 +0000 (23:22 +0200)]
[TASK] Remove hardcoded TypoScript setup

TypoScript TemplateService contains some hard coded TS that is always
present. The two defaults config.extTarget and config.uniqueLinkVars
are now moved to EXT:frontend and registered with the usual API call.
styles.insertContent is removed since it was always hidden in the
object browser and probably never used by anyone.

Change-Id: I8d0fd7c91e0c3b7ac19bcf1e435bb911b597e525
Resolves: #42543
Related: #60567
Releases: 6.3
Reviewed-on: http://review.typo3.org/20279
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
5 years ago[CLEANUP] Let expected exceptions test for code, not text 35/31835/2
Anja Leichsenring [Fri, 25 Jul 2014 19:33:02 +0000 (21:33 +0200)]
[CLEANUP] Let expected exceptions test for code, not text

When an exception is expected in DependencyUtilityTest, the correct
exception is tested by text. The change of wording of some of those
exceptions caused the related test to fail.

Testing for the exception code instead of the text opens the
possibility to adapt display messages, while the exception code stays
unchanged and stabilizes tests against false positives.

Change-Id: Ib1365c8d7166e522690bb9f8842adc8eb27f635b
Resolves: #60583
Relates: #53572
Releases: 6.3, 6.2
Reviewed-on: http://review.typo3.org/31835
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[BUGFIX] felogin plugin still uses old class name in TypoScript 90/31290/6
Benjamin Mack [Wed, 2 Jul 2014 14:10:39 +0000 (16:10 +0200)]
[BUGFIX] felogin plugin still uses old class name in TypoScript

FE Login still uses TypoScript with a manual
inclusion of the original file and then the
original class name.

plugin.tx_felogin_pi1 = USER_INT
plugin.tx_felogin_pi1 {
includeLibs = EXT:felogin/pi1/class.tx_felogin_pi1.php
userFunc = tx_felogin_pi1->main
}

This way it is impossible to XCLASS the new
namespaced class "FrontendLoginController"
without also changing the USER_INT userFunc
path.

In order to remove the deprecation, we need to
change the class name - no-brainer.

Resolves: #60063
Releases: 6.3
Change-Id: If09e5a3fdc3317623d5ea1de9af04cb04e606656
Reviewed-on: http://review.typo3.org/31290
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
5 years ago[CLEANUP] RSA Auth: Move JS files in proper location 32/31832/3
Benjamin Mack [Fri, 25 Jul 2014 18:55:22 +0000 (20:55 +0200)]
[CLEANUP] RSA Auth: Move JS files in proper location

Renames the folder "resources" to "Resources"
and moves the JS files into
"Resources/Public/JavaScript".

Resolves: #60582
Releases: 6.3
Change-Id: Id549c4d006e8690b49b7800399fca95410ee641c
Reviewed-on: http://review.typo3.org/31832
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[TASK] Drop TYPO3_CONF_VARS['SYS]['contentTable'] 31/31831/3
Christian Kuhn [Fri, 25 Jul 2014 18:21:13 +0000 (20:21 +0200)]
[TASK] Drop TYPO3_CONF_VARS['SYS]['contentTable']

There is a config to define the used "contentTable" which is set
by cms extension to tt_content. Using tt_content is hardcoded at
many places and probably no one ever set this option to something
different than "tt_content". The option is dropped now.

Resolves: #60570
Releases: 6.3
Change-Id: I039e7f5c9e0562c54ce671dc7e7a2ac807f8076e
Reviewed-on: http://review.typo3.org/31831
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Tested-by: Sascha Egerer <sascha@sascha-egerer.de>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Change wording for TYPO3 dependency errors 25/31825/3
Susanne Moog [Fri, 25 Jul 2014 17:44:29 +0000 (19:44 +0200)]
[BUGFIX] Change wording for TYPO3 dependency errors

The wording of a TYPO3 dependency error currently suggests
installing another TYPO3 version to make an extension usable -
that does not make sense.

Change the error message so it's clear that it's the extensions'
support that is missing.

Change-Id: I7a5f7acde7bebc9c3f7acda92e2522ffb979d478
Resolves: #53572
Fixes: 6.3, 6.2
Reviewed-on: http://review.typo3.org/31825
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[BUGFIX] Install Tool image tests: black background after scaling 16/31816/5
Susanne Moog [Fri, 25 Jul 2014 15:05:48 +0000 (17:05 +0200)]
[BUGFIX] Install Tool image tests: black background after scaling

Transparent turns black unless you specify a different color
because transparent = unset color = 0 = black. We should fix this
by adding the "-opaque white -background white -flatten"
parameters for the convert action done
by the install tool.

Change-Id: I5dd5c41852a33159752702b68ce0a297b33cf569
Releases: 6.3, 6.2
Fixes: #60570
Reviewed-on: http://review.typo3.org/31816
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Extension manager page browser not disabled on list update 23/31823/2
Susanne Moog [Fri, 25 Jul 2014 17:22:53 +0000 (19:22 +0200)]
[BUGFIX] Extension manager page browser not disabled on list update

The extension list on "get extensions" only masks the table when
loading where it should also mask the page browser as you will get
errors when using it while the list is still loading.

The mask now covers the whole ter table content.

Change-Id: I404e4f1a5b9b62a53392491c911d654ce6f007b3
Releases: 6.2, 6.3
Fixes: #55317
Reviewed-on: http://review.typo3.org/31823
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[TASK] Add missing unit test for enumeration 17/31817/2
Sascha Egerer [Fri, 25 Jul 2014 16:00:56 +0000 (18:00 +0200)]
[TASK] Add missing unit test for enumeration

Add unit test that checks if the constructor throws
an exception if an invalid value is requested.

Resolves: #60572
Releases: 6.3, 6.2
Change-Id: I2179414f94bbd6465c5b780c71dfed3c91e71776
Reviewed-on: http://review.typo3.org/31817
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[TASK] Show 'styles' object in TypoScript Object Browser 14/31814/2
Anja Leichsenring [Fri, 25 Jul 2014 14:21:51 +0000 (16:21 +0200)]
[TASK] Show 'styles' object in TypoScript Object Browser

When you look in the TOB for the styles.* settings, those are not
shown. In order to ease the lookup of existing settings, let's
show them there.

Resolves: #60567
Releases: 6.3
Change-Id: I5163736c21847070c50e29911fff2b492f7cfc87
Reviewed-on: http://review.typo3.org/31814
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[BUGFIX] Respect global renderReadonly in Tceforms for tree 10/31110/2
Lorenz Ulrich [Tue, 24 Jun 2014 12:45:48 +0000 (14:45 +0200)]
[BUGFIX] Respect global renderReadonly in Tceforms for tree

The global renderReadonly status in Tceforms doesn't affect a
rendered tree because the check was forgotten when #25888 was
implemented. An additional check is added.

Resolves: #59849
Releases: 6.3, 6.2
Change-Id: Ic89ab2f39636dbbb7dc37941af8fe7be085fefcf
Reviewed-on: http://review.typo3.org/31110
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[TASK] Change example for backend module in BaseScriptClass 11/31811/3
Wouter Wolters [Fri, 25 Jul 2014 13:30:59 +0000 (15:30 +0200)]
[TASK] Change example for backend module in BaseScriptClass

Resolves: #60566
Releases: 6.3
Change-Id: I742e68f617dc049ca059406b50e08e24c7d74b79
Reviewed-on: http://review.typo3.org/31811
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[TASK] Refactor Install Tool JavaScript 42/28642/6
Wouter Wolters [Sat, 22 Mar 2014 14:02:09 +0000 (15:02 +0100)]
[TASK] Refactor Install Tool JavaScript

Resolves: #57182
Releases: 6.3
Change-Id: I2c8a7f594e3716152dfb9acb5246c741f7c9580d
Reviewed-on: http://review.typo3.org/28642
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[BUGFIX] Labels in extension manager not loaded 90/31790/9
Susanne Moog [Fri, 25 Jul 2014 08:40:34 +0000 (10:40 +0200)]
[BUGFIX] Labels in extension manager not loaded

The extensionmanager tries to load language labels from the
old extension manager.

Add the needed labels to the extension manager language file and
delete the old file. Simultaneously refactor the language handling
a bit.

Change-Id: I937b0ce53de0bfe56219d676f6d008ae7a5d303c
Resolves: #55449
Releases: 6.3
Reviewed-on: http://review.typo3.org/31790
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[TASK] Use double back slashes for class name in makeInstance 08/31808/2
Wouter Wolters [Fri, 25 Jul 2014 12:53:23 +0000 (14:53 +0200)]
[TASK] Use double back slashes for class name in makeInstance

Resolves: #60562
Releases: 6.3
Change-Id: I321f32f85df90e11443837c2704eba5c097e7ea1
Reviewed-on: http://review.typo3.org/31808
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[TASK] Clean up backend login controller Part 1 02/31802/4
Christian Kuhn [Fri, 25 Jul 2014 11:00:32 +0000 (13:00 +0200)]
[TASK] Clean up backend login controller Part 1

To prepare a switch of the backend login view to a fluid rendered
template, the current controller is first simlpfied a bit and some
ancient code is removed.

With t3skin, the default template of ext:backend/.../login.html is
always overloaded by ext:t3skin/.../login.html. The patch overwrites
the content of the ext:backend template with the content from
ext:login and removes the template and overload registration in
ext:login.

The old template in ext:backend was not used for a very long time
but includes some old handling like loginBoxImage_rotationFolder
encapsulated in makeLoginBoxImage(). This code is dropped without
substitution.

References to two ancient login images are dropped with the removal
of makeLoginBoxImage() and can be finally removed along the way.

Change-Id: I057fbe062b138ab4f428e49e511bc46363a8a7ed
Resolves: #60559
Releases: 6.3
Reviewed-on: http://review.typo3.org/31802
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
5 years ago[TASK] Remove old default constants from TS service 03/31803/2
Christian Kuhn [Fri, 25 Jul 2014 11:36:50 +0000 (13:36 +0200)]
[TASK] Remove old default constants from TS service

$this->const in TemplateService and an extending class is super old,
unused and removed.

Resolves: #60561
Releases: 6.3
Change-Id: Ief7382b11d94094be587ae691ee6e3d1812b2d91
Reviewed-on: http://review.typo3.org/31803
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
5 years ago[TASK] Reduce file size of core images 29/29829/7
Anja Leichsenring [Fri, 25 Jul 2014 10:11:54 +0000 (12:11 +0200)]
[TASK] Reduce file size of core images

Reduce the file size without losing quality.
This reduces total typo3 directory size by ~2 MB.

Change-Id: I56d1e9eccee05833a4e0373211eaeb3fefbc4336
Resolves: #58110
Releases: 6.3
Reviewed-on: http://review.typo3.org/29829
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[TASK] Fix wrong named unit tests of the logging framework 82/31782/5
Sascha Egerer [Thu, 24 Jul 2014 20:50:44 +0000 (22:50 +0200)]
[TASK] Fix wrong named unit tests of the logging framework

Most of the unit tests for the logging framework have a
wrong filename and also a wrong classname.

Resolves: #60547
Releases: 6.3, 6.2
Change-Id: I5aaad54566bd33a9caf0d665655d9cb0f4552119
Reviewed-on: http://review.typo3.org/31782
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[FEATURE] Extend IntrospectionProcessor to log full Backtrace 96/31296/9
Sascha Egerer [Wed, 2 Jul 2014 17:00:16 +0000 (19:00 +0200)]
[FEATURE] Extend IntrospectionProcessor to log full Backtrace

Extend the introspection processor so it can add
a full backtrace instead of only the last item
of the backtrace.

Also adds an option to shift a given amount of
levels from the backtrace.

Resolves: #60064
Documentation: #60074
Releases: 6.3
Change-Id: Ieb5d1e8ca11fdfd649d18d7751ebb0f770e60ef5
Reviewed-on: http://review.typo3.org/31296
Reviewed-by: Steffen Müller <typo3@t3node.com>
Tested-by: Steffen Müller <typo3@t3node.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[TASK] Remove not needed TemplateService code 44/27244/6
Benjamin Mack [Sat, 1 Feb 2014 21:44:26 +0000 (22:44 +0100)]
[TASK] Remove not needed TemplateService code

The TemplateService class provides its own wrap()
function which is exactly the same as in cObj.
The only instances where the wrap() method is used
is in the MenuContentObjects - however, they can
also access the wrap() function via cObj.

The MenuContentObjects are now using the cObj
function so the duplicate code in TemplateService
can be deprecated.

Resolves: #55567
Releases: 6.3
Change-Id: Iaa7055473f814acc73429f31772d1946c66004f9
Reviewed-on: http://review.typo3.org/27244
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
5 years ago[BUGFIX] Prevent fatal when importing a t3d file without fal information 67/31767/3
Sascha Egerer [Thu, 24 Jul 2014 15:44:16 +0000 (17:44 +0200)]
[BUGFIX] Prevent fatal when importing a t3d file without fal information

Currently the importer expects that an imported t3d file contains
data for fal. This is not the case if the t3d file comes from
a TYPO3 4.5 installation.

As a result a fatal error is caused because fread is called with
a length of 0.

Resolves: #60540
Releases: 6.3, 6.2
Change-Id: Ib112200c2b6cba0252440cd370d57a6ccd048bf2
Reviewed-on: http://review.typo3.org/31767
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[FEATURE] Add LogManagerInterface 91/31791/3
Steffen Müller [Fri, 25 Jul 2014 09:03:59 +0000 (11:03 +0200)]
[FEATURE] Add LogManagerInterface

The interface \TYPO3\CMS\Core\Log\LogManagerInterface enables you
to ship an alternative 3rd party LogManager instance.
Having dependency injection in place, you could replace the core
Logger without touching a single line of code.

Releases: 6.3
Resolves: #60551
Change-Id: I2bf125f93599dee9a08e6c6b6fa7c369a7680d8d
Reviewed-on: http://review.typo3.org/31791
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Tested-by: Sascha Egerer <sascha@sascha-egerer.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[TASK] Add wrapper for GeneralUtility::getIndpEnv in ContentObjectRenderer 88/31788/2
Sascha Egerer [Fri, 25 Jul 2014 08:15:35 +0000 (10:15 +0200)]
[TASK] Add wrapper for GeneralUtility::getIndpEnv in ContentObjectRenderer

A wrapper function for GeneralUtility::getIndpEnv() is required
to mock these static calls in unit tests.

Resolves: #60549
Releases: 6.3, 6.2
Change-Id: I47b565f5a5bd9b2445847d38447c01cfa20954c7
Reviewed-on: http://review.typo3.org/31788
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Make call to isPackageKeyValid non-static 49/31749/4
Peter Niederlag [Thu, 24 Jul 2014 10:50:24 +0000 (12:50 +0200)]
[BUGFIX] Make call to isPackageKeyValid non-static

Function isPackagKeyValid on PackageManeger is not a static function
and must be called on an object instance.

Resolves: #59619
Releases: 6.3, 6.2
Change-Id: I03b068db00ccdf76b6e8658721e630b7de6ebfd8
Reviewed-on: http://review.typo3.org/31749
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[BUGFIX] Turn isOnSymmetricSide into static function 48/31748/4
Peter Niederlag [Thu, 24 Jul 2014 10:20:20 +0000 (12:20 +0200)]
[BUGFIX] Turn isOnSymmetricSide into static function

Function isOnSymmetricSide of RelationHandler is used as
static function all the time so we properly turn the function
declaration into a static one.

Resolves: #60516
Releases: 6.3, 6.2
Change-Id: I72a922596e69dca26e173dad5b42da76e0949865
Reviewed-on: http://review.typo3.org/31748
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[TASK] Keep the changes to PackageStates.php low 32/27932/5
Markus Klein [Fri, 28 Feb 2014 10:06:34 +0000 (11:06 +0100)]
[TASK] Keep the changes to PackageStates.php low

Introduce a sort operation of the packages before determining
the loading order.
This way the number of changes made to the PackageStates.php file
are reduced.

This is only a first step, further improvements have to be made
to finally resolve #56362.

Resolves: #56362
Releases: 6.3, 6.2
Change-Id: Id6cc4cc2d3f4d9f00e90f355bdede1afe20f57af
Reviewed-on: http://review.typo3.org/27932
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[BUGFIX] Add label for title of "Edit metadata" link 96/31696/2
Markus Klein [Sun, 20 Jul 2014 15:28:43 +0000 (17:28 +0200)]
[BUGFIX] Add label for title of "Edit metadata" link

Currently the title of the "Edit metadata" link in filelist is
hardcoded. Add a label to make it translatable.

Resolves: #60410
Releases: 6.3, 6.2
Change-Id: Id618dfcd96ae3b4558cf9d529e0cc7c3ae220f9a
Reviewed-on: http://review.typo3.org/31696
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 years ago[TASK] Remove old and unused extension icons from t3skin 40/31040/3
Tymoteusz Motylewski [Sun, 22 Jun 2014 10:16:20 +0000 (12:16 +0200)]
[TASK] Remove old and unused extension icons from t3skin

in t3skin/icons/ext there are plenty of really old icons
for e.g. tt_guest or tt_calender

We should remove them as they are not used.

Resolves: #59792
Releases: 6.3
Change-Id: I8d6a91e2a1c1aa6da04ee2da961c2f6c919de2c3
Reviewed-on: http://review.typo3.org/31040
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[TASK] Remove skipped FAL functional tests 68/31768/2
Christian Kuhn [Thu, 24 Jul 2014 16:02:10 +0000 (18:02 +0200)]
[TASK] Remove skipped FAL functional tests

Utility/File/ExtendedFileUtilityTest.php contains some old FAL
related tests that are not maintained for quite some time, broken
and skipped.
Functional tests for FAL should be re-written if needed from scratch
so these tests are removed for now.

Resolves: #60541
Releases: 6.3, 6.2

Change-Id: Ib703f5c4bbd5d52ef5c67f0fc2f2387772c315fd
Reviewed-on: http://review.typo3.org/31768
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Tested-by: Sascha Egerer <sascha@sascha-egerer.de>
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[CLEANUP] Remove browser hacks in CSS files 59/31759/2
Benjamin Mack [Thu, 24 Jul 2014 13:39:16 +0000 (15:39 +0200)]
[CLEANUP] Remove browser hacks in CSS files

Several browser hacks in backend CSS files
can now be removed as browser don't need
to use -moz or -webkit. Also, several filter
and IE7 star hacks can be removed.

Resolves: #60526
Releases: 6.3
Change-Id: I45aa45a51abe5ab0a6986f1bf0bfd324a23ccd12
Reviewed-on: http://review.typo3.org/31759
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[CLEANUP] Backend: Remove IE7/6/5 support 61/31761/4
Benjamin Mack [Thu, 24 Jul 2014 13:46:13 +0000 (15:46 +0200)]
[CLEANUP] Backend: Remove IE7/6/5 support

There are some places where there is special treatment for IE7
and below which can now be removed safely.

Resolves: #60528
Releases: 6.3
Change-Id: Ic942a499d1663672a6ac80966621010705e755be
Reviewed-on: http://review.typo3.org/31761
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[TASK] Add a "save and close" button in the extensionmanager 83/31083/7
Eric Chavaillaz [Mon, 23 Jun 2014 16:08:17 +0000 (18:08 +0200)]
[TASK] Add a "save and close" button in the extensionmanager

Resolves: #59812
Releases: 6.3, 6.2
Change-Id: I3ccfbdd496af2fca9a72d2675393537eafffd075
Reviewed-on: http://review.typo3.org/31083
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[BUGFIX] Catch freshly introduced ResourceDoesNotExistException 62/31762/3
Anja Leichsenring [Thu, 24 Jul 2014 13:55:29 +0000 (15:55 +0200)]
[BUGFIX] Catch freshly introduced ResourceDoesNotExistException

Change #60506 introduced a new specific exception in case a file
reference can not be resolved. This new exception now needs to be
catched on the right places.

Change-Id: I545f4eb98386918903380cc3d0b34796a0917b3f
Resolves: #60529
Relates: #60506
Releases: 6.3, 6.2
Reviewed-on: http://review.typo3.org/31762
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[BUGFIX] Fix resource exceptions 43/31743/4
Helmut Hummel [Wed, 23 Jul 2014 18:50:56 +0000 (20:50 +0200)]
[BUGFIX] Fix resource exceptions

When rendering the FILES content object,
exceptions due to missing file references and missing collections
are meant to be caught. However they are not, because
InvalidArgumentException and RuntimeException are thrown instead of
ResourceDoesNotExistException

Throw the appropriate exceptions instead and also
fix a wrong check in RecordCollection Repository, where
the return type is checked against NULL while the DB
call returns FALSE when no record is found.

Resolves: #60506
Releases: 6.2, 6.3
Change-Id: I9cea492d814850f75549d280c2de0defc8b91548
Reviewed-on: http://review.typo3.org/31743
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[BUGFIX] Set correct cookie when permalogin is enabled 07/31607/8
Gernot Schulmeister [Mon, 14 Jul 2014 21:17:37 +0000 (23:17 +0200)]
[BUGFIX] Set correct cookie when permalogin is enabled

Although permalogin is enabled we set a session cookie.
This happens because setSessionCookie is called too early
and we do not know yet whether the session should be permanent
and an according cookie shall be set or not.

Solution is to set $this->dontSetCookie = FALSE
which triggers setting the cookie at an appropriate time.

Resolves: #60264
Releases: 6.3, 6.2
Change-Id: Iad5ce8597f90c4a607a43ea4d3368d117fa6b4ed
Reviewed-on: http://review.typo3.org/31607
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Pierrick Caillon <pierrick.caillon@plan-net.fr>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Jan Schreier <jan-hendrik.schreier@bits-iserlohn.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Change sys_file.size type from INT to BIGINT 37/31737/3
Stefan Neufeind [Wed, 23 Jul 2014 11:05:37 +0000 (13:05 +0200)]
[BUGFIX] Change sys_file.size type from INT to BIGINT

Regular INT limits filesize to 2GB.

Change-Id: I525bd53bff6495630bd5880c8ef8789a1d9bbf26
Resolves: #60327
Releases: 6.3, 6.2
Reviewed-on: http://review.typo3.org/31737
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[BUGFIX] Complete datatable structure fe_groups 60/31560/5
Markus Guenther [Thu, 10 Jul 2014 15:24:34 +0000 (17:24 +0200)]
[BUGFIX] Complete datatable structure fe_groups

While creating frontend groups via extbase without any subgroup set,
the record will have the value NULL in the database
for the property subgroup.
This leads to an exception.

This patch only defines TSconfig, subgroups and description not
to accept NULL and to be consistent the tx_extbase_type gets
the default value 0.

Resolves: #60245
Releases: 6.3, 6.2
Change-Id: Ie402d4c47058755efe40cc762f4220ba7dc6b781
Reviewed-on: http://review.typo3.org/31560
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[BUGFIX] Catch all resource exceptions when parsing RTE links 19/31619/3
Helmut Hummel [Mon, 14 Jul 2014 16:00:30 +0000 (18:00 +0200)]
[BUGFIX] Catch all resource exceptions when parsing RTE links

The RteHtmlParser checks for valid links by trying to retrieve
a file or folder object. The FAL API will throw exceptions
if anything goes wrong with the given path.

Catch all these exceptions to ignore the invalid link
and act the same for invalid paths as for not found files/ folders

Releases: 6.2, 6.3
Resolves: #60316
Change-Id: I0752678eb8ed2b596c3a88536d957ec35c172d7b
Reviewed-on: http://review.typo3.org/31619
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
5 years ago[BUGFIX] Wrong sys_refindex for deleted child records 90/31590/3
Oliver Hader [Thu, 10 Jul 2014 16:53:03 +0000 (18:53 +0200)]
[BUGFIX] Wrong sys_refindex for deleted child records

Workspace actions using the DataHandler trigger a reprocessing
of the reference index. However, it happened that index entries
of the live workspace have been deleted or modified.

The reason for that is a missing SQL statement to limit those
actions to the current workspace only.

The result can be seen in e.g. the workspace module after
having deleted an IRRE child record and how the nesting could
not be determined correctly for that particular record.

Resolves: #59874
Releases: 6.2, 6.3
Change-Id: I850e2fe88999ce8db280d4ef426e43c85fff06da
Reviewed-on: https://review.typo3.org/31590
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
5 years ago[BUGFIX] Adjust comment for default HTTP-userAgent 41/31641/2
Stefan Neufeind [Wed, 16 Jul 2014 21:14:06 +0000 (23:14 +0200)]
[BUGFIX] Adjust comment for default HTTP-userAgent

The default userAgent is for example TYPO3/6.2.4

Change-Id: I2412b901a3a42938a433e7d8a414de24587011a3
Resolves: #60365
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31641
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 years ago[TASK] Update wrong copyright header in file BrowseLinks.php 31/31731/2
Michael Schams [Wed, 23 Jul 2014 01:54:56 +0000 (11:54 +1000)]
[TASK] Update wrong copyright header in file BrowseLinks.php

A new header in PHP files has been introduced with #59535. This
patch updates the copyright/license header of one file, which still
uses the old, outdated information.

Resolves: #60482
Releases: 6.3, 6.2
Change-Id: I642a4ce13331e2aadbd362988b963a8a5c576a29
Reviewed-on: https://review.typo3.org/31731
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Fix return value of DatabaseConnection::sql_free_result() 18/31718/3
Stefano Kowalke [Tue, 22 Jul 2014 10:57:50 +0000 (12:57 +0200)]
[BUGFIX] Fix return value of DatabaseConnection::sql_free_result()

In case of success the current implementation returns the result
of $res->free(). Unfortunately free() doesn't return anything.
That causes sql_free_result() to return NULL, which eventually
evaluates to FALSE.

Make sure the return value is correct and
return TRUE in case of success.

Resolves: #60457
Releases: 6.2, 6.3
Change-Id: I8756d4d2a321adc88738b9ac418207c63b312c86
Reviewed-on: https://review.typo3.org/31718
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Fix minor issues in functional testing framework 95/31695/2
Helmut Hummel [Sun, 20 Jul 2014 15:03:22 +0000 (17:03 +0200)]
[BUGFIX] Fix minor issues in functional testing framework

The bootstrap for frontend functional tests has some
minor issues, that are now fixed:

* json_decode returns null not false when not successfull
* Properly set the SERVER_PORT
* Use correct array key in error message
* Avoid notices with relative URLs

Releases: 6.2, 6.3
Resolves: #60413
Change-Id: I3ff07f01729d3403374759edbaa5ddcccd2e889a
Reviewed-on: https://review.typo3.org/31695
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
5 years ago[BUGFIX] sys_collection_entries column too small 71/31571/3
Wouter Wolters [Thu, 10 Jul 2014 18:37:44 +0000 (20:37 +0200)]
[BUGFIX] sys_collection_entries column too small

Set sys_collection_entries to varchar(64). This is the max
table name length on MySQL.

Resolves: #60180
Releases: 6.3,6.2
Change-Id: I253e6eb6cb35db9e6d13a716bfc5c8d89db4ca7e
Reviewed-on: https://review.typo3.org/31571
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Ernesto Baschny <ernst@cron-it.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 years ago[BUGFIX] Avoid PHP warning in TypoScriptFrontendController 72/31472/2
Markus Klein [Mon, 7 Jul 2014 21:05:36 +0000 (23:05 +0200)]
[BUGFIX] Avoid PHP warning in TypoScriptFrontendController

TypoScriptFrontendController throws a PHP warning on access to
$BE_USER->user['uid'] which might not be set.
Fix this by simply adding an empty() check.

Resolves: #60126
Releases: 6.3, 6.2
Change-Id: I7005baf73bce55d862b4b6b61697c2aa0a877c7b
Reviewed-on: https://review.typo3.org/31472
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Marcin Sągol <marcin@soee.pl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 years ago[BUGFIX] Send test email in Install Tool as HTML 78/31578/3
Wouter Wolters [Thu, 10 Jul 2014 19:27:20 +0000 (21:27 +0200)]
[BUGFIX] Send test email in Install Tool as HTML

Explicitly set the format of the email body to text/html.

Resolves: #60251
Releases: 6.3, 6.2
Change-Id: I350b0f4cb9e69cd20dbd439647f56cd9c641b501
Reviewed-on: https://review.typo3.org/31578
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Pascal Dürsteler <pascal.duersteler@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 years ago[BUGFIX] Menu-links generate two empty spaces at closing anchor 22/25322/4
Tomita Militaru [Tue, 12 Nov 2013 15:52:33 +0000 (17:52 +0200)]
[BUGFIX] Menu-links generate two empty spaces at closing anchor

Checks for ATagParams & access key code before adding empty
spaces between anchor parameters.

Resolves: #50566
Releases: 6.3, 6.2, 6.1
Change-Id: I57a2a2a06a97fc1eda6e0438bfdc6e210437e5bb
Reviewed-on: https://review.typo3.org/25322
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 years ago[TASK] Update swiftmailer to 5.2.1 72/31572/3
Wouter Wolters [Thu, 10 Jul 2014 18:54:09 +0000 (20:54 +0200)]
[TASK] Update swiftmailer to 5.2.1

Resolves: #60227
Releases: 6.3
Change-Id: Ic137136005f117ac491cd8897e702f81169a1c0a
Reviewed-on: https://review.typo3.org/31572
Reviewed-by: Michael Bakonyi <m.bakonyi@civit.de>
Tested-by: Michael Bakonyi <m.bakonyi@civit.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 years ago[CLEANUP] Final cleanup of TCA Overrides 21/31621/5
Helmut Hummel [Mon, 14 Jul 2014 22:49:33 +0000 (00:49 +0200)]
[CLEANUP] Final cleanup of TCA Overrides

Some of the files still miss the die statement in
the first line. To be consistent, add it to every
file.

One file had a check for TYPO3_MODE === BE which
is wrong in these files because the result is
cached.

If the first hit with empty cache is done in a FE
request, a wrong result would be cached.

Releases: 6.2, 6.3
Resolves: #60317
Change-Id: I839499100da28ba11d5dcbf81fde87b30b61de81
Reviewed-on: https://review.typo3.org/31621
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@mfc-linz.at>
Tested-by: Markus Klein <klein.t3@mfc-linz.at>
5 years ago[CLEANUP] Reformat IRRE JS code 33/29833/6
Andreas Wolf [Sat, 3 May 2014 16:14:05 +0000 (18:14 +0200)]
[CLEANUP] Reformat IRRE JS code

This is an automatic reformat performed by PhpStorm, to get rid of some
ugly constructs like one-line inline methods.

Change-Id: Id24666c673b3822916f9c5233c0b34ce7d38e7aa
Related: #58475
Releases: 6.3
Reviewed-on: https://review.typo3.org/29833
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
5 years ago[TASK] Extend Regular DataHandler functional tests 41/31141/4
Oliver Hader [Wed, 25 Jun 2014 13:02:24 +0000 (15:02 +0200)]
[TASK] Extend Regular DataHandler functional tests

* add third tt_content element with localization in live context
* add new tt_content delete placeholder in different workspace
* populate changes to all scenarios in live and workspace context

Releases: 6.2, 6.3
Resolves: #59881
Change-Id: I644e264048a5c33c0a613d5f8440975cabd40721
Reviewed-on: https://review.typo3.org/31141
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Use PATH_site in cache identifier for package cache 65/31565/5
Helmut Hummel [Thu, 10 Jul 2014 16:10:10 +0000 (18:10 +0200)]
[BUGFIX] Use PATH_site in cache identifier for package cache

The package cache writes paths to extension directories
(TYPO3_LOADED_EXT) into the cache.

This will result in wrong caches when the same
TYPO3 instance is called from a different absolute
directory e.g. from a different mount or symlink.

To avoid this, the cache identifier now includes
PATH_site which is the current absolute path
of the TYPO3 instance.

Additionally we now only include the modification
time of the package states file instead of the
md5 of the complete content into account, which should
be much faster and also enough.

Resolves: #58288
Releases: 6.2, 6.3
Change-Id: I7c8de41c608beab282f2b8bbeab39f257a9a6a6f
Reviewed-on: https://review.typo3.org/31565
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Clarify exception message for addPlugin() 56/31556/3
Helmut Hummel [Thu, 10 Jul 2014 13:52:52 +0000 (15:52 +0200)]
[TASK] Clarify exception message for addPlugin()

Add verbosity to the exception message to make it
more clear what is going wrong.

Releases: 6.2, 6.3
Resolves: #60225
Change-Id: I7bb4a16ff94d05b8b97633383d42c61aa600b1cf
Reviewed-on: https://review.typo3.org/31556
Reviewed-by: Christian Kuhn
Reviewed-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Christian Kuhn
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Fix page module styling in Languages view 98/31498/4
Tomita Militaru [Tue, 8 Jul 2014 09:44:18 +0000 (12:44 +0300)]
[BUGFIX] Fix page module styling in Languages view

Change in height of table header row for Languages view.

Resolves: #56714
Releases: 6.3, 6.2
Change-Id: Ic6bab8a99695798ecfc115209aec41e241870925
Reviewed-on: https://review.typo3.org/31498
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Collapse icon for accordion not centered in Install Tool 24/31524/2
Wouter Wolters [Tue, 8 Jul 2014 21:24:04 +0000 (23:24 +0200)]
[BUGFIX] Collapse icon for accordion not centered in Install Tool

Resolves: #60192
Releases: 6.3,6.2
Change-Id: I4bacce041ca3be3dce4cae1a7407ab3fdf301ff0
Reviewed-on: https://review.typo3.org/31524
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Sascha Egerer
Tested-by: Sascha Egerer
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Log errors after initial t3d import also if pages are created 01/30101/9
Marc Bastian Heinrichs [Wed, 14 May 2014 10:33:07 +0000 (12:33 +0200)]
[TASK] Log errors after initial t3d import also if pages are created

Errors are only logged if no pages are created on initial data.t3d
import. They should be logged generally.

Resolves: #58798
Releases: 6.3, 6.2
Change-Id: Ia859d12ec567a1b64bb9b65dd41f5ba996de3139
Reviewed-on: https://review.typo3.org/30101
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Followup to CacheBackend patch 20/31520/2
Markus Klein [Tue, 8 Jul 2014 21:00:10 +0000 (23:00 +0200)]
[BUGFIX] Followup to CacheBackend patch

Re-add a missing use statement that vanished during rebase.

Resolves: #59587
Releases: 6.3, 6.2, 6.1
Change-Id: I16ac1b9d5a00c4300202eaef493de43fc988a81d
Reviewed-on: https://review.typo3.org/31520
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Too many tags by identifier in CacheBackends 67/30767/13
Alexander Opitz [Tue, 17 Jun 2014 07:58:32 +0000 (09:58 +0200)]
[BUGFIX] Too many tags by identifier in CacheBackends

This applies to Apc/Memcached/Wincache/Xcache backends.

After an array_merge the values aren't unique. This leads to duplicate
tags per identifier. This patch changes that and also moves the
findTagsByIdentifier call out of the foreach loop.

Resolves: #59587
Releases: 6.3, 6.2, 6.1
Change-Id: Id31e16fa4bba11038ba692a483fb9a33808d95fa
Reviewed-on: https://review.typo3.org/30767
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Fix wrong type hint for emitAfterExtensionT3DImportSignal() 03/31503/3
Markus Klein [Tue, 8 Jul 2014 10:55:07 +0000 (12:55 +0200)]
[BUGFIX] Fix wrong type hint for emitAfterExtensionT3DImportSignal()

Fix a wrong type hint for the second parameter in
InstallUtility::emitAfterExtensionT3DImportSignal(). The parameter is of
type integer and not array.

Resolves: #60179
Releases: 6.3, 6.2
Change-Id: Iccfb7445bd374edaecfd3408380034dbec82e539
Reviewed-on: https://review.typo3.org/31503
Reviewed-by: Wouter Wolters
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Superfluous SQL queries on copying records 10/31310/9
Oliver Hader [Thu, 3 Jul 2014 11:12:20 +0000 (13:12 +0200)]
[BUGFIX] Superfluous SQL queries on copying records

On copying a page in the backend there are lots of superfluous
SQL queries containing "... WHERE uid=0". The reason for that
is, that DataHandler::recordInfo() is called for each field
which then tries to fetch the database record for the given
uid "NEW...". Casting the new record placeholder to an integer
value ends up with the "uid=0" condition.

In a test with copying a page with some sub-pages, there was a
total of about 1300 SQL queries, 300 of them have been those
superfluous "uid=0" SELECT statements.

Change-Id: Ib7006a7ceb52376032df8eaefaa918407718a482
Resolves: #58357
Releases: 6.2, 6.3
Reviewed-on: https://review.typo3.org/31310
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Sascha Egerer
Tested-by: Sascha Egerer
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Followup to read only filemounts 00/31500/2
Helmut Hummel [Tue, 8 Jul 2014 09:57:28 +0000 (11:57 +0200)]
[BUGFIX] Followup to read only filemounts

Fix tests by provide proper mocking of the storage

Resolves: #49391
Resolves: #57979
Releases: 6.2, 6.3
Change-Id: I2cd9e1bcffd082e861a7c8ae2fba6c68b461a8cc
Reviewed-on: https://review.typo3.org/31500
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Re-introduce read-only file mounts 85/30685/19
Lorenz Ulrich [Mon, 23 Jun 2014 13:41:17 +0000 (15:41 +0200)]
[BUGFIX] Re-introduce read-only file mounts

This re-introduces the read-only file mounts that were silently dropped
in TYPO3 6.0.

File mounts can be added by User TSconfig the same way they were added
in TYPO3 4.x. But since FAL added Storages, the storage needs to be
configurable.

options.folderTree.altElementBrowserMountPoints = 3:/test

This adds the folder "test" of storage 3 as read-only mount in the File
List and the Element Browser. The old syntax is still supported:

options.folderTree.altElementBrowserMountPoints = documents

If no storage is configured, it is assumed that the folder is in the
default storage.

Resolves: #49391
Resolves: #57979
Documentation: #59648
Releases: 6.3, 6.2
Change-Id: I648c8ae15d4add98cd55e2f9c27d89d8e49d6152
Reviewed-on: https://review.typo3.org/30685
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Movements pollute colPos value of content elements 01/25001/5
Nicole Cordes [Tue, 8 Jul 2014 07:53:33 +0000 (09:53 +0200)]
[BUGFIX] Movements pollute colPos value of content elements

Due to commit I148ca1b023226f2f99417b3baf238b72346e721f the information
concerning previous and next content elements in one row is messed up.
This patch helps to build information which depends on colPos again and
prevents records being moved to another column.

Resolves: #48939
Resolves: #49055
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I3a15321ee11a1f7d96b58b8b7a5ab14098664b22
Reviewed-on: https://review.typo3.org/25001
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[TASK] Update phpdoc @return of exec_SELECTgetSingleRow() 89/31489/2
Markus Klein [Tue, 8 Jul 2014 08:12:21 +0000 (10:12 +0200)]
[TASK] Update phpdoc @return of exec_SELECTgetSingleRow()

DatabaseConnection::exec_SELECTgetSingleRow() may return FALSE if no row
is found. This is not reflected in the phpdoc for the return value.

This patch adds the necessary information to the doc header.

Resolves: #60172
Releases: 6.3, 6.2
Change-Id: Ia07868c2a1e8fad5b1d53d89ff0a959c2bcf9e3a
Reviewed-on: https://review.typo3.org/31489
Reviewed-by: Thomas Löffler
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Sascha Egerer
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] TCA: handle select renderMode=tree with minitems=1 AND maxitems=1 71/31171/3
Alexander Bigga [Fri, 27 Jun 2014 12:57:39 +0000 (14:57 +0200)]
[BUGFIX] TCA: handle select renderMode=tree with minitems=1 AND maxitems=1

Using the TCA select renderMode=tree with the option
minitems=1 AND maxitems=1
leads to two bugs since TYPO3 4.5:

First #48943
* A new table entry won't mark the field selection as required. The yellow
  question mark is missing and you can save the entry.
* Once you select a checkbox in the tree and unselect it again, the
  required-check is working.

Second: #31637
* You load an existing table entry with a selection of e.g. a category
  which has been hidden or deleted. The selected checkbox won't be shown,
  but the required-check fails.
* Even worse: You can't select another category as the form thinks you
  have already selected one item (maxitem=1). You can fix this only by
  manipulating the database directly.

The reason for these bugs can be found in
DataPreprocessor::renderRecord_selectProc(). For maxitems = 1 the
foreign_table element ids for the tree will be fetched by getDataIdList().
These elements won't be checked whether they are valid (hidden/deleted).
This check is done in selectAddForeign() which is used for maxitems > 1.

The patch uses the same procedure as for maxitems > 1 in case
of renderMode = tree.

Resolves: #48943
Resolves: #31637
Releases: 6.3, 6.2, 6.1
Change-Id: I078ff524ea73951f2121d2c233a46bc2ae562952
Reviewed-on: https://review.typo3.org/31171
Reviewed-by: Wouter Wolters
Reviewed-by: Marcin Sągol
Tested-by: Frans Saris
Reviewed-by: Fabien Udriot
Reviewed-by: Nicole Cordes
Tested-by: Marcin Sągol
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Fix suggest wizard item selection 13/30513/6
Benoit Chenu [Mon, 2 Jun 2014 11:44:36 +0000 (13:44 +0200)]
[BUGFIX] Fix suggest wizard item selection

When selecting an item in a suggest list, the first label is always
taken instead of the clicked one.

Resolves: #55835
Releases: 6.3, 6.2
Change-Id: I7590cb290ee19fd807260ef5767805a23ef088b0
Reviewed-on: https://review.typo3.org/30513
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] LiveSearchToolbarItem not initialized correctly 75/31475/3
Gernot Schulmeister [Mon, 7 Jul 2014 21:33:42 +0000 (23:33 +0200)]
[BUGFIX] LiveSearchToolbarItem not initialized correctly

Initialising the LiveSearchToolbarItem class with two leading
backslashes \\ prevents XClasses of the LiveSearchToolbarItem
to be found by the GeneralUtility:makeInstance() function.

Resolves: #59959
Releases: 6.3, 6.2
Change-Id: Iab6bb31379090fa5770ed20f8fa8113e61071fe0
Reviewed-on: https://review.typo3.org/31475
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Fix position of buttons in RTE full screen mode 74/31474/2
Markus Klein [Mon, 7 Jul 2014 21:20:49 +0000 (23:20 +0200)]
[BUGFIX] Fix position of buttons in RTE full screen mode

Update the HTML markup for the action buttons in the RTE full screen
view to properly position the buttons there.

Releases: 6.3, 6.2
Resolves: #60119
Change-Id: I0c06dd5fa5a7975a3ddcddb58c3b44d41da2192a
Reviewed-on: https://review.typo3.org/31474
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Refactor extension upload controller 50/31250/6
Nicole Cordes [Fri, 4 Jul 2014 22:17:32 +0000 (00:17 +0200)]
[TASK] Refactor extension upload controller

The upload and install functions are needed by the extension coreapi.
In order to support the extension, the UploadExtensionFileController
is refactored and necessary functions are extracted to public functions.

Resolves: #59999
Releases: 6.2, 6.3
Change-Id: I21e734d1ecae2e7c8e7c3f72e129ef1f57532886
Reviewed-on: https://review.typo3.org/31250
Reviewed-by: Stefano Kowalke
Tested-by: Stefano Kowalke
Reviewed-by: Marcin Sągol
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Suggest Wizard: support for PAGE_TSCONFIG_*-values in addWhere 95/26695/7
Julian Hofmann [Wed, 8 Jan 2014 17:22:33 +0000 (18:22 +0100)]
[BUGFIX] Suggest Wizard: support for PAGE_TSCONFIG_*-values in addWhere

Using PAGE_TSCONFIG_*-values in the foreign_table_where-clause limits
the entries. This where clause is also used for the suggest wizard, but
the markers are not replaced there.
PAGE_TSCONFIG_*-values are now supported in the suggest wizard too.

Resolves: #54843
Releases: 6.3, 6.2
Documentation: #60160
Change-Id: Ieb53d48ca0ddf22bbbbc4aed4d1e83220a82ec09
Reviewed-on: https://review.typo3.org/26695
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Move signals to own emit functions 32/31432/2
Nicole Cordes [Mon, 7 Jul 2014 07:49:33 +0000 (09:49 +0200)]
[TASK] Move signals to own emit functions

Two new signals were introduced with the patch
https://review.typo3.org/#/c/27746/. This patch moves the dispatch of
the signals into own functions to improve the tracing of signals.

Resolves: #60133
Releases: 6.3, 6.2
Change-Id: Iecb7ff25ec31556c939dff6b0cf8749ebd3ff997
Reviewed-on: https://review.typo3.org/31432
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Marcin Sągol
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Report migration errors in TceformsUpdateWizard 00/29100/3
Steffen Müller [Wed, 2 Apr 2014 20:38:31 +0000 (22:38 +0200)]
[BUGFIX] Report migration errors in TceformsUpdateWizard

TceformsUpdateWizard should report errors if a migration
failed due to a missing source file.

Resolves: #57575
Releases: 6.3, 6.2
Change-Id: I68af9a5155f7d6190a22cc4986ef4a467b747737
Reviewed-on: https://review.typo3.org/29100
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Detect missing files in empty storage 34/30534/4
Robert Vock [Tue, 3 Jun 2014 11:56:15 +0000 (13:56 +0200)]
[BUGFIX] Detect missing files in empty storage

Improve the check for missing files by properly treating
the case when a storage is empty.

Change-Id: I8fba9be2622a4cd742c0065b68a8daf77f8a484a
Resolves: #54414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/30534
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Frans Saris
Tested-by: Frans Saris
5 years ago[BUGFIX] Wrong image reference handling during flexform copying 84/30884/3
Alexey Gafiulov [Thu, 19 Jun 2014 16:12:42 +0000 (22:12 +0600)]
[BUGFIX] Wrong image reference handling during flexform copying

References in flexforms having type=inline are not processed correctly
during copy.

Fix this by properly applying the reference field check.

Resolves: #59664
Releases: 6.3, 6.2, 6.1
Change-Id: I1abfa001ba420531ca0c59903e82b1509e0819e0
Reviewed-on: https://review.typo3.org/30884
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[FEATURE] Add signal slots to SoftReferenceIndex 46/27746/4
Alexander Stehlik [Mon, 10 Mar 2014 09:42:59 +0000 (10:42 +0100)]
[FEATURE] Add signal slots to SoftReferenceIndex

This patch adds two signal slot dispatch calls to the SoftReferenceIndex
in the getTypoLinkParts() method and the setTypoLinkPartsElement()
methods.

These slots allow third party link handlers to generate their own
soft reference data.

Resolves: #21396
Releases: 6.3, 6.2
Change-Id: If2bbcd1757ed480f31c1bdccd69bba2a77df9a8f
Reviewed-on: https://review.typo3.org/27746
Reviewed-by: Lorenz Ulrich
Tested-by: Lorenz Ulrich
Reviewed-by: Marcin Sągol
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Suggest wizard doesn't work in page flexforms 97/30797/5
Bernhard Kraft [Wed, 18 Jun 2014 08:04:28 +0000 (10:04 +0200)]
[BUGFIX] Suggest wizard doesn't work in page flexforms

When using the suggest wizard from within a flexform in a page it
doesn't work properly. The $row variable was only set when processing
tables other than pages but is required for proper flexform handling.

Change-Id: I0eec29b3c7266bae809e2753cdee726a4c50b1ab
Resolves: #59642
Releases: 6.3, 6.2, 6.1
Reviewed-on: https://review.typo3.org/30797
Reviewed-by: Marcin Sągol
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Remove non-needed URL parameter for standard search 14/25314/3
Tomita Militaru [Tue, 12 Nov 2013 14:57:56 +0000 (16:57 +0200)]
[BUGFIX] Remove non-needed URL parameter for standard search

Removes parameter to prevent duplicate content, speaking
url problems and overloaded urls.

Resolves: #51189
Releases: 6.3, 6.2, 6.1
Change-Id: I076d2f87ac7a1d0d9d831cf3293d060318750c7d
Reviewed-on: https://review.typo3.org/25314
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Optimize invocation of cObj::checkIf 43/26943/5
Oliver Hader [Mon, 20 Jan 2014 15:52:37 +0000 (16:52 +0100)]
[TASK] Optimize invocation of cObj::checkIf

The stdWrap property "if" can be used to allow output only if a
defined criterion is met. However, the checkIf() method gets
called even if the property is not set in TypoScript.

Fix this by adding a quick empty() check to all calls.
Also optimizes the code structure to exit early in case the if
does not evaluate to TRUE.

Resolves: #55173
Releases: 6.3, 6.2
Change-Id: Ie1178a5df2e98fd19b848aa2300c901c1200f555
Reviewed-on: https://review.typo3.org/26943
Reviewed-by: Simon Schaufelberger
Reviewed-by: Stefan Neufeind
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Support dots in page.meta 92/31192/6
Markus Klein [Sat, 28 Jun 2014 14:56:36 +0000 (16:56 +0200)]
[BUGFIX] Support dots in page.meta

The parsing of the meta tag TypoScript configuration does a too greedy
check on dots and hence breaks support for examples like DC.author.

Fix this by completely refactoring the meta tag generation and add unit
tests.

Resolves: #59890
Releases: 6.3, 6.2
Change-Id: Id534efff30903d96aee1677989d1bd6d3dd1644b
Reviewed-on: https://review.typo3.org/31192
Reviewed-by: Fabien Udriot
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Felogin improperly merges flexforms and TS conf 81/31081/4
Markus Klein [Mon, 23 Jun 2014 15:48:28 +0000 (17:48 +0200)]
[BUGFIX] Felogin improperly merges flexforms and TS conf

There are two options to show the forgot password link in FE:
 * TypoScript: showForgotPasswordLink
 * Flexforms: showForgotPassword

The flexform values are merged with the TS values, but as these config
options are named differently, they are not overridden properly.

With #50138 the forgot-form is now only displayed when showForgotPassword
is set, hence the TypoScript configuration is not taken into account.

Since we can neither change the flexform, nor the TypoScript, we need to
merge the values in the flexform-merge code part.

This patch reduces the code to use only the documented TypoScript option.

Resolves: #59821
Releases: 6.3, 6.2
Change-Id: I77c391910561a304649d4c747ec868388be3f1a5
Reviewed-on: https://review.typo3.org/31081
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[CLEANUP] Remove comment header in ext_emconf 05/31405/2
Christian Kuhn [Sun, 6 Jul 2014 16:43:27 +0000 (18:43 +0200)]
[CLEANUP] Remove comment header in ext_emconf

The "do not touch me" comment header in ext_emconf.php files
of system extensions are misleading since we are editing those
files manually for years now. Remove those headers.

Change-Id: I27f6253effa54dae7f92170175e7705cc706d03a
Resolves: #60129
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31405
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[TASK] Travis-ci: Disable apc in PHP 5.3 02/31402/2
Christian Kuhn [Sun, 6 Jul 2014 16:23:19 +0000 (18:23 +0200)]
[TASK] Travis-ci: Disable apc in PHP 5.3

apc on cli seems to be flaky, disable this php module for
now to see if that help stabilizing travis-ci builds again.

Change-Id: I7e6caa6c2c2d70a26e217e8fbf10a2d79b01f335
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31402
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[CLEANUP] ext_emconf files 97/31397/4
Christian Kuhn [Sun, 6 Jul 2014 15:19:31 +0000 (17:19 +0200)]
[CLEANUP] ext_emconf files

Quite some keys in ext_emconf are obsolete and can be removed.
See related issue for a list of keys.

Change-Id: Id12c2e3d61569cc1e84226ef75120ae4261922fb
Resolves: #60128
Related: #58365
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31397
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[CLEANUP] Ensure all variables are set before usage 20/31020/9
Markus Klein [Sun, 22 Jun 2014 00:46:21 +0000 (02:46 +0200)]
[CLEANUP] Ensure all variables are set before usage

This also applies for return values of functions. These are corrected
too if necessary.

Furthermore, some code style updates are done for better readability.

This patch contains no functional changes.

Resolves: #59775
Releases: 6.3, 6.2
Change-Id: I1e26e0516d79324244948caf091cd836d5f8d3c6
Reviewed-on: https://review.typo3.org/31020
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Remove unused EM_CONF variables 46/29746/6
Benjamin Mack [Wed, 30 Apr 2014 13:36:24 +0000 (15:36 +0200)]
[TASK] Remove unused EM_CONF variables

The ext_emconf.php are created when e.g. an extension
is downloaded from TER. Based on the data from TER the
extension information is built, but not needed anymore.

There are some values that are not in use in the current
6.2 system anymore, and just make ext_emconf.php
more complicated, as the current EM only runs with TER2
anyway.

The patch cleans up values when writing ext_emconf.php
for an extension. As soon as only 6.2+ is supported, the
TER could remove the values to be shipped in the
xml.gz files, thus saving resources (not much but I'm in
favor of a clean system).

Releases: 6.2,6.3
Resolves: #58365
Change-Id: Ic15247f57b557971e9a7c608e4dadd2080e976a3
Reviewed-on: https://review.typo3.org/29746
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] ClearCacheOnLoad camelCased does not work 94/31394/2
Susanne Moog [Sun, 6 Jul 2014 15:10:10 +0000 (17:10 +0200)]
[BUGFIX] ClearCacheOnLoad camelCased does not work

The em_conf setting "clearCacheOnLoad" is both used in
camelCase and lower case but only the latter one is
supported by the extension manager.

Change-Id: I637ace3bef07353b7a44c991f79d01da8e8b5547
Fixes: #60127
Releases: 6.2,6.3
Reviewed-on: https://review.typo3.org/31394
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Replace module token in be shortcut returnUrl 86/31386/3
Frans Saris [Sun, 6 Jul 2014 12:34:46 +0000 (14:34 +0200)]
[BUGFIX] Replace module token in be shortcut returnUrl

During the addition of the token check for mod.php the token
in the BE shortcut url was already replaced (#56359) but
not in the returnUrl parameter that can be present.

This patch makes sure that also the module token is replaced in
the returnUrl param.

Resolves: #59963
Releases: 6.3, 6.2
Change-Id: I12b9d6022240d0399825aade21b0879bfbc7eb6c
Reviewed-on: https://review.typo3.org/31386
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Marcin Sągol
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Allow colon in TypoScript key 93/31193/7
Markus Klein [Sat, 28 Jun 2014 15:19:32 +0000 (17:19 +0200)]
[BUGFIX] Allow colon in TypoScript key

The TypoScript parser does not properly parse the := operator.
It searches for : only and hence wrongly breaks a TypoScript key apart.

Fix this by detecting the full operator sequence ":=", do not rely
on ":" only.

Resolves: #59965
Releases: 6.3, 6.2
Change-Id: I6401c87b45432d4d74c4092edeb333d4d9d5914e
Reviewed-on: https://review.typo3.org/31193
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Tested-by: Wouter Wolters
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Page-TSconfig ###PAGE_TSCONFIG_STR### not evaluated correctly 01/20901/4
Wouter Wolters [Sat, 18 May 2013 18:55:23 +0000 (20:55 +0200)]
[BUGFIX] Page-TSconfig ###PAGE_TSCONFIG_STR### not evaluated correctly

Page-TSconfig ###PAGE_TSCONFIG_STR### not evaluated
correctly in the backend.

Change-Id: Ieda08a1df71117b5ac90f2c68260f5171570ff63
Resolves: #16392
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/20901
Reviewed-by: Markus Klein
Tested-by: Markus Klein