Packages/TYPO3.CMS.git
21 months ago[TASK] Cleanup GenericObjectValidatorTest 81/55281/3
Alexander Schnitzler [Fri, 5 Jan 2018 13:52:46 +0000 (14:52 +0100)]
[TASK] Cleanup GenericObjectValidatorTest

- Replace eval with anonymous classes
- Avoid mocks if not necessary

Releases: master
Resolves: #83485
Change-Id: I5c74f905807b082e6b039c29f475c78d05d0fefa
Reviewed-on: https://review.typo3.org/55281
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Reiner Teubner <reiner.teubner@me.com>
Tested-by: Reiner Teubner <reiner.teubner@me.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[TASK] Cleanup StringLengthValidatorTest 77/55277/5
Alexander Schnitzler [Fri, 5 Jan 2018 13:10:42 +0000 (14:10 +0100)]
[TASK] Cleanup StringLengthValidatorTest

- Replace eval with anonymous classes
- Avoid mocks if not necessary

Releases: master
Resolves: #83482
Change-Id: I38a7b5c78ffbe6f1347e70154eb72077916892bc
Reviewed-on: https://review.typo3.org/55277
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Reiner Teubner <reiner.teubner@me.com>
Tested-by: Reiner Teubner <reiner.teubner@me.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[TASK] Cleanup CollectionValidatorTest 83/55283/3
Alexander Schnitzler [Fri, 5 Jan 2018 14:26:08 +0000 (15:26 +0100)]
[TASK] Cleanup CollectionValidatorTest

Replace eval with anonymous classes

Releases: master
Resolves: #83487
Change-Id: Ib09ac0ecf9fe5bf3945b46a403be389d2a9ec84d
Reviewed-on: https://review.typo3.org/55283
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Reiner Teubner <reiner.teubner@me.com>
Tested-by: Reiner Teubner <reiner.teubner@me.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[TASK] Cleanup StringValidatorTest 78/55278/4
Alexander Schnitzler [Fri, 5 Jan 2018 13:22:24 +0000 (14:22 +0100)]
[TASK] Cleanup StringValidatorTest

- Replace eval with anonymous classes
- Avoid mocks if not necessary

Releases: master
Resolves: #83483
Change-Id: Id7fca4bbe43d907378031ce7b8f35ed4a364bcc7
Reviewed-on: https://review.typo3.org/55278
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Reiner Teubner <reiner.teubner@me.com>
Tested-by: Reiner Teubner <reiner.teubner@me.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[TASK] Update doctrine/dbal 2.5.10 ❯ 2.6.3 72/55272/4
Stefan Neufeind [Fri, 5 Jan 2018 08:15:12 +0000 (09:15 +0100)]
[TASK] Update doctrine/dbal 2.5.10 ❯ 2.6.3

Resolves: #83478
Releases: master
Change-Id: Ic7d249deefa4f188c039c2c3f8aa285f4e4effed
Reviewed-on: https://review.typo3.org/55272
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[TASK] Update ckeditor 4.7.3 ❯ 4.8.0 89/55289/3
Frank Naegler [Sat, 6 Jan 2018 12:22:40 +0000 (13:22 +0100)]
[TASK] Update ckeditor 4.7.3 ❯ 4.8.0

Resolves: #83493
Releases: master
Change-Id: I4a44da6fcca7462298b54d236e6aa601971de3b6
Reviewed-on: https://review.typo3.org/55289
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[TASK] Update moment 2.19.2 ❯ 2.20.1 90/55290/3
Frank Naegler [Sat, 6 Jan 2018 12:29:31 +0000 (13:29 +0100)]
[TASK] Update moment 2.19.2 ❯ 2.20.1

Resolves: #83498
Releases: master
Change-Id: I0f58711d5396a5b45269eb3fe609cf718976916f
Reviewed-on: https://review.typo3.org/55290
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
21 months ago[TASK] Update types definitions 86/55286/2
Frank Naegler [Sat, 6 Jan 2018 11:53:43 +0000 (12:53 +0100)]
[TASK] Update types definitions

Resolves: #83491
Releases: master
Change-Id: I7fe75639dfc1a83de5b3fdcfb9dba36d5d9c2c0f
Reviewed-on: https://review.typo3.org/55286
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[TASK] Cleanup AbstractEntityTest 82/55282/2
Alexander Schnitzler [Fri, 5 Jan 2018 14:11:52 +0000 (15:11 +0100)]
[TASK] Cleanup AbstractEntityTest

Replace eval with anonymous classes

Releases: master
Resolves: #83486
Change-Id: Ic90e72f2cec212d44a32aa0ee7767e821c808ecf
Reviewed-on: https://review.typo3.org/55282
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Reiner Teubner <reiner.teubner@me.com>
Tested-by: Reiner Teubner <reiner.teubner@me.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
21 months ago[TASK] Deprecate unneeded RawValidator 94/55294/2
Alexander Schnitzler [Sun, 7 Jan 2018 13:34:48 +0000 (14:34 +0100)]
[TASK] Deprecate unneeded RawValidator

The RawValidator is a useless Validator that is
automatically attached to all method params that
are annotated with "@param mixed".

This is due to the recognition of the pseudo type
"mixed" in ValidatorResolver::getValidatorType which
converts mixed into Raw and which then is responsible
for creating that RawValidator for the param.

However, this is completely useless as the Validator
does not validate. Hence, it will be deprecated and
removed in TYPO3 v10.0 without any replacement.

Releases: master
Resolves: #83503
Change-Id: Id3bc1418224e01983d6a3c13b759d6c8a4f764f3
Reviewed-on: https://review.typo3.org/55294
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Eugene Kenah Djomo <kdeugene@yahoo.fr>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
21 months ago[BUGFIX] Make empty $GLOBALS['TBE_MODULES_EXT'] traversable 74/55274/7
Richard Haeser [Fri, 5 Jan 2018 10:44:01 +0000 (11:44 +0100)]
[BUGFIX] Make empty $GLOBALS['TBE_MODULES_EXT'] traversable

Prevent warnings and notices if $GLOBALS['TBE_MODULES_EXT'] is not
set, which can be the case if no extensions are installed.

Change-Id: I72f513329790ee3b71fd30054574b79f41a6dcf8
Resolves: #83479
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/55274
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
21 months ago[TASK] Update codemirror 5.31.0 ❯ 5.33.0 91/55291/3
Frank Naegler [Sat, 6 Jan 2018 12:41:23 +0000 (13:41 +0100)]
[TASK] Update codemirror 5.31.0 ❯ 5.33.0

Resolves: #83494
Releases: master
Change-Id: I81c813d7a8604ae5c066a491d89e721ebcd599e8
Reviewed-on: https://review.typo3.org/55291
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
21 months ago[TASK] Update imagesloaded 4.1.3 ❯ 4.1.4 88/55288/2
Frank Naegler [Sat, 6 Jan 2018 12:06:47 +0000 (13:06 +0100)]
[TASK] Update imagesloaded 4.1.3 ❯ 4.1.4

Resolves: #83497
Releases: master
Change-Id: I1d22a6934dfdbe5987b5d7da00e357719fab88db
Reviewed-on: https://review.typo3.org/55288
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
21 months ago[TASK] Update d3 4.11.0 ❯ 4.12.2 92/55292/2
Frank Naegler [Sat, 6 Jan 2018 12:48:56 +0000 (13:48 +0100)]
[TASK] Update d3 4.11.0 ❯ 4.12.2

Resolves: #83495
Releases: master
Change-Id: I7313a8ca2fa5a4f7e69255549c0b16c28b997c11
Reviewed-on: https://review.typo3.org/55292
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
21 months ago[TASK] Migrate ContextHelp to TypeScript 69/55169/4
Andreas Fernandez [Tue, 19 Dec 2017 19:46:29 +0000 (20:46 +0100)]
[TASK] Migrate ContextHelp to TypeScript

Resolves: #82579
Releases: master
Change-Id: Ic2d44d8567c2b144f9250f9011b6106fe73358e9
Reviewed-on: https://review.typo3.org/55169
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
21 months ago[BUGFIX] Add missing htmlspecialchars() in ActionTask 19/55119/3
Stephan Großberndt [Sat, 16 Dec 2017 13:20:19 +0000 (14:20 +0100)]
[BUGFIX] Add missing htmlspecialchars() in ActionTask

Add missing htmlspecialchars() calls in
EXT:sys_action/Classes/ActionTask.php

Resolves: #83359
Releases: master, 8.7
Change-Id: Ieda2612762b23783b17f6b4c93c9cfabc149fcb2
Reviewed-on: https://review.typo3.org/55119
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Steffen Kamper <info@sk-typo3.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
21 months ago[TASK] Move changing preview processing config to processing service 10/55210/2
Helmut Hummel [Sun, 24 Dec 2017 14:21:49 +0000 (15:21 +0100)]
[TASK] Move changing preview processing config to processing service

Instead of complementing processing configuration in the file class,
move it to the processing service and LocalPreviewHelper class
to not have the code and logic duplicated and to ensure it is
always executed, not only when using the file API.

Resolves: #83421
Related: #81776
Related: #83242
Releases: master, 8.7, 7.6
Change-Id: I9b3f380625756137a56e7ad0ea55d21f47464ab8
Reviewed-on: https://review.typo3.org/55210
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
21 months ago[FOLLOWUP][TASK] Streamline ExtensionManagementUtility 70/55170/6
Anja Leichsenring [Tue, 19 Dec 2017 20:55:50 +0000 (21:55 +0100)]
[FOLLOWUP][TASK] Streamline ExtensionManagementUtility

Remove a misleading match from the Extension Scanner matcher
configuration that caused a strong match for a false positive.

Also add a forgotten deprecation.

Resolves: #82899
Releases: master
Change-Id: Ibbada6e3f221aed64b98bfccdd3d77502a7cd7d9
Reviewed-on: https://review.typo3.org/55170
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Reiner Teubner <rteubner@me.com>
Tested-by: Reiner Teubner <rteubner@me.com>
Reviewed-by: Sebastian Fischer <typo3@evoweb.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
21 months ago[BUGFIX] Do not try to fetch additionalFields for invalid tasks 22/55122/3
Stephan Großberndt [Sat, 16 Dec 2017 14:57:00 +0000 (15:57 +0100)]
[BUGFIX] Do not try to fetch additionalFields for invalid tasks

A task may be invalid when editing so there is no instance of
AbstractTask in $task. With this patch the SchedulerModuleController no
longer tries to add the additionalFields for that as the
AdditionalFieldProviders expect a valid task object when being called on
edit.

Additionally some cleanup in the PHPDoc of AdditionalFieldProviders is
made to make it clear the given task may be NULL on create.

Resolves: #79141
Releases: master, 8.7
Change-Id: Ia7cf8173e65cfdede89a776cff7615678e4ffb21
Reviewed-on: https://review.typo3.org/55122
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Benjamin Kluge <b.kluge@neusta.de>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[TASK] Raise testing-framework to 2.0.2 65/55265/2
Christian Kuhn [Thu, 4 Jan 2018 12:41:07 +0000 (13:41 +0100)]
[TASK] Raise testing-framework to 2.0.2

Brings an extension configuration patch during
acceptance / functional bootstrap.

Change-Id: Ibebc4a69d4b441ddafe3c7135f240ccf116b6ca9
Resolves: #83467
Releases: master
Reviewed-on: https://review.typo3.org/55265
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[TASK] Migrate DebugConsole to TypeScript 64/55264/2
Andreas Fernandez [Thu, 4 Jan 2018 11:52:25 +0000 (12:52 +0100)]
[TASK] Migrate DebugConsole to TypeScript

The DebugConsole used to render debug messages at the bottom of the TYPO3
backend is migrated to TypeScript.

A feature sneaked in as an easter egg where the icon of the debug panel
changes to a ":|" face on too many message groups has been dropped.

Resolves: #82583
Releases: master
Change-Id: Ied7a3e8f5563fb05029324db87c914ea1ef22953
Reviewed-on: https://review.typo3.org/55264
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Reiner Teubner <rteubner@me.com>
Tested-by: Reiner Teubner <rteubner@me.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[BUGFIX] Add class name to property deprecations 16/55216/4
Benni Mack [Wed, 27 Dec 2017 12:07:27 +0000 (13:07 +0100)]
[BUGFIX] Add class name to property deprecations

Resolves: #83431
Releases: master
Change-Id: I5dbc5649b46b007881717a98458de22b154203ca
Reviewed-on: https://review.typo3.org/55216
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Reiner Teubner <rteubner@me.com>
Tested-by: Reiner Teubner <rteubner@me.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[BUGFIX] EXT:form - use context specific configuration cache 40/55240/2
Ralf Zimmermann [Tue, 2 Jan 2018 11:59:52 +0000 (12:59 +0100)]
[BUGFIX] EXT:form - use context specific configuration cache

Cache the EXT:form configuration depending on the YAML files which
are loaded.

Resolves: #83311
Releases: master,8.7
Change-Id: Ib612e7638f5b5ad0ddc08c17e3d3b1e645967304
Reviewed-on: https://review.typo3.org/55240
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Reiner Teubner <rteubner@me.com>
Tested-by: Reiner Teubner <rteubner@me.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[BUGFIX] Exclude fields without db field from advanced search 53/55253/3
Reiner Teubner [Wed, 3 Jan 2018 16:53:28 +0000 (17:53 +0100)]
[BUGFIX] Exclude fields without db field from advanced search

In advanced search, each field of every table that is listed in TCA
can be used to compose db queries. But if the TCA field has no
counterpart in db, the query fails.
Removing fields that are defined as type user, but without a
defined userfunc are now excluded from view to prevent this kind of
error.

Releases: master, 8.7
Resolves: #83455
Change-Id: Ib35cd7ec54e6c02c77fd85305b6cf3fe1b1979d0
Reviewed-on: https://review.typo3.org/55253
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[TASK] Cleanup setting value $SET 62/55262/4
Reiner Teubner [Thu, 4 Jan 2018 10:58:14 +0000 (11:58 +0100)]
[TASK] Cleanup setting value $SET

For consistent usage the variable $SET was deleted
and replaced with $this->setting.

Resolves: #83466
Releases: master
Change-Id: I6c5174515d430ee829943b457a80f568990a7859
Reviewed-on: https://review.typo3.org/55262
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[BUGFIX] Fix resolving of method validators 44/55244/7
Alexander Schnitzler [Wed, 3 Jan 2018 16:38:30 +0000 (17:38 +0100)]
[BUGFIX] Fix resolving of method validators

This is a regression bugfix. During the ClassSchema refactoring
the resolving of method validators broke due to stripping of
beginning dollar signs from tags.

Releases: master
Resolves: #83425
Change-Id: Ida33ade7bc61c0bb926fbf1895612eac9a94d948
Reviewed-on: https://review.typo3.org/55244
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[BUGFIX] Check permissions for page deletion in context menu 35/55235/2
Tymoteusz Motylewski [Mon, 16 Oct 2017 15:38:11 +0000 (17:38 +0200)]
[BUGFIX] Check permissions for page deletion in context menu

Resolves: #82777
Releases: master, 8.7
Change-Id: I080e9d47053665c51fdc7b46787cd32299bfaba9
Reviewed-on: https://review.typo3.org/55235
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[FEATURE] Make list of fields configurable in Pagetree overview 41/55241/5
Georg Ringer [Tue, 2 Jan 2018 13:41:08 +0000 (14:41 +0100)]
[FEATURE] Make list of fields configurable in Pagetree overview

By using pageTsConfig it is now possible to change the available fields
and add additional entries to the selectbox.

Resolves: #83449
Releases: master
Change-Id: I0985185b3711173387b68f7a3254082faa421476
Reviewed-on: https://review.typo3.org/55241
Reviewed-by: Reiner Teubner <rteubner@me.com>
Tested-by: Reiner Teubner <rteubner@me.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
21 months ago[BUGFIX] Make full search in lowlevel module work again 13/55213/5
Benni Mack [Wed, 27 Dec 2017 10:47:52 +0000 (11:47 +0100)]
[BUGFIX] Make full search in lowlevel module work again

Due to the refactoring the advanced query functionality was broken and not
tested anymore.

The patch minimizes the functionality on the $GLOBALS['SOBE'] code again.

Related: #82729
Resolves: #83428
Releases: master
Change-Id: Ie83fd903aa8051167744e9f20444e5a021a36c75
Reviewed-on: https://review.typo3.org/55213
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Reiner Teubner <rteubner@me.com>
Tested-by: Reiner Teubner <rteubner@me.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
21 months ago[FEATURE] Show the field name for every FormEngine field if debug is enabled 54/55254/4
Georg Ringer [Wed, 3 Jan 2018 19:21:29 +0000 (20:21 +0100)]
[FEATURE] Show the field name for every FormEngine field if debug is enabled

Improve the life of integrators and developers by showing the field name
next to the title.

Resolves: #83461
Releases: master
Change-Id: I100022fb33facefe5f70cf99c2304fb080361427
Reviewed-on: https://review.typo3.org/55254
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
21 months ago[TASK] Update copyright year in documentation to 2018 47/55247/3
Andreas Fernandez [Tue, 2 Jan 2018 21:21:10 +0000 (22:21 +0100)]
[TASK] Update copyright year in documentation to 2018

Resolves: #83453
Releases: master, 8.7, 7.6
Change-Id: I40654f5c230e0e91b3b479dd1c07eb087e639051
Reviewed-on: https://review.typo3.org/55247
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
21 months ago[BUGFIX] Make it possible to add cHash to preview links 64/50264/21
Georg Ringer [Tue, 18 Oct 2016 13:54:39 +0000 (15:54 +0200)]
[BUGFIX] Make it possible to add cHash to preview links

It must be possible to generate preview URLs with a cHash, e.g. to
display records using Extbase which enforces cHash usage.

Introduce a new option "useCacheHash" which triggers cHash calculation.
If not specified, the "no_cache" parameter is added just like before.

Resolves: #78336
Resolves: #81297
Releases: master, 8.7
Change-Id: I225e2b8b4355022e7b4f6866c989b707e526e389
Reviewed-on: https://review.typo3.org/50264
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
21 months ago[TASK] Add section for translated pages to lowlevel statistics page 29/55229/3
Anja [Fri, 29 Dec 2017 08:44:59 +0000 (09:44 +0100)]
[TASK] Add section for translated pages to lowlevel statistics page

Since table pages holds both default language and translated records,
the statistics don't add up anymore.
By introducing a dedicated value count for translated pages, the
sums are equal with the page tree again.

Resolves: #83444
Releases: master
Change-Id: Ice6edde88a15e9590a86ced78565b180d2546ab7
Reviewed-on: https://review.typo3.org/55229
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
21 months ago[BUGFIX] Correct permissions for root page setting up empty site 36/55136/2
Stephan Großberndt [Sun, 17 Dec 2017 13:14:11 +0000 (14:14 +0100)]
[BUGFIX] Correct permissions for root page setting up empty site

Use the correct maximal permission "31" for the root page when setting
up an empty site during the installation process instead of "32" which
leads to non-editable permissions for that page even by an admin.

Resolves: #83369
Releases: master, 8.7, 7.6
Change-Id: I092f32b48c2a6deb79727fd6a1f8730829161287
Reviewed-on: https://review.typo3.org/55136
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Reiner Teubner <rteubner@me.com>
Tested-by: Reiner Teubner <rteubner@me.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
21 months ago[FOLLOWUP][BUGFIX] Add missing htmlspecialchars() and cleanup in DebuggerUtility 42/55242/2
Stephan Großberndt [Tue, 2 Jan 2018 13:49:33 +0000 (14:49 +0100)]
[FOLLOWUP][BUGFIX] Add missing htmlspecialchars() and cleanup in DebuggerUtility

Add missing htmlspecialchars() calls in
EXT:extbase/Classes/Utility/DebuggerUtility.php and cleanup indents in
collections.

Resolves: #83450
Related: #83356
Releases: master
Change-Id: I85a82b7c88e91173485938e95436bad8677694c6
Reviewed-on: https://review.typo3.org/55242
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
21 months ago[BUGFIX] Don’t show deprecations as "success" flash messages 02/55202/2
Andreas Wolf [Fri, 22 Dec 2017 16:06:52 +0000 (17:06 +0100)]
[BUGFIX] Don’t show deprecations as "success" flash messages

Change-Id: I48eba81412e314bb8ee013ef38ecbdb32a14ed96
Resolves: #83416
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55202
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Reiner Teubner <rteubner@me.com>
Tested-by: Reiner Teubner <rteubner@me.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
21 months ago[BUGFIX] Add support for PNG icons of the SVG Tree 92/55192/3
Benni Mack [Thu, 21 Dec 2017 16:31:34 +0000 (17:31 +0100)]
[BUGFIX] Add support for PNG icons of the SVG Tree

When the pagetree (base on SVG tree) is having a custom icon based on a PNG
like a custom page tree icon, then the SVG tree does not show anything.

The patch fixes the SVG tree to support rendering of PNG icons.

Resolves: #83410
Releases: master
Change-Id: Ifdcc827bc073da4b8eabcc209d03ce55d8f0c94f
Reviewed-on: https://review.typo3.org/55192
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
21 months ago[BUGFIX] Fix PHP 7.2 issues in EXT:lowlevel 06/55206/4
Georg Ringer [Sun, 24 Dec 2017 08:58:08 +0000 (09:58 +0100)]
[BUGFIX] Fix PHP 7.2 issues in EXT:lowlevel

Resolves: #83409
Releases: master, 8.7, 7.6
Change-Id: I94a3a3ad31de6e4969d5456f12b728c98adf0815
Reviewed-on: https://review.typo3.org/55206
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
21 months ago[FEATURE] Introduce Feature Toggles 29/54529/7
Benni Mack [Thu, 2 Nov 2017 10:46:40 +0000 (11:46 +0100)]
[FEATURE] Introduce Feature Toggles

A new API class "Features" allows to check if a feature is enabled/disabled
for a certain installation.

This API method can be used to have admins switch to new features explicitly
or disable legacy functionality.

Examples for using the feature toggles in the future:
- Do not load TCA for pages_language_overlay after DB migration
- Do not parse HTML for legacy <link> tag anymore
- Explicitly enable new Logging API in DataHandler (skipping sys_log calls)

Resolves: #83429
Releases: master
Change-Id: I5da8f66e593e311c83fefe5fe9edb503a885943b
Reviewed-on: https://review.typo3.org/54529
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
21 months ago[CLEANUP] Review comment and sig of checkRootlineForIncludeSection() 95/52895/8
Elmar Hinz [Mon, 22 May 2017 09:54:41 +0000 (11:54 +0200)]
[CLEANUP] Review comment and sig of checkRootlineForIncludeSection()

Reviews the comments and signatures of:

TypoScriptFrontendController::checkRootlineForIncludeSection()
TypoScriptFrontendController::checkPagerecordForIncludeSection()

Casts the return values to bool.

Resolves: #81280
Releases: master
Change-Id: I9344e2f3bcfeed12af7e51e0a50b07631eb1d33f
Reviewed-on: https://review.typo3.org/52895
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
21 months ago[TASK] Code cleanup in DataHandler 76/54876/4
Wouter Wolters [Wed, 29 Nov 2017 19:39:32 +0000 (20:39 +0100)]
[TASK] Code cleanup in DataHandler

Fix some IDE warnings in DataHandler class.

Resolves: #83170
Releases: master
Change-Id: I789ba23d2ff7fd9d1f96e7e9110c7be125f4de6e
Reviewed-on: https://review.typo3.org/54876
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
21 months ago[TASK] Use null coalescing operator where possible 10/54810/8
Wouter Wolters [Thu, 30 Nov 2017 21:16:13 +0000 (22:16 +0100)]
[TASK] Use null coalescing operator where possible

Using null coalescing operator in PHP 7 simplifies code structure.

Resolves: #83129
Releases: master
Change-Id: I449415c99ccb0ea158d3943800bc824514f7629c
Reviewed-on: https://review.typo3.org/54810
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
21 months ago[TASK] Remove unused PHP class imports 17/55217/3
Benni Mack [Wed, 27 Dec 2017 12:33:00 +0000 (13:33 +0100)]
[TASK] Remove unused PHP class imports

Some PHP classes still contain unused use statements. They have been removed.

Thanks to @cd on his initial patch
https://review.typo3.org/52014/

Resolves: 83432
Releases: master
Change-Id: I9020f505a826c40fcf11f75f87245293e7c6154f
Reviewed-on: https://review.typo3.org/55217
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
21 months ago[BUGFIX] Add missing htmlspecialchars() and cleanup in EXT:recordlist 17/55117/2
Stephan Großberndt [Sat, 16 Dec 2017 13:10:40 +0000 (14:10 +0100)]
[BUGFIX] Add missing htmlspecialchars() and cleanup in EXT:recordlist

Add missing htmlspecialchars() calls in EXT:recordlist and do cleanup.

Resolves: #83358
Releases: master, 8.7
Change-Id: If441da15bd0b37ca94121b3787457dddde9380bf
Reviewed-on: https://review.typo3.org/55117
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
21 months ago[FOLLOWUP][TASK] Remove ExtJS-related assets 11/55211/2
Benni Mack [Wed, 27 Dec 2017 06:43:58 +0000 (07:43 +0100)]
[FOLLOWUP][TASK] Remove ExtJS-related assets

Now unreferenced icons and CSS files have been forgotten to be removed.

Relates: #68075
Resolves: #83427
Releases: master
Change-Id: I96416220f56c8394104bd626f16e6215c651e8a8
Reviewed-on: https://review.typo3.org/55211
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
21 months ago[TASK] Remove reference to not existing labels 85/55185/2
Georg Ringer [Thu, 21 Dec 2017 06:41:46 +0000 (07:41 +0100)]
[TASK] Remove reference to not existing labels

As the labels don't exist, the usage can be dropped.

Resolves: #83388
Releases: master, 8.7
Change-Id: I43442a847f0705decbddf09139cfdb243ee0d099
Reviewed-on: https://review.typo3.org/55185
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
21 months ago[BUGFIX] get count consistent with execute for self written statements 44/54844/4
Sebastian Hofer [Tue, 28 Nov 2017 21:31:34 +0000 (22:31 +0100)]
[BUGFIX] get count consistent with execute for self written statements

Fix wrong result for self written sql statements executing count
on the query result.

To get this consistent, check for statement also in
getObjectCountByQuery and run getObjectDataByQuery
for self written statements. After that count the
rows.

Wrapping the statement in a subselect will
may be break doLanguageAndWorkspaceOverlay
in getObjectDataByQuery.

This is just to be consistent. Normally it does not
make sense to call the count method on a self written
statement.

Releases: master, 8.7
Resolves: #82910
Change-Id: I8bddb1b20d062d9f46939c16885f1eb73df1e5f4
Reviewed-on: https://review.typo3.org/54844
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
21 months ago[BUGFIX] Catch InvalidPathException in BE & FE 24/55024/7
Georg Ringer [Mon, 11 Dec 2017 10:09:46 +0000 (11:09 +0100)]
[BUGFIX] Catch InvalidPathException in BE & FE

Catch invalid links in FE & BE to keep a working
website.

Resolves: #83283
Releases: master, 8.7
Change-Id: Id9e42dc9be896f3777210843c651f9726dc94552
Reviewed-on: https://review.typo3.org/55024
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
21 months ago[BUGFIX] Add missing htmlspecialchars() and cleanup in DebuggerUtility 15/55115/2
Stephan Großberndt [Sat, 16 Dec 2017 12:56:52 +0000 (13:56 +0100)]
[BUGFIX] Add missing htmlspecialchars() and cleanup in DebuggerUtility

Add missing htmlspecialchars() calls in
EXT:extbase/Classes/Utility/DebuggerUtility.php and cleanup indents in
collections.

Resolves: #83356
Releases: master
Change-Id: I03eae07be66bbfb9b5b605359666857e56beba83
Reviewed-on: https://review.typo3.org/55115
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
21 months ago[BUGFIX] Change deprecation of language:update command 05/55205/3
Helmut Hummel [Sun, 24 Dec 2017 00:24:09 +0000 (01:24 +0100)]
[BUGFIX] Change deprecation of language:update command

Keep the nice and concise name instead of the long and clumsy name.
Also set an alias instead of registering the command twice.

Releases: master
Resolves: #82315
Change-Id: I302977702e2d09f1377f078af2f8b60f515cce1e
Reviewed-on: https://review.typo3.org/55205
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Benni Mack <benni@typo3.org>
21 months ago[TASK] Decouple Indexed Search from TSFE-BE User 54/55154/2
Benni Mack [Mon, 18 Dec 2017 20:11:14 +0000 (21:11 +0100)]
[TASK] Decouple Indexed Search from TSFE-BE User

Indexed Search is using an instance of TSFE-BE
to fetch all subpages of a page, which can
easily be implemented itself.

The method is refactored and adapted to its needs
within AdministrationRepository of Indexed Search.

Resolves: #83382
Releases: master
Change-Id: Iaa71c4dc04d69c0ca0d7bb61f2f36f4a93a4c11d
Reviewed-on: https://review.typo3.org/55154
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
21 months ago[TASK] Changelog docs: Review and add tags 82/55182/2
Christian Kuhn [Wed, 20 Dec 2017 19:34:47 +0000 (20:34 +0100)]
[TASK] Changelog docs: Review and add tags

* Add tags of all v7 Changelog files
* Review existing tags of all v8 & v9 Changelog files
* Minor .rst reformattings and fixes

Change-Id: I4761a1d8028feca5de30a3f860fd5f01bbdd42d1
Resolves: #83402
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/55182
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Use `new` in ReflectionServiceTest 64/55164/4
Andreas Fernandez [Tue, 19 Dec 2017 18:09:17 +0000 (19:09 +0100)]
[BUGFIX] Use `new` in ReflectionServiceTest

Resolves: #83390
Releases: master
Change-Id: I1883a855ae818295eec9cd8b4ae2baeb93eff05c
Reviewed-on: https://review.typo3.org/55164
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Sebastian Fischer <typo3@evoweb.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
22 months ago[BUGFIX] Only select current file when editing metadata 25/55125/3
Stephan Großberndt [Sat, 16 Dec 2017 17:08:46 +0000 (18:08 +0100)]
[BUGFIX] Only select current file when editing metadata

Only select the current file connected to the metadata when editing the
metadata of a file.

Resolves: #78845
Releases: master, 8.7, 7.6
Change-Id: Ib65b1e1aaae1fa2c93b03e4865582841a28990a6
Reviewed-on: https://review.typo3.org/55125
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Sascha Nowak <sascha.nowak@netlogix.de>
Tested-by: Sascha Nowak <sascha.nowak@netlogix.de>
Reviewed-by: Torben Hansen <derhansen@gmail.com>
Tested-by: Torben Hansen <derhansen@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
22 months ago[BUGFIX] Replace /s JS regex flag(modifier) with [/s/S] 57/55157/2
Tymoteusz Motylewski [Tue, 19 Dec 2017 09:18:20 +0000 (10:18 +0100)]
[BUGFIX] Replace /s JS regex flag(modifier) with [/s/S]

to match all characters including new line.

Resolves: #83385
Releases: master
Change-Id: I5c36550ddf3503f16006800d417c819d47af7fc4
Reviewed-on: https://review.typo3.org/55157
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nils Seinschedt <n.seinschedt@neusta.de>
Reviewed-by: Benjamin Kluge <b.kluge@neusta.de>
Tested-by: Benjamin Kluge <b.kluge@neusta.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
22 months ago[BUGFIX] Use correct path and add missing labels in TCA of extensionmanager 49/55149/2
Stephan Großberndt [Mon, 18 Dec 2017 15:06:02 +0000 (16:06 +0100)]
[BUGFIX] Use correct path and add missing labels in TCA of extensionmanager

Releases: master, 8.7, 7.6
Resolves: #83375
Change-Id: Id998c9fb688b8dcd41f09a0b863f87e8290adb2a
Reviewed-on: https://review.typo3.org/55149
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
22 months ago[FEATURE] Add ArrayUtility::filterRecursive() method 06/55106/14
Stefan Neufeind [Sat, 16 Dec 2017 10:08:04 +0000 (11:08 +0100)]
[FEATURE] Add ArrayUtility::filterRecursive() method

Add a new method ArrayUtility::filterRecursive() as an
enhancement to the PHP function array_filter() to filter
nested arrays.

Resolves: #83350
Releases: master
Change-Id: If291f1695eeef934ddf858ad28c54b30185e8bbc
Reviewed-on: https://review.typo3.org/55106
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Benjamin Kluge <b.kluge@neusta.de>
22 months ago[FOLLOWUP][TASK] Adjust size of new content element wizard 60/55160/2
Georg Ringer [Tue, 19 Dec 2017 13:33:35 +0000 (14:33 +0100)]
[FOLLOWUP][TASK] Adjust size of new content element wizard

Resolves: #83282
Releases: master
Change-Id: I7899cfc9c3a98b41798d64d42f0aff9f02bea6c3
Reviewed-on: https://review.typo3.org/55160
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
22 months ago[BUGFIX] Changelog install tool: Duplicate ids prevent expand 48/55148/2
Christian Kuhn [Mon, 18 Dec 2017 15:11:55 +0000 (16:11 +0100)]
[BUGFIX] Changelog install tool: Duplicate ids prevent expand

Expand / collapse sections need a unique id to be properly
collapsible. The "Changelog documentation viewer" uses the
forge issue number for this, which is not unique.
The patch changes the id to use a prefix per version / section
and the loop interation index.

Change-Id: I350d404c61b989deab34bf517e2890e567cb3172
Resolves: #83376
Release: master, 8.7
Reviewed-on: https://review.typo3.org/55148
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
22 months ago[CLEANUP] Use Permission constants consistently 56/55156/4
Benni Mack [Mon, 18 Dec 2017 20:27:38 +0000 (21:27 +0100)]
[CLEANUP] Use Permission constants consistently

Instead of integers, the permission constants
should be used throughout the TYPO3 Core.

Resolves: #83383
Releases: master
Change-Id: I00c10f97fc800d9533866c98284bbd22cd1bb575
Reviewed-on: https://review.typo3.org/55156
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
22 months ago[BUGFIX] Add missing labels in EXT:lang and EXT:indexed_search 53/55153/2
Stephan Großberndt [Mon, 18 Dec 2017 16:21:10 +0000 (17:21 +0100)]
[BUGFIX] Add missing labels in EXT:lang and EXT:indexed_search

Releases: master, 8.7
Resolves: #83381
Change-Id: Ide90a5a2fc3b5aa7223f6d547e4a0020b751bbe8
Reviewed-on: https://review.typo3.org/55153
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
22 months ago[CLEANUP] Review comment and sig of getSubpagesForPages() 75/52875/8
Benni Mack [Mon, 18 Dec 2017 19:37:03 +0000 (20:37 +0100)]
[CLEANUP] Review comment and sig of getSubpagesForPages()

Releases: master
Resolves: #81280
Change-Id: I7239895099f56b591daf6433ef4daad0dc1c4048
Reviewed-on: https://review.typo3.org/52875
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
22 months ago[BUGFIX] Remove deprecated annotation usage in sys_note 91/55091/2
Georg Ringer [Fri, 15 Dec 2017 07:31:18 +0000 (08:31 +0100)]
[BUGFIX] Remove deprecated annotation usage in sys_note

Resolves: #83337
Releases: master
Change-Id: I533ea2cce63aaefdf5e7b54c9d23103b44e187b0
Reviewed-on: https://review.typo3.org/55091
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
22 months ago[BUGFIX] Use integers in TCA definitions 52/55152/2
Stephan Großberndt [Mon, 18 Dec 2017 16:18:27 +0000 (17:18 +0100)]
[BUGFIX] Use integers in TCA definitions

Releases: master
Resolves: #83380
Change-Id: Ic90db1b6ee239841586ab100be6d8d312a94e859
Reviewed-on: https://review.typo3.org/55152
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
22 months ago[TASK] Remove excess whitespace 51/55151/2
Stephan Großberndt [Mon, 18 Dec 2017 16:12:31 +0000 (17:12 +0100)]
[TASK] Remove excess whitespace

Releases: master
Resolves: #83378
Change-Id: I78d79402a5fa344934ba83feb4c9dbfe126f0261
Reviewed-on: https://review.typo3.org/55151
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
22 months ago[BUGFIX] Get the correct crop configuration for imgResource 17/53717/17
Wolfgang Klinger [Thu, 17 Aug 2017 09:34:30 +0000 (11:34 +0200)]
[BUGFIX] Get the correct crop configuration for imgResource

This fix returns the right ImageManipulation\Area object
in case the imgResource "crop" value is a json string with variants.

Resolves: #82057
Releases: master, 8.7
Change-Id: Ibfc9f33ffc060992f22c1a3c7326990834f02ec4
Reviewed-on: https://review.typo3.org/53717
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
22 months ago[BUGFIX] Make JS url encoding utf aware 44/55144/2
Markus Klein [Mon, 18 Dec 2017 09:32:39 +0000 (10:32 +0100)]
[BUGFIX] Make JS url encoding utf aware

Replace the deprecated function JS `escape` with `encodeURIComponent`.

Releases: master, 8.7
Resolves: #83341
Change-Id: Ia9fdd44c7b06f63ab867f692e07193ab23f535a3
Reviewed-on: https://review.typo3.org/55144
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Huf <huf.daniel@gmail.com>
Tested-by: Daniel Huf <huf.daniel@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
22 months ago[TASK] Changelog docs: Update Howto.rst 39/55139/3
Christian Kuhn [Sun, 17 Dec 2017 16:23:47 +0000 (17:23 +0100)]
[TASK] Changelog docs: Update Howto.rst

Add more .rst file location information to the Changelog
"Documenting Changes" Howto.rst.
Also add missing Index.rst entries for 8.7.x/ files.

Change-Id: Ie68e5eb59f080537050717106bf549dc6d4a0ef3
Resolves: #83371
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/55139
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] v8 Changelog: Move post 8.7.0 files into 8.7.x folder 38/55138/3
Christian Kuhn [Sun, 17 Dec 2017 14:23:16 +0000 (15:23 +0100)]
[TASK] v8 Changelog: Move post 8.7.0 files into 8.7.x folder

Changelog files that have been merged into core v8 branch
after LTS release 8.7.0 are moved out of 8.7 folder into
8.7.x folder - same system we use with v7.

Change-Id: I0f7a2ddce23eaec997f5ee3c2632af06fa371874
Releases: master, 8.7
Resolves: #83370
Reviewed-on: https://review.typo3.org/55138
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] change TYPO3 version in INSTALL.md 32/55132/2
Philippe Court [Sat, 16 Dec 2017 21:49:07 +0000 (22:49 +0100)]
[TASK] change TYPO3 version in INSTALL.md

change TYPO3 version in INSTALL.md to v9

Releases: master
Resolves: #83368
Change-Id: I422449e7a114cc698b7fab73bbae70f5ebab8116
Reviewed-on: https://review.typo3.org/55132
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] Changelog docs: Re-add v7 files into v8 & master 27/55127/3
Christian Kuhn [Sat, 16 Dec 2017 17:52:49 +0000 (18:52 +0100)]
[TASK] Changelog docs: Re-add v7 files into v8 & master

As proposed in
https://decisions.typo3.org/t/core-changelog-documentation-workflow-revised
the v7 Changelog files are merged back into v8 and master.

Change-Id: I83b238aa24c5cfb2b3bf5450f178b438a84f3618
Resolves: #83363
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55127
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] CGL fix core after php-cs-fixer 2.9.0 raise 21/55121/4
Christian Kuhn [Sat, 16 Dec 2017 14:32:27 +0000 (15:32 +0100)]
[TASK] CGL fix core after php-cs-fixer 2.9.0 raise

The "self_accessor" fixer is more strict with younger
php-cs-fixer releases and changes method argument type
hints to self if a class object of the same class is
expected. It also changes return type hints to self
in this case.
This fixer now may collide with the "xclass" system
of the core and is thus deactivated. We shoud decide
manually if self or class name is used.

Change-Id: I3a8c20bea1d79ac2c7bc1e9ecbc2d435c4047843
Resolves: #83360
Related: #83331
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55121
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
22 months ago[FOLLOWUP][TASK] Remove column sys_file_reference.sorting 07/55107/3
Oliver Hader [Sat, 16 Dec 2017 10:23:37 +0000 (11:23 +0100)]
[FOLLOWUP][TASK] Remove column sys_file_reference.sorting

Table sys_file_reference is used as "inline 1:n foreign_field" composite
assiciation and is processed in RelationHandler methods readForeignField
and writeForeignField. Albeit it looks like an MM table it still is a
regular TCA table being used as an entity with further attributes.

That's why this follow-up reverts the changes in file RelationHandler.php
that have been introduced in 728bfc194f46651ac70725d8aa6b476dac777765.

Related: #83160
Releases: master
Change-Id: I4b7a78a0ee494af9492996e81c2b631c29832cc6
Reviewed-on: https://review.typo3.org/55107
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
22 months ago[TASK] Update Breaking-82878-RemovedFieldNoCacheInDatabaseTablePages.rst 95/55095/3
Tizian Schmidlin [Fri, 15 Dec 2017 15:47:11 +0000 (16:47 +0100)]
[TASK] Update Breaking-82878-RemovedFieldNoCacheInDatabaseTablePages.rst

Add SQL to execute to check if the change affects the system or not.

Releases: master
Resolves: #83343
Change-Id: I255af9e14d49bae5256ce90a267075b7cc28ce4b
Reviewed-on: https://review.typo3.org/55095
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] indexed_search docs: specialConfiguration instead of specConfs 92/55092/3
Roman Abt [Fri, 15 Dec 2017 12:01:08 +0000 (13:01 +0100)]
[TASK] indexed_search docs: specialConfiguration instead of specConfs

Document working typoscript key 'specialConfiguration' instead
of 'specConfs'.

Releases: master
Resolves: #83340
Change-Id: I4d2c0606200f5bcaf991b53fb67e2709a9c45bc5
Reviewed-on: https://review.typo3.org/55092
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
22 months ago[TASK] Update INSTALL.md 94/55094/2
Tizian Schmidlin [Fri, 15 Dec 2017 15:09:18 +0000 (16:09 +0100)]
[TASK] Update INSTALL.md

Replace references to TYPO3 8 by references to TYPO3 9

Releases: master
Resolves: #83342
Change-Id: I6204e550207f5db63b48390e90b38456ad71a024
Reviewed-on: https://review.typo3.org/55094
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] Update Breaking-82421-DroppedOldDBRelatedConfigurationOptions.rst 96/55096/2
Tizian Schmidlin [Fri, 15 Dec 2017 15:50:13 +0000 (16:50 +0100)]
[TASK] Update Breaking-82421-DroppedOldDBRelatedConfigurationOptions.rst

Releases: master
Resolves: #83344
Change-Id: I5653312697a2568b8b0937e96a315ed08068957d
Reviewed-on: https://review.typo3.org/55096
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Change behavior of new element during drag & drop into node 61/55061/7
Tymoteusz Motylewski [Wed, 13 Dec 2017 14:32:07 +0000 (15:32 +0100)]
[BUGFIX] Change behavior of new element during drag & drop into node

- place input correctly
- open node with children while holding the mouse over
this node for one second (when drag-adding new node)
- add chevron and expand it when adding first child
- refactor node.open to node.expand because they did the same thing
- show icons for custom doktypes (fix regex)

Releases: master
Resolves: #83306
Change-Id: I0255fa50f836d002392ed7791eed1ac3517cb400
Reviewed-on: https://review.typo3.org/55061
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
22 months ago[TASK] Raise ext:styleguide extension versions 12/55112/4
Oliver Hader [Sat, 16 Dec 2017 12:42:30 +0000 (13:42 +0100)]
[TASK] Raise ext:styleguide extension versions

Raise ext:styleguide extension versions to
* 9.0.1
* 8.0.14

The styleguide extensions uses and invalid configuration for FAL
references using the table sys_file_reference as MM table - the
regular use case is to use that as 1:n foreign_field composite
assiciation. In a result the example in the styleguide extension
mixed the meaning and behavior of both fields uid_local and
uid_foreign.

Resolves: #83355
Releases: master, 8.7
Change-Id: I203b468b4a06e3196a98e2c5de1ba06419a65636
Reviewed-on: https://review.typo3.org/55112
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
22 months ago[BUGFIX] AdminPanelView tries to count null value 97/55097/3
Oliver Hader [Fri, 15 Dec 2017 15:58:03 +0000 (16:58 +0100)]
[BUGFIX] AdminPanelView tries to count null value

Resolves: #83345
Releases: master, 8.7, 7.6
Change-Id: I49e0de26154430c8a93c6a25a7fa54d5e49be39d
Reviewed-on: https://review.typo3.org/55097
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
22 months ago[BUGFIX] Add editor permissions to pagetree 99/55099/2
Susanne Moog [Fri, 15 Dec 2017 17:05:11 +0000 (18:05 +0100)]
[BUGFIX] Add editor permissions to pagetree

The new pagetree repository implementation
did not check editor permissions and disallowed
any edit / show action for non-admins.

The fields to check permissions have been added.

Change-Id: I827d4b50302ee4d6c3268c44b43f93fa9ef0c870
Resolves: #83347
Releases: master
Reviewed-on: https://review.typo3.org/55099
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
22 months ago[TASK] Use hash_equals for timing-safe comparison of hash-values 74/55074/5
Stefan Neufeind [Thu, 14 Dec 2017 13:51:32 +0000 (14:51 +0100)]
[TASK] Use hash_equals for timing-safe comparison of hash-values

To prevent timing-attacks on hash-comparions it is advised
to use hash_equals.

Resolves: #83329
Releases: master, 8.7
Change-Id: I7539ed27538d7d81767bfce582d568cff09d1610
Reviewed-on: https://review.typo3.org/55074
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
22 months ago[TASK] EXT:scheduler: Last old image and cli_dispatch 88/55088/3
Michael Oehlhof [Thu, 14 Dec 2017 23:48:02 +0000 (00:48 +0100)]
[TASK] EXT:scheduler: Last old image and cli_dispatch

Exchanged the old BackendModuleMainView image and correct the examples
for the command line call.

Resolves: #83336
Releases: master
Change-Id: I53844f5bef4a5b52be58dc14d1fc260b7a97d775
Reviewed-on: https://review.typo3.org/55088
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
22 months ago[BUGFIX] Make sure that foreach loops are applied to arrays only 66/55066/6
Wolfgang Klinger [Thu, 14 Dec 2017 10:33:53 +0000 (11:33 +0100)]
[BUGFIX] Make sure that foreach loops are applied to arrays only

Fix some foreach loops so as not to run into potentially empty elements.
Use the ?? operator to accomplish that.

Change-Id: Id6306cea0546dfd4a20ba98c170335966cc2ae40
Resolves: #83322
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55066
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] Script to check doc comments for invalid annotations 90/54790/11
Alexander Schnitzler [Mon, 27 Nov 2017 13:16:36 +0000 (14:16 +0100)]
[TASK] Script to check doc comments for invalid annotations

To prevent the introduction of further invalid
php doc annotations a build script should scan
all php files and report the usage of invalid
annotations.

Releases: master
Resolves: #83115
Change-Id: I56cc64ef43037c6c55f5337d07cf722a1927865c
Reviewed-on: https://review.typo3.org/54790
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Replace PHP 7.2 deprecated each() 64/55064/6
Patrick Schriner [Thu, 14 Dec 2017 09:19:51 +0000 (10:19 +0100)]
[BUGFIX] Replace PHP 7.2 deprecated each()

each() is deprecated in PHP 7.2 and has to be replaced.

Resolves: #83321
Releases: master, 8.7, 7.6
Change-Id: Ic318b50a9921cd6a55435cc9b2e0b254e61b9dbc
Reviewed-on: https://review.typo3.org/55064
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
22 months ago[TASK] EXT:Scheduler: Update documentation 77/55077/3
Michael Oehlhof [Thu, 14 Dec 2017 15:22:07 +0000 (16:22 +0100)]
[TASK] EXT:Scheduler: Update documentation

Replaced images with new ones from current master.
Adjust the description text where necessary.
Change presentation of the "class not found" group.

Resolves: #72628
Releases: master
Change-Id: Icf6845c72b34afbf0105aa844e321a18878f16dd
Reviewed-on: https://review.typo3.org/55077
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
22 months ago[TASK] Bamboo: use udiff format for php-cs-fixer diff option 81/55081/4
Nicole Cordes [Thu, 14 Dec 2017 17:21:49 +0000 (18:21 +0100)]
[TASK] Bamboo: use udiff format for php-cs-fixer diff option

The option produces nice compact output instead of printing whole file.

Resolves: #83335
Releases: master, 8.7
Change-Id: I3b5fb0ab004c653751c4bc3e7f8e1079fcc66235
Reviewed-on: https://review.typo3.org/55081
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
22 months ago[TASK] Optimize structure of ChangeLog documentation 72/55072/4
Martin Bless [Thu, 14 Dec 2017 13:24:02 +0000 (14:24 +0100)]
[TASK] Optimize structure of ChangeLog documentation

Have a slightly different menu setup of the rendered
documentation, especially affects docs.typo3.org

Change-Id: I357c1f59ff7606361b680128d5a3934c981a4f43
Resolves: #83325
Releases: master
Reviewed-on: https://review.typo3.org/55072
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] Update friendsofphp/php-cs-fixer to 2.9.0 76/55076/4
Nicole Cordes [Thu, 14 Dec 2017 14:57:59 +0000 (15:57 +0100)]
[TASK] Update friendsofphp/php-cs-fixer to 2.9.0

This also updates needed dependencies.

composer command used:

composer update friendsofphp/php-cs-fixer --with-dependencies

Resolves: #83331
Releases: master, 8.7
Change-Id: I32be2033acacb881c467b23462afa1f852b290fe
Reviewed-on: https://review.typo3.org/55076
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
22 months ago[TASK] Show complete diff for cglFixMyCommit on Bamboo 69/55069/5
Nicole Cordes [Thu, 14 Dec 2017 12:16:59 +0000 (13:16 +0100)]
[TASK] Show complete diff for cglFixMyCommit on Bamboo

Resolves: #83324
Releases: master, 8.7
Change-Id: Idf7b0119c6d25b1336d3fce04e1bd393f4dc945c
Reviewed-on: https://review.typo3.org/55069
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Use correct language file location 73/55073/2
Georg Ringer [Thu, 14 Dec 2017 13:33:04 +0000 (14:33 +0100)]
[BUGFIX] Use correct language file location

With the move of the PageInformationController with change #81865
some labels in the info module needs to be adopted.

Resolves: #83326
Releases: master
Change-Id: I1d171fd35acb555f8f9065e3700a2ed2324d64fd
Reviewed-on: https://review.typo3.org/55073
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
22 months ago[BUGFIX] Changelog docs compile warnings 63/55063/4
Christian Kuhn [Wed, 13 Dec 2017 17:32:00 +0000 (18:32 +0100)]
[BUGFIX] Changelog docs compile warnings

Fix a series of ReST documentation compile warnings, some of them
lead to missing segments in the rendered docs. Most notable changes:

* Always have an empty line after '.. code-block:: <highlight-indicator>'
* Introduce inline text role ":javascript:" and use it consistently over
  ":js:", but give it the same HTML class "js" during rendering. This is
  because highlight code-block existists for "javascript", too, so this
  can now be used both in blocks as well as inline
* Introduce inline text role ":sql:", can now be used inline, too, in
  addition to code-block
* Various minor things like indentings in numerations, some broken
  tables, ...

Change-Id: Id9c16257a76623dc9ee292253450865b95e13dc3
Resolves: #83313
Releases: master
Reviewed-on: https://review.typo3.org/55063
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Allow current dev versions of subtree split packages 62/55062/2
Helmut Hummel [Wed, 13 Dec 2017 12:44:39 +0000 (13:44 +0100)]
[BUGFIX] Allow current dev versions of subtree split packages

To be able to install subtree split packages in dev-master
the package dependencies between them need to allow exactly that.

Releases: master
Resolves: #83309
Change-Id: If2b8ea86958a425a6a047207bc064a41698215a4
Reviewed-on: https://review.typo3.org/55062
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
22 months ago[TASK] Salted Passwords: Add a ComposedSaltInterface 60/55060/2
Benni Mack [Tue, 12 Dec 2017 20:49:57 +0000 (21:49 +0100)]
[TASK] Salted Passwords: Add a ComposedSaltInterface

Add another interface, in order to allow to code
against interface instead of abstractions,
so composed salts that implement their own
password-hashing can implement this interface.

Relates: #79795
Relates: #79889
Resolves: #83294
Releases: master
Change-Id: Ica97f695b5f005e7b835078e89d17f8003141b3f
Reviewed-on: https://review.typo3.org/55060
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
22 months ago[TASK] Set TYPO3 version to 9.1.0-dev 55/55055/7
Benni Mack [Tue, 12 Dec 2017 16:49:44 +0000 (17:49 +0100)]
[TASK] Set TYPO3 version to 9.1.0-dev

Releases: master
Change-Id: Ia7f55a6f40ec6b80939a78b13aa3fafc6c11132a
Reviewed-on: https://review.typo3.org/55055
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Don't list records from tables without searchFields on search 48/55048/4
Stephan Großberndt [Tue, 12 Dec 2017 14:05:56 +0000 (15:05 +0100)]
[BUGFIX] Don't list records from tables without searchFields on search

When searching for a string in the database list do not show any records
from tables without a searchField definition, if the searchString is not
an integer which might be a uid.

Releases: master, 8.7
Resolves: #83301
Change-Id: I259a4d9b2f89c55f9a0ac307b812e950ab549b20
Reviewed-on: https://review.typo3.org/55048
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Hannes Lau <office@hanneslau.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
22 months ago[BUGFIX] Read TER XML entity value complete 36/54936/4
Alexander Opitz [Tue, 5 Dec 2017 12:46:27 +0000 (13:46 +0100)]
[BUGFIX] Read TER XML entity value complete

Improve reading the TER XML file while using the php xml extension.
The character data handler could be called multiple times, so we
shouldn't cut previous data away.

Resolves: #83227
Releases: master, 8.7, 7.6
Change-Id: I9e96ade88da6a4709d1f72cd49fe766758d265fe
Reviewed-on: https://review.typo3.org/54936
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
22 months ago[TASK] Add missing Documentation/9.0/Index.rst 56/55056/2
Christian Kuhn [Tue, 12 Dec 2017 18:31:28 +0000 (19:31 +0100)]
[TASK] Add missing Documentation/9.0/Index.rst

Due to the missing index file, the 9.0 doc files
are not yet rendered on docs.typo3.org

Change-Id: I65781b9de84dd4a0f1205ded175858a90dc01f85
Resolves: #83304
Releases: master
Reviewed-on: https://review.typo3.org/55056
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[RELEASE] Release of TYPO3 9.0.0 54/55054/2 v9.0.0
Benni Mack [Tue, 12 Dec 2017 16:48:17 +0000 (17:48 +0100)]
[RELEASE] Release of TYPO3 9.0.0

Change-Id: Iafe266ef8904526c9822576bfbab135d27b6ce27
Reviewed-on: https://review.typo3.org/55054
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>