Packages/TYPO3.CMS.git
2 months ago[BUGFIX] Fix several typos in php comments 45/61845/4
Christian Eßl [Thu, 26 Sep 2019 19:37:36 +0000 (21:37 +0200)]
[BUGFIX] Fix several typos in php comments

Make spelling in TYPO3 great again.

Resolves: #89290
Releases: master
Change-Id: I520840dd0774aa5d658ce6a45811aa6282c9e461
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61845
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
2 months ago[TASK] Use node v12 to build assets 99/61899/3
Andreas Fernandez [Mon, 7 Oct 2019 09:04:59 +0000 (11:04 +0200)]
[TASK] Use node v12 to build assets

The minimum node version is raised to v12. This patch also updates the
upgrade task of runTests.sh to fetch new JS containers.

Resolves: #89357
Releases: master
Change-Id: Icf8a5af0791fffa483f0a970b83ae548f77885e5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61899
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[TASK] Deprecate legacy FormEngine functions 72/61872/10
Andreas Fernandez [Wed, 2 Oct 2019 06:24:58 +0000 (08:24 +0200)]
[TASK] Deprecate legacy FormEngine functions

This patch deprecates the last remaining legacy functions in FormEngine:

- setFormValueOpenBrowser()
- setFormValueFromBrowseWin()
- setHiddenFromList()
- setFormValueManipulate()
- setFormValue_getFObj()

Additionally, a call to the undefined function `group_change` has been
removed.

Resolves: #89331
Releases: master
Change-Id: Ie7419ed0581b92c37afd0614ca78287ffe286016
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61872
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
2 months ago[BUGFIX] Fix TypeScript path in Grunt watcher 82/61882/4
Andreas Fernandez [Fri, 4 Oct 2019 07:38:52 +0000 (09:38 +0200)]
[BUGFIX] Fix TypeScript path in Grunt watcher

Resolves: #89343
Releases: master
Change-Id: I1c14b46923c21bbe8547bc9a40bcabbecef67bb6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61882
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
2 months ago[BUGFIX] Escape url parameters in tree rendering 89/61889/2
Markus Klein [Fri, 4 Oct 2019 22:09:22 +0000 (00:09 +0200)]
[BUGFIX] Escape url parameters in tree rendering

This enables navigation in the Configuration module for tree
nodes having url-sensitive characters in the name, like a hash (#).

Resolves: #89333
Releases: master, 9.5
Change-Id: I7279778914f4165b8c8c6437fe68be1b60f52b79
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61889
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
2 months ago[TASK] Fill original attribute properly 77/61877/2
Georg Ringer [Thu, 3 Oct 2019 07:02:29 +0000 (09:02 +0200)]
[TASK] Fill original attribute properly

The attribute original should be filled with a useful information
instead of dummy value "messages".

This string is also shown in Crowdin and helps users while translating.

Resolves: #89336
Releases: master, 9.5
Change-Id: I35a48083edd35b00f6ec91b3e1c4cb07985c76f9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61877
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[TASK] Add resname attribute to trans-unit tags in XLF files 76/61876/3
Markus Klein [Thu, 3 Oct 2019 06:30:02 +0000 (08:30 +0200)]
[TASK] Add resname attribute to trans-unit tags in XLF files

Crowdin doesn't show the information stored in the attribute "id".
If we want to have that visible, the attribute must be duplicated using
"resname".

find typo3/ -name '*.xlf' -exec sed -i -e \
    '/resname/!s/\(<trans-unit id="\)\([^"]*\)"/\1\2" resname="\2"/' \
    '{}' +

Resolves: #89335
Releases: master, 9.5
Change-Id: I73de72a8bf4a837347a69183088c212d0a958d74
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61876
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[TASK] Fix typo and formatting in documentation for #84545 73/61873/4
Tymoteusz Motylewski [Wed, 2 Oct 2019 08:28:25 +0000 (10:28 +0200)]
[TASK] Fix typo and formatting in documentation for #84545

* Fix typo in folder name.
* Format lists properly.
* Add missing text roles.

Resolves: #89329
Releases: master, 9.5
Change-Id: I0b48404729dca49c4049dfb7b83c5248b887f791
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61873
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[TASK] Add configuration for Crowdin 46/61846/4
Georg Ringer [Thu, 26 Sep 2019 20:26:44 +0000 (22:26 +0200)]
[TASK] Add configuration for Crowdin

Crowdin requires a basic configuration which defines where the
XLIFF files and their translations are located. The configuration is used
by the GitHub integration which is offered by Crowdin itself.
See https://support.crowdin.com/github-integration/ for more information
about that.

Even though the translations will not be pushed back to the GitHub
repository of TYPO3 (as pull requests), the "translation" property is
required as the manual export of translations will use it.

Resolves: #89281
Releases: master, 9.5
Change-Id: I1a5f94b416a0652081976bcdbd9ea7d61fb202dc
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61846
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
2 months ago[TASK] Set TYPO3 version to 10.2.0-dev 70/61870/2
Oliver Hader [Tue, 1 Oct 2019 08:19:41 +0000 (10:19 +0200)]
[TASK] Set TYPO3 version to 10.2.0-dev

Change-Id: I81e89208e45b689b32f5c8df2392e8c2b24b8392
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61870
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
2 months ago[RELEASE] Release of TYPO3 10.1.0 69/61869/2 v10.1.0
Oliver Hader [Tue, 1 Oct 2019 08:18:06 +0000 (10:18 +0200)]
[RELEASE] Release of TYPO3 10.1.0

Change-Id: I6491f0abe1148a2fbea8b37709dd16b071657b35
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61869
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
2 months ago[BUGFIX] Adjust visibility of IRRE controls 68/61868/3
Andreas Fernandez [Tue, 1 Oct 2019 06:42:09 +0000 (08:42 +0200)]
[BUGFIX] Adjust visibility of IRRE controls

Previously, if constraints in an IRRE container were met, the control
container's visibility has been toggled. However, the PHP backend
defines the visibility per control item.

The JavaScript now toggles the visibility per control as well and does
not hide the container anymore.

Resolves: #89319
Releases: master
Change-Id: Ia0a70f98997b714ce8caedf549060601ff91a1d3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61868
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
2 months ago[BUGFIX] Re-implement record deletion via EditDocumentController 65/61865/3
Andreas Fernandez [Mon, 30 Sep 2019 15:35:07 +0000 (17:35 +0200)]
[BUGFIX] Re-implement record deletion via EditDocumentController

The change of #89033 removed the callback for deleting records within
EditDocumentController, resulting in JavaScript errors.

This patch adds the delete action again, directly implemented in the
FormEngine module. The URL to delete the record is pre-built as well,
since any required information is already known.

Resolves: #89315
Related: #89033
Releases: master
Change-Id: I842d0119291b53be3cdc3b2d6373ccd474fc7146
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61865
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
2 months ago[BUGFIX] Streamline site configuration import in distribution packages 64/61864/5
Oliver Hader [Mon, 30 Sep 2019 12:19:19 +0000 (14:19 +0200)]
[BUGFIX] Streamline site configuration import in distribution packages

Site configuration shipped in distribution packages had a couple of flaws
during import process which are tackled with this change:

* existing site configurations for same identifier are not overridden on
  the file system level anymore (according warning is logged)
* site configuration is now updated and mapped to for imported pages,
  which did not work before due to hard-coded rootPageId in config.yaml
  (warning is logged in case root page id cannot be mapped)

Resolves: #89314
Releases: master
Change-Id: I856024afb50186eb9f6cc73ef13f1961c948c784
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61864
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 months ago[BUGFIX] Pass SiteFinder to RedirectService instance 66/61866/2
Andreas Fernandez [Mon, 30 Sep 2019 17:22:14 +0000 (19:22 +0200)]
[BUGFIX] Pass SiteFinder to RedirectService instance

The patch for #89317 extended the RedirectService, but didn't adjust all
constructors. In this case, IntegrityService was forgotten and didn't
pass a SiteFinder to the RedirectService.

This patch now passes the SiteFinder instance.

Resolves: #89317
Related: #88877
Releases: master
Change-Id: I1758dc8549cf5f58c7dbaf1475d10288af86316b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61866
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
2 months ago[BUGFIX] Prevent auto-fill in user setup 62/61862/3
Frank Naegler [Mon, 30 Sep 2019 09:29:56 +0000 (11:29 +0200)]
[BUGFIX] Prevent auto-fill in user setup

This patch adds the correct value for autocomplete on password field.

Reference: https://developer.mozilla.org/en-US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion#Preventing_autofilling_with_autocompletenew-password

Resolves: #89310
Releases: master, 9.5, 8.7
Change-Id: Ib1a805ddc5e8da14380d9cf7e5b188a67ed54fea
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61862
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
2 months ago[BUGFIX] Manage Language Packs: Render empty column if language pack is downloaded 37/61837/5
Andreas Fernandez [Thu, 26 Sep 2019 08:06:22 +0000 (10:06 +0200)]
[BUGFIX] Manage Language Packs: Render empty column if language pack is downloaded

If a language pack is available for an extension, the matrix now renders
an empty column to fix wrong positioning of the actual download buttons.

Resolves: #89283
Releases: master, 9.5
Change-Id: I100a0c8f4a4db3ed03f86e2fb71c95ec9448b3bb
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61837
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Richard Haeser <richard@maxserv.com>
2 months ago[BUGFIX] Render correct preview link in page module 13/61713/3
Georg Ringer [Tue, 17 Sep 2019 06:43:55 +0000 (08:43 +0200)]
[BUGFIX] Render correct preview link in page module

If a page is translated and a translation is selected in the columns module of the
page module, the view webpage button must show the translation instead of
the default language.

Resolves: #89184
Releases: master, 9.5
Change-Id: Ib1c21a99a706e298300e355e6675839275361e28
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61713
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
2 months ago[BUGFIX] Load Clearable in system configuration 61/61861/2
Andreas Fernandez [Mon, 30 Sep 2019 09:24:02 +0000 (11:24 +0200)]
[BUGFIX] Load Clearable in system configuration

Resolves: #89309
Related: #89215
Releases: master
Change-Id: I6994039d5c2e7d99224336ecfd66a14b0580feac
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61861
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
2 months ago[TASK] Move changelog files into 10.1 folder 44/61844/10
Anja Leichsenring [Thu, 26 Sep 2019 15:37:54 +0000 (17:37 +0200)]
[TASK] Move changelog files into 10.1 folder

Preparation for TYPO3 10.1 release, all changelog files
are reviewed, adjusted and moved to the corresponding versioning folder

Change-Id: Ibafd4c05b0ec1684da4bfbc21f608916f4a3375d
Releases: master
Resolves: #89289
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61844
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[TASK] Update grunt and friends 07/61807/2
Andreas Fernandez [Wed, 25 Sep 2019 13:31:56 +0000 (15:31 +0200)]
[TASK] Update grunt and friends

This patch updates grunt and plugins to their latest version.

Executed command:

  yarn upgrade --pattern grunt --latest

Resolves: #89270
Releases: master
Change-Id: Ibc830d62115ba369afa15c459e93053985726c29
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61807
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
2 months ago[FEATURE] Auto slug update and redirect creation on slug change 13/61613/50
Frank Naegler [Sat, 28 Sep 2019 13:51:54 +0000 (15:51 +0200)]
[FEATURE] Auto slug update and redirect creation on slug change

If EXT:redirects is installed and a slug is updated by a backend user,
a redirect from the old URL to the new URL will be created.
All sub pages are checked too and the slugs will be updated.

Resolves: #89115
Releases: master
Change-Id: Id0b09cb22681aa6b2704b4f7cbc47d8b747e56d4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61613
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
2 months ago[BUGFIX] Correctly unpack CorrelationId version 56/61856/2
Oliver Hader [Sat, 28 Sep 2019 16:57:51 +0000 (18:57 +0200)]
[BUGFIX] Correctly unpack CorrelationId version

Resolves: #89299
Releases: master
Change-Id: Ib4e63b7baadb604ca77469e66af5bc060f79a8f6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61856
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
2 months ago[TASK] Introduce CorrelationId model 55/61855/4
Oliver Hader [Sat, 28 Sep 2019 13:52:16 +0000 (15:52 +0200)]
[TASK] Introduce CorrelationId model

Resolves: #89298
Releases: master
Change-Id: Icb2d406d8ba3759c8f999966fc68b8e31b046c01
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61855
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
2 months ago[BUGFIX] Ensure correct site is used when redirecting 38/61838/4
Andreas Fernandez [Thu, 26 Sep 2019 09:20:27 +0000 (11:20 +0200)]
[BUGFIX] Ensure correct site is used when redirecting

The RedirectService recives a NullSite instance from the current
request. This patch checks whether the redirect target is a page and
fetches its site configuration to be able to create a proper TSFE
instance.

Also, the TSFE instance now does not fetch any template configuration
anymore as it is rather extraneous for a redirect.

Resolves: #88877
Releases: master
Change-Id: If0463d3ad9e8af47950f001c8646dc8a15b6a02b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61838
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 months ago[BUGFIX] Enable link fields with softref url or email 07/61707/5
Lina Wolf [Fri, 13 Sep 2019 19:40:08 +0000 (21:40 +0200)]
[BUGFIX] Enable link fields with softref url or email

Enables checking of links in fields that have softrefs "url" or "email"
in their TCA configuration.

This is achieved by passing parameter that enables the 'subst' part of
the softref to SoftReferenceIndex::findRef

While SoftReferenceIndex::findRef_typolink and findRef_typolink_tag
automatically enable the 'subst' part SoftReferenceIndex::findRef_email
and findRef_url only do so if enabled via configuration.

Resolves: #52912
Releases: master, 9.5, 8.7
Change-Id: I98176d27d129aa0f67a8ad94747d1374873c6e34
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61707
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Sybille Peters <sypets@gmx.de>
Tested-by: Jonas Götze <jonnsn@gmail.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Simon Gilli <typo3@gilbertsoft.org>
Reviewed-by: Jonas Götze <jonnsn@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
2 months ago[BUGFIX] Page preview respects language fallbacks 41/61841/3
Benni Mack [Thu, 26 Sep 2019 11:16:18 +0000 (13:16 +0200)]
[BUGFIX] Page preview respects language fallbacks

When a default language page is hidden, it should also be visible
when a translated page is rendered but not available.

The current "simple" check to only check for a specific language
to find out if a page is hidden, is wrong, as l18n_cfg could be built
in a way that a page translation (language>0) does not exist, but
the default record is actually available.

This change overcomes a long-standing issue that
translations of hidden pages can be previewed.

Resolves: #89130
Releases: master, 9.5
Change-Id: I8bc8f1e55a07b680c7b7b9591ec2936d50840548
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61841
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Tobias Gaertner <tobias.gaertner@benaja-websolutions.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
2 months ago[BUGFIX] Load clearable module in recycler 43/61843/2
Andreas Fernandez [Thu, 26 Sep 2019 13:29:11 +0000 (15:29 +0200)]
[BUGFIX] Load clearable module in recycler

It was forgotten to load the new clearable module in the recycler
module.

Resolves: #89288
Related: #89215
Releases: master
Change-Id: I35f0e7b3d63112faf0c3fcfba7719141673856e6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61843
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[FEATURE] Add support for RecordHistory correlation ids in DataHandler 48/61848/4
Frank Naegler [Fri, 27 Sep 2019 09:25:36 +0000 (11:25 +0200)]
[FEATURE] Add support for RecordHistory correlation ids in DataHandler

Resolves: #89292
Related: #89143
Releases: master
Change-Id: Ie10bcbfca7f43a60b80a2a6634759584043c7cf4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61848
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[BUGFIX] Fix regression due to Doctrine DBAL refactoring 47/61847/2
Benni Mack [Fri, 27 Sep 2019 09:10:18 +0000 (11:10 +0200)]
[BUGFIX] Fix regression due to Doctrine DBAL refactoring

As added in change 6ef46cab02f754d0809daf751ec3385021ab9387
see https://review.typo3.org/c/Packages/TYPO3.CMS/+/49530/, the RelationHandler
works on deleted elements ON ALL OTHER workspaces instead of
the current one, as the SQL query does a "neq", but prior did a "wsid=".

Resolves: #89291
Related: #77565
Releases: master, 9.5, 8.7
Change-Id: Ide82a779f1f4ba3daa064243361b9a370198d958
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61847
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.com>
Reviewed-by: Benni Mack <benni@typo3.org>
2 months agoRevert "[FEATURE] Read site setting file and populate them with the site object" 17/61817/4
Anja Leichsenring [Wed, 25 Sep 2019 16:56:51 +0000 (18:56 +0200)]
Revert "[FEATURE] Read site setting file and populate them with the site object"

This reverts commit 0e70168d7aa74bd7e1f686952db731e239a6e86e.

Reason for revert: postponed to after 10.1

Change-Id: Ib1655e4f31f0fb620943a34f2361806a0fb47e0a
Releases: master
Resolves: #89278
Reverts: #89102
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61817
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
2 months agoRevert "[TASK] Edit Site Settings in Site Module" 16/61816/2
Anja Leichsenring [Wed, 25 Sep 2019 16:54:48 +0000 (18:54 +0200)]
Revert "[TASK] Edit Site Settings in Site Module"

This reverts commit 4989d5af6e37fc9083742c43fed105bb8cd3750e.

Reason for revert: once more after 10.1.
Resolves: #89277
Reverts: #89134
Releases: master

Change-Id: Id9486bf090db83f080c502ffbd36fd5f3c5d2ac4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61816
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
2 months ago[TASK] Move documentation of #86577 into correct folder 39/61839/2
Andreas Fernandez [Thu, 26 Sep 2019 09:43:06 +0000 (11:43 +0200)]
[TASK] Move documentation of #86577 into correct folder

The patch related to #86577 has been merged into v10 and v9, but the
ReST file was created in the wrong directory. This patch moves the file
into `9.5.x`.

Resolves: #89286
Related: #86577
Releases: master, 9.5
Change-Id: Ie4e55331ee4f01bfabe69da95d5f620522a826ce
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61839
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months agoRevert "[TASK] Avoid slow array functions in loops" 15/61815/3
Anja Leichsenring [Wed, 25 Sep 2019 16:37:53 +0000 (18:37 +0200)]
Revert "[TASK] Avoid slow array functions in loops"

This reverts commit e531ddce9a6874e5ad289ae58f6474565dab9218.

Reason for revert: immature merge

Change-Id: Ia31248587537a502ffdfc84761bacd7095999642
Resolves: #89276
Reverts: #89056
Releases: master
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61815
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[TASK] Fix CGL violation in FileList 35/61835/2
Benjamin Franzke [Thu, 26 Sep 2019 04:11:06 +0000 (06:11 +0200)]
[TASK] Fix CGL violation in FileList

https://review.typo3.org/c/Packages/TYPO3.CMS/+/57414 introduced
a CGL violation that was not discovered because the patchset was
pushed on 8th of august and was checked with php-cs-fixer 2.14.1
on bamboo where no violation was found.

In the meantime (between push and merge of the mentioned patch)
https://review.typo3.org/c/Packages/TYPO3.CMS/+/61564 has been
merged, which updates php-cs-fixer to 2.15.2 and contains new
rules.

Releases: master
Resolves: #89282
Related: #57414
Related: #85425
Change-Id: I61d5e6e5dc61b500fe620e59002f296f50f03214
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61835
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[TASK] Update CodeMirror to 5.49.0 08/61808/2
Andreas Fernandez [Wed, 25 Sep 2019 13:39:02 +0000 (15:39 +0200)]
[TASK] Update CodeMirror to 5.49.0

This patch updates CodeMirror to version 5.49.0.

Executed command:

  yarn add --dev codemirror@^5.49.0

Resolves: #89272
Releases: master, 9.5
Change-Id: I59b2808e5c363380628a247147faf4cae2a661fd
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61808
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
2 months ago[FEATURE] Allow additional file processors 88/61088/13
Tim Schreiner [Tue, 18 Jun 2019 17:37:13 +0000 (19:37 +0200)]
[FEATURE] Allow additional file processors

Allow registration of additional file processors.

Resolves: #88602
Releases: master
Change-Id: Iff5594ce07750e557f2dc316f3e8aacd90cf5c81
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61088
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 months ago[TASK] Keep old value on confirmation modal close 71/61771/10
Harald Atteneder [Sat, 21 Sep 2019 19:09:14 +0000 (21:09 +0200)]
[TASK] Keep old value on confirmation modal close

When changing the doktype a confirmation modal appears. This patch
reverts the value of the field to the original value after closing the
modal without clicking *OK*.

This works for all selects with 'onChange' => 'reload' and
'renderType' => 'selectSingle'

Resolves: #89220
Releases: master,9.5
Change-Id: I6d479f9180d64e8e4c25e96f52e60dca36863fd9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61771
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[BUGFIX] Provide error messages in install tool mail settings test 02/61802/2
Oliver Hader [Tue, 24 Sep 2019 17:55:29 +0000 (19:55 +0200)]
[BUGFIX] Provide error messages in install tool mail settings test

In order to identify problems with sending out mails, more specific
error messages than "Something went wrong" are used.

Resolves: #89254
Releases: master, 9.5
Change-Id: I61d8b122f7af764cfd5be0b08b27c99cd4fd56e0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61802
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[BUGFIX] Load language labels in RecordProvider 92/61692/6
Andreas Fernandez [Thu, 12 Sep 2019 07:30:46 +0000 (09:30 +0200)]
[BUGFIX] Load language labels in RecordProvider

The generic RecordProvider used for context menus now explicitly loads
the language labels for the modals.

Resolves: #89151
Releases: master, 9.5
Change-Id: If4368f507a0432606298fd5b17b05bf7c665d1d8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61692
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[FEATURE] Add data type in QueryBuilder::set with createNamedParameter 27/61327/4
Manuel Selbach [Fri, 19 Jul 2019 12:24:48 +0000 (14:24 +0200)]
[FEATURE] Add data type in QueryBuilder::set with createNamedParameter

With this change it is possible to define the type of the value if the
createNamedParameter option is set.

Releases: master
Resolves: #88805
Change-Id: I964d8fadf5d3e6512d8585c2bbd84e0b14c9d274
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61327
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Manuel Selbach <manuel_selbach@yahoo.de>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
2 months ago[BUGFIX] Check permissions on copy actions 14/57414/9
Guido Schmechel [Thu, 28 Jun 2018 19:43:16 +0000 (21:43 +0200)]
[BUGFIX] Check permissions on copy actions

No copy link in the context menu or the button
in the file list is displayed, when the user lacks the permission
to copy file or folder.

Resolves: #85425
Releases: master, 9.5
Change-Id: I442d17e04a87eb25a438c2c2e7f22aef70492061
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/57414
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[TASK] Improve loops in TypeScript 53/61653/6
Andreas Fernandez [Tue, 10 Sep 2019 06:41:24 +0000 (08:41 +0200)]
[TASK] Improve loops in TypeScript

This patch improves the loops in TypeScript by using `for (... of ...)`
and incorporating ES7 features as `Object.entries()` and
`Object.values()`.

Resolves: #89262
Releases: master
Change-Id: I4f4300a2e241bcd34494ae0b0d400e589ad702da
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61653
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[TASK] Avoid slow array functions in loops 83/59083/10
Andreas Fernandez [Tue, 11 Dec 2018 08:57:09 +0000 (09:57 +0100)]
[TASK] Avoid slow array functions in loops

This patch moves some array functions used in loops (array_merge,
array_replace) out of their calling loop for performance reasons, where
applicable.

This this achieved by calling the functions via array unpacking ("splat
operator").

See for further reading:
https://github.com/kalessil/phpinspectionsea/blob/master/docs/performance.md#slow-array-function-used-in-loop

Resolves: #89056
Releases: master
Change-Id: Ia21b1909f77879918b84c6fa702f07a41149e83f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59083
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[TASK] Use correct file ending for documentation mention 89/61789/4
Michael Binder [Wed, 25 Sep 2019 08:33:10 +0000 (10:33 +0200)]
[TASK] Use correct file ending for documentation mention

To avoid confusing users, a uniform way of referencing YAML files in
the documentation is used.

Releases: master
Resolves: #89237
Change-Id: Id03be5dbc17a174fafc4c188a298369834ef4a39
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61789
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[TASK] Make infobox for shortcut pages more helpful 10/61710/8
Oliver Bartsch [Mon, 16 Sep 2019 06:28:22 +0000 (08:28 +0200)]
[TASK] Make infobox for shortcut pages more helpful

Add proper information for the user about the target page.

In case the target page doesn't exist or is not accessible
in the frontend, the infobox in the page module now states this out.

Resolves: #89121
Releases: master, 9.5
Change-Id: Ie4d5b208028fa960e34dec64c546a2e5ebb1de05
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61710
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
2 months ago[FEATURE] Introduce Broadcast Messaging 88/61788/6
Oliver Hader [Mon, 23 Sep 2019 18:31:29 +0000 (20:31 +0200)]
[FEATURE] Introduce Broadcast Messaging

This change introduces BroadcastChannel in order to communicate between
frames. Messages are converted to according CustomEvents that can be
handled individually. Event handling happens in the most specific scope
on client side.

A polyfill to support Edge has been installed, executed command:

  yarn add broadcastchannel-polyfill

Resolves: #89244
Releases: master
Change-Id: Iab55bf78ff9324d19d115022464c24eea1b8b78e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61788
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[FEATURE] Toggle page menu visibility via context menu 83/57983/21
Gianluigi Martino [Tue, 21 Aug 2018 11:28:43 +0000 (13:28 +0200)]
[FEATURE] Toggle page menu visibility via context menu

Add a context menu entry to enable or disable the option "Page
enabled in menus".

Resolves: #85918
Releases: master
Change-Id: Ib821846fd78dafee9fc51df6d07148844e613a72
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/57983
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[TASK] Remove left-over clear_all_cache code from TS module controller 04/61804/2
Benjamin Franzke [Wed, 25 Sep 2019 06:50:52 +0000 (08:50 +0200)]
[TASK] Remove left-over clear_all_cache code from TS module controller

The frontend part that issued the GET parameter clear_all_cache=1 was
removed in 2008 with the following commit:
https://github.com/TYPO3/TYPO3.CMS/commit/94fb08233d

The handling of this unused parameter is therefore removed.

Releases: master
Resolves: #89257
Change-Id: I4d248d388fb8efdb11df9eb7fd6d976338fa65d1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61804
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
2 months ago[TASK] Use ESLint as base for linting 84/61784/8
Andreas Fernandez [Mon, 23 Sep 2019 14:20:44 +0000 (16:20 +0200)]
[TASK] Use ESLint as base for linting

TSLint is in a deprecation phase, recommending to migrate to ESLint
instead. This patch removes all TSLint packages and supplies a proper
ESLint configuration.

Also, rule violations are fixed in this patch.

Executed commands:

  yarn add --dev typescript-eslint \
    @typescript-eslint/parser \
    @typescript-eslint/eslint-plugin \
    eslint grunt-eslint

  yarn remove tslint grunt-tslint

  ./node_modules/.bin/eslint -c eslintrc.js --fix --ext .ts \
    ./Sources/TypeScript/

Resolves: #89232
Releases: master
Change-Id: I3bd4a1c30ecc27f8c334951547aff5e9352629da
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61784
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
2 months ago[TASK] Update CSS tooling 00/61800/2
Andreas Fernandez [Tue, 24 Sep 2019 15:33:22 +0000 (17:33 +0200)]
[TASK] Update CSS tooling

This patch updates some CSS tools to the current version and creates new
CSS builds.

Executed commands:

  yarn add --dev node-sass \
    grunt-stylelint@^0.11.0 \
    grunt-sass@^3.1.0 \
    stylefmt@^6.0.0 \
    autoprefixer@^9.6

  yarn upgrade --pattern postcss --latest

This patch also updates the list of supported browsers, raising minimum
iOS version and dropping Internet Explorer completely.

Resolves: #89251
Releases: master
Change-Id: I5e87a94184b2fe76c57b602266bebbc2c43390de
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61800
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
2 months ago[BUGFIX] Render "Admin Tools" icon in Install Tool as inline SVG 98/61798/3
Andreas Fernandez [Tue, 24 Sep 2019 13:31:15 +0000 (15:31 +0200)]
[BUGFIX] Render "Admin Tools" icon in Install Tool as inline SVG

Resolves: #89250
Related: #89206
Releases: master
Change-Id: Ic865c7610f84674e9a3c06a2e01e67e9adb2fc25
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61798
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
2 months ago[BUGFIX] Don't make clearable button tabbable 94/61794/3
Andreas Fernandez [Tue, 24 Sep 2019 12:39:40 +0000 (14:39 +0200)]
[BUGFIX] Don't make clearable button tabbable

The clearable button now has a `tabindex="-1"` attribute to disallow
focussing it via <TAB>.

Resolves: #89248
Related: #89215
Releases: master
Change-Id: I8bd637461d7c1e3b8ff51aa3a588a497787b0185
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61794
Tested-by: Nicole Cordes <typo3@cordes.co>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
2 months ago[TASK] Add scroll-padding to .module-body 70/61770/4
Harald Atteneder [Sat, 21 Sep 2019 16:59:33 +0000 (18:59 +0200)]
[TASK] Add scroll-padding to .module-body

This fixes the small annoyance when expanding an item in the
TypoScript Object Browser and the iframe reloads and scrolls to the
expanded item while the doc-header hides this item. CSS scroll-padding
solves this problem for modern browsers.

Resolves: #89217
Releases: master,9.5
Change-Id: If4b71c7fb6ba003b23cdd79460540f0bf335abb8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61770
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
2 months ago[FEATURE] Add Cache Preset to Maintenance Area Settings 75/61075/5
Benni Mack [Mon, 17 Jun 2019 15:05:27 +0000 (17:05 +0200)]
[FEATURE] Add Cache Preset to Maintenance Area Settings

On various mass hostings, it is sometimes more useful to switch
to file-based caching to speed up performance, as
SSD usages has improved.

In order to help non-experts to set up proper caching for their
most common use-cases, a Preset in the "Maintenance -> Settings"
for Caching has been added.

Resolves: #89229
Releases: master
Change-Id: Icd953937cce36d793b6c16ee518449049fca31df
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61075
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months agoRevert "[FEATURE] PHP API for backend JavaScript notifications" 51/61751/4
Andreas Fernandez [Tue, 24 Sep 2019 10:38:24 +0000 (12:38 +0200)]
Revert "[FEATURE] PHP API for backend JavaScript notifications"

This reverts commit deca7432d45225d1f4c00bd8fd7f05e3d7a0773d.

The PHP API is considered insecure as whole blocks of JavaScript are
manually written into the PageRenderer.

Change-Id: I8cd69cb9238b187ed6d6343548adf03a4c2bb464
Resolves: #89246
Reverts: #89066
Releases: master
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61751
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months agoRevert "[BUGFIX] Generate notification action on rendering" 50/61750/4
Andreas Fernandez [Tue, 24 Sep 2019 10:35:16 +0000 (12:35 +0200)]
Revert "[BUGFIX] Generate notification action on rendering"

This reverts commit 78955a67c7da23c839757b4509f11c637e5e88bb.

The approach uses `eval` that is considered insecure.

Change-Id: I6f6f1b7040dc9ed6b93c115983a2124752ae0327
Resolves: #89247
Reverts: #89173
Releases: master
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61750
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[FEATURE] Show configuration of USER_INT objects in adminpanel 45/61045/4
c.essl [Sun, 16 Jun 2019 09:20:05 +0000 (11:20 +0200)]
[FEATURE] Show configuration of USER_INT objects in adminpanel

Introduces a new panel in the info module of the admin panel which lists
the basic configuration of each USER_INT present on the current page.

Resolves: #88441
Releases: master
Change-Id: Iedc4112c7ff961995d70622beec1c7256f78c1ce
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61045
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
2 months ago[TASK] Remove unused signal/slot in EM site setup 91/61791/2
Benni Mack [Tue, 24 Sep 2019 08:56:44 +0000 (10:56 +0200)]
[TASK] Remove unused signal/slot in EM site setup

A new signal was added with https://review.typo3.org/c/Packages/TYPO3.CMS/+/61554
which has no effect and with the provided information
is not needed. If necessary, a new PSR-14 event should
 be invoked at that place.

The patch removes the signal again.

Resolves: #89242
Related: #89010
Releases: master
Change-Id: I383e39ced7d9b88303aa13a98c48ca5242e82739
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61791
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
2 months ago[FEATURE] Add email address to installation process 89/60889/7
Benni Mack [Thu, 6 Jun 2019 05:42:49 +0000 (07:42 +0200)]
[FEATURE] Add email address to installation process

New installations now ask for the email address as well, so
this can be used later on to e.g. notify the admin if somebody
logged-in (Warning email address).

The same feature is available in the maintenance module of
the Install Tool in the "Create Administrative User" card.

Resolves: #89227
Releases: master
Change-Id: Iafca7043543d5e299fb121d96d9b3b9caa375bc9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60889
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
2 months ago[BUGFIX] Generate valid export url for files in filelist 03/61503/3
Andreas Fernandez [Fri, 16 Aug 2019 08:01:14 +0000 (10:01 +0200)]
[BUGFIX] Generate valid export url for files in filelist

Since FAL is in place, the export url for files generated in the
clipboard is broken as it takes the full file identifier. Previously it
took the physical file path, the code was never adjusted to be
compatible with FAL.

This patch now resolves the file identifier and generates proper
arguments for export.

Resolves: #88969
Releases: master, 9.5, 8.7
Change-Id: I6599114b19b9d173f88db7beefabe39e90520899
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61503
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
2 months ago[TASK] Remove unused property in Extbase DataMapper 90/61790/2
Benni Mack [Tue, 24 Sep 2019 07:42:05 +0000 (09:42 +0200)]
[TASK] Remove unused property in Extbase DataMapper

Extbase's DataMapper added a $pageSelectObject (PageRepository) as property
in 2009 but it was never used due to further abstractions into the DbBackend
of Extbase.

The protected property is unneeded and can safely be removed,
as it is never initialized or used since at least TYPO3 4.5.

Resolves: #89238
Releases: master
Change-Id: I9f88b6421e20f23eeeccd7861082fb169ebbce98
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61790
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[FEATURE] Provide implementation for PSR-18 HTTP Client 67/61567/8
Benjamin Franzke [Tue, 27 Aug 2019 12:49:19 +0000 (14:49 +0200)]
[FEATURE] Provide implementation for PSR-18 HTTP Client

The implementation of the PSR-18 ClientInterface is provided
as an adapter to the existing GuzzleHTTP Client. Therefore
existing configuraton settings will be reused.

As our current Guzzle wrapper (RequestFactory->request)
has support for passing custom guzzle per-request options,
we do not deprecate this method but add the PSR-18 implementation
as a more generic alternative.

Once GuzzleHTTP supports PSR-18 natively we can (and will)
drop our adapter and point to Guzzles native implementation
in our dependency injection configuration.
Therefore, this adapter is marked as internal and extensions
are being instructed to depend on the PSR-18 interfaces
only.

composer require psr/http-client:^1.0

Releases: master
Resolves: #89216
Change-Id: I0f2c81916a2f5e4b40abd6f0b146440ef155cf00
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61567
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[FEATURE] Create sites on page creation 58/61658/20
Andreas Fernandez [Tue, 10 Sep 2019 13:18:25 +0000 (15:18 +0200)]
[FEATURE] Create sites on page creation

A new hook is introduced that creates a site configuration when a new
page on root level is created. This takes effect for pages of type
"default", "link" and "shortcut".

To reduce the likelihood for conflicts, a shortened MD5 hash of the page
id appended to the site identifier.

Resolves: #89142
Releases: master
Change-Id: Ibe2957e3789f2a165e36949ae5fb4fa2a1a572df
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61658
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[TASK] Remove PhantomJS dependencies 87/61787/3
Andreas Fernandez [Mon, 23 Sep 2019 16:56:51 +0000 (18:56 +0200)]
[TASK] Remove PhantomJS dependencies

This patch removes extraneous npm packages. They were
required for PhantomJS and are currently unused.

Executed command:

  yarn remove karma-phantomjs-launcher phantomjs-prebuilt

Resolves: #89233
Releases: master
Change-Id: Ic754873a01a687da6b133702c7a682da349d859a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61787
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[TASK] Add functional tests for linkvalidator 12/61712/12
Sybille Peters [Mon, 16 Sep 2019 16:10:54 +0000 (18:10 +0200)]
[TASK] Add functional tests for linkvalidator

Resolves: #82850
Releases: master, 9.5
Change-Id: I05dc5e83199d58b23a8da6e625d1b9557b5c57a2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61712
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[TASK] Update JavaScript unit test packages 81/61781/3
Andreas Fernandez [Mon, 23 Sep 2019 12:40:44 +0000 (14:40 +0200)]
[TASK] Update JavaScript unit test packages

Executed commands:

  yarn upgrade --pattern jasmine --latest
  yarn upgrade --pattern karma --latest

Resolves: #89228
Releases: master
Change-Id: Id4f32730cbbebe74e07101bb1fed8e420d4a67aa
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61781
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
2 months ago[TASK] Update Fluid engine to 2.6.4 42/61642/8
Claus Due [Sun, 8 Sep 2019 14:13:51 +0000 (16:13 +0200)]
[TASK] Update Fluid engine to 2.6.4

Addresses the following issues:

* Fixes an annotation that makes phpdocumentor/reflection-docblock
  throw exceptions in TYPO3v10.
* Removes deprecation warning from composer due
  to incorrectly cased package name.
* Fixes issues with binary characters in compiled templates.
* Supports overloaded methods for variable extraction.
* Avoids signature issues with CompileWithRenderStatic.
* Works around PCRE regression issues on affected platforms.

Change-Id: I2b766ccc9bf3eaae77b1dfc1a73e9acc2a88d8a9
Resolves: #89110
Releases: master, 9.5, 8.7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61642
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[TASK] Use SiteFinder directly in SlugHelper 78/61778/3
Benni Mack [Mon, 23 Sep 2019 11:27:58 +0000 (13:27 +0200)]
[TASK] Use SiteFinder directly in SlugHelper

Handling Sites via SiteMatcher is not necessary anymore,
as the SiteFinder does all the logic already, except for flushing
the rootline caches. The main reason (moving pages within DataHandler)
can be managed by adding this functionality into SlugHelper directly.

Resolves: #89225
Releases: master
Change-Id: I0e3fe151ebb99a154900f3335bef4a1db92ca4bf
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61778
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
2 months ago[BUGFIX] Do not assign variables to removed property 80/61780/4
Benni Mack [Mon, 23 Sep 2019 11:56:13 +0000 (13:56 +0200)]
[BUGFIX] Do not assign variables to removed property

The new IPlocker (supporting IPv6) also removed the public property
AbstractUserAuthentication->lockIP.

However, the original assignments are still in place, as they were forgotten
before the 10.0 release.

The change removes the two assignments.

Resolves: #89226
Releases: master
Change-Id: I9fb7bc2c5dbf523a13e6ba6faa0cd51fe3beffdc
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61780
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[TASK] Deprecate jquery.clearable 58/61758/9
Andreas Fernandez [Thu, 19 Sep 2019 09:00:08 +0000 (11:00 +0200)]
[TASK] Deprecate jquery.clearable

To slim down the usage of jQuery even further a bit, the jQuery plugin
`jquery.clearable` has been marked as deprecated. A new plugin
`TYPO3/CMS/Backend/Input/Clearable` may be used instead.

The new plugin extends the prototype of `HTMLInputElement` by a new
function called `clearable`.

Resolves: #89215
Releases: master
Change-Id: Id6e64b983561af0327cc3308499756b8fafbc883
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61758
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
2 months ago[BUGFIX] Adapt flexform container EventListener registration 56/61756/5
Henrik Elsner [Wed, 18 Sep 2019 15:24:19 +0000 (17:24 +0200)]
[BUGFIX] Adapt flexform container EventListener registration

Enables the functionality to add an inline element inside of
an unsaved inline element

Resolves: #89201
Releases: master, 9.5, 8.7
Change-Id: I077c75326b021b9bacc53d10c9584659391726ce
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61756
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[BUGFIX] Remove double json_decode call 22/61622/3
Devid Messner [Wed, 4 Sep 2019 14:57:57 +0000 (16:57 +0200)]
[BUGFIX] Remove double json_decode call

Avoids an exeption about incompatible type to the call, caused by double encoding.

Resolves: #89081
Releases: master, 9.5

Change-Id: Ia974227f0e9ca68a8f37a0e205bda1f27f015c7f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61622
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
2 months ago[TASK] Incorporate ES 6 features 49/61649/7
Andreas Fernandez [Mon, 9 Sep 2019 14:37:43 +0000 (16:37 +0200)]
[TASK] Incorporate ES 6 features

Since the build chain can generate ES6, the TypeScript code should
incorporate these changes.

Namely, this patch changes:
- Use native NodeList over arrays generated by Array.from() where
  possible
- Use explicit string search functions instead of indexOf

Resolves: #89118
Releases: master
Change-Id: I6e03ade35c545ece05ecca222cd1fde876fc22d4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61649
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[TASK] Add missing closing quote in doc comment 75/61775/3
Naderio [Mon, 23 Sep 2019 10:03:51 +0000 (10:03 +0000)]
[TASK] Add missing closing quote in doc comment

Added missing closing quote in cObjGetSingle-docblock

Releases: master
Resolves: #89224
Change-Id: If35976e5e2236fbf6209349c9ee346f52f5d3ac3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61775
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[TASK] Remove obsolet PHPDoc parts 73/61773/5
Oliver Bartsch [Sun, 22 Sep 2019 15:38:29 +0000 (17:38 +0200)]
[TASK] Remove obsolet PHPDoc parts

The PHPDocs of GeneralUtility::_GET and GeneralUtility::_POST
have been revised. In detail, statements have been removed
that those methods would strip slashes and should `ALWAYS` be used.

Resolves: #89221
Releases: master, 9.5
Change-Id: Ic05f31998b8af5205cd6847c403b95172eeb709a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61773
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
2 months ago[TASK] Improve PHPDoc of GeneralUtility::_GP 74/61774/3
Oliver Bartsch [Sun, 22 Sep 2019 18:28:01 +0000 (20:28 +0200)]
[TASK] Improve PHPDoc of GeneralUtility::_GP

The PHPDoc of GeneralUtility::_GP has been revised.
In detail, the outdated and misleading part about security
has been removed and the return annotation now also
includes NULL as possible return type.

Resolves: #89222
Releases: master, 9.5
Change-Id: Iccfbfc43b15b28c035f5e93805d41e858b816d6a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61774
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
2 months ago[BUGFIX] Fix tag consistency of FSC DropIn partials 63/61763/2
Claus Due [Thu, 19 Sep 2019 18:38:51 +0000 (20:38 +0200)]
[BUGFIX] Fix tag consistency of FSC DropIn partials

Fixes a missing closing tag which makes (X)HTML
validation fail and causes Fluid 3.0 to report a
parsing error in the templates.

Resolves: #89210
Releases: master, 9.5, 8.7
Change-Id: Ia8fe59df2f92761ba44ac649bd6907fa2c58ab66
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61763
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 months ago[BUGFIX] Avoid using non-API functionality for workspaces 83/60483/9
Benni Mack [Tue, 16 Apr 2019 05:38:03 +0000 (07:38 +0200)]
[BUGFIX] Avoid using non-API functionality for workspaces

BackendUser has some tight integration with workspaces, however
it also contains some legacy non-workspace related functionality
whereas checks against $pid is done for branch versioning.

This has been removed and some new internal methods are
now used with a clearer return value and internal code structure.

Resolves: #88155
Releases: master
Change-Id: I7b902085e53bd6bd8a8522df4815d31482468102
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60483
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Achim Fritz <af@achimfritz.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
2 months ago[DOCS] Remove unused include file from EXT:form docs 69/61769/3
Frank Naegler [Fri, 20 Sep 2019 10:28:45 +0000 (12:28 +0200)]
[DOCS] Remove unused include file from EXT:form docs

With #89129 the containerClassAttribute.rst include for Fieldset
was removed but the file which is now unused was not removed.

Reaolves: #89214
Related: #89129
Releases: master
Change-Id: Ib0055bcf3f8f9d256b50c167b37d454ebed145b2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61769
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
2 months ago[DOCS] Remove unused Fieldset property in documentation of EXT:form 60/61660/7
Elias Häußler [Tue, 10 Sep 2019 13:43:08 +0000 (13:43 +0000)]
[DOCS] Remove unused Fieldset property in documentation of EXT:form

The "containerClassAttribute" property is not respected by elements of
type "Fieldset" as the partial "Field/Field" takes care of its
rendering. Therefore, it has been removed from the official documentation
to avoid confusions.

Releases: master, 9.5, 8.7
Resolves: #89129
Change-Id: I5f2ed92ad2477a0eed20dcd8ad402e7894e568ee
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61660
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
2 months ago[DOCS] Added missing brackets 54/61754/3
someplace53 [Wed, 18 Sep 2019 13:11:40 +0000 (13:11 +0000)]
[DOCS] Added missing brackets

Since includeCssFiles and includeJsFiles are registered as arrays,
the given types in the example should be arrays, too.

Releases: master, 9.5
Resolves: #89200
Change-Id: Ic9ba160deb01bd4f2f86484ff2d8da517d417fc1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61754
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
2 months ago[FEATURE] Provide implementation for PSR-17 HTTP Message Factories 58/61558/17
Benjamin Franzke [Mon, 26 Aug 2019 12:11:18 +0000 (14:11 +0200)]
[FEATURE] Provide implementation for PSR-17 HTTP Message Factories

Support for PSR-17 HTTP Message Factories has been added.

PSR-17 HTTP Factories are intended to be used by PSR-15 request handlers
in order to create PSR-7 compatible message objects.

Classes may use dependency injection to use any of the available PSR-17
HTTP Factory interfaces.

The Request/Response base class (Message) is adapted to be able to lazily
initialize a stream when getBody() is called.
This is done as the PSR (Stream)RequestFactoryInterface does not allow
to control Stream properties. Therefore it is a performance
optimization to defer initialization. It is likely, that a new
Stream will be added to a Request with withStream() anyway.
(Which would mean resources for the intermediate stream would have
been wasted)

Furthermore some DocBlocks are adapted to reflect the variadic
UriInterface/StreamInterface parameters that are already handled in
code but were not documented. These cases are needed/required
by the PSR-17 factory implementation now.

composer require psr/http-factory:^1.0

Releases: master
Resolves: #89018
Change-Id: Ie6b9d865679bbf6f5d3d030b0ed1a3f277c47a3d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61558
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
2 months ago[BUGFIX] Fix wrong PSR-11 related deprecation messages in ObjectManager 60/61760/3
Benjamin Franzke [Thu, 19 Sep 2019 08:34:23 +0000 (10:34 +0200)]
[BUGFIX] Fix wrong PSR-11 related deprecation messages in ObjectManager

Due to an inverse condition the deprecation message that constructor
arguments shoud *not* be passed was triggered when actually no arguments
where passed.

Also fix the generation of the related non-object exception, the
string concatenation used a wrong variable name.

Change-Id: Icb387b666d2bf249e34eb7bae2d1ed9b3382a8b4
Releases: master
Resolves: #89207
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61760
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
2 months ago[FEATURE] Translate Indexed Search Configuration Titles 46/61446/3
Benni Mack [Mon, 5 Aug 2019 15:25:04 +0000 (17:25 +0200)]
[FEATURE] Translate Indexed Search Configuration Titles

Allows to override index_config titles that are
rendered in the dropdown of the Form in Indexed Search
and as headline when a configuration is selected.

Resolves: #9070
Releases: master
Change-Id: I1b013af529ba4985266535b2955bf4a32bba9ebd
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61446
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Daniel Gorges <daniel.gorges@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.com>
Reviewed-by: Benni Mack <benni@typo3.org>
2 months ago[TASK] Show TCAdefaults configuration in info module 62/61762/3
Georg Ringer [Thu, 19 Sep 2019 15:10:11 +0000 (17:10 +0200)]
[TASK] Show TCAdefaults configuration in info module

The info module must show potential TSconfig values of TCAdefaults.

Resolves: #89196
Releases: master, 9.5
Change-Id: I0ac8c90517a4ba5a9ab1f7c397f8ea5a964ae273
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61762
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Josef Glatz <josefglatz@gmail.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Josef Glatz <josefglatz@gmail.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
2 months ago[BUGFIX] Handle base paths with mixed FQDN and "/" 50/61650/7
Benni Mack [Mon, 9 Sep 2019 15:24:53 +0000 (17:24 +0200)]
[BUGFIX] Handle base paths with mixed FQDN and "/"

If a site has "/" as its entrypoint but the languages
have FQDNs or subdomains or a mixture between subdomain
the base without domain always gets found and the subdomains
are not considered.

Currently this situation is handled in
  SiteMatcher->getRouteCollectionForAllSites()
which does not fit a certain scheme if there is a mixture.

This change corrects this and adds tests to handle any cases:

- just / as base, and then /de and /en as language base
- just / as base, and then subdmoains or full domains+path as language base
- a full URL as base, and then path parts as language base
- a full URL as base and then full URLs + subdomains as language base
- Also check for http and http variants.

Resolves: #89183
Releases: master, 9.5
Change-Id: If570118ac371e1a1589f064605c0176a53220f0f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61650
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Daniel Gorges <daniel.gorges@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.com>
Reviewed-by: Benni Mack <benni@typo3.org>
2 months ago[TASK] Update @typo3/icons to 1.10.0 59/61759/2
Benjamin Kott [Thu, 19 Sep 2019 11:33:58 +0000 (13:33 +0200)]
[TASK] Update @typo3/icons to 1.10.0

Executed tasks:
  cd Build
  yarn add -D @typo3/icons@1.10.0
  yarn build

Resolves: #89206
Releases: master
Change-Id: I47ae87e522acdce57e07804c46e3b8b8f29bc848
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61759
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[DOCS] Remove eliminated scheduler configuration setting 57/61757/3
Chris Müller [Wed, 18 Sep 2019 19:20:53 +0000 (21:20 +0200)]
[DOCS] Remove eliminated scheduler configuration setting

Remove the eliminated extension configuration option "enableBELog" in
the documentation.

Additionally the unused language setting for extension configuration
"scheduler.config.listShowTaskDescriptionAsHover" was deleted.

Resolves: #89202
Relates: #83866
Releases: master, 9.5
Change-Id: I6b2b343d1a07f158edf72803acd791ff891c6a32
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61757
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
2 months ago[BUGFIX] Ensure FormEngine IRRE handles relations in workspace 90/60890/10
Benni Mack [Thu, 6 Jun 2019 06:44:19 +0000 (08:44 +0200)]
[BUGFIX] Ensure FormEngine IRRE handles relations in workspace

FormEngine does not show and handle IRRE records when they are
deleted (connected records from the live workspace are shown).

When removal and refactoring of code in this ares was done for
v9, "too much" code got removed. Which is why workspace overlays
are not handled properly anymore.

In addition, the ElementInformationController now correctly
resolves a workspace record when finding the pageInfo and access.

Resolves: #88502
Related: #82634
Releases: master, 9.5
Change-Id: Ib2d70ffa92c78752626b43ec5012d9dba036e7b8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60890
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Achim Fritz <af@achimfritz.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Achim Fritz <af@achimfritz.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
2 months ago[BUGFIX] Use correct log level integer / strings in admin panel 93/61693/3
Susanne Moog [Thu, 12 Sep 2019 07:57:09 +0000 (09:57 +0200)]
[BUGFIX] Use correct log level integer / strings in admin panel

Since #88799 the wrong log levels were used for configuration and
level comparison (strings where ints were required, ints where strings
should have been). The patch streamlines the use of the log levels to
re-introduce a working log module.

Resolves: #89155
Releases: master
Change-Id: I1faf2b8df77fd6e412eea7cb63180026e6c19969
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61693
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
2 months ago[BUGFIX] Fix comment typo in Check.php 52/61752/2
Christian Eßl [Wed, 18 Sep 2019 10:55:42 +0000 (12:55 +0200)]
[BUGFIX] Fix comment typo in Check.php

Fixes a small comment typo in the checkGdLibJpgSupport function,
replacing "jgp" with "jpg".

Resolves: #89198
Releases: master, 9.5
Change-Id: I9c0cafda7a000b5e0d801cb12af361f2c70467d3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61752
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[BUGFIX] Re-apply sorting after workspaces in FileRepository 14/61714/4
Benni Mack [Tue, 17 Sep 2019 06:57:26 +0000 (08:57 +0200)]
[BUGFIX] Re-apply sorting after workspaces in FileRepository

When in workspace mode, overlays are made but if there is
a different sorting (reordering of items in a workspace), the
FileRepository does not consider this, as the workspace
overlays are applied later-on.

As this patch is making Workspaces with FAL finally usable, and is
non-intrusive, and fixes a minor data / repository
issue, I consider backporting this down to 8.7 as well.

Resolves: #71973
Releases: master, 9.5, 8.7
Change-Id: Ie230558242e3ebfef541e8eb969fa21dd15708af
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61714
Tested-by: Achim Fritz <af@achimfritz.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Achim Fritz <af@achimfritz.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
2 months ago[BUGFIX] Generate notification action on rendering 06/61706/7
Andreas Fernandez [Sat, 14 Sep 2019 08:05:14 +0000 (10:05 +0200)]
[BUGFIX] Generate notification action on rendering

Due to scoping issues if a notification is generated in an iframe, the
actions are now generated when the notification is rendered.

This requires a change how the payload is passed to the notification,
instead of the action instance it now contains the action type and the
callback. The action instance is generated by a factory class.

To bypass issues with browser's garbage collection that kicks in when an
iframe changes, the callback methods are stringified and immediately
recovered by eval().

Resolves: #89173
Releases: master
Change-Id: I45624a26bad1527f9d6222ad10e1f9a1384ee07e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61706
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
2 months ago[BUGFIX] Set proper default value for unavailable redirect report 05/61705/2
Andreas Fernandez [Sat, 14 Sep 2019 07:03:26 +0000 (09:03 +0200)]
[BUGFIX] Set proper default value for unavailable redirect report

In case the redirect integrity check has never been executed before, the
code now uses an empty array as fallback value to fix issues with wrong
variable types.

Additionaly, a repeated typo has been fixed.

Resolves: #89172
Releases: master
Change-Id: Ib3f2815ad355dc9d8161c845f3b0dba9efc07ce9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61705
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Michael Schams <typo3@2018.schams.net>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
3 months ago[TASK] Remove further evaluations of pid=-1 69/61669/6
Benni Mack [Thu, 12 Sep 2019 05:37:54 +0000 (07:37 +0200)]
[TASK] Remove further evaluations of pid=-1

There are a few spots in TYPO3 Core where manual
queries are built, and the WorkspaceRestriction
would just work as dropin now.

In addition, some few changes are adapted to check
for t3ver_oid instead of "pid".

Resolves: #89157
Releases: master
Change-Id: I9d3a6f132ba20c0c603a6ab1664adf9d1dc06fd9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61669
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Achim Fritz <af@achimfritz.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
3 months ago[TASK] Edit Site Settings in Site Module 61/61661/22
Susanne Moog [Fri, 13 Sep 2019 07:36:20 +0000 (09:36 +0200)]
[TASK] Edit Site Settings in Site Module

Extensions can ship their own site settings default values,
that get provided to all available site configurations.

A UI in sites module enables the user to edit all values
from any active extension in the system. Inactive extension
settings will be preserved in the site settings for later recovery.

Resolves: #89134
Releases: master
Change-Id: I6bb4335460ccb5f6b0f609f4f0876507804d5821
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61661
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
3 months ago[BUGFIX] Keep workspace ID when discarding versioned records 71/61671/15
Oliver Hader [Thu, 12 Sep 2019 09:44:56 +0000 (11:44 +0200)]
[BUGFIX] Keep workspace ID when discarding versioned records

When a record was modified in a workspace, and then discarded, TYPO3 previously
set the t3ver_wsid to "0", which basically meant "we release it to live workspace
as a offline version with pid=-1".

However, this turns out to be ugly, as this information is then floating in live workspace,
without any information where this record was from.

Instead, "discarding versioned records" now keeps the t3ver_wsid=X, and just marks
the versioned record as "deleted" - or removes it completely if the database table
does not support to mark records as deleted.

As a result, there will be no records in live workspace anymore with "pid=-1" in the future
anymore. To remove any "old" discarded records, an upgrade wizard will follow
in a followup patch.

Resolves: #89166
Releases: master
Change-Id: I8ccab3cd2053c27d9b0ecd9f171a83b9097f29dd
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61671
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Daniel Gorges <daniel.gorges@b13.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[BUGFIX] Disallow phpdocumentor/reflection-docblock >= 4.3.2 02/61702/7
Andreas Fernandez [Fri, 13 Sep 2019 10:09:09 +0000 (12:09 +0200)]
[BUGFIX] Disallow phpdocumentor/reflection-docblock >= 4.3.2

The package phpdocumentor/reflection-docblock introduces major regressions
starting with 4.3.2 that leads to getting nullable compound types (e.g.
`?string|int`) parsed completely wrong, which currently also breaks in
symfony/property-info.

Also, it became stricter about type annotations which currently collides
with Fluid.

For this reason, the package is marked as conflicting starting with
version 4.3.2.

Resolves: #89167
Releases: master
Change-Id: Ife9d14c01de5bea2179dafc572820f292039a202
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61702
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 months ago[BUGFIX] Check for plain integer values in QueryGenerator::cleanInputVal() 70/61670/6
Andreas Fernandez [Thu, 12 Sep 2019 06:22:42 +0000 (08:22 +0200)]
[BUGFIX] Check for plain integer values in QueryGenerator::cleanInputVal()

Incoming field values are now also checked for being plain integers to
be able to handle timestamps properly.

Resolves: #89154
Related: #84588
Releases: master, 9.5
Change-Id: I220096faa563b3700eceb8a85839eed2a70d2170
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61670
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>