Packages/TYPO3.CMS.git
4 years ago[BUGFIX] Prevent Javascript loop for RTE-enabled fields 60/36860/11
Stanislas Rolland [Sat, 14 Feb 2015 18:40:25 +0000 (13:40 -0500)]
[BUGFIX] Prevent Javascript loop for RTE-enabled fields

Problem: If a collapsed IRRE element with a RTE-enabled field is added,
a JavaScript loop is triggered because of missing widths of the select
fields within the RTE toolbar. This is caused by change in the way IRRE
nested inline elements are made visible using class attribute rather than
display property of style attribute. This also applies to new tab menus.
The change also affects the properties of the nested elements whose
mutations must be observe in order to detect when the RTE iframe becomes
visible.
Solution: Adjust the list of attributes to be observed on nested inline
elements. Adjust also detection of nested elements visibility state as
well as the walk to make them hidden with the visibility property of
the style attribute while the RTE framework is being rendered.

There is also a check added for TYPO3.settings.Textarea that is not
present when RTE fields are hidden by DisplayCond for a child element
that gets expanded/opened.

Releases: master
Resolves: #64930
Change-Id: I6f3bea4e9e72c33f2ae773734e9e6d794fe38ee9
Reviewed-on: http://review.typo3.org/36860
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] Fix broken combobox styling 55/36955/2
Andreas Fernandez [Mon, 16 Feb 2015 19:28:34 +0000 (20:28 +0100)]
[BUGFIX] Fix broken combobox styling

Add a lightgrey background color to ExtJS comboboxes.

Resolves: #65101
Releases: master
Change-Id: I31e51b75d44794f09d6087e014816031db8c8ba1
Reviewed-on: http://review.typo3.org/36955
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Remove duplicate quotes from clickmenu "hide" 53/36953/2
Mathias Schreiber [Mon, 16 Feb 2015 17:27:46 +0000 (18:27 +0100)]
[BUGFIX] Remove duplicate quotes from clickmenu "hide"

Rebuilding the clickmenu resulted in a small typo with double quotes
leading to a JS error if clickmenu hide was clicked.

Resolves: #65098
Releases: master
Change-Id: I93c36542b2915eafb60eb6d9e7ea93214ffd2cfc
Reviewed-on: http://review.typo3.org/36953
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Initialize DateTimePicker on IRRE fields 44/36944/2
Andreas Fernandez [Mon, 16 Feb 2015 13:50:07 +0000 (14:50 +0100)]
[BUGFIX] Initialize DateTimePicker on IRRE fields

Reinitialize the DateTimePicker properly by calling the initialize()
method in the callback.

Resolves: #65092
Releases: master
Change-Id: I653dab6d476f6cf65d7739c05141fc73f7217027
Reviewed-on: http://review.typo3.org/36944
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] foreign_selector size > 1 create new relation link is not needed 96/36596/6
Andreas Allacher [Mon, 2 Feb 2015 07:16:26 +0000 (08:16 +0100)]
[BUGFIX] foreign_selector size > 1 create new relation link is not needed

if there are inline records with a foreign_selector that has a size > 1
there is no need for the create new relation link and it is only puzzling
to users.

Change-Id: Id2dba765e57cd9e724f7c4b88eb1199b7e7e9028
Resolves: #64728
Releases: master
Reviewed-on: http://review.typo3.org/36596
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
4 years ago[FOLLOWUP] Add TOC for 7.1 Changelog 25/36925/3
Francois Suter [Sun, 15 Feb 2015 20:09:01 +0000 (21:09 +0100)]
[FOLLOWUP] Add TOC for 7.1 Changelog

A table of contents must be added to "core" extensions's
documentation in order to be able to navigate through
the 7.1 Changelog items.

Additionnally some small reST markup errors are fixed.

Resolves: #65088
Releases: master
Change-Id: Ia0dc87a8e3543e982511603363246d1587507def
Reviewed-on: http://review.typo3.org/36925
Reviewed-by: Francois Suter <francois@typo3.org>
Tested-by: Francois Suter <francois@typo3.org>
4 years ago[BUGFIX] ElementBrowser: Show triggered flash messages 14/36914/2
Nicole Cordes [Sat, 14 Feb 2015 20:57:01 +0000 (21:57 +0100)]
[BUGFIX] ElementBrowser: Show triggered flash messages

If you try to add a new folder with empty name or an error during the
file upload happens, a FlashMessage is generated and added to the
FlashMessageQueue but not display within the ElementBrowser. The patch
adds output of the FlashMessageQueue above the navigation.

Releases: master, 6.2
Resolves: #65075
Change-Id: I9196fce917893ff04aad55a7f96c57a0b09f4fc3
Reviewed-on: http://review.typo3.org/36914
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] ElementBrowser: Fix JS error after folder creation 12/36912/3
Nicole Cordes [Sat, 14 Feb 2015 19:45:42 +0000 (20:45 +0100)]
[BUGFIX] ElementBrowser: Fix JS error after folder creation

Add missing parameters in returnUrl to prevent a Javascript error
blocking all further Javascript execution.

Releases: master, 6.2
Resolves: #65074
Change-Id: I34cb27eaf9678b6bab1297b579fec3a6d5385149
Reviewed-on: http://review.typo3.org/36912
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Make sure orig file is not removed when deleting processed files 55/36855/6
Frans Saris [Thu, 12 Feb 2015 10:04:36 +0000 (11:04 +0100)]
[BUGFIX] Make sure orig file is not removed when deleting processed files

A processed file only needs to be deleted from storage if it has its
own identifier.

Releases: master, 6.2
Resolves: #65021
Change-Id: I76c3f1afa6ba7fa5d8898f7281bef78f1ccb4a35
Reviewed-on: http://review.typo3.org/36855
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[BUGFIX] DatePicker can't handle minDate and maxDate 92/36892/3
Nicole Cordes [Fri, 13 Feb 2015 22:46:40 +0000 (23:46 +0100)]
[BUGFIX] DatePicker can't handle minDate and maxDate

The Bootstrap DatePicker expects the min and max dates to be formatted
in the format defined in the options. Currently both dates are filled
with an unix timestamp. These can't be converted to a date object (moment
object) and the date picker is completely disabled.

This patch adds the conversion of unix timestamp to the right format
before the Bootstrap DatePicker is initialized.

Releases: master
Resolves: #65068
Change-Id: Ie8143efb537067dd89cfb42aa477f63b8c07f693
Reviewed-on: http://review.typo3.org/36892
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] ElementBrowser: After file upload no file can be selected 03/36903/3
Wouter Wolters [Sat, 14 Feb 2015 13:19:06 +0000 (14:19 +0100)]
[BUGFIX] ElementBrowser: After file upload no file can be selected

Resolves: #65027
Releases: master, 6.2
Change-Id: I6df1361be3572497fadcea321b6d8d7f000062e0
Reviewed-on: http://review.typo3.org/36903
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Re-fix new content element wizard links click area 77/36877/2
Mathias Brodala [Fri, 13 Feb 2015 13:39:41 +0000 (14:39 +0100)]
[BUGFIX] Re-fix new content element wizard links click area

This fixes a regression introduced with #64892 and makes the
whole link area clickable again.

Resolves: #65058
Releases: master
Change-Id: I7e3c1bb19f1ed7148a2cd901ee23abf1f97aa04a
Reviewed-on: http://review.typo3.org/36877
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Do not call bidir_htmlspecialchars as static function 86/36886/4
Andreas Müller [Fri, 13 Feb 2015 20:23:31 +0000 (20:23 +0000)]
[BUGFIX] Do not call bidir_htmlspecialchars as static function

The static call of bidir_htmlspecialchars throws a notice.
Just refactored the code to use the class instance instead.

Resolves: #64827
Releases: master, 6.2
Change-Id: I384646ccb07c05e5db76100228f3bb61c2a07d93
Reviewed-on: http://review.typo3.org/36886
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUFGIX] Add modification time to processedfile checksum 30/36530/4
ruud [Sat, 31 Jan 2015 16:59:10 +0000 (17:59 +0100)]
[BUFGIX] Add modification time to processedfile checksum

Added modification time to processed file checksum so the filename of
the processed files changes when the original is replaced.

Resolves: #44645
Releases: master, 6.2
Change-Id: I12bf445ee2a75a9a69b3d8e9603ae5035028a195
Reviewed-on: http://review.typo3.org/36530
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Philipp Thiele <philipp.thiele@phth.de>
Tested-by: Philipp Thiele <philipp.thiele@phth.de>
Tested-by: Andrea Herzog-Kienast <a.herzog@kienastdv.de>
Reviewed-by: Roman Schürmann <roman.schuermann@wmdb.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
4 years ago[TASK] Disable ms-clear pseudo element 76/36876/2
Benjamin Kott [Fri, 13 Feb 2015 13:02:00 +0000 (14:02 +0100)]
[TASK] Disable ms-clear pseudo element

The ms-clear pseudo element was introduced in IE10
to provide an easy way to clear inputfields that are not empty
and focused. To avoid confusion we disable this feature
and keep the implementation of the current clearable.

Releases: master
Resolves: #65057
Change-Id: I15f83e395de58c03c677bb1a2f50a7ae1ffe4668
Reviewed-on: http://review.typo3.org/36876
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Element browser: correct the display of current link to file 42/36842/3
Stanislas Rolland [Wed, 11 Feb 2015 16:49:32 +0000 (11:49 -0500)]
[BUGFIX] Element browser: correct the display of current link to file

When editing a file link with the element browser wizard,
it is possible to navigate to other tabs. In tabs other than file or
folder, the current link to the file was shown as a simple id rather
than as a path to the file, like in the file or folder tabs.

Releases: master
Resolves: #65012
Change-Id: I79845506b0c5cdb2e956b56b6b505e581df446c7
Reviewed-on: http://review.typo3.org/36842
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Proofread and move 7.1 documentation 44/36844/5
Mathias Schreiber [Wed, 11 Feb 2015 17:14:08 +0000 (18:14 +0100)]
[TASK] Proofread and move 7.1 documentation

Resolves: #65013
Releases: master
Change-Id: Ic274247154c3594b89c270c0fdb52110f0d567ef
Reviewed-on: http://review.typo3.org/36844
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[FOLLOWUP][BUGFIX] Only write out one shortcut tag 56/36856/2
Markus Klein [Thu, 12 Feb 2015 10:13:32 +0000 (11:13 +0100)]
[FOLLOWUP][BUGFIX] Only write out one shortcut tag

Fix failing functional test.

Resolves: #24479
Releases: master
Change-Id: I05e0c292a66f90b377c3bd97491ec82eeafe6ed2
Reviewed-on: http://review.typo3.org/36856
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[BUGFIX] Fix margin of #typo3-curURL 54/36854/2
Andreas Fernandez [Thu, 12 Feb 2015 08:15:56 +0000 (09:15 +0100)]
[BUGFIX] Fix margin of #typo3-curURL

Correct margin of the table used in the link wizards.

Resolves: #65019
Releases: master
Change-Id: Id9d3da2f2c2a572a975c71f1232bf3378ed73f0d
Reviewed-on: http://review.typo3.org/36854
Reviewed-by: Felix Kopp <felix-source@phorax.com>
Tested-by: Felix Kopp <felix-source@phorax.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
4 years ago[BUGFIX] Only write out one shortcut tag 62/36762/2
Frederic Gaus [Mon, 9 Feb 2015 09:57:35 +0000 (10:57 +0100)]
[BUGFIX] Only write out one shortcut tag

Only write out one shortcut tag with <link rel="shortcut icon" ..>. This is fine
for all standards-compliant browsers and for IE. So not need to write out
two link tags.

Change-Id: I396fe5145237df9c88cd57965cd144faf769e017
Resolves: #24479
Releases: master
Reviewed-on: http://review.typo3.org/36762
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] RTE: Image modify dialogue: keep the current image tab 43/36843/3
Stanislas Rolland [Wed, 11 Feb 2015 16:58:43 +0000 (11:58 -0500)]
[BUGFIX] RTE: Image modify dialogue: keep the current image tab

When there is a current image, it should be possible to come back
to the current image tab after visiting the other tabs.

Follow-up to: https://review.typo3.org/#/c/36839/

Releases: master
Resolves: #65009
Change-Id: Ib8a8f7125b6f1c8c8759c31b6c625632b281e663
Reviewed-on: http://review.typo3.org/36843
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] RTE: Image modify dialogue: keep the current image tab 39/36839/2
Stanislas Rolland [Wed, 11 Feb 2015 16:27:14 +0000 (11:27 -0500)]
[BUGFIX] RTE: Image modify dialogue: keep the current image tab

When there is a current image, it should be possible to come back
to the current image tab after visiting the other tabs.

Releases: master
Resolves: #65009
Change-Id: I6a2b362bbe136201c37718423fe2a8a183222871
Reviewed-on: http://review.typo3.org/36839
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] RTE Link dialogue should not forward attributes between tabs 16/36816/2
Stanislas Rolland [Wed, 11 Feb 2015 04:12:07 +0000 (23:12 -0500)]
[BUGFIX] RTE Link dialogue should not forward attributes between tabs

When switching tabs in the RTE link dialogue, attributes should not be
forwarded as different defaults may be set for different types of links.

Releases: master
Resolves: #64977
Change-Id: Ifbf9032f4a99fda119405d8b86535fe2b0cd3e4b
Reviewed-on: http://review.typo3.org/36816
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] Use saltedpasswords for scheduler user creation 60/36760/4
Markus Klein [Mon, 9 Feb 2015 09:54:08 +0000 (10:54 +0100)]
[BUGFIX] Use saltedpasswords for scheduler user creation

Remove the hardcoded md5-hashing and let saltedpasswords do that for us.

Resolves: #64936
Releases: master, 6.2
Change-Id: I608a2106690d64b3ac64a5657d6b4ffa4be721a1
Reviewed-on: http://review.typo3.org/36760
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frederic Gaus <gaus@flagbit.de>
Tested-by: Frederic Gaus <gaus@flagbit.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Correctly store values of select fields 13/36813/8
Nicole Cordes [Tue, 10 Feb 2015 21:58:29 +0000 (22:58 +0100)]
[BUGFIX] Correctly store values of select fields

Due to a wrong position of the hidden helper field, the values of select
boxes aren't submitted. This patch removes the hidden field as it is
unused anyway.

Furthermore a double encoding of the option value is prevented.

Releases: master
Resolves: #64878
Change-Id: I3b24dd7c8fca41c01748efdeded3356ba9740a42
Reviewed-on: http://review.typo3.org/36813
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Frederic Gaus <gaus@flagbit.de>
Tested-by: Frederic Gaus <gaus@flagbit.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
4 years ago[BUGFIX] Correct typoscript log message in USER cObj 18/36818/3
Frederic Gaus [Wed, 11 Feb 2015 07:46:17 +0000 (08:46 +0100)]
[BUGFIX] Correct typoscript log message in USER cObj

Correct typoscript log message in UserContentObject

Change-Id: I5a36e4d67278f96fa6cfd269fc7efbbb0df0b7bf
Resolves: #64979
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/36818
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[FEATURE] RTE: Add property buttons.link.type.properties.target.default 57/36757/2
Stanislas Rolland [Mon, 9 Feb 2015 04:22:04 +0000 (23:22 -0500)]
[FEATURE] RTE: Add property buttons.link.type.properties.target.default

New RTE configuration property
buttons.link.[*type*].properties.target.default
may be used in Page TSconfig to configure a default target for links
of a given type.

Releases: master
Resolves: #59646
Change-Id: I26348562120630c98b709a399aa3663b5f33729e
Reviewed-on: http://review.typo3.org/36757
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[TASK] Edit metadata on file link click 89/36789/5
Andreas Fernandez [Tue, 10 Feb 2015 09:16:22 +0000 (10:16 +0100)]
[TASK] Edit metadata on file link click

This patch changes the behaviour in the filelist module: Clicking the
filename now opens the metadata editor. A new button is added, that
shows the image on click.

Resolves: #63231
Releases: master
Change-Id: I3c3b8c539971b5fcd0575c8f2aa3d808a6a953ec
Reviewed-on: http://review.typo3.org/36789
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
4 years ago[BUGFIX] Exclude some vars from serialization 23/36723/5
Helmut Hummel [Fri, 6 Feb 2015 20:52:46 +0000 (21:52 +0100)]
[BUGFIX] Exclude some vars from serialization

This voids the serialization of TSFE and currentFile with the
ContentObjectRenderer in UserInternalContentObject.

Releases: master
Resolves: #64916
Change-Id: I2ce74ee0960d33b39dec51c2f6150d79a113d5fe
Reviewed-on: http://review.typo3.org/36723
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
4 years ago[BUGFIX] Catch possible NULL values to avoid exception 87/36787/3
Andreas Fernandez [Tue, 10 Feb 2015 08:16:34 +0000 (09:16 +0100)]
[BUGFIX] Catch possible NULL values to avoid exception

If references are not maintained properly, all reference information
may be NULL or empty string (depending on it's type). Catch NULL values
and return early.

Resolves: #64955
Releases: master, 6.2
Change-Id: Id525e011f7b70190bc8f1f0c27e8c4b091325304
Reviewed-on: http://review.typo3.org/36787
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
4 years ago[TASK] Apply quoteJSvalue or htmlspecialchars to getModuleUrl 97/36697/6
Wouter Wolters [Thu, 5 Feb 2015 22:32:31 +0000 (23:32 +0100)]
[TASK] Apply quoteJSvalue or htmlspecialchars to getModuleUrl

Furthermore add BACK_PATH as 3rd argument where appropriate.

Resolves: #64896
Releases: master
Change-Id: Icd52343246c7aa57114f7d3e22f9a16ea65567c9
Reviewed-on: http://review.typo3.org/36697
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
4 years ago[TASK] Add migration wizard for backend shortcuts 56/36756/4
Wouter Wolters [Sun, 8 Feb 2015 22:16:18 +0000 (23:16 +0100)]
[TASK] Add migration wizard for backend shortcuts

Resolves: #61477
Releases: master
Change-Id: Icafa17b2e2927273faf23ca115f632d9718e8ebe
Reviewed-on: http://review.typo3.org/36756
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Ensure using jQuery objects in IRRE handling 32/36732/5
Nicole Cordes [Sat, 7 Feb 2015 19:29:45 +0000 (20:29 +0100)]
[BUGFIX] Ensure using jQuery objects in IRRE handling

Certain Javascript functions for IRRE handling expect jQuery objects
as parameter.
This patch ensures to convert objects from HTML to jQuery.

Furthermore one forgotten objectId encoding is added to find a jQuery
object by its id.

Releases: master
Resolves: #64846
Change-Id: I8edb4f6a891c972a3d679595c1bf456bbed9bad2
Reviewed-on: http://review.typo3.org/36732
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[TASK] Check PCRE version in SystemEnvironment/Check 84/36784/5
Stephan Großberndt [Mon, 9 Feb 2015 19:35:36 +0000 (20:35 +0100)]
[TASK] Check PCRE version in SystemEnvironment/Check

Certain regular expressions passed to PCRE library < 8.30
can trigger a PHP segfault. This patch introduces an additional
system environment check to verify the PCRE version is
>= 8.30 (default shipped with PHP 5.5).

Resolves: #64950
Related: #62463
Releases: master
Change-Id: I3725c67f2b8e99941f0c6eb82a64d646025a1b85
Reviewed-on: http://review.typo3.org/36784
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Adapt sorting arrows in EXT:filelist to Font Awesome 71/36771/3
Andreas Fernandez [Mon, 9 Feb 2015 14:00:36 +0000 (15:00 +0100)]
[BUGFIX] Adapt sorting arrows in EXT:filelist to Font Awesome

The sorting arrows in the table header sorting are adapted to the
monochrome versions in Font Awesome.

Resolves: #63234
Releases: master
Change-Id: Ic73ccb0bccb7e0dc7df614e75d4643c443fbe292
Reviewed-on: http://review.typo3.org/36771
Reviewed-by: Felix Kopp <felix-source@phorax.com>
Tested-by: Felix Kopp <felix-source@phorax.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
4 years ago[TASK] Func Module: Unify IconSelect 51/36751/2
Benjamin Kott [Sun, 8 Feb 2015 19:28:04 +0000 (20:28 +0100)]
[TASK] Func Module: Unify IconSelect

Create multiple pages wizard now adapts the FormEngine styling.
The new styling needs more space, the amount of default visible
fields is reduced to 5.

Resolves: #64915
Releases: master
Change-Id: I6a12bf411cd492a2f94caab62a907386d4be1c5b
Reviewed-on: http://review.typo3.org/36751
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Felix Kopp <felix-source@phorax.com>
Tested-by: Felix Kopp <felix-source@phorax.com>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Frederic Gaus <gaus@flagbit.de>
Tested-by: Frederic Gaus <gaus@flagbit.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
4 years ago[TASK] Page module: Button (a.btn) for the plus sign 80/34480/6
Frank Nägler [Sun, 23 Nov 2014 14:03:19 +0000 (15:03 +0100)]
[TASK] Page module: Button (a.btn) for the plus sign

Resolves: #63203
Releases: master
Change-Id: Ide4b857b26b6232d7ab86e859310110d1b96576b
Reviewed-on: http://review.typo3.org/34480
Reviewed-by: Felix Kopp <felix-source@phorax.com>
Tested-by: Felix Kopp <felix-source@phorax.com>
Reviewed-by: Benjamin Kott <info@bk2k.info>
Tested-by: Benjamin Kott <info@bk2k.info>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Document removal of several entry points 46/36746/3
Wouter Wolters [Sun, 8 Feb 2015 15:41:10 +0000 (16:41 +0100)]
[TASK] Document removal of several entry points

Resolves: #64922
Releases: master
Change-Id: I83a007a848874607b0258118cdb9e5db9e093b20
Reviewed-on: http://review.typo3.org/36746
Reviewed-by: Frederic Gaus <gaus@flagbit.de>
Tested-by: Frederic Gaus <gaus@flagbit.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
4 years ago[TASK] Document needed changes if you remove conf.php 45/36745/3
Wouter Wolters [Sun, 8 Feb 2015 15:24:18 +0000 (16:24 +0100)]
[TASK] Document needed changes if you remove conf.php

Resolves: #64921
Releases: master
Change-Id: Id1f1d8ccfcd3d8fafb8faa338ca7e4b09527fe36
Reviewed-on: http://review.typo3.org/36745
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Frederic Gaus <gaus@flagbit.de>
Tested-by: Frederic Gaus <gaus@flagbit.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
4 years ago[BUGFIX] Replace deprecated Fluid methods in Install Tool 76/36776/2
Andreas Fernandez [Mon, 9 Feb 2015 16:15:30 +0000 (17:15 +0100)]
[BUGFIX] Replace deprecated Fluid methods in Install Tool

Replace the deprecated methods setLayoutRootPath() and setPartialRootPath().

Resolves: #64949
Releases: master
Change-Id: I1f9f680abf82cbc8c98b48c05ab1598332a48c43
Reviewed-on: http://review.typo3.org/36776
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] RTE: WebKit may insert line-height style attribute on paste 49/36749/2
Stanislas Rolland [Sun, 8 Feb 2015 17:58:36 +0000 (12:58 -0500)]
[BUGFIX] RTE: WebKit may insert line-height style attribute on paste

Problem: When pasting content that contains (un)ordered lists, WebKit
browsers may insert line-height style attributes on the ul/ol elements.
Solution: Remove the added attributes if enableWordClean is set.

Releases: master, 6.2
Resolves: #63982
Change-Id: I64fe918aa1f0edcc52466736e390ae60b09e7ef8
Reviewed-on: http://review.typo3.org/36749
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] RTE: Incorrect dialog window height when browser zoom is used 35/36735/3
Stanislas Rolland [Sat, 7 Feb 2015 23:41:56 +0000 (18:41 -0500)]
[BUGFIX] RTE: Incorrect dialog window height when browser zoom is used

Problem: When browser zoom is used, ExtJS does not calculate correctly the
height of tabpanels that contain fieldsets.
Solution: Calculate the correct height and set the tabpanel height.

Releases: master, 6.2
Resolves: #45616
Change-Id: I0bc6d95b6699378b19fe81df8aaab7915e933c4d
Reviewed-on: http://review.typo3.org/36735
Reviewed-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Tested-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] Make IRRE Filetype check less greedy 42/36742/4
Mathias Schreiber [Sun, 8 Feb 2015 12:39:34 +0000 (13:39 +0100)]
[BUGFIX] Make IRRE Filetype check less greedy

IREE relations should check for allowed filetypes (which is good) but
due to a minor tunnel vision it always checked for allowed filetypes
even if the relation did not use filetypes at all.

Resolves: #64845
Resolves: #64898
Releases: master
Change-Id: I73c02d7ac2da44de3dd0da4628d7327085aa8990
Reviewed-on: http://review.typo3.org/36742
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Don't show storages multiple times in filelist 29/36729/3
Michael Oehlhof [Sat, 7 Feb 2015 15:37:25 +0000 (16:37 +0100)]
[BUGFIX] Don't show storages multiple times in filelist

When expanding tree nodes in Filelist module the storages
are now correctly shown once at the top-most level and not
multiple times within subtrees.

Resolves: #64894
Releases: master
Change-Id: I50d1085b6fc5e9ed36ac1effe11206618d4a853e
Reviewed-on: http://review.typo3.org/36729
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
4 years ago[TASK] Adapt backend meta tag 34/36734/2
Felix Kopp [Sat, 7 Feb 2015 22:54:40 +0000 (23:54 +0100)]
[TASK] Adapt backend meta tag

+ Remove chrome-frame in ua-compatibility
+ Adds meta charset to utf-8
+ Brings viewport for smartphones with initial scale

Note that these meta tags are recommended and required
by twbs/bootstrap.

Resolves: #64924
Releases: master
Change-Id: I1c75f0c49baeac7b8477a14cef8a3d163231366f
Reviewed-on: http://review.typo3.org/36734
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Benjamin Kott <info@bk2k.info>
Tested-by: Benjamin Kott <info@bk2k.info>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
4 years ago[BUGFIX] Fix unittest broken due to CRLF 43/36743/3
Stephan Großberndt [Sun, 8 Feb 2015 13:26:00 +0000 (14:26 +0100)]
[BUGFIX] Fix unittest broken due to CRLF

Instead of providing a hardcoded filesize for Dummy.html of 48 bytes in
the DataProvider read the actual filesize from the filesystem. This
fixes a unit test failure on windows when using autocrlf = true in git.

Resolves: #64929
Releases: master
Change-Id: I5227f225cce1fd9dc107859825e19d64907fd110
Reviewed-on: http://review.typo3.org/36743
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
4 years ago[BUGFIX] Hide hidden TCA palettes 39/36739/2
Frans Saris [Sun, 8 Feb 2015 11:13:23 +0000 (12:13 +0100)]
[BUGFIX] Hide hidden TCA palettes

Followup of Form engine refactory

Resolves: #64928
Releases: master
Change-Id: I3a563aba48179dacc2dcc871f47b9e234b095bba
Reviewed-on: http://review.typo3.org/36739
Reviewed-by: Benjamin Kott <info@bk2k.info>
Tested-by: Benjamin Kott <info@bk2k.info>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
4 years ago[BUGFIX] Make sure upload progress table uses full width again 37/36737/2
Frans Saris [Sun, 8 Feb 2015 10:32:25 +0000 (11:32 +0100)]
[BUGFIX] Make sure upload progress table uses full width again

Due to refactoring of the filelist HTML the DragUploader js used
the wrong selector to count the availeble columns.

This patch changes the selector so the full width is used again.

Resolves: #64925
Releases: master
Change-Id: I39bab7389670f21879c938b012c2f469b842df5b
Reviewed-on: http://review.typo3.org/36737
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
4 years ago[TASK] Split action buttons into two groups 88/34788/33
Andreas Fernandez [Sat, 29 Nov 2014 23:35:38 +0000 (00:35 +0100)]
[TASK] Split action buttons into two groups

The buttons in Web>List are split into two different groups: "primary"
and "secondary". Primary buttons are always visible and represent the
default RUD actions (Show, edit, hide, delete).

This patch also modifies the "Extended view" (EV) behaviour, which
affects the secondary buttons:
If EV is disabled, the secondary buttons are invisible, but can be made
visibile by hovering the trigger button. If EV is enabled, the secondary
buttons are always visible.

CSS rules for buttons in tables are now streamlined with the
backend. The blue styling for checked checkboxes in tables is
removed in favor of a cleaner implementation.

Resolves: #63207
Releases: master
Change-Id: Id1bfd42e658e9dbe0a7c13066fed618539fd5ce0
Reviewed-on: http://review.typo3.org/34788
Reviewed-by: Benjamin Kott <info@bk2k.info>
Tested-by: Benjamin Kott <info@bk2k.info>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Cleaner scripts crashes due to incomplete flexform content 20/36720/5
Jose Antonio Guerra [Fri, 6 Feb 2015 18:32:29 +0000 (19:32 +0100)]
[BUGFIX] Cleaner scripts crashes due to incomplete flexform content

Failure to check arguments used on recursive function call
causes PHP runtime error.

Resolves: #64914
Releases: master, 6.2
Change-Id: Id61ae9961415ab5d9d4294b224c90f2e02df6f14
Reviewed-on: http://review.typo3.org/36720
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Memcached backend identifierPrefix only based on PATH_site 30/36430/3
Arjen Hoekema [Fri, 30 Jan 2015 14:15:20 +0000 (15:15 +0100)]
[BUGFIX] Memcached backend identifierPrefix only based on PATH_site

Change the 'identifierPrefix' in the MemcachedBackend so it is
caculated based on:
* PATH_site
* Context (production/developement)
* Cache identifier (cache_pages, cache_hash)

This avoids cache collisions when using a single Memcached backend
for multiple caching configurations when using the same
'entryIdentifier' in set()

Resolves: #64588
Releases: master, 6.2
Change-Id: Ib1702caa06dc29937cdc4bf574a0f05d89a8d10c
Reviewed-on: http://review.typo3.org/36430
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Revert default value of $argument in TranslateViewHelper 11/36711/2
Georg Ringer [Fri, 6 Feb 2015 10:04:19 +0000 (11:04 +0100)]
[TASK] Revert default value of $argument in TranslateViewHelper

The default value of $arguments changed from NULL to array() which
can lead to warnings. As a solution change it back.

Change-Id: I9b3ff56effc84416c7dcbdabf84bb8f1cc2f7378
Resolves: #64901
Releases: master
Reviewed-on: http://review.typo3.org/36711
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Göran Bodenschatz <coding@46halbe.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Make advanced search work with indexed_search extbase plugin 13/36713/2
Tymoteusz Motylewski [Fri, 6 Feb 2015 11:16:55 +0000 (12:16 +0100)]
[BUGFIX] Make advanced search work with indexed_search extbase plugin

Resolves: #64904
Releases: master
Change-Id: Idd3ea31071fa37bca3e9e2aa807ab3afea561b76
Reviewed-on: http://review.typo3.org/36713
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Göran Bodenschatz <coding@46halbe.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Fix broken form markup in EM 15/36715/3
Andreas Fernandez [Fri, 6 Feb 2015 14:52:25 +0000 (15:52 +0100)]
[BUGFIX] Fix broken form markup in EM

Update the form markup to repair the broken layout after
FormEngine changes.

Resolves: #64910
Releases: master
Change-Id: I270a4338e36bbe1789b73ffc9f646531c936d92d
Reviewed-on: http://review.typo3.org/36715
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
4 years ago[BUGFIX] Recycler counts deleted records correctly 16/36716/3
Andreas Fernandez [Fri, 6 Feb 2015 14:56:04 +0000 (15:56 +0100)]
[BUGFIX] Recycler counts deleted records correctly

This patch improves the usability and fixes a small bug:
- Add the clearable to the search form
- Count deleted records correctly

Resolves: #64911
Releases: master
Change-Id: I0fc702697ce1c630d39f6b127f605c9d8aa5afb4
Reviewed-on: http://review.typo3.org/36716
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Scheduler: Show exception when invalid CommandController present 37/36637/9
Armin Ruediger Vieweg [Tue, 3 Feb 2015 19:43:44 +0000 (20:43 +0100)]
[BUGFIX] Scheduler: Show exception when invalid CommandController present

When a CommandController in an extbase extension has been registered,
but the class does not contain the string "CommandController"
an exception will be thrown. Before this patch, this exception
will never show up.

This patch adds the output of exception's message in Scheduler module,
which gives the developer a hint why the "add new task" form is not
displayed properly.

Also it extends the exception with description why the class name is invalid.

Resolves: #64836
Releases: master, 6.2
Change-Id: I309ed02c7fd4597b99388518abf842e600b27a9a
Reviewed-on: http://review.typo3.org/36637
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Properly check type of POST vars on clipboard action 00/36700/5
Markus Klein [Thu, 5 Feb 2015 23:47:03 +0000 (00:47 +0100)]
[BUGFIX] Properly check type of POST vars on clipboard action

Avoid a PHP warning by checking the type of data retrieved via POST.

"CBC" is an array of checkboxes, which can be null if nothing is selected.
"CBH" is an array of hidden fields. If this is not an array, something
is messed up in HTML generation and an Exception should be thrown then
(because of a PHP warning).

Also adapt the list module code accordingly.

Resolves: #64897
Releases: master, 6.2
Change-Id: Ife7d079a6d666e8bdbbce7b7eef34dbf5636c425
Reviewed-on: http://review.typo3.org/36700
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[!!!][BUGFIX] Add only required classes and class aliases 44/36644/5
Helmut Hummel [Mon, 2 Feb 2015 21:03:35 +0000 (22:03 +0100)]
[!!!][BUGFIX] Add only required classes and class aliases

Additionally we enable the composer class loading by default
if the according autoload.php file is found in Packages/Libraries/

To be able to detect the compatibility extension being installed
which brings class aliases for classes spread over other system extensions,
we need to add functionality that puts the class aliases to typo3conf/
when an extension is activated or deactivated.

This deviates from the approach in 6.2 branch and most likely will vanish
again later once we require composer installation

If the class alias file is present, the aliases will be added to the composer
class loader during TYPO3 bootstrap.

Releases: master, 6.2
Resolves: #64376
Change-Id: I4fd2202abad345c29bcb2b05d3702bdeef9e4474
Reviewed-on: http://review.typo3.org/36644
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[CLEANUP] Cleanup of classes extending AbstractPlugin 27/36627/8
Frederic Gaus [Tue, 3 Feb 2015 10:04:06 +0000 (11:04 +0100)]
[CLEANUP] Cleanup of classes extending AbstractPlugin

* fixes a few phpdocs
* use properties from AbstractPlugin instead of $GLOBALS
* define some undefined global vars in FrontendLoginController

Change-Id: I14c4aedd5b3a28ddda63ef9c594635d29ac455d6
Resolves: #64780
Releases: master
Reviewed-on: http://review.typo3.org/36627
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Ensure variable imageSizes is an array before accessing its values 71/36671/3
Fabien Udriot [Thu, 5 Feb 2015 14:01:04 +0000 (15:01 +0100)]
[BUGFIX] Ensure variable imageSizes is an array before accessing its values

It could be the PHP function "getimagesize" will fail to get the width and
the height of an image if the format is not supported by PHP. The patch
prevent accessing the value of an array which may be not an array.

Resolves: #64875
Releases: master, 6.2
Change-Id: Ibcbeb6edc7e23a2468cbcce40c2ecb0c2ba21142
Reviewed-on: http://review.typo3.org/36671
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Remove unused code in TYPO3\CMS\Install\SystemEnvironment\Check 72/36672/4
Frederic Gaus [Thu, 5 Feb 2015 14:41:18 +0000 (15:41 +0100)]
[TASK] Remove unused code in TYPO3\CMS\Install\SystemEnvironment\Check

Remove code which is never executed since the system environment check
of the Install Tool is omitted in cli mode.

Resolves: #64876
Releases: master

Change-Id: If22117d793b54230dc5ae703df478a91482fa7e6
Reviewed-on: http://review.typo3.org/36672
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Fix open_basedir warning when entering install tool 80/36680/3
Tymoteusz Motylewski [Thu, 5 Feb 2015 19:39:13 +0000 (20:39 +0100)]
[BUGFIX] Fix open_basedir warning when entering install tool

Due to the bug in php https://bugs.php.net/bug.php?id=67378
Warning is triggered when you have open_basedir set up.

This patch suppress the warning as a workaround.
This code is executed only when calling the install tool.
It doesn't influence FE or BE requests so it's acceptable
to use @ operator.

Resolves: #64882
Releases: master
Change-Id: I7881103464ec018cc0a23f47f6cd8c05bb34929c
Reviewed-on: http://review.typo3.org/36680
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
4 years ago[TASK] Make Content Element Wizard to use Bootstrap 93/36693/2
Benjamin Kott [Thu, 5 Feb 2015 21:52:41 +0000 (22:52 +0100)]
[TASK] Make Content Element Wizard to use Bootstrap

This patch removes the custom styling from the
content element wizard.

Releases: master
Resolves: #64892
Change-Id: I721a896efedcbb8c67274be85e84d434eda53806
Reviewed-on: http://review.typo3.org/36693
Reviewed-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Tested-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Adapt belog filter bar to twbs 92/36692/2
Felix Kopp [Thu, 5 Feb 2015 21:50:15 +0000 (22:50 +0100)]
[TASK] Adapt belog filter bar to twbs

Following beusers backend App the filter bar of belog is styled
and html markup following twbs.

Resolves: #64891
Releases: master
Change-Id: Ie0b3fa294621614d8ebc7859d3511f85f3b9981e
Reviewed-on: http://review.typo3.org/36692
Reviewed-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Tested-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Reviewed-by: Benjamin Kott <info@bk2k.info>
Tested-by: Benjamin Kott <info@bk2k.info>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Reduce .lead font-size 89/36689/2
Felix Kopp [Thu, 5 Feb 2015 21:31:46 +0000 (22:31 +0100)]
[TASK] Reduce .lead font-size

Add font-size definition of .lead text. Twbs does not deliver
a variable therefore the class is added. Lead font-size broke
during implementation of twbs.

Resolves: #64890
Releases: master
Change-Id: Id057b5b2b0b41bef86fc3fdae0ed9927fa9050ce
Reviewed-on: http://review.typo3.org/36689
Reviewed-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Tested-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Reduce App-Icon size in Module menu and Topbar 85/36685/4
Felix Kopp [Thu, 5 Feb 2015 21:07:05 +0000 (22:07 +0100)]
[TASK] Reduce App-Icon size in Module menu and Topbar

Decrease size of App-Icons to reduce the visual relevance
from 32x32px to 28x28px. Following paddings and snap mode.

Kudos to Benjamin Kott.

Resolves: #64889
Releases: master
Change-Id: I8e3219cf492415e94dc74d656ef42543bf36cfca
Reviewed-on: http://review.typo3.org/36685
Reviewed-by: Benjamin Kott <info@bk2k.info>
Tested-by: Benjamin Kott <info@bk2k.info>
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Indexed Search pibased plugin can load again translations 77/36677/6
Tymoteusz Motylewski [Thu, 5 Feb 2015 16:47:52 +0000 (17:47 +0100)]
[BUGFIX] Indexed Search pibased plugin can load again translations

This patch fixes a regression introduced in bf63a1c,
which changed the variable $scriptRelPath with a wrong
file location. The old file name is reverted so that
AbstractPlugin will look for the locallang.xlf file at
the correct location.

The patch also reformats the properties comments of the class.

Reference: https://review.typo3.org/#/c/32708/

Resolves: #64879
Releases: master
Change-Id: I58a07f11e382bde2ed84835ca0820ff5e00e1998
Reviewed-on: http://review.typo3.org/36677
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Göran Bodenschatz <coding@46halbe.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] PHP fatal error calling beuser module 95/36695/2
Christian Kuhn [Thu, 5 Feb 2015 21:59:15 +0000 (22:59 +0100)]
[BUGFIX] PHP fatal error calling beuser module

A missing namespace import triggers a PHP fatal error
in ext:beuser.

Resolves: #64893
Related: #64695
Releases: master
Change-Id: I366203ad87aa5823fcf9099525bf99ea003a9533
Reviewed-on: http://review.typo3.org/36695
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[BUGFIX] Make indexed search extbase plugin work after class alias change 81/36681/2
Tymoteusz Motylewski [Thu, 5 Feb 2015 20:02:56 +0000 (21:02 +0100)]
[BUGFIX] Make indexed search extbase plugin work after class alias change

Indexed search extbase experimental plugin (pi2) requires class alias
to work. This patch moves it back from compatibility6 extension
to indexed_search.

Resolves: #64886
Releases: master
Change-Id: I36d288d80453a0772181358222608e1df83f9cf6
Reviewed-on: http://review.typo3.org/36681
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[TASK] Improve maximum length for TCA text type .rst documentation 82/36682/6
Christian Kuhn [Thu, 5 Feb 2015 20:10:42 +0000 (21:10 +0100)]
[TASK] Improve maximum length for TCA text type .rst documentation

Improve the documentation file, mention IE9 is not compatible
and line breaks count as two characters.

Resolves: #64888
Related: #24906
Releases: master
Change-Id: I182734cdf9b9a01303369e88d237292d2ab861f4
Reviewed-on: http://review.typo3.org/36682
Reviewed-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Tested-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Remove obsolete useCachingFramework from LocalConfiguration 79/36679/4
Christian Kuhn [Thu, 5 Feb 2015 18:44:18 +0000 (19:44 +0100)]
[BUGFIX] Remove obsolete useCachingFramework from LocalConfiguration

TYPO3_CONF_VARS/SYS/useCachingFramework is obsolete since 4.6 but
was forgotten to be removed from LocalConfiguration for 6.2. The
patch add this option to the SilentConfigurationUpgradeService to
let the install tool remove it if still set.

Resolves: #64872
Releases: master
Change-Id: I0e34cef906e02a37660f2ae078ce0f075e448c90
Reviewed-on: http://review.typo3.org/36679
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Proper handling of allowedTables='*' in FormEngine 50/36650/2
Georg Ringer [Wed, 4 Feb 2015 13:00:36 +0000 (14:00 +0100)]
[BUGFIX] Proper handling of allowedTables='*' in FormEngine

The output of FormEngine needs to be changed if all tables are
allowed for a relation.

Change-Id: Ib83c39120a3c20d99982e80b9a40b9f0fb7a4a72
Resolves: #64849
Releases: master
Reviewed-on: http://review.typo3.org/36650
Reviewed-by: Göran Bodenschatz <coding@46halbe.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Frederic Gaus <gaus@flagbit.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
4 years ago[BUGFIX] Follow up: Fix ext_icon.gif leftovers 68/36668/5
Andreas Fernandez [Thu, 5 Feb 2015 09:21:02 +0000 (10:21 +0100)]
[BUGFIX] Follow up: Fix ext_icon.gif leftovers

The extension icons were replaced by png pendants in commit
b8d9e2859f98caf0de27be41c73373eba3c0438e, but some classes
or TCAs still require the gif version.

Resolves: #64866
Releases: master
Change-Id: Ide0c6b99381c5a3e071c2c40c4942212d85e7004
Reviewed-on: http://review.typo3.org/36668
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
4 years ago[BUGFIX] Restore expand state of module groups 65/36665/3
Andreas Fernandez [Thu, 5 Feb 2015 08:18:42 +0000 (09:18 +0100)]
[BUGFIX] Restore expand state of module groups

This patch recovers the expand state of module groups when they
were collapsed before.

Resolves: #64859
Releases: master
Change-Id: Id4b527d287a8ca1a7dd542639d4c5a691fe0f065
Reviewed-on: http://review.typo3.org/36665
Reviewed-by: Göran Bodenschatz <coding@46halbe.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Invalid class name in EXT:sys_note 67/36667/2
Xavier Perseguers [Thu, 5 Feb 2015 08:50:23 +0000 (09:50 +0100)]
[BUGFIX] Invalid class name in EXT:sys_note

Core class BackendUtility is wrongly referenced with a short namespace
and crashes Web > Page when a sys_note is present.

Resolves: #64862
Releases: master
Change-Id: I17edcdbd93af5d4367f562c036930565a155d6f8
Reviewed-on: http://review.typo3.org/36667
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
4 years ago[TASK] Make tce_file.php dispatched 20/36520/5
Wouter Wolters [Sat, 31 Jan 2015 15:29:40 +0000 (16:29 +0100)]
[TASK] Make tce_file.php dispatched

Use dispatching for tce_file.php

Resolves: #64692
Releases: master
Change-Id: Ia71d781a4fd4bfe829691598db039db8a7afe690
Reviewed-on: http://review.typo3.org/36520
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Make tce_db.php dispatched 24/36524/4
Wouter Wolters [Sat, 31 Jan 2015 15:58:43 +0000 (16:58 +0100)]
[TASK] Make tce_db.php dispatched

Use dispatching for tce_db.php

Resolves: #64695
Releases: master
Change-Id: I6da8dfd72c4814bd280cae9647f13b6a70f4934e
Reviewed-on: http://review.typo3.org/36524
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Make login_frameset.php dispatched 22/36622/5
Wouter Wolters [Mon, 2 Feb 2015 22:49:40 +0000 (23:49 +0100)]
[TASK] Make login_frameset.php dispatched

Use dispatching for login_frameset.php

Resolves: #64774
Releases: master
Change-Id: I1ce9794f3b7a7d66e20bca84464fb9d1cd48c759
Reviewed-on: http://review.typo3.org/36622
Reviewed-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[FEATURE] Speedup trimExplode with limit 47/36647/2
Alexander Opitz [Wed, 4 Feb 2015 11:22:56 +0000 (12:22 +0100)]
[FEATURE] Speedup trimExplode with limit

Using array_splice instead of array_slice two times.

Resolves: #64848
Releases: master
Change-Id: Iaa998c810aa94e1b3b547714ed4b431b0e5c8452
Reviewed-on: http://review.typo3.org/36647
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Frederic Gaus <gaus@flagbit.de>
Tested-by: Frederic Gaus <gaus@flagbit.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] RTE: Namespace all css selectors in FE skin 57/36657/3
Stanislas Rolland [Wed, 4 Feb 2015 17:53:49 +0000 (12:53 -0500)]
[TASK] RTE: Namespace all css selectors in FE skin

Avoid intruding the styles of the frontend page.

Releases: master
Resolves: #64858
Change-Id: I636f06dd38af334db26c953bbbbe874f37d6d83d
Reviewed-on: http://review.typo3.org/36657
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] Fix core update if core location exists 60/36360/10
Frederic Gaus [Mon, 2 Feb 2015 21:09:08 +0000 (22:09 +0100)]
[BUGFIX] Fix core update if core location exists

If multiple installations are symlinked to the same core location,
the core updater fails on the second update because the new version
already exists.

Check for this situation and skip unneeded tasks during the update
process.

Change-Id: I4c3c11f0e45c240e15913d5de5a3156ef5ad0aa6
Resolves: #58009
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/36360
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 years ago[BUGFIX] RTE: Parsing of some style sheets may fail in IE on first load 56/36656/2
Stanislas Rolland [Wed, 4 Feb 2015 15:58:18 +0000 (10:58 -0500)]
[BUGFIX] RTE: Parsing of some style sheets may fail in IE on first load

The length of the style sheet's rules array is reported as 0 while,
in fact, the style sheet is not yet completely loaded.

Releases: master
Resolves: #64854
Change-Id: I406ddebb250c15cd5b04ae1b734f146bd1025863
Reviewed-on: http://review.typo3.org/36656
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[FOLLOWUP] Revamp EXT:recycler 46/36646/5
Frederic Gaus [Wed, 4 Feb 2015 10:17:28 +0000 (11:17 +0100)]
[FOLLOWUP] Revamp EXT:recycler

Fix a few coding issues in new EXT:recycler

* Remove IDE warnings
* Correct phpDoc
* Remove an unused variable
* Introduce a int typecast of GP:id
* Replace spaces with tabs

Change-Id: I8eaadd51c29506958d7fa80c375ddf943dfbac2f
Resolves: #64844
Releases: master
Reviewed-on: http://review.typo3.org/36646
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[ClEANUP] Drop some @throws from the tests bootstrap 45/36645/2
Oliver Klee [Wed, 4 Feb 2015 10:11:05 +0000 (11:11 +0100)]
[ClEANUP] Drop some @throws from the tests bootstrap

The exceptions mentioned in the removed @throws annotations do not
get thrown.

In addition, change an exception code to be unique. (It was used in two
places due to copy'n'paste.)

Resolves: #64843
Releases: master

Change-Id: I5f5fe054f3b3ddd96224b6bc6b4632cb9e375ede
Reviewed-on: http://review.typo3.org/36645
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] RTE: IE 11 always drops images at the end of text 42/36642/2
Stanislas Rolland [Wed, 4 Feb 2015 00:21:46 +0000 (19:21 -0500)]
[BUGFIX] RTE: IE 11 always drops images at the end of text

IE needs a delay before the dialogue window gets closed.

Releases: master
Resolves: #64839
Change-Id: I02d49cb124370c23ba14f8617dd4019586e184ea
Reviewed-on: http://review.typo3.org/36642
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] RTE: Image drag&drop with WebKit still using ExtJS event 41/36641/2
Stanislas Rolland [Tue, 3 Feb 2015 23:31:50 +0000 (18:31 -0500)]
[BUGFIX] RTE: Image drag&drop with WebKit still using ExtJS event

Migrate it to jQuery.

Releases: master
Resolves: #64838
Change-Id: I182c694b5e531b19aef11500319367a3481885f6
Reviewed-on: http://review.typo3.org/36641
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] RTE: Image drag & drop raises PHP error 40/36640/2
Stanislas Rolland [Tue, 3 Feb 2015 21:21:47 +0000 (16:21 -0500)]
[BUGFIX] RTE: Image drag & drop raises PHP error

Old class name was left over.

Releases: master
Resolves: #64649
Change-Id: Ie78c781d466e6fabfc11170d828a9e43544bad65
Reviewed-on: http://review.typo3.org/36640
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[FOLLOWUP] This is FormEngine 38/36638/2
Benjamin Kott [Tue, 3 Feb 2015 20:20:21 +0000 (21:20 +0100)]
[FOLLOWUP] This is FormEngine

Correct clearing for --linebreaks-- within palettes.

Releases: master
Resolves: #64762
Change-Id: I9a7473e073cb9d563da3a645e1813fbff7dc1102
Reviewed-on: http://review.typo3.org/36638
Reviewed-by: Frederic Gaus <gaus@flagbit.de>
Tested-by: Frederic Gaus <gaus@flagbit.de>
Reviewed-by: Steffen Müller <typo3@t3node.com>
Tested-by: Steffen Müller <typo3@t3node.com>
4 years ago[BUGFIX] Indexed search broken after moving "SearchResultContentObject" 66/36566/3
Benjamin Mack [Sun, 1 Feb 2015 12:09:31 +0000 (13:09 +0100)]
[BUGFIX] Indexed search broken after moving "SearchResultContentObject"

Indexed search still uses the old cobject in both
plugins.

The problem arieses in just to call one method from
SearchResultContentObject->register_and_explode_search_string()

The necessary functions are moved to the common
IndexedSearchUtility.

Resolves: #64716
Releases: master
Change-Id: I386330f1f66342ee838e3616cac7f0924bd31522
Reviewed-on: http://review.typo3.org/36566
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Create typo3temp directory in functional tests if missing 87/36587/4
Christian Kuhn [Mon, 2 Feb 2015 23:37:43 +0000 (00:37 +0100)]
[TASK] Create typo3temp directory in functional tests if missing

All functional tests are run in an encapsulated environment
within typo3temp. The functional bootstrap needs to take care
this directory exists.

Resolves: #64715
Releases: master
Change-Id: I07581db4d2c2cd9792dfde74ec9748c0824a549c
Reviewed-on: http://review.typo3.org/36587
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[CLEANUP] Remove @see comment from ArrayBrowser 20/36620/2
Wouter Wolters [Mon, 2 Feb 2015 22:12:37 +0000 (23:12 +0100)]
[CLEANUP] Remove @see comment from ArrayBrowser

The reference mentioned in @see does not exists.

Resolves: #64773
Releases: master
Change-Id: I3e63ffd330a783e2448c5207957d33fca119cf1b
Reviewed-on: http://review.typo3.org/36620
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 years ago[CLEANUP] \TYPO3\CMS\Lowlevel\Utility\ArrayBrowser 04/36604/4
Frederic Gaus [Mon, 2 Feb 2015 13:55:06 +0000 (14:55 +0100)]
[CLEANUP] \TYPO3\CMS\Lowlevel\Utility\ArrayBrowser

Cleanup \TYPO3\CMS\Lowlevel\Utility\ArrayBrowser

* phpDoc
* delete unused var
* remove unneeded fully qualified class names

Change-Id: Iced2fd79272a5142a7dd27d78c12a97f33b408d4
Resolves: #64765
Releases: master
Reviewed-on: http://review.typo3.org/36604
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Göran Bodenschatz <coding@46halbe.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Change $fixture to $subject in unit-tests 15/36615/4
Wouter Wolters [Mon, 2 Feb 2015 20:56:46 +0000 (21:56 +0100)]
[TASK] Change $fixture to $subject in unit-tests

Subject is the "system under test, the
subject you're operating on"

Resolves: #64771
Releases: master
Change-Id: I7a70d5f44e721b958d86aea741534ace2f53b2a8
Reviewed-on: http://review.typo3.org/36615
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 years ago[TASK] Removed unused code from tests 17/36617/3
Wouter Wolters [Mon, 2 Feb 2015 21:01:43 +0000 (22:01 +0100)]
[TASK] Removed unused code from tests

Remove unused code in:

FileMountRepositoryTest
CategoryRepositoryTest

Resolves: #64772
Releases: master
Change-Id: Ic1386778d5a108bbbdfebf56933b6ba1cd2ffa68
Reviewed-on: http://review.typo3.org/36617
Reviewed-by: Göran Bodenschatz <coding@46halbe.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 years ago[TASK] Add functional tests for dynamic values in Extbase query cache 63/29963/9
Marc Bastian Heinrichs [Thu, 8 May 2014 01:31:21 +0000 (03:31 +0200)]
[TASK] Add functional tests for dynamic values in Extbase query cache

For performance reasons Extbase caches database queries. To ensure the
security relevant aspect, the frontend usergroup has to be parameterized
and be added by runtime. This patch adds functional tests to ensure
query caching by:

* adding possibility to simulate a frontend user in functional tests
* extending blog_example extension TCA adding fe_group for blogs
* adding a plugin and controller for blog listing
* adding new fixtures with frontend usergroups restrictions
* adding functional tests and frontend rending function

Resolves: #58655
Releases: master
Change-Id: Ib6d918461d5ad04bc2236a375f558d48548c9946
Reviewed-on: http://review.typo3.org/29963
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Keep linktype on core update 45/36345/5
Frederic Gaus [Thu, 29 Jan 2015 09:59:20 +0000 (10:59 +0100)]
[BUGFIX] Keep linktype on core update

Keep the linktype of the symlink pointing to the TYPO3 core. Currently
the CoreUpdateService always creates an absolute link even if the
link was relative before. This patch checks for the correct link type
during a core update. This could be important in some environments,
e.g. in a chrooted environemnt.

Change-Id: I47bbe0d54a88853adc4160937a21d641b756f20f
Resolves: #58000
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/36345
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Göran Bodenschatz <coding@46halbe.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 years ago[FEATURE] Add SplFileInfo implementation to get file mimeType 56/31256/14
Sascha Egerer [Sat, 31 Jan 2015 23:17:56 +0000 (00:17 +0100)]
[FEATURE] Add SplFileInfo implementation to get file mimeType

\TYPO3\CMS\Core\Type\File\FileInfo provides a new method
getMimeType() to get the MIME type of a file, e.g. text/html.

Custom implementations to determine the MIME type can be added
with the hook:

$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS'][\TYPO3\CMS\Core\Type\File\FileInfo::class]['mimeTypeGuessers']

The FAL LocalDriver also uses this new API.

Resolves: #60019
References: #46777
Releases: master
Change-Id: Ia2fa95d2ef6452f8022e33f1b1d2a9336f3e0303
Reviewed-on: http://review.typo3.org/31256
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Steffen Müller <typo3@t3node.com>
Reviewed-by: Steffen Müller <typo3@t3node.com>
4 years ago[BUGFIX] Prevent double slash in canonicalizeAndCheckFolderIdentifier 43/36543/6
Sascha Egerer [Sat, 31 Jan 2015 20:45:39 +0000 (21:45 +0100)]
[BUGFIX] Prevent double slash in canonicalizeAndCheckFolderIdentifier

If the value given to AbstractHierarchicalFilesystemDriver->
canonicalizeAndCheckFolderIdentifier()
is '.' the return was '//' but should be '/'.

Resolves: #64706
Releases: master
Change-Id: I63900c44be3180b0a9b8e31d89c6c896382db6b7
Reviewed-on: http://review.typo3.org/36543
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[!!!][TASK] This is FormEngine 51/35951/35
Benjamin Kott [Sat, 10 Jan 2015 23:31:58 +0000 (00:31 +0100)]
[!!!][TASK] This is FormEngine

The patch brings responsive layout for FormEngine and its
elements. It fixes a couple of issues along the way,
escpecially DatePicker and palettes field are aligned in
a better way and wizard icons look much better.

Adjustments:
- Change datepicker to work directly on input without wrapper
- Change clearableJs to bootstrap
- Change dyntabs to bootstrap classes
- Change fixed-font to text-monospace
- Port CheckboxElement to boostrap
- Port GroupElement to bootstrap
- Port InputElement to bootstrap
- Port Irre/Inline to bootstrap
- Port Flexform to bootstrap
- Port Palettes to bootstrap
- Port RadioElements to bootstrap
- Port TextElement to bootstrap
- Port NoneElement to bootstrap

Removes:
- Unused change image javascript removed

Deprecations:
- cssClassTypeElementPrefix not used anymore
- maxTextareaWidth not used anymore
- paletteFieldTemplate not used anymore
- palFieldTemplateHeader not used anymore
- wizard config _PADDING
- wizard config _DISTANCE
- wrapOpenPalette not used anymore
- wrapPaletteField not used anymore
- formWidth not used anymore
- formWidthAsArray not used anymore
- addUserTemplateMarkers not used anymore

Releases: master
Resolves: #64762
Change-Id: I04ce24e63d2395fe25f7d5a314f5868882b2cd74
Reviewed-on: http://review.typo3.org/35951
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Frederic Gaus <gaus@flagbit.de>
Tested-by: Frederic Gaus <gaus@flagbit.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Remove superfluous getInstance calls in Bootstrap 10/36610/3
Helmut Hummel [Mon, 2 Feb 2015 19:21:29 +0000 (20:21 +0100)]
[BUGFIX] Remove superfluous getInstance calls in Bootstrap

Releases: 6.2, master
Resolves: #64770
Change-Id: I9ae4cd9476b45a17c0246edf65fb01a54b7dd24f
Reviewed-on: http://review.typo3.org/36610
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>