Packages/TYPO3.CMS.git
8 months ago[BUGFIX] Let Install Tool use core's bootstrap 65/60565/3
Andreas Fernandez [Fri, 26 Apr 2019 08:40:41 +0000 (10:40 +0200)]
[BUGFIX] Let Install Tool use core's bootstrap

The Install Tool ships bootstrap on its own, which doesn't make much sense
right now, since other components get used from EXT:core as well.

For now, the separated bootstrap gets removed and the one of EXT:core is
used instead.

Resolves: #88219
Related: #88213
Releases: master, 9.5, 8.7
Change-Id: I53425f56a44fa9782d7f3776175ac08bc746e5ab
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60565
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Benni Mack <benni@typo3.org>
8 months ago[BUGFIX] Check existence of properties before usage 68/60568/8
Susanne Moog [Fri, 26 Apr 2019 10:49:34 +0000 (12:49 +0200)]
[BUGFIX] Check existence of properties before usage

The ImageViewHelper uses properties 'title' and 'alternative' from file
without checking whether they exist or not. This results in an
exception for example with freshly uploaded files.

Releases: master
Resolves: #88222
Change-Id: I2b251e5f885bd00119a958e6bc2275c7e672336f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60568
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Willi Wehmeier <wwwehmeier@gmail.com>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
8 months ago[FEATURE] Double click in structure tree changes label 82/60582/10
Dominik Merkel [Sat, 27 Apr 2019 07:50:15 +0000 (09:50 +0200)]
[FEATURE] Double click in structure tree changes label

A new convenience function has been integrated which allows the user to
change the label of an element within the structure tree.

Releases: master
Resolves: #84757
Change-Id: I7095dfbec8731714ceb2a73bb62b58aaa3cb8957
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60582
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
8 months ago[FEATURE] Send plaintext and HTML multipart mails 11/60611/13
Mathias Brodala [Sun, 28 Apr 2019 10:52:12 +0000 (12:52 +0200)]
[FEATURE] Send plaintext and HTML multipart mails

Now by default, mails sent with the EmailFinisher contain both a
plaintext and an HTML part. The latter can be controlled with the
new "addHtmlPart" option which is enabled by default.

The former "format" option is removed from the backend UI and
migrated to the new "addHtmlPart" option.

Resolves: #87200
Releases: master
Change-Id: Id0a58e8cfee07926a555d0d921fed8b41832cb77
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60611
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
8 months ago[FEATURE] Allow multiple recipients in email finisher 44/60544/37
Mathias Brodala [Thu, 25 Apr 2019 13:36:31 +0000 (15:36 +0200)]
[FEATURE] Allow multiple recipients in email finisher

Also deprecate the single recipients options
in favor of their list successors.

Resolves: #80420
Releases: master
Change-Id: I5bad6da8809bd362110025296564e3eff0df70a4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60544
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
8 months ago[TASK] Document property "elementDescription" 09/60609/4
Björn Jacob [Sun, 28 Apr 2019 09:25:38 +0000 (11:25 +0200)]
[TASK] Document property "elementDescription"

The property "elementDescription" has been documented for both the
backend (form editor) and the frontend of the form framework.

In addition, some minor contextual and spelling problems have been
fixed.

Resolves: #84229
Releases: master, 9.5
Change-Id: Ifc9039b3dc434a20783d8d67b5d6efcd1eed113e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60609
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
8 months ago[TASK] Move backend translations into Database.xlf 08/60608/3
Ralf Zimmermann [Sun, 28 Apr 2019 09:26:19 +0000 (11:26 +0200)]
[TASK] Move backend translations into Database.xlf

Resolves: #88239
Releases: master, 9.5
Change-Id: I09df1600304e4f0cff6d4cab6f45b0c966525a3c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60608
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Dominik Merkel <merkel.dominik@googlemail.com>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Dominik Merkel <merkel.dominik@googlemail.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Susanne Moog <look@susi.dev>
8 months ago[!!!][TASK] Use multiple translation files by default 93/60593/11
Mathias Brodala [Sat, 27 Apr 2019 13:51:14 +0000 (15:51 +0200)]
[!!!][TASK] Use multiple translation files by default

Resolves: #87009
Releases: master
Change-Id: I533ccf9959f0e9e3a485a3317af8befc8befeb98
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60593
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
8 months ago[BUGFIX] Fix structure of generated finisher FlexForm fields 07/60607/2
Mathias Brodala [Sat, 27 Apr 2019 21:57:25 +0000 (23:57 +0200)]
[BUGFIX] Fix structure of generated finisher FlexForm fields

A valid FlexForm field must have a "TCEforms" wrapper around
the field configuration as can be seen in the FlexFormTools
class.

Resolves: #88013
Releases: master
Change-Id: I986f4fdf6f32c7174b3967f75729bc1122d4fdbd
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60607
Tested-by: Dominik Merkel <merkel.dominik@googlemail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Dominik Merkel <merkel.dominik@googlemail.com>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
8 months ago[TASK] Avoid pointless finisher override checkbox 70/60570/8
Michael Waack [Fri, 26 Apr 2019 11:54:15 +0000 (13:54 +0200)]
[TASK] Avoid pointless finisher override checkbox

The form plugin now only renders the checkbox for overriding
the finishers if finishers are available at all. Also finishers
without options are ignored.

Resolves: #84774
Releases: master
Change-Id: I1165d054340457fdd219024f28b877a21458b603
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60570
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Dominik Merkel <merkel.dominik@googlemail.com>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Dominik Merkel <merkel.dominik@googlemail.com>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
8 months ago[TASK] Display max file size hint 95/60595/6
Susanne Moog [Sat, 27 Apr 2019 14:27:56 +0000 (16:27 +0200)]
[TASK] Display max file size hint

When configuring a form with a file size validator it can be helpful to
know what the servers' max upload capabilities are. As it may make sense
to set bigger values and then contact a server admin to adjust the
server settings, we do not want to restrict the input field. Instead,
a hint with the current configuration has been added to inform the
editor / integrator of the current limitations.

Resolves: #88055
Releases: master
Change-Id: Iaae73f8df87f47484e29a810c7531a117e35a286
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60595
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Dominik Merkel <merkel.dominik@googlemail.com>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
8 months ago[BUGFIX] Add arguments to the MimeTypeValidator error object 01/60601/2
Ralf Zimmermann [Sat, 27 Apr 2019 18:13:13 +0000 (20:13 +0200)]
[BUGFIX] Add arguments to the MimeTypeValidator error object

Enriches the ext:form MimeTypeValidator error object with the mime type
of the validated file.

Resolves: #88236
Releases: master, 9.5
Change-Id: Ie2ec6950c58841f4f942e38acf4a36a9b8b9635c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60601
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
8 months ago[BUGFIX] Use form specific flexform sheets within the frontend 48/60548/12
Ralf Zimmermann [Thu, 25 Apr 2019 15:11:23 +0000 (17:11 +0200)]
[BUGFIX] Use form specific flexform sheets within the frontend

Use contextual flexform sheets to identify ext:form finisher overrides
within the frontend.

Resolves: #88011
Releases: master, 9.5
Change-Id: I0a21deed29419281478f358ff61986d65b26dd0e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60548
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Susanne Moog <look@susi.dev>
8 months ago[TASK] Document variants of form framework 00/60600/3
Björn Jacob [Sat, 27 Apr 2019 17:14:57 +0000 (19:14 +0200)]
[TASK] Document variants of form framework

In addition, a couple of valuable examples have
been added.

Resolves: #84135
Releases: master, 9.5
Change-Id: I4de1570c990d190b4293b536b3bcdfc6e9cb8f82
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60600
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
8 months ago[BUGFIX] Add guard clause to preFileAdd form hook 96/60596/2
Susanne Moog [Sat, 27 Apr 2019 14:51:27 +0000 (16:51 +0200)]
[BUGFIX] Add guard clause to preFileAdd form hook

With the security fix in #f3445f964 checks on EXT:form file handling
were added to ensure secure form definition files. These checks are
based on FAL hooks. One of these - preFileAdd - contains checks based
on the content of the file to add, to do that, the file content is
fetched via file_get_contents. Due to a missing guard this was executed
for all file add operations instead of only for form definitions
resulting in performance loss and high memory usage. The check has
now been implemented.

Resolves: #88235
Releases: master, 9.5
Change-Id: Ie685df3d67d6ee58b1cd08f18acab1208a487ce7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60596
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Dominik Merkel <merkel.dominik@googlemail.com>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Dominik Merkel <merkel.dominik@googlemail.com>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
8 months ago[BUGFIX] Catch form errors and display speaking error message 98/60598/3
Susanne Moog [Sat, 27 Apr 2019 16:20:05 +0000 (18:20 +0200)]
[BUGFIX] Catch form errors and display speaking error message

When having a broken form configuration, the formEditor is not able
to load because of JavaScript errors. These errors are not fixable for
an editor as they most likely happen because of admins/integrators
changing and breaking the form. Instead of displaying a loading
indicator without a hint on the error that happened, a top level
catch displaying a flash message has now been implemented.

Resolves: #84595
Releases: master, 9.5
Change-Id: I44cf49d8e344629bc1a3250eade6267c7debdf00
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60598
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
8 months ago[TASK] Add clarification for link.editRecord ViewHelper 71/60571/3
Sybille Peters [Fri, 26 Apr 2019 12:06:40 +0000 (14:06 +0200)]
[TASK] Add clarification for link.editRecord ViewHelper

Resolves: #88223
Releases: master, 9.5
Change-Id: Ib6d13fcbfa4de1c0e28b6af95a26ec9fc90c4387
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60571
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
8 months ago[BUGFIX] Change finisher override display behavior 77/60577/10
Ralf Zimmermann [Fri, 26 Apr 2019 14:37:48 +0000 (16:37 +0200)]
[BUGFIX] Change finisher override display behavior

Show all possible finisher options which can be overridden within the
form plugin even if if they are not part of a form definition.

Resolves: #86635
Resolves: #85033
Releases: master, 9.5
Change-Id: Ie5ce8e2fb97e2c3fde92cbcb405d77818d1c7bda
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60577
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Susanne Moog <look@susi.dev>
8 months ago[BUGFIX] Add missing translation of validator 90/60590/2
Björn Jacob [Sat, 27 Apr 2019 12:48:21 +0000 (14:48 +0200)]
[BUGFIX] Add missing translation of validator

The missing translations of the validator "Number
of submitted values" have been added.

Resolves: #88234
Releases: master, 9.5
Change-Id: I97c8865ff2ff5a46d6d5dd598143781c5fb6d7d3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60590
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
8 months ago[BUGFIX] Add id to confirmation finisher template 88/60588/5
Dominik Merkel [Sat, 27 Apr 2019 11:57:16 +0000 (13:57 +0200)]
[BUGFIX] Add id to confirmation finisher template

Releases: master, 9.5
Resolves: #87198
Change-Id: I91b8b2f0d161ef89ba4896b063685ef2e2c8544d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60588
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
8 months ago[BUGFIX] Pass error arguments to translator 49/60549/10
Michael Waack [Thu, 25 Apr 2019 15:46:23 +0000 (17:46 +0200)]
[BUGFIX] Pass error arguments to translator

Resolves: #88022
Releases: master, 9.5
Change-Id: I7d86f8061d71357307d939d4c4359e9da1b2c68a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60549
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Dominik Merkel <merkel.dominik@googlemail.com>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Dominik Merkel <merkel.dominik@googlemail.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
8 months ago[TASK] Document validators of form framework 54/60554/8
Björn Jacob [Thu, 25 Apr 2019 19:09:03 +0000 (21:09 +0200)]
[TASK] Document validators of form framework

Furthermore, move some documentation around
regarding finishers and validators to have
the information at one central place.

In addition, fix a PHP comment regarding the
MimeType validator.

Resolves: #88212
Releases: master, 9.5
Change-Id: Ifa437294c05d3f9dba16f8bb17ac88a43796595b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60554
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
8 months ago[BUGFIX] Show "FlashMessage" finisher output 76/60576/4
Michael Waack [Fri, 26 Apr 2019 14:10:59 +0000 (16:10 +0200)]
[BUGFIX] Show "FlashMessage" finisher output

Resolves: #84699
Releases: master, 9.5
Change-Id: I2733556eae95db5f44867323cd217c4b3ea0127c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60576
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
8 months ago[BUGFIX] Fix docs of FlashMessage finisher 85/60585/2
Björn Jacob [Sat, 27 Apr 2019 08:41:28 +0000 (10:41 +0200)]
[BUGFIX] Fix docs of FlashMessage finisher

The property "options.messageCode" is mandatory. The
docs have been adapted accordingly.

Resolves: #88231
Releases: master, 9.5
Change-Id: I7617c3e54aaba046434daac5a6c01f45bac32e03
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60585
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
8 months ago[BUGFIX] Fluid viewhelper f:format.date() uses timestamp from context aspect 54/60454/9
Benni Mack [Tue, 9 Apr 2019 01:52:03 +0000 (03:52 +0200)]
[BUGFIX] Fluid viewhelper f:format.date() uses timestamp from context aspect

Use timestamp from context runtime instead of use time() in
viewhelper calls to prevent different dates in rendering process.

Resolves: #87935
Releases: master, 9.5
Change-Id: I8d4f2a231746a9a4cdc280c710ae07d9499e3d3e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60454
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
8 months ago[BUGFIX] Fix header levels for ViewHelper class comments 69/60569/2
Sybille Peters [Fri, 26 Apr 2019 11:55:30 +0000 (13:55 +0200)]
[BUGFIX] Fix header levels for ViewHelper class comments

Resolves: #88225
Releases: master, 9.5
Change-Id: I58166253bb451c829fe778379d8ada7644d63749
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60569
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
8 months ago[BUGFIX] Make AdvancedPassword confirmation error translatable 73/60573/4
Michael Waack [Fri, 26 Apr 2019 12:55:44 +0000 (14:55 +0200)]
[BUGFIX] Make AdvancedPassword confirmation error translatable

Resolves: #87722
Releases: master, 9.5
Change-Id: Icabb810a67a900ff0632256d36fb05b888912f83
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60573
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
8 months ago[BUGFIX] Render content element in ConfirmationFinisher 59/60559/4
Michael Waack [Fri, 26 Apr 2019 07:16:31 +0000 (09:16 +0200)]
[BUGFIX] Render content element in ConfirmationFinisher

Resolves: #87875
Releases: master
Change-Id: If093b8c0fa842060dcf64a984b426a8205095fe8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60559
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
8 months ago[TASK] Add editor tutorial for photo contest form 75/60575/3
Susanne Moog [Fri, 26 Apr 2019 13:43:02 +0000 (15:43 +0200)]
[TASK] Add editor tutorial for photo contest form

Add an editor tutorial to form docs for creating
photo contests to demonstrate the usage of

- image upload
- static text
- summary pages
- email to receiver finisher
- redirect finisher

Related: #82340
Resolves: #88217
Releases: master
Change-Id: I9bc0e7006a9a33ade9d9b051560843940bc4453e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60575
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
8 months ago[BUGFIX] Close file resource in FileLockStrategy if acquire failed 31/60531/4
Markus Klein [Wed, 24 Apr 2019 16:49:43 +0000 (18:49 +0200)]
[BUGFIX] Close file resource in FileLockStrategy if acquire failed

When acquiring a lock via the FileLockStrategy it is very important
to close the underlying file handle again, if the acquire action failed.

The same instance of the FileLockStrategy might be reused later
(e.g. in TSFE) again, whereas the (still open) file could have been
deleted meanwhile. The file handle would be invalid and another try
to open the same file again - with fopen() - may fail.
The behaviour of PHP's fopen() is different depending on the actual
file storage. Currently things fail on host-mounted drives in
containers in Docker for Windows.

Resolves: #88197
Releases: master, 9.5, 8.7
Change-Id: If802c670b617119d28aca09fcd5acef95f0ae678
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60531
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Reviewed-by: Susanne Moog <look@susi.dev>
8 months ago[TASK] Raise twitter bootstrap to 3.4.1 56/60556/2
Benni Mack [Thu, 25 Apr 2019 19:22:03 +0000 (21:22 +0200)]
[TASK] Raise twitter bootstrap to 3.4.1

To ensure that we incorporate the latest known
vulnerabilities and issues in Twitter Bootstrap 3.x,
the dependency is updated.

Executed tasks:
  cd Build
  yarn add bootstrap-sass@^3.4.1 --dev
  yarn exec grunt

Then copying the contents of Build/node_modules/bootstrap-sass/assets/javascripts/bootstrap.min.js
into typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap/bootstrap.js
additionally adding the AMD factory wrapper.

Resolves: #88213
Releases: master, 9.5, 8.7
Change-Id: Iae1274b1ca557f6337eea090e39292938b9571f2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60556
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[TASK] Incorporate changes of jQuery version to 3.4.0 57/60557/2
Andreas Fernandez [Mon, 22 Apr 2019 13:33:43 +0000 (15:33 +0200)]
[TASK] Incorporate changes of jQuery version to 3.4.0

All jQuery versions prior to 3.4 are susceptible to prototype pollution.
In order to fix this issue, jQuery has been updated to version 3.4.0.

http://blog.jquery.com/2019/04/10/jquery-3-4-0-released/

Executed commands:

    yarn add --dev jquery@^3.4
    grunt build

Resolves: #88214
Releases: master, 9.5, 8.7
Change-Id: I8c8eed08b0dcec7fe6762dbc70b62064a60c1e73
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60557
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[TASK] Introduce Editor Documentation for EXT:form 53/60553/3
Susanne Moog [Thu, 25 Apr 2019 18:56:04 +0000 (20:56 +0200)]
[TASK] Introduce Editor Documentation for EXT:form

To allow documentation for editors to be rendered alongside the
integrator documentation, the documentation structure of EXT:form
has been adjusted.

As the rst file paths have been too long in the past, the folder names
introduced uses the shortest name possible to not run into problems again.

The folder `I` now contains Integrator content.
The folder `E` is prepared for Editor content.

A first tutorial for editors has also been written and added to directly
have content for the new folder structure.

Related: #82358
Resolves: #88211
Releases: master
Change-Id: I6f485c20832d669c107c4e38472dffaf8ff35276
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60553
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
8 months ago[TASK] Document proposed folder structure 46/60546/5
Björn Jacob [Thu, 25 Apr 2019 14:35:14 +0000 (16:35 +0200)]
[TASK] Document proposed folder structure

The documentation of the form framework now
recommends a folder structure for a custom
form configuration, form definitions, templates
and language files. In addition, code snippets
have been adapted.

Resolves: #82714
Releases: master, 9.5
Change-Id: I7b81985fb2a2c4c9a9d65146e467b9b0cf227e89
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60546
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
8 months ago[BUGFIX] Properly handle quotes in plaintext mails 45/60545/3
Michael Waack [Thu, 25 Apr 2019 13:49:47 +0000 (15:49 +0200)]
[BUGFIX] Properly handle quotes in plaintext mails

Both email finishers of the form framework do not escape quotes anymore
when sending plain text mails.

Resolves: #85150
Releases: master, 9.5
Change-Id: Iadcfca66439bb2636f0e47173f96a74ea68653b6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60545
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
8 months ago[TASK] Transliterate accented characters 43/60543/4
Dominik Merkel [Thu, 25 Apr 2019 13:03:28 +0000 (15:03 +0200)]
[TASK] Transliterate accented characters

Convert accented characters in the form name
to ASCII characters

Resolves: #84533
Releases: master
Change-Id: I125a8df2f23d52d17ef2c1db4b5a9e113ae84f9c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60543
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
8 months ago[TASK] Update Settings.cfg to recent TYPO3 version 41/60541/3
Björn Jacob [Thu, 25 Apr 2019 13:02:05 +0000 (15:02 +0200)]
[TASK] Update Settings.cfg to recent TYPO3 version

Resolves: #85145
Releases: master, 9.5
Change-Id: I9a100af51d90f5a0da3a9d891748a6805cae6a47
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60541
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
8 months ago[BUGFIX] Fix DeleteUploadsFinisher with recyclers 40/60540/3
Michael Waack [Thu, 25 Apr 2019 12:25:15 +0000 (12:25 +0000)]
[BUGFIX] Fix DeleteUploadsFinisher with recyclers

Resolves: #86940
Releases: master, 9.5
Change-Id: Ice33805a10722459d28bacc89385e57e9618bba5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60540
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
8 months ago[TASK] Add class attribute for field type hidden 38/60538/2
siegtob [Thu, 25 Apr 2019 10:00:36 +0000 (12:00 +0200)]
[TASK] Add class attribute for field type hidden

Resolves: #88154
Releases: master
Change-Id: I45ca6387333061309be05047f5bbd75cf4ab9acd
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60538
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Dominik M <aceio@web.de>
Reviewed-by: Michael Waack <m.waack@i-d.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Michael Waack <m.waack@i-d.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
8 months ago[BUGFIX] Make filter in workspace module work again 99/60499/3
Benni Mack [Wed, 17 Apr 2019 19:15:52 +0000 (21:15 +0200)]
[BUGFIX] Make filter in workspace module work again

If no additional fields have been defined, the workspace
module search should use default columns that are shown
by TYPO3 Core.

Resolves: #86766
Releases: master, 9.5
Change-Id: I1d9ddb17b87c87ce07ebbf2ae20d6b5d0da59b06
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60499
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Achim Fritz <af@achimfritz.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Achim Fritz <af@achimfritz.de>
Reviewed-by: Benni Mack <benni@typo3.org>
8 months ago[BUGFIX] Remove Windows line breaks 33/59833/3
Guido Schmechel [Sat, 2 Mar 2019 10:38:50 +0000 (11:38 +0100)]
[BUGFIX] Remove Windows line breaks

In order to prevent a faulty configuration and silent output,
line breaks in the MetaData value are now also removed.

Resolves: #87821
Releases: master, 9.5
Change-Id: I243ce719474326dea24805695e27b793ba22ef6a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59833
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
9 months ago[BUGFIX] Add extension suggestions to EXT:form 07/59807/3
Andreas Fernandez [Tue, 26 Feb 2019 09:21:24 +0000 (10:21 +0100)]
[BUGFIX] Add extension suggestions to EXT:form

EXT:form adds a ContextMenu provider which depends on classes of
EXT:filelist. As EXT:filelist is optional in Composer mode, add the
extension as a suggestion and register the ContextMenu provider only in
case the extension is loaded.

Similar guards are added for hooks of EXT:filelist and EXT:impexp.

Resolves: #87785
Releases: master, 9.5
Change-Id: I254137bc85c87c3d2b6571e32676e7a579f342a9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59807
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
9 months ago[BUGFIX] Use correct value for remove function 97/58997/8
Devid Messner [Fri, 30 Nov 2018 08:53:48 +0000 (09:53 +0100)]
[BUGFIX] Use correct value for remove function

The function "remove" requires a string for the param $id,
but got an array.

Resolves: #87046
Releases: master, 9.5
Change-Id: Ia7b6d7ac107f65fb219577e2803509fb7882d21a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/58997
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] Overlay workspace records in Live Search 97/60497/2
Benni Mack [Wed, 17 Apr 2019 18:39:20 +0000 (20:39 +0200)]
[BUGFIX] Overlay workspace records in Live Search

The live search in the top right corner should detect and find
records of the current workspace.

A protected method which was unused is also removed.

Resolves: #36282
Releases: master, 9.5
Change-Id: I759e4f6dbd0c1676d9800d8319caf8b93ec0ecc5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60497
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
9 months ago[BUGFIX] Sanitize undefined TCA columns required for data integrity 11/60511/4
Oliver Hader [Thu, 18 Apr 2019 11:17:39 +0000 (13:17 +0200)]
[BUGFIX] Sanitize undefined TCA columns required for data integrity

TCA's 'ctrl' section allows to define several database columns that
shall be used to store according integrity information, such as the
current language or pointers to ancestors used during localization.

In case those names are not defined properly in TCA's 'columns'
section, several commands (like copy of localize) are executed,
but without actually maintaining these values in the database.

In order to ensure integrity, missing columns that are defined in
the 'ctrl' section but missing in the 'columns' section are applied
with the TCA type 'passthrough'. This applies to 'ctrl' properties

* origUid
* languageField
* translationSource
* transOrigPointerField

Resolves: #88057
Releases: master, 9.5
Change-Id: I39a28dc2e1eddafe6363b7dd633fd84968fc620f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60511
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[BUGFIX] Correction of the userdefined time range 02/60502/3
Guido Schmechel [Wed, 17 Apr 2019 20:28:04 +0000 (22:28 +0200)]
[BUGFIX] Correction of the userdefined time range

In the backend log view, the user-defined time range is recognized again.
Now the log entries observe the time limits and are displayed correctly.

Resolves: #88146
Releases: master, 9.5
Change-Id: Ie70260de42d46e34370e35c9a25c01efb3333dd5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60502
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
9 months ago[TASK] Streamline formatting of html templates 22/60522/2
Benjamin Kott [Sun, 21 Apr 2019 10:19:42 +0000 (12:19 +0200)]
[TASK] Streamline formatting of html templates

The indentations in the HTML templates are out of control.
Even if we provide an EditorConfig, which should ensure
that the files are all uniformly indented. There seems to
have been an increasing aversion to TABS over time.

This has led to the fact that above all newly created templates
have always been indented with SPACES instead of TABS.
We now have a mix of TABS and SPACES in our project, partly
also in a single file.

To avoid this in the future, all existing templates were converted
to indentations with SPACES and the provided EditorConfig was
adapted. In order to really, really make sure that it doesn't get
out of hand, we also introduce a new linter, which ensures
that all HTML templates are properly indented.

Resolves: #88180
Releases: master
Change-Id: I86d23120bc68e3696f398b1ae76f1efc4804d501
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60522
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Oliver Wand <wand@itaw.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[BUGFIX] Make loading of depth in workspace module work for 0 08/60508/2
Daniel Goerz [Thu, 18 Apr 2019 07:09:46 +0000 (09:09 +0200)]
[BUGFIX] Make loading of depth in workspace module work for 0

The implementation of storing the depth selection in the
workspace module did not account for the "This site"
option and the according value "0".

With this patch now all options of the depth selector can
be stored and loaded from UC.

Resolves: #88168
Releases: master, 9.5
Change-Id: I21ea3a4e300dbb71516679ea9f5ac901364b0c4c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60508
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Achim Fritz <af@achimfritz.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Achim Fritz <af@achimfritz.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[!!!][TASK] Remove auto-unpublishing of workspaces 82/60482/3
Benni Mack [Tue, 16 Apr 2019 03:46:11 +0000 (05:46 +0200)]
[!!!][TASK] Remove auto-unpublishing of workspaces

Workspaces had a field called "unpublish_time" which was not accessible
for TYPO3 Core since TYPO3 4.5. The field was still processed, but never
in use due to side-effects.

The functionality has therefore been removed without substitution.

Resolves: #81950
Releases: master
Change-Id: I6d79b78246103ef485a4d9d0de791b03d10d08a5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60482
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[BUGFIX] Make CodeMirror search persistent 90/60490/3
Andreas Fernandez [Wed, 17 Apr 2019 09:24:14 +0000 (11:24 +0200)]
[BUGFIX] Make CodeMirror search persistent

Currently, when searching a term in CodeMirror (used in EXT:t3editor),
the search bar disappears when after the operation, which is super
annoying.

The configuration of CodeMirror is slightly changed to keep the
search bar always present until closed explicitly.

Resolves: #88162
Releases: master, 9.5
Change-Id: I8780d9b10816c1667c14b0a23f50428a5f081579
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60490
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Josef Glatz <josefglatz@gmail.com>
Tested-by: Sven Juergens <typo3@blue-side.de>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Josef Glatz <josefglatz@gmail.com>
Reviewed-by: Sven Juergens <typo3@blue-side.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
9 months ago[BUGFIX] Mark symfony/routing 4.2.7 as conflict 09/60509/8
Susanne Moog [Thu, 18 Apr 2019 20:49:14 +0000 (22:49 +0200)]
[BUGFIX] Mark symfony/routing 4.2.7 as conflict

Symfony/routing 4.2.7 changed routing behaviour, breaking backwards
compatibility and our implementation. Reported at symfony:

https://github.com/symfony/symfony/pull/31107#issuecomment-484681404

Mark that version as conflict until the behaviour is fixed.

Composer commands:
 - composer update --lock

Resolves: #88171
Releases: master, 9.5
Change-Id: I6f2651a605c6339222626d37c307c04b8f0eadf8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60509
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Josef Glatz <josefglatz@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
9 months ago[BUGFIX] Fix alias of SaltedPasswordsService 05/60505/2
Benni Mack [Wed, 17 Apr 2019 21:45:20 +0000 (23:45 +0200)]
[BUGFIX] Fix alias of SaltedPasswordsService

A simple typo.

In TYPO3 v9.5 there need to be more adjustments done.

Resolves: #88007
Releases: master, 9.5
Change-Id: I6cd49b18b048b0e3b4362fc53c89a4617914f913
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60505
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Josef Glatz <josefglatz@gmail.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Josef Glatz <josefglatz@gmail.com>
Reviewed-by: Susanne Moog <look@susi.dev>
9 months ago[BUGFIX] Don't show new button when adding a new record 06/60506/2
Benni Mack [Wed, 17 Apr 2019 21:49:02 +0000 (23:49 +0200)]
[BUGFIX] Don't show new button when adding a new record

As there is no "pid" available, the new button on new
records should not be shown.

Resolves: #87721
Releases: master, 9.5
Change-Id: Ie3521882e38f031d3362de841351b058faed9521
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60506
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Josef Glatz <josefglatz@gmail.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Josef Glatz <josefglatz@gmail.com>
Reviewed-by: Susanne Moog <look@susi.dev>
9 months ago[BUGFIX] Ensure www.mydomain.com/index.php works 03/60503/2
Benni Mack [Wed, 17 Apr 2019 21:17:00 +0000 (23:17 +0200)]
[BUGFIX] Ensure www.mydomain.com/index.php works

Calling just "index.php" without "id" and "type" parameter
should work as expected, as before.

Resolves: #88028
Releases: master, 9.5
Change-Id: I36df591b8b334b9b5908563ca554cab98acba32a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60503
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Josef Glatz <josefglatz@gmail.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Josef Glatz <josefglatz@gmail.com>
Reviewed-by: Susanne Moog <look@susi.dev>
9 months ago[BUGFIX] URL without base runs into a redirect loop 91/59891/5
Marco Kaiser [Wed, 6 Mar 2019 20:32:00 +0000 (21:32 +0100)]
[BUGFIX] URL without base runs into a redirect loop

Calling something like bla.example.com/?id=34&type=2
runs in a endless loop.

The change removes the restrictive redirect.

Change-Id: I0457c48640d6b47a0947ed5115a96cf73cc97d81
Resolves: #88032
Releases: master, 9.5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59891
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[BUGFIX] Repair depth selection in workspace module 95/60495/3
Daniel Goerz [Wed, 17 Apr 2019 17:40:08 +0000 (19:40 +0200)]
[BUGFIX] Repair depth selection in workspace module

This patch fixes a regression introduced with
https://review.typo3.org/#/c/Packages/TYPO3.CMS/+/60492/

Resolves: #43338
Releases: master, 9.5
Change-Id: I3ac8445ec21097531ff1dcb5e33d0ff271332be3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60495
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Sattler <sattler@b13.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Sattler <sattler@b13.de>
Reviewed-by: Achim Fritz <af@achimfritz.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
9 months ago[BUGFIX] Allow to check/uncheck all recipients in Workspace stage dialog 94/60494/2
Benni Mack [Wed, 17 Apr 2019 17:06:02 +0000 (19:06 +0200)]
[BUGFIX] Allow to check/uncheck all recipients in Workspace stage dialog

The stage dialog shows various users relevent in a workspace that
should be notified. However, it is hard for editors (UX wise) to
uncheck / check everybody when a single element should be pushed
into the next stage.

The patch adds two buttons to toggle the checkboxes (check/uncheck all).

Resolves: #59228
Releases: master, 9.5
Change-Id: I2ebbcb7ec2d46b50880f93aefd243ef791300a2e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60494
Tested-by: Daniel Sattler <sattler@b13.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Daniel Sattler <sattler@b13.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
9 months ago[BUGFIX] Store depth selector in workspace module in uc 92/60492/2
Benni Mack [Wed, 17 Apr 2019 16:01:16 +0000 (18:01 +0200)]
[BUGFIX] Store depth selector in workspace module in uc

The depth selector is now stored in the users' UC, so the Persisent
Storage API can now be used easily.

This way, when changing pages, the depth selector value is kept.

Resolves: #43338
Releases: master, 9.5
Change-Id: I8fd49556e24f717cfa1b9e881a603f5adf5ce617
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60492
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Sattler <sattler@b13.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Daniel Sattler <sattler@b13.de>
9 months ago[BUGFIX] Check if language is accessible before uri generation 12/60212/9
Jonas Schwabe [Fri, 8 Mar 2019 14:59:04 +0000 (15:59 +0100)]
[BUGFIX] Check if language is accessible before uri generation

Sites with error handling were not rendering the correct page for
disabled languages because an inaccessible language was used
internally.

Resolves: #87865
Releases: master, 9.5
Change-Id: I8f6219d742c74359e0009085711f5452dc139f40
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60212
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jonas Schwabe <jonas.schwabe@eyeworkers.de>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Jonas Schwabe <jonas.schwabe@eyeworkers.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
9 months ago[BUGFIX] Ensure PageRouter only operates with previous result 74/60474/2
Benni Mack [Mon, 15 Apr 2019 04:52:49 +0000 (06:52 +0200)]
[BUGFIX] Ensure PageRouter only operates with previous result

If no previous result given, an exception should be thrown,
instead of a PHP error.

Resolves: #88133
Releases: master, 9.5
Change-Id: I708e735e664589b0fc8d125a60b9970128b584af
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60474
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Dmitry Dulepov
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Dmitry Dulepov
Reviewed-by: Susanne Moog <look@susi.dev>
9 months ago[TASK] Add missing fe_login hooks to docs 43/60443/6
Stephan Großberndt [Wed, 10 Apr 2019 10:11:12 +0000 (12:11 +0200)]
[TASK] Add missing fe_login hooks to docs

Add the missing documentation of the hooks

 * `password_changed` added in TYPO3 4.3
 * `login_error` added in TYPO3 6.0

Releases: master, 9.5, 8.7
Resolves: #88131
Related: #87726, #29698
Change-Id: I0dc875a399da58e13b15225e173392565c64bb03
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60443
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Julian Geils <j_geils@web.de>
Tested-by: Steffen Frese <steffenf14@gmail.com>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Julian Geils <j_geils@web.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
9 months ago[BUGFIX] Simplify UX in Workspace Module 76/60476/4
Benni Mack [Mon, 15 Apr 2019 11:26:52 +0000 (13:26 +0200)]
[BUGFIX] Simplify UX in Workspace Module

Some minor remarks are changed within the Workspace
Module (ReviewController).

- The preview link in docheader now has a text (makes it readable for newcomers)
- The checkboxes are now in the first column
- The modal box is bigger for increased readability

Resolves: #88151
Releases: master, 9.5
Change-Id: I2bbc581d73b0263d77029c533381c52f527dac42
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60476
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
9 months ago[FEATURE] Add properties changefreq and priority to XML sitemap entries 34/59834/19
Guido Schmechel [Sat, 2 Mar 2019 22:45:38 +0000 (23:45 +0100)]
[FEATURE] Add properties changefreq and priority to XML sitemap entries

The possibility to define the properties changefreq and priority for
XML sitemap entries has been implemented.

Resolves: #87433
Releases: master
Change-Id: I90b8c59ff916110be19aa8e8c888e77f25649bc3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59834
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
9 months ago[BUGFIX] Fix labels and field ordering of workspaces TCA 79/60479/2
Benni Mack [Mon, 15 Apr 2019 13:14:48 +0000 (15:14 +0200)]
[BUGFIX] Fix labels and field ordering of workspaces TCA

Labels regarding sys_workspaces are now in the same file,
and the fields / tabs have been grouped to ensure workspace
admins can work more efficiently with the records.

This way, the functionality is more self-explaining.

Resolves: #88152
Releases: master, 9.5
Change-Id: Ie55eada9956375bf0533affde80a927bcebb3502
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60479
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Achim Fritz <af@achimfritz.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Achim Fritz <af@achimfritz.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
9 months ago[BUGFIX] Apply quality settings for images 64/60464/3
Benni Mack [Sat, 13 Apr 2019 06:25:10 +0000 (08:25 +0200)]
[BUGFIX] Apply quality settings for images

When combining or scaling images, the quality
setting needs to be applied as well.

Resolves: #31664
Releases: master, 9.5
Change-Id: Iab4d7247c1ee51483b9ede705f6c61ba11f37589
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60464
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[BUGFIX] Allow adding content without page edit permissions 72/59872/2
Helmut Hummel [Tue, 5 Mar 2019 15:03:34 +0000 (16:03 +0100)]
[BUGFIX] Allow adding content without page edit permissions

Resolves: #87687
Releases: master, 9.5
Change-Id: I8113f3fa2facf6b21bc19ee1c445265c5ff4f4b4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59872
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
9 months ago[BUGFIX] Fix serialization of loggers 25/60325/2
Helmut Hummel [Mon, 25 Mar 2019 08:01:11 +0000 (09:01 +0100)]
[BUGFIX] Fix serialization of loggers

Only dealing with PHP file resource in writers is not
enough to properly initialize a logger on wakeup.

A logger has to log with a new request IDs and possibly completely new writers
and processors due to configuration changes in the meantime.

Therefore the __sleep and __wakeup methods are removed in the FileWriter
and new methods are added to the logger instance to make sure a
wakeup will have a correctly configured logger instance.

Resolves: #86941
Resolves: #87261
Releases: master, 9.5
Change-Id: Ia36e251404eae2bdf0dfdf52ace7dcf1815ec456
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60325
Tested-by: Ralf Merz <mail@merzilla.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Ralf Merz <mail@merzilla.de>
Reviewed-by: Susanne Moog <look@susi.dev>
9 months ago[BUGFIX] Use finder instance correctly 39/59839/13
Jan Delius [Mon, 4 Mar 2019 12:52:41 +0000 (13:52 +0100)]
[BUGFIX] Use finder instance correctly

Within SiteTcaConfiguration, the $finder is now reused as much as
possible. A new clean instance is used for the individual actions.

Resolves: #87832
Releases: master, 9.5
Change-Id: I34f2d08c51042f2cfe6b4a09ac6152e0b552ab14
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59839
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Rico Drexler <rico.drexler@gmx.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <look@susi.dev>
9 months ago[BUGFIX] Prevent throwing warnings when extract svg image sizes 02/59802/4
Remo Häusler [Mon, 25 Feb 2019 16:02:30 +0000 (17:02 +0100)]
[BUGFIX] Prevent throwing warnings when extract svg image sizes

TYPO3 should silently ignore errors and warnings in svg images.

Resolves: #86428
Releases: master, 9.5, 8.7
Change-Id: I54bb19ac0a6c949a8b150808f52562b73653e739
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59802
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <look@susi.dev>
9 months ago[!!!][TASK] Replace config.persistence.classes typoscript 70/59570/13
Alexander Schnitzler [Sun, 27 Jan 2019 18:48:56 +0000 (19:48 +0100)]
[!!!][TASK] Replace config.persistence.classes typoscript

This patch removes support for the configuration of
persistence related classes via typoscript. This is done
as typoscript is too variable, i.e. the configuration may
change depending on the day, the hour and whatever
possibility typoscript has when it comes to conditions.

The functionality must not vanish completely, but the
configuration should be immutable and predictable at an
early stage of the runtime.

To achieve this, the configuration has to be added to files
like EXT:Configuration/Extbase/Persistence/Classes.php

This patch is considered breaking as the configuration via
typoscript stops working immediately and the configuration
syntax slightly changed.

The easiest way to migrate to the new syntax is to have a
look at configuration files in core extensions.

Releases: master
Resolves: #87623
Change-Id: Id1ceceafd10ec647507bca8078ebf62fe1b02d2a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59570
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <look@susi.dev>
9 months ago[BUGFIX] Use proper TYPO3_CONF_VARS IM option 65/60465/2
Benni Mack [Sat, 13 Apr 2019 06:33:10 +0000 (08:33 +0200)]
[BUGFIX] Use proper TYPO3_CONF_VARS IM option

There is a copy/paste typo in LocalCropScaleMaskHelper,
which was introduced in TYPO3 v8.

The setting $TYPO3_CONF_VARS[GFX][processor_stripColorProfileCommand]
is the correct one.

Resolves: #87548
Releases: master, 9.5
Change-Id: I4f9e4f3f62e1b577a986c96a31d4438da1bc7f74
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60465
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Susanne Moog <look@susi.dev>
9 months ago[TASK] Add tests for SiteBased translations in Extbase records 61/60461/3
Benni Mack [Fri, 12 Apr 2019 23:24:18 +0000 (01:24 +0200)]
[TASK] Add tests for SiteBased translations in Extbase records

As part of using the SiteBased translation model instead of
the legacy TypoScript settings, another test suite is added
which mimics the exact same settings and results as in TypoScript
for Extbase.

Resolves: #88142
Releases: master, 9.5
Change-Id: Ieaa2e0d6cb510e6e00555e848020d89e8e1f5670
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60461
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
9 months ago[TASK] Migrate SelectElementTree to TypeScript 16/60316/4
Andreas Fernandez [Sat, 23 Mar 2019 10:32:52 +0000 (11:32 +0100)]
[TASK] Migrate SelectElementTree to TypeScript

This patch migrates FormEngine's SelectElementTree to TypeScript.
Also, a terrible hack that puts the local tree initialitation callback
into global scope has been removed.

Resolves: #87987
Releases: master
Change-Id: Ib34ae7fe4ac1e197af2183b8890cc72e13a900e9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60316
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Steffen Frese <steffenf14@gmail.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[BUGFIX] Populate href lang URI only if the link is available 50/60350/5
Julian Wundrak [Thu, 28 Mar 2019 20:11:03 +0000 (21:11 +0100)]
[BUGFIX] Populate href lang URI only if the link is available

If there are e.g., records that have no translation, the
HrefLangGenerator outputs the site-base URL. Expected is that the entry
for this page is suppressed.

Change-Id: I6fbd4dd00955906dff13c0e5aceea6804c52dd1b
Resolves: #88032
Releases: master, 9.5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60350
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
9 months ago[BUGFIX] Catch TypeError on inlineCSS files 20/60420/2
Benni Mack [Tue, 9 Apr 2019 02:01:05 +0000 (04:01 +0200)]
[BUGFIX] Catch TypeError on inlineCSS files

If page.includeCSS.myfile.import = 1 is used, but no "media" is set, a TypeError
is thrown, which is now caught and properly checked.

Resolves: #88059
Releases: master, 9.5
Change-Id: I0951688bb9ee779329ebe5c7fad698862d73f6c3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60420
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Julian Geils <j_geils@web.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Julian Geils <j_geils@web.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Benni Mack <benni@typo3.org>
9 months ago[FEATURE] Re-introduce mixed overlay mode for content fallback 67/60367/6
Benni Mack [Wed, 3 Apr 2019 14:29:42 +0000 (16:29 +0200)]
[FEATURE] Re-introduce mixed overlay mode for content fallback

This "feature" solves a lot of issues, but I really wanted to make sure
to cover the generic issues around this topic.

In order to understand this, we need to understand the different
logic when talking about "language fallbacks", but I don't want
to warm up how it was before.

This is how it works:
- fallbackChain: defines which page translation should be checked
when linking or resolving a page in a specific language
- fallbackType: Now that we covered all relevant cases, the naming
could be better, but here we go, it's actually defining the logic for fetching
content.
- fallbackType="strict" -> only show the content that is viable in the target language
  but this is based on "overlays". Fetch all "language=0" records, do overlays
  and remove the ones that have no overlays. However, take the ones that have no
  language parent and render them as well ("includeWithoutDefaultTranlsation")
  This is what we call "do overlays with floating".
  This is recommended to do in most classic translation cases, with different languages
- fallbackType="fallback" -> Do overlays: Fetch all "language=0" records, do overlays
  but KEEP the ones that have no overlays. However, take the ones that have no
  language parent and render them as well ("includeWithoutDefaultTranlsation")
  This is what we call "do overlays in mixed mode".
  Useful if your translation is Swiss-German but your default language is "German"
- fallbackType="free" - Do not do overlays, just fetch all records of the target language
  Could be seen as "free mode" as we do it in TYPO3 Page module.

The new free option is therefore new, also the "fallback" functionality
is actually showing more content than before (thus, different, but maybe we could fix that!)
as we have the "mixed" mode back.
Also the "language fallback" is now possible for any fallbackType.

Now, what's still missing - but out of scope - is actually a way to fetch content
with multiple possibilities for overlaying. I call this "forward language overlays"
however, this is a feature that is theoretically possible but not in v9 anymore.

This patch restores the max. types of use cases back for TYPO3 Core.

The following things that are really gone for good now and won't come back:
- config.sys_language_mode = ignore
- config.sys_language_mode =
- Option includeRecordsWithoutDefaultTranslation (= always enabled) is not needed anymore

Also, there are no ways anymore to use inconsistent multiple TypoScript settings which
do not make sense depending if the translated page does not exist (l18n_cfg)
but still using TypoScript conditions for that.

Resolves: #86762
Resolves: #86712
Releases: master, 9.5
Change-Id: I8b3144410f7d7ed1d705d42f16a46f190275387a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60367
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Nikolaj Wojtkowiak-Pfänder <nwp@dr-bock.com>
Tested-by: Steven Hilgendorff
Tested-by: Ralf Merz <mail@merzilla.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Nikolaj Wojtkowiak-Pfänder <nwp@dr-bock.com>
Reviewed-by: Ralf Merz <mail@merzilla.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[TASK] Add tests for pages.slug in workspaces tests 42/60242/3
Benni Mack [Wed, 13 Mar 2019 17:42:03 +0000 (18:42 +0100)]
[TASK] Add tests for pages.slug in workspaces tests

In order to see the current behaviour in
workspaces when modifying pages, the slug
field is added to the existing "Regular"
DataHandler tests within workspaces.

Resolves: #87904
Releases: master, 9.5
Change-Id: Ie2432fb078f2b04515a24de7b525b1c151186b05
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60242
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[TASK] Migrate TYPO3/CMS/Extensionmanager/* to TypeScript 53/60353/5
Frank Naegler [Fri, 29 Mar 2019 15:59:51 +0000 (16:59 +0100)]
[TASK] Migrate TYPO3/CMS/Extensionmanager/* to TypeScript

Resolves: #88040
Releases: master
Change-Id: I5408c30fef735fe52a4b58bda3fb5b4d3b8e002e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60353
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Steffen Frese <steffenf14@gmail.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
9 months ago[TASK] Migrate TYPO3/CMS/Impexp/* to TypeScript 50/60250/4
Frank Naegler [Thu, 14 Mar 2019 17:46:56 +0000 (18:46 +0100)]
[TASK] Migrate TYPO3/CMS/Impexp/* to TypeScript

Resolves: #87915
Releases: master
Change-Id: I4a7fa727c47b85bfae728f0a1dab0e6e833063ce
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60250
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Steffen Frese <steffenf14@gmail.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
9 months ago[TASK] Migrate TYPO3/CMS/Recycler/* to TypeScript 52/60352/5
Frank Naegler [Fri, 29 Mar 2019 13:04:31 +0000 (14:04 +0100)]
[TASK] Migrate TYPO3/CMS/Recycler/* to TypeScript

Resolves: #88038
Releases: master
Change-Id: I0441df6756bb4950b7875c74eed0e5bfff7625a7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60352
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Steffen Frese <steffenf14@gmail.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
9 months ago[FEATURE] Allow config.cache.all = fe_users:current 19/60419/4
Benni Mack [Tue, 9 Apr 2019 01:52:03 +0000 (03:52 +0200)]
[FEATURE] Allow config.cache.all = fe_users:current

The existing TypoScript functionality config.cache.all = ... allows a list
of tables and PIDs to take into account other records for the current page
caches.

The cache lifetime of page 42 takes starttime and endtime of news records of
page 15 and addresses of page 16 into account:

config.cache.42 = tt_news:15,tt_address:16

A new functionality used with "current" allows to take records of the current page
into account as well.

config.cache.all = fe_users:current

Resolves: #83734
Releases: master
Change-Id: Ib2063cc89e2c1549b7609b77948243e983d14c1b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60419
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Fabien Udriot <fudriot@omic.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] Do not use LSB in <f:form.select> 36/60436/4
Benni Mack [Wed, 10 Apr 2019 04:20:39 +0000 (06:20 +0200)]
[BUGFIX] Do not use LSB in <f:form.select>

<f:form.select.option> uses the FQDN::class
syntax, so late static binding (LSB) is leading
to side effects when extending <f:form.select>.

Using the self::class syntax in <f:form.select>
solves the issue.

Resolves: #88017
Releases: master, 9.5
Change-Id: Ic060267cdff06856d1aa0f76980124ecfc0967a5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60436
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] Use proper path to install cli binary 71/60371/7
Helmut Hummel [Thu, 4 Apr 2019 14:41:05 +0000 (16:41 +0200)]
[BUGFIX] Use proper path to install cli binary

The cli binary path is changed to be located in TYPO3_PATH_WEB
instead of TYPO3_PATH_ROOT.

Releases: 9.5, master
Resolves: #88088
Change-Id: I96587254d121149b58f35b0abb0084a89a31b0c7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60371
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
9 months ago[BUGFIX] Add table name as prefix for language DB selection 30/60430/2
Benni Mack [Tue, 9 Apr 2019 12:42:02 +0000 (14:42 +0200)]
[BUGFIX] Add table name as prefix for language DB selection

When building JOINs with TypoScript of tt_content or
any localized table, using "LEFTJOIN tt_content table2"
the language restriction check is not using a prefix
for the "l10n_parent" field.

The "sys_language_uid" field already has the same prefix
built in the same method.

This error existed in v8 already, but in TYPO3 v9, the
"includeRecordsWithoutDefaultTranslation" option is enabled
by default (via LanguageAspect), therefore it's more
prominent.

Resolves: #87521
Releases: master, 9.5
Change-Id: I1a3ee4f1f84d64a5d56cf63607a7aed83fdd13fc
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60430
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Julian Geils <j_geils@web.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Julian Geils <j_geils@web.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[TASK] Repair examples 24/60424/2
Stefan Frömken [Tue, 9 Apr 2019 08:49:07 +0000 (10:49 +0200)]
[TASK] Repair examples

Releases: master
Resolves: #88117
Change-Id: I5fa5da8f6697a74eda785c4655203f9d63c7b632
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60424
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Steffen Frese <steffenf14@gmail.com>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
9 months ago[BUGFIX] Allow FileInterface for ClickEnlarge ViewHelper 35/60435/2
Benni Mack [Wed, 10 Apr 2019 03:14:07 +0000 (05:14 +0200)]
[BUGFIX] Allow FileInterface for ClickEnlarge ViewHelper

Although the documentation and the internal
code allows File and FileReference, the functionality
requires a FileReference.

FileInterface is more appropriate and $cObj->imageLinkWrap()
can deal with File and FileReference.

Resolves: #82101
Releases: master, 9.5
Change-Id: I37e4f091fe0598509eef050cb811ad7627f16c21
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60435
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Steffen Frese <steffenf14@gmail.com>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[TASK] Move felogin TypoScript and TSconfig 14/60414/5
Jan Stockfisch [Mon, 8 Apr 2019 11:53:52 +0000 (13:53 +0200)]
[TASK] Move felogin TypoScript and TSconfig

Move all TypoScript and TSconfig from ext_localconf into separate files.

Resolves: #88105
Releases: master
Change-Id: I4b04352942f9ecc603c05072ec674340a7d73c25
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60414
Tested-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: Steffen Frese <steffenf14@gmail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[BUGFIX] Use PageTitle API for indexed_search 54/60354/7
Jonas Schwabe [Fri, 29 Mar 2019 16:52:11 +0000 (17:52 +0100)]
[BUGFIX] Use PageTitle API for indexed_search

The value of indexedDocTitle was not updated when a title had been
generated by the PageTitle API. This simply writes the generated
page title to indexedDocTitle so that it can be used in the
indexed hook.

Resolves: #88041
Releases: master, 9.5
Change-Id: I8ac1fd8295447aafa7e175fb09fa11f565442019
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60354
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Richard Haeser <richard@maxserv.com>
9 months ago[BUGFIX] Ensure to properly catch any connection exception 21/60421/2
Benni Mack [Tue, 9 Apr 2019 02:23:44 +0000 (04:23 +0200)]
[BUGFIX] Ensure to properly catch any connection exception

When e.g. a corrupt Database Connection is available
(MySQL down) and no connection is established, the Runtime
Exception should be caught as well.

In addition, the $message is more generic to avoid
any additional output for the end-users.

Resolves: #87993
Releases: master, 9.5
Change-Id: I2495426930d3fab841ff1632d778a945e73b521d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60421
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
9 months ago[TASK] Fix typo in form documentation 23/60423/4
Thorsten Griebenow [Tue, 9 Apr 2019 08:27:51 +0000 (10:27 +0200)]
[TASK] Fix typo in form documentation

Releases: master, 9.5, 8.7
Resolves: #88115
Change-Id: Ia1ab566ef3ebeff69a680b750b8e2ab4e8c9aba6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60423
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
9 months ago[BUGFIX] Fix handling menuConfig of LanguageMenuProcessor 32/60432/2
Daniel Gohlke [Tue, 9 Apr 2019 14:44:58 +0000 (16:44 +0200)]
[BUGFIX] Fix handling menuConfig of LanguageMenuProcessor

Use array_merge instead of union (+=) in order to
correctly handle overriding the menu configuration
of the LanguageMenuProcessor.

Resolves: #88123
Releases: master, 9.5
Change-Id: I1f382c11b2f24c052b97af2b7d62a6e0712e10e9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60432
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
9 months ago[TASK] Update columns in DocHeader bar 68/60368/4
Koen Wouters [Wed, 3 Apr 2019 18:57:40 +0000 (20:57 +0200)]
[TASK] Update columns in DocHeader bar

Dropdown fields will now stay next to each other for
responsive views.

Resolves: #88065
Releases: master, 9.5
Change-Id: I1990dc87dd69fd6c5470197277dc86c84f6c29de
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60368
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: André Schließer <andy.schliesser@gmail.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: André Schließer <andy.schliesser@gmail.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
9 months ago[TASK] Migrate TYPO3/CMS/Linkvalidator/* to TypeScript 55/60255/3
Frank Naegler [Fri, 15 Mar 2019 09:47:54 +0000 (10:47 +0100)]
[TASK] Migrate TYPO3/CMS/Linkvalidator/* to TypeScript

Resolves: #87920
Releases: master
Change-Id: Ibb3d28e85b6beddfd4bacca8303cca51c46ac6b3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60255
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
9 months ago[BUGFIX] Reenable Page TSconfig setting mod.web_list.hideTranslations 72/60372/3
Jan Helke [Fri, 5 Apr 2019 07:34:53 +0000 (09:34 +0200)]
[BUGFIX] Reenable Page TSconfig setting mod.web_list.hideTranslations

This regression fix reenables the setting mod.web_list.hideTranslations to
enable administrators to hide translations in the list view.
This behaviour is already described under
https://docs.typo3.org/typo3cms/TSconfigReference/PageTsconfig/Mod.html

Resolves: #88084
Releases: master, 9.5
Change-Id: I8bc0ce072a44c78564889325c888eb26fdb23a1c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60372
Tested-by: Sebastian Rosskopf <sebastian.rosskopf@gmx.de>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Raphael Thanner <r.thanner@zeroseven.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Windloff
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Sebastian Rosskopf <sebastian.rosskopf@gmx.de>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Raphael Thanner <r.thanner@zeroseven.de>
Reviewed-by: Daniel Windloff
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
9 months ago[BUGFIX] Refine build architecture 35/60335/9
Andreas Fernandez [Mon, 25 Mar 2019 15:52:34 +0000 (16:52 +0100)]
[BUGFIX] Refine build architecture

TypeScript:
Due to issues with upcoming TypeScript versions, the TypeScript sources
are moved into the Build directory before building JavaScript.

The unused Grunt task `tsdev` has been removed.

Additionally, some type defintions have been installed:

  yarn add --dev \
      @types/bootstrap-slider \
      @types/datatables.net \
      @types/chosen-js

Sass:
The Sass sources have been moved into the common "Sources" directory.
Those source files are moved to have a less cluttered Build directory.

Note: With this patch, all TypeScript files must be placed into
`Build/Sources/TypeScript` to be compiled by tsc again.

Resolves: #88043
Releases: master
Change-Id: I4d3e5f69564c38a35bf083652ea7262f5b85e4f3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60335
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
9 months ago[BUGFIX] Fix null coalesce evalutation in PageLayoutView::getLocalizedPageTitle() 00/60400/2
Andreas Fernandez [Fri, 5 Apr 2019 14:42:53 +0000 (16:42 +0200)]
[BUGFIX] Fix null coalesce evalutation in PageLayoutView::getLocalizedPageTitle()

This commit fixes a usage of the null coalesce operator within a condition.

Resolves: #88092
Related: #84375
Releases: master, 9.5
Change-Id: Ic34fb492e66eb224d0e617405e8ae2be69a16aa4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60400
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: André Schließer <andy.schliesser@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: André Schließer <andy.schliesser@gmail.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[BUGFIX] Deliver detected file type for IM identify 11/60311/7
Benni Mack [Fri, 22 Mar 2019 19:28:20 +0000 (20:28 +0100)]
[BUGFIX] Deliver detected file type for IM identify

Although not used in TYPO3 Core directly, the identify
command by ImageMagick now delivers the file extension
from IM plus the file type identified by IM as well.

This saves some regexp magic, and a foreach() loop,
as the "-format" output delivers proper IM results.

As this functionality is not actually fixing a core
bug, but rather a small improvement and correction
in the identified usage, the change is targeted to master-only.

Resolves: #23348
Releases: master
Change-Id: Ia380ee34dbbef7f9f763ecc088ee0c9b83167ce6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60311
Tested-by: Sebastian Rosskopf <sebastian.rosskopf@gmx.de>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Sebastian Rosskopf <sebastian.rosskopf@gmx.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[BUGFIX] DB check - search query, array handling on operator change 42/60342/3
Henrik Elsner [Tue, 26 Mar 2019 15:04:14 +0000 (16:04 +0100)]
[BUGFIX] DB check - search query, array handling on operator change

Exception is thrown when changing the operator from an array handling one
to a string handling. ("is in list" to "equals")
Also the selection is not set properly after changing.

Resolves: #88010
Releases: master, 9.5

Change-Id: Ibf7f607a51ac92d2c45dbfe16384f71c959e6c1f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60342
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Daniel Windloff
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[TASK] Remove superfluous function calls in page module 99/60399/2
Markus Klein [Fri, 5 Apr 2019 14:23:30 +0000 (16:23 +0200)]
[TASK] Remove superfluous function calls in page module

Resolves: #88091
Releases: master, 9.5
Change-Id: I3261190c1214dece4dce5d208a54af2b14b3aa0e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60399
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
9 months ago[BUGFIX] Use SiteFinder in SearchController for getting all languages 37/60337/4
Georg Ringer [Mon, 25 Mar 2019 20:59:25 +0000 (21:59 +0100)]
[BUGFIX] Use SiteFinder in SearchController for getting all languages

The SiteFinder must be used instead of only fetching all languages from
sys_language.

Resolves: #87999
Releases: master, 9.5
Change-Id: I95432c6221a8ee06d1fbb45a6780b0ec7c80ddf4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60337
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>