Packages/TYPO3.CMS.git
6 years ago[TASK] Move ExtensionManager Class part 1
Helmut Hummel [Sat, 3 Nov 2012 10:38:55 +0000 (11:38 +0100)]
[TASK] Move ExtensionManager Class part 1

Only move the class to keep track of history

Related: #42661
Releases: 6.0

Change-Id: I9118c41c78493369ccc12ff5443c3faf2261fad4
Reviewed-on: http://review.typo3.org/16162
Reviewed-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Re-implement update TER extension list task
Christian Kuhn [Sat, 3 Nov 2012 14:55:13 +0000 (15:55 +0100)]
[TASK] Re-implement update TER extension list task

The scheduler task to update the TER extension list on a regular basis
was removed with the implementation of the new extension manager.
The patch adds an updated version of it and takes care that
existing registered tasks of this type still work.

Change-Id: Ic770ed78f23413b589352c25998eaee7863ec64f
Resolves: #39915
Releases: 6.0
Reviewed-on: http://review.typo3.org/16168
Reviewed-by: Felix Kopp
Tested-by: Felix Kopp
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Missing pid field in ext_tables_static+adt.sql
Nicole Cordes [Fri, 2 Nov 2012 21:23:20 +0000 (22:23 +0100)]
[BUGFIX] Missing pid field in ext_tables_static+adt.sql

In the ext_tables.sql there is a pid field which is left in the
ext_tables_static+adt.sql file. This causes unnecessary ALTER queries in
database comparison.

Change-Id: Ia380f731c985a1739a88caf7c7f47fa3ec5a95cf
Fixes: #42655
Releases: 6.0
Reviewed-on: http://review.typo3.org/16152
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Regression test for issue #39677
Christian Kuhn [Fri, 2 Nov 2012 20:16:32 +0000 (21:16 +0100)]
[TASK] Regression test for issue #39677

Add simple regression test for issue #39677 checking
the generated string contains 'value="1"'

Change-Id: I3bb51be68c22878d519d2176ab358777780b34d6
Resolves: #42652
Related: #39677
Releases: 6.0
Reviewed-on: http://review.typo3.org/16151
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Failure in AbstractRepository::findByUid on deleted record
Oliver Hader [Thu, 1 Nov 2012 15:16:30 +0000 (16:16 +0100)]
[BUGFIX] Failure in AbstractRepository::findByUid on deleted record

Resource\AbstractRepository::findByUid fails if the record to
be fetched has been deleted or simply does not exist. The
condition whether something was fetched from database is wrong.

count(FALSE) is TRUE, thus it needs to be ensure that there is
a non-empty array.

Change-Id: I9fbdb2ed79ceef9ed0782eeed3db15af73636731
Releases: 6.0
Fixes: #42593
Reviewed-on: http://review.typo3.org/16102
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[BUGFIX] Update LocalConfiguration fails
Nicole Cordes [Wed, 31 Oct 2012 20:53:15 +0000 (21:53 +0100)]
[BUGFIX] Update LocalConfiguration fails

Due to changes in function
TYPO3\CMS\Core\Configuration\ConfigurationManager::writeLocalConfiguration
an error is thrown when the configuration file isn't accessable.

Of course when updating the system from a lower version it is not
available. So the installation process has to create the file on its own
to be able to write the settings.

Change-Id: I89553390ebd9f1f576311535e02ec73da6618cd6
Fixes: #42271
Releases: 6.0
Reviewed-on: http://review.typo3.org/16088
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] No sorting in TypoScript Object Browser when browsing
Nicole Cordes [Fri, 10 Aug 2012 10:41:55 +0000 (12:41 +0200)]
[BUGFIX] No sorting in TypoScript Object Browser when browsing

If you enable "Sort alphabetically" the correct value (1) is submitted to
extension settings. But when you use any other functionality of the page
(e.g. setting some conditions or use search filter) the value is set to
"on" which disables the sorting.

Change-Id: I88233f94edba032c9b23072fb5e9132b276c8f1e
Fixes: #39677
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/13567
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Add Test for namespaces in Logger names
Steffen Müller [Thu, 1 Nov 2012 11:53:19 +0000 (12:53 +0100)]
[TASK] Add Test for namespaces in Logger names

Resolves: #42582
Releases: 6.0

Change-Id: I5cf8c01ce1749be92e5e073b5812106ba08dc025
Reviewed-on: http://review.typo3.org/16100
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Enable extenisions with BE modules don't refresh the module list
Oliver Hader [Fri, 2 Nov 2012 12:43:49 +0000 (13:43 +0100)]
[BUGFIX] Enable extenisions with BE modules don't refresh the module list

When installing an extension with BE modules through the new
extension manager, the left frame with modules is not
refreshed. An accordant call to the module menu widget needs
to be triggered in those cases.

Change-Id: Ibead3b1a0da99be300c16ae3237986387294a74f
Releases: 6.0
Fixes: #42009
Reviewed-on: http://review.typo3.org/16129
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Require green PHP 5.4 build on travis again
Christian Kuhn [Fri, 2 Nov 2012 16:30:03 +0000 (17:30 +0100)]
[TASK] Require green PHP 5.4 build on travis again

Change-Id: Ifd13543b1b3b337171214f70087bc7010b3c0898
Reviewed-on: http://review.typo3.org/16146
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Use BE paginate widget in EM 6.0
Jigal van Hemert [Fri, 2 Nov 2012 13:48:51 +0000 (14:48 +0100)]
[TASK] Use BE paginate widget in EM 6.0

The backend paginate widget provides the familiar paginator
that is known from other parts of the backend.

Change-Id: I8bbf5851ca099e2219fefa777a26feba101eeaba
Fixes: #42583
Releases: 6.0
Reviewed-on: http://review.typo3.org/16133
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[BUGFIX] PHP 5.4 unit test warnings
Christian Kuhn [Fri, 2 Nov 2012 16:14:49 +0000 (17:14 +0100)]
[BUGFIX] PHP 5.4 unit test warnings

Incomplete mocking in some tests triggers
string offset PHP 5.4 warnings.

Fixes: #42644
Releases: 6.0

Change-Id: I261a7652909db21ee4839882a8360016cc854b2b
Reviewed-on: http://review.typo3.org/16144
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Speed up salted password unit test
Christian Kuhn [Fri, 2 Nov 2012 15:05:47 +0000 (16:05 +0100)]
[TASK] Speed up salted password unit test

The patch removes tests in blowfish and phpass salting classes that
test maximum iteration count returns a valid salt. The underlying
salt code is slow by design, so the tests also take ages. The
functionality itself is already covered by the minimum salt count
test as well, thus - after speaking with Marcus Krause - we decided
to remove them without substitution to reduce the unit test suite
runtime.

Resolves: #42639
Releases: 6.0

Change-Id: I4bf94dc8ae4726fa131f6113546442fb00718753
Reviewed-on: http://review.typo3.org/16141
Reviewed-by: Wouter Wolters
Tested-by: Marcus Krause
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Translated non-published page in workspace breaks live workspace
Oliver Hader [Fri, 26 Oct 2012 14:10:31 +0000 (16:10 +0200)]
[BUGFIX] Translated non-published page in workspace breaks live workspace

Translation of pages are stored in pages_language_overlay and
can be managed in workspaces as well. If a new translation is
created in the workspace only, the page module is broken in
the live workspace.

The reason for that is, that workspaces placeholders need to
be ignored if not working on a real workspace.

Change-Id: Ied52a985c3cb1c0796f616679414799d956024d8
Releases: 6.0, 4.7, 4.6, 4.5
Fixes: #42281
Reviewed-on: http://review.typo3.org/15958
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[BUGFIX] Illegal string offsets in t3lib_stdgraphic
Wouter Wolters [Sun, 28 Oct 2012 11:36:39 +0000 (12:36 +0100)]
[BUGFIX] Illegal string offsets in t3lib_stdgraphic

Illegal string offsets in t3lib_stdgraphic

Change-Id: I8be45d59b780595e25d6d7f5371300b6506baa2f
Fixes: #38024
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/12543
Reviewed-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years agoRevert "[BUGFIX] Hook to modify t3lib_div::getIndpEnv return value"
Christian Kuhn [Fri, 2 Nov 2012 12:23:17 +0000 (13:23 +0100)]
Revert "[BUGFIX] Hook to modify t3lib_div::getIndpEnv return value"

This reverts commit 33e72f56e8e5c4183c1784027639913581b225a9

Related: #39016
Releases: 6.0

Change-Id: I33ffcb206b2d4cac3cd7b683aec8df962c22d593
Reviewed-on: http://review.typo3.org/16127
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] PHP 5.4 unit test warnings
Christian Kuhn [Fri, 2 Nov 2012 11:09:29 +0000 (12:09 +0100)]
[BUGFIX] PHP 5.4 unit test warnings

PHP 5.4 throws warnings "Creating default object from empty value"
warnings if $foo->bar is accessed and $foo is not an object. The patch
fixes ConditionMatcherTest in this regard and does some other minor
cleanups within the test class.

Fixes: #42622
Releases: 6.0

Change-Id: I9d04618d88127b07d460be8dbd81c64633991bd6
Reviewed-on: http://review.typo3.org/16124
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Hook to modify t3lib_div::getIndpEnv return value
Michael Klapper [Tue, 17 Jul 2012 09:10:02 +0000 (11:10 +0200)]
[BUGFIX] Hook to modify t3lib_div::getIndpEnv return value

This hook makes it possible to modify the calculated return
value for custom environments.

Change-Id: I49a98565f8878cde44093ee2331d70b281e91f4f
Fixes: #39016
Releases: 6.0
Reviewed-on: http://review.typo3.org/12842
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
6 years ago[BUGFIX] "Upgrade Wizard" screen goes blank
Mattias Nilsson [Wed, 31 Oct 2012 17:39:28 +0000 (18:39 +0100)]
[BUGFIX] "Upgrade Wizard" screen goes blank

When using the "Upgrade Wizard" in install tool the screen goes blank.

Change-Id: I3a9c6bb2c86bbeb2c0fa17fd547e626eebfc2749
Resolves: #42569
Releases: 6.0
Reviewed-on: http://review.typo3.org/16083
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[TASK] Use new Be.Widget.Paginate in EXT: beuser
Felix Kopp [Wed, 31 Oct 2012 22:33:48 +0000 (23:33 +0100)]
[TASK] Use new Be.Widget.Paginate in EXT: beuser

Use the new ViewHelper be.widget.paginate for backend
user listing in EXT: beuser.

The ViewHelper was introduced in #42428.

Change-Id: Ic31d4a5aa1d6041d3fa5d610dffad02a3b5f87a3
Resolves: #42576
Releases: 6.0
Reviewed-on: http://review.typo3.org/16093
Reviewed-by: Mattias Nilsson
Reviewed-by: Oliver Klee
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[TASK] Raise submodule pointer
Christian Kuhn [Fri, 2 Nov 2012 00:30:50 +0000 (01:30 +0100)]
[TASK] Raise submodule pointer

Change-Id: I48a5498e10da7b1a1185324a35381f3bf4cd1815
Reviewed-on: http://review.typo3.org/16119
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Cleanup DebugUtility
Helmut Hummel [Thu, 1 Nov 2012 23:45:09 +0000 (00:45 +0100)]
[TASK] Cleanup DebugUtility

The debug utility outputs JavaScript, even when in CLI mode.
Additionally all strings are not correctly encoded for
JavaScript.

Additionally deprecate the method which does incomplete encoding.

Releases: 6.0
Resolves: #42611

Change-Id: I68fadc5d8f10e967913d1b79bc7758a5a18d77f6
Reviewed-on: http://review.typo3.org/16117
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] PHP 5.4 warning in CLI context in switch back user
Christian Kuhn [Thu, 1 Nov 2012 21:24:02 +0000 (22:24 +0100)]
[BUGFIX] PHP 5.4 warning in CLI context in switch back user

PHP 5.4 raises warnings of type "Illegal string offset" if you access
$foo['bar'] and $foo is no array. This is the case in hook
SwitchBackUser, if in cli context.

Furthermore, the class is cleaned up a bit in 6.0 version and the
compatibility layer is removed, since the hook file was moved around
together with the beuser refactoring anyway.

Change-Id: I5ed32e054b156c9fbc64e99ff33ba5c4637ce266
Fixes: #37578
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/16108
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Don't let PHP 5.4 failure fail the build on travis
Helmut Hummel [Thu, 1 Nov 2012 21:36:00 +0000 (22:36 +0100)]
[TASK] Don't let PHP 5.4 failure fail the build on travis

Change-Id: I21277f1f59a9055503414ae94f9dee626e1cd70d
Reviewed-on: http://review.typo3.org/16109
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Warning in FAL LocalDriverTest
Christian Kuhn [Thu, 1 Nov 2012 19:23:17 +0000 (20:23 +0100)]
[BUGFIX] Warning in FAL LocalDriverTest

A subfolder without write permissions makes the tearDown in FAL
LocalDriverTest throw a permission denied warning. This is fixed
by resetting the folder to be writable after gathering result
information in the test case.

Change-Id: I1eb9829b39af7ea67076252385e11701d4be3818
Fixes: #42604
Releases: 6.0
Reviewed-on: http://review.typo3.org/16107
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Failing Unit test in FAL LocalDriver
Christian Kuhn [Thu, 1 Nov 2012 18:56:52 +0000 (19:56 +0100)]
[BUGFIX] Failing Unit test in FAL LocalDriver

Issue #42603 changed the default behavior of the Driver systems
to also show hidden directories by default. This should be
reflected in the unit test with flipping the logic of one test
that actually tested the opposite and fails now.

Change-Id: I93492f2ec213423ffa06339f6a63de494d544534
Fixes: #42230
Related: #42603
Releases: 6.0
Reviewed-on: http://review.typo3.org/16105
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] FILES ContentObject ignores language handling
Steffen Ritter [Thu, 1 Nov 2012 09:39:09 +0000 (10:39 +0100)]
[BUGFIX] FILES ContentObject ignores language handling

The FILES TypoScript ContentObject, which is responsible
for rendering content element type "uploads" does not take
care of languages and pages_language_overlay table.

Change-Id: Ic311cf2162253bb1a382985df63999142b780555
Releases: 6.0
Resolves: #42357
Reviewed-on: http://review.typo3.org/16098
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Media field relation not resolved in translated pages
Steffen Ritter [Thu, 1 Nov 2012 08:30:28 +0000 (09:30 +0100)]
[BUGFIX] Media field relation not resolved in translated pages

Since the media field now is using IRRE relations and pages are
translated to an foreign table, the relation of translated media
images has to be resolved against the foreign_translation_table.

Change-Id: Iceb62704a6b694945c37bfacdb29e45cc3cf2b6c
Releases: 6.0
Resolves: #42249
Reviewed-on: http://review.typo3.org/16097
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Folder: File list filtering does not work
Andreas Wolf [Mon, 8 Oct 2012 14:36:27 +0000 (16:36 +0200)]
[BUGFIX] Folder: File list filtering does not work

To filter a file list for certain file extensions, the
FileExtensionFilter class should be used. However, the element browser
currently tries to directly call getFiles() with a file extension list.

This commit adds filter handling methods to Folder and changes the EBs
behaviour to use them. The public interface of Folder::getFiles() and
Folder::getSubfolders() is extended, but in a backwards-compatible way,
so this is no breaking change.

Change-Id: Ib45d5f0a99c038841193ed568d7ebf8289f629d3
Resolves: #41725
Releases: 6.0
Reviewed-on: http://review.typo3.org/15405
Reviewed-by: Dominik Mathern
Tested-by: Dominik Mathern
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
6 years ago[BUGFIX] Hidden files/folders are always filtered
Andreas Wolf [Sat, 20 Oct 2012 17:07:41 +0000 (19:07 +0200)]
[BUGFIX] Hidden files/folders are always filtered

The local driver has a hardcoded filter for dot-files, i.e. files whose
name starts with a dot. However, we (or the user) might need these files
in some situations. Therefore, the filter should be added by default,
but should be removable, which is the case if we use the extensible
filter mechanisms provided by FAL. This is done with this commit.

Resolves: #42230
Releases: 6.0
Change-Id: I69ff38d35f75e2a7f4bbb7574caf6a261638512d
Reviewed-on: http://review.typo3.org/15859
Reviewed-by: Dominik Mathern
Tested-by: Dominik Mathern
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
6 years ago[BUGFIX] EM 6.0 parse configuration type 'options' correctly
Jigal van Hemert [Wed, 31 Oct 2012 21:45:33 +0000 (22:45 +0100)]
[BUGFIX] EM 6.0 parse configuration type 'options' correctly

The labels for the options are in the options= part, not in the
label= part. Parsing the options correctly renders the select
box as intended.

Change-Id: I5a3c9e888f248a91c1c79f7a69f82a6a87880a3e
Fixes: #42252
Releases: 6.0
Reviewed-on: http://review.typo3.org/16090
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
6 years ago[TASK] Create uploads folder on travis
Helmut Hummel [Thu, 1 Nov 2012 08:21:20 +0000 (09:21 +0100)]
[TASK] Create uploads folder on travis

Upload folder is missing, leading to test failures
after activation of warning to error conversion.
Create the folder during setup.

Additionally fix a warning in the FAL tests.

Releases: 6.0

Change-Id: I8762a7f2db07edf84294dccb0d9570434040534a
Reviewed-on: http://review.typo3.org/16096
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Info link in file context menu broken
Andreas Wolf [Thu, 4 Oct 2012 08:16:04 +0000 (10:16 +0200)]
[BUGFIX] Info link in file context menu broken

The link for file info in the context menu of the file list module does
not work, as it missed the special identifier '_FILE'.

Change-Id: Ie9990e3800b0d4e8b49c2594b4ad96d9ffe9839b
Resolves: #41396
Releases: 6.0
Reviewed-on: http://review.typo3.org/15295
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
6 years ago[TASK] Prevent multiple processing ContentAdapter
Steffen Ritter [Sun, 21 Oct 2012 13:13:52 +0000 (15:13 +0200)]
[TASK] Prevent multiple processing ContentAdapter

The FrontendContentAdapter is triggered everytime a record
is passed to an ContentObject instance. Therefore it may
happen, that the same record is processed by the
FrontendContentAdapter multiple times.

Prevent multiple processing by setting a flag for finished
processing.

Change-Id: Ia9d5ea6db684097c33008f8ec6273abd2a6deb8d
Releases: 6.0
Resolves: #42244
Reviewed-on: http://review.typo3.org/15861
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
6 years ago[BUGFIX] Rootline must not include references to deleted records
Steffen Ritter [Mon, 3 Sep 2012 09:42:04 +0000 (11:42 +0200)]
[BUGFIX] Rootline must not include references to deleted records

The rootline resolval includes deleted records. Deleted
records should never be used in frontend. Add the missing
deleteClause to the request.

Change-Id: I2039d3343479ca080c747b1c39961d03efb34e0f
Fixes: #39960
Releases: 6.0
Reviewed-on: http://review.typo3.org/14302
Reviewed-by: Mario Rimann
Tested-by: Marcel Burkhalter
Reviewed-by: Georg Ringer
Reviewed-by: Stefan Neufeind
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
6 years ago[BUGFIX] ContentAdapter for FAL not capable of translations
Steffen Ritter [Sun, 21 Oct 2012 12:26:21 +0000 (14:26 +0200)]
[BUGFIX] ContentAdapter for FAL not capable of translations

The ContentAdapter, which rewrites FAL references to old
style database formats, is not capable of dealing with
relations - images and files so to speak - to translated
tt_content record.

IRRE Records always are related to the UID of the actual
translated record - not to the uid of tt_content record.

As in TSFE and/or CSS Styled Content Rendering the UID of
translated records is stored within the property
_LOCALIZED_UID this is what the ContentAdapater has to
hand over.

Change-Id: I5887511bcf1dd8fb481e45762e302e0908791bdd
Fixes: #40609
Releases: 6.0
Reviewed-on: http://review.typo3.org/14337
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
6 years ago[TASK] Remove unused icons typo3/gfx/fanner
Georg Ringer [Wed, 31 Oct 2012 05:00:21 +0000 (06:00 +0100)]
[TASK] Remove unused icons typo3/gfx/fanner

Change-Id: Ic67444d324b895bb1ec4204012ce3ada5534edf8
Resolves: #42536
Releases: 6.0
Reviewed-on: http://review.typo3.org/16056
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Cleanup indexed_search
Georg Ringer [Tue, 30 Oct 2012 11:55:30 +0000 (12:55 +0100)]
[TASK] Cleanup indexed_search

The ext can be cleaned up a bit:
* Remove not needed/old files
* Remove namespace compatibility for example files

Change-Id: I50ae60217c186f069908963aa2670d23c1fbe41e
Resolves: #42513
Releases: 6.0
Reviewed-on: http://review.typo3.org/16038
Reviewed-by: Wouter Wolters
Reviewed-by: Mattias Nilsson
Reviewed-by: Philipp Gampe
Reviewed-by: Felix Kopp
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] class_alias in the bootstrap for legacy base classes
Helmut Hummel [Thu, 20 Sep 2012 16:10:48 +0000 (18:10 +0200)]
[BUGFIX] class_alias in the bootstrap for legacy base classes

The legacy base classes t3lib_div and t3lib_extMgm used
to be available early in the bootstrap.

To enable the usage of the old class names a class alias
needs to be set up right after these classes are included.

Change-Id: I3cfa69d9bbca378015ee5ea3c13a6fac032fe9cc
Fixes: #42574
Resolves: #41122
Releases: 6.0
Reviewed-on: http://review.typo3.org/14776
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Incomplete mocking in FAL IndexerServiceTest
Christian Kuhn [Wed, 31 Oct 2012 22:19:45 +0000 (23:19 +0100)]
[BUGFIX] Incomplete mocking in FAL IndexerServiceTest

Incomplete mocking of FileRepository leads to warnings
in unit tests.

Resolves: #42575
Releases: 6.0

Change-Id: Ib0dc85de2575d38b87e482f0ad113aad27d46014
Reviewed-on: http://review.typo3.org/16092
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Raise submodule pointer of extbase and fluid
Christian Kuhn [Wed, 31 Oct 2012 21:04:00 +0000 (22:04 +0100)]
[TASK] Raise submodule pointer of extbase and fluid

Change-Id: Ia3d3a43a80fdade11bd947beb3678068b32998c6
Reviewed-on: http://review.typo3.org/16089
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Replace generic ObjectStorage in the whole core
Alexander Schnitzler [Wed, 31 Oct 2012 11:37:07 +0000 (12:37 +0100)]
[BUGFIX] Replace generic ObjectStorage in the whole core

Releases: 6.0
Fixes: #42553

Change-Id: Ie2cfa7f3d736391385511dd87c576d5b8124baf1
Reviewed-on: http://review.typo3.org/16075
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Change ObjectStorage namespace in legacyClassesForIde
Alexander Schnitzler [Wed, 31 Oct 2012 11:17:12 +0000 (12:17 +0100)]
[BUGFIX] Change ObjectStorage namespace in legacyClassesForIde

Releases: 6.0
Fixes: #42552

Change-Id: I46d6fa253711dbb5ad822bc4c294e3299d504efe
Reviewed-on: http://review.typo3.org/16074
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] RTE: Link class not always set in Firefox
Stanislas Rolland [Mon, 15 Oct 2012 22:52:51 +0000 (18:52 -0400)]
[BUGFIX] RTE: Link class not always set in Firefox

Problem: The range of the selection may be modified by the execCommand in
Firefox, at least since version 14.
Solution: Re-establish the range.

Change-Id: Ied6ff3570be99bac993163cc94b801a3872aa6a9
Resolves: #39662
Releases: 4.5, 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/15666
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
6 years ago[TASK] Remove classname from insert fields in scheduler
Helmut Hummel [Wed, 31 Oct 2012 15:52:17 +0000 (16:52 +0100)]
[TASK] Remove classname from insert fields in scheduler

The classname field has been removed from the scheduler
but has been forgotten to be removed when inserting a task

Remove that last occurrence, too.

Releases: 6.0

Change-Id: I54823d80b9a9a0f0cffdab3d76690b00b5522b19
Reviewed-on: http://review.typo3.org/16082
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Restore display of mount points path
Francois Suter [Tue, 16 Oct 2012 12:42:41 +0000 (14:42 +0200)]
[BUGFIX] Restore display of mount points path

The introduction of the virtual tree root in TYPO3 4.7 made it so
that the option to display the path to each mount point in the page
tree is never used anymore. This patch restores full usage of this
option.

Change-Id: I2b6cd2ac3c055ee3433339bf21d846ec5344227e
Resolves: #42046
Releases: 6.0, 4.7
Reviewed-on: http://review.typo3.org/15718
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[TASK] openid: Update php-openid to 2.2.2
Stefan Neufeind [Sat, 20 Oct 2012 22:42:19 +0000 (00:42 +0200)]
[TASK] openid: Update php-openid to 2.2.2

Update to current version.
Github-version contains several small
fixes / cleanups, so a current
checkout was used here.

Change-Id: Ia7006af0ebf651f7a76395e8a684c81c2b37b888
Resolves: #42236
Releases: 6.0
Reviewed-on: http://review.typo3.org/15847
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
6 years ago[TASK] Remove index_re.php
Georg Ringer [Tue, 30 Oct 2012 09:35:24 +0000 (10:35 +0100)]
[TASK] Remove index_re.php

The "apache-trailing-slash workaround" is not needed and can be
removed

Change-Id: Ic67cd24eb6ea6de2e78a871ec4b7831b8487be8b
Resolves: #42503
Releases: 6.0
Reviewed-on: http://review.typo3.org/16032
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Remove option "noEdit" from Install Tool
Georg Ringer [Tue, 30 Oct 2012 07:49:39 +0000 (08:49 +0100)]
[TASK] Remove option "noEdit" from Install Tool

As the new Extension Manager got not possibility
to edit files of extensions, this setting is not used anymore
and can be removed

Change-Id: I38470a79310a633828c8f163cac88a022f1cd4e3
Resolves: #41813
Releases: 6.0
Reviewed-on: http://review.typo3.org/16027
Reviewed-by: Mattias Nilsson
Reviewed-by: Daniel Lorenz
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[BUGFIX] Restricted elements should show edit options
Georg Ringer [Mon, 29 Oct 2012 22:17:34 +0000 (23:17 +0100)]
[BUGFIX] Restricted elements should show edit options

If a content element is not allowed to be edited, e.g.
because the ctype is not allowed to the current backend user,
the edit options should not be shown. Also the content
element should not be linked - the form is not displayed
anyway but an ugly error is shown.

Change-Id: I94beefdf6fc6a910201ab8fba4dbda0c5d174359
Fixes: #42501
Releases: 6.0
Reviewed-on: http://review.typo3.org/16023
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Improve Switch-User concept in ext:beuser
Georg Ringer [Mon, 29 Oct 2012 22:41:32 +0000 (23:41 +0100)]
[TASK] Improve Switch-User concept in ext:beuser

The "Switch-User" functionality can be improved:
* It should be possible to switch to other admin user,
  just not the current user
* The title of the link is reintroduced
* The order is as in previous TYPO3 version,
  switch-back-mode is the 2nd one

Resolves: #42502
Releases: 6.0

Change-Id: I7d2a32d5682731798a0671715b2bbfac9a6eee77
Reviewed-on: http://review.typo3.org/16024
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Fix handling of additionalHeaderData in USER_INT
Helmut Hummel [Mon, 29 Oct 2012 16:05:03 +0000 (17:05 +0100)]
[BUGFIX] Fix handling of additionalHeaderData in USER_INT

While introducing USER_INT handling for the pageRenderer
a bug has been introduced which breaks traditional usage of
additionalHeaderData and additionalFooterData.

This is the case because the replacement of the headerData is done
first, when the to be replaced strings are not present
in the HTML content.
They are stored in the pageRenderer context.

Because of that, we need to replace the pageRenderer marker first
and after that the marker for additionalHeaderData
and additionalFooterData

Fixes: #42490
Releases: 6.0

Change-Id: I91ef658b5b5c8ca5c6cf7e25752e59a33152c2ac
Reviewed-on: http://review.typo3.org/16013
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Fix translation overlay in RECORDS
Helmut Hummel [Mon, 22 Oct 2012 15:36:28 +0000 (17:36 +0200)]
[BUGFIX] Fix translation overlay in RECORDS

When RECORDS content object is used with pages as table
no translation overlay is done.

Fix that by adding a check and selecting the proper
overlay method in this case.

Resolves: #42279
Releases: 4.5, 4.6, 4.7, 6.0

Change-Id: I9be903c06abe8532390f814e2ff29825003359d7
Reviewed-on: http://review.typo3.org/15885
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Markus Klein
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Add information about ThreadStackSize to install tool
Nicole Cordes [Sat, 20 Oct 2012 23:09:55 +0000 (01:09 +0200)]
[TASK] Add information about ThreadStackSize to install tool

There is an information about the ThreadStackSize on Windows systems in
the Install.txt.

This information should be displayed in the Basic Configuration of the
Install Tool as well.

Change-Id: Iedbabccea903ab108220fbaf25492478b7e3ea1e
Resolves: #42237
Releases: 6.0
Reviewed-on: http://review.typo3.org/15848
Reviewed-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
6 years ago[BUGFIX] Fix usage of fileadminDir
Helmut Hummel [Sun, 28 Oct 2012 13:00:47 +0000 (14:00 +0100)]
[BUGFIX] Fix usage of fileadminDir

#41120 introduced a regression, as
$GLOBALS['TYPO3_CONF_VARS']['BE']['fileadminDir']
has a trailing backslash.

Fix that by removing the trailing slash and quoting
the value of the global for the case it contains
further path segments.

Fixes: #42454
Relates: #41120
Releases: 6.0, 4.7

Change-Id: I17455374ab2b9824bee9ceeaccbee7ea959b4841
Reviewed-on: http://review.typo3.org/15987
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] CGL violations "AssignmentArithmeticAndComparisonSpace"
Roland Waldner [Mon, 1 Oct 2012 17:17:02 +0000 (19:17 +0200)]
[TASK] CGL violations "AssignmentArithmeticAndComparisonSpace"

Change-Id: I9970ef5e2087233db095a1d296261c6eb06def18
Resolves: #41498
Releases: 6.0
Reviewed-on: http://review.typo3.org/15198
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Raise submodule pointer
Christian Kuhn [Sun, 28 Oct 2012 18:30:22 +0000 (19:30 +0100)]
[TASK] Raise submodule pointer

Change-Id: I04f259646198c809cfe358e9a1ccc8816482c288
Reviewed-on: http://review.typo3.org/15994
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Fix @param in phpdoc
Stefan Neufeind [Tue, 23 Oct 2012 14:57:25 +0000 (16:57 +0200)]
[BUGFIX] Fix @param in phpdoc

Some @param-tags are wrong or don't match
the number of params for the function they
refer to.

Change-Id: I80641f7ef714e9416243336c5a0723b6ca66f80d
Fixes: #42233
Releases: 6.0
Reviewed-on: http://review.typo3.org/15842
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Update jQuery to 1.8.2
Stefan Neufeind [Fri, 19 Oct 2012 22:08:40 +0000 (00:08 +0200)]
[TASK] Update jQuery to 1.8.2

Change-Id: I875f220cd3fee481077f5f2fa2296a611943a70c
Resolves: #42196
Releases: 6.0
Reviewed-on: http://review.typo3.org/15827
Reviewed-by: Mattias Nilsson
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Remove needless check function in language module
Kai Vogel [Wed, 10 Oct 2012 09:27:57 +0000 (11:27 +0200)]
[TASK] Remove needless check function in language module

This patch removes the check function and related to that, the use of
the caching framework.

Resolves: #41824
Related: #39963
Releases: 6.0

Change-Id: I3d3de72c287a9b1167f0d1ea563f16994fd0ffe3
Reviewed-on: http://review.typo3.org/15475
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Cleanup GeneralUtilityTest
Wouter Wolters [Sun, 28 Oct 2012 16:18:47 +0000 (17:18 +0100)]
[TASK] Cleanup GeneralUtilityTest

Change \TYPO3\CMS\Core\Utility\GeneralUtility to Utility\GeneralUtility

Change-Id: I4ebe25378873a6b11f906b872db92bffbad9f73f
Resolves: #42456
Releases: 6.0
Reviewed-on: http://review.typo3.org/15992
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Extension manager fixed DocHeader
Felix Kopp [Sun, 28 Oct 2012 16:06:13 +0000 (17:06 +0100)]
[TASK] Extension manager fixed DocHeader

Fixes the docheader rows in their top position by using the
standard css id "typo3-inner-docbody".

Also includes the new 6.0 docheader html tags.

Change-Id: Ifce74f41d1f882a5cb7095bc3546a0685935b688
Resolves: #42455
Releases: 6.0
Reviewed-on: http://review.typo3.org/15991
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Allow overwrite when uploading an existing extension
Kai Vogel [Wed, 3 Oct 2012 13:37:23 +0000 (15:37 +0200)]
[BUGFIX] Allow overwrite when uploading an existing extension

This patch adds a checkbox to the upload form, which makes it possible
to overwrite the existing directory when uploading an extension
which is already available in the system.

Resolves: #41006
Releases: 6.0

Change-Id: Ib51a10a0e557060f0260e97ff8a9129f1c9f7eba
Reviewed-on: http://review.typo3.org/15257
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Compare in install tool crashes
Mattias Nilsson [Wed, 24 Oct 2012 11:55:00 +0000 (13:55 +0200)]
[BUGFIX] Compare in install tool crashes

Change-Id: I70ed54656bfa20598fbfd6f6cf8ecfa9844af3ce
Resolves: #42346
Releases: 6.0
Reviewed-on: http://review.typo3.org/15923
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] GGL violation "Tabs must be used to indent lines"
Roland Waldner [Sun, 30 Sep 2012 11:48:03 +0000 (13:48 +0200)]
[TASK] GGL violation "Tabs must be used to indent lines"

Change-Id: Icdf2b997282ff6934ae0fe5563f9a797fcc4b863
Resolves: #41472
Releases: 6.0
Reviewed-on: http://review.typo3.org/15167
Reviewed-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Tested-by: Philipp Gampe
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Remove: Open Documents module
Felix Kopp [Wed, 26 Sep 2012 22:23:09 +0000 (00:23 +0200)]
[TASK] Remove: Open Documents module

Removes the Module Menu item for OpenDocs on the left.
Also moves Css/JavaScript/Images and Icons to default folders.

Change-Id: I90c3f04f5981c6b0e02b036c8b604ce03b3d7b66
Fixes: #41240
Releases: 6.0
Reviewed-on: http://review.typo3.org/15107
Reviewed-by: Helmut Hummel
Reviewed-by: Mattias Nilsson
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUG] Add missing logFile setting for FileWriter
Steffen Müller [Sat, 13 Oct 2012 00:19:25 +0000 (02:19 +0200)]
[BUG] Add missing logFile setting for FileWriter

Resolves: #41944
Releases: 6.0

Change-Id: I11bc2feeb463cc66bf19d6613f191e294a8e65c5
Reviewed-on: http://review.typo3.org/15547
Reviewed-by: Steffen Ritter
Reviewed-by: Philipp Gampe
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
6 years ago[BUGFIX] Rename Log Writer and Processor interface
Steffen Müller [Fri, 12 Oct 2012 20:04:31 +0000 (22:04 +0200)]
[BUGFIX] Rename Log Writer and Processor interface

Resolves: #41938
Releases: 6.0

Change-Id: I977d9ab1413078adfa1ea46055d389f2f1eaa6f6
Reviewed-on: http://review.typo3.org/15543
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
6 years ago[TASK] Fix code formatting
Oliver Hader [Fri, 26 Oct 2012 13:41:58 +0000 (15:41 +0200)]
[TASK] Fix code formatting

Change-Id: Ib681cc7ea82d820655a856e0a8e391e3397844ea
Releases: 6.0
Reviewed-on: http://review.typo3.org/15957
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[BUGFIX] PHP warning: open_basedir restriction
Xavier Perseguers [Tue, 16 Oct 2012 15:32:06 +0000 (17:32 +0200)]
[BUGFIX] PHP warning: open_basedir restriction

Change-Id: Ie1dfe4306cad8bdc23864f31a77dac980eac3494
Fixes: #42054
Relates: #35212
Releases: 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/15741
Reviewed-by: Mattias Nilsson
Reviewed-by: Stefan Neufeind
Reviewed-by: Michael Stucki
Tested-by: Michael Stucki
6 years ago[TASK] Fix inline comment style for ext_emconf.php files
Roland Waldner [Thu, 25 Oct 2012 18:31:58 +0000 (20:31 +0200)]
[TASK] Fix inline comment style for ext_emconf.php files

Change-Id: I6b1e1b1fb346f43118382c6c39bec3088feb2c2c
Resolves: #42399
Releases: 6.0
Reviewed-on: http://review.typo3.org/15940
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Refactor EM JavaScript
Hans Christian Reinl [Tue, 23 Oct 2012 18:40:18 +0000 (20:40 +0200)]
[TASK] Refactor EM JavaScript

* Use IIFE for faster access to jQuery and save $ use
* Make JS lint-free

Resolves: #42325
Releases: 6.0

Change-Id: Ia014de44570306ce9c5cd02c97a228205a7a2849
Reviewed-on: http://review.typo3.org/15915
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] EM 6.0 add clear search icon
Jigal van Hemert [Mon, 22 Oct 2012 21:47:03 +0000 (23:47 +0200)]
[BUGFIX] EM 6.0 add clear search icon

Add clear search button to the jQuery dataTables search box

Change-Id: I83b57e0db29f7a948461ffdeab6375dfd16a4ad3
Fixes: #42286
Releases: 6.0
Reviewed-on: http://review.typo3.org/15897
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Support logger names with namespaces
Steffen Müller [Fri, 12 Oct 2012 23:08:26 +0000 (01:08 +0200)]
[TASK] Support logger names with namespaces

Resolves: #41943
Releases: 6.0

Change-Id: Ie9ee6fd200a330d7c78285afc380d1d59d4ec03a
Reviewed-on: http://review.typo3.org/15545
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Philipp Gampe
Reviewed-by: Ingo Renner
Tested-by: Ingo Renner
6 years ago[BUGFIX] Resolve dependencies for local extensions
Helmut Hummel [Mon, 22 Oct 2012 09:01:41 +0000 (11:01 +0200)]
[BUGFIX] Resolve dependencies for local extensions

Add the dependency resolving when installing local
extensions with the extension manager.

Cleanup the download controller arguments on the go.

Fixes: #41273
Releases: 6.0

Change-Id: I10876f09bf4bed7b33d803a80a3d89fb583d4c7e
Reviewed-on: http://review.typo3.org/15873
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Remove singleton for EXT:form Localization
Christian Kuhn [Mon, 22 Oct 2012 15:38:07 +0000 (17:38 +0200)]
[BUGFIX] Remove singleton for EXT:form Localization

\TYPO3\CMS\Form\Localization is a singleton class with constructor
parameters. This is an antipattern and broken by design. As an effect
it leads to warnings in unit tests and makes the class unusable
with multiple files.

The patch removes the implementation of the singletonInterface, but
sets the default localization file as default parameter to keep
backwards compatibility.

Change-Id: I3ed5c77c5c3a653c8d5e7259baa64a41c8c20859
Resolves: #42280
Releases: 6.0
Reviewed-on: http://review.typo3.org/15886
Reviewed-by: Steffen Ritter
Reviewed-by: Wouter Wolters
Reviewed-by: Nicole Cordes
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] t3lib_div::unlink_tempfile does not always work on Windows
Stanislas Rolland [Mon, 15 Oct 2012 20:41:39 +0000 (16:41 -0400)]
[BUGFIX] t3lib_div::unlink_tempfile does not always work on Windows

Problem: The filename created by t3lib_div::tempnam may contain
backslashes.

Solution: Process the file name through t3lib_div::fixWindowsFilePath

Change-Id: I47f8fe39ffb29894d78ac28141b88ea7abf6fd2c
Releases: 4.5, 4.6, 4.7, 6.0
Resolves: #38699
Reviewed-on: http://review.typo3.org/12684
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] New form wizard not loading in IE8
Sebastian Schawohl [Tue, 31 Jan 2012 10:02:20 +0000 (11:02 +0100)]
[BUGFIX] New form wizard not loading in IE8

Internet Explorer 8 raises an error on JavaScript objects with reserved
words as property names. In the new form wizard an object was created
with class as property name which is a reserved word. Surrounding with
quotes fixes the bug.

Change-Id: Id9ceef79e8503886cdaebbf14ddb4e92c4b7dcea
Fixes: #33504
Releases: 6.0, 4.7, 4.6
Reviewed-on: http://review.typo3.org/8776
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Mario Rimann
Tested-by: Mario Rimann
Reviewed-by: Stefan Neufeind
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] EM 6.0 doesn't store extension state from TER
Jigal van Hemert [Mon, 22 Oct 2012 11:03:03 +0000 (13:03 +0200)]
[BUGFIX] EM 6.0 doesn't store extension state from TER

The extension state is stored as text in the TER dump, but stored as
an integer in the database. The correct conversion must be done to
be able to show the states from extensions in TER.

Change-Id: I9fc05a61df1df71696c690874507f7bbc51e9aab
Fixes: #42260
Releases: 6.0
Reviewed-on: http://review.typo3.org/15877
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
6 years ago[BUGFIX] Fix dependency handling of EM
Helmut Hummel [Sun, 21 Oct 2012 12:28:55 +0000 (14:28 +0200)]
[BUGFIX] Fix dependency handling of EM

Through calculation of dependencies the dependency
utility swapped lowest and highest constraint.

Fix that and also make the dialogue work again
when installing an extension with dependencies.

Fixes: #42245
Releases: 6.0

Change-Id: I1701b966bbb0c9768992e5e8a9a6a88ae4917ce6
Reviewed-on: http://review.typo3.org/15862
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] getFolders() does not return correct keys
Andreas Wolf [Fri, 12 Oct 2012 20:34:57 +0000 (22:34 +0200)]
[BUGFIX] getFolders() does not return correct keys

Resolves: #41941
Releases: 6.0
Change-Id: Ia500d4892532a7e5ec7a997f4b3b0c521d22a654
Reviewed-on: http://review.typo3.org/15858
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
6 years ago[BUGFIX] Folder: getSubfolders() has no range parameters
Andreas Wolf [Fri, 12 Oct 2012 20:31:35 +0000 (22:31 +0200)]
[BUGFIX] Folder: getSubfolders() has no range parameters

Resolves: #41940
Releases: 6.0
Change-Id: Ie45de7e048950cae42672439f72639813ce423ff
Reviewed-on: http://review.typo3.org/15857
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
6 years ago[BUGFIX] Storage uses wrong identifier for processing folder
Andreas Wolf [Thu, 18 Oct 2012 18:37:24 +0000 (20:37 +0200)]
[BUGFIX] Storage uses wrong identifier for processing folder

All absolute identifiers within a storage have to begin with a "/". The
Storage does not respect this for the processing folder, leading to
wrong identifiers being generated for images inside this folder.

To account for this change, the sys_file_processedfile table should be
cleared. All identifiers will be regenerated then.

Change-Id: I19293ea766f54830264555f63094471f73a61b28
Resolves: #42180
Releases: 6.0
Reviewed-on: http://review.typo3.org/15836
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
6 years ago[TASK] CleanUp FileRepository
Steffen Ritter [Sun, 21 Oct 2012 12:58:56 +0000 (14:58 +0200)]
[TASK] CleanUp FileRepository

Just some CGL, DocComment and variable name
cleanup within the FileRepository

Change-Id: If5cf743f1a3e5ac1e2dc5c7f592df642cca9211a
Resolves: #42243
Releases: 6.0
Reviewed-on: http://review.typo3.org/15860
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
6 years ago[BUGFIX] FAL: Misleading default filter array name
Andreas Wolf [Sat, 20 Oct 2012 20:18:52 +0000 (22:18 +0200)]
[BUGFIX] FAL: Misleading default filter array name

The key for the default filters array in the default configuration of
TYPO3 is callbackFilterMethods. This is misleading, as one might see
this as a list of *all* available filters. Therefore, the key is renamed
to defaultFilterCallbacks.

The name change does not break any public API as the array key is only
used in one place: the ResourceStorage.

Resolves: #42239
Releases: 6.0
Change-Id: I48282f8e49ab786aaf8821badfb411a653e9a3fc
Reviewed-on: http://review.typo3.org/15856
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
6 years ago[TASK] Add information about ThreadStackSize to report status
Nicole Cordes [Sat, 20 Oct 2012 21:54:20 +0000 (23:54 +0200)]
[TASK] Add information about ThreadStackSize to report status

There is an information about the ThreadStackSize on Windows systems in
the Install.txt

This information should be displayed in report status as well

Change-Id: I70512b15ec672aa16dee8223a48ea5d51f3a8964
Resolves: #42235
Releases: 6.0
Reviewed-on: http://review.typo3.org/15845
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
6 years ago[BUGFIX] Create upload folder on extension install
Helmut Hummel [Sat, 20 Oct 2012 13:44:09 +0000 (15:44 +0200)]
[BUGFIX] Create upload folder on extension install

Implement the creation of configured upload folder
and "createDirs".

Releases: 6.0
Resolves: #42145

Change-Id: I4951d6daa6c3c8981f03b3d77a56e5f48913a5a5
Reviewed-on: http://review.typo3.org/15838
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] EM: uploading extension form must go to iframe
Jigal van Hemert [Sat, 20 Oct 2012 17:44:15 +0000 (19:44 +0200)]
[BUGFIX] EM: uploading extension form must go to iframe

In some browsers the upload form did not go to the iframe for further
processing by JavaScript. Adding a name to the iframe solves the
problem.

Change-Id: If9f6afcf4a80ac178c6c473cc8542ddb4bf7317c
Fixes: #42156
Releases: 6.0
Reviewed-on: http://review.typo3.org/15840
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
6 years ago[TASK] Install tool should inform about suhosin.get.max_value_length
Roland Waldner [Fri, 19 Oct 2012 11:29:03 +0000 (13:29 +0200)]
[TASK] Install tool should inform about suhosin.get.max_value_length

Change-Id: Ifbf4d901a496ce065c453073bc15cb7f3590fa61
Resolves: #42170
Releases: 6.0
Reviewed-on: http://review.typo3.org/15813
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Steffen Müller
Tested-by: Steffen Müller
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[TASK] Remove excludefields at sys_file_reference table
Steffen Ritter [Sat, 20 Oct 2012 12:27:34 +0000 (14:27 +0200)]
[TASK] Remove excludefields at sys_file_reference table

The TCA for sys_file_reference table configures fields like
hidden, sys_language_uid and alike as "exclude => 1".

This causes the translation of tt_content elements with
images to fail for an regular editor if these fields are
not configured to be allowed explicitly.

These fields are always hidden in TCEforms, but always
required for IRRE and translation to work.
Therefore remove the exclude-field configuration.

Change-Id: I1783b7406b62c1142acb991308e3698cf5af68f1
Resolves: #42224
Releases: 6.0
Reviewed-on: http://review.typo3.org/15835
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[TASK] Cleanup EM Code
Helmut Hummel [Fri, 19 Oct 2012 16:32:00 +0000 (18:32 +0200)]
[TASK] Cleanup EM Code

* Use controller arguments for actions
* Simplify contollers

Releases: 6.0
Resolves: #42163

Change-Id: I211d58e0dbbed083bb7a643a89da764bb4a186a3
Reviewed-on: http://review.typo3.org/15823
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Hide unsafe extensions in EM TER list
Jigal van Hemert [Fri, 19 Oct 2012 20:44:32 +0000 (22:44 +0200)]
[BUGFIX] Hide unsafe extensions in EM TER list

When showing extensions from TER unsafe extensions must not be shown
in the list or search results.

Change-Id: I229e3fc2b00a25c4e1cbcdc1ec2ac1596692630a
Fixes: #42153
Releases: 6.0
Reviewed-on: http://review.typo3.org/15824
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Cleanup EM Code
Helmut Hummel [Thu, 18 Oct 2012 16:01:44 +0000 (18:01 +0200)]
[TASK] Cleanup EM Code

* Use controller arguments for actions
* Add escaping in viewhelpers
* Remove compatibility files
* Fix some annotations
* Enable test after ConfigurationManager change
* Fix new property mapper configuration

Releases: 6.0
Resolves: #42163

Change-Id: Ida9010e2eb00013c3a3e855983b58bb7df38c30d
Reviewed-on: http://review.typo3.org/15803
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Clean-up EXT: aboutmodules, adapt to "TYPO3 CMS"
Felix Kopp [Sun, 14 Oct 2012 14:31:37 +0000 (16:31 +0200)]
[TASK] Clean-up EXT: aboutmodules, adapt to "TYPO3 CMS"

Cleans up the About Modules CSS file (mainly paddings) and terminology
to distinct between "TYPO3" (Association) and "TYPO3 CMS" product
within copyright notices.

Standardize CSS ids to use the extension key (aboutmodules).
Also adds links to the module descriptions to jump to module.
Brings one further logo image to comply with new brand definition.

Only applies to the extbase version of AboutModules.

Resolves: #41980
Releases: 6.0, 4.7
Change-Id: Iba088c5d644dfc048ea9c65e72711d501b51ae59
Reviewed-on: http://review.typo3.org/15610
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Follow-Up to #41828 - Incomplete mocking in tests
Christian Kuhn [Fri, 19 Oct 2012 12:09:56 +0000 (14:09 +0200)]
[BUGFIX] Follow-Up to #41828 - Incomplete mocking in tests

Better mocking in test class to ensure isUsageEnabled() returns TRUE
in all environments and especially in travis.

Change-Id: Icb68b1c863c13db0fb1e48390db130f43b9e0622
Related: #41828
Releases: 6.0
Reviewed-on: http://review.typo3.org/15815
Reviewed-by: Steffen Ritter
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Follow-Up to #41828 - Move test files
Christian Kuhn [Fri, 19 Oct 2012 10:41:09 +0000 (12:41 +0200)]
[BUGFIX] Follow-Up to #41828 - Move test files

Test files for #41828 should be in Tests/ instead of tests/

Change-Id: I26188b0addae691a2d5c4c8289885303db556d82
Related: #41828
Releases: 6.0
Reviewed-on: http://review.typo3.org/15810
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Download as zip must use same filename structure as TER
Jigal van Hemert [Thu, 18 Oct 2012 21:11:18 +0000 (23:11 +0200)]
[BUGFIX] Download as zip must use same filename structure as TER

Upload in EM assumes <extkey>_<version>.zip, so the download as zip
feature must use the same format.

Change-Id: Ide7eb7aac3c8f213b7db2bc9dad5e014e8faa666
Fixes: #42067
Release: 6.0
Reviewed-on: http://review.typo3.org/15801
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] RTE: Link to disabled page doesn't show in FE, link icon does
Stanislas Rolland [Tue, 16 Oct 2012 14:45:24 +0000 (10:45 -0400)]
[BUGFIX] RTE: Link to disabled page doesn't show in FE, link icon does

Problem: When linking from a piece of content in the RTE to a disabled
page in the tree, the link isn't shown in the final frontend rendering.
However, the small arrow icon that you can have in front of the link to
denote its type, does get shown.
Solution: Remove the icon if no link is generated

Change-Id: If2f5af7ef81578571ed0a1255a53d9373f14bfed
Resolves: #36087
Releases: 4.5, 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/15802
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
6 years ago[BUGFIX] Respect newlines in method declarations
Helmut Hummel [Thu, 18 Oct 2012 13:28:53 +0000 (15:28 +0200)]
[BUGFIX] Respect newlines in method declarations

The compatibility class loader currently fails
to match method declarations that go over multiple
lines.

Add the /s modifier to the pattern and adjust the testcases.

Releases: 6.0
Resolves: #42134

Change-Id: I2671944a80608b9ac585f6b5c586ceb571b82ecb
Reviewed-on: http://review.typo3.org/15800
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] RTE: Words containing umlauts not added to personal dictionary
Stanislas Rolland [Thu, 18 Oct 2012 15:05:13 +0000 (11:05 -0400)]
[BUGFIX] RTE: Words containing umlauts not added to personal dictionary

Problem: The spell checker must analyze the dictionary file and may
have to update the charset of the personal dictionary. In doing so,
it is looking for the wrong file when the dictionary in use is a
regional/variety dictionary.

Change-Id: Ia2b57c0ead7c90a6d40e9db4d396e6c7ded72e5c
Resolves: #29685
Releases: 4.5, 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/15790
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland