Packages/TYPO3.CMS.git
7 years ago[TASK] Clean up the phpDoc of t3lib/l10n/
Wouter Wolters [Wed, 30 May 2012 16:46:28 +0000 (18:46 +0200)]
[TASK] Clean up the phpDoc of t3lib/l10n/

Clean up the phpDoc of t3lib/l10n/

So I made a patch doing mostly:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)
* CGLify method signatures (the first line of the method)

Change-Id: I2bbdeab574f7c2a4e8595e2dc872a4dff182228c
Resolves: #37616
Releases: 6.0
Reviewed-on: http://review.typo3.org/11743
Reviewed-by: Oliver Klee
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[TASK] CGL violations FunctionCallArgumentSpacing in /typo3/sysext/p*/
Roland Waldner [Tue, 29 May 2012 20:25:55 +0000 (22:25 +0200)]
[TASK] CGL violations FunctionCallArgumentSpacing in /typo3/sysext/p*/

There were violations against the CGL rule
"FunctionCallArgumentSpacingNoSpaceAfterComma" in /typo3/sysext/p*/.
These will be reduced by this commit.

Change-Id: I3ecede3999f3b999bd2b97db747dc9f3354823c5
Resolves: #37587
Releases: 6.0
Reviewed-on: http://review.typo3.org/11703
Reviewed-by: Oliver Klee
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[TASK] Fix CGL violations InlineCommentWrongStyle in ext_emconf.php files
Roland Waldner [Fri, 1 Jun 2012 13:22:33 +0000 (15:22 +0200)]
[TASK] Fix CGL violations InlineCommentWrongStyle in ext_emconf.php files

There are violations against the CGL rule "InlineCommentWrongStyle " in
ext_emconf.php files.

These will be fixed.

Change-Id: Ic8a83bf8a12246328a4c8fe48ef27fb99c2f3396
Resolves: #37685
Releases: 6.0
Reviewed-on: http://review.typo3.org/11793
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[TASK] CGL violations DoubleQuoteUsageNotRequired in indexed_search/
Roland Waldner [Fri, 1 Jun 2012 10:58:44 +0000 (12:58 +0200)]
[TASK] CGL violations DoubleQuoteUsageNotRequired in indexed_search/

There are violations against the CGL rule "DoubleQuoteUsageNotRequired" in
/typo3/typo3/sysext/indexed_search/.

These will be reduced.

Change-Id: I61072f26f9faa63065f6e92929d05d354a7f2c44
Resolves: #37675
Releases: 6.0
Reviewed-on: http://review.typo3.org/11788
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[TASK] Reduce CGL violations DoubleQuoteUsageNotRequired in install/
Roland Waldner [Fri, 1 Jun 2012 11:59:16 +0000 (13:59 +0200)]
[TASK] Reduce CGL violations DoubleQuoteUsageNotRequired in install/

There are violations against the CGL rule "DoubleQuoteUsageNotRequired" in
/typo3/sysext/install/.

These will be reduced.

Change-Id: I35dd7d205492719a75a21b2965e7672352087757
Resolves: #37678
Releases: 6.0
Reviewed-on: http://review.typo3.org/11791
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years agoReduce CGL violations FunctionCallArgumentSpacingTooMuchSpaceAfterComma
Roland Waldner [Fri, 1 Jun 2012 12:14:15 +0000 (14:14 +0200)]
Reduce CGL violations FunctionCallArgumentSpacingTooMuchSpaceAfterComma

There are violations against the CGL rule
FunctionCallArgumentSpacingTooMuchSpaceAfterComma.

These should be reduced.

Change-Id: I0c12729c67f0e94813e8d080995741858be24341
Resolves: #37682
Releases: 6.0
Reviewed-on: http://review.typo3.org/11792
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[TASK] CGL violations FunctionCallArgumentSpacing in /typo3/sysext/i*/
Roland Waldner [Sat, 26 May 2012 21:13:31 +0000 (23:13 +0200)]
[TASK] CGL violations FunctionCallArgumentSpacing in /typo3/sysext/i*/

There were violations against the CGL rule
"FunctionCallArgumentSpacingNoSpaceAfterComma" in /typo3/sysext/i*/.
These will be reduced by this commit.

Change-Id: Id945d410bf452d66a7ccfb6b902b3cef64345dd0
Resolves: #37513
Releases: 6.0
Reviewed-on: http://review.typo3.org/11653
Reviewed-by: Oliver Klee
Tested-by: Oliver Klee
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[BUGFIX ] CGL violations FunctionCallArgumentSpacing in /typo3/sysext/cms/
Roland Waldner [Sat, 26 May 2012 11:18:57 +0000 (13:18 +0200)]
[BUGFIX ] CGL violations FunctionCallArgumentSpacing in /typo3/sysext/cms/

There were violations against the CGL rule
"FunctionCallArgumentSpacingNoSpaceAfterComma" in /typo3/sysext/cms/.
These will be reduced by this commit.

Change-Id: I7b2f9f6e4aa3638046658bd59dd2ec51b7243d81
Resolves: #37500
Releases: 6.0
Reviewed-on: http://review.typo3.org/11639
Reviewed-by: Oliver Klee
Tested-by: Oliver Klee
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[TASK] Reduce CGL violations FunctionCallArgumentSpacingSpaceBeforeComma
Roland Waldner [Thu, 31 May 2012 18:02:18 +0000 (20:02 +0200)]
[TASK] Reduce CGL violations FunctionCallArgumentSpacingSpaceBeforeComma

There are violations against the CGL rule
"FunctionCallArgumentSpacingSpaceBeforeComma".

These will be reduced by this commit.

Change-Id: I13cb5f14cedafca33db7f4269526dbb8d4de8acf
Resolves: #37657
Releases: 6.0
Reviewed-on: http://review.typo3.org/11774
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[TASK] Clean up the phpDoc of t3lib/extjs/
Wouter Wolters [Thu, 31 May 2012 16:28:20 +0000 (18:28 +0200)]
[TASK] Clean up the phpDoc of t3lib/extjs/

Clean up the phpDoc of t3lib/extjs/

So I made a patch doing mostly:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)
* CGLify method signatures (the first line of the method)

Change-Id: I1bb9da4538f0f04e179e2eb9cf382c6ea988f63e
Resolves: #37651
Releases: 6.0
Reviewed-on: http://review.typo3.org/11771
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[TASK] Clean up the phpDoc of t3lib/error/
Wouter Wolters [Thu, 31 May 2012 18:44:13 +0000 (20:44 +0200)]
[TASK] Clean up the phpDoc of t3lib/error/

Clean up the phpDoc of t3lib/error/

So I made a patch doing mostly:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)
* CGLify method signatures (the first line of the method)

Change-Id: I64c55158f5dad177718b00e19395ac56904a8764
Resolves: #37658
Releases: 6.0
Reviewed-on: http://review.typo3.org/11775
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[FEATURE] Use FAL file extension filter in TCA
Ingmar Schlecht [Thu, 17 May 2012 10:59:18 +0000 (12:59 +0200)]
[FEATURE] Use FAL file extension filter in TCA

Change-Id: Ib85a55deae6e0d11669da804660630dbd95d9115
Releases: 6.0
Resolves: #37251
Reviewed-on: http://review.typo3.org/11270
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
7 years ago[FEATURE] Limit file extensions in FAL element browser
Ingmar Schlecht [Thu, 17 May 2012 10:47:43 +0000 (12:47 +0200)]
[FEATURE] Limit file extensions in FAL element browser

Change-Id: Ic34befbdf4541a2837701cb75a51d500daada8d5
Releases: 6.0
Resolves: #36816
Reviewed-on: http://review.typo3.org/10895
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
7 years ago[BUGFIX] CGL violations DoubleQuoteUsageContainsVar
Roland Waldner [Fri, 25 May 2012 15:54:56 +0000 (17:54 +0200)]
[BUGFIX] CGL violations DoubleQuoteUsageContainsVar

There are violations against the CGL rule "DoubleQuoteUsageContainsVar".
These will be reduced.

Change-Id: Ibb45e3aec90dbe0299e35dcebda4a62386fbf874
Resolves: #37489
Releases: 6.0
Reviewed-on: http://review.typo3.org/11619
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[TASK] Clean up the phpDoc of t3lib/stddb/
Wouter Wolters [Tue, 29 May 2012 16:41:16 +0000 (18:41 +0200)]
[TASK] Clean up the phpDoc of t3lib/stddb/

Clean up the phpDoc of t3lib/stddb/

So I made a patch doing mostly:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)
* CGLify method signatures (the first line of the method)

Change-Id: I021b2dffe389a29cc657c12ec47408a5b0cefd80
Resolves: #37579
Releases: 6.0
Reviewed-on: http://review.typo3.org/11695
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[TASK] Clean up the phpDoc of t3lib_tceforms
Wouter Wolters [Sun, 20 May 2012 16:41:28 +0000 (18:41 +0200)]
[TASK] Clean up the phpDoc of t3lib_tceforms

Clean up the phpDoc of t3lib_tceforms

So I made a patch doing mostly:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)
* CGLify method signatures (the first line of the method)

Change-Id: Ibf0663db32fcc62cd1ac0805e7be675ff5a241ad
Resolves: #37337
Releases: 6.0
Reviewed-on: http://review.typo3.org/11341
Reviewed-by: Oliver Klee
Tested-by: Oliver Klee
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[TASK] Clean up the phpDoc of t3lib/search/
Wouter Wolters [Tue, 29 May 2012 17:00:50 +0000 (19:00 +0200)]
[TASK] Clean up the phpDoc of t3lib/search/

Clean up the phpDoc of t3lib/search/

So I made a patch doing mostly:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)
* CGLify method signatures (the first line of the method)

Change-Id: I3f45698f2f9a2dc149a946bcb0702d1f0a6564f0
Resolves: #37581
Releases: 6.0
Reviewed-on: http://review.typo3.org/11697
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[TASK] CGL violations FunctionCallArgumentSpacing in /typo3/sysext/o*/
Roland Waldner [Tue, 29 May 2012 20:15:23 +0000 (22:15 +0200)]
[TASK] CGL violations FunctionCallArgumentSpacing in /typo3/sysext/o*/

There were violations against the CGL rule
"FunctionCallArgumentSpacingNoSpaceAfterComma" in /typo3/sysext/o*/.
These will be reduced by this commit.

Change-Id: Id5ec2a021c540cd6906d6b9abfb0ac42f75cfac8
Resolves: #37586
Releases: 6.0
Reviewed-on: http://review.typo3.org/11702
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[TASK] Clean up the phpDoc of t3lib/mail/
Wouter Wolters [Tue, 29 May 2012 21:23:17 +0000 (23:23 +0200)]
[TASK] Clean up the phpDoc of t3lib/mail/

Clean up the phpDoc of t3lib/mail/

So I made a patch doing mostly:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)
* CGLify method signatures (the first line of the method)

Change-Id: Ie2844aa5528f7d351f497506e3c32d89d209ced8
Resolves: #37590
Releases: 6.0
Reviewed-on: http://review.typo3.org/11708
Reviewed-by: Oliver Klee
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[TASK] CGL violations FunctionCallArgumentSpacing in /typo3/sysext/r*/
Roland Waldner [Tue, 29 May 2012 20:59:28 +0000 (22:59 +0200)]
[TASK] CGL violations FunctionCallArgumentSpacing in /typo3/sysext/r*/

There were violations against the CGL rule
"FunctionCallArgumentSpacingNoSpaceAfterComma" in /typo3/syset/r*/.
These will be reduced by this commit.

Change-Id: I27129f0e9ad055420f957077dfb619d05e4ffd60
Resolves: #37588
Releases: 6.0
Reviewed-on: http://review.typo3.org/11706
Reviewed-by: Oliver Klee
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[TASK] Clean up the phpDoc of t3lib/spritemanager/
Wouter Wolters [Tue, 29 May 2012 16:50:53 +0000 (18:50 +0200)]
[TASK] Clean up the phpDoc of t3lib/spritemanager/

Clean up the phpDoc of t3lib/spritemanager/

So I made a patch doing mostly:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)
* CGLify method signatures (the first line of the method)

Change-Id: Ib98dc3badbcdfb2fa36a1edee3d634f354be7781
Resolves: #37580
Releases: 6.0
Reviewed-on: http://review.typo3.org/11696
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[TASK] Clean up phpDoc comments in t3lib classes
Wouter Wolters [Tue, 29 May 2012 20:57:09 +0000 (22:57 +0200)]
[TASK] Clean up phpDoc comments in t3lib classes

Clean up phpDoc comments for the following classes:

* t3lib/matchcondition/class.t3lib_matchcondition_abstract.php
* t3lib/matchcondition/class.t3lib_matchcondition_backend.php
* t3lib/matchcondition/class.t3lib_matchcondition_frontend.php
* t3lib/message/class.t3lib_message_abstractmessage.php
* t3lib/message/class.t3lib_message_abstractstandalonemessage.php
* t3lib/message/class.t3lib_message_errorpagemessage.php

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: Ie6be2ebdada47da17596729f3a29bf29c54c1b38
Resolves: #37589
Releases: 6.0
Reviewed-on: http://review.typo3.org/11705
Reviewed-by: Oliver Klee
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[TASK] Clean up the phpDoc of t3lib/tree/
Wouter Wolters [Mon, 28 May 2012 20:48:10 +0000 (22:48 +0200)]
[TASK] Clean up the phpDoc of t3lib/tree/

Clean up the phpDoc of t3lib/tree/

So I made a patch doing mostly:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)
* CGLify method signatures (the first line of the method)

Change-Id: Ifd99d3af865d28c472c72a88d6d5fce2d36cfb76
Resolves: #37556
Releases: 6.0
Reviewed-on: http://review.typo3.org/11669
Reviewed-by: Oliver Klee
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[TASK] Clean up the phpDoc of t3lib/tceforms/
Wouter Wolters [Mon, 28 May 2012 21:00:33 +0000 (23:00 +0200)]
[TASK] Clean up the phpDoc of t3lib/tceforms/

Clean up the phpDoc of t3lib/tceforms/

So I made a patch doing mostly:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)
* CGLify method signatures (the first line of the method)

Change-Id: I7d2db45a13287b500349e5a5d34a3d74f82a67e9
Resolves: #37557
Releases: 6.0
Reviewed-on: http://review.typo3.org/11670
Reviewed-by: Oliver Klee
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[TASK] Clean up the phpDoc of t3lib/utility/
Wouter Wolters [Mon, 28 May 2012 20:09:32 +0000 (22:09 +0200)]
[TASK] Clean up the phpDoc of t3lib/utility/

Clean up the phpDoc of t3lib/utility/

So I made a patch doing mostly:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)
* CGLify method signatures (the first line of the method)

Change-Id: Iad4a09a537060499c93b055225588f95a7d9701b
Resolves: #37555
Releases: 6.0
Reviewed-on: http://review.typo3.org/11665
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[BUGFIX] Illegal string offset
Jigal van Hemert [Mon, 28 May 2012 19:34:58 +0000 (21:34 +0200)]
[BUGFIX] Illegal string offset

Check if parameter is an array before using it as an array in
getPagePath() and getPageInfo()

Change-Id: I9010dfb4411660b2aefa60f7a9e2415355887605
Fixes: #37553
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/11664
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[BUGFIX ] CGL violations FunctionCallArgumentSpacing in /typo3/
Roland Waldner [Fri, 25 May 2012 18:31:37 +0000 (20:31 +0200)]
[BUGFIX ] CGL violations FunctionCallArgumentSpacing in /typo3/

There are some violations against the CGL rule
"FunctionCallArgumentSpacingNoSpaceAfterComma" in /typo3/. These will be
reduced by this commit.

Change-Id: I98e1d8a7bc0f373a6b2cc621e9c1abe8b8e1950a
Resolves: #37491
Releases: 6.0
Reviewed-on: http://review.typo3.org/11622
Reviewed-by: Oliver Klee
Tested-by: Oliver Klee
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[TASK] Clean up the phpDoc of t3lib_treeview
Wouter Wolters [Mon, 28 May 2012 13:35:16 +0000 (15:35 +0200)]
[TASK] Clean up the phpDoc of t3lib_treeview

Clean up the phpDoc of t3lib_treeview

So I made a patch doing mostly:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)
* CGLify method signatures (the first line of the method)

Change-Id: I1a9dc3d3c920ce96ee231f032fc7e63f2d8754d3
Resolves: #37545
Releases: 6.0
Reviewed-on: http://review.typo3.org/11662
Reviewed-by: Oliver Klee
Tested-by: Oliver Klee
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[BUGFIX] CGL violations FunctionCallArgumentSpacing in sysext/beuser/
Roland Waldner [Sat, 26 May 2012 09:01:16 +0000 (11:01 +0200)]
[BUGFIX] CGL violations FunctionCallArgumentSpacing in sysext/beuser/

There are violations against the CGL rule
"FunctionCallArgumentSpacingNoSpaceAfterComma" in typo3/sysext/beuser/.
These will be reduced.

Change-Id: I90a9ed7d62e88764c66ef82782cafaa64b3478b7
Resolves: #37499
Releases: 6.0
Reviewed-on: http://review.typo3.org/11638
Reviewed-by: Oliver Klee
Tested-by: Oliver Klee
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[BUGFIX] CGL violations FunctionCallArgument in indexed_search
Roland Waldner [Sun, 20 May 2012 13:49:28 +0000 (15:49 +0200)]
[BUGFIX] CGL violations FunctionCallArgument in indexed_search

There were some violations against the CGL rule
"FunctionCallArgumentSpacingNoSpaceAfterComma" in
indexed_search. These will be reduced by this commit.

CGL violations will be reduced in 2 files.

Change-Id: Ic58282356e23eae0900f62051347f2e4dfdca137
Fixes: #37331
Releases: 6.0
Reviewed-on: http://review.typo3.org/11338
Reviewed-by: Oliver Klee
Tested-by: Oliver Klee
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[TASK] Remove commented-out code
Oliver Klee [Sat, 26 May 2012 12:28:08 +0000 (14:28 +0200)]
[TASK] Remove commented-out code

Commented-out code usually is not maintained, makes the code harder to
read and cannot be unit-tested. It should be removed.

Change-Id: I966ff1b88cf2196106110c57b9e48dceae21727e
Resolves: #37502
Releases: 6.0
Reviewed-on: http://review.typo3.org/11640
Reviewed-by: Wouter Wolters
Tested-by: Tolleiv Nietsch
Reviewed-by: Tolleiv Nietsch
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[TASK] CGL violations FunctionCallArgumentSpacing in /typo3/sysext/e*/
Roland Waldner [Sat, 26 May 2012 19:43:02 +0000 (21:43 +0200)]
[TASK] CGL violations FunctionCallArgumentSpacing in /typo3/sysext/e*/

There were violations against the CGL rule
"FunctionCallArgumentSpacingNoSpaceAfterComma" in /typo3/sysext/e*/.
These will be reduced by this commit.

Change-Id: Ica0fafe5bc68a8a06bfb142f474f13eaebf48e50
Resolves: #37511
Releases: 6.0
Reviewed-on: http://review.typo3.org/11651
Reviewed-by: Oliver Klee
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[TASK] CGL violations FunctionCallArgumentSpacing in /typo3/sysext/c*/
Roland Waldner [Sat, 26 May 2012 19:25:55 +0000 (21:25 +0200)]
[TASK] CGL violations FunctionCallArgumentSpacing in /typo3/sysext/c*/

There were violations against the CGL rule
"FunctionCallArgumentSpacingNoSpaceAfterComma" in /typo3/sysext/c*/.
These will be reduced by this commit.

Change-Id: I3c64376dcadb3ad9e4cd9e47a98d441826fd54a2
Resolves: #37510
Releases: 6.0
Reviewed-on: http://review.typo3.org/11649
Reviewed-by: Oliver Klee
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[TASK] CGL violations FunctionCallArgumentSpacing in /typo3/sysext/f*/
Roland Waldner [Sat, 26 May 2012 19:56:42 +0000 (21:56 +0200)]
[TASK] CGL violations FunctionCallArgumentSpacing in /typo3/sysext/f*/

There were violations against the CGL rule
"FunctionCallArgumentSpacingNoSpaceAfterComma" in /typo3/sysext/f*/.
These will be reduced by this commit.

Change-Id: I301a98427a558edbabc62e73e4ca05be546f3482
Resolves: #37512
Releases: 6.0
Reviewed-on: http://review.typo3.org/11652
Reviewed-by: Oliver Klee
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[TASK] Clean up the phpDoc of t3lib_tcemain
Wouter Wolters [Mon, 21 May 2012 20:12:50 +0000 (22:12 +0200)]
[TASK] Clean up the phpDoc of t3lib_tcemain

Clean up the phpDoc of t3lib_tcemain

So I made a patch doing mostly:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)
* CGLify method signatures (the first line of the method)

Change-Id: Ieda032bd940973b537c9cf882907d8ff8235b48d
Resolves: #37380
Releases: 6.0
Reviewed-on: http://review.typo3.org/11404
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Oliver Klee
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years ago[BUGFIX] CGL violations FunctionCallArgumentSpacingSpaceBeforeComma
Roland Waldner [Fri, 25 May 2012 12:24:53 +0000 (14:24 +0200)]
[BUGFIX] CGL violations FunctionCallArgumentSpacingSpaceBeforeComma

There are violations against the CGL rule
"FunctionCallArgumentSpacingSpaceBeforeComma". These will be reduced.

Change-Id: Ic57e4ec40b2344c13020f643b6d5c0c9c76d15a9
Resolves: #37488
Releases: 6.0
Reviewed-on: http://review.typo3.org/11607
Reviewed-by: Oliver Klee
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[TASK] Add unittest for url parameter related functions
Tolleiv Nietsch [Sun, 20 May 2012 10:15:30 +0000 (12:15 +0200)]
[TASK] Add unittest for url parameter related functions

Adds tests for implodeArrayForUrl, explodeUrl2Array and
compileSelectedGetVarsFromArray.

Change-Id: I07c7ee3a743632056b4e061fdb32af63b92abf17
Resolves: #37342
Releases: 6.0
Reviewed-on: http://review.typo3.org/11347
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Oliver Klee
Tested-by: Oliver Klee
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[BUGFIX ] CGL violations FunctionCallArgumentSpacing in alt_doc.php
Roland Waldner [Sun, 20 May 2012 12:45:39 +0000 (14:45 +0200)]
[BUGFIX ] CGL violations FunctionCallArgumentSpacing in alt_doc.php

There were some violations against the CGL rule
"FunctionCallArgumentSpacingNoSpaceAfterComma" in alt_doc.php.
These will be reduced by this commit.

Change-Id: I6660fb51f7c382eb05b647407abd034a91afbfce
Resolves: #37328
Releases: 6.0
Reviewed-on: http://review.typo3.org/11331
Reviewed-by: Oliver Klee
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years ago[BUGFIX ] CGL violations FunctionCallArgumentSpacing in wizard_forms.php
Roland Waldner [Sun, 20 May 2012 13:06:01 +0000 (15:06 +0200)]
[BUGFIX ] CGL violations FunctionCallArgumentSpacing in wizard_forms.php

There were some violations against the CGL rule
"FunctionCallArgumentSpacingNoSpaceAfterComma" in
typo3/wizard_forms.php. These will be reduced by this commit.

Change-Id: I2e41c83f02adea0af90bc9e4ac4eb99ebb285477
Resolves: #37329
Releases: 6.0
Reviewed-on: http://review.typo3.org/11332
Reviewed-by: Oliver Klee
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years ago[FEATURE] Enable overriding element browser type
Ingmar Schlecht [Thu, 17 May 2012 10:39:55 +0000 (12:39 +0200)]
[FEATURE] Enable overriding element browser type

Change-Id: I07e73b67a4714e1d2eae4695c690476ee85b13ae
Releases: 6.0
Resolves: #37249
Reviewed-on: http://review.typo3.org/11268
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Ingmar Schlecht
Tested-by: Ingmar Schlecht
7 years ago[TASK] Clean up the phpDoc of t3lib_tceforms_inline
Wouter Wolters [Sun, 20 May 2012 13:12:13 +0000 (15:12 +0200)]
[TASK] Clean up the phpDoc of t3lib_tceforms_inline

Clean up the phpDoc of t3lib_tceforms_inline

So I made a patch doing mostly:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)
* CGLify method signatures (the first line of the method)

Change-Id: Ic0ce2ccc2066f0c368ef553619a0e4bdf65609c3
Resolves: #37330
Releases: 6.0
Reviewed-on: http://review.typo3.org/11333
Reviewed-by: Oliver Klee
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years ago[FEATURE] New login error hook
Simon Schaufelberger [Tue, 8 Nov 2011 19:19:20 +0000 (20:19 +0100)]
[FEATURE] New login error hook

Add new login hook to handle login errors.

Change-Id: I72b91b78955e27e4123f458e4bf6c50ab150397b
Resolves: #29698
Releases: 6.0
Reviewed-on: http://review.typo3.org/6600
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[TASK] Add a comment for require(Bootstrap.php)
Oliver Klee [Wed, 23 May 2012 16:53:30 +0000 (18:53 +0200)]
[TASK] Add a comment for require(Bootstrap.php)

Bootstrap.php is included using "require" instead of "require_once" to
create a fatal error if Bootstrap.php is included from another place as
well (which would be a bug).

In order to keep people from changing this to "require_once" (as
recommended by the CGL), there should be comment explaining the
situation.

Change-Id: I39c88cae5af38bceafa5ca92561394a275152520
Resolves: #37447
Relates: #37383
Releases: 6.0
Reviewed-on: http://review.typo3.org/11549
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Oliver Klee
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years ago[TASK] Clean up phpDoc comments in t3lib classes
Wouter Wolters [Wed, 23 May 2012 17:47:00 +0000 (19:47 +0200)]
[TASK] Clean up phpDoc comments in t3lib classes

Clean up phpDoc comments for the following classes:

* t3lib/class.t3lib_userauth.php
* t3lib/class.t3lib_userauthgroup.php

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I43687e094a75b05109e99fb0adb5164fa584b85f
Resolves: #37450
Releases: 6.0
Reviewed-on: http://review.typo3.org/11551
Reviewed-by: Oliver Klee
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years ago[TASK] Set TYPO3 version to 6.0-dev
TYPO3 v4 Release Team [Tue, 22 May 2012 22:09:48 +0000 (00:09 +0200)]
[TASK] Set TYPO3 version to 6.0-dev

Change-Id: I4b21e237b4502f07ae1660d3e538759c716a1f4b
Reviewed-on: http://review.typo3.org/11511
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[RELEASE] Release of TYPO3 6.0.0alpha1
TYPO3 v4 Release Team [Tue, 22 May 2012 22:09:35 +0000 (00:09 +0200)]
[RELEASE] Release of TYPO3 6.0.0alpha1

Change-Id: I68f99111a53217f6b05ac6656b84763051516402
Reviewed-on: http://review.typo3.org/11510
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[TASK] Raise submodule pointer
TYPO3 v4 Release Team [Tue, 22 May 2012 09:57:43 +0000 (11:57 +0200)]
[TASK] Raise submodule pointer

Change-Id: I5018a3800a8a3553251ae0a79dfec7e7e5e9cb15
Reviewed-on: http://review.typo3.org/11438
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[BUGFIX] PHP warning when a language pack does not exist
Xavier Perseguers [Wed, 9 May 2012 07:48:05 +0000 (09:48 +0200)]
[BUGFIX] PHP warning when a language pack does not exist

If PHP warnings are not catched, file_get_contents issues a warning
message whenever a file cannot be retrieved.

Change-Id: Ibecfebf5ff4c89ca6c7c43370d87fc4e546a02c1
Fixes: #36976
Releases: 4.5, 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/11093
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[TASK] Add a comment for the require_once in t3lib_error_ErrorHandler
Oliver Klee [Sun, 20 May 2012 16:03:51 +0000 (18:03 +0200)]
[TASK] Add a comment for the require_once in t3lib_error_ErrorHandler

These require_once calls are needed to make the exception classes
available even if the autoloaded is not loaded at this point yet.

The comment point this out and (hopefully) keeps people from deleting
the require_once calls as part of some clean up.

Resolves: #37335
Relates: #23444, #36061

Change-Id: Ie226b67f44ea0c3cbd17fa9e52018dbf8d8b58d4
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/11340
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Missing argument 3 for t3lib_DB::exec_SELECTgetRows()
Philipp Gampe [Sun, 20 May 2012 13:45:02 +0000 (15:45 +0200)]
[BUGFIX] Missing argument 3 for t3lib_DB::exec_SELECTgetRows()

Change-Id: I063ff48e2f1d6f9dceaf910405d2f510818120c0
Fixes: #37324
Releases: 6.0
Reviewed-on: http://review.typo3.org/11337
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[BUGFIX] Pagetree: Copying large branches duplicates branch
Steffen Gebert [Sat, 11 Feb 2012 15:52:03 +0000 (16:52 +0100)]
[BUGFIX] Pagetree: Copying large branches duplicates branch

Copying large branches (500+ pages, depending on the server) has a big
problem: The AJAX request is answered too late (after Ext.Direct
timeout), so Ext.Direct will resend the request. This will copy the
branch once again. So the copied branch appears twice after copying.

The whole process fails with a connection timeout error message and the
user has to reload the page tree.

Change-Id: If0307586ec3196c3c3dedde92cfb6aee07bc9064
Resolves: #26993
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8981
Reviewed-by: Stefan Neufeind
Reviewed-by: Stefan Galinski
Reviewed-by: Philipp Gampe
Tested-by: Stefan Galinski
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[BUGFIX] CGL violations FunctionCallArgument in class.browse_links.php
Roland Waldner [Sun, 20 May 2012 12:22:56 +0000 (14:22 +0200)]
[BUGFIX] CGL violations FunctionCallArgument in class.browse_links.php

Fix some CGL violations in class.browse_links.php against rule
"FunctionCallArgumentSpacingNoSpaceAfterComma".

Change-Id: Ie0d3e471cb7ff443269c0d391b3a40752ce29ad3
Resolves: #37327
Releases: 6.0
Reviewed-on: http://review.typo3.org/11328
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] CGL violations FunctionCallArgumentSpacing in alt_clickmenu.php
Roland Waldner [Sun, 20 May 2012 11:57:07 +0000 (13:57 +0200)]
[BUGFIX] CGL violations FunctionCallArgumentSpacing in alt_clickmenu.php

Fix some CGL violations in alt_clickmenu.php against rule
"FunctionCallArgumentSpacingNoSpaceAfterComma".

Change-Id: Ie7b6da34e1ce1a0ecd23aaac29476dde13a7afd8
Resolves: #37323
Releases: 6.0
Reviewed-on: http://review.typo3.org/11323
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Clean up the phpDoc of t3lib_fullsearch
Wouter Wolters [Sun, 20 May 2012 12:10:40 +0000 (14:10 +0200)]
[TASK] Clean up the phpDoc of t3lib_fullsearch

Clean up the phpDoc of t3lib_fullsearch

So I made a patch doing mostly:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)
* CGLify method signatures (the first line of the method)

Change-Id: I0889c1272feda994e564d28704a6c31b6494c230
Resolves: #37326
Releases: 6.0
Reviewed-on: http://review.typo3.org/11325
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] CGL violations FunctionCallArgumentSpacing in /tests/
Roland Waldner [Sun, 20 May 2012 11:02:01 +0000 (13:02 +0200)]
[BUGFIX] CGL violations FunctionCallArgumentSpacing in /tests/

Fix some CGL violations in /tests/ against rule
"FunctionCallArgumentSpacingNoSpaceAfterComma".

Change-Id: I5a35bf48de79d9f1a7945b2191b5be9bd94146c8
Resolves: #37319
Releases: 6.0
Reviewed-on: http://review.typo3.org/11317
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Properly quote regexp in Install Tool
Jigal van Hemert [Fri, 30 Mar 2012 20:46:39 +0000 (22:46 +0200)]
[BUGFIX] Properly quote regexp in Install Tool

Characters with a special meaning must be properly quoted
if they appear in a regular expression.

Change-Id: I2587acb9d0f61a441be6e13dcaba7b7ca0fc82bc
Releases: 6.0, 4.7, 4.6, 4.5
Fixes: #35410
Reviewed-on: http://review.typo3.org/10103
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Philipp Gampe
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[BUGFIX] Regression of "better condition in versionOL of t3lib_tstemplate"
andy.grunwald [Wed, 9 May 2012 08:45:56 +0000 (10:45 +0200)]
[BUGFIX] Regression of "better condition in versionOL of t3lib_tstemplate"

versionOL in t3lib_tstemplate can cause a fatal error for
scripts like eID that run in frontend mode, but without a full
blown frontend environment.

The patch replaces the frontend check with a more specific test
for the required methods.

Change-Id: Ib3f9ebf355ee820e5144dd484d9a3a5e7708ebd4
Related: #31139, #25144
Resolves: #36981
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/11096
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[FEATURE] Bootstrap: Introduce shutdown and use in autoloader
Christian Kuhn [Thu, 17 May 2012 20:23:57 +0000 (22:23 +0200)]
[FEATURE] Bootstrap: Introduce shutdown and use in autoloader

The patch introduces a shutdown method to the bootstrap that
can be used to perform clean up and shutdown things at the
end of a script run. It is used in the most important entry
scripts like FE, mod.php, cli and backend.

First usage of shutdown() is the autoloader: If new classes are found
during script run, for example because they stick to the extbase naming
scheme and do not have a ext_autoload entry, the autoloader wrote a new
cache file for each class it found. Now, the autoloader remembers that
the cache file should be updated and delays of writing the cache file
until it is unregistered.
This way the full cache entry is only written once during shutdown.

Change-Id: Ibb84a7db65eb28e792c0b5ee9bedec00b29dbbb9
Resolves: #37268
Releases: 6.0
Reviewed-on: http://review.typo3.org/11279
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Oliver Klee
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[TASK] Add unit test for t3lib_div::callUserFunction
Tolleiv Nietsch [Sun, 20 May 2012 07:58:55 +0000 (09:58 +0200)]
[TASK] Add unit test for t3lib_div::callUserFunction

Releates to #36784 which would have brought some basic tests.
This patchset now has full coverage for the entire functionality
of callUserFunction and #36784 can be reduced to its actual purpose.

Change-Id: I02cfe3e963f90aa3c3986e57bdba4a08c6e4c0d5
Resolves: #37317
Releases: 6.0
Reviewed-on: http://review.typo3.org/11316
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[BUGFIX] DB field names exceed max length with 'zzz_deleted'
Tolleiv Nietsch [Wed, 1 Feb 2012 08:30:40 +0000 (09:30 +0100)]
[BUGFIX] DB field names exceed max length with 'zzz_deleted'

MySQL allows a maximum of 64 characters for column and table names.
When prefixing them with 'zzz_deleted' this limit might be reached
by accident. (e.g. with
'zzz_deleted_tx_powermail_tellAFriendForm_receiverEmailContentField')

The patch avoids the overstepping 64 characters.

At the same time the prefixed and shortened field names are more
likely to have the same name, therefore the names are cut
from the beginning.

Change-Id: Id423a5bc0bee8509c6da89793812b1399d6a14c0
Fixes: #33580
Releases: 4.5, 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/8791
Reviewed-by: Oliver Klee
Reviewed-by: Xavier Perseguers
Reviewed-by: Ingo Pfennigstorf
Tested-by: Ingo Pfennigstorf
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[TASK] Add unit tests for string related functions in t3lib_div
Tolleiv Nietsch [Sun, 20 May 2012 07:14:00 +0000 (09:14 +0200)]
[TASK] Add unit tests for string related functions in t3lib_div

Adds tests for htmlspecialchars_decode, deHSCentities, slashJS,
rawUrlEncodeJS, rawUrlEncodeFP, strtoupper and strtolower.

Change-Id: I1c68da9ac6bb187c1db559da03a2de6b20c4ab46
Resolves: #37315
Releases: 6.0
Reviewed-on: http://review.typo3.org/11315
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[BUGFIX] Reduce spacing CGL violations in /typo3/sysext/
Roland Waldner [Sun, 20 May 2012 05:52:33 +0000 (07:52 +0200)]
[BUGFIX] Reduce spacing CGL violations in /typo3/sysext/

There were a lot spacing CGL violations in /typo3/sysext/.
These will be reduced by this commit.

Change-Id: Iae4dc7bfbca79f5e71446d850eebfceeb20e4a18
Resolves: #37310
Releases: 6.0
Reviewed-on: http://review.typo3.org/11311
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Reduce spacing CGL violations in /t3lib/
Roland Waldner [Sat, 19 May 2012 21:13:29 +0000 (23:13 +0200)]
[BUGFIX] Reduce spacing CGL violations in /t3lib/

There were a lot spacing CGL violations in /t3lib/.
These will be reduced by this commit.

Change-Id: I66981be01ecb4f289de2ccbc0363d2f02bd98f6a
Resolves: #37309
Releases: 6.0
Reviewed-on: http://review.typo3.org/11310
Reviewed-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Reduce spacing CGL violations in /typo3/
Roland Waldner [Sat, 19 May 2012 20:57:26 +0000 (22:57 +0200)]
[BUGFIX] Reduce spacing CGL violations in /typo3/

There were a lot spacing CGL violations in /typo3/.
These will be reduced by this commit.

As there are really a lot of violations this fixes
these, which are NOT in /typo3/sysext/.

Change-Id: I71184548d54880905407ab6a80ac3feeee1123ee
Resolves: #37308
Releases: 6.0
Reviewed-on: http://review.typo3.org/11309
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Reduce spacing CGL violations in class.tslib_menu.php
Roland Waldner [Sat, 19 May 2012 20:38:14 +0000 (22:38 +0200)]
[BUGFIX] Reduce spacing CGL violations in class.tslib_menu.php

There were a lot spacing CGL violations in
class.tslib_menu.php. These will be reduced by
this commit.

Change-Id: I0c925ad2706d597906e830464f22a7ee939c6e98
Resolves: #37307
Releases: 6.0
Reviewed-on: http://review.typo3.org/11308
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Reduce spacing CGL violations in tslib_fe.php
Roland Waldner [Sat, 19 May 2012 19:58:07 +0000 (21:58 +0200)]
[BUGFIX] Reduce spacing CGL violations in tslib_fe.php

There were a lot spacing CGL violations in
tslib_fe.php. These will be reduced by this commit.

Change-Id: Id105b331df8a7970b52113228a6ab3bfda974e4e
Resolves: #37304
Releases: 6.0
Reviewed-on: http://review.typo3.org/11305
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Clean up the phpDoc of t3lib_div
Wouter Wolters [Sat, 19 May 2012 20:02:35 +0000 (22:02 +0200)]
[TASK] Clean up the phpDoc of t3lib_div

Clean up the phpDoc of t3lib_div

So I made a patch doing mostly:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)
* CGLify method signatures (the first line of the method)

Change-Id: I682d552d7cbf7ee3882f93d608390a50d57b1c41
Resolves: #37305
Releases: 6.0
Reviewed-on: http://review.typo3.org/11304
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[BUGFIX] Reduce spacing CGL violations in class.tx_impexp.php
Roland Waldner [Sat, 19 May 2012 20:21:43 +0000 (22:21 +0200)]
[BUGFIX] Reduce spacing CGL violations in class.tx_impexp.php

There were a lot spacing CGL violations in
class.tx_impexp.php. These will be reduced
by this commit.

Change-Id: I075a5ef7df9f2f33d89f90db409bc788a4786410
Resolves: #37306
Releases: 6.0
Reviewed-on: http://review.typo3.org/11306
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Add unittests for array related functions in t3lib_div
Tolleiv Nietsch [Sat, 19 May 2012 13:03:31 +0000 (15:03 +0200)]
[TASK] Add unittests for array related functions in t3lib_div

Some of the most basic functions should be covered with unit tests.

The change creates tests for inArray, array_merge, remapArrayKeys
and keepItemsInArray.

Change-Id: Id57148bc0d0418ed7308b9647c63af2d82ec94f2
Resolves: #37299
Releases: 6.0
Reviewed-on: http://review.typo3.org/11298
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[TASK] Add unittests for t3lib_div::formatSize
Tolleiv Nietsch [Sat, 19 May 2012 11:49:26 +0000 (13:49 +0200)]
[TASK] Add unittests for t3lib_div::formatSize

Some of the most basic functions should be covered with unit tests.

Change-Id: If9466ebdf9d7177de298db14c5460cddfcc5cbe1
Resolves: #37297
Releases: 6.0
Reviewed-on: http://review.typo3.org/11296
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[BUGFIX] Reduce spacing CGL violations in alt_clickmenu.php
Roland Waldner [Sat, 19 May 2012 19:41:55 +0000 (21:41 +0200)]
[BUGFIX] Reduce spacing CGL violations in alt_clickmenu.php

There were a lot spacing CGL violations in
/typo3/alt_clickmenu.php. These will be reduced
by this commit.

Change-Id: I5c209b0f05843412820d81f317ef7fafe19cadfc
Resolves: #37303
Releases: 6.0
Reviewed-on: http://review.typo3.org/11303
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Clean up phpDoc comments in t3lib classes
Wouter Wolters [Fri, 18 May 2012 20:28:49 +0000 (22:28 +0200)]
[TASK] Clean up phpDoc comments in t3lib classes

Clean up phpDoc comments for the following classes:

* t3lib/class.t3lib_tsfebeuserauth.php
* t3lib/class.t3lib_tsparser.php
* t3lib/class.t3lib_tsparser_ext.php
* t3lib/class.t3lib_tsparser_tsconfig.php
* t3lib/class.t3lib_tsstyleconfig.php
* t3lib/class.t3lib_tstemplate.php
* t3lib/class.t3lib_xml.php

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I312660e9da1964cff90b3998155d77bb3f4f0edd
Resolves: #37291
Releases: 6.0
Reviewed-on: http://review.typo3.org/11289
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Clean up phpDoc comments in t3lib classes
Wouter Wolters [Fri, 18 May 2012 19:18:11 +0000 (21:18 +0200)]
[TASK] Clean up phpDoc comments in t3lib classes

Clean up phpDoc comments for the following classes:

* t3lib/class.t3lib_svbase.php
* t3lib/class.t3lib_syntaxhl.php
* t3lib/class.t3lib_tceforms_fe.php
* t3lib/class.t3lib_timetrack.php
* t3lib/class.t3lib_timetracknull.php
* t3lib/class.t3lib_transferdata.php
* t3lib/class.t3lib_transl8tools.php

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I30f3f6819505751ff9339e0584ee58bff2944cc8
Resolves: #37290
Releases: 6.0
Reviewed-on: http://review.typo3.org/11288
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Clean up the phpDoc of t3lib_stdgraphic
Wouter Wolters [Fri, 18 May 2012 18:30:34 +0000 (20:30 +0200)]
[TASK] Clean up the phpDoc of t3lib_stdgraphic

Clean up the phpDoc of t3lib_stdgraphic

So I made a patch doing mostly:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)
* CGLify method signatures (the first line of the method)

Change-Id: Ic5797a1a33e75d1f8f474e855ba78198f4350c36
Resolves: #37289
Releases: 6.0
Reviewed-on: http://review.typo3.org/11287
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Clean up phpDoc comments in t3lib classes
Wouter Wolters [Fri, 18 May 2012 16:55:28 +0000 (18:55 +0200)]
[TASK] Clean up phpDoc comments in t3lib classes

Clean up phpDoc comments for the following classes:

* t3lib/class.t3lib_refindex.php
* t3lib/class.t3lib_scbase.php
* t3lib/class.t3lib_softrefproc.php
* t3lib/class.t3lib_sqlparser.php

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I1297ce2e244c7d19c590537d93b090f75a6043ce
Resolves: #37288
Releases: 6.0
Reviewed-on: http://review.typo3.org/11286
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Whitespace CGL
Felix Kopp [Sat, 19 May 2012 11:19:13 +0000 (13:19 +0200)]
[TASK] Whitespace CGL

Corrects several whitespace related issues.

Special focus lies on files
* typo3/class.db_list_extra.inc (127 violations)
* typo3/template.php (148 violations)
* EXT: rtehtmlarea/class.tx_rtehtmlarea_base.php (129 violations)

Sonar / metrics terms to be improved:

* OpeningFunctionBraceKernighanRitchieSpaceBeforeBrace
* FunctionCallArgumentSpacingSpaceBeforeComma
* FunctionCallArgumentSpacingTooMuchSpaceAfterComma
* SemicolonSpacingIncorrect

Change-Id: I18a971c64e62ad976d9da5daf6d9a4d5aa463425
Fixes: #37295
Releases: 6.0
Reviewed-on: http://review.typo3.org/11295
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Wrong DB fields usage in TCEmain
Felix Nagel [Wed, 16 May 2012 13:11:52 +0000 (15:11 +0200)]
[BUGFIX] Wrong DB fields usage in TCEmain

The fix for issue #35260 introduced a new bug in method
t3lib_TCEmain::getPreviousLocalizedRecordUid() by adding a
field in a query in the wrong place. In particular, this breaks
the localization of tt_content elements used with IRRE.

This patch fixes the problem by separating the list of fields
used for selecting and for sorting.

Change-Id: I66101071a0320b7c2b1826c3422e7bf99671a122
Fixes: #37221
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/11250
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Philipp Gampe
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years ago[BUGFIX] Fix CGL violations "SemicolonSpacingIncorrect"
Roland Waldner [Thu, 17 May 2012 18:48:09 +0000 (20:48 +0200)]
[BUGFIX] Fix CGL violations "SemicolonSpacingIncorrect"

Change-Id: Id5bf3756e215b50eb9d789648b2bca57bb8bb712
Resolves: #37264
Releases: 6.0
Reviewed-on: http://review.typo3.org/11277
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Bootstrap: Exit cli with valid keys if no key is given
Christian Kuhn [Wed, 16 May 2012 20:19:02 +0000 (22:19 +0200)]
[TASK] Bootstrap: Exit cli with valid keys if no key is given

If no cli key is given, cli_dispatch.phpsh exits with a generic
error message that a key must supplied to run the script. If a
key is given, but it is no registered cli script, the script
exits with a list of valid keys.

The patch removes the first test to also show the list of valid
keys if there is no key at all and adapts the error message a bit.

Change-Id: I4d356a1837218aaeb92ef85d9c5b8833b2737e08
Resolves: #37238
Releases: 6.0
Reviewed-on: http://review.typo3.org/11263
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Oliver Klee
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Reduce CGL violations in class.tx_install.php
Roland Waldner [Thu, 17 May 2012 13:40:20 +0000 (15:40 +0200)]
[BUGFIX] Reduce CGL violations in class.tx_install.php

Fix/Reduce CGL violations "FunctionCallArgumentSpacingNoSpaceAfterComma"
in typo3/sysext/install/mod/class.tx_install.php.

There are over 500 violations against this rule. This is fixed/reduced.

Change-Id: Iad13d9b4f2bad80cb7921ae44f46c3723f82cc20
Resolves: #37254
Releases: 6.0
Reviewed-on: http://review.typo3.org/11274
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Reduce CGL violations in class.tslib_fe.php
Roland Waldner [Thu, 17 May 2012 12:29:52 +0000 (14:29 +0200)]
[BUGFIX] Reduce CGL violations in class.tslib_fe.php

Fix/Reduce CGL violations "FunctionCallArgumentSpacingNoSpaceAfterComma"
in class.tslib_fe.php.

There are over 500 violations against this rule. This is fixed/reduced.

Change-Id: Ib4a8d95b99e06e1342a4f5c5a53df5582a9b7d86
Resolves: #37253
Releases: 6.0
Reviewed-on: http://review.typo3.org/11272
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Clean up phpDoc comments in t3lib classes
Wouter Wolters [Thu, 17 May 2012 11:13:35 +0000 (13:13 +0200)]
[TASK] Clean up phpDoc comments in t3lib classes

Clean up phpDoc comments for the following classes:

* t3lib/class.t3lib_parsehtml_proc.php
* t3lib/class.t3lib_positionmap.php
* t3lib/class.t3lib_querygenerator.php
* t3lib/class.t3lib_readmail.php
* t3lib/class.t3lib_recordlist.php
* t3lib/class.t3lib_registry.php
* t3lib/class.t3lib_rteapi.php

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I42a5b48a8eda5d77605a963ba8168d1d4342fa5f
Resolves: #37252
Releases: 6.0
Reviewed-on: http://review.typo3.org/11271
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[FEATURE] Remove invalid/unused FAL TCA config
Ingmar Schlecht [Thu, 17 May 2012 10:46:03 +0000 (12:46 +0200)]
[FEATURE] Remove invalid/unused FAL TCA config

Change-Id: I255e5067c3d2608870e4b35d35faf305af0f6b22
Releases: 6.0
Resolves: #37250
Reviewed-on: http://review.typo3.org/11269
Reviewed-by: Ingmar Schlecht
Tested-by: Ingmar Schlecht
7 years ago[TASK] Clean up phpDoc comments in t3lib classes
Wouter Wolters [Thu, 17 May 2012 00:12:48 +0000 (02:12 +0200)]
[TASK] Clean up phpDoc comments in t3lib classes

Clean up phpDoc comments for the following classes:

* t3lib/class.t3lib_pagerenderer.php
* t3lib/class.t3lib_pagetree.php
* t3lib/class.t3lib_parsehtml.php

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I56ffee774456d7712cf68cbd74652aad1b0f07bb
Resolves: #37242
Releases: 6.0
Reviewed-on: http://review.typo3.org/11265
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] CGL cleanup in bootstrap
Christian Kuhn [Wed, 16 May 2012 19:30:30 +0000 (21:30 +0200)]
[TASK] CGL cleanup in bootstrap

Fix some cgl flaws that slipped through during the bootstrap refactoring.

Change-Id: Id2d122d0afdb3e0e1091a13eeecf62c1c67236f4
Resolves: #37236
Releases: 6.0
Reviewed-on: http://review.typo3.org/11261
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Clean up phpDoc comments in t3lib_page
Wouter Wolters [Wed, 16 May 2012 18:17:49 +0000 (20:17 +0200)]
[TASK] Clean up phpDoc comments in t3lib_page

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: Ibbb16ff84edf3dfae9ca4152b62211f37afb4cda
Resolves: #37235
Releases: 6.0
Reviewed-on: http://review.typo3.org/11256
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Bootstrap: Disentangle cli and install from init.php
Christian Kuhn [Wed, 9 May 2012 19:27:53 +0000 (21:27 +0200)]
[TASK] Bootstrap: Disentangle cli and install from init.php

Extract code from init.php and put it to methods in Bootstrap.php.
Additionally, cli_dispatch and install/index.php do not require
init.php anymore and have a uncoupled bootstrap now.

There is still room for improvement,
this patch is just another intermediate step.

Change-Id: I5c6d84b8acb7760c8a77f192b2b5ba063b417b0d
Resolves: #37130
Releases: 6.0
Reviewed-on: http://review.typo3.org/11153
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[FEATURE] BE preview for non standard SSL port
Bas van de Wiel [Tue, 15 May 2012 17:56:50 +0000 (19:56 +0200)]
[FEATURE] BE preview for non standard SSL port

Make sure port number gets appended when backend
is locked to SSL and port number is set to something
other than the standard 443.

Change-Id: I5fcb04fa0e0b8cbde3f19e9c54366e11d14fdf8e
Fixes: #37076
Releases: 6.0
Reviewed-on: http://review.typo3.org/11225
Reviewed-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Remove old compatibility constructor
Christian Kuhn [Wed, 16 May 2012 09:03:06 +0000 (11:03 +0200)]
[TASK] Remove old compatibility constructor

typo3/class.show_rechis.inc was forgotten
during the cleanup round for 6.0

Change-Id: I1805b0845fa4e9f44ec2ec37cbceb02bcdcd015d
Resolves: #37207
Releases: 6.0
Reviewed-on: http://review.typo3.org/11231
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Remove deprecated class.alt_menu_functions.inc
Christian Kuhn [Wed, 16 May 2012 08:57:43 +0000 (10:57 +0200)]
[TASK] Remove deprecated class.alt_menu_functions.inc

Change-Id: I941fc2dfd028235ee0988d7e96cb374333987ae8
Resolves: #37206
Releases: 6.0
Reviewed-on: http://review.typo3.org/11230
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Fix whitespace in t3lib_befunc
Christian Kuhn [Wed, 16 May 2012 08:41:37 +0000 (10:41 +0200)]
[TASK] Fix whitespace in t3lib_befunc

This made jenkins unhappy with
https://review.typo3.org/#/c/11225/3

Change-Id: I02ae564546eea8982300e2c42b9abe72c463bb51
Resolves: #37205
Releases: 6.0
Reviewed-on: http://review.typo3.org/11229
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Clean up phpDoc comments in t3lib classes
Wouter Wolters [Sun, 13 May 2012 12:10:44 +0000 (14:10 +0200)]
[TASK] Clean up phpDoc comments in t3lib classes

Clean up phpDoc comments for the following classes:

* t3lib/class.t3lib_formmail.php
* t3lib/class.t3lib_frontendedit.php
* t3lib/class.t3lib_iconworks.php
* t3lib/class.t3lib_install.php

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I48a245d96f760c8957bebc8970cbe76446287084
Resolves: #37137
Releases: 6.0
Reviewed-on: http://review.typo3.org/11154
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Clean up phpDoc comments in t3lib classes
Wouter Wolters [Tue, 15 May 2012 21:52:49 +0000 (23:52 +0200)]
[TASK] Clean up phpDoc comments in t3lib classes

Clean up phpDoc comments for the following classes:

* t3lib/class.t3lib_install_sql.php
* t3lib/class.t3lib_loaddbgroup.php
* t3lib/class.t3lib_loadmodules.php
* t3lib/class.t3lib_lock.php
* t3lib/class.t3lib_modsettings.php

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I0465b7d41e492ae4746f0649b676eae4ad2a145a
Resolves: #37202
Releases: 6.0
Reviewed-on: http://review.typo3.org/11228
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Missing bottom margin in the page tree
Stefan Galinski [Fri, 13 Apr 2012 14:01:04 +0000 (16:01 +0200)]
[BUGFIX] Missing bottom margin in the page tree

This fixes the UI issue with the deletion overlay and drag&drop
with nodes at the very bottom of the page tree viewport too.

Change-Id: I5cee23ea9441fcd1910a998547772bc3f2e53fb5
Fixes: #35182
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/10411
Reviewed-by: Philipp Gampe
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
7 years ago[Task] CGL Cleanup LogicalOperatorSpacing*
Stefano Kowalke [Tue, 15 May 2012 10:16:51 +0000 (12:16 +0200)]
[Task] CGL Cleanup LogicalOperatorSpacing*

This is a follow-up to 37142.
It removes the last violation for this topic.

Change-Id: Ia788655833a5ab3778ce0ca16d3105f4a479fd6a
Fixes: #37178
Releases: 6.0
Reviewed-on: http://review.typo3.org/11204
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Re-enable indexed_search $TCA for index_config
Felix Kopp [Fri, 11 May 2012 13:31:48 +0000 (15:31 +0200)]
[BUGFIX] Re-enable indexed_search $TCA for index_config

EXT: indexed_search $TCA for table index_config is only loaded
when EXT: crawler is installed but $TCA must always be included.
Removes condition to limit $TCA inclusion.

Change-Id: I9768ae18c40fa95084fbca54880ffc7b31e1f0a1
Fixes: #32815
Releases: 4.7, 6.0
Reviewed-on: http://review.typo3.org/11145
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[BUGFIX] Wrong label reference for backend_layout
Markus Klein [Mon, 14 May 2012 12:37:08 +0000 (14:37 +0200)]
[BUGFIX] Wrong label reference for backend_layout

tbl_pages.php references non-existing labels.
Actually they have different names.

Change-Id: I9b89fd5dcc7355480e534c2b48130a8461f03ef4
Releases: 6.0, 4.7, 4.6, 4.5
Fixes: #37158
Reviewed-on: http://review.typo3.org/11178
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[BUGFIX] Pagetree doesn't expands to the last saved state
Stefan Galinski [Thu, 10 May 2012 17:51:11 +0000 (19:51 +0200)]
[BUGFIX] Pagetree doesn't expands to the last saved state

Change-Id: I0518d9dd06c7d126dfe5d885e4b2751b7e7462b6
Releases: 6.0, 4.7, 4.6, 4.5
Fixes: #36459
Reviewed-on: http://review.typo3.org/11138
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[BUGFIX] Fix 2 CGL violations in alt_shortcut.php.
Roland Waldner [Sun, 13 May 2012 17:15:32 +0000 (19:15 +0200)]
[BUGFIX] Fix 2 CGL violations in alt_shortcut.php.

on metrics.typo3.org the violations drilldown says
that is 1 violation against
"FunctionCallArgumentSpacingNoSpaceAfterEquals"
and 1 violation against
"FunctionCallArgumentSpacingNoSpaceBeforeEquals":
both in typo3/alt_shortcut.php.

this should be fixed.

after that i guess these 2 coding guidline sniffs
could be activated in the CI-server jobs?

Change-Id: I4ff9d4f57f97e2f502088d8d6026544615331cd6
Fixes: #37139
Releases: 6.0
Reviewed-on: http://review.typo3.org/11157
Reviewed-by: Roland Waldner
Tested-by: Roland Waldner
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[BUGFIX] CGL:ArrayBracketSpacingSpaceBeforeBracket
Roland Waldner [Sun, 13 May 2012 17:39:41 +0000 (19:39 +0200)]
[BUGFIX] CGL:ArrayBracketSpacingSpaceBeforeBracket

on metrics.typo3.org the violations drilldown
says that are 2 violations against
"ArrayBracketSpacingSpaceBeforeBracket" in
tests/Unit/t3lib/utility/
class.t3lib_utility_mailTest.php.

this should be fixed.

after that i guess this coding guidline sniff
could be activated in the CI-server jobs?

Change-Id: I6fb7c6b67611ebac903466b28c7c473b3d36ee51
Fixes: #37141
Releases: 6.0
Reviewed-on: http://review.typo3.org/11159
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer