Packages/TYPO3.CMS.git
19 months ago[FEATURE] Provide core cache frontends via dependency injection 88/61588/6
Markus Poerschke [Sun, 1 Sep 2019 18:48:30 +0000 (20:48 +0200)]
[FEATURE] Provide core cache frontends via dependency injection

Configure services for each service instance. The service names of the
cache frontends will follow this name pattern:
"cache.[NAME OF CONFIGURATION]".

E.g. the l10n cache frontend will be added as a service "cache.l10n".
(One exception has been made for the workspaces_cache, which is names
cache.workspaces)

Resolves: #89054
Releases: master
Change-Id: I5e328503ee0399f20ea37d766b8a80cd6d9930fc
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61588
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Markus Poerschke <markus@poerschke.nrw>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Susanne Moog <look@susi.dev>
19 months ago[BUGFIX] Do not check for pid=-1 when evaluating workspace records 41/61641/8
Benni Mack [Sun, 8 Sep 2019 13:34:52 +0000 (15:34 +0200)]
[BUGFIX] Do not check for pid=-1 when evaluating workspace records

TYPO3 Core handles the result of database queries in a lot of different
ways to filter out workspace records.

With "versioning support v1" (= without workspaces), the identifier was
usually "pid = -1" to filter out records that should not be displayed in
live results.

With workspaces, there are other, better ways to identify versioned via
the following fields:
- t3ver_state (what kind of versioned record is there)
- t3ver_oid (if the versioned record points to a live record)
- t3ver_wsid (the workspace ID)

The "pid" field was kept as misuse, but fine for most of the database
queries. Since we now have Doctrine DBAL, and Restrictions, the Core
API can now be unified to actually check for "t3ver_oid>0" instead of
"pid<>-1" to identify a versioned record.

All places in TYPO3 Core now does not check for "pid<>-1" anymore for
tables that are workspace-aware.

In the future, it is then possible to get rid of the "pid=-1" value when
writing versioned records, streamlining the API effectively, to find one
proper way to query and write records.

This change does not modify any other places in TYPO3 Core where
Workspace Records are written, but only cleans up the API to only
consider "t3ver_oid" instead of "pid", avoiding the mis-use of "pid".

Most queries can then be handled by simply checking:
- t3ver_wsid=0 AND deleted=0 for only fetching live records
- t3ver_wsid IN (0,12) AND t3ver_oid=0 to find all live records,
  and draft placeholders, to do overlays then

Resolves: #89122
Releases: master
Change-Id: I781d1ae440fe944e6c8c99d02884a6eb0c1be0a7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61641
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
19 months ago[BUGFIX] Render confirmation when deleting a scheduler task in edit view 40/61640/2
Andreas Fernandez [Sun, 8 Sep 2019 11:57:11 +0000 (13:57 +0200)]
[BUGFIX] Render confirmation when deleting a scheduler task in edit view

This patch renders a confirmation dialog when attempting to delete a
scheduler task in the edit view. This solves an inconsistency between
the SchedulerModuleController and the EditDocumentController.

Resolves: #89109
Releases: master, 9.5
Change-Id: Ibf76431aa075aaeed93dea71fd2d30a8be9760a9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61640
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Susanne Moog <look@susi.dev>
19 months ago[BUGFIX] Fix assertion ordering in test cases 66/61666/2
Oliver Hader [Wed, 11 Sep 2019 11:41:24 +0000 (13:41 +0200)]
[BUGFIX] Fix assertion ordering in test cases

* use assertEqualsCanonicalizing instead of assertSame
  on array values to ignore ordering
* apply sorting order for localizations retrieved in
  Clipboard (drive-by fix)
* properly tearDown left-over instances of previous
  test execution

Resolves: #89149
Releases: master
Change-Id: I369509bae1f58b7eeabe522c3a00af3ef86bb66f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61666
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
19 months ago[BUGFIX] Check date format before conversion in module "DB check" 30/56530/21
Sascha Egerer [Mon, 29 Jul 2019 13:34:05 +0000 (15:34 +0200)]
[BUGFIX] Check date format before conversion in module "DB check"

With the change in https://forge.typo3.org/issues/83675 every value could
be converted into a unix timestamp, which leads to incorrect conversions
in some cases e.g. if an interger value like a pid 5134 is passed to the
method.

Releases: master, 9.5
Resolves: #84588
Resolves: #85020
Change-Id: Id92367bae3085015399ed89531c019e8aacd6510
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/56530
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
19 months ago[TASK] Cleanup RecordHistory handling 31/61631/14
Frank Naegler [Thu, 5 Sep 2019 14:33:06 +0000 (16:33 +0200)]
[TASK] Cleanup RecordHistory handling

This patch deprecate some methods and public properties.
Also some code was moved into new classes to seperate
creations and rollback of record history entries.

Resolves: #89127
Releases: master
Change-Id: Ib30930bc2bce129cdbdb6039d0e361020799e8e3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61631
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <look@susi.dev>
19 months ago[BUGFIX] Avoid unnecessary DB queries to sys_language 56/61656/3
Benni Mack [Tue, 10 Sep 2019 09:39:55 +0000 (11:39 +0200)]
[BUGFIX] Avoid unnecessary DB queries to sys_language

Since site handling, finding the correct languages and the amount of languages in a page can be simplified.

NewRecordController->checkIfLanguagesExist() is never in use, and can be removed completely.

Resolves: #89125
Releases: master
Change-Id: I523bf8ecdf0598d7acb062200710c4fae2935cc5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61656
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <look@susi.dev>
19 months ago[BUGFIX] Correctly retrieve workspace versions 63/61663/6
Oliver Hader [Tue, 10 Sep 2019 22:01:53 +0000 (00:01 +0200)]
[BUGFIX] Correctly retrieve workspace versions

* Clipboard now correctly resolves record localizations of a workspace
* PageLayoutController new correctly determines sub-pages that are new
  in a particular workspace
* SlugHelper & TypoScriptTemplateModuleController can be simplified
  by using WorkspaceRestriction directly
* common function test scenario tree (based on YAML) is introduced
  for ext:backend in order to be used as structure for other tests
* required testing framework changes support version and language
  variants and combination much better now

Resolves: #89138
Releases: master
Change-Id: Ia4b412d48dd3ea92adc60c729ad6feb27c22b812
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61663
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Gorges <daniel.gorges@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Achim Fritz <af@achimfritz.de>
19 months ago[BUGFIX] Use RuntimeException instead of die() 59/61659/4
Benni Mack [Tue, 10 Sep 2019 13:28:22 +0000 (15:28 +0200)]
[BUGFIX] Use RuntimeException instead of die()

There are a few places left where Kasper-Kode stopped
a process with die(). Nowadays, with PHP 7, Errors and
Exceptions are used in order to avoid the full stop
of a process.

Using Exceptions instead of die() allows for
ExceptionHandlers to handle such an error and
return a proper HTTP response if called from the web.

Resolves: #89128
Releases: master
Change-Id: Ia50863104fb91303ca3b2ae5ac5cd1466fa982b6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61659
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
19 months ago[BUGFIX] Support mark symbols in slug generation 55/61655/2
Andreas Fernandez [Tue, 10 Sep 2019 08:58:17 +0000 (10:58 +0200)]
[BUGFIX] Support mark symbols in slug generation

Currently, slug sanitization removes a wide range of characters not
assumed suitable for slugs, for example single accent characters or
control characters. This patch adds support for mark characters used for
example in the devanagari alphabet.

Resolves: #89123
Releases: master, 9.5
Change-Id: Iac7350d716044225164aef8585b833e3c46423fc
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61655
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
19 months ago[TASK] Cleanup and de-duplicate Extension Configuration and Constant Editing 44/61644/8
Susanne Moog [Sun, 8 Sep 2019 19:49:34 +0000 (21:49 +0200)]
[TASK] Cleanup and de-duplicate Extension Configuration and Constant Editing

* Use the same parser for constants no matter the context
* Use a dedicated class for constant configuration parsing
* Remove custom flatten implementation and use ArrayUtility
* Use the TypoScriptParser for value parsing of constants
* Remove Code Duplication

Resolves: #89113
Releases: master
Change-Id: I4caae04d65b02e3220c4f1f3c478fd212cddf587
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61644
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[BUGFIX] Fix configuration composition for nested structures 46/61646/4
Andreas Fernandez [Mon, 9 Sep 2019 08:38:14 +0000 (10:38 +0200)]
[BUGFIX] Fix configuration composition for nested structures

When a new site configuration gets written, removed values are
determined first and changed values are determined afterwards to keep
nested structures intact.

Resolves: #89116
Related: #86803
Releases: master
Change-Id: I6deae2a3f6eed121aa2753f2ba9a5cafa058a54d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61646
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Benni Mack <benni@typo3.org>
19 months ago[FEATURE] Read site setting file and populate them with the site object 36/61636/19
Susanne Moog [Sun, 8 Sep 2019 11:24:41 +0000 (13:24 +0200)]
[FEATURE] Read site setting file and populate them with the site object

In order to introduce site wide accessible settings, a site settings
file can be placed into the sites configuration folder.
The provided data will be available via the sites object.

Resolves: #89102
Releases: master
Change-Id: Ic010b3f8c3b10df0b6dc0cfca1cd57a8346e3b88
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61636
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
19 months ago[TASK] Fix typo overriden > overridden 51/61651/3
Georg Ringer [Mon, 9 Sep 2019 18:30:33 +0000 (20:30 +0200)]
[TASK] Fix typo overriden > overridden

Also fix some typos where 'overidden' was used.

Resolves: #89119
Releases: master
Change-Id: I3d42fd662b978bc9688d2116b1c08eca9f9e7090
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61651
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
19 months ago[TASK] Change commenting style of spam protecting code 47/61647/2
Georg Ringer [Mon, 9 Sep 2019 12:20:22 +0000 (14:20 +0200)]
[TASK] Change commenting style of spam protecting code

To avoid possible conflicts with JS minification, the commenting style
is changed.

Resolves: #89093
Releases: master, 9.5
Change-Id: I1afce194b89eeb64988f48c37b6ba1107d21f61b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61647
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[TASK] Add default value to unused parameter in addPItoST43() 48/61648/3
Daniel [Mon, 9 Sep 2019 13:29:11 +0000 (13:29 +0000)]
[TASK] Add default value to unused parameter in addPItoST43()

The second argument of ExtensionManagementUtility::addPItoST43() has been
made obsolete with TYPO3 v8, but is still required when using the method.
This patch sets the default value of that argument to an empty string to
make the argument truly optional.

Releases: master, 9.5
Resolves: #89117
Change-Id: Ie99a4599481db61e425711eefec783d5826aa11d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61648
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
19 months ago[TASK] Speed up DB query for tables with versions 37/59037/5
Alexander Opitz [Wed, 5 Dec 2018 10:43:51 +0000 (11:43 +0100)]
[TASK] Speed up DB query for tables with versions

Eliminating OR combination of subselects within same table, as they get
wrongly managed by DBMS (mostly MySQL). Using JOIN and UNION reduces
time to execute (on larger data sets) from 10 s to 0.01 s. This helps to
get the page tree view working if an editor is inside workspace.

Resolves: #86945
Releases: master, 9.5, 8.7
Change-Id: I7a5aa66baa6cef160de66fff3f80aec49b46295f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59037
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Benni Mack <benni@typo3.org>
19 months ago[BUGFIX] Remove leftover functionality for workspace reviewers and vtypes 43/61643/3
Benni Mack [Sun, 8 Sep 2019 14:24:00 +0000 (16:24 +0200)]
[BUGFIX] Remove leftover functionality for workspace reviewers and vtypes

EXT:workspace code has leftover functionality from "reviewers" and "vtypes".

* "vtypes" defined whether element-, branch or page-type versioning was used until TYPO3 v4.x.
* "reviewers" defined a database field which was migrated to responsible persons for a stage

The database fields are fully removed, as well as database access (for the empty fields) and labels.

Resolves: #41419
Releases: master
Change-Id: I8a82bdce83638c290dba96e9e07dd28d695d720a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61643
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Daniel Gorges <daniel.gorges@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.com>
Reviewed-by: Benni Mack <benni@typo3.org>
19 months ago[TASK] Use Workspace API for checking TCA versioning support 39/61639/2
Benni Mack [Sun, 8 Sep 2019 09:47:56 +0000 (11:47 +0200)]
[TASK] Use Workspace API for checking TCA versioning support

The API method BackendUtility::isTableWorkspaceEnabled($table)
should be used when dealing with a backend context to determine
if a table has versioning support enabled.

This functionality wasn't used consistently throughout TYPO3
Backend / CLI code and should be used in order to determine.

For PageRepository a separate protected method is introduced
to avoid a dependency on BackendUtility.

This patch is a precursor for streamlining the workspaces API further.

Resolves: #89108
Releases: master
Change-Id: Id63e04a5faa1520459d23fb5467ebfb523d9d958
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61639
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <look@susi.dev>
19 months ago[TASK] Upgrade to TypeScript 3.6 37/61637/9
Andreas Fernandez [Fri, 6 Sep 2019 19:33:06 +0000 (21:33 +0200)]
[TASK] Upgrade to TypeScript 3.6

After shedding tears, blood and sacrificing brain cells and CPU time, we
finally managed to upgrade the code base to a recent TypeScript version.

With this patch, our code is compiled with TypeScript 3.6, which has
been added by the following command:

  yarn add --dev typescript@~3.6.2

Resolves: #89104
Releases: master
Change-Id: I023ba89b4d4d8d98394d046c53db7fa64c12d44c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61637
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: TYPO3com <noreply@typo3.com>
19 months ago[TASK] Fix TypeScript sources in preparation to upgrade 38/61638/7
Andreas Fernandez [Sat, 7 Sep 2019 15:01:18 +0000 (17:01 +0200)]
[TASK] Fix TypeScript sources in preparation to upgrade

To ease the upgrade to TypeScript 3.6, this patch adjusts the source
code in a TS 2.4 compatible way. This way, the upgrade patch stays as
small as possible.

Resolves: #89106
Releases: master
Change-Id: I7e2d65262395e19f958182f8658aa326dd0aec43
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61638
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
19 months ago[BUGFIX] Allow selective saving in SiteConfiguration 73/61573/10
Susanne Moog [Thu, 29 Aug 2019 10:42:06 +0000 (12:42 +0200)]
[BUGFIX] Allow selective saving in SiteConfiguration

YAML SiteConfiguration allows imports and custom configuration
that is not configurable via UI to be written directly into the
configuration files, however, when saving with the UI these
settings are overwritten and resolved. This change changes the
SiteConfiguration in a way, that only modified values are written
and imports are completely left as they are.

Resolves: #86803
Releases: master, 9.5
Change-Id: I92ece4959d57f41535e6fc8c3c7c9d2894d7f920
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61573
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Torben Hansen <derhansen@gmail.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Torben Hansen <derhansen@gmail.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
19 months ago[FEATURE] Add integrity check for redirects 27/61627/14
Andreas Fernandez [Thu, 5 Sep 2019 09:54:14 +0000 (11:54 +0200)]
[FEATURE] Add integrity check for redirects

A new Symfony command checks for redirects that may conflict with
existing and accessible sites. The command is schedulable and thus may be
created as a scheduler task.

Additionally, this patch comes with a report informing a backend user
about such conflicts.

Command:

  ./typo3/sysext/core/bin/typo3 redirects:checkintegrity [--site=some-site-identifier]

Resolves: #89090
Releases: master
Change-Id: Ide1bf0143ff55623cca268e6844e331805fb0178
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61627
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Richard Haeser <richard@maxserv.com>
19 months ago[BUGFIX] Hash extension versions into requireJS bust parameter 25/61625/3
Benjamin Franzke [Wed, 4 Sep 2019 11:45:20 +0000 (13:45 +0200)]
[BUGFIX] Hash extension versions into requireJS bust parameter

When a third party extension that contains a requireJS backend module is
updated, the cache bust parameter needs to be updated as well, otherwise
browsers would not download the updated asset.

We will now include all extensions that contain requireJS modules into the
requireJS bust parameter hash calculation (by extension name and version).
That means an extension update of these extensions will trigger a new
bust parameter.

This has the slight drawback that the requireJS bust parameter will need
to be re-calculated after every extension update of such extensions, but
that's actually limited to extensions that provide requireJS modules, and
better than no asset updates at all.

This patch uses the PackageManager instead of ExtensionManagementUtility
to get access to the package version using the PackageInterface. Having
the full package array available we can also drop the
GeneralUtility::getFileAbsFilename('EXT:…') indirection which ends up
calling PackageManager anyway (only with added string parsing overhead).

Releases: master, 9.5
Resolves: #89086
Change-Id: Id183c935aad60a38231eb1b39aae5baed269f8ce
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61625
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[BUGFIX] Filter translated rows in element browser 88/58888/4
Mathias Brodala [Mon, 12 Nov 2018 15:24:31 +0000 (16:24 +0100)]
[BUGFIX] Filter translated rows in element browser

It must be possible to also filter translated rows in the element
browser similarly to regular rows. This is essential to e.g. prevent
selection of translated rows in relation fields.

Resolves: #73165
Releases: master, 9.5
Change-Id: If0dbfb0841a0e69db3644eb7015786958c88e647
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/58888
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jonas Eberle <flightvision@googlemail.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
19 months ago[TASK] Add UnitTests for SiteConfiguration 29/61629/5
Anja Leichsenring [Thu, 5 Sep 2019 11:01:41 +0000 (13:01 +0200)]
[TASK] Add UnitTests for SiteConfiguration

Resolves: #89089
Releases: master, 9.5
Change-Id: I7971e27e01bd26f1ea7fe03a008447c8475cac9e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61629
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
19 months ago[BUGFIX] Fix broken nightlies because of unknown function 33/61633/3
Frank Naegler [Fri, 6 Sep 2019 07:07:52 +0000 (09:07 +0200)]
[BUGFIX] Fix broken nightlies because of unknown function

The minimum version of phpspec/prophecy is 1.7.6 and does not
contain the method `shouldBeCalledOnce()`.

Resolves: #89098
Related: #89066
Releases: master
Change-Id: Iacfda5c100ec809ea0f7f21ce2e113571b6ae25a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61633
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
19 months ago[BUGFIX] Respect readOnly for inline relation 90/61490/3
Georg Ringer [Mon, 12 Aug 2019 18:56:48 +0000 (20:56 +0200)]
[BUGFIX] Respect readOnly for inline relation

If a TCA field is set to readOnly=true and is using the type "inline",
all buttons are now hidden and the fields of the relation are set to
readOnly as well.

Resolves: #56060
Releases: master, 9.5
Change-Id: If2b1cb2be0591d765f40512aaf341a9c26a2f87f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61490
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Torben Hansen <derhansen@gmail.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Torben Hansen <derhansen@gmail.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
19 months ago[TASK] Make "Check TCA in ext_tables.php" install tool wizard more helpful 91/61591/5
Tymoteusz Motylewski [Mon, 2 Sep 2019 20:06:50 +0000 (22:06 +0200)]
[TASK] Make "Check TCA in ext_tables.php" install tool wizard more helpful

Add information about how user can fix the issue.

Releases: master, 9.5
Resolves: #89065
Change-Id: I4110e38ba69fbe277f5f1c08fb25fbbdd52d1fcc
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61591
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
19 months ago[BUGFIX] Name test class after subject under test 28/61628/2
Anja Leichsenring [Thu, 5 Sep 2019 10:16:58 +0000 (12:16 +0200)]
[BUGFIX] Name test class after subject under test

The subject under test is SiteConfigurationDataGroup::class,
due to the wrong name IDEs will not connect the test class with it.
To resolve the confusion, the test class gets named after the
class it tests.

Resolves: #89088
Releases: master, 9.5
Change-Id: Ice6f2857eb6bc416795b4576d6cce3410a81df96
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61628
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
19 months ago[BUGFIX] Use node-based Docker container for nightly JavaScript unit tests 24/61624/4
Andreas Fernandez [Thu, 5 Sep 2019 05:49:00 +0000 (07:49 +0200)]
[BUGFIX] Use node-based Docker container for nightly JavaScript unit tests

Resolves: #89085
Related: #89049
Releases: master
Change-Id: I3f2d83afcd833eac2caba13faedad3e449683bda
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61624
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[TASK] Update styleguide 18/61618/4
Susanne Moog [Wed, 4 Sep 2019 14:19:30 +0000 (16:19 +0200)]
[TASK] Update styleguide

    composer update typo3/cms-styleguide

Resolves: #89080
Releases: master, 9.5, 8.7
Change-Id: Ic4c62758efac128f61b2b8d1502ff671982a3e7a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61618
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Susanne Moog <look@susi.dev>
19 months ago[BUGFIX] Use node-based docker container for runTests.sh 23/61623/2
Andreas Fernandez [Wed, 4 Sep 2019 15:53:46 +0000 (17:53 +0200)]
[BUGFIX] Use node-based docker container for runTests.sh

Resolves: #89082
Releases: master
Change-Id: I845a6689374ec0e94e16286c58ce2a7deae43450
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61623
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Susanne Moog <look@susi.dev>
19 months ago[TASK] Add test case for reverse proxy configuration 04/61404/5
Jonas Eberle [Fri, 2 Aug 2019 14:51:47 +0000 (16:51 +0200)]
[TASK] Add test case for reverse proxy configuration

The case covers given HTTP_HOST and HTTP_X_FORWARDED_HOST with
a configuration for an (intransparent) proxy.

As some reverse proxies can be configured to have a rewritten HTTP_HOST
(usually some internal name that matches the virtual host config on the
webserver) I wondered if I can safely assume that TYPO3 handles that.

Resolves: #88898
Releases: master
Change-Id: I05302afdea0366674748445808ff00a48716e7f8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61404
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jonas Eberle <flightvision@googlemail.com>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Jonas Eberle <flightvision@googlemail.com>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
19 months ago[FEATURE] PHP API for backend JavaScript notifications 90/61590/19
Frank Naegler [Mon, 2 Sep 2019 14:36:34 +0000 (16:36 +0200)]
[FEATURE] PHP API for backend JavaScript notifications

Resolves: #89066
Related: #89061
Releases: master
Change-Id: Iba28c90287f35818d7d669f2bb8400a4fc089856
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61590
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <look@susi.dev>
19 months ago[FEATURE] Always enable filter in SelectMultipleSideBySide fields 28/61428/7
Georg Ringer [Sat, 3 Aug 2019 13:09:07 +0000 (15:09 +0200)]
[FEATURE] Always enable filter in SelectMultipleSideBySide fields

The filter functionality of fields `type = select` with
renderType = selectMultipleSideBySide is always enabled now.

Resolves: #88907
Releases: master
Change-Id: I7332f39abd6444fc164e8b60009690f6af637b73
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61428
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Susanne Moog <look@susi.dev>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Tested-by: Susanne Moog <look@susi.dev>
19 months ago[FEATURE] Introduce Notification Actions 89/61589/15
Andreas Fernandez [Mon, 2 Sep 2019 14:06:18 +0000 (16:06 +0200)]
[FEATURE] Introduce Notification Actions

This patch introduces the ability to attach action items to a
notification, as known from nowadays operating systems.

Resolves: #89061
Releases: master
Change-Id: I9a36118cea12b58683746a8758b68ac0a4d0f710
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61589
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
19 months ago[BUGFIX] Support multiple env vars per line in Yaml 76/61576/9
Susanne Moog [Thu, 29 Aug 2019 13:29:34 +0000 (15:29 +0200)]
[BUGFIX] Support multiple env vars per line in Yaml

Releases: master, 9.5
Resolves: #89059
Change-Id: Iafbe5cb8ade38f29c13fd8ded68e42d552a28891
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61576
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Susanne Moog <look@susi.dev>
19 months ago[TASK] Build JavaScript files using ECMAScript 6 82/61582/4
Andreas Fernandez [Fri, 30 Aug 2019 08:27:06 +0000 (10:27 +0200)]
[TASK] Build JavaScript files using ECMAScript 6

Since TYPO3 v10 dropped support for Internet Explorer, JavaScript files
may be shipped using the ECMAScript 6 standard. External assets simply
get transpiled as far as possible. TypeScript loads the internal for ES6
and ES7 to generate native ECMAScript 6 builds.

Resolves: #89047
Releases: master
Change-Id: I5ab877ae07bba26e3953441040a519c628501b6b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61582
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[TASK] Deprecate jumpToUrl() 89/61389/9
Andreas Fernandez [Mon, 29 Jul 2019 19:43:29 +0000 (21:43 +0200)]
[TASK] Deprecate jumpToUrl()

This patch deprecated the well-known `jumpToUrl()` function which simply
does a redirect nowadays. Any occurence may be replaced by either using
`window.location.href` or using simple `<a>` tags.

Resolves: #89033
Releases: master
Change-Id: I213d89825b8ee4736e168653cddb1929ceb9844e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61389
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Susanne Moog <look@susi.dev>
19 months ago[TASK] Run JS tests on ChromeHeadless instead of Phantom in CI 14/61614/8
Susanne Moog [Wed, 4 Sep 2019 06:28:39 +0000 (08:28 +0200)]
[TASK] Run JS tests on ChromeHeadless instead of Phantom in CI

As Phantom is discontinued and ChromeHeadless is an easy to use
alternative, we should use ChromeHeadless to run our CI tests.

In addition, a dedicated JS image for all JavaScript related tasks
has been added, enabling us to easier update node versions and adjust
our JavaScript builds in the future.

Resolves: #89049
Releases: master
Change-Id: I15c3af0796b0398f62b228d3aeefa1030c5e6ae7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61614
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <look@susi.dev>
19 months ago[TASK] Update testing framework to 5.0.12 17/61617/2
Susanne Moog [Wed, 4 Sep 2019 06:26:13 +0000 (08:26 +0200)]
[TASK] Update testing framework to 5.0.12

    composer require typo3/testing-framework:"~5.0.12"

Resolves: #89073
Releases: master
Change-Id: If6384d11c0201cea760b384a8b7d7b361874e815
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61617
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[TASK] Raise size of mountpoint fields in sys_workspace 16/61616/2
Georg Ringer [Wed, 4 Sep 2019 03:46:06 +0000 (05:46 +0200)]
[TASK] Raise size of mountpoint fields in sys_workspace

Increase the size of the fields `db_mountpoints` and `file_mountpoints`
and allow 100 instead of 25 items.

Resolves: #89071
Releases: master
Change-Id: I410900874475bce01a7f5f739640de6bd7d39d7e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61616
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Richard Haeser <richard@maxserv.com>
19 months ago[TASK] Deprecate evaluation of ll-XML localization files 72/61572/15
Georg Ringer [Thu, 29 Aug 2019 03:49:37 +0000 (05:49 +0200)]
[TASK] Deprecate evaluation of ll-XML localization files

Deprecate the usage of LocallangXmlParser in favor of xlf.

Resolves: #89037
Releases: master
Change-Id: I3f5a6beb28bf5e93fb83579c09f6c9aa4bacd662
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61572
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
19 months ago[BUGFIX] Strip logical operator prefix in config.additionalWhere 92/61392/7
Rémy DANIEL [Tue, 30 Jul 2019 15:58:05 +0000 (17:58 +0200)]
[BUGFIX] Strip logical operator prefix in config.additionalWhere

When building the additionalWhere clause in the
RecordsXmlSitemapDataProvider, a possible `AND` operator
must be removed. Doctrine's queryBuilder adds this prefix
automatically.

Resolves: #88865
Releases: master,9.5
Change-Id: I6fd1f170c1c3a3b46bcaab4f2a9589e98e489a79
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61392
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
19 months ago[BUGFIX] Select pid for both sides of a staged record 84/61584/3
Andreas Fernandez [Fri, 30 Aug 2019 11:39:56 +0000 (13:39 +0200)]
[BUGFIX] Select pid for both sides of a staged record

`WorkspaceService::selectAllVersionsFromPages()` must select the pid of
both sides of a staged record to be able to build a proper language
icon.

Resolves: #89050
Related: #89041
Releases: master
Change-Id: I18a5e59598cfc189da0b79c4f6ae01540d88fe0f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61584
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
19 months ago[BUGFIX] Respect offset of original query in PaginateController 87/60487/4
Chris Müller [Tue, 16 Apr 2019 13:35:18 +0000 (15:35 +0200)]
[BUGFIX] Respect offset of original query in PaginateController

When you have set an offset on a query, the PaginateController will
now take this offset into account when browsing to a next page.

Resolves: #88159
Releases: master, 9.5
Change-Id: I0791f8550ccfff4eefab297d7000e08e6e01b93e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60487
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
19 months ago[FEATURE] Allow relative paths in Yaml file imports 92/60992/11
Benni Mack [Wed, 12 Jun 2019 21:04:20 +0000 (23:04 +0200)]
[FEATURE] Allow relative paths in Yaml file imports

Allowing Yaml Files with an import statement that
can be relative to the current file allows to handle cascading
site configuration better.

This way, a common site can actually have global route enhancers
defined in the config/ folder (e.g. config/sites/base.yaml) that
all sites/XYZ/config.yaml files could import by using `../base.yaml`.

This greatly enhances the developer experience for
advanced and larger installations.

Resolves: #88742
Releases: master
Change-Id: I99139d237fef248e0da941469d732c0c24d8c64d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60992
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
19 months ago[BUGFIX] Ensure ReflectionService can be used during TCA load 73/61373/3
Benjamin Franzke [Thu, 25 Jul 2019 15:18:52 +0000 (17:18 +0200)]
[BUGFIX] Ensure ReflectionService can be used during TCA load

In order to support the 'tcaIsBeingBuilt' for legacy signal
listeners that are *not* available in the symfony container,
we need to enable the Extbase Object Container to use the
(lazy loaded) ReflectionService, which requires the CacheManager
to be available.
Therefore we now mark "boot.state" done once ext_localconf.php
has been loaded. boot.state = true will allow the CacheManager
to be created in TYPO3\CMS\Core\ServiceProvider instead of
throwing a LogicException.

Releases: master
Resolves: #88843
Change-Id: I93f182d1e84f65ae005a8e51a0faff5e47dc36f0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61373
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[BUGFIX] Fix frontend error handling when root page is protected 31/61531/3
Helmut Hummel [Fri, 23 Aug 2019 11:19:50 +0000 (13:19 +0200)]
[BUGFIX] Fix frontend error handling when root page is protected

If the root page is accessed directly, we add a check whether
the page could be fetched with ignored group permissions.
If that is the case, an access denied is triggered.

If the root page also has the extendToSubPages flag set,
we must not remove the page from the root line, which would
trigger a service unavailable handling, but instead
keep the root line and trigger a page not found.

Resolves: #89006
Releases: master, 9.5
Change-Id: I69fa1c725c16d69c37caca5e3013e0c010854b5f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61531
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
19 months ago[FEATURE] Introduce site config import for distributions 54/61554/10
Anja Leichsenring [Sun, 25 Aug 2019 09:14:51 +0000 (11:14 +0200)]
[FEATURE] Introduce site config import for distributions

Distributions or site packages can now ship their preconfigured
site configurations in Initialisation/Site and see it moved into
place upon extension activation.

Resolves: #89010
Releases: master
Change-Id: Ia1ecc6814f9d470e2973b80678ccfb38178e6745
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61554
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
19 months ago[BUGFIX] Restore original page tree after filter reset 81/61581/4
Andreas Fernandez [Fri, 30 Aug 2019 08:00:37 +0000 (10:00 +0200)]
[BUGFIX] Restore original page tree after filter reset

When a filter is applied to the page tree, the original state of the
tree is stored. When the filter is cleared, that stored state is
recovered.

Additionally, a regex check is fixed that falsely is positive for
undefined values.

Resolves: #87898
Releases: master, 9.5
Change-Id: I9b1e5386acec8f348e043f9ea45140818e312cc3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61581
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[BUGFIX] Correctly renumber sorting values for value 0 04/59604/6
Helmut Hummel [Fri, 1 Feb 2019 12:09:54 +0000 (13:09 +0100)]
[BUGFIX] Correctly renumber sorting values for value 0

The called method reorders all elements not including
the given sorting number, leading to an off by one error
when the element in question has sorting number 0.

Resolves: #87612
Releases: master, 9.5
Change-Id: I4cc3ccb96bb4c308026096993d9f09f1b806c77e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59604
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Roman Schilter <roman.schilter10@gmail.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Roman Schilter <roman.schilter10@gmail.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
19 months ago[BUGFIX] Set rel="noopener noreferrer" for external links 77/61577/3
Frank Naegler [Thu, 29 Aug 2019 14:21:45 +0000 (16:21 +0200)]
[BUGFIX] Set rel="noopener noreferrer" for external links

This patch adds rel="noopener noreferrer" for external links in
backend and install tool for security reasons.
If this is not set, the other page can access the window object
with the window.opener property.

Resolves: #89044
Releases: master, 9.5, 8.7
Change-Id: Ib3ceaf87ad0541cc8603ef0d02c95e0b4ef43d4e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61577
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[TASK] Modify HTTP proxy description 76/61376/7
Guido Schmechel [Fri, 26 Jul 2019 13:12:21 +0000 (15:12 +0200)]
[TASK] Modify HTTP proxy description

The configuration of an array for a http proxy will now
be described in more detail in the field description.

Resolves: #88835
Releases: master, 9.5
Change-Id: I85dd7b674a605b8741e9bfeea88a135c3edd9868
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61376
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[TASK] Upgrade asset build stack 75/61575/4
Andreas Fernandez [Thu, 29 Aug 2019 11:43:39 +0000 (13:43 +0200)]
[TASK] Upgrade asset build stack

Some tools used to build assets have been updated to recent versions. In
the same run, the assets have benn rebuilt.

For future tasks, uglifyjs is replaced with terserjs.

Executed commands:

  yarn remove grunt-contrib-uglify
  yarn add --dev grunt-terser
  yarn add --dev grunt-contrib-imagemin@^3.1
  grunt build

Resolves: #89042
Releases: master
Change-Id: Ib6fa02e6af03c2b079fc13010c2972369f046991
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61575
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[BUGFIX] Ensure pid is selected for records 74/61574/2
Frank Naegler [Thu, 29 Aug 2019 11:40:44 +0000 (13:40 +0200)]
[BUGFIX] Ensure pid is selected for records

The GridDataService is using the PID of a record. This patch
ensure that the PID is selected while generating the data array.

Resolves: #89041
Related: #89008
Releases: master
Change-Id: I5d134611fd81d94c5618396660b280dd503cc6c1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61574
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Richard Haeser <richard@maxserv.com>
19 months ago[TASK] Disable phone handler for canonical links 61/61561/3
Guido Schmechel [Tue, 27 Aug 2019 22:08:44 +0000 (00:08 +0200)]
[TASK] Disable phone handler for canonical links

As it makes no sense to set a canonical link to a phonenumber, the
phone handler is disabled for canonical links.

Releases: master
Resolves: #89029

Change-Id: I2058dd3b6476c94d1535c8d2dce7924bd2f8fc5a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61561
Tested-by: Richard Haeser <richard@maxserv.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
19 months ago[FEATURE] Separately enable / disable "Add media by URL" and "Select & upload files" 52/60752/7
siwa_pparzer [Tue, 14 May 2019 12:23:54 +0000 (14:23 +0200)]
[FEATURE] Separately enable / disable "Add media by URL" and "Select & upload files"

A new appearance property "fileByUrlAllowed" is used to separately enable / disable
the buttons "Add media by URL" and "Select & upload files".
fileUploadAllowed = 0 now only hides the button "Select & upload files"
fileByUrlAllowed = 0 now hides the button "Add media by URL"
if "elementBrowserType" is set to "file" both values are true by default

Resolves: #84250
Releases: master
Change-Id: I3c3ae34f7514128cb164a5edc8ed028a86af1238
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60752
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
19 months ago[TASK] Migrate EXT:workspaces to TypeScript 30/61530/9
Andreas Fernandez [Fri, 23 Aug 2019 10:01:57 +0000 (12:01 +0200)]
[TASK] Migrate EXT:workspaces to TypeScript

Resolves: #89008
Releases: master
Change-Id: I6d967dd14986fc70631718da88427bff181bf4a9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61530
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
19 months ago[TASK] Deprecate calling registerPlugin with vendor name 22/61522/10
Alexander Schnitzler [Wed, 21 Aug 2019 17:51:20 +0000 (19:51 +0200)]
[TASK] Deprecate calling registerPlugin with vendor name

As Extbase does no longer guess class names from extension
keys and vendor names, method ExtensionUtility::configurePlugin
does no longer accept providing a vendor name.

The same applies as well for parameter $extensionName of method
ExtensionUtility::registerPlugin. The vendor information is
not used at all and must be ommitted in the future.

The former syntax

   \TYPO3\CMS\Extbase\Utility\ExtensionUtility::registerPlugin(
       'TYPO3.CMS.Form',
       'Formframework',
       'Form',
       'content-form',
   );

has to be converted to

   \TYPO3\CMS\Extbase\Utility\ExtensionUtility::registerPlugin(
       'Form',
       'Formframework',
       'Form',
       'content-form',
   );

Releases: master
Resolves: #88995
Change-Id: I247df236d41c24a6ce5f58164f127671237ddf28
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61522
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
19 months ago[TASK] Improve View Helper documentation 70/61570/2
Daniel Siepmann [Wed, 28 Aug 2019 16:20:18 +0000 (18:20 +0200)]
[TASK] Improve View Helper documentation

* Fix syntax issue within TranslateViewHelper.
* Make HtmlentitiesDecodeViewHelper and HtmlentitiesViewHelper easier to
  understand.

Resolves: #89034
Releases: master, 9.5
Change-Id: I53efa0ae3ef81d4b41d13042b096c37a3edcd4f6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61570
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[BUGFIX] Fix documentation rendering of ext:felogin 60/61560/4
Naderio [Tue, 27 Aug 2019 19:32:34 +0000 (19:32 +0000)]
[BUGFIX] Fix documentation rendering of ext:felogin

Missing Data type for `changePasswordNotEqualMessage_stdWrap`, so the
design was broken for this line.

Releases: master, 9.5, 8.7
Resolves: #89027
Change-Id: I09c7e38caa4e00638a91e85264f0f4da73ab6679
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61560
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Sybille Peters <sypets@gmx.de>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
19 months ago[TASK] Change version in Settings.cfg of docs 62/61562/2
Sybille Peters [Wed, 28 Aug 2019 05:30:11 +0000 (07:30 +0200)]
[TASK] Change version in Settings.cfg of docs

Resolves: #89030
Releases: master
Change-Id: Ifeb28b3fc6a1a73ca495dd427eda24a01f6917ee
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61562
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[BUGFIX] Update friendsofphp/php-cs-fixer to 2.15.2 64/61564/6
Andreas Fernandez [Wed, 28 Aug 2019 07:04:56 +0000 (09:04 +0200)]
[BUGFIX] Update friendsofphp/php-cs-fixer to 2.15.2

This patch updates friendsofphp/php-cs-fixer to version 2.15.2 and
applies fixes to the code.

Executed commands:

  composer require --dev "friendsofphp/php-cs-fixer:^2.15.2"
  ./bin/php-cs-fixer fix --config Build/.php_cs

Resolves: #89031
Releases: master, 9.5
Change-Id: I3761ab56f66b6bd3b0fadc2bfa354cf4010b5e43
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61564
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <look@susi.dev>
19 months ago[TASK] Add tests for linkvalidator 18/61518/11
Sybille Peters [Tue, 20 Aug 2019 08:36:20 +0000 (10:36 +0200)]
[TASK] Add tests for linkvalidator

Resolves: #83850
Releases: master, 9.5
Change-Id: I8614c3d65a4c8a51f4db19177d37edb32207b816
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61518
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
19 months ago[BUGFIX] Remove canonicalized pages from XML sitemap 23/61523/5
Richard Haeser [Thu, 22 Aug 2019 12:10:00 +0000 (14:10 +0200)]
[BUGFIX] Remove canonicalized pages from XML sitemap

Pages with a canonical link set in the page properties, will not
be shown in the XML sitemap anymore.

Resolves: #88994
Releases: master,9.5
Change-Id: I3e18ee588d4a4548030b7d065d5884bf1baaa8c7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61523
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
19 months ago[TASK] Introduce a doc block checker job for bamboo 57/61557/7
Alexander Schnitzler [Mon, 26 Aug 2019 10:31:19 +0000 (12:31 +0200)]
[TASK] Introduce a doc block checker job for bamboo

In order to avoid issues creating proper ClassSchema instances
for core classes and in order to have a properly renderable
documentation with phpdocumentor/phpdocumentor, this patch
introduces a new bamboo job that checks all php doc blocks
of classes and their properties and methods.

Releases: master
Resolves: #89023
Change-Id: I13ec766c3ac7c4cea8de84a89e66382ded6d46ba
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61557
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
19 months ago[TASK] Fix class namespace in php doc comment of JsonView 59/61559/3
Daniel Siepmann [Mon, 26 Aug 2019 15:59:03 +0000 (17:59 +0200)]
[TASK] Fix class namespace in php doc comment of JsonView

This would allow everyone else to copy and paste example.

Releases: master, 9.5
Resolves: #89019
Change-Id: I64bc9d9f2db6d92bf264cff9d2172e6cc1ff36ee
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61559
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
19 months ago[BUGFIX] Remove superfluous comma in ActionController 56/61556/3
Alexander Schnitzler [Mon, 26 Aug 2019 07:59:45 +0000 (09:59 +0200)]
[BUGFIX] Remove superfluous comma in ActionController

https://review.typo3.org/c/Packages/TYPO3.CMS/+/61235
introduced a superfluous trailing comma, which leads to an
InvalidArgument exception, thrown by the phpDocumentor annoation parser.

The InvalidArgument exception is actually already handled in
PhpDocPropertyTypeExtractor::getDocBlockFromProperty, but other code
that uses phpdocumentator directly would be affected.

Releases: master
Resolves: #89011
Change-Id: Ia424b76871e0637eeed6a0330f6f408359720bd1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61556
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
19 months ago[TASK] Deprecate internal public properties of TSFE 88/61288/12
Benni Mack [Fri, 19 Jul 2019 12:08:39 +0000 (14:08 +0200)]
[TASK] Deprecate internal public properties of TSFE

Due to e50b1c1acdd5da514a35f837d9b853692bcfa16d
the TypoScriptFrontendController requires four objects
as constructor arguments while keeping maximum
compatibility by fetching fallback information from the
current PSR-7 object or setting data from the legacy arguments.

This allows for the following "internal" public properties
- TSFE->cHash
- TSFE->domainStartPage
- TSFE->cHash_array

to be deprecated.

The hashParameters for calculating the hashBase have been modified:

- "cHash" has been replaced by "dyamicArguments" but contains the same values
- "gr_list" is now called "groupIds"
- "domainStartPage" has been replaced by "site" (identifier of the site)

Resolves: #89001
Releases: master
Change-Id: Iea403e8ced0f5dc012ffd348181afcb7a2053db8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61288
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[TASK] Move CLI bootstrap logic into CommandApplication 49/61349/6
Benni Mack [Thu, 25 Jul 2019 05:18:54 +0000 (07:18 +0200)]
[TASK] Move CLI bootstrap logic into CommandApplication

The CLI-based RequestHandler logic is flawed,
and was used as a bridge between
- CommandLineController (very old, deprecated in TYPO3 v8, removed in TYPO3 v9)
- Extbase Command Controller (removed in TYPO3 v10)
- Symfony Commands

The CommandApplication (EntryPoint for CLI) can now
run the SymfonyApplication directly, and acts as a simple
wrapper now.

Resolves: #88839
Releases: master
Change-Id: I2d4d9b3e1a69be95945dc83f3ec4e0435a58621a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61349
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
19 months ago[TASK] Allow multiple extractor services with the same priority 94/59894/8
Susanne Moog [Thu, 7 Mar 2019 10:23:40 +0000 (11:23 +0100)]
[TASK] Allow multiple extractor services with the same priority

When having multiple extractor services with the same priority one
gets overwritten by the other. As extensions are free to deliver and
declare extractors, this cannot be fixed on 3rd party level.

ExtractorRegistry has been changed to allow registering multiple
extractors with same priority.

Resolves: #64942
Releases: master
Change-Id: I7581a28739246175e80a2985faf7329ef974669c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59894
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Julian Geils <j_geils@web.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
19 months ago[FEATURE] Allow array of handlers in RequestFactory 07/61407/8
Frank Naegler [Fri, 2 Aug 2019 19:18:48 +0000 (21:18 +0200)]
[FEATURE] Allow array of handlers in RequestFactory

Guzzle has the possibility to push custom middleware handlers during
client initialization. With this patch it is now possible to define own
handlers as an array of callables in $GLOBALS['TYPO3_CONF_VARS']['HTTP']['handler'].
The RequestFactory builds a HandlerStack from that array
and injects it into the created client.

Resolves: #88871
Releases: master
Change-Id: I62cb9c58c9ef7f8ce66255eb34b3a0953666cbc2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61407
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
19 months ago[BUGFIX] Fix AnnotationException 17/61517/5
Daniel Huf [Tue, 20 Aug 2019 12:12:31 +0000 (12:12 +0000)]
[BUGFIX] Fix AnnotationException

Doctrine\Common\Annotations\AnnotationException
[Semantical Error] The annotation "@mkdir" in method
TYPO3\CMS\Core\Utility\GeneralUtility::mkdir() was never imported. Did you
maybe forget to add a "use" statement for this annotation?

Releases: master
Resolves: #88986
Change-Id: I8086ce12da8eb4ae942b5d8eb747c8c253dc3b3d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61517
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[TASK] Optimize and cleanup replaceAndAppendScalarValuesRecursive() 15/61215/12
Simon Gilli [Tue, 2 Jul 2019 22:11:25 +0000 (00:11 +0200)]
[TASK] Optimize and cleanup replaceAndAppendScalarValuesRecursive()

This optimizes ArrayUtility::replaceAndAppendScalarValuesRecursive() by
moving parts into new method hasStringKeys and removing other
duplicated code.

Resolves: #88674
Releases: master
Change-Id: Ieb0f57c330c400af94fc85bfd9af725cc8a8fe18
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61215
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[FEATURE] Add api=1 option in VimeoRenderer 18/61418/9
Maik Hagenbruch [Fri, 2 Aug 2019 21:11:14 +0000 (23:11 +0200)]
[FEATURE] Add api=1 option in VimeoRenderer

Adds option to add parameter "api=1" to vimeo video urls.

Resolves: #87525
Releases: master
Change-Id: Ia54fb7a97e4c8dc0c1ccae2f5b65d377a763d2aa
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61418
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[FEATURE] Make default action in DragUploader adjustable 36/61436/6
Frank Naegler [Sun, 4 Aug 2019 15:34:26 +0000 (17:34 +0200)]
[FEATURE] Make default action in DragUploader adjustable

This patch adds a new TSConfig setting to define the default
action in the DragUploader of the file list module.

Resolves: #86670
Releases: master
Change-Id: Iec2bc6da0d932f5d1fb0b5e41451ae870d4136cd
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61436
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
19 months ago[BUGFIX] Use `strpos()` over `strstr()` 45/61445/2
Andreas Fernandez [Mon, 5 Aug 2019 14:32:13 +0000 (16:32 +0200)]
[BUGFIX] Use `strpos()` over `strstr()`

This patch replaces all usages of `strstr()` and its friends where the
existence of a certain substring is checked, but the result isn't used at
all with `strpos()`, which uses less memory.

Resolves: #88922
Releases: master
Change-Id: Ie45589ac9410e22e1b48e82dd8086eadb6d74107
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61445
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[BUGFIX] Set module state only if UC structure is intact 19/61519/5
Andreas Fernandez [Tue, 20 Aug 2019 12:09:25 +0000 (14:09 +0200)]
[BUGFIX] Set module state only if UC structure is intact

In some scenarios it seems the UC of a backend user is malformed and
isn't structured as expected. To circumvent this issue, the UC is
encoded to a JSON string and immediately decoded to a plain array again.

Resolves: #88984
Releases: master, 9.5
Change-Id: I9ebd382f5531bde1b872a75e02fb6fc4c93041ba
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61519
Tested-by: theline <typo3@theline.capella.uberspace.de>
Tested-by: Tobias Wollender <tliegl@gmail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: theline <typo3@theline.capella.uberspace.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
19 months ago[BUGFIX] Bamboo: Generate a full build to determine asset changes 66/60766/5
Andreas Fernandez [Wed, 15 May 2019 17:30:22 +0000 (19:30 +0200)]
[BUGFIX] Bamboo: Generate a full build to determine asset changes

To ensure a frontend build is completely free of any uncommitted
changes, the Bamboo build job checking for an unclean state executes a
full frontend build now.

Resolves: #89000
Releases: master, 9.5, 8.7
Change-Id: I5c8d285171b20753258da3095bc758e539362486
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60766
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[BUGFIX] Disable copying taboverride due to changed source map 28/61528/2
Andreas Fernandez [Thu, 22 Aug 2019 20:22:04 +0000 (22:22 +0200)]
[BUGFIX] Disable copying taboverride due to changed source map

With #86804 the hardcoded sourcemap reference got removed from
taboverrides. Unfortunately, executing `grunt build` copies the original
file from node_modules and basically reverts that very change. For this
reason the file is excluded from the "copy" task to keep the current
state of the file as is.

Resolves: #88999
Related: #86804
Releases: master, 9.5, 8.7
Change-Id: I53e9d39b979ed239bcac96a8d05b7b843622657b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61528
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[TASK] Enable mssql on PHP 7.3 nightly tests 24/61524/3
Susanne Moog [Thu, 22 Aug 2019 12:53:41 +0000 (14:53 +0200)]
[TASK] Enable mssql on PHP 7.3 nightly tests

Resolves: #88996
Releases: master, 9.5, 8.7
Change-Id: Iffbcc174359747b19c715b44bcc5754f426d7b9a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61524
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[BUGFIX] Ensure manually updated slug is saved correctly 82/61482/4
Oliver Bartsch [Fri, 9 Aug 2019 08:46:51 +0000 (10:46 +0200)]
[BUGFIX] Ensure manually updated slug is saved correctly

This fixes the bug, that after updating the slug and clicking
the toggle URL button, the slug isn't updated correctly.

Therefore, if the value of the input and read only field differ
after clicking the toggle button, now the updated value
of the input field is written into the read only and hidden field.

Furthermore after recreating the slug, the new value is now also
written into the input field to be present after clicking
the toogle URL button again. Otherwise the recreated slug would be
discarded on save.

Resolves: #86664
Releases: master, 9.5
Change-Id: I1cd8652618a7c5f2f7154c499ef1653bfed73c53
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61482
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jens Ulrich <jens.ulrich@snk.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Jens Ulrich <jens.ulrich@snk.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[BUGFIX] Avoid double slash in cache directory 99/61499/3
Helmut Hummel [Thu, 15 Aug 2019 13:27:15 +0000 (15:27 +0200)]
[BUGFIX] Avoid double slash in cache directory

When configuring a different cache directory,
the setter is called in SimpleFileBackend, which tries
to add the cache identifier as last directory name.

At this time however the cache identifier is still empty
and the full directory path is composed in setCache anyway.

Resolves: #88961
Releases: 8.7, 9.5, master
Change-Id: I44c99d78e98d951d83666ff51eeea37b90a52302
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61499
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Richard Haeser <richard@maxserv.com>
19 months ago[TASK] Cleanup order by clause in TCA select fields 75/61475/4
Christoph Lehmann [Wed, 7 Aug 2019 23:24:07 +0000 (01:24 +0200)]
[TASK] Cleanup order by clause in TCA select fields

This is a follow up of #88933 and removes all order by clauses
since the default_sortby of a table is respected.

It also changes/unifies default sorting of sys_language and
sys_category to title.

Every system table now as single configuration directive for
the sorting of its records: default_sortby

Resolves: #88933
Releases: master
Change-Id: I42678788c7cde86c918ace2eca1c58bb00b6bbe0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61475
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
19 months ago[BUGFIX] Set module menu state on render time 77/61477/2
Andreas Fernandez [Thu, 8 Aug 2019 08:52:52 +0000 (10:52 +0200)]
[BUGFIX] Set module menu state on render time

The module menu now contains its state whether either the menu itself, or
its module groups are expanded or collapsed. This information is now taken
into account when the markup of the backend viewport is rendered.

With this patch, some AJAX requests done after the backend is initialized
can bre dropped, improving the backend UX since the state of the menus is
correctly handled on render time.

Resolves: #88935
Releases: master, 9.5
Change-Id: I3f3765926d9d3f406af0ee0bc29993d547771853
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61477
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Richard Haeser <richard@maxserv.com>
19 months ago[BUGFIX] Dump processed files from 3rd party FAL-drivers in Install Tool 07/61507/3
Richard Haeser [Fri, 16 Aug 2019 14:33:19 +0000 (16:33 +0200)]
[BUGFIX] Dump processed files from 3rd party FAL-drivers in Install Tool

The configuration of 3rd party FAL-drivers is loaded before checking
for processed files in the Install Tool now. With this change also
processed files of those 3rd party FAL-drivers are deleted.

Resolves: #88970
Releases: master, 9.5
Change-Id: I0e568e3123b7f4cfa6f3fd0246883c91b3477dc5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61507
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
19 months ago[TASK] Add .rst file for 88045 12/61512/3
Oliver Bartsch [Mon, 19 Aug 2019 12:12:10 +0000 (14:12 +0200)]
[TASK] Add .rst file for 88045

Add information about possible workaround configuration
which need to be adapted.

Resolves: #88976
Related: #88045
Releases: master, 9.5
Change-Id: I608038371de450c26e90b348ba3de0dcb4b51e36
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61512
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[TASK] Update phpunit/phpunit to 8.3.3 73/61473/3
Anja Leichsenring [Wed, 7 Aug 2019 14:56:37 +0000 (16:56 +0200)]
[TASK] Update phpunit/phpunit to 8.3.3

commands:

- composer update phpunit/phpunit --with-dependencies
- composer update doctrine/instantiator  phpspec/prophecy
- composer update phpunit/phpunit --with-dependencies

Resolves: #88930
Releases: master
Change-Id: I4e96fd713e655324d67a7e37674bb31396a3b247
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61473
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
19 months ago[BUGFIX] Fallback to empty array if ExportController receives no input 02/61502/2
Andreas Fernandez [Fri, 16 Aug 2019 07:58:30 +0000 (09:58 +0200)]
[BUGFIX] Fallback to empty array if ExportController receives no input

Resolves: #88968
Releases: master
Change-Id: I1cab8a60e5b562376f9ac6bb6836e949bb9b1b50
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61502
Reviewed-by: Josef Glatz <josefglatz@gmail.com>
Reviewed-by: Pascal Querner <pq@paskl.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Pascal Querner <pq@paskl.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[BUGFIX] Incorrect HTTP range specification in Linkvalidator 96/61496/2
Dmitry Dulepov [Wed, 14 Aug 2019 16:35:13 +0000 (19:35 +0300)]
[BUGFIX] Incorrect HTTP range specification in Linkvalidator

Range specifications in HTTP may not include spaces. While many
web servers tolerate them, some return a 416 HTTP error. This
change makes range request from Linkvalidator to follow RFC 7233.

Resolves: #88958
Releases: master, 9.5, 8.7
Change-Id: I06fe31ab9db1a0391853f21ce28cb92be0b5656d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61496
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[BUGFIX] Process t3:// link resources correctly 98/61498/9
Oliver Hader [Wed, 14 Aug 2019 17:33:12 +0000 (19:33 +0200)]
[BUGFIX] Process t3:// link resources correctly

* t3://email?email=oliver@typo3.org (be greedy about missing mailto:)
* t3://file?identifier=1:/logo.png (not implemented since no integer)

Besides that according test cases are added in order to ensure the
basic behavior of link handling in a TypoScript frontend rendering
scenario using t3:// link resources.

Resolves: #88960
Releases: master, 9.5, 8.7
Change-Id: I9a1f47f2eaaacc4368a1ca3e1a4006a8248e654e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61498
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[BUGFIX] Fix typos in PHPDoc, rst file and template 86/61486/3
Oliver Bartsch [Mon, 12 Aug 2019 08:01:33 +0000 (10:01 +0200)]
[BUGFIX] Fix typos in PHPDoc, rst file and template

Fixes following typos:
- Replace 'ite_language' with 'site_language' in SiteTcaInline
- Replace 'langauges' with 'languages' in rst file
- Replace 'sytem' with 'system' in CreateAdmin template

Resolves: #88948
Releases: master, 9.5
Change-Id: Iaca4ad7eb7647508e3de66004c288efe84be4b0b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61486
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Susanne Moog <look@susi.dev>
19 months ago[BUGFIX] Require symfony/finder 4.3 91/61491/3
Andreas Fernandez [Tue, 13 Aug 2019 08:44:53 +0000 (10:44 +0200)]
[BUGFIX] Require symfony/finder 4.3

The bugfix for #88883 makes use of natural sorting via Symfony's Finder
component. Since TYPO3 depends on version 4.1, this won't work since the
feature was introdcuced in version 4.2.

This patch updates symfony/finder to version 4.3.

Executed composer command:

  composer require symfony/finder:^4.3

Resolves: #88953
Related: #88883
Releases: master
Change-Id: Ia4c3b246153d763f640de3dc1deeed6b40c601f4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61491
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
20 months ago[BUGFIX] Use workspace overlays in Record Path 98/60498/2
Benni Mack [Wed, 17 Apr 2019 18:50:49 +0000 (20:50 +0200)]
[BUGFIX] Use workspace overlays in Record Path

When in workspace, the workspaced version of the "bread crumb"
should be shown as rootline / page path in all modules.

Very specifically, the workspace module now shows this properly.

Resolves: #36285
Releases: master, 9.5
Change-Id: I1419ccb781315632eb28e194add4db20d0d76d15
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60498
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
20 months ago[BUGFIX] Increase memory cost of argon2i and force testing mariadb 10.3 83/61483/5
Andreas Fernandez [Fri, 9 Aug 2019 09:11:58 +0000 (11:11 +0200)]
[BUGFIX] Increase memory cost of argon2i and force testing mariadb 10.3

Due to security reasons, PHP's default memory_cost of argon2i has been
increased from 16384 to 65536:

  https://bugs.php.net/bug.php?id=78269

We shouldn't lower the factory default, thus this patch alignes the
hashing implementation.

Furthermore, mariadb 10.4 currently crashes with the functional
tests. The patch forces 10.3 for now to make bamboo green again.

Resolves: #88942
Releases: master, 9.5
Change-Id: I3650a709d92d5807058b628390ced7c1208ec06a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61483
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
20 months ago[BUGFIX] Ensure test environment is bootstrapped for cache backend tests 78/61478/4
Andreas Fernandez [Thu, 8 Aug 2019 11:33:47 +0000 (13:33 +0200)]
[BUGFIX] Ensure test environment is bootstrapped for cache backend tests

The cache backends tests need a bootstrapped test environment, since vital
parts are not booted at all, e.g. the Environment is undefined.

For this reason, the parent `setUp()` method is now called, albeit this
was not required previously.

Resolves: #88937
Releases: master, 9.5
Change-Id: Iaced6421e2042482c35c5b0d7a32eb9fe1a6c895
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61478
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
20 months ago[BUGFIX] Use calling class name for logger initialization 79/61479/3
Anja Leichsenring [Thu, 8 Aug 2019 12:01:28 +0000 (14:01 +0200)]
[BUGFIX] Use calling class name for logger initialization

Static class binding via `static::class` leads to the correct class name
in inherited classes.

Resolves: #88938
Relates: #88775
Relates: #87820
Releases: master, 9.5
Change-Id: I9a866fa26d3e7100d0db694237142f1449c68391
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61479
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
20 months ago[BUGFIX] Make sure the baseVariants are respected 75/61375/4
Guido Schmechel [Fri, 26 Jul 2019 10:17:20 +0000 (12:17 +0200)]
[BUGFIX] Make sure the baseVariants are respected

In the ContentObjectRenderer there is the possibility to get
the Site Configuration. Here a simple array which is read out.

In the case of baseUrl, the baseVariants are now considered
with the possible conditions.

Resolves: #88847
Releases: master, 9.5
Change-Id: I8db7e9264e82d4021ea8fe63b690eb2ec09288e4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61375
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>