Packages/TYPO3.CMS.git
6 weeks ago[BUGFIX] Make current folder selectable for folder links 52/62852/4
Markus Klein [Sun, 12 Jan 2020 15:22:56 +0000 (16:22 +0100)]
[BUGFIX] Make current folder selectable for folder links

This allows to create a folder link to the currently selected
folder in the folder browser.

Resolves: #72527
Releases: master, 9.5
Change-Id: Ifbbfbd744965f8ca8e78f116ea89e3b9d8396d59
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62852
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
6 weeks ago[BUGFIX] Improved visibility error message in install tool 98/60398/5
Sebastian Rosskopf [Fri, 5 Apr 2019 14:20:58 +0000 (16:20 +0200)]
[BUGFIX] Improved visibility error message in install tool

Prevent double scrolling bars in error messages.
For example in install tool modals.

Resolves: #88093
Releases: master, 9.5
Change-Id: I32b70197cede4f652c864774bcbf24cea5120d90
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60398
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Steffen Frese <steffenf14@gmail.com>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
6 weeks ago[DOCS] Update TypoLink example inside of ViewHelper 68/61968/4
Tizian Schmidlin [Mon, 14 Oct 2019 09:47:11 +0000 (11:47 +0200)]
[DOCS] Update TypoLink example inside of ViewHelper

Since TYPO3 8 the way TypoLinks are represented has changed.
The new form is t3://page?uid= as prefix for page links.
The documentation of TypoLinkViewHelper is updated to reflect this.

Resolves: #89408
Releases: master, 9.5

Change-Id: I093c3db171163cff9de3a02a715784241724a2c1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61968
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Steffen Frese <steffenf14@gmail.com>
Tested-by: Felix P. <f.pachowsky@neusta.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Felix P. <f.pachowsky@neusta.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
6 weeks ago[TASK] Avoid superfluous Reflection invocation in tests 44/62844/3
Oliver Hader [Fri, 10 Jan 2020 15:31:24 +0000 (16:31 +0100)]
[TASK] Avoid superfluous Reflection invocation in tests

Resolves: #90086
Releases: master, 9.5
Change-Id: Ibe5eb0db866933984a07ac5f5b82010a0ae4698b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62844
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
6 weeks ago[BUGFIX] Show argument validation results in scheduler list 56/62756/2
Markus Klösges [Sat, 21 Dec 2019 18:35:39 +0000 (19:35 +0100)]
[BUGFIX] Show argument validation results in scheduler list

The scheduler module now shows validation errors for execute console
commands as messages in the backend. Previously changing the
configuration of a console commands arguments could lead to an exception
when the currently selected set of arguments was not parseable anymore
with the new configuration.
In some circumstances it was also possible to save a task without
supplying all required arguments, which rendered the backend module
non-functional because of the exception.

Catching the exception and providing the error message helps spotting
and fixing these errors without having to manipulate the database
directly.

Resolves: #89774
Releases: master, 9.5
Change-Id: I838e90bdd48f7146863630fa7dd09776459393d2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62756
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
6 weeks ago[BUGFIX] Ensure StaticRangeMapper applies zero prefix to internal map 64/62864/3
Oliver Hader [Mon, 13 Jan 2020 14:59:43 +0000 (15:59 +0100)]
[BUGFIX] Ensure StaticRangeMapper applies zero prefix to internal map

StateRangeMapper routing aspects defined like the following did not use
leading zero (0) prefixes due to internal number conversion to integer:

    month:
      type: StaticRangeMapper
      start: '01'
      end: '12'

Zero prefixes are applied in case they were explicitly given in either
start or end property for StaticRangeMapper settings.

Resolves: #87730
Releases: master, 9.5
Change-Id: I1846d9faa4843834d7175173f5ca9db5b1445ca5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62864
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Tested-by: Felix P. <f.pachowsky@neusta.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Felix P. <f.pachowsky@neusta.de>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Susanne Moog <look@susi.dev>
6 weeks ago[TASK] Refactor route enhancer tests 15/62815/19
Oliver Hader [Fri, 3 Jan 2020 14:36:33 +0000 (15:36 +0100)]
[TASK] Refactor route enhancer tests

* replaces nested array logic with domain objects
* introduces perputation logic (instead of foreach/foreach/foreach/...)
* introduced common variables container compiled when executing tests
  (allows to declare arbitrary behaviour without hardcoding values)
* applies more specific page type decorators in request tests

Resolves: #90053
Releases: master, 9.5
Change-Id: Id145de4aafc419ab70cd60fb8a439144307a0cec
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62815
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Felix P. <f.pachowsky@neusta.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Felix P. <f.pachowsky@neusta.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
6 weeks ago[TASK] Cleanup and streamline felogin config/class files 77/62677/3
Jan Stockfisch [Mon, 16 Dec 2019 17:13:02 +0000 (18:13 +0100)]
[TASK] Cleanup and streamline felogin config/class files

Resolves: #89969
Releases: master
Change-Id: Ic813e072904c8a078567bd9a067d9787f6ebf856
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62677
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
6 weeks ago[TASK] Add index to l10n_source field 34/62534/3
Riny van Tiggelen [Thu, 5 Dec 2019 07:47:51 +0000 (08:47 +0100)]
[TASK] Add index to l10n_source field

The database field which is created based on TCA setting
translationSource, now automatically gets an index.
This improves the performace in (for example) the
migration from pages_language_overlay to pages.

Resolves: #89853
Releases: master, 9.5
Change-Id: I23ba8254158250249422b9fb0d20975372a11dbd
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62534
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Jonas Eberle <flightvision@googlemail.com>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Steffen Frese <steffenf14@gmail.com>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Jonas Eberle <flightvision@googlemail.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
6 weeks ago[BUGFIX] Directly resolve links to pages of type External URL 30/62630/3
Benni Mack [Fri, 13 Dec 2019 21:39:08 +0000 (22:39 +0100)]
[BUGFIX] Directly resolve links to pages of type External URL

HMENU provides a way to directly create the external link
if a page is of type "External URLs" but typolink does not
resulting in

a) more bandwidth / hits for TYPO3 when using typolink
b) different results / expectations.

The patch makes typolink handle external URLs like HMENU.

Resolves: #90008
Releases: master
Change-Id: I712e79f2a399b50d9781bca75f623a419a29f09e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62630
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
6 weeks ago[BUGFIX] Only include translated pages in sitemap 65/62865/4
Daniel Goerz [Mon, 13 Jan 2020 17:16:39 +0000 (18:16 +0100)]
[BUGFIX] Only include translated pages in sitemap

When generating the list of pages for a sitemap in
an alternative language only pages are considered that
are actually translated or covered by the fallback
strategy.

Additionally the method generateItems() in the internal
class PagesXmlSitemapDataProvider is now protected.

Resolves: #90046
Releases: master, 9.5
Change-Id: I54557e0485ae7791ac51fa975991d6d9c9211b61
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62865
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Richard Haeser <richard@maxserv.com>
6 weeks ago[TASK] Remove custom InvalidArgumentException 62/62862/3
Markus Klein [Mon, 13 Jan 2020 12:18:40 +0000 (13:18 +0100)]
[TASK] Remove custom InvalidArgumentException

The name clash with the PHP native exception is not beneficial.
We replace it with \InvalidArgumentException.

Resolves: #90101
Releases: master
Change-Id: Icc53bcca2dcc24352f4edd4f2e9ef66df7bdfdd5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62862
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Felix P. <f.pachowsky@neusta.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Felix P. <f.pachowsky@neusta.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
6 weeks ago[BUGFIX] Allow resolving unmapped type GET parameters with PageTypeDecorator 83/62383/4
Benni Mack [Fri, 22 Nov 2019 16:28:39 +0000 (17:28 +0100)]
[BUGFIX] Allow resolving unmapped type GET parameters with PageTypeDecorator

When the PageTypeDecorator is used for routing, currently ALL available
typeNums must be registered, otherwise links to pages with a typeNum
just get their type removed (fallback to default).

A new check is added when creating links (resolving these URLs with
a GET type= parameter works just fine) for skipping unmapped arguments
when decorating.

Resolves: #87817
Resolves: #88836
Releases: master, 9.5
Change-Id: I252cf80de2befed8396cc93b1bc737d77aa18b31
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62383
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
6 weeks ago[BUGFIX] Add language flags to sys category TCA config 60/62860/2
Joerg Boesche [Mon, 13 Jan 2020 10:02:08 +0000 (11:02 +0100)]
[BUGFIX] Add language flags to sys category TCA config

The sys_category TCA configuration behavior is now the same as in tt_content.
Flags and labels for the languages in the select single dropdown.

Resolves: #89607
Releases: master, 9.5
Change-Id: I5a4c2df7294b699136b62cbf4f68d2ceeae43b8e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62860
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Steffen Frese <steffenf14@gmail.com>
Tested-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
6 weeks ago[BUGFIX] Preserve order of select items in FormEngine 56/62856/4
Markus Klein [Sun, 12 Jan 2020 18:02:51 +0000 (19:02 +0100)]
[BUGFIX] Preserve order of select items in FormEngine

If a select field is comprised of static and dynamic
(database relation) values the order of items stored in
database is preserved when showing the select field.

Resolves: #87672
Releases: master, 9.5, 8.7
Change-Id: I95ed9d523f68eb106c22bbbcd14e60a17a2c0293
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62856
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Felix P. <f.pachowsky@neusta.de>
Tested-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Felix P. <f.pachowsky@neusta.de>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
6 weeks ago[BUGFIX] Only show translate button for available languages 54/62854/2
Daniel Goerz [Sun, 12 Jan 2020 16:06:38 +0000 (17:06 +0100)]
[BUGFIX] Only show translate button for available languages

The list module now takes the available SiteLanguages
into account when rendering the buttons for creating new
translations of records. If a language gets deleted from
the site configuration it is no longer possible to create
record translations to this language.

Resolves: #86662
Releases: master, 9.5
Change-Id: If03598fbb63496d36c93cd832cbdb3028b5e32e1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62854
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
6 weeks ago[DOCS] Document request.getPageArguments() in TS conditions 58/62858/2
Daniel Goerz [Sun, 12 Jan 2020 18:42:02 +0000 (19:42 +0100)]
[DOCS] Document request.getPageArguments() in TS conditions

Resolves: #90099
Releases: master, 9.5
Change-Id: Ia3917f8a33aa6c76c20cbcc5e107546520113ab3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62858
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Susanne Moog <look@susi.dev>
6 weeks ago[TASK] Add a function to safely traverse arrays in TS conditions 08/61708/4
Markus Klein [Sat, 14 Sep 2019 21:40:56 +0000 (23:40 +0200)]
[TASK] Add a function to safely traverse arrays in TS conditions

Example:
[traverse(request.getQueryParams(), 'tx_news_pi/news') > 0]

Resolves: #89176
Releases: master, 9.5
Change-Id: Ic589f68382951c203afa5ad6a7bc16fbddbc20b2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61708
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
6 weeks ago[BUGFIX] Handle missing TSFE gracefully in TS conditions 29/59129/7
Georg Ringer [Wed, 12 Dec 2018 22:58:39 +0000 (23:58 +0100)]
[BUGFIX] Handle missing TSFE gracefully in TS conditions

A condition like [getTSFE().id == 1] is evaluated in BE as well
and logged an error 'Unable to get a property on a non-object'.

This patch ensures that conditions based on getTSFE() are
treated gracefully and are evaluated to false.

Resolves: #87021
Releases: master, 9.5
Change-Id: If56a8b7bd66b9f7e66bdc8ce5f56c8df890cf655
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59129
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
6 weeks ago[TASK] Remove unused EditToolbarService 53/62853/4
Susanne Moog [Sun, 12 Jan 2020 15:58:18 +0000 (16:58 +0100)]
[TASK] Remove unused EditToolbarService

As feedit has been removed from the core,
EditToolbarService is no longer in use.
As it was marked as internal it is removed
without further notice.

Resolves: #90098
Releases: master
Change-Id: I5e8a622c5581e46539afe43a1aed3486c6d5ae11
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62853
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
6 weeks ago[BUGFIX] Do not pass extTarget by reference 52/62752/2
Susanne Moog [Thu, 19 Dec 2019 16:41:23 +0000 (17:41 +0100)]
[BUGFIX] Do not pass extTarget by reference

As config.extTarget might not be set, passing
it by reference results in the string "< config.extTarget"
being passed instead - which will not evaluate to empty
therefor breaking the fallback chain.

Resolves: #89994
Releases: master, 9.5
Change-Id: Ice368e3d139309b32fb886538ef69437f62b3cc7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62752
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
6 weeks ago[BUGFIX] Use correct labels for create folder form in folder browser 50/62850/6
Markus Klein [Sun, 12 Jan 2020 14:56:30 +0000 (15:56 +0100)]
[BUGFIX] Use correct labels for create folder form in folder browser

The labels have been moved around before and these place have been
forgotten to be updated.

Resolves: #90096
Related: #87882
Releases: master
Change-Id: I738e7b5230ed300449e25acedc4f06fccdd588d5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62850
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
6 weeks ago[BUGFIX] Allow sys_file_metadata to be translatable 19/61419/6
Volker Kemeter [Fri, 2 Aug 2019 21:30:37 +0000 (23:30 +0200)]
[BUGFIX] Allow sys_file_metadata to be translatable

Since sys_file_metadata records are stored on pid=0,
there is no site configuration available. This situation is
similar to be_users.limitToLanguage feature, where
all languages of all sites need to be visible (depending
on the backend user rights).

This patch adds an option for the TranslationConfigurationProvider
to render all languages of all sites as a combined list
if the given pageId is 0 (based on the current user rights).

Resolves: #88897
Releases: master
Change-Id: I14b1bb6ae5c8577571cf5fa7bc2da1c1824c0f58
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61419
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
6 weeks ago[BUGFIX] DefaultTcaSchema must not create SQL for tables not requested 54/62154/7
Markus Klein [Tue, 29 Oct 2019 13:32:55 +0000 (14:32 +0100)]
[BUGFIX] DefaultTcaSchema must not create SQL for tables not requested

The DefaultTcaSchema::enrich() function dynamically adds TCA-defined
ctrl-fields to the SQL schema definition for a provided set of tables.

The function used to add these definition for any table that is defined
in TCA, independent whether the table actually exists in any
ext_tables.sql file.
While this behaviour is no problem under the assumption that the
function is always called with the content of all ext_tables.sql files,
this is a problem if the function is called with only a subset of those
ext_tables.sql files. One example is the "extension manager tables"
upgrade in the Install Tool.

Despite the fact that the function was documented that it needs to be
called with the full set of tables, it actually is not strictly
necessary to do so.

This patch changes the requirement for the enrich() function and
changes the behaviour to not dynamically create tables if those are
found in TCA.

Technical detail to the reported bug:
The table definitions created by this class are usually overruled by
whatever might be defined in an ext_tables.sql file. In case of the
upgrade wizard (where only extension manager tables are requested) the
table definitions for all TCA tables were created based on the best
practice suggestions from the core. If the present DB schema (created by
the real ext_tables.sql files) mismatched those suggested definitions a
DB schema change was proposed, hence the wizard kept popping up.

Resolves: #89535
Releases: master, 9.5
Change-Id: I78594f1ee0878e8d3f5606901d0abb7fe0023059
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62154
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
6 weeks ago[TASK] Use new translation server 47/62747/6
Georg Ringer [Wed, 18 Dec 2019 21:16:31 +0000 (22:16 +0100)]
[TASK] Use new translation server

Remove the feature switch `betaTranslationServer` and use the new
translation server by default.

Resolves: #89992
Releases: master
Change-Id: Iab61c913d1a6df3cc1b509e731d30616392c43a3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62747
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
6 weeks ago[BUGFIX] Respect line breaks in media's description 29/62629/3
Georg Ringer [Fri, 13 Dec 2019 19:24:12 +0000 (20:24 +0100)]
[BUGFIX] Respect line breaks in media's description

As the description is using a textarea element in the backend,
editors can add a multi-line text.
The line breaks should be shown in the frontend as well by using
f:format.nl2br.

Resolves: #89611
Releases: master
Change-Id: Ia2b1b2ef896004b1ec91a1719d48826efdc3fb91
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62629
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
6 weeks ago[BUGFIX] Do not use the removed <i:constant> viewhelper anymore 38/62838/3
Benni Mack [Fri, 10 Jan 2020 08:01:23 +0000 (09:01 +0100)]
[BUGFIX] Do not use the removed <i:constant> viewhelper anymore

In the environment module, the removed <i:constant> viewhelper
is still referenced, which can easily be used by assigning
the proper variable to Fluid.

This change was merged last week due to the TYPO3_version
logic.

Resolves: #90077
Related: #90007
Releases: master
Change-Id: Ie3ccd03b757303e253a71bea26c60406552e3d5e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62838
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
6 weeks ago[BUGFIX] Fix OptimizeDatabaseTableTask for PDO and MySQLi 41/62841/2
Manuel Selbach [Fri, 10 Jan 2020 13:34:10 +0000 (14:34 +0100)]
[BUGFIX] Fix OptimizeDatabaseTableTask for PDO and MySQLi

With this change $connection::query() is used instead of
$connection::exec() which can not be used for statements
that return results, see:

https://www.php.net/manual/de/pdo.exec.php#61702

Resolves: #82686
Releases: master, 9.5, 8.7
Change-Id: Ic4b2cc8caec0bc74ffa730b09d03ca0009ca1751
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62841
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
6 weeks ago[TASK] Move constant declaration to class constants 24/62624/9
Benni Mack [Fri, 13 Dec 2019 15:24:57 +0000 (16:24 +0100)]
[TASK] Move constant declaration to class constants

Using Class constants instead of constants that are defined during
runtime has the following benefits:

- Naming can be made more consistent (and separated)
- Speeding up requests where the constants are not needed
- Benefit from Opcaching of class loading instead of dynamic runtime definition
- Testing framework has less "bootstrap" to do

This affects the following constants:
- TYPO3_copyright_year
- TYPO3_URL_GENERAL
- TYPO3_URL_LICENSE
- TYPO3_URL_EXCEPTION
- TYPO3_URL_DONATE
- TYPO3_URL_WIKI_OPCODECACHE

The constants are now deprecated.

In addition, the "Typo3Copyright" class is now called "TYPO3Information".

Resolves: #89866
Releases: master
Change-Id: I607c90cb281179bda9875504d258daefd3471868
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62624
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
6 weeks ago[BUGFIX] Do not reference EventDispatcher in TYPO3 Core 78/62778/7
Benni Mack [Sat, 28 Dec 2019 22:33:59 +0000 (23:33 +0100)]
[BUGFIX] Do not reference EventDispatcher in TYPO3 Core

With Dependency Injection, the new PSR-14 based
EventDispatcher, built into TYPO3 Core should never
be exposed to our core code, since we should always
reference the EventDispatcherInterface. We do this
in almost all cases, except for a few places where
we introduced PSR-14 before DI.

Resolves: #90034
Releases: master
Change-Id: I59e74333360c98b3c2e16c1b3df6fbd8bbf450f0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62778
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
6 weeks ago[TASK] Clean up RelationHandler variable assignments 30/62830/3
Benni Mack [Wed, 8 Jan 2020 08:01:27 +0000 (09:01 +0100)]
[TASK] Clean up RelationHandler variable assignments

This change cleans up some RelationHandler code:
- Working with true boolean inside RelationHandler for getValueArray()
- RelationHandler->MM_oppositeFieldConf is an array, but declared wrongly
as string (since forever!)
- detecting the MM_oppositeTable property should not need a $tmp variable,
  but using a direct assignment - and unset() is not needed due to PHP7s memory management
- internal $isSet flags should be boolean, instead of a number

Resolves: #90066
Releases: master
Change-Id: Ifff2a016a7be945ba6a1dd265e06b1e52bee5de7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62830
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 weeks ago[BUGFIX] Check return value of inet_pton in IpAnonymizationUtility 33/62833/4
Georg Ringer [Wed, 8 Jan 2020 21:03:05 +0000 (22:03 +0100)]
[BUGFIX] Check return value of inet_pton in IpAnonymizationUtility

The method inet_pton returns false if the provided IP address is
invalid. This needs to be checked to avoid errors.

Resolves: #90059
Releases: master, 9.5, 8.7
Change-Id: Ic3c7955eb64aff723b31862ef9c7c95e31a098b7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62833
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
6 weeks ago[BUGFIX] Correctly display the CGI environment in Environment module 37/62837/2
Benni Mack [Fri, 10 Jan 2020 07:58:01 +0000 (08:58 +0100)]
[BUGFIX] Correctly display the CGI environment in Environment module

During the TYPO3 v9 install tool refactoring, a simple PHP array syntax
mistake did not correctly set the fluid variable "systemInformationCgiDetected"
which always resulted in not running in a CGI environment.

The change adapts the array variable assigment.

Resolves: #87320
Releases: master, 9.5
Change-Id: I2368ff033a6318d67c9153be20816d13ad8bd08d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62837
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Michael Schams <typo3@2018.schams.net>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Michael Schams <typo3@2018.schams.net>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[BUGFIX] Ensure fresh logger instance in scheduler tasks 06/60306/8
Helmut Hummel [Thu, 21 Mar 2019 18:28:30 +0000 (19:28 +0100)]
[BUGFIX] Ensure fresh logger instance in scheduler tasks

The AbstractTask always had methods setScheduler and
unsetScheduler to avoid serialization of the scheduler instance.
These methods are called by the scheduler API before serializing
(unset) and after unserializing (set).

Use these methods in favor of the __sleep and __wakup calls
to avoid issues with third party subclasses that implement these methods
and to make sure tasks that are already serialized with an outdated
logger instance are properly updated on next run without the need
to clean them up manually.

Releases: master, 9.5
Resolves: #86941
Resolves: #87780
Change-Id: I140973fa952c5c41b8eac966ba3b541420ec060b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60306
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
6 weeks ago[BUGFIX] Properly set Reply-To address in mailer 36/62836/4
Benni Mack [Thu, 9 Jan 2020 15:41:42 +0000 (16:41 +0100)]
[BUGFIX] Properly set Reply-To address in mailer

The symfony/mailer instance needs an email address in the form
of new Address($emailAddress, $name);

The MailUtility::getSystemReplyTo() returns a strange (Swiftmailer-like)
syntax, which was implemented wrong when migrating to Symfony/Mailer.

The change switches the constructor arguments to be used in
the correct order ($email, $name).

Resolves: #90040
Releases: master
Change-Id: I2f2bfc67b47fdd1327895c96bd27b2d481805a1b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62836
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
6 weeks ago[TASK] Clean up BasicFileUtility 64/62764/5
Benni Mack [Fri, 27 Dec 2019 07:17:41 +0000 (08:17 +0100)]
[TASK] Clean up BasicFileUtility

The BasicFileUtility was very important before the FAL API was introduced
in TYPO3 v6. Since TYPO3 v10, the last important parts have been
removed, which is why the PHP class is now marked as internal.

In addition, several internal methods have been removed, the
"setFileExtensionPermission" method is still there in order to avoid
PHP Fatal Errors so extensions can stay compatible with TYPO3 v9 and TYPO3 v10.

Resolves: #90020
Releases: master
Change-Id: I1c6903f914722c5ddca79dd16f5766984f8c10db
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62764
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
6 weeks ago[TASK] Move TYPO3_version constant to a dedicated class 40/62740/8
Benni Mack [Wed, 18 Dec 2019 12:48:50 +0000 (13:48 +0100)]
[TASK] Move TYPO3_version constant to a dedicated class

To optimize TYPO3 for Opcaching and speeding up performance,
as well as simplyfing the bootstrap (also for the testing framework)
the constants
* TYPO3_version
* TYPO3_branch
are moved to a new PHP class "Typo3Version".

This reduces the necessity to define the constants, and since
TYPO3 Bootstrap continues to use the class, the constants
are defined in the constructor for TYPO3 v10, and will be removed
in TYPO3 v11.

Resolves: #90007
Releases: master
Change-Id: I18942023c0e234a328d45f724a6b3092c801982c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62740
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
6 weeks ago[TASK] Migrate linkvalidator results from serializable to json storage 31/62631/2
Benni Mack [Fri, 13 Dec 2019 22:14:25 +0000 (23:14 +0100)]
[TASK] Migrate linkvalidator results from serializable to json storage

LinkAnalyzer now stores the response as JSON instead of PHP serialize.

A fallback mechanism when unpacking uses unserialize() as fallback
to keep records in the database.

Resolves: #89944
Releases: master
Change-Id: Ic3a2ba058d916936cc5c46a0a8e279bc07bfe60c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62631
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Sybille Peters <sypets@gmx.de>
Tested-by: Jonas Eberle <flightvision@googlemail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Jonas Eberle <flightvision@googlemail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
7 weeks ago[TASK] Remove unused property in RelationHandler 29/62829/3
Benni Mack [Tue, 7 Jan 2020 22:45:54 +0000 (23:45 +0100)]
[TASK] Remove unused property in RelationHandler

RelationHandler->dbPaths was added in 2003 by kasper,
but NEVER ever used since then in TYPO3 Core, or does it
serve any purpose.

So this property can safely be removed.

Resolves: #90065
Releases: master
Change-Id: I361925e68e1025436799ceb97c7e1156d45e250a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62829
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
7 weeks ago[TASK] Refactor & streamline TypoLinkViewHelper implementations 75/62775/5
Oliver Hader [Fri, 27 Dec 2019 20:12:19 +0000 (21:12 +0100)]
[TASK] Refactor & streamline TypoLinkViewHelper implementations

* avoid assigning and forwarding multiple variables
* preparation for further enhancements of view helpers
* Uri UnitTest case mostly tested TypoLinkCodecService
  (it was a FunctionalTest) and to 1/3 a simple additionalParams case
* Link UnitTest case mostly tested TypoLinkCodecService
  (it was a FunctionalTest)

Resolves: #90022
Releases: master
Change-Id: If65e42d4ca8085855f3f335d1eb2604be9a36fe0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62775
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
7 weeks ago[TASK] Add max_line_length to .editorconfig for rst files 18/62818/2
Chris Müller [Sat, 4 Jan 2020 18:28:03 +0000 (19:28 +0100)]
[TASK] Add max_line_length to .editorconfig for rst files

The maximum line length of documentation files (80 characters)
should be reflected in the .editorconfig as described in
https://docs.typo3.org/m/typo3/docs-how-to-document/master/en-us/GeneralConventions/CodingGuidelines.html#line-length

Resolves: #90054
Releases: master, 9.5
Change-Id: Ib1c3f2f2fbae999b7d157949f1a59876c2ff451d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62818
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
7 weeks ago[TASK] Use PermutationUtility::meltStringItems in test cases 21/62821/4
Oliver Hader [Mon, 6 Jan 2020 10:34:53 +0000 (11:34 +0100)]
[TASK] Use PermutationUtility::meltStringItems in test cases

Resolves: #90057
Releases: master, 9.5
Change-Id: Ifee8153c4f49b7fdde544a51bc19ee7d6e21b323
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62821
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
7 weeks ago[DOCS] Update Deprecation 79440 Changelog entry 22/62822/5
Naderio [Mon, 6 Jan 2020 11:40:35 +0000 (11:40 +0000)]
[DOCS] Update Deprecation 79440 Changelog entry

Correct formatting of codeblock in "Link Browser" description.

Releases: master, 9.5, 8.7
Resolves: #90058
Change-Id: Ifbfff20a38cadef84e7e9c500fb846f2bbdccd3b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62822
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Rudy Gnodde <rudy@famouswolf.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Rudy Gnodde <rudy@famouswolf.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 weeks ago[TASK] Introduce PermutationUtility 19/62819/7
Oliver Hader [Sat, 4 Jan 2020 20:03:26 +0000 (21:03 +0100)]
[TASK] Introduce PermutationUtility

Permutations are currently used in test cases - however it would
be possible to make use of this functionality in regular sources
as well. That's why corresponding methods are moved into a new
PermutationUtility implementation.

Resolves: #90055
Releases: master, 9.5
Change-Id: I05d978ada2021c7db1b7abeb8a21a825472ae8cc
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62819
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
8 weeks ago[FEATURE] Add argument "fields" to editRecord ViewHelpers 98/62298/8
Sybille Peters [Mon, 11 Nov 2019 15:24:58 +0000 (16:24 +0100)]
[FEATURE] Add argument "fields" to editRecord ViewHelpers

The <be:link.editRecord> and <be:url.editRecord> now have an option
argument "fields" which can be used to limit the edit form to only
these fields (instead of the entire record).

The fields should be passed in a comma separated list.

Resolves: #89644
Releases: master
Change-Id: I28913c072578aacd1da95c3bacebea35f8958bac
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62298
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Daniel Siepmann <coding@daniel-siepmann.de>
Reviewed-by: Benni Mack <benni@typo3.org>
8 weeks ago[BUGFIX] Return integer value from Command::execute() 80/62780/2
Michael Schams [Sun, 29 Dec 2019 05:32:05 +0000 (16:32 +1100)]
[BUGFIX] Return integer value from Command::execute()

Symfony version 5 expects an integer as the return value from
Command::execute() in the Command class. This bugfix returns 0 to
satisfy Symfony version 5 requirements.

Resolves: #90032
Releases: master
Change-Id: Id759707091f6695388b19b9d081beaf8c137c3cf
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62780
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
8 weeks ago[BUGFIX] Use correct variable naming for PID value in DataHandler 12/62812/3
Benni Mack [Tue, 31 Dec 2019 11:49:04 +0000 (12:49 +0100)]
[BUGFIX] Use correct variable naming for PID value in DataHandler

The change of issue #90019 introduced a mis-spelling in hte variable naming,
where the variable was named "$tscPid" but the original code was "$tscPID"
which should be used as well.

Resolves: #90041
Releases: master
Change-Id: Idaad179968fb4b0953f7b12a8c7660793797cf02
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62812
Tested-by: Rudy Gnodde <rudy@famouswolf.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Rudy Gnodde <rudy@famouswolf.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
8 weeks ago[TASK] Avoid starting superfluous PHP session 73/60173/7
Oliver Hader [Mon, 11 Mar 2019 23:33:37 +0000 (00:33 +0100)]
[TASK] Avoid starting superfluous PHP session

TYPO3 backend does not need PHP session handling since
it has its own session handling implementation.

Resolves: #90024
Releases: master
Change-Id: I9d8ccaf38c62b86d3b6945b2c631a2602b4aa73f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60173
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
8 weeks ago[TASK] Clean up Page Permission handling in DataHandler 63/62763/6
Benni Mack [Fri, 27 Dec 2019 07:03:41 +0000 (08:03 +0100)]
[TASK] Clean up Page Permission handling in DataHandler

TYPO3's page permissions are based on five fields and a bitset.

- perms_userid
- perms_groupid
- perms_user
- perms_group
- perms_everybody

For permissions of a page there is
- show page ("show")
- edit page properties ("edit page")
- edit page contents / records ("edit content")
- delete page ("delete")
- create new subpages ("new")

In addition, these can be pre-set globally or via PageTSconfig.

The DataHandler currently uses a mix between strings and integers
for defining these values.

A new PagePermissionAssembler class builds together the page permissions
now, allowing to thin out certain parts of DataHandlers responsibility.

The following properties and methods are now deprecated:
- DataHandler->defaultPermissions
- DataHandler->pMap
- DataHandler->setTSconfigPermissions()
- DataHandler->assemblePermissions()

The methods
- DataHandler->doesRecordExist()
- DataHandler->recordInfoWithPermissionCheck()
should only be called with integers as permission argument in the future.

Resolves: #90019
Releases: master
Change-Id: I3724cb8661fe2b7cc5e1f8ab34d17dd4fa68c11b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62763
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
8 weeks ago[BUGFIX] PopulatePageSlugs return the most recent slug 54/62754/3
Herman Kremer [Fri, 20 Dec 2019 09:40:08 +0000 (10:40 +0100)]
[BUGFIX] PopulatePageSlugs return the most recent slug

The populate page slugs functionality in de upgrade wizard does not
work correct for pages with multiple title adjustments.

Realurl keeps for every page title change a record in
tx_realurl_pathdata.

In order to get the latest change a order should be added to the
query in getSuggestedSlugs.

Resolves: #89964
Releases: master, 9.5
Change-Id: I4b7fad14fc559e6c9e8a4fb6f6a2a112a290d7e2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62754
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Daniel Haupt <mail@danielhaupt.de>
Reviewed-by: Benni Mack <benni@typo3.org>
8 weeks ago[TASK] Remove leftover "menu_type" occurrences 85/62785/2
Benni Mack [Mon, 30 Dec 2019 08:46:16 +0000 (09:46 +0100)]
[TASK] Remove leftover "menu_type" occurrences

With TYPO3 v8.6, the new Content Types for menus were introduced
where each menu type is not stored in the database field "menu_type"
anymore, but moved to a separate "CType" property. This change
was breaking, however some left-over code was there but never
removed. The code does not do anything anymore but handle the
special "menu_type" cases like in Page Module CType Previews
or categorization handling.

FYI: This is a pre-patch to streamline the category API.

Resolves: #90035
Releases: master
Change-Id: I180fc5b1e2d33f74cf05d2565ab11049cc361c49
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62785
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Benni Mack <benni@typo3.org>
8 weeks ago[TASK] Avoid buildAccessibleProxy in tests 89/62789/3
Benni Mack [Mon, 30 Dec 2019 10:48:13 +0000 (11:48 +0100)]
[TASK] Avoid buildAccessibleProxy in tests

Tests should use getAccessibleMock() in all cases so
our testing API is used consistently everywhere.

The tests also show that some changes could be
made without having accessible proxies nowadays.

Resolves: #90037
Releases: master
Change-Id: I4a3f2948d9f645d736949fed4161cd91b1f3df0c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62789
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
8 weeks ago[TASK] Replace usage of BaseTestCase::getUniqueId() with core function 74/62774/5
Anja Leichsenring [Fri, 27 Dec 2019 15:33:17 +0000 (16:33 +0100)]
[TASK] Replace usage of BaseTestCase::getUniqueId() with core function

Tests can use the core function StringUtility::getUniqueId(), after both
functions provide the same service.

Resolves: #90021
Releases: master
Change-Id: I57fc362e3e93b1aa963ea497f210144cab5cea1e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62774
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
8 weeks ago[TASK] Apply rector set php71 51/62751/5
Alexander Schnitzler [Thu, 19 Dec 2019 14:49:31 +0000 (15:49 +0100)]
[TASK] Apply rector set php71

    php bin/rector process

A couple of rectors have been disabled due to different reasons:

- Rector\Php71\Rector\FuncCall\CountOnNullRector
  This rector has been disabled as it creates rather long and
  complex structures to avoid calling count on null.

  This rector will be enabled as soon as TYPO3 uses at least
  PHP 7.3 which introduces a "is_countable" method.

- Rector\Php71\Rector\Assign\AssignArrayToStringRector
  This rector has been disabled as it does not work properly.
  The default types of parameters have been changed although
  their types could properly be inferred by a doc block or
  by value assignments.

- Rector\Php71\Rector\BinaryOp\BinaryOpBetweenNumberAndStringRector
  This rector has been disabled as it does not work properly.
  A bug report is filed and to be found here:
  https://github.com/rectorphp/rector/issues/2454

- Rector\Php71\Rector\FuncCall\RemoveExtraParametersRector
  This rector has been disabled as it does not work properly.
  It removed arguments in tests, especially when using
  prophecies.

Releases: master
Resolves: #90002
Change-Id: I6ed14d38cc697a23104286db57535d6a3c0dbf62
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62751
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 weeks ago[TASK] Disallow .php8 file extensions for uploading 76/62776/2
Benni Mack [Fri, 27 Dec 2019 20:35:33 +0000 (21:35 +0100)]
[TASK] Disallow .php8 file extensions for uploading

With PHP 8 on the horizon, TYPO3 Core should be prepared
to also disallow files with the file extension ".php8" for uploading.

Resolves: #90023
Releases: master, 9.5, 8.7
Change-Id: I670755c5ae09ccf6ffd49c4b91b4617956f76ad7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62776
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
2 months ago[BUGFIX][DOCS] Rename RST file from "Galacian" to "Galician" 77/62777/3
Benni Mack [Fri, 27 Dec 2019 22:23:43 +0000 (23:23 +0100)]
[BUGFIX][DOCS] Rename RST file from "Galacian" to "Galician"

Resolves: #90027
Releases: master
Change-Id: I0783db5e26ceaba836a618f6dfce104080a4762d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62777
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
2 months ago[DOCS] Correct code block for site configuration 72/62772/4
Stephan Salzmann [Fri, 27 Dec 2019 13:08:32 +0000 (13:08 +0000)]
[DOCS] Correct code block for site configuration

The example claims to result in'.../detail/...', site configuration
needs to reflect that.

Releases: master, 9.5
Resolves: #90017
Change-Id: I3d6d133294763ee0e3e089c102a325a70ca3e1ea
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62772
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
2 months ago[DOCS] Update Context API usage example 98/62198/4
Tymoteusz Motylewski [Tue, 5 Nov 2019 16:07:24 +0000 (17:07 +0100)]
[DOCS] Update Context API usage example

Releases: master, 9.5
Resolves #90025

Change-Id: I8e155f7f15bf291bddf11c74cead8c68c91de49f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62198
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 months ago[TASK] Add index to slug field 03/61403/6
Tizian Schmidlin [Fri, 2 Aug 2019 14:27:39 +0000 (14:27 +0000)]
[TASK] Add index to slug field

`TYPO3\CMS\Core\Routing\PageRouter::getPagesFromDatabaseForCandidates`
looks-up candidates for the page using the `slug` field (and also sorts by
this value). This has some serious impact on the website performance on
systems with lots of pages. In order to optimize this, an index should be
set.

Releases: master
Resolves: #88896
Change-Id: I1aecca781db9562243a15341819b3ce261708836
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61403
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Jonas Eberle <flightvision@googlemail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Jonas Eberle <flightvision@googlemail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
2 months ago[BUGFIX] Fix /date|time|int/ regex in backend search 85/61885/4
Christian Eßl [Fri, 4 Oct 2019 14:18:22 +0000 (16:18 +0200)]
[BUGFIX] Fix /date|time|int/ regex in backend search

Several parts of the core use the regular expression /date|time|int/ to
test, if an 'eval' TCA configuration of a field contains one of these
evaluation strings. This regex would however match any other string that
contains one of those words. This patch fixes this behaviour by matching
only the exact words.

Resolves: #40347
Releases: master, 9.5
Change-Id: I2af1e3bf5b5cc4056f0e3875645c549a01e6dbd0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61885
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
2 months ago[BUGFIX] Reset evaluate permissions to previous value 45/62545/2
Susanne Moog [Thu, 5 Dec 2019 15:08:35 +0000 (16:08 +0100)]
[BUGFIX] Reset evaluate permissions to previous value

Resolves: #89842
Releases: master, 9.5
Change-Id: I42ffcc313290867d0410265f4c900225ceb554e2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62545
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
2 months ago[FEATURE] Add galacian flag 59/62759/4
Benni Mack [Mon, 23 Dec 2019 21:36:38 +0000 (22:36 +0100)]
[FEATURE] Add galacian flag

The flag for TYPO3's supported galacian is now added with the "gl.png" flag.

TYPO3 core previously had the "greenlandic" ("kl") named under the same
file, which was now renamed.

Resolves: #89929
Releases: master
Change-Id: Ia267dbf7f3e4a2bec67d6534bf26eddc4aaf71b5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62759
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
2 months ago[BUGFIX] Test failure due to erroneous usage of uniqueId() function 73/62773/4
Anja Leichsenring [Fri, 27 Dec 2019 14:36:27 +0000 (15:36 +0100)]
[BUGFIX] Test failure due to erroneous usage of uniqueId() function

The function in testing-framework provides a string that is target to be
used e.g. for HTML tags, but the BackendUserAuthenticationTest uses it
to produce a random userId, which needs to be an integer.
If the randomly produced string contains not only numbers, the cast
operation converts the uid to 0 and therefor prevents a DB query
from execution. This prevention results in a not consumed mock object,
which in turn causes a integration test failure.

Resolves: #90018
Releases: master, 9.5
Change-Id: I559041591a600a04da86e8b4a85cf5e6dd176475
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62773
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
2 months ago[BUGFIX] PopulatePagesSlugs should respect tx_realurl_pathsegment field 48/62748/5
Tobias Gaertner [Thu, 19 Dec 2019 08:30:34 +0000 (09:30 +0100)]
[BUGFIX] PopulatePagesSlugs should respect tx_realurl_pathsegment field

For upgrading from an old versions where EXT:realurl was used
the PopulatePagesSlugs upgradeWizard is in place.
It now also respects the tx_realurl_pathsegment field in generatorOptions.

The workflow is now, that it takes the page:tx_realurl_pathsegment field
and if empty falls back to page:title.

Resolves: #89069
Releases: master, 9.5
Change-Id: Ia9c6367d46713a8a1a609ef13c6bbd8878ec6bed
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62748
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Benni Mack <benni@typo3.org>
2 months ago[TASK] Acceptance tests for keyboard interaction with pagetree 21/62521/5
Michael Telgkamp [Tue, 22 Oct 2019 20:20:27 +0000 (22:20 +0200)]
[TASK] Acceptance tests for keyboard interaction with pagetree

Add keyboard interaction acceptance tests for the pagetree interactions.

Currently testing Home key, End key, navigation with Up and Down keys,
opening a selected entry with Enter and collapsing and expanding of
subtrees with Left / Right keys.

Resolves: #89832
Resolves: #89955
Releases: master
Change-Id: Ibe3c83fe6142296e333a66e68d67e283e2000957
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62521
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
2 months ago[TASK] Remove report for ext:compatibility7 74/62674/3
Anja Leichsenring [Mon, 16 Dec 2019 12:27:20 +0000 (13:27 +0100)]
[TASK] Remove report for ext:compatibility7

The extension does not exist for TYPO3 versions above 8, so the report
must not exist either in these versions.

Resolves: #89963
Releases: master, 9.5
Change-Id: I0de6b2646253a755b554b48dadabbfcb2bc1b795
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62674
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[TASK] Correctly nest testing template instructions in DOM 70/62770/4
Oliver Hader [Fri, 27 Dec 2019 10:33:53 +0000 (11:33 +0100)]
[TASK] Correctly nest testing template instructions in DOM

Resolves: #90016
Releases: master, 9.5
Change-Id: Id7fc792515cfc333118105ae832c2f283e455535
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62770
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
2 months ago[TASK] Remove repository polling trigger from pre-merge test plans 21/62721/2
Anja Leichsenring [Tue, 17 Dec 2019 09:47:21 +0000 (10:47 +0100)]
[TASK] Remove repository polling trigger from pre-merge test plans

The trigger will cause the plan to be executed after merge, which
is not needed because nightly plans take care of it.

Resolves: #89972
Releases: master, 9.5, 8.7
Change-Id: Iafc32174d2234439915c2e741020c4626391f98a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62721
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[TASK] COMPOSER_ROOT_VERSION raise to current version 10.2.0 34/62734/2
Anja Leichsenring [Tue, 17 Dec 2019 14:35:57 +0000 (15:35 +0100)]
[TASK] COMPOSER_ROOT_VERSION raise to current version 10.2.0

Resolves: #89976
Releases: master, 9.5, 8.7
Change-Id: I82d5811d9532ee47bcf2254c6bc18e4a3e0e74d0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62734
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[BUGFIX] Avoid showing telephone element for route link browser 57/62757/4
Oliver Hader [Sun, 22 Dec 2019 12:03:26 +0000 (13:03 +0100)]
[BUGFIX] Avoid showing telephone element for route link browser

Affects following site configuration aspects in site management module:
* page based error handling source field in link popup
* URI base static source field in link popup

Resolves: #90004
Releases: master
Change-Id: I2d8548141f20d5bf328dccc7145bdd54e59d6603
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62757
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
2 months ago[TASK] Update codeception and phpunit to latest versions 38/62738/3
Benni Mack [Thu, 19 Dec 2019 12:36:45 +0000 (13:36 +0100)]
[TASK] Update codeception and phpunit to latest versions

Updating codeception (3.2.1) and phpunit (8.5.0)
to latest versions allows for further updating other dependencies
TYPO3 is using.

Used command:
composer update codeception/codeception
composer update phpunit/phpunit

Resolves: #89984
Releases: master, 9.5, 8.7
Change-Id: I33a398fccadfb5c29056d33c7ff35429c263eb92
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62738
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
2 months ago[TASK] Simplify checks on Import about allowed filenames 27/62627/3
Benni Mack [Fri, 13 Dec 2019 16:06:06 +0000 (17:06 +0100)]
[TASK] Simplify checks on Import about allowed filenames

In TYPO3 v10, BasicFileUtility is not used by DataHandler anymore,
and never initialized with other file permissions than "allow
any file ending", which is why the simple check on the fileDenyPattern
can be used directly in Import functionality.

The next patch would then allow to clean up BasicFileUtility
where the methods which belong to "internal_type=file" are not in use
anymore.

Resolves: #89941
Releases: master
Change-Id: I58a28a1cd1f6d284d241479a324c877a2824e7bb
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62627
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <look@susi.dev>
2 months ago[BUGFIX] Fix various misbehaviors in "Broken Extension Scanner" 39/62639/5
Andreas Fernandez [Sat, 14 Dec 2019 13:01:21 +0000 (14:01 +0100)]
[BUGFIX] Fix various misbehaviors in "Broken Extension Scanner"

The "Broken Extension Scanner" has some flaws that are fixed with this
patch:

- Only one request is sent to scan all ext_localconf.php /
  ext_tables.php files, each
- ext_tables.php is only scanned if ext_localconf.php was successful,
  since those are dependent
- Protected extensions (mandatory to the system) cannot get uninstalled
- After uninstalling an extension all caches are cleared

Resolves: #89947
Releases: master, 9.5
Change-Id: I63aa7e67df9d061fded42af34c72727db629258a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62639
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <look@susi.dev>
2 months ago[TASK] Apply rector set php70 92/62592/3
Alexander Schnitzler [Tue, 10 Dec 2019 13:26:35 +0000 (14:26 +0100)]
[TASK] Apply rector set php70

    php bin/rector process

The Rector\Php70\Rector\List_\ListSwapArrayOrderRector rector
has been disabled as this needs proper testing and a separate
patch.

Releases: master
Resolves: #89907
Change-Id: I56b296221622afdc72feb5a48145431efd993ea1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62592
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[TASK] Update rector/rector 99/62599/5
Alexander Schnitzler [Wed, 11 Dec 2019 11:59:54 +0000 (12:59 +0100)]
[TASK] Update rector/rector

    composer remove --dev rector/rector
    composer require --dev rector/rector:~0.6

The update of rector brings important bugfixes and
enables the installation of the latest version of
phpstan/phpstan.

Releases: master
Resolves: #89918
Change-Id: I406aa56b19e88db23260033023e2c785425aef5e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62599
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[TASK] Increase wait limit for mssql containers 39/62739/3
Anja Leichsenring [Wed, 18 Dec 2019 12:35:56 +0000 (13:35 +0100)]
[TASK] Increase wait limit for mssql containers

For testing mssql based jobs, the wait limit for the database
to answer gets raised from 60 to 120 seconds to avoid build
failures solely caused by the container being up too late.

Releases: master, 9.5, 8.7
Resolves: #89986
Change-Id: If88949ed4dd978af1e349b524a40069b606dcb63
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62739
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[BUGFIX] Adjust parameters of implode() for PHP 7.4 45/62745/2
Susanne Moog [Wed, 18 Dec 2019 17:15:57 +0000 (18:15 +0100)]
[BUGFIX] Adjust parameters of implode() for PHP 7.4

The TimeTracker has been using the wrong order of glue
and pieces, the PageLayoutView has used implode with only
one parameter. Both occurences have been adjusted.

Resolves: #89991
Releases: master, 9.5, 8.7
Change-Id: Id600409548cf89b24832afcb5d0784c24be1d1b6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62745
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[BUGFIX] Use correct implode(string, array) syntax 41/62741/3
Anja Leichsenring [Wed, 18 Dec 2019 13:56:41 +0000 (14:56 +0100)]
[BUGFIX] Use correct implode(string, array) syntax

The usage of implode(array, string) has been marked as
deprecated by PHP and triggers PHP Deprecation warnings
by using PHP 7.4.

Resolves: #89987
Releases: master, 9.5
Change-Id: I4094744bd067203856dc305bb7e1651797d0c959
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62741
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Markus Klösges <mkloesges@gmx.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
2 months ago[TASK] Use new subdomain for new translation server 42/62742/2
Georg Ringer [Wed, 18 Dec 2019 13:59:54 +0000 (14:59 +0100)]
[TASK] Use new subdomain for new translation server

Use the final subdomain localize.typo3.org instead of
beta-translation.typo3.org. The latter is still available
and will be removed at later time.

Resolves: #89988
Releases: master
Change-Id: Ic7188d9edea0bbd4753b136242d992d195196880
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62742
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[TASK] Apply rector set php56 48/62448/10
Alexander Schnitzler [Sun, 1 Dec 2019 14:16:28 +0000 (15:16 +0100)]
[TASK] Apply rector set php56

    php bin/rector process

Releases: master
Resolves: #89807
Change-Id: I667199693dc519d0353d8e10b40d86faf1cf946a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62448
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[TASK] Introduce functional test for RequestBuilder 80/62580/4
Alexander Schnitzler [Sun, 8 Dec 2019 17:16:49 +0000 (18:16 +0100)]
[TASK] Introduce functional test for RequestBuilder

The now introduced functional tests are a replacement
for the unit tests which were only possible by mocking
the hell out of the RequestBuilder.

Releases: master
Resolves: #89898
Change-Id: Iccbd768ab0842e29d4954755e8f34f62bdc564f1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62580
Tested-by: Michael Telgkamp <michael.telgkamp@mindscreen.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Michael Telgkamp <michael.telgkamp@mindscreen.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[TASK] Speed up tests 47/62547/16
Benni Mack [Thu, 5 Dec 2019 18:57:55 +0000 (19:57 +0100)]
[TASK] Speed up tests

Some tests use "accessibleMock" (= eval() code) where
it is completely unnecessary as not even a mock is needed.

Resolves: #89974
Releases: master
Change-Id: I6d44a251e670ec97787a45b68b40e8f4bef2946f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62547
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[TASK] Fix closure comparison in test 37/62737/3
Susanne Moog [Wed, 18 Dec 2019 07:26:55 +0000 (08:26 +0100)]
[TASK] Fix closure comparison in test

ExactValueMatching of Closures in Prophecy may
result in Comparison Failures causing the test
to fail in newer PHPUnit Versions. Instead of
an exact match of that closure, a type comparison
is enough - as calling the closure is tested via
following assertions.

Resolves: #89982
Releases: master, 9.5
Change-Id: I23ef94a291a07d02e0c8857a1aeaf14931406af0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62737
Tested-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[BUGFIX] Include .htaccess file in extension packages 82/62582/3
Georg Ringer [Mon, 9 Dec 2019 13:52:06 +0000 (14:52 +0100)]
[BUGFIX] Include .htaccess file in extension packages

Adopt the excludeForPackaging to include also .htaccess files in
extension downloads of extension manager.

Resolves: #89876
Releases: master, 9.5, 8.7
Change-Id: If5a00956165bab386a980bc897f5750a3ffc73da
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62582
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Susanne Moog <look@susi.dev>
2 months ago[TASK] Remove redundancies in install tool ext conf template 48/62648/2
Claus Due [Mon, 16 Dec 2019 10:55:18 +0000 (11:55 +0100)]
[TASK] Remove redundancies in install tool ext conf template

This patch:

1. Removes a redundant usage of a "NoSpace" VH and
   the associated namespace import since there are no
   other usages.
2. Deletes the VH class since it is not used elsewhere.
3. Removes an always-true and therefore redundant "if"

Releases: master
Resolves: #89956
Change-Id: I943653e04fa731cdc4bdcbc8d6e32663e3ca30c9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62648
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Reviewed-by: Benni Mack <benni@typo3.org>
2 months ago[SECURITY] Avoid insecure deserialization in QueryGenerator & QueryView 20/62720/2
Frank Naegler [Tue, 17 Dec 2019 09:53:24 +0000 (10:53 +0100)]
[SECURITY] Avoid insecure deserialization in QueryGenerator & QueryView

Resolves: #89005
Releases: master, 9.5, 8.7
Security-Commit: 82656cf8149d04f31b1441a03415b5e9a067c614
Security-Bulletin: TYPO3-CORE-SA-2019-026
Change-Id: If312a53b24d919439fa70f5df96be383876957a6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62720
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
2 months ago[SECURITY] Prevent SQLi in ext:lowlevel QueryGenerator 19/62719/2
Frank Naegler [Tue, 17 Dec 2019 09:53:17 +0000 (10:53 +0100)]
[SECURITY] Prevent SQLi in ext:lowlevel QueryGenerator

Resolves: #89452
Releases: master, 9.5, 8.7
Security-Commit: d73e50f02afc5459f737282ede6cc70579fe7181
Security-Bulletin: TYPO3-CORE-SA-2019-025
Change-Id: I55afb17f4b1509a3dfc945e28e5d35671f6c28f3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62719
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
2 months ago[SECURITY] Avoid directory traversal on archive extraction 18/62718/2
Andreas Fernandez [Tue, 17 Dec 2019 09:53:08 +0000 (10:53 +0100)]
[SECURITY] Avoid directory traversal on archive extraction

The Extension Manager and Language Pack Manager receive Zip archives as
input from foreign sources and extract them on the disk. However, the
previous approach is considered insecure as the target directory is not
checked per file and directory traversal was possible.

This patch adds a new service class that handles the extraction of Zip
archives via PHP's internal ZipArchive class, which can handle such
cases on its own.

Resolves: #88764
Releases: master, 9.5, 8.7
Security-Commit: a02f19c73211a5f1c0286ab44bee27da9b73f026
Security-Bulletin: TYPO3-CORE-SA-2019-024
Change-Id: I701a577f54410344867b868409a38cc44339f976
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62718
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
2 months ago[SECURITY] XSS in file list through file extension 17/62717/2
Andreas Fernandez [Tue, 17 Dec 2019 09:52:59 +0000 (10:52 +0100)]
[SECURITY] XSS in file list through file extension

FAL currently filters invalid characters from file names stored by its
API. However, this sanitization took no effect when the file was placed
by e.g. uploads via FTP, which doesn't trigger FAL.

This patch adds a missing `htmlspecialchars` call when the file
extension is rendered and could not be sanitized before due to mentioned
circumstances.

Resolves: #88931
Releases: master, 9.5, 8.7
Security-Commit: 296c6a6723826b4ad2babbb1de5b9d23dfd256ea
Security-Bulletin: TYPO3-CORE-SA-2019-023
Change-Id: I24cbc623f6390944a608eadf3ebe7a13d294e0ae
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62717
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
2 months ago[SECURITY] Avoid XSS by correctly encoding typolink results 16/62716/2
Oliver Hader [Tue, 17 Dec 2019 09:52:50 +0000 (10:52 +0100)]
[SECURITY] Avoid XSS by correctly encoding typolink results

In order to avoid XSS through typolink, anchor text is encoded
correctly to be used in a HTML context. Fallback link texts of
links to pages are encoded per default in case lib.parseFunc
has not been configured.

Resolves: #88635
Releases: master, 9.5, 8.7
Security-Commit: b62f71c4e098156052ff33e775208981c2ef512b
Security-Bulletin: TYPO3-CORE-SA-2019-022
Change-Id: I76b0f06ad52a487e1aebc820531c11166ad45117
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62716
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
2 months ago[SECURITY] Prevent XSS in EXT:form error message output 15/62715/2
Frank Naegler [Tue, 17 Dec 2019 09:52:42 +0000 (10:52 +0100)]
[SECURITY] Prevent XSS in EXT:form error message output

Resolves: #88629
Releases: master, 9.5, 8.7
Security-Commit: df38c239aa9c627fb7b6f1c384d45ff0940d98fa
Security-Bulletin: TYPO3-CORE-SA-2019-021
Change-Id: Ib12dc0affe7f15f1869cff57ea09d9999a0d632a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62715
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
2 months ago[TASK] Streamline frontend user password recovery process 90/62690/2
Oliver Hader [Sun, 15 Dec 2019 19:34:47 +0000 (20:34 +0100)]
[TASK] Streamline frontend user password recovery process

The ext:felogin recovery process is using a non-typesafe comparison
which might be exploited with a probability of 0.000000294% and is
storing the recovery token as plain MD5-hash in database.

In order to streamline the process non-typesafe comparison is using
PHP's hash_equals() method; for keeping backward compatibility just
HMAC-SHA1 is applied to the recovery token in database.

Since exploitations to this scenario are very unlikely (for a 50%
chance an attacker would have to trigger the creation of around
170 million recovery requests) it is not handled with a security
workflow - but using the public workflow.

Resolves: #89952
Releases: master, 10.2, 9.5, 8.7
Change-Id: Idcb7b7d6eb418124dc17f1707284b6abe8a8b63b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62690
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
2 months ago[BUGFIX] Don't import PHP class in ext_localconf.php 87/62687/3
Andreas Fernandez [Tue, 17 Dec 2019 06:17:50 +0000 (07:17 +0100)]
[BUGFIX] Don't import PHP class in ext_localconf.php

Resolves: #89970
Releases: master
Change-Id: I5b7e22c853993e7434c086c22a3898eefbe07899
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62687
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
2 months ago[BUGFIX] Revert FolderCheck for clipboard actions 21/62321/2
Guido Schmechel [Wed, 13 Nov 2019 20:25:44 +0000 (21:25 +0100)]
[BUGFIX] Revert FolderCheck for clipboard actions

Due to a faulty query in #85425 it was no longer possible
to copy files at the clipboard multi-selection-mode.

This must be possible if the user has the permission to copy files,
but not to copy folders.

Resolves: #89669
Releases: master, 9.5
Change-Id: I1c26696a6c3886dd5669957cdce8ca472b17b577
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62321
Tested-by: Peter Kraume <peter.kraume@gmx.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Henrik Elsner <helsner@dfau.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Peter Kraume <peter.kraume@gmx.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Henrik Elsner <helsner@dfau.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
2 months ago[BUGFIX] Ensure correct return values in Workspace middleware 51/62651/2
Benni Mack [Mon, 16 Dec 2019 11:21:18 +0000 (12:21 +0100)]
[BUGFIX] Ensure correct return values in Workspace middleware

When setting config.disablePreviewNotification = 1 in workspaces
context, the preview middleware returns "null", although the method
signature says it always requires a string return value.

Resolves: #89959
Releases: master, 9.5
Change-Id: Icdef1891989db2869c2351adb07e6b4778d25e09
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62651
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Achim Fritz <af@achimfritz.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Achim Fritz <af@achimfritz.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[TASK] Simplify chunking of test-plan jobs 40/62640/3
Markus Klösges [Sat, 14 Dec 2019 15:01:59 +0000 (16:01 +0100)]
[TASK] Simplify chunking of test-plan jobs

To make the code for splitting all test-jobs into stages of equal size
simpler and easier to maintain, a helper class is introduced
that supports chunking two lists into equally sized chunks, while
ensuring that each chunk only contains a limited number of elements
from one of the lists.

Using this utility, the number of mssql jobs can easily be limited,
while keeping the spec-code easy to follow.

Releases: master, 9.5, 8.7
Resolves: #89948
Change-Id: I9e1677e19fb2ea6df7d9e964e8f772ffb7324ec8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62640
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[BUGFIX] Fix return value in command site:list 21/62621/5
Georg Ringer [Fri, 13 Dec 2019 14:06:17 +0000 (15:06 +0100)]
[BUGFIX] Fix return value in command site:list

Return 0 instead of null.

Resolves: #89936
Releases: master, 9.5
Change-Id: Ic3345975b60fca38537750c9617d68ba9d19cc3e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62621
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
2 months ago[DOCS] Extend docs of DeleteUploads finisher 97/61997/5
Jonas Schwabe [Tue, 15 Oct 2019 07:48:43 +0000 (07:48 +0000)]
[DOCS] Extend docs of DeleteUploads finisher

Releases: master, 9.5
Resolves: #89416
Change-Id: I4565d846bb86077c3e03534416f3047e2f7f0ce6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61997
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
2 months ago[BUGFIX] Always allow dividers in TCA auth mode check 42/62342/5
Alexander Stehlik [Mon, 18 Nov 2019 19:10:01 +0000 (20:10 +0100)]
[BUGFIX] Always allow dividers in TCA auth mode check

This brings back the optgroups in the CType and list_type fields
for normal editors.

Additionally some tests for checkAuthMode are added.

Releases: master, 9.5
Resolves: #89707
Change-Id: Ib3e6dbf3598ad767910161225a31ad2db939b3d6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62342
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
2 months ago[TASK] Rename method getName of TypoScriptConstants VH 41/62541/2
Claus Due [Thu, 5 Dec 2019 13:58:59 +0000 (14:58 +0100)]
[TASK] Rename method getName of TypoScriptConstants VH

The name "getName" will be reserved in Fluid 3.0 and is
ambiguous. This patch renames that method to become
"getFieldName" which is less ambiguous and conflict free.

Additionally the ViewHelper is changed so it no longer
accesses deprecated property AbstractViewHelper->
viewHelperVariableContainer, instead accessing the
ViewHelperVariableContainer via $this->renderingContext.

Resolves: #89861
Releases: master
Change-Id: Iea474625917293afe67326f765c6a77f7fbe9b73
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62541
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>