Packages/TYPO3.CMS.git
6 years ago[BUGFIX] Remove property item of category model
Alexander Schnitzler [Wed, 21 Nov 2012 17:06:43 +0000 (18:06 +0100)]
[BUGFIX] Remove property item of category model

Because the mere presence of the property leads
to an SqlException in the Typo3DbBackend it has
to be removed for 6.0. For 6.1 a solution will
be found.

Releases: 6.0
Fixes: #43074
Change-Id: I35850ba3513c48da692f6e1a9d07e7cfbfd7f1b3
Reviewed-on: http://review.typo3.org/16673
Reviewed-by: Ingo Pfennigstorf
Tested-by: Ingo Pfennigstorf
Reviewed-by: Wouter Wolters
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
6 years ago[TASK] Adjust namespaces of persistence unit tests
Alexander Schnitzler [Wed, 21 Nov 2012 18:42:14 +0000 (19:42 +0100)]
[TASK] Adjust namespaces of persistence unit tests

Test files that have been moved from Persistence
to Persistence\Generic also have to have an proper
namespace.

Also moved two test files back to Persistence.
I accidently moved them too in my last patch.

Releases: 6.0
Fixes: #43205

Change-Id: I1e29fd409f868da3e2295fa96ee685ca005ab584
Reviewed-on: http://review.typo3.org/16676
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
6 years ago[TASK] Move persistence unit tests
Alexander Schnitzler [Wed, 21 Nov 2012 18:30:59 +0000 (19:30 +0100)]
[TASK] Move persistence unit tests

From Persistence to Persistence\Generic

Releases: 6.0
Fixes: #43204

Change-Id: I5eb269217e8369b0f05dc52b2595fed3f1a41442
Reviewed-on: http://review.typo3.org/16675
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
6 years ago[CLEANUP] Adjust code to coding guidelines
Alexander Schnitzler [Tue, 20 Nov 2012 11:06:00 +0000 (12:06 +0100)]
[CLEANUP] Adjust code to coding guidelines

* whitespaces, tabs and blank line issues
* bool -> boolean
* int -> integer
* remove @scope and @entity

Fixes: #43146
Releases: 6.0
Change-Id: I0ffdde3c918920272e8b1e4d1eab199b7b3e90f3
Reviewed-on: http://review.typo3.org/16600
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[TASK] Comment legacy files to be removed with 6.2
Christian Kuhn [Mon, 19 Nov 2012 21:05:37 +0000 (22:05 +0100)]
[TASK] Comment legacy files to be removed with 6.2

The 'old' class files before namespace switch are commented
to be removed with TYPO3 7.0, but they should be scheduled
for removal with 6.2.

Change-Id: I01bad5874d1bf57e4272f7918557a8f53213cd0e
Resolves: #43120
Releases: 6.0
Reviewed-on: http://review.typo3.org/16586
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Use tablename for fullQuoteStr call
Anja Leichsenring [Sat, 17 Nov 2012 16:49:05 +0000 (17:49 +0100)]
[BUGFIX] Use tablename for fullQuoteStr call

In Typo3DbBackend->replacePlaceholders method always 'foo' is
used as tablename. As long as mysql is used this makes no difference,
but it prevents dbal from ensure proper quotation for other databases.

Fixes: #43058
Releases: 1.3, 4.7, 6.0
Change-Id: I9f08b9026d14d86e704771fd43ec3613045b4698
Reviewed-on: http://review.typo3.org/16534
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] Remove newlines after closing php tag
Alexander Schnitzler [Mon, 19 Nov 2012 15:50:28 +0000 (16:50 +0100)]
[BUGFIX] Remove newlines after closing php tag

Also made Jenkins happy...
* ext_localconf.php
* Tests/Unit/Persistence/Mapper/DataMapFactoryTest.php

Releases: 6.0
Fixes: #43106
Change-Id: I16d92dfb8cee675e85df9dcb90cd25b3fa56333f
Reviewed-on: http://review.typo3.org/16569
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
6 years ago[BUGFIX] Force command controller task arguments saved as array
Marc Bastian Heinrichs [Sat, 17 Nov 2012 19:17:03 +0000 (20:17 +0100)]
[BUGFIX] Force command controller task arguments saved as array

Executing command controller scheduler tasks without
action arguments fails because the arguments aren't saved as
array in the serialized task which is required for setting the request
arguments. Solution: cast the sumitted arguments to array.

Change-Id: Ie8b7d11fa6bfd666b720b387523c825d32b3876a
Fixes: #37563
Releases: 4.7, 6.0
Reviewed-on: http://review.typo3.org/16539
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Ingo Pfennigstorf
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
6 years ago[BUGFIX] Prevent sql errors with unsupported relation
Alexander Schnitzler [Sat, 17 Nov 2012 16:59:08 +0000 (17:59 +0100)]
[BUGFIX] Prevent sql errors with unsupported relation

Using passthrough as relation causes sql errors
in the addUnionStatement of Typo3DbBackend. To
prevent this an Exception is introduced which will
be thrown instead.

Fixes: #27057
Releases: 6.0
Change-Id: I3e57d2b8c290e8f8b445278a3a25ffef15adbeb5
Reviewed-on: http://review.typo3.org/16537
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Tomasz Grzemski
Tested-by: Tomasz Grzemski
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
6 years ago[BUGFIX] Make saving scheduler commandController tasks working again
Marc Bastian Heinrichs [Sat, 17 Nov 2012 18:42:28 +0000 (19:42 +0100)]
[BUGFIX] Make saving scheduler commandController tasks working again

After converting to namespaces the name of the configuration fields
in backend also contains namespaces. Rename them back to the original
name.
Also the commands select box option labels wasn't compatible to
namespaces.

Fixes: #43035
Releases: 6.0

Change-Id: I6f86cccaf6936f4ef8c64d830143930f1a48971c
Reviewed-on: http://review.typo3.org/16538
Reviewed-by: Markus Günther
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Ingo Pfennigstorf
Tested-by: Ingo Pfennigstorf
6 years ago[BUGFIX] Add missing TypoScript Mapping for Category Model
Ingo Pfennigstorf [Sun, 18 Nov 2012 21:53:02 +0000 (22:53 +0100)]
[BUGFIX] Add missing TypoScript Mapping for Category Model

The missing TypoScript configuration for the category model is
provided with this patch.

Fixes: #43084
Releases: 6.0

Change-Id: If93e5be94c845b21e77c8522444d3aaeae9c7ee4
Reviewed-on: http://review.typo3.org/16559
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] Tx_Extbase_DomainObject_AbstractDomainObject#getUid is final
Markus Günther [Sat, 17 Nov 2012 13:35:48 +0000 (14:35 +0100)]
[BUGFIX] Tx_Extbase_DomainObject_AbstractDomainObject#getUid is final

The final #getUid() method prevents Doctrine from generating proxies.
Having the method final is not necessary here.

Fixes: #35937
Releases: 6.0

Change-Id: Ib325647834accdce5b3f95967161beae9df81612
Reviewed-on: http://review.typo3.org/16521
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Oliver Klee
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
6 years ago[BUGFIX] Fix small DebuggerUtility issues
Alexander Schnitzler [Fri, 16 Nov 2012 10:11:25 +0000 (11:11 +0100)]
[BUGFIX] Fix small DebuggerUtility issues

* adjust css for better/safer margins
* respect ArrayAccess
* fix level depth in array rendering
* fix wrong display of max depth with arrays
* remove expand icon for empty objects/collections

Releases: 6.0
Fixes: #43051
Change-Id: I6641d53df7b9591598c738b9ea55ba96939d2224
Reviewed-on: http://review.typo3.org/16516
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
6 years ago[BUGFIX] Fix and deprecate legacy creation of objects in repository
Marc Bastian Heinrichs [Fri, 16 Nov 2012 14:43:54 +0000 (15:43 +0100)]
[BUGFIX] Fix and deprecate legacy creation of objects in repository

Since DI is used for instantiation of session and backend
objects, creating repository objects with makeInstance will fail. Add
legacy creation for this both objects to constructor and deprecate the
legacy creation

Fixes: #42968
Fixes: #42928
Releases: 6.0

Change-Id: Idc8aa7aadc2a4e43fdd938902dbd5f8c8098bf24
Reviewed-on: http://review.typo3.org/16484
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[!!!][BUGFIX] Remove property isOnline from frontenduser model
Marc Bastian Heinrichs [Sat, 17 Nov 2012 10:00:09 +0000 (11:00 +0100)]
[!!!][BUGFIX] Remove property isOnline from frontenduser model

Because there is no TCA definition for column is_online the
property would not get filled with data from database in mappping
process. Remove it to avoid confusion.

Fixes: #11024
Releases: 6.0

Change-Id: Ic62d2d918ac3bd0307e8ff1b6432769f12d1bb4e
Reviewed-on: http://review.typo3.org/16510
Reviewed-by: Ingo Pfennigstorf
Tested-by: Ingo Pfennigstorf
Reviewed-by: Markus Günther
Tested-by: Markus Günther
6 years ago[BUGFIX] Make ValidatorResolver respect namespaces
Tymoteusz Motylewski [Fri, 16 Nov 2012 16:23:24 +0000 (17:23 +0100)]
[BUGFIX] Make ValidatorResolver respect namespaces

ValidatorResolver should parse namespaced validator
definitions like:
@validate Vendor.Extension:Foo
or
@validate Vendor\Extension\FooValidator

Change-Id: I37ce3f559f2917b149256d1b57a838c6394048e0
Fixes: #42791
Releases: 6.0
Reviewed-on: http://review.typo3.org/16491
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Markus Günther
Tested-by: Markus Günther
6 years ago[BUGFIX] Reset 'vendorName' in RequestBuilder to NULL for new requests
Andreas Kiessling [Sat, 17 Nov 2012 10:36:55 +0000 (11:36 +0100)]
[BUGFIX] Reset 'vendorName' in RequestBuilder to NULL for new requests

It is currently impossible to use extensions with AND without
namespaces on the same page, since the vendorName is not reset
when a new request is built. So when the request is analyzed later on,
a vendor from a previous plugin may be found and thus the wrong
classname is built.

This patch resets the vendorName to NULL in method 'loadDefaultValues'.

Releases: 6.0
Fixes: #42782

Change-Id: Ie2d74a7140b325826fb752505e7569069f77146c
Reviewed-on: http://review.typo3.org/16481
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Correctly apply _LOCAL_LANG from typoscript
Jana Golinowski [Sun, 21 Oct 2012 21:35:21 +0000 (23:35 +0200)]
[BUGFIX] Correctly apply _LOCAL_LANG from typoscript

Language labels from typoscript are currently loaded by overwriting the
source/target array that is required by the method
Tx_Extbase_Utility_Localization::translate().

Change-Id: I936565475ec7741a5c0cb0d308b785bc08e4c708
Fixes: #42130
Releases: 6.0, 4.7, 4.6
Reviewed-on: http://review.typo3.org/15871
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[TASK] Rename Reflection/Service to Reflection/ReflectionService
Anja Leichsenring [Fri, 9 Nov 2012 07:20:35 +0000 (08:20 +0100)]
[TASK] Rename Reflection/Service to Reflection/ReflectionService

This is part of the code cleanup.

Change-Id: I1d9ff99b565e279110ee8c6e1cff8ab6a47566f5
Resolves: #42808
Releases: 6.0
Reviewed-on: http://review.typo3.org/16341
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Cache in BackendConfigurationManager is not taking pageId into account
Tymoteusz Motylewski [Wed, 7 Nov 2012 08:58:07 +0000 (09:58 +0100)]
[BUGFIX] Cache in BackendConfigurationManager is not taking pageId into account

Cache in BackendConfigurationManager is not taking pageId into account
Thanks to Timo Schmidt for providing the patch.

Change-Id: I55a5eb6bda086af91c5bf3ab621754b1a04d0f1e
Fixes: #42737
Releases: 6.0, 4.7, 1.3
Reviewed-on: http://review.typo3.org/16246
Reviewed-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] DataMapperFactory respects foreign_table_field
Peter Niederlag(office) [Thu, 21 Jul 2011 13:23:53 +0000 (15:23 +0200)]
[BUGFIX] DataMapperFactory respects foreign_table_field

- add foreign_table_field if present in $TCA
- add a corresponding unit test

Change-Id: I02eac46a7e4b17c001fe30fb9469e1e94b3dfb0f
Resolves: #28369
Releases: 4.7, 6.0
Reviewed-on: http://review.typo3.org/3454
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Fix Annotation for Category model
Ingo Pfennigstorf [Wed, 14 Nov 2012 14:36:43 +0000 (15:36 +0100)]
[BUGFIX] Fix Annotation for Category model

This fixes the annotation for the item property in the Category model.

Resolves: #42970
Releases: 6.0

Change-Id: Ic6e5f54a608f0c8f311a8fd887ce4c9195b1dba8
Reviewed-on: http://review.typo3.org/16442
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Add "Abstract" prefix to abstract task class
Helmut Hummel [Thu, 8 Nov 2012 21:57:03 +0000 (22:57 +0100)]
[TASK] Add "Abstract" prefix to abstract task class

All abstract classes should be start with an Abstract
prefix in the class name.
Adjust the abstract task class to this naming convention.

Resolves: #42803
Releases: 6.0

Change-Id: If0b62d4ff61d9aa7ce44f61a15457faeabeab2d7
Reviewed-on: http://review.typo3.org/16331
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Adjust phpdoc for classes (files) of backports
Anja Leichsenring [Tue, 6 Nov 2012 20:01:21 +0000 (21:01 +0100)]
[TASK] Adjust phpdoc for classes (files) of backports

Since it's neither "FLOW3" nor "v5" anymore those
headers need to be adjusted.

Before:
This class is a backport of the corresponding class of FLOW3.
All credits go to the v5 team.
Changed into:
This class is a backport of the corresponding class of TYPO3 Flow.
All credits go to the TYPO3 Flow team.

Change-Id: If5aaae848334c39a873b41ffc614942cedbbf4f8
Resolves: #42713
Releases: 6.0
Reviewed-on: http://review.typo3.org/16242
Reviewed-by: Stefan Neufeind
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUBFIX] Fix fatal error in Test
Helmut Hummel [Wed, 7 Nov 2012 17:25:30 +0000 (18:25 +0100)]
[BUBFIX] Fix fatal error in Test

Fixture class names have been used twice.
Use uniqid to avoid clashes.

Releases: 6.0
Relates: #42028

Change-Id: Iccf188969d988d259d7d5f5a4fa3bd194c1826c0
Reviewed-on: http://review.typo3.org/16259
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Fix several namespace related bugs
Helmut Hummel [Wed, 17 Oct 2012 19:50:46 +0000 (21:50 +0200)]
[BUGFIX] Fix several namespace related bugs

Due to the switch to namespaces several things are buggy or missing.
* DataMapper and property mapper should recognize old Extbase class names
* Adapt checks for class names in several places

Resolves: #42546
Releases: 6.0

Change-Id: I2044479ce76d4dd480cc8d93e5b0e1d52471fe87
Reviewed-on: http://review.typo3.org/16161
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Mapping of DomainObject with namespaces
Aske Ertmann [Mon, 15 Oct 2012 16:01:16 +0000 (18:01 +0200)]
[BUGFIX] Mapping of DomainObject with namespaces

This makes sure that when checking if the property meta data
type is a class name, it also checks if it's a namespaced class names.

Fixes: #40900
Change-Id: I36e20e0aada750bdebde183af65c73e69ab463d7
Releases: 6.0
Reviewed-on: http://review.typo3.org/15643
Reviewed-by: Aske Ertmann
Reviewed-by: Mattias Nilsson
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Dont respect pid for static & rootlevel tables
Alexander Schnitzler [Sat, 17 Mar 2012 12:40:57 +0000 (13:40 +0100)]
[BUGFIX] Dont respect pid for static & rootlevel tables

If TCA defines a table to be static or on root level
setRespectStoragePage should be set to false as pid
is either 0 or even not set at all.

Releases: 6.0
Fixes: #42519
Change-Id: Ia18f9258da68f228a13cf8d1ed7656e939ba52b8
Reviewed-on: http://review.typo3.org/16049
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Namespaced domain models are not updated
Nico de Haen [Tue, 16 Oct 2012 19:44:37 +0000 (21:44 +0200)]
[BUGFIX] Namespaced domain models are not updated

The check to see if the session's reconstituted objects are
aggregate roots doesn't support namespaced domain models.

Fixes: #42028
Change-Id: If9ad7569087a073471522036f645a039a869e682
Reviewed-on: http://review.typo3.org/15747
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Adjust phpdoc to namespaces
Stefan Neufeind [Sat, 13 Oct 2012 19:36:32 +0000 (21:36 +0200)]
[TASK] Adjust phpdoc to namespaces

phpdoc still contained references to
Tx_Extbase_...

Change-Id: I45271dfbd4fa6a6d03d719b670c8aa939bd2a07d
Releases: 6.0
Fixes: #42700
Reviewed-on: http://review.typo3.org/15581
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
6 years ago[TASK] Resync TYPO3Flow- and Extbase-Persistence
Alexander Schnitzler [Tue, 30 Oct 2012 10:01:09 +0000 (11:01 +0100)]
[TASK] Resync TYPO3Flow- and Extbase-Persistence

Releases: 6.0
Fixes: #42505
Change-Id: I1d3160013b248afcf0451fbc49bdb68b6bf9c92e
Reviewed-on: http://review.typo3.org/16037
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] Misspelling in Typo3DbBackend.php
Nicole Cordes [Mon, 5 Nov 2012 20:28:48 +0000 (21:28 +0100)]
[BUGFIX] Misspelling in Typo3DbBackend.php

There is a misspelling in
Classes/Persistence/Generic/Storage/Typo3DbBackend.php and its test.
Property pageRepositiory should be renamed to pageRepository.

Change-Id: I858c49509773f94483b5d92909e63625859bc9b5
Fixes: #42683
Releases: 6.0
Reviewed-on: http://review.typo3.org/16219
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Cleanup Typo3DbBackend
Helmut Hummel [Sun, 4 Nov 2012 17:14:44 +0000 (18:14 +0100)]
[TASK] Cleanup Typo3DbBackend

The Typo3DbBackend does assumptions on language
and version overlays based on request variables
or global variables.

Instead it should just evaluate the query settings
and use them.

Additionally further decrease the dependencies to global
objects where possible.

Resolves: #42676
Releases: 6.0

Change-Id: I1731d2b04d1e3be5b40fff484c5b4bd1cd0efa8c
Reviewed-on: http://review.typo3.org/16192
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] resolveValidatorObjectName support for namespaces
Aske Ertmann [Mon, 15 Oct 2012 15:46:14 +0000 (17:46 +0200)]
[BUGFIX] resolveValidatorObjectName support for namespaces

This fix makes sure that validators get resolved correctly for
namespaced extensions. This works for the following scenarios:
Fully qualified namespaced extension name, shorthand validator
names (namespaced & non-namespaaced) and built in validators.

This also changes the behavior for the built in validators,
so instead of resolving the deprecated class name it resolves
to the namespaced class name.

Fixes: #40955
Releases: 6.0

Change-Id: Iec6a1e613218cf1e5d032502231dfa3447d8fa96
Reviewed-on: http://review.typo3.org/15642
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Support plugins in namespaced extensions
Aske Ertmann [Tue, 9 Oct 2012 13:16:21 +0000 (15:16 +0200)]
[BUGFIX] Support plugins in namespaced extensions

The function registerPlugin doesn't handle namespaced extension keys
differently than normal extension keys, leading to being unable to
read the configuration set in the configurePlugin function.
In the configurePlugin the vendor name is stripped from the extension name,
but the same is not done in registerPlugin. This leads to it being
impossible to select the plugin in the backend when inserting/editing a
plugin content element.

Change-Id: Ic21dc68e83bf65171aba7eafa43530eb7b23884b
Fixes: #41785
Releases: 6.0
Reviewed-on: http://review.typo3.org/16052
Reviewed-by: Aske Ertmann
Tested-by: Aske Ertmann
Reviewed-by: Jan-Erik Revsbech
Tested-by: Jan-Erik Revsbech
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Rename File after renaming class
Helmut Hummel [Sun, 4 Nov 2012 18:51:38 +0000 (19:51 +0100)]
[BUGFIX] Rename File after renaming class

After renaming the class, the renaming of the
file was accidentally not committed.

Rename the file to make the tests green again.

Resolves: #42665
Releases: 6.0

Change-Id: I8033c9f89ef101321825e90420ca228a2577272f
Reviewed-on: http://review.typo3.org/16194
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] Typo3DbBackend language handling crashes in BE
Nicole Cordes [Fri, 19 Oct 2012 22:01:59 +0000 (00:01 +0200)]
[BUGFIX] Typo3DbBackend language handling crashes in BE

Within a past commit the language handling was completly rewritten to
support language uids other than 0. This was done for frontend only so we
have to add a backend handling as well.

The language uid is now taken from the L parameter (either POST or GET)
for backend modules. If anything was submitted a fallback to 0 is
integrated.

Change-Id: I683e4bb44fa86c2b40c6126d8360858a2319bebe
Fixes: #40796
Releases: 6.0
Reviewed-on: http://review.typo3.org/15826
Reviewed-by: Georg Ringer
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Rename FlashMessages to FlashMessageContainer
Helmut Hummel [Sun, 4 Nov 2012 09:47:26 +0000 (10:47 +0100)]
[TASK] Rename FlashMessages to FlashMessageContainer

Variable and method names already use this name, so
it makes sense to use this name as class name, also
to be in line with Flow.

Resolves: #42665
Releases: 6.0

Change-Id: I36743462dd6e6d42acc2e976e4aa3371d9d98d7a
Reviewed-on: http://review.typo3.org/16180
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Remove deprecated methods and classes
Helmut Hummel [Sat, 3 Nov 2012 22:33:53 +0000 (23:33 +0100)]
[TASK] Remove deprecated methods and classes

Remove code that has been scheduled for removal
for Extbase 6.0 except the old property mapper
which needs to stay for at least one version.

Also reschedule the removal for the old property
mapper for Extbase 6.1

Resolves: #41926
Resolves: #41925
Releases: 6.0

Change-Id: I60d2663a7ec3a37a6ba256189b77349ccebc91f6
Reviewed-on: http://review.typo3.org/16177
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Rename ExtensionManager class
Helmut Hummel [Sat, 3 Nov 2012 18:46:14 +0000 (19:46 +0100)]
[TASK] Rename ExtensionManager class

The class ExtensionManager is actually a utility
to manage extensions. Rename it to better reflect
it's purpose.

Resolves: #42661
Releases: 6.0

Change-Id: I6d7082e3f4fce767afb8cabe027d54cf786c24b2
Reviewed-on: http://review.typo3.org/16171
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Update doc block example code to to namespaces
Aske Ertmann [Tue, 30 Oct 2012 15:04:12 +0000 (16:04 +0100)]
[TASK] Update doc block example code to to namespaces

Change-Id: I89eeb3aaa772e97ca09cd633edc5d2e404fd7603
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/16048
Reviewed-by: Aske Ertmann
Tested-by: Aske Ertmann
Reviewed-by: Wouter Wolters
Reviewed-by: Jan-Erik Revsbech
Tested-by: Jan-Erik Revsbech
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] PHP 5.4 unit test warnings
Christian Kuhn [Thu, 1 Nov 2012 23:33:25 +0000 (00:33 +0100)]
[BUGFIX] PHP 5.4 unit test warnings

PHP 5.4 throws warnings "Creating default object from empty value"
if $foo->bar is accessed and $foo is not an object. This is the
case in several unit tests, especially if $GLOBALS['TSFE'] is accessed.
The patch fixes those warnings by initializing the object in question
with an instance of stdClass.
Furtermore some dumplicate cleanups of global backup handling is
removed that is already done in the parent classes.

Change-Id: I4c060632783926d76ff96b2eadf3c2ae89f6ae4e
Fixes: #42610
Releases: 6.0
Reviewed-on: http://review.typo3.org/16116
Reviewed-by: Helmut Hummel
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Change objectStorage patch in migration script
Alexander Schnitzler [Wed, 31 Oct 2012 11:11:06 +0000 (12:11 +0100)]
[TASK] Change objectStorage patch in migration script

Releases: 6.0
Fixes: #42549

Change-Id: I24ce34f2314bf0648830822242fef2d38fe9c3f0
Reviewed-on: http://review.typo3.org/16072
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
6 years ago[TASK] Change namespace and classname of ObjectStorage
Alexander Schnitzler [Wed, 31 Oct 2012 10:53:42 +0000 (11:53 +0100)]
[TASK] Change namespace and classname of ObjectStorage

Releases: 6.0
Fixes: #42549
Change-Id: I6ff8f42a53e47fe2e5d83a8a3c4baec8753a5291
Reviewed-on: http://review.typo3.org/16071
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
6 years ago[TASK] Move ObjectStorage from Generic to Persistence
Alexander Schnitzler [Wed, 31 Oct 2012 10:36:16 +0000 (11:36 +0100)]
[TASK] Move ObjectStorage from Generic to Persistence

Actually move the file without adjusting
the namespace.

Fixes: #42545
Releases: 6.0

Change-Id: I445e2442231bfed3fbf6132735ad92084f60dca5
Reviewed-on: http://review.typo3.org/16070
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
6 years ago[TASK] Remove ext_autoload.php
Helmut Hummel [Tue, 30 Oct 2012 22:11:36 +0000 (23:11 +0100)]
[TASK] Remove ext_autoload.php

The ext_autoload.php was only there for compatibility.
This is completely handled through the class alias
mapping. The testcase classes are automatically
handled by the autoloader.

Change-Id: I1f8e4539a1b924729b3553bc56c80aa939368131
Releases: 6.0
Reviewed-on: http://review.typo3.org/16055
Reviewed-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Cleanup files in persistence
Helmut Hummel [Tue, 30 Oct 2012 20:25:17 +0000 (21:25 +0100)]
[TASK] Cleanup files in persistence

Second commit to finalize the cleanup.

Fixes: #42504
Releases: 6.0
Change-Id: If9d108163c58d3b5216e8136603b808c822cba17
Reviewed-on: http://review.typo3.org/16053
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Remove duplicate files in persistence
Helmut Hummel [Tue, 30 Oct 2012 20:08:51 +0000 (21:08 +0100)]
[TASK] Remove duplicate files in persistence

The namespaceing script messed up the persistence
of Extbase. So duplicate files have to be removed.

For keeping git history, Manager.php will be
renamed to PersistenceManager.php in an additional commit.

Fixes: #42504
Releases: 6.0
Change-Id: I9f26e8f8ced0a992e88b455c2d823401d993d9e9
Reviewed-on: http://review.typo3.org/16034
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years agoRevert "[BUGFIX] Support plugins in namespaced extensions"
Ingo Pfennigstorf [Tue, 30 Oct 2012 12:22:38 +0000 (13:22 +0100)]
Revert "[BUGFIX] Support plugins in namespaced extensions"

This reverts commit 64b5012326858f73c2e093812a9abb9ad82db50c

Change-Id: I54276eb77d3b8c2a7a013cc2c0216f92719c1b67
Reviewed-on: http://review.typo3.org/16039
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Support plugins in namespaced extensions
Aske Ertmann [Tue, 9 Oct 2012 13:16:21 +0000 (15:16 +0200)]
[BUGFIX] Support plugins in namespaced extensions

The function registerPlugin doesn't handle namespaced extension keys
differently than normal extension keys, leading to being unable to
read the configuration set in the configurePlugin function.
In the configurePlugin the vendor name is stripped from the extension name,
but the same is not done in registerPlugin. This leads to it being
impossible to select the plugin in the backend when inserting/editing a
plugin content element.

Change-Id: I5fda7631e59262c93ca4955eb262a824ed9e8231
Fixes: #41785
Releases: 6.0
Reviewed-on: http://review.typo3.org/15440
Reviewed-by: Aske Ertmann
Tested-by: Aske Ertmann
Reviewed-by: Ingo Pfennigstorf
Tested-by: Ingo Pfennigstorf
6 years ago[TASK] Use core interface for accessible objects
Helmut Hummel [Tue, 30 Oct 2012 08:45:17 +0000 (09:45 +0100)]
[TASK] Use core interface for accessible objects

Instead of using the interface present in the phpunit
extension, use the interface of the core which has
been introduced recently.

Change-Id: I1497ec824ea3c2baecc612644e703efefaf00f96
Resolves: #42468
Releases: 6.0
Reviewed-on: http://review.typo3.org/16030
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Remove forceCharset references from LocalizationUtility
Ingo Pfennigstorf [Mon, 29 Oct 2012 14:46:37 +0000 (15:46 +0100)]
[TASK] Remove forceCharset references from LocalizationUtility

Since TYPO3 4.7 the forceCharset parameter in TYPO3_CONF_VARS['BE'] is
not needed anymore. This removes references to that setting from
LocalizationUtility.

Fixes: #42484
Releases: 6.0, 4.7

Change-Id: Ic0794865cf6def87abbcf4a8afcd845bfa2e2448
Reviewed-on: http://review.typo3.org/16011
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Ingo Pfennigstorf
Tested-by: Ingo Pfennigstorf
6 years ago[BUGFIX] NotEmpty Validator does not work with arrays and objects
Ingo Pfennigstorf [Tue, 18 Sep 2012 16:08:55 +0000 (18:08 +0200)]
[BUGFIX] NotEmpty Validator does not work with arrays and objects

This patch resolves the problem that empty arrays are not correctly
validated when using the @validate NotEmpty annotation.

Change-Id: Ifd758b59b48a38a5148561aaed52b5932c61ef42
Fixes: #40683
Releases: 6.0, 4.7, 1.4, 1.3
Reviewed-on: http://review.typo3.org/14707
Reviewed-by: Stefan Neufeind
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
6 years ago[TASK] Add phpdoc-comments for variables
Nicole Cordes [Sat, 13 Oct 2012 16:58:47 +0000 (18:58 +0200)]
[TASK] Add phpdoc-comments for variables

Add phpdoc comments for variables for better code completion.

Change-Id: I6cc31bfb4101ee10fef3dd91195d2cf24346f397
Releases: 6.0
Fixes: #42468
Reviewed-on: http://review.typo3.org/15576
Reviewed-by: Ingo Pfennigstorf
Tested-by: Ingo Pfennigstorf
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
6 years ago[BUGFIX] Removed trash files and their references
Alexander Schnitzler [Sun, 28 Oct 2012 18:47:33 +0000 (19:47 +0100)]
[BUGFIX] Removed trash files and their references

During the automatic namespace convertion
something went wrong and generated empty
trash files. This patch removes them and
their references.

Releases: 6.0
Fixes: #42459
Change-Id: I651a7b291eedb8128b7b723cd06b7af9098f0e7b
Reviewed-on: http://review.typo3.org/15996
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
6 years ago[CLEANUP] Remove old SVN comments
Alexander Schnitzler [Mon, 29 Oct 2012 10:01:24 +0000 (11:01 +0100)]
[CLEANUP] Remove old SVN comments

Releases: 6.0
Fixes: #42469
Change-Id: I004754cb05d06d2e3b91a41bde5657bb69d0f6b4
Reviewed-on: http://review.typo3.org/16004
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
6 years ago[BUGFIX] Fix mismatches between count of param in phpdoc and function-signature
Stefan Neufeind [Sat, 20 Oct 2012 19:50:36 +0000 (21:50 +0200)]
[BUGFIX] Fix mismatches between count of param in phpdoc and function-signature

Change-Id: Iec8cd64b36e758878619c8277b146e45e834d46a
Fixes: #42232
Releases: 6.0
Reviewed-on: http://review.typo3.org/15841
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Add explanation for $configurationType
Michael Bakonyi [Sat, 27 Oct 2012 18:27:16 +0000 (20:27 +0200)]
[TASK] Add explanation for $configurationType

Add explanation for constants used in method $configurationType

Resolves: #39981
Releases: 6.0

Change-Id: If2e1d937fd8db3cba5ef1d66b030c47b7687106f
Reviewed-on: http://review.typo3.org/15983
Reviewed-by: Ingo Pfennigstorf
Tested-by: Ingo Pfennigstorf
6 years ago[BUGFIX] Fix namespace related bugs in DebuggerUtility
Alexander Schnitzler [Fri, 26 Oct 2012 10:09:53 +0000 (12:09 +0200)]
[BUGFIX] Fix namespace related bugs in DebuggerUtility

Releases: 6.0
Fixes: #42004
Change-Id: Iec152b3f0543d3e2662273d54e3bf7c7666699d5
Reviewed-on: http://review.typo3.org/15946
Reviewed-by: Mattias Nilsson
Reviewed-by: Ingo Pfennigstorf
Tested-by: Ingo Pfennigstorf
6 years ago[TASK] Clean up testcases to use getAccessibleMock() function
Stefan Neufeind [Fri, 19 Oct 2012 21:07:43 +0000 (23:07 +0200)]
[TASK] Clean up testcases to use getAccessibleMock() function

The getAccessibleMock() function was moved to the BaseTestCase class.
For maintenance reasons this function should be used and old references
to getMock(buildAccessibleProxy()) construct converted.

Change-Id: I3d881d037ba5896827340201144fc43b62350b83
Resolves: #42195
Releases: 6.0, 4.7, 1.4, 1.3
Reviewed-on: http://review.typo3.org/15825
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Tested-by: Stefan Neufeind
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Fix typo: seperator -> separator
Helmut Hummel [Fri, 19 Oct 2012 13:05:34 +0000 (15:05 +0200)]
[TASK] Fix typo: seperator -> separator

Change-Id: Ie74d480e93693fdbc1d66e6e78efc73719322728
Resolves: #42174
Releases: 6.0
Reviewed-on: http://review.typo3.org/15821
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years agoRevert "[BUGFIX] Property mapper: Exception not thrown but skipped"
Helmut Hummel [Fri, 19 Oct 2012 11:26:35 +0000 (13:26 +0200)]
Revert "[BUGFIX] Property mapper: Exception not thrown but skipped"

This reverts commit 637f534d70680cdbeb3483b08044c95093e53888

Change-Id: I08cc3c4c890a7a85a0b1818a97cb0c21382989a8
Reviewed-on: http://review.typo3.org/15814
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Replace deprecated calls in Repository
Marc Bastian Heinrichs [Fri, 12 Oct 2012 12:51:38 +0000 (14:51 +0200)]
[BUGFIX] Replace deprecated calls in Repository

Repository class uses deprecated calls of persistenceManager for
getting the backend and session singletons. Replace it with dependency
injection.

Change-Id: I492d0fc3aeafd60dcae738f3f120aa1ef507205f
Fixes: #35869
Releases: 1.4, 4.7, 6.0
Reviewed-on: http://review.typo3.org/10262
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Change class name hash generation to md5
Alexander Schnitzler [Sat, 13 Oct 2012 14:17:12 +0000 (16:17 +0200)]
[BUGFIX] Change class name hash generation to md5

Releases: 6.0
Fixes: #41951
Change-Id: I571f2731616e6d1701c5fb02809c9f17e9822164
Reviewed-on: http://review.typo3.org/15559
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Fix broken table name mapping for namespaced extension models
Anja Leichsenring [Mon, 8 Oct 2012 06:23:29 +0000 (08:23 +0200)]
[BUGFIX] Fix broken table name mapping for namespaced extension models

With the introduction of namespaces came an additional
resolving mechanism for tablenames. The names for tables that belong
to an extension (not sysext) miss the last part of their name.

This patch applies the missing class name part to the algorithm.

Change-Id: Ie804fc5aa211b51d7f79716156ad07daaa634e36
Fixes: #41662
Releases: 6.0
Reviewed-on: http://review.typo3.org/15386
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Markus Günther
Tested-by: Markus Günther
6 years ago[BUGFIX] Fix generation of class schema for namespaced arguments
Helmut Hummel [Sat, 13 Oct 2012 13:14:24 +0000 (15:14 +0200)]
[BUGFIX] Fix generation of class schema for namespaced arguments

When creating argument objects extbase tries to generate
a class schema if the argument is an object. This did
not work for namespaced classes as they have not been
recognized yet.

On the way add some test cases for the TypeHandlingService
as it is related to this.

Change-Id: Ie8ee8f4ffd4fa52814a3332e45c659e2183ee201
Fixes: #41948
Releases: 6.0
Reviewed-on: http://review.typo3.org/15554
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
Reviewed-by: Nico de Haen
Tested-by: Nico de Haen
Reviewed-by: Markus Günther
Tested-by: Markus Günther
6 years ago[BUGFIX] Query Generation creates invalid query in BE scope
Anja Leichsenring [Fri, 12 Oct 2012 07:15:31 +0000 (09:15 +0200)]
[BUGFIX] Query Generation creates invalid query in BE scope

While in Backend scope, no $GLOBALS['TSFE'] is available and there
is no check in place nor a fallback to prevent extbase from generating
incomplete or empty query contraints.

This patch adds the missing check and fallback to the sys_language_uid
constraint.

Change-Id: I2ed9eb01ba83ce0763c3e692a1e9ff05147a49e1
Fixes: #41904
Releases: 6.0
Reviewed-on: http://review.typo3.org/15517
Tested-by: Wouter Wolters
Reviewed-by: Markus Günther
Tested-by: Markus Günther
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Fix generation of class name hash
Alexander Schnitzler [Fri, 12 Oct 2012 16:44:19 +0000 (18:44 +0200)]
[BUGFIX] Fix generation of class name hash

* replaced sha1 with str_replace

Change-Id: I787123ddd4d7cc4cece94071cb0988660ce1207c
Fixes: #41933
Releases: 6.0
Reviewed-on: http://review.typo3.org/15536
Reviewed-by: Christian Mueller
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Markus Günther
Tested-by: Markus Günther
6 years ago[BUGFIX] Correct link to first page in BE paginator widget
Helmut Hummel [Thu, 11 Oct 2012 21:38:45 +0000 (23:38 +0200)]
[BUGFIX] Correct link to first page in BE paginator widget

The link to the first page in the paginator widget is incorrect if
it's used in a backend module. Unsetting the arguments must be done
by handling the arrays.
Thanks to Nicole Cordes.

Fixes: #41614
Releases: 6.0

Change-Id: I2c4b88784c808ae587e0b2d7fde34feb53de2de4
Reviewed-on: http://review.typo3.org/15339
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Respect namespaced models in the reflection service
Ingo Pfennigstorf [Sat, 8 Sep 2012 20:40:33 +0000 (22:40 +0200)]
[BUGFIX] Respect namespaced models in the reflection service

This fixes the reflection service, so that repository classes
are found for namespaced models.

Change-Id: Id7be0f2d01ea480a1db7a0b9ab41785c0a1e143b
Fixes: #40743
Releases: 6.0
Reviewed-on: http://review.typo3.org/14466
Reviewed-by: Stefan Neufeind
Reviewed-by: Aske Ertmann
Reviewed-by: Sebastian Michaelsen
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Property Validation with Namespaces
Ingo Pfennigstorf [Sat, 8 Sep 2012 20:32:46 +0000 (22:32 +0200)]
[BUGFIX] Property Validation with Namespaces

This fixes the validation of properties in namespaced TYPO3.

Change-Id: I6a69f9e2890c71c91b572a991acbfb1a6760dcf5
Fixes: #40748
Releases: 6.0
Reviewed-on: http://review.typo3.org/14463
Reviewed-by: Stefan Neufeind
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[TASK] Provide class alias file for extbase
Thomas Maroschik [Wed, 26 Sep 2012 14:33:59 +0000 (16:33 +0200)]
[TASK] Provide class alias file for extbase

Change-Id: I33c1a735bb4500f2e34b297a4e252edab7bfc7a0
Resolves: #41385
Relates: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/15087
Reviewed-by: Ingo Pfennigstorf
Tested-by: Ingo Pfennigstorf
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[TASK] Introduce base class for PHPUnit tests
Markus Klein [Fri, 21 Sep 2012 15:55:39 +0000 (17:55 +0200)]
[TASK] Introduce base class for PHPUnit tests

Resolves: #41171
Releases: 6.0

Change-Id: I7274abf41766d16eabc5f4a127a9af6ad450066e
Reviewed-on: http://review.typo3.org/14857
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Update version number of all sysexts to 6.0.0
Markus Klein [Sat, 22 Sep 2012 17:16:47 +0000 (19:16 +0200)]
[TASK] Update version number of all sysexts to 6.0.0

Fixes: #41261
Releases: 6.0

Change-Id: I0d927427fd5acfb12dc4c75a55f582f3ff05e596
Reviewed-on: http://review.typo3.org/14931
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Remove PHP warnings in request
Ingo Pfennigstorf [Fri, 21 Sep 2012 09:21:14 +0000 (11:21 +0200)]
[BUGFIX] Remove PHP warnings in request

Fixes PHP warnings if the controllerObjectName is not a valid class.

Change-Id: I0edc3cfb30593adac97740afe0443efc1a88faed
Fixes: #27862
Releases: 6.0
Reviewed-on: http://review.typo3.org/14811
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Mueller
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Make all classes non final
Helmut Hummel [Sat, 22 Sep 2012 09:28:45 +0000 (11:28 +0200)]
[TASK] Make all classes non final

Defining a class as final does not help and only causes troubles,
especially when creating unit tests, because a final classes
cannot be mocked.

Remove the final statement for all classes to get rid of
these problems.

Change-Id: Icbf574dacd5c3b2bf1de2333a065b0eac838ea98
Resolves: #41235
Releases: 6.0
Reviewed-on: http://review.typo3.org/14905
Reviewed-by: Georg Ringer
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Fix Exception Class Name
Helmut Hummel [Fri, 21 Sep 2012 20:00:56 +0000 (22:00 +0200)]
[BUGFIX] Fix Exception Class Name

During renaming of classes one exception class name has been forgotten.
Rename Exception\InvalidSource to Exception\InvalidSourceException

Change-Id: Ia357c25f2489ffff9fb2023d4997a2aabcc3d501
Resolves: #41210
Releases: 6.0
Reviewed-on: http://review.typo3.org/14874
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Fix class naming and alias map after namespace change
Helmut Hummel [Fri, 21 Sep 2012 16:01:23 +0000 (18:01 +0200)]
[TASK] Fix class naming and alias map after namespace change

Change-Id: I3e0f6d9aa0e5d8680213e3afe6db58d773b54c0d
Resolves: #41131
Releases: 6.0
Reviewed-on: http://review.typo3.org/14843
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Fix translation fallback
Xavier Perseguers [Fri, 31 Aug 2012 12:37:10 +0000 (14:37 +0200)]
[BUGFIX] Fix translation fallback

If the target for the translation does not exist, we have to
fallback to the default language, which is guaranteed to have
a target.

Change-Id: I7c4055999df1211a5f88bf3eeadc98af568372ea
Fixes: #36905
Fixes: #39569
Releases: 6.0, 4.7, 4.6
Reviewed-on: http://review.typo3.org/13039
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[TASK] Remove superfluous parenthesis in sysexts
Arvid Jakobsson [Mon, 17 Sep 2012 19:39:38 +0000 (21:39 +0200)]
[TASK] Remove superfluous parenthesis in sysexts

Superfluous brackets in extbase after namespaces move

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: I0c72e4b899db7c87b2513f8546012bbb815a7220
Resolves: #41015
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14677
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[TASK] Adopt Extbase to the Autoloader -> ClassLoader name change
Thomas Maroschik [Tue, 11 Sep 2012 17:19:41 +0000 (19:19 +0200)]
[TASK] Adopt Extbase to the Autoloader -> ClassLoader name change

Change-Id: If464fbdacbd278d77a1e03a7df395d5a771642ea
Resolves: #40830
Related: #40095
Depends: I87da4bb2ef0420a94d1d155edde500c1aa96894a
Reviewed-on: http://review.typo3.org/14523
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Broken backups in BackendConfigurationManagerTest
Christian Kuhn [Mon, 10 Sep 2012 13:43:28 +0000 (15:43 +0200)]
[BUGFIX] Broken backups in BackendConfigurationManagerTest

BackendConfigurationManagerTest fiddles with several $GLOBALS but
incompletly resets to previous state in tearDown(). This has side
effects to tests executed afterwards and is fixed with the patch.

Change-Id: Id3093494fc3b08b997eddc86590d85ee3f9588c9
Resolves: #40793
Releases: 6.0
Reviewed-on: http://review.typo3.org/14497
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Incomplete mocking and backups it tests
Christian Kuhn [Sun, 9 Sep 2012 09:55:21 +0000 (11:55 +0200)]
[BUGFIX] Incomplete mocking and backups it tests

Fix two systematical warnings raised by running the unit tests:

* The DataMapperTest mocks Persistence\Generic\Mapper\DataMap which
raises warnings that the mocked class expects two constructor arguments
that are not given. The mocks are adapted to not call the constructor.

* Incomplete backups in ExtensionUtilityTest destroys
$GLOBALS['TYPO3_DB'] database handle. Fixed by using the usual
$backupGlobals and blackList code from other tests.

Change-Id: I14a22bb2e65ff2f751466e63d280d5fdf5f9be17
Resolves: #40768
Releases: 6.0
Reviewed-on: http://review.typo3.org/14474
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Declare LocalizationUtility::translateFileReference static
Christian Kuhn [Wed, 29 Aug 2012 10:59:02 +0000 (12:59 +0200)]
[BUGFIX] Declare LocalizationUtility::translateFileReference static

protected translateFileReference() is not declared static, like the
rest of the class methods. This leads to strict errors.

Change-Id: I63396e69f4bb3d36c7784c1a884dea003c89ecc4
Fixes: #40377
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/14186
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] TypeHandlingService throws Exception for StorageObjects
Nicole Cordes [Tue, 28 Aug 2012 09:27:34 +0000 (11:27 +0200)]
[BUGFIX] TypeHandlingService throws Exception for StorageObjects

On using the old ObjectStorage class the TypehandlingService throws an
exception. This patch adds old class name to type handling again.

Change-Id: Iad841c1ba19ce8b701c549e1b2dcaca86f33a748
Fixes: #40290
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14147
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] fix Mvc/Request builds old classnames
Anja Leichsenring [Mon, 27 Aug 2012 21:35:37 +0000 (23:35 +0200)]
[BUGFIX] fix Mvc/Request builds old classnames

This bugfix builds the classname after the new namespaced schema
@vendor\@extension\@subpackage\@controller
The vendor is default set to TYPO3\CMS by now.

Change-Id: Ie834fb64ee591f7779bd587982349de96e177162
Fixes: #40243
Relates: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14145
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Fix old propertymapper checking target with namespace
Sebastian Fischer [Mon, 27 Aug 2012 04:35:11 +0000 (06:35 +0200)]
[BUGFIX] Fix old propertymapper checking target with namespace

The propertymapper checks if the target is an object by checking on
is_string and an '_' in the string. Since namespaces are in use it
needs to check on \

Change-Id: I1e664995733fa1438a4df62f0e41758b22045692
Fixes: #40242
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14124
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
6 years ago[BUGFIX] Fixed missing class mapping without TS
Alexander Schnitzler [Sun, 26 Aug 2012 17:01:55 +0000 (19:01 +0200)]
[BUGFIX] Fixed missing class mapping without TS

If no Root template is found the class mapping
of extbase is not loaded, so e.g. the
persistenceManager is not found any more.

Change-Id: I51359e9e3bb6e11c32425bb5740047d5f0403750
Releases: 6.0
Fixes: #40236
Reviewed-on: http://review.typo3.org/14118
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Fix classes without or broken namespace
Alexander Schnitzler [Sun, 26 Aug 2012 15:38:15 +0000 (17:38 +0200)]
[BUGFIX] Fix classes without or broken namespace

The update script unfortunetly didn't successfully
rename all classes in Extbase, so I renamed the
remaining ones manually.

Change-Id: Ia084593b8e9bf13ba487ab3b430eddf9b254d85e
Fixes: #40224
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14112
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[CLEANUP] General code cleanup
Alexander Schnitzler [Sun, 26 Aug 2012 11:10:21 +0000 (13:10 +0200)]
[CLEANUP] General code cleanup

* Cleaned up wrong PHPDoc
* Removed unused variables
* Added missing fields
* Fixed type incompatibility

Change-Id: I3ecc49ceb25458dda285cc4e005c5c2d44112100
Fixes: #40224
Releases: 6.0
Reviewed-on: http://review.typo3.org/14106
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Subrequests can't be resolved
Nicole Cordes [Fri, 24 Aug 2012 23:17:29 +0000 (01:17 +0200)]
[BUGFIX] Subrequests can't be resolved

This patch fixes the resolution of the controller object name when using
widget controller.

Change-Id: I003e7d6c7893b3519252f69b097375b741c5cf73
Fixes: #40157
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14059
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Make Cli\Command Namespace aware
Thomas Maroschik [Sun, 26 Aug 2012 00:08:37 +0000 (02:08 +0200)]
[BUGFIX] Make Cli\Command Namespace aware

Change-Id: I2e9247cac7c2df58637ea43447ac195628292b80
Fixes: #40219
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14101
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Unit tests after namespace switch
Christian Kuhn [Sat, 25 Aug 2012 19:07:39 +0000 (21:07 +0200)]
[BUGFIX] Unit tests after namespace switch

Change-Id: Ibb5b34bcefe68e7399ced84e756c24bfaf261248
Resolves: #40211
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14092
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Naming clash: Fix several unit test failures
Christian Kuhn [Sat, 25 Aug 2012 10:53:43 +0000 (12:53 +0200)]
[BUGFIX] Naming clash: Fix several unit test failures

The move of classes in Persistence area of extbase to subfolder 'generic'
confused the refactor script a bit. The patch fixes several fatals that
especially occur in the unit test.

Change-Id: I06ae18030e8659ce1251ef87e3d634a65ddbcec4
Resolves: #40150
Related: #40095
Related: #35876
Releases: 6.0
Reviewed-on: http://review.typo3.org/14067
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Interface Tx_Scheduler_AdditionalFieldProvider' not found
Tymoteusz Motylewski [Fri, 24 Aug 2012 22:56:27 +0000 (00:56 +0200)]
[BUGFIX] Interface Tx_Scheduler_AdditionalFieldProvider' not found

Fixes wrong class names in Extbase scheduler.

Change-Id: I5117f8caebfda9249499ac57c88019846c80886e
Related: #40095
Fixes: #40156
Release: 6.0
Reviewed-on: http://review.typo3.org/14058
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Reanimate unit tests
Christian Kuhn [Fri, 24 Aug 2012 16:33:39 +0000 (18:33 +0200)]
[BUGFIX] Reanimate unit tests

Make phpunit backend module for extbase tests load again

Change-Id: Ib3e05e343d2f34185c52727f16ede1331332b7ca
Resolves: #40135
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14046
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Make extbase tests run again
Thomas Maroschik [Fri, 24 Aug 2012 12:02:38 +0000 (14:02 +0200)]
[TASK] Make extbase tests run again

Change-Id: Ib6475e5aed3633672c30a855edbf6c71b938510c
Resolves: #40119
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14034
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Namespace classes
Thomas Maroschik [Wed, 17 Oct 2012 20:25:57 +0000 (22:25 +0200)]
[TASK] Namespace classes

Change-Id: I403aee9d244a65e51547b21dac3b1228ffd3478e

6 years ago[TASK][WIP] Move non class code back to source files
Thomas Maroschik [Wed, 17 Oct 2012 19:05:05 +0000 (21:05 +0200)]
[TASK][WIP] Move non class code back to source files

Change-Id: I916ad5a3a24864a52e945aeb66e6f997b8e6fabd

6 years ago[TASK][WIP] Move classes to new locations
Thomas Maroschik [Wed, 17 Oct 2012 15:23:50 +0000 (17:23 +0200)]
[TASK][WIP] Move classes to new locations

Change-Id: Iaae73adcbba323ed5ca903e38f0b2f2e06f497e7