9 years ago[+BUGFIX] correct warning in ObjectStorage & LazyObjectStorage
Felix Oertel [Wed, 13 Apr 2011 13:06:32 +0000 (15:06 +0200)]
[+BUGFIX] correct warning in ObjectStorage & LazyObjectStorage

We got this little private warning, telling people to use
getFirst() instead of PHP's current() on objectStorages
but there is no getFirst(). Instead one can call rewind()
and current() on the ObjectStorage.

Change-Id: I1cdb392942ff800365b3dd87e703523cd3bac7b0

9 years agoMerge "[+TASK] improve exception message in Argument"
Sebastian Kurfuerst [Fri, 15 Apr 2011 06:16:22 +0000 (08:16 +0200)]
Merge "[+TASK] improve exception message in Argument"

9 years agoMerge "[+BUGFIX] Avoiding cHash for nonCacheable actions prevent action from being...
Bastian Waidelich [Wed, 13 Apr 2011 15:02:18 +0000 (17:02 +0200)]
Merge "[+BUGFIX] Avoiding cHash for nonCacheable actions prevent action from being called"

9 years ago[~CLEANUP] some smaller comment cleanups
Felix Oertel [Mon, 11 Apr 2011 21:43:13 +0000 (23:43 +0200)]
[~CLEANUP] some smaller comment cleanups

Change-Id: I915716879ef32bad2f43ede2c9621553c9a26b1e

9 years agoMerge "[~CLEANUP] apply naming convention for flexForms"
Felix Oertel [Tue, 12 Apr 2011 19:53:49 +0000 (21:53 +0200)]
Merge "[~CLEANUP] apply naming convention for flexForms"

9 years ago[+TASK] Extbase: Moved static cache utility class to a service
Bastian Waidelich [Fri, 18 Mar 2011 17:54:19 +0000 (18:54 +0100)]
[+TASK] Extbase: Moved static cache utility class to a service

Relates to: #13864

Change-Id: Ie5360a9e898d9173af7e5bcc567d98113f884421

9 years ago[+TASK] improve exception message in Argument
Felix Oertel [Mon, 11 Apr 2011 10:13:30 +0000 (12:13 +0200)]
[+TASK] improve exception message in Argument

When mapping or trying to map objects, the propertyMapper
leaves error messages in the mappingResults for every mapping
that failed.

If the Argument fails to map one object required by the
controllerAction, it throws an exception but it does not
include the mapping errors. Thus it is hard to find the reason(s)
an object could not be mapped.

* add mapping errors to exception

Change-Id: Icfca5eab5c9b243900ab5f34efd002a938a6a39a

9 years agoMerge "[+BUGFIX] MVC: Make forwarding of objects work"
Sebastian Kurfuerst [Tue, 5 Apr 2011 06:32:21 +0000 (08:32 +0200)]
Merge "[+BUGFIX] MVC: Make forwarding of objects work"

9 years agoMerge "Performance tuning in container by moving some information into the cached...
Sebastian Kurfuerst [Tue, 5 Apr 2011 06:30:41 +0000 (08:30 +0200)]
Merge "Performance tuning in container by moving some information into the cached ClassInfo object."

9 years agoPerformance tuning in container by moving some information into the cached
Timo Schmidt [Mon, 21 Mar 2011 20:35:49 +0000 (21:35 +0100)]
Performance tuning in container by moving some information into the cached
ClassInfo object.

Change-Id: Iabd26579e774145cd39ee87edec3d3392e165ee5

9 years ago[~BUGFIX] avoid fe_user's type to be overridden
Felix Oertel [Wed, 30 Mar 2011 16:05:20 +0000 (18:05 +0200)]
[~BUGFIX] avoid fe_user's type to be overridden

Extbase's ext_tables.php overrides the fe_user's type in TCA ctrl-
section because of a wrong if-statement.

* Fix small mistake in if-condition

Change-Id: I61d47e9161b18fc05914bd93043f3d441fc8f033

9 years ago[+BUGFIX] Avoiding cHash for nonCacheable actions prevent action from being called
Bastian Waidelich [Tue, 22 Mar 2011 15:25:22 +0000 (16:25 +0100)]
[+BUGFIX] Avoiding cHash for nonCacheable actions prevent action from being called

With #8565 cHash is only appended for calls to cachable actions
This has the side effect, that calling non-cacheable actions
from a cached action on the same page fails to execute the
target action.
This fix reverts the changes from #8565 as we couldn't find
a better solution for now. See #13970 for details.

Change-Id: I0aebbca4a8df37ba7b7b5b63ceb0962990d814c7
Related: #13970

9 years agoMerge "[+BUGFIX] Persistence: return ObjectCount return value as an integer"
Sebastian Kurfuerst [Tue, 22 Mar 2011 07:46:08 +0000 (08:46 +0100)]
Merge "[+BUGFIX] Persistence: return ObjectCount return value as an integer"

9 years ago[+BUGFIX] MVC: Make forwarding of objects work
Marc Bastian Heinrichs [Mon, 21 Mar 2011 08:19:27 +0000 (09:19 +0100)]
[+BUGFIX] MVC: Make forwarding of objects work

When setValue() on Controller_Argument is used with an already mapped
object with the correct datatype, don't try to transform the value.

Fixes: #9687

Change-Id: I95310d85be36dc39bde815fddde042052033a3f4

9 years ago[~CLEANUP] correct function parameter types
Marc Bastian Heinrichs [Sun, 20 Mar 2011 22:45:15 +0000 (23:45 +0100)]
[~CLEANUP] correct function parameter types

Change-Id: I96c0a9ca6b5eddea312745bc1556a963ea7abf6c

9 years ago[+BUGFIX] Persistence: return ObjectCount return value as an integer
Marc Bastian Heinrichs [Sun, 20 Mar 2011 18:13:14 +0000 (19:13 +0100)]
[+BUGFIX] Persistence: return ObjectCount return value as an integer

As phpdoc states, the function getObjectCountByQuery should return an
integer and not just the number as string, which is the case when
returning the result of COUNT(*). Thanks to Georg Ringer.

Fixes: #13151

Change-Id: I40f0c675dea56949b154fbc1f29b32f25d2ca4cc

9 years agoMerge "[+FEATURE] Extbase: Enable Dependency Injection for Domain Models"
Bastian Waidelich [Mon, 14 Mar 2011 09:56:19 +0000 (10:56 +0100)]
Merge "[+FEATURE] Extbase: Enable Dependency Injection for Domain Models"

9 years ago[+BUGFIX] Revert incorrect deletion of Query::count() & Query::withUid()
Bastian Waidelich [Thu, 10 Mar 2011 10:33:33 +0000 (11:33 +0100)]
[+BUGFIX] Revert incorrect deletion of Query::count() & Query::withUid()

The methods Tx_Extbase_Persistence_Query::count() and
Tx_Extbase_Persistence_Query::withUid() are deprecated.
They have been removed in

But the deletion is incomplete and leads to a fatal error
We'll have to keep count() until version 1.5 according to the
TYPO3 release policy.

WithUid() is already deprecated since extbase 1.2 so it could
be removed with 1.4. But it has to be removed from the interface
and from all parts in the core that are still using it (currently two)

Relates: #13745

Change-Id: I390edfe3de1fe92a27723dcccdd6a6d098f5ac07

9 years ago[~CLEANUP] apply naming convention for flexForms
Felix Oertel [Wed, 9 Mar 2011 20:41:40 +0000 (21:41 +0100)]
[~CLEANUP] apply naming convention for flexForms

We agreed to write "flexForm" lowerCamelCased.

* change flexform to flexForm
* change Flexform to FlexForm

Change-Id: Ied2f298e345093106cc2d282544faf512ef91456

9 years agoMerge "[+TASK] Move FlexForm parsing to a dedicated Service"
Felix Oertel [Wed, 9 Mar 2011 20:11:40 +0000 (21:11 +0100)]
Merge "[+TASK] Move FlexForm parsing to a dedicated Service"

9 years ago[+TASK] Move FlexForm parsing to a dedicated Service
Felix Oertel [Mon, 14 Feb 2011 17:20:05 +0000 (18:20 +0100)]
[+TASK] Move FlexForm parsing to a dedicated Service

The protected FlexForm conversion methods in the FrontendConfigurationManager
are now moved to a Service class. This enables the re-use of this parsing methods
by other classes or 3rd party extensions

* move convertFlexFormContentToArray to Service class
* mark old methods deprecated
* implement unit test for FlexForm parsing

Thanks to Rens Admiraal.

Change-Id: I346e26f18d5ca5609eb69d6a869b61d746bdc9a0
Resolves: #13032

9 years agoMerge "[!!!][+BUGFIX] make backend-modules in web use new pagetree by default"
Felix Oertel [Wed, 9 Mar 2011 08:05:42 +0000 (09:05 +0100)]
Merge "[!!!][+BUGFIX] make backend-modules in web use new pagetree by default"

9 years ago[!!!][+BUGFIX] make backend-modules in web use new pagetree by default
Felix Oertel [Fri, 4 Mar 2011 09:36:01 +0000 (10:36 +0100)]
[!!!][+BUGFIX] make backend-modules in web use new pagetree by default

In TYPO3 4.5 the new pagetree was introduced. It's possible to use
this in an Extbase backend-module with the config option
'navigationComponentId' in Tx_Extbase_Utility_Extension::registerModule.

With introducing this as default config for modules in 'web', we make
all Extbase based backend-modules make use of the new pagetree.

Even though this is a breaking change, all backend-modules are asked
to use the new pagetree since TYPO3 4.5 anyway.

* make navigationComponentId=typo3-pagetree default config

Change-Id: I3f08134a58bf41c7940ac3050f6b4843988a30b4

9 years ago[~CLEANUP] smaller deprecated clean-ups
Felix Oertel [Thu, 3 Mar 2011 15:33:26 +0000 (16:33 +0100)]
[~CLEANUP] smaller deprecated clean-ups

As a backport Extbase is influenced by all the changes in FLOW. It's
important to keep both in sync and thus deprecate code which is not
in FLOW3 anymore or which has changed.

All deprecated annotations should now match the CGL and all removals
are terminated in the future.

* clean up deprecation annotation
* remove code which was deprecated long enough

Change-Id: Ic1b6217bc6c9100b6c48c5d30eca6068417265a8

9 years ago[+FEATURE] Extbase: Enable Dependency Injection for Domain Models
Bastian Waidelich [Tue, 8 Mar 2011 17:45:21 +0000 (18:45 +0100)]
[+FEATURE] Extbase: Enable Dependency Injection for Domain Models

In order to avoid the constructor to be called,
domain objects are created by using PHPs unserialize() function.
This has the side-effect, that we need to inject
dependencies "manually" for those.
This is accomplished by adding a helper function
getEmptyObject() to the Object Container.
Thanks to Pascal Jungblut for the patches!

Change-Id: I49edab54eb810abc894f3f59fe8c46cf4ddfa464
Fixes: #11311

9 years agoMerge "[+BUGFIX] (Persistence) Make Typo3QuerySettings exchangeable"
Bastian Waidelich [Mon, 7 Mar 2011 15:59:40 +0000 (16:59 +0100)]
Merge "[+BUGFIX] (Persistence) Make Typo3QuerySettings exchangeable"

9 years ago[+BUGFIX] (Persistence) Make Typo3QuerySettings exchangeable
Marc Bastian Heinrichs [Sun, 6 Mar 2011 15:59:07 +0000 (16:59 +0100)]
[+BUGFIX] (Persistence) Make Typo3QuerySettings exchangeable

Let objectManager create querySettings object by
Tx_Extbase_Persistence_QuerySettingsInterface in
Tx_Extbase_Persistence_QueryFactory and remove obsolete instanceof
check in Typo3DbBackend

Fixes: #13191

Change-Id: I5ba9dbafeb8baa13d028fdb4f15c7bc9c6dcbd91

9 years ago[+BUGFIX] (Persistence) clone setDefaultQuerySettings for new queries
Marc Bastian Heinrichs [Sun, 6 Mar 2011 15:25:47 +0000 (16:25 +0100)]
[+BUGFIX] (Persistence) clone setDefaultQuerySettings for new queries

If you set the default querySettings object for an repository the same
instance is used for any query-object created with createQuery
method. So any repository method modificating its (normaly) own
querySettings object will also modificate the defaultQuerySettings
object. Thanks to Benjamin Schulte

Fixes: #12702

Change-Id: I9c00e064dee4349735a52e1ae01c6b5d28774fe1

9 years agoMerge "[~BUGFIX] correct annotations of Tx_Extbase_Persistence_Mapper_DataMapper"
Bastian Waidelich [Mon, 7 Mar 2011 13:32:46 +0000 (14:32 +0100)]
Merge "[~BUGFIX] correct annotations of Tx_Extbase_Persistence_Mapper_DataMapper"

9 years agoMerge "[~TASK] (FlashMessages) finish the renaming of flashMessages"
Bastian Waidelich [Mon, 7 Mar 2011 13:26:22 +0000 (14:26 +0100)]
Merge "[~TASK] (FlashMessages) finish the renaming of flashMessages"

9 years ago[~BUGFIX] correct annotations of Tx_Extbase_Persistence_Mapper_DataMapper
Felix Oertel [Mon, 21 Feb 2011 20:37:22 +0000 (21:37 +0100)]
[~BUGFIX] correct annotations of Tx_Extbase_Persistence_Mapper_DataMapper

In several places the DataMapper is still annotated with it's old
classname Tx_Extbase_Persistence_DataMapper.

* replace remaining old annotations with new classname

Fixes: #13185

(Thanks to Simon Schaufelberger for the initial patch.)

Change-Id: I07cbd05be909e6d591ee1697b325b79a02a76d57

9 years ago[~TASK] (FlashMessages) finish the renaming of flashMessages
Felix Oertel [Thu, 3 Mar 2011 12:52:25 +0000 (13:52 +0100)]
[~TASK] (FlashMessages) finish the renaming of flashMessages

Membervariables holding Tx_Extbase_MVC_Controller_FlashMessages were
renamed from $flashMessage to $flashMessageContainer some time ago.
Not all declarations and getter, setter and injectors were tagged
deprecated back then.

* rename left over member variables
* tag all corresponding methods deprecated
* add call to t3lib_div::logDeprecatedFunction()
* make sure the new flashMessageContainer is used everywhere

Change-Id: Iac19c5aabed7d225362cf0a9cfa3740f37f2b3b8

9 years ago[+BUGFIX] (Configuration): Adjusted Interface to implementation
Sebastian Kurfuerst [Wed, 16 Feb 2011 06:20:41 +0000 (07:20 +0100)]
[+BUGFIX] (Configuration): Adjusted Interface to implementation

The ConfigurationManagerInterface and the ConfigurationManager
had a different API, but of course they should be the same.

Change-Id: Ifff624dfc9cb4d29482e10edae805a517b8e11b1

9 years ago[~TASK] Extbase: Raising version from 1.3.0 to 1.4.0-devel
Bastian Waidelich [Tue, 15 Feb 2011 15:43:04 +0000 (16:43 +0100)]
[~TASK] Extbase: Raising version from 1.3.0 to 1.4.0-devel

Change-Id: Ia92aa5568cced5acbcec671d7d278d4c9717446f

9 years ago[+TASK] Extbase (MVC): Removed duplicated code from RequestBuilder. Thanks to Peter...
Jochen Rau [Thu, 27 Jan 2011 15:47:33 +0000 (10:47 -0500)]
[+TASK] Extbase (MVC): Removed duplicated code from RequestBuilder. Thanks to Peter Niederlag.

Resolves #12569.

Change-Id: I4bc732dfa20ffde40d96012c6534de11bad6ec5f

9 years ago* Raising Version number to 1.3.0.
Sebastian Kurfürst [Wed, 26 Jan 2011 08:19:54 +0000 (08:19 +0000)]
* Raising Version number to 1.3.0.

9 years ago[+BUGFIX] Extbase (Tests): reset added t3lib_div instances in UriBuilder & Extension...
Bastian Waidelich [Tue, 25 Jan 2011 19:38:28 +0000 (19:38 +0000)]
[+BUGFIX] Extbase (Tests): reset added t3lib_div instances in UriBuilder & Extension tests

9 years ago[+BUGFIX] Extbase (Persistence): Fixed updating of related objects. Thanks to Björn...
Jochen Rau [Tue, 25 Jan 2011 18:48:24 +0000 (18:48 +0000)]
[+BUGFIX] Extbase (Persistence): Fixed updating of related objects. Thanks to Björn Steinbrück and Bastian Waidelich for digging into this issue. Resolves #9270, #9182, #10211.

This is the second attempt after having reverted the first one in r3920. The patch includes some clean-up. Important additional changes:
* The objects within an ObjectStorage are now added to the queue. This is necessary to persist changes made to those contained objects without having changed the composition of objects.
* Moved the _memorizeCleanState() from the AbstractEntity to the AbstractDomainObject. In theory ValueObjects are immutable, but we need this as sometimes ValueObjects are stored in two steps (1. to get a UID, 2. to persist its properties). Maybe we have to recheck this for 1.4.
* Fixed some possible problems with detecting an ObjectStorage (namely SplObjectStorage->getUid()).

9 years ago[+TASK] Extbase (Persistence): Added two properties to describe a weird PHP behavior...
Jochen Rau [Tue, 25 Jan 2011 18:48:14 +0000 (18:48 +0000)]
[+TASK] Extbase (Persistence): Added two properties to describe a weird PHP behavior if calling current() on an ObjectStorage.

9 years ago[+BUGFIX] Extbase (MVC): Fixed argument order of Tx_Extbase_Utility_Extension::isActi...
Bastian Waidelich [Tue, 25 Jan 2011 17:49:33 +0000 (17:49 +0000)]
[+BUGFIX] Extbase (MVC): Fixed argument order of Tx_Extbase_Utility_Extension::isActionCacheable() call in UriBuilder

9 years ago[+TASK] Extbase (DomainObject): Added setPid() and getPid() to the DomainObjectInterf...
Jochen Rau [Tue, 25 Jan 2011 05:08:50 +0000 (05:08 +0000)]
[+TASK] Extbase (DomainObject): Added setPid() and getPid() to the DomainObjectInterface and removed the "final" keyword.

Related to #11361.

9 years ago[~TASK] Extbase: Moved isActionCacheable() from UriBuilder to Utility/Extension helpe...
Bastian Waidelich [Mon, 24 Jan 2011 16:44:45 +0000 (16:44 +0000)]
[~TASK] Extbase: Moved isActionCacheable() from UriBuilder to Utility/Extension helper class

Moved the protected method to a public static functions in Tx_Extbase_Utility_Extension
and added respective unit tests.
Note: We're not happy with all the public static functions in Utility/Extension.php
but that's currently the place for those helper functions.

9 years ago[+TASK] Extbase (Utility): implemented validation of arguments passed to sql statemen...
Felix Oertel [Mon, 24 Jan 2011 08:16:33 +0000 (08:16 +0000)]
[+TASK] Extbase (Utility): implemented validation of arguments passed to sql statements in Tx_Extbase_Utility_Cache. (resolves #11978)

9 years ago* Updated ChangeLog and raised version number to 1.3.0RC1
Sebastian Kurfürst [Fri, 21 Jan 2011 13:42:25 +0000 (13:42 +0000)]
* Updated ChangeLog and raised version number to 1.3.0RC1

9 years ago[-TASK] Extbase (Persistence): Reverting commit r3883 and r3852.
Jochen Rau [Fri, 21 Jan 2011 13:03:07 +0000 (13:03 +0000)]
[-TASK] Extbase (Persistence): Reverting commit r3883 and r3852.

Related to #9270.

9 years ago[+BUGFIX] Extbase (Object): constructor injection fails if default value for a depend...
Sebastian Kurfürst [Fri, 21 Jan 2011 13:01:39 +0000 (13:01 +0000)]
[+BUGFIX] Extbase (Object): constructor injection fails if default value for a dependency is NULL

In Container class the existence of a default value was checked with
isset($argumentInformation['defaultValue']) which returns false if
$argumentInformation['defaultValue'] === NULL.

This commit fixes this issue using array_key_exists() instead and adds a unit test.

Thanks to Lienhart Woitok for the patch!

Resolves: #11623

9 years ago[BUGFIX] Extbase (Object): Allow injection of prototypes via dependency injection
Sebastian Kurfürst [Fri, 21 Jan 2011 12:34:03 +0000 (12:34 +0000)]
[BUGFIX] Extbase (Object): Allow injection of prototypes via dependency injection

This change allows Injection of Prototypes into singletons
and prototypes. Now, all four cases are supported:

* Singletons which need Singletons (most common)
* Singletons which need Prototypes (very uncommon,
  as it usually hints at the fact that the injected
  prototype should be a singleton). In this case,
* Prototypes which need Singletons
* Prototypes which need Prototypes

All cases above are covered with unit tests, both
when using setter injection and when using constructor

Additionally, I greatly improved the unit tests, and added
working cycle detection in case of prototype objects
depending on each other.

Resolves: #12013

9 years ago[+BUGFIX] Extbase (Persistence): Use sql_free_result() in Typo3DbBackend to free...
Marc Bastian Heinrichs [Fri, 21 Jan 2011 11:46:07 +0000 (11:46 +0000)]
[+BUGFIX] Extbase (Persistence): Use sql_free_result() in Typo3DbBackend to free result memory. Resolves #10957

9 years ago[~BUGFIX] Extbase (Persistence): fixed an wrong referenced exception (resolves #12403)
Felix Oertel [Fri, 21 Jan 2011 11:41:24 +0000 (11:41 +0000)]
[~BUGFIX] Extbase (Persistence): fixed an wrong referenced exception (resolves #12403)

9 years ago[~BUGFIX] Extbase (Persistence): make Tx_Extbase_Persistence_Repository::remove(...
Felix Oertel [Fri, 21 Jan 2011 11:28:44 +0000 (11:28 +0000)]
[~BUGFIX] Extbase (Persistence): make Tx_Extbase_Persistence_Repository::remove() handle freshly created objects right. (resolves #11128)

9 years ago[~FOLLOWUP] Extbase (Utility): allow clearPageCache() to clear single, multiple and...
Felix Oertel [Fri, 21 Jan 2011 09:42:47 +0000 (09:42 +0000)]
[~FOLLOWUP] Extbase (Utility): allow clearPageCache() to clear single, multiple and all pageCaches. (resolves 11978)

9 years ago[+BUGFIX] Extbase (MVC): UriBuilder automatically added a cHash even on links to...
Franz Koch [Thu, 20 Jan 2011 22:17:40 +0000 (22:17 +0000)]
[+BUGFIX] Extbase (MVC): UriBuilder automatically added a cHash even on links to nonCacheable actions where this is not needed/recommended (resolves #8565)

9 years ago[~BUGFIX] Extbase (Persistence): made union statement on comma seperated list use...
Felix Oertel [Thu, 20 Jan 2011 21:37:36 +0000 (21:37 +0000)]
[~BUGFIX] Extbase (Persistence): made union statement on comma seperated list use find_in_set (Thanks to Marc Bastian Heinrichs) (resolves #9772)

9 years ago[+TASK] Extbase (Utility): allow clearPageCache() to clear single, multiple and all...
Felix Oertel [Thu, 20 Jan 2011 21:11:50 +0000 (21:11 +0000)]
[+TASK] Extbase (Utility): allow clearPageCache() to clear single, multiple and all pageCaches.

9 years ago[+BUGFIX] Extbase (MVC): Improve Error Handling in Request Builder
Sebastian Kurfürst [Thu, 20 Jan 2011 06:17:23 +0000 (06:17 +0000)]
[+BUGFIX] Extbase (MVC): Improve Error Handling in Request Builder

In the RequestBuilder, there is no error-handling which you get,
in case you've forgotten to configure the controllerActions in ext_localconf.php.

This patch adds some exceptions - you can't go without this config and things will break lateron anyway.

Thanks to Felix Oertel for the Patch!

Resolves: #11302

9 years ago[+TASK] Extbase (DomainObject): Added unit test to check circular dependencies.
Jochen Rau [Wed, 19 Jan 2011 21:52:44 +0000 (21:52 +0000)]
[+TASK] Extbase (DomainObject): Added unit test to check circular dependencies.

Related to #9270.

10 years ago[+BUGFIX] Extbase (Persistence): remove superfluous require_once statements
Sebastian Kurfürst [Wed, 19 Jan 2011 07:46:26 +0000 (07:46 +0000)]
[+BUGFIX] Extbase (Persistence): remove superfluous require_once statements

There are some require_once of classes that already are covered by the
Core autoloaded. This is unnecessary and also a negatively affects
performance (because require_once is rather slow). That's why these
require_once statements are dropped.

Thanks to Oliver Klee for the patch!

Resolves: #12324

10 years ago[+BUGFIX] Extbase (Tests): Remove require_once of phpunit testclasses
Sebastian Kurfürst [Wed, 19 Jan 2011 07:42:38 +0000 (07:42 +0000)]
[+BUGFIX] Extbase (Tests): Remove require_once of phpunit testclasses

The phpunit extension already automatically includes the base test
classes. So the extbase base test classes do not need the require.

Thanks to Oliver Klee for the patch!

Resolves: #12323

10 years ago[+BUGFIX] Extbase (Utility): Make _LOCAL_LANG override work with dots
Sebastian Kurfürst [Tue, 18 Jan 2011 18:00:19 +0000 (18:00 +0000)]
[+BUGFIX] Extbase (Utility): Make _LOCAL_LANG override work with dots

When dealing with Locallang files, it is a common approach to
write locallang keys with dots, as example
You can overwrite these keys easily by Typoscript _LOCAL_LANG,
and with this patch this also works with keys containing dots.

Thanks to Thomas Maroschik for the initial implementation!

Resolves: #12121

10 years ago[+BUGFIX] Extbase (Persistence): Fixed using the correct columnname for contains...
Marc Bastian Heinrichs [Tue, 18 Jan 2011 15:38:19 +0000 (15:38 +0000)]
[+BUGFIX] Extbase (Persistence): Fixed using the correct columnname for contains comparison with RELATION_HAS_MANY and empty parentKeyFieldName. Resolves #11048

10 years ago[+BUGFIX] extbase (Persistence): Added the missing pid property to the AbstractDomain...
Jochen Rau [Tue, 18 Jan 2011 14:52:18 +0000 (14:52 +0000)]
[+BUGFIX] extbase (Persistence): Added the missing pid property to the AbstractDomainModel.

* The pid property is a "special" property as the uid property.
* If your table does not contain a pid field, the property value will be NULL.
* There are now getPid() and setPid() methods available in the AbstractDomainObject.
* The support for workspaces ist still missing. You can't move objects from one page top another within a workspace view.

Related to #11361.

10 years ago[+BUGFIX] Extbase (Persistence): Language Oberlay now works with page table as well...
Jochen Rau [Tue, 18 Jan 2011 13:49:36 +0000 (13:49 +0000)]
[+BUGFIX] Extbase (Persistence): Language Oberlay now works with page table as well. Thanks to Andre Stoesel.

Resolves #11319.

10 years ago[+BUGFIX] Extbase (Reflection): Follow-up to r3854.
Jochen Rau [Tue, 18 Jan 2011 13:44:06 +0000 (13:44 +0000)]
[+BUGFIX] Extbase (Reflection): Follow-up to r3854.

Related to #10148.

10 years ago[+BUGFIX] Extbase (Persistence): The QueryObject gets cloned now in the getFirst...
Jochen Rau [Tue, 18 Jan 2011 11:34:28 +0000 (11:34 +0000)]
[+BUGFIX] Extbase (Persistence): The QueryObject gets cloned now in the getFirst() method of the QueryResult (as it was intended). Thanks to Sebastian Fischer. Resolves #11855.

10 years ago[+BUGFIX] Extbase (Bootstrap): Bootstrap calls initialize on reflectionService if...
Marc Bastian Heinrichs [Tue, 18 Jan 2011 10:44:41 +0000 (10:44 +0000)]
[+BUGFIX] Extbase (Bootstrap): Bootstrap calls initialize on reflectionService if it's already initialized. Resolves #12346, resolves #12156

10 years ago[+BUGFIX] Extbase (Persistence): Fix equals constraint with $caseSensitive FALSE...
Marc Bastian Heinrichs [Tue, 18 Jan 2011 10:39:51 +0000 (10:39 +0000)]
[+BUGFIX] Extbase (Persistence): Fix equals constraint with $caseSensitive FALSE (closing bracket missing). Thanks to Alexander Berl. Resolves #10781

10 years ago[+BUGFIX] Extbase (Reflection): ObjectAccess::isPropertyGettable works for ArrayAcces...
Sebastian Kurfürst [Tue, 18 Jan 2011 05:38:39 +0000 (05:38 +0000)]
[+BUGFIX] Extbase (Reflection): ObjectAccess::isPropertyGettable works for ArrayAccess objects

ObjectAccess::isPropertyGettable now returns TRUE if the object
implements ArrayAccess and has the specified property. This makes
getPropertyPath work correctly on ArrayAccess objects.

Resolves: #10148

10 years ago[+BUGFIX] Extbase [Persistence]: Fixed updating of 1:n related childs. Resolves ...
Jochen Rau [Tue, 18 Jan 2011 01:59:08 +0000 (01:59 +0000)]
[+BUGFIX] Extbase [Persistence]: Fixed updating of 1:n related childs. Resolves #9270, #9182, #10211.

Merge commit '3e5bbbba16521d06e49ad983ca52a7a9549eba91'

10 years ago[+FEATURE] Extbase (Configuration): Allow StoragePid to be manually defined by TS
Sebastian Kurfürst [Thu, 13 Jan 2011 19:25:21 +0000 (19:25 +0000)]
[+FEATURE] Extbase (Configuration): Allow StoragePid to be manually defined by TS

In certain cases, it is helpful to allow the storage PID
to be defined by TypoScript, so one could use stdWrap for example.
With this patch, this is possible.

Even better would be a more general solution, allowing processing
of arbitrary TS configuration with typoScript; but that's at the
moment not possible.

Credits go to Rens Admiraal for providing the patch!

Resolves: #8397

10 years ago[+BUGFIX] Extbase (Configuration): Fix warning in AbstractConfigurationManager
Sebastian Kurfürst [Thu, 13 Jan 2011 05:40:51 +0000 (05:40 +0000)]
[+BUGFIX] Extbase (Configuration): Fix warning in AbstractConfigurationManager

If there are no non cacheable actions defined for a controller, the AbstractConfigurationManager throws a warning when overriding switchable controller actions: array_intersect(): Argument 1 is not an array.

This change fixes the issue.
Resolves: #11631

10 years ago[+BUGFIX] Extbase (Object): Disabling Dependency Injection for injectSettings method
Sebastian Kurfürst [Thu, 13 Jan 2011 05:33:01 +0000 (05:33 +0000)]
[+BUGFIX] Extbase (Object): Disabling Dependency Injection for injectSettings method

Tx_Extbase_MVC_Controller_ActionController->resolveView() checks for the existence of
an injectSettings() method in a view class and calls it if found, passing on the
As Tx_Extbase_Object_Container_ClassInfoFactory->getInjectMethods() though
classifies that method as a method for dependency injection which of course fails
leading to an exception "Method is marked as setter for Dependency Injection, but
doesnt have a type annotation".

Bugfix: Make the DI container skip methods with the name
injectSettings(). This has the benefit of making sure nobody
will use that function for injections lateron, making upgrade to
FLOW3 more easy.

Resolves: #11011

10 years ago* Updating ChangeLog for 1.3.0beta4
Sebastian Kurfürst [Wed, 12 Jan 2011 15:46:12 +0000 (15:46 +0000)]
* Updating ChangeLog for 1.3.0beta4

10 years ago[+TASK] Extbase (Tests): Fixed a repository unit test so that it works in CLI mode
Bastian Waidelich [Wed, 12 Jan 2011 15:32:19 +0000 (15:32 +0000)]
[+TASK] Extbase (Tests): Fixed a repository unit test so that it works in CLI mode

10 years ago[+TASK] Extbase (Tests): Fixed Extbase unit tests
Bastian Waidelich [Wed, 12 Jan 2011 15:27:48 +0000 (15:27 +0000)]
[+TASK] Extbase (Tests): Fixed Extbase unit tests

Additionally some code cleanups and minor tweaks

This resolves: #10792

10 years ago[+BUGFIX] Extbase (Persistence): Hidden Records in Workspaces now work
Sebastian Kurfürst [Wed, 12 Jan 2011 05:02:08 +0000 (05:02 +0000)]
[+BUGFIX] Extbase (Persistence): Hidden Records in Workspaces now work

Before, if t3lib_pageSelect::getRecordOverlay returned FALSE (if
no translation is found), a fatal error occured:
PHP Catchable Fatal Error: Argument 2 passed to Tx_Extbase_Persistence_Mapper_DataMapper::getTargetType()
must be an array, boolean given, called in Persistence/Mapper/DataMapper.php

The patch fixes the issue.

Thanks to Michael Voehringer for the bugfix!

Resolves: #8679

10 years ago[~TASK] Extbase: Fixed line endings (Windows to Unix).
Jochen Rau [Tue, 4 Jan 2011 18:18:05 +0000 (18:18 +0000)]
[~TASK] Extbase: Fixed line endings (Windows to Unix).

10 years ago[~TASK] Fluid (Tests): Fixed some more testcase class names and some unit tests
Bastian Waidelich [Thu, 30 Dec 2010 23:50:39 +0000 (23:50 +0000)]
[~TASK] Fluid (Tests): Fixed some more testcase class names and some unit tests

Relates to #10792

10 years ago[+FEATURE] Extbase (Utility): Add support for custom specify custom plugin icon
Bastian Waidelich [Thu, 30 Dec 2010 14:06:28 +0000 (14:06 +0000)]
[+FEATURE] Extbase (Utility): Add support for custom specify custom plugin icon

Tx_Extbase_Utility_Extension::registerPlugin() now has a fourth parameter $pluginIconPathAndFilename
that you can set to the path of an icon, that will be displayed in the plugin dropdown in the backend.
You can use it like:
'My Plugin description',
t3lib_extMgm::extRelPath($_EXTKEY) . 'Resources/Public/Icons/someIcon.gif'

Thanks to Steffen Müller for the initial patches!

Resolves #11179

10 years ago* Raised Version Number to 1.3.0beta3.
Sebastian Kurfürst [Mon, 27 Dec 2010 07:38:16 +0000 (07:38 +0000)]
* Raised Version Number to 1.3.0beta3.

10 years ago[+BUGFIX] Extbase (Tests): Fixed Tx_Extbase_MVC_Controller_AbstractController_testcas...
Jochen Rau [Fri, 24 Dec 2010 14:51:42 +0000 (14:51 +0000)]
[+BUGFIX] Extbase (Tests): Fixed Tx_Extbase_MVC_Controller_AbstractController_testcase. Thanks to Oliver Klee. Resolves #11567.

10 years ago[BUGFIX] Extbase (Configuration): Make Extbase work again in Backend
Sebastian Kurfürst [Tue, 21 Dec 2010 10:48:06 +0000 (10:48 +0000)]
[BUGFIX] Extbase (Configuration): Make Extbase work again in Backend

In case the extbase configuration could not be loaded,
we add it explicitely so that it works in all circumstances.

10 years ago[TASK] Extbase (Bootstrap): Removed superfluous exception
Sebastian Kurfürst [Tue, 21 Dec 2010 09:34:41 +0000 (09:34 +0000)]
[TASK] Extbase (Bootstrap): Removed superfluous exception

10 years ago[TASK] Extbase (Object): Adjust doc comments
Sebastian Kurfürst [Mon, 20 Dec 2010 17:02:12 +0000 (17:02 +0000)]
[TASK] Extbase (Object): Adjust doc comments

still adding some documentation for the object container.

10 years ago[!!!][+TASK] Extbase (Object): Rewritten Object Container
Sebastian Kurfürst [Mon, 20 Dec 2010 16:56:37 +0000 (16:56 +0000)]
[!!!][+TASK] Extbase (Object): Rewritten Object Container

I have re-written the core of the Object Manager,
implementing proper dependency injection now, covered
by some unit tests (which could still be improved)...

Now, the object lifecycle method ("initializeObject")
is automatically called once an object has all of its
dependencies injected.

Additionally, Extbase (again) works in the backend
with an empty page tree.

Please thoroughly test this change!

10 years ago[+BUGFIX] Extbase (MVC): Improve Exception message
Sebastian Kurfürst [Mon, 20 Dec 2010 16:56:28 +0000 (16:56 +0000)]
[+BUGFIX] Extbase (MVC): Improve Exception message

If one misses the @dontvalidate annotation, he will
get a strange error which does not have a hint that
the @dontvalidate is missing. Now, the exception message
is extended.

10 years ago[+API] Extbase (Configuration): Adding getContentObject to API
Sebastian Kurfürst [Mon, 20 Dec 2010 16:56:23 +0000 (16:56 +0000)]
[+API] Extbase (Configuration): Adding getContentObject to API

10 years ago[+TASK] Extbase (Reflection): Added deprecation annotation to ObjectAccess::getAccess...
Bastian Waidelich [Thu, 2 Dec 2010 19:00:00 +0000 (19:00 +0000)]
[+TASK] Extbase (Reflection): Added deprecation annotation to ObjectAccess::getAccessiblePropertyNames()

To stay in sync with FLOW3, the methods getAccessibleProperties() and getAccessiblePropertyNames() to
getGettableProperties() and getGettablePropertyNames().
For compatibility reasons the old methods will stay in Extbase until version 1.5.
Note: you can now check wheter properties are settable as well

Relates to: #8534

10 years ago[+BUGFIX] Extbase (Reflection): Added PropertyNotAccessibleException that I forgot...
Bastian Waidelich [Thu, 2 Dec 2010 18:55:35 +0000 (18:55 +0000)]
[+BUGFIX] Extbase (Reflection): Added PropertyNotAccessibleException that I forgot to add in previous commit

Relates to: #8534

10 years ago[+FEATURE] Extbase (Reflection): Tx_Extbase_Reflection_ObjectAccess supports stdClass...
Bastian Waidelich [Thu, 2 Dec 2010 17:44:06 +0000 (17:44 +0000)]
[+FEATURE] Extbase (Reflection): Tx_Extbase_Reflection_ObjectAccess supports stdClass objects now

I've backported the ObjectAccess class and its unit tests from FLOW3.
Note: FLOW3's implementation allows to specify a third argument for the
method getPropertyPath() in order to support Closures.
This part is not backported as it's not compatible with PHP < 5.3.

10 years ago* Raising version to Extbase 1.3beta2a
Sebastian Kurfürst [Wed, 1 Dec 2010 12:47:57 +0000 (12:47 +0000)]
* Raising version to Extbase 1.3beta2a

10 years ago[+BUGFIX] Extbase (ConfigurationManager): FollowUp for #6067. Fixes a issue with...
Franz Koch [Wed, 1 Dec 2010 12:45:48 +0000 (12:45 +0000)]
[+BUGFIX] Extbase (ConfigurationManager): FollowUp for #6067. Fixes a issue with parsing flexform rootlevel keys not having child keys I recently came across

10 years ago[+BUGFIX] Extbase (Configuration): change the order of methods to determine the curre...
Franz Koch [Wed, 1 Dec 2010 12:35:09 +0000 (12:35 +0000)]
[+BUGFIX] Extbase (Configuration): change the order of methods to determine the current pageId for backend modules, which is used to fetch the TS framework configuration. Fixes #11205

10 years ago[+TASK] Extbase (Object): Make sure the class info cache is returning valid objects
Franz Koch [Wed, 1 Dec 2010 12:30:08 +0000 (12:30 +0000)]
[+TASK] Extbase (Object): Make sure the class info cache is returning valid objects

10 years ago* Raised version number to 1.3.0beta2
Sebastian Kurfürst [Wed, 1 Dec 2010 07:09:08 +0000 (07:09 +0000)]
* Raised version number to 1.3.0beta2
* Updated ChangeLog

10 years ago[+BUGFIX] Extbase (Persistence): Persistence_Backend::getIdentifierByObject should...
Sebastian Kurfürst [Wed, 1 Dec 2010 07:08:57 +0000 (07:08 +0000)]
[+BUGFIX] Extbase (Persistence): Persistence_Backend::getIdentifierByObject should work with LazyLoadingProxy

getIdentifierByObject should check if object is an instance of Tx_Extbase_Persistence_LazyLoadingProxy and should return the
identifier of the real object.

Resolves: #11194

10 years ago[+BUGFIX] Extbase (Configuration): slightly tweaked FrontendConfigurationManager...
Bastian Waidelich [Tue, 30 Nov 2010 15:37:12 +0000 (15:37 +0000)]
[+BUGFIX] Extbase (Configuration): slightly tweaked FrontendConfigurationManager (basically replaced explode() by t3lib_div::trimExplode() call)
[+TASK] Extbase (Tests): Added some unit tests for Backend- and FrontendConfigurationManager. To be continued

10 years ago[+BUGFIX] Extbase (DomainObject): added default __toString method to Tx_Extbase_Domai...
Marc Bastian Heinrichs [Tue, 30 Nov 2010 13:30:21 +0000 (13:30 +0000)]
[+BUGFIX] Extbase (DomainObject): added default __toString method to Tx_Extbase_DomainObject_AbstractDomainObject. Thanks to Marco Huber. Resolves #8083

10 years ago[+BUGFIX] Extbase (MVC): Fixed UriBuilder for handling LazyLoadingProxy objects as...
Marc Bastian Heinrichs [Tue, 30 Nov 2010 12:09:44 +0000 (12:09 +0000)]
[+BUGFIX] Extbase (MVC): Fixed UriBuilder for handling LazyLoadingProxy objects as arguments. Resolves #10705

10 years ago[+TASK] Extbase (Object): re-added Tx_Extbase_Object_Manager to gain more backwards...
Bastian Waidelich [Tue, 30 Nov 2010 12:06:03 +0000 (12:06 +0000)]
[+TASK] Extbase (Object): re-added Tx_Extbase_Object_Manager to gain more backwards compatibility. This class is marked deprecated and will be removed in Extbase 1.5

10 years ago[+BUGFIX] Extbase (Tests): tweaked ObjectContainer tests. Tests are failing deliberat...
Bastian Waidelich [Tue, 30 Nov 2010 12:02:39 +0000 (12:02 +0000)]
[+BUGFIX] Extbase (Tests): tweaked ObjectContainer tests. Tests are failing deliberately for now

The DI implementation has to be rewritten, as discussed.

This relates to: #11160