Packages/TYPO3.CMS.git
8 years ago[BUGFIX] compileWhereClause causes Extbase errors with DBAL
Patrick Schriner [Tue, 5 Apr 2011 12:20:24 +0000 (14:20 +0200)]
[BUGFIX] compileWhereClause causes Extbase errors with DBAL

t3lib_sqlparser::compileWhereClause iterates over the where subparts. It is called from
DBAL when running DBAL in native (MySQL) mode.

It does however resets its output string whenever the subpart is either FIND_IN_SET or
IFNULL. This causes the queries built by Extbase to fail.

Change-Id: Iea3d6f02cc9b8151f9fd6454f393ff6089567a03
Fixes: #25488
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1458
Reviewed-by: Stefan Neufeind
Reviewed-by: Georg Schönweger
Tested-by: Georg Schönweger
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] Add stdWrap for excludeUidList for HMENU.
Roland Waldner [Fri, 29 Apr 2011 20:03:41 +0000 (22:03 +0200)]
[BUGFIX] Add stdWrap for excludeUidList for HMENU.

Change-Id: I10a9814366e69dfdbf87e8ab404ab4d2ce02f4c3
Resolves: #26483
Reviewed-on: http://review.typo3.org/1813
Reviewed-by: Stefan Neufeind
Reviewed-by: Markus Klein
Reviewed-by: Christopher
Tested-by: Christopher
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[BUGFIX] Meta charset tag adjustment for html5 doctype
Susanne Moog [Sat, 21 May 2011 13:30:29 +0000 (15:30 +0200)]
[BUGFIX] Meta charset tag adjustment for html5 doctype

The meta charset tag is not fully compatible with html5.
Remove the namespace to avoid the validator warning.

Change-Id: I8275b677e5394f59dbd1efc65ced93f57149ebae
Resolves: #24212
Reviewed-on: http://review.typo3.org/2280
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[TASK] Refactor conditions in t3lib_extFileFunc
Andreas Wolf [Tue, 8 Mar 2011 07:00:37 +0000 (08:00 +0100)]
[TASK] Refactor conditions in t3lib_extFileFunc

t3lib_extFileFunc has a lot of deeply nested conditions. These
conditions make understanding the code really hard.

Most of the else-branches only contain a log call, so it helps a lot to
invert the conditions, move the log call inside the if-branch and add a
break statement afterwards. The else branch can then be removed to
streamline the code.

Change-Id: Ic900fe3294142ebc89be4c3d420bb729a24d5452
Resolves: #24218
Reviewed-on: http://review.typo3.org/1087
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Stefan Neufeind
8 years ago[TASK] Remove extension commerce specific code in TYPO3 Core
Marcus Krause [Wed, 25 May 2011 09:15:05 +0000 (11:15 +0200)]
[TASK] Remove extension commerce specific code in TYPO3 Core

Class tslib_feUserAuth contains TER specific code. This issue is about
to remove this piece of code.

In specific this is EXT:commerce related code which has been
introduced with the TYPO3 Core Session Fixation Security Fix.

Whether fixed or not in commerce, Core should not fix code for
TER listed extensions. However, as commerce list currently very active
it should be possible for the contributors to fix problems if still
existing.

Change-Id: I2dae9c6f5fa24ce11f43ebd612523a00101e2990
Resolves: #27027
Reviewed-on: http://review.typo3.org/2364
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[FEATURE][CONF][!!!] Deprecate PHP_SCRIPT* objects
Francois Suter [Fri, 20 May 2011 12:10:38 +0000 (14:10 +0200)]
[FEATURE][CONF][!!!] Deprecate PHP_SCRIPT* objects

PHP_SCRIPT, PHP_SCRIPT_INT and PHP_SCRIPT_EXT objects are old
TypoScript content objects which really shouldn't be used anymore.
Mark them as deprecated.

Change-Id: I6f17728e6202291ba5594fa9e1af8d05112acfe8
Resolves: #26936
Releases: 4.6
Reviewed-on: http://review.typo3.org/2269
Reviewed-by: Xavier Perseguers
Reviewed-by: Christopher
Tested-by: Christopher
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Francois Suter
Tested-by: Francois Suter
8 years ago[BUGFIX] Allow Tx_ as class prefix
Andreas Kiessling [Fri, 29 Apr 2011 15:07:48 +0000 (17:07 +0200)]
[BUGFIX] Allow Tx_ as class prefix

Although extbase urges to use Tx_ as prefix for class name, this prefix
is not accepted in all places of the core.

Change-Id: Icb46d875fdf66eaf6f51367cf3ef5030c07a4128
Resolves: #22594
Releases: 4.6, 4.5, 4.4, 4.3
Reviewed-on: http://review.typo3.org/1609
Tested-by: Philipp Gampe
Reviewed-by: Kay Strobach
Tested-by: Kay Strobach
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Jigal van Hemert
8 years ago[TASK] Update RTE manual with description of buttons
stan [Thu, 19 May 2011 04:34:01 +0000 (00:34 -0400)]
[TASK] Update RTE manual with description of buttons

Thanks to Christian Hennecke.

Change-Id: Ie3a6b285e3a1d79f71baa975e836a447c3449681
Resolves: #26724
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/2220
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[BUGFIX] TCA definition is not available in upgrade wizards
Steffen Gebert [Tue, 10 May 2011 21:09:42 +0000 (23:09 +0200)]
[BUGFIX] TCA definition is not available in upgrade wizards

The global TCA definition is empty in some upgrade wizards.
This was caused by a general clean-up to remove PHP global
statements that did not seem to be required anymore. However,
if PHP files get included inside a method or function accessing
$TCA did not happen in a global context.

Change-Id: I17df6b3caeda0ff2b5a7399c457ccebc57627882
Resolves: #26515
Reviewed-on: http://review.typo3.org/1809
Reviewed-by: Steffen Gebert
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[TASK] Raise submodule pointer
Xavier Perseguers [Fri, 13 May 2011 13:11:44 +0000 (15:11 +0200)]
[TASK] Raise submodule pointer

Change-Id: Ib9458084608ef938ab28a961d24a69cc29b7c45b
Reviewed-on: http://review.typo3.org/2111
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUG] Constant TYPO3_URL_DONATE defined twice
Xavier Perseguers [Thu, 12 May 2011 11:48:54 +0000 (13:48 +0200)]
[BUG] Constant TYPO3_URL_DONATE defined twice

Constant TYPO3_URL_DONATE is defined twice. Once with
the old, simulate static URL, and once with the new, current
URL.

Change-Id: If7d2ead0e86ac93d18251db38a7c226af5903355
Resolves: #26781
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/2094
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] Fix stdWrap for Click-to-enlarge
Markus Klein [Wed, 11 May 2011 13:54:34 +0000 (15:54 +0200)]
[BUGFIX] Fix stdWrap for Click-to-enlarge

Due to a syntax error, stdWrap for the target attribute of
the click-to-enlarge image link is broken. (Nobrainer)

Change-Id: Ie107fe9d4ddcfe04d341755834c049487e205c2d
Resolves: #26757
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/2079
Reviewed-by: Björn Pedersen
Reviewed-by: Stefano Kowalke
Tested-by: Stefano Kowalke
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[TASK] Set TYPO3 version to 4.6-dev
TYPO3 v4 Release Team [Wed, 11 May 2011 10:17:44 +0000 (12:17 +0200)]
[TASK] Set TYPO3 version to 4.6-dev

Change-Id: I2c120b64734eafd24fa848f9728edb2ebd572a97
Reviewed-on: http://review.typo3.org/2062
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
8 years ago[RELEASE] Release of TYPO3 4.6.0alpha1
TYPO3 v4 Release Team [Wed, 11 May 2011 10:17:39 +0000 (12:17 +0200)]
[RELEASE] Release of TYPO3 4.6.0alpha1

Change-Id: I42a88d82c1f1e252946f15d0ae53e037fe3ddfb1
Reviewed-on: http://review.typo3.org/2061
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
8 years agoRevert "[RELEASE] Release of TYPO3 4.6.0alpha1"
Oliver Hader [Wed, 11 May 2011 10:11:33 +0000 (12:11 +0200)]
Revert "[RELEASE] Release of TYPO3 4.6.0alpha1"

This reverts commit be13ba38a59478436f51169a31e1c87c8e78de4d.

Change-Id: I1f16e8bd6d5853fd0153cea8f8d128dff4e289e2
Reviewed-on: http://review.typo3.org/2059
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[RELEASE] Release of TYPO3 4.6.0alpha1
TYPO3 v4 Release Team [Wed, 11 May 2011 10:05:59 +0000 (12:05 +0200)]
[RELEASE] Release of TYPO3 4.6.0alpha1

Change-Id: I56b4964444f4320fd76be3473e97a9e076b1fc41
Reviewed-on: http://review.typo3.org/2057
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
8 years agoRevert "[RELEASE] Release of TYPO3 4.6.0alpha1"
Oliver Hader [Wed, 11 May 2011 10:03:10 +0000 (12:03 +0200)]
Revert "[RELEASE] Release of TYPO3 4.6.0alpha1"

This reverts commit 2512e8324952ae27ab33a5f91085bf5e2ccbe0e1.

Change-Id: Ie706762dcd844984c0031f01813f2c71f98da20d
Reviewed-on: http://review.typo3.org/2056
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[RELEASE] Release of TYPO3 4.6.0alpha1
TYPO3 v4 Release Team [Wed, 11 May 2011 10:00:40 +0000 (12:00 +0200)]
[RELEASE] Release of TYPO3 4.6.0alpha1

Change-Id: I952e21e466288b77fba172e0561004b4bec26f39
Reviewed-on: http://review.typo3.org/2055
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
8 years agoRevert "[RELEASE] Release of TYPO3 4.6.0alpha1"
Oliver Hader [Wed, 11 May 2011 09:57:52 +0000 (11:57 +0200)]
Revert "[RELEASE] Release of TYPO3 4.6.0alpha1"

This reverts commit fab9e6626f6b28e0c7c64b0f6bf0fc0b6806f9fc.

Change-Id: I7fd68d23f6b259171b7af337281f76b8a187e2f3
Reviewed-on: http://review.typo3.org/2054
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[RELEASE] Release of TYPO3 4.6.0alpha1
TYPO3 v4 Release Team [Wed, 11 May 2011 09:52:48 +0000 (11:52 +0200)]
[RELEASE] Release of TYPO3 4.6.0alpha1

Change-Id: I8a466e03172f2bbd2fd1fe6c79f4d40efa3da028
Reviewed-on: http://review.typo3.org/2053
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
8 years ago[TASK] Set ImageMagick v6 as default
Xavier Perseguers [Wed, 11 May 2011 09:13:53 +0000 (11:13 +0200)]
[TASK] Set ImageMagick v6 as default

IM4 and IM5 support has been deprecated and is scheduled for
removal in TYPO3 4.6. Default empty setting for im_version_5
meant IM4. It should now reflect v6 instead.

Change-Id: Idcebd41d9cf6059ea61363a8965fef9d526e9d00
Resolves: #24146
Reviewed-on: http://review.typo3.org/2049
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[TASK] Remove support for ImageMagick 4 and 5
Xavier Perseguers [Wed, 4 May 2011 18:48:18 +0000 (20:48 +0200)]
[TASK] Remove support for ImageMagick 4 and 5

IM4 and IM5 support has been deprecated and is scheduled for
removal in TYPO3 4.6.

Change-Id: Ib7610a3666e764e32c854fb04b5d80ef3030dad3
Resolves: #24146
Reviewed-on: http://review.typo3.org/1989
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
8 years ago[TASK] Use PHP5 constructors
Stefano Kowalke [Wed, 4 May 2011 18:48:18 +0000 (20:48 +0200)]
[TASK] Use PHP5 constructors

Using the new PHP5 constructors (__construct) instead of PHP4 variants.

Change-Id: Iab19b1be570cde143dacbbe244aedaf2dd8ce1a6
Resolves: #26505
Releases: 4.6
Reviewed-on: http://review.typo3.org/1797
Reviewed-by: Stefan Neufeind
Reviewed-by: Oliver Klee
Tested-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[TASK] Use external Core Project DBAL as Git submodule
Oliver Hader [Tue, 10 May 2011 21:01:26 +0000 (23:01 +0200)]
[TASK] Use external Core Project DBAL as Git submodule

Change-Id: Iaae5e6978096de060a1253f14de01b763048645c
Resolves: #26738
Releases: 4.2, 4.3, 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/2016
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[BUGFIX] Removing child records in a workspace does not work
Oliver Hader [Thu, 17 Mar 2011 17:58:19 +0000 (18:58 +0100)]
[BUGFIX] Removing child records in a workspace does not work

These parts are not working with IRRE in workspaces:
Removing children in TCEforms
Removing children in the list view
Reverting changes in the workspace module

Change-Id: I91313235e57c193e7103d065c02d2005ef74ab86
Resolves: #25352
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1195
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[BUGFIX] Variable was wrongly initialized
Stefano Kowalke [Wed, 4 May 2011 18:48:18 +0000 (20:48 +0200)]
[BUGFIX] Variable was wrongly initialized

Variable $codeLines should be initialized prior to being used
in a concatenation within the loop.

Change-Id: Ife0b44b937a33040f46402492a5ede6e99d39668
Resolves: #26622
Releases: 4.6
Reviewed-on: http://review.typo3.org/1927
Reviewed-by: Markus Klein
Reviewed-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[TASK] Raised submodule pointers of external projects
Oliver Hader [Tue, 10 May 2011 11:18:31 +0000 (13:18 +0200)]
[TASK] Raised submodule pointers of external projects

Affected projects: version, workspaces

Change-Id: Ic0229c0a25e450d4aae96843965bd7629780cce8
Reviewed-on: http://review.typo3.org/1981
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[TASK] Use external Core Projects workspaces and version as Git submodules
Oliver Hader [Fri, 6 May 2011 17:06:14 +0000 (19:06 +0200)]
[TASK] Use external Core Projects workspaces and version as Git submodules

Part 2/2

Change-Id: If78cf29e57c7ab560082826cbc395ad35fad0097
Resolves: #26581
Reviewed-on: http://review.typo3.org/1948
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
8 years ago[TASK] Use external Core Projects workspaces and version as Git submodules
Oliver Hader [Fri, 6 May 2011 17:00:27 +0000 (19:00 +0200)]
[TASK] Use external Core Projects workspaces and version as Git submodules

Part 1/2

Change-Id: I13ba0ff933510e5ee83fc719fb87933555ac3e70
Resolves: #26581
Reviewed-on: http://review.typo3.org/1947
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Stefan Neufeind
8 years ago[BUGFIX] Cannot redeclare class backend_toolbaritem
Xavier Perseguers [Sun, 1 May 2011 13:55:30 +0000 (15:55 +0200)]
[BUGFIX] Cannot redeclare class backend_toolbaritem

Because of a PHP bug on some systems, login to TYPO3 backend
fails because the interface backend_toolbaritem is included
twice, once with a relative path and the other one with an
absolute one.

Change-Id: I91f993935155af6d50dd99498c9d19b684f99b69
Resolves: #26535
Reviewed-on: http://review.typo3.org/1820
Tested-by: Steffen Gebert
Reviewed-by: Steffen Gebert
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[TASK] Each PHP statement must be on a line by itself
Stefano Kowalke [Thu, 5 May 2011 06:52:33 +0000 (08:52 +0200)]
[TASK] Each PHP statement must be on a line by itself

There are several places where two or more statements are in one line
like "if (condition) do something;" or just to semicolons at the end of
a line "$foo = 42;;"

Change-Id: I9e587751676fee8db27226c751483c1070de935d
Resolves: #26626
Release: 4.6
Reviewed-on: http://review.typo3.org/1932
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] Also crop when maxCharacters < first word
Peter Beernink [Fri, 25 Mar 2011 11:20:27 +0000 (12:20 +0100)]
[BUGFIX] Also crop when maxCharacters < first word

When maxCharacters is equal or less then the length of the first word,
the whole string was returned when 'crop to word' is enabled instead of
the only the cropped part.

Change-Id: I0a7ec720b12a7999245b183f36daff5cdd7a8ace
Resolves: #25368
Reviewed-on: http://review.typo3.org/1274
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] Display correct lost records count in record statistics
Susanne Moog [Sun, 10 Apr 2011 08:32:16 +0000 (10:32 +0200)]
[BUGFIX] Display correct lost records count in record statistics

The module DB Check > Record statistics counts the deleted pages
instead of the lost pages and displays that number. As the links
for adopting orphaned records should correlate to the count of
lost records, we should display the correct number.

Change-Id: Ie793aa337b56503f6f37ffd9cc6fbb8d052c1540
Resolves: #25863
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/1531
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Stefan Neufeind
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Tested-by: Stefan Neufeind
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[FEATURE] Add hook to override icon status overlay
Francois Suter [Tue, 5 Apr 2011 13:12:39 +0000 (15:12 +0200)]
[FEATURE] Add hook to override icon status overlay

Icons status overlays are defined in t3lib_iconWorks::
mapRecordOverlayToSpriteIconName(). However it is necessary
for "external" process (e.g. versioning) to override the
icon status. Currently a deleted record in a workspace will
not appear properly overlaid because only deleted = 1 is
checked and not also t3ver_state = 2. This hook makes it
possible for the version sysext to hook into the process and
set the right status.

Change-Id: I349012e402ab349ad810c57e46b0a7d5f8a46b03
Resolves: #25765
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1459
Tested-by: Oliver Hader
Reviewed-by: Stefan Neufeind
Reviewed-by: Oliver Hader
8 years ago[TASK] Change "false" into "FALSE"
Stefano Kowalke [Sat, 30 Apr 2011 11:55:48 +0000 (13:55 +0200)]
[TASK] Change "false" into "FALSE"

Booleans should be written in uppercase.

Change-Id: I5c6e07ceb53deb128f82dc67948925f5cb99dd91
Resolves: #26347
Releases: 4.6
Reviewed-on: http://review.typo3.org/1792
Reviewed-by: Peter Beernink
Tested-by: Peter Beernink
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Abandon one time CSRF tokens
Helmut Hummel [Sun, 20 Mar 2011 18:15:57 +0000 (19:15 +0100)]
[BUGFIX] Abandon one time CSRF tokens

Abandon the extra security feature of having one time tokens and create tokens
which are valid during a whole login session. Additionally create only one random token,
store it in the session and create the real URL and form tokens by hashing the scope strings
with the secret session token.

To enable re-login, store the session token in the registry and retrieve it in case a
re-login happens.

Thanks to Marion Eher (Bluechip.at) for sponsoring
this fix with 75 beers during the bug auction at T3BOARD11.

Resolves: #25359
Change-Id: If37990fbc1ae3701777e8218cc1bc8760a4d6a55
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1364
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
8 years ago[CLEANUP] Fix TCA tree the same as in TYPO3_4-5
Helmut Hummel [Fri, 29 Apr 2011 15:37:06 +0000 (17:37 +0200)]
[CLEANUP] Fix TCA tree the same as in TYPO3_4-5

The TCA tree feature did not work when setting maxitems=1 in the TCA.

This bug has been fixed in master in 290529a75647fe2bf6847638763e50348631e906 and in
TYPO3_4-5 branch 3019ca92f55faf650ad5981a001e323a2e91eab6 but the solution is different.

Use the same solution as is TYPO3_4-5 because it is cleaner:

* Check for empty() value instead of comparing with 0 in
  t3lib/tceforms/class.t3lib_tceforms_tree.php
* Do not recalculate the number of checked items only if a new
  item is checked and the maximum item count is reached instead of always
  recalculating the item count in
  t3lib/js/extjs/tree/tree.js

Resolves: #25347
Releases: 4.6

Change-Id: I1b55960f9c26f57aa05d6a95a9980798c06e8316
Reviewed-on: http://review.typo3.org/1804
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
8 years ago[TASK] Remove last relics of IE6 backend support
Steffen Gebert [Mon, 25 Apr 2011 20:49:33 +0000 (22:49 +0200)]
[TASK] Remove last relics of IE6 backend support

Remove the last occurrences of IE6 specific code.
Resolves: #26274

Change-Id: I82e86c5b8ecc14d6592871a2f86d6c50d69eed48
Reviewed-on: http://review.typo3.org/1723
Reviewed-by: Peter Beernink
Tested-by: Peter Beernink
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX][saltedpasswords] Failed backend logins not not logged
Torben Hansen [Fri, 29 Apr 2011 12:03:18 +0000 (14:03 +0200)]
[BUGFIX][saltedpasswords] Failed backend logins not not logged

The logging functions in saltedpasswords are not able to log failed
backend userlogins to TYPO3s syslog, because the inherited
writelog-function gets overridden by a local function. As a result, no
notification e-mail is sent to [warning_email_addr] when a backend user
has multiple failed login attempts. A remote 'attacker' could try to
login to a TYPO3 installations backend numerous of times without being
noticed (no log entry and no warning-email if configured).

Rename the local writelog-function to writeLogMessage and add the
original writelog-functionality, so that failed backend logins are
written to TYPO3s syslog again and all logging/notifications work as
expected.

Change-Id: Ic05b05873e3fd20df675db908ba76b7dd0e5548f
Resolves: #23917
Releases: 4.6, 4.5, 4.4, 4.3
Reviewed-on: http://review.typo3.org/1795
Reviewed-by: Torben Hansen
Tested-by: Torben Hansen
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
8 years ago[TASK] Change "null" into "NULL"
Stefano Kowalke [Wed, 27 Apr 2011 09:21:19 +0000 (11:21 +0200)]
[TASK] Change "null" into "NULL"

The special value "null" should written in uppercase "NULL".

Change-Id: I84deb049c823ee6b51792df7afd08b18bbff5cac
Resolves: #26345
Releases: 4.6
Reviewed-on: http://review.typo3.org/1791
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Typo "tsdWrap" instead of "stdWrap"
Christopher Stelmaszyk [Fri, 29 Apr 2011 14:46:30 +0000 (16:46 +0200)]
[BUGFIX] Typo "tsdWrap" instead of "stdWrap"

In class tslib_content_offsettable there is one occurence of "tsdWrap",
which should read "stdWrap".

Change-Id: Ia658149602d5bbf1e3453ad8ed9eacbec247c1c5
Resolves: #26500
Reviewed-on: http://review.typo3.org/1800
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[TASK] Change "true" into "TRUE"
Stefano Kowalke [Thu, 28 Apr 2011 15:25:19 +0000 (17:25 +0200)]
[TASK] Change "true" into "TRUE"

Booleans should be written in uppercase.

Change-Id: Ib29abc6e1e658e3a1b65cd1873a3a3edac7dba57
Resolves: #26346
Releases: 4.6
Reviewed-on: http://review.typo3.org/1790
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX][TESTS] Fix unit test fixPermissionsSetsPermissionsWithRelativeFileReference
Steffen Gebert [Thu, 28 Apr 2011 16:38:02 +0000 (18:38 +0200)]
[BUGFIX][TESTS] Fix unit test fixPermissionsSetsPermissionsWithRelativeFileReference

The test fixPermissionsSetsPermissionsWithRelativeFileReference
(t3lib_divTest) used a (wrong) relative path to a test file in the chmod
call. Thus the test failed.

Prepend PATH_site have the correct absolute path.

Change-Id: Ifab5649272952a626381e8562ca018d087efc789
Resolves: #26423
Reviewed-on: http://review.typo3.org/1780
Reviewed-by: Peter Beernink
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX][TESTS] Fix unit test cropIsMultibyteSafe
Steffen Gebert [Fri, 29 Apr 2011 10:50:52 +0000 (12:50 +0200)]
[BUGFIX][TESTS] Fix unit test cropIsMultibyteSafe

The unit test cropIsMultibyteSafe (class tslib_contentTest) fails, if
error reporting includes E_WARNING. In this case mb_strlen() throws an
error, as it is called with an empty string as second parameter
$charset. Initializing $GLOBALS['TSFE']->renderCharset in the setUp
method solves this.

Change-Id: If04278e3cbd01ad2f4b6b02c1b3df7cf89b251f0
Resolves: #26491
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1785
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[BUGFIX] Default login (without EXT:felogin) form should be removed
Susanne Moog [Sun, 17 Apr 2011 16:19:43 +0000 (18:19 +0200)]
[BUGFIX] Default login (without EXT:felogin) form should be removed

When EXT:felogin is not installed, a FE login content element is available, that is
out of date and should not be used anymore.
As we ship felogin since 4.2 and install it by default, the default login form is
useless and confusing.

Thanks to naw.info for sponsoring 135 beers at the bug auction for this fix.

Change-Id: I765b3d391b06dac34550f46f19992c9cf9d1c5c7
Resolves: #22408
Reviewed-on: http://review.typo3.org/1369
Reviewed-by: Björn Pedersen
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] Use recursive option of mkdir in t3lib_div::mkdir_deep
Christian Kuhn [Sun, 24 Apr 2011 16:22:29 +0000 (18:22 +0200)]
[BUGFIX] Use recursive option of mkdir in t3lib_div::mkdir_deep

Additionally throw exceptions instead of a return string if directory could
not be created.

Change-Id: I90da96e1b62d28997573d821c62b7b24b3ef2ba3
Resolves: #26240
Depends: #26230
Releases: 4.6
Reviewed-on: http://review.typo3.org/1716
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[BUGFIX] EM: Incorrect label ext_details_always_loaded ['SYS'] / ['EXT']
Bjoern Pedersen [Wed, 27 Apr 2011 12:17:36 +0000 (14:17 +0200)]
[BUGFIX] EM: Incorrect label ext_details_always_loaded ['SYS'] / ['EXT']

The message has TYPO3_CONF_VARS['SYS']['requiredExt'] instead of
TYPO3_CONF_VARS['EXT']['requiredExt'] as in config_default.php.

Change-Id: I46a3559b4b4da028b55b8cc8cda63aaa81fb91ea
Resolves: #26354
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1765
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Fix typo in class.t3lib_div.php
Stefano Kowalke [Wed, 27 Apr 2011 10:36:18 +0000 (12:36 +0200)]
[BUGFIX] Fix typo in class.t3lib_div.php

Change "$includeEmtpyValues" into "$includeEmptyValues"

Change-Id: I8527373b7b5934025f8ef44bde8ef76ee9036a07
Resolves: #26351
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/1763
Reviewed-by: Björn Pedersen
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[TASK] TYPO3 code must not use the else if construct
Stefano Kowalke [Tue, 26 Apr 2011 14:08:33 +0000 (16:08 +0200)]
[TASK] TYPO3 code must not use the else if construct

Change "else if" into "elseif"
This is a follow-up because I forgot one "else if".

Change-Id: I51eeab3ced57a7f9ffc84ad05ee952e529ed533b
Resolves: #26295
Releases: 4.6
Reviewed-on: http://review.typo3.org/1731
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[TASK] TYPO3 code must not use the else if construct
Stefano Kowalke [Tue, 26 Apr 2011 12:40:26 +0000 (14:40 +0200)]
[TASK] TYPO3 code must not use the else if construct

Change "else if" into "elseif"

Change-Id: I7db545131851b2bb99dfe25c80fef6b26f5504dd
Resolves: #26295
Releases: 4.6
Reviewed-on: http://review.typo3.org/1725
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Use setReplyTo and setCc instead of add*
Jigal van Hemert [Thu, 10 Mar 2011 21:25:14 +0000 (22:25 +0100)]
[BUGFIX] Use setReplyTo and setCc instead of add*

The methods addReplyTo and addCc accept strings as parameters, but we
need the setReplyTo and setCc which accept arrays. This will make the
reply-to and recipient-copy options work in formMail.

Change-Id: Ia3826d51f53ffe497f4c3b25957f0332fb89e81e
Resolves: #25301
Releases: 4.6
Reviewed-on: http://review.typo3.org/1442
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[TASK] Add helper function for array handling
Susanne Moog [Sun, 17 Apr 2011 14:09:27 +0000 (16:09 +0200)]
[TASK] Add helper function for array handling

Adds a helper functions for easier handling of arrays.
New class t3lib_utility_Array adds a method to reduce an
array by a search value.
New method in t3lib_extMgm adds a method to add new items
to a TCA select list at a spcified position.

Change-Id: I589294525a7eacc7af6e54c5b78f5ee411574f12
Resolves: #26069
Relates: #22408
Reviewed-on: http://review.typo3.org/1647
Reviewed-by: Alexander Stehlik
Tested-by: Alexander Stehlik
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Fix inconsistent linebreaks in some files
Michael Stucki [Tue, 19 Apr 2011 12:47:03 +0000 (14:47 +0200)]
[BUGFIX] Fix inconsistent linebreaks in some files

A few files are containing inconsistent linebreaks.
Since all of these files are taken from external projects,
someone needs to make sure that they get fixed during future
imports.

Change-Id: I49e482add2f991356a4ad335f13c9c60719e9e44
Resolves: #26126
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1661
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[FEATURE] Remove size bound of included TypoScript files
Rasto Birka [Fri, 1 Apr 2011 13:23:24 +0000 (15:23 +0200)]
[FEATURE] Remove size bound of included TypoScript files

Change-Id: Ib8dd5576d4400cb4da38c86384ce6dd31f734508
Resolves: #25709
Reviewed-on: http://review.typo3.org/1408
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Add unit tests for t3lib_div::mkdir_deep
Christian Kuhn [Sun, 24 Apr 2011 14:34:02 +0000 (16:34 +0200)]
[BUGFIX] Add unit tests for t3lib_div::mkdir_deep

Add new unit tests for mkdir_deep() to document current behavior.
Clean up variable names in mkdir_deep (no functional change).

Change-Id: Ied48fbb5c23d7e9152464b4f71ace60be04f6074
Resolves: #26230
Depends: #26228
Releases: 4.6
Reviewed-on: http://review.typo3.org/1714
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Remove obsolete safe_mode hacks from t3lib_div
Christian Kuhn [Sun, 24 Apr 2011 10:49:57 +0000 (12:49 +0200)]
[BUGFIX] Remove obsolete safe_mode hacks from t3lib_div

Remove code from t3lib_div::fixPermissions and t3lib_div::mkdir that remove
a trailing slash from a given directory. This was a workaraund for PHP functions
like mkdir, they fail with trailing slashes if safe_mode is on.
Additionally the according unit tests are cleaned up and completed.

Change-Id: I44b330a3542bfd172736b103feec895b46494346
Resolves: #26228
Related: #25332
Releases: 4.6
Reviewed-on: http://review.typo3.org/1713
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] redirectTo field max-value 255 chars
Markus Bucher [Wed, 6 Apr 2011 07:53:04 +0000 (09:53 +0200)]
[BUGFIX] redirectTo field max-value 255 chars

It is neccessary to hold more than 120 characters in redirectTo field,
thus changes in ext_table.sql and tbl_cms.php are neccessary. This fix
changes the max-value to 255 chars.

Resolves #25780
Releases 4.6

Change-Id: I228f636b529ca75c9b1820a8cff622970b00cd42
Reviewed-on: http://review.typo3.org/1472
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Stefano Kowalke
Reviewed-by: Björn Pedersen
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[BUGFIX] Add "class." prefix to all scheduler unit test files
Christian Kuhn [Sun, 24 Apr 2011 15:09:01 +0000 (17:09 +0200)]
[BUGFIX] Add "class." prefix to all scheduler unit test files

According to CGL the files which contain a class must have a prefix "class." in filename.

Change-Id: I1b636b6b64e7202d4c6fc4a6741478817295ce99
Resolves: #26231
Related: #25868
Releases: 4.6
Reviewed-on: http://review.typo3.org/1715
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[TASK] Remove file SVNreadme.txt
Steffen Gebert [Fri, 22 Apr 2011 12:12:25 +0000 (14:12 +0200)]
[TASK] Remove file SVNreadme.txt

The file SVNreadme.txt in the root of the repository contains
information, which should help people coming from older versions bevore
4.0 and using an SVN checkout.

Not only the name is outdated, most of the information is also wrong.
So remove this file.

Change-Id: If08c6b835278d2bb2b83f100f9f68a60406d1cae
Reviewed-on: http://review.typo3.org/1706
Reviewed-by: Stefano Kowalke
Tested-by: Stefano Kowalke
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Log out after running garbage collection tests
Christian Kuhn [Thu, 21 Apr 2011 15:05:43 +0000 (17:05 +0200)]
[BUGFIX] Log out after running garbage collection tests

TYPO3_DB must be added to $backupGlobalsBlacklist.

Change-Id: I1a4642d563f67582f5a300859a2ecc2ae2e96390
Resolves: #26174
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1700
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[TASK] Add missing PHP closing tag
Stefano Kowalke [Thu, 21 Apr 2011 13:37:23 +0000 (15:37 +0200)]
[TASK] Add missing PHP closing tag

This is a CGL cleanup.

Change-Id: I761fe8983c35e2dbe002728c54d547e590004d26
Resolves: #26173
Releases: 4.6
Reviewed-on: http://review.typo3.org/1698
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Replace deprecated assertType in unit tests
Alexander Stehlik [Thu, 21 Apr 2011 13:01:33 +0000 (15:01 +0200)]
[BUGFIX] Replace deprecated assertType in unit tests

Change-Id: I8fd91f031634e43a34ab1d3b75869452a8dd4d6a
Resolves: #25090
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1696
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[TASK] Remove whitespace between variable name and square bracket.
Stefano Kowalke [Thu, 21 Apr 2011 11:40:28 +0000 (13:40 +0200)]
[TASK] Remove whitespace between variable name and square bracket.

This is a CGL cleanup.

Change-Id: I30ef7ff173b91a14f8562c094ed071917a4918cb
Resolves: #26171
Releases: 4.6
Reviewed-on: http://review.typo3.org/1693
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[TASK] Remove trailing newlines from EOF
Stefano Kowalke [Wed, 20 Apr 2011 23:29:53 +0000 (01:29 +0200)]
[TASK] Remove trailing newlines from EOF

This is a CGL cleanup to get rid of all trailing newlines at EOF.

Change-Id: I905d04317303f000a5e71eaf61973bf7cadea119
Resolves: #26162
Releases: 4.6
Reviewed-on: http://review.typo3.org/1684
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[TASK] Fix some typos
Stefano Kowalke [Thu, 21 Apr 2011 08:05:29 +0000 (10:05 +0200)]
[TASK] Fix some typos

Change-Id: Ic068f31188e09e9d55cc7ada246e5d192a70fbc7
Resolves: #26164
Releases: 4.6
Reviewed-on: http://review.typo3.org/1685
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[FEATURE] Make template file for EXT:felogin configurable by constant
Soren Malling [Tue, 19 Apr 2011 08:36:55 +0000 (10:36 +0200)]
[FEATURE] Make template file for EXT:felogin configurable by constant

The HTML template for EXT:felogin should be configurable.

Therefore, add a new constant to css_styled_content named
styles.content.loginform.templateFile

As default it holds the previously hardcodede value from
EXT:felogin/ext_typoscript_setup.txt (EXT:felogin/template.html)

Change-Id: I98a55c3d2ed9f782450436194f95275e0ee307c7
Resolves: #26103
Reviewed-on: http://review.typo3.org/1658
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
8 years ago[BUGFIX] register['count_menuItems'] wrong, if filtered by userfunc
Bjoern Pedersen [Wed, 6 Apr 2011 07:47:40 +0000 (09:47 +0200)]
[BUGFIX] register['count_menuItems'] wrong, if filtered by userfunc

the register['count_menuItems'] is set, before a possible userfunc filters the menu items -> wrong register value.

Solution: change call sequence

Change-Id: I0425d04602110a5f6707022cb88077cc75e81f02
Resolves: #25405
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1471
Reviewed-by: Tolleiv Nietsch
Reviewed-by: Frederic Gaus
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Wrong type hinting in interface tslib_menu_filterMenuPagesHook
Michael Birchler [Mon, 18 Apr 2011 14:08:10 +0000 (16:08 +0200)]
[BUGFIX] Wrong type hinting in interface tslib_menu_filterMenuPagesHook

tslib_menu_filterMenuPagesHook::tslib_menu_filterMenuPagesHook expects a
tslib_tmenu object as fourth parameter $obj.
$obj should hint for tslib_menu and not as wrongly specified tslib_tmenu.
If hook is used and for example a GMENU will be processed an exception
will be thrown.

Change-Id: I0a61737755afbda6e2ab6c02ba59c078a77cc020
Resolves: #25979
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/1649
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[TASK] Add prefix "class." to all unit test files which contain classes.
Stefano Kowalke [Sun, 17 Apr 2011 13:05:39 +0000 (15:05 +0200)]
[TASK] Add prefix "class." to all unit test files which contain classes.

According to the CGL the files which contains a class must have a prefix "class." in filename.

Change-Id: I5ac0214236dc248a7d2b37d5981278fd65bc6c91
Resolves: #25868
Releases: 4.6
Reviewed-on: http://review.typo3.org/1646
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Recursion error when including TypoScript files
Tobias Liebig [Thu, 31 Mar 2011 19:48:21 +0000 (21:48 +0200)]
[BUGFIX] Recursion error when including TypoScript files

When editing TypoScript in the template module and using the "Include
TypoScript file content" option with more than 9 files, then the 10th
and all later files gets screwed up.

Thanks to André Spindler for reporting and providing a patch.
Thanks to Kilian Hann (futureconnection AG Zürich) for sponsoring
100 beers during the bug auction.

Change-Id: I2b1363506e5b01a9fb8fa47b792d3351d302eaa9
Resolves: #25374
Reviewed-on: http://review.typo3.org/1362
Reviewed-by: Michael Stucki
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Sebastian Fischer
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[TASK][!!!] Remove support for safe_mode
Jigal van Hemert [Sun, 3 Apr 2011 07:41:49 +0000 (09:41 +0200)]
[TASK][!!!] Remove support for safe_mode

Change-Id: Iae45d949855ceec1e9dc9bf6e27d4885749375d5
Resolves: #25332
Reviewed-on: http://review.typo3.org/1447
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[TASK] Remove global declarations inside methods
Xavier Perseguers [Wed, 13 Apr 2011 20:04:07 +0000 (22:04 +0200)]
[TASK] Remove global declarations inside methods

Global declaration such as global $TCA or global $BE_USER should
be changed to $GLOBALS['TCA'], $GLOBALS['BE_USER'], ...

Change-Id: I68f801ff6934a7e16db78cb3f10d1c2b64aef351
Fixes: #25334
Reviewed-on: http://review.typo3.org/1446
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Tested-by: Christian Kuhn
Reviewed-by: Christian Kuhn
8 years ago[FEATURE] Move class "tx_scheduler_Module" from "mod1/index.php" for unit test
Andy Grunwald [Tue, 12 Apr 2011 20:06:39 +0000 (22:06 +0200)]
[FEATURE] Move class "tx_scheduler_Module" from "mod1/index.php" for unit test

This change makes it possible to write unit tests for "tx_scheduler_module".

Change-Id: I85b977687c24966aadba11248a58ee081b8bef67
Resolves: #25925
Releases: 4.6
Reviewed-on: http://review.typo3.org/1588
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Flexformfield "Forgot Password Message" in felogin does not work
Steffen Mueller [Sun, 27 Mar 2011 20:46:15 +0000 (22:46 +0200)]
[BUGFIX] Flexformfield "Forgot Password Message" in felogin does not work

The value of the FF field "Forgot Password Message" in felogin is not working. Solution is to rename FF field name from "forgot_message" to "forgot_reset_message".

Change-Id: I5a08196f8a26c73a27b65d3456e242ea86fc5707
Resolves: #23134
Releases: 4.6, 4.5, 4.4, 4.3
Reviewed-on: http://review.typo3.org/1285
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] PHP_SCRIPT_INT unnecessarily requires parameter scriptSuffix
Steffen Gebert [Tue, 5 Apr 2011 15:42:19 +0000 (17:42 +0200)]
[BUGFIX] PHP_SCRIPT_INT unnecessarily requires parameter scriptSuffix

Using PHP_SCRIPT_INT throws an Exception "Expected parameter
$conf['scriptSuffix'] was not given.", in its render() method.

As the parameter is useless and not used in other places, this check
can be removed.

Change-Id: I64fd656e0af78e711290aea597353c7194dd613d
Resolves: #25145
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1466
Reviewed-by: Björn Pedersen
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[FEATURE] Include Request URL in Exception log
Steffen Gebert [Tue, 12 Apr 2011 18:13:33 +0000 (20:13 +0200)]
[FEATURE] Include Request URL in Exception log

Adding the requested URL in the log message for uncaught Exceptions can
ease the task of finding the particular page causing an error.

Change-Id: I39ffb7943c39a406c651dc30b2b2351347f0cad4
Resolves: #25924
Reviewed-on: http://review.typo3.org/1587
Reviewed-by: Stefano Cecere
Tested-by: Tim Duelken
Reviewed-by: Andy Grunwald
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] remove console.log in pagetree actions.js
Frederic Gaus, Flagbit GmbH & Co. KG [Tue, 12 Apr 2011 14:52:16 +0000 (16:52 +0200)]
[BUGFIX] remove console.log in pagetree actions.js

Simply removes the console.log debugging output. This line causes
JavaScript errors if there is no console object present.

Change-Id: I060b96f47b95d4265899ccff027009fe54f565cb
Resolves: #25721
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1584
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[BUGFIX] Visibility of method tx_sysaction_task::fixUsername()
Oliver Hader [Wed, 9 Mar 2011 14:05:36 +0000 (15:05 +0100)]
[BUGFIX] Visibility of method tx_sysaction_task::fixUsername()

The method fixUsername() is defined as private, but should be
protected instead.

Change-Id: I0513416a0d1cf07793708e86e7f1c7fde619f4d5
Resolves: #25219
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/1104
Reviewed-by: Jacob Rasmussen
Tested-by: Jacob Rasmussen
Reviewed-by: Oliver Klee
Reviewed-by: Andy Grunwald
Tested-by: Andy Grunwald
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[TASK] Add version 4.5 CSS Styled Content Templates and Compat Version
Susanne Moog [Thu, 31 Mar 2011 19:57:06 +0000 (21:57 +0200)]
[TASK] Add version 4.5 CSS Styled Content Templates and Compat Version

For changes to CSS Styled Content in TYPO3 version 4.6 we need new
static templates and a compatibility version.

Change-Id: I4e36f465c057982ed3b66ceffe8fcc9b4ff6a73c
Resolves: #25606
Reviewed-on: http://review.typo3.org/1363
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Missing sprite icons in module db check > record statistics
Sven Juergens [Sun, 10 Apr 2011 07:32:14 +0000 (09:32 +0200)]
[BUGFIX] Missing sprite icons in module db check > record statistics

The module DB check > Record statistics is using old icons for
pages. Additionally the icons for the different doktypes are
broken.

Change-Id: I64de9b55bf0a2fe32378aa9ce9c7bf3756da1224
Resolves: #24835
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/1530
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[BUGFIX] Disable the TCA Tree if $PA['fieldConf']['config']['readOnly'] is true.
Marco Huber [Mon, 11 Apr 2011 13:15:19 +0000 (15:15 +0200)]
[BUGFIX] Disable the TCA Tree if $PA['fieldConf']['config']['readOnly'] is true.

Disable the TCA Tree if $PA['fieldConf']['config']['readOnly'] is true.
This happens for example in translations of records if
$TCA['my_table']['columns']['my_column']['l10n_display'] = 'defaultAsReadonly'.

Change-Id: I18195bbc3fc6369d56669a5fd5c81103140e7a6c
Resolves: #25888
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1548
Reviewed-by: Marco Huber
Tested-by: Marco Huber
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[BUGFIX] Configuration Tool creates invalid extTables.php file
Markus Klein [Wed, 6 Apr 2011 09:44:24 +0000 (11:44 +0200)]
[BUGFIX] Configuration Tool creates invalid extTables.php file

If extTables.php is empty or not present, this changes takes care of
adding an extra LF after the opening <?php tag.

Change-Id: Ie9b94c75cd33c5a448c2e04759b38558ca1b8845
Resolves: #25781
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/1474
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Jan Loderhose
Tested-by: Jan Loderhose
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[BUGFIX] Media obj respect moveJsFromHeaderToFooter
Alexandre Gravel-Raymond [Fri, 4 Mar 2011 14:55:16 +0000 (15:55 +0100)]
[BUGFIX] Media obj respect moveJsFromHeaderToFooter

If you set config.moveJsFromHeaderToFooter=1 in your TS template, and
add a Media object, the swfobject library is correctly added at the
bottom of the page, but the inline code calling the swfobject library
is added inline at the same place as the media object.
This results in the javascript error "swfobject is not defined" and
the media not appearing on the page.

This change makes use of t3lib_PageRenderer::addJsInlineCode to add
the inline code, so it respects config.moveJsFromHeaderToFooter=1.

Change-Id: I0902ca60dab810dc58e7f1b46a07ad4ae6f1efda
Resolves: #M17868
Reviewed-on: http://review.typo3.org/1062
Reviewed-by: Steffen Kamper
Reviewed-by: Björn Pedersen
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[FEATURE] Create an Exception hierarchy for HTTP Status Exceptions
Steffen Gebert [Fri, 1 Apr 2011 10:13:20 +0000 (12:13 +0200)]
[FEATURE] Create an Exception hierarchy for HTTP Status Exceptions

This change creates an Exception hierarchy for the most frequently used
cases, when a request should be canceled with an Error 40x/50x.

Change-Id: If68f5f1f975b34c97b00a6a82c7eb47f38dc08cb
Resolves: #25697
Reviewed-on: http://review.typo3.org/1396
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[BUGFIX] List module - Fix pointer issue in pagebrowser
Susanne Moog [Sun, 10 Apr 2011 11:58:10 +0000 (13:58 +0200)]
[BUGFIX] List module - Fix pointer issue in pagebrowser

When you have more than 50 records in the list module, you can use
the page browser to display the next set of records.
When using this on the pages table, the pointer to page 2,3,.. is
added to the link of each page record. Selecting such a link causes
the result listing of that page to also start from that specific result
page. If there are not enough records, none will be shown.

Resolves: #20908
Change-Id: Ia112391533c40d4f2e56d41a6f893432480c8af1
Reviewed-on: http://review.typo3.org/1133
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[Bugfix] getUrl creates malformed requests if no path is given
Philipp Gampe [Sat, 12 Mar 2011 16:26:37 +0000 (17:26 +0100)]
[Bugfix] getUrl creates malformed requests if no path is given

If you fetch an url like example.org without a '/' at the end,
you will get a 400 Bad request of only fetching headers (2).
If you get all content+headers (1) you will get a 404.
getUrl should be tolerant and add the slash if it is missing.

Change-Id: I86c7478d46d62f980735e5b80c6766e8bd811938
Resolves: #12225
Resolves: #13432
Resolves: #24483
Reviewed-on: http://review.typo3.org/1138
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[BUGFIX] tcaTree Interface is not localized
Steffen Ritter [Wed, 2 Mar 2011 12:46:27 +0000 (13:46 +0100)]
[BUGFIX] tcaTree Interface is not localized

The TCA tree introduced to 4.5 is not localized by now.
Change it

Change-Id: Ifb713ca7194c1ac0e37f939b4af267fad4acb107
Resolves: #M17818
Reviewed-on: http://review.typo3.org/971
Reviewed-by: Björn Pedersen
Reviewed-by: Steffen Kamper
Tested-by: Steffen Kamper
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
8 years ago[CLEANUP] Replace spaces with tabs
Helmut Hummel [Thu, 7 Apr 2011 21:52:43 +0000 (23:52 +0200)]
[CLEANUP] Replace spaces with tabs

By fixing #25347 spaces were used as indention instead of tabs.
Replace the spaces with tabs as a cleanup.

Change-Id: I7f0005e7a53339c59a393fc8254c9fdd9ba87f23
Reviewed-on: http://review.typo3.org/1508
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
8 years ago[TASK] Remove DEPRECATED static templates
Xavier Perseguers [Fri, 25 Mar 2011 11:55:13 +0000 (12:55 +0100)]
[TASK] Remove DEPRECATED static templates

There are still lot of DEPRECATED static templates for extensions. They are not
supported anymore by the corresponding extensions since years.

Change-Id: I0f5bf30f6e8bb7574ea4e8d281778dab0ee3ab64
Resolves: #M16123
Reviewed-on: http://review.typo3.org/1275
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Susanne Moog
Reviewed-by: Markus Klein
Tested-by: Susanne Moog
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] Add missing parameter in "Page not found" handling
Steffen Gebert [Sun, 3 Apr 2011 18:42:13 +0000 (20:42 +0200)]
[BUGFIX] Add missing parameter in "Page not found" handling

t3lib_message_ErrorpageMessage::__construct() requires two parameters,
however only one is given after change #24945, which modified the
handling of 404 errors.

This patch adds the second one.

Change-Id: I7c82c11e4d90c1127076370e72fa99cd2ccda03b
Resolves: #25727
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1451
Reviewed-by: Steffen Kamper
Tested-by: Steffen Kamper
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] Disable of password field in setup should disable password2 too
Steffen Kamper [Tue, 29 Mar 2011 10:52:27 +0000 (12:52 +0200)]
[BUGFIX] Disable of password field in setup should disable password2 too

When using this userTS for disable the password field:
setup.fields.password.disabled=1
Then the field password2 for repeat the password remains rendered.

Solution:
if password is disabled, disable password2 too.

Change-Id: I954343d287302a2b65f4d3a6abdf34e528377cbc
Resolves: #25423
Reviewed-on: http://review.typo3.org/1303
Reviewed-by: Björn Pedersen
Reviewed-by: BIDAU
Tested-by: BIDAU
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[BUGFIX] tcaTree: make own record unselectable
Steffen Ritter [Wed, 2 Mar 2011 14:50:40 +0000 (15:50 +0100)]
[BUGFIX] tcaTree: make own record unselectable

Relations to an own record is not useful. You could exclude is via tca "andWhere"
This is not nice, because you wouldn't  see the whole tree.
Just make the own record unselectable.

Change-Id: I90a40df315055c116bf4d2b688694120606b62b9
Resolves: #M16726
Reviewed-on: http://review.typo3.org/977
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Kay Strobach
Reviewed-by: Tolleiv Nietsch
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
8 years ago[BUGFIX] Make backend layout dropdown in CE editform translateable
Stefano Kowalke [Sat, 5 Mar 2011 11:22:49 +0000 (12:22 +0100)]
[BUGFIX] Make backend layout dropdown in CE editform translateable

Change-Id: I755e70f1e82bc25515e879b9e166245a15d65b7e
Resolves: #M17873
Reviewed-on: http://review.typo3.org/1066
Reviewed-by: Steffen Kamper
Tested-by: Steffen Kamper
Reviewed-by: Christopher
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
8 years ago[BUGFIX] Wrong display of csh icon and text in new record wizard
sebastian.mueller [Tue, 29 Mar 2011 12:39:28 +0000 (14:39 +0200)]
[BUGFIX] Wrong display of csh icon and text in new record wizard

For each TCA-Table where you can add an element on a side, there is displayed
a csh icon with text (if text is configured). In db_new.php is a wrong
variable used so the csh text of the last tca-table is always used and for
each table. So it will also be displayed for tables which orginally got no csh text.

Additionally due to a missing break, the csh icon of a table is displayed
in the wrong line.

Change-Id: I39cee0f65d40626eb2c893fbaae4a9f25ae6c7d5
Resolves: #25371
Reviewed-on: http://review.typo3.org/1453
Reviewed-by: Francois Suter
Tested-by: Francois Suter
8 years ago[BUGFIX] BE list module fails to load after invalid inclusion removal
Xavier Perseguers [Sun, 3 Apr 2011 16:35:26 +0000 (18:35 +0200)]
[BUGFIX] BE list module fails to load after invalid inclusion removal

Class recordList is not included anymore due to a wrong require_once call deletion

Author:    Xavier Perseguers <typo3@perseguers.ch>
Change-Id: I60722426dd36842ce4460a712b310ee8aef9b2e9
Fixes: #25408
Reviewed-on: http://review.typo3.org/1449
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
8 years ago[FEATURE][CONF] Option to hide BE search box in list mod
Steffen Müller [Fri, 1 Apr 2011 13:03:17 +0000 (15:03 +0200)]
[FEATURE][CONF] Option to hide BE search box in list mod

Change-Id: Ic93ccc8c736ad95952b97da82152f0621cff9195
Resolves: #25705
Reviewed-on: http://review.typo3.org/1405
Reviewed-by: Alexander Stehlik
Tested-by: Alexander Stehlik
Reviewed-by: Steffen Kamper
Tested-by: Steffen Kamper
8 years ago[BUGFIX] BE list module fails on some systems with PHP 5.3
Xavier Perseguers [Mon, 28 Mar 2011 16:09:09 +0000 (18:09 +0200)]
[BUGFIX] BE list module fails on some systems with PHP 5.3

When trying to load Web > List, the server answers with
Fatal error: Cannot redeclare class recordList

Change-Id: I4cc7e542568b5a528c97bc5b93afd909ca766f39
Resolves: #25408
Reviewed-on: http://review.typo3.org/1296
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[TASK] Remove explicit checks for PHP < 5.3
Xavier Perseguers [Fri, 25 Mar 2011 15:53:29 +0000 (16:53 +0100)]
[TASK] Remove explicit checks for PHP < 5.3

Make PHP 5.3 a requirement for TYPO3 4.6 and remove tests that check for older
versions of PHP.

Change-Id: Ib73e332a44f618e59f78c8e442d2bf27474c4964
Resolves: #25395
Reviewed-on: http://review.typo3.org/1277
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[BUGFIX] Module -> List + "List only this table" search not working past page 1
Bjoern Pedersen [Fri, 1 Apr 2011 06:37:14 +0000 (08:37 +0200)]
[BUGFIX] Module -> List + "List only this table" search not working past page 1

Change-Id: I4edd9a020128246e4937dee8acb91ae7f393283d
Resolves: #25603
Reviewed-on: http://review.typo3.org/1390
Reviewed-by: Björn Pedersen
Tested-by: Björn Pedersen
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
8 years ago[FEATURE] Add helpful error messages in case of shortcut misconfiguration
Steffen Gebert [Thu, 31 Mar 2011 20:14:38 +0000 (22:14 +0200)]
[FEATURE] Add helpful error messages in case of shortcut misconfiguration

This change improves the output of wrongly misconfigured shortcut pages with
helpful error messages. Instead of "The requested page didn't have a proper
connection to the tree-root!", hints are given dependent on the configured
shortcut mode and target.

Thanks to Volker Graubaum (e-netconsulting) for sponsoring this fix with 80 beers
during the Bug Auction at T3BOARD11.

Change-Id: I09d88f907fc459b10e1598e117ea03733be8e0d0
Resolves: #24223
Reviewed-on: http://review.typo3.org/1366
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog