Packages/TYPO3.CMS.git
8 years ago[TASK] Additional unit tests for t3lib_div::mkdir and mkdir_deep
Loek Hilgersom [Thu, 8 Dec 2011 01:02:57 +0000 (02:02 +0100)]
[TASK] Additional unit tests for t3lib_div::mkdir and mkdir_deep

Added tests check if permissions and group ownership gets correctly
set when creating directories, also when a whole path is created
with mkdir_deep. These tests are created specifically for
https://review.typo3.org/7022
Omitted checks for thrown exceptions (not part of 4.5)

Change-Id: I19003d043729d6b3f8647b5175996e998843bb55
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8756
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[BUGFIX] htmlArea RTE: Target of localized string may be empty
Stanislas Rolland [Mon, 13 Feb 2012 19:40:34 +0000 (14:40 -0500)]
[BUGFIX] htmlArea RTE: Target of localized string may be empty

Solution: Do not allow an empty localized string to overrule the
default string.

Change-Id: I5b270b7b2888f5ff5d087ed2b65c9e5a55f17f30
Fixes: #33897
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/9017
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[BUGFIX] htmlArea RTE: Default skin inconsistent with ExtJS xtheme-blue
Stanislas Rolland [Mon, 13 Feb 2012 16:56:40 +0000 (11:56 -0500)]
[BUGFIX] htmlArea RTE: Default skin inconsistent with ExtJS xtheme-blue

The default RTE skin, used as default skin in FE, has colors
inconsistent with ExtJS skin xtheme-blue which is loaded by default
in FE.

Change-Id: I8c1714c133f503a7ebc4b9af0ccd7f09709e90ef
Fixes: #33889
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/9012
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[BUGFIX][t3editor] (De-)Activating does not work in Chrome
Steffen Gebert [Fri, 10 Feb 2012 21:48:00 +0000 (22:48 +0100)]
[BUGFIX][t3editor] (De-)Activating does not work in Chrome

The checkbox "Deactivate t3editor" does not work in modern Chrome
versions (e.g. 18). It works in Firefox, but didn't even work while
integrating the code into TYPO3 in Chrome.

Prototype recognizes it as Webkit and thus does not disable/enable it,
which was a pretty weird implementation, which is now removed.

Change-Id: I9660af7c754d25b1321c329e9d67f80ba6d71db8
Fixes: #33515
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/9011
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] Sorting of localized records is wrong after copying
Stanislas Rolland [Wed, 19 Oct 2011 16:15:50 +0000 (12:15 -0400)]
[BUGFIX] Sorting of localized records is wrong after copying

Solution: When copying a record in original language, if a localized
record of the destination record exists for language A, then the
localized record of the copied record, if it exists for language A,
should be inserted after the localized record, in language A, of the
destination record.
The same applies when moving a record in original language.
Similar situation arises when a new localization record is created.

Note: Backport from 4.7

Change-Id: I45464837e4685efbcf4671a6135a631d0c40d068
Resolves: #30469
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/8679
Reviewed-by: Stefan Neufeind
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
8 years ago[BUGFIX] Sporadic memcache error on server load
Dmitry Dulepov [Thu, 6 Oct 2011 14:00:54 +0000 (17:00 +0300)]
[BUGFIX] Sporadic memcache error on server load

Memcache server sometimes closes connection under heavy load. In
such cases TYPO3 shows error messages in Frontend when setting
the value to cache fails. This should not happen because it is
not such a error that should cause server down times. Change the
exception to a warning in sys_log instead. Admins can see the
error and work on it.

Change-Id: I3d461ef2517d8d10a161c1a1404931543681bb97
Fixes: #30162
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/5600
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Oliver Klee
Reviewed-by: Wouter Wolters
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
8 years ago[BUGFIX] IRRE translation links shouldn't be shown if no parent
Georg Ringer [Fri, 25 Nov 2011 06:45:13 +0000 (07:45 +0100)]
[BUGFIX] IRRE translation links shouldn't be shown if no parent

IRRE provides some links like "localize records" or "synchronize with
original language" which is great but those links should not be
shown if a record got no parent record

Change-Id: I4ea318abd0580fa79bce0b2dd98316027f7ddc57
Fixes: #32073
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8899
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
8 years ago[BUGFIX] Confusing error message in reports module
Markus Klein [Sun, 18 Dec 2011 04:48:51 +0000 (22:48 -0600)]
[BUGFIX] Confusing error message in reports module

The saltedpasswords status report shows "INSECURE" warnings
although the configuration is totally fine.

Change-Id: I58c5487ea589e38c58cf39511960ecfb91ffed59
Fixes: #32650
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8895
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
8 years ago[BUGFIX] Resetting of input field to default when having a range fails
Philipp Kitzberger [Wed, 28 Dec 2011 10:28:01 +0000 (11:28 +0100)]
[BUGFIX] Resetting of input field to default when having a range fails

When trying to reset a endtime (datetime or date) having a range (like tt_news
articles) the lower range limit will be stored instead of the default value.

Change-Id: I183b5ffa385e9d218f4942a57abd4e6a01e194fb
Fixes: #28298
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8960
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
8 years ago[BUGFIX] IRRE: Selected items remain in selector with foreign_unique
Stanislas Rolland [Wed, 8 Feb 2012 05:15:32 +0000 (00:15 -0500)]
[BUGFIX] IRRE: Selected items remain in selector with foreign_unique

Problem: When an inline field is defined as unique (foreign_unique
is set), selected items are removed neither from the inline record
selector, nor from the children record selectors.

Solution: Remove the used records from all selectors. Also, when
updating and collapseAll is set, remove records already used from
the child record after its ajax-retrieval/expansion.

Change-Id: I56ea89380c431af148216836da8913db76dc095e
Fixes: #21102
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/8956
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[BUGFIX] RTE: Removing div from formatblock selector may not workspaces
Stanislas Rolland [Thu, 9 Feb 2012 05:11:28 +0000 (00:11 -0500)]
[BUGFIX] RTE: Removing div from formatblock selector may not workspaces

Problem: RTE.default.buttons.formatblock.removeItems = div is not
honoured when indent/outdent is configured.
Solution: Honour the removal/restriction even when indent/outdent is
configured.

Fixes: #33457
Releases: 4.5, 4.6, 4.7

Change-Id: I2f2b43d8e5d74a6598667a3b79d6894acdff96f9
Reviewed-on: http://review.typo3.org/8921
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[BUGFIX] htmlArea RTE: CSS class names are lowercase in WebKit
Stanislas Rolland [Sat, 21 Jan 2012 06:24:39 +0000 (01:24 -0500)]
[BUGFIX] htmlArea RTE: CSS class names are lowercase in WebKit

Problem: See https://bugs.webkit.org/show_bug.cgi?id=55619
Solution: Add doctype to the iframe source

Change-Id: Iec721ee4e6eef990327f1398e02acdd35e89d689
Resolves: #32408
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/8623
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[BUGFIX] saltedpasswords update task only updates 42 records
Mario Rimann [Sun, 4 Dec 2011 19:29:08 +0000 (20:29 +0100)]
[BUGFIX] saltedpasswords update task only updates 42 records

The scheduler task to convert the fe_user and be_user passwords
to salted passwords took only 42 records per run. Now it should
take 250 per run. This will lead to an approx. run-time of about
50s (given 2 * 100ms * 250 records)

Change-Id: I1f37fd978984d6c6e4e06ad76b057575f916438b
Resolves: #31252
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8925
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
8 years ago[BUGFIX] Bookmarks to pages don't work
Stefan Galinski [Fri, 3 Feb 2012 17:22:49 +0000 (18:22 +0100)]
[BUGFIX] Bookmarks to pages don't work

Change-Id: I25fce6d672ffe890d494222ed4ea8a2500c5bfac
Fixes: #30352
Releases: 4.7. 4.6, 4.5
Reviewed-on: http://review.typo3.org/8830
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Galinski
Tested-by: Stefan Galinski
8 years ago[TASK] Disable compression for inlineJs in Backend
Steffen Gebert [Tue, 9 Aug 2011 19:51:32 +0000 (21:51 +0200)]
[TASK] Disable compression for inlineJs in Backend

JSMin is a major performance nightmare and no network connection can be
as slow as it would justify to spend so much time to execute JSmin
several times for each and every backend request.

As long as we have no fast replacement in core available, disable
compression for all JS snippets added with
t3lib_PageRenderer::addJsInlineCode in the Backend.

JSMin's share of execution time was about 20-25% of the page generation
time, for almost empty backend pages even ~50%.

Change-Id: Iabbd092a349dec6e84c40b7b7c750bc718168d85
Resolves: #29498
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/7201
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Sebastian Fischer
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Oliver Klee
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
8 years ago[BUGFIX] Prevent duplicate stdWrap for media content
Alexander Stehlik [Thu, 9 Jun 2011 22:17:14 +0000 (00:17 +0200)]
[BUGFIX] Prevent duplicate stdWrap for media content

All the standard renderers handle stdWrap themselves, so the general stdWrap
handling should be moved to the customMediaRenderer block to prevent duplicate
calls to stdWrap.

Change-Id: I4a8214d789721b68a0f9e5f55e4a27fc91a0e7cf
Fixes: #25277
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/7121
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
8 years ago[BUGFIX] Release locked records during logout
Tolleiv Nietsch [Sat, 4 Feb 2012 08:08:34 +0000 (09:08 +0100)]
[BUGFIX] Release locked records during logout

The sys_lockedrecords tables isn't cleared during the users logout.

Change-Id: I789cf1736a1b00760b54f8efddaffd633b47f4f5
Fixes: #20211
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8884
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
8 years ago[BUGFIX] Prevent compression of scripts that use ajax.php
Steffen Kamper [Tue, 11 Oct 2011 12:49:08 +0000 (14:49 +0200)]
[BUGFIX] Prevent compression of scripts that use ajax.php

When registering ajax calls, a pseudo JS file is registered within the
pageRenderer with a source like 'ajax.php?parameters'.

As it does not make sense to compress or concatenate those pseudo JS files,
the pageRenderer should ensure they are properly included.

Change-Id: I386663b9ea77426ea3d8e804eac0f3c8ca72cd7a
Fixes: #24274
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8881
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] "Show page" does not use a proper URL scheme
Dmitry Dulepov [Mon, 21 Nov 2011 12:16:35 +0000 (14:16 +0200)]
[BUGFIX] "Show page" does not use a proper URL scheme

"Show page" context menu and Web>View do not use proper scheme if
that is set in the page properties. They always use the scheme of
the Backend.

Change-Id: I3e700ecee13e0fb47317170dd2388cce627601fb
Fixes: #31959
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7412
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
8 years ago[TASK] Reports module uses internal data of salted passwords
Dmitry Dulepov [Mon, 28 Nov 2011 12:12:39 +0000 (14:12 +0200)]
[TASK] Reports module uses internal data of salted passwords

Reports module changes from issue #30695 introduced a check
for the saltedpasswords extension and a report about users,
whose passwords are not protected by the saltedpasswords.
That check queries database directly and uses internal
knowledge of saltedpasswords about marking the password
with certain characters. This can break reports module
if saltedpasswords adds a new scheme to salt passwords.
Only saltedpasswords should know about those prefixes.
Other extensions should use the API of saltedpasswords
to query the information.

Change-Id: I335697612d9f58935320261278054fc1863871f4
Resolves: #32136
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7408
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
8 years ago[BUGFIX] RTE: Some toolbar elements may not be correctly initialized
Stanislas Rolland [Mon, 6 Feb 2012 02:23:33 +0000 (21:23 -0500)]
[BUGFIX] RTE: Some toolbar elements may not be correctly initialized

This change is a follow-up to previous change which could cause JS
error when language dropdown is not configured in the toolbar.

Change-Id: I6c0edf8ba6869aa2f7ff36edb862015de46e57eb
Resolves: #33637
Releases: 4.5
Reviewed-on: http://review.typo3.org/8856
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[BUGFIX] Encoding error in TCEforms inline JavaScript
Manuel Stofer [Wed, 1 Feb 2012 09:17:02 +0000 (10:17 +0100)]
[BUGFIX] Encoding error in TCEforms inline JavaScript

JavaScript encoding is broken, when the link browser is used to add a
new item and sections are used.

Change-Id: Id366d078841a3decd0256f98df497956a494ecb8
Fixes: #32422
Related: #29067
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8790
Reviewed-by: Simon Tuck
Tested-by: Simon Tuck
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] t3lib_div::validPathStr() fails on certain file names
Dmitry Dulepov [Fri, 2 Dec 2011 15:22:56 +0000 (17:22 +0200)]
[BUGFIX] t3lib_div::validPathStr() fails on certain file names

Function t3lib_div::validPathStr() fails on file names with Unicode
characters. Adding 'u' modifier to the regular expression solves
the problem.

Change-Id: I99ebe784145eb3f2265eb7beb7dd58ac851c29ff
Resolves: #32046
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7796
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
8 years ago[BUGFIX] htmlArea RTE: Changing the text color to black does not work
Stanislas Rolland [Sat, 21 Jan 2012 02:31:32 +0000 (21:31 -0500)]
[BUGFIX] htmlArea RTE: Changing the text color to black does not work

Solution: Fix colorToHex conversion utility

Change-Id: I5c7f44f4255e0e52a8540a58f95eec3443ac9085
Resolves: #32877
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/8622
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[BUGFIX] htmlArea RTE: Firefox may report error when setting a color
Stanislas Rolland [Fri, 3 Feb 2012 00:36:20 +0000 (19:36 -0500)]
[BUGFIX] htmlArea RTE: Firefox may report error when setting a color

Problem: The color does get assigned, but Firefox reports a JS error.
Solution: The RTE may incorrectly detach the selection range.

Change-Id: Ief034d8d97894c44160487f353523bf83f688c7c
Resolves: #33644
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/8817
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[BUGFIX] RTE Text indicator does not work in Firefox in TYPO3 4.5
Stanislas Rolland [Thu, 2 Feb 2012 21:35:37 +0000 (16:35 -0500)]
[BUGFIX] RTE Text indicator does not work in Firefox in TYPO3 4.5

Solution: Backport logic from master (4.7).

Change-Id: Idf129efb55bc12ec8c2fe17ef931c0027ae08c69
Fixes: #33642
Releases: 4.5
Reviewed-on: http://review.typo3.org/8816
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[BUGFIX] RTE: Some toolbar elements may not be correctly initialized
Stanislas Rolland [Thu, 2 Feb 2012 18:05:33 +0000 (13:05 -0500)]
[BUGFIX] RTE: Some toolbar elements may not be correctly initialized

The language and font dropdowns need to initialized after their data
stores are loaded.

Change-Id: If34a6c03628ce277e4fa567fb34b0db8bcc428b4
Resolves: #33637
Releases: 4.5
Reviewed-on: http://review.typo3.org/8815
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[BUGFIX] Context menu of page translation doesn't work in languages view
Andreas Wolf [Mon, 29 Aug 2011 10:18:17 +0000 (12:18 +0200)]
[BUGFIX] Context menu of page translation doesn't work in languages view

For a page with translations, the clickmenu is not shown for these
translations in the page module, view "languages". This comes from a
missing table name in the clickmenu link generation call.

Change-Id: I6a66e0f1e21be072455ecab094d0cfc17c0e5802
Resolves: #27052
Releases: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/4662
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Galinski
Tested-by: Stefan Galinski
8 years agoRevert "[BUGFIX] Scheduler BE module fails to load due to autoloader issues"
Christian Kuhn [Sat, 28 Jan 2012 19:21:07 +0000 (20:21 +0100)]
Revert "[BUGFIX] Scheduler BE module fails to load due to autoloader issues"

The patch has an unwanted side-effect: It sometimes throws a php warning "Function spl_autoload_call() hasn't defined the class it was called for".
Reverted for now.

This reverts commit 33c8647966c919e2357701a4baaaef68738dfc91

Change-Id: If4cb4dc9e59dbdafe934d05c60bd92a14b55bde9
Reviewed-on: http://review.typo3.org/8755
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Reports module shows unnecessary info text
Markus Klein [Thu, 15 Dec 2011 01:49:26 +0000 (19:49 -0600)]
[BUGFIX] Reports module shows unnecessary info text

Do not show saltedpasswords info text in reports module
unless problems have been detected.

Change-Id: I4e3aeffe6bde09cea2a77193cf52672b0b71fa6b
Fixes: #32580
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8752
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Scheduler BE module fails to load due to autoloader issues
Dmitry Dulepov [Wed, 11 Jan 2012 12:15:00 +0000 (14:15 +0200)]
[BUGFIX] Scheduler BE module fails to load due to autoloader issues

When displaying a list of tasks, scheduler unserializes exceptions.
By default, unserialize() does not call autoloader to load classes
and it is possible that the exception class will not be loaded. In
such case scheduler BE module will fail with a PHP fatal error
when the scheduler will try to use a _PHP_Incomplete_Class.

The fix makes sure that autoloader is called during unserialize().
However this still may fail, so the scheduler now checks that the
exception is loaded properly before trying to use it.

Change-Id: I12188324ad133752a0c0eb77c4905ed1854197b7
Resolves: #33116
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8748
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Broken datepicker on unsaved flexform sections
Stefan Rotsch [Tue, 24 Jan 2012 10:41:55 +0000 (11:41 +0100)]
[BUGFIX] Broken datepicker on unsaved flexform sections

The onClick event for opening the datepicker is attached to the
datepicker icons only once on page load. There currently is no update
method which adds the onClick event to new sections, so the datepicker
icons are without function until the form is saved.

Related to this, IDs of input fields are not unique when adding more than
one new section before saving. They have to be randomized when inserting a
new section in order to make the datepicker work properly.

This patch implements an update() method in tceforms.js which is called
every time a new section is added to a flexform. The IDs of tceforms
date/datetime fields get randomized by adding a timestamp when adding a
new section.

Fixes: #23843
Releases: 4.7, 4.6, 4.5
Change-Id: Id64144f41804e64b245b68f0135e1b6e8c1bab4c
Reviewed-on: http://review.typo3.org/8746
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] TYPO3 prompts to select position when there are no pages
Dmitry Dulepov [Sat, 14 Jan 2012 10:43:01 +0000 (11:43 +0100)]
[BUGFIX] TYPO3 prompts to select position when there are no pages

When adding the very first page to the page tree, TYPO3 asks to
select a position and offers a weird looking selector (see the
attachment in the bug report). Instead, it should proceed
straight to the page properties window (or redirect to it).

Change-Id: I395e500d377879ebd206ad0e6042876f5a86f118
Resolves: #32111
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7802
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Unlimited memory limit handling in system status report
Mario Rimann [Fri, 2 Dec 2011 21:10:25 +0000 (22:10 +0100)]
[BUGFIX] Unlimited memory limit handling in system status report

According to the documentation, "-1" is a valid setting for PHP's
memory_limit and means "unlimited". So far this value has caused
the system status report to report this value as an error.

Change-Id: I2fbdbf8b9e39dd0425253f5487b869bc81f52e27
Fixes: #32231
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7793
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[BUGFIX] Warnings in BE when using "Find filename"
Dmitry Dulepov [Wed, 23 Nov 2011 13:14:58 +0000 (15:14 +0200)]
[BUGFIX] Warnings in BE when using "Find filename"

When using "Tools">"DB Check">"Find filename" with a slash
character (for example, "</title>"), there are warnings about
wrong regular expression in the Backend and nothing is found.

Change-Id: Ia8ebd218a6de5ead49301d0d082a6cbae0be1d93
Resolves: #21591
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8639
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] spriteManager for Clear RTE Cache icon
Felix Kopp [Sat, 31 Dec 2011 13:58:06 +0000 (14:58 +0100)]
[BUGFIX] spriteManager for Clear RTE Cache icon

RTE hooks into the clear cache menu to allow clearing RTE cache.
Changes the icon integration from iconWorks to spriteManager.
Solves styling issue caused by too small icon.

Change-Id: I60a5bbd045f05075be81eaab6603c02ab2653952
Resolves: #32892
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/8744
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[TASK] Improve debugTrail() to better handle includes
Markus Klein [Wed, 26 Oct 2011 00:28:04 +0000 (19:28 -0500)]
[TASK] Improve debugTrail() to better handle includes

The deprecation log lacks specific and necessary information about
include and require calls, which makes it hard to actually follow
a stack trace.

Add special treatment of this sort of functions and display additional
path information.

Change-Id: I0510082ad8668b0d552f65969bbec95f37365770
Resolves: #31300
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7795
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] htmlArea RTE: Some attributes wrongly unset by "Edit element"
Stanislas Rolland [Thu, 26 Jan 2012 15:37:07 +0000 (10:37 -0500)]
[BUGFIX] htmlArea RTE: Some attributes wrongly unset by "Edit element"

The style, lang and dir attributes may be incorrect after unsetting
using "Edit element" dialogue.

Change-Id: I9cd78d5e17588eb2b9f631b49e9d0c68af04538b
Resolves: #33466
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/8713
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[BUGFIX] Misinterpretation of memory_limit setting in install tool
Mario Rimann [Sun, 4 Dec 2011 21:34:51 +0000 (22:34 +0100)]
[BUGFIX] Misinterpretation of memory_limit setting in install tool

Adds a different warning into the system checks of the basic
configuration section of the install tool in case the memory_limit
is set to "-1" which means unlimited according to the PHP docs.

Change-Id: I9df642e0e92945927330eba9713dd866f50c53d3
Fixes: #20069
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8709
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-on: http://review.typo3.org/8710

8 years ago[BUGFIX] Marker not removed from file module
Ernesto Baschny [Thu, 26 Jan 2012 09:04:46 +0000 (10:04 +0100)]
[BUGFIX] Marker not removed from file module

If bookmarks are disabled, the ##SHORTCUT## marker is still shown.

Change-Id: I03820111e6384bf47b54aa2583fa891bcb55aa96
Fixes: #33455
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8708
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
8 years ago[TASK] Set TYPO3 version to 4.5.12-dev
TYPO3 v4 Release Team [Tue, 24 Jan 2012 10:32:39 +0000 (11:32 +0100)]
[TASK] Set TYPO3 version to 4.5.12-dev

Change-Id: I7d1611d26fb11aeaf936120a21d1a3374446e53a
Reviewed-on: http://review.typo3.org/8670
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
8 years ago[RELEASE] Release of TYPO3 4.5.11
TYPO3 v4 Release Team [Tue, 24 Jan 2012 10:32:30 +0000 (11:32 +0100)]
[RELEASE] Release of TYPO3 4.5.11

Change-Id: Ia292c6f4ae9d208b83b38d29d0758a39c043b799
Reviewed-on: http://review.typo3.org/8669
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
8 years ago[TASK] Raise submodule pointer
TYPO3 v4 Release Team [Tue, 24 Jan 2012 10:18:40 +0000 (11:18 +0100)]
[TASK] Raise submodule pointer

Change-Id: I87087c63d8828b2c473fb2cae0cf5fa6c4a66e3b
Reviewed-on: http://review.typo3.org/8664
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
8 years ago[BUGFIX] typolink prepends wrong domain when using url scheme
Dmitry Dulepov [Thu, 17 Nov 2011 16:03:43 +0000 (18:03 +0200)]
[BUGFIX] typolink prepends wrong domain when using url scheme

tslib_cObj::typoLink() uses a wrong domain if the target page
has a domain record and a URL scheme, which is different to
current. It prepends a current domain instead of the target
domain of the page.

Change-Id: Iedf2ade4707f41f10a1989b753cb5fc0dcf978a1
Resolves: #31771
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/6710
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[BUGFIX] htmlArea RTE: magic image maxWidth is not working as expected
Stanislas Rolland [Sat, 21 Jan 2012 18:04:21 +0000 (13:04 -0500)]
[BUGFIX] htmlArea RTE: magic image maxWidth is not working as expected

Solution: Clarify the documentation of the option

Change-Id: Ic6d530ac2f4a541e738033d8e14fc7fc3db3d6d3
Resolves: #32301
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/8627
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[BUGFIX] htmlArea RTE : Adding link problem with IE
Stanislas Rolland [Tue, 17 Jan 2012 22:58:04 +0000 (17:58 -0500)]
[BUGFIX] htmlArea RTE : Adding link problem with IE

Problem: Link may not be created on cell, list element or paragraph
when following element of same type already contains a link.
Solution: Fix selection breaking procedure

Change-Id: Ia35f4eb1f756eb5abc9d9d641e4b2fc1402cbb8f
Resolves: #31763
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/7836
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jean-S├ębastien Gervais
Tested-by: Jean-S├ębastien Gervais
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
8 years ago[BUGFIX] TCEmain::clear_cacheCmd relies on active BE_USER
Steffen Gebert [Thu, 29 Dec 2011 11:21:32 +0000 (12:21 +0100)]
[BUGFIX] TCEmain::clear_cacheCmd relies on active BE_USER

Several developers abuse t3lib_TCEmain and instantiate it also in other
contexts than BE, for which it never was made.

As this breaks several extensions that use it in FE or CLI mode and the
fix is trivial, avoid crashing.

Change-Id: I8df6682f0c28fd73cec461211c87fdcb4c9c4cb1
Fixes: #28007
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7807
Reviewed-by: Steffen Ritter
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
8 years ago[BUGFIX] md5.js fails with non-ascii-characters
Stefan Neufeind [Mon, 10 Oct 2011 12:04:32 +0000 (14:04 +0200)]
[BUGFIX] md5.js fails with non-ascii-characters

Current implementation of md5.js only considers a very
limited range of characters.
The implementation from webtoolkit.info uses correct
unicode-representation.

Change-Id: I3b75a14403791bb9aa2cb26972ac95fa74d74db2
Releases: 4.4, 4.5, 4.6
Resolves: #22328
Reviewed-on: http://review.typo3.org/5691
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[BUGFIX] HTML entity &nbsp; is inserted before and after inline element
Stanislas Rolland [Thu, 12 Jan 2012 23:45:39 +0000 (18:45 -0500)]
[BUGFIX] HTML entity &nbsp; is inserted before and after inline element

Problem: This is a regression caused by patch to issue #16217.
The last two lines of the merged patch are wrong. They should replace
only leading and trailing spaces inside block elements.
Solution: Revert the last two replacement lines of the patch.

Change-Id: I1ed4676ab4f16e2c3593a111c3593197a63b0d7b
Resolves: #32263
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/7754
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[BUGFIX] Module menu link wrap
Felix Kopp [Sun, 11 Dec 2011 23:27:58 +0000 (00:27 +0100)]
[BUGFIX] Module menu link wrap

Makes module links in menu on the left not wrap around in small frames.

Change-Id: Ie85287b0139c7b551838726e07b8328addb19cc4
Fixes: #32448
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/7399
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
8 years ago[BUGFIX] alt_doc.php uses deleted alternative page languages for translations
Marcus Krause [Fri, 28 Oct 2011 14:39:22 +0000 (16:39 +0200)]
[BUGFIX] alt_doc.php uses deleted alternative page languages for translations

The backend script alt_doc.php even considers deleted
pages_language_overlay records when determining in which language a
record can be/is localized.

This patch improves method documentation and applies
t3lib_BEfunc::deleteClause() on the respective database query.

Change-Id: I922ca2e5465b41ab40fcad42acc22fa2805dcfc4
Fixes: #31379
Releases: 4.3, 4.4, 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/6374
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
8 years ago[BUGFIX] Vague error message in t3lib_div
Dmitry Dulepov [Tue, 22 Nov 2011 14:44:08 +0000 (16:44 +0200)]
[BUGFIX] Vague error message in t3lib_div

If the web server cannot write to typo3temp/, a vague error
message may appear: "File not written to disk! Write
permission error in filesystem?". Fix the issue by hinting
the user where he should check permissions.

Change-Id: I96c19bb4f73df60f16286c6b4da14b3ef3e87700
Resolves: #18545
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7510
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Oliver Klee
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
8 years ago[BUGFIX] Typo in Install Tool
Georg Ringer [Wed, 4 Jan 2012 17:37:18 +0000 (18:37 +0100)]
[BUGFIX] Typo in Install Tool

Fix a simple typo in mail of Install Tool.

Change-Id: Ibe8b8003cbf6d2b98210bc22bf5e2a5678e0e137
Resolves: #32970
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7700
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[TASK] Scheduler: Add "Add Task" button to header
Markus Klein [Wed, 21 Dec 2011 22:24:01 +0000 (16:24 -0600)]
[TASK] Scheduler: Add "Add Task" button to header

This patch adds a "Add Task" button to the left area of
the module header.
It improves usability for long task lists and enforces
the standard layout of backend modules.
The "Add Task" link below the table is removed at the
same time.

Change-Id: If513454a895aefbbb7817753a7bacd6724562333
Resolves: #32753
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7512
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
8 years ago[BUGFIX] Reports are called twice
Philipp Gampe [Thu, 22 Dec 2011 00:20:34 +0000 (01:20 +0100)]
[BUGFIX] Reports are called twice

The code in getReport(), directly before the call to getSystemStatus(),
is exactly the same as in getSystemStatus().

Change-Id: Iedb1891cb6f807474e2fb1b994b24cbbbadf7ba7
Fixes: #32768
Releases: 4.5,4.6,4.7
Reviewed-on: http://review.typo3.org/7508
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
8 years ago[TASK] Raise submodule pointer
TYPO3 v4 Release Team [Tue, 20 Dec 2011 17:29:59 +0000 (18:29 +0100)]
[TASK] Raise submodule pointer

Change-Id: I427deea5ef67a4c82a5afcaf60d9de7a54a86d8a
Reviewed-on: http://review.typo3.org/7446
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
8 years ago[TASK] Set TYPO3 version to 4.5.11-dev
TYPO3 v4 Release Team [Tue, 20 Dec 2011 10:29:38 +0000 (11:29 +0100)]
[TASK] Set TYPO3 version to 4.5.11-dev

Change-Id: I0d45137eeafb23a7c9cc08bafe7855c809e7d7cb
Reviewed-on: http://review.typo3.org/7426
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
8 years ago[RELEASE] Release of TYPO3 4.5.10
TYPO3 v4 Release Team [Tue, 20 Dec 2011 10:29:29 +0000 (11:29 +0100)]
[RELEASE] Release of TYPO3 4.5.10

Change-Id: I4235f8fb7ede69c20741145b47433dc4fc60b2e8
Reviewed-on: http://review.typo3.org/7425
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
8 years ago[BUGFIX] Add SQL-comparator <> to SQL parser
Stefan Neufeind [Fri, 16 Dec 2011 22:48:00 +0000 (23:48 +0100)]
[BUGFIX] Add SQL-comparator <> to SQL parser

Comparator != was supported before.
But <> is ANSI SQL and therefore should be
supported as well.

Change-Id: I49dde6f06715ecd33df044d8a2e85a813516d6ad
Fixes: #32626
Releases: 4.4, 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/7417
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] Invalid query part on menu rendering
Oliver Hader [Sun, 6 Nov 2011 15:34:09 +0000 (16:34 +0100)]
[BUGFIX] Invalid query part on menu rendering

Each page can have a target defined, which can also be a
typeNum that gets added to the generated URL. Now if RealURL
is used, the "&type=" part will be just added to the final
URL which looks like "page.html&type=1". A question mark
is missing here to get a valid query part.

Change-Id: Idb5df6c604d12670107cbdd77c14e181cdb25dbe
Fixes: #31622
Releases: 4.7, 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/6959
Reviewed-by: Simon Schaufelberger
Tested-by: Simon Schaufelberger
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years agoRevert "[FEATURE] Add ExtJS xtype:modulepanel for BE Modules"
Ernesto Baschny [Mon, 19 Dec 2011 09:24:21 +0000 (10:24 +0100)]
Revert "[FEATURE] Add ExtJS xtype:modulepanel for BE Modules"

New features are not allowed in the stable branch. Please use the TYPO3_4-5_backports branch.

This reverts commit e1d535cc05d1c1da5ba8cbf103884084f69aca46

Change-Id: I8fb0a2d23ca60e186812834a63e5862bf9f27e1e
Reviewed-on: http://review.typo3.org/7377
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
8 years ago[BUGFIX] Login fails silently, when no backend for rsaauth is available
Steffen Gebert [Mon, 10 Oct 2011 22:15:13 +0000 (00:15 +0200)]
[BUGFIX] Login fails silently, when no backend for rsaauth is available

In case of no OpenSSL backend being available for rsaauth (e.g. after
moving to another server), the login silently fails.

Better throw an Exception and give useful hints, why no login is
possible and how to fix it.

Change-Id: Ic91d150f3efa307d7a9fa35e30c2036ef2dfb93d
Resolves: #30758
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/6965
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] EM: Uploading extensions fails with Fatal Errors
Steffen Gebert [Sun, 23 Oct 2011 20:24:36 +0000 (22:24 +0200)]
[BUGFIX] EM: Uploading extensions fails with Fatal Errors

In case of an extension having dependencies, suggestions, or conflicts,
the Extension Manager fails with PHP Fatal Errors.

Change-Id: Iaa04d733f25bf2e3bd7e2c2fcc2e85aa1461975e
Resolves: #27836
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/7111
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] sessionTimeout for BE does not work
Mario Rimann [Mon, 5 Dec 2011 20:59:26 +0000 (21:59 +0100)]
[BUGFIX] sessionTimeout for BE does not work

Changes an is_string() check to a check out of t3lib_Utility_Math
which will also accept '86400' as a valid value and not only 86400.

Change-Id: I469b532b67fc5ac523ced85616bcb869ec1e7b6d
Resolves: #32274
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7354
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
8 years ago[BUGFIX] @charset must be lowercase in CSS
Markus Klein [Tue, 29 Nov 2011 15:26:17 +0000 (09:26 -0600)]
[BUGFIX] @charset must be lowercase in CSS

CSS files must comply to http://www.w3.org/TR/CSS21/syndata.html#charset
which requires @charset to be
"the 10 characters '@charset "' (lowercase, no backslash escapes)".
Also the CSS compressor looks for the lowercase version.

Change-Id: Ie338e17817a76e0ebb61394b9c8088d685beb983
Fixes: #32163
Releases: 4.7, 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/7350
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
8 years ago[BUGFIX] Log password attempt with empty password
Mario Rimann [Fri, 25 Nov 2011 22:59:08 +0000 (23:59 +0100)]
[BUGFIX] Log password attempt with empty password

Adds logging for login attempts where an empty password is
submitted.

Change-Id: I473529845ab2a9e12d4d2f48a4553eb7dc02d681
Resolves: #18176
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/6923
Reviewed-by: Markus Klein
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
8 years ago[BUGFIX] Fatal error when exporting from root
Francois Suter [Sat, 5 Nov 2011 08:23:27 +0000 (09:23 +0100)]
[BUGFIX] Fatal error when exporting from root

An uncaught exception happens when trying to export records from a
singe table view in List mode on the page tree root. This is due to
the tree root being handled as a normal page record.

With this patch the tree root is handled as it should. Some cleanup
(CGL) is also applied.

Change-Id: I87b60cb098a2e8b9dcb407be6f69bd31ea2ddd9e
Fixes: #31350
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/6793
Reviewed-by: Oliver Hader
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
8 years ago[FEATURE] Add ExtJS xtype:modulepanel for BE Modules
Kay Strobach [Sun, 24 Jul 2011 08:31:39 +0000 (10:31 +0200)]
[FEATURE] Add ExtJS xtype:modulepanel for BE Modules

This is a follow up change to #12664.
It adds a new Extjs xtype called modulepanel and the required styles.

This way we can have extjs modules which fit the TYPO3 look'n'feel.

The CSS modifies the tbar and the bbar to look like the standard
toolbars in TYPO3.

4.5 is added to releases, as #12644 is the direct parent.

Change-Id: I57e51eb11b57889b4c434f13b658ca464a03a041
Resolves: #28384
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/7128
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
8 years ago[BUGFIX] Warnings in BE when using "Update reference index"
Dmitry Dulepov [Wed, 23 Nov 2011 13:24:12 +0000 (15:24 +0200)]
[BUGFIX] Warnings in BE when using "Update reference index"

If the table exists in $TCA but does not exist in the database,
"Update reference index" in "Tools">"DB Check" will throw
warnings. Implement a check and a descriptive error message in
the system log.

Change-Id: Iba80d74659cd9c0d168434f999cb9a281a9ba3f0
Resolves: #21590
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7109
Reviewed-by: Mario Rimann
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
8 years ago[BUGFIX] Hide versioning icon in list when workspaces is installed
Tolleiv Nietsch [Thu, 7 Jul 2011 05:34:13 +0000 (07:34 +0200)]
[BUGFIX] Hide versioning icon in list when workspaces is installed

Following #25962 the versioning icon in the
list module should be hidden whenever "workspaces" is installed.

Change-Id: I61149e288ad456670c3cdd2137b73e9380c5a910
Resolves: #27969
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/6966
Reviewed-by: Oliver Hader
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
8 years ago[BUGFIX] Fix path check for custom RTE styles
Stanislas Rolland [Sat, 17 Dec 2011 16:10:33 +0000 (11:10 -0500)]
[BUGFIX] Fix path check for custom RTE styles

Fix for #29899 introduced a check if the file holding
custom RTE CSS exists. However that path used was
wrong.

Change-Id: I9923b34f18ffd357439081f34bf69339820fa714
Fixes: #32625
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/7341
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[BUGFIX] Ambiguous XCLASS naming tx_em_Connection_ExtDirectServer
Steffen Gebert [Sat, 17 Dec 2011 10:24:39 +0000 (11:24 +0100)]
[BUGFIX] Ambiguous XCLASS naming tx_em_Connection_ExtDirectServer

The naming for XCLASSing tx_em_Connection_ExtDirectServer is written
with and without underscore between "connection" and "extdirectserver".

Change-Id: Ib8373df2c4fc377880e554563609d83191bd1ef2
Resolves: #32596
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7332
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] Random miscalculations in ImageTTFBBox
Albrecht Koehnlein [Wed, 13 Jul 2011 09:47:21 +0000 (11:47 +0200)]
[BUGFIX] Random miscalculations in ImageTTFBBox

ImageTTFBBox() randomly returns incorrect negative values. Repeat the operation
a number of time if this happens to try to find the correct values.

Change-Id: Ic7367345c786148674fe83331b9fff368546038c
Fixes: #21054
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/7119
Reviewed-by: Simon Schaufelberger
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
8 years ago[TASK] Set TYPO3 version to 4.5.10-dev
TYPO3 v4 Release Team [Fri, 16 Dec 2011 09:19:54 +0000 (10:19 +0100)]
[TASK] Set TYPO3 version to 4.5.10-dev

Change-Id: I678dd446095203f752c5a02454b9b676a5ac9378
Reviewed-on: http://review.typo3.org/7303
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
8 years ago[RELEASE] Release of TYPO3 4.5.9
TYPO3 v4 Release Team [Fri, 16 Dec 2011 09:19:34 +0000 (10:19 +0100)]
[RELEASE] Release of TYPO3 4.5.9

Change-Id: I4237674a2b81b170491a7942693777369b8ad4b7
Reviewed-on: http://review.typo3.org/7302
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
8 years ago[TASK] Raise submodule pointer
TYPO3 v4 Release Team [Fri, 16 Dec 2011 09:14:17 +0000 (10:14 +0100)]
[TASK] Raise submodule pointer

Change-Id: I6047bf3b7b15a93341b5eaf82624fca51cd7230c
Reviewed-on: http://review.typo3.org/7299
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
8 years ago[BUGFIX] RTE not loading in IE when content css file does not exist
Stanislas Rolland [Sun, 13 Nov 2011 02:05:08 +0000 (21:05 -0500)]
[BUGFIX] RTE not loading in IE when content css file does not exist

Solution: Fallback to the default contentCSS file when the file
specified in Page TS Config does not exist or has zero file size.

Change-Id: I7377daaee8443b0cbf8e2515d34316a278c8ec06
Resolves: #29899
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/6652
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[BUGFIX] TCEforms draws huge empty icon row which on select-fields
Benjamin Mack [Wed, 5 Oct 2011 14:14:47 +0000 (16:14 +0200)]
[BUGFIX] TCEforms draws huge empty icon row which on select-fields

Certain fields of type "select" which offer records from a
"foreign_table" will contain a huge amount of t3-icon-empty
icons just below the select box. If you have enough of them,
you even get a horizotanl scrollbar.

See some screenshots here:
http://forge.typo3.org/issues/13422

The issue is not a CSS issue, but a bug in the rendering
of such a field.

See it in action in tt_content field "sys_language". Just create
enough sys_language records so that you see the row of empty
icons being created. This wasn't this way before.

Change-Id: I2e2e59c906b2e239ba161b16aa1980f454210229
Resolves: #25398
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/7118
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
8 years ago[BUGFIX] Restructure the random byte generator
Helmut Hummel [Tue, 29 Mar 2011 22:18:47 +0000 (00:18 +0200)]
[BUGFIX] Restructure the random byte generator

Restructure the code to use the most performant methods first
if available. Take specialities of Windows OS and special
PHP versions into account.

Read/ generate more bytes than needed in one call, because it
does not cost (much) more to generate more random bytes, but it's
much cheaper for the next calls, because the bytes are already there.

Resolves: #23355, #23860, #24410, #24440, #23496
Releases: 4.6, 4.5, 4.4, 4.3

Change-Id: I42eea55dcbcd8d8f5b1a6e9493993e9ccd967dfa
Reviewed-on: http://review.typo3.org/4555
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Tomasz Krawczyk
Tested-by: Tomasz Krawczyk
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] Install Tool shows internal MySQL databases
Mario Rimann [Sun, 4 Dec 2011 21:53:52 +0000 (22:53 +0100)]
[BUGFIX] Install Tool shows internal MySQL databases

This patch removes "mysql" and "information_schema" from the
list of databases that the install tool offers to choose from.

Change-Id: I37fd85323f82c96941fadbf79c76b13041b5fb74
Resolves: #19278
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7084
Reviewed-by: Oliver Hader
Reviewed-by: Oliver Klee
Reviewed-by: Mario Rimann
Reviewed-by: Simon Schaufelberger
Tested-by: Simon Schaufelberger
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] Wrong char for explodes of links
Georg Ringer [Fri, 9 Sep 2011 15:49:50 +0000 (17:49 +0200)]
[BUGFIX] Wrong char for explodes of links

user_plaintext::renderImage uses ',' as char to
explode links but TYPO3 switched to a LF

Change-Id: I91b27467a40b4c984d26eee6a50e4206ff8b2c2f
Resolves: #29597
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/7116
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
8 years ago[TASK] Integrate system extension linkvalidator as submodule
Oliver Hader [Tue, 29 Nov 2011 09:30:19 +0000 (10:30 +0100)]
[TASK] Integrate system extension linkvalidator as submodule

Integrate system extension linkvalidator as Git submodule.
git://git.typo3.org/TYPO3v4/Extensions/linkvalidator.git

Change-Id: Ic0ec09fa6997106f28b6d24cf59eb296318bf176
Resolves: #32075
Reviewed-on: http://review.typo3.org/6970
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[BUGFIX] Add possibility to use Wizards->Suggest in FlexForms
Tolleiv Nietsch [Mon, 10 Oct 2011 01:58:07 +0000 (03:58 +0200)]
[BUGFIX] Add possibility to use Wizards->Suggest in FlexForms

The field names generated for the suggest wizard are
not compatible with "flex" fields. This changes loads
the datastructure for the field and expands the
field name as needed.

Change-Id: Iee65dd6c4f43fe7e8bdbc65a71e8b7f37e3b45aa
Fixes: #22231
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/7134
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
8 years ago[BUGFIX] Gap between module menu items causes collapse on click
Kay Strobach [Sat, 25 Jun 2011 10:52:05 +0000 (12:52 +0200)]
[BUGFIX] Gap between module menu items causes collapse on click

Transform the margins between entries in the module menu into paddings
to avoid that clicks on this margin cause collapsing of the menu
section.

Change-Id: Ife437730988287ca847c589edfc9b98a9bc677a6
Resolves: #27634
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/7126
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
8 years ago[BUGFIX] Localization: Editing in TCEforms shows unstyled original value
Benjamin Mack [Sat, 9 Jul 2011 08:22:50 +0000 (10:22 +0200)]
[BUGFIX] Localization: Editing in TCEforms shows unstyled original value

When editing a translated record in the TCEforms backend, the original
language label is shown below, in a green box. The green box is
definitively from the old skin (3.x) and should be changed.

Change-Id: Iceb9227a4a84ff6b06ba42d5c69f2b4f0ef74d51
Resolves: #28012
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/7122
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
8 years ago[BUGFIX] Use trimExplode() for pageOverlayFields
Georg Ringer [Tue, 16 Aug 2011 06:26:18 +0000 (08:26 +0200)]
[BUGFIX] Use trimExplode() for pageOverlayFields

Currently explode() is used for pageOverLayFields which requires a list
without any whitespaces. Using t3lib_div::trimExplode() improves
the usability for integrators and reduces possibilities of not working
configurations

Change-Id: I29db746de9831699721cfa93639c76397d2a026b
Resolves: #28916
Releases: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/7130
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
8 years ago[BUGFIX] EM: Available extension list misses icons
Steffen Gebert [Sun, 9 Oct 2011 12:11:14 +0000 (14:11 +0200)]
[BUGFIX] EM: Available extension list misses icons

The list of available extensions misses the install/uninstall icons in
Firefox 7 and Internet Explorer 9.

Change-Id: I8686646c2d3063134463076e92da9970213d4d2d
Resolves: #30369
Releases: 4.6,4.5
Reviewed-on: http://review.typo3.org/7110
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] Remove hardcoded limits in T3D export
Georg Ringer [Thu, 9 Jun 2011 17:22:07 +0000 (19:22 +0200)]
[BUGFIX] Remove hardcoded limits in T3D export

The memory_limit is hardcoded to 256m and
max_execution_time to 600.

There is no reason to hardcode those settings,
sometimes a bit more of both is needed.

Change-Id: I553c45c16be1ad561928678fa6a838abb78975d1
Resolves: #27272
Resolves: #17020
Resolves: #17045
Resolves: #18926
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/7063
Reviewed-by: Stefan Neufeind
Reviewed-by: Oliver Klee
Reviewed-by: Sebastian Fischer
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
9 years ago[TASK] Implement check for saltedpasswords in reports module
Steffen Ritter [Mon, 24 Oct 2011 22:38:58 +0000 (00:38 +0200)]
[TASK] Implement check for saltedpasswords in reports module

The reports module should show a warning, if saltedpasswords is
not installed or not configured correctly.

Change-Id: Icbd31378a05f02f20de5e43a63465c119f72a6d3
Resolves: #30695
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/6278
Reviewed-by: Stefan Neufeind
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
9 years ago[BUGFIX][SECURITY] XSS vulnerability in BE-User Admin module
Marco Bresch [Wed, 23 Nov 2011 16:34:58 +0000 (17:34 +0100)]
[BUGFIX][SECURITY] XSS vulnerability in BE-User Admin module

Fix XSS at column 'workspace membership'.

How to test:
* choose a workspace title like "<b>test</b>"
* assign a user as member to the workspace
* select the BE-module "Admin Tools->User Admin"
* select the checkbox "Workspace membership"
* press update
* take a look at column "Workspace membership"

Change-Id: I278287728db76b256607bcd07f58751553b40868
Fixes: #32040
Releases: 4.7, 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/6963
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
9 years ago[BUGFIX] Log date picker broken
Francois Suter [Mon, 31 Oct 2011 15:05:52 +0000 (16:05 +0100)]
[BUGFIX] Log date picker broken

The date picker in the Admin Tools > Log when selecting a user-defined
time range is broken. Adapt it to new skinning API for the JS to act
on it properly again.

Change-Id: Id09f190db1a8165cfd51abd2dd16049d8dfea644
Resolves: #31450
Releases: 4.7, 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/6860
Reviewed-by: Francois Suter
Tested-by: Francois Suter
9 years ago[TASK] Set TYPO3 version to 4.5.9-dev
TYPO3 v4 Release Team [Tue, 22 Nov 2011 14:59:55 +0000 (15:59 +0100)]
[TASK] Set TYPO3 version to 4.5.9-dev

Change-Id: I9edf67e08ff8de37a09305c20f39d19c1168cfc5
Reviewed-on: http://review.typo3.org/6855
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
9 years ago[RELEASE] Release of TYPO3 4.5.8
TYPO3 v4 Release Team [Tue, 22 Nov 2011 14:59:47 +0000 (15:59 +0100)]
[RELEASE] Release of TYPO3 4.5.8

Change-Id: I0138efdcac887ab8c43358e50ffb0ae602034df1
Reviewed-on: http://review.typo3.org/6854
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
9 years ago[TASK] Raise submodule pointer
TYPO3 v4 Release Team [Tue, 22 Nov 2011 14:41:31 +0000 (15:41 +0100)]
[TASK] Raise submodule pointer

Change-Id: Id3aebf7cb8f79e5f467e55db311fb26354622ab5
Reviewed-on: http://review.typo3.org/6849
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
9 years ago[BUGFIX] Error in the pageNotFound_handling with USER_FUNCTION
Dmitry Dulepov [Thu, 17 Nov 2011 15:53:50 +0000 (17:53 +0200)]
[BUGFIX] Error in the pageNotFound_handling with USER_FUNCTION

When using USER_FUNCTION in the pageNotFound_handling, an exception
or a blank screen appears in the Frontend (depending on error
handling settings) because $GLOBALS['TSFE']->sys_page is not
initialized.

Change-Id: Ieb2ef07d4977ebceeee7e68c390f53f9646337b0
Resolves: #31839
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/6846
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
9 years ago[BUGFIX] Vimeo mediawizardprovider needs new syntax
Georg Ringer [Tue, 8 Nov 2011 07:58:02 +0000 (08:58 +0100)]
[BUGFIX] Vimeo mediawizardprovider needs new syntax

Vimeo changed its behaviour and there is always the
vimeo error "no video" shown. Their change is strange
as vimeo required the argument clip_id as the 1st one

Change-Id: I6f4e1758175a2bda1eb7bfd9083fb769e1c6eeca
Resolves: #31661
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/6841
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
9 years ago[BUGFIX] magic_quotes_gpc does not exist anymore in PHP 5.4
Xavier Perseguers [Tue, 20 Sep 2011 09:36:58 +0000 (11:36 +0200)]
[BUGFIX] magic_quotes_gpc does not exist anymore in PHP 5.4

PHP INI magic_quotes_gpc got deprecated in PHP 5.3 and is removed in
PHP 5.4, init.php should then behave as if it were set to "Off".

Change-Id: Ifcd4fb7cc9c2cb23ba6d910ffbe6cc034a66cdbd
Fixes: #30083
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/6833
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
9 years ago[BUGFIX] Multiple values not displayed for simple items lists
Francois Suter [Fri, 28 Oct 2011 12:09:00 +0000 (14:09 +0200)]
[BUGFIX] Multiple values not displayed for simple items lists

t3lib_BEfunc::getProcessedValue() is used throughout the Core to
transform values stored as indices into human-readable values.

However for select-type fields based on a list of items
(and not a foreign table) where multiple selections are possible,
t3lib_BEfunc::getProcessedValue() fails to display anything.
This is due to t3lib_BEfunc::getLabelFromItemlist(),
being unable to handle several values.

This patch introduces a new method to avoid breaking compatibility.

Change-Id: I5fa6f385a3efa11db9aae82399102e67a96ec700
Resolves: #31374
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/6370
Reviewed-by: Michael Stucki
Tested-by: Michael Stucki
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Francois Suter
Tested-by: Francois Suter
9 years ago[TASK] Update ADOdb library to version 5.14
Xavier Perseguers [Tue, 1 Nov 2011 11:46:31 +0000 (12:46 +0100)]
[TASK] Update ADOdb library to version 5.14

Change-Id: Ib30675a445160b455dced98e6db6361f44b8bf51
Resolves: #31486
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/6766
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
9 years ago[BUGFIX] Error after hide/show element in list module
Simon Schaufelberger [Wed, 16 Nov 2011 18:22:36 +0000 (12:22 -0600)]
[BUGFIX] Error after hide/show element in list module

Showing or hiding an element with workspace selected will result in
Error: Could not be edited in offline workspace...

Change-Id: I768320084fd24917d22cbc1d01b47387da863605
Resolves: #20598
Releases: 4.7, 4.6, 4,5
Reviewed-on: http://review.typo3.org/6703
Reviewed-by: Georg Ringer
Reviewed-by: Simon Schaufelberger
Tested-by: Simon Schaufelberger
Reviewed-by: Francois Suter
Tested-by: Francois Suter