Anja Leichsenring [Sun, 10 Feb 2013 10:39:14 +0000 (11:39 +0100)]
[BUGFIX] Respect wildcard in PropertyConfiguration shouldMap()
Using 'name.*' in property mapping configuration did not work for
fields added on the client, because shouldMap() would reject those
fields before the configuration was even checked.
This patch is a backport from Flow.
Fixes: #43928
Releases: 6.1, 6.0
Change-Id: I7fb71f705f242160700e8c082373f547d9cf72b5
Reviewed-on: https://review.typo3.org/18177
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
Andreas Wolf [Sun, 10 Feb 2013 11:43:16 +0000 (12:43 +0100)]
[BUGFIX] Followup to issue #45323
Fix two places where create() was changed to get() on wrong objects.
Change-Id: I4bb79a14e280ce36fe7a6da28149f0e1212f2383
Related: #45323
Reviewed-on: https://review.typo3.org/18182
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Marc Bastian Heinrichs [Sun, 10 Feb 2013 10:55:05 +0000 (11:55 +0100)]
[TASK] Replace ObjectManager create with get
Since Extbase ObjectManager::create is deprecated replace all
usages of the create method with get.
Change-Id: I4a438565d8512c8f892cef5b63fb6483fd74d712
Resolves: #45323
Releases: 6.1
Reviewed-on: https://review.typo3.org/18175
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
Marc Bastian Heinrichs [Sat, 9 Feb 2013 23:25:30 +0000 (00:25 +0100)]
[TASK] Sync objectmananger get and create with Flow
ObjectManager::create was deprecated since Flow beta1 and was
removed for Flow 1.0. To be in sync again deprecate Extbase
ObjectManager::create and use ObjectManager::get.
Change-Id: I5b92bae39ec63fdd985797ff03cb688ea6ff96d3
Resolves: #45322
Releases: 6.1
Reviewed-on: https://review.typo3.org/18162
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
Markus Günther [Sat, 9 Feb 2013 20:37:12 +0000 (21:37 +0100)]
[TASK] Clean up Unit tests in extbase
We had many tests in extbase that are incomplete.
These tests has been incomplete for several years.
Some test has been removed also in TYPO3 flow.
Change-Id: I75a20d1a1bac6fdeca79067acd5d00ad2db9f964
Fixes: #45330
Releases: 6.1
Reviewed-on: https://review.typo3.org/18169
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Reviewed-by: Oliver Klee
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Anja Leichsenring [Sat, 9 Feb 2013 18:19:13 +0000 (19:19 +0100)]
[!!!][TASK] Remove forced STI settings from extbase configuration
The tx_extbase_type setting for fe_users and fe_groups was introduced
as a demonstration of Single Table Inheritance handled in extbase.
The forced setting brings more problems then doing good in real live
scenarios though.
So the typoscript is dropped, but TCA and sql kept for backwards
compatibility reasons.
Before 6.1 only fe_users with tx_extbase_type
Tx_Extbase_Domain_Model_FrontendUser and
fe_groups with Tx_Extbase_Domain_Model_FrontendUserGroup
are returned. Since 6.1 all fe_users and fe_groups are
returned if you don't set the TypoScript setting on your own.
Resolves: #11021
Releases: 6.1
Change-Id: I8c1fbc48d4ee5ea1202ac6d7837170ff74eba442
Reviewed-on: https://review.typo3.org/17879
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Sebastian Kurfürst [Sat, 9 Feb 2013 21:04:35 +0000 (22:04 +0100)]
[FEATURE] (MVC): Whitelist-based Property Mapping Configuration
Up to now, property mapping in the rewritten property mapper always
allowed to modify all properties of a given object. Especially in the
MVC stack, this functionality was relied upon for all update and create
actions. However, for nested objects, the user needed to configure
whether updates and creations should be allowed.
This was an inconsistent behavior, especially because for read-only
actions the object could be also modified.
The behavior is now changed to be more predictive:
- the default PropertyMappingConfiguration used in the MVC stack is
changed to be very restrictive: we do neither allow creation of any
new objects nor modification of existing ones; and all properties
which should be modified must be explicitly configured.
- For each form, Fluid now generates a list of trusted properties,
based upon which the PropertyMappingConfiguration is set correctly.
This means only properties which have been rendered by fluid are
allowed to be modified, and creation / insertion is only permitted
if needed.
(Excerpt from commit message of the original change in Flow)
https://review.typo3.org/#/c/10926/
This Patch is a 100% backport from this change with some needed
adjustments for the unit tests.
Change-Id: I6e59183a6ddfe83c65f975a2e2211e9ac33c5ccc
Resolves: #43057
Releases: 6.1
Reviewed-on: https://review.typo3.org/17092
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Andreas Wolf [Sat, 9 Feb 2013 19:00:38 +0000 (20:00 +0100)]
[TASK] Decouple BE module runner and Bootstrap
The Bootstrap class is currently registered as a dispatcher for backend
modules (called from mod.php). The dispatching is done in
Bootstrap::callModule(), which does not access the rest of the class
except run() (which is part of the public API).
To make the distinction more clear (and make different dispatchers
possible without logic fuckup), the module running code is moved
to a separate class ModuleRunner.
Change-Id: I7d7571d3204f9da927aa7c3d3cf0cca2b121ef15
Resolves: #45318
Releases: 6.1
Reviewed-on: https://review.typo3.org/18165
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Anja Leichsenring [Sat, 9 Feb 2013 12:40:53 +0000 (13:40 +0100)]
[TASK] Improve Test
Refine the test for DateTimeConverter timezone handling.
The suggested backport from Flow Fluid was already in place, but the
improved test was missing.
Resolves: #44213
Releases: 6.1
Change-Id: I3c7d73c1bba8ebecc5d49020d155d5d27c256961
Reviewed-on: https://review.typo3.org/18155
Reviewed-by: Markus Günther
Tested-by: Markus Günther
Reviewed-by: Daniel Hürtgen
Reviewed-by: Wouter Wolters
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
Anja Leichsenring [Fri, 14 Dec 2012 12:58:58 +0000 (13:58 +0100)]
[TASK] Add FileReference table mapping in extbase configuration
Extbase ships the FileReference model, but using it as a property
type causes a SQL error mentioning the table can not be found.
So adding the mapping to the extbase TypoScript configuration
resolves this problem.
Change-Id: I6d9452918dd78f767592aeafc9620e5ffc2880cc
Resolves: #44012
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/17160
Reviewed-by: Stefan Neufeind
Reviewed-by: Ingo Pfennigstorf
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Alexander Schnitzler [Fri, 25 Jan 2013 12:41:38 +0000 (13:41 +0100)]
[TASK] Provide unit test for Mvc/Response
Releases: 6.1
Resolves: #44804
Change-Id: Iaaaaa1e10915ec7527bf89605b557fa7f75d2df3
Reviewed-on: https://review.typo3.org/17701
Reviewed-by: Mattias Nilsson
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Günther
Tested-by: Markus Günther
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Alexander Schnitzler [Fri, 25 Jan 2013 12:48:02 +0000 (13:48 +0100)]
[TASK] Improve code coverage of Mvc/Request
Currently two important methods "getControllerObjectName"
and "setControllerObjectName" aren't tested at all. This
patch provides tests for both.
Releases: 6.1
Resolves: #44805
Change-Id: I3bcbfc72c5b77da3d876489dd4423c79823171c1
Reviewed-on: https://review.typo3.org/17702
Reviewed-by: Daniel Hürtgen
Tested-by: Daniel Hürtgen
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Alexander Schnitzler [Thu, 29 Nov 2012 14:05:36 +0000 (15:05 +0100)]
[FEATURE] Allow different overriding of object mapping per plugin
Currently the ObjectContainer has an array with a mapping of
class names to actual classes which allows the replacement
of objects via DI.
This mapping is set during the bootstrap process and uses the
typoscript settings in config.tx_extbase.objects which is too
strict. To be able to ovverride these settings for each plugin
extbase has to use 'CONFIGURATION_TYPE_FRAMEWORK' settings
instead of 'CONFIGURATION_TYPE_FULL_TYPOSCRIPT' settings.
Releases: 6.1
Resolves: #44796
Change-Id: I5d6ea135f5bec586073da3394f0ba8e0197020b7
Reviewed-on: https://review.typo3.org/17696
Reviewed-by: Mattias Nilsson
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Christian Kuhn [Tue, 5 Feb 2013 18:38:13 +0000 (19:38 +0100)]
[TASK] Remove loadTCA calls
Change-Id: I3de34fcaee7f5a3e973ccf203973d15c9a0e467d
Related: #45107
Releases: 6.1
Reviewed-on: https://review.typo3.org/18027
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Christian Kuhn [Sat, 26 Jan 2013 19:20:56 +0000 (20:20 +0100)]
[BUGFIX] Alphanumeric validator fails with broken PCRE
After change from #44216 the alphanumeric filter fails on
systems like debian squeeze with PHP 5.3.3 due to a broken
PCRE environment.
Change-Id: I349385c13c5b9757d879d483ec7e625501e32e88
Resolves: #44832
Related: #44216
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/17734
Reviewed-by: Wouter Wolters
Reviewed-by: Daniel Hürtgen
Tested-by: Daniel Hürtgen
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Christian Kuhn [Sat, 26 Jan 2013 19:06:31 +0000 (20:06 +0100)]
[BUGFIX] RepositoryTest raises warning
The change for issue #42506 introduced an incomplete mocking
of the Query object, now throwing warnings about missing
constructor() parameters. Fix is to not call the constructor.
Next to that, a minor namespace is fixed.
Change-Id: I7f3645549aeed97d5e11f44a17152441eb9bbad9
Resolves: #44833
Related: #42506
Releases: 6.1
Reviewed-on: https://review.typo3.org/17733
Reviewed-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Alexander Schnitzler [Fri, 25 Jan 2013 13:19:24 +0000 (14:19 +0100)]
[BUGFIX] ConfigurationManager must use namespaced FrontendSimulator
Since TYPO3 6.0 all classes are namespaced.
Though a compatibility layer exists all calls on old
class names should be avoided, so this patch replaces
calls on Tx_Extbase_Utility_FrontendSimulator with
\TYPO3\CMS\Extbase\Utility\FrontendSimulatorUtility.
Releases: 6.1, 6.0
Fixes: #44806
Change-Id: I60dd5f4fee8d5df8a79bb931e946a867b0083291
Reviewed-on: https://review.typo3.org/17703
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Alexander Schnitzler [Fri, 18 Jan 2013 13:38:02 +0000 (14:38 +0100)]
[TASK] Provide Unit Test for Scheduler/Task
Releases: 6.1
Resolves: #44638
Change-Id: Ibb522e3618b647f05a16b15fd114937ce482dcbd
Reviewed-on: https://review.typo3.org/17589
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Ingo Pfennigstorf [Sat, 8 Sep 2012 20:04:13 +0000 (22:04 +0200)]
[BUGFIX] Ordering without grouping is incompatible with non-MySQL DBMS
Each SELECT COUNT(*) statement has orderings. This fixes the
behaviour that is incompatible to database systems other than
MySQL and also is not needed as only an integer is returned.
Thanks to Xavier Perseguers for the patch.
Change-Id: I81a51dc6a7978434ef8e7751d7c72823e88fe550
Fixes: #25873
Releases: 1.3, 1.4, 4.7, 6.0
Reviewed-on: https://review.typo3.org/14461
Reviewed-by: Xavier Perseguers
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Xavier Perseguers
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Alexander Schnitzler [Sat, 19 Jan 2013 14:59:13 +0000 (15:59 +0100)]
[TASK] Provide Unit Test for Scheduler/TaskExecuter
Releases: 6.1
Resolves: #44664
Change-Id: I9ba89e1acc98082cceb7561c394dad1488cbe888
Reviewed-on: https://review.typo3.org/17598
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Alexander Schnitzler [Sat, 19 Jan 2013 19:45:14 +0000 (20:45 +0100)]
Revert "[FEATURE] Allow different overriding of object mapping per plugin"
This reverts commit
fecb7b1b32629283aa932cde38bdd26ee94dcf8d.
Releases: 6.1
Change-Id: I448b1fd0638a86ab31705be1c87056bc082b0dc8
Reviewed-on: https://review.typo3.org/17597
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
Alexander Schnitzler [Fri, 18 Jan 2013 15:57:01 +0000 (16:57 +0100)]
[TASK] Improve code coverage of Scheduler/FieldProvider
* Also fixed a small bug in Cli/Command.php
Releases: 6.1
Resolves: #44650
Change-Id: Ic9cc4ebb81a3926415223f6a7a8078198a39f1ab
Reviewed-on: https://review.typo3.org/17592
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Alexander Schnitzler [Fri, 18 Jan 2013 18:11:11 +0000 (19:11 +0100)]
[TASK] Increase code coverage of FrontendConfigurationManager
Releases: 6.1
Resolves: #44656
Change-Id: If39fb33a3a3d4cffca3f74f5f15d4a44ebf0e152
Reviewed-on: https://review.typo3.org/17593
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Alexander Schnitzler [Thu, 17 Jan 2013 17:07:27 +0000 (18:07 +0100)]
[TASK] Increase code coverage of Service/TypeHandlingService
Added one missing tests to achieve 100% code coverage.
Also adjusted the copyright header.
Releases: 6.1
Resolves: #44612
Change-Id: If543b055c139d63edcb8960e7e0f89875017bdf3
Reviewed-on: https://review.typo3.org/17581
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
Alexander Schnitzler [Thu, 17 Jan 2013 16:15:11 +0000 (17:15 +0100)]
[TASK] Increase code coverage of SignalSlot/Dispatcher
Added some missing tests to achieve 100% code coverage.
Also adjusted the copyright header and author annotations.
Releases: 6.1
Resolves: #44611
Change-Id: I9ffb474b5cd44d30c9eff49ae37ab55f5f68a5ce
Reviewed-on: https://review.typo3.org/17580
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
Alexander Schnitzler [Thu, 17 Jan 2013 13:42:14 +0000 (14:42 +0100)]
[TASK] Provide Unit Test for Error/Message
Releases: 6.1
Resolves: #44603
Change-Id: Iceb69ccb6b5097cf6c8cf9d7ff0d3fe440ac9d8e
Reviewed-on: https://review.typo3.org/17578
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Alexander Schnitzler [Thu, 17 Jan 2013 12:58:44 +0000 (13:58 +0100)]
[FEATURE] Provide UnitTest.xml with code coverage generation
This patch provides a basic setup for running extbase unit
test through one xml file that also collects code coverage
data whoose output will be stored in Build/Coverage.
Releases: 6.1
Resolves: #44601
Change-Id: I51f5c4c85d22a82848172b4716267d08d1b2f0f5
Reviewed-on: https://review.typo3.org/17576
Reviewed-by: Ingo Pfennigstorf
Tested-by: Ingo Pfennigstorf
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Helmut Hummel [Thu, 8 Nov 2012 15:45:37 +0000 (16:45 +0100)]
[TASK] Rename property, getter and setters of File Model
To be in line with TYPO3 Flow, rename the properties from
non speaking "object" to "originalResource"
This change did not make it into 6.0 final, but still should
be part of the 6.0 branch. Since the file models were not
usable anyway because of a bug in the data mapper
(see #10770), it's safe to rename these.
Resolves: #44255
Releases: 6.0, 6.1
Change-Id: Id9efe02a80e29e1ac6a4f6697f104bfb59e51399
Reviewed-on: https://review.typo3.org/17287
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Reviewed-by: Mattias Nilsson
Reviewed-by: Stefan Neufeind
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Markus Günther [Fri, 17 Aug 2012 23:07:05 +0000 (01:07 +0200)]
[FEATURE] Add userGroups to backendUser model
This patch adds the new BackendUserGroup model as property to the new
BackendUser model. The patch adds the usual methods for a
SplObjectStorage and the corresponding unit tests
Change-Id: I047361810eeb48c53483c99ed0a79966d0dd0e00
Resolves: #39329
Releases: 6.1
Reviewed-on: https://review.typo3.org/13879
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Markus Günther [Fri, 17 Aug 2012 23:49:12 +0000 (01:49 +0200)]
[FEATURE] Add filemount property to backend users
This patch set adds the new extbase filemount model as property to the
backend user model.
Change-Id: I8ed292fa4c38794a13ca62ee85f7767e16dc80e5
Resolves: #39324
Releases: 6.1
Reviewed-on: https://review.typo3.org/13880
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Oliver Klee
Reviewed-by: Markus Günther
Tested-by: Markus Günther
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Alexander Schnitzler [Mon, 7 Jan 2013 20:43:04 +0000 (21:43 +0100)]
[BUGFIX] Remove newline after ?> in AbstractController
The last commit added a newline again. This patch
removes it again.
Releases: 6.1
Fixes: #44366
Change-Id: I4bd33dc7947a64f975183f49eeffa3412f5c4d42
Reviewed-on: https://review.typo3.org/17406
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
Alexander Schnitzler [Fri, 4 Jan 2013 18:38:21 +0000 (19:38 +0100)]
[BUGFIX] Avoid clearing the page cache too often
Instead of clearing the page cache on every
create, update and delete action, implement
a page id stack which will be cleared at the
end of the request.
Releases: 6.1, 6.0
Fixes: #6117
Change-Id: I3703011e6cd2db9c6a4f32ba27ef09ecb25954f3
Reviewed-on: https://review.typo3.org/17373
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Stefan Neufeind
Reviewed-by: Markus Günther
Tested-by: Markus Günther
Anja Leichsenring [Sun, 6 Jan 2013 15:24:42 +0000 (16:24 +0100)]
[BUGFIX] Correct indention of class comment
Fixes: #44343
Releases: 6.1
Change-Id: I4acc9b50d7534f16ba7dca8bbdb34de1db3beac0
Reviewed-on: https://review.typo3.org/17394
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Alexander Schnitzler [Sun, 6 Jan 2013 09:57:42 +0000 (10:57 +0100)]
[BUGFIX] Suppress debug output of debugger in unit tests
Currently the debug output will be rendered which
leads to printed css if testing unit tests on the
command line.
Releases: 6.0
Fixes: #44335
Change-Id: Ie25c8f6cfe7380739d34a270ea2a0b3984e168e2
Reviewed-on: https://review.typo3.org/17388
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Anja Leichsenring [Sun, 6 Jan 2013 09:38:07 +0000 (10:38 +0100)]
[BUGFIX] Fix failing tests in ActionControllerTest
Introduction of signals into ActionController caused
some Unit Tests to fail. This patch injects the missing
SignalSlotDispatcher into those tests.
Fixes: #44334
Releases: 6.1
Change-Id: I44cfa71070442a83e2259d57743353dcaba0f3e7
Reviewed-on: https://review.typo3.org/17383
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
Anja Leichsenring [Sun, 6 Jan 2013 09:28:45 +0000 (10:28 +0100)]
Revert "[FEATURE] Introduce beforeCallActionMethod signal"
This reverts commit
f0614b4c7f7dc566889ea3de7d400f81ebb82740
Change-Id: Ic8908fb9cd959639f4f41ce5c35330ecfd521b6b
Reviewed-on: https://review.typo3.org/17382
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Alexander Schnitzler [Fri, 4 Jan 2013 12:28:28 +0000 (13:28 +0100)]
[FEATURE] Introduce beforeCallActionMethod signal
This patch introduces a signal for hooking in
right before calling the action method of the
controller. The slots are given the controller
name, the action name and the action arguments.
Relases: 6.1
Resolves: #7397
Change-Id: I09fbf75356060b4a0129c12ff2087e686016e442
Reviewed-on: https://review.typo3.org/17380
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Alexander Schnitzler [Fri, 4 Jan 2013 12:28:28 +0000 (13:28 +0100)]
[FEATURE] Introduce beforeCallActionMethod signal
This patch introduces a signal for hooking in
right before calling the action method of the
controller. The slots are given the controller
name, the action name and the action arguments.
Relases: 6.1, 6.0
Resolves: #7397
Change-Id: Ieaa27be80b187f5b6b60296404079febac663bd2
Reviewed-on: https://review.typo3.org/17364
Reviewed-by: Mattias Nilsson
Reviewed-by: Wouter Wolters
Reviewed-by: Daniel Hürtgen
Tested-by: Daniel Hürtgen
Reviewed-by: Stefan Neufeind
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Alexander Schnitzler [Sat, 17 Nov 2012 16:59:08 +0000 (17:59 +0100)]
[BUGFIX] Prevent sql errors with missing ColumnMap
If the TCA configuration for an object is missing
no ColumnMap can be generated which leads to sql
errors in method addUnionStatement in Typo3DbBackend.
Instead an Exception should be thrown.
Releases: 6.0, 6.1
Fixes: #7267
Change-Id: Ie364d2199be3d1e0128811e0cc41ff7ad210324b
Reviewed-on: https://review.typo3.org/16536
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
Alexander Schnitzler [Sat, 5 Jan 2013 09:44:05 +0000 (10:44 +0100)]
[BUGFIX] DebuggerUtility does not rewind instances of Iterator
Debugging a collection like ObjectStorage changes
the internal collection pointer which leads to the
collection being invalid.
Fixes: #43955
Releases: 6.1, 6.0, 4.7
Change-Id: I8258640c3ef7e2a7a4c53d608e673f59eecdeab1
Reviewed-on: https://review.typo3.org/17374
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Alexander Schnitzler [Fri, 4 Jan 2013 17:14:45 +0000 (18:14 +0100)]
[BUGFIX] Make AlphanumericValidator work with umlauts
Changes the regular expression used to validate the
string into a unicode-aware character-class and adds
a tests for this.
Backport of: https://review.typo3.org/#/c/9923/
Releases: 6.1, 6.0
Fixes: #44216
Change-Id: I85b77691ed7eea04972d834bb5fd083555872eee
Reviewed-on: https://review.typo3.org/17370
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Alexander Schnitzler [Fri, 4 Jan 2013 12:58:24 +0000 (13:58 +0100)]
[BUGFIX] Use interface in PersistenceManager::injectQueryFactory
Currently PersistenceManager::injectQueryFactory
expects a concrete implementation of QueryFactory
instead of an descendant of QueryFactoryInterface.
Releases: 6.1
Fixes: #32026
Change-Id: I1f25a4fdf692e144e5b5773ee7d25beca3e44444
Reviewed-on: https://review.typo3.org/17365
Reviewed-by: Mattias Nilsson
Reviewed-by: Wouter Wolters
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Alexander Schnitzler [Fri, 4 Jan 2013 16:25:32 +0000 (17:25 +0100)]
[BUGFIX] Use interface in Mapper::injectQueryFactory
Currently Mapper::injectQueryFactory expects a
concrete implementation of QueryFactory instead
of an descendant of QueryFactoryInterface.
Releases: 6.1
Fixes: #35936
Change-Id: Ie4a0cac10e866d8a41497ca31d915c8b1b2d66df
Reviewed-on: https://review.typo3.org/17369
Reviewed-by: Ralf Merz
Reviewed-by: Wouter Wolters
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Alexander Schnitzler [Mon, 17 Dec 2012 08:34:00 +0000 (09:34 +0100)]
[CLEANUP] Remove newlines after closing php tag
During the last commits some newlines made it
into extbase again. This patch removes them all.
Releases: 6.1
Fixes: #44042
Change-Id: Ifd2fe5e27c71e9ba93b5449b029cc381754c44ee
Reviewed-on: https://review.typo3.org/17185
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
Alexander Schnitzler [Thu, 29 Nov 2012 14:05:36 +0000 (15:05 +0100)]
[FEATURE] Allow different overriding of object mapping per plugin
Currently the ObjectContainer has an array with a mapping of
class names to actual classes which allows the replacement
of objects via DI.
This mapping is set during the bootstrap process and uses the
typoscript settings in config.tx_extbase.objects which is too
strict. To be able to ovverride these settings for each plugin
extbase has to use 'CONFIGURATION_TYPE_FRAMEWORK' settings
instead of 'CONFIGURATION_TYPE_FULL_TYPOSCRIPT' settings.
Releases: 6.1
Resolves: #43450
Change-Id: I067b19769e007578cea406964fc568dcf5727b7a
Reviewed-on: https://review.typo3.org/16855
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Alexander Schnitzler [Thu, 15 Nov 2012 15:01:19 +0000 (16:01 +0100)]
[TASK] Make current persistence replaceable
Releases: 6.1
Fixes: #42506
Change-Id: I409dec8eec58f512c1f2ce4d090816eb595bbcc5
Reviewed-on: https://review.typo3.org/16461
Reviewed-by: Mattias Nilsson
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Stefan Froemken [Tue, 11 Dec 2012 21:20:05 +0000 (22:20 +0100)]
[BUGFIX] Deprecated functions used in on fresh 6.0 final
There are some deprecated function calls I have
changed to the new functions
Resolves: #43528
Releases: 6.0, 6.1
Change-Id: I1acde2c8250192732030d2137e251ac79e5db81d
Reviewed-on: https://review.typo3.org/17116
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
Alexander Schnitzler [Tue, 11 Dec 2012 15:14:41 +0000 (16:14 +0100)]
[CLEANUP] Remove all @author annotations
Also adjusted some operators for jenkins
Releases: 6.1
Resolves: #43887
Change-Id: I5e6ba540d7d828bd24417356b887182966fb581c
Reviewed-on: https://review.typo3.org/17102
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Alexander Schnitzler [Tue, 11 Dec 2012 13:35:00 +0000 (14:35 +0100)]
[CLEANUP] Replace wrong/old file copyright comments
All files should have the same file comment with the
same copyright notice in it. Also there must not be
an author any more. Instead the Extbase Team is
mentioned as author from now on.
Releases: 6.1
Fixes: #43883
Change-Id: Ib61859a2fa853a238907df314f948da51306d7e8
Reviewed-on: https://review.typo3.org/17099
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Stefan Neufeind [Fri, 10 Jun 2011 19:30:06 +0000 (21:30 +0200)]
[FEATURE] Recursive starting point/storage pid via TypoScript
Change-Id: I47840230c1aa094c13bafb1b94c3f09ecadd6a33
Resolves: #6944
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/2636
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Kai Vogel [Wed, 21 Nov 2012 14:19:48 +0000 (15:19 +0100)]
[BUGFIX] MM_match_fields is ignored when persisting MM relations
With this patch MM_match_fields will be stored into MM table when
persisting MM relations between Extbase objects.
Change-Id: I8270f05c5dda4d15c42ad187efe9bc93be003c5a
Resolves: #43198
Releases: 6.1, 6.0
Reviewed-on: http://review.typo3.org/16854
Reviewed-by: Kai Vogel
Tested-by: Kai Vogel
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Ingo Pfennigstorf [Tue, 27 Nov 2012 09:33:10 +0000 (10:33 +0100)]
[TASK] Update ChangeLog.txt for 6.0
The Changelog is updated with a list of all commits since 4.7.
Fixes: #43334
Releases: 6.0
Change-Id: I64f485c0c9edd76918053d2493393924d4306fcd
Reviewed-on: http://review.typo3.org/16784
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Alexander Schnitzler [Wed, 28 Nov 2012 11:51:11 +0000 (12:51 +0100)]
[TASK] Update version to 6.1.0-dev
Releases: 6.1
Resolves: #43389
Change-Id: I0112ca34d5ff2ed48d63b0dac2c426db4ad53e83
Reviewed-on: http://review.typo3.org/16836
Reviewed-by: Wouter Wolters
Reviewed-by: Mattias Nilsson
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Helmut Hummel [Tue, 27 Nov 2012 10:03:18 +0000 (11:03 +0100)]
Revert "[BUGFIX] MM_match_fields is ignored when persisting MM relations"
This reverts commit
423ff57f029150e1cceb99d35eb5a4b77381f6e3
Change-Id: I597afa00b42a2e0ba55d23df85d6c25d2774387e
Reviewed-on: http://review.typo3.org/16787
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Claus Due [Sat, 20 Aug 2011 16:27:20 +0000 (18:27 +0200)]
[TASK] Timestamp support for DateTimeConverter
This change adds DateTimeConverter support for integer values
by using the "U" dateFormat which reads a UnixTimestamp date
format (i.e. integer as string).
Under the assumption that the new PropertyMapper is being
used, this fixes the bugs below.
At the same time backport the changes done in Flow and use the
same solution which is currently pending in Flow (#41989)
Fixes: #7574
Fixes: #8536
Fixes: #5595
Releases: 6.0
Change-Id: Id39e37451767ea732288423911109d83d47aa6e4
Reviewed-on: http://review.typo3.org/4440
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Kai Vogel [Wed, 21 Nov 2012 14:19:48 +0000 (15:19 +0100)]
[BUGFIX] MM_match_fields is ignored when persisting MM relations
With this patch MM_match_fields will be stored into MM table when
persisting MM relations between Extbase objects.
Resolves: #43198
Releases: 6.0
Change-Id: I8cd6dd70748b242870c73b697153ced650022450
Reviewed-on: http://review.typo3.org/16670
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Nicole Cordes [Sat, 24 Nov 2012 00:15:27 +0000 (01:15 +0100)]
[BUGFIX] Missing table definitions crash Dbal
The function
\TYPO3\CMS\Extbase\Persistence\Generic\Storage\Typo3DbBackend::parseQuery
returns table names not as numeric array but as associative array. To pass
a valid tablename for Dbal compatibility it is necessary to adjust the
current value.
Change-Id: Ia932e86436bd9365913e2e2723273d8ecc6a9d93
Fixes: #43263
Releases: 6.0
Reviewed-on: http://review.typo3.org/16705
Reviewed-by: Stefan Neufeind
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Alexander Schnitzler [Wed, 21 Nov 2012 17:06:43 +0000 (18:06 +0100)]
[BUGFIX] Remove property item of category model
Because the mere presence of the property leads
to an SqlException in the Typo3DbBackend it has
to be removed for 6.0. For 6.1 a solution will
be found.
Releases: 6.0
Fixes: #43074
Change-Id: I35850ba3513c48da692f6e1a9d07e7cfbfd7f1b3
Reviewed-on: http://review.typo3.org/16673
Reviewed-by: Ingo Pfennigstorf
Tested-by: Ingo Pfennigstorf
Reviewed-by: Wouter Wolters
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
Alexander Schnitzler [Wed, 21 Nov 2012 18:42:14 +0000 (19:42 +0100)]
[TASK] Adjust namespaces of persistence unit tests
Test files that have been moved from Persistence
to Persistence\Generic also have to have an proper
namespace.
Also moved two test files back to Persistence.
I accidently moved them too in my last patch.
Releases: 6.0
Fixes: #43205
Change-Id: I1e29fd409f868da3e2295fa96ee685ca005ab584
Reviewed-on: http://review.typo3.org/16676
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
Alexander Schnitzler [Wed, 21 Nov 2012 18:30:59 +0000 (19:30 +0100)]
[TASK] Move persistence unit tests
From Persistence to Persistence\Generic
Releases: 6.0
Fixes: #43204
Change-Id: I5eb269217e8369b0f05dc52b2595fed3f1a41442
Reviewed-on: http://review.typo3.org/16675
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
Alexander Schnitzler [Tue, 20 Nov 2012 11:06:00 +0000 (12:06 +0100)]
[CLEANUP] Adjust code to coding guidelines
* whitespaces, tabs and blank line issues
* bool -> boolean
* int -> integer
* remove @scope and @entity
Fixes: #43146
Releases: 6.0
Change-Id: I0ffdde3c918920272e8b1e4d1eab199b7b3e90f3
Reviewed-on: http://review.typo3.org/16600
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Christian Kuhn [Mon, 19 Nov 2012 21:05:37 +0000 (22:05 +0100)]
[TASK] Comment legacy files to be removed with 6.2
The 'old' class files before namespace switch are commented
to be removed with TYPO3 7.0, but they should be scheduled
for removal with 6.2.
Change-Id: I01bad5874d1bf57e4272f7918557a8f53213cd0e
Resolves: #43120
Releases: 6.0
Reviewed-on: http://review.typo3.org/16586
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Anja Leichsenring [Sat, 17 Nov 2012 16:49:05 +0000 (17:49 +0100)]
[BUGFIX] Use tablename for fullQuoteStr call
In Typo3DbBackend->replacePlaceholders method always 'foo' is
used as tablename. As long as mysql is used this makes no difference,
but it prevents dbal from ensure proper quotation for other databases.
Fixes: #43058
Releases: 1.3, 4.7, 6.0
Change-Id: I9f08b9026d14d86e704771fd43ec3613045b4698
Reviewed-on: http://review.typo3.org/16534
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Alexander Schnitzler [Mon, 19 Nov 2012 15:50:28 +0000 (16:50 +0100)]
[BUGFIX] Remove newlines after closing php tag
Also made Jenkins happy...
* ext_localconf.php
* Tests/Unit/Persistence/Mapper/DataMapFactoryTest.php
Releases: 6.0
Fixes: #43106
Change-Id: I16d92dfb8cee675e85df9dcb90cd25b3fa56333f
Reviewed-on: http://review.typo3.org/16569
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
Marc Bastian Heinrichs [Sat, 17 Nov 2012 19:17:03 +0000 (20:17 +0100)]
[BUGFIX] Force command controller task arguments saved as array
Executing command controller scheduler tasks without
action arguments fails because the arguments aren't saved as
array in the serialized task which is required for setting the request
arguments. Solution: cast the sumitted arguments to array.
Change-Id: Ie8b7d11fa6bfd666b720b387523c825d32b3876a
Fixes: #37563
Releases: 4.7, 6.0
Reviewed-on: http://review.typo3.org/16539
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Ingo Pfennigstorf
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
Alexander Schnitzler [Sat, 17 Nov 2012 16:59:08 +0000 (17:59 +0100)]
[BUGFIX] Prevent sql errors with unsupported relation
Using passthrough as relation causes sql errors
in the addUnionStatement of Typo3DbBackend. To
prevent this an Exception is introduced which will
be thrown instead.
Fixes: #27057
Releases: 6.0
Change-Id: I3e57d2b8c290e8f8b445278a3a25ffef15adbeb5
Reviewed-on: http://review.typo3.org/16537
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Tomasz Grzemski
Tested-by: Tomasz Grzemski
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
Marc Bastian Heinrichs [Sat, 17 Nov 2012 18:42:28 +0000 (19:42 +0100)]
[BUGFIX] Make saving scheduler commandController tasks working again
After converting to namespaces the name of the configuration fields
in backend also contains namespaces. Rename them back to the original
name.
Also the commands select box option labels wasn't compatible to
namespaces.
Fixes: #43035
Releases: 6.0
Change-Id: I6f86cccaf6936f4ef8c64d830143930f1a48971c
Reviewed-on: http://review.typo3.org/16538
Reviewed-by: Markus Günther
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Ingo Pfennigstorf
Tested-by: Ingo Pfennigstorf
Ingo Pfennigstorf [Sun, 18 Nov 2012 21:53:02 +0000 (22:53 +0100)]
[BUGFIX] Add missing TypoScript Mapping for Category Model
The missing TypoScript configuration for the category model is
provided with this patch.
Fixes: #43084
Releases: 6.0
Change-Id: If93e5be94c845b21e77c8522444d3aaeae9c7ee4
Reviewed-on: http://review.typo3.org/16559
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Markus Günther [Sat, 17 Nov 2012 13:35:48 +0000 (14:35 +0100)]
[BUGFIX] Tx_Extbase_DomainObject_AbstractDomainObject#getUid is final
The final #getUid() method prevents Doctrine from generating proxies.
Having the method final is not necessary here.
Fixes: #35937
Releases: 6.0
Change-Id: Ib325647834accdce5b3f95967161beae9df81612
Reviewed-on: http://review.typo3.org/16521
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Oliver Klee
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
Alexander Schnitzler [Fri, 16 Nov 2012 10:11:25 +0000 (11:11 +0100)]
[BUGFIX] Fix small DebuggerUtility issues
* adjust css for better/safer margins
* respect ArrayAccess
* fix level depth in array rendering
* fix wrong display of max depth with arrays
* remove expand icon for empty objects/collections
Releases: 6.0
Fixes: #43051
Change-Id: I6641d53df7b9591598c738b9ea55ba96939d2224
Reviewed-on: http://review.typo3.org/16516
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
Marc Bastian Heinrichs [Fri, 16 Nov 2012 14:43:54 +0000 (15:43 +0100)]
[BUGFIX] Fix and deprecate legacy creation of objects in repository
Since DI is used for instantiation of session and backend
objects, creating repository objects with makeInstance will fail. Add
legacy creation for this both objects to constructor and deprecate the
legacy creation
Fixes: #42968
Fixes: #42928
Releases: 6.0
Change-Id: Idc8aa7aadc2a4e43fdd938902dbd5f8c8098bf24
Reviewed-on: http://review.typo3.org/16484
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Marc Bastian Heinrichs [Sat, 17 Nov 2012 10:00:09 +0000 (11:00 +0100)]
[!!!][BUGFIX] Remove property isOnline from frontenduser model
Because there is no TCA definition for column is_online the
property would not get filled with data from database in mappping
process. Remove it to avoid confusion.
Fixes: #11024
Releases: 6.0
Change-Id: Ic62d2d918ac3bd0307e8ff1b6432769f12d1bb4e
Reviewed-on: http://review.typo3.org/16510
Reviewed-by: Ingo Pfennigstorf
Tested-by: Ingo Pfennigstorf
Reviewed-by: Markus Günther
Tested-by: Markus Günther
Tymoteusz Motylewski [Fri, 16 Nov 2012 16:23:24 +0000 (17:23 +0100)]
[BUGFIX] Make ValidatorResolver respect namespaces
ValidatorResolver should parse namespaced validator
definitions like:
@validate Vendor.Extension:Foo
or
@validate Vendor\Extension\FooValidator
Change-Id: I37ce3f559f2917b149256d1b57a838c6394048e0
Fixes: #42791
Releases: 6.0
Reviewed-on: http://review.typo3.org/16491
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Markus Günther
Tested-by: Markus Günther
Andreas Kiessling [Sat, 17 Nov 2012 10:36:55 +0000 (11:36 +0100)]
[BUGFIX] Reset 'vendorName' in RequestBuilder to NULL for new requests
It is currently impossible to use extensions with AND without
namespaces on the same page, since the vendorName is not reset
when a new request is built. So when the request is analyzed later on,
a vendor from a previous plugin may be found and thus the wrong
classname is built.
This patch resets the vendorName to NULL in method 'loadDefaultValues'.
Releases: 6.0
Fixes: #42782
Change-Id: Ie2d74a7140b325826fb752505e7569069f77146c
Reviewed-on: http://review.typo3.org/16481
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Jana Golinowski [Sun, 21 Oct 2012 21:35:21 +0000 (23:35 +0200)]
[BUGFIX] Correctly apply _LOCAL_LANG from typoscript
Language labels from typoscript are currently loaded by overwriting the
source/target array that is required by the method
Tx_Extbase_Utility_Localization::translate().
Change-Id: I936565475ec7741a5c0cb0d308b785bc08e4c708
Fixes: #42130
Releases: 6.0, 4.7, 4.6
Reviewed-on: http://review.typo3.org/15871
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Anja Leichsenring [Fri, 9 Nov 2012 07:20:35 +0000 (08:20 +0100)]
[TASK] Rename Reflection/Service to Reflection/ReflectionService
This is part of the code cleanup.
Change-Id: I1d9ff99b565e279110ee8c6e1cff8ab6a47566f5
Resolves: #42808
Releases: 6.0
Reviewed-on: http://review.typo3.org/16341
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Tymoteusz Motylewski [Wed, 7 Nov 2012 08:58:07 +0000 (09:58 +0100)]
[BUGFIX] Cache in BackendConfigurationManager is not taking pageId into account
Cache in BackendConfigurationManager is not taking pageId into account
Thanks to Timo Schmidt for providing the patch.
Change-Id: I55a5eb6bda086af91c5bf3ab621754b1a04d0f1e
Fixes: #42737
Releases: 6.0, 4.7, 1.3
Reviewed-on: http://review.typo3.org/16246
Reviewed-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Peter Niederlag(office) [Thu, 21 Jul 2011 13:23:53 +0000 (15:23 +0200)]
[BUGFIX] DataMapperFactory respects foreign_table_field
- add foreign_table_field if present in $TCA
- add a corresponding unit test
Change-Id: I02eac46a7e4b17c001fe30fb9469e1e94b3dfb0f
Resolves: #28369
Releases: 4.7, 6.0
Reviewed-on: http://review.typo3.org/3454
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Ingo Pfennigstorf [Wed, 14 Nov 2012 14:36:43 +0000 (15:36 +0100)]
[BUGFIX] Fix Annotation for Category model
This fixes the annotation for the item property in the Category model.
Resolves: #42970
Releases: 6.0
Change-Id: Ic6e5f54a608f0c8f311a8fd887ce4c9195b1dba8
Reviewed-on: http://review.typo3.org/16442
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Helmut Hummel [Thu, 8 Nov 2012 21:57:03 +0000 (22:57 +0100)]
[TASK] Add "Abstract" prefix to abstract task class
All abstract classes should be start with an Abstract
prefix in the class name.
Adjust the abstract task class to this naming convention.
Resolves: #42803
Releases: 6.0
Change-Id: If0b62d4ff61d9aa7ce44f61a15457faeabeab2d7
Reviewed-on: http://review.typo3.org/16331
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Anja Leichsenring [Tue, 6 Nov 2012 20:01:21 +0000 (21:01 +0100)]
[TASK] Adjust phpdoc for classes (files) of backports
Since it's neither "FLOW3" nor "v5" anymore those
headers need to be adjusted.
Before:
This class is a backport of the corresponding class of FLOW3.
All credits go to the v5 team.
Changed into:
This class is a backport of the corresponding class of TYPO3 Flow.
All credits go to the TYPO3 Flow team.
Change-Id: If5aaae848334c39a873b41ffc614942cedbbf4f8
Resolves: #42713
Releases: 6.0
Reviewed-on: http://review.typo3.org/16242
Reviewed-by: Stefan Neufeind
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Helmut Hummel [Wed, 7 Nov 2012 17:25:30 +0000 (18:25 +0100)]
[BUBFIX] Fix fatal error in Test
Fixture class names have been used twice.
Use uniqid to avoid clashes.
Releases: 6.0
Relates: #42028
Change-Id: Iccf188969d988d259d7d5f5a4fa3bd194c1826c0
Reviewed-on: http://review.typo3.org/16259
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Helmut Hummel [Wed, 17 Oct 2012 19:50:46 +0000 (21:50 +0200)]
[BUGFIX] Fix several namespace related bugs
Due to the switch to namespaces several things are buggy or missing.
* DataMapper and property mapper should recognize old Extbase class names
* Adapt checks for class names in several places
Resolves: #42546
Releases: 6.0
Change-Id: I2044479ce76d4dd480cc8d93e5b0e1d52471fe87
Reviewed-on: http://review.typo3.org/16161
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Aske Ertmann [Mon, 15 Oct 2012 16:01:16 +0000 (18:01 +0200)]
[BUGFIX] Mapping of DomainObject with namespaces
This makes sure that when checking if the property meta data
type is a class name, it also checks if it's a namespaced class names.
Fixes: #40900
Change-Id: I36e20e0aada750bdebde183af65c73e69ab463d7
Releases: 6.0
Reviewed-on: http://review.typo3.org/15643
Reviewed-by: Aske Ertmann
Reviewed-by: Mattias Nilsson
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Alexander Schnitzler [Sat, 17 Mar 2012 12:40:57 +0000 (13:40 +0100)]
[BUGFIX] Dont respect pid for static & rootlevel tables
If TCA defines a table to be static or on root level
setRespectStoragePage should be set to false as pid
is either 0 or even not set at all.
Releases: 6.0
Fixes: #42519
Change-Id: Ia18f9258da68f228a13cf8d1ed7656e939ba52b8
Reviewed-on: http://review.typo3.org/16049
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Nico de Haen [Tue, 16 Oct 2012 19:44:37 +0000 (21:44 +0200)]
[BUGFIX] Namespaced domain models are not updated
The check to see if the session's reconstituted objects are
aggregate roots doesn't support namespaced domain models.
Fixes: #42028
Change-Id: If9ad7569087a073471522036f645a039a869e682
Reviewed-on: http://review.typo3.org/15747
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Stefan Neufeind [Sat, 13 Oct 2012 19:36:32 +0000 (21:36 +0200)]
[TASK] Adjust phpdoc to namespaces
phpdoc still contained references to
Tx_Extbase_...
Change-Id: I45271dfbd4fa6a6d03d719b670c8aa939bd2a07d
Releases: 6.0
Fixes: #42700
Reviewed-on: http://review.typo3.org/15581
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
Alexander Schnitzler [Tue, 30 Oct 2012 10:01:09 +0000 (11:01 +0100)]
[TASK] Resync TYPO3Flow- and Extbase-Persistence
Releases: 6.0
Fixes: #42505
Change-Id: I1d3160013b248afcf0451fbc49bdb68b6bf9c92e
Reviewed-on: http://review.typo3.org/16037
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Nicole Cordes [Mon, 5 Nov 2012 20:28:48 +0000 (21:28 +0100)]
[BUGFIX] Misspelling in Typo3DbBackend.php
There is a misspelling in
Classes/Persistence/Generic/Storage/Typo3DbBackend.php and its test.
Property pageRepositiory should be renamed to pageRepository.
Change-Id: I858c49509773f94483b5d92909e63625859bc9b5
Fixes: #42683
Releases: 6.0
Reviewed-on: http://review.typo3.org/16219
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Helmut Hummel [Sun, 4 Nov 2012 17:14:44 +0000 (18:14 +0100)]
[TASK] Cleanup Typo3DbBackend
The Typo3DbBackend does assumptions on language
and version overlays based on request variables
or global variables.
Instead it should just evaluate the query settings
and use them.
Additionally further decrease the dependencies to global
objects where possible.
Resolves: #42676
Releases: 6.0
Change-Id: I1731d2b04d1e3be5b40fff484c5b4bd1cd0efa8c
Reviewed-on: http://review.typo3.org/16192
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Aske Ertmann [Mon, 15 Oct 2012 15:46:14 +0000 (17:46 +0200)]
[BUGFIX] resolveValidatorObjectName support for namespaces
This fix makes sure that validators get resolved correctly for
namespaced extensions. This works for the following scenarios:
Fully qualified namespaced extension name, shorthand validator
names (namespaced & non-namespaaced) and built in validators.
This also changes the behavior for the built in validators,
so instead of resolving the deprecated class name it resolves
to the namespaced class name.
Fixes: #40955
Releases: 6.0
Change-Id: Iec6a1e613218cf1e5d032502231dfa3447d8fa96
Reviewed-on: http://review.typo3.org/15642
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Aske Ertmann [Tue, 9 Oct 2012 13:16:21 +0000 (15:16 +0200)]
[BUGFIX] Support plugins in namespaced extensions
The function registerPlugin doesn't handle namespaced extension keys
differently than normal extension keys, leading to being unable to
read the configuration set in the configurePlugin function.
In the configurePlugin the vendor name is stripped from the extension name,
but the same is not done in registerPlugin. This leads to it being
impossible to select the plugin in the backend when inserting/editing a
plugin content element.
Change-Id: Ic21dc68e83bf65171aba7eafa43530eb7b23884b
Fixes: #41785
Releases: 6.0
Reviewed-on: http://review.typo3.org/16052
Reviewed-by: Aske Ertmann
Tested-by: Aske Ertmann
Reviewed-by: Jan-Erik Revsbech
Tested-by: Jan-Erik Revsbech
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Helmut Hummel [Sun, 4 Nov 2012 18:51:38 +0000 (19:51 +0100)]
[BUGFIX] Rename File after renaming class
After renaming the class, the renaming of the
file was accidentally not committed.
Rename the file to make the tests green again.
Resolves: #42665
Releases: 6.0
Change-Id: I8033c9f89ef101321825e90420ca228a2577272f
Reviewed-on: http://review.typo3.org/16194
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Nicole Cordes [Fri, 19 Oct 2012 22:01:59 +0000 (00:01 +0200)]
[BUGFIX] Typo3DbBackend language handling crashes in BE
Within a past commit the language handling was completly rewritten to
support language uids other than 0. This was done for frontend only so we
have to add a backend handling as well.
The language uid is now taken from the L parameter (either POST or GET)
for backend modules. If anything was submitted a fallback to 0 is
integrated.
Change-Id: I683e4bb44fa86c2b40c6126d8360858a2319bebe
Fixes: #40796
Releases: 6.0
Reviewed-on: http://review.typo3.org/15826
Reviewed-by: Georg Ringer
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Helmut Hummel [Sun, 4 Nov 2012 09:47:26 +0000 (10:47 +0100)]
[TASK] Rename FlashMessages to FlashMessageContainer
Variable and method names already use this name, so
it makes sense to use this name as class name, also
to be in line with Flow.
Resolves: #42665
Releases: 6.0
Change-Id: I36743462dd6e6d42acc2e976e4aa3371d9d98d7a
Reviewed-on: http://review.typo3.org/16180
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Helmut Hummel [Sat, 3 Nov 2012 22:33:53 +0000 (23:33 +0100)]
[TASK] Remove deprecated methods and classes
Remove code that has been scheduled for removal
for Extbase 6.0 except the old property mapper
which needs to stay for at least one version.
Also reschedule the removal for the old property
mapper for Extbase 6.1
Resolves: #41926
Resolves: #41925
Releases: 6.0
Change-Id: I60d2663a7ec3a37a6ba256189b77349ccebc91f6
Reviewed-on: http://review.typo3.org/16177
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Helmut Hummel [Sat, 3 Nov 2012 18:46:14 +0000 (19:46 +0100)]
[TASK] Rename ExtensionManager class
The class ExtensionManager is actually a utility
to manage extensions. Rename it to better reflect
it's purpose.
Resolves: #42661
Releases: 6.0
Change-Id: I6d7082e3f4fce767afb8cabe027d54cf786c24b2
Reviewed-on: http://review.typo3.org/16171
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Aske Ertmann [Tue, 30 Oct 2012 15:04:12 +0000 (16:04 +0100)]
[TASK] Update doc block example code to to namespaces
Change-Id: I89eeb3aaa772e97ca09cd633edc5d2e404fd7603
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/16048
Reviewed-by: Aske Ertmann
Tested-by: Aske Ertmann
Reviewed-by: Wouter Wolters
Reviewed-by: Jan-Erik Revsbech
Tested-by: Jan-Erik Revsbech
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Christian Kuhn [Thu, 1 Nov 2012 23:33:25 +0000 (00:33 +0100)]
[BUGFIX] PHP 5.4 unit test warnings
PHP 5.4 throws warnings "Creating default object from empty value"
if $foo->bar is accessed and $foo is not an object. This is the
case in several unit tests, especially if $GLOBALS['TSFE'] is accessed.
The patch fixes those warnings by initializing the object in question
with an instance of stdClass.
Furtermore some dumplicate cleanups of global backup handling is
removed that is already done in the parent classes.
Change-Id: I4c060632783926d76ff96b2eadf3c2ae89f6ae4e
Fixes: #42610
Releases: 6.0
Reviewed-on: http://review.typo3.org/16116
Reviewed-by: Helmut Hummel
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Alexander Schnitzler [Wed, 31 Oct 2012 11:11:06 +0000 (12:11 +0100)]
[TASK] Change objectStorage patch in migration script
Releases: 6.0
Fixes: #42549
Change-Id: I24ce34f2314bf0648830822242fef2d38fe9c3f0
Reviewed-on: http://review.typo3.org/16072
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler