Packages/TYPO3.CMS.git
7 years ago[TASK] Cleanup EM Code
Helmut Hummel [Fri, 19 Oct 2012 16:32:00 +0000 (18:32 +0200)]
[TASK] Cleanup EM Code

* Use controller arguments for actions
* Simplify contollers

Releases: 6.0
Resolves: #42163

Change-Id: I211d58e0dbbed083bb7a643a89da764bb4a186a3
Reviewed-on: http://review.typo3.org/15823
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[BUGFIX] Hide unsafe extensions in EM TER list
Jigal van Hemert [Fri, 19 Oct 2012 20:44:32 +0000 (22:44 +0200)]
[BUGFIX] Hide unsafe extensions in EM TER list

When showing extensions from TER unsafe extensions must not be shown
in the list or search results.

Change-Id: I229e3fc2b00a25c4e1cbcdc1ec2ac1596692630a
Fixes: #42153
Releases: 6.0
Reviewed-on: http://review.typo3.org/15824
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[TASK] Cleanup EM Code
Helmut Hummel [Thu, 18 Oct 2012 16:01:44 +0000 (18:01 +0200)]
[TASK] Cleanup EM Code

* Use controller arguments for actions
* Add escaping in viewhelpers
* Remove compatibility files
* Fix some annotations
* Enable test after ConfigurationManager change
* Fix new property mapper configuration

Releases: 6.0
Resolves: #42163

Change-Id: Ida9010e2eb00013c3a3e855983b58bb7df38c30d
Reviewed-on: http://review.typo3.org/15803
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[TASK] Clean-up EXT: aboutmodules, adapt to "TYPO3 CMS"
Felix Kopp [Sun, 14 Oct 2012 14:31:37 +0000 (16:31 +0200)]
[TASK] Clean-up EXT: aboutmodules, adapt to "TYPO3 CMS"

Cleans up the About Modules CSS file (mainly paddings) and terminology
to distinct between "TYPO3" (Association) and "TYPO3 CMS" product
within copyright notices.

Standardize CSS ids to use the extension key (aboutmodules).
Also adds links to the module descriptions to jump to module.
Brings one further logo image to comply with new brand definition.

Only applies to the extbase version of AboutModules.

Resolves: #41980
Releases: 6.0, 4.7
Change-Id: Iba088c5d644dfc048ea9c65e72711d501b51ae59
Reviewed-on: http://review.typo3.org/15610
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Follow-Up to #41828 - Incomplete mocking in tests
Christian Kuhn [Fri, 19 Oct 2012 12:09:56 +0000 (14:09 +0200)]
[BUGFIX] Follow-Up to #41828 - Incomplete mocking in tests

Better mocking in test class to ensure isUsageEnabled() returns TRUE
in all environments and especially in travis.

Change-Id: Icb68b1c863c13db0fb1e48390db130f43b9e0622
Related: #41828
Releases: 6.0
Reviewed-on: http://review.typo3.org/15815
Reviewed-by: Steffen Ritter
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Follow-Up to #41828 - Move test files
Christian Kuhn [Fri, 19 Oct 2012 10:41:09 +0000 (12:41 +0200)]
[BUGFIX] Follow-Up to #41828 - Move test files

Test files for #41828 should be in Tests/ instead of tests/

Change-Id: I26188b0addae691a2d5c4c8289885303db556d82
Related: #41828
Releases: 6.0
Reviewed-on: http://review.typo3.org/15810
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Download as zip must use same filename structure as TER
Jigal van Hemert [Thu, 18 Oct 2012 21:11:18 +0000 (23:11 +0200)]
[BUGFIX] Download as zip must use same filename structure as TER

Upload in EM assumes <extkey>_<version>.zip, so the download as zip
feature must use the same format.

Change-Id: Ide7eb7aac3c8f213b7db2bc9dad5e014e8faa666
Fixes: #42067
Release: 6.0
Reviewed-on: http://review.typo3.org/15801
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[BUGFIX] RTE: Link to disabled page doesn't show in FE, link icon does
Stanislas Rolland [Tue, 16 Oct 2012 14:45:24 +0000 (10:45 -0400)]
[BUGFIX] RTE: Link to disabled page doesn't show in FE, link icon does

Problem: When linking from a piece of content in the RTE to a disabled
page in the tree, the link isn't shown in the final frontend rendering.
However, the small arrow icon that you can have in front of the link to
denote its type, does get shown.
Solution: Remove the icon if no link is generated

Change-Id: If2f5af7ef81578571ed0a1255a53d9373f14bfed
Resolves: #36087
Releases: 4.5, 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/15802
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] Respect newlines in method declarations
Helmut Hummel [Thu, 18 Oct 2012 13:28:53 +0000 (15:28 +0200)]
[BUGFIX] Respect newlines in method declarations

The compatibility class loader currently fails
to match method declarations that go over multiple
lines.

Add the /s modifier to the pattern and adjust the testcases.

Releases: 6.0
Resolves: #42134

Change-Id: I2671944a80608b9ac585f6b5c586ceb571b82ecb
Reviewed-on: http://review.typo3.org/15800
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[BUGFIX] RTE: Words containing umlauts not added to personal dictionary
Stanislas Rolland [Thu, 18 Oct 2012 15:05:13 +0000 (11:05 -0400)]
[BUGFIX] RTE: Words containing umlauts not added to personal dictionary

Problem: The spell checker must analyze the dictionary file and may
have to update the charset of the personal dictionary. In doing so,
it is looking for the wrong file when the dictionary in use is a
regional/variety dictionary.

Change-Id: Ia2b57c0ead7c90a6d40e9db4d396e6c7ded72e5c
Resolves: #29685
Releases: 4.5, 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/15790
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[TASK] Make Core\Configuration\ConfigurationManager non static
Helmut Hummel [Wed, 3 Oct 2012 18:47:56 +0000 (20:47 +0200)]
[TASK] Make Core\Configuration\ConfigurationManager non static

To have the possibility to remove dependencies from code that
calls the configuration manager, it has to be made non static.

Together with this change, all further configuration file logic
is moved to that class, to not expose internals in other
places. For that some methods needed to be made public, but
have been marked private, thus are not public API.

Further cleanup and simplification, especially not calling
makeInstance several times, will go in a separate change.

Resolves: #41052
Releases: 6.0

Change-Id: I8ddfa4a957d0b4955ed422a1deeebaf84340c2c1
Reviewed-on: http://review.typo3.org/15267
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Remove EXT:cli from REQUIRED_EXTENSIONS
Christian Kuhn [Thu, 18 Oct 2012 14:30:24 +0000 (16:30 +0200)]
[BUGFIX] Remove EXT:cli from REQUIRED_EXTENSIONS

EXT:cli was removed and merged with core but the extension key is still in
the list of REQUIRED_EXTENSIONS.

Change-Id: I272338b2676f8d84d586586c36c151c9339ed1a7
Resolves: #42138
Related: #40949
Releases: 6.0
Reviewed-on: http://review.typo3.org/15788
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Extension Import not working with postgresql and DBAL
Helmut Hummel [Wed, 17 Oct 2012 22:14:42 +0000 (00:14 +0200)]
[BUGFIX] Extension Import not working with postgresql and DBAL

Do additional code style cleanups on the go.

Change-Id: I6d8732b7b4c979a96b4847a85e3aea52db01fbd3
Fixes: #38406
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/12898
Reviewed-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[BUGFIX] Compare feature is broken
Thomas Löffler [Sun, 7 Oct 2012 09:15:08 +0000 (11:15 +0200)]
[BUGFIX] Compare feature is broken

Adding users to Compare list does not work.

Change-Id: I079f0c8cf47213854c1ef358631b6a7c9ecc9260
Resolves: #41233
Releases: 6.0
Reviewed-on: http://review.typo3.org/15377
Reviewed-by: Mattias Nilsson
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
7 years ago[BUGFIX] Only show download location as configured
Jigal van Hemert [Wed, 17 Oct 2012 21:13:51 +0000 (23:13 +0200)]
[BUGFIX] Only show download location as configured

Extension manager shows possible locations to install an Extension.
The options set in the Install Tool must be shown.

Change-Id: I6d51c1a71eb4ff83077cf3962fadbcefb5049637
Fixes: #42103
Releases: 6.0
Reviewed-on: http://review.typo3.org/15778
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[TASK] Use language labels in Extension Manager javascript
Jigal van Hemert [Wed, 17 Oct 2012 11:59:01 +0000 (13:59 +0200)]
[TASK] Use language labels in Extension Manager javascript

Replace text in Javascript by language labels. Fix jQuery behaviour
for update, upload and other icons. Replace some text links by icons.
After answering No to update confirmation the mask in the background
is removed.

Change-Id: Id934e4c270897d5810ff68e1f076a91d7ba182fb
Fixes: #42033
Releases: 6.0
Reviewed-on: http://review.typo3.org/15759
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[TASK] t3lib: Autoloader now named ClassLoader
Stefan Neufeind [Wed, 17 Oct 2012 19:58:02 +0000 (21:58 +0200)]
[TASK] t3lib: Autoloader now named ClassLoader

Adjust occurence in t3lib which is just
there for compatibility (deprecated).

Change-Id: Ieca152e5a4f21fac4e5473747a205eead278f88e
Resolves: #42102
Releases: 6.0
Reviewed-on: http://review.typo3.org/15769
Reviewed-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[BUGFIX] Set class alias also for new class names
Helmut Hummel [Tue, 16 Oct 2012 20:29:11 +0000 (22:29 +0200)]
[BUGFIX] Set class alias also for new class names

As not all usage of class names trigger the autoloader,
usage of old class names in type hints for example doesn't.

If an object with a namespaced class name is given to
a method with an old class name, PHP dies with a fatal error.

To ensure full compatibility we need to set the
class alias also when a namespaced class is required
in the autoloader.

Resolves: #42058
Releases: 6.0

Change-Id: Ia4babeeae07fb778732c5846c5cf8c70115037f0
Reviewed-on: http://review.typo3.org/15748
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[TASK] Streamline EXT: em spacing & add Headline
Felix Kopp [Mon, 15 Oct 2012 21:32:16 +0000 (23:32 +0200)]
[TASK] Streamline EXT: em spacing & add Headline

Adds a standardized headline to the ExtensionManager backend
end module.

Also streamlines the outer spacing to comply with the other
core backend modules and #typo3-inner-docbody.

Change-Id: Ie5a8decf30f4fd19a2a692ee1f7e8d1c34d3ddf5
Resolves: #39921
Releases: 6.0
Reviewed-on: http://review.typo3.org/15661
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[BUGFIX] Faulty localization if IRRE is used on pages
Oliver Hader [Fri, 12 Oct 2012 13:18:04 +0000 (15:18 +0200)]
[BUGFIX] Faulty localization if IRRE is used on pages

Due to the fact that the pages table has it's own translation
table, pages_language_overlay, localization of IRRE records is
not possible there.
The fix is to use the TCA setting transOrigPointerTable
(= pages_language_overlay) instead of the original parent table
(= pages).

Change-Id: I088fe01033f9cf9c35a0e979215bb378be4a3dba
Fixes: #41924
Releases: 4.5, 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/15523
Reviewed-by: Steffen Ritter
Reviewed-by: Georg Ringer
Tested-by: Steffen Ritter
Reviewed-by: Andreas Wolf
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[TASK] Fix some issues in new logos
Steffen Ritter [Tue, 9 Oct 2012 13:41:35 +0000 (15:41 +0200)]
[TASK] Fix some issues in new logos

Follow up to which uses the vector graphics as base
instead of manually modified and cropped ones.

Change-Id: I73922312fa0512c635ce60b1b70662c25d3028ed
Fixes: #41704
Releases: 4.5,4.6,4.7,6.0
Reviewed-on: http://review.typo3.org/15443
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[BUGFIX] Find abstract functions in compatibility loader
Helmut Hummel [Tue, 16 Oct 2012 16:56:15 +0000 (18:56 +0200)]
[BUGFIX] Find abstract functions in compatibility loader

The compatibility class loader rewrites typehints of classes
but fails to find abstract class declarations which end with
an ; and not with a {

Adjust the regular expression to reflect that need.

Resolves: #42057
Releases: 6.0

Change-Id: I793bdaaf5c119c6dc525c9a2812a909404aa400e
Reviewed-on: http://review.typo3.org/15744
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[TASK] Raise submodule pointer
TYPO3 Release Team [Tue, 16 Oct 2012 13:21:26 +0000 (15:21 +0200)]
[TASK] Raise submodule pointer

Change-Id: I24d4648716825debef6f0ed275b1f0226cff47c6
Reviewed-on: http://review.typo3.org/15729
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
7 years ago[!!!][BUGFIX] Localization fallback does not work in Backend
Xavier Perseguers [Mon, 15 Oct 2012 11:35:42 +0000 (13:35 +0200)]
[!!!][BUGFIX] Localization fallback does not work in Backend

The ll-XML parser internally falls-back to English when looking for a
non-existing language translation. This prevents the localization
fallback mechanism to detect that the translation did not exist or was
only partially available and thus take the language dependency into
account to return a proper label.

Change-Id: I4095d20ec8fc08105dfff108c7e3865f468ddb91
Fixes: #41996
Releases: 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/15634
Reviewed-by: Dominique Feyer
Tested-by: Dominique Feyer
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] Labels should not be removed
Xavier Perseguers [Tue, 16 Oct 2012 09:38:37 +0000 (11:38 +0200)]
[BUGFIX] Labels should not be removed

We are not authorized to remove old labels.

Change-Id: Ia1f3db095fa3650a3d791c2bb011b29ab9bf7527
Relates: #41823
Releases: 6.0
Reviewed-on: http://review.typo3.org/15697
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] Prevent saltedpasswords destroying the password
Xavier Perseguers [Wed, 10 Oct 2012 10:48:19 +0000 (12:48 +0200)]
[BUGFIX] Prevent saltedpasswords destroying the password

When a record is using a plain MD5 password, EXT:saltedpasswords will
destroy the password after the second successive edit.

Add check for already temporarily hashed passwords to prevent that.

Change-Id: I487cbb335616c1d378a704845d5cc96e4ad6cb62
Fixes: #41828
Releases: 4.5, 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/15478
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] RTE: Opera extension Hyper Translate inserts markup
Stanislas Rolland [Mon, 15 Oct 2012 23:24:15 +0000 (19:24 -0400)]
[BUGFIX] RTE: Opera extension Hyper Translate inserts markup

Problem: When the RTE is loaded in Opera with browser extension
Hyper Translate installed, unwanted hidden markup is inserted at the
end of the edited text.
Solution: Un-install the faulty browser extension.
Document the issue in the RTE manual.

Change-Id: I0e0b74754b1d5449057666b228f0a63a34052d77
Resolves: #36794
Releases: 6.0
Reviewed-on: http://review.typo3.org/15669
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] RTE: Localization to content language does not work
Stanislas Rolland [Mon, 15 Oct 2012 18:21:45 +0000 (14:21 -0400)]
[BUGFIX] RTE: Localization to content language does not work

Solution: Create content language service

Change-Id: I8a628a9c195c8634d8a13d193e9d161ee785960b
Resolves: #39271
Releases: 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/15650
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[TASK] Extension Manager: Add icons and language labels
Jigal van Hemert [Thu, 11 Oct 2012 07:15:29 +0000 (09:15 +0200)]
[TASK] Extension Manager: Add icons and language labels

Add icons and language labels for Extension manager, titles on links.
Move text from templates to language labels.

Change-Id: If68c6481ee9bdca58b92cbb45ecba4d181b1b1b4
Resolves: #41812
Releases: 6.0
Reviewed-on: http://review.typo3.org/15499
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[BUGFIX] RTE: paste as plain text does not work in IE9
Stanislas Rolland [Wed, 10 Oct 2012 16:28:27 +0000 (12:28 -0400)]
[BUGFIX] RTE: paste as plain text does not work in IE9

Problem: IE9 may be configured to enable clipboard access, but most
users will not know how.
Solution: Use pasting pad.

Change-Id: I2f0a03547c91c51e022d6bdd4ed8c91474a08805
Resolves: #39389
Releases: 4.7, 6.0
Reviewed-on: http://review.typo3.org/15639
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] Use UTF-8 by default in Flexforms and Backend
Benjamin Mack [Tue, 9 Oct 2012 14:36:10 +0000 (16:36 +0200)]
[BUGFIX] Use UTF-8 by default in Flexforms and Backend

For FlexForm tools (used internally) and for backend
use, the encoding is always utf-8, so some checks
can be removed and functions can be deprecated.

Change-Id: I2a83b155d164ce5c4076b06bfbc219d7dd09fc38
Releases: 6.0
Resolves: #41793
Reviewed-on: http://review.typo3.org/15446
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
7 years ago[TASK] Consolidate copyright notice invocations
Felix Kopp [Sun, 14 Oct 2012 15:15:29 +0000 (17:15 +0200)]
[TASK] Consolidate copyright notice invocations

Marks the makeCopyrightNotice in LoginController as deprecated
since the exact functionally is already defined within BackendUtility.

Change-Id: I808583627030dc1fc01f2962fcefd0b94c42712f
Releases: 6.0
Resolves: #41992
Reviewed-on: http://review.typo3.org/15612
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
7 years ago[TASK] Add information to INSTALL.txt about ThreadStackSize
Jigal van Hemert [Sun, 14 Oct 2012 19:26:17 +0000 (21:26 +0200)]
[TASK] Add information to INSTALL.txt about ThreadStackSize

With the large regular expressions in Fluid Apache on Windows might
run out of stack space. The default stack size on Windows is only
1MB compared to 8MB default on *nix.
Add extra information in INSTALL.txt to explain this.

Change-Id: I259f36d8793ee82f96f4cb01f20880daec322f27
Releases: 6.0
Fixes: #41998
Reviewed-on: http://review.typo3.org/15617
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[BUGFIX] Fix the additional icon check
Mattias Nilsson [Sat, 29 Sep 2012 08:13:26 +0000 (10:13 +0200)]
[BUGFIX] Fix the additional icon check

When looking for additional icons the class AbstractSpriteHandler
a missing check if array on configuration.
Makes the whole TYPO3 installation to crash.

Change-Id: I6c513781f4fead38f8a261cc625bb98020bc6acf
Resolves: #41463
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/15151
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[BUGFIX] Support 'input' type in ext_conf_template.txt
Jigal van Hemert [Sun, 7 Oct 2012 10:21:44 +0000 (12:21 +0200)]
[BUGFIX] Support 'input' type in ext_conf_template.txt

Some older extensions use the type 'input' instead of 'string' in
ext_conf_template.txt . Although it was never documented the TS parser
which was used by the extension manager in previous version did support
this by using the default text field for it.
To improve backwards compatibility the undocumented type is added to the
new EM.

Change-Id: Ibed468b1363f2178c6c22dc0210c816739c8800a
Fixes: #41281
Releases: 6.0
Reviewed-on: http://review.typo3.org/15379
Reviewed-by: Philipp Gampe
Reviewed-by: Mattias Nilsson
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
7 years ago[TASK] Disable Memcache tests for now
Helmut Hummel [Fri, 12 Oct 2012 11:29:40 +0000 (13:29 +0200)]
[TASK] Disable Memcache tests for now

Travis Ci changed the infrastructure, leading
to failures in our memcache tests.

Disable the tests until we figured out the exact problem

Change-Id: I641af27a2253b8abe478dd3b97635a222a713e6e
Reviewed-on: http://review.typo3.org/15521
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[BUGFIX] Add pid column to extension manager tables
Helmut Hummel [Fri, 12 Oct 2012 11:03:24 +0000 (13:03 +0200)]
[BUGFIX] Add pid column to extension manager tables

Extbase relies on the pid column to exist for all
persistent domain models.

Add this column and at the same time ignore it
in created queries.

Change-Id: I2b23f44685b7a6712663458b6a776ec7870cf802
Resolves: #41917
Releases: 6.0
Reviewed-on: http://review.typo3.org/15520
Reviewed-by: Oliver Hader
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[TASK] Fix travis.yml to start memcache daemon
Steffen Ritter [Fri, 12 Oct 2012 10:56:45 +0000 (12:56 +0200)]
[TASK] Fix travis.yml to start memcache daemon

Change-Id: Iba6de218fdc221fc996d69637711afbc68a22b28
Reviewed-on: http://review.typo3.org/15519
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[BUGFIX] LocalDriver can be instantiated without basePath
Andreas Wolf [Sat, 1 Sep 2012 14:50:41 +0000 (16:50 +0200)]
[BUGFIX] LocalDriver can be instantiated without basePath

The Local driver of FAL does not check if its configuration contains a
base path, leading to some hard-to-track errors when no path is given.

Resolves: #40505
Releases: 6.0
Change-Id: Id90a005f6cc9c167e3ab8df06a896cd078867e0a
Reviewed-on: http://review.typo3.org/14258
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[BUGFIX] Rename ExtdirectTreeDataProvide to ExtdirectTreeDataProvider
Anja Leichsenring [Wed, 10 Oct 2012 20:12:26 +0000 (22:12 +0200)]
[BUGFIX] Rename ExtdirectTreeDataProvide to ExtdirectTreeDataProvider

During the namespace change a class named ExtdirectTreeDataProvide
had been introduced into the backend system extension. The more
appropriate name whould be ExtdirectTreeDataProvider.

The patch adds the missing r to filename, classname and all references
in code and comments.

Fixes: #41866
Relates: #41052
Releases: 6.0

Change-Id: If048682a058ae899711361e731c4a83b02eee933
Reviewed-on: http://review.typo3.org/15503
Reviewed-by: Wouter Wolters
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
7 years ago[BUGFIX] Fix SQL error in Livesearch with empty TCA sortby setting
Loek Hilgersom [Tue, 11 Sep 2012 18:54:52 +0000 (20:54 +0200)]
[BUGFIX] Fix SQL error in Livesearch with empty TCA sortby setting

If a searchable TCA field has a sortby setting which contains an empty
string or NULL, then BE Livesearch creates a query with one or more
'ORDER BY' without value, generating an SQL error. This fixes that.

Change-Id: I63aabfe860cd37645d9ac2905ed020d572629a1b
Fixes: #40816
Releases: 6.0
Reviewed-on: http://review.typo3.org/14526
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[TASK] Merge ext:integrity with ext:lowlevel
Markus Klein [Sat, 22 Sep 2012 22:22:36 +0000 (00:22 +0200)]
[TASK] Merge ext:integrity with ext:lowlevel

System extension integrity was created with the namespace switch and
contains the cli classes from ext:lowlevel. It turns out that this
change was not so useful, so for now the cli classes are moved back
to ext:lowlevel.

Resolves: #40950
Releases: 6.0

Change-Id: I22020736e91d7d0079ecf47e9b7d30a758f98e4c
Reviewed-on: http://review.typo3.org/14954
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Split jQuery and DataTables into separate files
Kai Vogel [Wed, 10 Oct 2012 18:26:20 +0000 (20:26 +0200)]
[BUGFIX] Split jQuery and DataTables into separate files

This patch removes the combined jQuery file and adds two separate files
for the main jQuery library and the plugin DataTables.

Fixes: #40498
Releases: 6.0

Change-Id: I9b75597c7183e1a620a036420f2c3841f7a62ec5
Reviewed-on: http://review.typo3.org/15500
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] sort versions of ext in descending order
Jigal van Hemert [Thu, 4 Oct 2012 20:50:52 +0000 (22:50 +0200)]
[BUGFIX] sort versions of ext in descending order

Versions of the same extension are sorted in descending order in the
PHP code, but the initial jQuery sorting must match that order.

Change-Id: Ic508fdf36b43e6209c83ca61bcf18917ae5ec3f3
Fixes: #41518
Releases: 6.0
Reviewed-on: http://review.typo3.org/15336
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Fatal error when copying file or folder
Andreas Wolf [Wed, 3 Oct 2012 14:38:22 +0000 (16:38 +0200)]
[BUGFIX] Fatal error when copying file or folder

When copying a file or folder, a fatal error is thrown if anything went
wrong. This happens because the error message was written to the log,
but the ExtendedFileUtility class also tried to output a (wrong) success
message containing the (not existing) target object.

Change-Id: If825e241ad60b7a2a65bd0826133005a3ba91091
Resolves: #41292
Releases: 6.0
Reviewed-on: http://review.typo3.org/15258
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[BUGFIX] FollowUp Tests to #41768
Steffen Ritter [Wed, 10 Oct 2012 14:27:41 +0000 (16:27 +0200)]
[BUGFIX] FollowUp Tests to #41768

The UnitTest has not been completely adapted.
Fix the tests.

Change-Id: I00e14a4c9d94a8549eb889bb1def8050d4d8736e
Releases: 6.0
Fixes: #41768
Reviewed-on: http://review.typo3.org/15487
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[TASK] FAL: Hard-coded flexform on storage creation
Benjamin Mack [Tue, 9 Oct 2012 14:20:18 +0000 (16:20 +0200)]
[TASK] FAL: Hard-coded flexform on storage creation

The StorageRepository creates FlexForm not through
the API calls, but with a static string. The attached
patch changes this.

Change-Id: Iba4fb6bb534c58755b10d69ee31b8bee57c45f1f
Resolves: #41716
Releases: 6.0
Reviewed-on: http://review.typo3.org/15444
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[TASK] File: add getNameWithoutExtension() method
Andreas Wolf [Tue, 9 Oct 2012 08:16:04 +0000 (10:16 +0200)]
[TASK] File: add getNameWithoutExtension() method

There is currently no way to get the filename without its extension,
e.g. to create a new name for a file converted to another format. This
commits adds such a method, together with tests and a fix for names like
somefile.tar.gz.

Resolves: #41768
Releases: 6.0
Change-Id: Iad924d1be4100cf798e36f25a22a32b221b8aef7
Reviewed-on: http://review.typo3.org/15427
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[TASK] CleanUp AjaxIDs and registration in ConfigDefault
Steffen Ritter [Wed, 10 Oct 2012 10:05:22 +0000 (12:05 +0200)]
[TASK] CleanUp AjaxIDs and registration in ConfigDefault

The registration of AjaxIds referred to old file names and
some of the AjaxIds have been replaced by a namespaced
class name in JavaScript which resulted in a failing
FlashUploader.

Change-Id: Id6f4943adc2b520817660ae85a656b06985e1674
Releases: 6.0
Fixes: #41829
Reviewed-on: http://review.typo3.org/15477
Reviewed-by: Wouter Wolters
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[BUGFIX] StorageRepository should ignore not found driver class
Georg Ringer [Tue, 14 Aug 2012 04:35:07 +0000 (06:35 +0200)]
[BUGFIX] StorageRepository should ignore not found driver class

If a driver doesn't exist anymore, the storage repository shouldn't load
it.

Most drivers will be implemented by extensions but if this extension is
deactived, the StorageRepository still tries to load this driver which is
not possible anymore and this ends in an uncaught exception in BE.
Therefore it should be checked if an implementation is available.

Change-Id: Ib71bef82a53096746cff4bd9577d6adbeae90ac5
Fixes: #39789
Releases: 6.0
Reviewed-on: http://review.typo3.org/13643
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[BUGFIX] Element Browser uses non-namespaced code
Benjamin Mack [Wed, 10 Oct 2012 11:17:38 +0000 (13:17 +0200)]
[BUGFIX] Element Browser uses non-namespaced code

Followup to #36817, where an old patch was moved to
the new namespaced code, but without refactoring the
code itself (my fault). The change fixes this.

Change-Id: I9e25a86af68dace1f605d6dfd6bf917350939f31
Releases: 6.0
Resolves: #41834
Reviewed-on: http://review.typo3.org/15482
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[BUGFIX] FAL: Default storage is created multiple times
Benjamin Mack [Tue, 9 Oct 2012 15:06:45 +0000 (17:06 +0200)]
[BUGFIX] FAL: Default storage is created multiple times

The "auto-creation" of the first file storage should only be
triggered once. Currently this happens whenever there is no
record for a user (thus a loop).

By checking the DB table for any record, which is done once
before the actual DB query, the auto-creation is really done
just a single time - when sys_file_storage is empty.

Change-Id: I6cd84bb68af15caffa3185f0a8541dcb30eecdaf
Releases: 6.0
Resolves: #39785
Reviewed-on: http://review.typo3.org/15451
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
7 years ago[FEATURE] Add several testcases for validators
Andreas Lappe [Wed, 28 Mar 2012 17:04:39 +0000 (19:04 +0200)]
[FEATURE] Add several testcases for validators

This adds several testcases for the provided validators.

Change-Id: Ie7a056cadaf767dbc306a980561c15e70d9698d8
Resolves: #35333
Releases: 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/10067
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
7 years ago[BUGFIX] Element Browser uses FAL API in a wrong way
Andreas Wolf [Sat, 1 Sep 2012 12:49:10 +0000 (14:49 +0200)]
[BUGFIX] Element Browser uses FAL API in a wrong way

The Element Browser needs a way to filter for certain file extensions.
FAL requires using a filter class for the storage; the EB did not
reflect this change until now. This commit adds a custom filter using
the configured file extension list.

Resolves: #39235
Releases: 6.0
Change-Id: I8237052417baf28081ba55fb221a3695710f6cad
Reviewed-on: http://review.typo3.org/14255
Reviewed-by: Mario Rimann
Reviewed-by: Stefan Neufeind
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[TASK] Start memcached on travis-ci build
Helmut Hummel [Wed, 10 Oct 2012 11:02:29 +0000 (13:02 +0200)]
[TASK] Start memcached on travis-ci build

Travis CI does not start memcached by default any more.
Add the memcached service to the travis.yaml

Change-Id: I27f4de6e1c0685632516b18c30858d61b793656e
Reviewed-on: http://review.typo3.org/15479
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[BUGFIX] Hardcoded fileadmin directory in Import-Export
Thomas Löffler [Sun, 7 Oct 2012 10:17:44 +0000 (12:17 +0200)]
[BUGFIX] Hardcoded fileadmin directory in Import-Export

$fileAdminDir is hardcoded in t3lib\class.t3lib_softrefproc.php
and typo3\sysext\impexp\class.tx_impexp.php
$TYPO3_CONF_VARS['BE']['fileadminDir'] should be used instead

Change-Id: I9f381507a762352ce6a555134534481e4df61f92
Releases: 4.5, 4.6, 4.7, 6.0
Resolves: #41120
Reviewed-on: http://review.typo3.org/15378
Reviewed-by: Wouter Wolters
Reviewed-by: Philipp Gampe
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[BUGFIX] Enable translation of file references
Helmut Hummel [Tue, 4 Sep 2012 13:44:00 +0000 (15:44 +0200)]
[BUGFIX] Enable translation of file references

Currently the file references are missing a localisation
possibility.

This change only adds the respective fields and TCA configuration.
Other needed changes to get the right languages for
frontend rendering will follow.

Also add some minor cleanups on the go.

Fixes: #40608
Releases: 6.0

Change-Id: Ia4454c1652eb3718a138a162319e9c95db6dd012
Reviewed-on: http://review.typo3.org/14335
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[BUGFIX] ResourceStorage: Bad comparison for strings
Andreas Wolf [Mon, 8 Oct 2012 14:32:34 +0000 (16:32 +0200)]
[BUGFIX] ResourceStorage: Bad comparison for strings

Resolves: #41719
Releases: 6.0
Change-Id: Idf333f303da4d3f2a26549eaf3ea28a149dbb2ee
Reviewed-on: http://review.typo3.org/15400
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[BUGFIX] Missing ExtDirect classes in ClassAliasMap
Steffen Ritter [Wed, 10 Oct 2012 09:58:31 +0000 (11:58 +0200)]
[BUGFIX] Missing ExtDirect classes in ClassAliasMap

The ExtDirect classes have been missing in ClassAliasMap.

Change-Id: I13351790a78c41d0b9660be116da78522dcf7580
Releases: 6.0
Relateds: #40095
Reviewed-on: http://review.typo3.org/15476
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[TASK] Introduce "TYPO3 CMS" in EXT: about
Felix Kopp [Wed, 10 Oct 2012 08:14:04 +0000 (10:14 +0200)]
[TASK] Introduce "TYPO3 CMS" in EXT: about

Changed terminology to "TYPO3 CMS" where applicable in
backend module About.

Change-Id: Id1e9aba5eedaa9da218d3887a71854cf03bf09c1
Resolves: #41823
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/15473
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Ingo Renner
Tested-by: Ingo Renner
7 years ago[BUGFIX] Files get indexed twice
Steffen Ritter [Tue, 9 Oct 2012 13:07:31 +0000 (15:07 +0200)]
[BUGFIX] Files get indexed twice

Files used within CSS Styled Content get indexed within
storage null again, since they are accessed via path
instead of file uid.

Change-Id: Ie529c6f9e853f429212265aa779a39086b4a652c
Fixes: #40669
Releases: 6.0
Reviewed-on: http://review.typo3.org/15439
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Mario Rimann
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
7 years ago[BUGFIX] FAL storage repo uses hard-coded enableFields
Benjamin Mack [Tue, 9 Oct 2012 14:27:34 +0000 (16:27 +0200)]
[BUGFIX] FAL storage repo uses hard-coded enableFields

The storage repository has hardcoded SQL where clauses
for deleted and hidden.
Solution: Create a new function that returns the additional
where clause, based on the frontend / backend context.

Change-Id: I6258ee639d4cc8d97a9712596baeb86ea1e576b6
Resolves: #41715
Releases: 6.0
Reviewed-on: http://review.typo3.org/15445
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[FEATURE] Element browser: get default upload folder from $BE_USER
Benjamin Mack [Tue, 9 Oct 2012 19:15:53 +0000 (21:15 +0200)]
[FEATURE] Element browser: get default upload folder from $BE_USER

When no folder is selected, use $BE_USER->getDefaultUploadFolder().

Change-Id: Iee443ae852b64c9398e80c9450a59e17e285d4d6
Releases: 6.0
Resolves: #36817
Reviewed-on: http://review.typo3.org/10972
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[TASK] Rebuild extension translation list in lang module
Kai Vogel [Tue, 18 Sep 2012 00:10:10 +0000 (02:10 +0200)]
[TASK] Rebuild extension translation list in lang module

This patch replaces the old translation update list in language module
with a lightwight one. It also cleans up the way to resolve the
translations and optimizes the interaction to the language selection
list.

Change-Id: Ifd4d8ca8c849def0bc868473ea15bc5fccdf757b
Resolves: #40833
Related: #39963
Releases: 6.0
Reviewed-on: http://review.typo3.org/14683
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[BUGFIX] RTE is not loading in IE8, when used with feedit
Stefan Aebischer [Mon, 3 Sep 2012 12:50:30 +0000 (13:50 +0100)]
[BUGFIX] RTE is not loading in IE8, when used with feedit

Solution: Avoid calls to undefined console methods

Change-Id: I1c2b72113a6a0045996ca5a219cd0bd49f6a0ae8
Fixes: #40558
Releases: 6.0, 4.7, 4.6
Reviewed-on: http://review.typo3.org/14311
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[TASK] Frontend should not expose exception for missing files
Steffen Ritter [Tue, 9 Oct 2012 16:03:28 +0000 (18:03 +0200)]
[TASK] Frontend should not expose exception for missing files

The exceptions within FAL are not catched in frontend. The
webpage renders broken instead of gracefully dealing with that.

Change-Id: Idf23f059336f723ba27a10d25ff60fcc49f9648b
Fixes: #38829
Releases: 6.0
Reviewed-on: http://review.typo3.org/15453
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[BUG] Deleting a file is impossible after it was used
Benjamin Mack [Tue, 9 Oct 2012 12:32:27 +0000 (14:32 +0200)]
[BUG] Deleting a file is impossible after it was used

The sys_refindex db table has a deleted column which is set
however when deleting a file, extfilefunc mentions that the
file is still in use. The extfilefunc check now takes the deleted
column into account.

Change-Id: If56178766c761309b2f4d2e7988399209fcc2480
Releases: 6.0
Resolves: #41115
Reviewed-on: http://review.typo3.org/15436
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[BUGFIX] RTE: Uncaught error in Firefox in TYPO3 6.0
Stanislas Rolland [Tue, 9 Oct 2012 14:54:01 +0000 (10:54 -0400)]
[BUGFIX] RTE: Uncaught error in Firefox in TYPO3 6.0

This is a regression introduced by fix to issue #41411. In Firefox,
the selection object may not provide any usable range.

Change-Id: I8f6e83ca249fb30299fa5b41755596ed54368343
Resolves: #41796
Releases: 6.0
Reviewed-on: http://review.typo3.org/15450
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] Fix compressor flooding typo3temp
Ivan Kartolo [Sat, 1 Sep 2012 17:49:02 +0000 (19:49 +0200)]
[BUGFIX] Fix compressor flooding typo3temp

Check for the temporary external file and
compare the content of the file with the freshly fetched content.

Change-Id: Id5f9e3a48395e2cba349c4592d241f035f867c5c
Fixes: #40409
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/14269
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[BUGFIX] RTE does not load in Frontend in USER_INT plugins in TYPO3 6.0
Stanislas Rolland [Tue, 9 Oct 2012 05:10:39 +0000 (01:10 -0400)]
[BUGFIX] RTE does not load in Frontend in USER_INT plugins in TYPO3 6.0

Solution: Rendering of css and js added by USER_INT plugins was fixed
in core. Adapt the RTE accordingly.

Change-Id: I5d63904e787efa1f5132639c8d80a7d18c737e73
Resolves: #41440
Releases: 6.0
Reviewed-on: http://review.typo3.org/15413
Reviewed-by: Christian Buelter
Tested-by: Christian Buelter
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[TASK] ResourceStorage: Remove getFileInfoByIdentifier() method
Andreas Wolf [Sun, 2 Sep 2012 09:29:31 +0000 (11:29 +0200)]
[TASK] ResourceStorage: Remove getFileInfoByIdentifier() method

The method getFileInfoByIdentifier() has been marked as deprecated long
ago. Additionally, the getFileInfo() method currently uses incorrect
semantics - it expects an identifier, while it should use a file object
to be in line with all other public FAL API methods.

Change-Id: Id76c1a03dcbcead33a16c6410ad93c66dafaa5c6
Resolves: #40520
Releases: 6.0
Reviewed-on: http://review.typo3.org/14281
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Mario Rimann
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
7 years ago[BUGFIX] Root-level folders cannot be displayed
Andreas Wolf [Wed, 3 Oct 2012 15:40:08 +0000 (17:40 +0200)]
[BUGFIX] Root-level folders cannot be displayed

Due to a recent fix in the folder resolving mechanism, the root-level
folders of a storage were not displayed anymore in the file list module.

This commit re-enables displaying rootlevel folders, at the expense of
removing the hierarchy resolving (i.e., we now always choose the
root-level folder of a storage instead of the next higher level. This
concept was broken anyways, as folders do not need to be in a hierarchy.
Thus we cannot use such a simple resolving mechanism, but have to
implement that per driver instead.

There is currently no permission check in the file list controller, so
both the selected folder and the (fallback) root-level folder might be
displayed though the user has no permission to do so.

Change-Id: I71580031f0cc14b2cfac76b80b3641dd05a3e052
Resolves: #41569
Releases: 6.0
Reviewed-on: http://review.typo3.org/15321
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[TASK] Adjust Logos to new style-guide
Felix Kopp [Mon, 8 Oct 2012 09:48:55 +0000 (11:48 +0200)]
[TASK] Adjust Logos to new style-guide

TYPO3 is changing and so is the logo.
Secondary color green is dropped and replaced by orange.
Also the signet moves to the left.

Adjusts logos/images/icons/files in backend to new brand definition.

Fixes: #41704
Releases: 4.6, 4.7, 6.0
Change-Id: I34c80b085ef6b6efaffe2de4b67bb47c79b570ec
Reviewed-on: http://review.typo3.org/15392
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[BUGFIX] RTE internal link handling broken since FAL changes
Steffen Ritter [Thu, 6 Sep 2012 14:34:00 +0000 (16:34 +0200)]
[BUGFIX] RTE internal link handling broken since FAL changes

When enabling the RTE link browser to deal with FAL the
refactoring broke the detection of internal links.

Editing an internal link resulted always in editing an
external link including the current site URL.

Change-Id: I90ea32562bf87a7cb75e65b7f3175b6f74e7b021
Fixes: #40678
Releases: 6.0
Reviewed-on: http://review.typo3.org/14419
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
7 years ago[TASK] Move local driver configuration file to EXT:core
Andreas Wolf [Wed, 3 Oct 2012 14:58:02 +0000 (16:58 +0200)]
[TASK] Move local driver configuration file to EXT:core

The configuration file for FAL's local driver was still placed in
t3lib/. This commit moves it to the more appropriate directory
Configuration/Resource/Driver in EXT:core.

Resolves: #40235
Releases: 6.0
Change-Id: I2bcc7d39cfea2ec84733eba7770b26467465a291
Reviewed-on: http://review.typo3.org/15259
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[BUGFIX] htmlArea RTE: Cursor jumps to first letter with Chrome 22
Stanislas Rolland [Sat, 6 Oct 2012 20:38:53 +0000 (16:38 -0400)]
[BUGFIX] htmlArea RTE: Cursor jumps to first letter with Chrome 22

Problem: Selection gets broken when intrusive bookmarks are inserted by
the undo/redo mechanism in Google Chrome 22.
Solution: Use non-intrusive bookmarks for undo/redo operations.

Change-Id: I92b817b58de6c0124ab9ce46cd73e7d33c77de54
Resolves: #41411
Releases: 6.0
Reviewed-on: http://review.typo3.org/15374
Tested-by: Philipp Gampe
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[TASK] Add missing csh description for file storage
Georg Ringer [Mon, 8 Oct 2012 06:37:10 +0000 (08:37 +0200)]
[TASK] Add missing csh description for file storage

The csh was missing for the field "processingfolder"
for file storage records.

Change-Id: I216a8cbc2ac02bc0db71f24bcf24cad6c38b047d
Releases: 6.0
Resolves: #41663
Reviewed-on: http://review.typo3.org/15387
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[TASK] Name of file storage should be required
Georg Ringer [Mon, 8 Oct 2012 06:41:52 +0000 (08:41 +0200)]
[TASK] Name of file storage should be required

The name of a file storage is currently not a required
field, this should be changed.

Change-Id: Ic10be69433e7012401a0122d2d4df08d8297219e
Resolves: #41664
Releases: 6.0
Reviewed-on: http://review.typo3.org/15388
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[BUGFIX] Clicking on empty storage does not show anything
Georg Ringer [Mon, 8 Oct 2012 07:08:33 +0000 (09:08 +0200)]
[BUGFIX] Clicking on empty storage does not show anything

Currently clicking on an empty storage (without any files)
in the filelist module, does not show anything.

Change-Id: I381a787b08bc4310ef9d10f84ded78a91baf0845
Fixes: #41667
Releases: 6.0
Reviewed-on: http://review.typo3.org/15390
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[BUGFIX] Fix wrong variable type part of the namespace migration
Fabien Udriot [Wed, 3 Oct 2012 12:52:55 +0000 (14:52 +0200)]
[BUGFIX] Fix wrong variable type part of the namespace migration

Resolves: #41574
Releases: 6.0
Change-Id: Ic1f0c2b379aa13fdcd9bc505137b592d9024b62a
Reviewed-on: http://review.typo3.org/15253
Reviewed-by: Wouter Wolters
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
7 years ago[TASK] Add docheader to module "about TYPO3"
Georg Ringer [Mon, 8 Oct 2012 10:06:03 +0000 (12:06 +0200)]
[TASK] Add docheader to module "about TYPO3"

The about module is missing the docheader, IMO the only
BE module where this is missing.

Change-Id: I155879e180fee8e213d192f506c4b662d8747f6d
Resolves: #41707
Releases: 6.0
Reviewed-on: http://review.typo3.org/15393
Reviewed-by: Felix Kopp
Tested-by: Felix Kopp
Reviewed-by: Mattias Nilsson
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[TASK] Show reference headline only if content is available
Georg Ringer [Mon, 8 Oct 2012 06:56:16 +0000 (08:56 +0200)]
[TASK] Show reference headline only if content is available

Currently the headline "References from this item" is
always shown in the info popup, no matter if there are
ones or not.

Therefore add an additional check and render the headline
only if needed.

Change-Id: I605d7ff35001f19fa6df2972b4ffde13cca60d7e
Resolves: #41665
Releases: 6.0
Reviewed-on: http://review.typo3.org/15389
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[BUGFIX] "stripOrderBy, stripGroupBy" should remove double occurrence
Laurent Cherpit [Sat, 6 Oct 2012 16:32:19 +0000 (18:32 +0200)]
[BUGFIX] "stripOrderBy, stripGroupBy" should remove double occurrence

Sometimes the string handed over to stripOrderBy includes the ORDER BY
twice.
Tweak the regular expression to detect and fix that kind of errors.

The same applies to stripGroupBy.

Fixes: #41641
Releases: 6.0, 4.7, 4.6, 4.5

Change-Id: Ifc6315ce31cf2037a77ea4b3f9a56bcb623a6b68
Reviewed-on: http://review.typo3.org/15371
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
7 years ago[BUGFIX] Duplicate ids in form view on record translation
Helmut Hummel [Sun, 7 Oct 2012 19:16:15 +0000 (21:16 +0200)]
[BUGFIX] Duplicate ids in form view on record translation

If a record shall be localized in the page module the accordant
form view gets loaded twice with the same id.

Fixes: #41659
Releases: 6.0
Change-Id: I396518433170e032b09d1d1026fc7fe6c3b0b85f
Reviewed-on: http://review.typo3.org/15383
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[TASK] Improve show_item for FAL files
Georg Ringer [Sun, 23 Sep 2012 12:57:16 +0000 (14:57 +0200)]
[TASK] Improve show_item for FAL files

The show_item.php shows some info about the selected file.
the property size is rendered twice, once in the
header section with a size (eg. 223kb) and below with
the size as byte. remote the last one.

A call to trim() can be removed as trimExplode() is used before

Change-Id: I33b0d9270bc6f81d490348c050c2b9e30c4a102c
Resolves: #41291
Releases: 6.0
Reviewed-on: http://review.typo3.org/14964
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
7 years ago[TASK] Simulatestatic should not be mentioned as sysext
Georg Ringer [Sun, 23 Sep 2012 11:34:08 +0000 (13:34 +0200)]
[TASK] Simulatestatic should not be mentioned as sysext

Currently the install tool stills suggests
simulatestatic as sysext to be installed.

Change-Id: I7f9bc95aa8c6cbbd5204d182a9b52a781fd466d8
Resolves: #41288
Releases: 6.0
Reviewed-on: http://review.typo3.org/14963
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[TASK] CGL violations "LineEndingsInvalidEOLChar"
Roland Waldner [Sun, 30 Sep 2012 12:49:38 +0000 (14:49 +0200)]
[TASK] CGL violations "LineEndingsInvalidEOLChar"

Resolves: #41474
Releases: 6.0
Change-Id: I55edcf54004f8ba1663a9d1d1fd8e4921a121d62
Reviewed-on: http://review.typo3.org/15172
Tested-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Reviewed-by: Philipp Gampe
Reviewed-by: Oliver Klee
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
7 years ago[TASK] CGL violation "CharacterAfterPHPClosingTag"
Roland Waldner [Sun, 30 Sep 2012 11:30:59 +0000 (13:30 +0200)]
[TASK] CGL violation "CharacterAfterPHPClosingTag"

Change-Id: I4335c2a6a4db1dae3a8863b781d713605933dee5
Resolves: #41471
Releases: 6.0
Reviewed-on: http://review.typo3.org/15166
Reviewed-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Reviewed-by: Oliver Klee
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
7 years ago[TASK] CGL violation "DoubleQuoteUsageNotRequired"
Roland Waldner [Sun, 30 Sep 2012 10:46:48 +0000 (12:46 +0200)]
[TASK] CGL violation "DoubleQuoteUsageNotRequired"

Resolves: #41470
Releases: 6.0
Change-Id: I0b58a49afb4e34fd03c9f89c25bb1d983fbc6dce
Reviewed-on: http://review.typo3.org/15164
Reviewed-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Tested-by: Philipp Gampe
Reviewed-by: Oliver Klee
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
7 years ago[BUGFIX] Make FAL Folder not found handling more user friendly
Steffen Ritter [Mon, 3 Sep 2012 09:06:40 +0000 (11:06 +0200)]
[BUGFIX] Make FAL Folder not found handling more user friendly

If an user moves the folder he currently views in the file
list module, after reload he sees only a red FlashMessage
error because the viewed folder is gone.

As the JavaScript cannot determine what might be the
identifier of the moved folder (after moving) it cannot
redirect there. Thus the file module needs to react more
user friendly in such a situation.

As a solution the module tries parent folders in, too.

Change-Id: Id9e8d988b159c3f0a21b41c4d1782101146ad23c
Fixes: #40547
Releases: 6.0
Reviewed-on: http://review.typo3.org/14301
Tested-by: Marcel Burkhalter
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
7 years ago[BUGFIX] Change submit button label to language file entry
Anja Leichsenring [Mon, 1 Oct 2012 19:55:46 +0000 (21:55 +0200)]
[BUGFIX] Change submit button label to language file entry

The submit button in configure extension form was hardcoded in
template file. This patch moves it to the language file and makes
use of the translate viewhelper.

Fixes: #41276
Releases: 6.0

Change-Id: I230e4eb350a4fe9eaa87ee4d225e6752c1c1df17
Reviewed-on: http://review.typo3.org/15224
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[TASK] Clean up class alias mechanism
Thomas Maroschik [Wed, 26 Sep 2012 14:25:43 +0000 (16:25 +0200)]
[TASK] Clean up class alias mechanism

* adopt class loader to load the class alias map from a location
  Migrations/Code/ClassAliasMap.php in every extensions path
* split up core class alias map into extension class alias maps
* adopt tests to the compound class loader cache

Change-Id: I7102fd5aab7a6364d5bcb5603f011dfcdb859ec9
Resolves: #41012
Resolves: #41013
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/15085
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[BUGFIX] Preview images not rendered in Web > Page view on Windows systems
Nicole Cordes [Fri, 21 Sep 2012 19:39:34 +0000 (21:39 +0200)]
[BUGFIX] Preview images not rendered in Web > Page view on Windows systems

In Web > Page view the preview images are not rendered on Windows systems.
This is due to failing functions in class
TYPO3\CMS\Core\Utility\PathUtility. Basically it's an issue with forward
and backward slashes. In the class the constance DIRECTORY_SEPARATOR is
used which is on Windows systems a backward slash. Normally paths in TYPO3
are converted to use forward slashes and here is the existing problem.

This patch removes the constance in some functions (which are nessessary
for preview images) and makes sure all pathes are converted to unix style.
Than processing can use forward shlashes and carry on.

Change-Id: If7b443e5180e26ceb089a5b47c1631c4c7eb21c1
Fixes: #41204
Releases: 6.0, 4.7
Reviewed-on: http://review.typo3.org/14873
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Simon Schaufelberger
Tested-by: Simon Schaufelberger
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[BUGFIX] Do not save expand state for root node in TCA tree
Christoph Gerold [Sun, 2 Sep 2012 10:46:06 +0000 (12:46 +0200)]
[BUGFIX] Do not save expand state for root node in TCA tree

To avoid a PHP warning: Missing argument for
BackendUserSettings::addToList() the expanded state must
not be saved for the tree root node which does not
have a uid property.

Change-Id: Id6d16525cd68e4ec13f36c8d95d2ecc0cc1bc794
Resolves: #31978
Releases: 4.5, 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/15168
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[BUGFIX] Consolidate usage of DocumentTemplate
Helmut Hummel [Sun, 30 Sep 2012 11:23:42 +0000 (13:23 +0200)]
[BUGFIX] Consolidate usage of DocumentTemplate

Do not use the global SOBE to get an instance
of DocumentTemplate. Instead make use of the
getter which is in the AbstractBackendViewHelper

Resolves: #41329
Releases: 6.0

Change-Id: Ic84e460670903869189955ca771f42066db8dda4
Reviewed-on: http://review.typo3.org/15165
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[BUGFIX] Make additional fields visible again in Scheduler
Jigal van Hemert [Sat, 29 Sep 2012 05:10:41 +0000 (07:10 +0200)]
[BUGFIX] Make additional fields visible again in Scheduler

Namespaced class names contain backslashes and are not suitable for
use in HTML attributes. Converting them to lowercase and replacing
the backslashes with dashes makes the additional fields for scheduler
tasks visible again when creating a new task.

Change-Id: I61a8fe9ce2ad798ff0823b9b7686238a29b670f6
Fixes: #41460
Releases: 6.0
Reviewed-on: http://review.typo3.org/15150
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[BUGFIX] Pagetree - Prevent a call to moveNode while creating nodes
Tobias Schultheiss [Thu, 16 Aug 2012 14:54:56 +0000 (16:54 +0200)]
[BUGFIX] Pagetree - Prevent a call to moveNode while creating nodes

Change-Id: I702ccb71dcf91063012eb77091f5982661ee3afd
Fixes: #39820
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/13808
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Galinski
Tested-by: Stefan Galinski
7 years ago[BUGFIX] Release scheduler from classname field
Thomas Maroschik [Thu, 30 Aug 2012 21:57:38 +0000 (23:57 +0200)]
[BUGFIX] Release scheduler from classname field

Currently the scheduler depends at many parts on its classname field in
the tx_scheduler_task table. This is not necessary as the classname is
already stored in the serialized task object. By releasing scheduler
tasks from their classname field backwards compatibility is maintained
by the class_alias mechanism.

Change-Id: I26f228add1f3db9f99ec3f5691488bd453ae2339
Fixes: #40215
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14236
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[TASK] Add leading backslashes to InvalidArgumentException
Anja Leichsenring [Tue, 25 Sep 2012 20:49:06 +0000 (22:49 +0200)]
[TASK] Add leading backslashes to InvalidArgumentException

for some cases the leading backslash is missing for PHP standard
classes. This patch adds those backslashes to InvalidArgumentException.

Change-Id: Ia7621ac7f4bcb3cadb8f89b375f7b75f35492135
Resolves: #41368
Releases: 6.0
Reviewed-on: http://review.typo3.org/15068
Reviewed-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[TASK] Raise submodule pointers
Helmut Hummel [Tue, 25 Sep 2012 21:41:13 +0000 (23:41 +0200)]
[TASK] Raise submodule pointers

Change-Id: Ic38a7287b97c79a6fabc96fe33bb047043e90cc3
Reviewed-on: http://review.typo3.org/15070
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel