Packages/TYPO3.CMS.git
8 years ago[BUGFIX] BE User module allows switching to CLI users
Andreas Wolf [Fri, 8 Jul 2011 22:59:31 +0000 (00:59 +0200)]
[BUGFIX] BE User module allows switching to CLI users

The backend user module shows two icons to switch to a given user (with
and without possibility to go back). This is also enabled for CLI users,
which can effectively render the session unusable.

This patch removes the icons if the username starts with _cli_

Change-Id: Ia8f027de8056a1d29cf240dc66588a23347475cd
Resolves: #28008
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/3163
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
8 years ago[BUGFIX] htmlArea RTE: TV CE editing not possible
stan [Sat, 9 Jul 2011 03:10:26 +0000 (23:10 -0400)]
[BUGFIX] htmlArea RTE: TV CE editing not possible

TV CE editing not possible as class.tx_staticinfotables_div.php is required by htmlArea RTE but apparently does not exist, despite the fact that extension Static Info Tables is loaded. No idea how to reproduce such an error.

Change-Id: I4caa2069a1debf3f6bb47d07390ea9ea616dd8b9
Fixes: #27819
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/3165
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[BUGFIX] Remove editing restriction for elements in workspace-stages
Tolleiv Nietsch [Wed, 22 Jun 2011 12:38:29 +0000 (14:38 +0200)]
[BUGFIX] Remove editing restriction for elements in workspace-stages

Fix bug where a (workspace) element which left the "editing" state can't be edited anymore if the editor doesn't have appropriate permission
for the current stage of the element. Now everyone can edit if they
are member within the workspace.

Change-Id: I32a93ebc182514df7fe594ff9d7983fb6cc58e0e
Resolves: #27643
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/2874
Reviewed-by: Michael Klapper
Tested-by: Michael Klapper
Reviewed-by: Stefan Neufeind
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
8 years ago[BUGFIX] Fix exception error when using caching framework and eID scripts
Michael Stucki [Wed, 6 Jul 2011 19:44:09 +0000 (21:44 +0200)]
[BUGFIX] Fix exception error when using caching framework and eID scripts

When using the caching framework and calling an eID script containing
locallang labels, it may happen that data from cache_hash is tried to be
accessed.

As there is no caching framework initialized at this time of execution,
an exception warning is issued:
A cache with identifier "cache_hash" does not exist.

Fix the error by checking if the caching framework is initialized,
otherwise skip its usage.

Change-Id: Iaeae13fe756b9b230f3eea919eaa3f045f2a6dcf
Branches: 4.5
Resolves: #25086
Reviewed-on: http://review.typo3.org/3068
Reviewed-by: Stefan Neufeind
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] tcaTree: make own record unselectable
Steffen Ritter [Wed, 2 Mar 2011 14:50:40 +0000 (15:50 +0100)]
[BUGFIX] tcaTree: make own record unselectable

Relations to an own record is not useful. You could exclude is via tca "andWhere"
This is not nice, because you wouldn't  see the whole tree.
Just make the own record unselectable.

Change-Id: I7c0cc969586c90ea3861754605d95b072eedad88
Resolves: #24324
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/976
Reviewed-by: Oliver Hader
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Stefan Neufeind
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
8 years ago[BUGFIX] Exclude E_DEPRECATED from exceptionalErrors
Helmut Hummel [Thu, 7 Jul 2011 08:26:40 +0000 (10:26 +0200)]
[BUGFIX] Exclude E_DEPRECATED from exceptionalErrors

To avoid exceptions in case an extension uses PHP functions
that have been deprecated in PHP 5.3, E_DEPRECATED messages have to
also be excluded from $TYPO3_CONF_VARS['SYS']['exceptionalErrors']

Change-Id: I3b5b4c8ec1738f9a3a9be146bb7e3a8a005087f3
Resolves: #27935
Reviewed-on: http://review.typo3.org/3117
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Stefan Neufeind
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Date of 1970-01-01 is shown in unset date fields
Benjamin Mack [Thu, 7 Jul 2011 09:34:43 +0000 (11:34 +0200)]
[BUGFIX] Date of 1970-01-01 is shown in unset date fields

The backend shows 1970-01-01 since TYPO3 4.3, even though this
value is empty. I know that there is a problem with mySQL that
cannot differentiate between "0" and NULL, and that this is a
more difficult problem. In any case, even though showing
1970-01-01 is "valid", this is just a bad thing in terms of
usability and user-friendly-ness.

Change-Id: I34d9cc48c809689a7fae7ad00139e4e151eb87c4
Resolves: #27936
Releases: 4.6, 4.5, 4.4, 4.3
Reviewed-on: http://review.typo3.org/3110
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[TASK] Raise submodule pointer
Oliver Hader [Thu, 7 Jul 2011 12:20:29 +0000 (14:20 +0200)]
[TASK] Raise submodule pointer

Change-Id: I6611011f085744ac92b9e5c3c9e1f351d49516ca
Reviewed-on: http://review.typo3.org/3102
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[BUGFIX] Wrong submodule pointer of fluid
Oliver Hader [Thu, 7 Jul 2011 08:02:35 +0000 (10:02 +0200)]
[BUGFIX] Wrong submodule pointer of fluid

The submodule pointer of fluid points to the current
master branch, but should be on fluid_1-3 instead.

Change-Id: I84ad7aad9323c4d67f3debc60af48432b9019fce
Reviewed-on: http://review.typo3.org/3085
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[TASK] Raise submodule pointer
TYPO3 v4 Release Team [Wed, 6 Jul 2011 15:12:14 +0000 (17:12 +0200)]
[TASK] Raise submodule pointer

Change-Id: I6973af9570f4dea6e33727226c85951b5bc953b1
Reviewed-on: http://review.typo3.org/3046
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
8 years ago[BUGFIX] Backend doctype 'xhtml_trans' is broken
Steffen Gebert [Wed, 29 Jun 2011 17:40:32 +0000 (19:40 +0200)]
[BUGFIX] Backend doctype 'xhtml_trans' is broken

Since introducing HTML5 as default backend doctype (#23639), two
mistakes make it impossible to use 'xhtml_trans' as doctype for the
Backend output.

Change-Id: I57944081881259970aa3a1666568c7d0ffe006bf
Resolves: #27774
Resolves: #27745
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/3040
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] Re-Introduce removed API method and mark it deprecated
Helmut Hummel [Sat, 2 Jul 2011 13:12:21 +0000 (15:12 +0200)]
[BUGFIX] Re-Introduce removed API method and mark it deprecated

After the refactoring of the form protection framework the API method
persitTokens() has been removed.

To not break existing extensions, re-introduce this method and
mark it as deprecated.

Change-Id: I2ef23724a3be8d3266d884506b066c587e332d9b
Fixes: #27809
Related: #25359
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/3017
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Dmitry Dulepov
Reviewed-by: Oliver Klee
Tested-by: Dmitry Dulepov
8 years ago[BUGFIX] Mirror selection is not respected
Xavier Perseguers [Sun, 3 Jul 2011 12:50:16 +0000 (14:50 +0200)]
[BUGFIX] Mirror selection is not respected

When a specific mirror is selected in Extension Manager,
the method used to return it fails.

Change-Id: Ica7309eed3ead0a76fc1adb993d2dc47c9437ba1
Resolves: #27755
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/3019
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] sys_action: Fix Record List page switching
Thomas Maroschik [Mon, 28 Mar 2011 12:04:17 +0000 (14:04 +0200)]
[BUGFIX] sys_action: Fix Record List page switching

If a list-records-task lists more than 100 records, the singe table page turning
functionality is shown on top of the table. If you want to switch the page (or
enter a page number) nothing happens or you get elsewhere than you are supposed
to be.

This happens due to wrong link generation. The Listmodule has been refactored, but the
sys_actions Module stayed the same. Link generation was broken.

This patch fixes the issues with sys_actions and list link generation by subclassing
the localRecordList class and adopting the link generation to sys_actions needs.

Change-Id: I6305901f0ede0efd0cf7305cbea1733bebce6a74
Resolves: #23567
Reviewed-on: http://review.typo3.org/1291
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX][INSTALL] Selecting existing database should check radio button
Steffen Gebert [Thu, 2 Jun 2011 13:52:50 +0000 (15:52 +0200)]
[BUGFIX][INSTALL] Selecting existing database should check radio button

Due to a JavaScript error the corresponding radio button in Step 2 of
the 1-2-3 wizard is not automatically checked, when the dropdown menu
to select an existing database changes.

Change-Id: Idc7c65a268bd7dd67004a88a4c49457f11c022de
Resolves: #11765
Reviewed-on: http://review.typo3.org/2506
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
8 years ago[BUGFIX] Flexform sheet description should be editable via TSConfig
Kai Vogel [Wed, 11 May 2011 18:56:49 +0000 (20:56 +0200)]
[BUGFIX] Flexform sheet description should be editable via TSConfig

Flexform sheet description, short description and language meta settings are now editable via TSConfig.

Change-Id: Ie50f84c49d8bd02290193b87da13d8e762836ac2
Resolves: #26771
Reviewed-on: http://review.typo3.org/2279
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] Missing parentheses in code break two stdWraps
Markus Klein [Tue, 21 Jun 2011 14:24:51 +0000 (16:24 +0200)]
[BUGFIX] Missing parentheses in code break two stdWraps

Missing parentheses around isset() checks in string concatenation break
functionality.

Change-Id: I57fb20a425ce39990f56cee792857feae6700524
Resolves: #27409
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/2863
Reviewed-by: Stefan Neufeind
Reviewed-by: Christopher
Tested-by: Christopher
Reviewed-by: Mario Rimann
Reviewed-by: Tolleiv Nietsch
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] Installer - Wrong value for CGI
Markus Klein [Tue, 21 Jun 2011 13:52:40 +0000 (15:52 +0200)]
[BUGFIX] Installer - Wrong value for CGI

In "Basic Configuration"->"System Information" the wrong value for
"UNIX/CGI" is displayed, when using fcgid.
The reason is that class.tx_install.php uses an old condition
for determining this.

Thanks to Stephan Grossberndt for discovering this.

Change-Id: Ic4a0494e0698b58b8abc0ff361df4a904c9dabcd
Resolves: #26913
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/2324
Reviewed-by: Stephan Grossberndt
Tested-by: Stephan Grossberndt
Reviewed-by: Stefan Neufeind
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
8 years ago[BUGFIX] FE-Error "NO entry in the $TCA-array..."
Nicole Cordes [Fri, 17 Jun 2011 09:33:56 +0000 (11:33 +0200)]
[BUGFIX] FE-Error "NO entry in the $TCA-array..."

Fix a possible race condition during a FE call if a BE user
'clears all cache' at the same time.

Change-Id: Ieaf1953147d23ec1266372273442820d2aa42308
Resolves: #22928
Releases: 4.6, 4.5, 4.4, 4.3
Reviewed-on: http://review.typo3.org/2839
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] Incompatible call to debug_backtrace() prior to PHP 5.3.5
Oliver Hader [Mon, 20 Jun 2011 11:08:57 +0000 (13:08 +0200)]
[BUGFIX] Incompatible call to debug_backtrace() prior to PHP 5.3.5

The additional parameter to debug_backtrace() was introduced
with PHP 5.3.6. To stay compatible with PHP 5.3.0, it shall be
removed again - besides that the behaviour stays the same.

Change-Id: Iaca7308c7eaadc7f47bf4927cc25924aa0640835
Resolves: #27348
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/2837
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Show correct record title
Johannes Feustel [Sun, 5 Jun 2011 15:53:16 +0000 (17:53 +0200)]
[BUGFIX] Show correct record title

Show correct record title in backend module using t3lib_BEfunc::getRecordTitle()
in template.php and beuser module.

Change-Id: I1624c24698337bd505411b29e411a005a07eb006
Resolves: #27100
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/2529
Reviewed-by: Andreas Wolf
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Mario Rimann
Reviewed-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[FEATURE] add .gitignore for common file exclusions
Oliver Hader [Sat, 18 Jun 2011 14:30:54 +0000 (16:30 +0200)]
[FEATURE] add .gitignore for common file exclusions

porting what was in svn:ignore before
needs to be aplied to all branches separatly, once we agree

Resolves: #13627

Change-Id: Ie58e662f15003ffec5cfec45d430f2eedca781f4
Reviewed-on: http://review.typo3.org/2797
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[TASK] Raise submodule pointer
TYPO3 v4 Release Team [Tue, 14 Jun 2011 18:29:50 +0000 (20:29 +0200)]
[TASK] Raise submodule pointer

Change-Id: Ie71720efd4f1f7d33f6c023f132a61a0a8cfb918
Reviewed-on: http://review.typo3.org/2743
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
8 years ago[TASK] Integrate external projects Fluid and Extbase as Git submodules
Oliver Hader [Tue, 14 Jun 2011 18:04:30 +0000 (20:04 +0200)]
[TASK] Integrate external projects Fluid and Extbase as Git submodules

Change-Id: I43fd669a02faeaf75cc1dabd61516a4527c896d1
Resolves: #27446
Reviewed-on: http://review.typo3.org/2740
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[BUGFIX] Scheduler: Show running icon during execution
Andy Grunwald [Mon, 30 May 2011 16:30:47 +0000 (18:30 +0200)]
[BUGFIX] Scheduler: Show running icon during execution

When tasks are executed manually via the Scheduler BE module, their
status icons should be changed to "running".

Resolves: #25669
Releases: 4.5, 4.6

Change-Id: I1ed15666b64916f9e165c8784c569ec6319745a8
Reviewed-on: http://review.typo3.org/2738
Reviewed-by: Francois Suter
Tested-by: Francois Suter
8 years ago[BUGFIX] Handle IDN domain names correctly
Johannes Feustel [Sun, 5 Jun 2011 13:41:29 +0000 (15:41 +0200)]
[BUGFIX] Handle IDN domain names correctly

Backend fails if using an IDN (international domain name) like täst.org

Change-Id: Ieb9b3ec921416a85fe6e56826cf66b57c61ffcbc
Resolves: #20519
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/2666
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[TASK] Raise submodule pointer
TYPO3 v4 Release Team [Fri, 10 Jun 2011 19:37:51 +0000 (21:37 +0200)]
[TASK] Raise submodule pointer

Change-Id: I271123dc6c0aa402b45b65fc482e203c409afcb8
Reviewed-on: http://review.typo3.org/2637
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
8 years ago[TASK] Raise submodule pointer
TYPO3 v4 Release Team [Thu, 9 Jun 2011 14:36:38 +0000 (16:36 +0200)]
[TASK] Raise submodule pointer

Change-Id: Ia8f4733b47448bc046b78b5fba90acc3534f8604
Reviewed-on: http://review.typo3.org/2607
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
8 years ago[BUGFIX] Make backend layout dropdown in CE editform translateable
Stefano Kowalke [Sat, 5 Mar 2011 11:22:49 +0000 (12:22 +0100)]
[BUGFIX] Make backend layout dropdown in CE editform translateable

Change-Id: Ic732f5e152115c2405bc23e35a67c10fb5083a6f
Resolves: #M17873
Reviewed-on: http://review.typo3.org/1469
Reviewed-by: Stefan Neufeind
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
8 years ago[BUGFIX] content FORM: wrong layout for label
Markus Klein [Tue, 17 May 2011 20:11:30 +0000 (22:11 +0200)]
[BUGFIX] content FORM: wrong layout for label

Layout configuration of FORM fields with type LABEL is taken from type
CHECK when no stdWrap options are defined.
Thanks to Alexander Claes for this fix.

Change-Id: Ie53bbfff4995fc5e5b2ed4c3f2b554eb61ede0d3
Resolves: #26867
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/2190
Reviewed-by: Christopher
Tested-by: Christopher
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
8 years ago[BUGFIX] pageNotFound_handling error with relative paths
Markus Klein [Sat, 21 May 2011 15:00:40 +0000 (17:00 +0200)]
[BUGFIX] pageNotFound_handling error with relative paths

This patch fixes the handling of relative paths of pageNotFound_handling.
Due to a missing check, the relative path is prefixed with http_host only,
causing a wrong Location header.

Change-Id: Ibf19841a984aaef863cdb72392b09b631e4f39e5
Resolves: #25725
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/2281
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
8 years ago[BUGFIX] phpTimeZone not correctly set from localconf.php
Patrick Schriner [Mon, 23 May 2011 12:39:41 +0000 (14:39 +0200)]
[BUGFIX] phpTimeZone not correctly set from localconf.php

There's a bug in the PHP time zone implementation - set in
t3lib/config_default.php and overridden in localconf.php.

The timeZone variable used to set the default timezone takes the value
from TYPO3_CONF_VARS[phpTimeZone], which does not exist. It needs to be
corrected to TYPO3_CONF_VARS[SYS][phpTimeZone].

The effect is that the time zone for TYPO3 is always set to the server
time zone and is not set by the localconf.php / Install Tool value of
phpTimeZone.

This looks like it may have been an issue since phpTimeZone was added.

Thanks to Todd Hossack for the patch

Resolves: #26779
Releases: 4.6, 4.5
Change-Id: Ie443a7c1297156cb4c475fdcda38bafcbe20d716
Reviewed-on: http://review.typo3.org/2303
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
8 years ago[BUGFIX] TCEFORM language selector: wrong relations
Thorsten Kahler [Sun, 5 Jun 2011 18:46:37 +0000 (20:46 +0200)]
[BUGFIX] TCEFORM language selector: wrong relations

The language selector in the top of BE forms is intended to show (and
switch between) all translations of a certain record. All records in
non-default languages, that are not bound to a record in the default
language are shown as translations of each other.
The patch adds a distinction between translated records and records in
a non-default language to render the dropdowns labels and functions.
Additionally fixes PHPDoc and indentation of
SC_alt_doc::languageSwitch().

Change-Id: I6292578a2e4b3807cb333ff85a6d6309b7d4c754
Resolves: #24958
Reviewed-on: http://review.typo3.org/2533
Reviewed-by: Thorsten Kahler
Tested-by: Thorsten Kahler
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
8 years ago[BUGFIX] Detect Android systems properly
Francois Suter [Tue, 10 May 2011 15:38:04 +0000 (17:38 +0200)]
[BUGFIX] Detect Android systems properly

Android system is not properly detected by
t3lib_utility_Client::getBrowserInfo() because it currently detects
Android devices as variants of a Linux system. However some browsers
don't send "Linux" in the User-Agent, so Android does not get detected
at all. This patch moves Android detection outside of the Linux
detection block. It also comes before Linux detection, so that
Android devices don't get rolled up into Linux computers.

Change-Id: I5e724802f1d8e5bf3b8a824a4fef7755eca779db
Resolves: #26734
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1999
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] content FORM: wrong layout for label
Markus Klein [Tue, 17 May 2011 20:11:30 +0000 (22:11 +0200)]
[BUGFIX] content FORM: wrong layout for label

Layout configuration of FORM fields with type LABEL is taken from type
CHECK when no stdWrap options are defined.
Thanks to Alexander Claes for this fix.

Change-Id: Ie9d6328fde25736fea15c1a7acc4ed2a7b08dba2
Resolves: #26867
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/2525
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] sysext recycler: Typo in language label
Stefan Neufeind [Sat, 4 Jun 2011 20:09:03 +0000 (22:09 +0200)]
[BUGFIX] sysext recycler: Typo in language label

Replaced "Create" with "Created". Date refers to when the record was "created".

Change-Id: Ied335bce631b3940767f9013296e7a847395bbaa
Resolves: #5539
Releases: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/2524
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
8 years ago[BUGFIX] Fixed typo in TBE_browser_recordList
Mario Rimann [Fri, 3 Jun 2011 13:31:01 +0000 (15:31 +0200)]
[BUGFIX] Fixed typo in TBE_browser_recordList

Change-Id: Ic19587902c325e0fdaf0092189dfcc60ee101336
Resolves: #26360
Reviewed-on: http://review.typo3.org/2517
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[TASK] Overwork typo3/sysext/README.txt
Ernesto Baschny [Wed, 1 Jun 2011 18:58:47 +0000 (20:58 +0200)]
[TASK] Overwork typo3/sysext/README.txt

Change-Id: I2cb39cc8ce4b82cbfb3d35d59e78e75fab31712c
Resolves: #27173
Reviewed-on: http://review.typo3.org/2495
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] Do not suppress parse errors in ext_emconf.php files
Steffen Gebert [Thu, 2 Jun 2011 12:54:46 +0000 (14:54 +0200)]
[BUGFIX] Do not suppress parse errors in ext_emconf.php files

In case of parse errors in an ext_emconf.php file, the error message
has been suppressed because of an @include(). Nevertheless, the EM
stops working with a blank page (without any error log entry).

Removing the @ shows the warning so that it easier for the user to
identify the erroneous extension.

Change-Id: I5dd67f1b486850ea1766dc8949b9541352632089
Resolves: #17506
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/2504
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] Add stdWrap for excludeUidList for HMENU.
Roland Waldner [Fri, 29 Apr 2011 20:03:41 +0000 (22:03 +0200)]
[BUGFIX] Add stdWrap for excludeUidList for HMENU.

Change-Id: I9753dd743e95520277982e89b8b94b1ac028bc68
Resolves: #26483
Reviewed-on: http://review.typo3.org/2508
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
8 years ago[BUGFIX] Natural sort with t3lib_div::naturalKeySortRecursive()
Markus Klein [Thu, 12 May 2011 20:10:19 +0000 (22:10 +0200)]
[BUGFIX] Natural sort with t3lib_div::naturalKeySortRecursive()

This fix changes the used compare function for
t3lib_div::naturalKeySortRecursive() from strcasecmp to strnatcasecmp.
This ensures >natural< sorting especially in conjunction with
numbers in strings.

Change-Id: Ic378215707dfa0b20a198f82230afd56f1681934
Resolves: #26485
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/2109
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
8 years ago[BUGFIX] Fix typo "PHP sessions availiable" in Install Tool
Stephan Großberndt [Mon, 23 May 2011 08:58:54 +0000 (10:58 +0200)]
[BUGFIX] Fix typo "PHP sessions availiable" in Install Tool

Change-Id: I6a9f716c35cc635405270051d7aafc3614e2139f
Resolves: #26914
Releases: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/2492
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] Missing XCLASS statement for class LiveSearch
Steffen Gebert [Wed, 1 Jun 2011 17:18:17 +0000 (19:18 +0200)]
[BUGFIX] Missing XCLASS statement for class LiveSearch

Change-Id: I5760b16fca1c4b057c092bf6490fe9a9be349a7e
Resolves: #27152
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/2489
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] Scheduler: use img title-tags for mouse-over at status legend
Francois Suter [Tue, 31 May 2011 11:44:30 +0000 (13:44 +0200)]
[BUGFIX] Scheduler: use img title-tags for mouse-over at status legend

The 'Status Legend' in the Scheduler backend module does not use
<img title="" /> tags. Only <img alt=""> tags.
This patch writes the value from alt=""-Tag to title="" tag.

Thanks to Qitec for the original patch.

Change-Id: Ic75ac1107b4ebe327ffa034d0d0b5353f5c3aac8
Resolves: #25661
Releases: 4.5
Reviewed-on: http://review.typo3.org/2456
Reviewed-by: Francois Suter
Tested-by: Francois Suter
8 years ago[BUGFIX] compileWhereClause causes Extbase errors with DBAL
Patrick Schriner [Mon, 30 May 2011 06:54:00 +0000 (08:54 +0200)]
[BUGFIX] compileWhereClause causes Extbase errors with DBAL

t3lib_sqlparser::compileWhereClause iterates over the where subparts. It is called from
DBAL when running DBAL in native (MySQL) mode.

It does however resets its output string whenever the subpart is either FIND_IN_SET or
IFNULL. This causes the queries built by Extbase to fail.

Change-Id: I1c37232fa11a9c3018b07b150fb0478efdef6aa5
Fixes: #25488
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/2421
Reviewed-by: Georg Schönweger
Tested-by: Georg Schönweger
Reviewed-by: Patrick Schriner
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] Meta charset tag adjustment for html5 doctype
Susanne Moog [Sat, 21 May 2011 13:30:29 +0000 (15:30 +0200)]
[BUGFIX] Meta charset tag adjustment for html5 doctype

The meta charset tag is not fully compatible with html5.
Remove the namespace to avoid the validator warning.

Change-Id: Ic1ec479086d955bed407e2c87fdc6ca0d9bc32f6
Resolves: #24212
Reviewed-on: http://review.typo3.org/2318
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Christopher
Tested-by: Christopher
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[TASK] Set TYPO3 version to 4.5.4-dev
TYPO3 v4 Release Team [Tue, 24 May 2011 12:16:26 +0000 (14:16 +0200)]
[TASK] Set TYPO3 version to 4.5.4-dev

Change-Id: If016c620e311aada98f029b0a280f8e2e09c7dfb
Reviewed-on: http://review.typo3.org/2350
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
8 years ago[RELEASE] Release of TYPO3 4.5.3
TYPO3 v4 Release Team [Tue, 24 May 2011 12:16:19 +0000 (14:16 +0200)]
[RELEASE] Release of TYPO3 4.5.3

Change-Id: Id75d5c38cc36eea789422751a2dbea3a3620ebcd
Reviewed-on: http://review.typo3.org/2349
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
8 years agoRevert "[RELEASE] Release of TYPO3 4.5.3"
TYPO3 v4 Release Team [Tue, 24 May 2011 11:51:48 +0000 (13:51 +0200)]
Revert "[RELEASE] Release of TYPO3 4.5.3"

This reverts commit b9e84c82e9ce0a034f5759f679892d0037aebcac.

Change-Id: Idc83e51ec5bb34cc3ff0ac37a7a81e2e4710d29f
Reviewed-on: http://review.typo3.org/2344
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
8 years ago[RELEASE] Release of TYPO3 4.5.3
TYPO3 v4 Release Team [Tue, 24 May 2011 11:44:06 +0000 (13:44 +0200)]
[RELEASE] Release of TYPO3 4.5.3

Change-Id: I60e023242b94ea84d7415bd7356c3f39d9b2b836
Reviewed-on: http://review.typo3.org/2343
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
8 years agoRevert "[RELEASE] Release of TYPO3 4.5.3"
Oliver Hader [Tue, 24 May 2011 11:24:44 +0000 (13:24 +0200)]
Revert "[RELEASE] Release of TYPO3 4.5.3"

This reverts commit 15d4c0e6797d230084a852ef52d6c376cf5d9dd1.

Change-Id: Ia0340d48d2caa457fcfc8b96c386f2fb36aa4930
Reviewed-on: http://review.typo3.org/2342
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[RELEASE] Release of TYPO3 4.5.3
TYPO3 v4 Release Team [Tue, 24 May 2011 10:22:30 +0000 (12:22 +0200)]
[RELEASE] Release of TYPO3 4.5.3

Change-Id: I99461f499196aeb8dc30b0f14df7c5b60a751567
Reviewed-on: http://review.typo3.org/2333
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
8 years ago[TASK] Merge changes in linkvalidator subproject
Philipp Gampe [Sun, 22 May 2011 18:51:30 +0000 (20:51 +0200)]
[TASK] Merge changes in linkvalidator subproject

The following issues were fixed:
* Task: Fix whitespace issues in all branches
* Task: Update Version Number to 1.0.3
* Feature #13800: Add user-agent header
* Fixed Bug #13680: Refactor external link, do not follow senseless loop, add user agent (thanks to Daniel Minder)
* Fixed bug #13953: Third-party classes cannot be checked due to dynamicConfigFile in TCA (thanks to Jan Philipp Timme)
* Fixed bug #13757: Scheduler task does not work at all (Michael Miousse)
* Fixed bug #13828: checkhidden has no effect for some configurations (Michael Miousse)
* Fixed bug #26731: The info module does not show up in IE 7 and 8 (Michael Miousse)
* Fixed bug #13368: Content of Tab is not scrollable (Michael Miousse)

Change-Id: I1074d4df19943cd2f0be5e734729830fbf2fa949
Resolves: #26884
Releases: 4.5
Reviewed-on: http://review.typo3.org/2288
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Oliver Hader
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
8 years ago[Bugfix] getUrl creates malformed requests if no path is given
Philipp Gampe [Sat, 12 Mar 2011 16:26:37 +0000 (17:26 +0100)]
[Bugfix] getUrl creates malformed requests if no path is given

If you fetch an url like example.org without a '/' at the end,
you will get a 400 Bad request of only fetching headers (2).
If you get all content+headers (1) you will get a 404.
getUrl should be tolerant and add the slash if it is missing.

Change-Id: I49a7bd993e51da0cdd42b15f0bf77150bed4d556
Resolves: #12225
Resolves: #13432
Resolves: #24483
Reviewed-on: http://review.typo3.org/1705
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
8 years ago[TASK] Raise submodule pointer
Oliver Hader [Mon, 23 May 2011 12:43:26 +0000 (14:43 +0200)]
[TASK] Raise submodule pointer

Change-Id: I96e93fbe6cce8b7af3891d073cc02a8d7bf9f358
Reviewed-on: http://review.typo3.org/2302
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[BUGFIX] Allow Tx_ as class prefix
Andreas Kiessling [Fri, 29 Apr 2011 15:07:48 +0000 (17:07 +0200)]
[BUGFIX] Allow Tx_ as class prefix

Although extbase urges to use Tx_ as prefix for class name, this prefix
is not accepted in all places of the core.

Change-Id: If067d9d31e9447caf4da555b03e743f31ed74a6b
Resolves: #22594
Releases: 4.6, 4.5, 4.4, 4.3
Reviewed-on: http://review.typo3.org/2287
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[TASK] Update RTE manual with description of buttons
stan [Thu, 19 May 2011 21:20:00 +0000 (17:20 -0400)]
[TASK] Update RTE manual with description of buttons

Thanks to Christian Hennecke.

Change-Id: I290db54584dacccbd359001347d8d161281bb13c
Resolves: #26724
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/2245
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[BUG] Constant TYPO3_URL_DONATE defined twice
Xavier Perseguers [Thu, 12 May 2011 11:48:54 +0000 (13:48 +0200)]
[BUG] Constant TYPO3_URL_DONATE defined twice

Constant TYPO3_URL_DONATE is defined twice. Once with
the old, simulate static URL, and once with the new, current
URL.

Change-Id: I8ec86ef3c0e371fa172535c7a465a775502f6b56
Resolves: #26781
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/2096
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Fedir RYKHTIK
Tested-by: Fedir RYKHTIK
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] Fix stdWrap for Click-to-enlarge
Markus Klein [Wed, 11 May 2011 23:22:28 +0000 (01:22 +0200)]
[BUGFIX] Fix stdWrap for Click-to-enlarge

Due to a syntax error, stdWrap for the target attribute of
the click-to-enlarge image link is broken. (Nobrainer)

Change-Id: If5c82e36dab13f85728440e2410bf734df7b727a
Resolves: #26757
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/2087
Reviewed-by: Yves Poersch
Tested-by: Yves Poersch
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[TASK] Use external Core Project DBAL as Git submodule
Oliver Hader [Tue, 10 May 2011 20:55:51 +0000 (22:55 +0200)]
[TASK] Use external Core Project DBAL as Git submodule

Change-Id: I11dc910f42ef98f91cc3a2e3931ffd2c400243fd
Resolves: #26738
Releases: 4.2, 4.3, 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/2015
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[BUGFIX] Removing child records in a workspace does not work
Oliver Hader [Thu, 17 Mar 2011 17:58:19 +0000 (18:58 +0100)]
[BUGFIX] Removing child records in a workspace does not work

These parts are not working with IRRE in workspaces:
Removing children in TCEforms
Removing children in the list view
Reverting changes in the workspace module

Change-Id: I79904c636772f6fcd7fcfe1fc6e136e9e2e19d98
Resolves: #25352
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1986
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[TASK] Raised submodule pointers of external projects
Oliver Hader [Tue, 10 May 2011 11:22:53 +0000 (13:22 +0200)]
[TASK] Raised submodule pointers of external projects

Affected project: workspaces

Change-Id: I6171c86367e866fefd2caeac69e4b10642497a7f
Reviewed-on: http://review.typo3.org/1982
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[TASK] Use external Core Projects workspaces and version as Git submodules
Oliver Hader [Mon, 9 May 2011 12:12:43 +0000 (14:12 +0200)]
[TASK] Use external Core Projects workspaces and version as Git submodules

Part 2/2

Change-Id: I5fd9dc244921b1751af0eadd8e5571728218ce6d
Resolves: #26581
Reviewed-on: http://review.typo3.org/1962
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[TASK] Use external Core Projects workspaces and version as Git submodules
Oliver Hader [Mon, 9 May 2011 12:06:39 +0000 (14:06 +0200)]
[TASK] Use external Core Projects workspaces and version as Git submodules

Part 1/2

Change-Id: Id743a7f72e1d11ed5631d75d6fb95d89b9decd17
Resolves: #26581
Reviewed-on: http://review.typo3.org/1961
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[BUGFIX] Also crop when maxCharacters < first word
Peter Beernink [Fri, 25 Mar 2011 11:20:27 +0000 (12:20 +0100)]
[BUGFIX] Also crop when maxCharacters < first word

When maxCharacters is equal or less then the length of the first word,
the whole string was returned when 'crop to word' is enabled instead of
the only the cropped part.

Change-Id: I96446430bd0681e9f64c699bca9f80866a712490
Resolves: #25368
Reviewed-on: http://review.typo3.org/1955
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] Display correct lost records count in record statistics
Susanne Moog [Sun, 10 Apr 2011 08:32:16 +0000 (10:32 +0200)]
[BUGFIX] Display correct lost records count in record statistics

The module DB Check > Record statistics counts the deleted pages
instead of the lost pages and displays that number. As the links
for adopting orphaned records should correlate to the count of
lost records, we should display the correct number.

Change-Id: I3b0e1046b1f79c3849fb883f7805d4a2b683b4fa
Resolves: #25863
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/1532
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] Check for a valid Date object before opening datepicker
Patrick Schriner [Fri, 6 May 2011 11:59:43 +0000 (13:59 +0200)]
[BUGFIX] Check for a valid Date object before opening datepicker

Fix a regression, while trying to parse the old time when opening
the datepicker would fail on a previously empty datetime field.
Add a check for a valid Date object.

Resolves: #26674
Relates: #25043

Change-Id: Ib435031d0aad56940618c0426cc400965786d891
Reviewed-on: http://review.typo3.org/1942
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[FEATURE] Add hook to override icon status overlay
Francois Suter [Tue, 5 Apr 2011 13:12:39 +0000 (15:12 +0200)]
[FEATURE] Add hook to override icon status overlay

Icons status overlays are defined in t3lib_iconWorks::
mapRecordOverlayToSpriteIconName(). However it is necessary
for "external" process (e.g. versioning) to override the
icon status. Currently a deleted record in a workspace will
not appear properly overlaid because only deleted = 1 is
checked and not also t3ver_state = 2. This hook makes it
possible for the version sysext to hook into the process and
set the right status.

Change-Id: Ie8603cf58dddc4159fd5198d97191ba607009475
Resolves: #25765
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1921
Tested-by: Oliver Hader
Reviewed-by: Oliver Hader
8 years ago[BUGFIX] Abandon one time CSRF tokens
Helmut Hummel [Sun, 20 Mar 2011 18:15:57 +0000 (19:15 +0100)]
[BUGFIX] Abandon one time CSRF tokens

Abandon the extra security feature of having one time tokens and create tokens
which are valid during a whole login session. Additionally create only one random token,
store it in the session and create the real URL and form tokens by hashing the scope strings
with the secret session token.

To enable re-login, store the session token in the registry and retrieve it in case a
re-login happens.

Thanks to Marion Eher (Bluechip.at) for sponsoring
this fix with 75 beers during the bug auction at T3BOARD11.

Resolves: #25359
Change-Id: I078a6fa7f579026a33568fd0af114e5776c994da
Reviewed-on: http://review.typo3.org/1361
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
8 years ago[BUGFIX][saltedpasswords] Failed backend logins not not logged
Torben Hansen [Fri, 29 Apr 2011 12:03:18 +0000 (14:03 +0200)]
[BUGFIX][saltedpasswords] Failed backend logins not not logged

The logging functions in saltedpasswords are not able to log failed
backend userlogins to TYPO3s syslog, because the inherited
writelog-function gets overridden by a local function. As a result, no
notification e-mail is sent to [warning_email_addr] when a backend user
has multiple failed login attempts. A remote 'attacker' could try to
login to a TYPO3 installations backend numerous of times without being
noticed (no log entry and no warning-email if configured).

Rename the local writelog-function to writeLogMessage and add the
original writelog-functionality, so that failed backend logins are
written to TYPO3s syslog again and all logging/notifications work as
expected.

Resolves: #23917
Releases: 4.6, 4.5, 4.4, 4.3

Change-Id: Id3209d09c366c3a662e6a2e037ebe2c74fc2dd6c
Reviewed-on: http://review.typo3.org/1643
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Torben Hansen
Tested-by: Torben Hansen
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
8 years ago[BUGFIX] Typo "tsdWrap" instead of "stdWrap"
Christopher Stelmaszyk [Fri, 29 Apr 2011 14:46:30 +0000 (16:46 +0200)]
[BUGFIX] Typo "tsdWrap" instead of "stdWrap"

In class tslib_content_offsettable there is one occurence of "tsdWrap",
which should read "stdWrap".

Change-Id: I8ae47213eeadaf2e77ef25138f3aa2da4b4f5cb6
Resolves: #26500
Reviewed-on: http://review.typo3.org/1801
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX][TESTS] Fix unit test cropIsMultibyteSafe
Steffen Gebert [Fri, 29 Apr 2011 10:50:52 +0000 (12:50 +0200)]
[BUGFIX][TESTS] Fix unit test cropIsMultibyteSafe

The unit test cropIsMultibyteSafe (class tslib_contentTest) fails, if
error reporting includes E_WARNING. In this case mb_strlen() throws an
error, as it is called with an empty string as second parameter
$charset. Initializing $GLOBALS['TSFE']->renderCharset in the setUp
method solves this.

Change-Id: Id57fab2393a651ddd72fdb46e86e71f0d70330a1
Resolves: #26491
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1786
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX][TESTS] Fix unit test fixPermissionsSetsPermissionsWithRelativeFileReference
Steffen Gebert [Thu, 28 Apr 2011 16:38:02 +0000 (18:38 +0200)]
[BUGFIX][TESTS] Fix unit test fixPermissionsSetsPermissionsWithRelativeFileReference

The test fixPermissionsSetsPermissionsWithRelativeFileReference
(t3lib_divTest) used a (wrong) relative path to a test file in the chmod
call. Thus the test failed.

Prepend PATH_site have the correct absolute path.

Change-Id: I14d5eb2e4a7f8867170c9d5fde7123b9313aea95
Resolves: #26423
Reviewed-on: http://review.typo3.org/1788
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] EM: Incorrect label ext_details_always_loaded ['SYS'] / ['EXT']
Bjoern Pedersen [Wed, 27 Apr 2011 12:17:36 +0000 (14:17 +0200)]
[BUGFIX] EM: Incorrect label ext_details_always_loaded ['SYS'] / ['EXT']

The message has TYPO3_CONF_VARS['SYS']['requiredExt'] instead of
TYPO3_CONF_VARS['EXT']['requiredExt'] as in config_default.php.

Change-Id: I0303b8416d7a4d19a6688f13bfb52c42aa0e98ca
Resolves: #26354
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1766
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] TCA tree with maxitems=1 doesn't work
Marco Huber [Thu, 17 Mar 2011 12:53:13 +0000 (13:53 +0100)]
[BUGFIX] TCA tree with maxitems=1 doesn't work

* Check if value of the parent field is neither empty nor 0,
  because t3lib_transferData returns 0 if the database field
  is empty and maxitems=1
* Only check if the selected nodes reached the maxitems limit
  if a node is checked, not if one is unchecked.

Change-Id: I89efc539cf720a6798d244e0a499d6bebff32d9f
Resolves: #25347
Reviewed-on: http://review.typo3.org/1211
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Marco Huber
Tested-by: Marco Huber
Reviewed-by: Andreas Wolf
8 years ago[BUGFIX] Fix inconsistent linebreaks in some files
Michael Stucki [Tue, 19 Apr 2011 12:47:03 +0000 (14:47 +0200)]
[BUGFIX] Fix inconsistent linebreaks in some files

A few files are containing inconsistent linebreaks.
Since all of these files are taken from external projects,
someone needs to make sure that they get fixed during future
imports.

Change-Id: I79f70d82edf199c165620dd426c9b9f2af690823
Resolves: #26126
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1662
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[TASK] Remove file SVNreadme.txt
Steffen Gebert [Fri, 22 Apr 2011 15:22:40 +0000 (17:22 +0200)]
[TASK] Remove file SVNreadme.txt

The file SVNreadme.txt in the root of the repository contains
information, which should help people coming from older versions bevore
4.0 and using an SVN checkout.

Not only the name is outdated, most of the information is also wrong.
So remove this file.

Change-Id: Ib30ced2be48cd0c986ff934802508f3db98f442d
Reviewed-on: http://review.typo3.org/1707
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] Log out after running garbage collection tests
Christian Kuhn [Thu, 21 Apr 2011 15:05:43 +0000 (17:05 +0200)]
[BUGFIX] Log out after running garbage collection tests

TYPO3_DB must be added to $backupGlobalsBlacklist.

Change-Id: I97e1a11da555e5f247c8f5cfb87142f70d2e8b78
Resolves: #26174
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1701
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Replace deprecated assertType in unit tests
Alexander Stehlik [Thu, 21 Apr 2011 13:01:33 +0000 (15:01 +0200)]
[BUGFIX] Replace deprecated assertType in unit tests

Change-Id: If068c3483225d4a21a69493a54ab2845c1f48760
Resolves: #25090
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1697
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Wrong type hinting in interface tslib_menu_filterMenuPagesHook
Michael Birchler [Mon, 18 Apr 2011 14:08:10 +0000 (16:08 +0200)]
[BUGFIX] Wrong type hinting in interface tslib_menu_filterMenuPagesHook

tslib_menu_filterMenuPagesHook::tslib_menu_filterMenuPagesHook expects a
tslib_tmenu object as fourth parameter $obj.
$obj should hint for tslib_menu and not as wrongly specified tslib_tmenu.
If hook is used and for example a GMENU will be processed an exception
will be thrown.

Change-Id: I0b9689f9ced9c027c1ef757ef37126268b568c97
Resolves: #25979
Reviewed-on: http://review.typo3.org/1680
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] register['count_menuItems'] wrong, if filtered by userfunc
Bjoern Pedersen [Wed, 6 Apr 2011 07:47:40 +0000 (09:47 +0200)]
[BUGFIX] register['count_menuItems'] wrong, if filtered by userfunc

the register['count_menuItems'] is set, before a possible userfunc filters the menu items -> wrong register value.

Solution: change call sequence

Change-Id: I3b7b8747309d57fcece2db949974530c38ba5bb2
Resolves: #25405
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1473
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Recursion error in typoscript when including typoscript files
Tobias Liebig [Thu, 31 Mar 2011 19:48:21 +0000 (21:48 +0200)]
[BUGFIX] Recursion error in typoscript when including typoscript files

In template module, when editing typoscript and using the "Include
TypoScript file content" option with more then 9 files, the 10th and
more files got screwed up.

Thanks to André Spindler for reporting and providing a patch.
Thanks to Kilian Hann (futureconnection AG Zürich) for sponsoring
100 beers during the bug auction.

Change-Id: I220ee78da5875ff66753769f2e704a49539dff31
Resolves: #25374
Reviewed-on: http://review.typo3.org/1365
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Sebastian Fischer
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] List module - Fix pointer issue in pagebrowser
Peter Beernink [Sun, 10 Apr 2011 11:58:10 +0000 (13:58 +0200)]
[BUGFIX] List module - Fix pointer issue in pagebrowser

When you have more than 50 records in the list module, you can use
the page browser to display the next set of records.
When using this on the pages table, the pointer to page 2,3,.. is
added to the link of each page record. Selecting such a link causes
the result listing of that page to also start from that specific result
page. If there are not enough records, none will be shown.

Change-Id: I27b79acfaebd23527019f83926b2a53018a6ab49
Resolves: #20908
Reviewed-on: http://review.typo3.org/1537
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[BUGFIX] Missing sprite icons in module db check > record statistics
Sven Juergens [Sun, 10 Apr 2011 07:32:14 +0000 (09:32 +0200)]
[BUGFIX] Missing sprite icons in module db check > record statistics

The module DB check > Record statistics is using old icons for
pages. Additionally the icons for the different doktypes are
broken.

Change-Id: I5b368b46699699406bb5fed99a8ac10619b14598
Resolves: #24835
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/1535
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Flexformfield "Forgot Password Message" in felogin does not work
Steffen Mueller [Sun, 27 Mar 2011 20:46:15 +0000 (22:46 +0200)]
[BUGFIX] Flexformfield "Forgot Password Message" in felogin does not work

The value of the FF field "Forgot Password Message" in felogin is not working. Solution is to rename FF field name from "forgot_message" to "forgot_reset_message".

Change-Id: I9f6080fc3cf577c123d652475b17fc607e8ce69d
Resolves: #23134
Releases: 4.6, 4.5, 4.4, 4.3
Reviewed-on: http://review.typo3.org/1640
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] PHP_SCRIPT_INT unnecessarily requires parameter scriptSuffix
Steffen Gebert [Tue, 5 Apr 2011 15:42:19 +0000 (17:42 +0200)]
[BUGFIX] PHP_SCRIPT_INT unnecessarily requires parameter scriptSuffix

Using PHP_SCRIPT_INT throws an Exception "Expected parameter
$conf['scriptSuffix'] was not given.", in its render() method.

As the parameter is useless and not used in other places, this check
can be removed.

Change-Id: I639a8d65406473efe3a40e7efe99c31055e479e9
Resolves: #25145
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1467
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] remove console.log in pagetree actions.js
Frederic Gaus, Flagbit GmbH & Co. KG [Tue, 12 Apr 2011 14:52:16 +0000 (16:52 +0200)]
[BUGFIX] remove console.log in pagetree actions.js

Simply removes the console.log debugging output. This line causes
JavaScript errors if there is no console object present.

Change-Id: I0e66318f45a5718b5e3c9d0a4dda089bbe68ae90
Resolves: #25721
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1593
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[BUGFIX] Visibility of method tx_sysaction_task::fixUsername()
Oliver Hader [Wed, 9 Mar 2011 14:13:37 +0000 (15:13 +0100)]
[BUGFIX] Visibility of method tx_sysaction_task::fixUsername()

The method fixUsername() is defined as private, but should be
protected instead.

Change-Id: I2a7369bf78e77e68595121e3083ad813e721e00f
Resolves: #25219
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/1105
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Using datetime field with datepicker the time information gets lost
Steffen Kamper [Wed, 23 Mar 2011 22:24:22 +0000 (23:24 +0100)]
[BUGFIX] Using datetime field with datepicker the time information gets lost

As the datepicker only return date information, the time information gets lost when select a new date with datepicker.

Solution:
Add time information to selected date

Change-Id: Id0a937a3e0344ddcca840cb7e8e36c8400a09075
Resolves: #M17596
Reviewed-on: http://review.typo3.org/1248
Reviewed-by: Caspar Stuebs
Tested-by: Caspar Stuebs
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Disable the TCA Tree if $PA['fieldConf']['config']['readOnly'] is true.
Marco Huber [Mon, 11 Apr 2011 13:15:19 +0000 (15:15 +0200)]
[BUGFIX] Disable the TCA Tree if $PA['fieldConf']['config']['readOnly'] is true.

Disable the TCA Tree if $PA['fieldConf']['config']['readOnly'] is true.
This happens for example in translations of records if
$TCA['my_table']['columns']['my_column']['l10n_display'] = 'defaultAsReadonly'.

Change-Id: Ib5e11aa80d55a6f74e4fc439ca8537dc8ed0e45b
Resolves: #25888
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1560
Reviewed-by: Marco Huber
Tested-by: Marco Huber
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[BUGFIX] Configuration Tool creates invalid extTables.php file
Markus Klein [Wed, 6 Apr 2011 09:44:24 +0000 (11:44 +0200)]
[BUGFIX] Configuration Tool creates invalid extTables.php file

If extTables.php is empty or not present, this changes takes care of
adding an extra LF after the opening <?php tag.

Change-Id: I948d98e033fc67e171926faccfdb5d1a2cf78aa6
Resolves: #25781
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/1474
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Jan Loderhose
Tested-by: Jan Loderhose
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-on: http://review.typo3.org/1552
Reviewed-by: Markus Klein
Tested-by: Markus Klein
8 years ago[BUGFIX] Media obj respect moveJsFromHeaderToFooter
Alexandre Gravel-Raymond [Fri, 4 Mar 2011 14:55:16 +0000 (15:55 +0100)]
[BUGFIX] Media obj respect moveJsFromHeaderToFooter

If you set config.moveJsFromHeaderToFooter=1 in your TS template, and
add a Media object, the swfobject library is correctly added at the
bottom of the page, but the inline code calling the swfobject library
is added inline at the same place as the media object.
This results in the javascript error "swfobject is not defined" and
the media not appearing on the page.

This change makes use of t3lib_PageRenderer::addJsInlineCode to add
the inline code, so it respects config.moveJsFromHeaderToFooter=1.

Change-Id: I971ebb2c31568e40a3209dfcf7871010e830565e
Resolves: #25258
Reviewed-on: http://review.typo3.org/1062
Reviewed-by: Steffen Kamper
Reviewed-by: Björn Pedersen
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1547

8 years ago[BUGFIX] Pagetree - Add missing icons for expand/collapse whole branches
Stefan Galinski [Thu, 10 Mar 2011 23:29:32 +0000 (00:29 +0100)]
[BUGFIX] Pagetree - Add missing icons for expand/collapse whole branches

Add icons for the expand/collapse context menu actions.

Change-Id: I62fbd5c40a1add5f5915d5ab4535245dd9bc1e77
Resolves: #25305
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1131
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[BUGFIX] Add missing parameter in "Page not found" handling
Steffen Gebert [Sun, 3 Apr 2011 18:52:24 +0000 (20:52 +0200)]
[BUGFIX] Add missing parameter in "Page not found" handling

t3lib_message_ErrorpageMessage::__construct() requires two parameters,
however only one is given after change #24945, which modified the
handling of 404 errors.

This patch adds the second one.

Change-Id: I9a766df6bf10ebc8c60346b3072e49008485b72a
Resolves: #25727
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1452
Reviewed-by: Peter Kraume
Tested-by: Peter Kraume
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] Wrong display of csh icon and text in new record wizard
sebastian.mueller [Tue, 29 Mar 2011 12:39:28 +0000 (14:39 +0200)]
[BUGFIX] Wrong display of csh icon and text in new record wizard

For each TCA-Table where you can add an element on a side, there is displayed
a csh icon with text (if text is configured). In db_new.php is a wrong
variable used so the csh text of the last tca-table is always used and for
each table. So it will also be displayed for tables which orginally got no csh text.

Additionally due to a missing break, the csh icon of a table is displayed
in the wrong line.

Change-Id: I7c4b0fec0e8c5c0a6947dec9c30b4c2ff3960d05
Resolves: #25371
Reviewed-on: http://review.typo3.org/1304
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Francois Suter
Tested-by: Francois Suter
8 years ago[BUGFIX] BE list module fails to load after invalid inclusion removal
Xavier Perseguers [Sun, 3 Apr 2011 16:35:26 +0000 (18:35 +0200)]
[BUGFIX] BE list module fails to load after invalid inclusion removal

Class recordList is not included anymore due to a wrong require_once call deletion

Change-Id: I0d585e078112552507eb0349bf589131277c5d81
Fixes: #25408
Reviewed-on: http://review.typo3.org/1450
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
8 years ago[BUGFIX] BE list module fails on some systems with PHP 5.3
Xavier Perseguers [Mon, 28 Mar 2011 16:09:09 +0000 (18:09 +0200)]
[BUGFIX] BE list module fails on some systems with PHP 5.3

When trying to load Web > List, the server answers with
Fatal error: Cannot redeclare class recordList

Change-Id: I090bb9c7fa6529216cd677c61f3eee427abda943
Resolves: #25408
Reviewed-on: http://review.typo3.org/1443
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] unzip_path setting is used inconsistently
Rasto Birka [Thu, 31 Mar 2011 20:38:34 +0000 (22:38 +0200)]
[BUGFIX] unzip_path setting is used inconsistently

The setting $TYPO3_CONF_VARS']['BE']['unzip_path'] is used inconsistently in TYPO3.

In some cases, it expects the directory of the unzip binary. In other places, the
full path of the unzip binary is expected. This change adds a compatibilty layer
to cope with this.

Thanks to Tobias Liebig (networkteam GmbH) for sponsoring 60 beers during the
bug auction at T3BOARD11.

Change-Id: Iae834f7577450ab7173c9827db508bd464ba1fa3
Resolves: #25470
Reviewed-on: http://review.typo3.org/1374
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
8 years ago[BUGFIX] Fix PHP Catchable Fatal Error in t3lib_iconWorks
Sven Luzar [Mon, 28 Mar 2011 11:03:02 +0000 (13:03 +0200)]
[BUGFIX] Fix PHP Catchable Fatal Error in t3lib_iconWorks

The hook in t3lib_iconWorks::mapRecordTypeToSpriteIconName() passes an
array to call a user function, but the method t3lib_div::callUserFunction
expects a variable being passed by reference.

Assigning the array to a variable fixes this error.

Thanks to Haymo Meran (Gentics) for sponsoring this fix with 80 beers
at the bug auction at T3BOARD11.

Change-Id: Ib0c0b2bd504fdbc346e8f70009bb60e82a66d8b0
Resolves: #25402
Reviewed-on: http://review.typo3.org/1378
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[BUGFIX] Add the storage field to the TCA for sysfolders
Henrik Møller Rasmussen [Thu, 31 Mar 2011 20:14:05 +0000 (22:14 +0200)]
[BUGFIX] Add the storage field to the TCA for sysfolders

The field disappeared in 4.5 and has now been added again.

Thanks to Rene Haflinger (Agentur Frontal) for sponsoring
this fix with 100 beers during the bug auction at T3BOARD11.

Change-Id: I7ba95be81f2ca5b758bbdb8a3d10ac4316309059
Resolves: #25494
Reviewed-on: http://review.typo3.org/1373
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert