Packages/TYPO3.CMS.git
8 years ago[TASK] Index for "pages" table is still not optimal
Dmitry Dulepov [Fri, 16 Sep 2011 12:11:46 +0000 (15:11 +0300)]
[TASK] Index for "pages" table is still not optimal

The fix for #21381 causes "using filesort" in the List view for
"pages" table. This happens due to the "hidden" field in the
index. This field should be removed from the index because it is
not needed for the List module and it is not useful in FE due to
more expensive fe_group field.

Change-Id: Ia5fc87f7b1fa89e515c292248365d1d684872be0
Resolves: #29896
Related: #21381
Releases: 4.6
Reviewed-on: http://review.typo3.org/4997
Reviewed-by: Björn Pedersen
Reviewed-by: Frederic Gaus
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] About modules: Adjust bgcolor of sections
Tomas Norre Mikkelsen [Sat, 17 Sep 2011 13:55:17 +0000 (15:55 +0200)]
[BUGFIX] About modules: Adjust bgcolor of sections

Adjust the background color of the module section table cells to match
the "body" background color.

Change-Id: Id688471665257a985004bf44cf5aec7fc646de08
Resolves: #27589
Reviewed-on: http://review.typo3.org/5004
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] Check curl availability before using it
Tolleiv Nietsch [Tue, 13 Sep 2011 11:47:08 +0000 (13:47 +0200)]
[BUGFIX] Check curl availability before using it

Curl is used when activated in the install tool.
The core should check if curl is available before using it.

Because the getUrl() refactoring will hopefully be ready in 4.7,
I found that this simple solution should at least fix it for 4.6.

Change-Id: I29e4d3b760aaf09f95a2ba6f560fe6562a7d5310
Resolves: #24984
Branches: 4.6, 4.5
Reviewed-on: http://review.typo3.org/4956
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
8 years ago[BUGFIX] Fix backpath for add wizards in IRRE records
Sebastian Fischer [Wed, 14 Sep 2011 13:09:37 +0000 (15:09 +0200)]
[BUGFIX] Fix backpath for add wizards in IRRE records

As in typo3/init.php the TYPO3_mainDir is set to 'typo3/' the replacement in
renderForeignRecord could not work because it uses the TYPO3_mainDir . '%2Fajax.php'
which results in typo3//ajax.php
By this the backpath of the add wizard in IRRE foreign records is fixed.

Change-Id: Id2bb587243b7ffbf8458ac3cecfa9ddaa5266d5c
Resolves: #29770
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/4976
Reviewed-by: Björn Pedersen
Reviewed-by: Tobias Liebig
Tested-by: Tobias Liebig
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
8 years ago[TASK] Refactor t3lib_message_AbstractMessage
Steffen Gebert [Mon, 8 Aug 2011 19:48:28 +0000 (21:48 +0200)]
[TASK] Refactor t3lib_message_AbstractMessage

Change-Id: I5a63a5ad1d491af6bbf9ac374b9df3d3f7a4d9b8
Resolves: #29495
Reviewed-on: http://review.typo3.org/4776
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
8 years ago[BUGFIX] t3lib_Compressor: Avoid reference in foreach loop
Frederic Gaus [Thu, 15 Sep 2011 13:57:29 +0000 (15:57 +0200)]
[BUGFIX] t3lib_Compressor: Avoid reference in foreach loop

This fixes a bug introduced in #29695. There is a PHP bug
when using $filename as a reference and later on as a variable in
a foreach loop. The problem is described here:

http://www.php.net/manual/de/control-structures.foreach.php#101425

PHP 5.3.2 (used in current Ubuntu) and 5.3.3 (used in current Debian)
are affected. Other versions could be affected, too.

Avoiding the use of reference in the foreach loop fixes the bug.

Change-Id: I74c0ceee40e170b7cf2e7db91b1554d811a7c844
Resolves: #29832
Releases: 4.6
Related: #29695
Reviewed-on: http://review.typo3.org/4983
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
8 years ago[BUGFIX] t3lib_Compressor fails with external files
Xavier Perseguers [Mon, 12 Sep 2011 14:02:41 +0000 (16:02 +0200)]
[BUGFIX] t3lib_Compressor fails with external files

Externally-referenced files such as jQuery included from a CDN fail to be
concatenated or compressed.

Change-Id: Idd02d85c98811167cccafd2e6a6a96fefda6a936
Fixes: #29695
Releases: 4.6
Reviewed-on: http://review.typo3.org/4924
Reviewed-by: Björn Pedersen
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Tested-by: Björn Pedersen
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] SQL Injection vulnerability in prepared statements
Helmut Hummel [Tue, 13 Sep 2011 18:32:19 +0000 (20:32 +0200)]
[BUGFIX] SQL Injection vulnerability in prepared statements

Change-Id: Iaa91761cd2dafbe7be1d6f6c5db169e3a8f48b0c
Resolves: #29400
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/4961
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[BUGFIX] Disabling the cache does not work on invalid cHash value
Daniel Pötzinger [Tue, 30 Aug 2011 20:40:31 +0000 (22:40 +0200)]
[BUGFIX] Disabling the cache does not work on invalid cHash value

Change-Id: I9df3d7b4bf1d565fc5a429bad6ee2d3d186f6044
Releases: 4.6, 4.5, 4.4, 4.3
Resolves: #29366
Reviewed-on: http://review.typo3.org/4705
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
8 years ago[BUGFIX] Show extension configuration after extension update
Helmut Hummel [Sat, 10 Sep 2011 10:28:27 +0000 (12:28 +0200)]
[BUGFIX] Show extension configuration after extension update

When updating an extension, updates of database tables are not
shown and not offered to be updated. Thus they remain unnoticed
and this leads to unexpected results.

Show extension configuration and database updates after updating an extension.

Resolves: #29625
Releases: 4.5, 4.6

Change-Id: I82281494b71cd9fa38235ebafaa2b2423d15436d
Reviewed-on: http://review.typo3.org/4898
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
8 years ago[TASK] Raise submodule pointer
TYPO3 v4 Release Team [Wed, 14 Sep 2011 08:12:59 +0000 (10:12 +0200)]
[TASK] Raise submodule pointer

Change-Id: I88562065fcedd8503554a7f9c9411d9599ca1292
Reviewed-on: http://review.typo3.org/4957
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
8 years ago[BUGFIX] No content in workspace preview when using select.selectFields
Tolleiv Nietsch [Thu, 14 Jul 2011 18:09:03 +0000 (20:09 +0200)]
[BUGFIX] No content in workspace preview when using select.selectFields

The TypoScript property select.selectFields does not consider workspaces
in the frontend rendering process.

Resolves: #17284
Releases: 4.6, 4.5, 4.4
Change-Id: Id9d1e7dcf56b5aeeec3070ff11416e82ec1bb978
Reviewed-on: http://review.typo3.org/2089
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
8 years ago[BUGFIX] Increase height of "View Item" window
Felix Kopp [Sat, 10 Sep 2011 11:47:13 +0000 (13:47 +0200)]
[BUGFIX] Increase height of "View Item" window

The "View Item" window shows information about a record or file.

Its height of 400px is very small, especially when an image preview is
shown. Increase height to 600px.

Change-Id: I4a97663e4a19c0319901cb82f4a3dc4d70cf3dd8
Resolves: #29627
Releases: 4.6
Reviewed-on: http://review.typo3.org/4900
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[TASK] Improve rendering of plugins in page module
Georg Ringer [Thu, 8 Sep 2011 08:06:11 +0000 (10:06 +0200)]
[TASK] Improve rendering of plugins in page module

The rendering of the content element "plugin" can be highly improved
by changing just a fiew lines.

Changes:
- Remove "CODE:" when not needed
- Remove the "Insert plugin" as there is no additional information

Change-Id: I84795d537ecb15bace39d5e17cfafb5d90115a94
Resolves: #29556
Reviewed-on: http://review.typo3.org/4836
Tested-by: Soren Malling
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] RTE: External links not updated to internal by link dialogue
Stanislas Rolland [Mon, 5 Sep 2011 14:51:17 +0000 (10:51 -0400)]
[BUGFIX] RTE: External links not updated to internal by link dialogue

Solution: Remove external attribute when switching to other type
of link.

Change-Id: Ica76a8d862fd2547ad0baac55b3770dc2cedf79a
Resolves: #29167
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4769
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[BUGFIX] RTE may overwrite link text in IE
Stanislas Rolland [Fri, 9 Sep 2011 03:34:28 +0000 (23:34 -0400)]
[BUGFIX] RTE may overwrite link text in IE

Problem: In IE, setting the link node href attribute may update the link
content when the content is recognized by IE as an url.
Solution: Workaround the IE feature and restore the link content.

Change-Id: I6f41dd2e43a64726e48dc3c714c7cfe89bbc860a
Resolves: #29527, #25464
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4863
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[BUGFIX] Unlock Install Tool only after acknowledgement
Steffen Gebert [Mon, 5 Sep 2011 19:51:12 +0000 (21:51 +0200)]
[BUGFIX] Unlock Install Tool only after acknowledgement

Since #28621, the Install Tool gets automatically unlocked, if an admin
user opens it from the Backend.

This reduces the admin's awareness of the Install Tool being
explicitly protected by the ENABLE_INSTALL_TOOL file. This change
introduces an additional step, in which the user is explicitly asked for
confirmation to unlock the Install Tool.

Change-Id: I289959f7cdc8ff05221005d4431f2e27b3f5cf95
Fixes: #28689
Related: #28621
Releases: 4.6
Reviewed-on: http://review.typo3.org/4777
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
8 years ago[TASK] EM: rename local and remote tabs
Xavier Perseguers [Sat, 10 Sep 2011 09:33:33 +0000 (11:33 +0200)]
[TASK] EM: rename local and remote tabs

After slightly refactoring the options and actions available in tabs
"Local Extension List" and "Remote Repository", the titles should be
updated:

Local Extension List -> Available Extension
Remote Repository -> Import Extensions

Resolves: #29588
Releases: 4.6

Change-Id: Ib4e98749ee72b701100db685b50bc0c76d8c1305
Reviewed-on: http://review.typo3.org/4896
Tested-by: Soren Malling
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[TASK] EM: show updatable extensions in Local Extension List
Xavier Perseguers [Sat, 10 Sep 2011 06:35:14 +0000 (08:35 +0200)]
[TASK] EM: show updatable extensions in Local Extension List

Move the "Show updatable extensions" filter from tab "Remote Repository"
to "Local Extension List".

Change-Id: I8a8dd78549a7b07cae5f7f843f34c691e76fd850
Resolves: #29586
Releases: 4.6
Reviewed-on: http://review.typo3.org/4892
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[TASK] EM: maintenance tab suggest download of CF tables
Francois Suter [Fri, 9 Sep 2011 15:49:36 +0000 (17:49 +0200)]
[TASK] EM: maintenance tab suggest download of CF tables

When looking at an extension's details, the developer information tab
lists all caching framework (CF) tables and the maintenance tab
proposes all CF tables for download. It doesn't make sense, even
for cache tables that are related to the current extension
(because they are created automatically and there's no reason
to dump a cache table's data).
The solution is to add a new flag to avoid listing CF tables
in some circumstances.

Change-Id: I3a8d43bc0d94d9bca99ae72a808e8e07057e9852
Resolves: #29592
Releases: 4.6
Reviewed-on: http://review.typo3.org/4886
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[TASK] Disable compression for inlineJs in Backend
Steffen Gebert [Tue, 9 Aug 2011 19:51:32 +0000 (21:51 +0200)]
[TASK] Disable compression for inlineJs in Backend

JSMin is a major performance nightmare and no network connection can be
as slow as it would justify to spend so much time to execute JSmin
several times for each and every backend request.

As long as we have no fast replacement in core available, disable
compression for all JS snippets added with
t3lib_PageRenderer::addJsInlineCode in the Backend.

JSMin's share of execution time was about 20-25% of the page generation
time, for almost empty backend pages even ~50%.

Change-Id: I5623ad6c8b9d24777b6bcf46ea97bf51eb9c62d3
Resolves: #29498
Reviewed-on: http://review.typo3.org/4778
Reviewed-by: Xavier Perseguers
Reviewed-by: Björn Pedersen
Tested-by: Björn Pedersen
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
8 years ago[BUGFIX] Wrong char for explodes of links
Georg Ringer [Fri, 9 Sep 2011 15:49:50 +0000 (17:49 +0200)]
[BUGFIX] Wrong char for explodes of links

user_plaintext::renderImage uses ',' as char to
explode links but TYPO3 switched to a LF

Change-Id: Id531b7d76e3b5d1f04cf61448ff8ece172f6cb29
Resolves: #29597
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4887
Reviewed-by: Markus Klein
Reviewed-by: Xavier Perseguers
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
8 years ago[TASK] EM: make update window use full screen
Francois Suter [Fri, 9 Sep 2011 12:30:45 +0000 (14:30 +0200)]
[TASK] EM: make update window use full screen

The UPDATE! script pop-up window in the Extension Manager is hard-coded
to some reduced size. Make it use the full screen instead. This also
makes it de facto modal, otherwise it can be launched several times.

Change-Id: I2bbe2189f421944389a648388e51893db43ad7bd
Resolves: #29593
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/4880
Reviewed-by: Björn Pedersen
Tested-by: Björn Pedersen
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Francois Suter
Tested-by: Francois Suter
8 years ago[TASK] Wrong phpDoc type hints
Francois Suter [Fri, 9 Sep 2011 13:41:59 +0000 (15:41 +0200)]
[TASK] Wrong phpDoc type hints

Simple copy and paste error: some variable names are wrong
inside the phpDocs.

Change-Id: Ifd8d27639d003cae90fb88704c8024e747e246d1
Releases: 4.6
Reviewed-on: http://review.typo3.org/4883
Reviewed-by: Francois Suter
Tested-by: Francois Suter
8 years ago[TASK] EM: remove info icon in extension list
Xavier Perseguers [Fri, 9 Sep 2011 12:01:39 +0000 (14:01 +0200)]
[TASK] EM: remove info icon in extension list

A blue info icon is shown next to the extension title when additional
information are configured to pop up as external window. This icon is
useless as clicking on the extension title shows the info window as well.

Change-Id: I239bd978220896742cddc0d0fe265859b11bdf3f
Resolves: #29589
Releases: 4.6
Reviewed-on: http://review.typo3.org/4879
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Steffen Ritter
Reviewed-by: Björn Pedersen
Tested-by: Björn Pedersen
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[TASK] EM: make pop-up window use full screen
Francois Suter [Fri, 9 Sep 2011 10:06:02 +0000 (12:06 +0200)]
[TASK] EM: make pop-up window use full screen

The information pop-up window in the Extension Manager is hard-coded
to some reduced size. Make it use the full screen instead, as it is
modal anyway. This provides more space to view all the information.

Change-Id: I5077cb9e3a4a23b60a4d6ab0b6a086905e7340a8
Resolves: #29585
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/4872
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Tested-by: Soren Malling
Reviewed-by: Francois Suter
Tested-by: Francois Suter
8 years ago[TASK] Trivial: bad phpDoc format in tslib_feUserAuth
Dmitry Dulepov [Fri, 9 Sep 2011 12:34:44 +0000 (15:34 +0300)]
[TASK] Trivial: bad phpDoc format in tslib_feUserAuth

phpDoc format does not conform to TYPO3 CGL in class
tslib_feUserAuth, function getCookieName(). Lines need to be
rearranged, proper letter case set.

Change-Id: Iba7a894ddca1e47fa8a8d8b64c666720e28973ed
Resolves: #29598
Releases: 4.6
Reviewed-on: http://review.typo3.org/4881
Reviewed-by: Björn Pedersen
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] FE session transfer is broken
Dmitry Dulepov [Tue, 28 Jun 2011 12:25:04 +0000 (15:25 +0300)]
[BUGFIX] FE session transfer is broken

The fix for #M13740 (revision 3a3a8d81) breaks FE session
transfer across top level domains.

Method tslib_fe::initFEuser() checks if there is a special
URL parameter named FE_SESSION_KEY. If that exists, it sets
$_COOKIE[$this->fe_user->name] to the passed session value.
This is very useful when using RealURL's feature to make
different language domains but use the same user for all
domains (multilanguage countries like Switzerland
or Belgium love that). However this is broken by using
$_SERVER['HTTP_COOKIE'] for FE session cookie. tslib_fe
has to be adjusted to set the same cookie.

Change-Id: Ieb77834d95ffc9f7a44bc4e739df65035be22339
Resolves: #27740
Releases: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/2948
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
8 years ago[BUGFIX] Padding of RTE statusbar is too big
Stanislas Rolland [Thu, 8 Sep 2011 15:19:48 +0000 (11:19 -0400)]
[BUGFIX] Padding of RTE statusbar is too big

onLayout produces incorrect results when executed on a hidden element.

Change-Id: Iffe239a05f43033ca7bb352d0f840e733b82bace
Resolves: #29485
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4859
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[BUGFIX] RTE only loads styles from external css file on reload in IE8
Stanislas Rolland [Thu, 8 Sep 2011 14:24:03 +0000 (10:24 -0400)]
[BUGFIX] RTE only loads styles from external css file on reload in IE8

Problem: The script fails to detect that a stylesheet is not loaded
Solution: Check for empty rules and imports arrays of skin and
content stylesheets.

Change-Id: Ie9669ca79e7814805dc5dbcd29f5f65939524071
Resolves: #29234
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4858
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[BUGFIX] Locales dependency is not taken into account
Xavier Perseguers [Thu, 1 Sep 2011 12:21:18 +0000 (14:21 +0200)]
[BUGFIX] Locales dependency is not taken into account

Localization methods do not take global or user-defined locales
dependencies into account when retrieving a label for a given language.
Instead, they always fall back to default (English) if the requested
language key was not found.

Change-Id: Icb2789e9ad3c56b65d098fe136d898954e39a51c
Fixes: #29386
Releases: 4.6
Reviewed-on: http://review.typo3.org/4718
Reviewed-by: Xavier Perseguers
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
8 years ago[BUGFIX] Fix JavaScript for multiple select fields
Bjoern Pedersen [Mon, 8 Aug 2011 17:17:58 +0000 (19:17 +0200)]
[BUGFIX] Fix JavaScript for multiple select fields

The core changed the groupfield JS code to use only the size attribute
and disallows the "multiple" attribute as a check for multiple
entries (see Bug #25221).

This breaks dam and related extensions. The check should also allow a
set "Multiple" attribute.

Change-Id: I429486d93574638db836d7874e473641fb6ec4a6
Resolves: #28849
Releases: 4.6
Reviewed-on: http://review.typo3.org/4227
Reviewed-by: Franz Koch
Tested-by: Franz Koch
Reviewed-by: Xavier Perseguers
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
8 years ago[FEATURE] Allow user-defined additional backend languages
Xavier Perseguers [Wed, 7 Sep 2011 17:16:29 +0000 (19:16 +0200)]
[FEATURE] Allow user-defined additional backend languages

At the moment, any language may be used for Frontend output. But in Backend, the list
of supported languages is hardcoded at various places. This prevents additional
languages to be defined locally, for instance when translating TYPO3 into a new
language, before it gets officially supported by the Core.

Change-Id: I66cd9149c860746356e249c778a5303211076d37
Resolves: #29513
Releases: 4.6
Reviewed-on: http://review.typo3.org/4830
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Dominique Feyer
Tested-by: Dominique Feyer
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[TASK] Encrypt password transmission in user setup
Helmut Hummel [Mon, 22 Aug 2011 06:36:56 +0000 (08:36 +0200)]
[TASK] Encrypt password transmission in user setup

If extension rsaauth is enabled, the password transmission
when saving the user settings form should be encrypted.

Resolves: #29143
Releases: 4.6

Change-Id: Icdbc63306289387690a5a71b96eb481c9515d233
Reviewed-on: http://review.typo3.org/4462
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[FEATURE] Allow user-defined additional backend languages
Xavier Perseguers [Tue, 6 Sep 2011 13:23:42 +0000 (15:23 +0200)]
[FEATURE] Allow user-defined additional backend languages

At the moment, any language may be used for Frontend output. But in Backend, the list
of supported languages is hardcoded at various places. This prevents additional
languages to be defined locally, for instance when translating TYPO3 into a new
language, before it gets officially supported by the Core.

Change-Id: Ibd3236a82790f9f20c91ff3663d6625694ef7cf6
Resolves: #29513
Releases: 4.6
Reviewed-on: http://review.typo3.org/4797
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
8 years ago[BUGFIX] Typo in $TYPO3_CONF_VARS['BE']['lang']['debug']
Xavier Perseguers [Tue, 6 Sep 2011 11:55:58 +0000 (13:55 +0200)]
[BUGFIX] Typo in $TYPO3_CONF_VARS['BE']['lang']['debug']

'debug' is wrongly written 'degug' in default configuration.

Change-Id: I0d47fe0234b81b5b6a8b6ab13ee1d07a2854ddad
Releases: 4.6
Reviewed-on: http://review.typo3.org/4794
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[TASK] Clean up t3lib_message_ErrorPageMessage
Steffen Gebert [Mon, 8 Aug 2011 16:07:13 +0000 (18:07 +0200)]
[TASK] Clean up t3lib_message_ErrorPageMessage

Change-Id: I598acfa2b2c15b1fb290827504a23462c90b374d
Resolves: #29494
Reviewed-on: http://review.typo3.org/4775
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[TASK] Add missing XCLASS to the t3lib_l10n_* classes
Xavier Perseguers [Mon, 5 Sep 2011 06:43:54 +0000 (08:43 +0200)]
[TASK] Add missing XCLASS to the t3lib_l10n_* classes

The t3lib_l10n_* classes lack the XCLASS definition even though
they are instantiated with makeInstance().

Change-Id: I5304552a6ce8ad943dcd27d977754d055e60c694
Resolves: #29473
Releases: 4.6
Reviewed-on: http://review.typo3.org/4763
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] Add missing files for HTTP_Request2
Philipp Gampe [Tue, 30 Aug 2011 06:19:18 +0000 (08:19 +0200)]
[BUGFIX] Add missing files for HTTP_Request2

Some files have been forgotten while committing HTTP_Request2,
because they are in a different directory and rarely used.

Change-Id: Ifc11dfdbdac5378fed6db33ccd434a0341bbf35f
Fixes: #29337
Releases: 4.6
Reviewed-on: http://review.typo3.org/4671
Reviewed-by: Xavier Perseguers
Reviewed-by: Björn Pedersen
Tested-by: Xavier Perseguers
8 years ago[TASK] XLIFF: Add translation hint to labels, which must not be
Christopher Stelmaszyk [Wed, 31 Aug 2011 05:33:39 +0000 (07:33 +0200)]
[TASK] XLIFF: Add translation hint to labels, which must not be
translated

In the Core there are several labels, which contain strings, which
must not be translated. However, people on the Translation Server
translate them as sentences, which breaks functionality. The best
way to prevent this is to add translation hints to those labels
pointing out that they must not be changed.

Change-Id: Ibb765b53fc6093b087d22a1ba5f34efebd4db43b
Resolves: #29335
Reviewed-on: http://review.typo3.org/4708
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Dominique Feyer
Tested-by: Dominique Feyer
8 years ago[BUGFIX] High CPU load in IE8/9 when using context menu in htmlArea RTE
Stanislas Rolland [Thu, 1 Sep 2011 17:08:20 +0000 (13:08 -0400)]
[BUGFIX] High CPU load in IE8/9 when using context menu in htmlArea RTE

Cleanup event listeners.

Change-Id: I1280ec790a3b4c97c1b867b451b719f297bb625a
Resolves: #29361
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4733
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[BUGFIX] RTE context menu adds unwanted id attribute to target
Stanislas Rolland [Thu, 1 Sep 2011 14:04:44 +0000 (10:04 -0400)]
[BUGFIX] RTE context menu adds unwanted id attribute to target

The context menu plugin uses Ext.get on the target element. ExtJs thus adds an unwanted id attribute to content.

Solution: Use Ext.fly rather than Ext.get.

Change-Id: Id91f6dfa4ed7a1f5f2591eb7ff2e24ba594fedc2
Resolves: #29421
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4720
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[BUGFIX] Incorrect behaviour of style selector in RTE
Stanislas Rolland [Wed, 24 Aug 2011 15:15:08 +0000 (11:15 -0400)]
[BUGFIX] Incorrect behaviour of style selector in RTE

When all classes allowed on an element have been assigned to a single
element, the block/text style selector becomes disabled. It is then not
possible to remove the assigned classes from this element.

Change-Id: Ifc5ca8e4fc07c8627a07fe94854ceda056b2e557
Resolves: #27801
Releases: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/4572
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[TASK] Set TYPO3 version to 4.6-dev
TYPO3 v4 Release Team [Tue, 30 Aug 2011 12:37:21 +0000 (14:37 +0200)]
[TASK] Set TYPO3 version to 4.6-dev

Change-Id: I30e3d3cadcbb04c6038f64193c573b9ad7be4342
Reviewed-on: http://review.typo3.org/4682
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
8 years ago[RELEASE] Release of TYPO3 4.6.0beta2
TYPO3 v4 Release Team [Tue, 30 Aug 2011 12:37:13 +0000 (14:37 +0200)]
[RELEASE] Release of TYPO3 4.6.0beta2

Change-Id: I67fda92ae7fb9b161c17a0c9b8d4df1876ec7fbf
Reviewed-on: http://review.typo3.org/4681
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
8 years ago[TASK] Change dimension of extjs message icons from 16x16 to 32x32
Kay Strobach [Thu, 4 Aug 2011 17:04:27 +0000 (19:04 +0200)]
[TASK] Change dimension of extjs message icons from 16x16 to 32x32

This changeset just increases the width and height of the icons in
Ext.Msg based messages to make the type of the message better
noticeable.

Fabien Udriot has created the icons - thanks.

Resolves: #28772
Releases: 4.6

Change-Id: I3c3c48ec51abb50657ae3bf8f5ff7dc799b1380b
Reviewed-on: http://review.typo3.org/4154
Reviewed-by: Fabien Udriot
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Oliver Hader
8 years ago[TASK] Raise submodule pointer
TYPO3 v4 Release Team [Tue, 30 Aug 2011 12:24:28 +0000 (14:24 +0200)]
[TASK] Raise submodule pointer

Change-Id: I53b389b9dd17b5c6ac3f73e75313e2f0d71d0dfd
Reviewed-on: http://review.typo3.org/4680
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
8 years ago[BUGFIX] Bring back recStatInfoHooks hook in Page Tree
Georg Ringer [Tue, 30 Aug 2011 12:03:14 +0000 (14:03 +0200)]
[BUGFIX] Bring back recStatInfoHooks hook in Page Tree

There was a hook 'recStatInfoHooks' in class.webpagetree.php, which is
missing in the current implementation with ExtJS.

Change-Id: I5cae926c7cfe623ba945e9a044b2d4128d889df4
Resolves: #27247
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/2546
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] Cannot use own translation with XLIFF
Xavier Perseguers [Mon, 29 Aug 2011 06:55:55 +0000 (08:55 +0200)]
[BUGFIX] Cannot use own translation with XLIFF

XLIFF files contains the definition for a single language. Additional languages cannot
be stored as when using ll-XML (locallang*.xml) files.

Allow localization files to be stored next to the main locallang*.xlf file, by prefixing
its name with the language key, just as for localization files retrieved from TYPO3
translation server.

Change-Id: If930350527077be33bdbeced9672f13793d1d8f4
Fixes: #29248
Releases: 4.6
Reviewed-on: http://review.typo3.org/4601
Reviewed-by: Björn Pedersen
Reviewed-by: Dominique Feyer
Tested-by: Dominique Feyer
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] Externally-referenced ll-XML files are not parsed
Xavier Perseguers [Mon, 29 Aug 2011 07:41:24 +0000 (09:41 +0200)]
[BUGFIX] Externally-referenced ll-XML files are not parsed

It is not possible to load an externally-referenced localization file
as explained in the documentation:

<languageKey index="fr">EXT:yourext/path/to/fr.locallang.xml</languageKey>

Change-Id: I2461a77c98779165bf6a39b0d73fdda4984a1399
Fixes: #29313
Releases: 4.6
Reviewed-on: http://review.typo3.org/4651
Reviewed-by: Dominique Feyer
Tested-by: Dominique Feyer
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[TASK] Merge linkvalidator for beta2
Philipp Gampe [Tue, 30 Aug 2011 06:46:46 +0000 (08:46 +0200)]
[TASK] Merge linkvalidator for beta2

Changes:
0c69001 [TASK] Release linkvalidator 1.0.4
defb32e [TASK] Fix phpdoc and method signatures
2f1f5e0 [BUGFIX] Fatal error with E_STRICT: Declarations of
fetchType and checkLink must be compatible with interface
64769ad [BUGFIX] XLIFF: Approved attribute is on wrong element
11b6535 [TASK] Unify table layouts
fb76d81 [TASK] Update ChangeLog
5096f76 [TASK] Refactor to t3lib_http_Request for external URLs
ad08acf [TASK] Add XLIFF files
267122e [TASK] Fix localization handling to support XLIFF
2a9f3ff [TASK] Merge changes from 4.5 upstream to master
6b026f3 [BUGFIX] Correct initialisation of BACK_PATH
79e5177 [TASK] Add .gitignore file.

Change-Id: I9efee664ffeb5174f8d5c382411d1b1abc6a26a4
Resolves: #29339
Releases: 4.6
Reviewed-on: http://review.typo3.org/4673
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] Fix HTTP Request Exceptions with SSL certificates
Philipp Gampe [Sun, 31 Jul 2011 18:46:15 +0000 (20:46 +0200)]
[BUGFIX] Fix HTTP Request Exceptions with SSL certificates

HTTP_Request2 expects the default value for ssl_cafile, ssl_capath,
ssl_local_cert and ssl_passphrase to be NULL, and not ''.

As the Install Tool is not able to handle this, we need to check if
those values are empty and set them NULL accordingly.

Additionally the socket adapter has trouble with ssl_verify_peer.
Therefore change ssl_verify_peer to FALSE by default

Change-Id: I065c649a671d4360c9a51ab4be40fb0eb58d6ec6
Resolves: #28619
Reviewed-on: http://review.typo3.org/3949
Reviewed-by: Stefan Neufeind
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[TASK] Convert XLIFF files to Tab indentation
Steffen Gebert [Sun, 28 Aug 2011 15:46:53 +0000 (17:46 +0200)]
[TASK] Convert XLIFF files to Tab indentation

Change-Id: If71429224f5c1f79b497987b70135b96c2a5d86a
Reviewed-on: http://review.typo3.org/4636
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[TASK] Improve filename in *.t3d export
Mario Rimann [Tue, 16 Aug 2011 20:34:47 +0000 (22:34 +0200)]
[TASK] Improve filename in *.t3d export

Change the default date format in the filename when exporting
a T3D file to be YYYY-MM-DD_HH-MM in order to make the
exported files sortable.

Change-Id: Idc463cbf0e33757152dc7f906a49068d6827f097
Resolves: #28777
Releases: 4.6
Reviewed-on: http://review.typo3.org/4383
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] RTE breaks mailto links in Firefox
Stanislas Rolland [Mon, 29 Aug 2011 16:22:36 +0000 (12:22 -0400)]
[BUGFIX] RTE breaks mailto links in Firefox

mailto link are incorrectly prefixed with base url

Change-Id: If97e99143666428dfced2bb7e129e1494c84f17e
Resolves: #29141
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4666
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[TASK] Improve description of $TYPO3_CONF_VARS['SYS']['no_pconnect']
Christopher [Sun, 28 Aug 2011 17:58:33 +0000 (19:58 +0200)]
[TASK] Improve description of $TYPO3_CONF_VARS['SYS']['no_pconnect']

Improve the description of $TYPO3_CONF_VARS['SYS']['no_pconnect'],
so that people at least get a keyword, which they can put into
Google, when they don't know, what to set here.

Change-Id: Ifde0587bdc9bf554b5f8497c7aae05347349ba2e
Resolves: #29304
Reviewed-on: http://review.typo3.org/4642
Reviewed-by: Kestutis
Tested-by: Kestutis
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] HTMLparser, treat fixAttrib.unset as boolean
Markus Klein [Thu, 25 Aug 2011 18:12:37 +0000 (13:12 -0500)]
[BUGFIX] HTMLparser, treat fixAttrib.unset as boolean

HTMLparser_tags fixAttrib.unset is documented to be boolean, but is
currently treated as string.
This patch corrects for the expected behavior.

Change-Id: I608debf23280dd7d3816fe1ee05421cc88efc752
Resolves: #29246
Releases: 4.6, 4.5, 4.4, 4.3
Reviewed-on: http://review.typo3.org/4605
Reviewed-by: Christopher
Tested-by: Christopher
Reviewed-by: Egbert van der Hout
Reviewed-by: Björn Pedersen
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
8 years ago[BUGFIX] Add DB structure update pre-processing hook in EM
Xavier Perseguers [Fri, 26 Aug 2011 10:04:27 +0000 (12:04 +0200)]
[BUGFIX] Add DB structure update pre-processing hook in EM

Extension Manager lacks a way to perform actions prior to modifying the database
structure (create new tables or add additional fields in existing ones) when
installing an extension.

This would be very handy for DBAL to let user update mapping definition from within
TYPO3 without the need to first manually edit typo3conf/localconf.php.

This is a bugfix as the feature had been accepted for 4.5.0beta1 and was wrongly
removed during Extension Manager refactoring task. In fact, the interface is still
here but never used.

Change-Id: I4de8490a6ad61f0068525fda07f41a8601be9c6c
Fixes: #23877
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4614
Reviewed-by: Björn Pedersen
Reviewed-by: Philipp Gampe
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
8 years ago[BUGFIX] Message about missing db credentials is misleading
Christopher [Sat, 27 Aug 2011 16:24:11 +0000 (18:24 +0200)]
[BUGFIX] Message about missing db credentials is misleading

If persistent connections are not allowed by MySQL the error message "Can only
select database if username/password/host is correctly set first." is shown.
Add an explanation that $TYPO3_CONF_VARS['SYS']['no_pconnect'] must be set 0
if persistent connections are not allowed.

Change-Id: I28f373c1e771f00d1584eff5080bfa51cf48ed96
Fixes: #29245
Releases: 4.6
Reviewed-on: http://review.typo3.org/4633
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
8 years ago[BUGFIX] Check for PHP 5.3
Wouter Wolters [Sat, 27 Aug 2011 12:14:33 +0000 (14:14 +0200)]
[BUGFIX] Check for PHP 5.3

Minimum PHP version to check for is now 5.3. The fix for the exec()
function in PHP lower than 5.3 on Windows is removed.

Change-Id: I62530c75ebbed592bbf0a6503ccadd229bb1c923
Fixes: #29285
Releases: 4.6
Reviewed-on: http://review.typo3.org/4630
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
8 years ago[BUGFIX] 'Update settings' button does not work in new em
Susanne Moog [Mon, 22 Aug 2011 18:55:28 +0000 (20:55 +0200)]
[BUGFIX] 'Update settings' button does not work in new em

After installing an extension you get a popup where you can
update the configuration settings of an extension. In the new
extension manager the update button there will not work as it
is a submit button but the form around the fields is missing.

Attached patch simply inserts the form in this case, too.

Change-Id: I9c4d5c1f1b84f1b6d7c3e1e1be33ee63752d09e9
Resolves: #29172
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4536
Reviewed-by: Björn Pedersen
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] XLIFF: Approved attribute is on wrong element
Xavier Perseguers [Fri, 26 Aug 2011 07:41:41 +0000 (09:41 +0200)]
[BUGFIX] XLIFF: Approved attribute is on wrong element

Attribute "approved" is currently put on "target" element instead
of "trans-unit".

Change-Id: I550eebbdcd549ada4a00c9cba4e45f690262381e
Fixes: #29262
Releases: 4.6
Reviewed-on: http://review.typo3.org/4607
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] Livesearch does not find all pages
Udo Leimberger [Mon, 22 Aug 2011 06:19:34 +0000 (08:19 +0200)]
[BUGFIX] Livesearch does not find all pages

If you are a BE user with various mount points (no admin), live search
does not find all pages.

Change-Id: Ie4c9c41f65d8a84722fa3847921912c7fb5a18f1
Resolves: #29086
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4460
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[TASK] Streamline class prefix handling in the core
Susanne Moog [Mon, 22 Aug 2011 15:53:51 +0000 (17:53 +0200)]
[TASK] Streamline class prefix handling in the core

At the moment the frontend option userFuncClassPrefix is also checked in
various backend scenarios (for example the registry) and in general
everywhere t3lib_div::hasValidPrefix is called. Therefore it should be a system
option. Additionally to ensure "user_" is working as a prefix this was given
hardcoded as additionalPrefix to the function in some cases.

This patch streamlines the handling of prefixes, introduces a [SYS] option
additionalAllowedClassPrefixes, deprecates the [FE] option and allows
the prefixes 'tx_', 'Tx_', 'user_' and 'User_' by default.

Change-Id: I70fa89120dbe8c7790e3d6de4b173b69beb8a6f9
Resolves: #29166
Releases: 4.6
Reviewed-on: http://review.typo3.org/4526
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] exec_SELECTcountRows returns string
Georg Ringer [Tue, 23 Aug 2011 04:04:06 +0000 (06:04 +0200)]
[BUGFIX] exec_SELECTcountRows returns string

PHPdoc states that return value is either FALSE if
something strange happened or integer with the count of
records.

MySql returns strings, so an intval is needed to have integers

Change-Id: I521db73e7e9a85c2f616d869f50b3d012cdb1dcb
Resolves: #29169
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/4540
Reviewed-by: Oliver Klee
Reviewed-by: Xavier Perseguers
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[TASK] Fix invalid class reference in deprecation message
Xavier Perseguers [Wed, 24 Aug 2011 12:19:59 +0000 (14:19 +0200)]
[TASK] Fix invalid class reference in deprecation message

References to tx_lang_parser_* should be replaced by t3lib_l10n_parser_*

Change-Id: I529227db91a126ccea25b58211c381c3c5d429f7
Reviewed-on: http://review.typo3.org/4565
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] INTincScript_process: array check too late
Bjoern Pedersen [Mon, 8 Aug 2011 11:20:28 +0000 (13:20 +0200)]
[BUGFIX] INTincScript_process: array check too late

The array check for the configuration has been moved before
the first usage.

Change-Id: Ia1355206b2a2e7bdc1cfa9b15402abb2ef3f36d5
Resolves: #28833
Releases: 4.6
Reviewed-on: http://review.typo3.org/4215
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[BUGFIX] Extension Manager Cleanup
Steffen Kamper [Tue, 2 Aug 2011 09:02:21 +0000 (11:02 +0200)]
[BUGFIX] Extension Manager Cleanup

Beside some type hintings and indent correction there is now a check
in response for timeout with fetching translation, so the UI is not
blocked anymore if a timeout occurs.

Change-Id: I670a2df4fddab0be6b0cb05e69e009c08db5e1fa
Resolves: #28667
Reviewed-on: http://review.typo3.org/4012
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Clean up API of t3lib_cache
Christian Kuhn [Mon, 22 Aug 2011 18:11:40 +0000 (20:11 +0200)]
[BUGFIX] Clean up API of t3lib_cache

This cleans up some loose ends of the caching framework by default patch series
for 4.6: Some methods in t3lib_cache are not static and there is still a check
for isCachingFrameworkInitialized() in tcemain.

Change-Id: I5725672849db185eaa6683ee9749cc9295d4ef01
Resolves: #29171
Reviewed-on: http://review.typo3.org/4529
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[TASK] Move aboutmodules files into extension directory
Steffen Kamper [Tue, 2 Aug 2011 11:56:56 +0000 (13:56 +0200)]
[TASK] Move aboutmodules files into extension directory

There are two classes in typo3 directory which belong to the "aboutmodules" module:
alt_intro.php
class.alt_menu_functions.inc

Move them into the extension's directory, cleanup a bit and use the module
dispatcher to call the module.

Change-Id: I2c398d985339bd1b35d15755cfec43b6e2c42eb5
Resolves: #28676
Reviewed-on: http://review.typo3.org/4021
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[CLEANUP] Remove code duplication in saltedpasswords
Andreas Wolf [Mon, 6 Jun 2011 21:12:45 +0000 (23:12 +0200)]
[CLEANUP] Remove code duplication in saltedpasswords

There is some duplicate code in tx_saltedpasswords_sv1::authUser().
This patch removes the code, making it more readable.

Change-Id: Ie461059bcc699936774a8e41475a9cbbc98d9606
Resolves: #29157
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/3039
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[BUGFIX] Remove check for invalid prefix in addService
Christian Kuhn [Mon, 22 Aug 2011 14:53:17 +0000 (16:53 +0200)]
[BUGFIX] Remove check for invalid prefix in addService

t3lib_extMgm::addService() checks that $serviceType (eg. 'auth') does not start
with a valid class prefix. While it is probably not a good idea to prefix a
service type with 'user_' or 'tx_', there is no technical reason to enforce
this. The check especially leads to problems if
TYPO3_CONF_VARS['FE']['userFuncClassPrefix'] is set to an empty string.
This patch removes the check.

Change-Id: I078078eef5147cb267483a0d8d04ab113a24f7e9
Resolves: #29165
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/4525
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[TASK] Remove array duplication in T3_SERVICES
Christian Kuhn [Mon, 22 Aug 2011 14:43:13 +0000 (16:43 +0200)]
[TASK] Remove array duplication in T3_SERVICES

These informations are important for a service:

* Extension name of a service implementation (e.g. 'saltedpasswords')
* Service type (eg. 'auth')
* Class implementing the service
  (service key, e.g. 'tx_saltedpasswords_sv1').

t3lib_extMgm::addService() registers a service in global array
$T3_SERVICES[type][key].
Additionally it registers the same service as $T3_SERVICES[key][key].

The latter registration is actually never used by any other service
method in the core and can be removed to simplify this handling.

Change-Id: I2c8c53bb763b0a41e5c2488bbcef96f7e1505c9f
Resolves: #29164
Reviewed-on: http://review.typo3.org/4522
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[TASK] Use autoloader in rsaauth system extension
Helmut Hummel [Mon, 22 Aug 2011 00:51:28 +0000 (02:51 +0200)]
[TASK] Use autoloader in rsaauth system extension

Resolves: #29142
Releases: 4.6

Change-Id: I5ee0161a49d22c9d29b82bebfce6a16d3f1a439d
Reviewed-on: http://review.typo3.org/4461
Reviewed-by: Georg Ringer
Reviewed-by: Xavier Perseguers
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[BUGFIX] Fix isAbsPath() on Windows
Daniel Hoffmann [Mon, 25 Jul 2011 06:45:42 +0000 (08:45 +0200)]
[BUGFIX] Fix isAbsPath() on Windows

Paths starting with a slash are absolute on Windows, too.

Change-Id: Ie34449b8fc9f5e5a203044457baa64283412cf66
Resolves: #16798
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/3712
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] Broken links representation gets saved to the database
Stanislas Rolland [Mon, 15 Aug 2011 20:25:28 +0000 (16:25 -0400)]
[BUGFIX] Broken links representation gets saved to the database

Solution: Avoid wrapping the a tag with span tag when style attribute
is set when rteerror attribute is also set.

Change-Id: I0f517b9f01deec05c9d31661a5fcf13f60ea0d37
Resolves: #25302
Releases: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/4351
Reviewed-by: Georg Ringer
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[BUGFIX] TYPO3 tries to connect to typo3.org on every login
Susanne Moog [Sun, 21 Aug 2011 15:42:31 +0000 (17:42 +0200)]
[BUGFIX] TYPO3 tries to connect to typo3.org on every login

The extension manager tries to establish a connection to the TER
as soon as user credentials for a user are given.

This patch changes that behavior so that it is only done for
the functions that actually need a TER call.

Additionally I did some cleanup.

Change-Id: I4424f71d1b645ffdb46b3319409a48dbe00c7e70
Resolves: #28949
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/4453
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Labels of modules extending t3lib_extobjbase not loaded
Christian Kuhn [Sun, 21 Aug 2011 12:53:13 +0000 (14:53 +0200)]
[BUGFIX] Labels of modules extending t3lib_extobjbase not loaded

Modules that extend t3lib_extobjbase currently do not show any label.
Affected are for example the function wizards like sort pages and sub modules
of the info module like info_pagetsconfig. The patch fixes this by changing
t3lib_extobjbase to look for .xlf files as well.

Change-Id: Id7faa5bb7e125b1857b07c28df561a760752e9ad
Resolves: #29134
Reviewed-on: http://review.typo3.org/4447
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[BUGFIX] t3lib_lock: Clean up constructor and add unit tests
Christian Kuhn [Sun, 21 Aug 2011 09:28:13 +0000 (11:28 +0200)]
[BUGFIX] t3lib_lock: Clean up constructor and add unit tests

t3lib_lock can be cleaned up a bit: The constructor currently returns values
which is impossible, one error case is turned into an exception.
The constructor is additionally covered with unit tests.

Change-Id: I86b2d7e2c1329cefd6a00952c9a024fd926d5abf
Resolves: #29132
Reviewed-on: http://review.typo3.org/4444
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[BUGFIX] Setting userFuncClassPrefix to empty string does not work
Susanne Moog [Sun, 21 Aug 2011 09:40:29 +0000 (11:40 +0200)]
[BUGFIX] Setting userFuncClassPrefix to empty string does not work

Setting $GLOBALS['TYPO3_CONF_VARS']['FE']['userFuncClassPrefix']
to an empty string - to allow all prefixes - does not work as
expected as the check in t3lib_div expects a valid string with
length > 0. Adjust t3lib_div::hasValidClassPrefix to also
allow empty prefix var.

Change-Id: Idbd8cf7a547d9549f1c31dadd731eda48f52fcec
Resolves: #29133
Releases: 4.6
Reviewed-on: http://review.typo3.org/4445
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Problems with Cardlayout
Kay Strobach [Mon, 8 Aug 2011 20:13:14 +0000 (22:13 +0200)]
[BUGFIX] Problems with Cardlayout

This fix contains several parts:

1. alt_file_navframe.php
   changed top.TYPO3.Backend.ContentContainer.setUrl()
   to new function
   top.TYPO3.ModuleMenu.App.openInContentFrame()

   This fix solves the problem in the filemodule

2. iframepanel.js
   added small delay to ensure, that the panel is rendered with correct
   size before applying the mask (force centering of loading indicator)

3. modulemenu.js
   make tree detect changed ids

4. modulemenu.js
   refactoring of the following functions:
   - loadModuleComponents
   - openInContentFrame
   this has been done to reduce redundant code

Change-Id: Ibccd5d6880e1e957d5de232fdc8f4ad168cd16ab
Resolves: #28851
Releases: 4.6
Reviewed-on: http://review.typo3.org/4299
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Fix security level "normal" for backend login
Helmut Hummel [Sat, 20 Aug 2011 17:02:45 +0000 (19:02 +0200)]
[BUGFIX] Fix security level "normal" for backend login

Only change the object property to something different than "superchallenged"
if the configuration is not set to a "standard" security level.

Resolves: #29130
Releases: 4.6, 4.5, 4.4, 4.3

Change-Id: Ibf1194d04a7159ade9ef33701e92930f98cfb90e
Reviewed-on: http://review.typo3.org/4452
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Add admin-note to tab-description of extension-manager
Stefan Neufeind [Sun, 21 Aug 2011 14:47:42 +0000 (16:47 +0200)]
[BUGFIX] Add admin-note to tab-description of extension-manager

All other admin-modules already have this under "About modules".

Change-Id: I54cc1ee2d3505f797623b5b9708174ee3e9df50e
Resolves: #21528
Reviewed-on: http://review.typo3.org/2788
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[BUGFIX] sys_action: Fix Record List page switching
Thomas Maroschik [Sun, 21 Aug 2011 12:22:04 +0000 (14:22 +0200)]
[BUGFIX] sys_action: Fix Record List page switching

If a list-records-task lists more than 100 records, the singe table page turning
functionality is shown on top of the table. If you want to switch the page (or
enter a page number) nothing happens or you get elsewhere than you are supposed
to be.

This happens due to wrong link generation. The Listmodule has been refactored, but the
sys_actions Module stayed the same. Link generation was broken.

This patch fixes the issues with sys_actions and list link generation by subclassing
the localRecordList class and adopting the link generation to sys_actions needs.

Change-Id: Ie84ec59ce632dbe4a74df8236eab777b23f3bd53
Resolves: #23567
Reviewed-on: http://review.typo3.org/2992
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[TASK] Use a larger preview image in show_item (launchView)
Felix Kopp [Sat, 13 Aug 2011 20:43:08 +0000 (22:43 +0200)]
[TASK] Use a larger preview image in show_item (launchView)

Increase the size of the image in show_item (launchView).
This window is displayed when a image in list or file_list is clicked.

Change-Id: I5b347a15c04b082b015d99fb2e80d486667a3398
Resolves: #28963
Releases: 4.6
Reviewed-on: http://review.typo3.org/4307
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[TASK] Increase size of thumbnails
Felix Kopp [Sat, 13 Aug 2011 20:59:55 +0000 (22:59 +0200)]
[TASK] Increase size of thumbnails

Increase the size of thumbnails (page, list, filelist) from 54x54px to 64x64px.

Change-Id: Ia830771e2e630d1fb5e4f624220cb6504ceb98a1
Resolves: #29136
Releases: 4.6
Reviewed-on: http://review.typo3.org/4309
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[TASK] Use proper localization API
Xavier Perseguers [Wed, 17 Aug 2011 07:22:32 +0000 (09:22 +0200)]
[TASK] Use proper localization API

Use of TYPO3.lang has been deprecated. Use TYPO3.l10n.localize() instead.

Change-Id: I68f968df3f3d105ee566987c000e3dafb97b9fe3
Resolves: #29028
Releases: 4.6
Reviewed-on: http://review.typo3.org/4388
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[TASK] Remove usage counts in method comments
Christian Kuhn [Sun, 21 Aug 2011 13:24:54 +0000 (15:24 +0200)]
[TASK] Remove usage counts in method comments

Issue #27985 removed the function indexes from class files and most
usage counts from method comments. This patch removes some missing matches.

Change-Id: Id53769839517e50b977cc01d7f6008beb74b5896
Resolves: #29135
Reviewed-on: http://review.typo3.org/4449
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[BUGFIX] Remove cache_pages from table garbage collection task
Christian Kuhn [Sun, 21 Aug 2011 11:54:56 +0000 (13:54 +0200)]
[BUGFIX] Remove cache_pages from table garbage collection task

table cache_pages does not exist anymore and must is removed from
the default configuration of the task.

Change-Id: I328c624bc328f99a93fa895ff54a668a16099aa8
Resolves: #29131
Reviewed-on: http://review.typo3.org/4446
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[TASK] Clean up API of tx_scheduler_CronCmd_Normalize
Christian Kuhn [Thu, 18 Aug 2011 22:42:15 +0000 (00:42 +0200)]
[TASK] Clean up API of tx_scheduler_CronCmd_Normalize

The only public API method in tx_scheduler_CronCmd_Normalize is normalize().
The patch makes all non API methods protected and uses an accessible proxy
class in unit tests to make the low level methods testable. This cleans
up the API and still gives detailed unit tests.

Change-Id: I6845d049523b68e6f57d86ad03ef0a48c453df81
Resolves: #29100
Reviewed-on: http://review.typo3.org/4421
Reviewed-by: Björn Pedersen
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Clean up caching framework garbage collection task
Christian Kuhn [Fri, 19 Aug 2011 12:23:27 +0000 (14:23 +0200)]
[BUGFIX] Clean up caching framework garbage collection task

Clean up some obsolete code from the garbage collection task since the
caching framework was enabled by default. Additionally fixes the
additional fields provider to find registered cache backends.

Change-Id: I242a9ccb904f9e692025336a6e302df673078050
Resolves: #28062
Reviewed-on: http://review.typo3.org/4427
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[BUGFIX] feedit: Use skinImage for edit icons
Bjoern Pedersen [Thu, 21 Jul 2011 09:19:24 +0000 (11:19 +0200)]
[BUGFIX] feedit: Use skinImage for edit icons

Replace hardcoded icons with t3lib_iconWorks::skinImage calls

Change-Id: I02236b36facb53222ccc8e0bfc17adf7b2ac7ae4
Resolves: #24920
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/3448
Reviewed-by: Steffen Kamper
Tested-by: Steffen Kamper
Reviewed-by: Stefan Neufeind
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[BUGFIX] After merge of #29029 flexform display is broken
Susanne Moog [Sat, 20 Aug 2011 09:53:41 +0000 (11:53 +0200)]
[BUGFIX] After merge of #29029 flexform display is broken

After #29029 flexforms display is broken because of the added
display:inline-block. Fix it by changing it for flexforms
back to display:block.

Change-Id: I020ad66647c1abc2958a201a61f51eaecdfdafbb
Resolves: #29126
Releases: 4.6
Reviewed-on: http://review.typo3.org/4433
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Also check if cache files are not empty
Jigal van Hemert [Thu, 18 Aug 2011 21:23:10 +0000 (23:23 +0200)]
[BUGFIX] Also check if cache files are not empty

If the temp_CACHED* files exist, but they are empty a lot of functions
produce incorrect result due to missing TCA data. Checking the fileSize
prevents the use of empty cache files.

Change-Id: I855034048eca142153badd2567fb2bf6dfbc2629
Resolves: #29075
Branches: 4.6, 4.5, 4.4, 4.3
Reviewed-on: http://review.typo3.org/4420
Reviewed-by: Björn Pedersen
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Some TCEforms elements are displaced
Francois Suter [Wed, 17 Aug 2011 08:50:55 +0000 (10:50 +0200)]
[BUGFIX] Some TCEforms elements are displaced

When a TCEforms field is part of a palette, a specific span tag
is added around it. A similar span tag must be added around fields
which are not part of a palette, so that we have similar behaviors.

Change-Id: If13c130423c4839b89c7f03e015feffd8ae3bd94
Resolves: #29029
Related: #28030
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/4390
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[BUGFIX] Suggest wizard missing in FE users / groups
Jigal van Hemert [Thu, 18 Aug 2011 17:17:59 +0000 (19:17 +0200)]
[BUGFIX] Suggest wizard missing in FE users / groups

For the redirect page field in the records for FE users and FE groups
the suggest wizard is missing.

Change-Id: I2d65f2d0215b38ed39df70ee33a0b504849bae2d
Resolves: #21723
Branches: 4.6, 4.5
Reviewed-on: http://review.typo3.org/4411
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] "New record" button in Template mod broken
Jigal van Hemert [Thu, 18 Aug 2011 09:18:16 +0000 (11:18 +0200)]
[BUGFIX] "New record" button in Template mod broken

Recent browsers follow HTML5 standards for submitting image input
elements. The result is that the name of the image input element is
not submitted anymore, only the name with the x and y coordinates.
Checking for createExtension_x or createExtension being set makes the
button work again.

Change-Id: Id6424c44978be807c51bcdd842d11761d9aa947e
Resolves: #28455
Branches: 4.6, 4.5
Reviewed-on: http://review.typo3.org/4405
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[BUGFIX] Unify table layouts
Felix Kopp [Fri, 19 Aug 2011 08:44:45 +0000 (10:44 +0200)]
[BUGFIX] Unify table layouts

Tables are styled with different layouts. These are unified and follow the
standard style (list, page, …). Style was taken from db_list.
These tables are rebrushed:

* file_list: folder and file list
* Scheduler: tasks table and information table
* TS-analyzer: template overview
* Web > Info / pagetree overview
* Move element / position map

Change-Id: Ia563e49fdfc6a06c706d4004454168ee177fdc36
Resolves: #28188
Releases: 4.6
Reviewed-on: http://review.typo3.org/4318
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Autoloader Cache is not updated
Oliver Hader [Thu, 18 Aug 2011 18:51:58 +0000 (20:51 +0200)]
[BUGFIX] Autoloader Cache is not updated

The patch adds the current TYPO3 version to the cache identifier.
This ensures a new cache file if upgrading TYPO3.

Change-Id: I4fa47178016925f39ff2168f65afb1ae357be556
Resolves: #28589
Reviewed-on: http://review.typo3.org/3903
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[BUGFIX] starttime / endtime l10n_mode exclude in core tables
Stefan Neufeind [Mon, 1 Aug 2011 16:46:48 +0000 (18:46 +0200)]
[BUGFIX] starttime / endtime l10n_mode exclude in core tables

starttime/endtime can be set different in localisations
but are (usually) not respected. This patch modifies
the behaviour inside localisations to show a readonly
value of the original starttime/endtime-values.

Change-Id: If7e32b0c8a628698115c60ec570c2526e5bb3546
Resolves: #24211
Reviewed-on: http://review.typo3.org/3984
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Björn Pedersen
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog