Packages/TYPO3.CMS.git
23 months ago[FOLLOWUP][TASK] EXT:form - change signal slots to hooks 88/52088/10
Ralf Zimmermann [Fri, 17 Mar 2017 16:46:07 +0000 (17:46 +0100)]
[FOLLOWUP][TASK] EXT:form - change signal slots to hooks

Resolves: #80333
Releases: master
Change-Id: I201392bc67228864e31d9e7117880fbb401af279
Reviewed-on: https://review.typo3.org/52088
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Jurian Janssen <jurian.janssen@gmail.com>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] EXT:form - change type of getRendererClassName() to string 97/51997/5
Martin Kutschker [Fri, 3 Mar 2017 23:12:51 +0000 (23:12 +0000)]
[BUGFIX] EXT:form - change type of getRendererClassName() to string

Fix incompatible return types of getRendererClassName()
Make sure it is a string in all interfaces and implementations.

Resolves: #80230
Releases: master
Change-Id: I59cd0a1222e3aa67c742ca41331af2ddc4a1ee51
Reviewed-on: https://review.typo3.org/51997
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Check if install tool enable file exists before removing it 00/52100/3
Michael Stucki [Mon, 20 Mar 2017 13:04:43 +0000 (14:04 +0100)]
[BUGFIX] Check if install tool enable file exists before removing it

The is_file() check got lost during the refactoring in
d855b4707ba1198b6c1dbf856c4377e230da4c4b.

Change-Id: Ia1688099a7ccd32667562e8c7f83fd54bb669f4a
Resolves: #80354
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/52100
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Cleanup FSC/CSC typoscript 95/52095/2
Josef Glatz [Sun, 19 Mar 2017 21:16:28 +0000 (22:16 +0100)]
[TASK] Cleanup FSC/CSC typoscript

* remove/update inline comments
* improve legibility by proper indentation and CGL

Resolves: #80346
Releases: master
Change-Id: I51207c0a54b18f78b1a0dd4313b398908ea2f021
Reviewed-on: https://review.typo3.org/52095
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] EXT:form - Render form name in form tree correctly 94/52094/3
Martin Kutschker [Sat, 4 Mar 2017 20:48:19 +0000 (20:48 +0000)]
[BUGFIX] EXT:form - Render form name in form tree correctly

Do not double-encode name with HTML entities.

Resolves: #80343
Releases: master
Change-Id: If8e3757f0d34712f0daf03122e61b6ef06a1ccd0
Reviewed-on: https://review.typo3.org/52094
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Do not compile parent config in inline ajax controller 77/52077/4
Christian Kuhn [Fri, 17 Mar 2017 11:14:29 +0000 (12:14 +0100)]
[BUGFIX] Do not compile parent config in inline ajax controller

Using the signed parent tca config incoming via ajax request in the
inline ajax controller solves a series of issues in 'new' and other
scopes.
The expensive calculation of inline parent TCA config within the
controller can be dropped.

Change-Id: I4ff31d0398ebfa1bb311bbe6ea97c839aa2df1ac
Resolves: #80325
Resolves: #76671
Releases: master
Reviewed-on: https://review.typo3.org/52077
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Use correct language sorting in TCA field language of pages_language_overlay 99/52099/2
Georg Ringer [Mon, 20 Mar 2017 12:34:40 +0000 (13:34 +0100)]
[TASK] Use correct language sorting in TCA field language of pages_language_overlay

Since #77652 the languages are sorted manually using a sorting field. Use this
field also in the language selection of pages_language_overlay.

Resolves: #80351
Releases: master
Change-Id: I490aa5c477cc2c45110a658e05b42e75f0528610
Reviewed-on: https://review.typo3.org/52099
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Remove l10n_cat leftover 86/52086/3
Christian Kuhn [Fri, 17 Mar 2017 16:02:23 +0000 (17:02 +0100)]
[TASK] Remove l10n_cat leftover

TCA property l10n_cat has been there since ever and nobody understood it.
The docs about it never said what it really does and the according arguments
from EditDocumentController were never used.
The patch removes l10n_cat and some left over handling in
EditDocumentController.
Do not confuse this l10n_cat related localizationMode text/media with the
localizationMode select/keep from inline: The inline part is not touched
by the patch.

Change-Id: Ia7b54bddabffcad3e38df76731d7fe9f6b8ff40f
Resolves: #80331
Releases: master
Reviewed-on: https://review.typo3.org/52086
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Typo3Status Report checks for Compatibility6 96/52096/2
Thomas Hohn [Mon, 20 Mar 2017 05:40:30 +0000 (06:40 +0100)]
[BUGFIX] Typo3Status Report checks for Compatibility6

Check for EXT:Compatibility7 instead of EXT:Compatibility6
in the Typo3Status Report.

Resolves: #80348
Releases: master
Change-Id: Iec4b7faa5eacd6007d0871278eeb23aa8e2b8448
Reviewed-on: https://review.typo3.org/52096
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] TCA field using MM table is incorrectly duplicates relations 78/51978/4
Georg Ringer [Tue, 7 Mar 2017 18:07:31 +0000 (19:07 +0100)]
[BUGFIX] TCA field using MM table is incorrectly duplicates relations

The previous change disabled the lookup on the parent UID which resulted
in getting all possible relations due to the missing constraint. Now the
behavior is mitigated by resetting non-numeric values to zero which will
lead to an empty result set - like implicitly for MySQL before.

Resolved: #80172
Releases: master
Change-Id: If6c8d2e3b2c2b2ddf15727196f7da294fe2ada06
Reviewed-on: https://review.typo3.org/51978
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Marcus Schwemer <ms@schwemer.de>
Tested-by: Marcus Schwemer <ms@schwemer.de>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[TASK] Deprecate further l10n_mode usages 13/52013/3
Oliver Hader [Sun, 12 Mar 2017 15:23:24 +0000 (16:23 +0100)]
[TASK] Deprecate further l10n_mode usages

This change is focussed on runtime processing of l10n_mode
which is not required anymore. Thus accordant internal
functionality is deprecated.

Change-Id: I19b8eabdfc98bfe83ff80d8205b0c9f029330ed5
Resolves: #80345
Releases: master
Reviewed-on: https://review.typo3.org/52013
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Deprecate inline localizationMode 50/51650/4
Oliver Hader [Sun, 12 Feb 2017 21:16:26 +0000 (22:16 +0100)]
[TASK] Deprecate inline localizationMode

TCA type's inline localizationMode can either be "keep" or "select".
At least "keep" is counter-productive if allowLanguageSynchronization
is enabled. That's why the whole localizationMode behaviour setting
shall be deprecated and ignored in case allowLanguageSynchronization
is enabled for the very same TCA field.

This change does not migrate non-conflicting localizationMode settings
automatically, since this potentially might be breaking and cannot be
done without side-effects. Besides that calls to the static function
BackendUtility::getInlineLocalizationMode() do not trigger a new entry
in the deprectation log since the usage of localizationMode in TCA is
logged already.

Resolves: #79770
Releases: master
Change-Id: Ic2072877d08bb880e9e957d6d31f0527333c2cc5
Reviewed-on: https://review.typo3.org/51650
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Remove inline styles from parsed blockquote tag 59/52059/6
Gianluigi Martino [Wed, 15 Mar 2017 15:20:05 +0000 (16:20 +0100)]
[TASK] Remove inline styles from parsed blockquote tag

The inline styles were removed from CSS Styled Content
but not in Fluid Styled Content.

Now this is also removed in EXT:fluid_styled_content.

Releases: master
Resolves: #80171
Change-Id: I91343b803d6da0b651b6984c8c94c2583730aa40
Reviewed-on: https://review.typo3.org/52059
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
2 years ago[TASK] Implement conflict handling into renameFile() 48/52048/14
Anja Leichsenring [Wed, 15 Mar 2017 09:33:10 +0000 (10:33 +0100)]
[TASK] Implement conflict handling into renameFile()

Upon DuplicationBehaviour::RENAME and ~::REPLACE, the according function
is called for the given file. For DuplicationBehaviour::CANCEL, the same
exception as before is thrown.

For a better UX, the existance of a possible duplicate is checked and a
modal window is rendered to the users to let them choose the desired
action if a duplicate was found.

Resolves: #80282
Releases: master
Change-Id: Ie67f04184a232fc23a3cda648692783771ba5171
Reviewed-on: https://review.typo3.org/52048
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Allow requireJsModules from FormEngine fieldControl 85/52085/3
Christian Kuhn [Fri, 17 Mar 2017 15:19:56 +0000 (16:19 +0100)]
[BUGFIX] Allow requireJsModules from FormEngine fieldControl

While the two NodeExpansion API's allow the usual returnArray
from single expansion nodes, fieldControl does not, due to its
restricted format.
The patch improves the single return value result merging and adds
support especially for 'requireJsModules' to fieldControl.

Change-Id: I7b8e44076aadd27fa5b9780ff97c1bab7141b55f
Resolves: #80330
Releases: master
Reviewed-on: https://review.typo3.org/52085
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Support valuePicker in colorpicker 90/52090/8
Christian Kuhn [Fri, 17 Mar 2017 18:37:48 +0000 (19:37 +0100)]
[TASK] Support valuePicker in colorpicker

Add the 'valuePicker' functionality to the colorpicker. This is useful
for editors to have a series of defaults. A similar configuration worked
in the past based on 'select' wizard.

Example TCA from styleguide master input_37:
    'config' => [
        'type' => 'input',
        'renderType' => 'colorpicker',
        'size' => 10,
        'valuePicker' => [
            'items' => [
                [ 'blue', '#0000FF', ],
                [ 'red', '#FF0000', ],
                [ 'typo3 orange', '#FF8700', ],
            ],
        ],
    ],

Change-Id: Idf24ecc1b47e84f6e4aa985191beebeb3631b202
Resolves: #80337
Releases: master
Reviewed-on: https://review.typo3.org/52090
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
2 years ago[TASK] EXT:form - set identifier for renderables 76/52076/2
Ralf Zimmermann [Fri, 17 Mar 2017 10:47:19 +0000 (11:47 +0100)]
[TASK] EXT:form - set identifier for renderables

Add method for setting the identifier for renderables.

Resolves: #80319
Releases: master
Change-Id: I9103068aef1b71eb86e589ddb7d107d7a738621e
Reviewed-on: https://review.typo3.org/52076
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Martin Kutschker <martin.kutschker@ymail.com>
Tested-by: Martin Kutschker <martin.kutschker@ymail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] EXT:form - move fixed template settings to configuration 05/52005/6
Ralf Zimmermann [Sat, 11 Mar 2017 12:02:55 +0000 (13:02 +0100)]
[TASK] EXT:form - move fixed template settings to configuration

Move this fluid form VH attributes into the EXT:form
configuration

* f:form -> additionalParams
* f:form -> addQueryString
* f:form -> argumentsToBeExcludedFromQueryString
* f:form -> action
* f:form -> enctype
* f:form -> method

Resolves: #80236
Releases: master
Change-Id: Id820e06678ec18ea6013c451ab5f42458863adb3
Reviewed-on: https://review.typo3.org/52005
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Martin Kutschker <martin.kutschker@ymail.com>
Tested-by: Martin Kutschker <martin.kutschker@ymail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Wrong header in 8.6 .rst file 87/52087/2
Christian Kuhn [Fri, 17 Mar 2017 16:11:10 +0000 (17:11 +0100)]
[BUGFIX] Wrong header in 8.6 .rst file

Deprecation should be Feature to fix the list on
https://docs.typo3.org/typo3cms/extensions/core/8-dev/Changelog/8.6/Index.html

Change-Id: Ic514b1adbb6e624ff9f740a0a9f020f848d7b0df
Resolves: #80332
Releases: master
Reviewed-on: https://review.typo3.org/52087
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FOLLOWUP][BUGFIX] l10n_state field is not created when installing an ext 81/52081/3
Oliver Hader [Fri, 17 Mar 2017 13:19:11 +0000 (14:19 +0100)]
[FOLLOWUP][BUGFIX] l10n_state field is not created when installing an ext

Fix PHPdoc comments of return types.

Change-Id: I58686de41b135694305ca146590cba1c66ee6716
Resolves: #80271
Releases: master
Reviewed-on: https://review.typo3.org/52081
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years agoRevert "[BUGFIX] Allow any navigation component to load in BE" 83/52083/4
Christian Kuhn [Fri, 17 Mar 2017 14:02:00 +0000 (15:02 +0100)]
Revert "[BUGFIX] Allow any navigation component to load in BE"

This reverts commit 51b5fad91efa5bef84bec16f3ae3738c382da5f1.

The patch introduced some delays and the acceptance tests fail,
reverted for now.

Change-Id: I2214932f4aadb8cb98c1e44752111dbaeaf04587
Resolves: #80328
Reverts: #80058
Releases: master
Reviewed-on: https://review.typo3.org/52083
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Escape dots of flexform field names 14/51014/3
Georg Ringer [Wed, 21 Dec 2016 11:47:06 +0000 (12:47 +0100)]
[BUGFIX] Escape dots of flexform field names

To make inline proper working in JS, the name of the field must be escaped
as it can contain dots.

Resolves: #78985
Releases: master, 7.6
Change-Id: I18c1d85906b9710c25b326b89e8104f3ea3c8a29
Reviewed-on: https://review.typo3.org/51014
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] validateRstFiles script: improve error message 68/52068/2
Josef Glatz [Thu, 16 Mar 2017 21:26:37 +0000 (22:26 +0100)]
[TASK] validateRstFiles script: improve error message

Improve the error message for non valid index keywords in
changelog RST files.

Resolves: #80310
Releases: master
Change-Id: Ibca4f135a7f43c7c936fd57c14b1f7b7fc0a9d1f
Reviewed-on: https://review.typo3.org/52068
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Use array_replace_recursive to merge columnsOverrides 74/52074/4
Christian Kuhn [Fri, 17 Mar 2017 09:58:27 +0000 (10:58 +0100)]
[TASK] Use array_replace_recursive to merge columnsOverrides

Merging columnsOverrides into columns in FormEngine data provider
TcaColumnsOverrides is done via ArrayUtility::mergeRecursiveWithOverrule()
which supports the '__UNSET' feature to kick array parts from the
original array.
This is problematic since TCA should be additive only, for instance
the 'isloaded' display condition has been removed for that reason, too.
Specific issue is here that using __UNSET stops working if there is
a second mergeRecursiveWithOverrule() later, for instance in the
element expansion classes. This leads to hard to track issues and
almost always does not end up with a result a developer expects.
Solution is switching to php built-in array_replace_recursive() instead
which does not do __UNSET magic.
In general, always only add things to the columns array in columnsOverrides,
columns should have the common dominator of all overrides. Disabling of
specific features can be done only by adding a new key 'disableFoo' = true
or similar, the according TCA feature has to explicitely support that.

Change-Id: Ieba262c899ae2df2e3aa2c63d7dfa6b86e3fa4f4
Resolves: #80321
Releases: master
Reviewed-on: https://review.typo3.org/52074
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] l10n_state field is not created when installing an extension 80/52080/3
Oliver Hader [Fri, 17 Mar 2017 12:23:59 +0000 (13:23 +0100)]
[BUGFIX] l10n_state field is not created when installing an extension

l10n_state fields are not created automatically when installing an
extension since there is no slot defined for the according signal
InstallUtility::tablesDefinitionIsBeingBuilt.

Change-Id: Ib4d05d3c3a2dde9b6d0a77f89dee650a3872544d
Resolves: #80271
Releases: master
Reviewed-on: https://review.typo3.org/52080
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Streamline EXT:form code 72/51972/21
Benni Mack [Tue, 7 Mar 2017 07:45:35 +0000 (08:45 +0100)]
[TASK] Streamline EXT:form code

* Register "formvh:" as global namespace, simplifying the templates
* Remove formvh:be.pageRenderer and add the missing files to EXT:fluid
* Migrate callbacks to signal slots and deprecate the callbacks
* Fix plain mail viewhelper, and deprecated it as it can be done in
  Fluid directly
* Code cleanup (fix indention, unused variables etc.)
* Deprecate custom checkbox VH because the fluid bug is gone
* Change tx_form view properties to ".0" instead of ".5" to be in line
  with FSC
* Streamline fluid VH additionalAttributes usage; add compatibility for
  previous configuration; Add BE form editor auto migration
* Fix small JavaScript bugs
* Fix small configuration bugs

Resolves: #80301
Resolves: #80287
Releases: master
Change-Id: Icf68b8a9a6876805af7bf273735d3d30984136ed
Reviewed-on: https://review.typo3.org/51972
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix deprecation message of two GeneralUtility methods 71/52071/2
Mathias Brodala [Fri, 17 Mar 2017 08:58:33 +0000 (09:58 +0100)]
[BUGFIX] Fix deprecation message of two GeneralUtility methods

We're only deprecating these two methods, not the whole file.

Resolves: #80316
Releases: master
Change-Id: Ia1727c0996f53caa35d4755d2d5caa04bc48de46
Reviewed-on: https://review.typo3.org/52071
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] TCA selectTree ajax must not calculate display conditions 74/51574/9
Thorben Nissen [Wed, 8 Feb 2017 09:55:41 +0000 (10:55 +0100)]
[BUGFIX] TCA selectTree ajax must not calculate display conditions

Opening a record with a FormEngine field type='select' and
renderType='selectTree' just renders boilerplate HTML that triggers
an ajax request to fetch actual tree node data for each field.
The server side ajax controller reduces the TCA to contain only the field
the items should be calculated for to reduce parse times.
In flex form context, if now that tree field has a FIELD display condition,
the standard data group 'tcaDatabaseRecord' which calls 'all' providers fails,
since it can't find a database value of the condition target.

Solution is to create an own data provider group for this 'fetch tree data'
ajax context: This group contains only providers needed by the
'TcaSelectTreeItems' provider and ignores everything else, most importantly
the EvaluateDisplayConditions provider. Leaving out a series of other
not needed data providers gives an additional performance improvement
in this context.

Resolves: #79657
Releases: master
Change-Id: I29bdd659d5f5ee28f8ae017c47df0233abefd6f5
Reviewed-on: https://review.typo3.org/51574
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Resolve cross dep between EXT:backend and EXT:feedit 11/52011/4
Claus Due [Sun, 12 Mar 2017 13:26:22 +0000 (14:26 +0100)]
[TASK] Resolve cross dep between EXT:backend and EXT:feedit

This patch moves frontend-editing intialisation from the
EditDocumentController (EXT:backend) to a signal listener
in EXT:feedit. Step towards extracting EXT:feedit to TER.

Change-Id: I09a7e5a2205e7020e7145023d7d63c61d9be508c
Resolves: #80244
Releases: master
Reviewed-on: https://review.typo3.org/52011
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Return to content element after un-/hide 45/52045/3
Josef Glatz [Wed, 15 Mar 2017 07:21:24 +0000 (08:21 +0100)]
[TASK] Return to content element after un-/hide

Add the current content element as section to the un-/hide link.

Releases: master, 7.6
Resolves: #80274
Change-Id: I0d6ec4ea8274f82f6d4c66a4e9e77860819d4d15
Reviewed-on: https://review.typo3.org/52045
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Recordlist shows content of wrong folder 74/51974/2
Stefan Fruhen [Tue, 7 Mar 2017 13:21:03 +0000 (14:21 +0100)]
[BUGFIX] Recordlist shows content of wrong folder

Subfolder requires identifier when parent folder is expanded.

Resolves: #80166
Releases: master, 7.6
Change-Id: I5226f425951f9124dcaa3e9780b52354e266382d
Reviewed-on: https://review.typo3.org/51974
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] Localize tt_content_defValues in new content element wizard 69/51469/3
Eric Chavaillaz [Mon, 30 Jan 2017 13:09:33 +0000 (14:09 +0100)]
[BUGFIX] Localize tt_content_defValues in new content element wizard

Resolves: #79551
Releases: master, 7.6
Change-Id: I76bf3996b3f76b18f9ff9cc95b70b2e41bbc4143
Reviewed-on: https://review.typo3.org/51469
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Do not overwrite inlineData in mergeResult 84/51984/3
Helmut Hummel [Wed, 8 Mar 2017 20:54:49 +0000 (21:54 +0100)]
[BUGFIX] Do not overwrite inlineData in mergeResult

Instead of merging different inlineData results, the
FormResultCompiler has one seemingly leftover line of code
which overwrites the inlineData, leading to the situation
that only the last inlineData is kept.

In the list module when editing multiple fields with IRRE relations,
this leads to the fact that children can only be added
to the last element.

For some reason the same code does not expose the bug to the end user,
most likely due to different handling of the context data.

Nevertheless this obviously wrong line should also be removed in 7.6.

Releases: master, 7.6
Resolves: #80181
Change-Id: I56cef1c56a36d1760a99c239130c6791869a1978
Reviewed-on: https://review.typo3.org/51984
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Volker Kemeter <volker@kemeter.de>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Register SVG icons for backend modules automatically 43/52043/8
Cedric Ziel [Tue, 14 Mar 2017 16:20:36 +0000 (17:20 +0100)]
[BUGFIX] Register SVG icons for backend modules automatically

Releases: master
Fixes: #80278
Change-Id: Idcb7efa0fb7a5ad819ce0f65a837916cdeb13c56
Reviewed-on: https://review.typo3.org/52043
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
2 years ago[BUGFIX] Missing max value for title in file reference TCA 41/51941/4
Torben Hansen [Fri, 3 Mar 2017 18:35:53 +0000 (19:35 +0100)]
[BUGFIX] Missing max value for title in file reference TCA

Add a max value of 255 chars for the field "title" and
increase size of field "alternative" in sys_file_reference to
the same size of "parent" field sys_file_metadata in db definition.

Resolves: #80122
Releases: master, 7.6
Change-Id: I9f1e4ef57fbd56e5d6a253409186e16a58c60e2b
Reviewed-on: https://review.typo3.org/51941
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Torben Hansen <derhansen@gmail.com>
Tested-by: Torben Hansen <derhansen@gmail.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Allow any navigation component to load in BE 88/51888/7
Benni Mack [Tue, 28 Feb 2017 10:12:32 +0000 (11:12 +0100)]
[BUGFIX] Allow any navigation component to load in BE

Since the ExtJS viewport refactoring in 8.5, it is not possible
anymore to load any other registered navigation component,
which makes EXT:commerce to not work anymore.

The patch changes the hard-coded pagetree app component
to fetch it from the pool of available navigation components.

Resolves: #80058
Releases: master
Change-Id: I1ce4cfa068f72f39cd5d993df6f9ebbdb7d07b2e
Reviewed-on: https://review.typo3.org/51888
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Maroschik <tmaroschik@dfau.de>
Tested-by: Thomas Maroschik <tmaroschik@dfau.de>
Reviewed-by: Sebastian Fischer <typo3@evoweb.de>
Tested-by: Sebastian Fischer <typo3@evoweb.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Move config.sys_language_softExclude to compat7 36/52036/3
Benni Mack [Mon, 13 Mar 2017 20:30:47 +0000 (21:30 +0100)]
[TASK] Move config.sys_language_softExclude to compat7

The TypoScript option `config.sys_language_softExclude`
allows to set certain fields on tables to l10n_mode=exclude
during Frontend runtime. This TCA option has been migrated
to "allowLanguageSynchronization", but with the clean way that
the database values are consistent across all translations already.

Any special runtime logic and changes can still be done via hooks
for specific use-cases.

Resolves: #80266
Releases: master
Change-Id: I15c55a556b6f1c100e300299410e26d45409e09c
Reviewed-on: https://review.typo3.org/52036
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[!!!][TASK] Remove $TYPO3_CONF_VARS['FE']['pageOverlayFields'] 54/51954/5
Oliver Hader [Sun, 5 Mar 2017 10:25:16 +0000 (11:25 +0100)]
[!!!][TASK] Remove $TYPO3_CONF_VARS['FE']['pageOverlayFields']

The configuration $GLOBALS['TYPO3_CONF_VARS']['FE']['pageOverlayFields']
is removed from the default configuration as well as from the overlay
handling in PageRepository and RootlineUtility. This setting has been
used to determine overlay fields in the table pages_language_overlay at
a time in the runtime processing when the complete TCA was not fully
available. Since the allowLanguageSynchronization possibility has been
integrated into TYPO3 CMS 8, l10n_mode was available already and the TCA
is loaded as well, the pageOverlayFields settings are superfluous.

Change-Id: I36198d7dec94204fc761048de705aa03a5e931c3
Resolves: #80149
Releases: master
Reviewed-on: https://review.typo3.org/51954
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Prevent crash saving <a> without "href" attribute 38/52038/3
Francois Suter [Tue, 14 Mar 2017 08:42:18 +0000 (09:42 +0100)]
[BUGFIX] Prevent crash saving <a> without "href" attribute

Prevent a PHP error in the HTML parser when saving a content element
containing an <a> tag without "href" attribute by using an empty string
instead of null in the link resolver.

Resolves: #80268
Releases: master
Change-Id: I249f8ad13ebd0b2e9430868fdce287b2745ae9bc
Reviewed-on: https://review.typo3.org/52038
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Gianluigi Martino <gmartino27@gmail.com>
Tested-by: Gianluigi Martino <gmartino27@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Be more specific about the inputLink wizard migration 42/52042/2
Cedric Ziel [Tue, 14 Mar 2017 15:40:48 +0000 (16:40 +0100)]
[TASK] Be more specific about the inputLink wizard migration

Resolves: #80277
Releases: master
Change-Id: I4aeab3c0c45d88d8e8934407dfaa3e845d6dd376
Reviewed-on: https://review.typo3.org/52042
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Switch to typo3/cms-styleguide 40/51940/3
Christian Kuhn [Fri, 3 Mar 2017 16:08:38 +0000 (17:08 +0100)]
[TASK] Switch to typo3/cms-styleguide

Styleguide moved from 7elix/styleguide to typo3/cms-styleguide

Change-Id: Ib11cd3d21121214ed5828aa26166d4a7b1419a3c
Resolves: #80118
Releases: master
Reviewed-on: https://review.typo3.org/51940
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
2 years ago[BUGFIX] colPos_list gets respected in language view 41/52041/2
Tobias Kretschmann [Tue, 14 Mar 2017 13:55:23 +0000 (14:55 +0100)]
[BUGFIX] colPos_list gets respected in language view

mod.SHARED.colPos_list is now also respected in
Web > Page > Language View.

Since TYPO3 6.2 the setting was only respected in
Page > Columns View, but should also be taken
into account by the Language View as it is a
SHARED setting.

Releases: master, 7.6
Resolves: #80275
Change-Id: Ibdc90103208d5abbcfba1dbbfee3b87d045885f9
Reviewed-on: https://review.typo3.org/52041
Reviewed-by: Steffen Frese
Tested-by: Steffen Frese
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Return to content element after closing 40/52040/2
Georg Ringer [Tue, 14 Mar 2017 13:28:30 +0000 (14:28 +0100)]
[TASK] Return to content element after closing

Add the current content element as section to the edit link.
Since #70074, the edit link in the header has been already
improved but other links have been missing.

Resolves: #80273
Releases: master
Change-Id: Id7cc236819ccd3306d4638cb65e87aee011a35b3
Reviewed-on: https://review.typo3.org/52040
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Better positioning of suggest result 34/52034/2
Josef Glatz [Mon, 13 Mar 2017 16:30:49 +0000 (17:30 +0100)]
[TASK] Better positioning of suggest result

The suggest result (which is used for autocomplete) within
the TYPO3 backend is now left aligned which is especially
useful, if the form element fills the entire width of the form.

Releases: master
Resolves: #80254
Change-Id: Id6e166272e2e9b2eb3562edb815bb6d053b7fbe8
Reviewed-on: https://review.typo3.org/52034
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Add max to the overrideable fields of type text 35/52035/2
Georg Ringer [Mon, 13 Mar 2017 20:05:15 +0000 (21:05 +0100)]
[TASK] Add max to the overrideable fields of type text

The configuration "max" of TCA type "text" should be overridable
via TsConfig. This makes it possible limit textarea input by using
TsConfig like

TCEFORM.tx_table.teaser.config.max = 20

Resolves: #80265
Releases: master
Change-Id: I84b0dc5ce240b0da1f5619353e8e525fba685e2d
Reviewed-on: https://review.typo3.org/52035
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Update 8.6 Documentation 10/52010/4
Michael Oehlhof [Sun, 12 Mar 2017 10:32:22 +0000 (11:32 +0100)]
[TASK] Update 8.6 Documentation

Update and proofread 8.6 docs
Add changes from https://review.typo3.org/#/c/51599/ which is now
abandoned.

Resolves: #80260
Releases: master
Change-Id: If4398ee1a4c9223b4b4072e82a9171b590e9b29b
Reviewed-on: https://review.typo3.org/52010
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[BUGFIX] Add localizationStateSelector to some elements 01/52001/2
Christian Kuhn [Fri, 10 Mar 2017 21:16:31 +0000 (22:16 +0100)]
[BUGFIX] Add localizationStateSelector to some elements

When the localizationStateSelector has been added, it has been
forgotten for some elements. Add the wizard to both RTE's and t3editor.

Change-Id: If1ad3503f4ffde7d1dd8153708bb7da21c87e308
Resolves: #80234
Releases: master
Reviewed-on: https://review.typo3.org/52001
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Preview pages with publish dates 23/52023/4
Susanne Moog [Mon, 13 Mar 2017 11:53:08 +0000 (12:53 +0100)]
[BUGFIX] Preview pages with publish dates

Currently pages can be hidden for different reasons:
- page is disabled
- page has a start time in the future
- page has an end time in the past
- page has an access restriction

When previewing a page the fe_groups and disabled restriction are
already ignored when TYPO3 is configured to preview hidden pages.

Start and endtime should be ignored, too, so an editor is able to
preview pages with start or end times set.

Change-Id: I634076af7219b70ccfc46f470ba046417177d29a
Resolves: #66451
Releases: master
Reviewed-on: https://review.typo3.org/52023
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Steffen Frese
Tested-by: Steffen Frese
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[BUGFIX] Editing start-/end time of scheduled task not working correctly 60/51960/8
Thomas Hohn [Mon, 6 Mar 2017 05:41:53 +0000 (06:41 +0100)]
[BUGFIX] Editing start-/end time of scheduled task not working correctly

The start/end value can now contain either the start-/end time as
unix timestamp or as formatted date when using the datepicker.
In the later case the value must be converted to an unix timestamp
before storing it in the DB.

Resolves: #79814
Related: #77702
Releases: master
Change-Id: I750c1bc6d4634b89423e26a0dea48d2001115f18
Reviewed-on: https://review.typo3.org/51960
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christer V <cvi@systime.dk>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Thomas Maroschik <tmaroschik@dfau.de>
Tested-by: Thomas Maroschik <tmaroschik@dfau.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
2 years ago[BUGFIX] Fix rendering of select icons 83/51983/4
Georg Ringer [Wed, 8 Mar 2017 19:48:46 +0000 (20:48 +0100)]
[BUGFIX] Fix rendering of select icons

Use floating divs for the select icons instead of
a table with a fixed column count of 12.

Resolves: #79508
Releases: master
Change-Id: I4b4f485753ca33aa71d5c533b437e518da2096ed
Reviewed-on: https://review.typo3.org/51983
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Add sys_domain index matching getDomainStartPage query 17/52017/2
Claus Due [Sun, 12 Mar 2017 18:45:24 +0000 (19:45 +0100)]
[TASK] Add sys_domain index matching getDomainStartPage query

The added index optimises the query that executes on every
single page load both cached and uncached.

Change-Id: I67dd28d08322442fcacdc5101e0063d072b25ae2
Resolves: #80247
Releases: master
Reviewed-on: https://review.typo3.org/52017
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Remove no longer used CSS 86/51986/3
Josef Glatz [Thu, 9 Mar 2017 08:19:34 +0000 (09:19 +0100)]
[BUGFIX] Remove no longer used CSS

Remove obsolete and no longer used css styles concerning `ul.tree`.

This patch make also compiling css with grunt clean again when
executing.

Resolves: #80203
Related: #79803
Releases: master
Change-Id: Icee30a5e7ae1771062e452f70b38ad9f13eef774
Reviewed-on: https://review.typo3.org/51986
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Remove default fieldWizard on NoneElement 98/51998/4
Christian Kuhn [Fri, 10 Mar 2017 21:08:01 +0000 (22:08 +0100)]
[BUGFIX] Remove default fieldWizard on NoneElement

The NoneElement is a readOnly field. The fieldWizard API does not
make sense for this element, thus the declaration of default
fieldWizards can be dropped.

Change-Id: I59b0a25a798058858384dcea4fb9e9a33bf2b7ae
Resolves: #80231
Releases: master
Reviewed-on: https://review.typo3.org/51998
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] EXT:form - add typoscript inline documentation 06/52006/3
Ralf Zimmermann [Sat, 11 Mar 2017 13:01:17 +0000 (14:01 +0100)]
[TASK] EXT:form - add typoscript inline documentation

Resolves: #80142
Releases: master
Change-Id: I9463bf12732966de177816e14fc76c16e8f74783
Reviewed-on: https://review.typo3.org/52006
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] MM language synchronization is ignored on initial localization 04/52004/7
Oliver Hader [Sat, 11 Mar 2017 09:50:11 +0000 (10:50 +0100)]
[BUGFIX] MM language synchronization is ignored on initial localization

The language synchronization of many-to-many fields (MM) is ignored for
the initial localization command, but is considered again when further
changes happen to source/parent elements of a localized element.

Besides fixing the missing 'config' segment on resolving the foreign
table name of the field to be synchronized, the special handling for
language assignments has been added - albeit it might not been used
in fields different to sys_language_uid.

Change-Id: I8bf02ee117fa41cf5b0425d0e535fced84fb72ca
Resolves: #80211
Releases: master
Reviewed-on: https://review.typo3.org/52004
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Müllenhagen <christianmuellenhagen@yahoo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Fixed processing of non jpg, png and gif images 51/51751/4
Frans Saris [Sun, 19 Feb 2017 10:11:05 +0000 (11:11 +0100)]
[BUGFIX] Fixed processing of non jpg, png and gif images

Resolves: #79903
Releases: master
Change-Id: I159286a17bbb7dbab9d5ef696608e0e4d8558e7d
Reviewed-on: https://review.typo3.org/51751
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anders Kostending <aha@systime.dk>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Use-fine grained request types in Applications 09/52009/2
Benni Mack [Sun, 12 Mar 2017 07:21:06 +0000 (08:21 +0100)]
[BUGFIX] Use-fine grained request types in Applications

The new CLI console application as well as the install tool define
the request type as simulating backend, which is wrong, as they are
a separate application indeed.

In order to use more fine-grained different validations in the future
the request types are set as they are.

Resolves: #80242
Releases: master
Change-Id: Ide7bae5fc4ea2ed591c6f7e24836309a24242106
Reviewed-on: https://review.typo3.org/52009
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Two wrong conditions in FormEngine expansion 99/51999/2
Christian Kuhn [Fri, 10 Mar 2017 21:12:00 +0000 (22:12 +0100)]
[BUGFIX] Two wrong conditions in FormEngine expansion

Two minor condition checks in FormEngine element expansion
classes.

Change-Id: I087b744ee826d9b7174261bc084c4c188920e6c8
Resolves: #80232
Releases: master
Reviewed-on: https://review.typo3.org/51999
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] EXT:form - Change regexp for identifier escaping 96/51996/3
Martin Kutschker [Fri, 3 Mar 2017 22:42:48 +0000 (22:42 +0000)]
[BUGFIX] EXT:form - Change regexp for identifier escaping

Change regexp for identifier escaping of forms to work
for underscores and dashes.

Resolves: #80229
Releases: master
Change-Id: I2d76da7b42039cc13429344ca82120bf60b0ab13
Reviewed-on: https://review.typo3.org/51996
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Add allowLanguageSynchronization chain resolving 52/51952/15
Oliver Hader [Sat, 4 Mar 2017 12:39:15 +0000 (13:39 +0100)]
[BUGFIX] Add allowLanguageSynchronization chain resolving

Currently the localization behavior does not consider localization
chains concerning field values to be synchronized over multiple
localization hops that use the relative l10n_state "source".

Imagine the following scenario of content elements:
* { uid:10, sys_language_uid:0, l18n_parent:0, l10n_source:0,
    header:Value, l10n_state:null }
* { uid:11, sys_language_uid:1, l18n_parent:10, l10n_source:10,
    header:Value, l10n_state:{header:parent} }
* { uid:12, sys_language_uid:2, l18n_parent:10, l10n_source:11,
    header:Value, l10n_state:{header:source} }

Now if the record of the default language (uid:10) will be updated and
the header value set to "Modified", only direct dependents would be
synchronized. The automated update of the direct-child localization
record (uid:11) does not trigger another update for the grand-child
localization (uid:12).
To achieve this, the data-map processor has been extended to collect
new modifications to the data-map caused by synchronization processes
- as long as modifications could be determined, another synchronization
round is triggered for the modified items.
This way the localization chain is completely synchronized if required,
depending on the according l10n_state settings.

Change-Id: Ic08460f3ed0071f3dca6c6d1666031895bc3d832
Resolves: #80141
Releases: master
Reviewed-on: https://review.typo3.org/51952
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[TASK] Bypass fetch of database record if already loaded 29/51929/3
Xavier Perseguers [Thu, 2 Mar 2017 14:51:38 +0000 (15:51 +0100)]
[TASK] Bypass fetch of database record if already loaded

Change-Id: I737f76e497ef4a9c2ce1439cfe09b0b1e75afd73
Resolves: #80100
Releases: master
Reviewed-on: https://review.typo3.org/51929
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Wrong variable checked in BrowseLinksController 91/51991/2
Christer Vindberg [Thu, 9 Mar 2017 13:00:14 +0000 (14:00 +0100)]
[BUGFIX] Wrong variable checked in BrowseLinksController

Changed so the correct variable classesAnchorDefaultTitle is checked.

In BrowseLinksController::getTitleField the wrong variable was checked,
which could cause faulty behaviour and an PHP warning since $title could
become null instead of the empty string.

Resolves: #80209
Releases: master
Change-Id: Ie2c82085438d0f0303d0d61ccb0a095ee37da338
Reviewed-on: https://review.typo3.org/51991
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Minor typo and unused use 00/52000/2
Christian Kuhn [Fri, 10 Mar 2017 21:14:51 +0000 (22:14 +0100)]
[BUGFIX] Minor typo and unused use

Change-Id: If3eb8c6d2b0fef265b3030fc1c2ed7ec8958564f
Resolves: #80233
Releases: master
Reviewed-on: https://review.typo3.org/52000
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Make InvalidXmlFileException for language files more verbose 95/51995/2
Andreas Fernandez [Fri, 10 Mar 2017 11:14:45 +0000 (12:14 +0100)]
[TASK] Make InvalidXmlFileException for language files more verbose

The message of the InvalidXmlFileException, thrown when parsing broken
language files now always shows the last occured error in libxml with
the affected file and line.

Resolves: #80224
Releases: master, 7.6
Change-Id: I49949119db73f0c09d997a3e2cf45bf86a9587c8
Reviewed-on: https://review.typo3.org/51995
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Avoid CKEditor RequireJS information loaded in FE 87/51987/2
Benni Mack [Thu, 9 Mar 2017 09:16:16 +0000 (10:16 +0100)]
[BUGFIX] Avoid CKEditor RequireJS information loaded in FE

The CKEditor default configuration for RequireJS path
resolving is only relevant in BE, Frontend Page Rendering
needs to do that separately for now, to avoid
loading of too many unnecessary config files if only
requireJS should be used in the Frontend.

The patch changes the functionality to only load
RequireJS in Backend (and not in CLI mode).

Resolves: #80183
Releases: master
Change-Id: I035ddb6bc83ebfb2a8f45de71fadd8f0e0b2d0a3
Reviewed-on: https://review.typo3.org/51987
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Christer V <cvi@systime.dk>
Tested-by: Christer V <cvi@systime.dk>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Fix configuration example in image manipulation rst 93/51993/2
Helmut Hummel [Thu, 9 Mar 2017 21:22:38 +0000 (22:22 +0100)]
[BUGFIX] Fix configuration example in image manipulation rst

The configuration example for cover areas is wrong and needs
to be nested below cropVariants and <cropVariantId>

Resolve: #80218
Releases: master
Change-Id: I5c65fb8657fe93b41a083c01b6bea0a8610177bc
Reviewed-on: https://review.typo3.org/51993
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Fix PageTS config example of CKEditor RTE 70/51770/3
mkoitka [Mon, 20 Feb 2017 12:35:32 +0000 (13:35 +0100)]
[BUGFIX] Fix PageTS config example of CKEditor RTE

Releases: master
Resolves: #79919
Change-Id: Ic47513eddca720e29bc83efccdb6f55854768d37
Reviewed-on: https://review.typo3.org/51770
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
2 years ago[TASK] Remove TCA config 'max' on inputDateTime fields 03/51903/7
Thomas Hohn [Tue, 28 Feb 2017 15:42:39 +0000 (16:42 +0100)]
[TASK] Remove TCA config 'max' on inputDateTime fields

The TCA migration removes the 'max' config option for
renderType="inputDateTime" since this should not be set
for this renderType to avoid performance issues when
storing data in the DB.

Resolves: #80027
Releases: master
Change-Id: Ia8d6d95e0830c6173522757ece5e3f48db618f33
Reviewed-on: https://review.typo3.org/51903
Reviewed-by: Christer V <cvi@systime.dk>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
2 years ago[BUGFIX] Make styles.content.get available after major FSC rewrite 84/51884/7
Josef Glatz [Tue, 28 Feb 2017 06:36:35 +0000 (07:36 +0100)]
[BUGFIX] Make styles.content.get available after major FSC rewrite

Since the major rewrite of EXT:fluid_styled_content and
EXT:css_styled_content the following TypoScript setup must
be loaded by default:

* `styles.content.get` can be used as ready2use `CONTENT`
  object for `colPos = 0`
* `tt_content.default` outputs necessary info in the frontend,
  if the CType has currently no rendering definition

Both can be used independently from FSC or CSC.

Including the necessary TypoScript via `addTypoScriptSetup()`
takes care of loading it before any other activated extension.

Resolves: #80044
Related: #79622
Releases: master
Change-Id: I460ed9f57e215be96ee13d6714cd522882fb53eb
Reviewed-on: https://review.typo3.org/51884
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Tested-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Tested-by: Daniela Grammlich <grammlich@punkt.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Skip CKEditor registration on CLI 81/51981/4
Christer Vindberg [Wed, 8 Mar 2017 12:14:29 +0000 (13:14 +0100)]
[BUGFIX] Skip CKEditor registration on CLI

Made sure the CKEditor RequireJS paths are not calculated when running
in a CLI context.

When rte_ckeditor is installed, all caches are cleared
and the first hit to a TYPO3 installation is a CLI command, the
backend RequireJS paths are calculated and saved wrongly
causing the backend to fail afterwards.

How to replicate:

* install rte_ckeditor
* delete var/Cache/
* run typo3/cli_dispatch.phpsh
* visit backend

Resolves: #80183
Releases: master
Change-Id: I5de9462a6f577f2eb6c06adabe44a6a86e3c2592
Reviewed-on: https://review.typo3.org/51981
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Anders Kostending <aha@systime.dk>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
2 years ago[BUGFIX] MediaViewHelper does not render data-focus-area attribute 19/51919/4
Jörg Bösche [Wed, 1 Mar 2017 14:32:59 +0000 (15:32 +0100)]
[BUGFIX] MediaViewHelper does not render data-focus-area attribute

The media view helper should support the new data-focus-area attribute
for image manipulation. Just like the ImageViewHelper does.

Resolves: #80081
Releases: master
Change-Id: I89395ae974b72522d1c4c97d0dae38dd65495ae3
Reviewed-on: https://review.typo3.org/51919
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Claus Due <claus@phpmind.net>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[BUGFIX] Update selected ratio in preview element 79/51979/3
Helmut Hummel [Tue, 7 Mar 2017 19:30:00 +0000 (20:30 +0100)]
[BUGFIX] Update selected ratio in preview element

When selecting a different ratio and accepting the image manipulation,
not only the image thumbnails, but also the selected ratio should be updated.

Also set the selected ratio correctly when initializing the image manipulation
and set the value even if selected ratio is not defined in TCA but is present
in allowed aspect ratios.

Also always set crop area from saved collection.

Resolves: #80169
Releases: master
Change-Id: I63c24e14b724c3f47ff3101afb4bcb56983c1b28
Reviewed-on: https://review.typo3.org/51979
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Add possibility to define crop variants per table 51/51951/11
Helmut Hummel [Thu, 2 Mar 2017 13:14:31 +0000 (14:14 +0100)]
[BUGFIX] Add possibility to define crop variants per table

Currently it is not possible to define crop variants per
table or content type. This makes this feature a lot less useful
as it could be.

Add a form data provider to make this possible.

Also fix the issue that the full size image is used instead of
a smaller variant in the interface and hide the cropping
tool if no image size can be determined (happens for some SVGs).

Focus area now also works when no cover areas are defined.

Resolves: #80105
Resolves: #80157
Resolves: #79961
Releases: master
Change-Id: I3333a59c84b6f55f7bf300663ea2ff52bf70e698
Reviewed-on: https://review.typo3.org/51951
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
2 years ago[BUGFIX] Add support for target attribute to form viewhelper 71/51971/2
Susanne Moog [Tue, 7 Mar 2017 07:48:48 +0000 (08:48 +0100)]
[BUGFIX] Add support for target attribute to form viewhelper

<f:form> now supports setting target="" as attribute.

Change-Id: Id6bd5f136b3ca6a4083f08780796b408ceaf0116
Releases: master,7.6
Resolves: #80159
Reviewed-on: https://review.typo3.org/51971
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
2 years ago[TASK] Upgrade d3.js to 4.7.1 61/51961/2
Anders Kostending [Mon, 6 Mar 2017 08:23:55 +0000 (09:23 +0100)]
[TASK] Upgrade d3.js to 4.7.1

Release notes:
4.6.0
 * Add path.measure.
 * Improve d3.pack layout.
 * Fix d3.geoBounds for certain line geometries.
 * Fix d3.geoCentroid for detailed features.
4.7.0
 * Add d3.cross.
 * Allow d3.pairs to take an optional reducer.
 * Add d3.geoContains.
 * Fix invalid transforms when an ordinal axis transition
 is interrupted.
 * Localized number formats can now define numeral systems,
 such as Hindu–Arabic.
 * Fix number formatting of negative infinity.
 * Maybe make rounded arcs a little more robust.
 * Optimize d3.geoCentroid.
4.7.1
 * Fix the Mercator projection’s built-in clipping when
 projection.center is used.
 * Fix the Mercator projection’s built-in clipping when
 projection.clipExtent is used.
 * Ignore small-angle arcs in path.arc to workaround
 rendering bug in Chrome on Ubuntu.
 * Fix escaping of strings containing carriage returns
 in d3-dsv.

 More on https://github.com/d3/d3/releases

Resolves: #80147
Releases: master
Change-Id: I0fd7280b46795c9acd31fb84308fd682494feb30
Reviewed-on: https://review.typo3.org/51961
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] EM: Highlighting for insecure/outdated extensions 36/51936/6
Josef Glatz [Fri, 3 Mar 2017 14:01:54 +0000 (15:01 +0100)]
[BUGFIX] EM: Highlighting for insecure/outdated extensions

- Fix styles for extensions marked insecure or outdated
  within the TYPO3 extension manager list.
- Fix and update styles for the extension upload form.

Make compiling css with grunt clean again when executing:
* install.css

This patch fixes also the version number of a bower dependency
which should reflect the installed version:
* matchHeight v0.7.0 to v0.7.2

Resolves: #80114
Related: #79803
Releases: master, 7.6
Change-Id: If6b6fbf7331c292605c3e0b17aafbaea301825f7
Reviewed-on: https://review.typo3.org/51936
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Move version selector view to EXT:compatibility7 77/51777/5
Benni Mack [Tue, 21 Feb 2017 07:01:24 +0000 (08:01 +0100)]
[TASK] Move version selector view to EXT:compatibility7

The functionality for switching between versions and showing
all versions of a record is available through the clickmenu when
EXT:version, but not EXT:workspaces is installed.

It is only used on certain edge cases and therefor moved
to EXT:compatibility7.

Resolves: #79942
Releases: master
Change-Id: Ic54f6ff2641fcb25ab3984ebead44dc44d9d3834
Reviewed-on: https://review.typo3.org/51777
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Always use forward slashes in Upgrade Analysis 59/51959/2
Jigal van Hemert [Sun, 5 Mar 2017 22:13:36 +0000 (23:13 +0100)]
[BUGFIX] Always use forward slashes in Upgrade Analysis

In the Upgrade Analysis in the Install Tool only forward slashes
can be used in paths to prevent exceptions from being throws while
checking if the file is inside the documentation directory. If the path
is constructed with realpath() the path contains backslashes on Windows.

Resolves: #80146
Releases: master
Change-Id: Ib3fde8389ca74f7ee60bc7adf261232e58113639
Reviewed-on: https://review.typo3.org/51959
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[FOLLOWUP][BUGFIX] Exception when setting "language" to "all" for content 62/51962/2
Oliver Hader [Mon, 6 Mar 2017 09:06:15 +0000 (10:06 +0100)]
[FOLLOWUP][BUGFIX] Exception when setting "language" to "all" for content

The initial change just hid a misbehavior when dealing with a content
element that was defined for the non-existing "all language". In this
case no localizations are possible and the data-map item shall not be
considered at all. This change makes the exception on language "-1"
more explicit and does not hide these side-effects.

Besides that, the functional tests were extended to check the complete
scenario for the defined language to be tested in the frontend.

Change-Id: I336e0e5c3994e21b9b8a17818b3dc0ab1c2a1b3a
Resolves: #79853
Releases: master
Reviewed-on: https://review.typo3.org/51962
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Joerg Kummer <service@enobe.de>
Tested-by: Joerg Kummer <service@enobe.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
2 years ago[BUGFIX] Respect TypoScript code after not matched include 63/51963/3
Helmut Hummel [Mon, 6 Mar 2017 11:30:46 +0000 (12:30 +0100)]
[BUGFIX] Respect TypoScript code after not matched include

When parsing TypoScript with <INCLUDE which has a condition,
following TypoScript code which is not in an <INCLUDE statement
will be discarded.

Before early returning from a non matched condition, this
code needs to be added.

Resolves: #80150
Releases: master, 7.6
Change-Id: I4ea839012c57e5e7945dde3705aa96839afc58a0
Reviewed-on: https://review.typo3.org/51963
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[TASK] Hide word count in indexed_search backend if mysql fulltext is used 31/51931/2
Georg Ringer [Thu, 2 Mar 2017 20:19:58 +0000 (21:19 +0100)]
[TASK] Hide word count in indexed_search backend if mysql fulltext is used

If mysql fulltext is enabled, the word count is always empty.
Therefore the word count should be always be hidden.

Resolves: #79985
Releases: master
Change-Id: I6463acecbb8935cf51419c5faebd9818da6efc7b
Reviewed-on: https://review.typo3.org/51931
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[TASK] Show actual connect problem in Install tool 48/51948/9
Thomas Hohn [Sat, 4 Mar 2017 07:16:25 +0000 (08:16 +0100)]
[TASK] Show actual connect problem in Install tool

If a connection can't be established to the database show the
actual exception message instead of just asking the user to check.
Can be due to faulty configuration in LocalConfiguration.php

Resolves: #80134
Releases: master
Change-Id: Ib04f4ac74ca8234dd18d5bc9ba71c4d75c28038f
Reviewed-on: https://review.typo3.org/51948
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
2 years ago[BUGFIX] Check for required migrations in silentCacheFrameworkTableSchemaMigration 07/51907/3
Georg Ringer [Tue, 28 Feb 2017 19:14:42 +0000 (20:14 +0100)]
[BUGFIX] Check for required migrations in silentCacheFrameworkTableSchemaMigration

Check that there are tables that need to be migrated instead of blindy
calling the SchemaMigrator.

Resolves: #80065
Releases: master
Change-Id: I6992f4fa1786a27123058ce89f8c8669f13ddabc
Reviewed-on: https://review.typo3.org/51907
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Add deleted = 0 to getProcessedValue 55/51955/2
Mathias Schreiber [Sun, 5 Mar 2017 12:50:16 +0000 (13:50 +0100)]
[BUGFIX] Add deleted = 0 to getProcessedValue

The doctrine migration missed a DeletedRestriction.

Resolves: #80143
Releases: master
Change-Id: I391f47ecb61be6ebdcd6f57978cf5cf5b007a2d3
Reviewed-on: https://review.typo3.org/51955
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] CKEditor: UI language should respect BE user language 47/51947/3
Benni Mack [Sat, 4 Mar 2017 06:49:16 +0000 (07:49 +0100)]
[BUGFIX] CKEditor: UI language should respect BE user language

If a backend user has selected a backend language,
CKEditor is not respecting this option, instead calculating
this based on the current browsers' language.

By default, CKeditor checks if the config option "language"
is set and if this is a valid language key, and translation is available
if not, it checks for the browser settings, if nothing matching found
it falls back to to the config option "defaultLanguage".

"defaultLanguage" should be set to "en", as the TYPO3 Backend
does as well.

The config option "language" should be calculated based on the
Backend Users' settings.

Resolves: #80133
Releases: master
Change-Id: I0f095ab7147871c2a4e8c8ea379754749bc1ba98
Reviewed-on: https://review.typo3.org/51947
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Catch FileDoesNotExistException in InputLinkElement 22/51922/5
Georg Ringer [Wed, 1 Mar 2017 22:37:41 +0000 (23:37 +0100)]
[BUGFIX] Catch FileDoesNotExistException in InputLinkElement

If a file is linked which does not exist anymore, the UI
must not break.

Resolves: #80086
Releases: master
Change-Id: If95af9bf4b1e6e723e26e412ce7a29d8214fe411
Reviewed-on: https://review.typo3.org/51922
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[TASK] CKEditor: Add quicktable plugin / easier table configuration 45/51945/4
Benni Mack [Sat, 4 Mar 2017 06:25:54 +0000 (07:25 +0100)]
[TASK] CKEditor: Add quicktable plugin / easier table configuration

In order to reduce the dialog popups and ease the pain with tables
within CKEditor, quicktable (https://github.com/ufdada/quicktable)
is added which complements the basic "table" plugin.

The quicktable plugin is modified to add only unstyled tables
instead of the default tables/borders.

Additionally, some styles for tables are added to the default contents.css

Resolves: #80131
Releases: master
Change-Id: I06b619fa89e21cb43ea79ebc8a67238db8d58c66
Reviewed-on: https://review.typo3.org/51945
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] CKEditor: Use better default alignment classes 46/51946/2
Benni Mack [Sat, 4 Mar 2017 06:39:47 +0000 (07:39 +0100)]
[TASK] CKEditor: Use better default alignment classes

The default alignment classes are adapted to reflect default stylings for
websites, using twitter bootstrap instead of custom classes.

Resolves: #80132
Releases: master
Change-Id: I7ef353d357ee9095f47a8701bbcb2fc5f2b8253b
Reviewed-on: https://review.typo3.org/51946
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Catch exceptions in LinkBrowser 23/51923/3
Georg Ringer [Wed, 1 Mar 2017 22:57:32 +0000 (23:57 +0100)]
[BUGFIX] Catch exceptions in LinkBrowser

If a folder or file is linked which does not exist, the UI must not
break.

Resolves: #80087
Releases: master
Change-Id: I9027234065c33f68db6af24f1dae9735d46d2584
Reviewed-on: https://review.typo3.org/51923
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[BUGFIX] Incorrect usages of string as array in QueryGenerator 15/51915/8
Christer Vindberg [Wed, 1 Mar 2017 11:46:47 +0000 (12:46 +0100)]
[BUGFIX] Incorrect usages of string as array in QueryGenerator

Changed so an empty $queryConfig is always an array.

$queryConfig is declared as an array but can be used as an array or
string, therefore in PHP 7.1 an exception was thrown.

Resolves: #80075
Releases: master, 7.6
Change-Id: Ifd8b89e0ccce4f93a6c7bee5afe10bf52fa73634
Reviewed-on: https://review.typo3.org/51915
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[TASK] Use LanguageService::$moduleLabels as fallback in ModuleLoader 32/51932/2
Nicole Cordes [Thu, 2 Mar 2017 23:18:17 +0000 (00:18 +0100)]
[TASK] Use LanguageService::$moduleLabels as fallback in ModuleLoader

As the property moduleLabels of the LanguageService was deprecated with
8, it should be used as fallback for module labels unless it is removed
completely. This raises compatibility possibilities for extensions as
otherwise an empty module is shown in the module list.

Resolves: #80107
Releases: master
Change-Id: I5fc306b2bd2c2ba221ad877cec3914f07d2ff584
Reviewed-on: https://review.typo3.org/51932
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[BUGFIX] Felogin: Only wrap header/message if not empty 34/51934/3
Benni Mack [Fri, 3 Mar 2017 10:21:16 +0000 (11:21 +0100)]
[BUGFIX] Felogin: Only wrap header/message if not empty

When adding felogin template the wraps defined by default
of EXT:felogin are always outputted even though it just adds
an empty div/h3 tag around, which looks odd in most installations.

The patch adds a proper required tag to see if the value is actually not
empty.

Resolves: #80110
Releases: master, 7.6
Change-Id: Ia9e4c7d3dc294b30db3f10cdde96f95899aa18ef
Reviewed-on: https://review.typo3.org/51934
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[BUGFIX] SchemaMigrator: Don't add indexes on changed columns 28/51928/8
Morton Jonuschat [Fri, 3 Mar 2017 03:15:10 +0000 (19:15 -0800)]
[BUGFIX] SchemaMigrator: Don't add indexes on changed columns

Adding or changing an index on MySQL could sometimes fail due
to a dependency between the index definition and the column types.
On MySQL indexes on TEXT/BLOB types might require defining a
prefix length so that the index does not exceed storage limits.

Implement a check when migrating the database in a mode that
only adds fields and indexes such that added indexes do not touch
columns that require changes.

Also update the detection of required database changes in the
upgrade wizard so it does not get stuck on database changes
which will not be performed in that phase.

Resolves: #80096
Resolves: #80043
Releases: master
Change-Id: I4fa403e8429f9f59a6316d0f425d36673a690e31
Reviewed-on: https://review.typo3.org/51928
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[FOLLOWUP][BUGFIX] Add query restrictions for all tables in query 12/51912/4
Tymoteusz Motylewski [Wed, 1 Mar 2017 14:17:03 +0000 (15:17 +0100)]
[FOLLOWUP][BUGFIX] Add query restrictions for all tables in query

This patch ensures a correct table name is used within the restrictions
to be able to find TCA information.

Resolves: #79615
Releases: master
Change-Id: I1e96531602bfb5debeb0a1202ed91eb90cc31032
Reviewed-on: https://review.typo3.org/51912
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Default saltedPWHashingMethod Pbkdf2 35/51935/3
Christian Futterlieb [Fri, 3 Mar 2017 11:59:22 +0000 (12:59 +0100)]
[TASK] Default saltedPWHashingMethod Pbkdf2

Change default saltedPWHashingMethod to Pbkdf2 in order to use the
most secure salting method that is available by default.

Change-Id: I4cd06731fe5aee177f4809fd604c8f770232062f
Releases: master
Resolves: #80112
Reviewed-on: https://review.typo3.org/51935
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Futterlieb <christian@futterlieb.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Improve migration steps of BE viewhelper attributes deprecation 27/51927/5
Tymoteusz Motylewski [Thu, 2 Mar 2017 11:59:06 +0000 (12:59 +0100)]
[TASK] Improve migration steps of BE viewhelper attributes deprecation

Resolves: #80097
Releases: master
Change-Id: Ia0d4448bfa257bb3f77f12baaa210bc1af1b6b57
Reviewed-on: https://review.typo3.org/51927
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[CLEANUP] Streamline Avatar-related code in EXT:backend 08/51908/4
Benni Mack [Tue, 28 Feb 2017 19:54:22 +0000 (20:54 +0100)]
[CLEANUP] Streamline Avatar-related code in EXT:backend

- Add proper comments to all PHP code, remove all unnecessary
comments (e.g. "get height" for getHeight() method).
- Move Icon functionality to ViewHelpers instead of doing everything
in PHP.

Resolves: #80066
Releases: master
Change-Id: I5c814824f57112e9603f5994e051f7eb6dd85e45
Reviewed-on: https://review.typo3.org/51908
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Ensure pageTS is overriding on top-level RTE syntax 17/51917/4
Benni Mack [Wed, 1 Mar 2017 11:51:10 +0000 (12:51 +0100)]
[BUGFIX] Ensure pageTS is overriding on top-level RTE syntax

If using RTE.classesAnchor before, the new Richtext class
did not merge the values together. This is now solved by
doing proper overlays.

Resolves: #80078
Releases: master
Change-Id: Ia76696065a22207ed40974cc0da8b2842120c45d
Reviewed-on: https://review.typo3.org/51917
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
2 years ago[TASK] Deprecate \TYPO3\CMS\Core\Core\Bootstrap::loadExtensionTables 18/51918/3
Nicole Cordes [Wed, 1 Mar 2017 12:17:37 +0000 (13:17 +0100)]
[TASK] Deprecate \TYPO3\CMS\Core\Core\Bootstrap::loadExtensionTables

With the patch https://review.typo3.org/51892 we have introduced single
functions to handle loading of information correctly. We can now remove
the wrapper function and call the new ones instead.

Resolves: #80079
Releases: master
Change-Id: I0d61f0d5760ae3c61fa96dc16329365d5f4182a5
Reviewed-on: https://review.typo3.org/51918
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[!!!][TASK] Always include pageId in cHash calculation 83/51883/5
Benni Mack [Tue, 28 Feb 2017 06:17:43 +0000 (07:17 +0100)]
[!!!][TASK] Always include pageId in cHash calculation

The option $TYPO3_CONF_VARS[FE][cHashIncludePageId]
was included as part of a security fix to stay backwards-compatible
with existing installations.

The option was only there as a intermediate step, however
the cHash calculation should always contain the pageID,
so the option is removed and should be enabled by default.

The change removes the option via a silent configuration
updater in the Install Tool, removes the status report and
changes the cHash calculation to always include a pageId,
and if the page ID is not given, an exception is now
thrown all the time.

Resolves: #80050
Releases: master
Change-Id: Iac8eef1273848309da62deb24160f1c14ef338f4
Reviewed-on: https://review.typo3.org/51883
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>