Packages/TYPO3.CMS.git
6 years ago[TASK] Backport Flow property mapper
Thomas Maroschik [Sat, 13 Apr 2013 11:21:18 +0000 (13:21 +0200)]
[TASK] Backport Flow property mapper

In order to be in sync with Flow again the property mapper has been
backported again.

Resolves: #47182
Releases: 6.1
Change-Id: I28712c643da54d203549f503a7721a14b0c8eb29
Reviewed-on: https://review.typo3.org/19906
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Andreas Wolf
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] Localization ignores extensionName argument for TypoScript labels
Tymoteusz Motylewski [Sat, 13 Apr 2013 11:35:16 +0000 (13:35 +0200)]
[BUGFIX] Localization ignores extensionName argument for TypoScript labels

Localization utility should pass extesnionName to configurationManager
when fetching TypoScript _LOCAL_LANG labels.
Without this parameter configurationManager returns configuration
of the current plugin.
For example having
<f:translate key="foo" extensionName="news" />
in the blog_example extension template should load translation
from "news" extesnion.

This patch also makes LocalizationUtility::loadTypoScriptLabels()
testable.

Resolves: #46042
Releases: 4.7, 6.0, 6.1
Change-Id: If3785617defe2894cf3a8dc201e66acd182c18c0
Reviewed-on: https://review.typo3.org/19908
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Provide .gitignore and ignore code coverage report folder
Alexander Schnitzler [Sat, 13 Apr 2013 09:14:15 +0000 (11:14 +0200)]
[TASK] Provide .gitignore and ignore code coverage report folder

Releases: 6.1
Resolves: #47178
Change-Id: Ieaeaf4e0560bd8ff3dd64176bd55a7e91640bd7a
Reviewed-on: https://review.typo3.org/19888
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Added handling for array in findOneByXXX result
Benjamin Bretz [Fri, 12 Apr 2013 15:30:45 +0000 (17:30 +0200)]
[BUGFIX] Added handling for array in findOneByXXX result

If query findOneByXXX is configured to return an array, the first array
element is returned (instead of calling ->getFirst() on a non object).

Fixes: #46035
Releases: 6.1, 6.0, 4.7, 1.3
Change-Id: I2c9d3083ce0eaebd2929ce9f50ec2a7cc36fe222
Reviewed-on: https://review.typo3.org/19855
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] RequestBuilder must not call $request->setMethod with NULL
Alexander Schnitzler [Sat, 13 Apr 2013 09:05:19 +0000 (11:05 +0200)]
[BUGFIX] RequestBuilder must not call $request->setMethod with NULL

If running a cli script the variable $_SERVER['REQUEST_METHOD'] is
not set at all. So when dispatching a sub webrequest the variable is
still not set and the RequestBuilder sets the method of Request to
NULL which is not allowed.

Therefore the variable will now be fetched via the Enrivonment-
Service which detects if the variable is empty and falls back to
"GET".

Releases: 6.1, 6.0, 4.7, 1.3
Resolves: #13845
Change-Id: I5e33aba48605895f9eae1e3b710364091e7e84f0
Reviewed-on: https://review.typo3.org/19887
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[TASK] Fix typehints in docblocks of Mapper
Stefan Neufeind [Fri, 12 Apr 2013 21:32:15 +0000 (23:32 +0200)]
[TASK] Fix typehints in docblocks of Mapper

Resolves: #47174
Releases: 6.0, 6.1
Change-Id: Ib29e83b59f6f97e19f3123700d8971e1ea2ea7e8
Reviewed-on: https://review.typo3.org/19881
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[TASK] Optimize persisting a dirty objectStorage
Marc Bastian Heinrichs [Wed, 12 Dec 2012 21:00:24 +0000 (22:00 +0100)]
[TASK] Optimize persisting a dirty objectStorage

This change optimizes persisting a dirty objectStorage
by not removing and inserting/updating all relations,
but insert/update/remove only new/dirty relations.
In the issue a wiki page is linked with some additional infos.

Resolves: #28091
Releases: 6.1
Change-Id: I1e861b62df0379eb84126c7f70f82287e23f0bdd
Reviewed-on: https://review.typo3.org/3390
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
6 years ago[BUGFIX] Prevent call of updateReferenceIndex on unknown object
Stefan Galinski [Mon, 18 Mar 2013 21:35:16 +0000 (22:35 +0100)]
[BUGFIX] Prevent call of updateReferenceIndex on unknown object

Fixes: #46418
Releases: 6.1, 6.0

Change-Id: I20ab919c2290edcf6478f8edc7a0eafe2bac7cbb
Reviewed-on: https://review.typo3.org/19032
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Frans Saris
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
6 years ago[TASK] Simplify propertyName-creation
Stefan Neufeind [Fri, 12 Apr 2013 20:12:07 +0000 (22:12 +0200)]
[TASK] Simplify propertyName-creation

Since PHP 5.3.0 function lcfirst() exists.

Resolves: #47171
Releases: 6.0, 6.1
Change-Id: I314ee3c14683283dc000daad41693294c12c62d2
Reviewed-on: https://review.typo3.org/19870
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[BUGFIX] Prevent building empty IN () query by throwing exception
Benjamin Bretz [Fri, 12 Apr 2013 15:30:45 +0000 (17:30 +0200)]
[BUGFIX] Prevent building empty IN () query by throwing exception

If $storagePageIds is empty Typo3DbBackend::addPageIdStatement()
InconsistentQuerySettingsException is thrown instead of creating
an invalid query

Fixes: #47167
Releases: 6.1, 6.0, 1.3
Change-Id: Ib52884573c9a09b791c0b090daaffc9b7d15b6a1
Reviewed-on: https://review.typo3.org/19861
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[TASK] Add caching layer for getTargetPidByPlugin
Georg Ringer [Fri, 12 Apr 2013 10:58:38 +0000 (12:58 +0200)]
[TASK] Add caching layer for getTargetPidByPlugin

The function getTargetPidByPlugin should use an internal
cache for reducing the load to the DB

Change-Id: Iec5ab7bc75b5a50c05bd814594dd3568a5beac73
Resolves: #36053
Releases: 6.1
Reviewed-on: https://review.typo3.org/19821
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[BUGFIX] Redirect-method in abstractController does not work with SSL
Rony Khoury [Wed, 27 Mar 2013 16:09:28 +0000 (17:09 +0100)]
[BUGFIX] Redirect-method in abstractController does not work with SSL

redirect method in AbstractController respect now the current url scheme.

Fixes: #46079
Releases: 6.1, 6.0, 4.7, 4.5
Change-Id: I1452483b93f3d892f3c6fa5f6c024097697bcdb2
Reviewed-on: https://review.typo3.org/19844
Reviewed-by: Wouter Wolters
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[BUGFIX] Translation of extbase-core
tomas [Mon, 1 Apr 2013 19:54:48 +0000 (21:54 +0200)]
[BUGFIX] Translation of extbase-core

Made massages from validators and property errors translatable.

Change-Id: I376f55a22d9e7d822146f0f935b1de24098b37cf
Fixes: #6538
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/16544
Reviewed-by: Georg Ringer
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] RespectStoragePage does not respect rootLevel
Stefan Frömken [Thu, 21 Feb 2013 15:41:48 +0000 (16:41 +0100)]
[BUGFIX] RespectStoragePage does not respect rootLevel

AdditionalWhereClause pid statement for set rootLevel=-1 will be empty,
and for rootLevel = 1 it will limit the query to pid = 0.
For not set rootLevel or rootLevel = 0 the given Pids are taken into
account.

Fixes: #45715
Releases: 6.1
Change-Id: I5f4cdc23273fef186d620e2596a0e3e1eab313ce
Reviewed-on: https://review.typo3.org/18425
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[TASK] Disable functional tests
Philipp Gampe [Sun, 7 Apr 2013 13:14:15 +0000 (15:14 +0200)]
[TASK] Disable functional tests

Extbase ships with a functional test class "FileContextTest" which
contains 10 tests. All those test fail currently.

The core does not (yet) have a strategy for functional tests.
As an intermediate solution, disable the functional tests.

They can be reactivated later if the core found a general concept for
functional tests.

Resolves: #47026
Releases: 6.1,6.0
Change-Id: I53136a8ac0e902658889daed12934340c88374fd
Reviewed-on: https://review.typo3.org/19733
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Update t3lib mentions
Christian Kuhn [Thu, 11 Apr 2013 17:57:14 +0000 (19:57 +0200)]
[TASK] Update t3lib mentions

Some core parts still mention t3lib classes after namespaces,
mostly in comments.

Related: #47138
Releases: 6.1

Change-Id: Ic3cb7119503e69b0914ef51b80360266ff3c2df8
Reviewed-on: https://review.typo3.org/19808
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] Property Mapper chokes on already-converted objects
Marc Neuhaus [Sat, 9 Feb 2013 23:21:49 +0000 (00:21 +0100)]
[BUGFIX] Property Mapper chokes on already-converted objects

Fixes also PropertyMappers chokes on already converted Objects if the
targetType is a compositeType like Collection<Entity>.
Backport from Flow issues #39445, #40661 and #36988

Change-Id: I8622dd9ef15a5e8e4aa98adc4e5b0def4a913ce1
Fixes: #44214
Fixes: #44215
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18172
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Marc Neuhaus
Reviewed-by: Markus Günther
Tested-by: Markus Günther
6 years ago[BUGFIX] Fix namespace in FileMountRepositoryTest
Alexander Schnitzler [Mon, 1 Apr 2013 16:41:31 +0000 (18:41 +0200)]
[BUGFIX] Fix namespace in FileMountRepositoryTest

Currently a "Tests\Unit" is missing in between.

Resolves: #46845
Releases: 6.1
Change-Id: I2cb4f7fedf826ff35b66ecd4ea600bc60b41123b
Reviewed-on: https://review.typo3.org/19498
Reviewed-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[TASK] Update copyright year to 2013
Alexander Schnitzler [Mon, 1 Apr 2013 14:14:49 +0000 (16:14 +0200)]
[TASK] Update copyright year to 2013

Changes "(c) 2010-2012" to "(c) 2010-2013"

Releases: 6.1
Resolves: #46840
Change-Id: I0a26a9a05cfc5697eb536016aee946ad970d82b3
Reviewed-on: https://review.typo3.org/19494
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
6 years agoRevert "[TASK] Make current persistence replaceable"
Alexander Schnitzler [Mon, 1 Apr 2013 13:28:26 +0000 (15:28 +0200)]
Revert "[TASK] Make current persistence replaceable"

This reverts commit 4d4b047e8eca2cfd86eef94954066f292277394f.

Conflicts:
Classes/Persistence/Generic/PersistenceManager.php
Tests/Unit/Persistence/RepositoryTest.php

Resolves: #46837
Releases: 6.1
Change-Id: I87914c6786d75ce217993cb6a70721b821bd0647
Reviewed-on: https://review.typo3.org/19488
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
6 years ago[BUGFIX] Native DateTime values cannot be mapped from storage
Oliver Hader [Mon, 11 Mar 2013 23:20:19 +0000 (00:20 +0100)]
[BUGFIX] Native DateTime values cannot be mapped from storage

DateTime values that are stored with an accordant (native) type
cannot be mapped correctly since a unix timestamp is expected.
The TCA configuration property 'dbType' for 'date' and
'datetime' fields reflects the non-timestamp way.

Change-Id: Ie694cf020a08ad91cc14982943b26705e5b128a9
Fixes: #46193
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/19450
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Steffen Ritter
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years agoRevert "[BUGFIX] Native DateTime values cannot be mapped from storage"
Oliver Hader [Sat, 30 Mar 2013 16:14:52 +0000 (17:14 +0100)]
Revert "[BUGFIX] Native DateTime values cannot be mapped from storage"

This reverts commit c21dc476bd18280f3d2985a48c2ce16bd09f3576

Change-Id: Idff5c59665839caf49c3df8115bf48c136380d40
Reviewed-on: https://review.typo3.org/19449
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[BUGFIX] Native DateTime values cannot be mapped from storage
Oliver Hader [Mon, 11 Mar 2013 23:20:19 +0000 (00:20 +0100)]
[BUGFIX] Native DateTime values cannot be mapped from storage

DateTime values that are stored with an accordant (native) type
cannot be mapped correctly since a unix timestamp is expected.
The TCA configuration property 'dbType' for 'date' and
'datetime' fields reflects the non-timestamp way.

Change-Id: I214c857bcb8b0380554b481870ab5f3556713226
Fixes: #46193
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/19009
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] FlashMessageContainer uses static flashMessageQueue
Christian Kuhn [Fri, 29 Mar 2013 13:26:46 +0000 (14:26 +0100)]
[BUGFIX] FlashMessageContainer uses static flashMessageQueue

Change-Id: I1a2078d71f21a812261ee1e3a6db8f1e7e90cafb
Resolves: #46774
Related: #44593
Releases: 6.1
Reviewed-on: https://review.typo3.org/19434
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Remove not maintained md5 in ext_emconf
Christian Kuhn [Tue, 26 Mar 2013 21:12:48 +0000 (22:12 +0100)]
[TASK] Remove not maintained md5 in ext_emconf

The serialized array _md5_values_when_last_written is not
maintained for core extensions since ages and just contains
a long string with outdated information.
It is set to an empty string now.

Change-Id: Iae1de150dd0da4ef9ccd993bdc0e75e5eb4c62c1
Resolves: #46699
Releases: 6.1
Reviewed-on: https://review.typo3.org/19324
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Table Mapping for File Model
Anja Leichsenring [Mon, 25 Mar 2013 07:23:11 +0000 (08:23 +0100)]
[TASK] Table Mapping for File Model

With the shipping of the File Model (#46102) Extbase needs to contain
the TypoScript table mapping for sys_file.

Resolves: #46635
Relates: #44012, #46102
Releases: 6.1, 6.0
Change-Id: Ie11ec9b1d339faa63fecd8db0938aaa2a765e1d4
Reviewed-on: https://review.typo3.org/19255
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[BUGFIX] TypoScript configuration not available in backend
Oliver Hader [Thu, 21 Mar 2013 18:14:46 +0000 (19:14 +0100)]
[BUGFIX] TypoScript configuration not available in backend

On bootstrapping and dispatching Extbase modules in the
backend, the frontend TypoScript is being parsed. However, if
the accordant page does not have any root template assigned, the
basic Extbase settings cannot be loaded and parsed. In a result,
e.g. persistence mappings for backend users are not available in
this situation.

The solution is to explicitly trigger the processing of the
extension static files (e.g. ext_typoscript_setup.txt) even if
there's no valid root template.

Change-Id: Ibdeba3f4a0c6303989d5393fee51c20bb6741ca0
Fixes: #46511
Related: #46250
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/19147
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[FEATURE] Use EnvironmentService to detect TYPO3_MODE in several places
Alexander Schnitzler [Mon, 18 Mar 2013 09:48:47 +0000 (10:48 +0100)]
[FEATURE] Use EnvironmentService to detect TYPO3_MODE in several places

In several places the TYPO3_MODE is still detected by
checking the TYPO3_MODE constant directly. This patch
replaces the checks by using the EnvironmentService.

Releases: 6.1
Resolves: #46396
Change-Id: I2f58e1ca175a86845beb053440428cc42f093847
Reviewed-on: https://review.typo3.org/19006
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[TASK] Rename methods in EnvironmentService
Alexander Schnitzler [Wed, 20 Mar 2013 20:28:48 +0000 (21:28 +0100)]
[TASK] Rename methods in EnvironmentService

Releases: 6.1
Resolves: #46478
Change-Id: Idbefdd38bbed5197fd3d3e012ae2f0ee5366576f
Reviewed-on: https://review.typo3.org/19117
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
6 years ago[BUGFIX] Fix wrong parenthesis in Typo3DbBackend
Anja Leichsenring [Fri, 8 Mar 2013 15:19:48 +0000 (16:19 +0100)]
[BUGFIX] Fix wrong parenthesis in Typo3DbBackend

Fixes an erroneously placed parenthesis in getObjectDataByQuery() for
retrieving the correct table name.

If dbal is in use, this leads to the reported failure.

Fixes: #46133
Relates: #43058
Releases: 6.1, 6.0, 4.7, 1.4, 1.3
Change-Id: I958dc954f0c1e11c6851e6d5dc2514e13d4eed31
Reviewed-on: https://review.typo3.org/18817
Reviewed-by: Markus Klein
Reviewed-by: Oliver Hader
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[FEATURE] Introduce methods to detect TYPO3_MODE properly
Alexander Schnitzler [Sun, 17 Mar 2013 21:31:08 +0000 (22:31 +0100)]
[FEATURE] Introduce methods to detect TYPO3_MODE properly

Currently a lot of conditions exist that directly
check for TYPO3_MODE to be "FE" or "BE". When it
comes to unit test this is pretty bad as constants
cannot be mocked at all.

Therefore this patch introduces two methods in the
ExtensionService to detect if the plugin is running
in frontend or backend mode.

Releases: 6.1
Resolves: #46391
Change-Id: I7367cda467ac2a421e0f8d6d25dd2209f939b99b
Reviewed-on: https://review.typo3.org/18995
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
6 years ago[TASK] Streamline creation of column maps
Alexander Schnitzler [Sat, 16 Mar 2013 14:27:42 +0000 (15:27 +0100)]
[TASK] Streamline creation of column maps

Currently the datamap factory calls "new ColumnMap" to create
a column map. This is bad as this cannot be mocked at all. A
method that handles the process of creation should be introduced,
also the object manager should be used to create the object.

Important:
This is neither a feature nor a bugfix but as it behaves like a
feature it will not be backported at all!

Releases: 6.1
Resolves: #46354
Change-Id: Ie27da180b05ba11d902da9c11185d41a3a4a8f05
Reviewed-on: https://review.typo3.org/18975
Reviewed-by: Mattias Nilsson
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[FEATURE] Providing Core Resource FileReference functionality
Benjamin Rau [Thu, 7 Mar 2013 12:19:25 +0000 (13:19 +0100)]
[FEATURE] Providing Core Resource FileReference functionality

Retrieve file information from Core\Resource by creating
a FAL resource object on the fly when needed.

You can access properties or getters of the object in Fluid
easily with the dot notation:

E.g.:

{myEntity.fileProperty.originalResource.title}
{myEntity.fileProperty.originalResource.properties.identifier}

Resolves: #46102
Releases: 6.1, 6.0
Change-Id: I33ff6a088e61715513446ae7600d3d21cbcfcd5a
Reviewed-on: https://review.typo3.org/18779
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[TASK] Remove obsolete doc comment check in reports module
Christian Kuhn [Thu, 14 Mar 2013 20:52:35 +0000 (21:52 +0100)]
[TASK] Remove obsolete doc comment check in reports module

The check for non-stripped doc comments is now done in the install
tool system check and obsolete within extbase.

Change-Id: Id3fc26f382044b417f928838073a5f33509bf218
Resolves: #46299
Related: #46219
Releases: 6.1
Reviewed-on: https://review.typo3.org/18926
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[!!!][FEATURE] Enable rewritten PropertyMapper as default
Anja Leichsenring [Thu, 14 Mar 2013 18:09:53 +0000 (19:09 +0100)]
[!!!][FEATURE] Enable rewritten PropertyMapper as default

After solving the missing security features and bugfixes
the rewritten PropertyMapper is now ready to be used in
production environments.

Resolves: #46293
Releases: 6.1
Change-Id: I810c2296d85158bcbc214ce5ddbd3dfd47d82a69
Reviewed-on: https://review.typo3.org/18915
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[!!!][BUGFIX] Remove support for TCA setting 'foreign_selector'
Helmut Hummel [Fri, 14 Dec 2012 10:53:07 +0000 (11:53 +0100)]
[!!!][BUGFIX] Remove support for TCA setting 'foreign_selector'

The TCA setting 'foreign_selector' is a UI feature which can be
configured for field in a relation table, when this table
is editable using the IRRE feature. Then a selector box
is rendered making it possible to select records from a child
table.

In this scenario the relation table itself may contain other
editable fields, which should be represented by a domain model.

The latter is currently not possible with Extbase because
'foreign_selector' triggers the DataMapper to resolve a
many to many relation to the child table.

Solution is to remove this behaviour and let the DataMapper
resolve the one to many relation to the relation table.

Find a test setup at https://gist.github.com/4284545

Change-Id: I2d8366f9ce54470999c1b02ad2098359f5aaa6b3
Fixes: #10770
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/17159
Reviewed-by: Thomas Maroschik
Reviewed-by: Sebastian Michaelsen
Tested-by: Sebastian Michaelsen
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Arjen Hoekema
Tested-by: Arjen Hoekema
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] TypeConverter can handle oldschool classnames
Anja Leichsenring [Tue, 5 Mar 2013 21:01:13 +0000 (22:01 +0100)]
[BUGFIX] TypeConverter can handle oldschool classnames

In case an extension provides oldschool classnames, the
setTypeConverterOptions functions fail due to mismatched arraykey.
This key is the classname of the converter.
Test for oldschool classnames and replace the arraykey with the
namespaced version solves the issue.

Fixes: #45977
Releases: 6.0, 6.1
Change-Id: I88debadda628ee166aea6ebdbf173a6239779303
Reviewed-on: https://review.typo3.org/18709
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[SECURITY] SQL Injection Possibility in Extbase
Felix Oertel [Wed, 6 Mar 2013 10:49:32 +0000 (11:49 +0100)]
[SECURITY] SQL Injection Possibility in Extbase

The Extbase persistence layer is vulnerable to SQL injection
due to improper sanitation of submitted arguments on relations
of the many-to-many type.

Fixes: #46057
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Change-Id: Ie5c9cf4a54260db937975edef61d464ddc808475
Security-Commit: 88fcf40028f0378948fd3572847a577aa91aaf76
Security-Bulletin: TYPO3-CORE-SA-2013-001
Reviewed-on: https://review.typo3.org/18735
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[BUGFIX] Prevent Extbase warnings accessing ObjectStorages with strings
Christian Kuhn [Wed, 27 Feb 2013 20:28:30 +0000 (21:28 +0100)]
[BUGFIX] Prevent Extbase warnings accessing ObjectStorages with strings

Feeding ObjectAccess->getPropertyPath() with an ObjectStorage raises
warnings, that might flood the errorLog quickly.

With the patch those warnings are prevented.
Additionaly the patch delivers a test scenario explaining the missing
ability to properly resolve the properny path, when it comes to
ObjectStorages.

Fixes: #37000
Releases: 6.1
Change-Id: I3acf5aef281894f06f1e35f45ac14ba692a90b3e
Reviewed-on: https://review.typo3.org/18527
Reviewed-by: Wouter Wolters
Reviewed-by: Pascal Dürsteler
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] BooleanValidator skips Validation with missing compare param
Anja Leichsenring [Tue, 5 Mar 2013 19:18:50 +0000 (20:18 +0100)]
[BUGFIX] BooleanValidator skips Validation with missing compare param

If no 'is' parameter is given, BooleanValidator skips testing and
returns TRUE. So all properties of type boolean not explicit assigned
to validation pass the test without limitation.

Fixes: #46031
Releases: 6.1
Change-Id: Ib484e35fbb90e3bb878ef5114cf65c05975d0d6e
Reviewed-on: https://review.typo3.org/18705
Reviewed-by: Jost Baron
Tested-by: Jost Baron
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] Prevent PHP errors with missing ColumnMap object
Alexander Schnitzler [Wed, 20 Feb 2013 09:47:31 +0000 (10:47 +0100)]
[BUGFIX] Prevent PHP errors with missing ColumnMap object

If the TCA configuration for an object is missing
no ColumnMap object is created by data mapper which leads
to PHP fatal errors in Typo3DbBackend.
Instead an Exception should be thrown.

This is a fixed version of the reverted commit reviewed in
https://review.typo3.org/16536

Releases: 6.0, 6.1
Fixes: #7267
Change-Id: Ie945d2e198c7ef8847a14a9c154c8bf7b8c372cf
Reviewed-on: https://review.typo3.org/18392
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] Fix tests for old property mapper
Anja Leichsenring [Sun, 24 Feb 2013 20:36:30 +0000 (21:36 +0100)]
[BUGFIX] Fix tests for old property mapper

The "fix" for failing tests after merging #42622
was to actually not test if the mapping works,
but only if the map method completes without errors.

Re-enable the correct test again.

Fixes: #45682
Releases: 6.1
Change-Id: I8ddabb1fce82f75b379c41aac7c959890f3ff56b
Reviewed-on: https://review.typo3.org/18462
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[FEATURE] Introducing a BooleanValidator.
Pascal Dürsteler [Wed, 27 Feb 2013 12:00:34 +0000 (13:00 +0100)]
[FEATURE] Introducing a BooleanValidator.

A validator for boolean fields, which takes an option to set expectations.

Resolves: #45880
Releases: 6.1
Change-Id: I2aaf7bec8847483646a8562e7ea3da416d088381
Reviewed-on: https://review.typo3.org/18512
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[FEATURE] TCA refactoring
Christian Kuhn [Thu, 14 Feb 2013 13:12:23 +0000 (14:12 +0100)]
[FEATURE] TCA refactoring

Follow up to core patch for extbase submodule

Related: #45767
Releases: 6.1
Change-Id: Ic1c17a322d89043e9ea84ce9ef9b29288254b2fd
Reviewed-on: https://review.typo3.org/18451
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Old property mapper shouldn't map other domain objects
Christian Kuhn [Thu, 21 Feb 2013 12:12:08 +0000 (13:12 +0100)]
[BUGFIX] Old property mapper shouldn't map other domain objects

The fix of issue #45622 opened the reflection service to handle
more object types. Now, the old property mapper stumbles upon that
and tries to map objects it did not handle before. For example the
sys_note extension now throws errors about broken mapping.
The patch restricts the old property mapper to object types it
handled before.

Change-Id: Id41f8c75944dc5e868d793a0831ebad98a12bb07
Resolves: #45705
Related: #45622
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18416
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] Fix tests throwing errors in MapperTest
Anja Leichsenring [Wed, 20 Feb 2013 21:30:06 +0000 (22:30 +0100)]
[BUGFIX] Fix tests throwing errors in MapperTest

Due to incomplete mocking of dependencies the tests for class Mapper
throw Errors after merging #45622.

Fixes: #45682
Releases: 6.0, 6.1
Change-Id: Ibd285acda2c85fdc3e441866f6429ccb1e130809
Reviewed-on: https://review.typo3.org/18407
Reviewed-by: Daniel Hürtgen
Tested-by: Daniel Hürtgen
6 years ago[BUGFIX] ReflectionService rejects classSchema for custom models
Anja Leichsenring [Tue, 19 Feb 2013 20:34:31 +0000 (21:34 +0100)]
[BUGFIX] ReflectionService rejects classSchema for custom models

The Extbase ReflectionService rejects to build a classSchema for
classes not extending AbstractEntity or AbstractValueObject.
Therefor it is not possible to use own Model constructs, that are
not persisted.

The according TYPO3 Flow class does not contain the restriction
to this inheritence/annotation.

Fixes: #45622
Releases: 6.0, 6.1
Change-Id: I46362d3d708f5b5e7e52f7ab0d17ed92a991a558
Reviewed-on: https://review.typo3.org/18383
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Markus Günther
Tested-by: Markus Günther
6 years agoRevert "[BUGFIX] Prevent sql errors with missing ColumnMap"
Anja Leichsenring [Tue, 19 Feb 2013 21:13:33 +0000 (22:13 +0100)]
Revert "[BUGFIX] Prevent sql errors with missing ColumnMap"

This reverts commit 0b899a43f2512d90c1db1e60f53b365071f7cea3

Change-Id: Iac88987a7022711d5407712eb9dddf6a6f553e71
Reviewed-on: https://review.typo3.org/18387
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years agoRevert "[TASK] Remove loadTCA calls"
Christian Kuhn [Wed, 13 Feb 2013 16:05:05 +0000 (17:05 +0100)]
Revert "[TASK] Remove loadTCA calls"

This reverts commit c2464e992668a0afbb8d8aa663324cec47275b94

Change-Id: I6bedfd6f4279c70d8d77dee6cd4cea5edab8828b
Related: #45107
Reviewed-on: https://review.typo3.org/18245
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Add foreign_match_fields support for one-to-x relations
Helmut Hummel [Sun, 10 Feb 2013 12:09:15 +0000 (13:09 +0100)]
[BUGFIX] Add foreign_match_fields support for one-to-x relations

The data mapper currently has no foreign_match_fields support for
one to one or one to many relations. This is critical even for 6.0 as
without it, the data mapper can not correctly map FAL relations.

Fixes: #45337
Releases: 6.0, 6.1
Change-Id: If8c5ecd64bca0f4c6dbb43445125bdad876ed7a8
Reviewed-on: https://review.typo3.org/18186
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[FEATURE] Make use of the ClassNamingUtility class
Anja Leichsenring [Mon, 10 Dec 2012 14:40:36 +0000 (15:40 +0100)]
[FEATURE] Make use of the ClassNamingUtility class

The Core got a new ClassNamingUtility, which provides a central place to
translate classnames. Extbase now uses this class in some places.

Resolves: #43836
Depends: #43052
Releases: 6.1
Change-Id: I29ae0215c403c7fb6456015ebf376b50919afb0f
Reviewed-on: https://review.typo3.org/17070
Reviewed-by: Markus Günther
Tested-by: Markus Günther
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
6 years ago[BUGFIX] Respect wildcard in PropertyConfiguration shouldMap()
Anja Leichsenring [Sun, 10 Feb 2013 10:39:14 +0000 (11:39 +0100)]
[BUGFIX] Respect wildcard in PropertyConfiguration shouldMap()

Using 'name.*' in property mapping configuration did not work for
fields added on the client, because shouldMap() would reject those
fields before the configuration was even checked.

This patch is a backport from Flow.

Fixes: #43928
Releases: 6.1, 6.0
Change-Id: I7fb71f705f242160700e8c082373f547d9cf72b5
Reviewed-on: https://review.typo3.org/18177
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
6 years ago[BUGFIX] Followup to issue #45323
Andreas Wolf [Sun, 10 Feb 2013 11:43:16 +0000 (12:43 +0100)]
[BUGFIX] Followup to issue #45323

Fix two places where create() was changed to get() on wrong objects.

Change-Id: I4bb79a14e280ce36fe7a6da28149f0e1212f2383
Related: #45323
Reviewed-on: https://review.typo3.org/18182
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Replace ObjectManager create with get
Marc Bastian Heinrichs [Sun, 10 Feb 2013 10:55:05 +0000 (11:55 +0100)]
[TASK] Replace ObjectManager create with get

Since Extbase ObjectManager::create is deprecated replace all
usages of the create method with get.

Change-Id: I4a438565d8512c8f892cef5b63fb6483fd74d712
Resolves: #45323
Releases: 6.1
Reviewed-on: https://review.typo3.org/18175
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
6 years ago[TASK] Sync objectmananger get and create with Flow
Marc Bastian Heinrichs [Sat, 9 Feb 2013 23:25:30 +0000 (00:25 +0100)]
[TASK] Sync objectmananger get and create with Flow

ObjectManager::create was deprecated since Flow beta1 and was
removed for Flow 1.0. To be in sync again deprecate Extbase
ObjectManager::create and use ObjectManager::get.

Change-Id: I5b92bae39ec63fdd985797ff03cb688ea6ff96d3
Resolves: #45322
Releases: 6.1
Reviewed-on: https://review.typo3.org/18162
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
6 years ago[TASK] Clean up Unit tests in extbase
Markus Günther [Sat, 9 Feb 2013 20:37:12 +0000 (21:37 +0100)]
[TASK] Clean up Unit tests in extbase

We had many tests in extbase that are incomplete.
These tests has been incomplete for several years.

Some test has been removed also in TYPO3 flow.

Change-Id: I75a20d1a1bac6fdeca79067acd5d00ad2db9f964
Fixes: #45330
Releases: 6.1
Reviewed-on: https://review.typo3.org/18169
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Reviewed-by: Oliver Klee
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[!!!][TASK] Remove forced STI settings from extbase configuration
Anja Leichsenring [Sat, 9 Feb 2013 18:19:13 +0000 (19:19 +0100)]
[!!!][TASK] Remove forced STI settings from extbase configuration

The tx_extbase_type setting for fe_users and fe_groups was introduced
as a demonstration of Single Table Inheritance handled in extbase.
The forced setting brings more problems then doing good in real live
scenarios though.

So the typoscript is dropped, but TCA and sql kept for backwards
compatibility reasons.

Before 6.1 only fe_users with tx_extbase_type
Tx_Extbase_Domain_Model_FrontendUser and
fe_groups with Tx_Extbase_Domain_Model_FrontendUserGroup
are returned. Since 6.1 all fe_users and fe_groups are
returned if you don't set the TypoScript setting on your own.

Resolves: #11021
Releases: 6.1
Change-Id: I8c1fbc48d4ee5ea1202ac6d7837170ff74eba442
Reviewed-on: https://review.typo3.org/17879
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[FEATURE] (MVC): Whitelist-based Property Mapping Configuration
Sebastian Kurfürst [Sat, 9 Feb 2013 21:04:35 +0000 (22:04 +0100)]
[FEATURE] (MVC): Whitelist-based Property Mapping Configuration

Up to now, property mapping in the rewritten property mapper always
allowed to modify all properties of a given object. Especially in the
MVC stack, this functionality was relied upon for all update and create
actions. However, for nested objects, the user needed to configure
whether updates and creations should be allowed.
This was an inconsistent behavior, especially because for read-only
actions the object could be also modified.
The behavior is now changed to be more predictive:
- the default PropertyMappingConfiguration used in the MVC stack is
  changed to be very restrictive: we do neither allow creation of any
  new objects nor modification of existing ones; and all properties
  which should be modified must be explicitly configured.
- For each form, Fluid now generates a list of trusted properties,
  based upon which the PropertyMappingConfiguration is set correctly.
  This means only properties which have been rendered by fluid are
  allowed to be modified, and creation / insertion is only permitted
  if needed.

(Excerpt from commit message of the original change in Flow)
https://review.typo3.org/#/c/10926/

This Patch is a 100% backport from this change with some needed
adjustments for the unit tests.

Change-Id: I6e59183a6ddfe83c65f975a2e2211e9ac33c5ccc
Resolves: #43057
Releases: 6.1
Reviewed-on: https://review.typo3.org/17092
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[TASK] Decouple BE module runner and Bootstrap
Andreas Wolf [Sat, 9 Feb 2013 19:00:38 +0000 (20:00 +0100)]
[TASK] Decouple BE module runner and Bootstrap

The Bootstrap class is currently registered as a dispatcher for backend
modules (called from mod.php). The dispatching is done in
Bootstrap::callModule(), which does not access the rest of the class
except run() (which is part of the public API).

To make the distinction more clear (and make different dispatchers
possible without logic fuckup), the module running code is moved
to a separate class ModuleRunner.

Change-Id: I7d7571d3204f9da927aa7c3d3cf0cca2b121ef15
Resolves: #45318
Releases: 6.1
Reviewed-on: https://review.typo3.org/18165
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[TASK] Improve Test
Anja Leichsenring [Sat, 9 Feb 2013 12:40:53 +0000 (13:40 +0100)]
[TASK] Improve Test

Refine the test for DateTimeConverter timezone handling.

The suggested backport from Flow Fluid was already in place, but the
improved test was missing.

Resolves: #44213
Releases: 6.1
Change-Id: I3c7d73c1bba8ebecc5d49020d155d5d27c256961
Reviewed-on: https://review.typo3.org/18155
Reviewed-by: Markus Günther
Tested-by: Markus Günther
Reviewed-by: Daniel Hürtgen
Reviewed-by: Wouter Wolters
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
6 years ago[TASK] Add FileReference table mapping in extbase configuration
Anja Leichsenring [Fri, 14 Dec 2012 12:58:58 +0000 (13:58 +0100)]
[TASK] Add FileReference table mapping in extbase configuration

Extbase ships the FileReference model, but using it as a property
type causes a SQL error mentioning the table can not be found.

So adding the mapping to the extbase TypoScript configuration
resolves this problem.

Change-Id: I6d9452918dd78f767592aeafc9620e5ffc2880cc
Resolves: #44012
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/17160
Reviewed-by: Stefan Neufeind
Reviewed-by: Ingo Pfennigstorf
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Provide unit test for Mvc/Response
Alexander Schnitzler [Fri, 25 Jan 2013 12:41:38 +0000 (13:41 +0100)]
[TASK] Provide unit test for Mvc/Response

Releases: 6.1
Resolves: #44804
Change-Id: Iaaaaa1e10915ec7527bf89605b557fa7f75d2df3
Reviewed-on: https://review.typo3.org/17701
Reviewed-by: Mattias Nilsson
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Günther
Tested-by: Markus Günther
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Improve code coverage of Mvc/Request
Alexander Schnitzler [Fri, 25 Jan 2013 12:48:02 +0000 (13:48 +0100)]
[TASK] Improve code coverage of Mvc/Request

Currently two important methods "getControllerObjectName"
and "setControllerObjectName" aren't tested at all. This
patch provides tests for both.

Releases: 6.1
Resolves: #44805
Change-Id: I3bcbfc72c5b77da3d876489dd4423c79823171c1
Reviewed-on: https://review.typo3.org/17702
Reviewed-by: Daniel Hürtgen
Tested-by: Daniel Hürtgen
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[FEATURE] Allow different overriding of object mapping per plugin
Alexander Schnitzler [Thu, 29 Nov 2012 14:05:36 +0000 (15:05 +0100)]
[FEATURE] Allow different overriding of object mapping per plugin

Currently the ObjectContainer has an array with a mapping of
class names to actual classes which allows the replacement
of objects via DI.

This mapping is set during the bootstrap process and uses the
typoscript settings in config.tx_extbase.objects which is too
strict. To be able to ovverride these settings for each plugin
extbase has to use 'CONFIGURATION_TYPE_FRAMEWORK' settings
instead of 'CONFIGURATION_TYPE_FULL_TYPOSCRIPT' settings.

Releases: 6.1
Resolves: #44796
Change-Id: I5d6ea135f5bec586073da3394f0ba8e0197020b7
Reviewed-on: https://review.typo3.org/17696
Reviewed-by: Mattias Nilsson
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Remove loadTCA calls
Christian Kuhn [Tue, 5 Feb 2013 18:38:13 +0000 (19:38 +0100)]
[TASK] Remove loadTCA calls

Change-Id: I3de34fcaee7f5a3e973ccf203973d15c9a0e467d
Related: #45107
Releases: 6.1
Reviewed-on: https://review.typo3.org/18027
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Alphanumeric validator fails with broken PCRE
Christian Kuhn [Sat, 26 Jan 2013 19:20:56 +0000 (20:20 +0100)]
[BUGFIX] Alphanumeric validator fails with broken PCRE

After change from #44216 the alphanumeric filter fails on
systems like debian squeeze with PHP 5.3.3 due to a broken
PCRE environment.

Change-Id: I349385c13c5b9757d879d483ec7e625501e32e88
Resolves: #44832
Related: #44216
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/17734
Reviewed-by: Wouter Wolters
Reviewed-by: Daniel Hürtgen
Tested-by: Daniel Hürtgen
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] RepositoryTest raises warning
Christian Kuhn [Sat, 26 Jan 2013 19:06:31 +0000 (20:06 +0100)]
[BUGFIX] RepositoryTest raises warning

The change for issue #42506 introduced an incomplete mocking
of the Query object, now throwing warnings about missing
constructor() parameters. Fix is to not call the constructor.

Next to that, a minor namespace is fixed.

Change-Id: I7f3645549aeed97d5e11f44a17152441eb9bbad9
Resolves: #44833
Related: #42506
Releases: 6.1
Reviewed-on: https://review.typo3.org/17733
Reviewed-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] ConfigurationManager must use namespaced FrontendSimulator
Alexander Schnitzler [Fri, 25 Jan 2013 13:19:24 +0000 (14:19 +0100)]
[BUGFIX] ConfigurationManager must use namespaced FrontendSimulator

Since TYPO3 6.0 all classes are namespaced.
Though a compatibility layer exists all calls on old
class names should be avoided, so this patch replaces
calls on Tx_Extbase_Utility_FrontendSimulator with
\TYPO3\CMS\Extbase\Utility\FrontendSimulatorUtility.

Releases: 6.1, 6.0
Fixes: #44806
Change-Id: I60dd5f4fee8d5df8a79bb931e946a867b0083291
Reviewed-on: https://review.typo3.org/17703
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[TASK] Provide Unit Test for Scheduler/Task
Alexander Schnitzler [Fri, 18 Jan 2013 13:38:02 +0000 (14:38 +0100)]
[TASK] Provide Unit Test for Scheduler/Task

Releases: 6.1
Resolves: #44638
Change-Id: Ibb522e3618b647f05a16b15fd114937ce482dcbd
Reviewed-on: https://review.typo3.org/17589
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] Ordering without grouping is incompatible with non-MySQL DBMS
Ingo Pfennigstorf [Sat, 8 Sep 2012 20:04:13 +0000 (22:04 +0200)]
[BUGFIX] Ordering without grouping is incompatible with non-MySQL DBMS

Each SELECT COUNT(*) statement has orderings. This fixes the
behaviour that is incompatible to database systems other than
MySQL and also is not needed as only an integer is returned.

Thanks to Xavier Perseguers for the patch.

Change-Id: I81a51dc6a7978434ef8e7751d7c72823e88fe550
Fixes: #25873
Releases: 1.3, 1.4, 4.7, 6.0
Reviewed-on: https://review.typo3.org/14461
Reviewed-by: Xavier Perseguers
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Xavier Perseguers
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[TASK] Provide Unit Test for Scheduler/TaskExecuter
Alexander Schnitzler [Sat, 19 Jan 2013 14:59:13 +0000 (15:59 +0100)]
[TASK] Provide Unit Test for Scheduler/TaskExecuter

Releases: 6.1
Resolves: #44664
Change-Id: I9ba89e1acc98082cceb7561c394dad1488cbe888
Reviewed-on: https://review.typo3.org/17598
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years agoRevert "[FEATURE] Allow different overriding of object mapping per plugin"
Alexander Schnitzler [Sat, 19 Jan 2013 19:45:14 +0000 (20:45 +0100)]
Revert "[FEATURE] Allow different overriding of object mapping per plugin"

This reverts commit fecb7b1b32629283aa932cde38bdd26ee94dcf8d.

Releases: 6.1
Change-Id: I448b1fd0638a86ab31705be1c87056bc082b0dc8
Reviewed-on: https://review.typo3.org/17597
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
6 years ago[TASK] Improve code coverage of Scheduler/FieldProvider
Alexander Schnitzler [Fri, 18 Jan 2013 15:57:01 +0000 (16:57 +0100)]
[TASK] Improve code coverage of Scheduler/FieldProvider

* Also fixed a small bug in Cli/Command.php

Releases: 6.1
Resolves: #44650
Change-Id: Ic9cc4ebb81a3926415223f6a7a8078198a39f1ab
Reviewed-on: https://review.typo3.org/17592
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[TASK] Increase code coverage of FrontendConfigurationManager
Alexander Schnitzler [Fri, 18 Jan 2013 18:11:11 +0000 (19:11 +0100)]
[TASK] Increase code coverage of FrontendConfigurationManager

Releases: 6.1
Resolves: #44656
Change-Id: If39fb33a3a3d4cffca3f74f5f15d4a44ebf0e152
Reviewed-on: https://review.typo3.org/17593
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[TASK] Increase code coverage of Service/TypeHandlingService
Alexander Schnitzler [Thu, 17 Jan 2013 17:07:27 +0000 (18:07 +0100)]
[TASK] Increase code coverage of Service/TypeHandlingService

Added one missing tests to achieve 100% code coverage.
Also adjusted the copyright header.

Releases: 6.1
Resolves: #44612
Change-Id: If543b055c139d63edcb8960e7e0f89875017bdf3
Reviewed-on: https://review.typo3.org/17581
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
6 years ago[TASK] Increase code coverage of SignalSlot/Dispatcher
Alexander Schnitzler [Thu, 17 Jan 2013 16:15:11 +0000 (17:15 +0100)]
[TASK] Increase code coverage of SignalSlot/Dispatcher

Added some missing tests to achieve 100% code coverage.
Also adjusted the copyright header and author annotations.

Releases: 6.1
Resolves: #44611
Change-Id: I9ffb474b5cd44d30c9eff49ae37ab55f5f68a5ce
Reviewed-on: https://review.typo3.org/17580
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
6 years ago[TASK] Provide Unit Test for Error/Message
Alexander Schnitzler [Thu, 17 Jan 2013 13:42:14 +0000 (14:42 +0100)]
[TASK] Provide Unit Test for Error/Message

Releases: 6.1
Resolves: #44603
Change-Id: Iceb69ccb6b5097cf6c8cf9d7ff0d3fe440ac9d8e
Reviewed-on: https://review.typo3.org/17578
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[FEATURE] Provide UnitTest.xml with code coverage generation
Alexander Schnitzler [Thu, 17 Jan 2013 12:58:44 +0000 (13:58 +0100)]
[FEATURE] Provide UnitTest.xml with code coverage generation

This patch provides a basic setup for running extbase unit
test through one xml file that also collects code coverage
data whoose output will be stored in Build/Coverage.

Releases: 6.1
Resolves: #44601
Change-Id: I51f5c4c85d22a82848172b4716267d08d1b2f0f5
Reviewed-on: https://review.typo3.org/17576
Reviewed-by: Ingo Pfennigstorf
Tested-by: Ingo Pfennigstorf
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[TASK] Rename property, getter and setters of File Model
Helmut Hummel [Thu, 8 Nov 2012 15:45:37 +0000 (16:45 +0100)]
[TASK] Rename property, getter and setters of File Model

To be in line with TYPO3 Flow, rename the properties from
non speaking "object" to "originalResource"

This change did not make it into 6.0 final, but still should
be part of the 6.0 branch. Since the file models were not
usable anyway because of a bug in the data mapper
(see #10770), it's safe to rename these.

Resolves: #44255
Releases: 6.0, 6.1

Change-Id: Id9efe02a80e29e1ac6a4f6697f104bfb59e51399
Reviewed-on: https://review.typo3.org/17287
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Reviewed-by: Mattias Nilsson
Reviewed-by: Stefan Neufeind
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[FEATURE] Add userGroups to backendUser model
Markus Günther [Fri, 17 Aug 2012 23:07:05 +0000 (01:07 +0200)]
[FEATURE] Add userGroups to backendUser model

This patch adds the new BackendUserGroup model as property to the new
BackendUser model. The patch adds the usual methods for a
SplObjectStorage and the corresponding unit tests

Change-Id: I047361810eeb48c53483c99ed0a79966d0dd0e00
Resolves: #39329
Releases: 6.1
Reviewed-on: https://review.typo3.org/13879
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
6 years ago[FEATURE] Add filemount property to backend users
Markus Günther [Fri, 17 Aug 2012 23:49:12 +0000 (01:49 +0200)]
[FEATURE] Add filemount property to backend users

This patch set adds the new extbase filemount model as property to the
backend user model.

Change-Id: I8ed292fa4c38794a13ca62ee85f7767e16dc80e5
Resolves: #39324
Releases: 6.1
Reviewed-on: https://review.typo3.org/13880
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Oliver Klee
Reviewed-by: Markus Günther
Tested-by: Markus Günther
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] Remove newline after ?> in AbstractController
Alexander Schnitzler [Mon, 7 Jan 2013 20:43:04 +0000 (21:43 +0100)]
[BUGFIX] Remove newline after ?> in AbstractController

The last commit added a newline again. This patch
removes it again.

Releases: 6.1
Fixes: #44366
Change-Id: I4bd33dc7947a64f975183f49eeffa3412f5c4d42
Reviewed-on: https://review.typo3.org/17406
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
6 years ago[BUGFIX] Avoid clearing the page cache too often
Alexander Schnitzler [Fri, 4 Jan 2013 18:38:21 +0000 (19:38 +0100)]
[BUGFIX] Avoid clearing the page cache too often

Instead of clearing the page cache on every
create, update and delete action, implement
a page id stack which will be cleared at the
end of the request.

Releases: 6.1, 6.0
Fixes: #6117
Change-Id: I3703011e6cd2db9c6a4f32ba27ef09ecb25954f3
Reviewed-on: https://review.typo3.org/17373
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Stefan Neufeind
Reviewed-by: Markus Günther
Tested-by: Markus Günther
6 years ago[BUGFIX] Correct indention of class comment
Anja Leichsenring [Sun, 6 Jan 2013 15:24:42 +0000 (16:24 +0100)]
[BUGFIX] Correct indention of class comment

Fixes: #44343
Releases: 6.1
Change-Id: I4acc9b50d7534f16ba7dca8bbdb34de1db3beac0
Reviewed-on: https://review.typo3.org/17394
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] Suppress debug output of debugger in unit tests
Alexander Schnitzler [Sun, 6 Jan 2013 09:57:42 +0000 (10:57 +0100)]
[BUGFIX] Suppress debug output of debugger in unit tests

Currently the debug output will be rendered which
leads to printed css if testing unit tests on the
command line.

Releases: 6.0
Fixes: #44335
Change-Id: Ie25c8f6cfe7380739d34a270ea2a0b3984e168e2
Reviewed-on: https://review.typo3.org/17388
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] Fix failing tests in ActionControllerTest
Anja Leichsenring [Sun, 6 Jan 2013 09:38:07 +0000 (10:38 +0100)]
[BUGFIX] Fix failing tests in ActionControllerTest

Introduction of signals into ActionController caused
some Unit Tests to fail. This patch injects the missing
SignalSlotDispatcher into those tests.

Fixes: #44334
Releases: 6.1
Change-Id: I44cfa71070442a83e2259d57743353dcaba0f3e7
Reviewed-on: https://review.typo3.org/17383
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
6 years agoRevert "[FEATURE] Introduce beforeCallActionMethod signal"
Anja Leichsenring [Sun, 6 Jan 2013 09:28:45 +0000 (10:28 +0100)]
Revert "[FEATURE] Introduce beforeCallActionMethod signal"

This reverts commit f0614b4c7f7dc566889ea3de7d400f81ebb82740

Change-Id: Ic8908fb9cd959639f4f41ce5c35330ecfd521b6b
Reviewed-on: https://review.typo3.org/17382
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[FEATURE] Introduce beforeCallActionMethod signal
Alexander Schnitzler [Fri, 4 Jan 2013 12:28:28 +0000 (13:28 +0100)]
[FEATURE] Introduce beforeCallActionMethod signal

This patch introduces a signal for hooking in
right before calling the action method of the
controller. The slots are given the controller
name, the action name and the action arguments.

Relases: 6.1
Resolves: #7397
Change-Id: I09fbf75356060b4a0129c12ff2087e686016e442
Reviewed-on: https://review.typo3.org/17380
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[FEATURE] Introduce beforeCallActionMethod signal
Alexander Schnitzler [Fri, 4 Jan 2013 12:28:28 +0000 (13:28 +0100)]
[FEATURE] Introduce beforeCallActionMethod signal

This patch introduces a signal for hooking in
right before calling the action method of the
controller. The slots are given the controller
name, the action name and the action arguments.

Relases: 6.1, 6.0
Resolves: #7397
Change-Id: Ieaa27be80b187f5b6b60296404079febac663bd2
Reviewed-on: https://review.typo3.org/17364
Reviewed-by: Mattias Nilsson
Reviewed-by: Wouter Wolters
Reviewed-by: Daniel Hürtgen
Tested-by: Daniel Hürtgen
Reviewed-by: Stefan Neufeind
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] Prevent sql errors with missing ColumnMap
Alexander Schnitzler [Sat, 17 Nov 2012 16:59:08 +0000 (17:59 +0100)]
[BUGFIX] Prevent sql errors with missing ColumnMap

If the TCA configuration for an object is missing
no ColumnMap can be generated which leads to sql
errors in method addUnionStatement in Typo3DbBackend.
Instead an Exception should be thrown.

Releases: 6.0, 6.1
Fixes: #7267
Change-Id: Ie364d2199be3d1e0128811e0cc41ff7ad210324b
Reviewed-on: https://review.typo3.org/16536
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
6 years ago[BUGFIX] DebuggerUtility does not rewind instances of Iterator
Alexander Schnitzler [Sat, 5 Jan 2013 09:44:05 +0000 (10:44 +0100)]
[BUGFIX] DebuggerUtility does not rewind instances of Iterator

Debugging a collection like ObjectStorage changes
the internal collection pointer which leads to the
collection being invalid.

Fixes: #43955
Releases: 6.1, 6.0, 4.7
Change-Id: I8258640c3ef7e2a7a4c53d608e673f59eecdeab1
Reviewed-on: https://review.typo3.org/17374
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] Make AlphanumericValidator work with umlauts
Alexander Schnitzler [Fri, 4 Jan 2013 17:14:45 +0000 (18:14 +0100)]
[BUGFIX] Make AlphanumericValidator work with umlauts

Changes the regular expression used to validate the
string into a unicode-aware character-class and adds
a tests for this.

Backport of: https://review.typo3.org/#/c/9923/

Releases: 6.1, 6.0
Fixes: #44216
Change-Id: I85b77691ed7eea04972d834bb5fd083555872eee
Reviewed-on: https://review.typo3.org/17370
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
6 years ago[BUGFIX] Use interface in PersistenceManager::injectQueryFactory
Alexander Schnitzler [Fri, 4 Jan 2013 12:58:24 +0000 (13:58 +0100)]
[BUGFIX] Use interface in PersistenceManager::injectQueryFactory

Currently PersistenceManager::injectQueryFactory
expects a concrete implementation of QueryFactory
instead of an descendant of QueryFactoryInterface.

Releases: 6.1
Fixes: #32026
Change-Id: I1f25a4fdf692e144e5b5773ee7d25beca3e44444
Reviewed-on: https://review.typo3.org/17365
Reviewed-by: Mattias Nilsson
Reviewed-by: Wouter Wolters
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
6 years ago[BUGFIX] Use interface in Mapper::injectQueryFactory
Alexander Schnitzler [Fri, 4 Jan 2013 16:25:32 +0000 (17:25 +0100)]
[BUGFIX] Use interface in Mapper::injectQueryFactory

Currently Mapper::injectQueryFactory expects a
concrete implementation of QueryFactory instead
of an descendant of QueryFactoryInterface.

Releases: 6.1
Fixes: #35936
Change-Id: Ie4a0cac10e866d8a41497ca31d915c8b1b2d66df
Reviewed-on: https://review.typo3.org/17369
Reviewed-by: Ralf Merz
Reviewed-by: Wouter Wolters
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
6 years ago[CLEANUP] Remove newlines after closing php tag
Alexander Schnitzler [Mon, 17 Dec 2012 08:34:00 +0000 (09:34 +0100)]
[CLEANUP] Remove newlines after closing php tag

During the last commits some newlines made it
into extbase again. This patch removes them all.

Releases: 6.1
Fixes: #44042
Change-Id: Ifd2fe5e27c71e9ba93b5449b029cc381754c44ee
Reviewed-on: https://review.typo3.org/17185
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
6 years ago[FEATURE] Allow different overriding of object mapping per plugin
Alexander Schnitzler [Thu, 29 Nov 2012 14:05:36 +0000 (15:05 +0100)]
[FEATURE] Allow different overriding of object mapping per plugin

Currently the ObjectContainer has an array with a mapping of
class names to actual classes which allows the replacement
of objects via DI.

This mapping is set during the bootstrap process and uses the
typoscript settings in config.tx_extbase.objects which is too
strict. To be able to ovverride these settings for each plugin
extbase has to use 'CONFIGURATION_TYPE_FRAMEWORK' settings
instead of 'CONFIGURATION_TYPE_FULL_TYPOSCRIPT' settings.

Releases: 6.1
Resolves: #43450
Change-Id: I067b19769e007578cea406964fc568dcf5727b7a
Reviewed-on: https://review.typo3.org/16855
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[TASK] Make current persistence replaceable
Alexander Schnitzler [Thu, 15 Nov 2012 15:01:19 +0000 (16:01 +0100)]
[TASK] Make current persistence replaceable

Releases: 6.1
Fixes: #42506
Change-Id: I409dec8eec58f512c1f2ce4d090816eb595bbcc5
Reviewed-on: https://review.typo3.org/16461
Reviewed-by: Mattias Nilsson
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] Deprecated functions used in on fresh 6.0 final
Stefan Froemken [Tue, 11 Dec 2012 21:20:05 +0000 (22:20 +0100)]
[BUGFIX] Deprecated functions used in on fresh 6.0 final

There are some deprecated function calls I have
changed to the new functions

Resolves: #43528
Releases: 6.0, 6.1
Change-Id: I1acde2c8250192732030d2137e251ac79e5db81d
Reviewed-on: https://review.typo3.org/17116
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
6 years ago[CLEANUP] Remove all @author annotations
Alexander Schnitzler [Tue, 11 Dec 2012 15:14:41 +0000 (16:14 +0100)]
[CLEANUP] Remove all @author annotations

Also adjusted some operators for jenkins

Releases: 6.1
Resolves: #43887
Change-Id: I5e6ba540d7d828bd24417356b887182966fb581c
Reviewed-on: https://review.typo3.org/17102
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[CLEANUP] Replace wrong/old file copyright comments
Alexander Schnitzler [Tue, 11 Dec 2012 13:35:00 +0000 (14:35 +0100)]
[CLEANUP] Replace wrong/old file copyright comments

All files should have the same file comment with the
same copyright notice in it. Also there must not be
an author any more. Instead the Extbase Team is
mentioned as author from now on.

Releases: 6.1
Fixes: #43883
Change-Id: Ib61859a2fa853a238907df314f948da51306d7e8
Reviewed-on: https://review.typo3.org/17099
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring