Packages/TYPO3.CMS.git
4 years ago[TASK] Improve retrieving distribution list 82/39182/3
Nicole Cordes [Sat, 2 May 2015 09:12:35 +0000 (11:12 +0200)]
[TASK] Improve retrieving distribution list

If you open the "Get preconfigured distribution" extension manager
function the extension list is retrieved twice. Furthermore database
queries are executed multiple times. This patch improves retrieving the
extension list, prevents database queries and catches thrown errors to
prevent errors.

Releases: master, 6.2
Resolves: #66730
Change-Id: Ice1bd36e1233fde121bb33232f98a4e25480b0e0
Reviewed-on: http://review.typo3.org/39182
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Make Url/EmailViewHelper compilable 65/39165/2
Jan Helke [Fri, 1 May 2015 18:03:50 +0000 (20:03 +0200)]
[TASK] Make Url/EmailViewHelper compilable

Resolves: #66715
Releases: master
Change-Id: Iac1648be8a6898077d42844003c194bb17f85f17
Reviewed-on: http://review.typo3.org/39165
Reviewed-by: Dirk Jüttner <dirk.juettner@gmail.com>
Tested-by: Dirk Jüttner <dirk.juettner@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Implement CompileableInterface for SwitchViewHelper 70/39170/4
Christian Müller [Fri, 1 May 2015 18:54:26 +0000 (20:54 +0200)]
[TASK] Implement CompileableInterface for SwitchViewHelper

Allows the SwitchViewHelper to be compiled into cached templates.
Until now using the SwitchViewHelper would result in the template
not being compiled at all. With this change that is no longer the
case.

Releases: master
Resolves: #66718
Change-Id: I5c34c1f770ec73c0296054905b65301af9de7c1b
Reviewed-on: http://review.typo3.org/39170
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Optimize implementation of CompilableInterface 79/39179/3
Frank Nägler [Fri, 1 May 2015 22:05:40 +0000 (00:05 +0200)]
[BUGFIX] Optimize implementation of CompilableInterface

In some cases the implementation of CompilableInterface is not correct.
Implementing renderStatic and compile at the same time makes no sense.
This patch removes the renderStatic method in case compile is implemented too.

Resolves: #66726
Related: #66711
Releases: master
Change-Id: Idd7db07f5386c840ca3877b22748c9ed35efa426
Reviewed-on: http://review.typo3.org/39179
Reviewed-by: Dirk Jüttner <dirk.juettner@gmail.com>
Tested-by: Dirk Jüttner <dirk.juettner@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Prevent wrong information after extension upload 81/39181/2
Nicole Cordes [Sat, 2 May 2015 08:58:45 +0000 (10:58 +0200)]
[BUGFIX] Prevent wrong information after extension upload

If you upload an extension it is extracted and installed in separate
steps. If the extraction was successful a flash message is rendered.
If the installation fails the whole extension is removed again but the
flash message is still visible. This patch separates flash message output
for upload and installation process.

Releases: master, 6.2
Resolves: #66729
Change-Id: I6d84d8ecebd55a989a34c1024300916e33af66a7
Reviewed-on: http://review.typo3.org/39181
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Travis: functionals not allowed_failure anymore 77/39177/3
Christian Kuhn [Fri, 1 May 2015 20:15:43 +0000 (22:15 +0200)]
[TASK] Travis: functionals not allowed_failure anymore

I don't always code, but when I do it's functional.

Releases: master
Change-Id: Ifec41da9a344f7ec64c1a5d0c88b1f7f078b6fd1
Reviewed-on: http://review.typo3.org/39177
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Dirk Jüttner <dirk.juettner@gmail.com>
Tested-by: Dirk Jüttner <dirk.juettner@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Add more unit tests to GeneralUtility::trimExplode 26/38526/12
Stefan Froemken [Wed, 8 Apr 2015 06:37:10 +0000 (08:37 +0200)]
[TASK] Add more unit tests to GeneralUtility::trimExplode

Add unit tests to GeneralUtility::trimExplode in preparation of a
performance improvement patch. Test with whitespaces and alternative
delimiters.

Related: #66317
Resolves: #66323
Releases: master
Change-Id: I1fc12996fb3f990deb405f84f1c2758b1b1ce3a2
Reviewed-on: http://review.typo3.org/38526
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[TASK] Make HtmlspecialcharsViewHelper compilable 67/39167/3
dirk_juettner [Fri, 1 May 2015 18:26:31 +0000 (20:26 +0200)]
[TASK] Make HtmlspecialcharsViewHelper compilable

Resolves: #66711
Releases: master
Change-Id: Ie2954aafe8c2f087709ece7fb3c128f656bcbf9c
Reviewed-on: http://review.typo3.org/39167
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[BUGFIX] Race condition in Unit / FunctionalTestBootstrap 71/39171/2
Christian Kuhn [Fri, 1 May 2015 18:42:38 +0000 (20:42 +0200)]
[BUGFIX] Race condition in Unit / FunctionalTestBootstrap

Executing tests in parallel sometimes leads to race conditions
preparing the environment. This rare case is now just suppressed
and shut off.

Resolves: #66720
Releases: master
Change-Id: I63de8c8cf8460772d0896f1957701f053ca82590
Reviewed-on: http://review.typo3.org/39171
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[TASK] Makes Format/UrlencodeViewHelper compilable 63/39163/2
Jan Helke [Fri, 1 May 2015 17:19:49 +0000 (19:19 +0200)]
[TASK] Makes Format/UrlencodeViewHelper compilable

Resolves: #66713
Releases: master
Change-Id: Ia079f24e86df63dbd8467e5750d660739af1beb7
Reviewed-on: http://review.typo3.org/39163
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[TASK] Makes Format/HtmlentitiesDecodeViewHelper compilable 62/39162/5
Jan Helke [Fri, 1 May 2015 16:27:47 +0000 (18:27 +0200)]
[TASK] Makes Format/HtmlentitiesDecodeViewHelper compilable

Resolves: #66710
Releases: master
Change-Id: I13d0df90c4d3e03af31d9cb3c4a081136fdd96e3
Reviewed-on: http://review.typo3.org/39162
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[FOLLOWUP] Fix override field handling in form engine 69/39169/2
Helmut Hummel [Fri, 1 May 2015 18:42:46 +0000 (20:42 +0200)]
[FOLLOWUP] Fix override field handling in form engine

Remove duplicate code.

Resolves: #66705
Releases: master
Change-Id: Ib38862f30f85f7528166c7c3597fe2357dfa50f2
Reviewed-on: http://review.typo3.org/39169
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[BUGFIX] Fix override field handling in form engine 57/39157/4
Helmut Hummel [Fri, 1 May 2015 14:33:24 +0000 (16:33 +0200)]
[BUGFIX] Fix override field handling in form engine

The override field handling was broken since the form engine
refactoring. This change applies several fixes
to make it work again.

Resolves: #66705
Releases: master
Change-Id: I7cd83952d130a7a1e875b75bcd093bf51a9904d6
Reviewed-on: http://review.typo3.org/39157
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Make NumberViewHelper compilable 61/39161/6
Markus Sommer [Fri, 1 May 2015 16:21:52 +0000 (18:21 +0200)]
[TASK] Make NumberViewHelper compilable

Resolves: #66712
Releases: master
Change-Id: I49a446ecabf0893e6231e687744cfad0fada1135
Reviewed-on: http://review.typo3.org/39161
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[FOLLOWUP] Use GeneralUtility::quoteJSvalue() where needed part 1 59/39159/4
Nicole Cordes [Fri, 1 May 2015 14:55:59 +0000 (16:55 +0200)]
[FOLLOWUP] Use GeneralUtility::quoteJSvalue() where needed part 1

Fix accidentally quoted JavaScript links.

Releases: master
Resolves: #66706
Relates: #66115
Change-Id: Icf23b5f3a9b9a9a3cd206a9201b38d64d5fc62fd
Reviewed-on: http://review.typo3.org/39159
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[CLEANUP] Add htmlspecialchars in some form elements 29/35429/4
Frank Nägler [Sun, 14 Dec 2014 16:55:30 +0000 (17:55 +0100)]
[CLEANUP] Add htmlspecialchars in some form elements

Resolves: #63843
Releases: master
Change-Id: I4b736b76d4a8e92f54d0ec3961f93030737ffe39
Reviewed-on: http://review.typo3.org/35429
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[FEATURE] Allow page title edit by double-click 67/38367/10
Andreas Fernandez [Tue, 31 Mar 2015 08:39:08 +0000 (10:39 +0200)]
[FEATURE] Allow page title edit by double-click

If a user has proper permissions, the page title can
be edited in "Page" and "List" module by double-clicking on the header.
The header will transform into a form which sends an ajax request
after saving.

Resolves: #66173
Releases: master
Change-Id: I93f03f8e86ae708cdc973cc0a3a8c6399b122428
Reviewed-on: http://review.typo3.org/38367
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Deprecate public DataHandler->checkValue_*-methods 38/35238/13
Stephan Großberndt [Wed, 10 Dec 2014 13:29:48 +0000 (14:29 +0100)]
[TASK] Deprecate public DataHandler->checkValue_*-methods

Instead of passing all parameters from DataHandler->checkValue_SW to
the checkValue_*-methods in an array $PP, pass only those actually
needed by each function.

In order to stay compatible keep the public checkValue_*-methods
(now unused in core and deprecated) and introduce new protected
methods checkValueFor* instead, called from checkValue_SW.

Resolves: #63735
Releases: master
Change-Id: I463c35e5361310f401ca5e0cc9833e6cbebfff9f
Reviewed-on: http://review.typo3.org/35238
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[BUGFIX] Persistent classes with more than five name parts in extbase 49/38749/3
Artus Kolanowski [Thu, 16 Apr 2015 19:10:09 +0000 (21:10 +0200)]
[BUGFIX] Persistent classes with more than five name parts in extbase

Resolve the table name of a corresponding class correctly when the name
has more than five parts.

This avoids unexpected SQL syntax errors when you have a full qualified
class names like "\Vendor\Extension\Domain\Model\Foo\Bar\Baz".

Resolves: #66425
Releases: master, 6.2
Change-Id: If31fe53bc34a3b2f2080732b2a0237d3480de79f
Reviewed-on: http://review.typo3.org/38749
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[FEATURE] Add integrity property to JavaScript files 32/39132/2
Xavier Perseguers [Fri, 1 May 2015 07:43:23 +0000 (09:43 +0200)]
[FEATURE] Add integrity property to JavaScript files

Add a property 'integrity="some-hash"' to JavaScript files via TypoScript
page.includeJSlibs.<array>.integrity = some-hash

This patch affects the TypoScript PAGE properties
* includeJSlibs
* includeJSFooterlibs
* includeJS
* includeJSFooter

Resolves: #66698
Releases: master
Change-Id: I82b6aaaf424d7056844912f7194f88e01a972ec3
Reviewed-on: http://review.typo3.org/39132
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[FOLLOWUP] Use GeneralUtility::quoteJSvalue() where needed part 1 49/39149/2
Helmut Hummel [Fri, 1 May 2015 10:52:29 +0000 (12:52 +0200)]
[FOLLOWUP] Use GeneralUtility::quoteJSvalue() where needed part 1

Fix accidentally quoted global JavaScript variable in edit links.

Resolves: #66115
Releases: master
Change-Id: Iecc0ee98f2ad020153dc6ace168cdc9511fe2a77
Reviewed-on: http://review.typo3.org/39149
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
4 years ago[BUGFIX] Prevent sorting incomplete loaded packages 33/39133/2
Nicole Cordes [Fri, 1 May 2015 08:52:43 +0000 (10:52 +0200)]
[BUGFIX] Prevent sorting incomplete loaded packages

If an extension is defined in PackageStates.php but missing in file
system the package gets unloaded and the PackageStates.php is rewritten.
If a core extension is missing (e.g. extra_page_cm_options) the file
is rewritten with incomplete loaded package information and gets wrongly
sorted.

Releases: master, 6.2
Resolves: #66699
Change-Id: I18e4bb83cf1676537a45ea4b07b9228335e34ec7
Reviewed-on: http://review.typo3.org/39133
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Add index key to sys_category_record_mm 85/36385/7
Bodo Eichstädt [Thu, 29 Jan 2015 20:35:30 +0000 (21:35 +0100)]
[TASK] Add index key to sys_category_record_mm

Add an index covering uid_foreign, fieldname and tablename.

Resolves: #55689
Releases: master
Change-Id: Ifc1037f6253e94ab3eae12f57edef7e41700e3f3
Reviewed-on: http://review.typo3.org/36385
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Dirk Jüttner <dirk.juettner@gmail.com>
Tested-by: Dirk Jüttner <dirk.juettner@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Use GeneralUtility::quoteJSvalue() where needed part 1 24/38324/10
Wouter Wolters [Sat, 28 Mar 2015 16:19:18 +0000 (17:19 +0100)]
[TASK] Use GeneralUtility::quoteJSvalue() where needed part 1

Extension backend is done with this patch except FormEngine
classes.

Resolves: #66115
Releases: master
Change-Id: I0dc335b0193566b9d14e4b8fdafc116a81e0f5cc
Reviewed-on: http://review.typo3.org/38324
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] FormEngine: FlexForm section container not saved 10/39110/2
Christian Kuhn [Thu, 30 Apr 2015 16:32:33 +0000 (18:32 +0200)]
[BUGFIX] FormEngine: FlexForm section container not saved

Naming prefixes in flex form section container handling is changed
to successfully save them again.

Resolves: #66663
Releases: master
Change-Id: I8268a4cd9860c4b17a54e05ba2aa86190fa7eda2
Reviewed-on: http://review.typo3.org/39110
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[!!!][FEATURE] Integrate Symfony/Console into CommandController 43/30743/11
Wouter Wolters [Mon, 16 Jun 2014 12:32:12 +0000 (14:32 +0200)]
[!!!][FEATURE] Integrate Symfony/Console into CommandController

This is a backport from the new introduced feature in Flow
https://review.typo3.org/#/c/30653/ with upstream patches.

This extends the base ``CommandController`` by some convenience
helpers from the ``symfony/console`` package:
easy output coloring through "<error>Warning!</error>"
TableHelper to render values to a grid
ProgressHelper to render and advance and progress bars
DialogHelper with numerous types of questions like: select,
ask, confirm, askHidden, etc
Additionally this change improves the
``mapRequestArgumentsToControllerArguments()`` method to ask for
missing required arguments instead of quitting with an exception.
You can make use of the new features by calling the introduced
ConsoleOutput object with its respective methods:
outputTable()
select()
ask()
askConfirmation()
askHiddenResponse()
askAndValidate()
askHiddenResponseAndValidate()
progressStart()
progressSet()
progressAdvance()
progressFinish()

This change does not alter the public API so it is not breaking
in the strict sense. But it introduces a new behavior:
Previously all outputs where collected in the ``Cli\Response``
and only rendered to the console at the end of a CLI request.
Now all methods producing output (inluding ``output()`` and
``outputLine()``) render the result directly to the console.
If you use ``$this->response`` directly or let the command method
return a string, the rendering is still deferred until the end of
the CLI request.

Resolves: #59606
Releases: master
Change-Id: I33e051f698f5cc1e204f609734280bbed69610c9
Reviewed-on: http://review.typo3.org/30743
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] FormEngine: Type input eval userfunc not called in JS 91/39091/2
Christian Kuhn [Thu, 30 Apr 2015 13:13:29 +0000 (15:13 +0200)]
[BUGFIX] FormEngine: Type input eval userfunc not called in JS

It is possible to add custom JS as eval function for type input. This
is no longer called after FormEngine refactoring due to an additional
quoteJSvalue() that is missing in the reference.

Resolves: #66689
Releases: master
Change-Id: I31c7b1f01e37e21aa4bf6d27f324cb522be74fe5
Reviewed-on: http://review.typo3.org/39091
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
4 years ago[BUGFIX] Cannot use equal operator on data type text 86/39086/2
Xavier Perseguers [Thu, 30 Apr 2015 12:50:29 +0000 (14:50 +0200)]
[BUGFIX] Cannot use equal operator on data type text

MSSQL does not allow a column of type "text" to be compared with
an equal operator. It fails with:

    The data types text and varchar are incompatible in the equal to operator

Change-Id: I59e955e53127854fb44ec1af9d81388801438222
Releases: master, 6.2
Resolves: #66686
Reviewed-on: http://review.typo3.org/39086
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
4 years ago[TASK] Do not use sequence table when uid field is auto-incremented 79/39079/2
Xavier Perseguers [Thu, 30 Apr 2015 10:43:42 +0000 (12:43 +0200)]
[TASK] Do not use sequence table when uid field is auto-incremented

A sequence table should not be used when the underlying ADOdb driver
is capable of properly using and retrieving auto-incremented fields.

Change-Id: I8d474e253c927d2dcb4d6ebc9ad6eb5bb4d06f2d
Releases: master, 6.2
Resolves: #66680
Reviewed-on: http://review.typo3.org/39079
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
4 years ago[BUGFIX] ADOdb: mssqlnative driver fails to create sequences 75/39075/2
Xavier Perseguers [Thu, 30 Apr 2015 09:56:29 +0000 (11:56 +0200)]
[BUGFIX] ADOdb: mssqlnative driver fails to create sequences

Change-Id: Ie251d2b9776be4d7c8d3a450cfa1252a57ce07a3
Resolves: #66678
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/39075
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
4 years ago[BUGFIX] Adhere absRefPrefix for storages 89/38889/2
Markus Klein [Thu, 23 Apr 2015 22:46:41 +0000 (00:46 +0200)]
[BUGFIX] Adhere absRefPrefix for storages

If plain images from local storages are rendered to FE,
absRefPrefix will now be applied correctly.

Resolves: #66496
Releases: master, 6.2
Change-Id: I9c7c4590d5ca53bb4669da383462dfa63f7ab3ab
Reviewed-on: http://review.typo3.org/38889
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] exec_SELECTcountRows where clause must not be empty 70/39070/2
Xavier Perseguers [Thu, 30 Apr 2015 08:25:27 +0000 (10:25 +0200)]
[BUGFIX] exec_SELECTcountRows where clause must not be empty

When using DBAL, the where clause of database query must not be
left empty. exec_SELECTcountRows() defaults to an empty string
and causes the Install Tool to fail to create the tables for the
extension manager.

Change-Id: I9fd66147bf662bbf7e527860756d83ca247a2260
Resolves: #66675
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/39070
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
4 years ago[TASK] Travis: Mark functionals as allowed_failure 73/39073/2
Christian Kuhn [Thu, 30 Apr 2015 09:42:01 +0000 (11:42 +0200)]
[TASK] Travis: Mark functionals as allowed_failure

With mysql 5.6 we still see various mysql issues that come from
travis infrastructure. We're currently unable to fix this. To have
a green build for now, functional tests are separated and marked
as allowed_failure until stuff is sorted out on travis side.
Patch is for master only at the moment, 6.2 may get an own change
if problems persist.

Releases: master
Change-Id: I9513c8894d7737c09a47588dc9efddd4e9e140e3
Reviewed-on: http://review.typo3.org/39073
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] MSSQL native driver for ADOdb returns erroneous message 69/39069/3
Xavier Perseguers [Thu, 30 Apr 2015 08:15:33 +0000 (10:15 +0200)]
[BUGFIX] MSSQL native driver for ADOdb returns erroneous message

When no errors are found in a query, the MSSQL native driver for ADOdb
returns an invalid error message "No errors found" instead of an empty
string. This causes TYPO3 to take the non-empty string as an actual
error.

Change-Id: I09474747cd4733576464792d5d59212e87778e8a
Resolves: #66674
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/39069
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
4 years ago[BUGFIX] FormEngine exception and warning creating new record 17/39017/2
Christian Kuhn [Tue, 28 Apr 2015 15:43:56 +0000 (17:43 +0200)]
[BUGFIX] FormEngine exception and warning creating new record

Some extensions like ext:news use ';;;;2-2-2' in TCA showItem which is
actually an invalid syntax. FormEngine detects this and throws an
exception. To mitigate the issue, the exception is commented out for
now and a @todo is added on how this case could be handled later.

Another warning in flex form container / section handling is fixed
with the patch by sanitizing the given row data to an array, which
is not always the case, for example if adding a new record.

Resolves: #66628
Related: #63846
Releases: master
Change-Id: Ib6dcba0c5e2c1dad8c842e99994ab97e456deb41
Reviewed-on: http://review.typo3.org/39017
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[CLEANUP] Link validator: LinkHandler 31/38631/3
Markus Klein [Sat, 11 Apr 2015 09:11:17 +0000 (11:11 +0200)]
[CLEANUP] Link validator: LinkHandler

Releases: master
Resolves: #66375
Change-Id: Ic61889d6fadd3ec8196ccf96ad97e5247e804ab5
Reviewed-on: http://review.typo3.org/38631
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
4 years ago[FOLLOWUP][TASK] Introduce getter for $GLOBALS['LANG'] in EXT:cshmanual 51/39051/3
Michael Oehlhof [Tue, 28 Apr 2015 22:57:25 +0000 (00:57 +0200)]
[FOLLOWUP][TASK] Introduce getter for $GLOBALS['LANG'] in EXT:cshmanual

Fixes an issue mentioned by http://scrutinizer-ci.com/g/DFAU/TYPO3.CMS

Resolves: #66638
Releases: master
Change-Id: Ifad658b07fe5024b8cdaeae657a3ce637af8af80
Reviewed-on: http://review.typo3.org/39051
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Make sure excludedTablesAndFields are empty in DataHandler 84/38684/5
Benjamin Serfhos [Tue, 14 Apr 2015 07:56:14 +0000 (09:56 +0200)]
[BUGFIX] Make sure excludedTablesAndFields are empty in DataHandler

Simulating the admin function when saving their own account failed when
TCA is modified. The backend user is now simulated as admin, instead of
the DataHandler class only.

Now it validates all possible checks when updating the user records as
admin.

Note: This will keep the same functionality and therefor has no impact
on the Core itself.

Releases: master, 6.2
Resolves: #66412
Change-Id: Ib17ac99d9e7a4aaf1e807b41b30f7310ad8da655
Reviewed-on: http://review.typo3.org/38684
Reviewed-by: Benjamin Serfhos <serfhos@gmail.com>
Tested-by: Benjamin Serfhos <serfhos@gmail.com>
Reviewed-by: Jesper Paardekooper <jesper.paardekooper@gmail.com>
Tested-by: Jesper Paardekooper <jesper.paardekooper@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[!!!][TASK] House of forms 33/38433/40
Christian Kuhn [Fri, 13 Mar 2015 13:43:53 +0000 (14:43 +0100)]
[!!!][TASK] House of forms

This patch introduces a structural code refactoring to the
FormEngine class and its related friend classes.

FormEngine used to call itself over and over again with itself
and sub classes writing to public properties of FormEngine keeping
a global state that is then magically merged to sometimes working
output.

The patch introduces a tree approach with lots of small containers
doing an encapsulated part of the rendering process and calling
sub containers for inner details.
As main construct a "globalOptions" array is modified in containers
and given down to sub containers (tree knots) or elements (leaves),
while sub structures always return a defined array that is
merged by the parent and accumulates the full result.
Goal is to have a better encapsulated code structure with better
visible impact on changes done to this system.

The patch creates this main structure. There is still a lot of
mess around and additional patches can further improve the overall
situation with smaller changes.

Change-Id: I56b898dc0eaae8de4d31016997cfefe8d14ec53e
Releases: master
Resolves: #63846
Resolves: #63854
Resolves: #63856
Resolves: #63858
Resolves: #63859
Resolves: #63860
Resolves: #63861
Resolves: #63862
Resolves: #63863
Resolves: #63865
Resolves: #63876
Resolves: #63881
Resolves: #63882
Resolves: #63883
Resolves: #63893
Reviewed-on: http://review.typo3.org/38433
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Set TYPO3 version to 7.3-dev 93/38993/2
Benjamin Mack [Tue, 28 Apr 2015 11:44:57 +0000 (13:44 +0200)]
[TASK] Set TYPO3 version to 7.3-dev

Change-Id: Ie9edd14d2d55c1731f69d6f6b15e04e9528efc28
Reviewed-on: http://review.typo3.org/38993
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Improve usability by adding filters to TCA fields 82/38982/2
Georg Ringer [Tue, 28 Apr 2015 08:35:48 +0000 (10:35 +0200)]
[TASK] Improve usability by adding filters to TCA fields

To improve the usability of the backend, filters should be provided where it makes
sense, especially where it is likely to have more records.

- FE Groups: Subgroup selection
- FE User: Group selection
- BE User: Group selection

Resolves: #66621
Releases: master
Change-Id: I483c22487f89f79f313bd72e0bb6fce49efab3fa
Reviewed-on: http://review.typo3.org/38982
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Shorten namespace for FlashMessage in ext:setup 11/38911/2
Wouter Wolters [Fri, 24 Apr 2015 19:10:53 +0000 (21:10 +0200)]
[TASK] Shorten namespace for FlashMessage in ext:setup

Resolves: #66585
Releases: master
Change-Id: If8c79dcab8553848a276691b7e20ce1d38ca107f
Reviewed-on: http://review.typo3.org/38911
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
4 years ago[TASK] Remove unused CSH initialization in ext:taskcenter 09/38909/2
Wouter Wolters [Fri, 24 Apr 2015 18:48:15 +0000 (20:48 +0200)]
[TASK] Remove unused CSH initialization in ext:taskcenter

Resolves: #66583
Releases: master
Change-Id: I9e28156562bf56612eebd91dba0d61616f8170ea
Reviewed-on: http://review.typo3.org/38909
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
4 years ago[FEATURE] Add stdWrap strtotime 29/35029/12
Mathias Brodala [Thu, 4 Dec 2014 11:32:03 +0000 (12:32 +0100)]
[FEATURE] Add stdWrap strtotime

This allows for conversion of formatted dates to timestamp and
complements the existing date/strftime properties.

Resolves: #63561
Releases: master
Change-Id: I4e41cabc70979da5746f5b119ab2096bdd9e0c6e
Reviewed-on: http://review.typo3.org/35029
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Jo Hasenau <info@cybercraft.de>
Tested-by: Jo Hasenau <info@cybercraft.de>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
4 years ago[RELEASE] Release of TYPO3 7.2.1 86/38986/2
TYPO3 Release Team [Tue, 28 Apr 2015 10:03:41 +0000 (12:03 +0200)]
[RELEASE] Release of TYPO3 7.2.1

Change-Id: I794e721bd23246fd2eed923d3a88d2334de62394
Reviewed-on: http://review.typo3.org/38986
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
4 years ago[TASK] Set TYPO3 version to 7.2.1-dev 85/38985/2
TYPO3 Release Team [Tue, 28 Apr 2015 09:57:30 +0000 (11:57 +0200)]
[TASK] Set TYPO3 version to 7.2.1-dev

Change-Id: I90e56b8dbfffc46b40700fed333b03496847cc98
Reviewed-on: http://review.typo3.org/38985
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
4 years ago[RELEASE] Release of TYPO3 7.2.0 84/38984/2 7.2.0 TYPO3_7-2-0
TYPO3 Release Team [Tue, 28 Apr 2015 09:56:56 +0000 (11:56 +0200)]
[RELEASE] Release of TYPO3 7.2.0

Change-Id: I61d66ccd2f4bb031b0a98b45dbfbdfcc3e6c0a1b
Reviewed-on: http://review.typo3.org/38984
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
4 years ago[BUGFIX] Correct path for redirect to Installer 73/38973/3
Markus Klein [Mon, 27 Apr 2015 19:49:39 +0000 (21:49 +0200)]
[BUGFIX] Correct path for redirect to Installer

Resolves: #66615
Releases: master
Change-Id: Ia8497f963b8e4189df1e43b93624db57bedf0e54
Reviewed-on: http://review.typo3.org/38973
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[FOLLOWUP] Clean up 7.x documentation 67/38967/2
Xavier Perseguers [Mon, 27 Apr 2015 16:55:58 +0000 (18:55 +0200)]
[FOLLOWUP] Clean up 7.x documentation

There are still a few inconsistencies in the way titles are written.

This patch also corrects some errors which happen upon rendering
to HTML (wrong code blocks).

Change-Id: I09105c94eaed6e8d96d0ae489f95b4e7a19ffd82
Releases: master
Resolves: #66613
Reviewed-on: http://review.typo3.org/38967
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
4 years ago[BUGFIX] Show correct timezone when displaying FormEngine time field 12/38112/15
Andreas Allacher [Wed, 25 Mar 2015 15:40:08 +0000 (16:40 +0100)]
[BUGFIX] Show correct timezone when displaying FormEngine time field

"time" and "timesec" fields currently do not store time as UTC in database,
however, in the FormEngine modifications time was also handled
as being stored in UTC which results in time fields being stored and
then being modified with +/- x hours, depending on server time.
This patch reverts the behaviour back to store times as server-time.

However, in the future it would be good to store those values as UTC too,
but that will require more changes and would also be a breaking change.

Change-Id: I6c299bfa3d0387081f00c6cba7723e10236fabf0
Resolves: #65976
Releases: master
Reviewed-on: http://review.typo3.org/38112
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Jan Helke <typo3@helke.de>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Multiple fixes for Locking API and TSFE locking 40/38840/13
Markus Klein [Tue, 21 Apr 2015 00:33:04 +0000 (02:33 +0200)]
[BUGFIX] Multiple fixes for Locking API and TSFE locking

* Retrieve correct LockingStrategy for requested capabilities
* Prefix lock filenames to make them better visible in the folder
* Make all LockStrategies destroyable
* Semaphore locking now uses ftok() to generate a unique id
* Make the Mbox lock independent of the target file
* Introduce an access lock for each of the TSFE cache locks

We decrease the priority of Semaphore locking since this can
be pretty dangerous for the average user. If something goes
really wrong in the webserver (which is out of our control),
we might leave behind stale semaphores, which might cause
a permanent deadlock for an instance, which can only be resolved
by a server admin.
We might raise the priority again at a later point in time,
when we can provide better means of cleanup.

The new access locks protects the access to the cache locks in TSFE
now, which allows us to safely remove those cache locks after using
them. This way we don't spam the system with loads of locks.

Releases: master
Resolves: #66503
Change-Id: Ia19e6e7d47d7941e01785f5a6b67746a6c0fa368
Reviewed-on: http://review.typo3.org/38840
Reviewed-by: Andreas Allacher <andreas.allacher@gmx.at>
Tested-by: Andreas Allacher <andreas.allacher@gmx.at>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[FOLLOWUP] Clean up 7.2 documentation 64/38964/2
Francois Suter [Mon, 27 Apr 2015 15:39:32 +0000 (17:39 +0200)]
[FOLLOWUP] Clean up 7.2 documentation

An index file is missing in the 7.2 change log to have a TOC
for navigating in 7.2 documentation.

This patch also corrects some errors which happen upon rendering
to HTML (wrong code blocks, missing lexer argument, missing
Intersphinx references for cross-links).

Resolves: #66612
Releases: master
Change-Id: If53632fc50694b330253fdab9cf9a81ba7bf13ec
Reviewed-on: http://review.typo3.org/38964
Reviewed-by: Francois Suter <francois@typo3.org>
Tested-by: Francois Suter <francois@typo3.org>
4 years ago[BUGFIX] Simplify composer class alias loader usage 55/38955/3
Helmut Hummel [Mon, 27 Apr 2015 12:47:39 +0000 (14:47 +0200)]
[BUGFIX] Simplify composer class alias loader usage

The class alias loader package was changed to be a composer plugin.
By that, the script section can be removed again.

In addition we change the requirement to the minimum version which
contains the plugin conversion.

Releases: 6.2, master
Resolves: #65688
Change-Id: I2ca1eee56e9a3f9e1f538ab95d9a01544ea98c95
Reviewed-on: http://review.typo3.org/38955
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[BUGFIX] getProcessedValue ignores foreign_table_field 35/37035/9
Andreas Allacher [Fri, 20 Feb 2015 08:29:45 +0000 (09:29 +0100)]
[BUGFIX] getProcessedValue ignores foreign_table_field

Currently BackendUtility::getProcessedValue method
ignores the foreign_table field.
This is basically a follow-up to commit:
c47c35744adb8b3243cbff5c91dc40672bec93f2

Change-Id: Ia08878a7a3cdcf7e1a0743c7ce84251a0b82fd82
Resolves: #63557
Related: #62755
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/37035
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Stephan Jorek <stephan.jorek@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Store page title information in cache 52/38852/4
Markus Klein [Tue, 21 Apr 2015 16:36:40 +0000 (18:36 +0200)]
[BUGFIX] Store page title information in cache

Store page title information in page cache as well,
so we have a proper state when rendering partially cached pages.

On those pages *_INT objects might be present, which modify
the title and this has to be handled correctly.

Releases: master, 6.2
Resolves: #66499
Change-Id: If03568d36bd847c9a4ca41881a1723f6f1de7671
Reviewed-on: http://review.typo3.org/38852
Reviewed-by: Andreas Allacher <andreas.allacher@gmx.at>
Tested-by: Andreas Allacher <andreas.allacher@gmx.at>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
4 years ago[TASK] Backend login: unify logo and bg image path example 23/38923/3
Felix Kopp [Sun, 26 Apr 2015 22:22:30 +0000 (00:22 +0200)]
[TASK] Backend login: unify logo and bg image path example

Explains the accepted login logo and background image paths
"EXT:…" or "fileadmin/…" or "/fileadmin/…".

Resolves: #66476
Releases: master
Change-Id: I68824eca21601ed69e96fe5ee9fc5472b889f314
Reviewed-on: http://review.typo3.org/38923
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
4 years ago[TASK] Protect configuration of extensions 21/38921/3
Jan Kiesewetter [Sun, 26 Apr 2015 07:24:10 +0000 (09:24 +0200)]
[TASK] Protect configuration of extensions

Similar to protecting the private resources, the configuration
of an extension should be protected as well.

Change-Id: Ib68cb77ea21e8ec192927d1c9c62a30c1bb7103f
Releases: master, 6.2
Resolves: #66573
Reviewed-on: http://review.typo3.org/38921
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Jan Kiesewetter <jan@t3easy.de>
Tested-by: Jan Kiesewetter <jan@t3easy.de>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[FOLLOWUP][TASK] New Login Screen 26/38926/6
Benjamin Kott [Sun, 26 Apr 2015 12:58:08 +0000 (14:58 +0200)]
[FOLLOWUP][TASK] New Login Screen

- Resolve image paths equally without fal compat layer
- Remove border if background image is set
- Increase border radius

Releases: master
Resolves: #66431
Change-Id: Icf5217c46467268f67d4e7fd91903e916535ebfa
Reviewed-on: http://review.typo3.org/38926
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[TASK] Remove "max" attribute from datetime fields in TCA 25/38925/3
Andreas Fernandez [Sun, 26 Apr 2015 12:57:04 +0000 (14:57 +0200)]
[TASK] Remove "max" attribute from datetime fields in TCA

It's not required to limit the maxlength of datetime fields
by TCA anymore, as the used DateTimePicker already validates
the values.

Releases: master
Resolves: #66593
Change-Id: Ib2ab070c907e790c7b23a4cacf3cd11aa5e219fc
Reviewed-on: http://review.typo3.org/38925
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[FOLLOWUP][BUGFIX] Date and DateTimePicker in IE 22/38922/2
Benjamin Kott [Sun, 26 Apr 2015 10:55:12 +0000 (12:55 +0200)]
[FOLLOWUP][BUGFIX] Date and DateTimePicker in IE

Fixed wrong LESS path.

Releases: master
Resolves: #65055
Change-Id: I2d95775e2796e8b1fdff67430b287230699690de
Reviewed-on: http://review.typo3.org/38922
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Proofread 7.2 documentation 72/38872/4
Mathias Schreiber [Thu, 23 Apr 2015 11:47:57 +0000 (13:47 +0200)]
[BUGFIX] Proofread 7.2 documentation

Proofread breaking, deprecations and features.

Releases: master
Resolves: #66553
Change-Id: I08c497e53bd90845940fb536ca17e90a9fde20c9
Reviewed-on: http://review.typo3.org/38872
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
4 years ago[BUGFIX] Fix wrong image reference in ext:taskcenter 10/38910/2
Wouter Wolters [Fri, 24 Apr 2015 18:56:42 +0000 (20:56 +0200)]
[BUGFIX] Fix wrong image reference in ext:taskcenter

Path to image does not exists, rename it to the existing png file.

Furthermore this patch shortens a few namespaces and uses
GeneralUtility::quoteJSvalue for the url in openInNewWindow function.

Resolves: #66584
Releases: master
Change-Id: I9b17aafae6a4f94ddefa5d012c447b8eacc0495d
Reviewed-on: http://review.typo3.org/38910
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
4 years ago[BUGFIX] Complete Iframe-Progressbar in IE 87/38887/2
Benjamin Kott [Thu, 23 Apr 2015 21:21:24 +0000 (23:21 +0200)]
[BUGFIX] Complete Iframe-Progressbar in IE

Releases: master
Resolves: #66563
Change-Id: I23be4cab776252afff25f3f23c8fee2f4c09fad5
Reviewed-on: http://review.typo3.org/38887
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Date and DateTimePicker in IE 85/38885/3
Benjamin Kott [Thu, 23 Apr 2015 19:21:00 +0000 (21:21 +0200)]
[BUGFIX] Date and DateTimePicker in IE

Releases: master
Resolves: #65055
Change-Id: I342cf15602ccd3d7769144eea031ba450e7033e4
Reviewed-on: http://review.typo3.org/38885
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Properly set checked attribute for objects 68/35668/9
Mathias Brodala [Tue, 30 Dec 2014 09:12:45 +0000 (10:12 +0100)]
[BUGFIX] Properly set checked attribute for objects

This makes sure the checked attribute is properly set by the
CheckboxViewHelper for a list of objects.

Resolves: #64057
Releases: master, 6.2
Change-Id: I7b25d2086b8e1d436730283e30a6df0eda34712a
Reviewed-on: http://review.typo3.org/35668
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
4 years ago[BUGFIX] getPageOverlayHook has to use GeneralUtility::getUserObj 76/38876/4
Andreas Allacher [Thu, 23 Apr 2015 13:35:29 +0000 (15:35 +0200)]
[BUGFIX] getPageOverlayHook has to use GeneralUtility::getUserObj

The introduction of getPagesOverlay in
commit f6f12f0fcfef0b565a4fcb9f31dd6e780c828ed
modified the hook to use GeneralUtility::makeInstance instead of
GeneralUtility::getUserObj which is a breaking change.

We revert this change now, and use GeneralUtility::getUserObj again.

Change-Id: I43521b85308a69cdafb8fbc5a374d2b99dc22875
Resolves: #66557
Related: #64258
Releases: master
Reviewed-on: http://review.typo3.org/38876
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Make openid login working again 63/38863/4
Markus Klein [Wed, 22 Apr 2015 19:24:22 +0000 (21:24 +0200)]
[BUGFIX] Make openid login working again

This reverts commit c6f16016a8ac5fcfe6df47015151e141a681e0c3.

Resolves: #66399
Releases: master
Change-Id: If884c5a6cb0849605e1e7706358ed7e8471f73d0
Reviewed-on: http://review.typo3.org/38863
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Christian Weiske <christian.weiske@netresearch.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Rename TCA type image_manipulation to imageManipulation 60/38860/2
Frans Saris [Wed, 22 Apr 2015 14:52:06 +0000 (16:52 +0200)]
[TASK] Rename TCA type image_manipulation to imageManipulation

Resolves: #66543
Releases: master
Change-Id: Ie4875f729913a372f7f50b5b5b63df51475e710a
Reviewed-on: http://review.typo3.org/38860
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
4 years ago[BUGFIX] Keep scheduler functional after task interruption 56/38856/3
Xavier Perseguers [Wed, 22 Apr 2015 13:15:56 +0000 (15:15 +0200)]
[BUGFIX] Keep scheduler functional after task interruption

If the execution of a task was interrupted (e.g., for debugging
purpose with Xdebug), the scheduler module may not open up again
and fails with a PHP warning.

Change-Id: I8d28d2094eeff941b2c09788480e8b79bef766f1
Releases: master, 6.2
Resolves: #66537
Reviewed-on: http://review.typo3.org/38856
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
4 years ago[BUGFIX] Use API to register AJAX handler for recycler 62/38862/3
Markus Klein [Wed, 22 Apr 2015 19:15:02 +0000 (21:15 +0200)]
[BUGFIX] Use API to register AJAX handler for recycler

Releases: master
Resolves: #66546
Change-Id: Ic64205454a511efbd2b32a1eb7763e4ff0a653fd
Reviewed-on: http://review.typo3.org/38862
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] dbFileIcons: Show UID for internal_type db 39/38239/3
Andreas Allacher [Thu, 26 Mar 2015 13:04:42 +0000 (14:04 +0100)]
[BUGFIX] dbFileIcons: Show UID for internal_type db

The UID value for show_thumbs needs to be shown for internal_type db,
and not for internal_type file,folder, ...

Change-Id: Iea97d5b03ece19562e9834147f1ce601f2e9e039
Resolves: #66044
Releases: master
Reviewed-on: http://review.typo3.org/38239
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
4 years ago[BUGFIX] Remove superfluous linebreaks in CE preview 98/38798/2
Markus Klein [Sun, 19 Apr 2015 11:54:02 +0000 (13:54 +0200)]
[BUGFIX] Remove superfluous linebreaks in CE preview

Releases: master
Resolves: #66479
Change-Id: I93ac0eed83cf3a4dc26239a66b2ff69cd37d7580
Reviewed-on: http://review.typo3.org/38798
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] compatibility6: add class alias for backend_cacheActionsHook 51/38851/3
Andreas Allacher [Tue, 21 Apr 2015 14:35:45 +0000 (16:35 +0200)]
[BUGFIX] compatibility6: add class alias for backend_cacheActionsHook

This adds the class alias for backend_cacheActionsHook to
the ClassAliasMap.php of compitability6.

Change-Id: Ia42eb48d0be7886fd9c86ac7ce1bcf0b3b5840f8
Resolves: #66522
Releases: master
Reviewed-on: http://review.typo3.org/38851
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
4 years ago[TASK] Store last access of modules linked in the System Information menu 81/38781/4
Andreas Fernandez [Sat, 18 Apr 2015 11:39:19 +0000 (13:39 +0200)]
[TASK] Store last access of modules linked in the System Information menu

Store the access time of modules linked in
the System Information menu in the UC of the current backend user
to make it possible to reset the counter.

Resolves: #66234
Releases: master
Change-Id: I605680e50a04974455a30837463f51fe77fec56b
Reviewed-on: http://review.typo3.org/38781
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[BUGFIX] AbstractTreeView correct permission handling with non pages 34/37034/7
Andreas Allacher [Fri, 20 Feb 2015 08:07:51 +0000 (09:07 +0100)]
[BUGFIX] AbstractTreeView correct permission handling with non pages

AbstractTreeView now checks correctly, if a user has permission
to access elements even if they are not pages.

Without this change it was always assumed that the "uid" of the record
is the page uid. However, that is only valid for pages.

Change-Id: I4dd4970fb529ac6ab6f3c79d993456feed225fea
Resolves: #63047
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/37034
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
4 years ago[BUGFIX] Always use uc_default after first install 34/38834/2
Jigal van Hemert [Mon, 20 Apr 2015 18:54:54 +0000 (20:54 +0200)]
[BUGFIX] Always use uc_default after first install

If the Install Tool sets the start module on first login to allow the
installation of a distribution the uc_default settings must still be
applied. A special temporary setting by the Install Tool makes it easy
to detect this situation.

Resolves: #66432
Releases: master
Change-Id: Icb779860c54fd53af6c38437ab2dedad846a9fbc
Reviewed-on: http://review.typo3.org/38834
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Show preview after cropping image 08/38808/2
Frans Saris [Sun, 19 Apr 2015 18:37:14 +0000 (20:37 +0200)]
[BUGFIX] Show preview after cropping image

Resolves: #66441
Releases: master
Change-Id: I3e7e8b5b69daf9c2795c9860db576727621bd948
Reviewed-on: http://review.typo3.org/38808
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Felix Kopp <felix-source@phorax.com>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
4 years ago[BUGFIX] Check if validationrules are set before foreach statement 46/38846/2
Ruud [Tue, 21 Apr 2015 09:21:47 +0000 (11:21 +0200)]
[BUGFIX] Check if validationrules are set before foreach statement

The ValidationUtility now checks if there are any rules set,
before trying to use the variable in the foreach loop.

Resolves: #66508
Releases: master, 6.2
Change-Id: I201986d88666d8de8a84de6581d2ea06da7374c2
Reviewed-on: http://review.typo3.org/38846
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Streamline buttons in Language module 42/38842/2
Andreas Fernandez [Tue, 21 Apr 2015 07:10:41 +0000 (09:10 +0200)]
[TASK] Streamline buttons in Language module

Apply the btn classes to the action buttons in the Language module to
make the look and feel more consistent.

Resolves: #66509
Releases: master
Change-Id: I5c4b2b2318d1ae7fac20f4b4021e4911044752c4
Reviewed-on: http://review.typo3.org/38842
Reviewed-by: Felix Kopp <felix-source@phorax.com>
Tested-by: Felix Kopp <felix-source@phorax.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[FOLLOWUP][TASK] Add meaningful exceptions to new locking API 83/38683/9
Mathias Brodala [Tue, 14 Apr 2015 07:57:41 +0000 (09:57 +0200)]
[FOLLOWUP][TASK] Add meaningful exceptions to new locking API

This adds dedicated exceptions to the new locking API which
vastly simplifies usage workflows.

Since the new API was not yet released, this is a non-breaking
change.

Resolves: #66411
Related: #47712
Releases: master
Change-Id: Iae44eaa121562469b64222f5837f7a48e6d9fc14
Reviewed-on: http://review.typo3.org/38683
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
4 years ago[BUGFIX] Add missing padding arround ElementInformationController content 33/38833/2
Frans Saris [Mon, 20 Apr 2015 18:33:51 +0000 (20:33 +0200)]
[BUGFIX] Add missing padding arround ElementInformationController content

Resolves: #66501
Releases: master
Change-Id: I67f6785ababc559f5aa2cb76c92fb8cff390c7a5
Reviewed-on: http://review.typo3.org/38833
Reviewed-by: Benjamin Kott <info@bk2k.info>
Tested-by: Benjamin Kott <info@bk2k.info>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Remove HTML from exception messages 09/38609/2
Mathias Brodala [Fri, 10 Apr 2015 06:49:56 +0000 (08:49 +0200)]
[BUGFIX] Remove HTML from exception messages

Exception messages are independent from a specific context and thus
should not contain HTML code.

Resolves: #66344
Releases: master
Change-Id: I8bfab2d1da3fc3baf344d833eaaec8b267732baf
Reviewed-on: http://review.typo3.org/38609
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 years ago[BUGFIX] Support SVG without XML prologue 27/38727/11
Frank Nägler [Thu, 16 Apr 2015 07:50:21 +0000 (09:50 +0200)]
[BUGFIX] Support SVG without XML prologue

If a SVG does not contains a XML prologue, TYPO3 indexes this file with
mimetype text/plain, which results in missing width and height in the
database. This patch adds a mapping for known filetypes to support
also files which mimetype can not detected automatically.

Resolves: #66445
Releases: master
Change-Id: I908e2f1bb95f9e59ebf23f79f09645afd6696ecd
Reviewed-on: http://review.typo3.org/38727
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
4 years ago[BUGFIX] Load CSH properly 19/38819/5
Andreas Fernandez [Mon, 20 Apr 2015 07:50:29 +0000 (09:50 +0200)]
[BUGFIX] Load CSH properly

The inline setting "moduleUrl" now gets written in the DocumentTemplate,
as it is also available in popups.

Resolves: #66481
Releases: master
Change-Id: I386df6c16bdf730aaddb09b668f743ce6e10877d
Reviewed-on: http://review.typo3.org/38819
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Remove unnecessary and failing code 21/38821/4
Helmut Hummel [Mon, 20 Apr 2015 08:09:00 +0000 (10:09 +0200)]
[BUGFIX] Remove unnecessary and failing code

While fixing #57199 a slot was introduced to write the class cache
after each extension installation. This not only adds unnecessary overhead
as the class loader already holds the class loading information of activated
packages in runtime cache, it currently causes fatal errors in certain
situations, as the class cache is also removed after each
extension installation *and* runtime information is flushed in the slot.

Removing the slot increases stability and performance
for extension installation process.

Resolves: #66487
Releases: 6.2, master
Change-Id: Ie33a73af7abb8aa50cd30cbfa30bfb43031f0cea
Reviewed-on: http://review.typo3.org/38821
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[BUGFIX] Make global TSFE and TT a reference to the class members 89/38489/3
Anja Leichsenring [Sun, 5 Apr 2015 10:40:12 +0000 (12:40 +0200)]
[BUGFIX] Make global TSFE and TT a reference to the class members

The global variables $GLOBALS['TSFE'] and ['TT'] are modified in
some places throughout FE rendering.
Since those public objects should only be mirrors of the protected
members of the RequestHandler, we need to make the global variables
a reference to the protected members.

Be aware that this is a dirty workaround and actually bypasses
the protected access of the members by making them changable
via the global variables.

Change-Id: I542f382ee42bdbacc6bad7d74dfb69dfe6fcca88
Resolves: #66278
Relates: #65914
Releases: master
Reviewed-on: http://review.typo3.org/38489
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Make fields in EM table larger 17/38817/4
Andreas Fernandez [Mon, 20 Apr 2015 06:37:52 +0000 (08:37 +0200)]
[BUGFIX] Make fields in EM table larger

Increase the size of the "version" field, as it breaks the UNIQUE constraint
in MySQL. Also, increase other fields as some values are too large and
errors in other DBMS.
Additionally, fields for author information have been increased to 150 characters.

Resolves: #66486
Releases: master, 6.2
Change-Id: I69340318fa0c528e3c16ad3c6d3054dd9b9c6eb9
Reviewed-on: http://review.typo3.org/38817
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[BUGFIX] Indexed_search Make results per page work (Extbase plugin) 89/38789/5
Tymoteusz Motylewski [Sat, 18 Apr 2015 18:35:28 +0000 (20:35 +0200)]
[BUGFIX] Indexed_search Make results per page work (Extbase plugin)

Replaces wrong setting "results" and uses "numberOfResults" instead.
Protects PageBrowskingViewHelper from division by zero warning.
Fix wrong path to the page_links setting in the template.

Resolves: #40280
Releases: master, 6.2
Change-Id: I6636c6796b92181dbe298562df2fb59a4f1f1ec2
Reviewed-on: http://review.typo3.org/38789
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
4 years ago[BUGFIX] Avoid double-encoding of URL parameters 83/38783/4
Andreas Fernandez [Sat, 18 Apr 2015 11:59:40 +0000 (13:59 +0200)]
[BUGFIX] Avoid double-encoding of URL parameters

Fix some double rawurlencode() on parameters in EditDocumentController.

In almost all cases the getModuleUrl() method is now used, which already
takes care of proper URL encoding.

This also prevents errors where the CSRF protection failed due to wrong
URL encoding.

Resolves: #66433
Releases: master
Change-Id: Ib962020dd074f38808634ae2ac7bfd1da2c3364b
Reviewed-on: http://review.typo3.org/38783
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
4 years ago[BUGFIX] Add IMAGE_MANIPULATION type to TableColumnType 36/38736/5
Andreas Allacher [Thu, 16 Apr 2015 14:46:13 +0000 (16:46 +0200)]
[BUGFIX] Add IMAGE_MANIPULATION type to TableColumnType

Added IMAGE_MANIPULATION type to TableColumnType in order to
not result in frontend exceptions when using image_manipulation.
The issue was introduced with commit
e7ec4abaea793808a2248595b2d6f11c1f2bb585.

Change-Id: Ie2f48724ba708f892912ec785441aa8f7a9ccc04
Resolves: #66458
Releases: master
Reviewed-on: http://review.typo3.org/38736
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
4 years ago[BUGFIX] Indexed_search extbase plugin support for mysql fulltext search 30/38130/8
Tymoteusz Motylewski [Tue, 24 Mar 2015 19:08:49 +0000 (20:08 +0100)]
[BUGFIX] Indexed_search extbase plugin support for mysql fulltext search

Add three getters for IndexSearchRepository and SearchFormController
to have a common api for accessing data needed by FulltextIndexHook.

Unify the processing of $page_where as in one class it
was expected that it returns statement with 'AND' and in other without.

Unify the formatting of select statements in both classes to make
differences easier to spot (fix missing $wordSel statement
in the extbase plugin in the process).

Resolves: #65989
Resolves: #52277
Releases: master, 6.2
Change-Id: I9fcb86d44208e8fe6d205667f344022b0ad62505
Reviewed-on: http://review.typo3.org/38130
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
4 years ago[BUGFIX] Calculate correct cropping for large images 17/38717/4
Frans Saris [Wed, 15 Apr 2015 18:36:54 +0000 (20:36 +0200)]
[BUGFIX] Calculate correct cropping for large images

When the visible image in the cropping wizard is a scaled
version of the original image we need to take the scaled ratio into
account when setting the crop info.

Scaling of the original images occurs when it is bigger then
1000px x 700px.

This patch makes sure the crop info is correctly calculated.

Resolves: #66440
Releases: master
Change-Id: I7852b19a47f462120c6ea4b72ec388254a210d3e
Reviewed-on: http://review.typo3.org/38717
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
4 years ago[!!!][TASK] New Login Screen 66/38366/18
Benjamin Kott [Mon, 30 Mar 2015 21:46:40 +0000 (23:46 +0200)]
[!!!][TASK] New Login Screen

The login screen is now supporting background
images and adjustable highlight colors out of the
box. Settings for the login screen can now be
accessed in the backend extension setting.

To keep the focus on the most important stuff,
the news that can be displayed are reduced to
a single view carousel where you can slide
through the latest news.

Releases: master
Resolves: #66431
Change-Id: I12aa4e078cd9782ba4f73921164731a055226004
Reviewed-on: http://review.typo3.org/38366
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Felix Kopp <felix-source@phorax.com>
Tested-by: Felix Kopp <felix-source@phorax.com>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[TASK] Simplify PHP lint execution 04/38704/3
Mathias Brodala [Wed, 15 Apr 2015 13:00:58 +0000 (15:00 +0200)]
[TASK] Simplify PHP lint execution

This simplifies PHP lint execution in Travis by ensuring lint
errors are outputted to stderr and drops everything else. If
any check fails, the exit code 1 is returned.

The Composer vendor directory is excluded from linting.

Resolves: #66437
Releases: master
Change-Id: I588a880f548c248a0db44f3a3f1274fcec2edd00
Reviewed-on: http://review.typo3.org/38704
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Visible notification if cropping has changed 16/38716/4
Frank Nägler [Wed, 15 Apr 2015 18:30:42 +0000 (20:30 +0200)]
[BUGFIX] Visible notification if cropping has changed

For all formfields there is a visible notification (blue border)
for when value has been changed. This is now also visible for
the preview image if the cropping has been changed.

Resolves: #66442
Releases: master
Change-Id: I0a089687b8641732076c302f43f9d8a5e7a671ab
Reviewed-on: http://review.typo3.org/38716
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
4 years ago[FEATURE] Add TCA type image_manipulation 22/37622/22
Frans Saris [Sat, 7 Mar 2015 19:05:44 +0000 (20:05 +0100)]
[FEATURE] Add TCA type image_manipulation

TCA type image_manipulation brings a image manipulation wizard
to the core.

This first version brings image cropping with the possibility to
set a certain aspect ratio for the cropped area. The
sys_file_reference.crop property is extended and can now also hold
a json string to describe the image manipulation.

The LocalCropScaleMaskHelper that is used by the core
to create adjusted images is also adjusted to handle the new format.

Overriding TCA by TSConfig will be done in a followup.

Resolves: #65585
Releases: master
Change-Id: I58dee33e0f884ba2907259e8b03254c43f4c9186
Reviewed-on: http://review.typo3.org/37622
Reviewed-by: Benjamin Kott <info@bk2k.info>
Tested-by: Benjamin Kott <info@bk2k.info>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
4 years ago[BUGFIX] Clear inputs when switching between OpenID and normal login 80/38680/4
Christian Weiske [Tue, 14 Apr 2015 06:50:27 +0000 (08:50 +0200)]
[BUGFIX] Clear inputs when switching between OpenID and normal login

Browsers auto-fill username + password, and when switching to
OpenID login those fields were still submitted and used to log
into TYPO3.

By clearing them unconditionally, we're sure that they do not get
used to log the user into TYPO3.

Change-Id: Ief908829826c65345f034e0763cbbd845452907c
Fixes: #66404
Releases: master
Reviewed-on: http://review.typo3.org/38680
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
4 years ago[FEATURE] Add flexible preview link configuration 39/38639/2
Markus Klein [Sat, 11 Apr 2015 18:41:29 +0000 (20:41 +0200)]
[FEATURE] Add flexible preview link configuration

We add new page TSconfig to allow flexible configuration of preview
links for any record.

Releases: master
Resolves: #66370
Change-Id: I5beac52f9383d17aac424694dd9b3011a1e06776
Reviewed-on: http://review.typo3.org/38639
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
4 years ago[CLEANUP] ReferenceIndex 73/37473/16
Stephan Großberndt [Mon, 2 Mar 2015 18:52:53 +0000 (19:52 +0100)]
[CLEANUP] ReferenceIndex

Use imports, correct typos, use getters instead of globals, improve
variable names, introduce some early returns, empty() instead of
count() and explicit return statements.

Deprecate unused property $errorLog and unused function error().

Resolves: #65465
Releases: master
Change-Id: I4a7f1b5c2b74c8e5b8a7017cd05929c85f2eba07
Reviewed-on: http://review.typo3.org/37473
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
4 years ago[BUGFIX] Store dependency errors before further dependency tests 86/38686/4
Nicole Cordes [Tue, 14 Apr 2015 09:10:11 +0000 (11:10 +0200)]
[BUGFIX] Store dependency errors before further dependency tests

During dependency checking the extensions are checked recursively. If an
depended extension is not yet installed, dependencies for this extension
are tested as well. Unfortunately the second test resets the array with
stored dependency errors which leads to improper dependency handling.
This patch stores the dependency errors before starting further tests
and re-adds them after processing.

Resolves: #66410
Releases: master, 6.2
Change-Id: Ic576c30f6b1f066467c4899ea5e958280c12d37c
Reviewed-on: http://review.typo3.org/38686
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>