Packages/TYPO3.CMS.git
2 years ago[TASK] Move bower dependencies to npm 97/53097/2
Johannes Goslar [Fri, 2 Jun 2017 22:18:01 +0000 (00:18 +0200)]
[TASK] Move bower dependencies to npm

Resolves: #81448
Resolves: #81449
Resolves: #81450
Releases: 8.7
Change-Id: Ic87b62f09d607e7f37491ebec2ea4619bc1aff70
Reviewed-on: https://review.typo3.org/53097
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Resolve grunt build errors 96/53096/2
Markus Sommer [Fri, 7 Apr 2017 11:59:37 +0000 (13:59 +0200)]
[TASK] Resolve grunt build errors

* Remove /* @end */ comments
* Add missing line end line
* Remove unnessasery blank lines
* Add chosen to git

Resolves: #80748
Releases: 8.7
Change-Id: Ifc75b31894f1daa2f27f100819a5ffdd77eff062
Reviewed-on: https://review.typo3.org/53096
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Hide empty descriptions in textmedia in page module 93/53093/2
Jigal van Hemert [Sat, 3 Jun 2017 15:30:39 +0000 (17:30 +0200)]
[BUGFIX] Hide empty descriptions in textmedia in page module

In the Page module with textmedia content elements the descriptions
are shown below the thumbnails of linked media. If there is no
description an empty line is now suppressed.

Resolves: #81408
Releases: master, 8.7, 7.6
Change-Id: I9f342908f179550bcf2156328117c464bb8c672f
Reviewed-on: https://review.typo3.org/53093
Reviewed-by: Jo Hasenau <info@cybercraft.de>
Tested-by: Jo Hasenau <info@cybercraft.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FOLLOWUP][BUGFIX] Exchange flag icons from SVG to PNG 90/53090/2
Marco Christian Krenn [Fri, 2 Jun 2017 09:27:01 +0000 (11:27 +0200)]
[FOLLOWUP][BUGFIX] Exchange flag icons from SVG to PNG

Remove flag SVG's from grunt and bower.

Resolves: #76291
Releases: master
Change-Id: I5698c5b23e74848a0330f080845d1d471ac37523
Reviewed-on: https://review.typo3.org/53090
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] DocumentEditController save with translation broken 88/53088/2
Markus Sommer [Fri, 5 May 2017 11:48:09 +0000 (13:48 +0200)]
[BUGFIX] DocumentEditController save with translation broken

With changing the input type=image to input type=submit,
the x/y values are no longer transferred the
EditDocumentController checked for, and content is no
longer saved. Adapt the controller code for the new parameters.

Resolves: #76649
Releases: 8.7, master

Change-Id: I921b92f1086e142592fc84083656c4baecd43aa7
Reviewed-on: https://review.typo3.org/53088
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Show hidden sub group items in be_groups records 87/53087/2
Markus Sommer [Sat, 3 Jun 2017 12:26:25 +0000 (14:26 +0200)]
[TASK] Show hidden sub group items in be_groups records

Show hidden records in the subgroup list of be_group
records, too.

Change-Id: Iaca85f22bdf8a4c308b59fd37bd75b4a913614a0
Resolves: #81452
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53087
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Prohibit editing of uneditable labels in pagetree 80/53080/2
Johannes Goslar [Fri, 2 Jun 2017 20:15:16 +0000 (22:15 +0200)]
[BUGFIX] Prohibit editing of uneditable labels in pagetree

Resolves: #81445
Releases: master, 8.7
Change-Id: Ie88eb7ce2fdaf7429377062e86996847f7e9bfa9
Reviewed-on: https://review.typo3.org/53080
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Avoid jumping of form fields on focus 81/53081/2
Jasmina Liessmann [Fri, 2 Jun 2017 22:20:30 +0000 (00:20 +0200)]
[BUGFIX] Avoid jumping of form fields on focus

Use absolute position for hints of remaining
characters to prevent form fields from being
moved down.

Resolves: #81447
Related: #77069
Releases: master, 8.7
Change-Id: I8df8cd25955a6ed44bfa5ee727f439856960167f
Reviewed-on: https://review.typo3.org/53081
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] CSH on popup window - more link leads to non-existent page 74/53074/2
Oliver Hader [Fri, 2 Jun 2017 21:13:38 +0000 (23:13 +0200)]
[BUGFIX] CSH on popup window - more link leads to non-existent page

Opening CSH help popups from another popup (e.g. add/edit wizard) fails
since the resolved CSH URI is not valid.

Resolves: #80665
Releases: master, 8.7
Change-Id: I16f4dcd037cdb7ab210c083272d0941c979da205
Reviewed-on: https://review.typo3.org/53074
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Add type hints and fix PHPDoc in extbase DataMapFactory 48/53048/2
Stephan Großberndt [Wed, 24 May 2017 13:56:34 +0000 (15:56 +0200)]
[TASK] Add type hints and fix PHPDoc in extbase DataMapFactory

While this is technically a breaking change it only affects internal API.

Releases: master, 8.7
Resolves: #81336
Change-Id: I700caafcfe7f889bba90c03ae7f7010d8228c64a
Reviewed-on: https://review.typo3.org/53048
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Move jquery to npm 71/53071/2
Johannes Goslar [Fri, 2 Jun 2017 22:02:01 +0000 (00:02 +0200)]
[TASK] Move jquery to npm

Resolves: #81446
Change-Id: I10fd5950636d2e4b992e1a03f1720759d9e7c55d
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53071
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Use reference for label 'bodytext' in CType 'textpic' 67/53067/2
Jasmina Liessmann [Fri, 2 Jun 2017 21:08:14 +0000 (23:08 +0200)]
[TASK] Use reference for label 'bodytext' in CType 'textpic'

Resolves: #81352
Releases: master, 8.7
Change-Id: I7f55e6998ebde5d8d90e7b6bcd05f4550f6ce09a
Reviewed-on: https://review.typo3.org/53067
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] npm script for grunt css build 60/53060/2
Christian Kuhn [Fri, 2 Jun 2017 17:37:45 +0000 (19:37 +0200)]
[TASK] npm script for grunt css build

Execute with "npm run build-css"

Change-Id: Ib5d57df2c6b1281baa245b36ba466524f8db65c0
Resolves: #81442
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53060
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Raise styleguide to 8.0.12 58/53058/2
Christian Kuhn [Fri, 2 Jun 2017 15:39:08 +0000 (17:39 +0200)]
[TASK] Raise styleguide to 8.0.12

A series of bug fixes and most TCA example records
are now multi language aware and the generator creates
multi language data records.

Change-Id: I5fca90642fde64269d08c9fc9f41ad5f949ed8ef
Resolves: #81441
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53058
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Add visual difference for elapsed endtime 55/53055/2
Markus Sommer [Fri, 2 Jun 2017 10:33:45 +0000 (12:33 +0200)]
[TASK] Add visual difference for elapsed endtime

Add an icon which indicates that the time is ahead of the endtime of the
record.

Change-Id: I04b3fcd48b554a6a15606ec580f38b2470f0327c
Resolves: #3464
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53055
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Update TYPO3 Icons and add to icon registry 52/53052/2
maikh [Fri, 2 Jun 2017 15:03:44 +0000 (17:03 +0200)]
[TASK] Update TYPO3 Icons and add to icon registry

Change-Id: Ibc94a1f0434db96f09ee421cf64867c5779290e7
Resolves: #81426
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53052
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Update display of table in log module 45/53045/2
Jasmina Liessmann [Fri, 2 Jun 2017 12:57:18 +0000 (14:57 +0200)]
[TASK] Update display of table in log module

Add the possibility to scroll the table respecting the viewport,
wrap words in the column 'Details' on desktops

Resolves: #80994
Releases: master, 8.7
Change-Id: Ib684d1747979390b7fa83b30846139bbc17879b8
Reviewed-on: https://review.typo3.org/53045
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Disable a series of functional tests with mssql 46/53046/2
Christian Kuhn [Fri, 2 Jun 2017 13:44:37 +0000 (15:44 +0200)]
[TASK] Disable a series of functional tests with mssql

Disable mysql specific tests for mssql. This list is
nearly identical to the postgres skipped tests.
Only a couple of additional skips are added in extbase where
extbase relies on non standard query constructs that postgres
and mysql support, but mssql doesn't. This will need a more
intrusive change later, but can't be solved easily now.

Change-Id: I0db8f8f094498ff47255c6cd08c03644b58ff4ca
Resolves: #81424
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53042
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-on: https://review.typo3.org/53046

2 years ago[BUGFIX] Editing all records after deleting one throws exception 41/53041/2
Oliver Hader [Fri, 2 Jun 2017 11:55:40 +0000 (13:55 +0200)]
[BUGFIX] Editing all records after deleting one throws exception

If some record has been removed in the list module and after that
the "edit marked" button is clicked, an exception is thrown concerning
the just removed record.

The list of records to be edited is now determined from the visible
elements of the list.

Resolves: #75966
Releases: master, 8.7
Change-Id: I2c77dd2d92cda038a1009c318a2ee6650bd82963
Reviewed-on: https://review.typo3.org/53041
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Raise testing-framework to 1.0.7 35/53035/2
Christian Kuhn [Fri, 2 Jun 2017 12:35:50 +0000 (14:35 +0200)]
[TASK] Raise testing-framework to 1.0.7

A couple of bug fixes and preparations for mssql support.

Change-Id: Ia8f874d03a37250d739e6939e36bb04455a85fc4
Resolves: #81419
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53035
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Do not show hidden tables in LiveSearch 32/53032/2
Susanne Moog [Fri, 2 Jun 2017 10:20:37 +0000 (12:20 +0200)]
[BUGFIX] Do not show hidden tables in LiveSearch

LiveSearch did not check whether the tables were
allowed to be shown (via TCA ctrl hideTable) and
displayed results that were not available after
clicking 'show all'.

Change-Id: I90f61e1156c446cd399c0f26b96bbd30c747554d
Releases: master, 8.7
Resolves: #75651
Reviewed-on: https://review.typo3.org/53032
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Remove disabled button in inline records 29/53029/2
Johannes Schlier [Tue, 30 May 2017 15:23:24 +0000 (17:23 +0200)]
[BUGFIX] Remove disabled button in inline records

If the info icon is disabled it is now removed completely.
Previously the logic for new records was not caught correctly, so that
the case for the enabled icon with a new record was executed.
Disabling the icon should remove it completely,
as a disabled non-clickable icon is not helpful and confusing for editors.
This is now done, and the case for the enabled icon with new records is
also correctly caught.

Resolves: #81380
Releases: master, 8.7
Change-Id: I1c78a99a83efa3c88e3a6337df9cd0c8a959ea7b
Reviewed-on: https://review.typo3.org/53029
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Add background-color to Link Wizard Attribute Container 28/53028/2
Marco Christian Krenn [Thu, 1 Jun 2017 12:55:33 +0000 (14:55 +0200)]
[BUGFIX] Add background-color to Link Wizard Attribute Container

Background color was added to the Link Wizard Attribute Container,
to fit with the leading tab navigation.

Releases: master, 8.7
Resolves: #81404
Change-Id: Idcc009ec2b02da367a1ed749e3a5c746fed43717
Reviewed-on: https://review.typo3.org/53028
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fixed broken links in file reference list 24/53024/2
Christer Vindberg [Mon, 29 May 2017 08:49:01 +0000 (10:49 +0200)]
[BUGFIX] Fixed broken links in file reference list

Changed so file reference list icon and title links don't throw an
exception

The fluid template used a url as a pageUid, which caused typo3 to
throw an exception.

Resolves: #81357
Releases: master, 8.7
Change-Id: Ibbb8d7d51d1b65e9178082f59e34fdfbb501d2fa
Reviewed-on: https://review.typo3.org/53024
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Use Fluid standalone TagBuilder object 25/53025/2
Benni Mack [Fri, 26 May 2017 15:43:43 +0000 (17:43 +0200)]
[BUGFIX] Use Fluid standalone TagBuilder object

When instantiating the tag-based viewhelpers and
extbase is in the game, the class alias map is not
taken place, because there is a class expected
which is only in the class alias map, but not
existing anymore.

Instead, the Fluid standalone's TagBuilder object
should be used.

Resolves: #81350
Releases: master, 8.7
Change-Id: I1d3d73a65b4948474dd68c42f43ead454c842ecb
Reviewed-on: https://review.typo3.org/53025
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Raise required PCRE version 22/53022/2
Stephan Großberndt [Wed, 24 May 2017 14:09:18 +0000 (16:09 +0200)]
[BUGFIX] Raise required PCRE version

Warn about an outdated PCRE version which is not compatible to PHP 7.0
in the Install Tool to make aware of possible PHP crashes in the TYPO3
backend.

Releases: master, 8.7
Resolves: #81335
Change-Id: I0db145146eb02bcab81a83195f375c87ae85f3e4
Reviewed-on: https://review.typo3.org/53022
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Avoid jumping of form fields on focus 20/53020/2
Jasmina Liessmann [Thu, 1 Jun 2017 14:11:43 +0000 (16:11 +0200)]
[BUGFIX] Avoid jumping of form fields on focus

Use absolute position for hints of remaining
characters to prevent form fields from being
moved down.

Resolves: #77069
Releases: master, 8.7
Change-Id: Iacba62543b036309e17828ab86f1986eb65f36a0
Reviewed-on: https://review.typo3.org/53020
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] SystemInformationMenu: Automatically refresh counter badge 18/53018/2
Johannes Goslar [Thu, 1 Jun 2017 16:22:31 +0000 (18:22 +0200)]
[TASK] SystemInformationMenu: Automatically refresh counter badge

Automatically reload the SystemInformation every 5 minutes.

Resolves: #68920
Releases: master, 8.7
Change-Id: Ie21d345d6bcbbae30f0fd77f084c22b1b2a0f6f2
Reviewed-on: https://review.typo3.org/53018
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Change order of preferred extension icons 17/53017/2
Georg Ringer [Thu, 1 Jun 2017 16:56:49 +0000 (18:56 +0200)]
[TASK] Change order of preferred extension icons

Prefer svg over png icons.

Resolves: #81396
Releases: master, 8.7
Change-Id: Ide44eb1f0c841c788516424fbff01bd319c79104
Reviewed-on: https://review.typo3.org/53017
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Exchange flag icons from SVG to PNG 16/53016/2
Marco Christian Krenn [Thu, 1 Jun 2017 20:53:05 +0000 (22:53 +0200)]
[BUGFIX] Exchange flag icons from SVG to PNG

All flag icons are exchanged to PNG to reduce file size and
fix viewport rendering problem in IE11.

Moved following flag icons from IconRegistry to registerFlags

* flag-an
* flag-cs
* flag-qc

Removed icon 'flag-fam', this was the famfamfam flag and has no use

Remove US states flags

Releases: master, 8.7
Resolves: #76291
Change-Id: I3d45b76901c2584680c8fcaa49aa0fed308405fc
Reviewed-on: https://review.typo3.org/53016
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Avoid unnecessarily fetching file for processing 15/53015/3
Helmut Hummel [Sat, 20 May 2017 09:29:45 +0000 (11:29 +0200)]
[BUGFIX] Avoid unnecessarily fetching file for processing

Files that are not configured as images, won't be processed,
but are still unnecessarily fetched for processing.

To avoid this, we change the processing API, that fetching
only happens, if the file is then used by following code.

In addition we avoid showing a non descriptive thumb
in FileInfoElement, which is used when editing meta data of the file.

Resolves: #81279
Releases: master, 8.7, 7.6
Change-Id: Ie68aa02b1b6149ddb7fbda346ac312d3646e260c
Reviewed-on: https://review.typo3.org/53015
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years agoRevert "[BUGFIX] Avoid duplicates if ReferenceIndex is unable to finish" 14/53014/3
Christian Kuhn [Tue, 23 May 2017 20:39:31 +0000 (22:39 +0200)]
Revert "[BUGFIX] Avoid duplicates if ReferenceIndex is unable to finish"

This reverts commit c2a9726c4efb23d76c084e3319b29f74c14ccdce
from review https://review.typo3.org/#/c/50803/
due to regression in #81320

Change-Id: I496e13ce9efe743a5607e12b46a3fdc90e2f17c2
Resolves: #81320
Reverts: #78829
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53014
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Combine lint task for ci integration and correct code violations 13/53013/3
Benjamin Kott [Thu, 1 Jun 2017 19:05:19 +0000 (21:05 +0200)]
[TASK] Combine lint task for ci integration and correct code violations

Resolves: #81411
Releases: master, 8.7
Change-Id: I2b0f848ee6db870e78d8d102ef48ba2b417f91d7
Reviewed-on: https://review.typo3.org/53013
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Module menu clicks with slow connections opens standalone module 10/53010/2
Oliver Hader [Thu, 1 Jun 2017 13:57:50 +0000 (15:57 +0200)]
[BUGFIX] Module menu clicks with slow connections opens standalone module

If loading the backend using a slow internet connection an early click on
any item in the module menu on the left side causes the link to be opened
directly. The reason is, that JavaScript and thus click handlers are not
completely loaded yet. Thus, the regular DOM behavior of anchor tags is
executed.

To circumvent this behavior, href-arguments have to be disabled and the
module URL moved to a dedicated new data-attribute. As a result all items
that trigger a module change have to be adjusted as well.

Resolves: #80565
Releases: master, 8.7
Change-Id: I4687e6594eb539acc0d299dc8fc02e6820019911
Reviewed-on: https://review.typo3.org/53010
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Require bower and have node build scripts 05/53005/2
Christian Kuhn [Thu, 1 Jun 2017 17:06:43 +0000 (19:06 +0200)]
[TASK] Require bower and have node build scripts

In preperation of a scss linter and typescript linter
we require bower as root dev dependency and register
some happy little scripts.

Change-Id: I425fd848a4012065fc7d955be0ae961f0f2ee8c4
Resolves: #81410
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53005
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Add NPM package lock file 04/53004/2
Christian Kuhn [Thu, 1 Jun 2017 17:13:20 +0000 (19:13 +0200)]
[TASK] Add NPM package lock file

The file describes the exact tree that was generated, such that
subsequent installs are able to generate identical trees, regardless
of intermediate dependency updates.

https://docs.npmjs.com/files/package-lock.json

Resolves: #81406
Releases: master, 8.7
Change-Id: I8c2f0d7a8d6a1d0cd7434d8e753a32d387b32f8f
Reviewed-on: https://review.typo3.org/53004
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] trigger Backend.doLayout() on window resize 94/52994/2
Johannes Goslar [Thu, 1 Jun 2017 12:26:47 +0000 (14:26 +0200)]
[BUGFIX] trigger Backend.doLayout() on window resize

Resolves: #78464
Releases: master, 8.7
Change-Id: I8d861df1e047213a355d145e05a9131386c7439f
Reviewed-on: https://review.typo3.org/52991
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
(cherry picked from commit 194bdeaae53cbf4301c8743edcb819547c262a91)
Reviewed-on: https://review.typo3.org/52994

2 years ago[TASK] Functionals: Rename "@group mysql" to "@group not-postgres" 85/52985/2
Christian Kuhn [Wed, 31 May 2017 20:28:12 +0000 (22:28 +0200)]
[TASK] Functionals: Rename "@group mysql" to "@group not-postgres"

Functional tests annotated with "@group mysql" are currently ignored
if running tests on postgres via "--exclude-group mysql" argument.
With mssql we have some tests that run fine with mysql and postgres,
but not with mssql.
To improve handling, "@group mysql" annotation is renamed
to "@group not-postgres". Tests not available on postgres and mssql
will then later have a second annotation "@group not-mssql".
This way its easier to keep track which tests go red on which DBMS.

Change-Id: I2522b00352f1a7d61479588a22cdd9ea5d454ca3
Resolves: #81394
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52985
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[CLEANUP] Reduce cache gets in MarkerBasedTemplateService 82/52982/2
Claus Due [Tue, 30 May 2017 22:42:10 +0000 (00:42 +0200)]
[CLEANUP] Reduce cache gets in MarkerBasedTemplateService

Multiple calls to get() from cache can be condensed to one.

Change-Id: I1d949fcbc0c91afdbfb2d0e2bc3d9c1b4dfd475a
Resolves: #81385
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52982
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Refactor ext:impexp functional tests 81/52981/2
Christian Kuhn [Wed, 31 May 2017 15:18:15 +0000 (17:18 +0200)]
[TASK] Refactor ext:impexp functional tests

The ext:impexp functional tests are rather hard to read and
follow. The patch untangles them to make them better maintainable:

* Combine the two different import / export abstract classes into 1 class
* Don't inherit from AbstractDataHandlerActionTestCase anymore
* Give single test cases better file names and do not hide them in sub dirs
* Move all fixtures to Fixtures/ dir
* Use less helper methods to import and test things
* File paths are more straight and with less helper magic

Change-Id: Iae36771b94045f99444f394129cbcf183168b584
Resolves: #81393
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52981
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Fix typos in upgrade wizards of Install Tool 79/52979/2
Georg Ringer [Tue, 30 May 2017 19:57:46 +0000 (21:57 +0200)]
[TASK] Fix typos in upgrade wizards of Install Tool

Use the term "Upgrade wizard" instead of "Update wizard"
for the buttons of the single steps as the main menu item
is also called "Upgrade wizard".

Resolves: #81383
Releases: master, 8.7
Change-Id: I8047ae45101533a67fa4488af7040acc49af563f
Reviewed-on: https://review.typo3.org/52979
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[FOLLOWUP][TASK] Squeeze every bit of performance from CGL fixer 65/52965/2
Elmar Hinz [Wed, 24 May 2017 16:10:23 +0000 (18:10 +0200)]
[FOLLOWUP][TASK] Squeeze every bit of performance from CGL fixer

Support case sensitve file systems again.

Releases: master, 8.7
Resolves: #80814
Change-Id: I82274b328e9cfa75fb35360145d7a668d1270dc3
Reviewed-on: https://review.typo3.org/52965
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Extbase: Pass parameter to real raw queries 62/52962/2
Daniel Goerz [Fri, 19 May 2017 12:02:56 +0000 (14:02 +0200)]
[BUGFIX] Extbase: Pass parameter to real raw queries

Resolves: #81272
Releases: master, 8.7
Change-Id: Iac3d486697b8c52fbace185ab1a55c514847db07
Reviewed-on: https://review.typo3.org/52962
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] Ensure correct URL generation with http_build_query() 64/52964/2
Markus Klein [Wed, 24 May 2017 12:09:42 +0000 (14:09 +0200)]
[BUGFIX] Ensure correct URL generation with http_build_query()

http_build_query() internally uses the PHP setting arg-separator.output
to identify the URL parameter separator.
This does not seem appropriate for URLs generated by TYPO3.

Use the optional parameters of http_build_query() to get the desired
functionality.

Releases: master, 8.7, 7.6
Resolves: #81366
Change-Id: Ie2df9207b1967257d6327ff1103503e6a58d5cdf
Reviewed-on: https://review.typo3.org/52964
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Properly escape <> in Install Tool Check. 44/52944/2
Georg Ringer [Wed, 24 May 2017 05:47:12 +0000 (07:47 +0200)]
[BUGFIX] Properly escape <> in Install Tool Check.

Escape the < > in the check of the Windows Apache ThreadStackSize.

Resolves: #81134
Releases: master, 8.7
Change-Id: Iaa73e61438766f413ba7aeeaebac0fcbf41f1a99
Reviewed-on: https://review.typo3.org/52944
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
2 years ago[BUGFIX] Make encoding of parameters for cHash independent of PHP settings 23/52923/2
Markus Klein [Tue, 23 May 2017 20:51:35 +0000 (22:51 +0200)]
[BUGFIX] Make encoding of parameters for cHash independent of PHP settings

http_build_query() internally uses the PHP setting arg-separator.output
to identify the URL parameter separator.
Our code relies on having a simple ampersand as this character.
If the PHP is set to a different configuration the code will fail.

This is fixed by enforcing the ampersand. Moreover we force RFC3986
encoding to ensure that decoding with rawurldecode() does the right
thing.

Change-Id: I92f9b877201c634303a2e387d9aad49106151f63
Releases: master, 8.7
Resolves: #81293
Reviewed-on: https://review.typo3.org/52923
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Explicit cast to string for VersionState object 17/52917/2
Christian Kuhn [Mon, 22 May 2017 21:12:31 +0000 (23:12 +0200)]
[BUGFIX] Explicit cast to string for VersionState object

Some DB drivers are picky on their arguments not being
objects. Add an explicit cast to string for a VersionState
object just before it's fed to a query as argument.

Change-Id: I81c8f9dded7068ad7bf817e034aa67a29f28290c
Resolves: #81309
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52917
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Use correct constructor argument for TableDiff 08/52908/2
Stephan Großberndt [Fri, 19 May 2017 17:33:14 +0000 (19:33 +0200)]
[BUGFIX] Use correct constructor argument for TableDiff

Using the correct datatype "string" instead of a
\Doctrine\DBAL\Schema\Identifier as TableDiff->name prevents exceptions
if another SchemaEventSubscriber is registered.

Releases: master, 8.7
Resolves: #81276
Change-Id: If273a165604ff3149d8e5aba2c0b5ccbdef8102d
Reviewed-on: https://review.typo3.org/52908
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Avoid DBAL\Exception on unknown data type in Install Tool 07/52907/2
Stephan Großberndt [Fri, 19 May 2017 06:35:30 +0000 (08:35 +0200)]
[BUGFIX] Avoid DBAL\Exception on unknown data type in Install Tool

Using $connection->getSchemaManager()->listTableNames() instead of
->listTables() in Install Tool prevents a DBAL\Exception as the table
details are not requested - which are not used anyway, so this is
faster too.

Releases: master, 8.7
Resolves: #81264
Change-Id: I35db1b6fa743ad4869bf2ba24717320f0f009995
Reviewed-on: https://review.typo3.org/52907
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Re-enable passing tests in SchemaMigratorTest 06/52906/2
Stephan Großberndt [Mon, 22 May 2017 16:00:00 +0000 (18:00 +0200)]
[TASK] Re-enable passing tests in SchemaMigratorTest

Re-enable the tests passing tests changeExistingColumn() and
installDoesNotAddIndexOnChangedColumn() in SchemaMigratorTest.

Resolves: #81302
Releases: master, 8.7
Change-Id: Idaf9d87c16d58864c6de3353ec68be46ae93024f
Reviewed-on: https://review.typo3.org/52906
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Squeeze every bit of performance from CGL fixer 04/52904/2
Claus Due [Tue, 11 Apr 2017 18:23:31 +0000 (20:23 +0200)]
[TASK] Squeeze every bit of performance from CGL fixer

This patch reduces the amount of time required to check
CGL to less than 3% of what it was before when xdebug
is loaded and the script is asked to check ~100 files.

Time before: 17m
Time after: 23.3s

Change-Id: I533ac3bfd03922362ccd6180caf6df2bfecd5bac
Releases: master, 8.7
Resolves: #80814
Reviewed-on: https://review.typo3.org/52904
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Extract datahandling framework to testing-framework 98/52898/2
Anja Leichsenring [Sat, 20 May 2017 16:36:34 +0000 (18:36 +0200)]
[TASK] Extract datahandling framework to testing-framework

Ext:core comes with a little testing framework for functional tests,
that is pretty useful for all kind of DataHandler related tests. Those
classes are better located in the testing-framework package to be
available.

Change-Id: I429e801b7318fda3a96acb4f5f63bb75050fb3e3
Resolves: #81154
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52898
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Remove usage of PATH_typo3conf from ConfigurationManager 97/52897/2
Anja Leichsenring [Sat, 20 May 2017 17:57:23 +0000 (19:57 +0200)]
[TASK] Remove usage of PATH_typo3conf from ConfigurationManager

Resolves: #81284
Releases: master, 8.7
Change-Id: I59730f5807d27bbc7eb232917763daa89f41315a
Reviewed-on: https://review.typo3.org/52897
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Acceptance test installing TYPO3 on mysql 94/52894/2
Christian Kuhn [Sat, 20 May 2017 19:12:30 +0000 (21:12 +0200)]
[TASK] Acceptance test installing TYPO3 on mysql

A basic acceptance tests clicking through installer
using a mysql db connection, checking backend login
and "blank" site frontend output works.

Change-Id: Ie14d9c6fd8280d382b4041f98fa04ed00ef8386c
Resolves: #81285
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52894
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Embed parameters in SQL fragment create by getSelectQuery 93/52893/2
Christer Vindberg [Tue, 18 Apr 2017 10:28:07 +0000 (12:28 +0200)]
[BUGFIX] Embed parameters in SQL fragment create by getSelectQuery

Use quoted/escaped values embedded in the SQL fragment instead of named
parameters in QueryGenerator::getSelectQuery. The values of named
parameters get lost when the SQL fragment is returned and subsequently
used in a query.

Resolves: #80872
Releases: master, 8.7
Change-Id: If22bf24b75d2aa0efe36e587e38e7c590f3ec34a
Reviewed-on: https://review.typo3.org/52893
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[TASK] Minor CGL cleanup makes php-cs-fixer happy 90/52890/2
Christian Kuhn [Sun, 21 May 2017 12:43:04 +0000 (14:43 +0200)]
[TASK] Minor CGL cleanup makes php-cs-fixer happy

Change-Id: I4ce5bae6d200bbd7eba6679136375c71cfb6e268
Resolves: #81289
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52890
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Update typo3/testing-framework to 1.0.6 86/52886/2
Christian Kuhn [Sat, 20 May 2017 23:23:05 +0000 (01:23 +0200)]
[TASK] Update typo3/testing-framework to 1.0.6

A couple of bug fixes and a setup for acceptance tests
of the installation procedure.

Change-Id: I97c211acb6f65a48ee90a45885887f8d16f800b9
Resolves: #81287
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52886
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[CLEANUP] Review comment and sig of addMountPointParameterToPage() 84/52884/2
Elmar Hinz [Sat, 20 May 2017 13:03:14 +0000 (15:03 +0200)]
[CLEANUP] Review comment and sig of addMountPointParameterToPage()

Releases: master, 8.7
Resolves: #81280
Change-Id: I8689827c9e33202e7659a39bb55e7a9bfd792aa2
Reviewed-on: https://review.typo3.org/52884
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Cleanup .gitignore components directory 82/52882/2
Christian Kuhn [Sat, 20 May 2017 19:19:48 +0000 (21:19 +0200)]
[TASK] Cleanup .gitignore components directory

The components/ directory has been a temporary directory in v8 phase,
does not exist anymore and can be removed from .gitignore.

Change-Id: I0f690c8fb38733dc8d168a7e43078dffc60450ea
Resolves: #81286
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52882
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Make sure relative URL receives a proper host part for errorpage 62/52862/2
Anja Leichsenring [Fri, 19 May 2017 09:46:40 +0000 (11:46 +0200)]
[BUGFIX] Make sure relative URL receives a proper host part for errorpage

If the code given for PageNotFound_handling is a relative URL, the host
determination gets skipped, resulting in a redirect of the markup of
the page instead a proper redirect.

Resolves: #81267
Relates: #81031
Releases: master, 8.7
Change-Id: Id9c26cba813c212438368cee031673dc59db360b
Reviewed-on: https://review.typo3.org/52862
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Prevent duplicated special char in backend breadcrumb 56/52856/2
Thomas Schur [Wed, 17 May 2017 11:09:03 +0000 (13:09 +0200)]
[BUGFIX] Prevent duplicated special char in backend breadcrumb

Prevent duplicated special char conversion of page title in
TYPO3 backend breadcrumb and fix title cropping

Resolves: #81242
Releases: master, 8.7
Change-Id: Id7710d8d8f79e20b20f43569558833d3d3f68f16
Reviewed-on: https://review.typo3.org/52856
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Remove doubled SQL query in PageRepository 54/52854/2
Benni Mack [Thu, 11 May 2017 06:22:13 +0000 (08:22 +0200)]
[BUGFIX] Remove doubled SQL query in PageRepository

The method PageRepository->checkWorkspaceAccess() does a SQL query to fetch
the workspace record, then hands it over to BE_USER->checkWorkspace which has the
same functionality - to fetch the full workspace record.

As this is redundant code, the PageRepository code can be simplified a lot by just leaving
the workspaceCache property.

Resolves: #81187
Releases: master, 8.7
Change-Id: Ia82febb2269084ea9101acfc36a1c9aa20950290
Reviewed-on: https://review.typo3.org/52854
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Page tree request in a workspaces times out 53/52853/2
Oliver Hader [Wed, 19 Apr 2017 19:24:38 +0000 (21:24 +0200)]
[BUGFIX] Page tree request in a workspaces times out

Tryign to determine workspace versions for a particular database table
results in a very long process execution time and possible timeout due
to the following reasons:

* in general a bug was introduced during the Doctrine DBAL migration
  which leads to misbehaviors in resolving versions for pages
* the SQL query implicitly creates an INNER JOIN with a huge result
  set that takes a long query time
* invalid types leading to possible flaws when using prepared statements

The SQL query has been split into using sub-queries now.

Change-Id: I4e4f69815bd73f0562f7ffbd6d411b417be7a18a
Resolves: #80898
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52853
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Streamline icons (order/style) in InlineRecordContainer 52/52852/2
Daniel Windloff [Fri, 7 Oct 2016 12:05:47 +0000 (14:05 +0200)]
[TASK] Streamline icons (order/style) in InlineRecordContainer

In order to be consistent, change the button order and styling
(according to the list module) in the InlineRecordContainer.

Resolves: #78174
Releases: master, 8.7
Change-Id: I2f4498f1e822785c2b26dab697ec4fe26aae5ef0
Reviewed-on: https://review.typo3.org/52852
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix wrong comment in TSFE for xhtmlDoctype property 51/52851/2
Jochen Greiner [Sat, 13 May 2017 17:11:52 +0000 (19:11 +0200)]
[BUGFIX] Fix wrong comment in TSFE for xhtmlDoctype property

The comment was wrong because the TSFE-Controller
takes care of setting this option internally.

Resolves: #81219
Releases: master, 8.7
Change-Id: If4af5b5aefa2758063e595e9e3e0b55892c7df27
Reviewed-on: https://review.typo3.org/52851
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Render prepended option tag always in first place 48/52848/2
Marcus Schwemer [Sun, 22 Jan 2017 21:24:39 +0000 (22:24 +0100)]
[BUGFIX] Render prepended option tag always in first place

Currently the prepend option is rendered together with the options
argument from select viewhelper. Using the option "optionsAfterContent"
renders also the prepend option after the children. The preprend
option is now rendered always in the first place.

Resolves: #79584
Releases: master, 8.7
Change-Id: Ia58c3b7d9b26d00cbda4d7ebce2a881a7129b331
Reviewed-on: https://review.typo3.org/52848
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Typo3DBQueryParser fails to wrap subselect in braces 47/52847/2
Thomas Maroschik [Wed, 17 May 2017 10:30:18 +0000 (12:30 +0200)]
[BUGFIX] Typo3DBQueryParser fails to wrap subselect in braces

When the Typo3DBQueryParser converts Extbase queries to Doctrine
queries, it creates subselects for certain relation constraints.
It fails to wrap the subselect in braces for has-many relations
which leads to sql exceptions.

This patch introduces braces around those subselects.

Change-Id: Ie9721a01bf166391770c7a1471272af0e15f9ccb
Fixes: #81240
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52847
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Convert ViewHelpers to static calling 75/52775/3
Claus Due [Fri, 5 May 2017 01:31:07 +0000 (03:31 +0200)]
[TASK] Convert ViewHelpers to static calling

Several ViewHelpers were not yet converted to use
the renderStatic method and CompileWith* traits
from Fluid. This patch converts those.

Change-Id: I17773d4014969c5ad5a3b87bffd34c14871a2958
Releases: 8.7,master
Resolves: #81143
Reviewed-on: https://review.typo3.org/52775
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Use different field for logging in EXT:scheduler 46/52846/2
Georg Ringer [Fri, 21 Apr 2017 20:37:36 +0000 (22:37 +0200)]
[BUGFIX] Use different field for logging in EXT:scheduler

The public method Scheduler::log accepts an optional $code as 3rd
parameter. Add this information to the parameter $details of
BackendUserAuthentication::writelog as otherwise it will be
casted to an integer and its information will be lost.

Resolves: #80592
Releases: master, 8.7
Change-Id: Iab5f1d285976e9e88795ebbe75faff9f689b1a8c
Reviewed-on: https://review.typo3.org/52846
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[CLEANUP] Update comment of PageRepository::getMountPointInfo() 45/52845/2
Elmar Hinz [Thu, 18 May 2017 10:48:05 +0000 (12:48 +0200)]
[CLEANUP] Update comment of PageRepository::getMountPointInfo()

Update the comment of the mehtod PageRepository::getMountPointInfo().
Add hint addressing to the usage of recursive mount points.

Change-Id: I095563cb940e25f8c5f004497d407733faf4cbcc
Releases: master, 8.7
Resolves: #81254
Reviewed-on: https://review.typo3.org/52845
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Fix typo in documentation intent-left > indent-left 34/52834/2
Fabian Thommen [Thu, 18 May 2017 09:14:25 +0000 (11:14 +0200)]
[TASK] Fix typo in documentation intent-left > indent-left

Releases: master, 8.7
Resolves: #81253
Change-Id: I9920ba02349d51925610c2bd04fd8c3ea668e3a6
Reviewed-on: https://review.typo3.org/52834
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Use EXEC_TIME for sys_log entry instead of time() 33/52833/3
Helmut Hummel [Wed, 17 May 2017 12:11:04 +0000 (14:11 +0200)]
[BUGFIX] Use EXEC_TIME for sys_log entry instead of time()

DataHandler does a lookup in sys_log table after it performed
its operations to find relevant error entries for the current request.

It determines relevance by looking for entries with the same
timestamp as $GLOBALS['EXEC_TIME'].

However error log entries are written using time(). Now if the
DataHandler operations take longer than one second, or the log entry
is written directly before a next tick, it can happen, that errors
will not be detected during the lookup process.

Since such errors are exposed to the user, it can happen that an operation
fails, but the users will not be notified.

Fix this by using $GLOBALS['EXEC_TIME'] when writing the log entries.

Resolves: #81244
Releases: master, 8.7, 7.6
Change-Id: Ic22b5f51ba4e10991be4a59ae28cb1f77a91c71e
Reviewed-on: https://review.typo3.org/52833
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
2 years ago[BUGFIX] Correct doctrine expression for perms_clause 30/52830/2
Gerrit Mohrmann [Wed, 17 May 2017 12:41:23 +0000 (14:41 +0200)]
[BUGFIX] Correct doctrine expression for perms_clause

During the refactoring to doctrine in https://review.typo3.org/#/c/48574
a wrong expression was used. Use notIn() instead of in().

Resolves: #81246
Releases: master, 8.7
Change-Id: Icd1bf595fe3a75dc12d875a8a4c416c9b568c6c0
Reviewed-on: https://review.typo3.org/52830
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
2 years ago[BUGFIX] EXT:beuser: Fix action icon (compare user) 28/52828/2
Daniel Windloff [Sat, 29 Apr 2017 10:17:13 +0000 (12:17 +0200)]
[BUGFIX] EXT:beuser: Fix action icon (compare user)

In EXT:beuser -> Backend User Listing there is the
possibility to add an user to the compare list.

If the user is already in the compare user list,
the user is removed from this list.

Resolves: #81079
Releases: master, 8.7
Change-Id: If0d6c132cdb2dbbd524890c3c90f92877240a284
Reviewed-on: https://review.typo3.org/52828
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
2 years ago[BUGFIX] Fix parse time calculation 13/52813/4
Susanne Moog [Fri, 5 May 2017 15:20:16 +0000 (17:20 +0200)]
[BUGFIX] Fix parse time calculation

Parse time calculation in RequestHandler was wrong,
additionally the same calculation is used in admin panel view.

The calculation was therefore added to the TimeTracker into a
common function and tested.

Change-Id: Ib935664e78a62deab7818426e2a853087c00b015
Resolves: #80742
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52813
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix minor ux issues in EXT:recycler 24/52824/2
Daniel Windloff [Sat, 29 Apr 2017 12:51:13 +0000 (14:51 +0200)]
[BUGFIX] Fix minor ux issues in EXT:recycler

* move multi selector to the left
* separate action icons
* use info icon to open more information
* move mass action actions to the left
* use btn-default for actions
* add icons to the mass action buttons

Resolves: #81086
Releases: master, 8.7
Change-Id: Ib65343043a5c5c7ae77689d95502b389bb4acb0b
Reviewed-on: https://review.typo3.org/52824
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Add `controlsList` as known additional attribute 21/52821/2
Andreas Fernandez [Sun, 14 May 2017 09:12:39 +0000 (11:12 +0200)]
[BUGFIX] Add `controlsList` as known additional attribute

The HTML5 attribute `controlsList` is used in at least Google Chrome
to limit the control buttons. The AudioTagRenderer and VideoTagRenderer
classes are now aware of that attribute.

Resolves: #81222
Releases: master, 8.7, 7.6
Change-Id: I9a577ae077e7e7b55b9fed7852a5a61a5fd4061a
Reviewed-on: https://review.typo3.org/52821
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Tested-by: TYPO3com <no-reply@typo3.com>
2 years ago[TASK] Unit test fails with recent PHP releases 18/52818/2
Christian Kuhn [Wed, 17 May 2017 10:24:18 +0000 (12:24 +0200)]
[TASK] Unit test fails with recent PHP releases

Recent PHP unit minor upgrades fixed a bug in DateTimeZone reflection
which is used as test object in our ObjectAccess reflection tests.
Make the test a bit less strict to cope with youngest and older
PHP versions at the same time.

Change-Id: Iaf2290872938f4c04a3307b0fe73c933ca7d69d8
Resolves: #81239
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/52818
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FEATURE] Introduce .typoscript file extension 15/52815/3
Andreas Allacher [Fri, 7 Oct 2016 05:37:33 +0000 (07:37 +0200)]
[FEATURE] Introduce .typoscript file extension

The new file extension .typoscript will be the default for TypoScript
configuration files and is the only recommended one from now on. This
effort is made to introduce a dedicated file extension for TypoScript
configuration files, and to avoid conflicts with already existing and
more spread file extensions like ".ts" for TypeScript or Video Transport
Stream Files.

Resolves: #78161
Resolves: #80689
Releases: master, 8.7
Change-Id: I44b41631f498e3ba39e0f1936329094a59859f4e
Reviewed-on: https://review.typo3.org/52815
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Unset current file in generic Content Object Renderer 11/52811/2
Benjamin Serfhos [Mon, 29 Aug 2016 08:38:22 +0000 (10:38 +0200)]
[BUGFIX] Unset current file in generic Content Object Renderer

When function is done, reset current file for further processing

Resolves: #77645
Releases: master, 8.7, 7.6
Change-Id: Ibae2e3221c51c8cb45f92b0bc7dbe395cc809605
Reviewed-on: https://review.typo3.org/52811
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Introduce cache for readLLfile() 98/52798/2
Faton Haliti [Mon, 10 Apr 2017 13:43:24 +0000 (15:43 +0200)]
[TASK] Introduce cache for readLLfile()

Cache the result of readLLfile() gives a better performance
for cases where readLLfile() is called often.

Resolves: #80788
Releases: master, 8.7
Change-Id: I59913c7c5124ebe54c567a0a7c126a32fdd60284
Reviewed-on: https://review.typo3.org/52798
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Kasper Ligaard <kasperligaard+typo3.org@gmail.com>
Reviewed-by: Faton Haliti <fha@systime.dk>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Add UI blocker to prevent loading issues in FormEngine 76/52776/2
Frank Naegler [Wed, 26 Apr 2017 13:19:37 +0000 (15:19 +0200)]
[BUGFIX] Add UI blocker to prevent loading issues in FormEngine

Resolves: #80672
Releases: master, 8.7, 7.6
Change-Id: I52da6df109531f2a29acbb99b7871dc6227974b7
Reviewed-on: https://review.typo3.org/52776
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Let ElementInfo Template take care of proper title crop 94/52794/2
Mathias Brodala [Wed, 3 May 2017 07:27:21 +0000 (09:27 +0200)]
[BUGFIX] Let ElementInfo Template take care of proper title crop

If the title is too long, it gets cropped. Then, the link title must
contain the whole string in order to provide a proper tooltip.

Resolves: #81124
Releases: master, 8.7
Change-Id: I55b4784c431b4a495dc4089ab954eb3c7e1ca435
Reviewed-on: https://review.typo3.org/52794
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Throw explicit exception on missing link handler class 92/52792/2
Mathias Brodala [Fri, 12 May 2017 09:07:19 +0000 (11:07 +0200)]
[TASK] Throw explicit exception on missing link handler class

This adds the link handler identifier to the error message which
makes it easier to fix the missing class reference.

Resolves: #81205
Releases: master, 8.7, 7.6
Change-Id: I0ce610f7ec167704d5cbc5de20d43639c18e3fc1
Reviewed-on: https://review.typo3.org/52792
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Indexed Search should use FrontendRestrictionsContainer 86/52786/3
Benni Mack [Thu, 11 May 2017 12:19:11 +0000 (14:19 +0200)]
[BUGFIX] Indexed Search should use FrontendRestrictionsContainer

Indexed Search still uses enableFields for querying page records,
unlike most other places in the TYPO3 Core. This should be streamlined
because it was forgotten in the initial migration.

Resolves: #81194
Releases: master, 8.7
Change-Id: I0712f6811eefba6d2cb46ed06ff4b1d31ac7fa0b
Reviewed-on: https://review.typo3.org/52786
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Do not throw exception on unavailable APC(u) cache backend 85/52785/2
tbringewatt [Fri, 3 Feb 2017 14:45:02 +0000 (15:45 +0100)]
[TASK] Do not throw exception on unavailable APC(u) cache backend

Log an error (keeping the website available) instead of throwing an
exception (and thus completely disabling it) if TYPO3 is configured to
use the APC / APCu cache backend but saving data to the cache failed.

Resolves: #79636
Releases: master, 8.7

Change-Id: I3adf829825017a3061e921d5d3ec74f20e18311e
Reviewed-on: https://review.typo3.org/52785
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Added missing workspace preview info 81/52781/2
Robert Vock [Fri, 2 Sep 2016 07:45:04 +0000 (09:45 +0200)]
[BUGFIX] Added missing workspace preview info

The workspace preview info got lost from TYPO3 4.5 to 4.6. This commit
readds the info and respects the same TypoScript config options.

Resolves: #77467
Releases: master, 8.7
Change-Id: Ie1696a5f86714c6ef9a61c10c41b0397abb95ab5
Reviewed-on: https://review.typo3.org/52781
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Linkvalidator: Scheduler task not working correctly 80/52780/2
Thorben Nissen [Tue, 25 Apr 2017 07:51:57 +0000 (09:51 +0200)]
[BUGFIX] Linkvalidator: Scheduler task not working correctly

The scheduler task does not check anything but just returns and does not
send an email. Furthermore it is not possible to enter email address
separated by newlines. Under some conditions it can happen, that result
numbers are added to the last result.

Explode pid list into array in LinkAnalyzer::init and use the array later.
Check if email adresses are comma or newline separated when validating
them when saving the task. Add file link statistic to default email
template. Reset the link statistics before the run to avoid adding it to
the last result numbers.

Resolves: #81000
Releases: master, 8.7
Change-Id: I05a98c9babcb889a83ce2f1ec7c0a2bee5dafede
Reviewed-on: https://review.typo3.org/52780
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Respect link target for individual pages in menu generation 79/52779/2
Benjamin Kott [Sun, 7 May 2017 17:33:30 +0000 (19:33 +0200)]
[BUGFIX] Respect link target for individual pages in menu generation

The link target configuration for a page was ignored during menu
generation. The link target is now respected and will override the
defined link target for the menu.

Resolves: #81162
Releases: master, 8.7
Change-Id: Iecf45456942c998e4084b95fe3003d2c5dc038db
Reviewed-on: https://review.typo3.org/52779
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
2 years ago[BUGFIX] Set default root paths constants in Indexed Search 73/52773/2
Christian Toffolo [Thu, 20 Apr 2017 17:47:56 +0000 (19:47 +0200)]
[BUGFIX] Set default root paths constants in Indexed Search

Resolves: #80923
Releases: master, 8.7
Change-Id: Id291a086c6ce4717d5b934d80cd7a4101fb985af
Reviewed-on: https://review.typo3.org/52773
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Replace outdated nowrap attribute 72/52772/2
Henrik Elsner [Tue, 2 May 2017 14:17:39 +0000 (16:17 +0200)]
[TASK] Replace outdated nowrap attribute

The outdated nowrap attribute for table tags
is replaced by a class addition, bringing
the functional stylings

Resolves: #81110
Releases: master, 8.7
Change-Id: Id0981b104be226dec4dc7c2c56b2919391823b31
Reviewed-on: https://review.typo3.org/52772
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
2 years ago[TASK] Cover getContentObject related methods by unit tests. 67/52767/2
Elmar Hinz [Thu, 6 Apr 2017 18:11:52 +0000 (20:11 +0200)]
[TASK] Cover getContentObject related methods by unit tests.

Cover getContentObject related methods of ContentObjectRenderer
by unit tests.

Resolves: #80737
Releases: master, 8.7, 7.6
Change-Id: Ida957cd18c35d10cfc41f954ffdc15e0a04c03a8
Reviewed-on: https://review.typo3.org/52767
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[TASK] Add unit test for Typolink resolveTargetAttribute 66/52766/2
Elmar Hinz [Fri, 31 Mar 2017 19:49:21 +0000 (21:49 +0200)]
[TASK] Add unit test for Typolink resolveTargetAttribute

Add a unit test for AbstractTypolinkBuilder::resolveTargetAttribute.

Releases: master, 8.7
Resolves: #80618
Change-Id: I429900c036371be4f0bd57e75d841f9d0dfe7720
Reviewed-on: https://review.typo3.org/52305
Reviewed-on: https://review.typo3.org/52766
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] Use DBAL Restrictions for index_config queries 65/52765/2
Benni Mack [Thu, 11 May 2017 06:26:58 +0000 (08:26 +0200)]
[BUGFIX] Use DBAL Restrictions for index_config queries

The IndexSearch repository calls $TSFE->sys_page->enableFields
for queries on index_config which has very static information
(deleted/hidden) which the default restriction container handles.

Changing this code was simply forgotton to migrate to the
restriction container.

Resolves: #81188
Releases: master, 8.7
Change-Id: I159b4c2cf898e97b0e92fd2a57bcd30de0806146
Reviewed-on: https://review.typo3.org/52765
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Use renderType selectSingle for field t3_tables of sys_action 69/52769/2
Georg Ringer [Wed, 3 May 2017 03:48:50 +0000 (05:48 +0200)]
[BUGFIX] Use renderType selectSingle for field t3_tables of sys_action

The field t3_tables of sys_action must be rendered as a single
select field. This was also the behaviour before the regression
introduced with #69822.

Resolves: #81119
Releases: master, 8.7, 7.6
Change-Id: I2c885ea3494d7e2be22fad6df1b2a4791991551b
Reviewed-on: https://review.typo3.org/52769
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Fix path to Header partial in Textmedia and Textpic 63/52763/2
Olli [Sun, 16 Apr 2017 14:31:11 +0000 (16:31 +0200)]
[BUGFIX] Fix path to Header partial in Textmedia and Textpic

Fix path to call the existing partial Partials/Header/All instead of
Partials/Header.

Releases: master,8.7
Resolves: #80859
Change-Id: Ib4743acd3f3673fdfbe414cf4563c38e2f153055
Reviewed-on: https://review.typo3.org/52763
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Make DataHandler multibyte-safe 64/52764/2
Benni Mack [Thu, 11 May 2017 04:51:01 +0000 (06:51 +0200)]
[BUGFIX] Make DataHandler multibyte-safe

There are still a few places left where multibyte string functions
are not used. Since 8.x the core delivers a mbstring polyfill
and can be used in various places.

Resolves: #19774
Releases: master, 8.7
Change-Id: I16f022b109749e9f547c177c511fee3bcc5d4b60
Reviewed-on: https://review.typo3.org/52764
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Ensure extractDottedPathToLastElement() always returns a string 62/52762/2
Daniel Goerz [Thu, 20 Apr 2017 13:46:16 +0000 (15:46 +0200)]
[BUGFIX] Ensure extractDottedPathToLastElement() always returns a string

Resolves: #80919
Releases: master, 8.7
Change-Id: I3fddc6e83a117d25ec7abeb7d82130275321c2c7
Reviewed-on: https://review.typo3.org/52762
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] INCLUDE_TYPOSCRIPT condition use correct ConditionMatcher 60/52760/2
Andreas Allacher [Wed, 22 Mar 2017 07:25:35 +0000 (08:25 +0100)]
[BUGFIX] INCLUDE_TYPOSCRIPT condition use correct ConditionMatcher

In order to support all conditions correctly
whether one is in FE or BE the condition
has to be matched against the correct
ConditionMatcher instead of always
using the one for BE.

Releases: master, 8.7, 7.6
Resolves: #80385
Change-Id: Id5e216da40000b408f96822855d97799f254d0fb
Reviewed-on: https://review.typo3.org/52760
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] travis-ci: Drop JS unit tests 59/52759/2
Christian Kuhn [Thu, 11 May 2017 10:24:36 +0000 (12:24 +0200)]
[TASK] travis-ci: Drop JS unit tests

Drop the jasmine / karma based JS unit tests from travis. They're
becoming unstable and are executed as pre-merge tests anyway.
Supporting one executing platform that keeps an eye on
nodejs & friends should be enough.

Change-Id: Ie2134c08c50d9da33ff39bc1a0fe3f4a416e7b45
Resolves: #81192
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52759
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>