Packages/TYPO3.CMS.git
6 months ago[TASK] Harden \TYPO3\CMS\Extbase\Object\ObjectManager 00/59600/4
Johannes Seipelt [Thu, 31 Jan 2019 20:09:23 +0000 (21:09 +0100)]
[TASK] Harden \TYPO3\CMS\Extbase\Object\ObjectManager

- Use strict type mode
- Use type hints whereever possible
- fix test of creating viewhelper instance using object manager

Releases: master
Resolves: #87605
Change-Id: Ia626ae1156dacd7c9ddcfefed9bb03d26ba91404
Reviewed-on: https://review.typo3.org/59600
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Johannes Seipelt <johannes.seipelt@3m5.de>
Reviewed-by: Felix Döring <Felix.Doering@3m5.de>
Reviewed-by: André Schließer <andy.schliesser@gmail.com>
Tested-by: André Schließer <andy.schliesser@gmail.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
6 months ago[FEATURE] Render thumbnails in file list module deferred 46/57646/19
Frank Naegler [Fri, 20 Jul 2018 19:03:47 +0000 (21:03 +0200)]
[FEATURE] Render thumbnails in file list module deferred

This patch adds a new ViewHelper to render thumbnails deferred in
the backend. This increase the performance of the file list.

Resolves: #85607
Related: #85605
Releases: master
Change-Id: Id97876e889605d7d8d3075ee98a4fc34b002f395
Reviewed-on: https://review.typo3.org/57646
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
6 months ago[TASK] Reduce information disclosure of the used TYPO3 version 65/59565/2
Josef Glatz [Thu, 24 Jan 2019 13:15:17 +0000 (14:15 +0100)]
[TASK] Reduce information disclosure of the used TYPO3 version

Reduce information disclosure of the used TYPO3 version by adding
a dynamic 4-digit year in the TYPO3_copyright_year constant.

That makes it more difficult to find out the used TYPO3 version
just by looking at the frontend source code of a website.

Releases: master, 9.5
Resolves: #87543
Change-Id: Ic169548c7111715eecedfce4ced5c8a3564d102a
Reviewed-on: https://review.typo3.org/59565
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: André Schließer <andy.schliesser@gmail.com>
Tested-by: André Schließer <andy.schliesser@gmail.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
6 months ago[BUGFIX] Use real finisher identifier in form element variants 06/59606/2
Ralf Zimmermann [Fri, 1 Feb 2019 12:51:40 +0000 (13:51 +0100)]
[BUGFIX] Use real finisher identifier in form element variants

Use the real finisher identifiers as they are configured in the
form definition instead the finisher implementation class name.
This requires a change of the public AbstractFinisher implementation
which implements the FinisherInterface. The interface is not changed,
as this would be a breaking change. Therefore, the existence of the
new method is checked. If it does not exist in a finisher
implementation, a fallback to the previous behavior happens.

Releases: master, 9.5
Resolves: #87615
Change-Id: I962502f0601845a5f9793751e87c97b3b902caa1
Reviewed-on: https://review.typo3.org/59606
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[TASK] Update typo3fluid/fluid to 2.6.0 54/59554/7
Gerrit Mohrmann [Wed, 23 Jan 2019 20:43:08 +0000 (21:43 +0100)]
[TASK] Update typo3fluid/fluid to 2.6.0

Fixes missing output in ifAuthenticatedViewHelper after cache clearing
and erroneous replication of field properties to subsequent fields.

composer command used:
composer update typo3fluid/fluid

Resolves: #86930
Resolves: #86890
Resolves: #87430
Resolves: #86910
Resolves: #87586
Releases: master, 9.5
Change-Id: I8d1abd0aa08d7d7399ec23675dcf07d08dbdd2f2
Reviewed-on: https://review.typo3.org/59554
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Jonas Eberle <flightvision@googlemail.com>
Tested-by: Jonas Eberle <flightvision@googlemail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[TASK] Improve ClassSchema methods api 22/59422/10
Alexander Schnitzler [Sun, 13 Jan 2019 12:46:26 +0000 (13:46 +0100)]
[TASK] Improve ClassSchema methods api

This patch introduces a new Method class to have an
easier and more stable api to get information about class
methods from ClassSchema objects.

The reflection data fetched and stored by/in the ClassSchema
objects is no longer publicly available as an array. Instead,
Method objects are returned for the following calls:

- getMethod
- getMethods
- getInjectMethods

Also it removes the following method:

- getConstructorArguments

The following constants are marked as private:

- ClassSchema::MODELTYPE_ENTITY
- ClassSchema::MODELTYPE_VALUEOBJECT

Releases: master
Resolves: #87427
Change-Id: I38e8a7287896e9303fad1fa8f8f9182895365adc
Reviewed-on: https://review.typo3.org/59422
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: André Schließer <andy.schliesser@gmail.com>
Tested-by: André Schließer <andy.schliesser@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[TASK] Remove deprecated code from TypoScript condition matchers 91/59491/11
Frank Naegler [Fri, 18 Jan 2019 08:27:09 +0000 (09:27 +0100)]
[TASK] Remove deprecated code from TypoScript condition matchers

Resolves: #87607
Related: #87193
Releases: master
Change-Id: I5c1ce876cd6ad5edeecefce03d7a1e3619f9d54c
Reviewed-on: https://review.typo3.org/59491
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[BUGFIX] Ensure type safety for ViewHelper calling ImageService 08/59608/2
Anja Leichsenring [Fri, 1 Feb 2019 14:59:36 +0000 (15:59 +0100)]
[BUGFIX] Ensure type safety for ViewHelper calling ImageService

The ImageService::getImage requires a string as first and a boolean as
third parameter. The Image ViewHelpers must respect this requirement.

Resolves: #87619
Relates: #87599
Releases: master
Change-Id: I0d8f57c2bef62dcc6b4d6e6684bbbb1593bff98f
Reviewed-on: https://review.typo3.org/59608
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: André Schließer <andy.schliesser@gmail.com>
Tested-by: André Schließer <andy.schliesser@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[!!!][TASK] Harden \TYPO3\CMS\Extbase\Service\ImageService 94/59594/7
Alexander Schnitzler [Thu, 31 Jan 2019 18:20:58 +0000 (19:20 +0100)]
[!!!][TASK] Harden \TYPO3\CMS\Extbase\Service\ImageService

- Use strict type mode
- Use type hints whereever possible

Releases: master
Resolves: #87599
Change-Id: I8840b7fad16c4fffb7f50973fb97a498e0f683e4
Reviewed-on: https://review.typo3.org/59594
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[TASK] Harden \TYPO3\CMS\Extbase\Service\EnvironmentService 92/59592/3
Alexander Schnitzler [Thu, 31 Jan 2019 17:26:48 +0000 (18:26 +0100)]
[TASK] Harden \TYPO3\CMS\Extbase\Service\EnvironmentService

- Use strict type mode
- Use type hints whereever possible

Releases: master
Resolves: #87597
Change-Id: Ic4cfb5512f49b3e20fa16c782301b8dcb2ba5dec
Reviewed-on: https://review.typo3.org/59592
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: André Schließer <andy.schliesser@gmail.com>
Tested-by: André Schließer <andy.schliesser@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Felix Döring <Felix.Doering@3m5.de>
Tested-by: Felix Döring <Felix.Doering@3m5.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[TASK] Harden \TYPO3\CMS\Extbase\Utility\TypeHandlingUtility 96/59596/3
Alexander Schnitzler [Thu, 31 Jan 2019 18:51:41 +0000 (19:51 +0100)]
[TASK] Harden \TYPO3\CMS\Extbase\Utility\TypeHandlingUtility

- Use strict type mode
- Use type hints whereever possible

Releases: master
Resolves: #87601
Change-Id: I087fcb4a87e12ac3d4345a4514dae674b8551460
Reviewed-on: https://review.typo3.org/59596
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Rudy Gnodde <rgn@windinternet.nl>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[TASK] Harden \TYPO3\CMS\Extbase\Service\CacheService 91/59591/4
Alexander Schnitzler [Thu, 31 Jan 2019 17:22:31 +0000 (18:22 +0100)]
[TASK] Harden \TYPO3\CMS\Extbase\Service\CacheService

- Use strict type mode
- Use type hints whereever possible

Releases: master
Resolves: #87596
Change-Id: I99fe661ff7ee0c29d34c0fde7c5c2c83f0f39201
Reviewed-on: https://review.typo3.org/59591
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[!!!][TASK] Consolidate extbase caches 73/59573/8
Alexander Schnitzler [Mon, 28 Jan 2019 08:51:30 +0000 (09:51 +0100)]
[!!!][TASK] Consolidate extbase caches

The caches of extbase have been consolidated as both of them shared the
same caching frontend. Cache identifiers `extbase_reflection` and
`extbase_datamapfactory_datamap` do no longer exist.

A single cache `extbase` is pre-configured and used for class schemata
and data maps instead.

Releases: master
Resolves: #87558
Change-Id: I4d7ec53cfd1b4900998fa2d01db1d8f2c1730633
Reviewed-on: https://review.typo3.org/59573
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[TASK] Replace ModuleLinkViewHelper of EXT:scheduler with ModuleLinkViewHelper of... 83/59583/2
Georg Ringer [Wed, 30 Jan 2019 08:25:09 +0000 (09:25 +0100)]
[TASK] Replace ModuleLinkViewHelper of EXT:scheduler with ModuleLinkViewHelper of EXT:backend

Resolves: #87579
Releases: master
Change-Id: I04e8d291a030dac0a0df526e46aa40ba27a24b39
Reviewed-on: https://review.typo3.org/59583
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
6 months ago[TASK] Use shorthand syntax for global variable $LANG consistently 78/59578/3
Benni Mack [Tue, 29 Jan 2019 12:41:58 +0000 (13:41 +0100)]
[TASK] Use shorthand syntax for global variable $LANG consistently

TYPO3 uses $GLOBALS['LANG'] directly in some places, but since
TYPO3 v7, new code started to use a short hand protected method
"getLanguageService" in order to get IDE code completion and better
analysis of code.

This patch replaces all left-over places of $GLOBALS['LANG']
and encapsulates this into a short-hand method to streamline
TYPO3 Core's code base.

Resolves: #87571
Releases: master
Change-Id: Ie15e320713fe65d40552a19e0a517d5739abbb41
Reviewed-on: https://review.typo3.org/59578
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
6 months ago[TASK] Harden \TYPO3\CMS\Extbase\Security\Cryptography\HashService 90/59590/3
Alexander Schnitzler [Thu, 31 Jan 2019 17:18:14 +0000 (18:18 +0100)]
[TASK] Harden \TYPO3\CMS\Extbase\Security\Cryptography\HashService

- Use strict type mode
- Use type hints whereever possible

Releases: master
Resolves: #87595
Change-Id: If59546093176c5a7725725aad8e619de70fd43cd
Reviewed-on: https://review.typo3.org/59590
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Felix Döring <Felix.Doering@3m5.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: André Schließer <andy.schliesser@gmail.com>
Tested-by: André Schließer <andy.schliesser@gmail.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
6 months ago[TASK] Harden \TYPO3\CMS\Extbase\Core\Bootstrap 98/59598/4
Alexander Schnitzler [Thu, 31 Jan 2019 19:54:02 +0000 (20:54 +0100)]
[TASK] Harden \TYPO3\CMS\Extbase\Core\Bootstrap

- Use strict type mode
- Use type hints whereever possible

Releases: master
Resolves: #87603
Change-Id: I3430b59e93133d9b19d6520d3fd7cca83c0fdb49
Reviewed-on: https://review.typo3.org/59598
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[!!!][TASK] Harden \TYPO3\CMS\Extbase\DomainObject\DomainObjectInterface 02/59602/5
Alexander Schnitzler [Thu, 31 Jan 2019 20:41:57 +0000 (21:41 +0100)]
[!!!][TASK] Harden \TYPO3\CMS\Extbase\DomainObject\DomainObjectInterface

- Use strict type mode
- Use type hints whereever possible

Releases: master
Resolves: #87608
Change-Id: I3fc153c68bb29aa85517965c6d4d8414d25af35b
Reviewed-on: https://review.typo3.org/59602
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[TASK] Use FQCN's when registering plugins/modules 66/59566/11
Alexander Schnitzler [Thu, 24 Jan 2019 18:02:33 +0000 (19:02 +0100)]
[TASK] Use FQCN's when registering plugins/modules

The following methods used controller aliases:

- \TYPO3\CMS\Extbase\Utility\ExtensionUtility::configurePlugin
- \TYPO3\CMS\Extbase\Utility\ExtensionUtility::registerModule

This means, that while configuring plugins or modules, a list
of controllers (and their actions) had to be provided, so they
could be registered as available controllers for said plugin
or module.

The controller name used for the registration, was kind of an
alias for that controller. It was the class name without the
namespace and without the "Controller" suffix. By a certain
convention a proper class name could be derived from that
alias. All this was necessary back then when TYPO3 didn't have
a proper autoloader and when the class location was derived
from the class name. These circumstances do not exist any more
and since it's only important that a controller class exists,
the registration of plugins must now use the fully qualified
controller class name as array key.

The former syntax

   \TYPO3\CMS\Extbase\Utility\ExtensionUtility::configurePlugin(
       'TYPO3.CMS.IndexedSearch',
       'Pi2',
       ['Search' => 'form,search,noTypoScript'],
       ['Search' => 'form,search']
   );

has to be converted to

   \TYPO3\CMS\Extbase\Utility\ExtensionUtility::configurePlugin(
       'IndexedSearch',
       'Pi2',
       [
           \TYPO3\CMS\IndexedSearch\Controller\SearchController::class
               => 'form,search,noTypoScript'
       ],
       [
           \TYPO3\CMS\IndexedSearch\Controller\SearchController::class
               => 'form,search'
       ]
   );

Please note, that not only the controller configuration changed.
The vendor `TYPO3.CMS` in `TYPO3.CMS.IndexedSearch`, must no longer
be set. Instead, the vendor will be evaluated by looking at the
controller namespace.

Releases: master
Resolves: #87550
Change-Id: If47d087836c4345a8180dae3d4e4b8cd384e684c
Reviewed-on: https://review.typo3.org/59566
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[!!!][TASK] Remove view related properties from ActionController 14/59514/6
Alexander Schnitzler [Mon, 21 Jan 2019 16:13:05 +0000 (17:13 +0100)]
[!!!][TASK] Remove view related properties from ActionController

Both properties $namespacesViewObjectNamePattern and
$viewFormatToObjectNameMap of class ActionController
have been removed without replacement.

Both properties provided a functionality to set a
custom view object class during runtime. As this
contradicts the idea of having a defined state per
request by configuring concrete implementations
before runtime, these properties needed to vanish.

While there is no dependency injection with a proper
configuration available, the view object class can
still be defined via property $defaultViewObjectName.

Releases: master
Resolves: #87511
Change-Id: I4b89a9434f71a3cbf38a9ad113ba8233e7f327f9
Reviewed-on: https://review.typo3.org/59514
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Achim Fritz <af@achimfritz.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 months ago[TASK] Remove unused class import statements 59/59359/5
Oliver Hader [Mon, 7 Jan 2019 17:26:16 +0000 (18:26 +0100)]
[TASK] Remove unused class import statements

Resolves: #87589
Releases: master
Change-Id: I69119636e11d116b79fc627a2993a1fa84d7a39c
Reviewed-on: https://review.typo3.org/59359
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 months ago[TASK] Remove unused PHP variables 60/59360/6
Oliver Hader [Wed, 30 Jan 2019 16:14:43 +0000 (17:14 +0100)]
[TASK] Remove unused PHP variables

Resolves: #87590
Releases: master
Change-Id: I30af97f075d352792370b363b0b152ead99eacab
Reviewed-on: https://review.typo3.org/59360
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 months ago[BUGFIX] Resolve site correctly in nested site structure 79/59579/3
Benni Mack [Tue, 29 Jan 2019 15:24:24 +0000 (16:24 +0100)]
[BUGFIX] Resolve site correctly in nested site structure

Due to a bug in checking for $result[t3ver_oid] ?? $result[uid]
the uid is never used, but only the t3ver_oid. This value could be empty
and then "0" is used. This means, the page record to be edited
in FormEngine is treated as "NullSite" = Page without Site Configuration.

Resolves: #87572
Releases: master, 9.5
Change-Id: I1c4175f61a9c5df3dd3a392c2f636112cfbdb350
Reviewed-on: https://review.typo3.org/59579
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 months ago[TASK] Increase field name of table sys_file_storage 81/59581/2
Georg Ringer [Wed, 30 Jan 2019 07:12:44 +0000 (08:12 +0100)]
[TASK] Increase field name of table sys_file_storage

Increase the length of the field from 30 to 255 chars to be in
sync with other tables, e.g. sys_file_mounts. 30 is fairly short
for bigger sites and lots of storages.

As this is an admin only field and not too often used, it is ok to backport
that to 9.5 as well.

Resolves: #87576
Releases: master, 9.5
Change-Id: I355b6295a9f813e72e1e66e05dd93419fd2aeaeb
Reviewed-on: https://review.typo3.org/59581
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
6 months ago[TASK] Remove unused DeleteFileViewHelper 82/59582/2
Georg Ringer [Wed, 30 Jan 2019 08:01:27 +0000 (09:01 +0100)]
[TASK] Remove unused DeleteFileViewHelper

Since #72332 the url to the delete action is built in the controller and
assigned to the view.

Resolves: #87578
Releases: master
Change-Id: I36ea3374a848c48c981718dfc8dc1899dc9c0164
Reviewed-on: https://review.typo3.org/59582
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
6 months ago[BUGFIX] Use overridden field label in list view 05/59505/6
Georg Ringer [Mon, 21 Jan 2019 10:41:31 +0000 (11:41 +0100)]
[BUGFIX] Use overridden field label in list view

If a label of a table column is overridden by TsConfig
(TCEFORM.<table>.<column>.label), the new value
must also be used in the list view:

- header of the table rendering
- list of "set fields"

Resolves: #87484
Releases: master, 9.5
Change-Id: I8eafd1f2878b571edd1e5a30b28b0d5330b9b5d0
Reviewed-on: https://review.typo3.org/59505
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 months ago[!!!][TASK] Drop TBE_TEMPLATE variable 92/59492/6
Benni Mack [Fri, 18 Jan 2019 20:52:19 +0000 (21:52 +0100)]
[!!!][TASK] Drop TBE_TEMPLATE variable

The global variable TBE_TEMPLATE is not
necessary anymore, and is not available anymore.

The change is still ugly, as TBE_TEMPLATE
initializes the PageRenderer object
with necessary information, which should
become built inside PageRenderer for BE. This has been
moved to Backend's RequestHandler where this can be
abstracted further at a later point.

Resolves: #87567
Releases: master
Change-Id: If1cb184740f1e99c0aeca5ae19c85899d56f3f9a
Reviewed-on: https://review.typo3.org/59492
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 months ago[TASK] Use ModuleLinkViewHelper in EXT:sys_note 11/59511/2
Georg Ringer [Mon, 21 Jan 2019 13:16:24 +0000 (14:16 +0100)]
[TASK] Use ModuleLinkViewHelper in EXT:sys_note

Replace custom VH with the one provided by EXT:backend.

Resolves: #87507
Releases: master
Change-Id: I882d7555654a051e7190d7ffd25ff6e903f16ab1
Reviewed-on: https://review.typo3.org/59511
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 months ago[TASK] Use ModuleLinkViewHelper instead of IssueCommandViewHelper 13/59513/2
Georg Ringer [Mon, 21 Jan 2019 14:20:59 +0000 (15:20 +0100)]
[TASK] Use ModuleLinkViewHelper instead of IssueCommandViewHelper

Use the general ModuleLinkViewHelper instead of custom VH.

Resolves: #87509
Releases: master
Change-Id: I7f0d7125d0ee84973bc80599cbc51e44747e2d06
Reviewed-on: https://review.typo3.org/59513
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 months ago[BUGFIX] Add correct description for CType menu_sitemap 71/59571/3
Josef Glatz [Sun, 27 Jan 2019 21:46:03 +0000 (22:46 +0100)]
[BUGFIX] Add correct description for CType menu_sitemap

This patch adds the correct description text for the new
content element wizard of CType "menu_sitemap".

Resolves: #87556
Releases: master, 9.5
Change-Id: Iec0de6887a9a60215a813e03041e4d58af7b297b
Reviewed-on: https://review.typo3.org/59571
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[TASK] Use PSR-15 middlewares in install tool 41/59541/6
Benjamin Franzke [Tue, 22 Jan 2019 08:26:33 +0000 (09:26 +0100)]
[TASK] Use PSR-15 middlewares in install tool

Remove the old concept of priority-based HTTP request handlers,
and use statically configured PSR-15 middlewares instead.
Tranform the priority based request handlers into a set of
chained middlewares.

In case none of the middlewares handles the request a
NotFoundRequestHandler returns a 404 response
(replacing the previous exception that was thrown in that case).
This scheme of using a 404 handler as "last" request handler is
not new, it is also used in zend expressive (a PSR-15 framework).

The TYPO3 RequestHandlerInterface is marked @internal and was set
to be removed in v9, therefore we drop it now and also remove its
implementation from the frontend and backend request handlers.

Releases: master
Resolves: #87516
Change-Id: Ibbd6a0e6c4ff8aa55b4367c9e4c07e279595dbfb
Reviewed-on: https://review.typo3.org/59541
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 months ago[TASK] Add correct description for ext-intl composer.json 74/59574/2
Josef Glatz [Mon, 28 Jan 2019 11:52:03 +0000 (12:52 +0100)]
[TASK] Add correct description for ext-intl composer.json

Releases: master
Resolves: #87559
Change-Id: I74d7ef26017080e45eb129217613ad7c36cd3881
Reviewed-on: https://review.typo3.org/59574
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
6 months ago[!!!][TASK] Remove last marked deprecations 03/59503/6
Benni Mack [Mon, 21 Jan 2019 06:38:28 +0000 (07:38 +0100)]
[!!!][TASK] Remove last marked deprecations

Various deprecated code regarding EXT:form and FormEngine
have been removed.

* IRRE CustomControls without userFunc is not possible anymore.
* TBE_MODULES's configureModuleFunction is removed
* EXT:form type "GridContainer" is removed (use GridRow)
* EXT:form form configuration files must end with .form.yaml.
* EXT:form renderingOptions._isHiddenFormElement and
renderingOptions._isReadOnlyFormElement are removed
* CLI Command "lang:language:update" is now only
available under "language:update"

Resolves: #87514
Releases: master
Change-Id: Idef84daf51f882df23ef227d1777d24b1076dfaf
Reviewed-on: https://review.typo3.org/59503
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 months ago[TASK] Improve indexed_search manual 68/58968/6
hasenbalg [Wed, 28 Nov 2018 08:32:13 +0000 (09:32 +0100)]
[TASK] Improve indexed_search manual

Improves indexed search documentation, mentioning activation
and inclusion of a static template.

Releases: master, 9.5
Resolves: #87023
Change-Id: I85e40b768e4020e71a7717d877a6305fb55a00cb
Reviewed-on: https://review.typo3.org/58968
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
6 months ago[TASK] Use constructor injection in configuration managers 46/59446/3
Alexander Schnitzler [Tue, 15 Jan 2019 14:24:57 +0000 (15:24 +0100)]
[TASK] Use constructor injection in configuration managers

The following classes do no longer use setter injection but
constructor injection instead:

- TYPO3\CMS\Extbase\Configuration\AbstractConfigurationManager
- TYPO3\CMS\Extbase\Configuration\BackendConfigurationManager
- TYPO3\CMS\Extbase\Configuration\ConfigurationManager
- TYPO3\CMS\Extbase\Configuration\FrontendConfigurationManager

Releases: master
Resolves: #87448
Change-Id: Ib6df3ab4a286bbe77cdda82d0066495a8dab8b22
Reviewed-on: https://review.typo3.org/59446
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Christian Wolff <chris@wolffc.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Sebastian Fischer <typo3@evoweb.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
6 months ago[TASK] bamboo: db dependency loop needs break condition 67/59567/3
Christian Kuhn [Fri, 25 Jan 2019 11:00:46 +0000 (12:00 +0100)]
[TASK] bamboo: db dependency loop needs break condition

Functional and acceptance tests need a db up and running.
The according container is started as dependency and a
loop delays further execution until the database connected
to its network port. This sometimes goes wrong, for
instance mssql in rare conditions does not come up. This
leads to the loop running "forever", consuming the
executing bamboo agent and the job never finishs.
The patch adds an additional break condition: If db did
not connect to the port after a minute, the job now fails.

Resolves: #87549
Releases: master, 9.5, 8.7
Change-Id: Idc45f57d9cfd2d390cea6bd5319adaf4158340df
Reviewed-on: https://review.typo3.org/59567
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[TASK] Replace RemoveUserViewHelper with ModuleLinkViewHelper 52/59552/2
Georg Ringer [Wed, 23 Jan 2019 07:47:20 +0000 (08:47 +0100)]
[TASK] Replace RemoveUserViewHelper with ModuleLinkViewHelper

Resolves: #87523
Releases: master
Change-Id: I711ddb140e03e87b38ec06a7814e4b488bc9e9c9
Reviewed-on: https://review.typo3.org/59552
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 months ago[SECURITY] Extend file deny pattern 40/59540/2
Oliver Hader [Tue, 22 Jan 2019 08:43:31 +0000 (09:43 +0100)]
[SECURITY] Extend file deny pattern

In order to enhance protection against (possible) executable file
extensions phar, shtml, cgi, pl have been added to the according
file deny pattern.

Releases: master, 9.5, 8.7
Resolves: #87368
Security-Commit: c9f0d00b89768b63df9c77884cf9d19d658fc0fc
Security-Bulletin: TYPO3-CORE-SA-2019-008
Change-Id: I92998a2046b6efb7f31961c20f24c81d00957879
Reviewed-on: https://review.typo3.org/59540
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
6 months ago[SECURITY] Use a fluid template for the ConfirmationFinisher message 39/59539/2
Ralf Zimmermann [Tue, 22 Jan 2019 08:43:24 +0000 (09:43 +0100)]
[SECURITY] Use a fluid template for the ConfirmationFinisher message

The ConfirmationFinisher message is now rendered within a fluid template
to allow styling of the message.
Furthermore, the FormRuntime (and thus all form element values) and the
finisherVariableProvider are available in the template.
Custom variables can be added globally within the form setup or at
form level in the form definition.
By using a fluid template and the associated html escaping, the display
of the ConfirmationFinisher message is protected against XSS / html
injection attacks.

Resolves: #84902
Releases: master, 9.5, 8.7
Security-Commit: a38c63f3f03b1ab267666ca06a3abaead57b8265
Security-Bulletin: TYPO3-CORE-SA-2019-007
Change-Id: Ib6cfef88bef09f72b675909f7022120b32c095df
Reviewed-on: https://review.typo3.org/59539
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
6 months ago[SECURITY] Raise bootstrap 3.4.0 to fix XSS in JS components 38/59538/2
Benni Mack [Tue, 22 Jan 2019 08:43:15 +0000 (09:43 +0100)]
[SECURITY] Raise bootstrap 3.4.0 to fix XSS in JS components

Fixes an XSS issue in Alert, Carousel, Collapse, Dropdown, Modal,
and Tab components.

Executed tasks:
  cd Build
  yarn add bootstrap-sass@^3.4.0 --dev
  yarn exec grunt

Then copying the contents of Build/node_modules/bootstrap-sass/assets/javascripts/bootstrap.min.js
into typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap/bootstrap.js
additionally adding the AMD factory wrapper.

Resolves: #86580
Releases: master, 9.5, 8.7
Security-Commit: f456e3c185b23c51d08a579ceef1082df473b01b
Security-Bulletin: TYPO3-CORE-SA-2019-006
Change-Id: I235a4b5f6865afd9283cd1e692b25d3a572513ba
Reviewed-on: https://review.typo3.org/59538
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
6 months ago[SECURITY] XSS issues in Fluid view helpers 37/59537/2
Andreas Wolf [Tue, 22 Jan 2019 08:43:08 +0000 (09:43 +0100)]
[SECURITY] XSS issues in Fluid view helpers

* HtmlentitiesViewHelper
* UrlencodeViewHelper
* StripTagsViewHelper

Resolves: #85764
Releases: master, 9.5, 8.7
Security-Commit: 37bc147e634d67d521b716f83ca8d925ec57d531
Security-Bulletin: TYPO3-CORE-SA-2019-005
Change-Id: I1d5473b20378217a68e06c792be7f1cf096859fe
Reviewed-on: https://review.typo3.org/59537
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
6 months ago[SECURITY] Prevent possible XSS in install tool 36/59536/2
Frank Naegler [Tue, 22 Jan 2019 08:43:00 +0000 (09:43 +0100)]
[SECURITY] Prevent possible XSS in install tool

Resolves: #86455
Releases: master, 9.5
Security-Commit: 161663d336f7a6c52a87359a1d1ac01037e5c768
Security-Bulletin: TYPO3-CORE-SA-2019-004
Change-Id: Ief21fcf68f14cb756f140b4c709ddb51f447e544
Reviewed-on: https://review.typo3.org/59536
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
6 months ago[SECURITY] Avoid creation of backend users without password 35/59535/2
Benni Mack [Tue, 22 Jan 2019 08:42:53 +0000 (09:42 +0100)]
[SECURITY] Avoid creation of backend users without password

When using FormEngine it is possible to create a Backend User
without setting a password (or username), which could lead to
issues when using third-party authentication providers.

A hook within DataHandler ensures to set a random username
and/or password if the data is handed into DataHandler without
proper data. Besides that new backend users are disabled per
default and have to be enable manually.

Resolves: #80269
Releases: master, 9.5, 8.7
Security-Commit: f8a9edfed26ad48d13564ea99f27e0846671841c
Security-Bulletin: TYPO3-CORE-SA-2019-002
Change-Id: Ic1d84010717e3ac056f447fd373b31bbce8f65c6
Reviewed-on: https://review.typo3.org/59535
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
6 months ago[SECURITY] Avoid disclosing loaded extensions 34/59534/2
Oliver Hader [Tue, 22 Jan 2019 08:42:46 +0000 (09:42 +0100)]
[SECURITY] Avoid disclosing loaded extensions

Inline JavaScript settings for RequireJS and ajaxUrls disclose the
existence of specific extensions in a TYPO3 installation.

In case no backend user is logged in RequireJS settings are fetched
using an according endpoint, ajaxUrls (for backend AJAX routes) are
limited to those that are accessible without having a user session.

Resolves: #83855
Releases: master, 9.5, 8.7
Security-Commit: a9b60d26597449fec46bd26e0b511bc6e423ef24
Security-Bulletin: TYPO3-CORE-SA-2019-001
Change-Id: Ifa4029340e750baaf216fa953bf41b6d06d3138b
Reviewed-on: https://review.typo3.org/59534
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
6 months ago[BUGFIX] Prevent exception in early bootstrap exception handler 07/59507/2
Benjamin Franzke [Mon, 21 Jan 2019 11:57:20 +0000 (12:57 +0100)]
[BUGFIX] Prevent exception in early bootstrap exception handler

ErrorPageController which is used by the ProductionExceptionHandler
must not rely on PackageManager to be available. Rather use
paths derived from Environment::getFrameworkBasePath().

Releases: master, 9.5
Resolves: #87503
Related: #87175
Change-Id: I556b503e06962b338ec11f2e031eb941417d5944
Reviewed-on: https://review.typo3.org/59507
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 months ago[BUGFIX] Prevent selection of pagetree loader animation 08/59508/3
Josef Glatz [Mon, 21 Jan 2019 12:23:35 +0000 (13:23 +0100)]
[BUGFIX] Prevent selection of pagetree loader animation

Resolves: #87505
Releases: master, 9.5
Change-Id: I879c4c484f8380a7270bd57c0d54a14ea7c7ad2e
Reviewed-on: https://review.typo3.org/59508
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
6 months ago[TASK] Raise guzzlehttp/psr7 composer dependency 17/59517/2
Oliver Hader [Mon, 21 Jan 2019 19:07:46 +0000 (20:07 +0100)]
[TASK] Raise guzzlehttp/psr7 composer dependency

composer update guzzlehttp/psr7

Resolves: #87512
Releases: master, 9.5, 8.7
Change-Id: Ic3dcef632fd1ac65e09f5d8fb6d631ab211e8c3e
Reviewed-on: https://review.typo3.org/59517
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
6 months ago[TASK] Add hidden field to form definition example 47/59447/4
Sebastian Roßkopf [Tue, 15 Jan 2019 14:45:37 +0000 (15:45 +0100)]
[TASK] Add hidden field to form definition example

Since it is not obvious how to add a "Hidden" field to form definitions
without the visual editor we add an element to the form definition example.

Releases: master
Resolves: #87449
Change-Id: I860a5a17346e405cf1f7b29ea3c6255dda1be044
Reviewed-on: https://review.typo3.org/59447
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
6 months ago[TASK] Make the site's identifier available in TypoScript 06/59506/2
Georg Ringer [Mon, 21 Jan 2019 11:00:07 +0000 (12:00 +0100)]
[TASK] Make the site's identifier available in TypoScript

Since #86422 the configuration of a site is available with TypoScript.
As the identifier itself is not part of the configuration, it can't be retrieved.

Now "site:identifier" will retrieve the identifier as well.

Resolves: #87434
Releases: master, 9.5
Change-Id: Ic5a60e8a033c8fbc45baa19ad6a3fe81ff3b6e0b
Reviewed-on: https://review.typo3.org/59506
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Tested-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 months ago[BUGFIX] Add missing use statement in Core/Bootstrap 09/59509/2
Benjamin Franzke [Mon, 21 Jan 2019 12:21:49 +0000 (13:21 +0100)]
[BUGFIX] Add missing use statement in Core/Bootstrap

Bootstrap::createCache() uses Typo3DatabaseBackend::class
as fallback if no cache backend is configured explicitly.
In that case incorrect class name 'Typo3DatabaseBackend'
would be used without the `use` statement.

Releases: master
Resolves: #87504
Change-Id: I6abd1024d79fb7dad194ab32ae79d0658654c4a5
Reviewed-on: https://review.typo3.org/59509
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 months ago[TASK] Extract "taskcenter" and "sys_action" to TER/composer 02/59502/3
Christian Kuhn [Sun, 20 Jan 2019 14:03:30 +0000 (15:03 +0100)]
[TASK] Extract "taskcenter" and "sys_action" to TER/composer

This is the last round of planned extension extractions
from the main core repository.

Both the extensions 'taskcenter' and its add-on extension
'sys_action' did not receive much love over the years. They
are rarely used and their approach is clumsy to say the least.

They are both dropped from main core repository with core v10
now. A fresh approach for a cool new dashboard is in the works
already that may eventually find its way into the core later.

The patch removes both extensions with have been released as
'taskcenter' and 'sys_action' to TER and as
'friendsoftypo3/taskcenter' and 'friendsoftypo3/sys_action'
to composer.

Extension 'impexp' registered a task for the taskcenter which
is now within 'taskcenter' directly.

Resolves: #87499
Releases: master
Change-Id: I86e0292f13247bbd1f2060214f4f6d8e2aefe6c0
Reviewed-on: https://review.typo3.org/59502
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[!!!][TASK] Extract extension feedit to TER/composer 01/59501/3
Christian Kuhn [Sun, 20 Jan 2019 12:00:00 +0000 (13:00 +0100)]
[!!!][TASK] Extract extension feedit to TER/composer

Looking back, extension feedit had a hard life: While
so many parts in the core improved so much over the
years, it never received any similar love.

There have already been multiple attempts to rewrite
a frontend editing approach for TYPO3, for instance with
core 4.5 as the feedit_advanced extension that quickly
died.
There is another editing approach as extension
frontend_editing in the works that may eventually end
up being integrated in the core again.

feedit itself however is so sparse, outdated and not
well working that we now go ahead and drop that extension
from the core, extracting it to github.com/friendsoftypo3.
Maybe some enthusiasts pick the development up again and
make the extension shine and healthy again, without
boundaries of core development.

The patch removes the extension from the core repository,
including some feedit specific code in adminpanel that
has already been merged into the friendsoftypo3 feedit
repository and released as v10.0.0.

The extension is available as friendsoftypo3/feedit via
composer and as name 'feedit' via TER. An upgrade wizard
is in place to fetch it for those who want to use it.

Resolves: #87498
Releases: master
Change-Id: I11a0e91830b47f88fcea9a15459be37bc6dbd3de
Reviewed-on: https://review.typo3.org/59501
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[TASK] Speed up ReST file reference check 95/59495/4
Christian Kuhn [Sat, 19 Jan 2019 07:25:32 +0000 (08:25 +0100)]
[TASK] Speed up ReST file reference check

There is a test related check for the extension scanner
to verify all referenced ReST files actually exist. It
is active as part of the 'integrity' job in bamboo.
The patch adds a variable to suppress checking the same
ReST file name multiple times if it is referenced in many
matchers. In practice, this speeds up the scanning process
drastically, on my local machine with current master from
more than a minute to less than ten seconds.

Resolves: #87493
Releases: master, 9.5
Change-Id: Iaa19add06ad9eeda9d36e3e204c1a671368b5f29
Reviewed-on: https://review.typo3.org/59495
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[TASK] Fix minor syntax in Changelog 98/59498/2
Joerg Kummer [Sat, 19 Jan 2019 13:26:40 +0000 (14:26 +0100)]
[TASK] Fix minor syntax in Changelog

Change backslash to slash in file format, where backslash is not visible
in rendered HTML - it is a file path, not a PHP namespace.

Releases: master, 9.5
Resolves: #87495
Change-Id: If749a3cb1faaf9b25e05db7c1c3cbf7a38d0eafc
Reviewed-on: https://review.typo3.org/59498
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[TASK] Fix minor spelling in Changelog 96/59496/2
Joerg Kummer [Sat, 19 Jan 2019 09:14:24 +0000 (10:14 +0100)]
[TASK] Fix minor spelling in Changelog

Adopt wrong spelling in deprecation Changelog
which is rendered in documentation and extension scanner

Resolves: #87494
Releases: master, 9.5
Change-Id: I4ebea1d5f263762be61b16104b14f66655ddcd4f
Reviewed-on: https://review.typo3.org/59496
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Tested-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 months ago[TASK] Fix minor syntax in Changelog 93/59493/5
jokumer [Sat, 19 Jan 2019 00:41:53 +0000 (01:41 +0100)]
[TASK] Fix minor syntax in Changelog

Change backslash to slash in file format, where backslash is not visible
in rendered HTML - it is a file path, not a PHP namespace.

Releases: master, 9.5
Resolves: #87492
Change-Id: I5a26eed78ba49b0c32cc5bfef95f9f587635053c
Reviewed-on: https://review.typo3.org/59493
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 months ago[!!!][TASK] Remove deprecated code at various places 75/59475/6
Christian Kuhn [Fri, 18 Jan 2019 10:47:03 +0000 (11:47 +0100)]
[!!!][TASK] Remove deprecated code at various places

The patch pics various smaller places to drop
their deprecated code snippets. Additionally
some comments are changed slightly to better
hint on what needs to be done later in v11.

Resolves: #87476
Releases: master
Change-Id: Ib7fe5e4ca29b1c41dd02806e25484e99ef9a41ba
Reviewed-on: https://review.typo3.org/59475
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 months ago[!!!][TASK] Drop extension rsaauth 70/59470/9
Christian Kuhn [Thu, 17 Jan 2019 14:24:49 +0000 (15:24 +0100)]
[!!!][TASK] Drop extension rsaauth

Extension rsaauth that has been marked deprecated in v9 due
to its flaws and is dropped from core v10 with this patch.
People who still think not using https but using the
rsaauth extension approach is a good idea can fetch the
extension from ter using an upgrade wizard or
composer require friendsoftypo3/rsaauth.

Needs a typo3/testing-framework raise since the
acceptance tests still used loginSecurityLevel rsa:
composer require --dev typo3/testing-framework ~5.0.4

Resolves: #87470
Releases: master
Change-Id: Iefdd1c4e4b8725e0968875d4b8cb68103634783c
Reviewed-on: https://review.typo3.org/59470
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[!!!][TASK] Remove EXT/extConf configuration handling 82/59482/4
Christian Kuhn [Fri, 18 Jan 2019 12:43:13 +0000 (13:43 +0100)]
[!!!][TASK] Remove EXT/extConf configuration handling

Resolves: #87482
Releases: master
Change-Id: Id644857a9090ab98efaa4a6bf36ee2ec37e169b0
Reviewed-on: https://review.typo3.org/59482
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[!!!][TASK] Drop handling of M$ prefixed passwords 87/59487/10
Christian Kuhn [Fri, 18 Jan 2019 14:04:34 +0000 (15:04 +0100)]
[!!!][TASK] Drop handling of M$ prefixed passwords

Passwords prefixed with M$ in fe_user or be_user table
are passwords that have been previously stored as simple md5
and have been converted to salted md5 using the saltedpasswords
converter task. That task has been removed in v9 already and
affected only users who did not log in for ages (multiple
core versions), since otherwise their password would have
been upgraded already.
The patch now finally drops the handling of M$ prefixed
passwords. If there are still users like that, they have
to have their password reset by and editor or admin user.

Resolves: #87489
Releases: master
Change-Id: I2d98476e91dd40c60a1084f9b05cf4ce7b9c5829
Reviewed-on: https://review.typo3.org/59487
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[BUGFIX] Adapt tests concerning fluid viewhelpers 74/59474/6
Anja Leichsenring [Fri, 18 Jan 2019 10:13:34 +0000 (11:13 +0100)]
[BUGFIX] Adapt tests concerning fluid viewhelpers

Since the release of fluid 2.6.0 unit tests fail due to
changed calling sequence. The unit tests use mocked calls
to keep track of internal sequence.
Using the prophecy mock framework gives better control and fixes
the issue for now.

Resolves: #87474
Releases: master, 9.5
Change-Id: I371ae8c7793ae74ecc827696cbbb97c30b3862f8
Reviewed-on: https://review.typo3.org/59474
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 months ago[!!!][TASK] Remove deprecated code from extensionmanager 80/59480/2
Christian Kuhn [Fri, 18 Jan 2019 12:02:07 +0000 (13:02 +0100)]
[!!!][TASK] Remove deprecated code from extensionmanager

Resolves: #87480
Releases: master
Change-Id: I9fcb2a9ace87d12f96c8ff3463358349b57841bd
Reviewed-on: https://review.typo3.org/59480
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 months ago[!!!][TASK] Drop deprecated code from ScalableVectorGraphicsContentObject 77/59477/3
Christian Kuhn [Fri, 18 Jan 2019 11:40:11 +0000 (12:40 +0100)]
[!!!][TASK] Drop deprecated code from ScalableVectorGraphicsContentObject

Resolves: #87479
Releases: master
Change-Id: Icd23eb06690ff775ba0aff516e01553fd2f6271e
Reviewed-on: https://review.typo3.org/59477
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 months ago[!!!][TASK] Remove deprecated code from Core/Cache 81/59481/2
Christian Kuhn [Fri, 18 Jan 2019 12:24:14 +0000 (13:24 +0100)]
[!!!][TASK] Remove deprecated code from Core/Cache

Resolves: #87481
Releases: master
Change-Id: I9d1fa4db56c2a7fe93a1d5e6a68fb7d42f623d63
Reviewed-on: https://review.typo3.org/59481
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 months ago[TASK] Drop a "probably not required" method from routing 86/59486/2
Christian Kuhn [Fri, 18 Jan 2019 13:32:18 +0000 (14:32 +0100)]
[TASK] Drop a "probably not required" method from routing

Method addArguments() of Route class is marked as
'@deprecated Probably not required'. It looks like
a left over from the routing development. The method is
indeed unused and can be dropped without further
notice from this @internal marked class.

Change-Id: Iefaec031003b55571c5d2f0f658fed9b25132cbb
Resolves: #87488
Releases: master.
Reviewed-on: https://review.typo3.org/59486
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 months ago[TASK] Drop some wrong deprecation annotations in extbase 83/59483/2
Christian Kuhn [Fri, 18 Jan 2019 13:11:30 +0000 (14:11 +0100)]
[TASK] Drop some wrong deprecation annotations in extbase

There are four @deprecated annotations in extbase query / persistence
area that have been marked as such in v6 and never removed. Those
methods are still used in extbase and needed. Remove the
deprecation notes for these methods.

Resolves: #87485
Releases: master
Change-Id: If47487792124909e736583819640133a135e090e
Reviewed-on: https://review.typo3.org/59483
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 months ago[TASK] Drop invalid deprecation annotation in TSFE 84/59484/2
Christian Kuhn [Fri, 18 Jan 2019 13:21:02 +0000 (14:21 +0100)]
[TASK] Drop invalid deprecation annotation in TSFE

There is an "Deprecated stuff" comment in
TypoScriptFrontendController that is there since before 4.5
times. The code below is clearly needed. Drop that comment.

Resolves: #87486
Releases: master
Change-Id: Ie0362742c4e1eac2ba3160dece9ee128347106d7
Reviewed-on: https://review.typo3.org/59484
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 months ago[TASK] Mark some places internal instead of deprecated 85/59485/2
Christian Kuhn [Fri, 18 Jan 2019 13:27:28 +0000 (14:27 +0100)]
[TASK] Mark some places internal instead of deprecated

Some methods in BasicFileUtility have been marked as
deprecated for various versions already but never removed
since they are still used within core.
Switch these to @internal to give core freedom to remove
these at will.

Resolves: #87487
Releases: master
Change-Id: I837dfbbfdc7069dd89f86133c75ad9b0fd45e046
Reviewed-on: https://review.typo3.org/59485
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 months ago[!!!][TASK] Do not rely on global variables for ext_*.php files 00/59300/7
Benni Mack [Thu, 27 Dec 2018 19:13:50 +0000 (20:13 +0100)]
[!!!][TASK] Do not rely on global variables for ext_*.php files

ext_tables.php, ext_localconf.php and all Configuration/TCA/*.php
do not have global scope anymore.

Thus, it is necessary to use
$GLOBALS['TYPO3_CONF_VARS'] instead of $TYPO3_CONF_VARS

Also, $_EXTKEY and $_EXTCONF are gone in these files.

Resolves: #87483
Releases: master
Change-Id: I2c33c696151ace8596cbc9a59a43ef188de26b9c
Reviewed-on: https://review.typo3.org/59300
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[!!!][TASK] Drop FILE content object 76/59476/2
Christian Kuhn [Fri, 18 Jan 2019 11:15:30 +0000 (12:15 +0100)]
[!!!][TASK] Drop FILE content object

Resolves: #87477
Releases: master
Change-Id: I0bffc072667c736195e002e4b3811055334cb633
Reviewed-on: https://review.typo3.org/59476
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[TASK] Add `.nvmrc` file 66/59466/3
Andreas Fernandez [Wed, 16 Jan 2019 21:37:15 +0000 (22:37 +0100)]
[TASK] Add `.nvmrc` file

nvm (node version manager) is a tool to have multiple node versions
installed. Since TYPO3 relies on an older node version right now, we can
provide support for nvm by adding a .nvmrc file.

This still requires to have nvm installed and configured on the client.

Resolves: #87468
Releases: master, 9.5, 8.7
Change-Id: Ie16827594fbdebeff1004cd178c28c67a61d60d7
Reviewed-on: https://review.typo3.org/59466
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[BUGFIX] Harden CommandUtility invocations 48/59448/2
Oliver Hader [Mon, 10 Dec 2018 07:51:21 +0000 (08:51 +0100)]
[BUGFIX] Harden CommandUtility invocations

In order to harden CommandUtility API arguments used for invoking
system commands are escaped in addition. Since no insecure usages
have been identified in the TYPO3 core nor in public third party
extensions, this change is handled using a public workflow.

| In order to evaluate whether third party extensions open a
| potential attack vector, usages of CommandUtility::checkCommand(),
| CommandUtility::getCommand() and the registration of custom services
| ($GLOBALS[‘T3_SERVICES’]) concerning their ‘exec’ argument have to
| be checked.

Resolves: #87450
Releases: master, 9.5, 8.7
Security-Advisory: TYPO3-PSA-2019-001
Change-Id: If4f2a63045ac7b2473881992f9731a635a768d37
Reviewed-on: https://review.typo3.org/59448
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
7 months ago[!!!][TASK] Remove deprecated code from AbstractTreeView 62/59462/3
Christian Kuhn [Wed, 16 Jan 2019 19:40:59 +0000 (20:40 +0100)]
[!!!][TASK] Remove deprecated code from AbstractTreeView

Resolves: #87466
Releases: master
Change-Id: Ia6e4dc9441b559c2e6dbeaa6276cd03bee12d13a
Reviewed-on: https://review.typo3.org/59462
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
7 months ago[BUGFIX] Fix duplicate rendering of 'pages' id-attribute 65/59465/3
theline [Wed, 16 Jan 2019 20:06:25 +0000 (21:06 +0100)]
[BUGFIX] Fix duplicate rendering of 'pages' id-attribute

When translations and (sub-)pages are present at the same time the
'page' id-attribute will be rendered twice.
This ensures that translations and (sub-)pages are independently
collapsible.

Resolves: #87465
Releases: master, 9.5
Change-Id: I0fd6a8323d89b34ecda0be7fb005fe64adb05928
Reviewed-on: https://review.typo3.org/59465
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[!!!][TASK] Remove deprecated code from PagePositionMap 57/59457/4
Christian Kuhn [Wed, 16 Jan 2019 18:52:12 +0000 (19:52 +0100)]
[!!!][TASK] Remove deprecated code from PagePositionMap

Resolves: #87460
Releases: master
Change-Id: Ib4df7ffc1e1b67ae1fcb7e5f68ccc4b89ac2baeb
Reviewed-on: https://review.typo3.org/59457
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[!!!][TASK] Remove deprecated code from ModuleTemplate 63/59463/3
Christian Kuhn [Wed, 16 Jan 2019 19:52:15 +0000 (20:52 +0100)]
[!!!][TASK] Remove deprecated code from ModuleTemplate

Resolves: #87467
Releases: master
Change-Id: I51e3b25545ffe6e3789524980f06920b11f80437
Reviewed-on: https://review.typo3.org/59463
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[TASK] Update Feature-84729-NewTCATypeSlug.rst 55/59455/4
Dmytro Nozdrin [Wed, 16 Jan 2019 14:42:55 +0000 (15:42 +0100)]
[TASK] Update Feature-84729-NewTCATypeSlug.rst

Fix code example for 'slug' TCA type according to this
https://docs.typo3.org/typo3cms/TCAReference/ColumnsConfig/Type/Slug.html

Releases: master, 9.5
Resolves: #87456
Change-Id: Ica3ebe037623ddc1fb679e362e041eca6e662b49
Reviewed-on: https://review.typo3.org/59455
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Sybille Peters <sypets@gmx.de>
Tested-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[!!!][TASK] Remove deprecated code from TypoScriptParser 56/59456/3
Christian Kuhn [Wed, 16 Jan 2019 18:44:18 +0000 (19:44 +0100)]
[!!!][TASK] Remove deprecated code from TypoScriptParser

Resolves: #87459
Releases: master
Change-Id: Iae4bd1efc937b225437d49857674276e18d5422c
Reviewed-on: https://review.typo3.org/59456
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[!!!][TASK] Remove deprecated code from DatabaseRowInitializeNew 60/59460/3
Christian Kuhn [Wed, 16 Jan 2019 19:22:28 +0000 (20:22 +0100)]
[!!!][TASK] Remove deprecated code from DatabaseRowInitializeNew

Resolves: #87463
Releases: master
Change-Id: I48cce7cea659036e58c1119fee4b4737df67ffbe
Reviewed-on: https://review.typo3.org/59460
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[!!!][TASK] Drop entry point typo3/install/index.php 58/59458/3
Christian Kuhn [Wed, 16 Jan 2019 19:00:44 +0000 (20:00 +0100)]
[!!!][TASK] Drop entry point typo3/install/index.php

The old install tool entry point "typo3/install/index.php" which was
deprecated is removed now.

The entry point "typo3/install.php" is still available to access the
install tool in its standalone version.

Resolves: #87461
Releases: master
Change-Id: I545bfe7f02449c94464cf024f951ea36a584fcf7
Reviewed-on: https://review.typo3.org/59458
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[!!!][TASK] Remove deprecated code from UserElement 61/59461/2
Christian Kuhn [Wed, 16 Jan 2019 19:26:40 +0000 (20:26 +0100)]
[!!!][TASK] Remove deprecated code from UserElement

Resolves: #87464
Releases: master
Change-Id: I20fac10c82f22c3e2dec0ed02e5f2a769866c966
Reviewed-on: https://review.typo3.org/59461
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
7 months ago[!!!][TASK] Remove deprecated code from ElementBrowserFolderTreeView 59/59459/2
Christian Kuhn [Wed, 16 Jan 2019 19:10:47 +0000 (20:10 +0100)]
[!!!][TASK] Remove deprecated code from ElementBrowserFolderTreeView

Resolves: #87462
Releases: master
Change-Id: Ia88bd74ce8710d93a8041242397901325094fd61
Reviewed-on: https://review.typo3.org/59459
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[!!!][TASK] Drop core 7->8 auto TCA migrations 45/59445/4
Christian Kuhn [Tue, 15 Jan 2019 14:09:46 +0000 (15:09 +0100)]
[!!!][TASK] Drop core 7->8 auto TCA migrations

Auto TCA migrations are now handled identical to
core upgrade wizards: They are kept for two versions.
The patch thus removes all TCA auto migrations
that applied if upgrading from v7 to v8 in current
v10 master. Along other stuff, especially the old
TCA 'wizard' stuff is no longer migrated to the
new syntax.

Resolves: #87447
Related: #87335
Releases: master
Change-Id: I05d795ef5c2c36bae3654d81eab5b82b4d3a2fa0
Reviewed-on: https://review.typo3.org/59445
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[BUGFIX] Fix various "No pseudo-site found in root line of page" errors 29/59229/6
Benni Mack [Wed, 19 Dec 2018 20:52:14 +0000 (21:52 +0100)]
[BUGFIX] Fix various "No pseudo-site found in root line of page" errors

Fixes workspace resolving etc.

The !empty statement is wrong as a string value "0" would not expect the
right return. This fixes the detection of l10n_parent.
Also check for sys_language_uid, too, to get the pid of the record
instead of its parent.

This also fixes opening categories (sys_category) when using EXT:news,
which calls this condition in TCA:
'displayCond' => 'USER:' . \TYPO3\CMS\Core\Compatibility\
PseudoSiteTcaDisplayCondition::class . '->isInPseudoSite:pages:false',

Check array index exists in SiteResolving.

Resolves: #79606
Resolves: #86186
Resolves: #86622
Resolves: #86678
Resolves: #86684
Releases: master, 9.5
Change-Id: If3ddf5eead2dddd51db3bcf751d71d3bc362ef35
Reviewed-on: https://review.typo3.org/59229
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[!!!][TASK] Do not handle 'uploadsfolder' in ext_emconf anymore 43/59443/6
Christian Kuhn [Tue, 15 Jan 2019 12:44:23 +0000 (13:44 +0100)]
[!!!][TASK] Do not handle 'uploadsfolder' in ext_emconf anymore

With TCA type=group with internal_type=file and
file_reference being dropped, the uploads/ folder
is unused and obsolete.
The patch drops further related code in this area,
especially the ext_emconf.php property uploadsfolder
is obsolete. It is dropped from all ext_emconf.php
files together with its handling in extensionmanager.

Change-Id: I93abc7d614b17adf4d0f2f896e346d3147c49472
Resolves: #87445
Releases: master
Reviewed-on: https://review.typo3.org/59443
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
7 months ago[!!!][TASK] Remove v7->v8 upgrade wizards 40/59440/3
Christian Kuhn [Tue, 15 Jan 2019 11:34:04 +0000 (12:34 +0100)]
[!!!][TASK] Remove v7->v8 upgrade wizards

Upgrade wizards created to upgrade from v7 to v8
are removed now. Note the DatabaseRowUpdater
mini-framework wizard does not register single
row updaters at the moment, is disabled but the
class is kept.

Resolves: #87440
Releases: master
Change-Id: If84dd1f0ce710f535e39516b984b94a9df2bccb2
Reviewed-on: https://review.typo3.org/59440
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[!!!][TASK] Remove deprecated code from backend controllers 38/59438/4
Christian Kuhn [Tue, 15 Jan 2019 10:33:08 +0000 (11:33 +0100)]
[!!!][TASK] Remove deprecated code from backend controllers

Last set of deprecation trait removals from controllers
of the backend extension. This one comes with minor and
straight changes to improve code structure of some of the
simple controllers along the way.

Resolves: #87437
Releases: master
Change-Id: I4c6b453a3341ced072337896002fba250dd230a9
Reviewed-on: https://review.typo3.org/59438
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[BUGFIX] Drop a unit test that relies on uploads folder 42/59442/4
Christian Kuhn [Tue, 15 Jan 2019 12:30:00 +0000 (13:30 +0100)]
[BUGFIX] Drop a unit test that relies on uploads folder

With the removal of type=group internal_type=file and
file_reference, the uploads folder is obsolete. The
patch drops a last unit test that relies on its
existance, so typo3/testing-framework no longer
needs to create that directory for tests.

Change-Id: I76984d4717112c63d0befa8faa708d4f5cf408eb
Resolves: #87441
Releases: master
Reviewed-on: https://review.typo3.org/59442
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
7 months ago[BUGFIX] Use correct variable to select a subfolder within folder selector 20/59420/3
Ioulia Kondratovitch [Fri, 11 Jan 2019 21:04:26 +0000 (22:04 +0100)]
[BUGFIX] Use correct variable to select a subfolder within folder selector

Use correct variable to select a subfolder within the folder selector
instead of using the variable for parent-folder identifier.

Resolves: #87415
Releases: master, 9.5
Change-Id: I8bb30f81aea2b17f0b3567b9272e239b2beaf772
Reviewed-on: https://review.typo3.org/59420
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[!!!][TASK] Drop support for deprecated cache usage in ext_localconf 31/59231/10
Benjamin Franzke [Wed, 19 Dec 2018 09:44:58 +0000 (10:44 +0100)]
[!!!][TASK] Drop support for deprecated cache usage in ext_localconf

The initialization of the CacheManager has a design problem:

The *CacheManager* is used to create the core_cache. That core_cache
is used to read the (possibly) cached *CacheManager* configuration
(from ext_localconf.php), which is then used to (re)configure the
already-being-used *CacheManager* after ext_localconf.php has been
loaded. That means an extension can create a cache while it has
not been configured by a second extension. That behaviour was
deprecated in v9 and can therefore be dropped now.

We now create the core cache (and because of requirements
in core currently also the 'assets' cache) during early bootstrap
(independently from the CacheManager) and inject these early caches
into the CacheManager instance later on. The CacheManager instance is now
created during late bootstrap.
Looking forward to a Dependency Injection (DI) container, this change will
allow to move the CacheManager creation from bootstrap code into the DI
service providers (which will allow the CacheManager to be instantiated
on demand)

Releases: master
Resolves: #87245
Related: #86353
Change-Id: I984beabdbbd550c191de347fdc19166283452a88
Reviewed-on: https://review.typo3.org/59231
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[!!!][TASk] Remove deprecated code from controllers 39/59439/2
Christian Kuhn [Tue, 15 Jan 2019 11:19:28 +0000 (12:19 +0100)]
[!!!][TASk] Remove deprecated code from controllers

Last part of controller deprecation removals and
deprecation trait usages. Affects extensions
recordlist, reports and rte_ckeditor.

Change-Id: I88f7ea2e708629b889b09b279f09a7f82dcb8801
Resolves: #87439
Releases: master
Reviewed-on: https://review.typo3.org/59439
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[!!!][TASK] Remove deprecated code from backend Controller/File 28/59428/3
Christian Kuhn [Mon, 14 Jan 2019 15:06:11 +0000 (16:06 +0100)]
[!!!][TASK] Remove deprecated code from backend Controller/File

Resolves: #87431
Releases: master
Change-Id: Idb7a87bce6d7edee409bc24348b185ea51c17de2
Reviewed-on: https://review.typo3.org/59428
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
7 months ago[!!!][TASK] Remove deprecated code from backend ContentElement 29/59429/2
Christian Kuhn [Mon, 14 Jan 2019 15:42:39 +0000 (16:42 +0100)]
[!!!][TASK] Remove deprecated code from backend ContentElement

Resolves: #87432
Releases: master
Change-Id: I9f27b0b59d34e7ae9ceb681db4f0225b55fcaec6
Reviewed-on: https://review.typo3.org/59429
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
7 months ago[BUGFIX] Use argument $tparams BackendUtility::thumbCode for FAL items 17/59417/2
Georg Ringer [Fri, 11 Jan 2019 19:59:20 +0000 (20:59 +0100)]
[BUGFIX] Use argument $tparams BackendUtility::thumbCode for FAL items

Add the argument $tparams to the image tag also for FAL items.

Resolves: #87410
Releases: master, 9.5
Change-Id: I4961a829e2497c747824a76ce5277a7dfe35c2d1
Reviewed-on: https://review.typo3.org/59417
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[!!!][TASK] Remove internal_type=file/file_reference 61/59361/11
Benni Mack [Mon, 7 Jan 2019 18:40:30 +0000 (19:40 +0100)]
[!!!][TASK] Remove internal_type=file/file_reference

This drops TCA type=group with internal_type=file and
internal_type=file_reference handling.
This patch is rather huge since detail handling of this
stuff is spread throughout the core. Additionally, some
further methods become unused and oboselete along the way.
Most of them - except DataHandler->process_uploads() - have
been used internally only and can be safetly dropped,
while process_uploads() which has always been part of the
externally called API is substituted with a no-op method.

Resolves: #87428
Releases: master
Change-Id: Ia60b5d0e021b34adf4b4187a5f1fe4475b0070b4
Reviewed-on: https://review.typo3.org/59361
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[BUGFIX] Use proper typolink with clean TSFE for redirects 32/59032/6
Benni Mack [Tue, 4 Dec 2018 20:33:33 +0000 (21:33 +0100)]
[BUGFIX] Use proper typolink with clean TSFE for redirects

Instead of re-using $GLOBALS['TSFE'] with
an already set $id and $type query
params, a new instance is created depending
on the given site.

Resolves: #87070
Releases: master, 9.5
Change-Id: I65b0b5c7c89db69c99600232927a00575c15d231
Reviewed-on: https://review.typo3.org/59032
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[!!!][TASK] Remove deprecated arguments from TranslateElementErrorViewHelper 77/59377/3
Georg Ringer [Tue, 8 Jan 2019 18:58:23 +0000 (19:58 +0100)]
[!!!][TASK] Remove deprecated arguments from TranslateElementErrorViewHelper

Resolves: #87371
Releases: master
Change-Id: Ie7df7b29f3a82a954856d1f7c922cd726f2a43b8
Reviewed-on: https://review.typo3.org/59377
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
7 months ago[BUGFIX] Check for unset font if text is set in GIFBUILDER 18/59418/3
Tom Novotny [Fri, 11 Jan 2019 20:44:49 +0000 (21:44 +0100)]
[BUGFIX] Check for unset font if text is set in GIFBUILDER

You can set a text without defining a font file to be used, explicitly.

Resolves: #87363
Releases: master, 9.5
Change-Id: I5cbb447da29cf49ad23f621261044edea12ccb7f
Reviewed-on: https://review.typo3.org/59418
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
7 months ago[FEATURE] Improve ClassSchema properties api 82/59382/9
Alexander Schnitzler [Wed, 9 Jan 2019 11:35:16 +0000 (12:35 +0100)]
[FEATURE] Improve ClassSchema properties api

This patch introduces a new Property class to have an
easier and more stable api to get information about class
properties from ClassSchema objects

The reflection data fetched and stored by/in the ClassSchema
objects is no longer publicly available as an array. Instead,
Property objects are returned for the following calls:

- getProperty
- getProperties

Releases: master
Resolves: #87377
Change-Id: Ica09e7f2df42638497cbde1aea35d62c42332d3f
Reviewed-on: https://review.typo3.org/59382
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
7 months ago[BUGFIX] Remove bottom margin of image content elements 13/59013/2
Jan Kiesewetter [Mon, 3 Dec 2018 08:45:05 +0000 (09:45 +0100)]
[BUGFIX] Remove bottom margin of image content elements

Resolves: #87059
Releases: master
Change-Id: I842fa15aa7bb8a01035299be1298f2a5d9480c98
Reviewed-on: https://review.typo3.org/59013
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Raphael Graf <r@undefined.ch>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Jonas Esser <info@jonas-esser.de>
Tested-by: Jonas Esser <info@jonas-esser.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>