Packages/TYPO3.CMS.git
4 months ago[BUGFIX] Do not treat all classes as entities in ClassSchema 28/59628/3
Alexander Schnitzler [Mon, 4 Feb 2019 09:03:08 +0000 (10:03 +0100)]
[BUGFIX] Do not treat all classes as entities in ClassSchema

The ClassSchema class has a property $modelType which indicates
that a class is either an entity or a value object. This property
has a default value that reflected the state of an entity.

This means, that all classes, class schemata are created for are
considered entities which then leads to the execution of further
entity related analysis code, such as looking for specific doc
blocks and/or annotations.

While this isn't an issue functionality wise, it can be in the future.
Also, the superfluous cpu cycles can and should be spared.

Releases: master, 9.5
Resolves: #87632
Change-Id: If4bc79b9761ee28ffd9e2f25924588140310c0fa
Reviewed-on: https://review.typo3.org/c/59628
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Don't call mergeRecursiveWithOverrule with null argument 19/59719/4
Alexander Schnitzler [Mon, 18 Feb 2019 13:56:14 +0000 (14:56 +0100)]
[BUGFIX] Don't call mergeRecursiveWithOverrule with null argument

During the removal of deprecated code in Extbase, a bug has been
introduced which is fixed with this patch.

Releases: master
Resolves: #87732
Relates: #87269
Change-Id: I5739acf64c65ad5eb79bcf16c6e7962366af59f6
Reviewed-on: https://review.typo3.org/c/59719
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Respect no_cache in PageLinkBuilder 15/59715/2
Georg Ringer [Mon, 18 Feb 2019 07:18:32 +0000 (08:18 +0100)]
[BUGFIX] Respect no_cache in PageLinkBuilder

If a link is being built with a site configuration, the
configuration no_cache must be respected.

Resolves: #87728
Releases: master, 9.5
Change-Id: I8d71f11ca953c5744063deec318d9a23c11c1337
Reviewed-on: https://review.typo3.org/c/59715
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[!!!][TASK] Harden \TYPO3\CMS\Extbase\Property\TypeConverterInterface 30/59630/5
Alexander Schnitzler [Mon, 4 Feb 2019 13:49:23 +0000 (14:49 +0100)]
[!!!][TASK] Harden \TYPO3\CMS\Extbase\Property\TypeConverterInterface

- Use strict type mode
- Use type hints whereever possible

Releases: master
Resolves: #87654
Change-Id: I3f78f502a33f9c9eae61847f32b3f17f47a69836
Reviewed-on: https://review.typo3.org/c/59630
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Mock FileRepository Singletons in unit tests 55/59755/2
Benjamin Franzke [Mon, 18 Feb 2019 14:56:21 +0000 (15:56 +0100)]
[TASK] Mock FileRepository Singletons in unit tests

Prevent indirect SignalSlot\Dispatcher and ObjectManager
invocation by mocking FileRepository.

Releases: master, 9.5
Resolves: #87740
Change-Id: Ia193cc52af95bae9b1306bef012c7871bf939b41
Reviewed-on: https://review.typo3.org/c/59755
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Use constructor injection in PersistenceManager 33/59633/3
Alexander Schnitzler [Mon, 4 Feb 2019 15:31:16 +0000 (16:31 +0100)]
[TASK] Use constructor injection in PersistenceManager

Class PersistenceManager does no longer use setter injection but
constructor injection instead.

Releases: master
Resolves: #87644
Change-Id: Id8daa169cf5cc8756aae47321d828d37bca21233
Reviewed-on: https://review.typo3.org/c/59633
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Deprecate TypeHandlingUtility::hex2bin 03/59603/4
Alexander Schnitzler [Fri, 1 Feb 2019 11:59:31 +0000 (12:59 +0100)]
[TASK] Deprecate TypeHandlingUtility::hex2bin

Method \TYPO3\CMS\Extbase\Utility\TypeHandlingUtility::hex2bin
has been deprecated. As of PHP 5.4, a native function hex2bin
exists, which should be used instead.

Releases: master
Resolves: #87613
Change-Id: I19cfade0584762148a611713412889bec4895200
Reviewed-on: https://review.typo3.org/c/59603
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[FEATURE] Introduce BitSet class 50/59650/6
Alexander Schnitzler [Wed, 6 Feb 2019 10:35:23 +0000 (11:35 +0100)]
[FEATURE] Introduce BitSet class

This patch introduces a simple BitSet class that
can be used to handle boolean flags.

Releases: master
Resolves: #87665
Change-Id: I32911ed1213421ef30596c2aceb4b8cbd27a8a45
Reviewed-on: https://review.typo3.org/c/59650
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Migrate existing ViewHelper docs to valid rst 44/58844/15
Daniel Siepmann [Mon, 5 Nov 2018 17:17:53 +0000 (18:17 +0100)]
[TASK] Migrate existing ViewHelper docs to valid rst

* In order to allow proper rendering at docs.typo3.org
* Only migrated HTML to rst, and streamlined structure.

Resolves: #86855
Releases: master, 9.5
Change-Id: Ia617d24b0e70182b8702b23a340ad1f2b536910e
Reviewed-on: https://review.typo3.org/c/58844
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Use real ObjectManager stubs in unit tests 57/59757/3
Benjamin Franzke [Mon, 18 Feb 2019 07:12:15 +0000 (08:12 +0100)]
[TASK] Use real ObjectManager stubs in unit tests

Prevent invocation of the constructor (which instantiates
an internal instance of the extbase container) and do not
mix usage of mocked and stubbed methods.

The mixture happened due to the usage of setMethods():
When specifing `setMethods(['get'])` all methods besides ->get()
are actually proxied to the real ObjectManager methods.

Releases: master, 9.5
Resolves: #87742
Change-Id: I817f8ee90d82f36b8117e873b5802e11f601384e
Reviewed-on: https://review.typo3.org/c/59757
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Mock ResourceFactory Singletons in unit tests 54/59754/4
Benjamin Franzke [Mon, 18 Feb 2019 13:54:49 +0000 (14:54 +0100)]
[TASK] Mock ResourceFactory Singletons in unit tests

This prevents indirect SignalSlotDispatcher and ObjectManager
invocation by stubbing the ResourceFactory (or removing unneeded
mocks by preventing constructor invocation as in ImageServiceTest).

Releases: master, 9.5
Resolves: #87739
Change-Id: I70c5413fbdf66f3deb8ae0113e62f17ad8168f19
Reviewed-on: https://review.typo3.org/c/59754
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Mock SignalSlot\Dispatcher Singletons in unit tests 56/59756/3
Benjamin Franzke [Mon, 18 Feb 2019 07:59:10 +0000 (08:59 +0100)]
[TASK] Mock SignalSlot\Dispatcher Singletons in unit tests

Prevent indirect ObjectManager invocation by mocking FileRepository.

Releases: master, 9.5
Resolves: #87741
Change-Id: I4a0c4f322f47223406a313f222f1f5b5e53c6ed7
Reviewed-on: https://review.typo3.org/c/59756
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Do not instantiate DocumentTemplate at every BE call 81/59781/3
Benni Mack [Thu, 21 Feb 2019 16:08:19 +0000 (17:08 +0100)]
[TASK] Do not instantiate DocumentTemplate at every BE call

Currently, document template and thus, pagerenderer is initialized
with all functionality and loaded CSS for every BE call,
which is unnecessary for simple JSON-based AJAX calls.

In order to avoid this, PageRenderer is now instantiated only
when needed - when ModuleTemplate or DocumentTemplate
are initialized, resulting in higher performance for AJAX calls
but also removing a necessary means for having DocumentTemplate
set up at all BE requests, reducing the need for DocTemplate
even more, so it can slowly be migrated to ModuleTemplate
in the future.

Resolves: #87766
Releases: master
Change-Id: Ic1549be7f4d62164bf99cb496fad4b96dee2bc7d
Reviewed-on: https://review.typo3.org/c/59781
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[!!!][TASK] Remove [SYS][recursiveDomainSearch] option 82/59782/3
Benni Mack [Thu, 21 Feb 2019 16:58:38 +0000 (17:58 +0100)]
[!!!][TASK] Remove [SYS][recursiveDomainSearch] option

The option related to sys_domain records and pseudo-sites
is removed due to the upcoming removal of Pseudo Sites.

Resolves: #87767
Releases: master
Change-Id: Ife933f86d9ce3d8049e2e74d856a6ec0df3e4e40
Reviewed-on: https://review.typo3.org/c/59782
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Use PageRenderer directly in LoginController 80/59780/3
Benni Mack [Thu, 21 Feb 2019 15:53:08 +0000 (16:53 +0100)]
[TASK] Use PageRenderer directly in LoginController

In order to emphasize the PageRenderer API and get rid
of DocumentTemplate logic in further refactorings, the inline
CSS and JavaScript is added directly to the PageRenderer
instead of the document template, which contains its own
legacy-concatenation magic.

Resolves: #87765
Releases: master
Change-Id: Id5db83f34f3ab31b016198cb90a8c84126b43dd6
Reviewed-on: https://review.typo3.org/c/59780
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Clean up Backend Controller 53/59753/2
Benni Mack [Tue, 19 Feb 2019 09:05:40 +0000 (10:05 +0100)]
[TASK] Clean up Backend Controller

The main backend controller has some pre v7 code built-in where
special handling of JavaScript includes and files could be extended
via hooks, which have been removed. This way, code within the Backend
Controller can be simplified, allowing for further work in this class.

Resolves: #87736
Releases: master
Change-Id: Ic777630cef51714197451077beebefd8e445936d
Reviewed-on: https://review.typo3.org/c/59753
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Do not render unused attribute in Checkbox element 74/59774/2
Benni Mack [Wed, 20 Feb 2019 22:54:57 +0000 (23:54 +0100)]
[BUGFIX] Do not render unused attribute in Checkbox element

Due to refactoring in FormEngine back in 2015, the Checkbox
Element renders " ... 1 ... " when a checkbox element is not
disabled.

To overcome this, the ternary operator is turned around,
returning an empty string when the element is not disabled.

Resolves: #87754
Releases: master, 9.5
Change-Id: Ic5fad1335fbdf1ed76523f598c20f66bfe195686
Reviewed-on: https://review.typo3.org/c/59774
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
4 months ago[!!!][TASK] Remove deprecated parsing of <link> tag 75/59775/2
Benni Mack [Wed, 20 Feb 2019 23:05:12 +0000 (00:05 +0100)]
[!!!][TASK] Remove deprecated parsing of <link> tag

The original <link> tag was replaced in TYPO3 v8 by using
proper <a> tags with href="t3://" syntax, which is handled
by the new LinkService introduced in v8. All database RTE fields
were migrated to <a> tags, but the link tag code was kept for
the time being, which is now removed.

The result is that <link> tags are now never replaced
when rendering the Frontend now.

Resolves: #87755
Releases: master
Change-Id: I10afba763736a6b91cbca513f7496dee86da8902
Reviewed-on: https://review.typo3.org/c/59775
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[BUGFIX] Catch orphaned language related exception 42/59642/2
Patrick Schriner [Tue, 5 Feb 2019 11:57:21 +0000 (12:57 +0100)]
[BUGFIX] Catch orphaned language related exception

Generating a preview link will not crash the backend when the relevant
site is missing the language information to build the proper url.

Resolves: #87510
Releases: master, 9.5
Change-Id: I49b006f83cb6dcf4f105f215e8c069b465b6408c
Reviewed-on: https://review.typo3.org/c/59642
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: dmst <sascha.ternes@diemedialen.de>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: dmst <sascha.ternes@diemedialen.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
4 months ago[TASK] Do not use ObjectManager to instantiate PageTitleProviderManager 52/59752/3
Benjamin Franzke [Mon, 18 Feb 2019 22:38:07 +0000 (23:38 +0100)]
[TASK] Do not use ObjectManager to instantiate PageTitleProviderManager

PageTitleProviderManager is public API in EXT:core and should therefore
not depend on initialization through the EXT:extbase ObjectManager.

PageTitleProviderManager actually does not use any ObjectManager features,
so the current instantiation in TypoScriptFrontendController can simply be
replaced by GeneralUtility::makeInstance().

Releases: master, 9.5
Resolves: #87735
Change-Id: I56231f834b6cf40d613bea84334eb48d03ca6094
Reviewed-on: https://review.typo3.org/c/59752
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
4 months ago[BUGFIX] fix windows file paths in copydirectory 79/47879/2
Jigal van Hemert [Sat, 23 Apr 2016 18:39:01 +0000 (20:39 +0200)]
[BUGFIX] fix windows file paths in copydirectory

Make sure forward slashes are used in paths. Also, use a string
to pass to upload_copy_move instead of an SplFileInfo object.

Resolves: #75887
Releases: master
Change-Id: Ida634e954b19bd1dee5ab5aca25affab51e8ed06
Reviewed-on: https://review.typo3.org/c/47879
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Elmar Hinz <t3elmar@gmail.com>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Sonja Großewinkelmann <s.grossewinkelmann@neusta.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Alessandro Filira <alessandro.filira@pallino.it>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Update tslint.json and fix build 96/59696/5
Andreas Fernandez [Wed, 13 Feb 2019 14:00:59 +0000 (15:00 +0100)]
[BUGFIX] Update tslint.json and fix build

This patch updates the definitions in tslint.json to use current settings
for TypeScript builds.

Most of the occurred issues were fixed by executing

  cd Build
  ./node_modules/tslint/bin/tslint -c tslint.json --fix --project .

Resolves: #87709
Releases: master, 9.5
Change-Id: Iba318b438a44f6de3fdfcacfb52a5bddef9c8002
Reviewed-on: https://review.typo3.org/c/59696
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[TASK] Harden \TYPO3\CMS\Extbase\Utility\LocalizationUtility 95/59595/5
Alexander Schnitzler [Thu, 31 Jan 2019 18:30:51 +0000 (19:30 +0100)]
[TASK] Harden \TYPO3\CMS\Extbase\Utility\LocalizationUtility

- Use strict type mode
- Use type hints whereever possible

Releases: master
Resolves: #87600
Change-Id: Ie57d5515f97909191b61927d820713615c6a8b69
Reviewed-on: https://review.typo3.org/c/59595
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Migrate AdminPanel modules to TypeScript 89/59689/4
Frank Naegler [Wed, 13 Feb 2019 08:54:40 +0000 (09:54 +0100)]
[TASK] Migrate AdminPanel modules to TypeScript

Resolves: #87702
Releases: master
Change-Id: I5e90dd30a006304005693a629270c1d787655974
Reviewed-on: https://review.typo3.org/c/59689
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Migrate TYPO3/CMS/Tstemplate/* to TypeScript 93/59693/4
Frank Naegler [Wed, 13 Feb 2019 11:24:00 +0000 (12:24 +0100)]
[TASK] Migrate TYPO3/CMS/Tstemplate/* to TypeScript

Resolves: #87705
Releases: master
Change-Id: Ife45202ad6151ad00f20aefdac881c99a88b93a3
Reviewed-on: https://review.typo3.org/c/59693
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Migrate TYPO3/CMS/Viewpage/Main to TypeScript 91/59691/4
Frank Naegler [Wed, 13 Feb 2019 10:20:44 +0000 (11:20 +0100)]
[TASK] Migrate TYPO3/CMS/Viewpage/Main to TypeScript

Resolves: 87704
Releases: master
Change-Id: Ie502ba03c95e4efde77f07245f7cd260db48565a
Reviewed-on: https://review.typo3.org/c/59691
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Migrate TYPO3/CMS/Scheduler/* to TypeScript 94/59694/3
Frank Naegler [Wed, 13 Feb 2019 11:56:35 +0000 (12:56 +0100)]
[TASK] Migrate TYPO3/CMS/Scheduler/* to TypeScript

Resolves: #87707
Releases: master
Change-Id: I942fcd9b98daea74c97e42885bd079ad5505c409
Reviewed-on: https://review.typo3.org/c/59694
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Migrate TYPO3/CMS/Opendocs/OpendocsMenu to TypeScript 92/59692/4
Frank Naegler [Wed, 13 Feb 2019 10:55:55 +0000 (11:55 +0100)]
[TASK] Migrate TYPO3/CMS/Opendocs/OpendocsMenu to TypeScript

Resolves: #87703
Releases: master
Change-Id: Ie44d5feae31b8c4cf64c621d12a42d6f7e6d574e
Reviewed-on: https://review.typo3.org/c/59692
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Replace IRC with Slack in composer support section 05/59705/2
Tomas Norre Mikkelsen [Fri, 15 Feb 2019 10:25:13 +0000 (11:25 +0100)]
[TASK] Replace IRC with Slack in composer support section

Remove reference to irc as it is not used anymore. Linking
to Slack instead.

Resolves: #87720
Releases: master, 9.5, 8.7
Change-Id: I7dea0d62329e8e361b8ac37a1d18b9f9f8603943
Reviewed-on: https://review.typo3.org/c/59705
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Harden \TYPO3\CMS\Extbase\Object\Container\Container 01/59601/4
Alexander Schnitzler [Thu, 31 Jan 2019 20:17:00 +0000 (21:17 +0100)]
[TASK] Harden \TYPO3\CMS\Extbase\Object\Container\Container

- Use strict type mode
- Use type hints whereever possible

Releases: master
Resolves: #87606
Change-Id: I8dfdb347beca5468da1b8cb2f8a05ec7dbf4418a
Reviewed-on: https://review.typo3.org/c/59601
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Missing quote in declaring the task example 81/59681/2
Phillip Schallmayer [Mon, 11 Feb 2019 14:31:10 +0000 (15:31 +0100)]
[TASK] Missing quote in declaring the task example

The current declaring a task example produces a PHP syntax error because
of a missing quote

Releases: master
Resolves: #87690
Change-Id: Idbff9169488d30d986787e82bf0774e4908f23f5
Reviewed-on: https://review.typo3.org/59681
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] EXT:opendocs - Remove bogus initial document count 08/59708/2
Andreas Fernandez [Fri, 15 Feb 2019 16:15:22 +0000 (17:15 +0100)]
[BUGFIX] EXT:opendocs - Remove bogus initial document count

When the opendocs toolbar item gets initialized, the document count shows
a bogus value as deleted records are not removed from the calculation.

As the documents are loaded deferred since #84412, the correct value gets
in place automatically which renders the initial counting obsolete and is
removed with this patch.

Additonally, a wrong class hint in OpenDocumentController is fixed.

Resolves: #87725
Related: #84412
Releases: master, 9.5
Change-Id: I0684e0950d0f4daf11042d6c078b5598bfb3d4be
Reviewed-on: https://review.typo3.org/59708
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
4 months ago[BUGFIX] Have stdWrap.lang use Site concept 98/59698/4
Benni Mack [Thu, 14 Feb 2019 08:57:33 +0000 (09:57 +0100)]
[BUGFIX] Have stdWrap.lang use Site concept

When building TypoScript like this:

10 = TEXT
10.value = English
10.lang.dk = danish

This does not work currently as it relies on "config.language". This part
has been forgotten while the Site Handling was initially implemented into
the TYPO3 core.

The patch adapts the changes to make use of Site Handling if it is available,
but falls back to the TypoScript options (for PseudoSites).

Resolves: #87712
Releases: master, 9.5
Change-Id: I5e2b97b178e6ccafec1ff7556d41321ea67fb45a
Reviewed-on: https://review.typo3.org/59698
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[DOCS] Document rte_ckeditor 27/59627/11
Sybille Peters [Sun, 3 Feb 2019 20:18:08 +0000 (21:18 +0100)]
[DOCS] Document rte_ckeditor

Resolves: #85461
Releases: master, 9.5, 8.7
Change-Id: I36eef1d24fce233639e2047cc2f09d972ccbe046
Reviewed-on: https://review.typo3.org/59627
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Allow type 'check' in site configuration 83/59683/4
Julian Wundrak [Mon, 11 Feb 2019 20:42:51 +0000 (21:42 +0100)]
[TASK] Allow type 'check' in site configuration

Add check option to site-config tca for something like active or
maintenance mode
Resolves: #87692
Releases: master, 9.5
Change-Id: Idaa09a5929db5bdf177e57c5f78f827047705f91
Reviewed-on: https://review.typo3.org/59683
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: André Schließer <andy.schliesser@gmail.com>
Tested-by: André Schließer <andy.schliesser@gmail.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[BUGFIX] Add missing interface to AdminPanel Cache Module 88/59688/3
Frank Naegler [Wed, 13 Feb 2019 08:32:03 +0000 (09:32 +0100)]
[BUGFIX] Add missing interface to AdminPanel Cache Module

The AdminPanel Cache Module has to implement the
ResourceProviderInterface to load the required JavaScript module.

Resolves: #87701
Releases: master, 9.5
Change-Id: Ib8c440bc5847da64aad480dc98adda7b440f4bf9
Reviewed-on: https://review.typo3.org/59688
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 months ago[BUGFIX] Cast lastMod property to int 82/59682/4
Richard Haeser [Mon, 11 Feb 2019 19:24:39 +0000 (20:24 +0100)]
[BUGFIX] Cast lastMod property to int

To prevent type mismatches when using pdo_mysql as the database driver,
the data for the lastMod field is cast to an integer.

Resolves: #87689
Releases: master, 9.5
Change-Id: I696f62a3b08d464708c9e1ab9edb4c733835f475
Reviewed-on: https://review.typo3.org/59682
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: André Schließer <andy.schliesser@gmail.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[BUGFIX] Simplify if in typolink 85/59685/2
Stefan Froemken [Tue, 12 Feb 2019 15:29:20 +0000 (16:29 +0100)]
[BUGFIX] Simplify if in typolink

Resolves: #87696
Releases: master
Change-Id: I50eb442bc2130ed5a0741ea3f71558257535ff89
Reviewed-on: https://review.typo3.org/59685
Reviewed-by: Pascal Rinker <info@crynton.com>
Tested-by: Pascal Rinker <info@crynton.com>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Raise php-cs-fixer version 77/59677/4
Benni Mack [Mon, 11 Feb 2019 05:36:40 +0000 (06:36 +0100)]
[TASK] Raise php-cs-fixer version

Used
 * composer update friendsofphp/php-cs-fixer --with-all-dependencies

The new php-cs-fixer is compatible with PHP7.3+ and fixes
some more issues configured according to our code style settings.

Resolves: #87684
Releases: master, 9.5
Change-Id: Ibb2150eea173ded11495866aa171dd171aca7efd
Reviewed-on: https://review.typo3.org/59677
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Update doctrine/dbal to ~2.8.0 68/59668/10
Benni Mack [Sun, 30 Sep 2018 23:06:46 +0000 (01:06 +0200)]
[TASK] Update doctrine/dbal to ~2.8.0

doctrine/dbal 2.7.x will reach end of life before core
v9 is out of support. We should upgrade to at least 2.8:

composer req doctrine/dbal:~2.8.0

https://www.doctrine-project.org/2018/07/12/common-2-9-and-dbal-2-8-and-orm-2-6-2.html

Also needs a typo3/testing-framework raise:

composer req --dev typo3/testing-framework:~5.0.5

Needed core changes:
- DBAL does not add "OFFSET 0" if nothing given (test change only)
- SQLite does not need "PRIMARY KEY" if autoincrement is given (in DefaultTcaSchema)

Resolves: #86490
Releases: master, 9.5
Change-Id: I28014d252a57f7f421242e35086c63a0a824ed04
Reviewed-on: https://review.typo3.org/59668
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Keep language reference for children using l10n_mode=exclude 29/59629/8
Oliver Hader [Mon, 4 Feb 2019 12:51:37 +0000 (13:51 +0100)]
[BUGFIX] Keep language reference for children using l10n_mode=exclude

Having 1:n child associations being defined as l10n_mode=exclude on their
parent side, currently leads to deleting and recreating the child entity
(re-synchronization). For composite relations (children can only exist
with their parent - usually accessed through their parent as aggregate
root) this is "okay" in terms of domain-driven design.

However having large data-sets leads to performance impact during the
re-synchronization process.

In the current scenario children processed with l10n_mode=exclude did not
have any pointer to their language origin (due to l10n_parent not being
set). This change copies these children and applies the same values as
used for localizations - without actually invoking the localization
process.

For l10n_mode=exclude children this means, the sys_language_uid and
l10n_parent values are now set - which have been empty before.

Resolves: #87640
Releases: master, 9.5
Change-Id: I3d862f536603b9e49c7a5d3205ccfc2b4e2e9532
Reviewed-on: https://review.typo3.org/59629
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Allow strings in site configuration type "select" 49/59649/2
Georg Ringer [Wed, 6 Feb 2019 07:49:47 +0000 (08:49 +0100)]
[TASK] Allow strings in site configuration type "select"

To allow more usecases for extending the site configuration,
the value of tca type select should only be typecasted
if it looks like an integer.

Resolves: #87663
Releases: master, 9.5
Change-Id: I700bba3ac67ceac9acc8aa473d1b723b4bc34f4f
Reviewed-on: https://review.typo3.org/59649
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Scheduler: Remove label from progress bar 21/59621/2
Thorben Nissen [Sat, 2 Feb 2019 11:55:07 +0000 (12:55 +0100)]
[BUGFIX] Scheduler: Remove label from progress bar

Remove the label `Check/Uncheck all` from the progress bar and show only
the process percentage.

Resolves: #87624
Releases: master, 9.5
Change-Id: Iff6cbb47099747f613d4ea90ab75863454c2669b
Reviewed-on: https://review.typo3.org/59621
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[BUGFIX] Cast fallback language uids to integer 62/59662/7
Andreas Fernandez [Thu, 7 Feb 2019 12:04:05 +0000 (13:04 +0100)]
[BUGFIX] Cast fallback language uids to integer

To prepare a couple of bugfixes regarding the language fallback handling,
the property `SiteLanguage::$fallbackLanguageIds` must be an array of
integer values. The patch ensures that all values are cast to integers.

Resolves: #87673
Releases: master, 9.5
Change-Id: I437a08ce992718f601a612df4cddd9ecac5e1d3a
Reviewed-on: https://review.typo3.org/59662
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 months ago[!!!][TASK] Build strict PSR-15 middlewares 90/59490/6
Benni Mack [Fri, 18 Jan 2019 19:18:37 +0000 (20:18 +0100)]
[!!!][TASK] Build strict PSR-15 middlewares

All PSR-15 middlewares now do not set the
$GLOBALS['TYPO3_REQUEST'] object anymore. Instead,
the RequestHandlers are using them for all
other logic (e.g. GP etc) where the request object
or any other attribute has not been handed in
yet.

It is now safe to say that PSR-7 request/response
objects have to be used within middlewares to
access or manipulate GET/POST data. Also,
the safety net for overriding GET/POST again
is still in place for FE (data = GP:id) in
order for existing TypoScript to work still,
until all other code gets global-free.

There are still places in TYPO3 Core where $TYPO3_REQUEST
is necessary (TypoScriptConditionMatcher, Error Handling)
which are added accordingly.

Resolves: #87661
Releases: master
Change-Id: Ibe499b6fda86ccd3abefcb3c8be294a7cb765d74
Reviewed-on: https://review.typo3.org/59490
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[BUGFIX] Revert Set controller in ExtbasePluginEnhancer" 58/59658/3
Benni Mack [Thu, 7 Feb 2019 08:28:09 +0000 (09:28 +0100)]
[BUGFIX] Revert Set controller in ExtbasePluginEnhancer"

The accepted change adds an ugly side-effect when using
the same controller/action in multiple route variants.

This reverts commit 977ed578d04a3c2094cdad3207b5d9f86322f326.

Resolves: #87668
Reverts: #87337
Releases: master, 9.5

Change-Id: I7167b42cb26538e676256c9d2e36d1ec18f2bd40
Reviewed-on: https://review.typo3.org/59658
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[BUGFIX] Set controller in ExtbasePluginEnhancer 43/59343/2
Guido Schmechel [Sat, 5 Jan 2019 18:34:35 +0000 (19:34 +0100)]
[BUGFIX] Set controller in ExtbasePluginEnhancer

If the controller of a route in a routeEnhancer differs
from the default controller, it will now be used for the
generation of enhancers.

Resolves: #87337
Releases: master, 9.5
Change-Id: Iea3d15bbc99cb17c640e6a4824d3dd42176295d1
Reviewed-on: https://review.typo3.org/59343
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Alexander Grein <alexander.grein@gmail.com>
Tested-by: Alexander Grein <alexander.grein@gmail.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Use proper argument for options in SendEmailCommand 43/59643/2
Georg Ringer [Tue, 5 Feb 2019 12:09:33 +0000 (13:09 +0100)]
[BUGFIX] Use proper argument for options in SendEmailCommand

InputOption::VALUE_REQUIRED must be used instead of InputArgument::REQUIRED.

Resolves: #87648
Releases: master, 9.5
Change-Id: Ifd727ec26af0e1e2237e9ca5ae480b9ed2fd5b6f
Reviewed-on: https://review.typo3.org/59643
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 months ago[TASK] Add language synchronization tests for TCA type inline/CSV 52/59652/2
Oliver Hader [Wed, 6 Feb 2019 13:34:17 +0000 (14:34 +0100)]
[TASK] Add language synchronization tests for TCA type inline/CSV

Adds DataHandler tests that were available for TCA type inline/FF
for inline/CSV as well (initially introduced with issue ##79856).

Resolves: #87666
Releases: master, 9.5, 8.7
Change-Id: I01eadae3fc00a0ba037e1c8ef7e92b6de467266d
Reviewed-on: https://review.typo3.org/59652
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[TASK] Use constructor injection in QueryFactory 31/59631/3
Alexander Schnitzler [Mon, 4 Feb 2019 14:07:45 +0000 (15:07 +0100)]
[TASK] Use constructor injection in QueryFactory

Class QueryFactory does no longer use setter injection but
constructor injection instead.

Releases: master
Resolves: #87642
Change-Id: I5d595ff2c9b5b7e81f5d6380eef1284e0e2d9739
Reviewed-on: https://review.typo3.org/59631
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
4 months ago[TASK] Migrate Redirect Url Validator into own class 48/59648/3
Benni Mack [Tue, 5 Feb 2019 18:50:42 +0000 (19:50 +0100)]
[TASK] Migrate Redirect Url Validator into own class

The logic within EXT:felogin for validating proper redirect/referer
URLs is extracted into a new PHP class, which can now be called
separately.

This is useful for further refactorings within the Controller,
and it lays the foundation to use proper validation in various
places other than Extbase.

Resolves: #87660
Releases: master
Change-Id: I79aab5908bde869b7ee3cf730fbf61d658f2ee88
Reviewed-on: https://review.typo3.org/59648
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[!!!][TASK] Remove obsolete APC Cache Backend 88/59588/11
Josef Glatz [Wed, 30 Jan 2019 11:02:50 +0000 (12:02 +0100)]
[!!!][TASK] Remove obsolete APC Cache Backend

All occurrences of APC (without suffix "u") are removed from the
TYPO3 core since APC is discontinued and does not work with
PHP 7.x.

This changes does not affect the PHP OPcache related area.

Releases: master
Resolves: #87583
Change-Id: Ie724f8343dae9bdc4721d35c6d384c1de51f365e
Reviewed-on: https://review.typo3.org/59588
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Show hidden subgroups of fe_group 40/59640/2
Stephan Großberndt [Mon, 4 Feb 2019 20:04:30 +0000 (21:04 +0100)]
[BUGFIX] Show hidden subgroups of fe_group

When editing a fe_group show its subgroups even if those are set to
hidden in order to avoid losing the subgroup relation on saving the
fe_group.

Resolves: #87649
Releases: master, 9.5
Change-Id: Ic39f32b47327202a848827bd9d6b4935c35edcdd
Reviewed-on: https://review.typo3.org/59640
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
4 months ago[TASK] Avoid runtime reflection calls in ObjectAccess 31/59331/23
Alexander Schnitzler [Fri, 1 Feb 2019 09:45:19 +0000 (10:45 +0100)]
[TASK] Avoid runtime reflection calls in ObjectAccess

ObjectAccess had two kinds of runtime reflection calls:

1) To gather data about object properties and methods
2) To make non public properties accessible

The first one is tackled by using class schema instances
and by using the property accessor of symfony/property-access.

The latter is tackled by deprecating all method arguments
that trigger reflection to make properties accessible. In
the future, gettable/settable properties need to be either
public or have a getter (get*/has*/is*) or setter.

Releases: master
Resolves: #87332
Change-Id: I6ecef81de7aa4cc1244166d683874a1a87ac6bb7
Reviewed-on: https://review.typo3.org/59331
Reviewed-by: André Schließer <andy.schliesser@gmail.com>
Tested-by: André Schließer <andy.schliesser@gmail.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
4 months ago[FEATURE] Use symfony/property-info to gather doc block information 54/59454/21
Alexander Schnitzler [Wed, 16 Jan 2019 12:21:40 +0000 (13:21 +0100)]
[FEATURE] Use symfony/property-info to gather doc block information

This patch introduces the requirement to symfony/property-info
which provides a neat api to extract information about
properties via several different extractors.

The package comes with a PhpDocExtractor, which is kind of
a drop in replacement (functional wise) for the extbase
DocCommentParser which has been removed.

Along with the replacement of the doc block extractor
the package comes with an api to fetch context data that
enables us to resolve non fully qualified class names.

This is now possible:

```
use TYPO3\CMS\Extbase\Persistence\ObjectStorage;
use ExtbaseTeam\BlogExample\Domain\Model\Comment;

class Post
{
    /*
     * @var ObjectStorage<Comment>
     */
    public $comments;
}
```

Important:
This only works in extbase models as the reflection
costs are high and the information is only needed
in this case.

The non fully qualified class name is now also
supported for injection properties, although it is
still recommended to avoid injection properties in
favor of injection methods or constructor injection.

Example:

```
use TYPO3\CMS\Extbase\Annotation as Extbase;
use TYPO3\CMS\Extbase\Configuration\ConfigurationManager;

class Service
{
    /*
     * @Extbase\Inject
     * @var ConfigurationManager
     */
    public $configurationManager;
}
```

Releases: master
Resolves: #87457
Change-Id: I006aeb737b4bb9790fda257e12ba46a105d9b113
Reviewed-on: https://review.typo3.org/59454
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Raise minimum required prophecy version to 1.7.5 20/59620/6
Benjamin Franzke [Sat, 2 Feb 2019 04:55:09 +0000 (05:55 +0100)]
[BUGFIX] Raise minimum required prophecy version to 1.7.5

The recently introduced `object` type declarations for extbase classes
require a minimum version of prophecy 1.7.5. Previous versions trigger
the following error:
  Scalar type declaration 'object' must be unqualified

Prophecy added support for object type declarations in 1.7.4 and
for return type object declarations in 1.7.5.

Therefore we add an explicit dev dependency to prophecy in composer.json
now (previously it was transitively required as ^1.7 by phpunit 7.1).

composer require --no-update --dev phpspec/prophecy:^1.7.5
composer update --lock

Releases: master
Resolves: #87622
Change-Id: Ic35db424d1ea46143839ec3f4bd3c10e39c99b4e
Reviewed-on: https://review.typo3.org/59620
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Reuse entities of overridden classes in persistence session 59/58959/10
Markus Klösges [Tue, 27 Nov 2018 09:41:05 +0000 (10:41 +0100)]
[BUGFIX] Reuse entities of overridden classes in persistence session

When saving and retrieving object from the persistence session,
implementation class names set via \TYPO3\CMS\Extbase\Object\Container
are now respected by storing and retrieving them with that overridden
class name.

Resolves: #77617
Releases: master, 9.5
Change-Id: I887cb164328afe789dc274c92c8f8774b2098a40
Reviewed-on: https://review.typo3.org/58959
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Add support for language -1 to TCA field type slug 29/59029/5
André Schließer [Tue, 4 Dec 2018 16:50:24 +0000 (17:50 +0100)]
[BUGFIX] Add support for language -1 to TCA field type slug

Use default language as fallback for records with sys_language_uid = -1

Resolves: #87067
Releases: master, 9.5
Change-Id: If57d5566b83f4bba79451e8595337ca6c0eb3fc9
Reviewed-on: https://review.typo3.org/59029
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Replace EditRecordViewHelper of EXT:redirects with ModuleLinkViewHelper 84/59584/4
Georg Ringer [Wed, 30 Jan 2019 08:47:01 +0000 (09:47 +0100)]
[TASK] Replace EditRecordViewHelper of EXT:redirects with ModuleLinkViewHelper

Resolves: #87580
Releases: master
Change-Id: I5a384707d0c0ecd9b797ce89dced25f0738942c6
Reviewed-on: https://review.typo3.org/59584
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Ensure type safety for ViewHelper calling ImageService 17/59617/2
Anja Leichsenring [Fri, 1 Feb 2019 17:49:45 +0000 (18:49 +0100)]
[BUGFIX] Ensure type safety for ViewHelper calling ImageService

The ImageService::getImage requires a string as first and a boolean as
third parameter. The ThumbnailViewHelper must respect this requirement.

Resolves: #87621
Relates: #87599
Releases: master
Change-Id: Ib84f88665fd692629efdb54a33ff83263abe6bfe
Reviewed-on: https://review.typo3.org/59617
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Refactor metadata handling in FAL 08/57908/22
Andreas Fernandez [Wed, 15 Aug 2018 07:36:35 +0000 (09:36 +0200)]
[TASK] Refactor metadata handling in FAL

Meta data of files handled by FAL is fetched, created and updated in
various places, which makes it hard to maintain the current code base.

Albeit the method `_getMetaData()` is marked as internal, it has been
marked as deprecated as well, because the method is widely used in the
TYPO3 extension universe.

For this reason, a MetaDataAspect is introduced that takes care of meta
data handling on a low-level basis.

In the same run, FAL's `Indexer` is now responsible for creating or
updating such meta data records, the `ResourceStorage` now only tells
whether auto-extraction is enabled. The meta data extraction, based on
registered extractors implementing the `ExtractorInterface` interface,
has been moved into a separate service class.

Resolves: #85895
Releases: master
Change-Id: Icb929a6226777dcea3868ee5c083cf13ff5a71f6
Reviewed-on: https://review.typo3.org/57908
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Mark scheduler tasks as executed on PHP-level errors 04/59504/2
Andreas Fernandez [Mon, 21 Jan 2019 10:36:51 +0000 (11:36 +0100)]
[BUGFIX] Mark scheduler tasks as executed on PHP-level errors

The scheduler now catches any error implementing the `\Throwable`
interface thrown by a task to be able to mark such task as executed.

Resolves: #87502
Releases: master, 9.5, 8.7
Change-Id: I1f1bebee922c864ce8d7bfc3f0aa6e9434228e98
Reviewed-on: https://review.typo3.org/59504
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Use proper exception messages for Scheduler::fetchTask() 85/59385/6
Stefanos Karasavvidis [Wed, 9 Jan 2019 13:16:51 +0000 (15:16 +0200)]
[BUGFIX] Use proper exception messages for Scheduler::fetchTask()

Use a proper message in case a non existent uid was passed and
correctly handle the case where no task uid was passed and no task
is overdue.

Resolves: #87375
Releases: master, 9.5, 8.7
Change-Id: I69d2798cc185451c889bf37d8a007eacf572c163
Reviewed-on: https://review.typo3.org/59385
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Fix return type of determineSiteScript 95/59395/5
Harald Atteneder [Thu, 10 Jan 2019 10:26:27 +0000 (10:26 +0000)]
[BUGFIX] Fix return type of determineSiteScript

substr returns a boolean instead of an empty string. A typecast fixes
this problem (See http://php.net/manual/de/function.substr.php#90369)

Resolves: #87387
Releases: master, 9.5
Change-Id: I14aa49c18ae028dc27b94bfdbfc3dfb643c18746
Reviewed-on: https://review.typo3.org/59395
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Move FieldControl/EditPopup handling to module 87/58887/6
Andreas Fernandez [Sun, 11 Nov 2018 23:02:14 +0000 (15:02 -0800)]
[TASK] Move FieldControl/EditPopup handling to module

The FieldControl `EditPopup` now uses a dedicated module for its
handling and no longer uses inline `onclick` handlers nor inline
FormEngine calls.

Resolves: #86644
Releases: master
Change-Id: I46e5d3dbfcb4c187afb6cd1c0692b4e728bfaf26
Reviewed-on: https://review.typo3.org/58887
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Harden \TYPO3\CMS\Extbase\Object\ObjectManager 00/59600/4
Johannes Seipelt [Thu, 31 Jan 2019 20:09:23 +0000 (21:09 +0100)]
[TASK] Harden \TYPO3\CMS\Extbase\Object\ObjectManager

- Use strict type mode
- Use type hints whereever possible
- fix test of creating viewhelper instance using object manager

Releases: master
Resolves: #87605
Change-Id: Ia626ae1156dacd7c9ddcfefed9bb03d26ba91404
Reviewed-on: https://review.typo3.org/59600
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Johannes Seipelt <johannes.seipelt@3m5.de>
Reviewed-by: Felix Döring <Felix.Doering@3m5.de>
Reviewed-by: André Schließer <andy.schliesser@gmail.com>
Tested-by: André Schließer <andy.schliesser@gmail.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
4 months ago[FEATURE] Render thumbnails in file list module deferred 46/57646/19
Frank Naegler [Fri, 20 Jul 2018 19:03:47 +0000 (21:03 +0200)]
[FEATURE] Render thumbnails in file list module deferred

This patch adds a new ViewHelper to render thumbnails deferred in
the backend. This increase the performance of the file list.

Resolves: #85607
Related: #85605
Releases: master
Change-Id: Id97876e889605d7d8d3075ee98a4fc34b002f395
Reviewed-on: https://review.typo3.org/57646
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
4 months ago[TASK] Reduce information disclosure of the used TYPO3 version 65/59565/2
Josef Glatz [Thu, 24 Jan 2019 13:15:17 +0000 (14:15 +0100)]
[TASK] Reduce information disclosure of the used TYPO3 version

Reduce information disclosure of the used TYPO3 version by adding
a dynamic 4-digit year in the TYPO3_copyright_year constant.

That makes it more difficult to find out the used TYPO3 version
just by looking at the frontend source code of a website.

Releases: master, 9.5
Resolves: #87543
Change-Id: Ic169548c7111715eecedfce4ced5c8a3564d102a
Reviewed-on: https://review.typo3.org/59565
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: André Schließer <andy.schliesser@gmail.com>
Tested-by: André Schließer <andy.schliesser@gmail.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
4 months ago[BUGFIX] Use real finisher identifier in form element variants 06/59606/2
Ralf Zimmermann [Fri, 1 Feb 2019 12:51:40 +0000 (13:51 +0100)]
[BUGFIX] Use real finisher identifier in form element variants

Use the real finisher identifiers as they are configured in the
form definition instead the finisher implementation class name.
This requires a change of the public AbstractFinisher implementation
which implements the FinisherInterface. The interface is not changed,
as this would be a breaking change. Therefore, the existence of the
new method is checked. If it does not exist in a finisher
implementation, a fallback to the previous behavior happens.

Releases: master, 9.5
Resolves: #87615
Change-Id: I962502f0601845a5f9793751e87c97b3b902caa1
Reviewed-on: https://review.typo3.org/59606
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Update typo3fluid/fluid to 2.6.0 54/59554/7
Gerrit Mohrmann [Wed, 23 Jan 2019 20:43:08 +0000 (21:43 +0100)]
[TASK] Update typo3fluid/fluid to 2.6.0

Fixes missing output in ifAuthenticatedViewHelper after cache clearing
and erroneous replication of field properties to subsequent fields.

composer command used:
composer update typo3fluid/fluid

Resolves: #86930
Resolves: #86890
Resolves: #87430
Resolves: #86910
Resolves: #87586
Releases: master, 9.5
Change-Id: I8d1abd0aa08d7d7399ec23675dcf07d08dbdd2f2
Reviewed-on: https://review.typo3.org/59554
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Jonas Eberle <flightvision@googlemail.com>
Tested-by: Jonas Eberle <flightvision@googlemail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Improve ClassSchema methods api 22/59422/10
Alexander Schnitzler [Sun, 13 Jan 2019 12:46:26 +0000 (13:46 +0100)]
[TASK] Improve ClassSchema methods api

This patch introduces a new Method class to have an
easier and more stable api to get information about class
methods from ClassSchema objects.

The reflection data fetched and stored by/in the ClassSchema
objects is no longer publicly available as an array. Instead,
Method objects are returned for the following calls:

- getMethod
- getMethods
- getInjectMethods

Also it removes the following method:

- getConstructorArguments

The following constants are marked as private:

- ClassSchema::MODELTYPE_ENTITY
- ClassSchema::MODELTYPE_VALUEOBJECT

Releases: master
Resolves: #87427
Change-Id: I38e8a7287896e9303fad1fa8f8f9182895365adc
Reviewed-on: https://review.typo3.org/59422
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: André Schließer <andy.schliesser@gmail.com>
Tested-by: André Schließer <andy.schliesser@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Remove deprecated code from TypoScript condition matchers 91/59491/11
Frank Naegler [Fri, 18 Jan 2019 08:27:09 +0000 (09:27 +0100)]
[TASK] Remove deprecated code from TypoScript condition matchers

Resolves: #87607
Related: #87193
Releases: master
Change-Id: I5c1ce876cd6ad5edeecefce03d7a1e3619f9d54c
Reviewed-on: https://review.typo3.org/59491
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Ensure type safety for ViewHelper calling ImageService 08/59608/2
Anja Leichsenring [Fri, 1 Feb 2019 14:59:36 +0000 (15:59 +0100)]
[BUGFIX] Ensure type safety for ViewHelper calling ImageService

The ImageService::getImage requires a string as first and a boolean as
third parameter. The Image ViewHelpers must respect this requirement.

Resolves: #87619
Relates: #87599
Releases: master
Change-Id: I0d8f57c2bef62dcc6b4d6e6684bbbb1593bff98f
Reviewed-on: https://review.typo3.org/59608
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: André Schließer <andy.schliesser@gmail.com>
Tested-by: André Schließer <andy.schliesser@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[!!!][TASK] Harden \TYPO3\CMS\Extbase\Service\ImageService 94/59594/7
Alexander Schnitzler [Thu, 31 Jan 2019 18:20:58 +0000 (19:20 +0100)]
[!!!][TASK] Harden \TYPO3\CMS\Extbase\Service\ImageService

- Use strict type mode
- Use type hints whereever possible

Releases: master
Resolves: #87599
Change-Id: I8840b7fad16c4fffb7f50973fb97a498e0f683e4
Reviewed-on: https://review.typo3.org/59594
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Harden \TYPO3\CMS\Extbase\Service\EnvironmentService 92/59592/3
Alexander Schnitzler [Thu, 31 Jan 2019 17:26:48 +0000 (18:26 +0100)]
[TASK] Harden \TYPO3\CMS\Extbase\Service\EnvironmentService

- Use strict type mode
- Use type hints whereever possible

Releases: master
Resolves: #87597
Change-Id: Ic4cfb5512f49b3e20fa16c782301b8dcb2ba5dec
Reviewed-on: https://review.typo3.org/59592
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: André Schließer <andy.schliesser@gmail.com>
Tested-by: André Schließer <andy.schliesser@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Felix Döring <Felix.Doering@3m5.de>
Tested-by: Felix Döring <Felix.Doering@3m5.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Harden \TYPO3\CMS\Extbase\Utility\TypeHandlingUtility 96/59596/3
Alexander Schnitzler [Thu, 31 Jan 2019 18:51:41 +0000 (19:51 +0100)]
[TASK] Harden \TYPO3\CMS\Extbase\Utility\TypeHandlingUtility

- Use strict type mode
- Use type hints whereever possible

Releases: master
Resolves: #87601
Change-Id: I087fcb4a87e12ac3d4345a4514dae674b8551460
Reviewed-on: https://review.typo3.org/59596
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Rudy Gnodde <rgn@windinternet.nl>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Harden \TYPO3\CMS\Extbase\Service\CacheService 91/59591/4
Alexander Schnitzler [Thu, 31 Jan 2019 17:22:31 +0000 (18:22 +0100)]
[TASK] Harden \TYPO3\CMS\Extbase\Service\CacheService

- Use strict type mode
- Use type hints whereever possible

Releases: master
Resolves: #87596
Change-Id: I99fe661ff7ee0c29d34c0fde7c5c2c83f0f39201
Reviewed-on: https://review.typo3.org/59591
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[!!!][TASK] Consolidate extbase caches 73/59573/8
Alexander Schnitzler [Mon, 28 Jan 2019 08:51:30 +0000 (09:51 +0100)]
[!!!][TASK] Consolidate extbase caches

The caches of extbase have been consolidated as both of them shared the
same caching frontend. Cache identifiers `extbase_reflection` and
`extbase_datamapfactory_datamap` do no longer exist.

A single cache `extbase` is pre-configured and used for class schemata
and data maps instead.

Releases: master
Resolves: #87558
Change-Id: I4d7ec53cfd1b4900998fa2d01db1d8f2c1730633
Reviewed-on: https://review.typo3.org/59573
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Replace ModuleLinkViewHelper of EXT:scheduler with ModuleLinkViewHelper of... 83/59583/2
Georg Ringer [Wed, 30 Jan 2019 08:25:09 +0000 (09:25 +0100)]
[TASK] Replace ModuleLinkViewHelper of EXT:scheduler with ModuleLinkViewHelper of EXT:backend

Resolves: #87579
Releases: master
Change-Id: I04e8d291a030dac0a0df526e46aa40ba27a24b39
Reviewed-on: https://review.typo3.org/59583
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
4 months ago[TASK] Use shorthand syntax for global variable $LANG consistently 78/59578/3
Benni Mack [Tue, 29 Jan 2019 12:41:58 +0000 (13:41 +0100)]
[TASK] Use shorthand syntax for global variable $LANG consistently

TYPO3 uses $GLOBALS['LANG'] directly in some places, but since
TYPO3 v7, new code started to use a short hand protected method
"getLanguageService" in order to get IDE code completion and better
analysis of code.

This patch replaces all left-over places of $GLOBALS['LANG']
and encapsulates this into a short-hand method to streamline
TYPO3 Core's code base.

Resolves: #87571
Releases: master
Change-Id: Ie15e320713fe65d40552a19e0a517d5739abbb41
Reviewed-on: https://review.typo3.org/59578
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
4 months ago[TASK] Harden \TYPO3\CMS\Extbase\Security\Cryptography\HashService 90/59590/3
Alexander Schnitzler [Thu, 31 Jan 2019 17:18:14 +0000 (18:18 +0100)]
[TASK] Harden \TYPO3\CMS\Extbase\Security\Cryptography\HashService

- Use strict type mode
- Use type hints whereever possible

Releases: master
Resolves: #87595
Change-Id: If59546093176c5a7725725aad8e619de70fd43cd
Reviewed-on: https://review.typo3.org/59590
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Felix Döring <Felix.Doering@3m5.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: André Schließer <andy.schliesser@gmail.com>
Tested-by: André Schließer <andy.schliesser@gmail.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
4 months ago[TASK] Harden \TYPO3\CMS\Extbase\Core\Bootstrap 98/59598/4
Alexander Schnitzler [Thu, 31 Jan 2019 19:54:02 +0000 (20:54 +0100)]
[TASK] Harden \TYPO3\CMS\Extbase\Core\Bootstrap

- Use strict type mode
- Use type hints whereever possible

Releases: master
Resolves: #87603
Change-Id: I3430b59e93133d9b19d6520d3fd7cca83c0fdb49
Reviewed-on: https://review.typo3.org/59598
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[!!!][TASK] Harden \TYPO3\CMS\Extbase\DomainObject\DomainObjectInterface 02/59602/5
Alexander Schnitzler [Thu, 31 Jan 2019 20:41:57 +0000 (21:41 +0100)]
[!!!][TASK] Harden \TYPO3\CMS\Extbase\DomainObject\DomainObjectInterface

- Use strict type mode
- Use type hints whereever possible

Releases: master
Resolves: #87608
Change-Id: I3fc153c68bb29aa85517965c6d4d8414d25af35b
Reviewed-on: https://review.typo3.org/59602
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Use FQCN's when registering plugins/modules 66/59566/11
Alexander Schnitzler [Thu, 24 Jan 2019 18:02:33 +0000 (19:02 +0100)]
[TASK] Use FQCN's when registering plugins/modules

The following methods used controller aliases:

- \TYPO3\CMS\Extbase\Utility\ExtensionUtility::configurePlugin
- \TYPO3\CMS\Extbase\Utility\ExtensionUtility::registerModule

This means, that while configuring plugins or modules, a list
of controllers (and their actions) had to be provided, so they
could be registered as available controllers for said plugin
or module.

The controller name used for the registration, was kind of an
alias for that controller. It was the class name without the
namespace and without the "Controller" suffix. By a certain
convention a proper class name could be derived from that
alias. All this was necessary back then when TYPO3 didn't have
a proper autoloader and when the class location was derived
from the class name. These circumstances do not exist any more
and since it's only important that a controller class exists,
the registration of plugins must now use the fully qualified
controller class name as array key.

The former syntax

   \TYPO3\CMS\Extbase\Utility\ExtensionUtility::configurePlugin(
       'TYPO3.CMS.IndexedSearch',
       'Pi2',
       ['Search' => 'form,search,noTypoScript'],
       ['Search' => 'form,search']
   );

has to be converted to

   \TYPO3\CMS\Extbase\Utility\ExtensionUtility::configurePlugin(
       'IndexedSearch',
       'Pi2',
       [
           \TYPO3\CMS\IndexedSearch\Controller\SearchController::class
               => 'form,search,noTypoScript'
       ],
       [
           \TYPO3\CMS\IndexedSearch\Controller\SearchController::class
               => 'form,search'
       ]
   );

Please note, that not only the controller configuration changed.
The vendor `TYPO3.CMS` in `TYPO3.CMS.IndexedSearch`, must no longer
be set. Instead, the vendor will be evaluated by looking at the
controller namespace.

Releases: master
Resolves: #87550
Change-Id: If47d087836c4345a8180dae3d4e4b8cd384e684c
Reviewed-on: https://review.typo3.org/59566
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[!!!][TASK] Remove view related properties from ActionController 14/59514/6
Alexander Schnitzler [Mon, 21 Jan 2019 16:13:05 +0000 (17:13 +0100)]
[!!!][TASK] Remove view related properties from ActionController

Both properties $namespacesViewObjectNamePattern and
$viewFormatToObjectNameMap of class ActionController
have been removed without replacement.

Both properties provided a functionality to set a
custom view object class during runtime. As this
contradicts the idea of having a defined state per
request by configuring concrete implementations
before runtime, these properties needed to vanish.

While there is no dependency injection with a proper
configuration available, the view object class can
still be defined via property $defaultViewObjectName.

Releases: master
Resolves: #87511
Change-Id: I4b89a9434f71a3cbf38a9ad113ba8233e7f327f9
Reviewed-on: https://review.typo3.org/59514
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Achim Fritz <af@achimfritz.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Remove unused class import statements 59/59359/5
Oliver Hader [Mon, 7 Jan 2019 17:26:16 +0000 (18:26 +0100)]
[TASK] Remove unused class import statements

Resolves: #87589
Releases: master
Change-Id: I69119636e11d116b79fc627a2993a1fa84d7a39c
Reviewed-on: https://review.typo3.org/59359
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[TASK] Remove unused PHP variables 60/59360/6
Oliver Hader [Wed, 30 Jan 2019 16:14:43 +0000 (17:14 +0100)]
[TASK] Remove unused PHP variables

Resolves: #87590
Releases: master
Change-Id: I30af97f075d352792370b363b0b152ead99eacab
Reviewed-on: https://review.typo3.org/59360
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Resolve site correctly in nested site structure 79/59579/3
Benni Mack [Tue, 29 Jan 2019 15:24:24 +0000 (16:24 +0100)]
[BUGFIX] Resolve site correctly in nested site structure

Due to a bug in checking for $result[t3ver_oid] ?? $result[uid]
the uid is never used, but only the t3ver_oid. This value could be empty
and then "0" is used. This means, the page record to be edited
in FormEngine is treated as "NullSite" = Page without Site Configuration.

Resolves: #87572
Releases: master, 9.5
Change-Id: I1c4175f61a9c5df3dd3a392c2f636112cfbdb350
Reviewed-on: https://review.typo3.org/59579
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Increase field name of table sys_file_storage 81/59581/2
Georg Ringer [Wed, 30 Jan 2019 07:12:44 +0000 (08:12 +0100)]
[TASK] Increase field name of table sys_file_storage

Increase the length of the field from 30 to 255 chars to be in
sync with other tables, e.g. sys_file_mounts. 30 is fairly short
for bigger sites and lots of storages.

As this is an admin only field and not too often used, it is ok to backport
that to 9.5 as well.

Resolves: #87576
Releases: master, 9.5
Change-Id: I355b6295a9f813e72e1e66e05dd93419fd2aeaeb
Reviewed-on: https://review.typo3.org/59581
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 months ago[TASK] Remove unused DeleteFileViewHelper 82/59582/2
Georg Ringer [Wed, 30 Jan 2019 08:01:27 +0000 (09:01 +0100)]
[TASK] Remove unused DeleteFileViewHelper

Since #72332 the url to the delete action is built in the controller and
assigned to the view.

Resolves: #87578
Releases: master
Change-Id: I36ea3374a848c48c981718dfc8dc1899dc9c0164
Reviewed-on: https://review.typo3.org/59582
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 months ago[BUGFIX] Use overridden field label in list view 05/59505/6
Georg Ringer [Mon, 21 Jan 2019 10:41:31 +0000 (11:41 +0100)]
[BUGFIX] Use overridden field label in list view

If a label of a table column is overridden by TsConfig
(TCEFORM.<table>.<column>.label), the new value
must also be used in the list view:

- header of the table rendering
- list of "set fields"

Resolves: #87484
Releases: master, 9.5
Change-Id: I8eafd1f2878b571edd1e5a30b28b0d5330b9b5d0
Reviewed-on: https://review.typo3.org/59505
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[!!!][TASK] Drop TBE_TEMPLATE variable 92/59492/6
Benni Mack [Fri, 18 Jan 2019 20:52:19 +0000 (21:52 +0100)]
[!!!][TASK] Drop TBE_TEMPLATE variable

The global variable TBE_TEMPLATE is not
necessary anymore, and is not available anymore.

The change is still ugly, as TBE_TEMPLATE
initializes the PageRenderer object
with necessary information, which should
become built inside PageRenderer for BE. This has been
moved to Backend's RequestHandler where this can be
abstracted further at a later point.

Resolves: #87567
Releases: master
Change-Id: If1cb184740f1e99c0aeca5ae19c85899d56f3f9a
Reviewed-on: https://review.typo3.org/59492
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Use ModuleLinkViewHelper in EXT:sys_note 11/59511/2
Georg Ringer [Mon, 21 Jan 2019 13:16:24 +0000 (14:16 +0100)]
[TASK] Use ModuleLinkViewHelper in EXT:sys_note

Replace custom VH with the one provided by EXT:backend.

Resolves: #87507
Releases: master
Change-Id: I882d7555654a051e7190d7ffd25ff6e903f16ab1
Reviewed-on: https://review.typo3.org/59511
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Use ModuleLinkViewHelper instead of IssueCommandViewHelper 13/59513/2
Georg Ringer [Mon, 21 Jan 2019 14:20:59 +0000 (15:20 +0100)]
[TASK] Use ModuleLinkViewHelper instead of IssueCommandViewHelper

Use the general ModuleLinkViewHelper instead of custom VH.

Resolves: #87509
Releases: master
Change-Id: I7f0d7125d0ee84973bc80599cbc51e44747e2d06
Reviewed-on: https://review.typo3.org/59513
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Add correct description for CType menu_sitemap 71/59571/3
Josef Glatz [Sun, 27 Jan 2019 21:46:03 +0000 (22:46 +0100)]
[BUGFIX] Add correct description for CType menu_sitemap

This patch adds the correct description text for the new
content element wizard of CType "menu_sitemap".

Resolves: #87556
Releases: master, 9.5
Change-Id: Iec0de6887a9a60215a813e03041e4d58af7b297b
Reviewed-on: https://review.typo3.org/59571
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Use PSR-15 middlewares in install tool 41/59541/6
Benjamin Franzke [Tue, 22 Jan 2019 08:26:33 +0000 (09:26 +0100)]
[TASK] Use PSR-15 middlewares in install tool

Remove the old concept of priority-based HTTP request handlers,
and use statically configured PSR-15 middlewares instead.
Tranform the priority based request handlers into a set of
chained middlewares.

In case none of the middlewares handles the request a
NotFoundRequestHandler returns a 404 response
(replacing the previous exception that was thrown in that case).
This scheme of using a 404 handler as "last" request handler is
not new, it is also used in zend expressive (a PSR-15 framework).

The TYPO3 RequestHandlerInterface is marked @internal and was set
to be removed in v9, therefore we drop it now and also remove its
implementation from the frontend and backend request handlers.

Releases: master
Resolves: #87516
Change-Id: Ibbd6a0e6c4ff8aa55b4367c9e4c07e279595dbfb
Reviewed-on: https://review.typo3.org/59541
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[TASK] Add correct description for ext-intl composer.json 74/59574/2
Josef Glatz [Mon, 28 Jan 2019 11:52:03 +0000 (12:52 +0100)]
[TASK] Add correct description for ext-intl composer.json

Releases: master
Resolves: #87559
Change-Id: I74d7ef26017080e45eb129217613ad7c36cd3881
Reviewed-on: https://review.typo3.org/59574
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
4 months ago[!!!][TASK] Remove last marked deprecations 03/59503/6
Benni Mack [Mon, 21 Jan 2019 06:38:28 +0000 (07:38 +0100)]
[!!!][TASK] Remove last marked deprecations

Various deprecated code regarding EXT:form and FormEngine
have been removed.

* IRRE CustomControls without userFunc is not possible anymore.
* TBE_MODULES's configureModuleFunction is removed
* EXT:form type "GridContainer" is removed (use GridRow)
* EXT:form form configuration files must end with .form.yaml.
* EXT:form renderingOptions._isHiddenFormElement and
renderingOptions._isReadOnlyFormElement are removed
* CLI Command "lang:language:update" is now only
available under "language:update"

Resolves: #87514
Releases: master
Change-Id: Idef84daf51f882df23ef227d1777d24b1076dfaf
Reviewed-on: https://review.typo3.org/59503
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[TASK] Improve indexed_search manual 68/58968/6
hasenbalg [Wed, 28 Nov 2018 08:32:13 +0000 (09:32 +0100)]
[TASK] Improve indexed_search manual

Improves indexed search documentation, mentioning activation
and inclusion of a static template.

Releases: master, 9.5
Resolves: #87023
Change-Id: I85e40b768e4020e71a7717d877a6305fb55a00cb
Reviewed-on: https://review.typo3.org/58968
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
4 months ago[TASK] Use constructor injection in configuration managers 46/59446/3
Alexander Schnitzler [Tue, 15 Jan 2019 14:24:57 +0000 (15:24 +0100)]
[TASK] Use constructor injection in configuration managers

The following classes do no longer use setter injection but
constructor injection instead:

- TYPO3\CMS\Extbase\Configuration\AbstractConfigurationManager
- TYPO3\CMS\Extbase\Configuration\BackendConfigurationManager
- TYPO3\CMS\Extbase\Configuration\ConfigurationManager
- TYPO3\CMS\Extbase\Configuration\FrontendConfigurationManager

Releases: master
Resolves: #87448
Change-Id: Ib6df3ab4a286bbe77cdda82d0066495a8dab8b22
Reviewed-on: https://review.typo3.org/59446
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Christian Wolff <chris@wolffc.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Sebastian Fischer <typo3@evoweb.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>