Packages/TYPO3.CMS.git
13 months ago[TASK] Add unit tests for CommandUtility::unQuoteFilenames 88/57888/3
Wouter Wolters [Mon, 13 Aug 2018 18:43:30 +0000 (20:43 +0200)]
[TASK] Add unit tests for CommandUtility::unQuoteFilenames

While moving this method to CommandUtility class the unit tests
were missing. They are re-added now.

Resolves: #85837
Releases: master
Change-Id: I993a06d6da107a333d186706dcbee1fcc4b2731e
Reviewed-on: https://review.typo3.org/57888
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
13 months ago[BUGFIX] Fix wrong configuration values for password hashes 91/57891/3
Markus Klein [Tue, 14 Aug 2018 08:42:26 +0000 (10:42 +0200)]
[BUGFIX] Fix wrong configuration values for password hashes

And also fix wrong backwards compatibility class declarations.

Resolves: #85838
Related: #85833
Releases: master
Change-Id: I6140f999c99e6903e08f6fa726e06bdf295b8f5b
Reviewed-on: https://review.typo3.org/57891
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
13 months ago[TASK] Merge EXT:saltedpasswords into EXT:core 85/57885/13
Christian Kuhn [Mon, 13 Aug 2018 11:56:35 +0000 (13:56 +0200)]
[TASK] Merge EXT:saltedpasswords into EXT:core

Move all classes and other resources from EXT:saltedpasswords to
EXT:core.

Classes live in TYPO3\CMS\Core\Crypto\PasswordHashing. This namespace
will be clean in v10 when the classes that are currently only kept for
backwards compatibility are removed.

The documentation has been integrated into the "Core API" docs at
https://docs.typo3.org/typo3cms/CoreApiReference/stable/ApiOverview/PasswordHashing/

Resolves: #85833
Resolves: #85026
Releases: master
Change-Id: Ie6ac7fbf215fe61711f0acdd6dc5a318bce1ad35
Reviewed-on: https://review.typo3.org/57885
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
13 months ago[FEATURE] Move expression language handling into EXT:core 84/57884/10
Frank Naegler [Mon, 13 Aug 2018 10:41:06 +0000 (12:41 +0200)]
[FEATURE] Move expression language handling into EXT:core

The implementation of the symfony expression language has been moved
into EXT:core to centralize the functionality and make it usable
in other scopes.

Resolves: #85828
Releases: master
Change-Id: I5c64001d24a610fd1c3ee4a6bb58e4c1923ec78a
Reviewed-on: https://review.typo3.org/57884
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
13 months ago[FEATURE] Add Log Module to AdminPanel 24/57724/12
Susanne Moog [Sun, 29 Jul 2018 21:30:30 +0000 (23:30 +0200)]
[FEATURE] Add Log Module to AdminPanel

Add a log module to the admin panel that can display
logging entries generated through the current request.

Resolves: #84606
Releases: master
Change-Id: Id596d99273f751c05d0112a57eb3c32f7f9a6149
Reviewed-on: https://review.typo3.org/57724
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
13 months ago[BUGFIX] Use params set in db in recordLinkHandler 70/57370/5
Susanne Moog [Mon, 25 Jun 2018 18:39:31 +0000 (20:39 +0200)]
[BUGFIX] Use params set in db in recordLinkHandler

Resolving of links with a custom record link handler is now done
in the following order:

- TypoScriptConfiguration Parameters
- Parameters set in link field in content element
- If param is empty in link field but set in config that is taken into
account as a fallback
- It is _not_ possible to unset a value (class, title, target, link) in
the link field if it _is_ set to a default value in TypoScript

Caveat: Overwriting attributes only works if they are set via parameter
in configuration _not_ if they are set via ATagParams.

Resolves: #81620
Releases: master, 8.7
Change-Id: Ie723e7d7d36a03bac4ec97211749317d7311dd3e
Reviewed-on: https://review.typo3.org/57370
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Ralf Merz <mail@merzilla.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Marc Hirdes <hirdes@clickstorm.de>
Reviewed-by: Maik Peuser <maik.peuser@verdure.de>
Reviewed-by: Tim Schreiner <schreiner.tim@gmail.com>
Tested-by: Tim Schreiner <schreiner.tim@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
13 months ago[TASK] Add hint to Site Configuration without pages 59/57659/2
Mathias Brodala [Mon, 23 Jul 2018 12:53:09 +0000 (14:53 +0200)]
[TASK] Add hint to Site Configuration without pages

Resolves: #85620
Releases: master
Change-Id: I71185161afc5b50ed7b27a8f6298bcf32809a5a4
Reviewed-on: https://review.typo3.org/57659
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
13 months ago[TASK] Deprecate PageGenerator::renderContent 80/57880/3
Benni Mack [Sun, 12 Aug 2018 11:18:51 +0000 (13:18 +0200)]
[TASK] Deprecate PageGenerator::renderContent

The PSR-15 RequestHandler should be responsible for compiling content, avoiding
a call to a static method which uses global objects again, which are available
already in the RequestHandler.

Therefore this logic is moved into RequestHandler.

Resolves: #85822
Releases: master
Change-Id: Id37887152a11739b9a43abaa577695daa1957905
Reviewed-on: https://review.typo3.org/57880
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
13 months ago[BUGFIX] Modify SQL Server IDENTITY_INSERT when creating records 75/57875/5
Oliver Hader [Sat, 11 Aug 2018 19:38:40 +0000 (21:38 +0200)]
[BUGFIX] Modify SQL Server IDENTITY_INSERT when creating records

In SQL Server (MSSQL), hard setting uid auto-increment primary keys is
only allowed if the table is prepared for such an operation beforehand.

Resolves: #85818
Releases: master
Change-Id: I28f1c4c6a98b571d5d19521b37ba9bd69ffcf76b
Reviewed-on: https://review.typo3.org/57875
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
13 months ago[BUGFIX] Avoid exception on non-existing error handler 77/57877/6
Benni Mack [Sat, 11 Aug 2018 18:41:37 +0000 (20:41 +0200)]
[BUGFIX] Avoid exception on non-existing error handler

When a site is configured, but has no error handler
for a specific error case (e.g. a site has no
configured 404 page), then the regular error handler
should kick in.

This also allows to enable some previously wrong
tests (expected!).

Resolves: #85819
Releases: master
Change-Id: Iefc0e23460de0389b66083da4e6d7aca12b82c59
Reviewed-on: https://review.typo3.org/57877
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
13 months ago[BUGFIX] Add missing icon overlay for pages in page tree 68/57868/2
Joerg Kummer [Sat, 11 Aug 2018 00:31:09 +0000 (02:31 +0200)]
[BUGFIX] Add missing icon overlay for pages in page tree

Extend default fields of page tree repository to transmit page properties
for icon overlay rendering in page tree, like in version 8.7

Resolves: #85782
Releases: master
Change-Id: Ia3a30ea93669608cd73ab63e2963357958816773
Reviewed-on: https://review.typo3.org/57868
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
13 months ago[TASK] Deprecate unused functionality in Core Bootstrap 71/57871/4
Benni Mack [Sat, 11 Aug 2018 11:52:34 +0000 (13:52 +0200)]
[TASK] Deprecate unused functionality in Core Bootstrap

Due to heavy refactoring with PSR-15 within
the TYPO3 Core Bootstrap, a lot of functionality
can be deprecated.

Resolves: #85821
Releases: master
Change-Id: Ib65ccc9d58a5202d63cd2e8e4f63fa49383ec512
Reviewed-on: https://review.typo3.org/57871
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
13 months ago[TASK] Render wizards of FormEngine elements only if needed 14/57614/3
Georg Ringer [Tue, 17 Jul 2018 02:23:54 +0000 (04:23 +0200)]
[TASK] Render wizards of FormEngine elements only if needed

Reduce the HTML of a record form by rendering divs of wizards only
if those are required.

Resolves: #85577
Releases: master
Change-Id: I6ca6ad5c3ebd1a1aa949a9a0349bd7894e4532df
Reviewed-on: https://review.typo3.org/57614
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[TASK] Add more tests to site resolving 78/57878/3
Benni Mack [Sat, 11 Aug 2018 19:02:10 +0000 (21:02 +0200)]
[TASK] Add more tests to site resolving

This patch adds additional tests for resolving
multi-site nested sites and domains.

Resolves: #85820
Releases: master
Change-Id: I4b9083c9cddebbe972874664308fa65d8fc01e56
Reviewed-on: https://review.typo3.org/57878
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
13 months ago[FEATURE] Use symfony/routing for Site Resolving 51/57851/17
Benni Mack [Fri, 10 Aug 2018 11:38:21 +0000 (13:38 +0200)]
[FEATURE] Use symfony/routing for Site Resolving

Use symfony/router 4.1 for resolving a site based on the
current request.

This actually removes some simple resolving built previously
by myself, which was stupid code to detect a site base.

With the symfony/routing component, it is now possible to
have site base prefixes without a scheme (just the domain)
and allow to handle both prefixes. It is also possible to
just add "/site1" and "/site2" as base for domains as
well, allowing to listen to any incoming domain.

As this Routing component will be used for further
page-based routing, the introduced symfony-specific
code might change and encapsulated in other places.

With this patch we now require symfony 4.1 components
or higher, as symfony/routing became fast with 4.1,
and symfony/routing 4.1 is incompatible with various 3.x
components we use. Composer-based installations might
not be able to upgrade, if they have a strong
dependency on a lower symfony version.

The composer command used:
    composer req symfony/console:^4.1 symfony/expression-language:^4.1 \
    symfony/finder:^4.1 symfony/routing:^4.1 symfony/yaml:^4.1 \
    --update-with-dependencies

Resolves: #85719
Resolves: #85165
Releases: master
Change-Id: If21ff3581552ca98af28739a76236a160508f16d
Reviewed-on: https://review.typo3.org/57851
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Daniel Siepmann <daniel.siepmann@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
13 months ago[TASK] Deprecate second argument of PageRenderer::addInlineLanguageLabelArray 58/57858/3
Wouter Wolters [Fri, 10 Aug 2018 12:36:21 +0000 (14:36 +0200)]
[TASK] Deprecate second argument of PageRenderer::addInlineLanguageLabelArray

Calling `PageRenderer::addInlineLanguageLabelArray` with a second
parameter set to "true" is deprecated. Use the LanguageService directly
when defining your labels.

Resolves: #85806
Releases: master
Change-Id: I92b5186a8e540f91b5873f007934624c4facf1fb
Reviewed-on: https://review.typo3.org/57858
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
13 months ago[TASK] Clean up Admin Panel Code 70/57870/5
Benni Mack [Sat, 11 Aug 2018 09:42:35 +0000 (11:42 +0200)]
[TASK] Clean up Admin Panel Code

Due to the Admin Panel refactoring, some helper methods
were deprecated, but need a better description.

Also, the $BE_USER->uc property is set to "AdminPanel"
instead of cryptic string "TSFE_adminConfig" since
AdminPanel is not related to TSFE anymore.

Additionally, some helper methods and properties which
are not in use are removed.

Resolves: #85815
Releases: master
Change-Id: I7f875acd0f883690f69e895c814b6ad335d86601
Reviewed-on: https://review.typo3.org/57870
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[TASK] Move Preview Info hook to hook_eofe 72/57872/2
Benni Mack [Sat, 11 Aug 2018 14:52:33 +0000 (16:52 +0200)]
[TASK] Move Preview Info hook to hook_eofe

The Frontend Request uses two hooks separately to
allow modifying the content via TSFE. In order
to deprecate one (previewInfo), the Frontend Hook
to show the "Preview" info box, is moved to the
hook_eofe hook.

Resolves: #85816
Releases: master
Change-Id: I66fe66a43364c670bdaf7837793180122e329e7b
Reviewed-on: https://review.typo3.org/57872
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[TASK] Make password hash selection an install tool preset 50/57850/18
Christian Kuhn [Thu, 9 Aug 2018 22:41:39 +0000 (00:41 +0200)]
[TASK] Make password hash selection an install tool preset

With this change, the password hash code in salted passwords is
reduced to the SaltFactory with two methods and the single hash
classes that implement SaltInterface without further public
methods. Everything else including the utility classes is
deprecated.
The change moves the LocalConfiguration.php config options around,
adds a settings preset for hash mechanism selection, adds according
silent upgrades, adds 'best available' hash mechanism selection
at installation time and drops the last saltedpasswords
ext_conf_template.txt option.

Details:
* Remove the password hash selection from saltedpasswords config
  namespace and put to TYPO3_CONF_VARS/BE/passwordHashing/className
  and TYPO3_CONF_VARS/FE/passwordHashing/className
* Move available password hash registry from
  TYPO3_CONF_VARS/SC_OPTIONS/ext/saltedpasswords/saltMethods
  to TYPO3_CONF_VARS/SYS/availablePasswordHashAlgorithms
* Add a setting preset to select one of argon2i (preferred),
  bcrypt, pbkdf2 or phpass (last fallback)
* Use 'best matching preset' during installation to select a good
  salt mechanism by default
* Silently upgrade existing password hash selection and upgrade
  to one of the four hash algorithms above
* Allow algorithm specific options in
  TYPO3_CONF_VARS/BE/passwordHashing/options and
  TYPO3_CONF_VARS/FE/passwordHashing/options for admins who
  know what they are doing and need to fiddle with hash details.
* Simplify and refactor the single password hash classes. Deprecate
  a huge list of methods along the way.

Change-Id: I773e2ee27a121c9f0d5302695ebf4aa561170400
Resolves: #85804
Resolves: #83760
Releases: master
Reviewed-on: https://review.typo3.org/57850
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[TASK] Use full namespace in a documentation file 73/57873/3
Franz Holzinger [Sat, 11 Aug 2018 15:35:17 +0000 (17:35 +0200)]
[TASK] Use full namespace in a documentation file

Releases: master, 8.7
Resolves: #85817
Change-Id: Ifac7a5545d9467a6973bfef55e264fe263d10396
Reviewed-on: https://review.typo3.org/57873
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[TASK] Move FlexFormService from EXT:extbase to EXT:core 54/57854/3
Wouter Wolters [Fri, 10 Aug 2018 09:56:02 +0000 (11:56 +0200)]
[TASK] Move FlexFormService from EXT:extbase to EXT:core

Resolves: #85802
Releases: master
Change-Id: I878bb4552ae8709ed4a1ec32afdfbfd7abaaa2e6
Reviewed-on: https://review.typo3.org/57854
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
13 months ago[TASK] Correctly initialize environment for DataHandler in tests 69/57869/4
Oliver Hader [Sat, 11 Aug 2018 07:46:25 +0000 (09:46 +0200)]
[TASK] Correctly initialize environment for DataHandler in tests

Since importing data scenarios in tests relies on DataHandler, it is
required to correctly initialize $GLOBALS['LANG'] as well. Since not
all tests were failing, this probably points out side effects during
test execution in terms of reusing globals settings of other tests.

Besides that, a misbehavior in typo3/testing-framework lead to the
situation that not all entities have been created - which would have
triggered DataHandler log entries that rely on previously mentioned
$GLOBALS['LANG'] instance.

Resolves: #85814
Releases: master
Change-Id: I4e2745cfeed6e2576f7ae23dd4d4ea4b49572a3f
Reviewed-on: https://review.typo3.org/57869
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
13 months ago[TASK] Add frontend functional tests for site handling 67/57867/4
Oliver Hader [Fri, 10 Aug 2018 21:20:29 +0000 (23:20 +0200)]
[TASK] Add frontend functional tests for site handling

Integrate functional tests for legacy frontend requests
(index.php?id=123) without having any site configuration,
as well as dedicated tests for frontend requests using
the new v9 site handling feature.

Resolves: #85813
Releases: master
Change-Id: I5e08c41010a7482f779e7aa578597cf771429ebd
Reviewed-on: https://review.typo3.org/57867
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
13 months ago[TASK] Throw PSR-7 Responses up to Application 66/57866/5
Oliver Hader [Fri, 10 Aug 2018 20:21:18 +0000 (22:21 +0200)]
[TASK] Throw PSR-7 Responses up to Application

In order to properly handle PSR-7 response objects explicit die()
or exit() calls should be avoided since those states cannot be
handle nor analyzed further. As a current work-around a new
ImmediateResponseException is introduced that throws the exception
up to application object that transforms the emitted message into
a proper response object. This API is internal and considered as
intermediate - the real solution would be to completely refactor
TypoScriptFrontendController processing and only use
request/response consequently.

Resolves: #85812
Releases: master
Change-Id: I047ad82fd5734c38160b8552aa754b1e7c356417
Reviewed-on: https://review.typo3.org/57866
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
13 months ago[TASK] Use view helper to configure ModuleTemplate in log module 88/51088/17
Helmut Hummel [Sun, 1 Jan 2017 12:56:01 +0000 (13:56 +0100)]
[TASK] Use view helper to configure ModuleTemplate in log module

With implementation of ModuleTemplate as view helpers,
we can remove class inheritance for the two purposes
where we render the log module and use Fluid layouts for that.

By doing so, we can clean up the Fluid templates,
add xml based namespace registration, remove unnecessary partials
and also get rid of persistent object inheritance of
the filter DTO.

Resolves: #85521
Releases: master
Change-Id: I5e35ea97ce419fc3a7ffbee309c466118e22ab80
Reviewed-on: https://review.typo3.org/51088
Reviewed-by: Tim Schreiner <schreiner.tim@gmail.com>
Tested-by: Tim Schreiner <schreiner.tim@gmail.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
13 months ago[TASK] Split site configuration loading into separate method 62/57862/2
Benni Mack [Fri, 10 Aug 2018 18:29:19 +0000 (20:29 +0200)]
[TASK] Split site configuration loading into separate method

Resolves: #85810
Releases: master
Change-Id: I329b343715895536fde5013b2ece9e2717c3834d
Reviewed-on: https://review.typo3.org/57862
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
13 months ago[BUGFIX] Use proper phpDoc in PSR-7 implementation 63/57863/2
Benni Mack [Fri, 10 Aug 2018 18:39:47 +0000 (20:39 +0200)]
[BUGFIX] Use proper phpDoc in PSR-7 implementation

This fixes some IDE issues when working with PSR-7 classes within TYPO3.

Resolves: #85811
Releases: master, 8.7
Change-Id: I69b9fed8a603b32ac6bfed57c251907d09dcae19
Reviewed-on: https://review.typo3.org/57863
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
13 months ago[FEATURE] Select first element of PageTree toolbar on initialization 15/57815/6
Paweł Rogowicz [Sun, 5 Aug 2018 09:47:20 +0000 (11:47 +0200)]
[FEATURE] Select first element of PageTree toolbar on initialization

The first element of the PageTree toolbar is selected when initialized.
The possibility to close/hide a toolbar option has been removed. Either
the page type or the filter/search is displayed.

Releases: master
Resolves: #13265
Change-Id: I055c877d300ba023ae880679a9a602f95a40c374
Reviewed-on: https://review.typo3.org/57815
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Tim Schreiner <schreiner.tim@gmail.com>
Tested-by: Tim Schreiner <schreiner.tim@gmail.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
13 months ago[TASK] Deprecate EnvironmentService::isEnvironmentInCliMode 59/57859/2
Wouter Wolters [Fri, 10 Aug 2018 13:09:33 +0000 (15:09 +0200)]
[TASK] Deprecate EnvironmentService::isEnvironmentInCliMode

Resolves: #85807
Releases: master
Change-Id: I4737a11e4e673e33553aa5ff835999bcc9a4afb5
Reviewed-on: https://review.typo3.org/57859
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tim Schreiner <schreiner.tim@gmail.com>
Tested-by: Tim Schreiner <schreiner.tim@gmail.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
13 months ago[TASK] Add php extension PDO to master and sub packages 55/57855/4
Anja [Fri, 10 Aug 2018 09:50:02 +0000 (11:50 +0200)]
[TASK] Add php extension PDO to master and sub packages

composer command:

composer require ext-pdo:"*"

Releases: master
Resolves: #85803
Change-Id: Ied0f9b60bf1dc8b8ada66b1da622bc6bf49cf80a
Reviewed-on: https://review.typo3.org/57855
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
13 months ago[TASK] Add documentation render directories to .gitignore 71/57771/3
Sybille Peters [Thu, 2 Aug 2018 08:30:49 +0000 (10:30 +0200)]
[TASK] Add documentation render directories to .gitignore

Add directory created by documentation rendering to .gitignore.

Rendering the docs locally is helpful for checking if it will render
correctly on the server. This will create the rendered files in
typo3/sysext/*/Documentation-GENERATED-temp/.

Adding this to .gitignore will prevent accidentally adding the generated
documentation to a patch.

Resolves: #85725
Releases: master, 8.7
Change-Id: Ibcff2570b961e1f1add519ead49e565c671a28ba
Reviewed-on: https://review.typo3.org/57771
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
13 months ago[TASK] Improve TS Template module information on root level list 06/57806/16
Joerg Kummer [Sat, 4 Aug 2018 13:52:09 +0000 (15:52 +0200)]
[TASK] Improve TS Template module information on root level list

The template tool on root level, which displays an overview of pages
including templates, now displays instead of the count of templates
all related templates of a page with several informations like:
- title
- state (by icon)
- is root or extend
- direct link to edit (with ID ans site-title as link title)
Pages in rootline, which do not includes templates itself are no longer
linked to the template modul.
Database query has been streamlined, and all render logic of
Html specific output has been moved to FLUID templating.
This offers the possibility to add filter or search to this view.
An issue with page sorting in page tree, when rootline pages does not
contain TS templates has been fixed.

Resolves: #81430
Releases: master, 8.7
Change-Id: I5250c53df1acc4a1a29839ce4a472f3e863ae992
Reviewed-on: https://review.typo3.org/57806
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
13 months ago[TASK] Deprecate 2nd argument of GeneralUtility::explodeUrl2Array 70/57770/7
Benni Mack [Thu, 2 Aug 2018 08:06:48 +0000 (10:06 +0200)]
[TASK] Deprecate 2nd argument of GeneralUtility::explodeUrl2Array

Calling `GeneralUtility::explodeUrl2Array` with a second
parameter "true" can be simplified by using PHP's
native parse_str() method directly.

The second parameter is then deprecated.

All occurrences are replaced with "parse_str()" where
the second parameter was set to true.

Resolves: #85801
Releases: master
Change-Id: Ifd590bc17626cb93495f3f43935671e3f2296c7b
Reviewed-on: https://review.typo3.org/57770
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
13 months ago[TASK] Clean up code due to Context API deprecations 52/57852/2
Benni Mack [Fri, 10 Aug 2018 07:41:23 +0000 (09:41 +0200)]
[TASK] Clean up code due to Context API deprecations

The TSFE object does not use $gr_list, $showHiddenPage, $loginUser etc.
anymore, and the deprecations in place (via magic methods) do not expect the
properties to be filled at all anymore.

Some comments are adjusted.

Additionally, some tests where a global TSFE is not necessary anymore, are adapted.

Resolves: #85800
Releases: master
Change-Id: I3b10e3d28d200cb1533bc418b3ad24cf47f452d4
Reviewed-on: https://review.typo3.org/57852
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Richard Vollebregt <richard.vollebregt@maxserv.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
13 months ago[BUGFIX] Fix fluid error in admin panel 62/57762/4
Susanne Moog [Wed, 1 Aug 2018 19:14:57 +0000 (21:14 +0200)]
[BUGFIX] Fix fluid error in admin panel

Resolves: #85702
Releases: master
Change-Id: I6dc4dabdf565b14fd4271c476881fbd8d06d9a77
Reviewed-on: https://review.typo3.org/57762
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
13 months ago[TASK] Refactor SaltFactory 47/57847/11
Christian Kuhn [Thu, 9 Aug 2018 15:47:30 +0000 (17:47 +0200)]
[TASK] Refactor SaltFactory

The patch deprecates static SaltFactory::getSaltingInstance()
and replaces it with the two new non-static methods.
The ->get() method returns a hash instance to check a given password
against a given hash, and ->getDefaultHashInstance() which returns
an instance of the configured default hash method to calculate
a hash for a new password.

The new methods are now strict, non-static and throw exceptions if
something goes wrong. This simplifies mocking in tests and sanitizes
password hash handling in the core.

Change-Id: I186576593202cb6d052bc7c1ca6f81314eddbaf2
Resolves: #85796
Releases: master
Reviewed-on: https://review.typo3.org/57847
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
13 months ago[TASK] Change URL of TYPO3_URL_DONATE constant 45/57845/2
Wouter Wolters [Thu, 9 Aug 2018 14:58:38 +0000 (16:58 +0200)]
[TASK] Change URL of TYPO3_URL_DONATE constant

Resolves: #85791
Releases: master,8.7
Change-Id: Ib90b3a0dcc77ba5f6006232ac8357e5a50ec782a
Reviewed-on: https://review.typo3.org/57845
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
13 months ago[BUGFIX] Select first element in tree when deleting selected node 91/57791/14
Paweł Rogowicz [Fri, 3 Aug 2018 13:49:04 +0000 (15:49 +0200)]
[BUGFIX] Select first element in tree when deleting selected node

This patch fixes a bug which occured when deleting a currently selected
node. After deleting this node the first element of the tree is
displayed.

Releases: master
Resolves: #85431
Change-Id: I64cd7c4ebd8415a2c261da3f62f8e412575b0075
Reviewed-on: https://review.typo3.org/57791
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Tested-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
13 months ago[BUGFIX] Remove double zip extension when downloading in EM 34/57834/2
Wouter Wolters [Wed, 8 Aug 2018 11:48:33 +0000 (13:48 +0200)]
[BUGFIX] Remove double zip extension when downloading in EM

The download as zip action outputs the zip file with double .zip
extension. Remove the second .zip from the header.

Resolves: #85770
Releases: master,8.7
Change-Id: Iecc69676cd019060f2bd9e86f97d6adc0e9b6c2b
Reviewed-on: https://review.typo3.org/57834
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[TASK] Deprecate GeneralUtility::unQuoteFilenames 21/57821/3
Wouter Wolters [Sun, 5 Aug 2018 13:04:35 +0000 (15:04 +0200)]
[TASK] Deprecate GeneralUtility::unQuoteFilenames

Moves the method over to CommandUtility as that is the only usage
in the core.

Resolves: #85760
Releases: master
Change-Id: I6d1831a6f6288365e5cb879c056ee06b7bb6fb74
Reviewed-on: https://review.typo3.org/57821
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[TASK] Improve readability of 8.x Changelog 29/57829/9
Daniel Siepmann [Tue, 7 Aug 2018 10:55:29 +0000 (12:55 +0200)]
[TASK] Improve readability of 8.x Changelog

Only breaking changes and important changes were adjusted for now.

* Fix rst syntax issues, like missing blank line before list.
* Add roles for highlighting of inline files and code.
* Add link to mentioned issues.
* Prefix PHP Globals with $GLOBALS[] to keep things as they are in real
  world and to keep it the same between all files.
* Use single formats, e.g. always '*' for lists. This will make
  refactorings and other stuff easier.

Resolves: #85771
Releases: master, 8.7
Change-Id: I47f7db732ab1da751c6f84469152d7209e065c19
Reviewed-on: https://review.typo3.org/57829
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[BUGFIX] Fix wrong changelog information for #82794 38/57838/2
Daniel Siepmann [Thu, 9 Aug 2018 06:29:28 +0000 (08:29 +0200)]
[BUGFIX] Fix wrong changelog information for #82794

The introduced keyword is called pageNotFound and is available for the
existing keyword content_fallback.
"stop" and "fallback" were wrong.

* Fix wrong syntax to allow rendering of list.
* Add roles for syntax highlighting of TS.
* Add styling to inline configuration.

Resolves: #85771
Releases: master, 8.7
Change-Id: I6cb36d2b680527ab402c0fc8cb8245d90c5accd7
Reviewed-on: https://review.typo3.org/57838
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[TASK] Reduce number of needed SQL queries for resorting of records 18/57218/41
Markus Klein [Tue, 24 Jul 2018 13:25:09 +0000 (15:25 +0200)]
[TASK] Reduce number of needed SQL queries for resorting of records

This reduces the resorting to require only a single update statement
in contrast to "number of records" statements.
It also only updates the records after the current one, so less records
are touched when resorting.

Now handling of the sorting value is following:
- if no record exists: set interval as sorting number
- if inserted before an element: put in the middle of the existing elements
- if inserted behind the last element: add interval to last sorting number
- if collision: move all subsequent records by 2 * interval, insert
  new record with sorting = collision + interval

Before, in case of the collision all the records from given pid were
resorted. The first item was getting 512 (2*sortIntervals) as sorting,
following records were getting value of
previous record + sortIntervals (768,1024,...).

Note:
I case we have multiple records with the same sorting value,
resorting will not fix that, but just move them up.

New algorithm drawback:
Sorting column values will grow quicker in time as we're always
increasing the sorting value and never tidying the whole table
(thus possibly lowering the max used value).
The current implementation still allows to insert some 80 million
records per colpos if sizeof(int) is only 32bit.
A lot more if we have 64bit.

Changes to the DataHandler->getSortNumber method are mostly comments and
formatting (added guard clause), no change in behavior except for
additional sorting by uid. The additional sorting was required to have
the same test results across database servers.

Description of updated tests:

- workspaces/.../IRRE/ForeignField/Publish/DataSet/copyPage.csv
  workspaces/.../IRRE/ForeignField/Publish/DataSet/copyPageWHotelBeforeParentContent.csv
  workspaces/.../IRRE/ForeignField/PublishAll/DataSet/copyPage.csv
  workspaces/.../IRRE/ForeignField/PublishAll/DataSet/copyPageWHotelBeforeParentContent.csv

  Now copied tx_irretutorial_1nff_price records have the same
  sorting values/order as original records (1,2,3 instead of 1,3,2).
  So workspace actions result in the same values as live operations.

- backend/.../Controller/Page/Localization/CSV/DataSet/CreatedElementOrdering.csv
  Order of the records in both languages is kept (before and after the patch),
  It might look wrong that a record 2.5 in translation is between 1 and 2
  and not between 2 and 3, but keep in mind that colpos is taken into account.
  So record 2.5 has just to be after record 1 (only the two are in colpos 0).

- install/.../Updates/RowUpdater/DataSet/recordsCanBeUpdated.csv
  core/.../IRRE/ForeignField/Modify/DataSet/localizePageWSynchronization.csv
  core/.../IRRE/ForeignField/Modify/DataSet/createNLocalizeParentContentNHotelNOfferChildren.csv
  core/.../IRRE/ForeignField/Modify/DataSet/createNLocalizeParentContentNHotelNOfferChildrenWOSortBy.csv
  core/.../IRRE/ForeignField/Modify/DataSet/localizeNCopyPageWSynchronization.csv
  core/.../IRRE/ForeignField/Modify/DataSet/localizePageWExclude.csv
  core/.../IRRE/ForeignField/Modify/DataSet/localizePageWithSynchronizationAndCustomLocalizedHotel.csv
  core/.../IRRE/ForeignField/Modify/DataSet/localizeParentContentNCreateNestedChildrenWLanguageSynchronization.csv
  core/.../IRRE/ForeignField/Modify/DataSet/localizeParentContentSynchronization.csv
  core/.../IRRE/ForeignField/Modify/DataSet/localizeParentContentChainLanguageSynchronizationSource.csv
  core/.../IRRE/ForeignField/Modify/DataSet/localizeParentContentWAllChildren.csv
  core/.../IRRE/ForeignField/Modify/DataSet/localizePageAddMonoglotHotelChildNCopyPageWSynchronization.csv
  core/.../IRRE/ForeignField/Modify/DataSet/localizePageNAddMonoglotHotelChildWSynchronization.csv
  core/.../IRRE/ForeignField/Modify/DataSet/localizePageNAddHotelChildWSynchronization.csv
  core/.../IRRE/ForeignField/Modify/DataSet/localizePageNAddHotelChildWExclude.csv
  core/.../IRRE/ForeignField/Modify/DataSet/copyParentContentToLanguageWAllChildren.csv
  workspaces/.../IRRE/ForeignField/Publish/DataSet/createNLocalizeParentContentNHotelNOfferChildren.csv
  workspaces/.../IRRE/ForeignField/PublishAll/DataSet/localizeParentContentWAllChildren.csv
  workspaces/.../IRRE/ForeignField/PublishAll/DataSet/createNLocalizeParentContentNHotelNOfferChildren.csv
  workspaces/.../IRRE/ForeignField/PublishAll/DataSet/createNLocParentNHotelNOfferChildrenNDiscardCreatedParent.csv
  workspaces/.../IRRE/ForeignField/PublishAll/DataSet/createNLocParentNHotelNOfferChildrenNDiscardLocParent.csv
  workspaces/.../IRRE/ForeignField/Modify/DataSet/copyPage.csv
  workspaces/.../IRRE/ForeignField/Modify/DataSet/localizeParentContentWAllChildren.csv
  workspaces/.../IRRE/ForeignField/Modify/DataSet/createNLocalizeParentContentNHotelNOfferChildren.csv
  workspaces/.../IRRE/ForeignField/Modify/DataSet/createNLocalizeParentContentNHotelNOfferChildrenWOSortBy.csv
  workspaces/.../IRRE/ForeignField/Modify/DataSet/createNLocParentNHotelNOfferChildrenNDiscardCreatedParent.csv
  workspaces/.../IRRE/ForeignField/Modify/DataSet/copyPageWHotelBeforeParentContent.csv
  workspaces/.../IRRE/ForeignField/Publish/DataSet/localizeParentContentWAllChildren.csv
  workspaces/.../IRRE/ForeignField/Publish/DataSet/createNLocParentNHotelNOfferChildrenNDiscardCreatedParent.csv
  workspaces/.../IRRE/ForeignField/Publish/DataSet/createNLocParentNHotelNOfferChildrenNDiscardLocParent.csv

  Order of the records is kept, less records have changed sorting values,
  as now we're just resorting records after the current one.

- impexp/.../DatabaseAssertions/importPagesAndRelatedTtContentWithDifferentImageToExistingData.csv
  impexp/.../DatabaseAssertions/importPagesAndRelatedTtContentWithSameImageToExistingData.csv
  now existing page sorting is not changed when importing data.

- workspaces/.../IRRE/CSV/Publish/DataSet/moveParentContentToDifferentPageNChangeSorting.csv
  workspaces/.../IRRE/CSV/Modify/DataSet/moveParentContentToDifferentPageNChangeSorting.csv
  workspaces/.../IRRE/CSV/PublishAll/DataSet/moveParentContentToDifferentPageNChangeSorting.csv

  in CSV relation we don't care about the child sorting field as
  the order is determined by the value of the CSV field.

Resolves: #85300
Releases: master
Change-Id: I033acae475be8778d10dfb5d506d63804aa941e0
Reviewed-on: https://review.typo3.org/57218
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[TASK] Allow C-style comments on a single line in TypoScript 63/57763/4
Markus Klein [Wed, 1 Aug 2018 19:38:15 +0000 (21:38 +0200)]
[TASK] Allow C-style comments on a single line in TypoScript

Resolves: #16681
Releases: master
Change-Id: I8a0e3e4a0ef9e6debabe581e1d8b05a32055621f
Reviewed-on: https://review.typo3.org/57763
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
13 months ago[BUGFIX] Use correct server variable for domain lock evaluation 33/57833/4
Markus Klein [Tue, 7 Aug 2018 21:39:35 +0000 (23:39 +0200)]
[BUGFIX] Use correct server variable for domain lock evaluation

Patch https://review.typo3.org/57759 introduced a regression by using
REMOTE_HOST instead of HTTP_HOST for matching an authenticating user
against a configured domain lock.

Resolves: #85776
Related: #85761
Releases: master
Change-Id: I1d0087fa0c86506fedccba83fa83502963bd5f6f
Reviewed-on: https://review.typo3.org/57833
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
13 months ago[BUGFIX] Remove wrong parameters for log entries and remove REMOTE_HOST 32/57832/2
Markus Klein [Tue, 7 Aug 2018 21:31:58 +0000 (23:31 +0200)]
[BUGFIX] Remove wrong parameters for log entries and remove REMOTE_HOST

Patch https://review.typo3.org/57313 introduced a number of wrong
log entry calls, which provide too much data for sprintf().
This patch removes those unneeded entries.

Moreover, this patch removes the REMOTE_HOST from log entries as those
would exact matching of the IP address, which is not desired. (GDPR)

Resolves: #85773
Related: #85316
Releases: master
Change-Id: Ic7eb288efde53f6232ee699e6786d965a67d2e7f
Reviewed-on: https://review.typo3.org/57832
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
13 months ago[!!!][TASK] Merge salted passwords auth service into default service 59/57759/14
Christian Kuhn [Wed, 1 Aug 2018 17:05:45 +0000 (19:05 +0200)]
[!!!][TASK] Merge salted passwords auth service into default service

The patch merges the default 'authUserBE' and 'authUserFE' authentication
service of extension saltedpasswords on priority 70 into the default
authentication service of the core on priority 50.

The now unused SaltedPasswordService is deprecated with this class.
Last inactive ways for authentication against stored plain text
passwords are removed.

While this is in almost all cases not a problem for existing instances
when upgrading, an edge case when this may lead to a security relevant
breaking change is described in a changelog file.

The new 'authUser' of the default core authentication method is
rewritten and carefully crafted to be much easier to understand, much
more defensive, better documented and tested.

Change-Id: Ie21e891b6f8b5ceed694b412f933ad6435240ff9
Resolves: #85761
Releases: master
Reviewed-on: https://review.typo3.org/57759
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[TASK] Update Breaking-72360-RemovedDeprecatedEntryPointFallback.rst 28/57828/2
Daniel Siepmann [Tue, 7 Aug 2018 08:19:05 +0000 (10:19 +0200)]
[TASK] Update Breaking-72360-RemovedDeprecatedEntryPointFallback.rst

Use link reference to issue.

Releases: master
Resolves: #85769
Change-Id: Iceed7dc91c9e6db032ab682bca5fb1db880a8857
Reviewed-on: https://review.typo3.org/57828
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
13 months ago[TASK] Update Breaking-72293-APIChangeInExceptionHandlerInterface.rst 27/57827/2
Daniel Siepmann [Tue, 7 Aug 2018 07:43:45 +0000 (09:43 +0200)]
[TASK] Update Breaking-72293-APIChangeInExceptionHandlerInterface.rst

Use link reference to issue.

Releases: master
Resolves: #85768
Change-Id: I2ab05a39637a85e815b986931846292da4497f85
Reviewed-on: https://review.typo3.org/57827
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
13 months ago[TASK] Deprecate GeneralUtility::getHostName 20/57820/2
Wouter Wolters [Sun, 5 Aug 2018 12:46:58 +0000 (14:46 +0200)]
[TASK] Deprecate GeneralUtility::getHostName

Resolves: #85759
Releases: master
Change-Id: I95fd13114bd7390f1baaecf81f5ef5d6b5ee60a8
Reviewed-on: https://review.typo3.org/57820
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Tested-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
13 months ago[TASK] Unnecessary isset argument specification 19/57819/2
Wouter Wolters [Sun, 5 Aug 2018 12:33:41 +0000 (14:33 +0200)]
[TASK] Unnecessary isset argument specification

Resolves: #85758
Releases: master
Change-Id: I2655e789003eaa98dc539d261503b4bc5138fe02
Reviewed-on: https://review.typo3.org/57819
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
13 months ago[FEATURE] Add hooks for DatabaseRecordList CSV actions 48/57648/3
Guido Schmechel [Sat, 21 Jul 2018 08:58:54 +0000 (10:58 +0200)]
[FEATURE] Add hooks for DatabaseRecordList CSV actions

Now it is possible to customize the csv output
in the DatabaseRecordList with a hook.

The following two hooks were implemented:
- customizeCsvHeader for the header
- customizeCsvRow for a single row

Resolves: #85590
Releases: master
Change-Id: Id80f7d22811c012d8f4671ce2e97956afc8a21db
Reviewed-on: https://review.typo3.org/57648
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Tested-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
13 months ago[TASK] Migrate Tooltip to TypeScript 24/56224/6
Andreas Wolf [Fri, 16 Mar 2018 13:44:37 +0000 (14:44 +0100)]
[TASK] Migrate Tooltip to TypeScript

Change-Id: I7de5841838784f5f3062e0657c30b272c0be7670
Resolves: #82607
Releases: master
Reviewed-on: https://review.typo3.org/56224
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Tested-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
13 months ago[BUGFIX] Adapt TCA signature for customControls to the documentation 25/57525/7
Xavier Perseguers [Tue, 10 Jul 2018 09:41:10 +0000 (11:41 +0200)]
[BUGFIX] Adapt TCA signature for customControls to the documentation

According to the documentation since TYPO3 v4.7, the definition of
"customControls" for "inline" columns should be a numerical array
with at least a "userFunc" key, just as any user function.

Releases: master, 8.7
Resolves: #83750
Change-Id: I2617cc9af9d642715b908296a2d75a3945b86cbb
Reviewed-on: https://review.typo3.org/57525
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Tested-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
13 months ago[TASK] Deprecate methods in PageRepository 85/57685/8
Wouter Wolters [Wed, 25 Jul 2018 19:10:14 +0000 (21:10 +0200)]
[TASK] Deprecate methods in PageRepository

Resolves: #85699
Releases: master
Change-Id: Ifd987469261b4b97c0f71bdaa20546f68eb21a37
Reviewed-on: https://review.typo3.org/57685
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Tested-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
13 months ago[BUGFIX] Remove attribute 'selected' if its value is false 31/56431/11
Georg Ringer [Thu, 22 Mar 2018 13:34:13 +0000 (14:34 +0100)]
[BUGFIX] Remove attribute 'selected' if its value is false

If the selected attribute is set to false (or zero), the
attribute itself must not be shown as even if it is empty it would be
meant to set the option to selected.

Resolves: #83229
Releases: master, 8.7
Change-Id: Ic2c87bf7b603eac288a4ce9d38a4ce75c5817f3d
Reviewed-on: https://review.typo3.org/56431
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Timo Poppinga <timo.poppinga@zdrei.com>
Tested-by: Timo Poppinga <timo.poppinga@zdrei.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
13 months ago[TASK] Migrate Localization to TypeScript 94/57594/4
Andreas Fernandez [Fri, 13 Jul 2018 20:06:56 +0000 (22:06 +0200)]
[TASK] Migrate Localization to TypeScript

Resolves: #82593
Releases: master
Change-Id: I808d823948a84f6eda1060d46fda4bd93d9bcf0d
Reviewed-on: https://review.typo3.org/57594
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
13 months ago[BUGFIX] Remove flashmessages only from session when session exists 57/57657/3
Christoph Lehmann [Sun, 22 Jul 2018 20:01:09 +0000 (22:01 +0200)]
[BUGFIX] Remove flashmessages only from session when session exists

A user may not be initialized, for example in the BE
module "Extension Configuration".

Resolves: #85615
Releases: master
Change-Id: I848f875b7035f59db4c01a856f957e405992096d
Reviewed-on: https://review.typo3.org/57657
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
13 months ago[BUGFIX] Detect current ImageMagick Version 7 for Windows. 05/57805/6
Michael Kersten [Sat, 4 Aug 2018 12:10:55 +0000 (14:10 +0200)]
[BUGFIX] Detect current ImageMagick Version 7 for Windows.

Try to use magick.exe if executable does not exists.

ImageMagick Version 7 for Windows does not use the executables for
identify, convert and combine/composite anymore. Instead the executable
magick.exe is used.

Resolves: #80909
Releases: master, 8.7
Change-Id: I823d399b723077e726b1105192474607b43fa907
Reviewed-on: https://review.typo3.org/57805
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
13 months ago[FEATURE] Open specific field when fixing links 02/57102/4
Sybille Peters [Thu, 31 May 2018 10:58:40 +0000 (12:58 +0200)]
[FEATURE] Open specific field when fixing links

When fixing links in Linkvalidator, you click on the edit icon
for the respective broken link which gets you to an edit form
for the record.

There you have too many input fields, and it is difficult to see,
what needs fixing.

With this patch only the respective table.field that contains
the broken link is opened in the edit form.

Resolves: #84704
Releases: master
Change-Id: I7d4b3ad96aa47a6a236a8ed0f6dcadc0229fbb82
Reviewed-on: https://review.typo3.org/57102
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
13 months ago[BUGFIX] Move page correctly when droping page before another one 09/57809/3
Paweł Rogowicz [Sat, 4 Aug 2018 16:57:24 +0000 (18:57 +0200)]
[BUGFIX] Move page correctly when droping page before another one

Fixes an issue where drag and dropping page before a another one didn't
detect the previous page correctly. DataHandler always expect
us to put a node AFTER. So when we want to place a page before, we need
to find previous page and put the new on after it.

Now it correctly compares depth of the node mouse is over with a previous
node. Before it took a dragged node depth for a comparison, which was wrong.

Releases: master
Resolves: #84008
Change-Id: Ic43be1147a5bb0fc1e15943a5d9e235d10727a07
Reviewed-on: https://review.typo3.org/57809
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
13 months ago[TASK] Improve layout of service reports 82/57782/6
Georg Ringer [Thu, 2 Aug 2018 15:52:08 +0000 (17:52 +0200)]
[TASK] Improve layout of service reports

Improve the following issues in the reports module regarding services:

- Use th instead of td
- Use correct labels
- Improved layout
- Add label for description

Resolves: #85734
Releases: master
Change-Id: Ied52773319706661d01d49682ef52829f924e555
Reviewed-on: https://review.typo3.org/57782
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Paweł Rogowicz <rogowicz.pawel@gmail.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
13 months ago[TASK] Deprecate property and method in DocumentTemplate 83/57783/3
Wouter Wolters [Thu, 2 Aug 2018 18:20:05 +0000 (20:20 +0200)]
[TASK] Deprecate property and method in DocumentTemplate

Method addStyleSheet and property $hasDocheader are marked as
deprecated.

Resolves: #85735
Releases: master
Change-Id: I69b5a35f006e9b77b87dd842ec636653829e8c96
Reviewed-on: https://review.typo3.org/57783
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
13 months ago[TASK] Set table cell alignment in Indexing Engine Statistics to top 07/57807/4
Michael Kersten [Sat, 4 Aug 2018 14:17:25 +0000 (16:17 +0200)]
[TASK] Set table cell alignment in Indexing Engine Statistics to top

Add CSS class "table-vertical-top" to table in template "Statistic"
for controller "Administration" in extension "indexed_search".

Resolves: #79549
Releases: master, 8.7
Change-Id: Iab6309a957340af7f1f0f2959b14da4c1eedc7a4
Reviewed-on: https://review.typo3.org/57807
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
13 months ago[TASK] Reactivate test in ConditionMatcherTest 03/57803/3
Anja [Sat, 4 Aug 2018 10:01:03 +0000 (12:01 +0200)]
[TASK] Reactivate test in ConditionMatcherTest

The test code has been fixed to actually do what the test name says.

Additionally, a comment has been added to the code being tested,
so the intention of the regex condition is clearer.

Change-Id: I7f78b913beffb026d7e5f9a3c6b10eb0083c542e
Resolves: #85755
Releases: master
Reviewed-on: https://review.typo3.org/57803
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Tested-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
13 months ago[TASK] Reactivate former skipped test in RendererRegistryTest 97/57797/3
Anja [Sat, 4 Aug 2018 08:15:42 +0000 (10:15 +0200)]
[TASK] Reactivate former skipped test in RendererRegistryTest

The test has been skipped due to a bug in PHP > 7.0, so
for v9 the skip condition doesn't apply anymore.

Change-Id: I202d8a8df90d709b2d21b72e4598edf8b4bb9951
Resolves: #85751
Releases: master
Reviewed-on: https://review.typo3.org/57797
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Tested-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
13 months ago[TASK] Switch some skipped conditions to annotations in GeneralUtilityTest 02/57802/5
Johannes Seipelt [Fri, 3 Aug 2018 17:05:16 +0000 (19:05 +0200)]
[TASK] Switch some skipped conditions to annotations in GeneralUtilityTest

Set requirements for some tests by annotation instead of conditions.

Resolves: #85747
Releases: master
Change-Id: Ic1c72bcf9757d2f6d0bb2294b445248479db9dd3
Reviewed-on: https://review.typo3.org/57802
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
13 months ago[TASK] Switch skip condition to annotations in PdoBackendTest 99/57799/2
Michael Kersten [Sat, 4 Aug 2018 08:31:46 +0000 (10:31 +0200)]
[TASK] Switch skip condition to annotations in PdoBackendTest

Use requires annotation for skipping test if php extension pdo_sqlite
is not loaded.

Resolves: #85752
Releases: master
Change-Id: I5bc418b9de553bd3ebf5be9cfa5d1497baa24cc2
Reviewed-on: https://review.typo3.org/57799
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
13 months ago[TASK] Switch skip condition to annotations in SemaphoreLockStrategyTest 01/57801/2
Michael Kersten [Sat, 4 Aug 2018 08:46:56 +0000 (10:46 +0200)]
[TASK] Switch skip condition to annotations in SemaphoreLockStrategyTest

Use requires annotation for skipping test if function sem_get does
not exists.

Resolves: #85754
Releases: master
Change-Id: Ic77d0687533b09bc4460394a183dd6c00930d856
Reviewed-on: https://review.typo3.org/57801
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
13 months ago[TASK] Switch skip condition to annotations in WincacheBackendTest 00/57800/2
Michael Kersten [Sat, 4 Aug 2018 08:38:43 +0000 (10:38 +0200)]
[TASK] Switch skip condition to annotations in WincacheBackendTest

Use requires annotation for skipping test if php extension wincache
is not loaded.

Resolves: #85753
Releases: master
Change-Id: Ifd53bdef148eac04ea4229c19c3ce018152d5eab
Reviewed-on: https://review.typo3.org/57800
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Tested-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
13 months ago[TASK] Switch skip condition with annotations in RedisSessionBackendTest 96/57796/3
Michael Kersten [Sat, 4 Aug 2018 07:28:40 +0000 (09:28 +0200)]
[TASK] Switch skip condition with annotations in RedisSessionBackendTest

Use requires annotation for skipping test if php extension redis
is not loaded.

Resolves: #85749
Releases: master
Change-Id: Ib5d642eae057676c34516c83ed3ab8c7c6ee02bd
Reviewed-on: https://review.typo3.org/57796
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
13 months ago[TASK] Switch skip condition with annotations in RedisBackendTest 95/57795/3
Michael Kersten [Sat, 4 Aug 2018 07:19:43 +0000 (09:19 +0200)]
[TASK] Switch skip condition with annotations in RedisBackendTest

Use requires annotation for skipping test if php extension redis
is not loaded.

Resolves: #85748
Releases: master
Change-Id: I587d2e6f9928defef9417c44358cc6816345caf3
Reviewed-on: https://review.typo3.org/57795
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
13 months ago[BUGFIX] Properly access table TCA 'ctrl' section in getPrioritizedFieldNames 81/57781/6
Tymoteusz Motylewski [Thu, 2 Aug 2018 16:07:07 +0000 (18:07 +0200)]
[BUGFIX] Properly access table TCA 'ctrl' section in getPrioritizedFieldNames

A part with table name was missing when accessing TCA array.
It also fixes similar issue in the rst file.

Resolves: #85733
Related: #85195
Releases: master
Change-Id: I947fe223336bb184f24a3b7248c6d8d724addb11
Reviewed-on: https://review.typo3.org/57781
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Tested-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
13 months ago[BUGFIX] Read page ID correctly when drag-dropping content 40/57640/4
Claus Due [Fri, 20 Jul 2018 12:04:55 +0000 (14:04 +0200)]
[BUGFIX] Read page ID correctly when drag-dropping content

Fixes an issue where drag and dropping a content element
would send the page title, not the page ID, as part of the
command map DataHandler receives.

The reason was an indiscriminate lookup in DOM for any
element which had any `data-page` attribute and assuming
that the first found object contained the integer value.

Using the drop target’s parent element instead will resolve
the value from the nearest relative place it can be found.

Effect is that DataHandler command hooks can once again
safely assume that the value of the “move” command is the
target page ID, not an arbitrary title on v9 and ID on v8.

Change-Id: I3b34bd099d50f6ef88fc6df1bbb647acbaa253d2
Releases: master
Resolves: #85603
Reviewed-on: https://review.typo3.org/57640
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Paweł Rogowicz <rogowicz.pawel@gmail.com>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
13 months ago[TASK] Replace default value with placeholder in external url link handler 34/57734/8
Joerg Boesche [Tue, 31 Jul 2018 06:48:50 +0000 (08:48 +0200)]
[TASK] Replace default value with placeholder in external url link handler

Use a placeholder attribute instead of a default value.

Resolves: #85689
Releases: master, 8.7
Change-Id: I99398125e16985ba78b3887150157da2b2c01905
Reviewed-on: https://review.typo3.org/57734
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
13 months ago[TASK] Update Styleguide to 9.2.0 85/57785/10
Tymoteusz Motylewski [Fri, 3 Aug 2018 10:09:08 +0000 (12:09 +0200)]
[TASK] Update Styleguide to 9.2.0

This brings examples of the field descriptions
and DataHandler based creation of test data.

https://github.com/TYPO3/styleguide/compare/9.1.0...9.2.0

Command run for updating the Styleguide:
composer require --dev typo3/cms-styleguide:~9.2.0

Releases: master
Resolves: #85740
Change-Id: Ibb7275f4cda8a487bb1c6ec6c05632d6d645f164
Reviewed-on: https://review.typo3.org/57785
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
13 months ago[TASK] Remove ugly empty area when container element is empty 22/57422/7
Łukasz Uznański [Sat, 30 Jun 2018 14:27:01 +0000 (16:27 +0200)]
[TASK] Remove ugly empty area when container element is empty

Remove margin from container elements

Resolves: #85049
Releases: master
Change-Id: I87f315343d96087ca70ac73049d9c6bba92910d2
Reviewed-on: https://review.typo3.org/57422
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Paweł Rogowicz <rogowicz.pawel@gmail.com>
Tested-by: Paweł Rogowicz <rogowicz.pawel@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
13 months ago[TASK] Block web access to *.tsconfig files 88/57788/2
Stephan Großberndt [Fri, 3 Aug 2018 08:22:02 +0000 (10:22 +0200)]
[TASK] Block web access to *.tsconfig files

Resolves: #85738
Releases: master, 8.7
Change-Id: I824cdce7c08e5390eafb654e2066b8f61db3c0ac
Reviewed-on: https://review.typo3.org/57788
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
13 months ago[TASK] Use RootlineUtility in Site Finder 64/57764/9
Benni Mack [Wed, 1 Aug 2018 20:08:59 +0000 (22:08 +0200)]
[TASK] Use RootlineUtility in Site Finder

The SiteFinder uses a custom rootline traversal, but
since this is cleared up with the Context API and
the separation of RootlineUtility from PageRepository,
this can now be used directly - thus caching is
utilized by default.

Resolves: #85714
Releases: master
Change-Id: Ie60bc059e24058b1bd893ad4102b39363eba85d7
Reviewed-on: https://review.typo3.org/57764
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
13 months ago[TASK] Move PageUriBuilder to EXT:core 84/57784/3
Frank Naegler [Thu, 2 Aug 2018 19:05:38 +0000 (21:05 +0200)]
[TASK] Move PageUriBuilder to EXT:core

The class PageUriBuilder is moved to the system extension EXT:core

A class alias is in place.

Resolves: #85736
Releases: master
Change-Id: Ib96dda9cf30131fc86bc44a2cbc38ac4fc86f9ae
Reviewed-on: https://review.typo3.org/57784
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
13 months ago[TASK] Move DatabaseIntegrityCheck to EXT:lowlevel 65/57765/4
Benni Mack [Wed, 1 Aug 2018 20:16:01 +0000 (22:16 +0200)]
[TASK] Move DatabaseIntegrityCheck to EXT:lowlevel

The class DatabaseIntegrityCheck is solely needed in
EXT:lowlevel, and is moved to the system extension
out of EXT:core.

Resolves: #85727
Releases: master
Change-Id: I86e3b359f4692746aa87ea153edf0b18c89cea30
Reviewed-on: https://review.typo3.org/57765
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
13 months ago[TASK] Move RecordHistory into DataHandling namespace 73/57773/3
Benni Mack [Thu, 2 Aug 2018 10:44:39 +0000 (12:44 +0200)]
[TASK] Move RecordHistory into DataHandling namespace

The newly created (internal) RecordHistory class is
moved to the DataHandling namespace as it is related
to all other logic (e.g. DataHandler).

Resolves: #85728
Releases: master
Change-Id: Ib3cf60541e638586f246d64542d0e19bef7f62e8
Reviewed-on: https://review.typo3.org/57773
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
13 months ago[TASK] Fix typo in rst file 79/57779/2
Georg Ringer [Thu, 2 Aug 2018 15:29:33 +0000 (17:29 +0200)]
[TASK] Fix typo in rst file

Instead of 'Important-85683-DoppedSaltedpasswordOptions.rst' the file should be
named 'Important-85683-DroppedSaltedpasswordOptions.rst'.

Resolves: #85732
Releases: master
Change-Id: Ie6a13739128818e23dbdc6e20732011905f80509
Reviewed-on: https://review.typo3.org/57779
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
13 months ago[BUGFIX] Avoid exception for int label column 76/57776/2
Stephan Großberndt [Thu, 2 Aug 2018 11:51:39 +0000 (13:51 +0200)]
[BUGFIX] Avoid exception for int label column

By casting the title column to string for the label of an TCA record an
exception caused by a strict type check is avoided when shortening the
title.

Resolves: #85729
Related: #79440
Releases: master, 8.7
Change-Id: Ie365b92ae73cd766c412d66ff7624eebbbfb3cf7
Reviewed-on: https://review.typo3.org/57776
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
13 months ago[TASK] Add SiteInterface to site handling 85/57085/5
Benni Mack [Tue, 29 May 2018 22:10:04 +0000 (00:10 +0200)]
[TASK] Add SiteInterface to site handling

In order to allow sites without configuration
(e.g. based on sys_domain records),  a site interface
is added which also allows to code against.

Resolves: #85717
Releases: master
Change-Id: Icc3c8f574855d2c54560d49320dda6de426977e5
Reviewed-on: https://review.typo3.org/57085
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
13 months ago[TASK] Deprecate methods in ModuleTemplate 50/57750/4
Wouter Wolters [Tue, 31 Jul 2018 19:25:20 +0000 (21:25 +0200)]
[TASK] Deprecate methods in ModuleTemplate

Two methods are marked as deprecated in the class ModuleTemplate.

Resolves: #85701
Releases: master
Change-Id: If17a0e40b4bcb31c1292d4fd97af35967427c621
Reviewed-on: https://review.typo3.org/57750
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
13 months ago[BUGFIX] Do not create default export of AjaxDataHandler class 49/57749/7
Andreas Fernandez [Tue, 31 Jul 2018 18:11:12 +0000 (20:11 +0200)]
[BUGFIX] Do not create default export of AjaxDataHandler class

Resolves: #85611
Related: #84168
Releases: master
Change-Id: If6003015d0c300566781856cc8351e2b60468573
Reviewed-on: https://review.typo3.org/57749
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Paweł Rogowicz <rogowicz.pawel@gmail.com>
Tested-by: Paweł Rogowicz <rogowicz.pawel@gmail.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
13 months ago[TASK] Deprecate LoginFramesetController 56/57756/5
Benni Mack [Wed, 1 Aug 2018 15:10:10 +0000 (17:10 +0200)]
[TASK] Deprecate LoginFramesetController

The class LoginFramesetController just does a simple frameset and
has been replaced by using `index.php?loginRefresh=1` directly.

Resolves: #85707
Related: #84368
Releases: master
Change-Id: Iaa4457ed9617d47a1551326125ed2c737f3bd34a
Reviewed-on: https://review.typo3.org/57756
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
13 months ago[BUGFIX] LocalizationFactory use new trigger_error call 69/57769/2
Benni Mack [Thu, 2 Aug 2018 06:28:02 +0000 (08:28 +0200)]
[BUGFIX] LocalizationFactory use new trigger_error call

Seems like this one was forgotten, don't know how
this could ever happen.

Resolves: #85721
Releases: master
Change-Id: I1c6bef0433c4b7ecf169ce83da2dc44ca4e4ef70
Reviewed-on: https://review.typo3.org/57769
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Tested-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
13 months ago[BUGFIX] Cast config.noPageTitle to int before strict comparison 68/57768/3
Richard Haeser [Wed, 1 Aug 2018 21:49:10 +0000 (23:49 +0200)]
[BUGFIX] Cast config.noPageTitle to int before strict comparison

Resolves: #85720
Related: #83254
Releases: master
Change-Id: I3183e24e59e38eb7f384deecf2e8227a2c3da6de
Reviewed-on: https://review.typo3.org/57768
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
13 months ago[TASK] Update composer dependencies 65/57665/4
Wouter Wolters [Mon, 23 Jul 2018 19:41:36 +0000 (21:41 +0200)]
[TASK] Update composer dependencies

composer update guzzlehttp/guzzle
composer update nikic/php-parser
composer update symfony/polyfill-php70
composer update symfony/polyfill-php72
composer update enm1989/chromedriver
composer update typo3fluid/fluid
composer update symfony/expression-language
composer update symfony/browser-kit
composer update symfony/css-selector
composer update symfony/dom-crawler
composer update symfony/cache
composer update symfony/event-dispatcher
composer update symfony/process

Resolves: #85700
Releases: master
Change-Id: I3389aa9e8004c6aee079a026cbc6f0ddb8712263
Reviewed-on: https://review.typo3.org/57665
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[TASK] Clean up tests from Context API refactoring 57/57757/3
Benni Mack [Wed, 1 Aug 2018 15:23:34 +0000 (17:23 +0200)]
[TASK] Clean up tests from Context API refactoring

Due to the Context API a lot less mocking needs to be done, and tests can be cleaned up.

On top, cObject receives a TSFE object as first parameter as DI, which can be used in
the code instead of global variables.

Resolves: #85708
Releases: master
Change-Id: I9d662b6735983d71e0b046548b747ac9b7f529db
Reviewed-on: https://review.typo3.org/57757
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
13 months ago[TASK] Separate sending from gathering HTTP headers 58/57758/4
Benni Mack [Wed, 1 Aug 2018 15:41:50 +0000 (17:41 +0200)]
[TASK] Separate sending from gathering HTTP headers

In order to streamline HTTP response output, the list compiling of
headers sent to the browser is separated from the actual sending
(PHP call "header()").

This is a pre-patch to allow further refactorings for
better PSR-7 support.

Resolves: #85709
Releases: master
Change-Id: Id1f7750fcdf6a40ed23d3529ae8552d0a85abd93
Reviewed-on: https://review.typo3.org/57758
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[TASK] Use CLI and Composer Checks via Environment class 96/55996/20
Benni Mack [Sat, 3 Mar 2018 22:23:31 +0000 (23:23 +0100)]
[TASK] Use CLI and Composer Checks via Environment class

This patch removes the last occurrences of TYPO3_REQUESTTYPE_CLI
by using Environment::isCli().

A new "TYPO3/Testing" TYPO3_CONTEXT check ensures that the Frontend
Request is now always simulated in a non-CLI environment.

Used composer command:

  composer req typo3/testing-framework:~4.2.0 --dev

Resolves: #85712
Releases: master
Change-Id: I7472e86f2816fdabd025ad87014e64b25c3d1642
Reviewed-on: https://review.typo3.org/55996
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
13 months ago[BUGFIX] Correctly render language fields of sys_file_metadata 60/57760/2
Helmut Hummel [Wed, 1 Aug 2018 18:04:16 +0000 (20:04 +0200)]
[BUGFIX] Correctly render language fields of sys_file_metadata

This reverts commit 1a74c8c9d302958dd17b6a35c03e185f13811c4b
("[BUGFIX] Correctly reference sys_file_metadata.language in TCA"),
that replaced the rendering of sys_language_uid and l10n_parent
with the file language field, which was since then rendered twice.

We now correctly render the hidden language palette in the general tab
and remove the language tab, which was empty after the palette has been
hidden.

Resolves: #85711
Related: #84200
Related: #75040
Releases: master, 8.7
Change-Id: I18ab907bc48f81b257d3af42c4278d6688166b2f
Reviewed-on: https://review.typo3.org/57760
Reviewed-by: Moritz Ngo <moritz.ngo@p2media.de>
Tested-by: Moritz Ngo <moritz.ngo@p2media.de>
Reviewed-by: Dennis Oezet <dennisoezet@gmx.net>
Tested-by: Dennis Oezet <dennisoezet@gmx.net>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Volkmer <typo3@markusvolkmer.de>
Tested-by: Markus Volkmer <typo3@markusvolkmer.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
13 months ago[BUGFIX] Allow requirejs modules from wizards in RTE fields 53/57753/3
Helmut Hummel [Wed, 1 Aug 2018 10:42:47 +0000 (12:42 +0200)]
[BUGFIX] Allow requirejs modules from wizards in RTE fields

The RichTextElement must not unset "requireJsModules"
from the result array as this removes previously added
modules.

Resolves: #85705
Releases: master, 8.7
Change-Id: I495732f0a1f16db84b8ec6daa2fd028e4a3a9dee
Reviewed-on: https://review.typo3.org/57753
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
13 months ago[BUGFIX] Streamline deprecation messages 54/57754/2
Benni Mack [Wed, 1 Aug 2018 12:36:23 +0000 (14:36 +0200)]
[BUGFIX] Streamline deprecation messages

Some usages of trigger_error() used \E_USER_DEPRECATED or no 2nd parameter
(which falls back to E_USER_NOTICE) which resulted in some weird issues
with opcache fatal PHP errors.

Resolves: #85706
Releases: master
Change-Id: I0916cc000d6c5d5b7e436bf91285072ff66dd657
Reviewed-on: https://review.typo3.org/57754
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Sattler <sattler@b13.de>
Tested-by: Daniel Sattler <sattler@b13.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
13 months ago[TASK] Merge saltedpasswords felogin hook into felogin 52/57752/2
Christian Kuhn [Wed, 1 Aug 2018 08:59:24 +0000 (10:59 +0200)]
[TASK] Merge saltedpasswords felogin hook into felogin

Extension salted passwords hooks into felogin to hash a new
password before it is written to database if the user resets
his password using the 'forgot password' functionality.
Since salted passwords is a mandatory extension, this hook
usage is now removed and the hash creation is put into
felogin directly.
Note the hook method feloginForgotPasswordHook() had a type
hint to FrontendLoginController, is thus tailored for this
extension only and can't be abused by a different one. It is
safe to remove that method entirely.

Change-Id: I85d4ba59cecd3bd43b148008e70fe20f0f5dc0bc
Resolves: #85703
Releases: master
Reviewed-on: https://review.typo3.org/57752
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
13 months ago[BUGFIX] Send AJAX data in EXT:recycler as POST 45/57745/2
Stephan Großberndt [Tue, 31 Jul 2018 13:37:32 +0000 (15:37 +0200)]
[BUGFIX] Send AJAX data in EXT:recycler as POST

By sending the uids of the records to really delete or recover by POST
instead of GET an HTTP error "414 Request-URI too long" is avoided when
deleting many records at once.

Resolves: #85696
Releases: master, 8.7
Change-Id: Ia8b7d5330a281bdc7916001a6b29a857f91bb986
Reviewed-on: https://review.typo3.org/57745
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Willi Wehmeier <wwwehmeier@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
13 months ago[FEATURE] Add TCA 'saltedPassword' eval for type=input 46/57746/5
Christian Kuhn [Tue, 31 Jul 2018 14:28:14 +0000 (16:28 +0200)]
[FEATURE] Add TCA 'saltedPassword' eval for type=input

The salted passwords extension did register a custom
field evaluation to hash a given password when editing users
in the backend through FormEngine.
This is now turned into a general eval 'saltedPassword'
and handled in the DataHandler directly. Note the existing
eval 'password' is not extended since 'password' eval
changes the display part to show '****', which should be
kept seperated from the salt evaluation.
The "Evaluation" classes are dropped directly without
substitution since they are totally saltedpasswords internal
and don't make sense to be used externally.

Change-Id: I93306eaf18222d14e141a3d612a419a2b7174341
Resolves: #85698
Releases: master
Reviewed-on: https://review.typo3.org/57746
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>