Packages/TYPO3.CMS.git
9 years ago[BUGFIX] root-lines for DB Mounts in Pagetree rendering wrong markup
Steffen Ritter [Tue, 18 Oct 2011 12:15:43 +0000 (14:15 +0200)]
[BUGFIX] root-lines for DB Mounts in Pagetree rendering wrong markup

The option "options.pageTree.showPathAboveMounts = 1" which shows the
rootline of each DB Mount in a line before is implemented in a
non-valid way.

This means, that a <div> tag is rendered within an <ul> tag right in
front of the <li> of the DB Mount node.

Change-Id: Ic715426b8d04220410bcb15bfba33a39e5fd47bc
Fixes: #31067
Releases: 4.6
Reviewed-on: http://review.typo3.org/5962
Reviewed-by: Xavier Perseguers
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Francois Suter
Tested-by: Francois Suter
9 years ago[TASK] English XLIFF files should not contain target element
Dominique Feyer [Mon, 17 Oct 2011 19:57:21 +0000 (21:57 +0200)]
[TASK] English XLIFF files should not contain target element

Pootle uses the English XLIFF file has the template language and as such
it does not make sense to have "en" -> "en" translation files.

English XLIFF files are templates and should contain only a 'source', not
a 'target' element.

This commit contains:

- Remove of the target elements
- Remove target-language attribute
- Set the date attribute to the correct format
- Remove approved attribute

Change-Id: I84f4534f5ed595868c88f05816a73464a76f3f25
Resolves: #31035
Relates: #30916
Releases: 4.6
Reviewed-on: http://review.typo3.org/5916
Tested-by: Philipp Gampe
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
9 years ago[TASK] PHPdoc improvement in saltedpasswords autoloader
Steffen Gebert [Mon, 17 Oct 2011 21:25:52 +0000 (23:25 +0200)]
[TASK] PHPdoc improvement in saltedpasswords autoloader

Change-Id: Ifb8a3b6235e409adfd3204e883bd69b83213cf20
Releases: 4.6
Reviewed-on: http://review.typo3.org/5926
Reviewed-by: Björn Pedersen
Tested-by: Björn Pedersen
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
9 years ago[TASK] Add support for English XLIFF template files
Dominique Feyer [Mon, 17 Oct 2011 19:50:13 +0000 (21:50 +0200)]
[TASK] Add support for English XLIFF template files

Currently the XLIFF files provided with the Core are "en" -> "en" translation files,
and this is a wrong design.

English XLIFF files must be template files (XLIFF files without target element) and
as such, the parser needs to be adjusted not to return an empty label.

Change-Id: I7181872ebd9ff7a89ec66558aa6de9a9608f72c7
Resolves: #30916
Releases: 4.6
Reviewed-on: http://review.typo3.org/5914
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Björn Pedersen
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
9 years ago[BUGFIX] Pagetree broken due to JavaScript exception
Steffen Ritter [Tue, 18 Oct 2011 11:44:51 +0000 (13:44 +0200)]
[BUGFIX] Pagetree broken due to JavaScript exception

Sometimes (especially with empty DB Mount) the Pagetree is broken and stops with a JavaScript Exception.

This is due to some problems with the state-restore logic, where the state of not-yet-rendered nodes is applied.

Change-Id: Ic9ac5792272b3bc6b2907149a93cd7c22649c317
Fixes: #28687
Releases: 4.6
Reviewed-on: http://review.typo3.org/5958
Reviewed-by: Björn Pedersen
Tested-by: Björn Pedersen
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
9 years ago[TASK] Raise submodule pointer
TYPO3 v4 Release Team [Tue, 18 Oct 2011 09:04:12 +0000 (11:04 +0200)]
[TASK] Raise submodule pointer

Change-Id: Ib698448736b9649cd2a60a4f72b43810075f8793
Reviewed-on: http://review.typo3.org/5940
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
9 years ago[BUGFIX] date expects parameter 2 to be long, string given
Simon Schaufelberger [Sat, 15 Oct 2011 09:38:13 +0000 (11:38 +0200)]
[BUGFIX] date expects parameter 2 to be long, string given

Any zero length string value is replaced with the current timestamp.
(Just like the default value for the second parameter of date/gmdate.)

Change-Id: I44d095deb7b511b8b35730f2f031186aeaadb945
Fixes: #30931
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/5821
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Björn Pedersen
Reviewed-by: Simon Schaufelberger
Tested-by: Simon Schaufelberger
9 years ago[BUGFIX] Load date-time picker in Scheduler module
Jigal van Hemert [Tue, 18 Oct 2011 06:27:31 +0000 (08:27 +0200)]
[BUGFIX] Load date-time picker in Scheduler module

The date-time picker must be loaded explicitly.

Change-Id: I06014d1a3ed9ce6584272632f1532ba1bcf92843
Releases: 4.6
Fixes: #31027
Reviewed-on: http://review.typo3.org/5927
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
9 years ago[BUGFIX] Class not found fatal in autoload
Christian Kuhn [Sun, 16 Oct 2011 17:16:36 +0000 (19:16 +0200)]
[BUGFIX] Class not found fatal in autoload

If the caching framework configuration is broken and cache_phpcode
array is not set properly, cacheManager throws a fatal error unable
to find class t3lib_cache_exception_NoSuchCache. The patch adds the
class to be required during bootstrap so the exception (uncaught) is
actually thrown and hints an administrator on what exactly goes wrong.

Change-Id: I42ac66457776e1b4a4f8dca40e41f364d9496eed
Resolves: #30913
Reviewed-on: http://review.typo3.org/5881
Reviewed-by: Björn Pedersen
Reviewed-by: Xavier Perseguers
Reviewed-by: Dmitry Dulepov
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
9 years ago[BUGFIX] Layout of "Move Element" screen
Tomas Norre Mikkelsen [Sat, 17 Sep 2011 17:20:03 +0000 (19:20 +0200)]
[BUGFIX] Layout of "Move Element" screen

Added more space between page icon/title and checkbox
"Make copy instead of moving element".

Change-Id: I5467d98adfebeee7b022dab829da175bf52f3254
Fixes: #27605
Releases: 4.6
Reviewed-on: http://review.typo3.org/5008
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
9 years ago[TASK] Update a list of required PHP extensions in the INSTALL.txt
Dmitry Dulepov [Mon, 17 Oct 2011 11:26:55 +0000 (14:26 +0300)]
[TASK] Update a list of required PHP extensions in the INSTALL.txt

OpenSSL PHP extension is now required by the TYPO3 core and must
be listed in the INSTALL.txt.

Change-Id: I54f853603ec7fa5079980026abfc7de59196793c
Resolves: #30999
Releases: 4.6
Reviewed-on: http://review.typo3.org/5896
Reviewed-by: Oliver Klee
Tested-by: Oliver Klee
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
9 years ago[BUGFIX] skip missing icons in tceforms select options
Peter Niederlag(office) [Wed, 28 Sep 2011 07:55:32 +0000 (09:55 +0200)]
[BUGFIX] skip missing icons in tceforms select options

check existance of file before adding background style url

Change-Id: Ie5db6d6a6b6b7ccdd5772a829be0ca236787cd9a
Fixes: #24591
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/5394
Reviewed-by: Björn Pedersen
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Philipp Gampe
Reviewed-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
9 years ago[BUGFIX] About module is missing the extension credits
Oliver Klee [Sat, 15 Oct 2011 19:53:33 +0000 (21:53 +0200)]
[BUGFIX] About module is missing the extension credits

Re-add the extension list to the Help > About module.

This part had acidentally been removed during the refactoring
of that module.

Resolves: #30972

Change-Id: I9f4adcb30b12f67e8ba302c01011a040c8d6a469
Releases: 4-6
Reviewed-on: http://review.typo3.org/5864
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
9 years ago[TASK] Add a hook to customize field list for Backend search
Dmitry Dulepov [Fri, 14 Oct 2011 09:51:56 +0000 (12:51 +0300)]
[TASK] Add a hook to customize field list for Backend search

Due to Backend search changes, we need a hook to alter table
search configuration in the List module. This hook can be used
by extensions to add their own fields to the list of searchable
fields. Also this hook will be used by a compatibility extension
that provides legacy search functionality until extension
authors update their extensions for smarter search.

Change-Id: I0b37ceb617779925555bcbeb10da9ef093d4bd81
Resolves: #30915
Releases: 4.6
Reviewed-on: http://review.typo3.org/5785
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
9 years ago[TASK] Fix CGL issue in t3lib/config_default.php
Oliver Hader [Thu, 13 Oct 2011 15:47:35 +0000 (17:47 +0200)]
[TASK] Fix CGL issue in t3lib/config_default.php

Change-Id: I7b9f175ce7882399528d61f338defc8db43746c8
Reviewed-on: http://review.typo3.org/5772
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
9 years ago[TASK] Update system extension information
Xavier Perseguers [Wed, 12 Oct 2011 15:33:03 +0000 (17:33 +0200)]
[TASK] Update system extension information

When shipped with TYPO3, system extensions should be stable, have a
version that is at least 1.0.0, have a version that is higher than
in TYPO3 4.5 LTS and should have at least the same basic dependencies
as the Core itself.

Change-Id: I141cd5a2254ae9430d3047a7506b4ae3cf9e7c9e
Resolves: #30853
Releases: 4.6
Reviewed-on: http://review.typo3.org/5743
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Björn Pedersen
Tested-by: Björn Pedersen
9 years ago[TASK] Set TYPO3 version to 4.6-dev
TYPO3 v4 Release Team [Tue, 11 Oct 2011 13:40:32 +0000 (15:40 +0200)]
[TASK] Set TYPO3 version to 4.6-dev

Change-Id: I328139309e5d971ea771f3506325efe544414bc6
Reviewed-on: http://review.typo3.org/5723
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
9 years ago[RELEASE] Release of TYPO3 4.6.0rc1
TYPO3 v4 Release Team [Tue, 11 Oct 2011 13:40:12 +0000 (15:40 +0200)]
[RELEASE] Release of TYPO3 4.6.0rc1

Change-Id: I74f33e689df164058f8e17b104c7f9650f99f604
Reviewed-on: http://review.typo3.org/5722
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
9 years ago[BUGFIX] EM: Fix button "close window" after fulfilling dependencies
Kay Strobach [Tue, 11 Oct 2011 06:38:27 +0000 (08:38 +0200)]
[BUGFIX] EM: Fix button "close window" after fulfilling dependencies

This fix opens the window in a sized window and changes the logic to
determine the correct function for closing the window.

Change-Id: Ie16d67284240a833e5bfae67d8b78eab808f9a79
Releases: 4.6
Resolves: #29788
Reviewed-on: http://review.typo3.org/5706
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
9 years ago[TASK] Raise submodule pointer
TYPO3 v4 Release Team [Tue, 11 Oct 2011 11:45:42 +0000 (13:45 +0200)]
[TASK] Raise submodule pointer

Change-Id: I2518fcaa595529cf840b0d56805d11feb17468fe
Reviewed-on: http://review.typo3.org/5718
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
9 years ago[BUGFIX] Showmodule cannot be called before Store is loaded
Oliver Hader [Mon, 10 Oct 2011 21:24:41 +0000 (23:24 +0200)]
[BUGFIX] Showmodule cannot be called before Store is loaded

Example: Using the direct page edit feature (backend.php?edit=xxx)
the BE responds with "Module loader No module found. If this is a
temporary error, please reload the Backend!" error.

Since the AJAX request is not finished at the time this is called,
it has to be checked whether the store was completely loaded.

Change-Id: Ia7c39fc94e75ef003a7a839856ea78cbd0854a66
Releases: 4.6,4.5
Resolves: #28951
Reviewed-on: http://review.typo3.org/5681
Reviewed-by: Helmut Hummel
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Tested-by: Jigal van Hemert
9 years ago[BUGFIX] backend.php wrongly checks deprecated TSconfig
Xavier Perseguers [Mon, 10 Oct 2011 20:03:35 +0000 (22:03 +0200)]
[BUGFIX] backend.php wrongly checks deprecated TSconfig

Deprecated option options.shortcut_onEditId_dontSetPageTree is wrongly
tested.

Change-Id: If88e869b8c92592ad6bb3369f1eda29c2a0809bf
Fixes: #30754
Releases: 4.6
Reviewed-on: http://review.typo3.org/5683
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
9 years ago[BUGFIX] Replace debug with call to deprecationLog
Tolleiv Nietsch [Mon, 10 Oct 2011 01:03:08 +0000 (03:03 +0200)]
[BUGFIX] Replace debug with call to deprecationLog

Commit 0eb4686afb2ed871adf3376ad12cb069d4a3f88d wrongly introduced
a debug() statement instead of a call to the deprecationLog()
method.

Change-Id: Ie54e6b0f1d22035b17dad59ec8fea7b1b2f644f1
Resolves: #30759
Branches: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/5693
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
9 years ago[TASK] Merge linkvalidator for RC1
Philipp Gampe [Mon, 10 Oct 2011 20:32:18 +0000 (22:32 +0200)]
[TASK] Merge linkvalidator for RC1

Changes included:
3b062e3 [TASK] Prepare merge for 4.6-RC1 (part 2)
27e93d6 Merge "[BUGFIX] Invalid target language in localization file"
ba0178b [BUGFIX] Invalid target language in localization file
36f1b21 [BUGFIX][SECURITY] SQL Injection in Scheduler Task of
Linkvalidator
9636b77 [TASK] Merge Changes from core since last sync
709531e [TASK] Prepare merge for 4.6-RC1
5607748 Merge "[BUGFIX] SQL error if a task is run on a disabled page"
e2bb756 [TASK] Update manual
79b4741 [BUGFIX] SQL error if a task is run on a disabled page
6856163 Merge "[BUGFIX] It is not possible to set page 0 to schedular
task"
28a38da Merge "[BUGFIX] SQL error if opening a disabled page with
module"
0fece3f [BUGFIX] It is not possible to set page 0 to schedular task
df464d4 [BUGFIX] Revert change in interface signature
4335331 [BUGFIX] SQL error if opening a disabled page with module
c12d8f5 [TASK] Fix CGL issues
74a9c14 [BUGFIX] Initialize $currentR in analyseTypoLinks
e5d6b19 [TASK] Bump version number

Change-Id: Ia3a9583112b601c21f58e9b782ecb5b03e331fe4
Resolves: #30756
Reviewed-on: http://review.typo3.org/5685
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
9 years ago[BUGFIX] EM: Remove nested form tag
Helmut Hummel [Mon, 10 Oct 2011 20:56:28 +0000 (22:56 +0200)]
[BUGFIX] EM: Remove nested form tag

In the new EM in the extension configuration settings it is not possible
to switch between extension configuration categories in some browsers.
This is caused by a nested form tag which will be removed with this commit.

Change-Id: Ie4e4d5f33d319467626aa4923abe07d608af9bbb
Resolves: #30257
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/5688
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
9 years ago[BUGFIX] Wrong alignment of French labels for login screen
Eric Chavaillaz [Sun, 9 Oct 2011 15:14:53 +0000 (17:14 +0200)]
[BUGFIX] Wrong alignment of French labels for login screen

Since the username label changed from "Utilisateur" to "Nom d'utilisateur"
in French, the alignment of labels and text fields is broken.

Change-Id: I35f28fd61f8c4a3e133949ae8eb865af0e0a1bc9
Fixes: #30688
Releases: 4.5,4.6
Reviewed-on: http://review.typo3.org/5648
Reviewed-by: Eric Chavaillaz
Tested-by: Eric Chavaillaz
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
9 years ago[TASK] Remove space between ExtJS tbar and related panel
Kay Strobach [Sat, 6 Aug 2011 09:10:37 +0000 (11:10 +0200)]
[TASK] Remove space between ExtJS tbar and related panel

This task just changes one line of css to remove the senseless space
between a panel and it's related tbar.

This is useful, because the space between toolbar and panel was bigger,
than the space to neighboor panels.

Change-Id: I631acb14d1ed598f2e5718b84b21d76277a37391
Resolves: #28793
Releases: 4.6
Reviewed-on: http://review.typo3.org/4170
Reviewed-by: Stefan Neufeind
Reviewed-by: Fabien Udriot
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
9 years ago[BUGFIX] handler is undefined when resizing the backend
Simon Schaufelberger [Sat, 8 Oct 2011 16:20:48 +0000 (18:20 +0200)]
[BUGFIX] handler is undefined when resizing the backend

Resizing the backend browser window results in a JavaScript error.
The function that handles the re-positioning of the menus does not
work correctly. The observer requires a reference to a callback
function - currently the method was directly executed and the return
value used as function reference, which was undefined in this case.

Change-Id: Ifb2db858d7075f4fd714d737576189c0e1efc5a5
Resolves: #25787
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/5634
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
9 years ago[BUGFIX] Implement availability checks for rsaauth
Helmut Hummel [Sun, 18 Sep 2011 20:16:10 +0000 (22:16 +0200)]
[BUGFIX] Implement availability checks for rsaauth

The 123 Installer now checks if openssl is configured properly
before enabling saltedpasswords and rsaauth.

Resolves: #28275
Releases: 4.6

Change-Id: I1d6c5ce6e3dfedfac85349baa01c88118bb348f8
Reviewed-on: http://review.typo3.org/5657
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Dmitry Dulepov
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
9 years ago[BUGFIX] md5.js fails with non-ascii-characters
Stefan Neufeind [Mon, 10 Oct 2011 12:04:32 +0000 (14:04 +0200)]
[BUGFIX] md5.js fails with non-ascii-characters

Current implementation of md5.js only considers a very
limited range of characters.
The implementation from webtoolkit.info uses correct
unicode-representation.

Change-Id: I8f71673f60f22e39862ca2a447f496159b8079bb
Releases: 4.4, 4.5, 4.6
Resolves: #22328
Reviewed-on: http://review.typo3.org/5665
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Tested-by: Oliver Hader
9 years ago[BUGFIX] Race-condition while updating extension list
Steffen Gebert [Sat, 8 Oct 2011 22:18:16 +0000 (00:18 +0200)]
[BUGFIX] Race-condition while updating extension list

There is a race-condition in the EM while updating the extension list.

If the update takes more than 30 seconds, Ext.Direct reaches its Ajax
timeout and sends the Ajax request (to update the list) again. As the EM
updates the extensions.xml.gz file at the beginning of the update
process, the second request immediately sees that the repository is
already up-to-date and respons this status to the client.

Thus, the user gets a "Repository is already up-to-date" message shown,
although it was not.

Change-Id: I2bc6b83f0951e16b895607025c2d3bad392b9759
Resolves: #30673
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/5641
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Kay Strobach
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
9 years ago[TASK] Remove unused option for "oncontextmenu"
Benjamin Mack [Thu, 6 Oct 2011 20:51:00 +0000 (22:51 +0200)]
[TASK] Remove unused option for "oncontextmenu"

The TYPO3_CONF_VARS option to enable oncontextmenu is not
needed anymore IMHO, as this option is official part of
HTML5 (previously it wasn't allowed by IE for HTML4, and a
proprietary option for Firefox (back when we introduced it
in 4.1). The patch removes any occurence of this option and
enables oncontextmneu everywhere.

Change-Id: I487accb5717af79072c704fde34018827850269d
Resolves: #30613
Releases: 4.6
Reviewed-on: http://review.typo3.org/5603
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
9 years ago[BUGFIX] Typo in the Extension Manager
Dmitry Dulepov [Mon, 10 Oct 2011 08:35:25 +0000 (11:35 +0300)]
[BUGFIX] Typo in the Extension Manager

There are multiple occurencies of the word "resource" spelled as "ressource".

Change-Id: Ib29360ec87d0070c9e7d8865dbf18b565c65784a
Resolves: #30704
Releases: 4.6
Reviewed-on: http://review.typo3.org/5662
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
9 years ago[BUGFIX] Wide split bar areas don't work in Chrome
Kay Strobach [Sun, 9 Oct 2011 17:47:04 +0000 (19:47 +0200)]
[BUGFIX] Wide split bar areas don't work in Chrome

Just a small css fix, that enables the extjs like splitbars in chrome.
This fix adds small gray spaces into the toolbar, but let the splitbars
work as expected.

It also adds a background to the splitbars to reduce the optical
difference between chrome and other browsers.

Change-Id: Ib7be667d3b5dba0797bd1c5ecb1149a83f1e0bdc
Releases: 4.6
Resolves: #27660
Reviewed-on: http://review.typo3.org/5649
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
9 years ago[TASK] Update codemirror to recent version 0.9.4
Tobias Liebig [Mon, 10 Oct 2011 12:45:50 +0000 (14:45 +0200)]
[TASK] Update codemirror to recent version 0.9.4

TYPO3 4.5 already uses the codemirror library 0.9.4. It has not yet been updated for 4.6.

Change-Id: I5ada44a795d47465025fb8e7c6de1ff61f5249d9
Resolves: #28854
Releases: 4.6
Reviewed-on: http://review.typo3.org/5670
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
9 years ago[BUGFIX] Copyright year in HTML comment is hardcoded
Andreas Wolf [Mon, 10 Oct 2011 12:05:33 +0000 (14:05 +0200)]
[BUGFIX] Copyright year in HTML comment is hardcoded

The copyright year in the HTML comment is hardcoded as 1998-2009. This
should be changed to using the constant.

Change-Id: I475f9a221acd4da4fe5376ee73d1b6bed2c3ccaa
Resolves: #30725
Releases: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/5666
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
9 years ago[TASK] Update md5 checksums for system extensions
Xavier Perseguers [Mon, 10 Oct 2011 12:48:16 +0000 (14:48 +0200)]
[TASK] Update md5 checksums for system extensions

The md5 checksums for all system extensions not integrated as submodule
should be updated.

Change-Id: I845cc4204ca3f6c334fcdb7750ba5a927a9c36f7
Resolves: #30723
Releases: 4.6
Reviewed-on: http://review.typo3.org/5664
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
9 years ago[FEATURE] Generate cHash only if needed
Popy [Thu, 21 Jul 2011 15:04:02 +0000 (17:04 +0200)]
[FEATURE] Generate cHash only if needed

tslib_cObj->typolink() generates cHash in every case, even if not
needed. Change the behavior to generate cHash only if necessary.

Change-Id: Id6a015e6bd89e9baeafd9532d4a21018adf91691
Resolves: #28352
Releases: 4.6
Reviewed-on: http://review.typo3.org/3456
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Tested-by: Popy
Reviewed-by: Xavier Perseguers
Reviewed-by: Stefan Neufeind
Reviewed-by: Benjamin Mack
Reviewed-by: Björn Pedersen
Tested-by: Xavier Perseguers
9 years ago[TASK] Increase default titleLen
Felix Kopp [Sat, 8 Oct 2011 18:25:43 +0000 (20:25 +0200)]
[TASK] Increase default titleLen

UC/titleLen in BE_USER is used to truncate data in the backend.
Increase the default value.

Change-Id: I64e2ecb1a8f4458101bc2bd395ef6c1be0ca667c
Resolves: #30670
Releases: 4.6
Reviewed-on: http://review.typo3.org/5637
Reviewed-by: Markus Klein
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
9 years ago[TASK] Update sysext form documentation
Xavier Perseguers [Sun, 2 Oct 2011 15:08:08 +0000 (17:08 +0200)]
[TASK] Update sysext form documentation

System extension 'form' does not have a proper cover page (missing title
and basic information) and still contain lots of example placeholders.

Change-Id: I2ccecc6aa7904df0501a2c91d599258148458c33
Resolves: #30709
Releases: 4.6
Reviewed-on: http://review.typo3.org/5482
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
9 years ago[BUGFIX] All fields of 'type'=>'group' are broken in IE
Jigal van Hemert [Sun, 9 Oct 2011 12:38:17 +0000 (14:38 +0200)]
[BUGFIX] All fields of 'type'=>'group' are broken in IE

The HTML multiple attribute is added for select boxes with size > 1 and
the Javascript to check this uses the multiple-property instead of the
getAttribute method which is poorly supported by various browsers.

Change-Id: Ib2ffeb2d0933a6c66e55586f1960ee7745e5623e
Fixes: #30681
Releases: 4.6
Reviewed-on: http://review.typo3.org/5646
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
9 years ago[TASK] Deprecate template::clearCacheMenu()
Xavier Perseguers [Mon, 10 Oct 2011 07:22:10 +0000 (09:22 +0200)]
[TASK] Deprecate template::clearCacheMenu()

Method clearCacheMenu() allowed to create a drop-down selector to clear
caches and possibly add options such as "save and close documents".

Modules should respect the TYPO3 backend layout and use the top toolbar
instead. In addition, this method does not provide all clear cache commands
supported by the Core.

Change-Id: I2ecb014e6ceced56d827eac4f1b683c3f245cb4b
Resolves: #30700
Releases: 4.6
Reviewed-on: http://review.typo3.org/5660
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
9 years agoRevert "[FEATURE] Speed-up Backend with CardLayout"
Xavier Perseguers [Sat, 8 Oct 2011 07:19:02 +0000 (09:19 +0200)]
Revert "[FEATURE] Speed-up Backend with CardLayout"

This reverts the use of CardLayout for the Backend.
Following commits have been squashed:

9ec94db20e803641b5be39e8ac83bf18f08789ab
5ec3779c978899659694941d79492e536aba6159
873f1dfe909f500e862744c817d029c9f05328ff
a408234cdf05ef4b69682161d8e2198db71318fd
120d38d1015117cc415482e7efec35430a5e3dfd

Change-Id: I2287b18598dbc5fe546c5ddc9aa9980d9b6a3b97
Resolves: #30645
Reviewed-on: http://review.typo3.org/5630
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
9 years ago[BUGFIX] EM: Available extension list misses icons
Steffen Gebert [Sun, 9 Oct 2011 12:11:14 +0000 (14:11 +0200)]
[BUGFIX] EM: Available extension list misses icons

The list of available extensions misses the install/uninstall icons in
Firefox 7 and Internet Explorer 9.

Change-Id: I1c5f51eb37441935ffafbd22109f56c336ba89e2
Resolves: #30369
Releases: 4.6,4.5
Reviewed-on: http://review.typo3.org/5640
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
9 years ago[TASK] TSFE - Add hook after BE_USER init to clean up workspace functionality
Benjamin Mack [Sat, 8 Oct 2011 10:17:22 +0000 (12:17 +0200)]
[TASK] TSFE - Add hook after BE_USER init to clean up workspace functionality

In order to move workspace logic out of the TYPO3 core and into
versioning/workspaces extensions, a new hook is required first.
The hook will be placed after the backend authorization, and in
a followup issue the hook will be used for further cleanups of the
TSFE issue.

Change-Id: Ica08ce0c9d3802c6e9cd1b97d91f3d7a4efebd0f
Resolves: #30646
Releases: 4.6
Reviewed-on: http://review.typo3.org/5631
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
9 years ago[TASK] Clean up EM CSS file
Steffen Gebert [Sat, 8 Oct 2011 17:00:55 +0000 (19:00 +0200)]
[TASK] Clean up EM CSS file

Change-Id: I860f6257e67c0fd6182d26d743a0d67127db224f
Resolves: #30669
Reviewed-on: http://review.typo3.org/5635
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
9 years ago[BUGFIX] EM, Error when downloading extension files
Markus Klein [Wed, 5 Oct 2011 23:56:50 +0000 (18:56 -0500)]
[BUGFIX] EM, Error when downloading extension files

Trying to download a file using the Edit Files page of the old EM
leads to a fatal error, because URL is not decoded properly.

Change-Id: I6980a0fbe8967bff0df0d8d7bc4c8f1abf53615e
Resolves: #27098
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/5578
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Stefan
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
9 years ago[BUGFIX] Don't add uid,pid if <table>.'*' is present in field list.
Bjoern Pedersen [Wed, 14 Sep 2011 12:37:51 +0000 (14:37 +0200)]
[BUGFIX] Don't add uid,pid if  <table>.'*' is present in field list.

tx_cal_tsservice uses queries with select <tablename>.* and
complex joins. This breaks due to the unconditionl adding of uid,pid
if the query is set.

Do not add uid,pid,... to field list if the field list already contains a
'*' or the repective field is in the list.

To keep the code easier to read, the sanitizing has been moved
to a seperate function.

The regexp matching is necessary to  detect fields like post_uid
(comments extension).

Change-Id: I50332c22e627ea452aaee233fdbbdf3dd426a1b6
Resolves: #29783,#30486
Releases: 4.6
Reviewed-on: http://review.typo3.org/4974
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
Reviewed-by: Christof Rodejohann
Tested-by: Christof Rodejohann
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
9 years ago[BUGFIX] PHP warning on each Extension Manager invocation
Dmitry Dulepov [Thu, 6 Oct 2011 07:48:04 +0000 (10:48 +0300)]
[BUGFIX] PHP warning on each Extension Manager invocation

Extension manager produces a PHP warning on each invocation due to
incorrect parameters passed to t3lib_div::trimExplode().

Change-Id: I7bfd31677efb3cef07c0752486071e00d9ce889e
Resolves: #30598
Releases: 4.6
Reviewed-on: http://review.typo3.org/5581
Reviewed-by: Markus Klein
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
9 years ago[TASK] Introduce Hooks to create DB fields and keys dynamically
Thomas Maroschik [Fri, 9 Sep 2011 09:56:34 +0000 (11:56 +0200)]
[TASK] Introduce Hooks to create DB fields and keys dynamically

For the purpose of modifying the database schema upon extension
installation and database compare in install tool I implemented hooks
to append sql create statements dynamically.

Hooks are registered via:

$TYPO3_CONF_VARS['SC_OPTIONS']['typo3/mod/tools/em/index.php']
['checkDBupdates'] for changes in the extension manager and has to
implement tx_em_Index_CheckDatabaseUpdatesHook interface

$TYPO3_CONF_VARS['SC_OPTIONS']['ext/install/mod/class.tx_install.php']
['checkTheDatabase'] for changes in the install tool and has to
implement tx_em_Index_CheckDatabaseUpdatesHook interface

Change-Id: I66ff195ae8f656961f5251d7722a16a554aca219
Resolves: #29594
Releases: 4.6
Reviewed-on: http://review.typo3.org/4870
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
9 years ago[BUGFIX] Prevent duplicate stdWrap for media content
Alexander Stehlik [Thu, 9 Jun 2011 22:17:14 +0000 (00:17 +0200)]
[BUGFIX] Prevent duplicate stdWrap for media content

All the standard renderers handle stdWrap themselves, so the general stdWrap
handling should be moved to the customMediaRenderer block to prevent duplicate
calls to stdWrap.

Change-Id: Ic0db017ad1d037636f1cb40994695686a2904c76
Fixes: #25277
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/2620
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
9 years ago[BUGFIX] Random miscalculations in ImageTTFBBox
Albrecht Koehnlein [Wed, 13 Jul 2011 09:47:21 +0000 (11:47 +0200)]
[BUGFIX] Random miscalculations in ImageTTFBBox

ImageTTFBBox() randomly returns incorrect negative values. Repeat the operation
a number of time if this happens to try to find the correct values.

Change-Id: I6c1548e0f8762d6c2befdd47dbfb7810b01c9508
Fixes: #21054
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/3281
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
9 years ago[BUGFIX] EM installs outdated versions of depending extensions
Steffen Gebert [Wed, 5 Oct 2011 20:11:13 +0000 (22:11 +0200)]
[BUGFIX] EM installs outdated versions of depending extensions

When installing an extension with a dependency to another extension,
which is not available on the server, EM retrieves it from TER. However,
by mistake it always retrieves the oldest version, not the newest.

Change-Id: I518cd5e4521d5ad1b578e342175f8b542ef42d02
Resolves: #29243
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/5574
Reviewed-by: Josef Florian Glatz
Tested-by: Josef Florian Glatz
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
9 years ago[BUGFIX] Typo in gifbuilder
Simon Schaufelberger [Thu, 6 Oct 2011 10:13:31 +0000 (12:13 +0200)]
[BUGFIX] Typo in gifbuilder

stdWrap features GIFBUILDER transparentBackground and reduceColors
are broken

Change-Id: Icb74191aa6e53e8ca0737ead2638c3bda5d6a7fd
Resolves: #29445
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/5590
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
9 years ago[BUGFIX] RTE: Tag attributes are reversed on save
Stanislas Rolland [Tue, 4 Oct 2011 23:58:42 +0000 (19:58 -0400)]
[BUGFIX] RTE: Tag attributes are reversed on save

Problem: When saving a content element, the order of attributes of tags
is reversed. This clutters the workspace diffs with many changes. The
problem arises in WebKit and Opera.
Solution: Reverse the order of attributes.

Change-Id: I4686dc9a1a0a7a81b06ee6b6430371e86b593817
Resolves: #29855
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/5535
Reviewed-by: Markus Klein
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
9 years ago[BUGFIX] TCEforms draws huge empty icon row which on select-fields
Benjamin Mack [Wed, 5 Oct 2011 14:14:47 +0000 (16:14 +0200)]
[BUGFIX] TCEforms draws huge empty icon row which on select-fields

Certain fields of type "select" which offer records from a
"foreign_table" will contain a huge amount of t3-icon-empty
icons just below the select box. If you have enough of them,
you even get a horizotanl scrollbar.

See some screenshots here:
http://forge.typo3.org/issues/13422

The issue is not a CSS issue, but a bug in the rendering
of such a field.

See it in action in tt_content field "sys_language". Just create
enough sys_language records so that you see the row of empty
icons being created. This wasn't this way before.

Change-Id: I664400ee6ee1d778e227b1858f79b9ed98482d0a
Resolves: #25398
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/5569
Reviewed-by: Stefan Galinski
Tested-by: Stefan Galinski
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
9 years ago[TASK] Fix CGL issue in recent saltedpasswords commit
Oliver Hader [Thu, 6 Oct 2011 10:46:06 +0000 (12:46 +0200)]
[TASK] Fix CGL issue in recent saltedpasswords commit

Change-Id: Ie4d202bc29094f3c234c1929c7fdd6c129777044
Related: #22881
Reviewed-on: http://review.typo3.org/5586
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
9 years agoRevert "[FEATURE] Indexed Search: add mySQL fulltext support"
Xavier Perseguers [Wed, 5 Oct 2011 12:56:37 +0000 (14:56 +0200)]
Revert "[FEATURE] Indexed Search: add mySQL fulltext support"

This reverts commit 6294f1fa8fd13a27ce93cfe6257d6754e8e0e1a6

This feature should be postponed to TYPO3 4.7, before feature freeze.

Change-Id: I86909cdf8e7e0133082b68000b014d3d4ad2a1ca
Reviewed-on: http://review.typo3.org/5566
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
9 years ago[BUGFIX] Removed dependency on TYPO3_MODE in saltedpasswords
Alexander Stehlik [Thu, 28 Apr 2011 13:53:28 +0000 (15:53 +0200)]
[BUGFIX] Removed dependency on TYPO3_MODE in saltedpasswords

Removed dependency on TYPO3_MODE constant in saltedpasswords which was
used to determine if the extension is enabled and which table (fe_users
or be_users) should be updated.

Since the mode is required in the init process of saltedpasswords where
the parent auth object is not available the new data in the info
array (introduced in #26410) is used.

Change-Id: I04180d283d6818b2e09d33f82036f6f88a5cb26c
Resolves: #22881
Reviewed-on: http://review.typo3.org/1778
Reviewed-by: Markus Klein
Reviewed-by: Stefan Neufeind
Reviewed-by: Steffen Ritter
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
9 years ago[TASK] Improve information in show_item.php
Soren Malling [Wed, 14 Sep 2011 12:35:52 +0000 (14:35 +0200)]
[TASK] Improve information in show_item.php

Currently the "Info" popup (show_item.php) provides information with raw
data from sys_refindex. A editor will get informations such as actual
table name from the database and a uid - but no real hint to what
records it's all about.

This patch provides information about table (name shown in list module),
field name ( as shown in TCEforms) for both references tables

Screenshots in forge issue

Change-Id: I3c053b261573eae47bc812978e3d9d23e69af2e1
Resolves: #29774
Reviewed-on: http://review.typo3.org/4971
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
9 years ago[FEATURE] Indexed Search: add mySQL fulltext support
Stefan Neufeind [Sun, 7 Aug 2011 22:44:32 +0000 (00:44 +0200)]
[FEATURE] Indexed Search: add mySQL fulltext support

Adds some minor modifications for restructuring in the pi code,
and some hooks in order to allow for other search engines to be
used.
Additionally, "indexed_search_mysql" is added to the core that
allows the mysql fulltext search with it.
Thanks to Michael Stucki for all the work!

Change-Id: I19ebc78dd0bb79297ee78104c7c6979379f2001e
Resolves: #28613
Reviewed-on: http://review.typo3.org/3925
Reviewed-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
9 years ago[BUGFIX] Email links marked as external when preceded by external link
Stanislas Rolland [Tue, 4 Oct 2011 16:29:11 +0000 (12:29 -0400)]
[BUGFIX] Email links marked as external when preceded by external link

Variable is not initialized leading to incorrect transformation
on way to RTE.

Change-Id: I38751c6c5eb56920eb1286f2d39393b3dae7ce34
Resolves: #29782
Releases: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/5537
Reviewed-by: Markus Klein
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
9 years ago[BUGFIX] meaningfulTempFilePrefix is not multi-byte safe
Steffen Gebert [Sun, 2 Oct 2011 08:23:59 +0000 (10:23 +0200)]
[BUGFIX] meaningfulTempFilePrefix is not multi-byte safe

On a utf-8 file system meaningful prefixes can contain utf-8 characters. To
prevent truncating in the middle of a multi-byte character the API functions
must be used instead of substr().

Change-Id: I760f80b8cfa2dcea8b554c24467f56b662d465d9
Resolves: #30416
Releases: 4.5, 4.6
Author: Steffen Gebert <steffen.gebert@typo3.org>
Reviewed-on: http://review.typo3.org/5479
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
9 years ago[BUGFIX] Copying directories is impossible
Andreas Wolf [Thu, 22 Sep 2011 21:05:00 +0000 (23:05 +0200)]
[BUGFIX] Copying directories is impossible

Due to a bug introduced with a refactoring of t3lib_extFileFunc, it
became impossible to copy directories. The two wrong statements (they
were not inverted though they should have been) are fixed with this
commit.

Change-Id: Iaac9cbcf30e2b73e2fd7f5df6986e1ccdf76c079
Resolves: #30213
Related: #24218
Releases: 4.6
Reviewed-on: http://review.typo3.org/5241
Reviewed-by: Markus Klein
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Tested-by: Markus Klein
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
9 years ago[BUGFIX] config.compressCss = 1 does not work
Xavier Perseguers [Tue, 4 Oct 2011 08:51:02 +0000 (10:51 +0200)]
[BUGFIX] config.compressCss = 1 does not work

TypoScript configuration option 'compressCss' is never tested and thus
does not work. Only the deprecated configuration option 'minifyCSS' is
taken into account.

Change-Id: Ic9d15bd1da84c92602a7e88283161c5b109d2939
Fixes: #30537
Releases: 4.6
Reviewed-on: http://review.typo3.org/5522
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
9 years ago[BUGFIX] RTE: Add TYPO3 version to hash of cached scripts
Stanislas Rolland [Tue, 4 Oct 2011 03:45:38 +0000 (23:45 -0400)]
[BUGFIX] RTE: Add TYPO3 version to hash of cached scripts

Problem: Fixed JS scripts may not be loaded when a new version of
TYPO3 is released. This may happen if the version of htmlArea RTE was
not incremented. This is an error-prone situation.
Solution: Add TYPO3 version to hash of cached scripts

Change-Id: I78b94620cf782423fa70b779661ddb759c4915f5
Resolves: #30534
Releases: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/5511
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
9 years ago[BUGFIX] RTE: Compressor fails on files with absolute url in FE
Stanislas Rolland [Tue, 4 Oct 2011 03:19:04 +0000 (23:19 -0400)]
[BUGFIX] RTE: Compressor fails on files with absolute url in FE

Solution: Use relative url.

Change-Id: I5bca5cd8567f9489e07ec928b9b2e046e970f212
Resolves: #30533
Releases: 4.6
Reviewed-on: http://review.typo3.org/5510
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
9 years ago[BUGFIX] Module User Settings calls deprecated methods
Xavier Perseguers [Sun, 2 Oct 2011 14:19:49 +0000 (16:19 +0200)]
[BUGFIX] Module User Settings calls deprecated methods

When opening user settings, two deprecated methods are called. The new
methods cannot be used as they combine the business logic into a single
call but do not offer the same information granularity.

Change-Id: I13df6093e61d9ba2aa730c27ac4f9b7471443f6a
Fixes: #30516
Releases: 4.6
Reviewed-on: http://review.typo3.org/5481
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
9 years ago[BUGFIX] Modify jumpTo to work with the new cardLayout
Kay Strobach [Thu, 29 Sep 2011 17:35:38 +0000 (19:35 +0200)]
[BUGFIX] Modify jumpTo to work with the new cardLayout

Modifies the jumpTo function as described in #28851
This replaces the call

top.TYPO3.Backend.ContentContainer.setUrl()

with
top.TYPO3.ModuleMenu.App.openInContentFrame()

Change-Id: I7101563ad92da7d15baaa135629e3185630ab727
Resolves: #30409
Releases: 4.6
Reviewed-on: http://review.typo3.org/5448
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Markus Klein
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
9 years ago[BUGFIX] Link to manual of sysext "form" is not displayed in EM
Xavier Perseguers [Sat, 1 Oct 2011 06:47:59 +0000 (08:47 +0200)]
[BUGFIX] Link to manual of sysext "form" is not displayed in EM

The system extension "form" comes with a manual in
typo3/sysext/form/Documentation/Manual/en/manual.sxw. As the corresponding
'docPath' key is not defined in ext_emconf.php, the link to open this
manual in not shown in the Extension Manager.

Change-Id: Ia644d3dcebdc8e8909a0a54a760825028e637104
Fixes: #30444
Releases: 4.6
Reviewed-on: http://review.typo3.org/5476
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
9 years ago[BUGFIX][SECURITY] Arbitrary TypoScript execution on system extension form
Oliver Hader [Tue, 20 Sep 2011 15:53:24 +0000 (17:53 +0200)]
[BUGFIX][SECURITY] Arbitrary TypoScript execution on system extension form

The new system extension form can be used to render custom FORM elements as
well as regular cObjects like TEXT or COA. Since the form wizard can be used
by any editor in the backend and writes data to the field bodytext, this can
also be used to execute arbitrary TypoScript without further access checks.

This change introduces two defined and allowed content elements "header" and
"textblock" that can be defined by using the form wizard. If the TypoScript
that was generated by the mentioned wizard is rendered, regular cObjects are
disabled. If the FORM or FORM_INT cObject is used directly from a TypoScript
template, all possible cObjects can still be used.

Change-Id: I573764de7583b078456e71e95ea7903b433c29db
Resolves: #30095
Releases: 4.6
Reviewed-on: http://review.typo3.org/5128
Reviewed-by: Andreas Wolf
Reviewed-by: Frederic Gaus
Tested-by: Frederic Gaus
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
9 years ago[BUGFIX] getSingleField_typeFlex doesn't respect TSconfig settings
cybercraft [Tue, 16 Aug 2011 15:37:28 +0000 (17:37 +0200)]
[BUGFIX] getSingleField_typeFlex doesn't respect TSconfig settings

Change-Id: I73bb1739d9b85320f00f4a228ade898d41a5df9c
Resolves: #29019
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/4377
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
9 years ago[TASK] Update reference from SVN to Git
Xavier Perseguers [Wed, 21 Sep 2011 15:18:53 +0000 (17:18 +0200)]
[TASK] Update reference from SVN to Git

Module About TYPO3 shows this text:
The SVN Repository and the ChangeLog can be found here.

This has to be updated to read "Git" instead of "SVN".

Change-Id: I8e708f9e47e5afa5f4528bd308ca13b7f2535364
Resolves: #30171
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/5164
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
9 years ago[BUGFIX][t3editor] typolinkEnableLinksAcrossDomains missing
Steffen Gebert [Sun, 18 Sep 2011 14:10:46 +0000 (16:10 +0200)]
[BUGFIX][t3editor] typolinkEnableLinksAcrossDomains missing

The description for config.typolinkEnableLinksAcrossDomains is missing
in the t3editor auto-completion.

Change-Id: I701773bf9f6525035754ad46e54af5716e753c47
Fixes: #27697
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/5028
Reviewed-by: Tobias Liebig
Tested-by: Tobias Liebig
9 years ago[TASK] Refactor view component of system extension form
Oliver Hader [Tue, 20 Sep 2011 14:54:49 +0000 (16:54 +0200)]
[TASK] Refactor view component of system extension form

Get rid of calling the constructor of the parent without any additional logic.

Change-Id: I5ebfe092c4174db0c75d76c1469ddff15e6c4ddf
Resolves: #30094
Releases: 4.6
Reviewed-on: http://review.typo3.org/5125
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
9 years ago[TASK] Set TYPO3 version to 4.6-dev
TYPO3 v4 Release Team [Tue, 20 Sep 2011 13:34:15 +0000 (15:34 +0200)]
[TASK] Set TYPO3 version to 4.6-dev

Change-Id: I8856a8f5dc9e59b7e6ae629f365c34cf07a7e605
Reviewed-on: http://review.typo3.org/5122
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
9 years ago[RELEASE] Release of TYPO3 4.6.0beta3
TYPO3 v4 Release Team [Tue, 20 Sep 2011 13:34:07 +0000 (15:34 +0200)]
[RELEASE] Release of TYPO3 4.6.0beta3

Change-Id: Id2eebe9044ef8c2710bcc16e2caca8d8e22eb28b
Reviewed-on: http://review.typo3.org/5121
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
9 years ago[TASK] Raise submodule pointer
TYPO3 v4 Release Team [Tue, 20 Sep 2011 13:30:42 +0000 (15:30 +0200)]
[TASK] Raise submodule pointer

Change-Id: I68120670e097815523ebd628135b90ed939c8905
Reviewed-on: http://review.typo3.org/5120
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
9 years ago[BUGFIX] check for required PHP modules in Reports module
Jigal van Hemert [Mon, 19 Sep 2011 23:48:52 +0000 (01:48 +0200)]
[BUGFIX] check for required PHP modules in Reports module

The 1-2-3 installer checks for the presence of the required PHP modules. The
Reports module needs to perform this check to catch problems in many
situations.

Change-Id: I0b19bfb4d0f6a5bdd48ba8df9869ecfc4dd3a2d6
Fixes: #30054
Releases: 4.6
Reviewed-on: http://review.typo3.org/5094
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Oliver Hader
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
9 years ago[TASK] Raise t3editor version and set state to stable
Tobias Liebig [Tue, 20 Sep 2011 08:43:08 +0000 (10:43 +0200)]
[TASK] Raise t3editor version and set state to stable

For the beta3 release of the 4.6 core, all sysexts should have the state
stable. Further the t3editor version number needs to be adjusted for the
upcoming 4.6.0 release.

Change-Id: I20c0c4dba4600c95ee2411591004542f0e5dc354
Resolves: #30077
Releases: 4.6
Reviewed-on: http://review.typo3.org/5100
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
9 years ago[BUGFIX] t3lib_Compressor breaks absolute paths in CSS
Andreas Bouche [Mon, 19 Sep 2011 09:23:20 +0000 (11:23 +0200)]
[BUGFIX] t3lib_Compressor breaks absolute paths in CSS

Adds a negative lookahead for trailing slash to the regular
Expressions in method "cssFixRelativeUrlPaths" to exclude
absolute paths from being rewritten.

Change-Id: I36355f46da53d167a9fb318228383a6181920398
Resolves: #29904
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/5051
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
9 years ago[BUGFIX] Wrong content element rendering in system extension form
Oliver Hader [Tue, 20 Sep 2011 11:53:23 +0000 (13:53 +0200)]
[BUGFIX] Wrong content element rendering in system extension form

The ability to render custom content elements in the system extension form fails.

Change-Id: Ib2ff3cc391705be458140c9a0dea0e6255948e83
Resolves: #30088
Releases: 4.6
Reviewed-on: http://review.typo3.org/5117
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
9 years ago[TASK] Strict string value handling in system extension form
Oliver Hader [Tue, 20 Sep 2011 10:56:04 +0000 (12:56 +0200)]
[TASK] Strict string value handling in system extension form

Misconfigurations in e.g. TypoScript lead to cased "Array" strings.

Change-Id: I3e161b855d7628d2b2bfc10df9dab3e9ef1d5356
Resolves: #30086
Releases: 4.6
Reviewed-on: http://review.typo3.org/5109
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
9 years ago[TASK] Missing report for deprecated setting magic_quotes_gpc
Xavier Perseguers [Tue, 20 Sep 2011 09:11:44 +0000 (11:11 +0200)]
[TASK] Missing report for deprecated setting magic_quotes_gpc

Since PHP 5.3, PHP INI setting magic_quotes_gpc is deprecated but still
defaults to "On". A report should be added to raise awareness of the
administrators.

Change-Id: Icdaeee1ea054bda1f26c5d3060e74006e7077e26
Resolves: #30079
Releases: 4.6
Reviewed-on: http://review.typo3.org/5101
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
9 years ago[BUGFIX] Improve usability of group fields
Stefan Geith [Fri, 15 Jul 2011 07:35:58 +0000 (09:35 +0200)]
[BUGFIX] Improve usability of group fields

If you set
    'disable_controls'=>'list'
you can _once_ upload an image (or file). But because of a missing Delete-Button
you never are able to change this image (or file) later.

Solution is, to add the delete Button, even if the list is not shown.
To remove even the delete button, use
    'disable_controls'=>'list,delete'

Change-Id: Ia13a9a25a64742eb49e64b7f26c085f15ca72b87
Resolves: #22679, #M14430
Releases: 4.6
Reviewed-on: http://review.typo3.org/3347
Reviewed-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
9 years ago[!!!][TASK] Deprecate usage of old Extension Manager
Xavier Perseguers [Mon, 19 Sep 2011 11:44:24 +0000 (13:44 +0200)]
[!!!][TASK] Deprecate usage of old Extension Manager

The old Extension Manager should be officially deprecated in order to
concentrate on enhancing the ExtJS-based one.

Change-Id: I6e5b2daf149faa92973f4a3f1c41aaa82cb90ae8
Resolves: #30027
Releases: 4.6
Reviewed-on: http://review.typo3.org/5057
Reviewed-by: Markus Klein
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
9 years ago[BUGFIX] Label status_configuration_PhpSafeModeEnabled is not retrieved
Xavier Perseguers [Tue, 20 Sep 2011 09:21:36 +0000 (11:21 +0200)]
[BUGFIX] Label status_configuration_PhpSafeModeEnabled is not retrieved

Wrong method is used to retrieve label status_configuration_PhpSafeModeEnabled.

Change-Id: Ie14d4d446a9d5e51e60594576a1cf3d42468f952
Fixes: #30081
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/5102
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
9 years ago[BUGFIX] EM: tx_em_Repository::addMirrors() has invalid method signature
Xavier Perseguers [Tue, 20 Sep 2011 08:12:40 +0000 (10:12 +0200)]
[BUGFIX] EM: tx_em_Repository::addMirrors() has invalid method signature

Invalid use of variable passed by reference in the method signature throws
a PHP Runtime Notice in tx_em_Repository_Utility.

Change-Id: I37f0ebb551b2d4fc06baa2c13c4c8bfcb15266ee
Fixes: #30072
Releases: 4.6
Reviewed-on: http://review.typo3.org/5099
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
9 years ago[TASK] EM: cleanup phpDoc and fix type hints
Xavier Perseguers [Tue, 20 Sep 2011 07:45:08 +0000 (09:45 +0200)]
[TASK] EM: cleanup phpDoc and fix type hints

Add type hints and fix obviously wrong references (missing "tx_"
and wrong case in class name).

Change-Id: I702ccf454d9a547a075537e36a250169442ba1e1
Resolves: #30074
Releases: 4.6
Reviewed-on: http://review.typo3.org/5098
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
9 years ago[FEATURE][t3editor] Update TypoScript reference for TYPO3 4.6
Steffen Gebert [Sun, 18 Sep 2011 18:10:40 +0000 (20:10 +0200)]
[FEATURE][t3editor] Update TypoScript reference for TYPO3 4.6

Updated the syntax completion database of t3editor to the changes of
TYPO3 4.6.

Change-Id: I798196aafd16c75f924f49c2f01389e43fb901c5
Resolves: #29995
Releases: 4.6
Reviewed-on: http://review.typo3.org/5037
Tested-by: Stephan Petzl
Tested-by: Jigal van Hemert
Reviewed-by: Björn Pedersen
Reviewed-by: Jigal van Hemert
9 years ago[BUGFIX] Initialize $currentR in analyseTypoLinks
Bjoern Pedersen [Tue, 20 Sep 2011 05:01:59 +0000 (07:01 +0200)]
[BUGFIX] Initialize $currentR in analyseTypoLinks

There are pathes through analyseTypoLinks where currentR is
 not set, it can happen that the fetchType hook gets
called with currentR=null.

This throws an API error as the fetchType interface
requires the first arg to be an array.

Change-Id: I2d517b8c57678e645c590b51d50343c42a3d36a9
Resolves: #30043
Releases: 4.6
Reviewed-on: http://review.typo3.org/5097
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
9 years ago[TASK] Clean-up PHPdoc in t3lib_div
Oliver Hader [Mon, 19 Sep 2011 23:34:09 +0000 (01:34 +0200)]
[TASK] Clean-up PHPdoc in t3lib_div

* fix some PHPdoc comments
* remove @author annotations

Change-Id: If0600e654b785683e1b394154022c650fee7dcda
Resolves: #30066
Releases: 4.6
Reviewed-on: http://review.typo3.org/5093
Reviewed-by: Björn Pedersen
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
9 years ago[BUGFIX] Undefined t3lib_utility_Mail::breakLinesForPlainEmail()
Oliver Hader [Mon, 19 Sep 2011 22:44:50 +0000 (00:44 +0200)]
[BUGFIX] Undefined t3lib_utility_Mail::breakLinesForPlainEmail()

t3lib_utility_Mail::breakLinesForPlainEmail() is not defined.

Change-Id: I7d375aa53e7ab32f8cce383afd0a458da21a80f3
Resolves: #30065
Releases: 4.6
Reviewed-on: http://review.typo3.org/5092
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
9 years ago[BUGFIX] Non-static function t3lib_TStemplate::sortedKeyList()
Oliver Hader [Mon, 19 Sep 2011 22:35:08 +0000 (00:35 +0200)]
[BUGFIX] Non-static function t3lib_TStemplate::sortedKeyList()

t3lib_TStemplate::sortedKeyList() is used in a static context
but is not declared to be static.

Change-Id: I2659730d60e750d42d7c46372067e926a0d2411d
Resolves: #30064
Releases: 4.6
Reviewed-on: http://review.typo3.org/5091
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
9 years ago[TASK] Refactor code of new form system extension
Oliver Hader [Mon, 19 Sep 2011 18:42:28 +0000 (20:42 +0200)]
[TASK] Refactor code of new form system extension

* remove superfluous __construct() methods
* fix PHPdoc comments and add type hints
* remove unused classes
* fix CGL issues

Change-Id: Ie859ea0a54a8234b5c5c8d6d16f0be6c947a9bc5
Resolves: #30046
Reviewed-on: http://review.typo3.org/5077
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
9 years ago[BUGFIX] Some methods of SC_mod_web_perm_ajax should be static
Xavier Perseguers [Mon, 19 Sep 2011 22:20:29 +0000 (00:20 +0200)]
[BUGFIX] Some methods of SC_mod_web_perm_ajax should be static

Fix the method signatures that are statically called throughout the Core.

Change-Id: Ic415b271eb66950de9dbaf1a82b130112b026f35
Fixes: #30063
Releases: 4.6
Reviewed-on: http://review.typo3.org/5090
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
9 years ago[BUGFIX] Invalid method signature for t3lib_pageTree::init()
Xavier Perseguers [Mon, 19 Sep 2011 22:11:17 +0000 (00:11 +0200)]
[BUGFIX] Invalid method signature for t3lib_pageTree::init()

Method t3lib_treeView::init() is not properly overriden in subclasses.

Change-Id: Ia39eb8ba775e1f217fb77f402dd8f2ab4e1d24ae
Fixes: #30062
Releases: 4.6
Reviewed-on: http://review.typo3.org/5089
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
9 years ago[BUGFIX] Invalid method signature for t3lib_tree_extdirect_Node::toArray()
Xavier Perseguers [Mon, 19 Sep 2011 22:02:51 +0000 (00:02 +0200)]
[BUGFIX] Invalid method signature for t3lib_tree_extdirect_Node::toArray()

Method toArray() from t3lib_tree_Node is not properly overriden in subclasses.

Furthermore, many phpDoc comments are wrongly returning void instead of bool.

Change-Id: I99bea296df305673d5c111fc9e5b92ea42599c5f
Fixes: #30060
Releases: 4.6
Reviewed-on: http://review.typo3.org/5088
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
9 years ago[BUGFIX] Invalid method signature for ext_posMap::onClickInsertRecord()
Xavier Perseguers [Mon, 19 Sep 2011 21:54:37 +0000 (23:54 +0200)]
[BUGFIX] Invalid method signature for ext_posMap::onClickInsertRecord()

Invalid method override signature.

Change-Id: Ifb82ee48c8a83c626004cf67e6529f386d8edb40
Fixes: #30061
Releases: 4.6
Reviewed-on: http://review.typo3.org/5087
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
9 years ago[BUGFIX] Methods of tx_em_Database should be static
Xavier Perseguers [Mon, 19 Sep 2011 21:40:32 +0000 (23:40 +0200)]
[BUGFIX] Methods of tx_em_Database should be static

Methods of class tx_em_Database miss the static keyword and, sometimes,
the visibility as well.

Change-Id: I477ca961ae9dc6fc456c3e90fd8f0871be2cc145
Fixes: #30059
Releases: 4.6
Reviewed-on: http://review.typo3.org/5086
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers