Packages/TYPO3.CMS.git
3 months ago[BUGFIX] Don't make clearable button tabbable 94/61794/3
Andreas Fernandez [Tue, 24 Sep 2019 12:39:40 +0000 (14:39 +0200)]
[BUGFIX] Don't make clearable button tabbable

The clearable button now has a `tabindex="-1"` attribute to disallow
focussing it via <TAB>.

Resolves: #89248
Related: #89215
Releases: master
Change-Id: I8bd637461d7c1e3b8ff51aa3a588a497787b0185
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61794
Tested-by: Nicole Cordes <typo3@cordes.co>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
3 months ago[TASK] Add scroll-padding to .module-body 70/61770/4
Harald Atteneder [Sat, 21 Sep 2019 16:59:33 +0000 (18:59 +0200)]
[TASK] Add scroll-padding to .module-body

This fixes the small annoyance when expanding an item in the
TypoScript Object Browser and the iframe reloads and scrolls to the
expanded item while the doc-header hides this item. CSS scroll-padding
solves this problem for modern browsers.

Resolves: #89217
Releases: master,9.5
Change-Id: If4b71c7fb6ba003b23cdd79460540f0bf335abb8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61770
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
3 months ago[FEATURE] Add Cache Preset to Maintenance Area Settings 75/61075/5
Benni Mack [Mon, 17 Jun 2019 15:05:27 +0000 (17:05 +0200)]
[FEATURE] Add Cache Preset to Maintenance Area Settings

On various mass hostings, it is sometimes more useful to switch
to file-based caching to speed up performance, as
SSD usages has improved.

In order to help non-experts to set up proper caching for their
most common use-cases, a Preset in the "Maintenance -> Settings"
for Caching has been added.

Resolves: #89229
Releases: master
Change-Id: Icd953937cce36d793b6c16ee518449049fca31df
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61075
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 months agoRevert "[FEATURE] PHP API for backend JavaScript notifications" 51/61751/4
Andreas Fernandez [Tue, 24 Sep 2019 10:38:24 +0000 (12:38 +0200)]
Revert "[FEATURE] PHP API for backend JavaScript notifications"

This reverts commit deca7432d45225d1f4c00bd8fd7f05e3d7a0773d.

The PHP API is considered insecure as whole blocks of JavaScript are
manually written into the PageRenderer.

Change-Id: I8cd69cb9238b187ed6d6343548adf03a4c2bb464
Resolves: #89246
Reverts: #89066
Releases: master
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61751
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
3 months agoRevert "[BUGFIX] Generate notification action on rendering" 50/61750/4
Andreas Fernandez [Tue, 24 Sep 2019 10:35:16 +0000 (12:35 +0200)]
Revert "[BUGFIX] Generate notification action on rendering"

This reverts commit 78955a67c7da23c839757b4509f11c637e5e88bb.

The approach uses `eval` that is considered insecure.

Change-Id: I6f6f1b7040dc9ed6b93c115983a2124752ae0327
Resolves: #89247
Reverts: #89173
Releases: master
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61750
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
3 months ago[FEATURE] Show configuration of USER_INT objects in adminpanel 45/61045/4
c.essl [Sun, 16 Jun 2019 09:20:05 +0000 (11:20 +0200)]
[FEATURE] Show configuration of USER_INT objects in adminpanel

Introduces a new panel in the info module of the admin panel which lists
the basic configuration of each USER_INT present on the current page.

Resolves: #88441
Releases: master
Change-Id: Iedc4112c7ff961995d70622beec1c7256f78c1ce
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61045
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
3 months ago[TASK] Remove unused signal/slot in EM site setup 91/61791/2
Benni Mack [Tue, 24 Sep 2019 08:56:44 +0000 (10:56 +0200)]
[TASK] Remove unused signal/slot in EM site setup

A new signal was added with https://review.typo3.org/c/Packages/TYPO3.CMS/+/61554
which has no effect and with the provided information
is not needed. If necessary, a new PSR-14 event should
 be invoked at that place.

The patch removes the signal again.

Resolves: #89242
Related: #89010
Releases: master
Change-Id: I383e39ced7d9b88303aa13a98c48ca5242e82739
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61791
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
3 months ago[FEATURE] Add email address to installation process 89/60889/7
Benni Mack [Thu, 6 Jun 2019 05:42:49 +0000 (07:42 +0200)]
[FEATURE] Add email address to installation process

New installations now ask for the email address as well, so
this can be used later on to e.g. notify the admin if somebody
logged-in (Warning email address).

The same feature is available in the maintenance module of
the Install Tool in the "Create Administrative User" card.

Resolves: #89227
Releases: master
Change-Id: Iafca7043543d5e299fb121d96d9b3b9caa375bc9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60889
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
3 months ago[BUGFIX] Generate valid export url for files in filelist 03/61503/3
Andreas Fernandez [Fri, 16 Aug 2019 08:01:14 +0000 (10:01 +0200)]
[BUGFIX] Generate valid export url for files in filelist

Since FAL is in place, the export url for files generated in the
clipboard is broken as it takes the full file identifier. Previously it
took the physical file path, the code was never adjusted to be
compatible with FAL.

This patch now resolves the file identifier and generates proper
arguments for export.

Resolves: #88969
Releases: master, 9.5, 8.7
Change-Id: I6599114b19b9d173f88db7beefabe39e90520899
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61503
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
3 months ago[TASK] Remove unused property in Extbase DataMapper 90/61790/2
Benni Mack [Tue, 24 Sep 2019 07:42:05 +0000 (09:42 +0200)]
[TASK] Remove unused property in Extbase DataMapper

Extbase's DataMapper added a $pageSelectObject (PageRepository) as property
in 2009 but it was never used due to further abstractions into the DbBackend
of Extbase.

The protected property is unneeded and can safely be removed,
as it is never initialized or used since at least TYPO3 4.5.

Resolves: #89238
Releases: master
Change-Id: I9f88b6421e20f23eeeccd7861082fb169ebbce98
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61790
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 months ago[FEATURE] Provide implementation for PSR-18 HTTP Client 67/61567/8
Benjamin Franzke [Tue, 27 Aug 2019 12:49:19 +0000 (14:49 +0200)]
[FEATURE] Provide implementation for PSR-18 HTTP Client

The implementation of the PSR-18 ClientInterface is provided
as an adapter to the existing GuzzleHTTP Client. Therefore
existing configuraton settings will be reused.

As our current Guzzle wrapper (RequestFactory->request)
has support for passing custom guzzle per-request options,
we do not deprecate this method but add the PSR-18 implementation
as a more generic alternative.

Once GuzzleHTTP supports PSR-18 natively we can (and will)
drop our adapter and point to Guzzles native implementation
in our dependency injection configuration.
Therefore, this adapter is marked as internal and extensions
are being instructed to depend on the PSR-18 interfaces
only.

composer require psr/http-client:^1.0

Releases: master
Resolves: #89216
Change-Id: I0f2c81916a2f5e4b40abd6f0b146440ef155cf00
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61567
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[FEATURE] Create sites on page creation 58/61658/20
Andreas Fernandez [Tue, 10 Sep 2019 13:18:25 +0000 (15:18 +0200)]
[FEATURE] Create sites on page creation

A new hook is introduced that creates a site configuration when a new
page on root level is created. This takes effect for pages of type
"default", "link" and "shortcut".

To reduce the likelihood for conflicts, a shortened MD5 hash of the page
id appended to the site identifier.

Resolves: #89142
Releases: master
Change-Id: Ibe2957e3789f2a165e36949ae5fb4fa2a1a572df
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61658
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Remove PhantomJS dependencies 87/61787/3
Andreas Fernandez [Mon, 23 Sep 2019 16:56:51 +0000 (18:56 +0200)]
[TASK] Remove PhantomJS dependencies

This patch removes extraneous npm packages. They were
required for PhantomJS and are currently unused.

Executed command:

  yarn remove karma-phantomjs-launcher phantomjs-prebuilt

Resolves: #89233
Releases: master
Change-Id: Ic754873a01a687da6b133702c7a682da349d859a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61787
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Add functional tests for linkvalidator 12/61712/12
Sybille Peters [Mon, 16 Sep 2019 16:10:54 +0000 (18:10 +0200)]
[TASK] Add functional tests for linkvalidator

Resolves: #82850
Releases: master, 9.5
Change-Id: I05dc5e83199d58b23a8da6e625d1b9557b5c57a2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61712
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Update JavaScript unit test packages 81/61781/3
Andreas Fernandez [Mon, 23 Sep 2019 12:40:44 +0000 (14:40 +0200)]
[TASK] Update JavaScript unit test packages

Executed commands:

  yarn upgrade --pattern jasmine --latest
  yarn upgrade --pattern karma --latest

Resolves: #89228
Releases: master
Change-Id: Id4f32730cbbebe74e07101bb1fed8e420d4a67aa
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61781
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
4 months ago[TASK] Update Fluid engine to 2.6.4 42/61642/8
Claus Due [Sun, 8 Sep 2019 14:13:51 +0000 (16:13 +0200)]
[TASK] Update Fluid engine to 2.6.4

Addresses the following issues:

* Fixes an annotation that makes phpdocumentor/reflection-docblock
  throw exceptions in TYPO3v10.
* Removes deprecation warning from composer due
  to incorrectly cased package name.
* Fixes issues with binary characters in compiled templates.
* Supports overloaded methods for variable extraction.
* Avoids signature issues with CompileWithRenderStatic.
* Works around PCRE regression issues on affected platforms.

Change-Id: I2b766ccc9bf3eaae77b1dfc1a73e9acc2a88d8a9
Resolves: #89110
Releases: master, 9.5, 8.7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61642
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Use SiteFinder directly in SlugHelper 78/61778/3
Benni Mack [Mon, 23 Sep 2019 11:27:58 +0000 (13:27 +0200)]
[TASK] Use SiteFinder directly in SlugHelper

Handling Sites via SiteMatcher is not necessary anymore,
as the SiteFinder does all the logic already, except for flushing
the rootline caches. The main reason (moving pages within DataHandler)
can be managed by adding this functionality into SlugHelper directly.

Resolves: #89225
Releases: master
Change-Id: I0e3fe151ebb99a154900f3335bef4a1db92ca4bf
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61778
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
4 months ago[BUGFIX] Do not assign variables to removed property 80/61780/4
Benni Mack [Mon, 23 Sep 2019 11:56:13 +0000 (13:56 +0200)]
[BUGFIX] Do not assign variables to removed property

The new IPlocker (supporting IPv6) also removed the public property
AbstractUserAuthentication->lockIP.

However, the original assignments are still in place, as they were forgotten
before the 10.0 release.

The change removes the two assignments.

Resolves: #89226
Releases: master
Change-Id: I9fb7bc2c5dbf523a13e6ba6faa0cd51fe3beffdc
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61780
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
4 months ago[TASK] Deprecate jquery.clearable 58/61758/9
Andreas Fernandez [Thu, 19 Sep 2019 09:00:08 +0000 (11:00 +0200)]
[TASK] Deprecate jquery.clearable

To slim down the usage of jQuery even further a bit, the jQuery plugin
`jquery.clearable` has been marked as deprecated. A new plugin
`TYPO3/CMS/Backend/Input/Clearable` may be used instead.

The new plugin extends the prototype of `HTMLInputElement` by a new
function called `clearable`.

Resolves: #89215
Releases: master
Change-Id: Id6e64b983561af0327cc3308499756b8fafbc883
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61758
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Adapt flexform container EventListener registration 56/61756/5
Henrik Elsner [Wed, 18 Sep 2019 15:24:19 +0000 (17:24 +0200)]
[BUGFIX] Adapt flexform container EventListener registration

Enables the functionality to add an inline element inside of
an unsaved inline element

Resolves: #89201
Releases: master, 9.5, 8.7
Change-Id: I077c75326b021b9bacc53d10c9584659391726ce
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61756
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
4 months ago[BUGFIX] Remove double json_decode call 22/61622/3
Devid Messner [Wed, 4 Sep 2019 14:57:57 +0000 (16:57 +0200)]
[BUGFIX] Remove double json_decode call

Avoids an exeption about incompatible type to the call, caused by double encoding.

Resolves: #89081
Releases: master, 9.5

Change-Id: Ia974227f0e9ca68a8f37a0e205bda1f27f015c7f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61622
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
4 months ago[TASK] Incorporate ES 6 features 49/61649/7
Andreas Fernandez [Mon, 9 Sep 2019 14:37:43 +0000 (16:37 +0200)]
[TASK] Incorporate ES 6 features

Since the build chain can generate ES6, the TypeScript code should
incorporate these changes.

Namely, this patch changes:
- Use native NodeList over arrays generated by Array.from() where
  possible
- Use explicit string search functions instead of indexOf

Resolves: #89118
Releases: master
Change-Id: I6e03ade35c545ece05ecca222cd1fde876fc22d4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61649
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Add missing closing quote in doc comment 75/61775/3
Naderio [Mon, 23 Sep 2019 10:03:51 +0000 (10:03 +0000)]
[TASK] Add missing closing quote in doc comment

Added missing closing quote in cObjGetSingle-docblock

Releases: master
Resolves: #89224
Change-Id: If35976e5e2236fbf6209349c9ee346f52f5d3ac3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61775
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Remove obsolet PHPDoc parts 73/61773/5
Oliver Bartsch [Sun, 22 Sep 2019 15:38:29 +0000 (17:38 +0200)]
[TASK] Remove obsolet PHPDoc parts

The PHPDocs of GeneralUtility::_GET and GeneralUtility::_POST
have been revised. In detail, statements have been removed
that those methods would strip slashes and should `ALWAYS` be used.

Resolves: #89221
Releases: master, 9.5
Change-Id: Ic05f31998b8af5205cd6847c403b95172eeb709a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61773
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
4 months ago[TASK] Improve PHPDoc of GeneralUtility::_GP 74/61774/3
Oliver Bartsch [Sun, 22 Sep 2019 18:28:01 +0000 (20:28 +0200)]
[TASK] Improve PHPDoc of GeneralUtility::_GP

The PHPDoc of GeneralUtility::_GP has been revised.
In detail, the outdated and misleading part about security
has been removed and the return annotation now also
includes NULL as possible return type.

Resolves: #89222
Releases: master, 9.5
Change-Id: Iccfbfc43b15b28c035f5e93805d41e858b816d6a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61774
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
4 months ago[BUGFIX] Fix tag consistency of FSC DropIn partials 63/61763/2
Claus Due [Thu, 19 Sep 2019 18:38:51 +0000 (20:38 +0200)]
[BUGFIX] Fix tag consistency of FSC DropIn partials

Fixes a missing closing tag which makes (X)HTML
validation fail and causes Fluid 3.0 to report a
parsing error in the templates.

Resolves: #89210
Releases: master, 9.5, 8.7
Change-Id: Ia8fe59df2f92761ba44ac649bd6907fa2c58ab66
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61763
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
4 months ago[BUGFIX] Avoid using non-API functionality for workspaces 83/60483/9
Benni Mack [Tue, 16 Apr 2019 05:38:03 +0000 (07:38 +0200)]
[BUGFIX] Avoid using non-API functionality for workspaces

BackendUser has some tight integration with workspaces, however
it also contains some legacy non-workspace related functionality
whereas checks against $pid is done for branch versioning.

This has been removed and some new internal methods are
now used with a clearer return value and internal code structure.

Resolves: #88155
Releases: master
Change-Id: I7b902085e53bd6bd8a8522df4815d31482468102
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60483
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Achim Fritz <af@achimfritz.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[DOCS] Remove unused include file from EXT:form docs 69/61769/3
Frank Naegler [Fri, 20 Sep 2019 10:28:45 +0000 (12:28 +0200)]
[DOCS] Remove unused include file from EXT:form docs

With #89129 the containerClassAttribute.rst include for Fieldset
was removed but the file which is now unused was not removed.

Reaolves: #89214
Related: #89129
Releases: master
Change-Id: Ib0055bcf3f8f9d256b50c167b37d454ebed145b2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61769
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
4 months ago[DOCS] Remove unused Fieldset property in documentation of EXT:form 60/61660/7
Elias Häußler [Tue, 10 Sep 2019 13:43:08 +0000 (13:43 +0000)]
[DOCS] Remove unused Fieldset property in documentation of EXT:form

The "containerClassAttribute" property is not respected by elements of
type "Fieldset" as the partial "Field/Field" takes care of its
rendering. Therefore, it has been removed from the official documentation
to avoid confusions.

Releases: master, 9.5, 8.7
Resolves: #89129
Change-Id: I5f2ed92ad2477a0eed20dcd8ad402e7894e568ee
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61660
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
4 months ago[DOCS] Added missing brackets 54/61754/3
someplace53 [Wed, 18 Sep 2019 13:11:40 +0000 (13:11 +0000)]
[DOCS] Added missing brackets

Since includeCssFiles and includeJsFiles are registered as arrays,
the given types in the example should be arrays, too.

Releases: master, 9.5
Resolves: #89200
Change-Id: Ic9ba160deb01bd4f2f86484ff2d8da517d417fc1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61754
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
4 months ago[FEATURE] Provide implementation for PSR-17 HTTP Message Factories 58/61558/17
Benjamin Franzke [Mon, 26 Aug 2019 12:11:18 +0000 (14:11 +0200)]
[FEATURE] Provide implementation for PSR-17 HTTP Message Factories

Support for PSR-17 HTTP Message Factories has been added.

PSR-17 HTTP Factories are intended to be used by PSR-15 request handlers
in order to create PSR-7 compatible message objects.

Classes may use dependency injection to use any of the available PSR-17
HTTP Factory interfaces.

The Request/Response base class (Message) is adapted to be able to lazily
initialize a stream when getBody() is called.
This is done as the PSR (Stream)RequestFactoryInterface does not allow
to control Stream properties. Therefore it is a performance
optimization to defer initialization. It is likely, that a new
Stream will be added to a Request with withStream() anyway.
(Which would mean resources for the intermediate stream would have
been wasted)

Furthermore some DocBlocks are adapted to reflect the variadic
UriInterface/StreamInterface parameters that are already handled in
code but were not documented. These cases are needed/required
by the PSR-17 factory implementation now.

composer require psr/http-factory:^1.0

Releases: master
Resolves: #89018
Change-Id: Ie6b9d865679bbf6f5d3d030b0ed1a3f277c47a3d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61558
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
4 months ago[BUGFIX] Fix wrong PSR-11 related deprecation messages in ObjectManager 60/61760/3
Benjamin Franzke [Thu, 19 Sep 2019 08:34:23 +0000 (10:34 +0200)]
[BUGFIX] Fix wrong PSR-11 related deprecation messages in ObjectManager

Due to an inverse condition the deprecation message that constructor
arguments shoud *not* be passed was triggered when actually no arguments
where passed.

Also fix the generation of the related non-object exception, the
string concatenation used a wrong variable name.

Change-Id: Icb387b666d2bf249e34eb7bae2d1ed9b3382a8b4
Releases: master
Resolves: #89207
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61760
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
4 months ago[FEATURE] Translate Indexed Search Configuration Titles 46/61446/3
Benni Mack [Mon, 5 Aug 2019 15:25:04 +0000 (17:25 +0200)]
[FEATURE] Translate Indexed Search Configuration Titles

Allows to override index_config titles that are
rendered in the dropdown of the Form in Indexed Search
and as headline when a configuration is selected.

Resolves: #9070
Releases: master
Change-Id: I1b013af529ba4985266535b2955bf4a32bba9ebd
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61446
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Daniel Gorges <daniel.gorges@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.com>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Show TCAdefaults configuration in info module 62/61762/3
Georg Ringer [Thu, 19 Sep 2019 15:10:11 +0000 (17:10 +0200)]
[TASK] Show TCAdefaults configuration in info module

The info module must show potential TSconfig values of TCAdefaults.

Resolves: #89196
Releases: master, 9.5
Change-Id: I0ac8c90517a4ba5a9ab1f7c397f8ea5a964ae273
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61762
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Josef Glatz <josefglatz@gmail.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Josef Glatz <josefglatz@gmail.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
4 months ago[BUGFIX] Handle base paths with mixed FQDN and "/" 50/61650/7
Benni Mack [Mon, 9 Sep 2019 15:24:53 +0000 (17:24 +0200)]
[BUGFIX] Handle base paths with mixed FQDN and "/"

If a site has "/" as its entrypoint but the languages
have FQDNs or subdomains or a mixture between subdomain
the base without domain always gets found and the subdomains
are not considered.

Currently this situation is handled in
  SiteMatcher->getRouteCollectionForAllSites()
which does not fit a certain scheme if there is a mixture.

This change corrects this and adds tests to handle any cases:

- just / as base, and then /de and /en as language base
- just / as base, and then subdmoains or full domains+path as language base
- a full URL as base, and then path parts as language base
- a full URL as base and then full URLs + subdomains as language base
- Also check for http and http variants.

Resolves: #89183
Releases: master, 9.5
Change-Id: If570118ac371e1a1589f064605c0176a53220f0f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61650
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Daniel Gorges <daniel.gorges@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.com>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Update @typo3/icons to 1.10.0 59/61759/2
Benjamin Kott [Thu, 19 Sep 2019 11:33:58 +0000 (13:33 +0200)]
[TASK] Update @typo3/icons to 1.10.0

Executed tasks:
  cd Build
  yarn add -D @typo3/icons@1.10.0
  yarn build

Resolves: #89206
Releases: master
Change-Id: I47ae87e522acdce57e07804c46e3b8b8f29bc848
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61759
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
4 months ago[DOCS] Remove eliminated scheduler configuration setting 57/61757/3
Chris Müller [Wed, 18 Sep 2019 19:20:53 +0000 (21:20 +0200)]
[DOCS] Remove eliminated scheduler configuration setting

Remove the eliminated extension configuration option "enableBELog" in
the documentation.

Additionally the unused language setting for extension configuration
"scheduler.config.listShowTaskDescriptionAsHover" was deleted.

Resolves: #89202
Relates: #83866
Releases: master, 9.5
Change-Id: I6b2b343d1a07f158edf72803acd791ff891c6a32
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61757
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
4 months ago[BUGFIX] Ensure FormEngine IRRE handles relations in workspace 90/60890/10
Benni Mack [Thu, 6 Jun 2019 06:44:19 +0000 (08:44 +0200)]
[BUGFIX] Ensure FormEngine IRRE handles relations in workspace

FormEngine does not show and handle IRRE records when they are
deleted (connected records from the live workspace are shown).

When removal and refactoring of code in this ares was done for
v9, "too much" code got removed. Which is why workspace overlays
are not handled properly anymore.

In addition, the ElementInformationController now correctly
resolves a workspace record when finding the pageInfo and access.

Resolves: #88502
Related: #82634
Releases: master, 9.5
Change-Id: Ib2d70ffa92c78752626b43ec5012d9dba036e7b8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60890
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Achim Fritz <af@achimfritz.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Achim Fritz <af@achimfritz.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
4 months ago[BUGFIX] Use correct log level integer / strings in admin panel 93/61693/3
Susanne Moog [Thu, 12 Sep 2019 07:57:09 +0000 (09:57 +0200)]
[BUGFIX] Use correct log level integer / strings in admin panel

Since #88799 the wrong log levels were used for configuration and
level comparison (strings where ints were required, ints where strings
should have been). The patch streamlines the use of the log levels to
re-introduce a working log module.

Resolves: #89155
Releases: master
Change-Id: I1faf2b8df77fd6e412eea7cb63180026e6c19969
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61693
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[BUGFIX] Fix comment typo in Check.php 52/61752/2
Christian Eßl [Wed, 18 Sep 2019 10:55:42 +0000 (12:55 +0200)]
[BUGFIX] Fix comment typo in Check.php

Fixes a small comment typo in the checkGdLibJpgSupport function,
replacing "jgp" with "jpg".

Resolves: #89198
Releases: master, 9.5
Change-Id: I9c0cafda7a000b5e0d801cb12af361f2c70467d3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61752
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
4 months ago[BUGFIX] Re-apply sorting after workspaces in FileRepository 14/61714/4
Benni Mack [Tue, 17 Sep 2019 06:57:26 +0000 (08:57 +0200)]
[BUGFIX] Re-apply sorting after workspaces in FileRepository

When in workspace mode, overlays are made but if there is
a different sorting (reordering of items in a workspace), the
FileRepository does not consider this, as the workspace
overlays are applied later-on.

As this patch is making Workspaces with FAL finally usable, and is
non-intrusive, and fixes a minor data / repository
issue, I consider backporting this down to 8.7 as well.

Resolves: #71973
Releases: master, 9.5, 8.7
Change-Id: Ie230558242e3ebfef541e8eb969fa21dd15708af
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61714
Tested-by: Achim Fritz <af@achimfritz.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Achim Fritz <af@achimfritz.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
4 months ago[BUGFIX] Generate notification action on rendering 06/61706/7
Andreas Fernandez [Sat, 14 Sep 2019 08:05:14 +0000 (10:05 +0200)]
[BUGFIX] Generate notification action on rendering

Due to scoping issues if a notification is generated in an iframe, the
actions are now generated when the notification is rendered.

This requires a change how the payload is passed to the notification,
instead of the action instance it now contains the action type and the
callback. The action instance is generated by a factory class.

To bypass issues with browser's garbage collection that kicks in when an
iframe changes, the callback methods are stringified and immediately
recovered by eval().

Resolves: #89173
Releases: master
Change-Id: I45624a26bad1527f9d6222ad10e1f9a1384ee07e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61706
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
4 months ago[BUGFIX] Set proper default value for unavailable redirect report 05/61705/2
Andreas Fernandez [Sat, 14 Sep 2019 07:03:26 +0000 (09:03 +0200)]
[BUGFIX] Set proper default value for unavailable redirect report

In case the redirect integrity check has never been executed before, the
code now uses an empty array as fallback value to fix issues with wrong
variable types.

Additionaly, a repeated typo has been fixed.

Resolves: #89172
Releases: master
Change-Id: Ib3f2815ad355dc9d8161c845f3b0dba9efc07ce9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61705
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Michael Schams <typo3@2018.schams.net>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[TASK] Remove further evaluations of pid=-1 69/61669/6
Benni Mack [Thu, 12 Sep 2019 05:37:54 +0000 (07:37 +0200)]
[TASK] Remove further evaluations of pid=-1

There are a few spots in TYPO3 Core where manual
queries are built, and the WorkspaceRestriction
would just work as dropin now.

In addition, some few changes are adapted to check
for t3ver_oid instead of "pid".

Resolves: #89157
Releases: master
Change-Id: I9d3a6f132ba20c0c603a6ab1664adf9d1dc06fd9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61669
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Achim Fritz <af@achimfritz.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
4 months ago[TASK] Edit Site Settings in Site Module 61/61661/22
Susanne Moog [Fri, 13 Sep 2019 07:36:20 +0000 (09:36 +0200)]
[TASK] Edit Site Settings in Site Module

Extensions can ship their own site settings default values,
that get provided to all available site configurations.

A UI in sites module enables the user to edit all values
from any active extension in the system. Inactive extension
settings will be preserved in the site settings for later recovery.

Resolves: #89134
Releases: master
Change-Id: I6bb4335460ccb5f6b0f609f4f0876507804d5821
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61661
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
4 months ago[BUGFIX] Keep workspace ID when discarding versioned records 71/61671/15
Oliver Hader [Thu, 12 Sep 2019 09:44:56 +0000 (11:44 +0200)]
[BUGFIX] Keep workspace ID when discarding versioned records

When a record was modified in a workspace, and then discarded, TYPO3 previously
set the t3ver_wsid to "0", which basically meant "we release it to live workspace
as a offline version with pid=-1".

However, this turns out to be ugly, as this information is then floating in live workspace,
without any information where this record was from.

Instead, "discarding versioned records" now keeps the t3ver_wsid=X, and just marks
the versioned record as "deleted" - or removes it completely if the database table
does not support to mark records as deleted.

As a result, there will be no records in live workspace anymore with "pid=-1" in the future
anymore. To remove any "old" discarded records, an upgrade wizard will follow
in a followup patch.

Resolves: #89166
Releases: master
Change-Id: I8ccab3cd2053c27d9b0ecd9f171a83b9097f29dd
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61671
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Daniel Gorges <daniel.gorges@b13.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[BUGFIX] Disallow phpdocumentor/reflection-docblock >= 4.3.2 02/61702/7
Andreas Fernandez [Fri, 13 Sep 2019 10:09:09 +0000 (12:09 +0200)]
[BUGFIX] Disallow phpdocumentor/reflection-docblock >= 4.3.2

The package phpdocumentor/reflection-docblock introduces major regressions
starting with 4.3.2 that leads to getting nullable compound types (e.g.
`?string|int`) parsed completely wrong, which currently also breaks in
symfony/property-info.

Also, it became stricter about type annotations which currently collides
with Fluid.

For this reason, the package is marked as conflicting starting with
version 4.3.2.

Resolves: #89167
Releases: master
Change-Id: Ife9d14c01de5bea2179dafc572820f292039a202
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61702
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Check for plain integer values in QueryGenerator::cleanInputVal() 70/61670/6
Andreas Fernandez [Thu, 12 Sep 2019 06:22:42 +0000 (08:22 +0200)]
[BUGFIX] Check for plain integer values in QueryGenerator::cleanInputVal()

Incoming field values are now also checked for being plain integers to
be able to handle timestamps properly.

Resolves: #89154
Related: #84588
Releases: master, 9.5
Change-Id: I220096faa563b3700eceb8a85839eed2a70d2170
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61670
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Strip tags in prepared label from suggest wizard 98/61698/2
Elias Häußler [Thu, 12 Sep 2019 14:17:35 +0000 (16:17 +0200)]
[BUGFIX] Strip tags in prepared label from suggest wizard

Labels of records provided by the suggest wizard should not contain
any HTML content as they are directly applied as <option> element
to the <select> element of the appropriate database field in backend
forms.

As the suggest wizard may generate such labels in case of stripped
record titles, this commit strips away all HTML tags in order to apply
the labels in a clean way to the appropriate element in the DOM.

Resolves: #89161
Releases: master, 9.5
Change-Id: Ibe5bb81f79c663cf7cfc30bbe896fdf4492c4c3c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61698
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[TASK] Move configuration viewHelper into sysext:core 97/61697/6
Anja Leichsenring [Thu, 12 Sep 2019 14:03:16 +0000 (16:03 +0200)]
[TASK] Move configuration viewHelper into sysext:core

The view helper will provide form fields for extension configuration
based on ext_template.txt files in install tool.

A similar functionality is to be implemented into the site module,
so the view helper is moved into sysext:core to be used from
both places.

Resolves: #89160
Releases: master
Change-Id: I76dfefadcbe44271bed445717861cc01835ca793
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61697
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
4 months ago[FEATURE] Add correlation_id for RecordHistory 65/61665/7
Frank Naegler [Wed, 11 Sep 2019 07:36:17 +0000 (09:36 +0200)]
[FEATURE] Add correlation_id for RecordHistory

To allow a rollback for a set of RecordHistory entries, this patch
adds a correlation_id to allow a kind of grouping of changes.
The rollback itself is not part of this patch.

Resolves: #89143
Releases: master
Change-Id: Id1c4aee675805e2f00639072cf324b582decaa6b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61665
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[BUGFIX] Select available languages based on Site configuration 64/61664/4
Benni Mack [Wed, 11 Sep 2019 05:13:06 +0000 (07:13 +0200)]
[BUGFIX] Select available languages based on Site configuration

When the translation wizard in the Page Module
fetches translations and possible languages, it
queries the sys_language records - however since SiteMatcher/SiteFinder
already does this on a per-page level (currently via TranslationConfigurationProvider)
the LocalizationRepository can find allowed language IDs
directly instead of querying the sys_language table, which might
contain 20 languages, but only 2 are available for this pagetree.

Resolves: #89140
Releases: master, 9.5
Change-Id: I8e755e4cc3bdbae7dc4dd71319b8ffc8120200a4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61664
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[TASK] Clean up DataHandlerHook in Workspaces 62/61662/6
Benni Mack [Tue, 10 Sep 2019 19:05:31 +0000 (21:05 +0200)]
[TASK] Clean up DataHandlerHook in Workspaces

DataHandlerHook originally extracted most of the versioning
functionality of DataHandler, and can now be cleaned up:

- Most of the protected methods have better type definitions
  and return types, where it was safe to do so
- Some properties / methods / arguments was
  not used and could be cleaned up

Resolves: #89136
Releases: master
Change-Id: I73734f57356e31381062043be7a6056a13d16b0b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61662
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Gorges <daniel.gorges@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.com>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[FEATURE] Add events before and after rollback of record history entries 67/61667/4
Frank Naegler [Wed, 11 Sep 2019 11:41:57 +0000 (13:41 +0200)]
[FEATURE] Add events before and after rollback of record history entries

Resolves: #89150
Releases: master
Change-Id: If00904ea940e45f03b3871c4e0146ab717cf9c14
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61667
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
4 months ago[BUGFIX] Improve finding the correct realurl cache entry to create slug 08/61508/4
Albrecht Köhnlein [Fri, 16 Aug 2019 14:39:39 +0000 (16:39 +0200)]
[BUGFIX] Improve finding the correct realurl cache entry to create slug

Respect the `expire` field when selecting realurl cache data to generate
page slugs from realurl cache.
And also only the first found result will be used to simulate original
behavior of realurl, where `exec_SELECTgetSingleRow()` with internal
LIMIT 1 is used.

Resolves: #88971
Releases: master, 9.5
Change-Id: Ic008fc42c80d7c797c082fef1274d1ad925f09c1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61508
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[BUGFIX] Fix IRRE uniqueness flaws 78/61578/13
Andreas Fernandez [Thu, 29 Aug 2019 16:02:48 +0000 (18:02 +0200)]
[BUGFIX] Fix IRRE uniqueness flaws

This patch fixes some flaws in the IRRE uniqueness handling:

- Validation is triggered once a record has been removed from DOM
- Removed records are now added to their selector again if not opened
  before
- Uniqueness handling now works for records with uid "0", which is
  relevant for a site's language handling
- The unique update is now triggered only when the value of its selector
  in a record actually changes

Resolves: #87711
Releases: master, 9.5
Change-Id: I9fe15d8e8790eff305024b706450cd2c37da9340
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61578
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
4 months ago[FEATURE] Provide core cache frontends via dependency injection 88/61588/6
Markus Poerschke [Sun, 1 Sep 2019 18:48:30 +0000 (20:48 +0200)]
[FEATURE] Provide core cache frontends via dependency injection

Configure services for each service instance. The service names of the
cache frontends will follow this name pattern:
"cache.[NAME OF CONFIGURATION]".

E.g. the l10n cache frontend will be added as a service "cache.l10n".
(One exception has been made for the workspaces_cache, which is names
cache.workspaces)

Resolves: #89054
Releases: master
Change-Id: I5e328503ee0399f20ea37d766b8a80cd6d9930fc
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61588
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Markus Poerschke <markus@poerschke.nrw>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[BUGFIX] Do not check for pid=-1 when evaluating workspace records 41/61641/8
Benni Mack [Sun, 8 Sep 2019 13:34:52 +0000 (15:34 +0200)]
[BUGFIX] Do not check for pid=-1 when evaluating workspace records

TYPO3 Core handles the result of database queries in a lot of different
ways to filter out workspace records.

With "versioning support v1" (= without workspaces), the identifier was
usually "pid = -1" to filter out records that should not be displayed in
live results.

With workspaces, there are other, better ways to identify versioned via
the following fields:
- t3ver_state (what kind of versioned record is there)
- t3ver_oid (if the versioned record points to a live record)
- t3ver_wsid (the workspace ID)

The "pid" field was kept as misuse, but fine for most of the database
queries. Since we now have Doctrine DBAL, and Restrictions, the Core
API can now be unified to actually check for "t3ver_oid>0" instead of
"pid<>-1" to identify a versioned record.

All places in TYPO3 Core now does not check for "pid<>-1" anymore for
tables that are workspace-aware.

In the future, it is then possible to get rid of the "pid=-1" value when
writing versioned records, streamlining the API effectively, to find one
proper way to query and write records.

This change does not modify any other places in TYPO3 Core where
Workspace Records are written, but only cleans up the API to only
consider "t3ver_oid" instead of "pid", avoiding the mis-use of "pid".

Most queries can then be handled by simply checking:
- t3ver_wsid=0 AND deleted=0 for only fetching live records
- t3ver_wsid IN (0,12) AND t3ver_oid=0 to find all live records,
  and draft placeholders, to do overlays then

Resolves: #89122
Releases: master
Change-Id: I781d1ae440fe944e6c8c99d02884a6eb0c1be0a7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61641
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[BUGFIX] Render confirmation when deleting a scheduler task in edit view 40/61640/2
Andreas Fernandez [Sun, 8 Sep 2019 11:57:11 +0000 (13:57 +0200)]
[BUGFIX] Render confirmation when deleting a scheduler task in edit view

This patch renders a confirmation dialog when attempting to delete a
scheduler task in the edit view. This solves an inconsistency between
the SchedulerModuleController and the EditDocumentController.

Resolves: #89109
Releases: master, 9.5
Change-Id: Ibf76431aa075aaeed93dea71fd2d30a8be9760a9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61640
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[BUGFIX] Fix assertion ordering in test cases 66/61666/2
Oliver Hader [Wed, 11 Sep 2019 11:41:24 +0000 (13:41 +0200)]
[BUGFIX] Fix assertion ordering in test cases

* use assertEqualsCanonicalizing instead of assertSame
  on array values to ignore ordering
* apply sorting order for localizations retrieved in
  Clipboard (drive-by fix)
* properly tearDown left-over instances of previous
  test execution

Resolves: #89149
Releases: master
Change-Id: I369509bae1f58b7eeabe522c3a00af3ef86bb66f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61666
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Check date format before conversion in module "DB check" 30/56530/21
Sascha Egerer [Mon, 29 Jul 2019 13:34:05 +0000 (15:34 +0200)]
[BUGFIX] Check date format before conversion in module "DB check"

With the change in https://forge.typo3.org/issues/83675 every value could
be converted into a unix timestamp, which leads to incorrect conversions
in some cases e.g. if an interger value like a pid 5134 is passed to the
method.

Releases: master, 9.5
Resolves: #84588
Resolves: #85020
Change-Id: Id92367bae3085015399ed89531c019e8aacd6510
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/56530
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[TASK] Cleanup RecordHistory handling 31/61631/14
Frank Naegler [Thu, 5 Sep 2019 14:33:06 +0000 (16:33 +0200)]
[TASK] Cleanup RecordHistory handling

This patch deprecate some methods and public properties.
Also some code was moved into new classes to seperate
creations and rollback of record history entries.

Resolves: #89127
Releases: master
Change-Id: Ib30930bc2bce129cdbdb6039d0e361020799e8e3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61631
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[BUGFIX] Avoid unnecessary DB queries to sys_language 56/61656/3
Benni Mack [Tue, 10 Sep 2019 09:39:55 +0000 (11:39 +0200)]
[BUGFIX] Avoid unnecessary DB queries to sys_language

Since site handling, finding the correct languages and the amount of languages in a page can be simplified.

NewRecordController->checkIfLanguagesExist() is never in use, and can be removed completely.

Resolves: #89125
Releases: master
Change-Id: I523bf8ecdf0598d7acb062200710c4fae2935cc5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61656
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[BUGFIX] Correctly retrieve workspace versions 63/61663/6
Oliver Hader [Tue, 10 Sep 2019 22:01:53 +0000 (00:01 +0200)]
[BUGFIX] Correctly retrieve workspace versions

* Clipboard now correctly resolves record localizations of a workspace
* PageLayoutController new correctly determines sub-pages that are new
  in a particular workspace
* SlugHelper & TypoScriptTemplateModuleController can be simplified
  by using WorkspaceRestriction directly
* common function test scenario tree (based on YAML) is introduced
  for ext:backend in order to be used as structure for other tests
* required testing framework changes support version and language
  variants and combination much better now

Resolves: #89138
Releases: master
Change-Id: Ia4b412d48dd3ea92adc60c729ad6feb27c22b812
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61663
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Gorges <daniel.gorges@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Achim Fritz <af@achimfritz.de>
4 months ago[BUGFIX] Use RuntimeException instead of die() 59/61659/4
Benni Mack [Tue, 10 Sep 2019 13:28:22 +0000 (15:28 +0200)]
[BUGFIX] Use RuntimeException instead of die()

There are a few places left where Kasper-Kode stopped
a process with die(). Nowadays, with PHP 7, Errors and
Exceptions are used in order to avoid the full stop
of a process.

Using Exceptions instead of die() allows for
ExceptionHandlers to handle such an error and
return a proper HTTP response if called from the web.

Resolves: #89128
Releases: master
Change-Id: Ia50863104fb91303ca3b2ae5ac5cd1466fa982b6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61659
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[BUGFIX] Support mark symbols in slug generation 55/61655/2
Andreas Fernandez [Tue, 10 Sep 2019 08:58:17 +0000 (10:58 +0200)]
[BUGFIX] Support mark symbols in slug generation

Currently, slug sanitization removes a wide range of characters not
assumed suitable for slugs, for example single accent characters or
control characters. This patch adds support for mark characters used for
example in the devanagari alphabet.

Resolves: #89123
Releases: master, 9.5
Change-Id: Iac7350d716044225164aef8585b833e3c46423fc
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61655
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
4 months ago[TASK] Cleanup and de-duplicate Extension Configuration and Constant Editing 44/61644/8
Susanne Moog [Sun, 8 Sep 2019 19:49:34 +0000 (21:49 +0200)]
[TASK] Cleanup and de-duplicate Extension Configuration and Constant Editing

* Use the same parser for constants no matter the context
* Use a dedicated class for constant configuration parsing
* Remove custom flatten implementation and use ArrayUtility
* Use the TypoScriptParser for value parsing of constants
* Remove Code Duplication

Resolves: #89113
Releases: master
Change-Id: I4caae04d65b02e3220c4f1f3c478fd212cddf587
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61644
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
4 months ago[BUGFIX] Fix configuration composition for nested structures 46/61646/4
Andreas Fernandez [Mon, 9 Sep 2019 08:38:14 +0000 (10:38 +0200)]
[BUGFIX] Fix configuration composition for nested structures

When a new site configuration gets written, removed values are
determined first and changed values are determined afterwards to keep
nested structures intact.

Resolves: #89116
Related: #86803
Releases: master
Change-Id: I6deae2a3f6eed121aa2753f2ba9a5cafa058a54d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61646
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[FEATURE] Read site setting file and populate them with the site object 36/61636/19
Susanne Moog [Sun, 8 Sep 2019 11:24:41 +0000 (13:24 +0200)]
[FEATURE] Read site setting file and populate them with the site object

In order to introduce site wide accessible settings, a site settings
file can be placed into the sites configuration folder.
The provided data will be available via the sites object.

Resolves: #89102
Releases: master
Change-Id: Ic010b3f8c3b10df0b6dc0cfca1cd57a8346e3b88
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61636
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Fix typo overriden > overridden 51/61651/3
Georg Ringer [Mon, 9 Sep 2019 18:30:33 +0000 (20:30 +0200)]
[TASK] Fix typo overriden > overridden

Also fix some typos where 'overidden' was used.

Resolves: #89119
Releases: master
Change-Id: I3d42fd662b978bc9688d2116b1c08eca9f9e7090
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61651
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
4 months ago[TASK] Change commenting style of spam protecting code 47/61647/2
Georg Ringer [Mon, 9 Sep 2019 12:20:22 +0000 (14:20 +0200)]
[TASK] Change commenting style of spam protecting code

To avoid possible conflicts with JS minification, the commenting style
is changed.

Resolves: #89093
Releases: master, 9.5
Change-Id: I1afce194b89eeb64988f48c37b6ba1107d21f61b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61647
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
4 months ago[TASK] Add default value to unused parameter in addPItoST43() 48/61648/3
Daniel [Mon, 9 Sep 2019 13:29:11 +0000 (13:29 +0000)]
[TASK] Add default value to unused parameter in addPItoST43()

The second argument of ExtensionManagementUtility::addPItoST43() has been
made obsolete with TYPO3 v8, but is still required when using the method.
This patch sets the default value of that argument to an empty string to
make the argument truly optional.

Releases: master, 9.5
Resolves: #89117
Change-Id: Ie99a4599481db61e425711eefec783d5826aa11d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61648
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
4 months ago[TASK] Speed up DB query for tables with versions 37/59037/5
Alexander Opitz [Wed, 5 Dec 2018 10:43:51 +0000 (11:43 +0100)]
[TASK] Speed up DB query for tables with versions

Eliminating OR combination of subselects within same table, as they get
wrongly managed by DBMS (mostly MySQL). Using JOIN and UNION reduces
time to execute (on larger data sets) from 10 s to 0.01 s. This helps to
get the page tree view working if an editor is inside workspace.

Resolves: #86945
Releases: master, 9.5, 8.7
Change-Id: I7a5aa66baa6cef160de66fff3f80aec49b46295f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59037
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Remove leftover functionality for workspace reviewers and vtypes 43/61643/3
Benni Mack [Sun, 8 Sep 2019 14:24:00 +0000 (16:24 +0200)]
[BUGFIX] Remove leftover functionality for workspace reviewers and vtypes

EXT:workspace code has leftover functionality from "reviewers" and "vtypes".

* "vtypes" defined whether element-, branch or page-type versioning was used until TYPO3 v4.x.
* "reviewers" defined a database field which was migrated to responsible persons for a stage

The database fields are fully removed, as well as database access (for the empty fields) and labels.

Resolves: #41419
Releases: master
Change-Id: I8a82bdce83638c290dba96e9e07dd28d695d720a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61643
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Daniel Gorges <daniel.gorges@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.com>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Use Workspace API for checking TCA versioning support 39/61639/2
Benni Mack [Sun, 8 Sep 2019 09:47:56 +0000 (11:47 +0200)]
[TASK] Use Workspace API for checking TCA versioning support

The API method BackendUtility::isTableWorkspaceEnabled($table)
should be used when dealing with a backend context to determine
if a table has versioning support enabled.

This functionality wasn't used consistently throughout TYPO3
Backend / CLI code and should be used in order to determine.

For PageRepository a separate protected method is introduced
to avoid a dependency on BackendUtility.

This patch is a precursor for streamlining the workspaces API further.

Resolves: #89108
Releases: master
Change-Id: Id63e04a5faa1520459d23fb5467ebfb523d9d958
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61639
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[TASK] Upgrade to TypeScript 3.6 37/61637/9
Andreas Fernandez [Fri, 6 Sep 2019 19:33:06 +0000 (21:33 +0200)]
[TASK] Upgrade to TypeScript 3.6

After shedding tears, blood and sacrificing brain cells and CPU time, we
finally managed to upgrade the code base to a recent TypeScript version.

With this patch, our code is compiled with TypeScript 3.6, which has
been added by the following command:

  yarn add --dev typescript@~3.6.2

Resolves: #89104
Releases: master
Change-Id: I023ba89b4d4d8d98394d046c53db7fa64c12d44c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61637
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: TYPO3com <noreply@typo3.com>
4 months ago[TASK] Fix TypeScript sources in preparation to upgrade 38/61638/7
Andreas Fernandez [Sat, 7 Sep 2019 15:01:18 +0000 (17:01 +0200)]
[TASK] Fix TypeScript sources in preparation to upgrade

To ease the upgrade to TypeScript 3.6, this patch adjusts the source
code in a TS 2.4 compatible way. This way, the upgrade patch stays as
small as possible.

Resolves: #89106
Releases: master
Change-Id: I7e2d65262395e19f958182f8658aa326dd0aec43
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61638
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
4 months ago[BUGFIX] Allow selective saving in SiteConfiguration 73/61573/10
Susanne Moog [Thu, 29 Aug 2019 10:42:06 +0000 (12:42 +0200)]
[BUGFIX] Allow selective saving in SiteConfiguration

YAML SiteConfiguration allows imports and custom configuration
that is not configurable via UI to be written directly into the
configuration files, however, when saving with the UI these
settings are overwritten and resolved. This change changes the
SiteConfiguration in a way, that only modified values are written
and imports are completely left as they are.

Resolves: #86803
Releases: master, 9.5
Change-Id: I92ece4959d57f41535e6fc8c3c7c9d2894d7f920
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61573
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Torben Hansen <derhansen@gmail.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Torben Hansen <derhansen@gmail.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
4 months ago[FEATURE] Add integrity check for redirects 27/61627/14
Andreas Fernandez [Thu, 5 Sep 2019 09:54:14 +0000 (11:54 +0200)]
[FEATURE] Add integrity check for redirects

A new Symfony command checks for redirects that may conflict with
existing and accessible sites. The command is schedulable and thus may be
created as a scheduler task.

Additionally, this patch comes with a report informing a backend user
about such conflicts.

Command:

  ./typo3/sysext/core/bin/typo3 redirects:checkintegrity [--site=some-site-identifier]

Resolves: #89090
Releases: master
Change-Id: Ide1bf0143ff55623cca268e6844e331805fb0178
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61627
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Richard Haeser <richard@maxserv.com>
4 months ago[BUGFIX] Hash extension versions into requireJS bust parameter 25/61625/3
Benjamin Franzke [Wed, 4 Sep 2019 11:45:20 +0000 (13:45 +0200)]
[BUGFIX] Hash extension versions into requireJS bust parameter

When a third party extension that contains a requireJS backend module is
updated, the cache bust parameter needs to be updated as well, otherwise
browsers would not download the updated asset.

We will now include all extensions that contain requireJS modules into the
requireJS bust parameter hash calculation (by extension name and version).
That means an extension update of these extensions will trigger a new
bust parameter.

This has the slight drawback that the requireJS bust parameter will need
to be re-calculated after every extension update of such extensions, but
that's actually limited to extensions that provide requireJS modules, and
better than no asset updates at all.

This patch uses the PackageManager instead of ExtensionManagementUtility
to get access to the package version using the PackageInterface. Having
the full package array available we can also drop the
GeneralUtility::getFileAbsFilename('EXT:…') indirection which ends up
calling PackageManager anyway (only with added string parsing overhead).

Releases: master, 9.5
Resolves: #89086
Change-Id: Id183c935aad60a38231eb1b39aae5baed269f8ce
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61625
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
4 months ago[BUGFIX] Filter translated rows in element browser 88/58888/4
Mathias Brodala [Mon, 12 Nov 2018 15:24:31 +0000 (16:24 +0100)]
[BUGFIX] Filter translated rows in element browser

It must be possible to also filter translated rows in the element
browser similarly to regular rows. This is essential to e.g. prevent
selection of translated rows in relation fields.

Resolves: #73165
Releases: master, 9.5
Change-Id: If0dbfb0841a0e69db3644eb7015786958c88e647
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/58888
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jonas Eberle <flightvision@googlemail.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
4 months ago[TASK] Add UnitTests for SiteConfiguration 29/61629/5
Anja Leichsenring [Thu, 5 Sep 2019 11:01:41 +0000 (13:01 +0200)]
[TASK] Add UnitTests for SiteConfiguration

Resolves: #89089
Releases: master, 9.5
Change-Id: I7971e27e01bd26f1ea7fe03a008447c8475cac9e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61629
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
4 months ago[BUGFIX] Fix broken nightlies because of unknown function 33/61633/3
Frank Naegler [Fri, 6 Sep 2019 07:07:52 +0000 (09:07 +0200)]
[BUGFIX] Fix broken nightlies because of unknown function

The minimum version of phpspec/prophecy is 1.7.6 and does not
contain the method `shouldBeCalledOnce()`.

Resolves: #89098
Related: #89066
Releases: master
Change-Id: Iacfda5c100ec809ea0f7f21ce2e113571b6ae25a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61633
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Respect readOnly for inline relation 90/61490/3
Georg Ringer [Mon, 12 Aug 2019 18:56:48 +0000 (20:56 +0200)]
[BUGFIX] Respect readOnly for inline relation

If a TCA field is set to readOnly=true and is using the type "inline",
all buttons are now hidden and the fields of the relation are set to
readOnly as well.

Resolves: #56060
Releases: master, 9.5
Change-Id: If2b1cb2be0591d765f40512aaf341a9c26a2f87f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61490
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Torben Hansen <derhansen@gmail.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Torben Hansen <derhansen@gmail.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
4 months ago[TASK] Make "Check TCA in ext_tables.php" install tool wizard more helpful 91/61591/5
Tymoteusz Motylewski [Mon, 2 Sep 2019 20:06:50 +0000 (22:06 +0200)]
[TASK] Make "Check TCA in ext_tables.php" install tool wizard more helpful

Add information about how user can fix the issue.

Releases: master, 9.5
Resolves: #89065
Change-Id: I4110e38ba69fbe277f5f1c08fb25fbbdd52d1fcc
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61591
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
4 months ago[BUGFIX] Name test class after subject under test 28/61628/2
Anja Leichsenring [Thu, 5 Sep 2019 10:16:58 +0000 (12:16 +0200)]
[BUGFIX] Name test class after subject under test

The subject under test is SiteConfigurationDataGroup::class,
due to the wrong name IDEs will not connect the test class with it.
To resolve the confusion, the test class gets named after the
class it tests.

Resolves: #89088
Releases: master, 9.5
Change-Id: Ice6f2857eb6bc416795b4576d6cce3410a81df96
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61628
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
4 months ago[BUGFIX] Use node-based Docker container for nightly JavaScript unit tests 24/61624/4
Andreas Fernandez [Thu, 5 Sep 2019 05:49:00 +0000 (07:49 +0200)]
[BUGFIX] Use node-based Docker container for nightly JavaScript unit tests

Resolves: #89085
Related: #89049
Releases: master
Change-Id: I3f2d83afcd833eac2caba13faedad3e449683bda
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61624
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
4 months ago[TASK] Update styleguide 18/61618/4
Susanne Moog [Wed, 4 Sep 2019 14:19:30 +0000 (16:19 +0200)]
[TASK] Update styleguide

    composer update typo3/cms-styleguide

Resolves: #89080
Releases: master, 9.5, 8.7
Change-Id: Ic4c62758efac128f61b2b8d1502ff671982a3e7a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61618
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[BUGFIX] Use node-based docker container for runTests.sh 23/61623/2
Andreas Fernandez [Wed, 4 Sep 2019 15:53:46 +0000 (17:53 +0200)]
[BUGFIX] Use node-based docker container for runTests.sh

Resolves: #89082
Releases: master
Change-Id: I845a6689374ec0e94e16286c58ce2a7deae43450
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61623
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[TASK] Add test case for reverse proxy configuration 04/61404/5
Jonas Eberle [Fri, 2 Aug 2019 14:51:47 +0000 (16:51 +0200)]
[TASK] Add test case for reverse proxy configuration

The case covers given HTTP_HOST and HTTP_X_FORWARDED_HOST with
a configuration for an (intransparent) proxy.

As some reverse proxies can be configured to have a rewritten HTTP_HOST
(usually some internal name that matches the virtual host config on the
webserver) I wondered if I can safely assume that TYPO3 handles that.

Resolves: #88898
Releases: master
Change-Id: I05302afdea0366674748445808ff00a48716e7f8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61404
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jonas Eberle <flightvision@googlemail.com>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Jonas Eberle <flightvision@googlemail.com>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
4 months ago[FEATURE] PHP API for backend JavaScript notifications 90/61590/19
Frank Naegler [Mon, 2 Sep 2019 14:36:34 +0000 (16:36 +0200)]
[FEATURE] PHP API for backend JavaScript notifications

Resolves: #89066
Related: #89061
Releases: master
Change-Id: Iba28c90287f35818d7d669f2bb8400a4fc089856
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61590
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[FEATURE] Always enable filter in SelectMultipleSideBySide fields 28/61428/7
Georg Ringer [Sat, 3 Aug 2019 13:09:07 +0000 (15:09 +0200)]
[FEATURE] Always enable filter in SelectMultipleSideBySide fields

The filter functionality of fields `type = select` with
renderType = selectMultipleSideBySide is always enabled now.

Resolves: #88907
Releases: master
Change-Id: I7332f39abd6444fc164e8b60009690f6af637b73
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61428
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Susanne Moog <look@susi.dev>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Tested-by: Susanne Moog <look@susi.dev>
4 months ago[FEATURE] Introduce Notification Actions 89/61589/15
Andreas Fernandez [Mon, 2 Sep 2019 14:06:18 +0000 (16:06 +0200)]
[FEATURE] Introduce Notification Actions

This patch introduces the ability to attach action items to a
notification, as known from nowadays operating systems.

Resolves: #89061
Releases: master
Change-Id: I9a36118cea12b58683746a8758b68ac0a4d0f710
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61589
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[BUGFIX] Support multiple env vars per line in Yaml 76/61576/9
Susanne Moog [Thu, 29 Aug 2019 13:29:34 +0000 (15:29 +0200)]
[BUGFIX] Support multiple env vars per line in Yaml

Releases: master, 9.5
Resolves: #89059
Change-Id: Iafbe5cb8ade38f29c13fd8ded68e42d552a28891
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61576
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[TASK] Build JavaScript files using ECMAScript 6 82/61582/4
Andreas Fernandez [Fri, 30 Aug 2019 08:27:06 +0000 (10:27 +0200)]
[TASK] Build JavaScript files using ECMAScript 6

Since TYPO3 v10 dropped support for Internet Explorer, JavaScript files
may be shipped using the ECMAScript 6 standard. External assets simply
get transpiled as far as possible. TypeScript loads the internal for ES6
and ES7 to generate native ECMAScript 6 builds.

Resolves: #89047
Releases: master
Change-Id: I5ab877ae07bba26e3953441040a519c628501b6b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61582
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
4 months ago[TASK] Deprecate jumpToUrl() 89/61389/9
Andreas Fernandez [Mon, 29 Jul 2019 19:43:29 +0000 (21:43 +0200)]
[TASK] Deprecate jumpToUrl()

This patch deprecated the well-known `jumpToUrl()` function which simply
does a redirect nowadays. Any occurence may be replaced by either using
`window.location.href` or using simple `<a>` tags.

Resolves: #89033
Releases: master
Change-Id: I213d89825b8ee4736e168653cddb1929ceb9844e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61389
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[TASK] Run JS tests on ChromeHeadless instead of Phantom in CI 14/61614/8
Susanne Moog [Wed, 4 Sep 2019 06:28:39 +0000 (08:28 +0200)]
[TASK] Run JS tests on ChromeHeadless instead of Phantom in CI

As Phantom is discontinued and ChromeHeadless is an easy to use
alternative, we should use ChromeHeadless to run our CI tests.

In addition, a dedicated JS image for all JavaScript related tasks
has been added, enabling us to easier update node versions and adjust
our JavaScript builds in the future.

Resolves: #89049
Releases: master
Change-Id: I15c3af0796b0398f62b228d3aeefa1030c5e6ae7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61614
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[TASK] Update testing framework to 5.0.12 17/61617/2
Susanne Moog [Wed, 4 Sep 2019 06:26:13 +0000 (08:26 +0200)]
[TASK] Update testing framework to 5.0.12

    composer require typo3/testing-framework:"~5.0.12"

Resolves: #89073
Releases: master
Change-Id: If6384d11c0201cea760b384a8b7d7b361874e815
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61617
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
4 months ago[TASK] Raise size of mountpoint fields in sys_workspace 16/61616/2
Georg Ringer [Wed, 4 Sep 2019 03:46:06 +0000 (05:46 +0200)]
[TASK] Raise size of mountpoint fields in sys_workspace

Increase the size of the fields `db_mountpoints` and `file_mountpoints`
and allow 100 instead of 25 items.

Resolves: #89071
Releases: master
Change-Id: I410900874475bce01a7f5f739640de6bd7d39d7e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61616
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Richard Haeser <richard@maxserv.com>
4 months ago[TASK] Deprecate evaluation of ll-XML localization files 72/61572/15
Georg Ringer [Thu, 29 Aug 2019 03:49:37 +0000 (05:49 +0200)]
[TASK] Deprecate evaluation of ll-XML localization files

Deprecate the usage of LocallangXmlParser in favor of xlf.

Resolves: #89037
Releases: master
Change-Id: I3f5a6beb28bf5e93fb83579c09f6c9aa4bacd662
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61572
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>