Packages/TYPO3.CMS.git
4 years ago[BUGFIX] Always use uc_default after first install 48/42848/2
Jigal van Hemert [Mon, 20 Apr 2015 18:54:54 +0000 (20:54 +0200)]
[BUGFIX] Always use uc_default after first install

If the Install Tool sets the start module on first login to allow the
installation of a distribution the uc_default settings must still be
applied. A special temporary setting by the Install Tool makes it easy
to detect this situation.

Change-Id: I33afcbd80595584767fe70dd972e24b9c43aa763
Resolves: #69138
Releases: 6.2
Reviewed-on: http://review.typo3.org/42848
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Correctly assign workspace for rootline retrieval 67/42867/2
Markus Klein [Tue, 25 Aug 2015 10:55:26 +0000 (12:55 +0200)]
[BUGFIX] Correctly assign workspace for rootline retrieval

Resolves: #69306
Releases: master, 6.2
Change-Id: If59ec36222c1124c2918b39fc014e4c8a2d7bf2f
Reviewed-on: http://review.typo3.org/42867
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Fix task execution in Scheduler 62/42862/2
Francois Suter [Tue, 25 Aug 2015 08:57:48 +0000 (10:57 +0200)]
[BUGFIX] Fix task execution in Scheduler

Executing a task from the Scheduler is currently broken
in 6.2, due to a wrong backport.

Resolves: #69302
Releases: 6.2
Change-Id: Ib8d2c1d327adc387f262a8f9dcb661671ea98a6a
Reviewed-on: http://review.typo3.org/42862
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 years ago[BUGFIX] Replace ###ID### in openCustomUrlInContentFrame correctly 31/42731/5
Christian Seifert [Tue, 18 Aug 2015 20:31:19 +0000 (20:31 +0000)]
[BUGFIX] Replace ###ID### in openCustomUrlInContentFrame correctly

Adding an URL by getModuleUrl including an array having an ID
parameter id=###ID### results in an escaped string.
Instead of "###ID###" the value "%23%23%23ID%23%23%23" is
submitted to the JavaScript function.

This patch fixes the old replacement function.
Now, you can again add click menu items linking to modules and
passing the selected page uid.

Resolves: #69170
Releases: master, 6.2
Change-Id: Ib4c0a1556dd1ed583e8faefe431e2d4eaaf864ad
Reviewed-on: http://review.typo3.org/42731
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Assure a backend domain is set in workspace preview 37/42837/2
Daniel Goerz [Fri, 7 Aug 2015 19:27:44 +0000 (21:27 +0200)]
[BUGFIX] Assure a backend domain is set in workspace preview

Change-Id: Idc17243f8741057ee6ea1746ec6c344aec28d57a
Resolves: #45519
Resolves: #31718
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/42837
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Don't cut off icons in New Record wizard 36/42836/2
Andreas Fernandez [Fri, 21 Aug 2015 13:05:00 +0000 (15:05 +0200)]
[BUGFIX] Don't cut off icons in New Record wizard

If an icon larger than 16x16 pixels is used for the record icon in TCA,
it gets cutted and only the top left part is displayed. Apply proper
CSS rules to fix this behaviour.

Resolves: #69236
Releases: master, 6.2
Change-Id: I9f7643817f05fd6fba73b7884e70dbed2db84999
Reviewed-on: http://review.typo3.org/42836
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[FOLLOWUP][BUGFIX] Show first tab in Element Wizard as fallback 01/42801/2
Markus Klein [Fri, 21 Aug 2015 07:44:10 +0000 (09:44 +0200)]
[FOLLOWUP][BUGFIX] Show first tab in Element Wizard as fallback

A wrong variable initialization is fixed.

Resolves: #59810
Releases: master, 6.2
Change-Id: Ied65743326e52e7e56e24a19db57ba40f6b4be47
Reviewed-on: http://review.typo3.org/42801
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[BUGFIX] Show first tab in Element Wizard as fallback 99/42799/2
Christian Seifert [Thu, 20 Aug 2015 22:59:29 +0000 (22:59 +0000)]
[BUGFIX] Show first tab in Element Wizard as fallback

Using the extension gridelements it is possible to restrict the
selectable content elements instead of the full menu configured
by TSconfig. At first, you might have 5 menus available and you
click on the last menu tab (maybe the fifth), so the backend
stores 5 as current tab.
Adding content elements within a gridelement, which restricts the
range of selectable CEs, you can only select the first tab (p.e.).
The original code assumes that the fifth tab is still there and
tries to select it.

This patch checks first against the existence of the selected tab.
If there is no "fifth" tab p.e. the index is set to 1.

Resolves: #59810
Releases: master, 6.2
Change-Id: I829489737de4631dfe3362e4fb11909be9315864
Reviewed-on: http://review.typo3.org/42799
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Cache healing for classes loaded via ext_autoload 28/39928/5
Bernhard Kraft [Tue, 2 Jun 2015 14:43:38 +0000 (16:43 +0200)]
[BUGFIX] Cache healing for classes loaded via ext_autoload

Currently classes loaded via an ext_autoload.php will get their cache
generated only after clearing all caches using the install tool "Clear
all caches" button or the red clear cache icon. This patch improves the
situation by taking care of ext_autoload.php files also during normal
processing. There can be edge cases where the classes_cache will not get
properly generated. In such a situation a missing cache entry will cause
"class not found" errors.

There is no performance impact for Production systems (TYPO3_CONTEXT) as
the result of the class lookup will get cached anyways. If a class is
not found via the existing mechanisms or in an ext_autoload.php it will
get cached as "invalid". Of course the class could get loaded by some
other autoload handler afterwards.

Change-Id: Id996139d31f16c6bcb40f286fbf266a87147852d
Resolves: #67246
Releases: 6.2
Reviewed-on: http://review.typo3.org/39928
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] FAL upgrade wizard: take care of files in subfolders 64/42664/2
Josef Glatz [Sun, 16 Aug 2015 18:10:20 +0000 (20:10 +0200)]
[BUGFIX] FAL upgrade wizard: take care of files in subfolders

Enable migrating files from uploads/pics/ subdirectories to FAL.

Change-Id: Ife160dd03633dc1da542cad990be3cd166cc1636
Releases: 6.2
Resolves: #69112
Reviewed-on: http://review.typo3.org/42664
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 years ago[BUGFIX] Fix QueryBuilding in IndexSearchRepository 70/42670/2
Marc Neuhaus [Mon, 3 Aug 2015 11:45:57 +0000 (13:45 +0200)]
[BUGFIX] Fix QueryBuilding in IndexSearchRepository

This changeset fixes an issue in the indexSearchRepository that creates
invalid sql queries. Main issue is the missing of several wSelClauses,
that need to be collected, because they are imploded into the query.

Resolves: #67843
Releases: master, 6.2
Change-Id: Ib53b28660acfd92233de748431131f70e69f5125
Reviewed-on: http://review.typo3.org/42219
Reviewed-on: http://review.typo3.org/42670
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Marc Neuhaus <apocalip@gmail.com>
Tested-by: Marc Neuhaus <apocalip@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Log exception as array instead of serialized 36/42736/2
Stephan Großberndt [Tue, 18 Aug 2015 14:54:05 +0000 (16:54 +0200)]
[BUGFIX] Log exception as array instead of serialized

Log exceptions thrown by scheduler tasks as array instead of
serializing the whole exception in order to keep the size down.

Resolves: #69157
Releases: master, 6.2
Change-Id: Ifc6457f3de114779a522baa77443e5019f0dc4c1
Reviewed-on: http://review.typo3.org/42736
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Exclude computed field names on fetching record overlays 58/42158/5
Albrecht Köhnlein [Fri, 31 Jul 2015 08:12:23 +0000 (10:12 +0200)]
[BUGFIX] Exclude computed field names on fetching record overlays

During versioning, the dynamic fields _ORIG_pid and _ORIG_uid are added
to $row, but they do not exist in database and cause an SQL error.

Resolves: #68643
Releases: master, 6.2
Change-Id: I33a56b2071a04b5224821805e60722ce8dd3dd14
Reviewed-on: http://review.typo3.org/42158
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 years ago[BUGFIX] Assure language override without original file 94/42694/5
Stefan Galinski [Wed, 4 Mar 2015 14:50:20 +0000 (15:50 +0100)]
[BUGFIX] Assure language override without original file

The language override of language files is currently broken,
because it only works if a localized language file already
exists inside the extension or l10n directory. This patch assures
that the language override takes place even if no file could
be found in the first place.

Resolves: #65513
Releases: master, 6.2
Change-Id: I9269e60c5788c435b06b820c459fd4f077d066ea
Reviewed-on: http://review.typo3.org/42694
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Extbase: Optional arguments must not throw an Exception 63/42663/2
Anja Leichsenring [Sun, 16 Aug 2015 16:45:32 +0000 (18:45 +0200)]
[BUGFIX] Extbase: Optional arguments must not throw an Exception

Example:
public function barAction(\Vendor\Ext\Domain\Model\Foo $foo = NULL)

If the property mapper receives NULL, 0 or a valid value
the property mapping does not fail. But if the value is
a valid uid (>0) and there is no record with that uid
the whole property mapping fails.

While this is totally valid for required arguments,
optional arguments must be skipped.

Resolves: #55861
Resolves: #55837
Resolves: #62951
Releases: master, 6.2
Change-Id: I4c954bac50be1d34ea09bfc21f8978e9165683d1
Reviewed-on: http://review.typo3.org/42663
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 years ago[BUGFIX] Reestablish DB connection in long-running tasks 65/42665/2
Stefan Neufeind [Wed, 12 Aug 2015 18:31:33 +0000 (20:31 +0200)]
[BUGFIX] Reestablish DB connection in long-running tasks

During a long-running task the connection to the database may be
disconnected, if mysql `wait_timeout` is exceeded. This patch makes
sure the connection is reestablished if there has been a connection
before.

Resolves: #69001
Releases: master, 6.2
Change-Id: I7575ae386ec190d60ddceee146133125083dee41
Reviewed-on: http://review.typo3.org/42665
Reviewed-by: Josef Glatz <jousch@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 years ago[BUGFIX] Prevent error if getimagesize() fails 49/42649/2
Stefan Neufeind [Sat, 15 Aug 2015 16:48:25 +0000 (18:48 +0200)]
[BUGFIX] Prevent error if getimagesize() fails

Upon failure getimagesize() returns FALSE instead of image-dimensions.
Handle that case cleanly.

Change-Id: I8dcd98c842aaa01f572002a6e9c86ea889de6b1b
Resolves: #59528
Releases: 6.2
Reviewed-on: http://review.typo3.org/42649
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Fix dependencies for t3x upload 42/42642/3
Helmut Hummel [Fri, 14 Aug 2015 16:03:02 +0000 (18:03 +0200)]
[BUGFIX] Fix dependencies for t3x upload

When extracting the t3x archive, the EM_CONF data is taken to
create a new ext_emconf.php file.
An already extracted ext_emconf.php file is overwritten in this process.

Since those t3x files are created by TER server and this TER server
does not include the extension constraints in this array,
all constraints are lost in this process.

To fix this, it is needed to use a present ext_emconf.php file
and merge the meta properties with its properties to construct
the final ext_emconf.php.

Resolves: #69070
Releases: master, 6.2
Change-Id: I3997bee05f256a3ff23f0eee516ecf0a323017c3
Reviewed-on: http://review.typo3.org/42642
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[TASK] Properly encode database input in the right place 61/42661/2
Helmut Hummel [Fri, 14 Aug 2015 13:45:15 +0000 (15:45 +0200)]
[TASK] Properly encode database input in the right place

This adds code that prevents potential SQL injections.
The core is not exploitable, as cleaning is done in other code parts.

Resolves: #69061
Releases: master, 6.2
Change-Id: Iba42adc6dd4abd3976b57f1dc84ba6585ea7bbd4
Reviewed-on: http://review.typo3.org/42661
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[BUGFIX] Remove trailing colons from checkbox labels 60/42660/2
Daniel Goerz [Sun, 16 Aug 2015 11:09:17 +0000 (13:09 +0200)]
[BUGFIX] Remove trailing colons from checkbox labels

Change-Id: I4339ad96c4fa8efabd8c99e7de1cdebae3a1d76b
Resolves: #69092
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/42660
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Add encodeURIComponent to search parameter 91/42591/2
Stephan Großberndt [Thu, 13 Aug 2015 16:00:13 +0000 (18:00 +0200)]
[BUGFIX] Add encodeURIComponent to search parameter

Encode search parameter to encode special characters

Resolves: #68400
Releases: master, 6.2
Change-Id: I991fd7c3855dbefd152792eb8888f09b3f22f597
Reviewed-on: http://review.typo3.org/42591
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Illegal string offset 'currentLangId' in DataHandler 41/42641/2
Joerg Kummer [Fri, 14 Aug 2015 13:04:17 +0000 (15:04 +0200)]
[BUGFIX] Illegal string offset 'currentLangId' in DataHandler

Avoid PHP warning on save CE plugin with empty </meta> element in flexform

Resolves: #69056
Releases: master,6.2
Change-Id: Ibbbebe3745b2a8bb793d5cc0b799b98ad69d0223
Reviewed-on: http://review.typo3.org/42641
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[BUGFIX] Fix PHP Warning in updateRefIndexTable() 40/42640/2
Stephan Großberndt [Thu, 13 Aug 2015 17:50:35 +0000 (19:50 +0200)]
[BUGFIX] Fix PHP Warning in updateRefIndexTable()

This patch fixes a PHP Warning occurring if
ReferenceIndex::updateRefIndexTable() is called with a tableName of a
table without a TCA definition.

Resolves: #68503
Releases: master, 6.2
Change-Id: I2fd755703199a4d76ef29082e9306833a18be130
Reviewed-on: http://review.typo3.org/42640
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Retrieve correct fieldname for condition lookup 96/42496/2
Benjamin Serfhos [Tue, 11 Aug 2015 06:36:35 +0000 (08:36 +0200)]
[BUGFIX] Retrieve correct fieldname for condition lookup

DisplayCond for sheets in flexforms should allow extbase
parameters, eg: "settings.data".

Resolves: #68493
Related-to: If5e5c3396972758a022f67606670892327e0d180
Releases: 6.2
Change-Id: I46e36804878f3681bfba973ec1cf831d54df1ead
Reviewed-on: http://review.typo3.org/42496
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Calculations in GIFBUILDER properties using stdWrap fail 39/42639/2
Dan Untenzu [Mon, 21 Oct 2013 12:13:39 +0000 (14:13 +0200)]
[BUGFIX] Calculations in GIFBUILDER properties using stdWrap fail

Unset each existing TypoScript subarray of all properties
with calculations (offset,dimensions,set,…) in GIFBUILDER.
Do this to prevent the double execution of stdWrap,
which would cause those properties to return uncalculated
and therefore wrong values afterwards.

Resolves: #53002
Releases: master, 6.2
Change-Id: Ib9a6ede30988acad25df8fcca811475c19e77b09
Reviewed-on: http://review.typo3.org/42639
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Prevent ResourceDoesNotExistException 94/42594/2
Andre Hähnel [Fri, 9 Jan 2015 13:47:40 +0000 (14:47 +0100)]
[BUGFIX] Prevent ResourceDoesNotExistException

An exception is thrown if the show info popup is opened by sys_file uid
for a file which does not exist anymore in filestorage.

This change marks the file as missing so no exception is thrown in
ElementInformationController but a error message is shown to the user
about the missing file.

Resolves: #64214
Releases: master, 6.2
Change-Id: I460013e21db149760a1b391d9cdbd68b6530d190
Reviewed-on: http://review.typo3.org/42594
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
4 years ago[BUGFIX] EM: Trim whitespace in search field 11/42611/3
Alexander Opitz [Fri, 14 Aug 2015 10:12:29 +0000 (12:12 +0200)]
[BUGFIX] EM: Trim whitespace in search field

Leading and trailing whitespaces are now trimmed before the TER is inquired.

Resolves: #69040
Releases: master, 6.2
Change-Id: Iabb641e276358f76732673efb3a23b13d63ac144
Reviewed-on: http://review.typo3.org/42611
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[BUGFIX] Make editIconsHook work again 89/42589/2
Nicole Cordes [Mon, 13 Jul 2015 09:40:06 +0000 (11:40 +0200)]
[BUGFIX] Make editIconsHook work again

It isn't possible to add icons in filelist extended view easily,
because there is no way to get the current file or folder object nor get
information about it. This patch adds the object to the cells variable
and reset it after hook execution to ensure access to it.

Releases: master, 6.2
Resolves: #67962
Change-Id: I44a4229128bcfdb2ed17900462f50a771ed63fdd
Reviewed-on: http://review.typo3.org/42589
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[BUGFIX] Allow subclasses of \DateTime as entity properties 90/42590/2
Stephan Schuler [Wed, 13 May 2015 13:05:35 +0000 (15:05 +0200)]
[BUGFIX] Allow subclasses of \DateTime as entity properties

When a class "\MyCustomDateTime extends \DateTime", the data mapper
creates "\DateTime" objects instead when mapping database results.
This patch uses the class annotation to resolve the class to create.

Resolves: #66939
Releases: master, 6.2
Change-Id: I45062d4d1a44333016258289ea9e2026d9923f70
Reviewed-on: http://review.typo3.org/42590
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
4 years ago[BUGFIX] Draft usergroup access rights are now respected 53/42553/3
Bart Dubelaar [Fri, 27 Jan 2012 10:28:31 +0000 (11:28 +0100)]
[BUGFIX] Draft usergroup access rights are now respected

Adding usergroup access rights to a page in a draft workspace had no
effect on the preview, the page was still shown in menus. The other way
around didn't work either. Removing access rights would not make the page
available. Previewing wasn't possible at all.

This behavior is fixed. All draft usergroup changes are now respected
when previewing.

Releases: master, 6.2
Resolves: #33436
Change-Id: Ib9a74e98d6ed7457849465fc64685f89ed82fb61
Reviewed-on: http://review.typo3.org/42553
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
4 years ago[BUGFIX] Edits disappear when published twice 92/42592/2
Stefan Rotsch [Fri, 10 Jan 2014 09:34:38 +0000 (10:34 +0100)]
[BUGFIX] Edits disappear when published twice

When accidentally publishing an edit twice, eg. by using multiple
browser tabs, all modifications are reverted and the changes are no
longer visible in the workspace.

In the database, the old workspace version of the record has wsid = 0
and pid = -1 and is thus invisible, but still contains the modified
content.

Resolves: #54924
Releases: master, 6.2
Change-Id: I8805737540f030ae24331d33590b71629c7f3179
Reviewed-on: http://review.typo3.org/42592
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
4 years ago[BUGFIX] Use proper data sets in workspaces tests 96/42596/2
Oliver Hader [Thu, 13 Aug 2015 17:03:11 +0000 (19:03 +0200)]
[BUGFIX] Use proper data sets in workspaces tests

Some field values are not correct in the initial scenario
definition for the workspaces functional tests. The faulty
behavior can only be determined if MySQL is working in
strict mode.

Resolves: #69027
Releases: master, 6.2
Change-Id: I12f1dc8d6fbd479b46749062be5d24075c0f2b6d
Reviewed-on: http://review.typo3.org/42596
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 years ago[BUGFIX] Fix wrong comment in install tool for [HTTP][proxy_host] 93/42593/2
Frank Nägler [Thu, 6 Aug 2015 09:08:11 +0000 (11:08 +0200)]
[BUGFIX] Fix wrong comment in install tool for [HTTP][proxy_host]

Resolves: #62340
Releases: master, 6.2
Change-Id: I20554a255141ba2f49f0632404957eaf320cee7b
Reviewed-on: http://review.typo3.org/42593
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
4 years ago[BUGFIX] Fix faulty move-placeholder processing with workspaces 73/42573/2
Artur Cichosz [Tue, 28 Jul 2015 17:13:18 +0000 (19:13 +0200)]
[BUGFIX] Fix faulty move-placeholder processing with workspaces

Fix a possibly faulty condition based on a comparison of boolean
with integer (TRUE >= 2) which always results in TRUE.
To avoid this, an additional integer test for the first
part of the condition statement has been added.

Resolves: #68494
Releases: master, 6.2
Change-Id: Icf7b55532483e6a315b93c001ddf41f1caf3a7f8
Reviewed-on: http://review.typo3.org/42573
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 years ago[BUGFIX] Catch exceptions for inaccessible storages 17/42017/5
Philipp Gampe [Sun, 1 Feb 2015 10:46:51 +0000 (11:46 +0100)]
[BUGFIX] Catch exceptions for inaccessible storages

A storage might be (temporary or permanently) not available in the
current file system. Then it should be displayed as inaccessible
(offline).
Catch all exceptions while trying to fetch permissions for any related
folders.
Only display paste icons for browsable storages.

Resolves: #64714
Releases: master, 6.2
Change-Id: I803d1d2dad919fefebf9b37c60b40a7a440bc6d5
Reviewed-on: http://review.typo3.org/42017
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Catch exception when linked file is deleted 49/42549/3
Benjamin Mack [Wed, 12 Aug 2015 20:05:47 +0000 (22:05 +0200)]
[BUGFIX] Catch exception when linked file is deleted

If a file is linked in the RTE and the file is deleted afterwards
an exception is thrown thus making it impossible to change
the link.

Instead the popup shows up without selecting anything.

Resolves: #66624
Releases: master, 6.2
Change-Id: Iec985b0202002a2c906b4cee43cd4e27e496d4fb
Reviewed-on: http://review.typo3.org/42549
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 years ago[BUGFIX] Consider placeholders in fixVersioningPid 48/42548/2
Timo Webler [Wed, 11 Sep 2013 13:43:25 +0000 (15:43 +0200)]
[BUGFIX] Consider placeholders in fixVersioningPid

Method fixVersioningPid does not analyze the new location for an element.
Check for a move placeholder to get the new location.
Same behavior as in frontend.
See \TYPO3\CMS\Frontend\Page\PageRepository::fixVersioningPid

Resolves: #51913
Releases: master, 6.2
Change-Id: I08a8eab714ec1530f3c655f0440c98342120e328
Reviewed-on: http://review.typo3.org/42548
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 years ago[BUGFIX] Capability check fails for some storage types 47/42547/2
Benjamin Mack [Wed, 12 Aug 2015 19:37:15 +0000 (21:37 +0200)]
[BUGFIX] Capability check fails for some storage types

The check should only complain if a user wants to mark a storage as
public and the driver does not support that. This commit changes the
check accordingly.

Change-Id: Id5d029dbbb2c99b373af9ff41aa6dd4a40d70764
Releases: master, 6.2
Resolves: #67284
Reviewed-on: http://review.typo3.org/42547
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 years ago[BUGFIX] Set background for disabled input fields 46/39746/4
Andreas Fernandez [Tue, 26 May 2015 14:28:59 +0000 (16:28 +0200)]
[BUGFIX] Set background for disabled input fields

Set a proper background color for disabled input fields.

Resolves: #67145
Releases: 6.2
Change-Id: I4c2e57357ffc882635545b5a5706d9f0f2262ba8
Reviewed-on: http://review.typo3.org/39746
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 years ago[FOLLOWUP][BUGFIX] Provide title label for paste into column 57/42457/2
Anja Leichsenring [Sun, 9 Aug 2015 12:15:29 +0000 (14:15 +0200)]
[FOLLOWUP][BUGFIX] Provide title label for paste into column

Backport introduced a new locallang file that did not belong.

Change-Id: I62bb7610c2366fd593d872c93824853f8b2f192e
Releases: 6.2
Resolves: #68873
Reviewed-on: http://review.typo3.org/42457
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years agoRevert "[BUGFIX] Fix broken functional tests" 56/42456/2
Anja Leichsenring [Sun, 9 Aug 2015 11:59:12 +0000 (13:59 +0200)]
Revert "[BUGFIX] Fix broken functional tests"

the original patch was never backported to 6.2, sorry for the hassle.

This reverts commit e65f253abfa056827766da247347fb102fb2e53a.

Change-Id: I515c4c896c1f258f675531128093e28174f02aaa
Reviewed-on: http://review.typo3.org/42456
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Fix broken functional tests 53/42453/2
Anja Leichsenring [Sun, 9 Aug 2015 10:06:03 +0000 (12:06 +0200)]
[BUGFIX] Fix broken functional tests

Change-Id: I742c16a2689fd7ec89abf3620a618a99f24779a7
Resolves: #68882
Relates: #68871
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/42453
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Provide title label for paste into column 48/42448/2
Daniel Goerz [Sat, 8 Aug 2015 21:39:52 +0000 (23:39 +0200)]
[BUGFIX] Provide title label for paste into column

Change-Id: Ia01c9083cc0eda52725efdec93106e911884f097
Resolves: #68873
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/42448
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Workspace preview links for multiple languages 17/42417/3
Stefan Rotsch [Wed, 22 Jan 2014 12:30:54 +0000 (13:30 +0100)]
[BUGFIX] Workspace preview links for multiple languages

The workspace preview link will only be generated for one language at
a time, so it might require some effort to generate preview links for
multiple languages.

For convenience of editors, preview links will now be generated for
all available translations of a certain page in a batch.

Resolves: #20852
Resolves: #12970
Releases: master, 6.2
Change-Id: I6de6f2c7b741e238fc373f0756bc29f0100a19f0
Reviewed-on: http://review.typo3.org/42417
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Document required MySQL privileges 82/42382/2
Morton Jonuschat [Fri, 7 Aug 2015 13:11:45 +0000 (15:11 +0200)]
[TASK] Document required MySQL privileges

Add the minimum set of privileges required to run TYPO3 CMS to the
INSTALL.md document.

Add a recommendation for the privileges to manage/use views and
stored procedures.

Resolves: #68734
Releases: master, 6.2
Change-Id: I1472c36133e560df72d1a5412129322df0d2cf95
Reviewed-on: http://review.typo3.org/42382
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Skip write access check if core files exist 78/42378/3
Frederic Gaus [Mon, 20 Jul 2015 12:07:27 +0000 (14:07 +0200)]
[BUGFIX] Skip write access check if core files exist

If updating a TYPO3 instance when the core files are
already present, the CoreUpdateService can skip the
write access check.

Resolves: #68386
Releases: master, 6.2
Change-Id: I7af201d98e43799f4066c74443a1815d9b65cbf0
Reviewed-on: http://review.typo3.org/42378
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Remove php warning for RTE classes without name 67/42367/4
Manuel Selbach [Fri, 7 Aug 2015 10:14:56 +0000 (12:14 +0200)]
[BUGFIX] Remove php warning for RTE classes without name

Check if name within the configuration is set
so that no PHP warning: illigal offset will be thrown

Resolves: #68068
Releases: master,6.2
Change-Id: I781fa237aa696e6e9b03714f8e1aca4124589d5f
Reviewed-on: http://review.typo3.org/42367
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Change value from NULL to empty string for link field in test data 35/42335/2
Marc Bastian Heinrichs [Thu, 6 Aug 2015 21:56:31 +0000 (23:56 +0200)]
[BUGFIX] Change value from NULL to empty string for link field in test data

When increasing max length of link fields the definition for db field link in
table sys_file_reference changed to not NOT NULL. This needs to be adapted
also in the impexp functional test data.

Resolves: #68810
Related: #61944
Releases: master,6.2
Change-Id: I3c518ad865037365793a58c73ff9d1ec539410f2
Reviewed-on: http://review.typo3.org/42335
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 years ago[BUGFIX] Clear affected caches on page publishing 08/42308/3
Bart Dubelaar [Tue, 19 Jun 2012 12:54:45 +0000 (14:54 +0200)]
[BUGFIX] Clear affected caches on page publishing

When publishing a page, the treelist cache should be cleared.
This is fixed by adding a condition that checks for a swap action in
the existing class that hooks into DataHandler and listens for updates to
pages to update the treelist cache.

Change-Id: I0c01450efe9507dcef9f74af626a9ebf3cdc7d4c
Resolves: #37952
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/42308
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Typo in neg_foreign_table in DataPreprocessor 89/42289/2
Andreas Wolf [Wed, 5 Aug 2015 18:38:34 +0000 (20:38 +0200)]
[BUGFIX] Typo in neg_foreign_table in DataPreprocessor

Change-Id: I5f281c99c65a6a3a0d0d527bdd5db02853eb078b
Releases: master, 6.2
Resolves: #68769
Related: #36573
Reviewed-on: http://review.typo3.org/42289
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Do not turn TYPO3 Logo upside down on error pages 43/42243/2
Benjamin Mack [Tue, 4 Aug 2015 11:22:38 +0000 (13:22 +0200)]
[BUGFIX] Do not turn TYPO3 Logo upside down on error pages

Resolves: #68718
Releases: master, 6.2
Change-Id: Ie41426bac4a21e53f423e52fd537e037db18ac4f
Reviewed-on: http://review.typo3.org/42243
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Disallow access to vcs directories 52/42152/2
Philipp Gampe [Wed, 29 Jul 2015 15:34:55 +0000 (17:34 +0200)]
[TASK] Disallow access to vcs directories

Access to vcs directories should be denied by default to avoid leaking
information to the outsite that might have been accidentally committed
to a repository.
This does not effect the core as the version information is public by
license, but any repository containing configuration or third party
extensions.

Resolves: #68626
Releases: master,6.2
Change-Id: I4f3cb88e577f56ac71d882c8b11341da46a8b757
Reviewed-on: http://review.typo3.org/42152
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Call fixPermissions after replaceFile 42/42142/2
Frans Saris [Thu, 30 Jul 2015 12:59:53 +0000 (14:59 +0200)]
[BUGFIX] Call fixPermissions after replaceFile

Resolves: #68642
Releases: master, 6.2
Change-Id: Iec6bf8989cae1fafd2cc909635d980c971af656c
Reviewed-on: http://review.typo3.org/42142
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Invalid handling of "mergeIfNotBlank" in backend 21/42121/2
Christian Kuhn [Wed, 29 Jul 2015 21:22:48 +0000 (23:22 +0200)]
[BUGFIX] Invalid handling of "mergeIfNotBlank" in backend

This is a partial backport of #68592 to fix the title part
in the backend for 6.2 as well.

Change-Id: I56fce644416baf5e26c359c1767bb0569b02cbf4
Resolves: #68624
Related: #68592
Releases: 6.2
Reviewed-on: http://review.typo3.org/42121
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Don't use FAL based ImageViewHelper in extension manager 35/42135/2
Frans Saris [Wed, 29 Jul 2015 20:13:07 +0000 (22:13 +0200)]
[BUGFIX] Don't use FAL based ImageViewHelper in extension manager

Resolves: #68636
Releases: master, 6.2
Change-Id: I15c48447d0226518f0bdf8459295a82e49864306
Reviewed-on: http://review.typo3.org/42135
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Rename setLocale() in DateTimeViewHelperTest 13/42113/2
Andreas Fernandez [Wed, 29 Jul 2015 18:07:00 +0000 (20:07 +0200)]
[BUGFIX] Rename setLocale() in DateTimeViewHelperTest

The method setLocale($locale) in the DateTimeViewHelperTest
was implemented to test against several locales. However,
as there is a setLocale() in the parent class from PHPUnit that
does not take any parameter, PHP7 throws a warning as the
subclass does not have the same method signature as the parent
class.

The patch changes the method to be named differently thus,
solving the method signature conflict inside the test.

Resolves: #67092
Releases: 6.2, master
Change-Id: Ia05d90c64a3a8e2fc599935d2435192392e5a667
Reviewed-on: http://review.typo3.org/42113
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[BUGFIX] Fixed permissions of media field in page properties 70/41670/4
Michael Oehlhof [Wed, 1 Jul 2015 19:14:55 +0000 (21:14 +0200)]
[BUGFIX] Fixed permissions of media field in page properties

It was not possible to add media to the page properties if the user has
only the permissions for "page edit" and not for "page content"..

Resolves: #66702
Releases: master, 6.2
Change-Id: I553ee805a0e992d2ea5e00b91e7de733b2e4c94e
Reviewed-on: http://review.typo3.org/41670
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Show pages with "show at any login" in view module 82/41982/2
Daniel Goerz [Sun, 26 Jul 2015 14:08:14 +0000 (16:08 +0200)]
[BUGFIX] Show pages with "show at any login" in view module

Resolves: #67752
Releases: master, 6.2
Change-Id: I9e8e54012bcfb994e508eae0269493d250cc005a
Reviewed-on: http://review.typo3.org/41982
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Invalid links to documentation 66/41966/2
Xavier Perseguers [Sun, 26 Jul 2015 10:15:56 +0000 (12:15 +0200)]
[BUGFIX] Invalid links to documentation

Resolves: #68540
Releases: master, 6.2
Change-Id: I7e66ab53bb4ec67af5a2b4355d0704e329ea3ea7
Reviewed-on: http://review.typo3.org/41966
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
4 years ago[BUGFIX] dbal: Cast field to CHAR for FIND_IN_SET() 42/41842/2
Morton Jonuschat [Thu, 28 May 2015 17:50:47 +0000 (19:50 +0200)]
[BUGFIX] dbal: Cast field to CHAR for FIND_IN_SET()

Implement explicit casting of fields to a character representation.
Most DBMS are stricter in regard to data type checking and emit an
error when trying to use FIND_IN_SET() on non-text field types.

On the DBAL side of things the DBMS specifics are used to define that
an explicit cast is required for FIND_IN_SET() so that a query including
the CAST() statement gets generated.

A PostgreSQL Specific has been added to enable the explicit casting in
conjuction with DBAL. To avoid checking repeatedly if a DBMS has defined
specific requirements a NullSpecific has been implemented that gets used
as a default.

In the DatabaseTreeDataProvider the listFieldQuery() function has been
changed to use an explicit CAST() instead of relying on the implicit
cast done by MySQL when comparing it to an empty string.

The SqlParser has been extended with the support for CAST().

Resolves: #67155
Resolves: #67172
Resolves: #46271
Releases: master, 6.2
Change-Id: Ic77d1700e0fb4e3723c90b34e131dafb456038e0
Reviewed-on: http://review.typo3.org/39779
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-on: http://review.typo3.org/41842

4 years ago[BUGFIX] Use correct extension name for labels in indexed search 41/41841/3
Markus Klein [Wed, 22 Jul 2015 18:01:09 +0000 (20:01 +0200)]
[BUGFIX] Use correct extension name for labels in indexed search

The extbase implementation of the search form must use extensionName
and not extension_key for retrieving translations.
This ensures that translations from the template are taken into account.

Releases: master, 6.2
Resolves: #68430
Change-Id: Ia2265793b4f57c018ffca5ae5af9feb1cbf94803
Reviewed-on: http://review.typo3.org/41841
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Fix image descriptions for renderMethod = table 10/41810/2
Torben Hansen [Thu, 16 Jul 2015 08:12:07 +0000 (10:12 +0200)]
[BUGFIX] Fix image descriptions for renderMethod = table

Image descriptions are not rendered correctly using
renderMethod = table, since only the description of the
last image is rendered when you have multiple images
in a content object..

This patch loads the current image file reference to the
contentObjectRenderer while looping through all images
in order to output the image descriptions.

Resolves: #68153
Releases: master, 6.2
Change-Id: I273fff90a5ab3a35e6422ca74b6d83b298b9b09d
Reviewed-on: http://review.typo3.org/41810
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Use parse_url to determine absolute urls in ImageService 77/41777/5
Frans Saris [Tue, 21 Jul 2015 11:50:22 +0000 (13:50 +0200)]
[BUGFIX] Use parse_url to determine absolute urls in ImageService

Since it is possible to have protocol relative URIs and parse_url
only identifies a hostname once a scheme or scheme relative prefix is
applied, we can check for a hostname here.

Resolves: #68423
Releases: master, 6.2
Change-Id: I3eb51d9b5175657454657bbd7f75cfafa6bd9760
Reviewed-on: http://review.typo3.org/41777
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Allow editing of shortcuts for non-admin users 62/41762/2
Markus Klein [Tue, 21 Jul 2015 07:13:58 +0000 (09:13 +0200)]
[BUGFIX] Allow editing of shortcuts for non-admin users

Resolves: #60254
Releases: master, 6.2
Change-Id: Ie5e65ab761e8ce018a4d71daa39495fae3ad3572
Reviewed-on: http://review.typo3.org/41762
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
4 years ago[BUGFIX] HTMLParser doesn't remove endtag when applying rmTagIfNoAttrib 96/41596/2
Alexander Stehlik [Fri, 17 Jul 2015 19:39:43 +0000 (21:39 +0200)]
[BUGFIX] HTMLParser doesn't remove endtag when applying rmTagIfNoAttrib

Solution: Force nesting = 1 when rmTagIfNoAttrib is set on a tag.

Releases: master, 6.2
Resolves: #22871
Resolves: #50144
Change-Id: Ibdadf07d80591588c0698ed322905cc0be45fe7e
Reviewed-on: http://review.typo3.org/41596
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
4 years ago[BUGFIX] includeCSS is not compressed and concatenated 47/41747/2
Sebastian Michaelsen [Sat, 18 Jul 2015 11:13:53 +0000 (13:13 +0200)]
[BUGFIX] includeCSS is not compressed and concatenated

The CSS files defined in page.includeCSSLibs don't get concatenated and
compressed if you enable config.compressCss and config.concatenateCss

Resolves: #65772
Releases: master, 6.2
Change-Id: I7bb72de5308dd255ff0b20f13b65d80e4a23d5cb
Reviewed-on: http://review.typo3.org/41747
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
4 years ago[BUGFIX] Implement EXT: usage in addModulePath 33/41733/3
Michael Oehlhof [Sun, 19 Jul 2015 08:45:47 +0000 (10:45 +0200)]
[BUGFIX] Implement EXT: usage in addModulePath

Make it possible to use EXT: for resolving paths in addModulePath

Resolves: #68361
Releases: master, 6.2
Change-Id: I6e79a3e11c42530fadaa25e4dc64f05e6d6a0e32
Reviewed-on: http://review.typo3.org/41733
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
4 years ago[BUGFIX] Implement EXT: usage in addModule 92/41692/5
Wouter Wolters [Sat, 18 Jul 2015 12:30:42 +0000 (14:30 +0200)]
[BUGFIX] Implement EXT: usage in addModule

Make it possible to use EXT: for resolving paths in addModule

Resolves: #68341
Releases: master, 6.2
Change-Id: Ic26d410f09303baa4fa18c744b30ee72ada09227
Reviewed-on: http://review.typo3.org/41692
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
4 years ago[BUGFIX] Reuse local mirror.xml.gz when updating translations 22/41722/2
Xavier Perseguers [Mon, 20 Jul 2015 09:56:15 +0000 (11:56 +0200)]
[BUGFIX] Reuse local mirror.xml.gz when updating translations

When updating translation packages, the local mirrors.xml.gz should be
reused instead of being fetched again and again.

The list of mirrors virtually never changes and is already updated when
fetching the list of TER extensions in Extension Manager. It should thus
be assumed that the local content is just correct and may be used safely.

Change-Id: I5863762061b2a55d2439a92d53fdbf02bcd6e124
Resolves: #68364
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/41722
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
4 years ago[BUGFIX] felogin: Invalid action url in changePassword form 24/41724/2
Stano Paška [Tue, 30 Jul 2013 14:46:54 +0000 (16:46 +0200)]
[BUGFIX] felogin: Invalid action url in changePassword form

Resolves: #50141
Releases: master, 6.2
Change-Id: I26a6215523ed409cbac8fe0f4659102d0b7ca365
Reviewed-on: http://review.typo3.org/41724
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
4 years ago[BUGFIX] Invalid sys file storages must be ignored 96/41696/2
Georg Ringer [Sun, 19 Jul 2015 07:48:25 +0000 (09:48 +0200)]
[BUGFIX] Invalid sys file storages must be ignored

If a storage is not available anymore, it must be ignored

Change-Id: Ie00af1bc086871c046ac4556c0119fc82d30a17e
Resolves: #55714
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/41696
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Checkbox values not shown in emails 64/41664/2
Sebastian Müller [Tue, 27 Nov 2012 00:58:16 +0000 (01:58 +0100)]
[BUGFIX] Checkbox values not shown in emails

Emails sent by FORM sysext do not show the values of checkboxes, in case
of they were checked.

Change-Id: Ie8df935932abb59d211e963776dcdf09c94618c6
Resolves: #33092
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/41664
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Clarify install tool no-password-set message 49/41649/2
Andreas Wolf [Fri, 17 Jul 2015 23:32:46 +0000 (01:32 +0200)]
[TASK] Clarify install tool no-password-set message

Change-Id: I4a66d5975921fdff64af33e4c745d5ab05ff0f70
Releases: master, 6.2
Resolves: #68324
Reviewed-on: http://review.typo3.org/41649
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Fix double encoded link text 31/41631/2
Gordon Brüggemann [Fri, 17 Jul 2015 19:54:38 +0000 (21:54 +0200)]
[BUGFIX] Fix double encoded link text

Resolves: #39290
Releases: master,6.2
Change-Id: If06c4e79e126fc347960a14da42cf3e6091d5c3e
Reviewed-on: http://review.typo3.org/41631
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
4 years ago[BUGFIX] Remove PHP notice in getModuleData() 86/41586/2
Benjamin Mack [Fri, 17 Jul 2015 16:25:56 +0000 (18:25 +0200)]
[BUGFIX] Remove PHP notice in getModuleData()

Resolves: #60979
Releases: master, 6.2
Change-Id: Idb45d769ece09d8bfeae1f1ba74ced85a5fa9768
Reviewed-on: http://review.typo3.org/41586
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 years ago[BUGFIX] OpenID service uses incorrect priorities to check returned data 78/41578/2
Dmitry Dulepov [Thu, 16 Jul 2015 08:57:36 +0000 (11:57 +0300)]
[BUGFIX] OpenID service uses incorrect priorities to check returned data

OpenID servers return several identifiers that can be used for user
authentication. According to the speciciation openid.claimed_id
is authoritative for authentication if it is set. openid.identity
can be used but openid.claimed_id is more authoritative.

Usually those two identifiers are the same. But some OpenID servers
(namely UNINETT AS server) provide different values for these
identifiers. In such cases preferred value is in the
openid.claimed_id as defined by the specification. However the code
in the OpenID service fails to properly test that because of wrong
priorities during checks.

This fix changes priorities of checks.

Change-Id: I61461f3258ffbd6caad89cd3163e79bfdc70d555
Resolves: #68205
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/41578
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[FOLLOWUP][TASK] Reduce SQL queries of page tree in workspaces 53/41553/2
Nicole Cordes [Fri, 17 Jul 2015 09:57:51 +0000 (11:57 +0200)]
[FOLLOWUP][TASK] Reduce SQL queries of page tree in workspaces

The patch adds a check if workspaces is activated before using its
class and function.

Releases: 6.2
Resolves: #50349
Resolves: #66231
Related: #61184
Change-Id: I12bc2d496f2216725ac97a8640bc6c431630cc7a
Reviewed-on: http://review.typo3.org/41553
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[BUGFIX] Do not log out a logged out user 66/41466/3
Helmut Hummel [Thu, 16 Jul 2015 12:48:20 +0000 (14:48 +0200)]
[BUGFIX] Do not log out a logged out user

It can happen that the logout action of the logout
controller is called without a user being logged in.

To avoid a fatal error, we do not call the logoff
code any more and just do the redirect handling.

Releases: master, 6.2
Resolves: #68220
Change-Id: I06f6289d01c681d4b412910ded8e9894f377892d
Reviewed-on: http://review.typo3.org/41466
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
4 years ago[FOLLOWUP][BUGFIX] Check access to folder in FileListController 28/41428/2
Christian Kuhn [Thu, 16 Jul 2015 10:50:51 +0000 (12:50 +0200)]
[FOLLOWUP][BUGFIX] Check access to folder in FileListController

Duplicate use flag triggers PHP fatal error.

Change-Id: I4f4c66fa0d8b8ad1a4131a412d8843e930e0a6d2
Releases: 6.2
Resolves: #66693
Resolves: #56641
Reviewed-on: http://review.typo3.org/41428
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Reduce SQL queries of page tree in workspaces 25/41425/3
Nicole Cordes [Wed, 15 Jul 2015 19:22:00 +0000 (21:22 +0200)]
[TASK] Reduce SQL queries of page tree in workspaces

Nodes of the page tree are highlighted, if that particular node
has versioned elements in the current workspace. However, this is
determined by iterating over all tables and all records for each
page. If having installed many extensions with many tables and
many records, this will produce a lot of SQL queries.

This patch introduces a new cache for record versions per page which is
fetched once from the database. This cache is located within the
\TYPO3\CMS\Workspaces\Service\WorkspaceService and can be shared between
several other classes as this is implements a SingletonInterface.

Resolves: #50349
Resolves: #66231
Related: #61184
Releases: master, 6.2
Change-Id: Ibaef07bdab87147c6826af8578870c52803dfe03
Reviewed-on: http://review.typo3.org/41425
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[BUGFIX] Check access to folder in FileListController 11/40411/3
Nicole Cordes [Thu, 30 Apr 2015 16:12:27 +0000 (18:12 +0200)]
[BUGFIX] Check access to folder in FileListController

Currently if a folder isn't accessible for the user, the root folder
is taken as fallback solution. But this folder might be inaccessible as
well. This patch adds an access check for the returned folder and
turns thrown errors into flash messages.

Releases: master, 6.2
Resolves: #66693
Resolves: #56641
Change-Id: I310df8061edc790dde1034a27136365b4253ac7f
Reviewed-on: http://review.typo3.org/40411
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[BUGFIX] Ensure filemount path has trailing slash after upgrade 78/40478/4
Nicole Cordes [Sat, 20 Jun 2015 09:50:56 +0000 (11:50 +0200)]
[BUGFIX] Ensure filemount path has trailing slash after upgrade

Currently the upgrade wizard for filemounts  doesn't ensure trailing
slashes for the paths. This results in "invalid value" messages if
an user edit filemounts and has to choose the correct path again. This
patch adds missing trailing slashes for paths.

Resolves: #67643
Releases: 6.2
Change-Id: I145a08ac5d6b6675723a73b7ec7d1bfb3ca22303
Reviewed-on: http://review.typo3.org/40478
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
4 years ago[BUGFIX] Respect cached page config 32/41132/3
Andreas Fernandez [Mon, 27 Apr 2015 13:17:27 +0000 (15:17 +0200)]
[BUGFIX] Respect cached page config

On a cached page, initialise the page config only if it does not exist
yet. Merge the cached config with the template config to get the same
array as on a uncached page.

Releases: master, 6.2
Resolves: #66605
Change-Id: Idee4682cbfe5a8fb5f9522fc2f09e1c9bdb81396
Reviewed-on: http://review.typo3.org/41132
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
4 years ago[BUGFIX] Workspace grid remains empty due to AJAX timeout 59/41259/2
Stefan Rotsch [Thu, 9 Jan 2014 13:44:23 +0000 (14:44 +0100)]
[BUGFIX] Workspace grid remains empty due to AJAX timeout

With a large amount of unpublished changes, the workspace grid requires
a longer Ajax timeout than the default 30s (similar to the mass
actions).

Resolves: #54922
Releases: master, 6.2
Change-Id: I7e81e1f7ce989599c9fc17a6e698a31a79e474d5
Reviewed-on: http://review.typo3.org/41259
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
4 years ago[BUGFIX] Hide preview link on delete page in workspaces mode 28/41228/2
Oliver Hader [Thu, 12 Mar 2015 16:12:20 +0000 (17:12 +0100)]
[BUGFIX] Hide preview link on delete page in workspaces mode

If a page is marked to be deleted (delete placeholder) in the
workspace mode, offering a frontend preview does not make much
sense. Thus, the accordant button in the page module won't be
shown in that case.

Resolves: #65699
Releases: master, 6.2
Change-Id: Ib27721c5e4b52dc91872ddb2a2f494649e13dab5
Reviewed-on: http://review.typo3.org/41228
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Fix parseUserFuncArguments to respect 0 as argument 25/41225/2
Sascha Egerer [Tue, 14 Jul 2015 15:54:41 +0000 (17:54 +0200)]
[BUGFIX] Fix parseUserFuncArguments to respect 0 as argument

"0" must be an valid "last argument" value in the parseUserFuncArguments
method.

The implementation of the argument iteration must strictly check if
the arguments string is empty.

Change-Id: I8cee20a48030ea9163f55723d9027f39c43e5e1c
Resolves: #68132
Related: #61256
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/41225
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[FOLLOWUP][BUGFIX] Workspaces: Properly use slots to modify data 09/41209/3
Benjamin Mack [Tue, 14 Jul 2015 14:39:58 +0000 (16:39 +0200)]
[FOLLOWUP][BUGFIX] Workspaces: Properly use slots to modify data

Using slots in GridDataService does not work since passing
arguments by reference does not work. Since TYPO3 CMS 6.2
it's possible that the SignalSlotDispatcher returns
(modified) arguments.

Change-Id: I6a5e123bfc0d44d484e5b432e65a4d6cb50b75fb
Resolves: #60926
Releases: 6.2
Reviewed-on: http://review.typo3.org/41209
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Workspaces: Properly use slots to modify data 91/41191/2
Oliver Hader [Wed, 13 Aug 2014 07:55:30 +0000 (09:55 +0200)]
[BUGFIX] Workspaces: Properly use slots to modify data

Using slots in GridDataService does not work since passing
arguments by reference does not work. Since TYPO3 CMS 6.2
it's possible that the SignalSlotDispatcher returns
(modified) arguments.

Resolves: #60926
Releases: master, 6.2
Change-Id: If7f3a782bf8870bfb158c566df01cf2311fce048
Reviewed-on: http://review.typo3.org/41191
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Fix invalid HTML in ElementBrowser 72/41172/2
Markus Klein [Mon, 13 Jul 2015 18:55:44 +0000 (20:55 +0200)]
[BUGFIX] Fix invalid HTML in ElementBrowser

An old implementations expected icons to be img-tags, which
is not the case anymore. The regex for replacing parts of the
tag do not work with the span tags anymore and therefore all
calls to the function are dropped.

Resolves: #68086
Releases: master, 6.2
Change-Id: I073e6e2d640ac5f53ae13ec564e6f8903b65e8b8
Reviewed-on: http://review.typo3.org/41172
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Show uncaught errors in Extension Manager 18/40918/2
Andreas Fernandez [Fri, 3 Jul 2015 07:41:17 +0000 (09:41 +0200)]
[TASK] Show uncaught errors in Extension Manager

Errors in the Extension Manager (e.g. deleting an extension w/o proper
file permissions) are now caught and displayed as a flash message.

Resolves: #67898
Releases: master, 6.2
Change-Id: I8f8334f2f0ea1c2fcf3ab49122c2c52447efc904
Reviewed-on: http://review.typo3.org/40918
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[BUGFIX] Double protocol when using TCEMAIN.previewDomain 22/41122/2
Wouter Wolters [Sat, 11 Jul 2015 09:58:48 +0000 (11:58 +0200)]
[BUGFIX] Double protocol when using TCEMAIN.previewDomain

In EXT:viewpage the option TCEMAIN.previewDomain is used but
not evaluated correctly. The option can contain the protocol
already and this is not respected in EXT:viewpage.

Check if domain already contains a protocol.

Resolves: #34820
Resolves: #36542
Resolves: #23115
Releases: master, 6.2
Change-Id: I13f7cda1dca54d60d350ba460e43ec924c140d35
Reviewed-on: http://review.typo3.org/41122
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Wrong directory path checked while unzipping extension 23/41123/2
Wouter Wolters [Sat, 11 Jul 2015 12:29:18 +0000 (14:29 +0200)]
[BUGFIX] Wrong directory path checked while unzipping extension

Uploading an extension a zip file has a wrong check for directory
existence. Fix the path to this directory in the check.

Resolves: #65702
Releases: master,6.2
Change-Id: I61b46a6f9efb55e3f8b6843597a31b458752fc46
Reviewed-on: http://review.typo3.org/41123
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Ensure PageRenderer singleton is set 12/41112/3
Helmut Hummel [Sun, 12 Jul 2015 13:10:37 +0000 (15:10 +0200)]
[BUGFIX] Ensure PageRenderer singleton is set

Before rendering _INT content objects, the page renderer is unserialized
and stored in a TypoScriptFrontendController property. However this new
object is not updated in the singleton store in GeneralUtility.

This leads to the situation that plugin code that (legally) just instantiate
the page renderer using GeneralUtility::makeInstance() receive the wrong object.

Make sure the singleton store is updated once the page renderer is unserialized
for _INT processing.

Releases: master, 6.2
Resolves: #68061
Change-Id: I162b8a4dc102ffd8cc0fcc4d21ccc271c861b187
Reviewed-on: http://review.typo3.org/41112
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[BUGFIX] Add a dummy distinguished name to CSR generation 53/40453/2
Alexander Krist [Wed, 17 Jun 2015 16:28:39 +0000 (18:28 +0200)]
[BUGFIX] Add a dummy distinguished name to CSR generation

Add a dummy distinguished name to CSR generation in PhpBackend to fix a
problem with certain openssl versions, specifically a Gentoo Linux,
Kernel 3.8.3-hardened, OpenSSL 1.0.1f, PHP 5.4.24

Change-Id: I5c34d764077fe7561835d0e1b9b4fd47088a8de1
Resolves: #55396
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/40453
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] dbal: make admin_get_tables() return correct table information 58/41058/2
Morton Jonuschat [Wed, 20 May 2015 19:26:35 +0000 (21:26 +0200)]
[BUGFIX] dbal: make admin_get_tables() return correct table information

Return the table information in the documented format (array with
tablenames as key and arrays with status information as value).

Resolves: #67067
Releases: master, 6.2
Change-Id: I7a35c5cfdaa469c407f5c4e4f80b55625034be91
Reviewed-on: http://review.typo3.org/41058
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] keep options array for TableGarbageCollectionTask 39/40939/3
Daniel Neugebauer [Wed, 1 Jul 2015 17:48:21 +0000 (19:48 +0200)]
[BUGFIX] keep options array for TableGarbageCollectionTask

scheduler now keeps an options sub-array if it has been populated
before ext_localconf.php runs.

User can define additional options for TableGarbageCollectionTask as
per extension documentation, i.e. tables can be added from user
configuration files such as AdditionalConfiguration.php.

Resolves: #67874
Releases: master, 6.2
Change-Id: I9eee7e1315e4a5049cee9db694c1f5a8375c8475
Reviewed-on: http://review.typo3.org/40939
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Prevent exclude field mixup in FormEngine 72/40272/3
Alexander Stehlik [Mon, 15 Jun 2015 20:17:32 +0000 (22:17 +0200)]
[BUGFIX] Prevent exclude field mixup in FormEngine

Use a local variable for storing the excluded fields in the
FormEngine to prevent the configuration from being overwritten
by the inline form element renderer.

Resolves: #47359
Releases: master, 6.2
Change-Id: I5a7a2de16d767f854b4d3f89d599deec28266092
Reviewed-on: http://review.typo3.org/40272
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Remove wrong RewriteBase in _.htaccess 34/40934/2
Markus Klein [Mon, 6 Jul 2015 12:36:33 +0000 (14:36 +0200)]
[BUGFIX] Remove wrong RewriteBase in _.htaccess

The configuration now works independently of RewriteBase,
hence we must not define one.

Resolves: #67922
Releases: master, 6.2
Change-Id: Ib1e14f808fbf2e7abd08a4e85d2a3d4e8509060a
Reviewed-on: http://review.typo3.org/40934
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Clear opcode cache on extension install/update 30/40930/3
Alexander Opitz [Mon, 6 Jul 2015 12:47:04 +0000 (14:47 +0200)]
[BUGFIX] Clear opcode cache on extension install/update

Resolves: #65066
Releases: master, 6.2
Change-Id: If3d665b696f3847d91486afcffee7b62fd32b60a
Reviewed-on: http://review.typo3.org/40930
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] No exceptions in GeneralUtility::rmdir 17/40917/2
Alexander Opitz [Fri, 3 Jul 2015 12:47:14 +0000 (14:47 +0200)]
[BUGFIX] No exceptions in GeneralUtility::rmdir

The API returns TRUE on success and FALSE if something went wrong.
So we need to prevent that the ErrorHandler comes up, as it throws
Core\Error exceptions.

Resolves: #67897
Releases: master, 6.2
Change-Id: I2912241dd3c9a1b9928b4449ebc16897699fa9b5
Reviewed-on: http://review.typo3.org/40917
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>