Packages/TYPO3.CMS.git
10 months ago[BUGFIX] Assure that $_POST is never set to null 82/58682/4
Daniel Goerz [Wed, 24 Oct 2018 08:05:24 +0000 (10:05 +0200)]
[BUGFIX] Assure that $_POST is never set to null

Resolves: #86731
Releases: master
Change-Id: Ia48925cf98637d7c7b2ecfb071bc935508032dec
Reviewed-on: https://review.typo3.org/58682
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Sattler <sattler@b13.de>
Tested-by: Daniel Sattler <sattler@b13.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
10 months ago[TASK] Update php-cs-fixer configuration to exclude _generated directory 83/58683/2
Sybille Peters [Wed, 24 Oct 2018 08:21:38 +0000 (10:21 +0200)]
[TASK] Update php-cs-fixer configuration to exclude _generated directory

Resolves: #86730
Releases: master, 8.7
Change-Id: I9e707e6d9c1305baa92b7f2c4c0f83bbeea52daa
Reviewed-on: https://review.typo3.org/58683
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
10 months ago[BUGFIX] Remove `fbclid` argument from chash calculation 71/58671/2
Andreas Fernandez [Tue, 23 Oct 2018 06:17:56 +0000 (08:17 +0200)]
[BUGFIX] Remove `fbclid` argument from chash calculation

Facebook adds the `fbclid` argument to outbound URLs which triggers a
recalculcation of the cache hash. The argument is now added to the
blacklist for chash parameters.

Resolves: #86715
Releases: master, 8.7, 7.6
Change-Id: I8cd66fdfa2c549c65750d6ef896261cccba4b54d
Reviewed-on: https://review.typo3.org/58671
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
11 months ago[TASK] Remove duplicate XLIFF entry 70/58670/4
Xavier Perseguers [Mon, 22 Oct 2018 09:13:51 +0000 (11:13 +0200)]
[TASK] Remove duplicate XLIFF entry

Resolves: #86135
Releases: master
Change-Id: I2b77b58aeb5bdbd12e9186b1b18d8b82a9dbfe6d
Reviewed-on: https://review.typo3.org/58670
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Willi Wehmeier <wwwehmeier@gmail.com>
Tested-by: Willi Wehmeier <wwwehmeier@gmail.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
11 months ago[BUGFIX] Bring back findByUid behavior for L>0 35/58635/12
Tymoteusz Motylewski [Mon, 15 Oct 2018 10:20:48 +0000 (12:20 +0200)]
[BUGFIX] Bring back findByUid behavior for L>0

findByUid as well as getObjectByIdentifier will always overlay records
to a language from the global context.

This solves the problem with controller arguments not being translated,
when default language record was used in the URL.

Resolves: #86619
Releases: master
Related: #82363
Change-Id: I823cdc1118a8217e306473b1596d349cc7ca08d4
Reviewed-on: https://review.typo3.org/58635
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Alexander Grein <alexander.grein@gmail.com>
Tested-by: Alexander Grein <alexander.grein@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
11 months ago[TASK] Raise version of typo3/phar-stream-wrapper to 3.0.1 47/58647/3
Oliver Hader [Thu, 18 Oct 2018 10:15:38 +0000 (12:15 +0200)]
[TASK] Raise version of typo3/phar-stream-wrapper to 3.0.1

composer require typo3/phar-stream-wrapper:^3.0.1

Resolves: #86680
Releases: master
Change-Id: Id138feafe6a3507f2cee5e3650a343d9ba10cf64
Reviewed-on: https://review.typo3.org/58647
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
11 months ago[BUGFIX] Fix example of StaticRangeMapper 42/58642/2
Georg Ringer [Tue, 16 Oct 2018 05:28:24 +0000 (07:28 +0200)]
[BUGFIX] Fix example of StaticRangeMapper

The variables need to be strings and not integers.

Resolves: #86665
Releases: master
Change-Id: I6ee14d6865b954aa84208ed361b1a760bf9e0d26
Reviewed-on: https://review.typo3.org/58642
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
11 months ago[BUGFIX] Fix argument ordering of RecordHistoryStore 41/58641/3
Georg Ringer [Mon, 15 Oct 2018 19:46:52 +0000 (21:46 +0200)]
[BUGFIX] Fix argument ordering of RecordHistoryStore

The DataHandler must use the correct ordering of arguments of
RecordHistoryStore. Furthermore the sorting of the arguments in the
doc block is fixed.

Resolves: #86657
Releases: master
Change-Id: I3054cb5a94f0e84a5c93accfd6349b7c24dbc885
Reviewed-on: https://review.typo3.org/58641
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
11 months ago[BUGFIX] Minor typo in bamboo specs 44/58644/2
Christian Kuhn [Tue, 16 Oct 2018 12:51:53 +0000 (14:51 +0200)]
[BUGFIX] Minor typo in bamboo specs

Resolves: #86671
Releases: master
Change-Id: I66916f2b7570ef44884b8f268fc127685f710840
Reviewed-on: https://review.typo3.org/58644
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
11 months ago[BUGFIX] Always provide an array to applyControllerActionValues 95/58595/5
Daniel Siepmann [Mon, 8 Oct 2018 08:07:17 +0000 (10:07 +0200)]
[BUGFIX] Always provide an array to applyControllerActionValues

As applyControllerActionValues requires an array as 2nd argument by
reference, we make sure to provide an array as 2nd argument.

Resolves: #86592
Releases: master
Change-Id: If2d56da60302b8a2dea89f0b31c02eba41024d3d
Reviewed-on: https://review.typo3.org/58595
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
11 months ago[BUGFIX] Use consistent API for checking update status 20/58620/3
Susanne Moog [Fri, 12 Oct 2018 09:53:24 +0000 (11:53 +0200)]
[BUGFIX] Use consistent API for checking update status

Instead of re-implementing checking of update wizards in
the status report, the same methods for checking should be
used to generate the same status as the install tool upgrade
wizard section itself.

Resolves: #86632
Releases: master
Change-Id: Ifc0f282dcb42dd52b79e65c31e29f52b46e54593
Reviewed-on: https://review.typo3.org/58620
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
11 months ago[BUGFIX] Add link to "cleanup of AbstractRecordList breaks hook" documentation 85/58585/5
Tomas Norre Mikkelsen [Fri, 5 Oct 2018 16:35:00 +0000 (18:35 +0200)]
[BUGFIX] Add link to "cleanup of AbstractRecordList breaks hook" documentation

Releases: master
Resolves: #86583
Change-Id: Icbd41aba47a5cb3ba82485f505e6d90e21bc524e
Reviewed-on: https://review.typo3.org/58585
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
11 months ago[BUGFIX] Correct tooltips for pages in the page tree 16/58616/3
Tymoteusz Motylewski [Thu, 11 Oct 2018 14:32:48 +0000 (16:32 +0200)]
[BUGFIX] Correct tooltips for pages in the page tree

Make tooltips for pages in the page tree correct (in case of shortcuts,
and mountpoints).

* add missing fields to selection in page tree Repository
required by BackendUtility->titleAttribForPages()
* add guard clauses for page 0 to avoid unnecessary processing
* fixes several notices

Resolves: #86631
Releases: master
Change-Id: Ia0229203b78ef8c58e066ef3a587c1de1ee0b975
Reviewed-on: https://review.typo3.org/58616
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
11 months ago[BUGFIX] Use correct variable name in OnlineMedia.ts 19/58619/3
Georg Ringer [Fri, 12 Oct 2018 08:16:42 +0000 (10:16 +0200)]
[BUGFIX] Use correct variable name in OnlineMedia.ts

Resolves: #86630
Releases: master, 8.7
Change-Id: I4bce2665ed54cddc3a151445c5863c24ffac6df6
Reviewed-on: https://review.typo3.org/58619
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
11 months ago[BUGFIX] Return success when zero wizards run in upgrade:run 58/58558/4
Benjamin Franzke [Tue, 2 Oct 2018 12:12:08 +0000 (14:12 +0200)]
[BUGFIX] Return success when zero wizards run in upgrade:run

Having to run zero wizards (e.g. fully upgraded)
is obviously not an error.

Releases: master
Resolves: #86543
Change-Id: Ide967005581e7c5fa956f5ffdb2c482a4a2f2048
Reviewed-on: https://review.typo3.org/58558
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
11 months ago[BUGFIX] Correct inline foreign_unique with target type="group" handling 21/58421/5
Cyril Janody [Thu, 27 Sep 2018 22:31:10 +0000 (18:31 -0400)]
[BUGFIX] Correct inline foreign_unique with target type="group" handling

Using type="inline" and MM relations having type="group" (instead of
type="select") and foreign_unique defined results in a fatal since
group db relations have been resolved to an array in TcaGroup data
provider already.

Change-Id: I20d138e7622aafb097a11e60014f9e4398bae811
Resolves: #82104
Resolves: #84735
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/58421
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Cyril Janody <typo3@cjanody.com>
Tested-by: Cyril Janody <typo3@cjanody.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
11 months ago[BUGFIX] Disable dump autoloading in Composer mode 78/58578/4
Rune Piper [Fri, 5 Oct 2018 07:20:00 +0000 (09:20 +0200)]
[BUGFIX] Disable dump autoloading in Composer mode

This patch hides the "Dump autoload" button in the maintenance area when
in Composer mode, because it does nothing.

Resolves: #86565
Releases: master
Change-Id: Ib8f71f5a41189f97f02aed6b4c7cb69feabef724
Reviewed-on: https://review.typo3.org/58578
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Torben Hansen <derhansen@gmail.com>
Reviewed-by: Nikita Hovratov <nikita.h@live.de>
Tested-by: Nikita Hovratov <nikita.h@live.de>
Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[BUGFIX] Fix path when writing AdditionalConfiguration.php 71/58571/2
Alexander Stehlik [Wed, 3 Oct 2018 19:08:29 +0000 (21:08 +0200)]
[BUGFIX] Fix path when writing AdditionalConfiguration.php

Use the getAdditionalConfigurationFileLocation() method to
determine the path to the file.

Releases: master
Resolves: #86561
Change-Id: I61b52e8eeb99ab2575f75025712a17f4c8ea4a40
Reviewed-on: https://review.typo3.org/58571
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Reviewed-by: Rune Piper <kontakt@runepiper.de>
Tested-by: Rune Piper <kontakt@runepiper.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
11 months ago[BUGFIX] pages.content_from_pid suggest wizard should not suggest itself 97/58597/4
Josef Glatz [Tue, 9 Oct 2018 03:51:46 +0000 (05:51 +0200)]
[BUGFIX] pages.content_from_pid suggest wizard should not suggest itself

Make it impossible to select the page you are currently
working on within the suggest wizard result set.

In addition, the suggest has been improved to search also in the
following fields of page records:
* nav_title
* alias
* url

Releases: master, 8.7
Resolves: #86600
Related: #54867
Change-Id: Ifce04fc5f01b5585f2320901b56be8b9970d4762
Reviewed-on: https://review.typo3.org/58597
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
11 months ago[BUGFIX] Fix version preview checks in PageRepository 77/58577/2
Markus Klein [Thu, 4 Oct 2018 20:26:01 +0000 (22:26 +0200)]
[BUGFIX] Fix version preview checks in PageRepository

This patch corrects all conditions for version preview in the
PageRepository class, which have been converted incorrectly
with #85078.

Resolves: #86574
Releases: master
Change-Id: I9a77f2de7c6c8abab9e5b3a1012c1582ed863fdd
Reviewed-on: https://review.typo3.org/58577
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
11 months ago[TASK] Do not render robots metatag on pages with index,follow 90/58590/3
Richard Haeser [Sat, 6 Oct 2018 19:17:57 +0000 (21:17 +0200)]
[TASK] Do not render robots metatag on pages with index,follow

Index,follow is default behaviour for robots. In case that a page have
the index and follow attributes, the robots tag is not generated in
frontend.

Resolves: #86570
Releases: master
Change-Id: I951a25150f48bc16e15e8d10516be0347632cea0
Reviewed-on: https://review.typo3.org/58590
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Tested-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Marc Hirdes <hirdes@clickstorm.de>
Tested-by: Marc Hirdes <hirdes@clickstorm.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
11 months ago[BUGFIX] Avoid using hardcoded uid of repository record 09/58609/2
Georg Ringer [Wed, 10 Oct 2018 19:31:39 +0000 (21:31 +0200)]
[BUGFIX] Avoid using hardcoded uid of repository record

As some situations might lead to a different uid set in the database
the correct repository should be found by the method 'findOneTypo3OrgRepository'.

Resolves: #86591
Releases: master
Change-Id: I8a1b9e8241b054f4d864dd5474f9eddfeaa44a6c
Reviewed-on: https://review.typo3.org/58609
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
11 months ago[BUGFIX] Filelist: fix file/folder pasteFileInto in file tree context menu 06/58606/3
Josef Glatz [Wed, 10 Oct 2018 04:30:00 +0000 (05:30 +0100)]
[BUGFIX] Filelist: fix file/folder pasteFileInto in file tree context menu

Provide missing data attributes for the context menu paste action.

Resolves: #86613
Releases: master
Change-Id: Ieafa22ca1456ac51cf217d30dbf1b762c9b6c923
Reviewed-on: https://review.typo3.org/58606
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Tested-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
11 months ago[BUGFIX] Let FileBrowser render the readable directory path 01/58601/3
Andreas Fernandez [Tue, 9 Oct 2018 12:46:32 +0000 (14:46 +0200)]
[BUGFIX] Let FileBrowser render the readable directory path

The FileBrowser is changed to render the human readable path of a
directory instead of the raw identifier.

Resolves: #86603
Releases: master, 8.7
Change-Id: I437075cfdeb6adaeddd38a55ff6f4fbd5415a351
Reviewed-on: https://review.typo3.org/58601
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
11 months ago[TASK] Fix link in Changelog: Breaking-80929-TYPO3_DBMovedToExtension.rst 83/58583/4
Tomas Norre Mikkelsen [Fri, 5 Oct 2018 16:06:08 +0000 (18:06 +0200)]
[TASK] Fix link in Changelog: Breaking-80929-TYPO3_DBMovedToExtension.rst

Missing space between link text and link-href

Releases: master
Resolves: #86581
Change-Id: I8c8b131eee6b08862c4567f9393dfbdcc17f24d8
Reviewed-on: https://review.typo3.org/58583
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
11 months ago[BUGFIX] Do not cache content with different status code than 200 82/58582/3
Markus Klein [Fri, 5 Oct 2018 08:57:24 +0000 (10:57 +0200)]
[BUGFIX] Do not cache content with different status code than 200

Resolves: #83755
Releases: master, 8.7, 7.6
Change-Id: I6e13133f221137c63283ec1575fc405a38668b1a
Reviewed-on: https://review.typo3.org/58582
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Tested-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
11 months ago[BUGFIX] Fix site handling documentation 89/58589/2
Georg Ringer [Sat, 6 Oct 2018 19:16:14 +0000 (21:16 +0200)]
[BUGFIX] Fix site handling documentation

Since #86323 the structure of the site yaml file has been changed.
Fix the documentation accordingly.

Resolves: #86587
Releases: master
Change-Id: I776e06d9f790141507b0a884bf9e38f343b015a2
Reviewed-on: https://review.typo3.org/58589
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Christian Knauf <knauf@analog.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
11 months ago[BUGFIX] Records sitemap uses wrong data array 98/58598/3
Susanne Moog [Tue, 9 Oct 2018 10:12:29 +0000 (12:12 +0200)]
[BUGFIX] Records sitemap uses wrong data array

The records sitemap has an additional level of nesting for
data from database but was trying to access database data
on the first level resulting in missing URL parameters in
generated URLs.

This array access has been fixed.

Resolves: #86602
Releases: master
Change-Id: I0e5e368f177ad2fc4358b8ef8927e220536fa59f
Reviewed-on: https://review.typo3.org/58598
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
11 months ago[BUGFIX] Initialize arguments correctly in routing related ViewHelpers 79/58579/4
Daniel Goerz [Fri, 5 Oct 2018 07:34:51 +0000 (09:34 +0200)]
[BUGFIX] Initialize arguments correctly in routing related ViewHelpers

Being initialized with the correct default value of an empty array
the Viewhelper no longer leads to a fatal error if called without
the argument "parameters".

Additionally the argument "route" is marked as required.

Resolves: #86576
Releases: master
Change-Id: I3457b4292d4409826250d4c5b1ec53d087b2bd95
Reviewed-on: https://review.typo3.org/58579
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Rudy Gnodde <rgn@windinternet.nl>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
11 months ago[TASK] Improve click area of new content element wizard item 94/58594/4
Josef Glatz [Mon, 8 Oct 2018 03:30:00 +0000 (04:30 +0100)]
[TASK] Improve click area of new content element wizard item

The clickable area of a new content element wizard item
is improved now.

The <a>-tag was added around the Bootstrap 3 media object
childrens which makes it easier now to add a new content
element by clicking anywhere on the item.

The text shows also the hover-style when an editor hovers
the icon of a NCEW item. The user experience for editors
working on touch devices is also improved by this.

Resolves: #86590
Releases: master
Change-Id: Ib6dc65a0d926945e6e9dd8a9fe7b57e5ee27d8f9
Reviewed-on: https://review.typo3.org/58594
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
11 months ago[TASK] Fix formatting of lists in Changelog 87/58587/3
Sybille Peters [Sat, 6 Oct 2018 17:19:22 +0000 (19:19 +0200)]
[TASK] Fix formatting of lists in Changelog

Lists in reStructuredText must be seperated by the rest of a text
a newline. If not, the text is not rendered correctly.
This patch fixes incorrectly formatted lists in the .rst files of
the Changelog.

Resolves: #85995
Releases: master,8.7
Change-Id: Icc390862f77ee99a5f96373e85ef5e09ac4272d5
Reviewed-on: https://review.typo3.org/58587
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
11 months ago[BUGFIX] Omit `overrideVals` in NewRecordController 61/58561/3
Andreas Fernandez [Tue, 2 Oct 2018 14:51:38 +0000 (16:51 +0200)]
[BUGFIX] Omit `overrideVals` in NewRecordController

In the old times of pages_language_overlay, the "New Record" wizard
automatically re-used the doktype of the parent table which was `pages`.
Since pages_language_overlay vanished, the `overrideVals` in the links in
the wizard use the `pages` table.

This results in invalid value for `doktype` if a page in pid=0 is
created, as pid=0 has no doktype.

For this reason, the `overrideVals` parameter is removed.

Resolves: #86547
Related: #82445
Releases: master
Change-Id: I6efa699e5ef09eed6321ae68b5838682214376de
Reviewed-on: https://review.typo3.org/58561
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
11 months ago[TASK] Info about the new location of _.htaccess / _web.config 64/58564/4
Josef Glatz [Wed, 3 Oct 2018 05:00:00 +0000 (06:00 +0100)]
[TASK] Info about the new location of _.htaccess / _web.config

Resolves: #86484
Releases: master
Change-Id: Ie711a5de0849081389e78dd32b60a3a451e58eec
Reviewed-on: https://review.typo3.org/58564
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Peter Kraume <peter.kraume@gmx.de>
Tested-by: Peter Kraume <peter.kraume@gmx.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
11 months ago[BUGFIX] Only English shown as BE language in Composer mode 60/58560/3
Andreas Wolf [Tue, 2 Oct 2018 14:21:37 +0000 (16:21 +0200)]
[BUGFIX] Only English shown as BE language in Composer mode

Using the legacy path for the l10n files folder does not work anymore in
Composer mode, as the folder was moved into `var/` there.

Change-Id: I61dea0e4e909c5640e776e558ca493015a539015
Resolves: #86546
Releases: master
Reviewed-on: https://review.typo3.org/58560
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
11 months ago[TASK] Add return type declaration to FileDumpController::dumpAction 74/58574/2
Benjamin Franzke [Wed, 3 Oct 2018 20:42:28 +0000 (22:42 +0200)]
[TASK] Add return type declaration to FileDumpController::dumpAction

For historical reasons FileDumpController::dumpAction was allowed to
return null. It didn't specify a nullable return type declaration because
it was not yed decided whether v9 will require php 7.2 or not.
With https://review.typo3.org/55585 FileDumpController was adapted to
return a PSR-7 Response but missed to update the function signature.
The nullable annotation is therefore removed now and the explicit
return type declaration is added.

Change-Id: I10e2cc60ab8e1f023c1beb6cf467bee1800971c8
Releases: master
Resolves: #86564
Reviewed-on: https://review.typo3.org/58574
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
11 months ago[TASK] Set COMPOSER_ROOT_VERSION=9.5.0 in bamboo 69/58569/2
Christian Kuhn [Wed, 3 Oct 2018 14:50:33 +0000 (16:50 +0200)]
[TASK] Set COMPOSER_ROOT_VERSION=9.5.0 in bamboo

Resolves: #86559
Releases: master
Change-Id: Ic691f77adaa521f1b5d3d7457fa9cfb81ef47663
Reviewed-on: https://review.typo3.org/58569
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
11 months ago[TASK] Update typo3/class-alias-loader from 1.0.0 to 1.0.1 66/58566/2
Christian Kuhn [Wed, 3 Oct 2018 13:11:15 +0000 (15:11 +0200)]
[TASK] Update typo3/class-alias-loader from 1.0.0 to 1.0.1

Tiny patch level release with cosmetical fixes.

composer update typo3/class-alias-loader

Resolves: #86555
Releases: master, 8.7, 7.6
Change-Id: Ib949e1aa961ea9aede1eeaebd5da9995a2a65bc0
Reviewed-on: https://review.typo3.org/58566
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
11 months ago[BUGFIX] Use chr(10) instead of LF in functional test data provider 63/58563/2
Christian Kuhn [Wed, 3 Oct 2018 10:04:18 +0000 (12:04 +0200)]
[BUGFIX] Use chr(10) instead of LF in functional test data provider

The functional test splitter script does not define LF and various
other constants, but loads test data providers to find out how
many tests they produce. Those data provider should not use LF,
the splitter throws PHP warnings otherwise.

Resolves: #86552
Releases: master
Change-Id: I89c0748ce595f1f7caee2934f4431b103f60471b
Reviewed-on: https://review.typo3.org/58563
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
11 months ago[BUGFIX] Adjust conditions for Symfony Expressions in RST-files 57/58557/4
Stefan Neufeind [Tue, 2 Oct 2018 08:35:50 +0000 (10:35 +0200)]
[BUGFIX] Adjust conditions for Symfony Expressions in RST-files

Since the original introduction of some new features the syntax used
for the expression was adjusted globally in TYPO3, leading to
examples no longer up-to-date in the documentation shipped as RSTs.

Resolves: #86541
Releases: master
Change-Id: I3c8b78fe05263a6cca5afa52d61f5ea5afe940a4
Reviewed-on: https://review.typo3.org/58557
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
11 months ago[BUGFIX] Update installation acceptance tests 59/58559/6
Mathias Brodala [Tue, 2 Oct 2018 13:28:18 +0000 (15:28 +0200)]
[BUGFIX] Update installation acceptance tests

The introduction package was revamped which brought us some text
changes, thus update the installation acceptance tests accordingly.

To mitigate an issue with certain databases causing a wrong casing of
column names, the DefaultTcaSchema now always quotes all column names
with backticks.

Resolves: #86544
Releases: master
Change-Id: Ic91368817bb775379302e904496c35537aaaa13c
Reviewed-on: https://review.typo3.org/58559
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
11 months ago[TASK] Set TYPO3 version to 9.5.1-dev 56/58556/2
Oliver Hader [Tue, 2 Oct 2018 08:11:35 +0000 (10:11 +0200)]
[TASK] Set TYPO3 version to 9.5.1-dev

Change-Id: If916407e7a7d9d54777ecee641bee5a604885ce2
Reviewed-on: https://review.typo3.org/58556
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
11 months ago[RELEASE] Release of TYPO3 9.5.0 55/58555/2 v9.5.0
Oliver Hader [Tue, 2 Oct 2018 08:10:15 +0000 (10:10 +0200)]
[RELEASE] Release of TYPO3 9.5.0

Change-Id: Ibacf4ce5d6c2a2e3f7aafb2c17536ab89dff1c15
Reviewed-on: https://review.typo3.org/58555
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
11 months ago[BUGFIX] Ensure that requirements in RouteEnhancers are optional 54/58554/2
Benni Mack [Tue, 2 Oct 2018 07:39:29 +0000 (09:39 +0200)]
[BUGFIX] Ensure that requirements in RouteEnhancers are optional

Resolves: #86539
Releases: master
Change-Id: Ia0a53b713382ae5cbbc9f5b57c82a532ba8f601b
Reviewed-on: https://review.typo3.org/58554
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
11 months ago[BUGFIX] Streamline PageTypeDecorator handling 53/58553/2
Oliver Hader [Tue, 2 Oct 2018 06:47:36 +0000 (08:47 +0200)]
[BUGFIX] Streamline PageTypeDecorator handling

* uses '&type=xyz' argument value of query in case no PageType decorator
  has been configured or if no value could be resolved (not defined in
  'map' nor as 'default' value)
* allows using 'default' value without having it defined in 'map' (values
  always should be explicit, however this is a fallback handling)

Resolves: #86538
Releases: master
Change-Id: I32ddbaebba916f875f6cd76609fce6b4172eee4d
Reviewed-on: https://review.typo3.org/58553
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
11 months ago[BUGFIX] Do not append slashes on slug importer 52/58552/3
Benni Mack [Tue, 2 Oct 2018 06:17:55 +0000 (08:17 +0200)]
[BUGFIX] Do not append slashes on slug importer

When importing from page_path of RealURL,
a slash is appended for all imported URLs,
however TYPO3 Core does not add slashes at the
end for new pages - which leads to a bad UX, having
mixed values.

However, with route enhancers, it is possible to add slashes
to the very end of a link, so it's useful to NOT have them
anymore inside the database.

Resolves: #86536
Releases: master
Change-Id: I50e941ec97a70654d9974757a6191b416aa40c29
Reviewed-on: https://review.typo3.org/58552
Reviewed-by: Kevin Appelt <kevin.appelt@icloud.com>
Reviewed-by: Willi Wehmeier <wwwehmeier@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
11 months ago[TASK] Improve changelog docs 51/58551/2
Daniel Siepmann [Tue, 2 Oct 2018 06:07:28 +0000 (08:07 +0200)]
[TASK] Improve changelog docs

* Fix wrong indentation level in example.
* Adjust sorting of paragraphs for explanation to match order of
  configuration options in example above.
* Keep example consistent. Remove single quotes around two keys in a
  single line, not used in other lines.
* Add syntax highlighting to SiteConfiguration syntax for environment
  variables.

Releases: master
Resolves: #86365, #86409
Change-Id: Ic7923bf7a3215f86637d3a8e20776f74666daf3f
Reviewed-on: https://review.typo3.org/58551
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
11 months ago[BUGFIX] Ensure LoadTcaService loads ext_tables.php 50/58550/2
Benni Mack [Tue, 2 Oct 2018 06:12:39 +0000 (08:12 +0200)]
[BUGFIX] Ensure LoadTcaService loads ext_tables.php

During deprecation of TYPO3_LOADED_EXT,
ext_tables.php is not loaded in "Check TCA in ext_tables.php"
anymore.

The fix loads the file correctly.

Resolves: #86534
Releases: master
Change-Id: If4ab1183704862bed7e2c6f657f8d80d9338d9f4
Reviewed-on: https://review.typo3.org/58550
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
11 months ago[BUGFIX] Reduce amount of false positives of extension scanner 49/58549/5
Georg Ringer [Mon, 1 Oct 2018 22:18:57 +0000 (00:18 +0200)]
[BUGFIX] Reduce amount of false positives of extension scanner

Reduce amount of false positives introduced with #86366 as methods
like 'getTitle()' are used too often.

Resolves: #86533
Releases: master
Change-Id: I97e7406cb5f134042fabf96ea3435c5c2f7ad665
Reviewed-on: https://review.typo3.org/58549
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
11 months ago[BUGFIX] Do not expand pseudo element `:after` to 100% in modals 47/58547/2
Andreas Fernandez [Mon, 1 Oct 2018 21:18:32 +0000 (23:18 +0200)]
[BUGFIX] Do not expand pseudo element `:after` to 100% in modals

This patch removes the unnecessary `width: 100%` definition. This fixes
the glitch in the image cropper.

Resolves: #86530
Related: #86445
Releases: master
Change-Id: Iaaf6e7f2f69bc526e245ec4b79ece00977c5c5d6
Reviewed-on: https://review.typo3.org/58547
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
11 months ago[TASK] Move documentation files into 9.5 folder - part 2 45/58545/3
Anja [Mon, 1 Oct 2018 19:50:09 +0000 (21:50 +0200)]
[TASK] Move documentation files into 9.5 folder - part 2

Change-Id: Ic2ad05680c072f901c200b05810be958204825db
Releases: master
Resolves: #86434
Reviewed-on: https://review.typo3.org/58545
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
11 months ago[BUGFIX] Fix decrementing of AJAX requests in extension scanner 39/58539/5
Andreas Fernandez [Mon, 1 Oct 2018 17:55:00 +0000 (19:55 +0200)]
[BUGFIX] Fix decrementing of AJAX requests in extension scanner

The queueing of AJAX requests in the extension scanner has some flaws
which causes the scanner to refuse another scan request.

The counter of pending requests is now always decremented, not only if
the amount of requests equals the threshold. Also, it's now checked if
there is any item in the request queue before shifting.

Instead of overriding the `success` and `error` callback, only `complete`
is now overridden, as this callback is executed on any return state.

To make the queueing part better maintainable and reusable, the code has
been moved into a separate module.

Resolves: #86523
Related: #86436
Releases: master
Change-Id: Ifa26ad7ce3bd81497c43b8606b902d467bdd1dda
Reviewed-on: https://review.typo3.org/58539
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
11 months ago[BUGFIX] XmlSitemapRenderer should use TSFE->type for page-type 40/58540/2
Stefan Neufeind [Mon, 1 Oct 2018 19:19:36 +0000 (21:19 +0200)]
[BUGFIX] XmlSitemapRenderer should use TSFE->type for page-type

When the new PageTypeEnhancer resolved type from a URL it is
not part of getQueryParams() but needs to be fetched from TSFE.

Resolves: #86527
Releases: master
Change-Id: I5041b042f1246f2ecc8adc8fa6cba123abfccf5b
Reviewed-on: https://review.typo3.org/58540
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
11 months ago[TASK] Update INSTALL.md and README.md 88/58388/10
Josef Glatz [Tue, 25 Sep 2018 11:55:17 +0000 (13:55 +0200)]
[TASK] Update INSTALL.md and README.md

The main goal of this patch is to update the neglected
INSTALL.md and README.md to represent the current
state of the requirements and to improve the overall
content of the two "entry" documentation files.

The install.md has been massively shortened and links to
the official guides were added to finally be able to have
one source of truth.

Resolves: #86487
Releases: master
Change-Id: Id61abf86a4113d25c940c63f1423fa341aa7e702
Reviewed-on: https://review.typo3.org/58388
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
11 months ago[BUGFIX] Fix EXT:core/bin/typo3 entry point in composer-mode 31/58531/7
Benjamin Franzke [Mon, 1 Oct 2018 11:49:03 +0000 (13:49 +0200)]
[BUGFIX] Fix EXT:core/bin/typo3 entry point in composer-mode

typo3/sysext/core/bin/typo3 does not work in composer mode
currently. Composer-based installations need to use the binary from
the composer "bin-dir", which is fine from a composer-usage point
of view – but hard for documentation.
Additionally the path to "typo3/sysext/core/bin/typo3" is hardcoded
in some places (e.g. scheduler).
We now make sure this binary works in composer mode as well,
using the same entry point strategy as for "typo3/index.php"
and "typo3/install.php".

Change-Id: I400ccd3a2bba4496c5d4ec9482e624cf8270a462
Releases: master
Resolves: #86513
Reviewed-on: https://review.typo3.org/58531
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
11 months ago[BUGFIX] Ensure most site related exceptions are handled 37/58537/6
Markus Klein [Mon, 1 Oct 2018 16:47:53 +0000 (18:47 +0200)]
[BUGFIX] Ensure most site related exceptions are handled

Make sure that in most places any site related exception is handled
in a graceful way to avoid negative UX.

Resolves: #86522
Releases: master
Change-Id: I3b0d7f9ce63351f8dd7bb6b4988704fc8a3d0a9f
Reviewed-on: https://review.typo3.org/58537
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Jurian Janssen <jurian.janssen@gmail.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Richard Haeser <richard@maxserv.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
11 months ago[BUGFIX] Resolve slashed values in PageTypeDecorator correctly 12/58512/15
Oliver Hader [Sun, 30 Sep 2018 22:52:13 +0000 (00:52 +0200)]
[BUGFIX] Resolve slashed values in PageTypeDecorator correctly

* slashed values are not resolved correctly concerning their
  dynamic '/' prefix in route paths
* adjusting route path and parameters might cause side effects
  when dealing with multiple decorating enhancers
* test cases for resolving and generating URIs using new
  PageTypeDecorator enhancer are added

Resolves: #86506
Releases: master
Change-Id: I3757933c47ea0f06d88bb27a635c2077e8f673b1
Reviewed-on: https://review.typo3.org/58512
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
11 months ago[BUGFIX] Make redirect sources with Query matchable 22/58522/6
Daniel Goerz [Mon, 1 Oct 2018 11:26:33 +0000 (13:26 +0200)]
[BUGFIX] Make redirect sources with Query matchable

Resolves: #86503
Releases: master
Change-Id: Iaf924b9f851bd25cb2d16ab5e5656703603a669b
Reviewed-on: https://review.typo3.org/58522
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
11 months ago[TASK] Streamline phpdoc annotations in EXT:extbase 35/58535/2
Benni Mack [Mon, 1 Oct 2018 16:03:21 +0000 (18:03 +0200)]
[TASK] Streamline phpdoc annotations in EXT:extbase

EXT:extbase uses @api and @internal phpDoc annotations. Going with a cleaner
approach with marking code as just @internal, and everything not annotated
as @internal is public, is the way to go, also the way PSR-5 is heading.

For EXT:extbase: Every PHP class that had nothing marked, is now @internal,
everything that was @api is now implicitly part of TYPO3 Core API.

On top, all license headers and @license annotations have been streamlined.

This means:
- TYPO3 Core's PHP classes area all public API by default
   unless marked as @internal or an extension class
- @api is not allowed anymore and will be restricted in
   the future from adding.
- @internal should be used for everything that should
   not be explicitly exposed as public API in the future.
- Everything under Tests/ is not part of TYPO3's Public API

Resolves: #86521
Releases: master
Change-Id: I83c5a27d9af001929142d2620600668ad0a84c92
Reviewed-on: https://review.typo3.org/58535
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
11 months ago[BUGFIX] Ensure Uri->getQuery() always returns a string 34/58534/2
Daniel Goerz [Mon, 1 Oct 2018 14:47:47 +0000 (16:47 +0200)]
[BUGFIX] Ensure Uri->getQuery() always returns a string

As stated in the Interface:
If no query string is present, this method MUST return an empty string.

Resolves: #86520
Releases: master, 8.7
Change-Id: I9869af08c84262443e503c34a2c608fbc5ba4bc2
Reviewed-on: https://review.typo3.org/58534
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
11 months ago[BUGFIX] Add user authentication to activate extension command 36/58536/2
Susanne Moog [Mon, 1 Oct 2018 16:24:39 +0000 (18:24 +0200)]
[BUGFIX] Add user authentication to activate extension command

As extensions might contain data to import the activate extension
command needs to initialize the user authentication so the data
handler may import data.

The backend user authentication initialization has been added to
the activate extension command.

Resolves: #86161
Releases: master
Change-Id: Id25c45bdfc8ac1cb930c9ed6adb49c39c17d7952
Reviewed-on: https://review.typo3.org/58536
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
11 months ago[TASK] Mark various parts with phpdoc internal - part 4 32/58532/2
Benni Mack [Mon, 1 Oct 2018 14:07:10 +0000 (16:07 +0200)]
[TASK] Mark various parts with phpdoc internal - part 4

All specific controllers for specific Backend actions, Backend-module related modules,
all hook implementations (where the core uses hooks by itself), and module-specific
ViewHelpers are now marked as @internal to ensure developers what is
part of the public TYPO3 Core API.

within
- EXT:core
- EXT:extensionmanager
- EXT:install

All @api annotations have been removed.

Resolves: #86517
Releases: master
Change-Id: I7869d8e3b6e8a4365529cc7c98b99cde7ca1495f
Reviewed-on: https://review.typo3.org/58532
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
11 months ago[TASK] Send uid of sys_redirect in Response Header 23/58523/6
Daniel Goerz [Mon, 1 Oct 2018 11:28:22 +0000 (13:28 +0200)]
[TASK] Send uid of sys_redirect in Response Header

Resolves: #86504
Releases: master
Change-Id: I115d1fcce00142b5e0eb34dbb840c785cf1b59f4
Reviewed-on: https://review.typo3.org/58523
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
11 months ago[TASK] Mark various parts with phpdoc internal - part 3 30/58530/2
Benni Mack [Mon, 1 Oct 2018 12:55:55 +0000 (14:55 +0200)]
[TASK] Mark various parts with phpdoc internal - part 3

All specific controllers for specific Backend actions, Backend-module related modules,
all hook implementations (where the core uses hooks by itself), and module-specific
ViewHelpers are now marked as @internal to ensure developers what is
part of the public TYPO3 Core API.

within
- EXT:indexed_search
- EXT:info
- EXT:linkvalidator
- EXT:lowlevel
- EXT:opendocs
- EXT:recordlist
- EXT:recycler
- EXT:redirects
- EXT:reports
- EXT:scheduler

All @api annotations have been removed.

Resolves: #86511
Releases: master
Change-Id: I80de460142266305c1af3ad437f939b7e4448676
Reviewed-on: https://review.typo3.org/58530
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
11 months ago[TASK] Streamline phpdoc annotations in EXT:fluid 25/58525/3
Benni Mack [Mon, 1 Oct 2018 11:59:15 +0000 (13:59 +0200)]
[TASK] Streamline phpdoc annotations in EXT:fluid

EXT:fluid uses @api and @internal phpDoc annotations. Going with a cleaner
approach with marking code as just @internal, and everything not annotated
as @internal is public, is the way to go, also the way PSR-5 is heading.

For EXT:fluid: Every PHP class that had nothing marked, is now @internal,
everything that was @api is now implicitly part of TYPO3 Core API.

Other areas will follow so the API for TYPO3 v9 LTS is clearer than ever.

Resolves: #86507
Releases: master
Change-Id: I5deba0ba2b868743e7eda8f0e32cda40ef008046
Reviewed-on: https://review.typo3.org/58525
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
11 months ago[BUGFIX] Fix log module bootstrap 16/58516/5
Susanne Moog [Mon, 1 Oct 2018 09:31:34 +0000 (11:31 +0200)]
[BUGFIX] Fix log module bootstrap

Resolves: #86498
Releases: master
Change-Id: I8605215706406a0a7826a1fe401ccd11d46ead73
Reviewed-on: https://review.typo3.org/58516
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
11 months ago[TASK] Mark various parts with phpdoc internal - part 2 29/58529/2
Benni Mack [Mon, 1 Oct 2018 12:36:07 +0000 (14:36 +0200)]
[TASK] Mark various parts with phpdoc internal - part 2

All specific controllers for specific Backend actions, Backend-module related modules,
all hook implementations (where the core uses hooks by itself), and module-specific
ViewHelpers are now marked as @internal to ensure developers what is
part of the public TYPO3 Core API.

within
- EXT:seo
- EXT:setup
- EXT:rte_ckeditor
- EXT:workspaces
- EXT:viewpage
- EXT:tstemplate
- EXT:taskcenter
- EXT:t3editor
- EXT:sys_action
- EXT:sys_note

All leftover @api methods have been removed.

Resolves: #86509
Releases: master
Change-Id: I6e5ee2302055de9ea4c124ca913e4677d62721fe
Reviewed-on: https://review.typo3.org/58529
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
11 months ago[TASK] Add proper exception handling to RouterInterface logic 19/58519/3
Benni Mack [Mon, 1 Oct 2018 10:42:06 +0000 (12:42 +0200)]
[TASK] Add proper exception handling to RouterInterface logic

Two new Exceptions are now thrown when routing does not
work, one being thrown when a URL is generated but could
not be generated, and one when a URL could not be resolved.

This is much cleaner than the distinction of a nullable return type,
so the new interface is adapted as well.

As a drive-by fix, the Backend routing exception now inherits from
this new exception.

Resolves: #86500
Releases: master
Change-Id: Ifaf7b61422dfd49df18399c3bcbdf735bc522cba
Reviewed-on: https://review.typo3.org/58519
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
11 months ago[TASK] Improve code to avoid Scrutinizer warnings 05/58505/5
Markus Klein [Sun, 30 Sep 2018 16:23:40 +0000 (18:23 +0200)]
[TASK] Improve code to avoid Scrutinizer warnings

Releases: master
Resolves: #86481
Change-Id: I87b9a07b6cc10c4379a6bf3e1c0e1695354b574a
Reviewed-on: https://review.typo3.org/58505
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
11 months agoRevert "[FEATURE] Add stdWrap to config.additionalHeaders" 17/58517/11
Markus Klein [Mon, 1 Oct 2018 09:37:52 +0000 (11:37 +0200)]
Revert "[FEATURE] Add stdWrap to config.additionalHeaders"

This reverts commit 2124bba49f68f5c35705c5c499abe6a0ee95a6cf.

The feature is reverted as the functionality can't be provided
in a fully working manner to work in all possible cases the FE
may be called.

Change-Id: Ia7caf3770b12737fd195da9d9f66bdc179981de8
Resolves: #86492
Reverts: #23494
Releases: master
Reviewed-on: https://review.typo3.org/58517
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
11 months ago[TASK] Add icons for install tool modules 28/58528/3
Benjamin Kott [Mon, 1 Oct 2018 12:35:28 +0000 (14:35 +0200)]
[TASK] Add icons for install tool modules

Resolves: #86510
Releases: master
Change-Id: I80692b806c3a7b51de3fad4947102e34956114a2
Reviewed-on: https://review.typo3.org/58528
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
11 months ago[TASK] Mark various parts with phpdoc internal 27/58527/2
Benni Mack [Mon, 1 Oct 2018 12:13:51 +0000 (14:13 +0200)]
[TASK] Mark various parts with phpdoc internal

All specific controllers for specific Backend actions, Backend-module related modules,
all hook implementations (where the core uses hooks by itself), and module-specific
ViewHelpers are now marked as @internal to ensure developers what is
part of the public TYPO3 Core API.

within
- EXT:felogin
- EXT:feedit
- EXT:filelist
- EXT:frontend
- EXT:fluid_styled_content
- EXT:impexp

All leftover @api methods have been removed.

Resolves: #86508
Releases: master
Change-Id: I97a6964a5f77dc9ee3d90365e9fda3d7d7be6266
Reviewed-on: https://review.typo3.org/58527
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
11 months ago[TASK] Mark various obvious code as @internal 24/58524/2
Benni Mack [Mon, 1 Oct 2018 11:41:20 +0000 (13:41 +0200)]
[TASK] Mark various obvious code as @internal

All specific controllers for specific Backend actions, Backend-module related modules,
all hook implementations (where the core uses hooks by itself), and module-specific
ViewHelpers are now marked as @internal to ensure developers what is
part of the public TYPO3 Core API.

within
- EXT:backend (except ViewHelpers)
- EXT:beuser
- EXT:about
- EXT:belog

All @api methods have been removed.

Resolves: #86505
Releases: master
Change-Id: I1fd1e16f7885e81fb994999e5873a1a3a1aa6c3b
Reviewed-on: https://review.typo3.org/58524
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
11 months ago[TASK] Update CKEditor icon to meet the new CKEditor CD 20/58520/2
Josef Glatz [Mon, 1 Oct 2018 11:15:45 +0000 (13:15 +0200)]
[TASK] Update CKEditor icon to meet the new CKEditor CD

This patch adds the newly added CKEditor v4 icon (via #86499)
to ext:rte_ckeditor as new extension icon.

`yarn && yarn build` was used to copy the file to the final location.

Releases: master
Resolves: #86501
Change-Id: I5225805f195eb2efe29a5deac6bb5426c313b604
Reviewed-on: https://review.typo3.org/58520
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Tested-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
11 months ago[TASK] Streamline phpdoc annotations in EXT:form 21/58521/2
Benni Mack [Mon, 1 Oct 2018 11:22:15 +0000 (13:22 +0200)]
[TASK] Streamline phpdoc annotations in EXT:form

EXT:form uses @api and @internal phpDoc annotations. Going with a cleaner
approach with marking code as just @internal, and everything not annotated
as @internal is public, is the way to go, also the way PSR-5 is heading.

For EXT:form: Every PHP class that had nothing marked, is now @internal,
everything that was @api is now implicitly part of TYPO3 Core API.

Other areas will follow so the API for TYPO3 v9 LTS is clearer than ever.

Resolves: #86502
Releases: master
Change-Id: I2c1efdd11f0fbaa992315a90049eb109e2620c76
Reviewed-on: https://review.typo3.org/58521
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
11 months ago[TASK] Update typo3/icons from 1.7.0 to 1.8.0 18/58518/2
Benjamin Kott [Mon, 1 Oct 2018 10:21:29 +0000 (12:21 +0200)]
[TASK] Update typo3/icons from 1.7.0 to 1.8.0

Following commands were used to update the external package
and copy the files/folders to the final location:
`yarn upgrade @typo3/icons@1.8.0 && yarn build`

Resolves: #86499
Releases: master
Change-Id: I87b571234257d82b1f2f09f523817c2eea2b26d2
Reviewed-on: https://review.typo3.org/58518
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
11 months ago[TASK] Adjust rst syntax for proper yaml and ts highlighting 15/58515/2
Daniel Siepmann [Mon, 1 Oct 2018 09:10:12 +0000 (11:10 +0200)]
[TASK] Adjust rst syntax for proper yaml and ts highlighting

Use proper code highlighting syntax for yaml and typoscript within 86160
changelog entry.

Resolves: #86160
Releases: master
Change-Id: I791956413885cabdfdf5693e9d0ad6c4be41a29d
Reviewed-on: https://review.typo3.org/58515
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
11 months ago[TASK] Adjust rst syntax for proper yaml highlighting 14/58514/2
Daniel Siepmann [Mon, 1 Oct 2018 07:55:18 +0000 (09:55 +0200)]
[TASK] Adjust rst syntax for proper yaml highlighting

Define default highlighting for 86365 changelog entry to be yaml. Adjust
all yaml occurrences within this entry to use default highlighting.

Releases: master
Resolves: #86365
Change-Id: I9063311830330d55ae051c8a0d38da78a2a91831
Reviewed-on: https://review.typo3.org/58514
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
11 months ago[BUGFIX] Improve performance of extension scanner 10/58510/3
Frank Naegler [Sun, 30 Sep 2018 21:45:56 +0000 (23:45 +0200)]
[BUGFIX] Improve performance of extension scanner

This patch adds a request queue for the massive amount of AJAX calls
in the extension scanner. This patch mitigates the problem of massive
server load in case the amount of files to be scanned is very high.

This patch mitigates the problem by allowing a maximum of 10 concurrent
requests. After the release of TYPO3 v9 LTS, this scanner module should
be refactored further.

Resolves: #86436
Releases: master
Change-Id: I824dfb74aae46d6b00690e7ca6553305c4221f0f
Reviewed-on: https://review.typo3.org/58510
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
11 months ago[FEATURE] Introduce PageTypeEnhancer 78/58478/14
Benni Mack [Sat, 29 Sep 2018 22:27:04 +0000 (00:27 +0200)]
[FEATURE] Introduce PageTypeEnhancer

A new PageTypeEnhancer is added to map the internal TYPO3
GET parameter `type` to a speaking URL suffix.

The PageTypeEnhancer only does suffixes, if other

You can configure it like this:

routeEnhancers:
  PageType:
    type: PageType
    default: ''
    map:
      '.html': 1
      'menu.json': 13

Resolves: #86160
Releases: master
Change-Id: Ie4b387963012946272568a69c9581e8d345dbe4c
Reviewed-on: https://review.typo3.org/58478
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[TASK] Rename RouteResult to SiteRouteResult 11/58511/2
Benni Mack [Sun, 30 Sep 2018 21:57:42 +0000 (23:57 +0200)]
[TASK] Rename RouteResult to SiteRouteResult

Resolves: #86489
Releases: master
Change-Id: I721c89b8afdc248b040a5e82cfd8c209dc84dbab
Reviewed-on: https://review.typo3.org/58511
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
11 months ago[BUGFIX] Streamline trigger_error messages 94/58494/4
Benni Mack [Sun, 30 Sep 2018 12:03:15 +0000 (14:03 +0200)]
[BUGFIX] Streamline trigger_error messages

This patch streamlines all deprecation messages and follow the
following rules.

1. All @deprecated should contain
@deprecated since TYPO3 xx, will be removed in TYPO3 v10.0 (not "core v10" or just "v10"

2. trigger_error()
- All trigger_error() messages MUST end with a "." (dot).
- Never use "This method" but the method name (enjoy the logs otherwise)
- "has been deprecated" can be spared - we KNOW it's deprecated once its in the deprecation log. Instead "Will be removed in TYPO3 v10.0" SHOULD be in the log file.
- Do not use "__METHOD__" or some other "magic".

Resolves: #86488
Releases: master
Change-Id: I6a34593ff89ecafe649366d60d725daa3aa6676c
Reviewed-on: https://review.typo3.org/58494
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
11 months ago[TASK] Add HTTP headers to Frontend Response object 99/58499/10
Benni Mack [Sun, 30 Sep 2018 13:23:28 +0000 (15:23 +0200)]
[TASK] Add HTTP headers to Frontend Response object

HTTP Headers are added to the PSR-7 response object now
within TSFE.

They are then sent at the very end of the request process.

A bw compat layer is added as well.

Resolves: #86486
Releases: master
Change-Id: Ifdeaab26868d0cf60dd87d52046a2565c4971488
Reviewed-on: https://review.typo3.org/58499
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[BUGFIX] Remove hardcoded index.php indexed search links 87/58387/3
Frank Naegler [Tue, 25 Sep 2018 10:53:18 +0000 (12:53 +0200)]
[BUGFIX] Remove hardcoded index.php indexed search links

Resolves: #86326
Releases: master
Change-Id: Ifbe8c5067c5a7e47188ea89f4e6df3db9192ac61
Reviewed-on: https://review.typo3.org/58387
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
11 months ago[TASK] Reintroduce tooltips for new SVG Pagetree 81/58481/6
Nikita Hovratov [Sun, 30 Sep 2018 00:06:06 +0000 (02:06 +0200)]
[TASK] Reintroduce tooltips for new SVG Pagetree

When hovering over a page-icon in the pagetree, a tooltip with the
id and status is now shown instead of a browser default title tooltip.

Resolves: #86314
Releases: master
Change-Id: I7d39841fa5085ea5bedb138e1d3e0eb036a3f402
Reviewed-on: https://review.typo3.org/58481
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
11 months ago[TASK] Adapt FAL dumpFile to use PSR-7 response objects 85/55585/15
Benjamin Franzke [Wed, 2 Aug 2017 14:06:54 +0000 (16:06 +0200)]
[TASK] Adapt FAL dumpFile to use PSR-7 response objects

A new driver method streamFile() is added (specified
in a new, internal StreamableDriverInterface).
streamFile() returns a PSR-7 response which serves
the contents of the file.

Once this interface will be marked as public, third party drivers
will be allowed to return an own response (e.g. containing a redirect
to a CDN), providing full controls to headers. It also opens
possibilties for optimizations like X-SendFile (apache) or
X-Accell-Redirect (nginx) to be used by drivers.

We also add SelfEmittableStreamInterface (marked as internal) to support
the same fast file sending using readfile() – the interface provides
a hook which is called by the AbstractApplication in sendResponse.
That means that file contents do not need to be read into memory, stored
into a stream, and then read again, but can be piped to stdout by php
directly.

For all existing drivers backward compatibility is provided by
wrapping their dumpFileContents() method into a decorator stream which
calls dumpFileContents *when* the response is sent.
That means middlewares are able to prevent/stop/enhance
the response, but the driver method dumpFileContents is still used –
it's delayed until Application::sendResponse.

The dumpFileContents method of the ResourceStorage class
is now deprecated. ResourceStorage->streamFile() should be used instead.

Change-Id: I64e707c1f8350e409ff2505b98531b92b2936e02
Releases: master
Resolves: #83793
Reviewed-on: https://review.typo3.org/55585
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
11 months ago[BUGFIX] Do not trigger tooltip automatically after hide/unhide 79/58479/2
Nikita Hovratov [Sat, 29 Sep 2018 22:47:02 +0000 (00:47 +0200)]
[BUGFIX] Do not trigger tooltip automatically after hide/unhide

The tooltip is not shown now, when you move the cursor away, while the
spinning icon is active. The new label still updates, if you keep the
cursor the whole time on the button.

Resolves: #85319
Releases: master, 8.7
Change-Id: Id653a9f6d43c1ca1f6a24112edde18b50286843f
Reviewed-on: https://review.typo3.org/58479
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[TASK] Use PageRepository in indexed search menu generation 92/58492/2
Benni Mack [Sun, 30 Sep 2018 11:33:26 +0000 (13:33 +0200)]
[TASK] Use PageRepository in indexed search menu generation

Use your own instance of PageRepository instead of depending
on TSFE, and use the menu by using the global context
and restrictions by using PageRepository instead of custom
DB queries.

Resolves: #86472
Releases: master
Change-Id: Ia480caace4d7415a8b43abc36b7dda5e314c0712
Reviewed-on: https://review.typo3.org/58492
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
11 months ago[TASK] Streamline labels of site configuration 08/58508/2
Susanne Moog [Sun, 30 Sep 2018 19:18:54 +0000 (21:18 +0200)]
[TASK] Streamline labels of site configuration

Labels have been rewritten to consequently use
title case. Additionally, the layout of the
main site tab has been adjusted.

Resolves: #86485
Releases: master
Change-Id: I5186c3a4506d546dc61ef8e4e9e41491b123ace4
Reviewed-on: https://review.typo3.org/58508
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
11 months ago[TASK] Migrate BackendWorkspaceRestriction to Context API 84/58484/5
Benni Mack [Sun, 30 Sep 2018 09:50:44 +0000 (11:50 +0200)]
[TASK] Migrate BackendWorkspaceRestriction to Context API

This patch also streamlines the Context API usage of
Workspaces in the main AbstractDataHandlerActionTestCase
class.

Resolves: #86465
Releases: master
Change-Id: I99e2a379e745494f9c23cca40ca4ad7ee1fc887f
Reviewed-on: https://review.typo3.org/58484
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[BUGFIX] Ensure deleted scheduler tasks are never run 39/58439/5
Benni Mack [Sun, 30 Sep 2018 16:03:24 +0000 (18:03 +0200)]
[BUGFIX] Ensure deleted scheduler tasks are never run

In #79777 a new "tx_scheduler_task.deleted" field was
added, but is not always considered when tasks are run.

Resolves: #86420
Related: #79777
Releases: master
Change-Id: Ide025bda13504bd56dc5f9cc090f5e7e54da6695
Reviewed-on: https://review.typo3.org/58439
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[TASK] Streamline Page Argument merge strategies 07/58507/2
Benni Mack [Sun, 30 Sep 2018 17:36:18 +0000 (19:36 +0200)]
[TASK] Streamline Page Argument merge strategies

PageArguments are fetched and added on top of PSR-7 request
queryParams right after they are validated from the PageRouter.

They are also re-populated after config.defaultGetVars has
modified global state.

But they do not need to be set to TSFE again within the
the PageArgumentValidator middleware.

Resolves: #86483
Releases: master
Change-Id: I03df4223832845038d4207417cfcab7cbcc687dc
Reviewed-on: https://review.typo3.org/58507
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[BUGFIX] Installer should use 50% of its space 06/58506/5
Benni Mack [Sun, 30 Sep 2018 16:52:33 +0000 (18:52 +0200)]
[BUGFIX] Installer should use 50% of its space

The Installer uses a full grid which is a lot of white space if not needed.

So, the whole layout is put into a col-md-6 grid with a col-md-offset-3
offset.

Resolves: #86482
Releases: master
Change-Id: If2e409deae98c0cf23eb7606a6cf35b950834874
Reviewed-on: https://review.typo3.org/58506
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
11 months ago[BUGFIX] Fix panel-collapse and modal-body padding-bottom in firefox 60/58460/2
Nikita Hovratov [Sat, 29 Sep 2018 15:55:29 +0000 (17:55 +0200)]
[BUGFIX] Fix panel-collapse and modal-body padding-bottom in firefox

* The last item in panel-collapse has now proper padding to its bottom.
* With a different behaviour of firefox a container having overflow-y
  ignores padding-bottom. A workaround is a pseudo-element reserving
  the same space as the padding attribute would have.

Resolves: #86445
Releases: master
Change-Id: I55b6318f1b59ceda65857726828deab5bc8a306f
Reviewed-on: https://review.typo3.org/58460
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
11 months ago[BUGFIX] Skip special doktype parent pages in slug generation 73/58473/4
Benni Mack [Sat, 29 Sep 2018 18:57:24 +0000 (20:57 +0200)]
[BUGFIX] Skip special doktype parent pages in slug generation

When checking the parent page for an existing slug, the parent page
should not be used if the parent page is a sys folder, spacer or
recycler (pages.doktype), but the traversal goes up.

This makes it a bit easier for editors to work with better-speaking
URLs and keep the rootline traversal as best practice.

Resolves: #86456
Releases: master
Change-Id: I2c46d096e41fb3a325fd42bf86b8968b79d6305b
Reviewed-on: https://review.typo3.org/58473
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[BUGFIX] Ensure workspace preview works with Site Handling 02/58502/3
Benni Mack [Sun, 30 Sep 2018 15:23:02 +0000 (17:23 +0200)]
[BUGFIX] Ensure workspace preview works with Site Handling

While introducing Page URL handling, the workspace functionality
still built the URL with `/index.php` although the Router should
take care of that now.

As drive-by fix, the BackendUtility preview URL hook now works again
due to some refactoring back in TYPO3 9.2.

Another drive-by fix allows to register the middleware at the
right place to render the workspace preview in general.

Resolves: #86480
Releases: master
Change-Id: Icfa5a5eee304c27db39cf25903b9a14452c81168
Reviewed-on: https://review.typo3.org/58502
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
11 months ago[BUGFIX] Avoid double slashes in slug generation 03/58503/2
Oliver Hader [Sun, 30 Sep 2018 15:34:58 +0000 (17:34 +0200)]
[BUGFIX] Avoid double slashes in slug generation

When generating slugs it might happen, that double slashes
are generated. This basically results from both prepending
and appending slashes at the same time.

Resolves: #86479
Releases: master
Change-Id: I441fee333cd0b3fbad3dde1a130eb08356bd4c2d
Reviewed-on: https://review.typo3.org/58503
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
11 months ago[TASK] Improve processing of mappable aspects 83/58483/3
Oliver Hader [Sun, 30 Sep 2018 08:40:21 +0000 (10:40 +0200)]
[TASK] Improve processing of mappable aspects

Improve processing by deferring those mappers that invoke persistence
the latest possible time. In case mappers do not match the processing
is stopped earlier to avoid superfluous checks and invocations.

Resolves: #86464
Releases: master
Change-Id: I4f9ec66611e84b49a54223f77aee824033a2fb7a
Reviewed-on: https://review.typo3.org/58483
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[TASK] Shorten the extend class in all unit tests 01/58501/2
Wouter Wolters [Sun, 30 Sep 2018 14:28:57 +0000 (16:28 +0200)]
[TASK] Shorten the extend class in all unit tests

Shorten \TYPO3\TestingFramework\Core\Unit\UnitTestCase to UnitTestCase

Resolves: #86478
Releases: master
Change-Id: I5dc7704fb2776cff26f1bbf89b35e28fecd9a79e
Reviewed-on: https://review.typo3.org/58501
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
11 months ago[BUGFIX] Display correct original state when invertStateDisplay is true 38/58238/4
Jigal van Hemert [Sun, 9 Sep 2018 11:01:24 +0000 (13:01 +0200)]
[BUGFIX] Display correct original state when invertStateDisplay is true

In the fieldWizard defaultLanguageDifferences the opposite value must be
displayed if invertStateDisplay is active in fields of type "check".

Resolves: #86205
Releases: master
Change-Id: Iac8fa73406b076b3d26a6ed3aed7e21b79220750
Reviewed-on: https://review.typo3.org/58238
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
11 months ago[BUGFIX] Remove unreachable return statement 98/58498/2
Christian Kuhn [Sun, 30 Sep 2018 13:20:22 +0000 (15:20 +0200)]
[BUGFIX] Remove unreachable return statement

Resolves: #86476
Releases: master
Change-Id: I182bd77895744d13ba535b43e46b802def49cb45
Reviewed-on: https://review.typo3.org/58498
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>