Packages/TYPO3.CMS.git
4 years ago[FOLLOWUP] Revamp EXT:recycler 46/36646/5
Frederic Gaus [Wed, 4 Feb 2015 10:17:28 +0000 (11:17 +0100)]
[FOLLOWUP] Revamp EXT:recycler

Fix a few coding issues in new EXT:recycler

* Remove IDE warnings
* Correct phpDoc
* Remove an unused variable
* Introduce a int typecast of GP:id
* Replace spaces with tabs

Change-Id: I8eaadd51c29506958d7fa80c375ddf943dfbac2f
Resolves: #64844
Releases: master
Reviewed-on: http://review.typo3.org/36646
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[ClEANUP] Drop some @throws from the tests bootstrap 45/36645/2
Oliver Klee [Wed, 4 Feb 2015 10:11:05 +0000 (11:11 +0100)]
[ClEANUP] Drop some @throws from the tests bootstrap

The exceptions mentioned in the removed @throws annotations do not
get thrown.

In addition, change an exception code to be unique. (It was used in two
places due to copy'n'paste.)

Resolves: #64843
Releases: master

Change-Id: I5f5fe054f3b3ddd96224b6bc6b4632cb9e375ede
Reviewed-on: http://review.typo3.org/36645
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] RTE: IE 11 always drops images at the end of text 42/36642/2
Stanislas Rolland [Wed, 4 Feb 2015 00:21:46 +0000 (19:21 -0500)]
[BUGFIX] RTE: IE 11 always drops images at the end of text

IE needs a delay before the dialogue window gets closed.

Releases: master
Resolves: #64839
Change-Id: I02d49cb124370c23ba14f8617dd4019586e184ea
Reviewed-on: http://review.typo3.org/36642
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] RTE: Image drag&drop with WebKit still using ExtJS event 41/36641/2
Stanislas Rolland [Tue, 3 Feb 2015 23:31:50 +0000 (18:31 -0500)]
[BUGFIX] RTE: Image drag&drop with WebKit still using ExtJS event

Migrate it to jQuery.

Releases: master
Resolves: #64838
Change-Id: I182c694b5e531b19aef11500319367a3481885f6
Reviewed-on: http://review.typo3.org/36641
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] RTE: Image drag & drop raises PHP error 40/36640/2
Stanislas Rolland [Tue, 3 Feb 2015 21:21:47 +0000 (16:21 -0500)]
[BUGFIX] RTE: Image drag & drop raises PHP error

Old class name was left over.

Releases: master
Resolves: #64649
Change-Id: Ie78c781d466e6fabfc11170d828a9e43544bad65
Reviewed-on: http://review.typo3.org/36640
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[FOLLOWUP] This is FormEngine 38/36638/2
Benjamin Kott [Tue, 3 Feb 2015 20:20:21 +0000 (21:20 +0100)]
[FOLLOWUP] This is FormEngine

Correct clearing for --linebreaks-- within palettes.

Releases: master
Resolves: #64762
Change-Id: I9a7473e073cb9d563da3a645e1813fbff7dc1102
Reviewed-on: http://review.typo3.org/36638
Reviewed-by: Frederic Gaus <gaus@flagbit.de>
Tested-by: Frederic Gaus <gaus@flagbit.de>
Reviewed-by: Steffen Müller <typo3@t3node.com>
Tested-by: Steffen Müller <typo3@t3node.com>
4 years ago[BUGFIX] Indexed search broken after moving "SearchResultContentObject" 66/36566/3
Benjamin Mack [Sun, 1 Feb 2015 12:09:31 +0000 (13:09 +0100)]
[BUGFIX] Indexed search broken after moving "SearchResultContentObject"

Indexed search still uses the old cobject in both
plugins.

The problem arieses in just to call one method from
SearchResultContentObject->register_and_explode_search_string()

The necessary functions are moved to the common
IndexedSearchUtility.

Resolves: #64716
Releases: master
Change-Id: I386330f1f66342ee838e3616cac7f0924bd31522
Reviewed-on: http://review.typo3.org/36566
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Create typo3temp directory in functional tests if missing 87/36587/4
Christian Kuhn [Mon, 2 Feb 2015 23:37:43 +0000 (00:37 +0100)]
[TASK] Create typo3temp directory in functional tests if missing

All functional tests are run in an encapsulated environment
within typo3temp. The functional bootstrap needs to take care
this directory exists.

Resolves: #64715
Releases: master
Change-Id: I07581db4d2c2cd9792dfde74ec9748c0824a549c
Reviewed-on: http://review.typo3.org/36587
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[CLEANUP] Remove @see comment from ArrayBrowser 20/36620/2
Wouter Wolters [Mon, 2 Feb 2015 22:12:37 +0000 (23:12 +0100)]
[CLEANUP] Remove @see comment from ArrayBrowser

The reference mentioned in @see does not exists.

Resolves: #64773
Releases: master
Change-Id: I3e63ffd330a783e2448c5207957d33fca119cf1b
Reviewed-on: http://review.typo3.org/36620
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 years ago[CLEANUP] \TYPO3\CMS\Lowlevel\Utility\ArrayBrowser 04/36604/4
Frederic Gaus [Mon, 2 Feb 2015 13:55:06 +0000 (14:55 +0100)]
[CLEANUP] \TYPO3\CMS\Lowlevel\Utility\ArrayBrowser

Cleanup \TYPO3\CMS\Lowlevel\Utility\ArrayBrowser

* phpDoc
* delete unused var
* remove unneeded fully qualified class names

Change-Id: Iced2fd79272a5142a7dd27d78c12a97f33b408d4
Resolves: #64765
Releases: master
Reviewed-on: http://review.typo3.org/36604
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Göran Bodenschatz <coding@46halbe.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Change $fixture to $subject in unit-tests 15/36615/4
Wouter Wolters [Mon, 2 Feb 2015 20:56:46 +0000 (21:56 +0100)]
[TASK] Change $fixture to $subject in unit-tests

Subject is the "system under test, the
subject you're operating on"

Resolves: #64771
Releases: master
Change-Id: I7a70d5f44e721b958d86aea741534ace2f53b2a8
Reviewed-on: http://review.typo3.org/36615
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 years ago[TASK] Removed unused code from tests 17/36617/3
Wouter Wolters [Mon, 2 Feb 2015 21:01:43 +0000 (22:01 +0100)]
[TASK] Removed unused code from tests

Remove unused code in:

FileMountRepositoryTest
CategoryRepositoryTest

Resolves: #64772
Releases: master
Change-Id: Ic1386778d5a108bbbdfebf56933b6ba1cd2ffa68
Reviewed-on: http://review.typo3.org/36617
Reviewed-by: Göran Bodenschatz <coding@46halbe.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 years ago[TASK] Add functional tests for dynamic values in Extbase query cache 63/29963/9
Marc Bastian Heinrichs [Thu, 8 May 2014 01:31:21 +0000 (03:31 +0200)]
[TASK] Add functional tests for dynamic values in Extbase query cache

For performance reasons Extbase caches database queries. To ensure the
security relevant aspect, the frontend usergroup has to be parameterized
and be added by runtime. This patch adds functional tests to ensure
query caching by:

* adding possibility to simulate a frontend user in functional tests
* extending blog_example extension TCA adding fe_group for blogs
* adding a plugin and controller for blog listing
* adding new fixtures with frontend usergroups restrictions
* adding functional tests and frontend rending function

Resolves: #58655
Releases: master
Change-Id: Ib6d918461d5ad04bc2236a375f558d48548c9946
Reviewed-on: http://review.typo3.org/29963
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Keep linktype on core update 45/36345/5
Frederic Gaus [Thu, 29 Jan 2015 09:59:20 +0000 (10:59 +0100)]
[BUGFIX] Keep linktype on core update

Keep the linktype of the symlink pointing to the TYPO3 core. Currently
the CoreUpdateService always creates an absolute link even if the
link was relative before. This patch checks for the correct link type
during a core update. This could be important in some environments,
e.g. in a chrooted environemnt.

Change-Id: I47bbe0d54a88853adc4160937a21d641b756f20f
Resolves: #58000
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/36345
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Göran Bodenschatz <coding@46halbe.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 years ago[FEATURE] Add SplFileInfo implementation to get file mimeType 56/31256/14
Sascha Egerer [Sat, 31 Jan 2015 23:17:56 +0000 (00:17 +0100)]
[FEATURE] Add SplFileInfo implementation to get file mimeType

\TYPO3\CMS\Core\Type\File\FileInfo provides a new method
getMimeType() to get the MIME type of a file, e.g. text/html.

Custom implementations to determine the MIME type can be added
with the hook:

$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS'][\TYPO3\CMS\Core\Type\File\FileInfo::class]['mimeTypeGuessers']

The FAL LocalDriver also uses this new API.

Resolves: #60019
References: #46777
Releases: master
Change-Id: Ia2fa95d2ef6452f8022e33f1b1d2a9336f3e0303
Reviewed-on: http://review.typo3.org/31256
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Steffen Müller <typo3@t3node.com>
Reviewed-by: Steffen Müller <typo3@t3node.com>
4 years ago[BUGFIX] Prevent double slash in canonicalizeAndCheckFolderIdentifier 43/36543/6
Sascha Egerer [Sat, 31 Jan 2015 20:45:39 +0000 (21:45 +0100)]
[BUGFIX] Prevent double slash in canonicalizeAndCheckFolderIdentifier

If the value given to AbstractHierarchicalFilesystemDriver->
canonicalizeAndCheckFolderIdentifier()
is '.' the return was '//' but should be '/'.

Resolves: #64706
Releases: master
Change-Id: I63900c44be3180b0a9b8e31d89c6c896382db6b7
Reviewed-on: http://review.typo3.org/36543
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[!!!][TASK] This is FormEngine 51/35951/35
Benjamin Kott [Sat, 10 Jan 2015 23:31:58 +0000 (00:31 +0100)]
[!!!][TASK] This is FormEngine

The patch brings responsive layout for FormEngine and its
elements. It fixes a couple of issues along the way,
escpecially DatePicker and palettes field are aligned in
a better way and wizard icons look much better.

Adjustments:
- Change datepicker to work directly on input without wrapper
- Change clearableJs to bootstrap
- Change dyntabs to bootstrap classes
- Change fixed-font to text-monospace
- Port CheckboxElement to boostrap
- Port GroupElement to bootstrap
- Port InputElement to bootstrap
- Port Irre/Inline to bootstrap
- Port Flexform to bootstrap
- Port Palettes to bootstrap
- Port RadioElements to bootstrap
- Port TextElement to bootstrap
- Port NoneElement to bootstrap

Removes:
- Unused change image javascript removed

Deprecations:
- cssClassTypeElementPrefix not used anymore
- maxTextareaWidth not used anymore
- paletteFieldTemplate not used anymore
- palFieldTemplateHeader not used anymore
- wizard config _PADDING
- wizard config _DISTANCE
- wrapOpenPalette not used anymore
- wrapPaletteField not used anymore
- formWidth not used anymore
- formWidthAsArray not used anymore
- addUserTemplateMarkers not used anymore

Releases: master
Resolves: #64762
Change-Id: I04ce24e63d2395fe25f7d5a314f5868882b2cd74
Reviewed-on: http://review.typo3.org/35951
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Frederic Gaus <gaus@flagbit.de>
Tested-by: Frederic Gaus <gaus@flagbit.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Remove superfluous getInstance calls in Bootstrap 10/36610/3
Helmut Hummel [Mon, 2 Feb 2015 19:21:29 +0000 (20:21 +0100)]
[BUGFIX] Remove superfluous getInstance calls in Bootstrap

Releases: 6.2, master
Resolves: #64770
Change-Id: I9ae4cd9476b45a17c0246edf65fb01a54b7dd24f
Reviewed-on: http://review.typo3.org/36610
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[BUGFIX] Remove duplicated use statement 01/36601/2
Anja Leichsenring [Mon, 2 Feb 2015 12:28:04 +0000 (13:28 +0100)]
[BUGFIX] Remove duplicated use statement

Change-Id: If8762600edaf2bd4b8d2b2fd811b900be91910b5
Releases: master
Resolves: #64761
Reviewed-on: http://review.typo3.org/36601
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Fixes TCA icon file for scheduler task group 98/36598/2
Eric Chavaillaz [Mon, 2 Feb 2015 11:34:25 +0000 (12:34 +0100)]
[BUGFIX] Fixes TCA icon file for scheduler task group

Resolves: #64729
Releases: master
Change-Id: I7e8630f87152df25cf66ba4c58c3ddb04303177d
Reviewed-on: http://review.typo3.org/36598
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years agoRevert "[CLEANUP] Rework/simplify copyright header and remove @package" 99/36599/3
Anja Leichsenring [Mon, 2 Feb 2015 11:50:18 +0000 (12:50 +0100)]
Revert "[CLEANUP] Rework/simplify copyright header and remove @package"

The licence change is no good idea.

This reverts commit 5504a1411a59623813fba1810d766e26f8029084.

Change-Id: I6d5427a953846d35dc5695f24b673c1c47139c17
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/36599
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUFGIX] Remove all existing processed files on file replace 42/36542/3
ruud [Sat, 31 Jan 2015 16:59:10 +0000 (17:59 +0100)]
[BUFGIX] Remove all existing processed files on file replace

When a file gets replaced by calling replaceFile() or by overriding
on uploading all processed files of the original file get removed.

Resolves: #63976
Releases: master, 6.2
Change-Id: I865503e46ac9044b22f976e0db5b163ac7e2e4c9
Reviewed-on: http://review.typo3.org/36542
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Thomas Deuling <tdeuling@gmail.com>
Tested-by: Thomas Deuling <tdeuling@gmail.com>
Reviewed-by: Ruud Silvrants <ruudsilvrants@gmail.com>
Tested-by: Ruud Silvrants <ruudsilvrants@gmail.com>
Reviewed-by: Roman Schürmann <roman.schuermann@wmdb.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
4 years ago[FOLLOWUP][!!!][TASK] Move old mailform to compatibility6 75/36575/2
Wouter Wolters [Sun, 1 Feb 2015 13:00:58 +0000 (14:00 +0100)]
[FOLLOWUP][!!!][TASK] Move old mailform to compatibility6

Resolves: #64668
Releases: master
Change-Id: Ibe2fdf4eb654da312f1dd58188dd7a55b83444be
Reviewed-on: http://review.typo3.org/36575
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Avoid to call recordInfo for new records 37/35237/7
Stephan Großberndt [Wed, 10 Dec 2014 11:15:53 +0000 (12:15 +0100)]
[BUGFIX] Avoid to call recordInfo for new records

Avoid to call recordInfo for new records in DataHandler->checkValue by
checking the id. This improves performance for bulk inserts.

Resolves: #63733
Releases: master, 6.2
Change-Id: I02c2d282f487defe3c74d89e7041ecb8b0eae7b8
Reviewed-on: http://review.typo3.org/35237
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Cleanup TYPO3\CMS\Install\FolderStructure 86/36586/3
Stephan Großberndt [Sun, 1 Feb 2015 16:50:13 +0000 (17:50 +0100)]
[TASK] Cleanup TYPO3\CMS\Install\FolderStructure

Shortens qualified names and fixes typos.

Resolves: #64724
Releases: master
Change-Id: Ia4a57744a939532c5078f94fef68b1401fa2662c
Reviewed-on: http://review.typo3.org/36586
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[CLEANUP] Drop unused variable $JS in GraphicsFunctions 85/36585/2
Oliver Klee [Sun, 1 Feb 2015 16:38:03 +0000 (17:38 +0100)]
[CLEANUP] Drop unused variable $JS in GraphicsFunctions

Resolves: #64703
Releases: master
Change-Id: I8312ff4e6465d9baf613149d252dfabd11ba257d
Reviewed-on: http://review.typo3.org/36585
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years agoRevert "[CLEANUP] MENU Content Object classes" 83/36583/2
Anja Leichsenring [Sun, 1 Feb 2015 16:28:06 +0000 (17:28 +0100)]
Revert "[CLEANUP] MENU Content Object classes"

This reverts commit 2bb692ae9fc1747372d4d0079f414e3782a65587.

Change-Id: I44fd2457bb39c7302ca9de141c15d3b34a67a936
Reviewed-on: http://review.typo3.org/36583
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Do not create uploads/tf directory 81/36581/2
Stephan Großberndt [Sun, 1 Feb 2015 15:12:27 +0000 (16:12 +0100)]
[TASK] Do not create uploads/tf directory

No longer create the directory uploads/tf in the default folder
structure in install tool. This directory was used until TYPO3 CMS 4.7
to store resources related to sys_template-records. The definition of
the "resources"-field was removed in TYPO3 CMS 6.0, but the default
folder creation was overlooked.

Resolves: #64721
Releases: master, 6.2
Change-Id: I96f14183d82d39945399b4554eb6216395cd852d
Reviewed-on: http://review.typo3.org/36581
Reviewed-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Adapt extension icons to App icon 93/34393/8
Felix Kopp [Thu, 20 Nov 2014 13:33:56 +0000 (14:33 +0100)]
[TASK] Adapt extension icons to App icon

Bring new extension icons based on the alredy existing App icons.

Resovles: #63099
Releases: master
Change-Id: Ie423ccd15aadecc4968556ad8fb71229f3e241d9
Reviewed-on: http://review.typo3.org/34393
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[FOLLOWUP][CLEANUP] Comments, usages and phpdoc of InlineElement 80/36580/2
Wouter Wolters [Sun, 1 Feb 2015 14:49:49 +0000 (15:49 +0100)]
[FOLLOWUP][CLEANUP] Comments, usages and phpdoc of InlineElement

Resolves: #64705
Releases: master
Change-Id: I4c777fa2cffacbeaad4bc1a8119d84ad0e2aa278
Reviewed-on: http://review.typo3.org/36580
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[CLEANUP] Comments, usages and phpdoc of InlineElement 44/36544/3
Stephan Großberndt [Sat, 31 Jan 2015 21:25:53 +0000 (22:25 +0100)]
[CLEANUP] Comments, usages and phpdoc of InlineElement

Clean up formatting, comments, typos, unused variables, uses and
phpdoc of TYPO3\CMS\Backend\Form\Element\InlineElement.

Resolves: #64705
Releases: master, 6.2
Change-Id: I9d9b2ea61350359c21f1b05a357027b5e6c7aa4b
Reviewed-on: http://review.typo3.org/36544
Reviewed-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Göran Bodenschatz <coding@46halbe.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[FOLLOWUP][BUGFIX] FAL: Do not paste a folder into itself 70/36570/2
Wouter Wolters [Sun, 1 Feb 2015 12:31:10 +0000 (13:31 +0100)]
[FOLLOWUP][BUGFIX] FAL: Do not paste a folder into itself

Add missing @throws annotation for the added function.

Also the correct exception is thrown in ResourceStorage
if it occurs anyway.

Resolves: #51670
Releases: master, 6.2
Change-Id: I52551012c88326cc3fd58d2e72e53f58fedb334b
Reviewed-on: http://review.typo3.org/36570
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
4 years ago[TASK] Remove leading slash from use statements 71/36571/2
Wouter Wolters [Sun, 1 Feb 2015 12:45:00 +0000 (13:45 +0100)]
[TASK] Remove leading slash from use statements

Resolves: #64718
Releases: master
Change-Id: I2ab9a4194f236ece9035d15dd4aa33ef9aa5371a
Reviewed-on: http://review.typo3.org/36571
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
4 years ago[CLEANUP] TranslationConfigurationProvider 58/30258/21
Sebastian Michaelsen [Thu, 29 Jan 2015 19:47:12 +0000 (20:47 +0100)]
[CLEANUP] TranslationConfigurationProvider

* Import class names with use statements
* Encapsulate $GLOBALS['TYPO3_DB'] and $GLOBALS['LANG'] in type-hinted
  getters
* Remove unused $backPath parameter of ->getSystemLanguages
  and adapt the core method calls
* Refactor ->getSystemLanguages method
* Refactor ->translationInfo method
* Break very long lines of code into smaller chunks
* Fix phpDoc issues
* Use lowerCamelCase for variable names

Releases: master
Resolves: #59004
Change-Id: Ib5cbcb19559a47b067a1e666528de3d6e23f406b
Reviewed-on: http://review.typo3.org/30258
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[TASK] Deprecate unused CSS Styled Content Controller methods 58/36558/2
Benjamin Mack [Sun, 1 Feb 2015 09:19:50 +0000 (10:19 +0100)]
[TASK] Deprecate unused CSS Styled Content Controller methods

Certain methods within CSS Styled Content Controller for
rendering TypoScript-based calculations can be deprecated
as there are proper TypoScript-based solutions already.

Resolves: #64711
Releases: master
Change-Id: I2a0868d03f64422fcccae492d002ec7b2c74efa0
Reviewed-on: http://review.typo3.org/36558
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Göran Bodenschatz <coding@46halbe.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Followup: Move functions to GraphicalFunctions 67/36567/5
Philipp Gampe [Sun, 1 Feb 2015 12:11:52 +0000 (13:11 +0100)]
[BUGFIX] Followup:  Move functions to GraphicalFunctions

Change back to the old behavior to return the orginal file in case no
png_to_gif convertion should happen.

Resolves: #46589
Releases: master
Change-Id: I2815ce0767c8c0d8466972cb094239fdde03364f
Reviewed-on: http://review.typo3.org/36567
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Jana Kienast <jana.a.kienast@gmail.com>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Andrea Herzog-Kienast <a.herzog@kienastdv.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
4 years ago[FOLLOWUP][TASK] Remove legacy CSS Styled Content TS prior to 6.2 76/36576/2
Benjamin Mack [Sun, 1 Feb 2015 13:13:26 +0000 (14:13 +0100)]
[FOLLOWUP][TASK] Remove legacy CSS Styled Content TS prior to 6.2

In the process of removing legacy code, the states
for CSS Styled Content Templates for 6.1, 6.0, 4.7, 4.6, 4.5
are removed without substitution.

Resolves: #64637
Releases: master
Change-Id: I75bd3e79df099618c2669e7dad8f784f91174865
Reviewed-on: http://review.typo3.org/36576
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Check for not allowed file extensions in element browser 96/36496/8
Armin Ruediger Vieweg [Fri, 30 Jan 2015 18:45:14 +0000 (19:45 +0100)]
[BUGFIX] Check for not allowed file extensions in element browser

When adding files from element browser, an additional check
will ensure that files with extensions that are not allowed
in TCA configuration can no longer be added.

Resolves: #64621
Releases: master
Change-Id: I43adc9292a34391a3e0c7c9f5c476aa399565e44
Reviewed-on: http://review.typo3.org/36496
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Tested-by: Sascha Egerer <sascha@sascha-egerer.de>
4 years ago[BUGFIX] Enhancing StripNewLinesFilter for Windows line breaks 64/36564/3
Ronny Vorpahl [Sun, 1 Feb 2015 11:20:58 +0000 (12:20 +0100)]
[BUGFIX] Enhancing StripNewLinesFilter for Windows line breaks

Currently the filter does not handle Windows line breaks.
This results in unfiltered Windows line breaks.
This patch adds Windows line break support to the filter function.
Furthermore the unit tests for the filter are extended to check
Windows line breaks as well.

Resolves: #64710
Releases: master,6.2
Change-Id: I503657daaf693f1a28589bc7d8a9321ebae54e61
Reviewed-on: http://review.typo3.org/36564
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Prevent folder deletion with referenced files 13/36413/14
Armin Ruediger Vieweg [Fri, 30 Jan 2015 11:57:34 +0000 (12:57 +0100)]
[BUGFIX] Prevent folder deletion with referenced files

Currently a folder can be deleted without any check if included files
are still in use anywhere within the website. This can lead to lost
files and can be harmful for the user. The patch adds a test if files
within a folder, which should be deleted, are still referenced and
prevents deleting it if files where found. The user is notified with a
warning shown above the file list.

Resolves: #48893
Releases: master, 6.2
Change-Id: If1c79d86e1f6c7a32a6a3e94e639951f882302d7
Reviewed-on: http://review.typo3.org/36413
Reviewed-by: Ingo Schmitt <is@marketing-factory.de>
Tested-by: Ingo Schmitt <is@marketing-factory.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Armin Ruediger Vieweg <armin@v.ieweg.de>
Tested-by: Andrea Herzog-Kienast <a.herzog@kienastdv.de>
Reviewed-by: Thomas Deuling <tdeuling@gmail.com>
Tested-by: Thomas Deuling <tdeuling@gmail.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[CLEANUP] MENU Content Object classes 64/35764/8
Markus Klein [Sun, 4 Jan 2015 02:23:10 +0000 (03:23 +0100)]
[CLEANUP] MENU Content Object classes

Resolves: #64099
Releases: master
Change-Id: I99ee03ad11ed65b9fe9df5f20fe1ad7f54df03f4
Reviewed-on: http://review.typo3.org/35764
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[CLEANUP] Fix TYPO3.ControlStructures.DisallowEachInLoopCondition-Sniff 70/32070/5
Andy Grunwald [Sun, 10 Aug 2014 17:19:37 +0000 (19:19 +0200)]
[CLEANUP] Fix TYPO3.ControlStructures.DisallowEachInLoopCondition-Sniff

Resolves: #60876
Releases: master
Change-Id: Ifc630f26bd5670ce2f3c6f62522face4514fdbd6
Reviewed-on: http://review.typo3.org/32070
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Mateusz Wojtuła <matw88@gmail.com>
Reviewed-by: Zbigniew Jacko <z.jacko@macopedia.pl>
Reviewed-by: Göran Bodenschatz <coding@46halbe.de>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[FOLLOWUP][CLEANUP] Wrap the tests bootstrap code into classes 68/36568/2
Wouter Wolters [Sun, 1 Feb 2015 12:24:40 +0000 (13:24 +0100)]
[FOLLOWUP][CLEANUP] Wrap the tests bootstrap code into classes

Remove space too much from @param notation.

Resolves: #64662
Releases: master
Change-Id: I3886e356f985b89b890fbcdeb0e8baf565e03084
Reviewed-on: http://review.typo3.org/36568
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[CLEANUP] Add missing signature to DatabaseConnection phpDoc updateQuery 46/36346/6
Ruud Silvrants [Thu, 29 Jan 2015 11:26:15 +0000 (12:26 +0100)]
[CLEANUP] Add missing signature to DatabaseConnection phpDoc updateQuery

Fix the bug of the missing code documentation at the PHPDoc of
execUpdateQuery and updateQuery to expect also an array or string
necessary for fullQuoteArray().

Resolves: #64511
Releases: master, 6.2
Change-Id: I310291f3686cca8ac17bad3aedf7f94cfbe6370c
Reviewed-on: http://review.typo3.org/36346
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
4 years ago[FOLLOW-UP] Remove inline styles from parsed blockquote tag 61/36561/2
Steffen Müller [Sun, 1 Feb 2015 10:47:24 +0000 (11:47 +0100)]
[FOLLOW-UP] Remove inline styles from parsed blockquote tag

Add document about breaking changes to changelog

Resolves: #44879
Releases: master
Change-Id: I27ace3040a71d073f474d4ed12539fb56a6b7c1b
Reviewed-on: http://review.typo3.org/36561
Reviewed-by: Steffen Müller <typo3@t3node.com>
Tested-by: Steffen Müller <typo3@t3node.com>
4 years ago[BUGFIX] Install tool navigation icon mess 59/36559/4
Marc Bastian Heinrichs [Fri, 14 Dec 2012 21:30:18 +0000 (22:30 +0100)]
[BUGFIX] Install tool navigation icon mess

After merging the patch https://review.typo3.org/#/c/36535/ the icons
in the Install Tool navigation are messed. This is caused because the
background is reset in css. This patch removes the background reset.

Releases: master
Resolves: #64712
Change-Id: Idd35108bc65c9aedb2d8af0320fb51621699757b
Reviewed-on: http://review.typo3.org/36559
Reviewed-by: Mateusz Wojtuła <matw88@gmail.com>
Tested-by: Mateusz Wojtuła <matw88@gmail.com>
Reviewed-by: Göran Bodenschatz <coding@46halbe.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Doreen Gröger <mail@doreen-groeger.de>
Tested-by: Doreen Gröger <mail@doreen-groeger.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[CLEANUP] Wrap the tests bootstrap code into classes 32/36532/2
Oliver Klee [Sat, 31 Jan 2015 17:27:38 +0000 (18:27 +0100)]
[CLEANUP] Wrap the tests bootstrap code into classes

Resolves: #64662
Releases: master
Change-Id: I4763bf413190b0aa8ba0af62016b9971878435f7
Reviewed-on: http://review.typo3.org/36532
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Create typo3temp/_processed_/ by default 57/36557/2
Sebastian Fischer [Sun, 1 Feb 2015 09:33:02 +0000 (10:33 +0100)]
[BUGFIX] Create typo3temp/_processed_/ by default

By this the needed folder for files from default storage
is created.

Resolves: #55833
Releases: master, 6.2
Change-Id: I5f31203a58d2a093362305aebf1f264f175980c3
Reviewed-on: http://review.typo3.org/36557
Reviewed-by: Roman Schürmann <roman.schuermann@wmdb.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Ingo Schmitt <is@marketing-factory.de>
Tested-by: Ingo Schmitt <is@marketing-factory.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
4 years ago[BUGFIX] Felogin: Ignore scheme in isInCurrentDomain 70/17170/10
Jigal van Hemert [Fri, 14 Dec 2012 21:30:18 +0000 (22:30 +0100)]
[BUGFIX] Felogin: Ignore scheme in isInCurrentDomain

While determining if the referrer is in the current domain the
scheme part should be ignored. This makes it possible to have the
login page using https and the rest http.

Change-Id: Ic411e3b18d22b96ae5e5a955d88d6270a05116a7
Resolves: #32618
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/17170
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] ExtractorRegistry can not handle Extractors with same priority 02/36502/3
Fabien Udriot [Sat, 31 Jan 2015 13:24:11 +0000 (14:24 +0100)]
[BUGFIX] ExtractorRegistry can not handle Extractors with same priority

The ExtractorRegistry::getExtractors() overrides existing
instances with the same execution priority. There is no check
or notification about this. As instance, it could be that you
have a extractor for Local driver and an extractor for a remote
driver with the same execution priority, that is currently not possible.

The change set also keep in sync some part of the code with
the FileRenderRegistry which is very close to the Extractor Registry.

Change-Id: I42fdd3916410536a0b097d96cf833129f5359d72
Releases: master, 6.2
Resolves: #56727
Reviewed-on: http://review.typo3.org/36502
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
4 years ago[BUGFIX] Missing stream_cast() in FileStreamWrapper 22/36522/7
Philipp Gampe [Sat, 31 Jan 2015 15:51:31 +0000 (16:51 +0100)]
[BUGFIX] Missing stream_cast() in FileStreamWrapper

Resolves: #64693
Releases: master
Change-Id: Ib3eeee53d9937e4ae8a1cdfd0da2acf51644241f
Reviewed-on: http://review.typo3.org/36522
Reviewed-by: Altan Tosun <a.tosun@gmx.de>
Tested-by: Altan Tosun <a.tosun@gmx.de>
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Tested-by: Sascha Egerer <sascha@sascha-egerer.de>
4 years ago[BUGFIX] FAL: Do not paste a folder into itself 86/36386/10
Helmut Hummel [Thu, 29 Jan 2015 21:03:57 +0000 (22:03 +0100)]
[BUGFIX] FAL: Do not paste a folder into itself

If a folder is selected in fileadmin, which is already in
the clipboard, the paste icon is not shown to prevent
a endlessly nested folder structure.

Also the correct exception is thrown in ResourceStorage
if it occurs anyway.

Resolves: #51670
Releases: master, 6.2
Change-Id: I996cb8eede1371e479f756f18e1ede03f65950cb
Reviewed-on: http://review.typo3.org/36386
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
4 years ago[TASK] Make move_el.php dispatched 11/36511/3
Wouter Wolters [Sat, 31 Jan 2015 15:01:14 +0000 (16:01 +0100)]
[TASK] Make move_el.php dispatched

Use dispatching for move_el.php

Resolves: #64691
Releases: master
Change-Id: Ice9733d6b323ea998d28879db5908696ed7f1fa1
Reviewed-on: http://review.typo3.org/36511
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Fix folder casing of Icons/Flags 40/36540/5
Sebastian Fischer [Sat, 31 Jan 2015 18:24:56 +0000 (19:24 +0100)]
[BUGFIX] Fix folder casing of Icons/Flags

Rename folder Icons/flags to Icons/Flags to fix the missing language
flags in case-sensitive file systems.

Resolves: #64702
Releases: master
Change-Id: I77aee2b2c066faa96555387fe68324c848d3cfd4
Reviewed-on: http://review.typo3.org/36540
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
4 years ago[CLEANUP] Move functions to GraphicalFunctions 67/36367/6
Zbigniew Jacko [Thu, 29 Jan 2015 16:04:09 +0000 (17:04 +0100)]
[CLEANUP] Move functions to GraphicalFunctions

Clean up the code by moving IM related function
from GeneralUtility to GraphicalFunctions class.

Change-Id: I714435ad76e542e9aff297cad779964fd543a2c5
Resolves: #46589
Releases: master
Reviewed-on: http://review.typo3.org/36367
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[FOLLOWUP] Move legacy "search" CType to compatibility6 39/36539/2
Stephan Großberndt [Sat, 31 Jan 2015 18:23:42 +0000 (19:23 +0100)]
[FOLLOWUP] Move legacy "search" CType to compatibility6

Fix use statement and call to log deprecation.

Releases: master
Resolves: #64696
Change-Id: I8c41afaced3dd650c31b2083451c0b395fae2bdc
Reviewed-on: http://review.typo3.org/36539
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[CLEANUP] Use statement for GeneralUtility in UriBuilder 31/36531/3
Stephan Großberndt [Sat, 31 Jan 2015 17:10:30 +0000 (18:10 +0100)]
[CLEANUP] Use statement for GeneralUtility in UriBuilder

Resolves: #64699
Releases: master
Change-Id: Ice37ae02c4aba6edef531a523ec16e6b786ededf
Reviewed-on: http://review.typo3.org/36531
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Add test for NULL fields when comparing SQL field definitions 29/36529/2
Stephan Großberndt [Sat, 31 Jan 2015 16:43:33 +0000 (17:43 +0100)]
[TASK] Add test for NULL fields when comparing SQL field definitions

Resolves: #64697
Releases: master, 6.2
Change-Id: I6d08445633af54d64f9176fc7b691e318d08d897
Reviewed-on: http://review.typo3.org/36529
Reviewed-by: Ronny Vorpahl <vorpahl@artplan21.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[!!!][TASK] Move legacy "search" CType to compatibility6 26/36526/3
Benjamin Mack [Sat, 31 Jan 2015 16:24:58 +0000 (17:24 +0100)]
[!!!][TASK] Move legacy "search" CType to compatibility6

The primitive search, which is loaded via
"Search" CType contains a cObject called
"SEARCHRESULTS". The search is based on
a form based on FORM (old functionality already
moved to compatibility6), is moved to
compatibility6.

The following parts are moved:
- New Content Element Wizard
- cObject SEARCHRESULTS
- TypoScript from CSS Styled Content
- The TCA configuration

Due to the limited possibility to
add a CType (select item in general)
at a specific position (e.g. as first item
of an item group divided with --div--),
the patch also provides compatibility
for EXT:felogin and EXT:form by doing
TCA overrides for the CType element.

This also fixes some sideffects that came
with the previous patches for "mailform".

Releases: master
Resolves: #64696
Change-Id: I722e3bd7d3b7fad7d198e61d8ad1abde4dfdba2b
Reviewed-on: http://review.typo3.org/36526
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Change TS property includeJSlibs to proper camelcase 12/33312/7
Stefan Froemken [Tue, 14 Oct 2014 19:36:39 +0000 (21:36 +0200)]
[BUGFIX] Change TS property includeJSlibs to proper camelcase

LowerCamelCase told us to use includeJSLibs
instead of includeJSlibs. We also use
includeJSFooter.

Resolves: #61605
Releases: master
Change-Id: I65966482c32b28c59d3d7402b01f6ff80129e3c9
Reviewed-on: http://review.typo3.org/33312
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[FEATURE] Improve link area in Install Tool navigation 35/36535/2
Doreen Gröger [Sat, 31 Jan 2015 16:58:56 +0000 (17:58 +0100)]
[FEATURE] Improve link area in Install Tool navigation

Currently only the text from the Install Tool navigation is clickable.
To improve the user experience this patch extends CSS to enlarge the
link area to the whole navigation item.

Releases: master
Resolves: #64698
Change-Id: I6c4b130a931c1cf0c7d07261f2742b1a4fb6a9d3
Reviewed-on: http://review.typo3.org/36535
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[FOLLOWUP][TASK] Move xhtml_cleaning check to compatibility6 36/36536/2
Benjamin Mack [Sat, 31 Jan 2015 18:00:27 +0000 (19:00 +0100)]
[FOLLOWUP][TASK] Move xhtml_cleaning check to compatibility6

Resolves: #62855
Releases: master
Change-Id: I5148e6fe06a73308283bb5f42427cef3d814dbfa
Reviewed-on: http://review.typo3.org/36536
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[CLEANUP] Rework/simplify copyright header and remove @package 19/36519/3
Stephan Großberndt [Sat, 31 Jan 2015 15:29:14 +0000 (16:29 +0100)]
[CLEANUP] Rework/simplify copyright header and remove @package

Align some files with old copyright headers, mostly in extbase and
fluid sysext which were missed in Task #59535. Also remove some left
@package statements missed in Task #43019.

Resolves: #64689
Releases: master, 6.2
Change-Id: I9838c9be73cb3a310ef2572fcc3843ff53dbf724
Reviewed-on: http://review.typo3.org/36519
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Deactivate output buffer for FileDumpEID.php 85/36485/6
Roman Schuermann [Sat, 31 Jan 2015 09:33:29 +0000 (10:33 +0100)]
[BUGFIX] Deactivate output buffer for FileDumpEID.php

If you try to download large file via FileDumpEID.php you may
get an out of memory error.

Resolves: #64273
Releases: master, 6.2
Change-Id: Ie1fcf9eac5d8e7466bbfe6eb8357ed9ce62fa649
Reviewed-on: http://review.typo3.org/36485
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Sebastian Fischer <typo3@evoweb.de>
Tested-by: Sebastian Fischer <typo3@evoweb.de>
Reviewed-by: Ingo Schmitt <is@marketing-factory.de>
Tested-by: Ingo Schmitt <is@marketing-factory.de>
4 years ago[!!!][TASK] Move xhtml_cleaning check to compatibility6 27/36527/6
Jan Helke [Sat, 31 Jan 2015 16:24:32 +0000 (17:24 +0100)]
[!!!][TASK] Move xhtml_cleaning check to compatibility6

XHTML cleaning is not neccessary anymore, after modern technology
bases completely on HTML5. Therefore the according functionality
has been moved to the legacy extension "compatibility6".

Resolves: #62855
Releases: master
Change-Id: I4f4b7cfd2388d516951b0f37b399b0359b44c487
Reviewed-on: http://review.typo3.org/36527
Reviewed-by: Göran Bodenschatz <coding@46halbe.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[CLEANUP] Make use of possible imports and remove unused ones 13/36513/6
Göran Bodenschatz [Sat, 31 Jan 2015 15:02:27 +0000 (16:02 +0100)]
[CLEANUP] Make use of possible imports and remove unused ones

Resolves: #64690
Releases: master
Change-Id: Ia785278f0210416a0075e8e6eed712d97fd7272a
Reviewed-on: http://review.typo3.org/36513
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Steffen Müller <typo3@t3node.com>
Tested-by: Steffen Müller <typo3@t3node.com>
4 years ago[BUGFIX] Respect (NOT) NULL when comparing SQL field definitions 00/36400/4
Stephan Großberndt [Fri, 30 Jan 2015 10:23:17 +0000 (11:23 +0100)]
[BUGFIX] Respect (NOT) NULL when comparing SQL field definitions

When comparing the database or updating extensions the definitions for
NULL / NOT NULL in fields are now respected and updated.

Resolves: #64616
Releases: master, 6.2
Change-Id: I70c63339505b373023f24973313a2e673e8eaf86
Reviewed-on: http://review.typo3.org/36400
Tested-by: Ronny Vorpahl <vorpahl@artplan21.de>
Reviewed-by: Mateusz Wojtuła <matw88@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Improve functional test execution on Windows system 91/36491/3
Nicole Cordes [Sat, 31 Jan 2015 11:01:09 +0000 (12:01 +0100)]
[BUGFIX] Improve functional test execution on Windows system

On Windows systems you can execute several commands using '&' like
set typo3DatabaseUsername=root & set typo3DatabasePassword=root.
Unfortunately Windows sets those parameter with a trailing space. This
causes database connections not to work. Therefore the patch adds a trim
on getting system environment variables for database credentials for
functional tests.

Furthermore the PHP versions on Windows throw a warning on setting the
database name when the connection is closed. The warning is caught by
PHPUnit but the database tables aren't initialized correctly. This patch
adds an '@' to mute the warning.

Releases: master, 6.2
Resolves: #64680
Change-Id: If649b5bd440a3bd504f028a3c9c96c9d294d380c
Reviewed-on: http://review.typo3.org/36491
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[CLEANUP] Move array specific functions to ArrayUtility 71/36371/8
Göran Bodenschatz [Thu, 29 Jan 2015 16:53:36 +0000 (17:53 +0100)]
[CLEANUP] Move array specific functions to ArrayUtility

1. Move functions + tests to ArrayUtility class
2. Change function calls throughout Core
3. Deprecate functions in GeneralUtility

Resolves: #62807
Releases: master
Change-Id: Ib5c00b74d2326a377a76a1f24d1b541c33a2d956
Reviewed-on: http://review.typo3.org/36371
Reviewed-by: Mateusz Wojtuła <matw88@gmail.com>
Tested-by: Mateusz Wojtuła <matw88@gmail.com>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Zbigniew Jacko <z.jacko@macopedia.pl>
Tested-by: Zbigniew Jacko <z.jacko@macopedia.pl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Remove inline styles from parsed blockquote tag 58/17758/5
Jan Helke [Fri, 30 Jan 2015 21:36:48 +0000 (22:36 +0100)]
[BUGFIX] Remove inline styles from parsed blockquote tag

When passing blockquote tags trough lib.parseFunc_RTE (this
is commonly done when rendering TS objects in Fluid templates)
their attributes will be replaced with some inline styles.
I don't know what the intention of this behavior is, but it's been
like this at least since 2004. Inline styles should generally be
avoided.
I suggest to simple remove this rule.

Code to reproduce the issue and test the change:
https://gist.github.com/4654874

Resolves: #44879
Releases: master
Change-Id: If8954fa392b906d78a8cc32aba9e5b23d84decd9
Reviewed-on: http://review.typo3.org/17758
Reviewed-by: Steffen Müller <typo3@t3node.com>
Tested-by: Steffen Müller <typo3@t3node.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Ensure unix like paths for temp files 93/36493/4
Nicole Cordes [Sat, 31 Jan 2015 11:18:32 +0000 (12:18 +0100)]
[BUGFIX] Ensure unix like paths for temp files

Using tempnam() on Windows systems returns paths containing backslashes.
As other paths inside the core are already transformed to paths using
forward slashes some string comparisons fail. This patch ensures correct
transforming of slashes after the usage of tempnam().

Releases: master, 6.2
Resolves: #64682
Change-Id: Ic85e06d9ed32c9f668efd5bb74b9bc14df367e1b
Reviewed-on: http://review.typo3.org/36493
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Mateusz Wojtuła <matw88@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Sections not properly handled by record collector 92/35692/3
Bernhard Kraft [Wed, 31 Dec 2014 14:12:57 +0000 (15:12 +0100)]
[BUGFIX] Sections not properly handled by record collector

When using the Unit-Test framework frontend record collector the
resulting response is not correct.

Instead of adding records only to the specific section (configured via
TypoScript) the records pile up in $this->records and get added to
every section. The reason this only true for $this->records of the
Collector is, that for the other class variables (like $this->structure)
there are appropriate array keys used anyways.

Solution is to reset the internal member variables used for collecting
record information each time after attaching a section.

Resolves: #64066
Releases: master
Change-Id: I7a1ff945e0d267f1e0c6608637479ea0cc28fe70
Reviewed-on: http://review.typo3.org/35692
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mateusz Wojtuła <matw88@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[FOLLOWUP] Harmonize allowed characters of backend usernames 01/36501/2
Oliver Klee [Sat, 31 Jan 2015 13:49:22 +0000 (14:49 +0100)]
[FOLLOWUP] Harmonize allowed characters of backend usernames

Drop an now-unnecessary trim on the user name.

Relates: #50875
Releases: master
Change-Id: I771a5340212da81da08e8cb668e096acd97dc9b9
Reviewed-on: http://review.typo3.org/36501
Reviewed-by: Steffen Müller <typo3@t3node.com>
Tested-by: Steffen Müller <typo3@t3node.com>
4 years ago[TASK] Harmonize allowed characters of backend usernames 97/35997/3
Georg Ringer [Tue, 13 Jan 2015 12:41:44 +0000 (13:41 +0100)]
[TASK] Harmonize allowed characters of backend usernames

When creating new backend users from the intall tool, any
character is now accepted for the username. Whitespaces get
trimmed and uppercase is converted to lowercase.
This is already the case for TCA of be_users.username

Change-Id: I0edabd2cb82dc59bdc52dd385c1e198f04be6017
Resolves: #50875
Releases: master
Reviewed-on: http://review.typo3.org/35997
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[!!!][TASK] Move old mailform to compatibility6 79/36479/6
Benjamin Mack [Fri, 30 Jan 2015 21:34:48 +0000 (22:34 +0100)]
[!!!][TASK] Move old mailform to compatibility6

Due to the replacement of the better
EXT:form logic, the fallback and default
mailform when EXT:form is not installed,
is moved to compatibility6.

There are certain parts that are migrated
as well and therefore removed from the
main core installation.

 * Various methods in ContentObjectRenderer,
and especially TypoScriptFrontendRenderer
which specifically served the purpose.
 * The FORM Content Object
 * The TCA tt_content mailform configuration
 * The TypoScript from css styled content
 * The newContentElement wizard configuration
 * Related tests to the form-related methods
 * The preview functionality for a mailform in "Web"=>"Page"

The submission class (DataSubmissionController)
has been moved and renamed as well, and now
hooks into the checkDataSubmission of TSFE.

Additionally, the related tests to the methods
have been removed.

Resolves: #64668
Releases: master
Change-Id: Iefbaf11322678f811d5c38d82f7d81be56b1d378
Reviewed-on: http://review.typo3.org/36479
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Move old SVN ChangeLog entries to wiki.typo3.org/ChangeLog 92/36492/3
Benjamin Mack [Sat, 31 Jan 2015 11:14:18 +0000 (12:14 +0100)]
[TASK] Move old SVN ChangeLog entries to wiki.typo3.org/ChangeLog

In order to keep our base distribution a bit
smaller, the SVN part (pre 2011) of the ChangeLog
file is moved to http://wiki.typo3.org/ChangeLog

Resolves: #64681
Releases: master
Change-Id: I86523a111d311d349748e760bead47d6c3d9ddfc
Reviewed-on: http://review.typo3.org/36492
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Mateusz Wojtuła <matw88@gmail.com>
Tested-by: Mateusz Wojtuła <matw88@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Take table permissions in account for file edit icon 16/36416/8
Philipp Thiele [Fri, 30 Jan 2015 12:34:03 +0000 (13:34 +0100)]
[BUGFIX] Take table permissions in account for file edit icon

Hides the file edit icon in filelist if the user has no modify
permissions for sys_file_metadata.

Resolves: #64634
Releases: master
Change-Id: Id0070849032d0596e8fe30c9f17a314f31adc6fa
Reviewed-on: http://review.typo3.org/36416
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] FAL: Remove old publishing leftovers 94/36494/2
Benjamin Mack [Sat, 31 Jan 2015 11:23:19 +0000 (12:23 +0100)]
[TASK] FAL: Remove old publishing leftovers

The initial concept of having publishers
in the File Abstraction Layer was never
implemented.

The leftover code is removed.
No dependencies to the protected
method are found and can safely be
removed.

Resolves: #64683
Releases: master, 6.2
Change-Id: I4eca172bc9fd618ce80bd7c0158da73b01745a77
Reviewed-on: http://review.typo3.org/36494
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Inform user about possibly missing Ghostscript tools 87/36487/3
Markus Klein [Sat, 31 Jan 2015 10:33:36 +0000 (11:33 +0100)]
[TASK] Inform user about possibly missing Ghostscript tools

Extend the error message for failing image tests to include a note
about possibly missing Ghostscript tools on the server.

Releases: master, 6.2
Resolves: #64677
Change-Id: I9dbc9e3b4afb8280c54d4ac87456f9272bdb0874
Reviewed-on: http://review.typo3.org/36487
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[FEATURE] Show allowed file extensions in FAL field 43/36443/3
Armin Ruediger Vieweg [Fri, 30 Jan 2015 15:44:51 +0000 (16:44 +0100)]
[FEATURE] Show allowed file extensions in FAL field

Above the list of file relations are buttons to add or upload new images.
Now, behind these buttons a label appears, which shows the allowed file
extensions to upload/use.

Resolves: #45428
Releases: master
Change-Id: I6e7caea22c6198819084db4c737088cc6f7eb02f
Reviewed-on: http://review.typo3.org/36443
Reviewed-by: Benjamin Kott <info@bk2k.info>
Tested-by: Benjamin Kott <info@bk2k.info>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
4 years ago[!!!][TASK] Move Content Object IMGTEXT to compatibility6 84/36484/2
Benjamin Mack [Sat, 31 Jan 2015 09:16:51 +0000 (10:16 +0100)]
[!!!][TASK] Move Content Object IMGTEXT to compatibility6

The predecessor of css styled content-based
text w/ image, called IMGTEXT, is moved to
compatibility6.

The only place where it is used when it is called
directly (page.10 = IMGTEXT), and specifically
requested within CSS Styled Content in
renderTextpic() if ".renderMethod" is empty or
explicitly set to "table".

Releases: master
Resolves: #64671
Change-Id: I3b56ac9b044adfaa4295a3d54070187e14caf576
Reviewed-on: http://review.typo3.org/36484
Reviewed-by: Jan Helke <typo3@helke.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Göran Bodenschatz <coding@46halbe.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Use resource API to deleted files from uploads in DataHandler 01/31001/6
Marc Bastian Heinrichs [Sat, 21 Jun 2014 13:49:34 +0000 (15:49 +0200)]
[TASK] Use resource API to deleted files from uploads in DataHandler

The DataHandler deletes files from the uploads folder. Since also a
sys_file record could exist for such file, the resource API should be
used to delete it.

Resolves: #58967
Releases: master, 6.2
Change-Id: I6c0b3683657e1c4da5f9ab0a2016e33b1e472f62
Reviewed-on: http://review.typo3.org/31001
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Files to FileStorage relations are now recorded in sys_refindex 12/36412/3
alinafleser [Fri, 30 Jan 2015 11:59:48 +0000 (13:59 +0200)]
[BUGFIX] Files to FileStorage relations are now recorded in sys_refindex

When a file (sys_file) is added/modified/deleted,
the relation to the file storage (sys_file_storage)
is recorded and updated in sys_refindex

Resolves: #64631
Related: #50871
Releases: master, 6.2
Change-Id: If95fac13c5530041948b3f9c896ebb390c31956a
Reviewed-on: http://review.typo3.org/36412
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Ingo Schmitt <is@marketing-factory.de>
Tested-by: Ingo Schmitt <is@marketing-factory.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Gracefully show missing files in IRRE relations 44/29544/15
Andre Hähnel [Thu, 17 Apr 2014 13:24:58 +0000 (15:24 +0200)]
[BUGFIX] Gracefully show missing files in IRRE relations

When the database is inconsistent and a sys_file entry linked
from sys_file_reference does not exist anymore, an exception
is shown in the "page" module in the backend:

> No file found for given UID.

We will now gracefully show the reference as "broken" and let
the action up to the editor. Works for temporarily unavailable
storages too.

Releases: master, 6.2
Resolves: #58013
Change-Id: Ibce9bb3b60e9294aa1902b95c1b99337d3a8e2e6
Reviewed-on: http://review.typo3.org/29544
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Ingo Schmitt <is@marketing-factory.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Remove old PHP version leftovers 40/35940/4
Markus Klein [Fri, 9 Jan 2015 21:31:56 +0000 (22:31 +0100)]
[TASK] Remove old PHP version leftovers

Releases: master
Resolves: #64670
Change-Id: Ia54cb96e20cd0392bd43cec366b3d8b9ab0a02df
Reviewed-on: http://review.typo3.org/35940
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Steffen Müller <typo3@t3node.com>
Tested-by: Steffen Müller <typo3@t3node.com>
4 years ago[BUGFIX] Path of a storage must be required 78/36478/7
Altan Tosun [Fri, 30 Jan 2015 22:12:08 +0000 (23:12 +0100)]
[BUGFIX] Path of a storage must be required

Remove the default 'fileadmin/' and introduce a placeholder
instead.
The field is required now.

Resolves: #64650
Releases: master
Change-Id: I517fc816f4c84be8592199f3341f11a3395b8079
Reviewed-on: http://review.typo3.org/36478
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
4 years ago[BUGFIX] Display Info of File in popup instead of File Metadata 94/33294/5
Fabien Udriot [Mon, 13 Oct 2014 15:20:20 +0000 (17:20 +0200)]
[BUGFIX] Display Info of File in popup instead of File Metadata

To stay inline with the File List, the popup from the list
should display info of a File and not of the File Metadata. Otherwise,
it will display misleading information for the End User such
as different creation / modification date.

Change-Id: I84ac293dc63d222d1111dd35bd1474709449bafa
Releases: master, 6.2
Resolves: #56655
Reviewed-on: http://review.typo3.org/33294
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
4 years ago[BUGFIX] Set correct workspace ID when updating referenceIndex for files 44/36044/7
Markus Klösges [Fri, 16 Jan 2015 13:00:35 +0000 (14:00 +0100)]
[BUGFIX] Set correct workspace ID when updating referenceIndex for files

When publishing a workspace the referenceIndex entries of the affected
sys_file_reference rows were not updated with the new workspace. That's
because the user is always in the affected workspace and therefore
the workspace is not set to live as expected.
Now updating referenceIndex for both workspaces when swapping.

Resolves: #64253
Releases: master, 6.2
Change-Id: Icfb4fcd1ae92da4ea881105b387c3d6db20ece95
Reviewed-on: http://review.typo3.org/36044
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
4 years ago[FEATURE] Display the bad class name in makeInstance 72/36472/2
Oliver Klee [Fri, 30 Jan 2015 19:53:19 +0000 (20:53 +0100)]
[FEATURE] Display the bad class name in makeInstance

The class name provided to GeneralUtility::makeInstance must not
start with a backslash. To help track down the offending code parts,
makeInstance now includes the offending class name in the exception
message.

Resolves: #64665
Releases: master
Change-Id: I745840f9d6497b0b73bd2f1872310728e780ae5e
Reviewed-on: http://review.typo3.org/36472
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Add test for categories with multiple tables 77/36477/2
Zbigniew Jacko [Fri, 30 Jan 2015 20:17:27 +0000 (21:17 +0100)]
[TASK] Add test for categories with multiple tables

Add test for #45332. Remove one relation and check count of collection.

Change-Id: I59871058df97614f7f339c0df241de30e17358b9
Resolves: #50091
Release: master
Reviewed-on: http://review.typo3.org/36477
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[FOLLOWUP] Disable functionality to hide file storage 74/36474/2
Helmut Hummel [Fri, 30 Jan 2015 20:07:31 +0000 (21:07 +0100)]
[FOLLOWUP] Disable functionality to hide file storage

Also remove an obsolete sql key and remaing TCA from the hidden column

Releases: master
Resolves: #59017
Change-Id: I0b4bfa0036eab6a69cb548bd5e21d0569b7dfbf7
Reviewed-on: http://review.typo3.org/36474
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
4 years ago[BUGFIX] Take table permissions in account for file translate icon 71/36471/2
Philipp Thiele [Fri, 30 Jan 2015 19:43:52 +0000 (20:43 +0100)]
[BUGFIX] Take table permissions in account for file translate icon

Hides the translate icon in file list if the user has no
modify permissions for sys_file_metadata

Resolves: #55576
Releases: master
Change-Id: Ida3ea7a437c2b4fb49099ff7a3448ceccf063bd2
Reviewed-on: http://review.typo3.org/36471
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
4 years ago[BUGFIX] FAL Indexer follow symlinks now 29/36429/2
Roman Schuermann [Fri, 30 Jan 2015 14:14:37 +0000 (15:14 +0100)]
[BUGFIX] FAL Indexer follow symlinks now

Currently the indexing scheduler task from FAL ignores symlinks and all files behind symlinks are not indexed.

Resolves: #60511
Releases: master
Change-Id: If4eb503e96eccebaf39a9f3ba48ffc469e038f4b
Reviewed-on: http://review.typo3.org/36429
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[BUGFIX] Disable functionality to hide file storage 61/36461/5
ruud [Fri, 30 Jan 2015 18:01:31 +0000 (19:01 +0100)]
[BUGFIX] Disable functionality to hide file storage

Disables the functionality to hide a file storage.

Resolves: #59017
Releases: master
Change-Id: Ibe542f384b4ecff033ae8c73b002fad266b61683
Reviewed-on: http://review.typo3.org/36461
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[BUGFIX] DateValidator fails to validate incorrect dates 67/36467/3
Nicole Cordes [Fri, 30 Jan 2015 18:35:11 +0000 (19:35 +0100)]
[BUGFIX] DateValidator fails to validate incorrect dates

If the function "strptime" is not present in the environment (mostly on
Windows systems) the fallback to check a given date in the dateValidator
fails to detect invalid dates. The conversion from the given string to
a date object respects invalid dates and just converts them to valid
ones (by moving in next month/year). Therefore the function returns an
object instead of false. This patch adds a value comparison between old
and new value to be sure still the same date string is returned.

Releases: master, 6.2
Resolves: #64661
Change-Id: I739d309278143bb5fc24c48ca7bb884a1e25a442
Reviewed-on: http://review.typo3.org/36467
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Steffen Müller <typo3@t3node.com>
Tested-by: Steffen Müller <typo3@t3node.com>
4 years ago[TASK] Drop support and tests for FreeType 1 53/36153/6
Stefan Neufeind [Wed, 21 Jan 2015 08:43:40 +0000 (09:43 +0100)]
[TASK] Drop support and tests for FreeType 1

We've been using FreeType 2 for quite some time.
FreeType 1 is history meanwhile.

Change-Id: I45add19b77c9168bc00def15295ed85f4a7353e9
Resolves: #48542
Releases: master
Reviewed-on: http://review.typo3.org/36153
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Adjust visibility of setUp() and tearDown() 38/36438/4
Anja Leichsenring [Fri, 30 Jan 2015 15:08:32 +0000 (16:08 +0100)]
[BUGFIX] Adjust visibility of setUp() and tearDown()

Protected is the correct visibility for those functions, as
given by the base class.

Change-Id: If8ed81c49c6c5cdd6933dd61647f1c2ad1bfc746
Resolves: #64642
Releases: master
Reviewed-on: http://review.typo3.org/36438
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[BUGFIX] Distributions: Import files before database 28/34428/4
Sascha Egerer [Fri, 21 Nov 2014 08:27:39 +0000 (09:27 +0100)]
[BUGFIX] Distributions: Import files before database

The distribution import does sometimes not import the Assets
(Resources/Files/) of the distribution. This is because the
t3d-file is imported before the files are imported.
That means that the t3d import will create FAL file relations
to files that do not exists. This will end up in an FAL exception.
Files should be imported before the t3d-file is imported.

Resolves: #63121
Releases: master,6.2
Change-Id: Ibb3695b0b92ed2a257380c8684e4451851a2248f
Reviewed-on: http://review.typo3.org/34428
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Sebastian Fischer <typo3@evoweb.de>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Always display errors when running the tests 62/36462/3
Oliver Klee [Fri, 30 Jan 2015 18:01:50 +0000 (19:01 +0100)]
[TASK] Always display errors when running the tests

With some default php.ini files (e.g., the file shipped with MAMP PRO),
display_errors is set to "off", and the memory limit is rather low.

As the bootstraps for the unit and functional tests do not read the
current installation's settings, the default values from the php.ini
are used. This can cause the tests to fail at some point due to
insufficient memory, but without any visible messages.

This change makes sure that PHP errors always are output when running
the unit or functional tests using the Core bootstrap files.

Resolves: #64659
Releases: master, 6.2
Change-Id: I28773515b354811a42f0ce262e950603218927b6
Reviewed-on: http://review.typo3.org/36462
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] RTE not resizable in IE 64/36464/2
Stanislas Rolland [Fri, 30 Jan 2015 18:19:51 +0000 (13:19 -0500)]
[BUGFIX] RTE not resizable in IE

Incorrect test of support for CSS3 resize property.

Releases: master
Resolves: #64660
Change-Id: Id137f476920dcbf05fa028940039fa3191d808f4
Reviewed-on: http://review.typo3.org/36464
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>