Packages/TYPO3.CMS.git
8 years ago[TASK] Update md5 checksums for system extensions
Xavier Perseguers [Mon, 10 Oct 2011 12:48:16 +0000 (14:48 +0200)]
[TASK] Update md5 checksums for system extensions

The md5 checksums for all system extensions not integrated as submodule
should be updated.

Change-Id: I845cc4204ca3f6c334fcdb7750ba5a927a9c36f7
Resolves: #30723
Releases: 4.6
Reviewed-on: http://review.typo3.org/5664
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[FEATURE] Generate cHash only if needed
Popy [Thu, 21 Jul 2011 15:04:02 +0000 (17:04 +0200)]
[FEATURE] Generate cHash only if needed

tslib_cObj->typolink() generates cHash in every case, even if not
needed. Change the behavior to generate cHash only if necessary.

Change-Id: Id6a015e6bd89e9baeafd9532d4a21018adf91691
Resolves: #28352
Releases: 4.6
Reviewed-on: http://review.typo3.org/3456
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Tested-by: Popy
Reviewed-by: Xavier Perseguers
Reviewed-by: Stefan Neufeind
Reviewed-by: Benjamin Mack
Reviewed-by: Björn Pedersen
Tested-by: Xavier Perseguers
8 years ago[TASK] Increase default titleLen
Felix Kopp [Sat, 8 Oct 2011 18:25:43 +0000 (20:25 +0200)]
[TASK] Increase default titleLen

UC/titleLen in BE_USER is used to truncate data in the backend.
Increase the default value.

Change-Id: I64e2ecb1a8f4458101bc2bd395ef6c1be0ca667c
Resolves: #30670
Releases: 4.6
Reviewed-on: http://review.typo3.org/5637
Reviewed-by: Markus Klein
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[TASK] Update sysext form documentation
Xavier Perseguers [Sun, 2 Oct 2011 15:08:08 +0000 (17:08 +0200)]
[TASK] Update sysext form documentation

System extension 'form' does not have a proper cover page (missing title
and basic information) and still contain lots of example placeholders.

Change-Id: I2ccecc6aa7904df0501a2c91d599258148458c33
Resolves: #30709
Releases: 4.6
Reviewed-on: http://review.typo3.org/5482
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] All fields of 'type'=>'group' are broken in IE
Jigal van Hemert [Sun, 9 Oct 2011 12:38:17 +0000 (14:38 +0200)]
[BUGFIX] All fields of 'type'=>'group' are broken in IE

The HTML multiple attribute is added for select boxes with size > 1 and
the Javascript to check this uses the multiple-property instead of the
getAttribute method which is poorly supported by various browsers.

Change-Id: Ib2ffeb2d0933a6c66e55586f1960ee7745e5623e
Fixes: #30681
Releases: 4.6
Reviewed-on: http://review.typo3.org/5646
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
8 years ago[TASK] Deprecate template::clearCacheMenu()
Xavier Perseguers [Mon, 10 Oct 2011 07:22:10 +0000 (09:22 +0200)]
[TASK] Deprecate template::clearCacheMenu()

Method clearCacheMenu() allowed to create a drop-down selector to clear
caches and possibly add options such as "save and close documents".

Modules should respect the TYPO3 backend layout and use the top toolbar
instead. In addition, this method does not provide all clear cache commands
supported by the Core.

Change-Id: I2ecb014e6ceced56d827eac4f1b683c3f245cb4b
Resolves: #30700
Releases: 4.6
Reviewed-on: http://review.typo3.org/5660
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
8 years agoRevert "[FEATURE] Speed-up Backend with CardLayout"
Xavier Perseguers [Sat, 8 Oct 2011 07:19:02 +0000 (09:19 +0200)]
Revert "[FEATURE] Speed-up Backend with CardLayout"

This reverts the use of CardLayout for the Backend.
Following commits have been squashed:

9ec94db20e803641b5be39e8ac83bf18f08789ab
5ec3779c978899659694941d79492e536aba6159
873f1dfe909f500e862744c817d029c9f05328ff
a408234cdf05ef4b69682161d8e2198db71318fd
120d38d1015117cc415482e7efec35430a5e3dfd

Change-Id: I2287b18598dbc5fe546c5ddc9aa9980d9b6a3b97
Resolves: #30645
Reviewed-on: http://review.typo3.org/5630
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] EM: Available extension list misses icons
Steffen Gebert [Sun, 9 Oct 2011 12:11:14 +0000 (14:11 +0200)]
[BUGFIX] EM: Available extension list misses icons

The list of available extensions misses the install/uninstall icons in
Firefox 7 and Internet Explorer 9.

Change-Id: I1c5f51eb37441935ffafbd22109f56c336ba89e2
Resolves: #30369
Releases: 4.6,4.5
Reviewed-on: http://review.typo3.org/5640
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
8 years ago[TASK] TSFE - Add hook after BE_USER init to clean up workspace functionality
Benjamin Mack [Sat, 8 Oct 2011 10:17:22 +0000 (12:17 +0200)]
[TASK] TSFE - Add hook after BE_USER init to clean up workspace functionality

In order to move workspace logic out of the TYPO3 core and into
versioning/workspaces extensions, a new hook is required first.
The hook will be placed after the backend authorization, and in
a followup issue the hook will be used for further cleanups of the
TSFE issue.

Change-Id: Ica08ce0c9d3802c6e9cd1b97d91f3d7a4efebd0f
Resolves: #30646
Releases: 4.6
Reviewed-on: http://review.typo3.org/5631
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[TASK] Clean up EM CSS file
Steffen Gebert [Sat, 8 Oct 2011 17:00:55 +0000 (19:00 +0200)]
[TASK] Clean up EM CSS file

Change-Id: I860f6257e67c0fd6182d26d743a0d67127db224f
Resolves: #30669
Reviewed-on: http://review.typo3.org/5635
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] EM, Error when downloading extension files
Markus Klein [Wed, 5 Oct 2011 23:56:50 +0000 (18:56 -0500)]
[BUGFIX] EM, Error when downloading extension files

Trying to download a file using the Edit Files page of the old EM
leads to a fatal error, because URL is not decoded properly.

Change-Id: I6980a0fbe8967bff0df0d8d7bc4c8f1abf53615e
Resolves: #27098
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/5578
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Stefan
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] Don't add uid,pid if <table>.'*' is present in field list.
Bjoern Pedersen [Wed, 14 Sep 2011 12:37:51 +0000 (14:37 +0200)]
[BUGFIX] Don't add uid,pid if  <table>.'*' is present in field list.

tx_cal_tsservice uses queries with select <tablename>.* and
complex joins. This breaks due to the unconditionl adding of uid,pid
if the query is set.

Do not add uid,pid,... to field list if the field list already contains a
'*' or the repective field is in the list.

To keep the code easier to read, the sanitizing has been moved
to a seperate function.

The regexp matching is necessary to  detect fields like post_uid
(comments extension).

Change-Id: I50332c22e627ea452aaee233fdbbdf3dd426a1b6
Resolves: #29783,#30486
Releases: 4.6
Reviewed-on: http://review.typo3.org/4974
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
Reviewed-by: Christof Rodejohann
Tested-by: Christof Rodejohann
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
8 years ago[BUGFIX] PHP warning on each Extension Manager invocation
Dmitry Dulepov [Thu, 6 Oct 2011 07:48:04 +0000 (10:48 +0300)]
[BUGFIX] PHP warning on each Extension Manager invocation

Extension manager produces a PHP warning on each invocation due to
incorrect parameters passed to t3lib_div::trimExplode().

Change-Id: I7bfd31677efb3cef07c0752486071e00d9ce889e
Resolves: #30598
Releases: 4.6
Reviewed-on: http://review.typo3.org/5581
Reviewed-by: Markus Klein
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[TASK] Introduce Hooks to create DB fields and keys dynamically
Thomas Maroschik [Fri, 9 Sep 2011 09:56:34 +0000 (11:56 +0200)]
[TASK] Introduce Hooks to create DB fields and keys dynamically

For the purpose of modifying the database schema upon extension
installation and database compare in install tool I implemented hooks
to append sql create statements dynamically.

Hooks are registered via:

$TYPO3_CONF_VARS['SC_OPTIONS']['typo3/mod/tools/em/index.php']
['checkDBupdates'] for changes in the extension manager and has to
implement tx_em_Index_CheckDatabaseUpdatesHook interface

$TYPO3_CONF_VARS['SC_OPTIONS']['ext/install/mod/class.tx_install.php']
['checkTheDatabase'] for changes in the install tool and has to
implement tx_em_Index_CheckDatabaseUpdatesHook interface

Change-Id: I66ff195ae8f656961f5251d7722a16a554aca219
Resolves: #29594
Releases: 4.6
Reviewed-on: http://review.typo3.org/4870
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] Prevent duplicate stdWrap for media content
Alexander Stehlik [Thu, 9 Jun 2011 22:17:14 +0000 (00:17 +0200)]
[BUGFIX] Prevent duplicate stdWrap for media content

All the standard renderers handle stdWrap themselves, so the general stdWrap
handling should be moved to the customMediaRenderer block to prevent duplicate
calls to stdWrap.

Change-Id: Ic0db017ad1d037636f1cb40994695686a2904c76
Fixes: #25277
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/2620
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
8 years ago[BUGFIX] Random miscalculations in ImageTTFBBox
Albrecht Koehnlein [Wed, 13 Jul 2011 09:47:21 +0000 (11:47 +0200)]
[BUGFIX] Random miscalculations in ImageTTFBBox

ImageTTFBBox() randomly returns incorrect negative values. Repeat the operation
a number of time if this happens to try to find the correct values.

Change-Id: I6c1548e0f8762d6c2befdd47dbfb7810b01c9508
Fixes: #21054
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/3281
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
8 years ago[BUGFIX] EM installs outdated versions of depending extensions
Steffen Gebert [Wed, 5 Oct 2011 20:11:13 +0000 (22:11 +0200)]
[BUGFIX] EM installs outdated versions of depending extensions

When installing an extension with a dependency to another extension,
which is not available on the server, EM retrieves it from TER. However,
by mistake it always retrieves the oldest version, not the newest.

Change-Id: I518cd5e4521d5ad1b578e342175f8b542ef42d02
Resolves: #29243
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/5574
Reviewed-by: Josef Florian Glatz
Tested-by: Josef Florian Glatz
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] Typo in gifbuilder
Simon Schaufelberger [Thu, 6 Oct 2011 10:13:31 +0000 (12:13 +0200)]
[BUGFIX] Typo in gifbuilder

stdWrap features GIFBUILDER transparentBackground and reduceColors
are broken

Change-Id: Icb74191aa6e53e8ca0737ead2638c3bda5d6a7fd
Resolves: #29445
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/5590
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
8 years ago[BUGFIX] RTE: Tag attributes are reversed on save
Stanislas Rolland [Tue, 4 Oct 2011 23:58:42 +0000 (19:58 -0400)]
[BUGFIX] RTE: Tag attributes are reversed on save

Problem: When saving a content element, the order of attributes of tags
is reversed. This clutters the workspace diffs with many changes. The
problem arises in WebKit and Opera.
Solution: Reverse the order of attributes.

Change-Id: I4686dc9a1a0a7a81b06ee6b6430371e86b593817
Resolves: #29855
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/5535
Reviewed-by: Markus Klein
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[BUGFIX] TCEforms draws huge empty icon row which on select-fields
Benjamin Mack [Wed, 5 Oct 2011 14:14:47 +0000 (16:14 +0200)]
[BUGFIX] TCEforms draws huge empty icon row which on select-fields

Certain fields of type "select" which offer records from a
"foreign_table" will contain a huge amount of t3-icon-empty
icons just below the select box. If you have enough of them,
you even get a horizotanl scrollbar.

See some screenshots here:
http://forge.typo3.org/issues/13422

The issue is not a CSS issue, but a bug in the rendering
of such a field.

See it in action in tt_content field "sys_language". Just create
enough sys_language records so that you see the row of empty
icons being created. This wasn't this way before.

Change-Id: I664400ee6ee1d778e227b1858f79b9ed98482d0a
Resolves: #25398
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/5569
Reviewed-by: Stefan Galinski
Tested-by: Stefan Galinski
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
8 years ago[TASK] Fix CGL issue in recent saltedpasswords commit
Oliver Hader [Thu, 6 Oct 2011 10:46:06 +0000 (12:46 +0200)]
[TASK] Fix CGL issue in recent saltedpasswords commit

Change-Id: Ie4d202bc29094f3c234c1929c7fdd6c129777044
Related: #22881
Reviewed-on: http://review.typo3.org/5586
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years agoRevert "[FEATURE] Indexed Search: add mySQL fulltext support"
Xavier Perseguers [Wed, 5 Oct 2011 12:56:37 +0000 (14:56 +0200)]
Revert "[FEATURE] Indexed Search: add mySQL fulltext support"

This reverts commit 6294f1fa8fd13a27ce93cfe6257d6754e8e0e1a6

This feature should be postponed to TYPO3 4.7, before feature freeze.

Change-Id: I86909cdf8e7e0133082b68000b014d3d4ad2a1ca
Reviewed-on: http://review.typo3.org/5566
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[BUGFIX] Removed dependency on TYPO3_MODE in saltedpasswords
Alexander Stehlik [Thu, 28 Apr 2011 13:53:28 +0000 (15:53 +0200)]
[BUGFIX] Removed dependency on TYPO3_MODE in saltedpasswords

Removed dependency on TYPO3_MODE constant in saltedpasswords which was
used to determine if the extension is enabled and which table (fe_users
or be_users) should be updated.

Since the mode is required in the init process of saltedpasswords where
the parent auth object is not available the new data in the info
array (introduced in #26410) is used.

Change-Id: I04180d283d6818b2e09d33f82036f6f88a5cb26c
Resolves: #22881
Reviewed-on: http://review.typo3.org/1778
Reviewed-by: Markus Klein
Reviewed-by: Stefan Neufeind
Reviewed-by: Steffen Ritter
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
8 years ago[TASK] Improve information in show_item.php
Soren Malling [Wed, 14 Sep 2011 12:35:52 +0000 (14:35 +0200)]
[TASK] Improve information in show_item.php

Currently the "Info" popup (show_item.php) provides information with raw
data from sys_refindex. A editor will get informations such as actual
table name from the database and a uid - but no real hint to what
records it's all about.

This patch provides information about table (name shown in list module),
field name ( as shown in TCEforms) for both references tables

Screenshots in forge issue

Change-Id: I3c053b261573eae47bc812978e3d9d23e69af2e1
Resolves: #29774
Reviewed-on: http://review.typo3.org/4971
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
8 years ago[FEATURE] Indexed Search: add mySQL fulltext support
Stefan Neufeind [Sun, 7 Aug 2011 22:44:32 +0000 (00:44 +0200)]
[FEATURE] Indexed Search: add mySQL fulltext support

Adds some minor modifications for restructuring in the pi code,
and some hooks in order to allow for other search engines to be
used.
Additionally, "indexed_search_mysql" is added to the core that
allows the mysql fulltext search with it.
Thanks to Michael Stucki for all the work!

Change-Id: I19ebc78dd0bb79297ee78104c7c6979379f2001e
Resolves: #28613
Reviewed-on: http://review.typo3.org/3925
Reviewed-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
8 years ago[BUGFIX] Email links marked as external when preceded by external link
Stanislas Rolland [Tue, 4 Oct 2011 16:29:11 +0000 (12:29 -0400)]
[BUGFIX] Email links marked as external when preceded by external link

Variable is not initialized leading to incorrect transformation
on way to RTE.

Change-Id: I38751c6c5eb56920eb1286f2d39393b3dae7ce34
Resolves: #29782
Releases: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/5537
Reviewed-by: Markus Klein
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
8 years ago[BUGFIX] meaningfulTempFilePrefix is not multi-byte safe
Steffen Gebert [Sun, 2 Oct 2011 08:23:59 +0000 (10:23 +0200)]
[BUGFIX] meaningfulTempFilePrefix is not multi-byte safe

On a utf-8 file system meaningful prefixes can contain utf-8 characters. To
prevent truncating in the middle of a multi-byte character the API functions
must be used instead of substr().

Change-Id: I760f80b8cfa2dcea8b554c24467f56b662d465d9
Resolves: #30416
Releases: 4.5, 4.6
Author: Steffen Gebert <steffen.gebert@typo3.org>
Reviewed-on: http://review.typo3.org/5479
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
8 years ago[BUGFIX] Copying directories is impossible
Andreas Wolf [Thu, 22 Sep 2011 21:05:00 +0000 (23:05 +0200)]
[BUGFIX] Copying directories is impossible

Due to a bug introduced with a refactoring of t3lib_extFileFunc, it
became impossible to copy directories. The two wrong statements (they
were not inverted though they should have been) are fixed with this
commit.

Change-Id: Iaac9cbcf30e2b73e2fd7f5df6986e1ccdf76c079
Resolves: #30213
Related: #24218
Releases: 4.6
Reviewed-on: http://review.typo3.org/5241
Reviewed-by: Markus Klein
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Tested-by: Markus Klein
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] config.compressCss = 1 does not work
Xavier Perseguers [Tue, 4 Oct 2011 08:51:02 +0000 (10:51 +0200)]
[BUGFIX] config.compressCss = 1 does not work

TypoScript configuration option 'compressCss' is never tested and thus
does not work. Only the deprecated configuration option 'minifyCSS' is
taken into account.

Change-Id: Ic9d15bd1da84c92602a7e88283161c5b109d2939
Fixes: #30537
Releases: 4.6
Reviewed-on: http://review.typo3.org/5522
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
8 years ago[BUGFIX] RTE: Add TYPO3 version to hash of cached scripts
Stanislas Rolland [Tue, 4 Oct 2011 03:45:38 +0000 (23:45 -0400)]
[BUGFIX] RTE: Add TYPO3 version to hash of cached scripts

Problem: Fixed JS scripts may not be loaded when a new version of
TYPO3 is released. This may happen if the version of htmlArea RTE was
not incremented. This is an error-prone situation.
Solution: Add TYPO3 version to hash of cached scripts

Change-Id: I78b94620cf782423fa70b779661ddb759c4915f5
Resolves: #30534
Releases: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/5511
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[BUGFIX] RTE: Compressor fails on files with absolute url in FE
Stanislas Rolland [Tue, 4 Oct 2011 03:19:04 +0000 (23:19 -0400)]
[BUGFIX] RTE: Compressor fails on files with absolute url in FE

Solution: Use relative url.

Change-Id: I5bca5cd8567f9489e07ec928b9b2e046e970f212
Resolves: #30533
Releases: 4.6
Reviewed-on: http://review.typo3.org/5510
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[BUGFIX] Module User Settings calls deprecated methods
Xavier Perseguers [Sun, 2 Oct 2011 14:19:49 +0000 (16:19 +0200)]
[BUGFIX] Module User Settings calls deprecated methods

When opening user settings, two deprecated methods are called. The new
methods cannot be used as they combine the business logic into a single
call but do not offer the same information granularity.

Change-Id: I13df6093e61d9ba2aa730c27ac4f9b7471443f6a
Fixes: #30516
Releases: 4.6
Reviewed-on: http://review.typo3.org/5481
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] Modify jumpTo to work with the new cardLayout
Kay Strobach [Thu, 29 Sep 2011 17:35:38 +0000 (19:35 +0200)]
[BUGFIX] Modify jumpTo to work with the new cardLayout

Modifies the jumpTo function as described in #28851
This replaces the call

top.TYPO3.Backend.ContentContainer.setUrl()

with
top.TYPO3.ModuleMenu.App.openInContentFrame()

Change-Id: I7101563ad92da7d15baaa135629e3185630ab727
Resolves: #30409
Releases: 4.6
Reviewed-on: http://review.typo3.org/5448
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Markus Klein
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
8 years ago[BUGFIX] Link to manual of sysext "form" is not displayed in EM
Xavier Perseguers [Sat, 1 Oct 2011 06:47:59 +0000 (08:47 +0200)]
[BUGFIX] Link to manual of sysext "form" is not displayed in EM

The system extension "form" comes with a manual in
typo3/sysext/form/Documentation/Manual/en/manual.sxw. As the corresponding
'docPath' key is not defined in ext_emconf.php, the link to open this
manual in not shown in the Extension Manager.

Change-Id: Ia644d3dcebdc8e8909a0a54a760825028e637104
Fixes: #30444
Releases: 4.6
Reviewed-on: http://review.typo3.org/5476
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
8 years ago[BUGFIX][SECURITY] Arbitrary TypoScript execution on system extension form
Oliver Hader [Tue, 20 Sep 2011 15:53:24 +0000 (17:53 +0200)]
[BUGFIX][SECURITY] Arbitrary TypoScript execution on system extension form

The new system extension form can be used to render custom FORM elements as
well as regular cObjects like TEXT or COA. Since the form wizard can be used
by any editor in the backend and writes data to the field bodytext, this can
also be used to execute arbitrary TypoScript without further access checks.

This change introduces two defined and allowed content elements "header" and
"textblock" that can be defined by using the form wizard. If the TypoScript
that was generated by the mentioned wizard is rendered, regular cObjects are
disabled. If the FORM or FORM_INT cObject is used directly from a TypoScript
template, all possible cObjects can still be used.

Change-Id: I573764de7583b078456e71e95ea7903b433c29db
Resolves: #30095
Releases: 4.6
Reviewed-on: http://review.typo3.org/5128
Reviewed-by: Andreas Wolf
Reviewed-by: Frederic Gaus
Tested-by: Frederic Gaus
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[BUGFIX] getSingleField_typeFlex doesn't respect TSconfig settings
cybercraft [Tue, 16 Aug 2011 15:37:28 +0000 (17:37 +0200)]
[BUGFIX] getSingleField_typeFlex doesn't respect TSconfig settings

Change-Id: I73bb1739d9b85320f00f4a228ade898d41a5df9c
Resolves: #29019
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/4377
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
8 years ago[TASK] Update reference from SVN to Git
Xavier Perseguers [Wed, 21 Sep 2011 15:18:53 +0000 (17:18 +0200)]
[TASK] Update reference from SVN to Git

Module About TYPO3 shows this text:
The SVN Repository and the ChangeLog can be found here.

This has to be updated to read "Git" instead of "SVN".

Change-Id: I8e708f9e47e5afa5f4528bd308ca13b7f2535364
Resolves: #30171
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/5164
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
8 years ago[BUGFIX][t3editor] typolinkEnableLinksAcrossDomains missing
Steffen Gebert [Sun, 18 Sep 2011 14:10:46 +0000 (16:10 +0200)]
[BUGFIX][t3editor] typolinkEnableLinksAcrossDomains missing

The description for config.typolinkEnableLinksAcrossDomains is missing
in the t3editor auto-completion.

Change-Id: I701773bf9f6525035754ad46e54af5716e753c47
Fixes: #27697
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/5028
Reviewed-by: Tobias Liebig
Tested-by: Tobias Liebig
8 years ago[TASK] Refactor view component of system extension form
Oliver Hader [Tue, 20 Sep 2011 14:54:49 +0000 (16:54 +0200)]
[TASK] Refactor view component of system extension form

Get rid of calling the constructor of the parent without any additional logic.

Change-Id: I5ebfe092c4174db0c75d76c1469ddff15e6c4ddf
Resolves: #30094
Releases: 4.6
Reviewed-on: http://review.typo3.org/5125
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[TASK] Set TYPO3 version to 4.6-dev
TYPO3 v4 Release Team [Tue, 20 Sep 2011 13:34:15 +0000 (15:34 +0200)]
[TASK] Set TYPO3 version to 4.6-dev

Change-Id: I8856a8f5dc9e59b7e6ae629f365c34cf07a7e605
Reviewed-on: http://review.typo3.org/5122
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
8 years ago[RELEASE] Release of TYPO3 4.6.0beta3
TYPO3 v4 Release Team [Tue, 20 Sep 2011 13:34:07 +0000 (15:34 +0200)]
[RELEASE] Release of TYPO3 4.6.0beta3

Change-Id: Id2eebe9044ef8c2710bcc16e2caca8d8e22eb28b
Reviewed-on: http://review.typo3.org/5121
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
8 years ago[TASK] Raise submodule pointer
TYPO3 v4 Release Team [Tue, 20 Sep 2011 13:30:42 +0000 (15:30 +0200)]
[TASK] Raise submodule pointer

Change-Id: I68120670e097815523ebd628135b90ed939c8905
Reviewed-on: http://review.typo3.org/5120
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
8 years ago[BUGFIX] check for required PHP modules in Reports module
Jigal van Hemert [Mon, 19 Sep 2011 23:48:52 +0000 (01:48 +0200)]
[BUGFIX] check for required PHP modules in Reports module

The 1-2-3 installer checks for the presence of the required PHP modules. The
Reports module needs to perform this check to catch problems in many
situations.

Change-Id: I0b19bfb4d0f6a5bdd48ba8df9869ecfc4dd3a2d6
Fixes: #30054
Releases: 4.6
Reviewed-on: http://review.typo3.org/5094
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Oliver Hader
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
8 years ago[TASK] Raise t3editor version and set state to stable
Tobias Liebig [Tue, 20 Sep 2011 08:43:08 +0000 (10:43 +0200)]
[TASK] Raise t3editor version and set state to stable

For the beta3 release of the 4.6 core, all sysexts should have the state
stable. Further the t3editor version number needs to be adjusted for the
upcoming 4.6.0 release.

Change-Id: I20c0c4dba4600c95ee2411591004542f0e5dc354
Resolves: #30077
Releases: 4.6
Reviewed-on: http://review.typo3.org/5100
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] t3lib_Compressor breaks absolute paths in CSS
Andreas Bouche [Mon, 19 Sep 2011 09:23:20 +0000 (11:23 +0200)]
[BUGFIX] t3lib_Compressor breaks absolute paths in CSS

Adds a negative lookahead for trailing slash to the regular
Expressions in method "cssFixRelativeUrlPaths" to exclude
absolute paths from being rewritten.

Change-Id: I36355f46da53d167a9fb318228383a6181920398
Resolves: #29904
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/5051
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] Wrong content element rendering in system extension form
Oliver Hader [Tue, 20 Sep 2011 11:53:23 +0000 (13:53 +0200)]
[BUGFIX] Wrong content element rendering in system extension form

The ability to render custom content elements in the system extension form fails.

Change-Id: Ib2ff3cc391705be458140c9a0dea0e6255948e83
Resolves: #30088
Releases: 4.6
Reviewed-on: http://review.typo3.org/5117
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[TASK] Strict string value handling in system extension form
Oliver Hader [Tue, 20 Sep 2011 10:56:04 +0000 (12:56 +0200)]
[TASK] Strict string value handling in system extension form

Misconfigurations in e.g. TypoScript lead to cased "Array" strings.

Change-Id: I3e161b855d7628d2b2bfc10df9dab3e9ef1d5356
Resolves: #30086
Releases: 4.6
Reviewed-on: http://review.typo3.org/5109
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[TASK] Missing report for deprecated setting magic_quotes_gpc
Xavier Perseguers [Tue, 20 Sep 2011 09:11:44 +0000 (11:11 +0200)]
[TASK] Missing report for deprecated setting magic_quotes_gpc

Since PHP 5.3, PHP INI setting magic_quotes_gpc is deprecated but still
defaults to "On". A report should be added to raise awareness of the
administrators.

Change-Id: Icdaeee1ea054bda1f26c5d3060e74006e7077e26
Resolves: #30079
Releases: 4.6
Reviewed-on: http://review.typo3.org/5101
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] Improve usability of group fields
Stefan Geith [Fri, 15 Jul 2011 07:35:58 +0000 (09:35 +0200)]
[BUGFIX] Improve usability of group fields

If you set
    'disable_controls'=>'list'
you can _once_ upload an image (or file). But because of a missing Delete-Button
you never are able to change this image (or file) later.

Solution is, to add the delete Button, even if the list is not shown.
To remove even the delete button, use
    'disable_controls'=>'list,delete'

Change-Id: Ia13a9a25a64742eb49e64b7f26c085f15ca72b87
Resolves: #22679, #M14430
Releases: 4.6
Reviewed-on: http://review.typo3.org/3347
Reviewed-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
8 years ago[!!!][TASK] Deprecate usage of old Extension Manager
Xavier Perseguers [Mon, 19 Sep 2011 11:44:24 +0000 (13:44 +0200)]
[!!!][TASK] Deprecate usage of old Extension Manager

The old Extension Manager should be officially deprecated in order to
concentrate on enhancing the ExtJS-based one.

Change-Id: I6e5b2daf149faa92973f4a3f1c41aaa82cb90ae8
Resolves: #30027
Releases: 4.6
Reviewed-on: http://review.typo3.org/5057
Reviewed-by: Markus Klein
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] Label status_configuration_PhpSafeModeEnabled is not retrieved
Xavier Perseguers [Tue, 20 Sep 2011 09:21:36 +0000 (11:21 +0200)]
[BUGFIX] Label status_configuration_PhpSafeModeEnabled is not retrieved

Wrong method is used to retrieve label status_configuration_PhpSafeModeEnabled.

Change-Id: Ie14d4d446a9d5e51e60594576a1cf3d42468f952
Fixes: #30081
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/5102
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] EM: tx_em_Repository::addMirrors() has invalid method signature
Xavier Perseguers [Tue, 20 Sep 2011 08:12:40 +0000 (10:12 +0200)]
[BUGFIX] EM: tx_em_Repository::addMirrors() has invalid method signature

Invalid use of variable passed by reference in the method signature throws
a PHP Runtime Notice in tx_em_Repository_Utility.

Change-Id: I37f0ebb551b2d4fc06baa2c13c4c8bfcb15266ee
Fixes: #30072
Releases: 4.6
Reviewed-on: http://review.typo3.org/5099
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[TASK] EM: cleanup phpDoc and fix type hints
Xavier Perseguers [Tue, 20 Sep 2011 07:45:08 +0000 (09:45 +0200)]
[TASK] EM: cleanup phpDoc and fix type hints

Add type hints and fix obviously wrong references (missing "tx_"
and wrong case in class name).

Change-Id: I702ccf454d9a547a075537e36a250169442ba1e1
Resolves: #30074
Releases: 4.6
Reviewed-on: http://review.typo3.org/5098
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[FEATURE][t3editor] Update TypoScript reference for TYPO3 4.6
Steffen Gebert [Sun, 18 Sep 2011 18:10:40 +0000 (20:10 +0200)]
[FEATURE][t3editor] Update TypoScript reference for TYPO3 4.6

Updated the syntax completion database of t3editor to the changes of
TYPO3 4.6.

Change-Id: I798196aafd16c75f924f49c2f01389e43fb901c5
Resolves: #29995
Releases: 4.6
Reviewed-on: http://review.typo3.org/5037
Tested-by: Stephan Petzl
Tested-by: Jigal van Hemert
Reviewed-by: Björn Pedersen
Reviewed-by: Jigal van Hemert
8 years ago[BUGFIX] Initialize $currentR in analyseTypoLinks
Bjoern Pedersen [Tue, 20 Sep 2011 05:01:59 +0000 (07:01 +0200)]
[BUGFIX] Initialize $currentR in analyseTypoLinks

There are pathes through analyseTypoLinks where currentR is
 not set, it can happen that the fetchType hook gets
called with currentR=null.

This throws an API error as the fetchType interface
requires the first arg to be an array.

Change-Id: I2d517b8c57678e645c590b51d50343c42a3d36a9
Resolves: #30043
Releases: 4.6
Reviewed-on: http://review.typo3.org/5097
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
8 years ago[TASK] Clean-up PHPdoc in t3lib_div
Oliver Hader [Mon, 19 Sep 2011 23:34:09 +0000 (01:34 +0200)]
[TASK] Clean-up PHPdoc in t3lib_div

* fix some PHPdoc comments
* remove @author annotations

Change-Id: If0600e654b785683e1b394154022c650fee7dcda
Resolves: #30066
Releases: 4.6
Reviewed-on: http://review.typo3.org/5093
Reviewed-by: Björn Pedersen
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] Undefined t3lib_utility_Mail::breakLinesForPlainEmail()
Oliver Hader [Mon, 19 Sep 2011 22:44:50 +0000 (00:44 +0200)]
[BUGFIX] Undefined t3lib_utility_Mail::breakLinesForPlainEmail()

t3lib_utility_Mail::breakLinesForPlainEmail() is not defined.

Change-Id: I7d375aa53e7ab32f8cce383afd0a458da21a80f3
Resolves: #30065
Releases: 4.6
Reviewed-on: http://review.typo3.org/5092
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[BUGFIX] Non-static function t3lib_TStemplate::sortedKeyList()
Oliver Hader [Mon, 19 Sep 2011 22:35:08 +0000 (00:35 +0200)]
[BUGFIX] Non-static function t3lib_TStemplate::sortedKeyList()

t3lib_TStemplate::sortedKeyList() is used in a static context
but is not declared to be static.

Change-Id: I2659730d60e750d42d7c46372067e926a0d2411d
Resolves: #30064
Releases: 4.6
Reviewed-on: http://review.typo3.org/5091
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[TASK] Refactor code of new form system extension
Oliver Hader [Mon, 19 Sep 2011 18:42:28 +0000 (20:42 +0200)]
[TASK] Refactor code of new form system extension

* remove superfluous __construct() methods
* fix PHPdoc comments and add type hints
* remove unused classes
* fix CGL issues

Change-Id: Ie859ea0a54a8234b5c5c8d6d16f0be6c947a9bc5
Resolves: #30046
Reviewed-on: http://review.typo3.org/5077
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[BUGFIX] Some methods of SC_mod_web_perm_ajax should be static
Xavier Perseguers [Mon, 19 Sep 2011 22:20:29 +0000 (00:20 +0200)]
[BUGFIX] Some methods of SC_mod_web_perm_ajax should be static

Fix the method signatures that are statically called throughout the Core.

Change-Id: Ic415b271eb66950de9dbaf1a82b130112b026f35
Fixes: #30063
Releases: 4.6
Reviewed-on: http://review.typo3.org/5090
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] Invalid method signature for t3lib_pageTree::init()
Xavier Perseguers [Mon, 19 Sep 2011 22:11:17 +0000 (00:11 +0200)]
[BUGFIX] Invalid method signature for t3lib_pageTree::init()

Method t3lib_treeView::init() is not properly overriden in subclasses.

Change-Id: Ia39eb8ba775e1f217fb77f402dd8f2ab4e1d24ae
Fixes: #30062
Releases: 4.6
Reviewed-on: http://review.typo3.org/5089
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] Invalid method signature for t3lib_tree_extdirect_Node::toArray()
Xavier Perseguers [Mon, 19 Sep 2011 22:02:51 +0000 (00:02 +0200)]
[BUGFIX] Invalid method signature for t3lib_tree_extdirect_Node::toArray()

Method toArray() from t3lib_tree_Node is not properly overriden in subclasses.

Furthermore, many phpDoc comments are wrongly returning void instead of bool.

Change-Id: I99bea296df305673d5c111fc9e5b92ea42599c5f
Fixes: #30060
Releases: 4.6
Reviewed-on: http://review.typo3.org/5088
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] Invalid method signature for ext_posMap::onClickInsertRecord()
Xavier Perseguers [Mon, 19 Sep 2011 21:54:37 +0000 (23:54 +0200)]
[BUGFIX] Invalid method signature for ext_posMap::onClickInsertRecord()

Invalid method override signature.

Change-Id: Ifb82ee48c8a83c626004cf67e6529f386d8edb40
Fixes: #30061
Releases: 4.6
Reviewed-on: http://review.typo3.org/5087
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] Methods of tx_em_Database should be static
Xavier Perseguers [Mon, 19 Sep 2011 21:40:32 +0000 (23:40 +0200)]
[BUGFIX] Methods of tx_em_Database should be static

Methods of class tx_em_Database miss the static keyword and, sometimes,
the visibility as well.

Change-Id: I477ca961ae9dc6fc456c3e90fd8f0871be2cc145
Fixes: #30059
Releases: 4.6
Reviewed-on: http://review.typo3.org/5086
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] Some methods in t3lib_TSparser should be static
Xavier Perseguers [Mon, 19 Sep 2011 21:23:23 +0000 (23:23 +0200)]
[BUGFIX] Some methods in t3lib_TSparser should be static

A few methods in t3lib_TSparser are called statically but are not
declared as being static. This leads to PHP notices.

Change-Id: I7ea7cb659a830e74c4f8797f118662b517015614
Fixes: #30058
Releases: 4.6
Reviewed-on: http://review.typo3.org/5085
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] tx_rsaauth_sv1::authUser() gives PHP notice
Xavier Perseguers [Mon, 19 Sep 2011 21:12:00 +0000 (23:12 +0200)]
[BUGFIX] tx_rsaauth_sv1::authUser() gives PHP notice

PHP Runtime Notice: Declaration of tx_rsaauth_sv1::authUser() should
be compatible with that of tx_sv_auth::authUser().

Change-Id: Idbd7ca2b69d3142497b1770088d991901950a852
Fixes: #30057
Releases: 4.6
Reviewed-on: http://review.typo3.org/5084
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] Invalid use of array_shift() in t3lib_div
Xavier Perseguers [Mon, 19 Sep 2011 20:58:53 +0000 (22:58 +0200)]
[BUGFIX] Invalid use of array_shift() in t3lib_div

PHP Runtime Notice: Only variables should be passed by reference.

Change-Id: Ib1e9af4b58202f085d1afbba2b9bd0b288a8ef58
Fixes: #30056
Releases: 4.6
Reviewed-on: http://review.typo3.org/5083
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] t3lib_userAuthGroup::checkLogFailures() gives PHP notice
Xavier Perseguers [Mon, 19 Sep 2011 20:47:00 +0000 (22:47 +0200)]
[BUGFIX] t3lib_userAuthGroup::checkLogFailures() gives PHP notice

Due to improper method signature in the parent class of t3lib_userAuthGroup,
a PHP notice is generated when calling method checkLogFailures().

Change-Id: Ic41cb88889ee18f2508ae5b2e96858e8bf16c349
Fixes: #30055
Releases: 4.6
Reviewed-on: http://review.typo3.org/5082
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] Allow proper method override in tx_coreupdates_installsysexts
Xavier Perseguers [Mon, 19 Sep 2011 20:30:28 +0000 (22:30 +0200)]
[BUGFIX] Allow proper method override in tx_coreupdates_installsysexts

Method tx_coreupdates_installsysexts::performUpdate() cannot be properly overriden
because its signature is incomplete.

This leads to PHP notices.

Change-Id: Iaf13c166c07d04ee194bec1543ac5ae450f1e38b
Fixes: #30053
Releases: 4.6
Reviewed-on: http://review.typo3.org/5078
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] t3lib_div should contain only static methods
Xavier Perseguers [Mon, 19 Sep 2011 20:24:49 +0000 (22:24 +0200)]
[BUGFIX] t3lib_div should contain only static methods

A few methods don't have the static keyword. This leads to PHP notices.

Change-Id: I90a99601a39cd26abed665b42a8b054385f561ff
Fixes: #30050
Releases: 4.6
Reviewed-on: http://review.typo3.org/5075
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] Don't unnecessarily start PHP session
Helmut Hummel [Sat, 17 Sep 2011 15:59:51 +0000 (17:59 +0200)]
[BUGFIX] Don't unnecessarily start PHP session

Because of an information disclosure problem in the backend login
we moved the session_start() in t3lib_userauth in a place which caused
unwanted side effects with 3rd party extensions.

Revert that change to avoid compatibility and performance problems
and instead send no cache headers earlier in t3lib_userauth
to also fix the information disclosure.

Releases: 4.3, 4.4, 4.5, 4.6
Resolves: #29274
Related: #24456, #28694

Change-Id: I87226a21d9b1955773ceb3c377fa1b4c9938e6b2
Reviewed-on: http://review.typo3.org/5007
Reviewed-by: Christopher Hlubek
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Xavier Perseguers
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
8 years ago[TASK] Fix CGL issues on class names in system extension form
Oliver Hader [Tue, 2 Aug 2011 12:39:10 +0000 (14:39 +0200)]
[TASK] Fix CGL issues on class names in system extension form

Change-Id: Ic41b317fdb608dcc5630859168d3d5674bfe0593
Resolves: #28679
Reviewed-on: http://review.typo3.org/4024
Reviewed-by: Xavier Perseguers
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[BUGFIX] t3editor not visible with TYPO3 on Windows
Jigal van Hemert [Mon, 19 Sep 2011 11:51:31 +0000 (13:51 +0200)]
[BUGFIX] t3editor not visible with TYPO3 on Windows

The template for t3editor contains CRLF line endings on Windows systems. To
prevent JS errors and to make the t3editor visible the CR parts of the line
endings must be removed.

Change-Id: If4f126c46ab243e616292a60563ebe4bea3fd624
Fixes: #30026
Branches: 4.6
Reviewed-on: http://review.typo3.org/5058
Reviewed-by: Oliver Hader
Reviewed-by: Tobias Liebig
Tested-by: Tobias Liebig
8 years ago[TASK] Add SwiftMailer license exception to be included in TYPO3v4
Ernesto Baschny [Thu, 15 Sep 2011 10:00:03 +0000 (12:00 +0200)]
[TASK] Add SwiftMailer license exception to be included in TYPO3v4

Change-Id: Ie72691fc5146bed17e11e959081f655371bfafed
Resolves: #29802
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/5062
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[BUGFIX] Disable Upgade Wizard "Version Compatibility" when up to date
Steffen Gebert [Sun, 18 Sep 2011 18:29:13 +0000 (20:29 +0200)]
[BUGFIX] Disable Upgade Wizard "Version Compatibility" when up to date

The Version Compatibility always appears at the first place and tells
you that you should upgrade your compatVersion or that everything is
okay, but you might.. if you really really want this.. in case of, don't
know, whatever reason.. downgrad again.

Remove this ugly thing. compat_version can still be changed again using
"All configuration".

Change-Id: Ie45a50ab20a0c8d59021362e45b7bed743e43199
Resolves: #24834
Releases: 4.6
Reviewed-on: http://review.typo3.org/5038
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
8 years ago[TASK] Remove the "Enable Install Tool" button
Steffen Gebert [Sun, 18 Sep 2011 18:59:46 +0000 (20:59 +0200)]
[TASK] Remove the "Enable Install Tool" button

The "Enable Install Tool" button in the User Settings is useless, as the
Install Tool is automatically enabled (after request) since #28621
and #28689.

Change-Id: I596a0b45d9b947e58b30e0082f23413b56e6f325
Resolves: #29996
Releases: 4.6
Reviewed-on: http://review.typo3.org/5040
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
8 years ago[BUGFIX] Respect PATH_site in t3lib_autoloader::getAutoloadCacheIdentifier
Frederic Gaus, Flagbit GmbH & Co. KG [Fri, 16 Sep 2011 14:34:49 +0000 (16:34 +0200)]
[BUGFIX] Respect PATH_site in t3lib_autoloader::getAutoloadCacheIdentifier

Function t3lib_autoloader::getAutoloadCacheIdentifier now respects the constant
PATH_site. This is needed because otherwise a fatal error occures when the
path to webroot changes (e.g. moving site to another webserver)

Change-Id: I9755da82cbf71914d47bc0523bacc8413addcf63
Resolves: #29901
Releases: 4.6
Reviewed-on: http://review.typo3.org/5000
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
8 years ago[BUGFIX] 1-2-3 installer does not create cache tables
Dmitry Dulepov [Fri, 16 Sep 2011 11:45:02 +0000 (14:45 +0300)]
[BUGFIX] 1-2-3 installer does not create cache tables

After 1-2-3 installation it is not possible to start using TYPO3
because caching framework tables are missing. TYPO3 backend shows
SQL errors in the debug console (if enabled).

Resolves: #29894
Releases: 4.6

Change-Id: I343ddd6ab3171b5337c53cb58e3e120ea3e6469a
Reviewed-on: http://review.typo3.org/4996
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
8 years ago[BUGFIX] Space between Template Analyzer options
Tomas Norre Mikkelsen [Sat, 17 Sep 2011 14:52:49 +0000 (16:52 +0200)]
[BUGFIX] Space between Template Analyzer options

Add some space between the Template Analyzer options and vertically
align the labels.

Change-Id: Ifb6124beed73f2b176826096e9c20e3a17fcd2af
Resolves: #27588
Reviewed-on: http://review.typo3.org/5006
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] No margin between search and sys_notes
Tomas Norre Mikkelsen [Sat, 17 Sep 2011 18:25:25 +0000 (20:25 +0200)]
[BUGFIX] No margin between search and sys_notes

Change-Id: I06c172211fb737ed51afd846c44e00ba2e0dbd0e
Resolves: #27603
Reviewed-on: http://review.typo3.org/5013
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[TASK] EM: move "upload t3x" to tab Remote Repository
Xavier Perseguers [Sat, 10 Sep 2011 09:00:36 +0000 (11:00 +0200)]
[TASK] EM: move "upload t3x" to tab Remote Repository

In an attempt to have the Remote Repository tab become a place to
search and install new extensions, the tiny upload .t3x icon next
to the filter textbox in "Local Extension List" should be moved.

Change-Id: I198dc95ecd8dcd953f699428d7118a9670d6b277
Resolves: #29587
Releases: 4.6
Reviewed-on: http://review.typo3.org/4893
Tested-by: Soren Malling
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] Alignment issue in "View Item" window
Tomas Norre Mikkelsen [Thu, 15 Sep 2011 22:32:29 +0000 (00:32 +0200)]
[BUGFIX] Alignment issue in "View Item" window

The file name and dimension information need some space for better
separation in the "View Item" window.

Change-Id: I0d737d85b7444747c7292362a43f48528a0d4806
Resolves: #27602
Reviewed-on: http://review.typo3.org/4987
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
8 years ago[TASK] Index for "pages" table is still not optimal
Dmitry Dulepov [Fri, 16 Sep 2011 12:11:46 +0000 (15:11 +0300)]
[TASK] Index for "pages" table is still not optimal

The fix for #21381 causes "using filesort" in the List view for
"pages" table. This happens due to the "hidden" field in the
index. This field should be removed from the index because it is
not needed for the List module and it is not useful in FE due to
more expensive fe_group field.

Change-Id: Ia5fc87f7b1fa89e515c292248365d1d684872be0
Resolves: #29896
Related: #21381
Releases: 4.6
Reviewed-on: http://review.typo3.org/4997
Reviewed-by: Björn Pedersen
Reviewed-by: Frederic Gaus
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] About modules: Adjust bgcolor of sections
Tomas Norre Mikkelsen [Sat, 17 Sep 2011 13:55:17 +0000 (15:55 +0200)]
[BUGFIX] About modules: Adjust bgcolor of sections

Adjust the background color of the module section table cells to match
the "body" background color.

Change-Id: Id688471665257a985004bf44cf5aec7fc646de08
Resolves: #27589
Reviewed-on: http://review.typo3.org/5004
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] Check curl availability before using it
Tolleiv Nietsch [Tue, 13 Sep 2011 11:47:08 +0000 (13:47 +0200)]
[BUGFIX] Check curl availability before using it

Curl is used when activated in the install tool.
The core should check if curl is available before using it.

Because the getUrl() refactoring will hopefully be ready in 4.7,
I found that this simple solution should at least fix it for 4.6.

Change-Id: I29e4d3b760aaf09f95a2ba6f560fe6562a7d5310
Resolves: #24984
Branches: 4.6, 4.5
Reviewed-on: http://review.typo3.org/4956
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
8 years ago[BUGFIX] Fix backpath for add wizards in IRRE records
Sebastian Fischer [Wed, 14 Sep 2011 13:09:37 +0000 (15:09 +0200)]
[BUGFIX] Fix backpath for add wizards in IRRE records

As in typo3/init.php the TYPO3_mainDir is set to 'typo3/' the replacement in
renderForeignRecord could not work because it uses the TYPO3_mainDir . '%2Fajax.php'
which results in typo3//ajax.php
By this the backpath of the add wizard in IRRE foreign records is fixed.

Change-Id: Id2bb587243b7ffbf8458ac3cecfa9ddaa5266d5c
Resolves: #29770
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/4976
Reviewed-by: Björn Pedersen
Reviewed-by: Tobias Liebig
Tested-by: Tobias Liebig
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
8 years ago[TASK] Refactor t3lib_message_AbstractMessage
Steffen Gebert [Mon, 8 Aug 2011 19:48:28 +0000 (21:48 +0200)]
[TASK] Refactor t3lib_message_AbstractMessage

Change-Id: I5a63a5ad1d491af6bbf9ac374b9df3d3f7a4d9b8
Resolves: #29495
Reviewed-on: http://review.typo3.org/4776
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
8 years ago[BUGFIX] t3lib_Compressor: Avoid reference in foreach loop
Frederic Gaus [Thu, 15 Sep 2011 13:57:29 +0000 (15:57 +0200)]
[BUGFIX] t3lib_Compressor: Avoid reference in foreach loop

This fixes a bug introduced in #29695. There is a PHP bug
when using $filename as a reference and later on as a variable in
a foreach loop. The problem is described here:

http://www.php.net/manual/de/control-structures.foreach.php#101425

PHP 5.3.2 (used in current Ubuntu) and 5.3.3 (used in current Debian)
are affected. Other versions could be affected, too.

Avoiding the use of reference in the foreach loop fixes the bug.

Change-Id: I74c0ceee40e170b7cf2e7db91b1554d811a7c844
Resolves: #29832
Releases: 4.6
Related: #29695
Reviewed-on: http://review.typo3.org/4983
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
8 years ago[BUGFIX] t3lib_Compressor fails with external files
Xavier Perseguers [Mon, 12 Sep 2011 14:02:41 +0000 (16:02 +0200)]
[BUGFIX] t3lib_Compressor fails with external files

Externally-referenced files such as jQuery included from a CDN fail to be
concatenated or compressed.

Change-Id: Idd02d85c98811167cccafd2e6a6a96fefda6a936
Fixes: #29695
Releases: 4.6
Reviewed-on: http://review.typo3.org/4924
Reviewed-by: Björn Pedersen
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Tested-by: Björn Pedersen
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] SQL Injection vulnerability in prepared statements
Helmut Hummel [Tue, 13 Sep 2011 18:32:19 +0000 (20:32 +0200)]
[BUGFIX] SQL Injection vulnerability in prepared statements

Change-Id: Iaa91761cd2dafbe7be1d6f6c5db169e3a8f48b0c
Resolves: #29400
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/4961
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[BUGFIX] Disabling the cache does not work on invalid cHash value
Daniel Pötzinger [Tue, 30 Aug 2011 20:40:31 +0000 (22:40 +0200)]
[BUGFIX] Disabling the cache does not work on invalid cHash value

Change-Id: I9df3d7b4bf1d565fc5a429bad6ee2d3d186f6044
Releases: 4.6, 4.5, 4.4, 4.3
Resolves: #29366
Reviewed-on: http://review.typo3.org/4705
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
8 years ago[BUGFIX] Show extension configuration after extension update
Helmut Hummel [Sat, 10 Sep 2011 10:28:27 +0000 (12:28 +0200)]
[BUGFIX] Show extension configuration after extension update

When updating an extension, updates of database tables are not
shown and not offered to be updated. Thus they remain unnoticed
and this leads to unexpected results.

Show extension configuration and database updates after updating an extension.

Resolves: #29625
Releases: 4.5, 4.6

Change-Id: I82281494b71cd9fa38235ebafaa2b2423d15436d
Reviewed-on: http://review.typo3.org/4898
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
8 years ago[TASK] Raise submodule pointer
TYPO3 v4 Release Team [Wed, 14 Sep 2011 08:12:59 +0000 (10:12 +0200)]
[TASK] Raise submodule pointer

Change-Id: I88562065fcedd8503554a7f9c9411d9599ca1292
Reviewed-on: http://review.typo3.org/4957
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
8 years ago[BUGFIX] No content in workspace preview when using select.selectFields
Tolleiv Nietsch [Thu, 14 Jul 2011 18:09:03 +0000 (20:09 +0200)]
[BUGFIX] No content in workspace preview when using select.selectFields

The TypoScript property select.selectFields does not consider workspaces
in the frontend rendering process.

Resolves: #17284
Releases: 4.6, 4.5, 4.4
Change-Id: Id9d1e7dcf56b5aeeec3070ff11416e82ec1bb978
Reviewed-on: http://review.typo3.org/2089
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
8 years ago[BUGFIX] Increase height of "View Item" window
Felix Kopp [Sat, 10 Sep 2011 11:47:13 +0000 (13:47 +0200)]
[BUGFIX] Increase height of "View Item" window

The "View Item" window shows information about a record or file.

Its height of 400px is very small, especially when an image preview is
shown. Increase height to 600px.

Change-Id: I4a97663e4a19c0319901cb82f4a3dc4d70cf3dd8
Resolves: #29627
Releases: 4.6
Reviewed-on: http://review.typo3.org/4900
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[TASK] Improve rendering of plugins in page module
Georg Ringer [Thu, 8 Sep 2011 08:06:11 +0000 (10:06 +0200)]
[TASK] Improve rendering of plugins in page module

The rendering of the content element "plugin" can be highly improved
by changing just a fiew lines.

Changes:
- Remove "CODE:" when not needed
- Remove the "Insert plugin" as there is no additional information

Change-Id: I84795d537ecb15bace39d5e17cfafb5d90115a94
Resolves: #29556
Reviewed-on: http://review.typo3.org/4836
Tested-by: Soren Malling
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] RTE: External links not updated to internal by link dialogue
Stanislas Rolland [Mon, 5 Sep 2011 14:51:17 +0000 (10:51 -0400)]
[BUGFIX] RTE: External links not updated to internal by link dialogue

Solution: Remove external attribute when switching to other type
of link.

Change-Id: Ica76a8d862fd2547ad0baac55b3770dc2cedf79a
Resolves: #29167
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4769
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[BUGFIX] RTE may overwrite link text in IE
Stanislas Rolland [Fri, 9 Sep 2011 03:34:28 +0000 (23:34 -0400)]
[BUGFIX] RTE may overwrite link text in IE

Problem: In IE, setting the link node href attribute may update the link
content when the content is recognized by IE as an url.
Solution: Workaround the IE feature and restore the link content.

Change-Id: I6f41dd2e43a64726e48dc3c714c7cfe89bbc860a
Resolves: #29527, #25464
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4863
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[BUGFIX] Unlock Install Tool only after acknowledgement
Steffen Gebert [Mon, 5 Sep 2011 19:51:12 +0000 (21:51 +0200)]
[BUGFIX] Unlock Install Tool only after acknowledgement

Since #28621, the Install Tool gets automatically unlocked, if an admin
user opens it from the Backend.

This reduces the admin's awareness of the Install Tool being
explicitly protected by the ENABLE_INSTALL_TOOL file. This change
introduces an additional step, in which the user is explicitly asked for
confirmation to unlock the Install Tool.

Change-Id: I289959f7cdc8ff05221005d4431f2e27b3f5cf95
Fixes: #28689
Related: #28621
Releases: 4.6
Reviewed-on: http://review.typo3.org/4777
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
8 years ago[TASK] EM: rename local and remote tabs
Xavier Perseguers [Sat, 10 Sep 2011 09:33:33 +0000 (11:33 +0200)]
[TASK] EM: rename local and remote tabs

After slightly refactoring the options and actions available in tabs
"Local Extension List" and "Remote Repository", the titles should be
updated:

Local Extension List -> Available Extension
Remote Repository -> Import Extensions

Resolves: #29588
Releases: 4.6

Change-Id: Ib4e98749ee72b701100db685b50bc0c76d8c1305
Reviewed-on: http://review.typo3.org/4896
Tested-by: Soren Malling
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers