Packages/TYPO3.CMS.git
3 years ago[TASK] Extend regular workspaces DataHandler functional tests 67/45067/3
Oliver Hader [Mon, 30 Nov 2015 15:13:59 +0000 (16:13 +0100)]
[TASK] Extend regular workspaces DataHandler functional tests

The following actions are added:
* delete content and copy either draft or live page
* change content sorting and copy either draft or live page
* move content around and copy either draft or live page

Resolves: #71988
Releases: master, 6.2
Change-Id: I398fc9f0e7f91a9a944c74868d2718fdf19aa9f8
Reviewed-on: https://review.typo3.org/45067
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[TASK] Extend workspaces DataHandler functional tests 64/45064/2
Oliver Hader [Mon, 30 Nov 2015 14:46:09 +0000 (15:46 +0100)]
[TASK] Extend workspaces DataHandler functional tests

Add content element on different page in base scenario.

Resolves: #71986
Releases: master, 6.2
Change-Id: I87f198301fa8090c96a7c2e22eab9ecc59900405
Reviewed-on: https://review.typo3.org/45064
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[TASK] Travis: Disable Xdebug 43/45043/2
Nicole Cordes [Sat, 28 Nov 2015 23:31:25 +0000 (00:31 +0100)]
[TASK] Travis: Disable Xdebug

Resolves: #71947
Releases: master, 6.2
Change-Id: I06ad0771dd87d5186818028b4bea7bd61ee305d9
Reviewed-on: https://review.typo3.org/45043
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] EXT:form - OPTGROUP cannot be a child element of SELECT 92/43492/3
Ralf Zimmermann [Thu, 24 Sep 2015 21:44:37 +0000 (23:44 +0200)]
[BUGFIX] EXT:form - OPTGROUP cannot be a child element of SELECT

Resolves: #69376
Releases: 6.2
Change-Id: I9e77649203466e37067384f7043e7f1a6ce5fa7e
Reviewed-on: https://review.typo3.org/43492
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[BUGFIX] EXT:form - accept-charset in form not working 55/44955/4
Ralf Zimmermann [Thu, 26 Nov 2015 12:44:29 +0000 (13:44 +0100)]
[BUGFIX] EXT:form - accept-charset in form not working

Let the wizard write the correct attribute name "accept-charset"
instead of "acceptcharset". Avoid non existing attribute-class loading
if an attribute name contains non-alphabetic characters.

Resolves: #62713
Releases: 6.2
Change-Id: Iaadf8829b40a39061665dcea529f44ccf2d0a294
Reviewed-on: https://review.typo3.org/44955
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[BUGFIX] Allow reply-to mail header in EXT:form 61/43661/4
Ralf Zimmermann [Thu, 26 Nov 2015 11:28:11 +0000 (12:28 +0100)]
[BUGFIX] Allow reply-to mail header in EXT:form

In EXT:form it was not possible to set a reply-to header in the email
and so the entered mail address was used as "from" which could cause SPF
failures.

The reply-to was there in the old mailform (e.g. TYPO3 4.5) but not in
the new extension which is the successor. That is why this issue handled
as bugfix.

Resolves: #69395
Related: #68771
Releases: 6.2

Change-Id: I1e7b77d3196c4a921d2902f212d03815bb3e0eb9
Reviewed-on: https://review.typo3.org/43661
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[BUGFIX] Assure correct INCLUDE_TYPOSCRIPT with relative paths on subpages 52/44952/2
Daniel Goerz [Thu, 26 Nov 2015 11:41:44 +0000 (12:41 +0100)]
[BUGFIX] Assure correct INCLUDE_TYPOSCRIPT with relative paths on subpages

If a subpage has a template that clears the setup, INCLUDE_TYPOSCRIPT
will not work with relative paths anymore. This patch assures that always
the correct file is included.

Change-Id: I43b524c7c0fde7211ccbfc8481e2bbfd00bb4c0e
Resolves: #71197
Releases: master, 6.2
Reviewed-on: https://review.typo3.org/44952
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
3 years ago[TASK] Disallow multi-line HTTP headers 00/44900/2
Helmut Hummel [Sun, 22 Nov 2015 13:00:52 +0000 (14:00 +0100)]
[TASK] Disallow multi-line HTTP headers

PHP removed the support for this deprecated HTTP specification
in recent versions of PHP, thus we should remove these as well.

Besides that, we add an additional check for newlines
in GeneralUtility::locationHeaderUrl() to prevent potential
issues with Internet Explorer.
These lines can be removed once the minimum PHP requirement
are raised.

Releases: master, 6.2
Resolves: #58816
Change-Id: I38d26affd31913b82a972ac90ebf906a45b92e05
Reviewed-on: https://review.typo3.org/44900
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] Save parents localized uid as child reference 26/44926/2
Nicole Cordes [Wed, 9 Sep 2015 09:29:57 +0000 (11:29 +0200)]
[BUGFIX] Save parents localized uid as child reference

This patch resolves problems with updating translated records which
have a relation to a parent object. The backend expects the localized
uid as parent id but extbase currently saves the original uid. This
leads to wrong relation information within the child record.

Resolves: #69630
Releases: master, 6.2
Change-Id: Ib0af8b5fa13c03e15c4db5cb0ac1a81c8ee568eb
Reviewed-on: https://review.typo3.org/44926
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 years ago[BUGFIX] Position NULL-Checkbox left of TCA input 43/44043/3
Stephan Großberndt [Wed, 14 Oct 2015 08:54:14 +0000 (10:54 +0200)]
[BUGFIX] Position NULL-Checkbox left of TCA input

Positioning of the checkbox to nullify an TCA field is handled by the
FormEngine-Rewrite on master but not on 6.2. This patch positions the
NULL-Checkbox left of TCA input instead of to the far right.

Resolves: #52261
Releases: 6.2
Change-Id: Icc9e3d8d20a0bf728906275fe8041abd2b7446d9
Reviewed-on: https://review.typo3.org/44043
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
3 years ago[BUGFIX] Check webmounts for backend user in workspace preview 97/44897/2
Nicole Cordes [Sun, 22 Nov 2015 12:03:36 +0000 (13:03 +0100)]
[BUGFIX] Check webmounts for backend user in workspace preview

This patch adds a check if the current backend user used for workspace
authentication has access to the current requested page. If the user
doesn't have access the workspace version of that page can't be displayed
and the live version is shown instead.

Resolves: #71734
Releases: master, 6.2
Change-Id: I66b79f9ee36ed3037729dceedd9410ccd85880f4
Reviewed-on: https://review.typo3.org/44897
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
3 years ago[BUGFIX] Prevent deletion of closing bracket via INCLUDE_TYPOSCRIPT 24/44724/2
Andreas Allacher [Sun, 15 Nov 2015 11:45:53 +0000 (12:45 +0100)]
[BUGFIX] Prevent deletion of closing bracket via INCLUDE_TYPOSCRIPT

Due to missing check of the last char being a new line, it is
possible that a closing bracket character is removed by
using INCLUDE_TYPOSCRIPT.
This leads to broken typoscript.
By introducing the missing check this kind of error is prevented.

Change-Id: I92ef213d31c4d62ba797e2741d5a0beaa042c6b3
Resolves: #62280
Releases: master, 6.2
Reviewed-on: https://review.typo3.org/44724
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Andreas Allacher <andreas.allacher@gmx.at>
Reviewed-by: Martin Kutschker <martin.kutschker@ymail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Remove Ter.json template in extension manager 14/44814/2
Nicole Cordes [Thu, 19 Nov 2015 01:06:59 +0000 (02:06 +0100)]
[TASK] Remove Ter.json template in extension manager

The Ter.json template is needed to reload the extension table list
after the extension information was reloaded. As this request is not
useful (e.g. any search parameter stays in the input field, but the
request doesn't filter anything), the template should be removed and
the whole page should be reloaded afterwards.

Resolves: #71669
Releases: master, 6.2
Change-Id: I64158edff282540e7cc9f2597c9579607834aa55
Reviewed-on: https://review.typo3.org/44814
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
3 years ago[BUGFIX] Remove double encoding of fieldset in extension "felogin" 31/44831/2
Martin Kutschker [Fri, 20 Nov 2015 15:23:05 +0000 (16:23 +0100)]
[BUGFIX] Remove double encoding of fieldset in extension "felogin"

Change-Id: Ieaad7bff161fd8927388ab3a3aa7688885fc09fb
Resolves: #71730
Releases: master, 6.2
Reviewed-on: https://review.typo3.org/44831
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Add unit tests for spamProtectEmailAddresses 16/44816/3
Oliver Hader [Fri, 20 Nov 2015 10:58:50 +0000 (11:58 +0100)]
[TASK] Add unit tests for spamProtectEmailAddresses

Adding unit tests for TypoScript config property
spamProtectEmailAddresses and its variations.

Resolves: #71716
Releases: master, 6.2
Change-Id: I368806cdfcdb9c2cc05641892df56f3127190789
Reviewed-on: https://review.typo3.org/44816
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[SECURITY][TASK] Blind more options in the configuration module 09/44809/2
Georg Ringer [Fri, 20 Nov 2015 09:09:03 +0000 (10:09 +0100)]
[SECURITY][TASK] Blind more options in the configuration module

The database credentials should not be shown in the configuration module.

Change-Id: I6037f343d9e6932e1293e463fe513e793e948762
Resolves: #71706
Resolves: #68905
Releases: master, 6.2
Reviewed-on: https://review.typo3.org/44809
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] Fix f:cObject documentation example 49/44749/2
Josef Glatz [Tue, 17 Nov 2015 09:26:45 +0000 (10:26 +0100)]
[BUGFIX] Fix f:cObject documentation example

Fix current value example.

Releases: master, 6.2
Resolves: #71620
Change-Id: Ie82bab5a6767c664951c2e163a08015b5f7e3323
Reviewed-on: https://review.typo3.org/44749
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] Empty array not encoded as empty XML tag 01/44601/5
Andreas Wolf [Sat, 7 Nov 2015 16:04:32 +0000 (17:04 +0100)]
[BUGFIX] Empty array not encoded as empty XML tag

When encoding an empty array, an empty line with indentation was
created. If the <el> tag had a proper type="array" attribute, it could
still be decoded to an array again. If not, it was decoded to a string,
leading to errors e.g. when trying to traverse it.

The fix is to include an empty element now, which will be decoded to
an empty array again then.

Change-Id: Ia78adc1e7e81a943cdbc94f3cfa19b36442c430f
Resolves: #71394
Releases: 6.2, master
Reviewed-on: https://review.typo3.org/44601
Reviewed-by: Daniel Lorenz <forge@extco.de>
Tested-by: Daniel Lorenz <forge@extco.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
3 years ago[BUGFIX] .htaccess created for log folder outside PATH_site 15/44715/2
Andreas Wolf [Sun, 19 Jul 2015 11:29:55 +0000 (13:29 +0200)]
[BUGFIX] .htaccess created for log folder outside PATH_site

Change-Id: I47d38033581a3ac71ee61d9607c708c01fe56743
Resolves: #68368
Releases: master, 6.2
Reviewed-on: https://review.typo3.org/44715
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Steffen Müller <typo3@t3node.com>
Tested-by: Steffen Müller <typo3@t3node.com>
3 years ago[BUGFIX] Fix l10n identifier string in date validator of EXT:form 93/43493/3
Ralf Zimmermann [Wed, 23 Sep 2015 07:40:49 +0000 (09:40 +0200)]
[BUGFIX] Fix l10n identifier string in date validator of EXT:form

Resolves: #69354
Releases: 6.2
Change-Id: Ie99cff4bb300056b57dad0f33412b184d8d3c7d6
Reviewed-on: https://review.typo3.org/43493
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Steffen Müller <typo3@t3node.com>
Tested-by: Steffen Müller <typo3@t3node.com>
3 years ago[BUGFIX] EXT:form - error in mail process if label layout contains label 94/43494/2
Ralf Zimmermann [Wed, 23 Sep 2015 07:45:58 +0000 (09:45 +0200)]
[BUGFIX] EXT:form - error in mail process if label layout contains label

Do not delete the parent dom node if
TYPO3\CMS\Form\View\Mail\Html\Additional\LabelAdditionalElementView
is rendered and the layout definition contains a label tag.

Resolves: #69817
Releases: 6.2
Change-Id: I8f1be9af8d3b2575d83867900b5c75f5ab5b6482
Reviewed-on: https://review.typo3.org/43494
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Steffen Müller <typo3@t3node.com>
Tested-by: Steffen Müller <typo3@t3node.com>
3 years ago[BUGFIX] Handling of uploaded files not within open_basedir 10/44710/2
Morton Jonuschat [Fri, 13 Nov 2015 19:55:54 +0000 (20:55 +0100)]
[BUGFIX] Handling of uploaded files not within open_basedir

When the "upload_tmp_dir" folder is not within the "open_basedir"
an Exception will get thrown when uploading files in the fileadmin.
This patch silences open_basedir() warnings occuring in the file_exists()
check and adds detection of uploaded files as the handling of these with
move_uploaded_file() is not influenced by the open_basedir setting.

Resolves: #69356
Releases: master, 6.2
Change-Id: I649373e8910c2d30f73cbb0e3b56476196c151fd
Reviewed-on: https://review.typo3.org/44710
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[BUGFIX] BackendUtility: Skip rendering thumbnails for anything but files 09/44709/2
Morton Jonuschat [Fri, 13 Nov 2015 19:17:52 +0000 (20:17 +0100)]
[BUGFIX] BackendUtility: Skip rendering thumbnails for anything but files

If the stored value in a group field with type file/file_reference is a
folder the thumbCode() method skips rendering a thumbnail for that
resource. This avoids fatal error as the interface of e.g. a Folder is
different to that of a File, missing the ::isMissing() method.

Resolves: #66045
Releases: master, 6.2
Change-Id: I29b75dec0173cc2423583a9cf42ff56ca81ce7d3
Reviewed-on: https://review.typo3.org/44709
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[BUGFIX] EXT:form - avoid number reduction in currency filter 91/43491/3
Ralf Zimmermann [Wed, 23 Sep 2015 07:29:21 +0000 (09:29 +0200)]
[BUGFIX] EXT:form - avoid number reduction in currency filter

Avoid a number reduction each time the filter is applied.
Preserve the decimal places.

Resolves: #69807
Releases: 6.2
Change-Id: I3d7587ecf65447439bd8b58819805263aa5fa7f8
Reviewed-on: https://review.typo3.org/43491
Reviewed-by: Richard Haeser <richardhaeser@gmail.com>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[TASK] Fix deprecation-message in FormEngine 90/44690/3
Stefan Neufeind [Thu, 12 Nov 2015 11:46:31 +0000 (12:46 +0100)]
[TASK] Fix deprecation-message in FormEngine

Fix a typo. And since there are large changes in 7 LTS already
adjust surrounding deprecation-related comments as well.

Change-Id: I8074bccc65847d8027d8ced711f4ed616346ccf4
Resolves: #71544
Releases: 6.2
Reviewed-on: https://review.typo3.org/44690
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[BUGFIX] Replace old @dontvalidate with @ignorevalidation 73/44373/2
Stefan Neufeind [Thu, 29 Oct 2015 19:07:07 +0000 (20:07 +0100)]
[BUGFIX] Replace old @dontvalidate with @ignorevalidation

@dontvalidate was syntax of the old propertymapper.

Change-Id: I50394d5272118253e4bb738adbed08054a6e1f64
Resolves: #71096
Releases: master, 6.2
Reviewed-on: https://review.typo3.org/44373
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Andreas Bouche <andreas.bouche@flagbit.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Ensure processing folder within another storage is created 85/44685/2
Benjamin Mack [Thu, 12 Nov 2015 06:02:27 +0000 (07:02 +0100)]
[BUGFIX] Ensure processing folder within another storage is created

This patch checks if the processing folder within another storage
exists and ensures it is created if not.

Resolves: #70481
Releases: master, 6.2
Change-Id: Ib6747b5e37a46e6f761912103d1ac5f490bb2a1d
Reviewed-on: https://review.typo3.org/44685
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
3 years agoRevert "[BUGFIX] IMG_RESOURCE does not prepend absRefPrefix" 32/44632/3
Andreas Allacher [Mon, 9 Nov 2015 12:42:03 +0000 (13:42 +0100)]
Revert "[BUGFIX] IMG_RESOURCE does not prepend absRefPrefix"

This reverts commit 119d9607090bf390a1cb299e692b8f2e90fbe399.
Due to this change in various instances the absRefPrefix was appended twice because of this commit.
If one wants to fix the issue one could modify
\TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController::setAbsRefPrefix()
to also e.g. include single quotes.

Releases: master, 6.2
Resolves: #71435
Resolves: #70718
Reverts: #69516
Change-Id: I1a2547df0439aab8c67866b1a2d5ab59dd0ba730
Reviewed-on: https://review.typo3.org/44632
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[BUGFIX] Add img longdescUrl only if available 77/44577/2
Benjamin Mack [Fri, 6 Nov 2015 12:09:06 +0000 (13:09 +0100)]
[BUGFIX] Add img longdescUrl only if available

According to the W3C standard (http://www.w3.org/TR/html-longdesc/#implementation),
longDesc should only be added if the attribute value is not empty.

The change adds an additional check to do so.

Resolves: #70685
Releases: master, 6.2
Change-Id: I4f61e61f04de81f881becee871edcc15d77deecd
Reviewed-on: https://review.typo3.org/44577
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Non-admins cannot use mass actions in a workspace 16/44416/2
Oliver Hader [Fri, 30 Oct 2015 16:20:13 +0000 (17:20 +0100)]
[BUGFIX] Non-admins cannot use mass actions in a workspace

Non-admins cannot use the mass actions "publish", "swap" or
"discard" in a workspace. The reason is, that for non-admins
the mount-page tree is traversed for a given recursion depth
which is not the case for privileged admin users. The default
value for the depth value is zero (0), that's why no pages,
except the mount-points, are processed.

Resolves: #59226
Releases: master, 6.2
Change-Id: I8d1e2032f72fa977cfcaf44978300d36bef9be23
Reviewed-on: https://review.typo3.org/44416
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[TASK] Allow to define multiple DataHandler commands for one element 51/44351/2
Oliver Hader [Thu, 29 Oct 2015 12:35:28 +0000 (13:35 +0100)]
[TASK] Allow to define multiple DataHandler commands for one element

The method DataHandler::process_cmdmap currently allows only one command
to be executed for one element. A command-map like the following is
currently not possible - the second command would be ignored:

[tt_content][13][localize] = 1
[tt_content][13][inlineLocalizeSynchronize] = children:14

Resolves: #71125
Releases: master, 6.2
Change-Id: I473ea0de3789d77cb913ad64a26a666ab73c2a52
Reviewed-on: https://review.typo3.org/44351
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[TASK] Extend functional test cases for copying data 48/44548/2
Oliver Hader [Thu, 5 Nov 2015 11:24:00 +0000 (12:24 +0100)]
[TASK] Extend functional test cases for copying data

The workspaces functional test cases are extended with combined
draft and live actions on copying record data. This task is to
add the tests first. Thus, the assertions contain flaws that
are solved in a separate issue - which can be visualized and
proven then.

Resolves: #71342
Releases: master, 6.2
Change-Id: I85787a410f4e6260528a89491537e243842a405a
Reviewed-on: https://review.typo3.org/44548
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[BUGFIX] t3editor: menu objects: common properties missing 31/44531/3
Andreas Bouche [Mon, 2 Nov 2015 12:27:05 +0000 (13:27 +0100)]
[BUGFIX] t3editor: menu objects: common properties missing

When autocompleting menu objects the common properties are missing

Releases: master, 6.2
Resolves: #67764
Change-Id: Ib54daf26647966f00f7609715c98199e3234c51e
Reviewed-on: https://review.typo3.org/44531
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[TASK] Support EXT: syntax in TCA ctrl iconfile 60/43760/4
Stephan Großberndt [Sat, 3 Oct 2015 15:00:53 +0000 (17:00 +0200)]
[TASK] Support EXT: syntax in TCA ctrl iconfile

Using EXT: in iconfile of TCA ctrl is used as favorite method as of
TYPO3 7.5, using extRelPath() is deprecated. In order to ease the
transformation to EXT: add support for it in TYPO3 6.2.

Resolves: #70283
Releases: 6.2
Change-Id: Ib724c9c561e425769a1d3c93c4960fe663679173
Reviewed-on: https://review.typo3.org/43760
Reviewed-by: Ruud Silvrants <ruudsilvrants@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
3 years ago[TASK] Add possibility to copy pages recursively in functional tests 63/44463/2
Oliver Hader [Sat, 31 Oct 2015 19:29:22 +0000 (20:29 +0100)]
[TASK] Add possibility to copy pages recursively in functional tests

Resolves: #71222
Releases: master, 6.2
Change-Id: I6d73c5556ba48e936d28c0532a57f8bf9d3b6175
Reviewed-on: https://review.typo3.org/44463
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[BUGFIX] EXT:form - HIDDEN element cannot be accessed in form wizard 34/44434/2
Björn Jacob [Fri, 30 Oct 2015 16:10:17 +0000 (17:10 +0100)]
[BUGFIX] EXT:form - HIDDEN element cannot be accessed in form wizard

After creating a HIDDEN element with the help of the form wizard one is
not able to edit the element afterwards. This is due to the fact that
the element is hidden which is kind of correct but does not help the
editor to work target orientied.

This patch adds a dummy element to the HIDDEN element. The dummy
element contains the element's name and has a dotted border.
That way the editor can edit and move a HIDDEN element.

Resolves: #70637
Releases: master, 6.2
Change-Id: I933df4f7a4b01d9246f6bd0981179497c103882b
Reviewed-on: https://review.typo3.org/44434
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Workspace placeholder is not processed with eval-function 02/44402/3
Oliver Hader [Fri, 30 Oct 2015 13:56:57 +0000 (14:56 +0100)]
[BUGFIX] Workspace placeholder is not processed with eval-function

The workspace move-placeholder is not processed with the accordant
eval-function. This leads to scenario that a placeholder is not
persisted at all and produces orphaned or invalid data sets.

Resolves: #71161
Releases: master, 6.2
Change-Id: I60eaaa30399a26a10452f0605ba73476a9d129ef
Reviewed-on: https://review.typo3.org/44402
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[BUGFIX] Add class alias of class loader to alias map 02/44302/3
Helmut Hummel [Mon, 26 Oct 2015 21:16:20 +0000 (22:16 +0100)]
[BUGFIX] Add class alias of class loader to alias map

Instead of hardcoding the class_alias call to alias the Flow
class loader, we must use the class alias API,
which in turn triggers the integrated composer
class loader to properly establish the alias.

This avoids a fatal error in the install tool clear cache action
which calls Bootstrap::initializeClassLoader() twice.

Resolves: #71057
Related: #69476
Releases: 6.2
Change-Id: I83310f9f9668c2ce0cdd07497036b406e94decc7
Reviewed-on: https://review.typo3.org/44302
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Change default label for sys_file_references 47/44347/2
Bernd Wilke [Fri, 5 Jun 2015 07:38:43 +0000 (09:38 +0200)]
[BUGFIX] Change default label for sys_file_references

In the List module you can select additional fields to be displayed.
For fields referencing files only, the uid is shown which does give
no hint to the real referenced file.
This change selects the uid_local field, which selects the filename
from sys_file for display.

Resolves: #67303
Releases: master, 6.2
Change-Id: I8dd301ff8d8d17baa67fafd26892a3eeea46509b
Reviewed-on: https://review.typo3.org/44347
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[BUGFIX] Invalid behaviour with GeneralUtility::trimExplode() 94/44194/2
Xavier Perseguers [Wed, 21 Oct 2015 08:39:58 +0000 (10:39 +0200)]
[BUGFIX] Invalid behaviour with GeneralUtility::trimExplode()

The subject's parts are wrongly trimmed although a limit is specified.
According to the PHP documentation, the values are trimmed for whitespace
in the end, not at the beginning.

Change-Id: Ifb4547b3349be2d31d5ce75b19db77eb6535d5ec
Resolves: #70864
Releases: master, 6.2
Reviewed-on: https://review.typo3.org/44194
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
3 years ago[BUGFIX] Allow log files to be outside PATH_site 42/44142/3
Andreas Wolf [Sun, 18 Oct 2015 16:27:01 +0000 (18:27 +0200)]
[BUGFIX] Allow log files to be outside PATH_site

Change-Id: I81438b2230a9d3d15dca0c15d14bca3736ca12a3
Resolves: #68231
Releases: master, 6.2
Reviewed-on: https://review.typo3.org/44142
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
3 years ago[FOLLOWUP][TASK] Properly encode database input in Typo3DbQueryParser 72/44172/2
Morton Jonuschat [Tue, 20 Oct 2015 06:19:47 +0000 (08:19 +0200)]
[FOLLOWUP][TASK] Properly encode database input in Typo3DbQueryParser

Restore PHP 5.3/5.4 compatibility by replacing usage of ::class syntax.

Resolves: #70632
Releases: 6.2
Change-Id: I41b0973076f6d095c6d4bd387f9e9d6adb38a1e4
Reviewed-on: https://review.typo3.org/44172
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] Properly encode database input in Typo3DbQueryParser 34/44134/2
Helmut Hummel [Mon, 12 Oct 2015 16:35:22 +0000 (18:35 +0200)]
[TASK] Properly encode database input in Typo3DbQueryParser

Resolves: #70632
Releases: 6.2, master
Change-Id: I3ecbc2dd887789866512d4fc4aa7d0913b49fd0d
Reviewed-on: https://review.typo3.org/44134
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
3 years ago[BUGFIX] Child sorting is lost after publishing workspace data 40/43940/2
Oliver Hader [Tue, 23 Sep 2014 17:48:42 +0000 (19:48 +0200)]
[BUGFIX] Child sorting is lost after publishing workspace data

If sorting of IRRE child records is changed in a workspace and
published, the sorting of child records is not published along.

This behaviour could be solved by using proper move placeholders
for IRRE child records as well, but conflicts with the
possibility to define a custom sorting field in the parent
entity of the relation construct. Besides that, sorting
values are not published in any case. That's why a
post-processing of IRRE children is required for sorting.

Resolves: #61750
Releases: master, 6.2
Change-Id: Ia8a0a1766233161d566e67a619ee195d6b0433c9
Reviewed-on: http://review.typo3.org/43940
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[TASK] Extract data overlay handling to common class 10/43910/4
Oliver Hader [Sat, 22 Aug 2015 14:45:38 +0000 (16:45 +0200)]
[TASK] Extract data overlay handling to common class

The data overlay handling of RelationHandler is extracted to
a separate common class. The scope of this object shall be
independent from frontend-only or backend-only constraints.

The new handler resolves version overlays for given IDs of
a database table and applies sorting for the target context.

This is just an intermediate solution to overcome sorting issues
of relations handled in RelationHandler. The goal of DataResolvers
should be to provide independent APIs for OneToMany and ManyToMany
relation resolving in the future as well.

Resolves: #69967
Releases: master, 6.2
Change-Id: I5a7f76a55b4af93aee6270168285fff9486a2e73
Reviewed-on: http://review.typo3.org/43910
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[BUGFIX] Possible silent fatal error with legacy extensions 20/44120/3
Xavier Perseguers [Sat, 17 Oct 2015 07:04:45 +0000 (09:04 +0200)]
[BUGFIX] Possible silent fatal error with legacy extensions

The use of the '@' symbol while including an extension update script
may result into a PHP fatal error being totally muted which in turn
results into a blank screen.

In TYPO3 6.2, this happens when a legacy extension is trying to manually
include class t3lib_SCbase in its update script:

    require_once(PATH_t3lib . 'class.t3lib_scbase.php');

Having a white screen and no log entry makes it really hard to
understand where the error comes from. The Install Tool does not help
either since the check for broken extensions only tries to include
ext_tables.php and ext_localconf.php.

Change-Id: I9078882e10739309ac160f4ac5a0dfcfd49fbba1
Resolves: #70697
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/44120
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
3 years ago[BUGFIX] Add stdWrap support for Partial- and layoutRootPaths 79/41679/6
Anja Leichsenring [Sat, 18 Jul 2015 14:40:26 +0000 (16:40 +0200)]
[BUGFIX] Add stdWrap support for Partial- and layoutRootPaths

The single occurrences layoutRootPath and partialRootPath have
stdWrap support, but not the collection entries of
layoutRootPaths and partialRootPaths. This is added now.

Change-Id: I59d4967ce67b48b53e9bf1052d703c974f1472ca
Resolves: #63380
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/41679
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
3 years ago[FOLLOWUP][BUGFIX] Do not crop inside known html tags 96/43996/2
Benjamin Mack [Sun, 11 Oct 2015 21:16:45 +0000 (23:16 +0200)]
[FOLLOWUP][BUGFIX] Do not crop inside known html tags

Fixed indent spaces to tabs.

This change adds missing tags to the regex used to match html tags.
Furthermore, scripting tags are added, so that they will not be counted
nor split apart.

This list of html tags was extracted from the current W3C html5
standard recommendation at [1] and merged with tags from the current
code that are not (or no longer) in the W3C standard recommendation
(e.g: TYPO3's internal <link> tag).

---
[1]: http://www.w3.org/TR/html5/semantics.html#semantics

Change-Id: Ie1aedecbfd46c82b49f34936a96004af29c63d54
Resolves: #69263
Releases: 6.2
Reviewed-on: http://review.typo3.org/43996
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[BUGFIX] Do not crop inside known html tags 95/43995/2
Benjamin Mack [Sun, 11 Oct 2015 21:09:34 +0000 (23:09 +0200)]
[BUGFIX] Do not crop inside known html tags

This change adds missing tags to the regex used to match html tags.
Furthermore, scripting tags are added, so that they will not be counted
nor split apart.

This list of html tags was extracted from the current W3C html5
standard recommendation at [1] and merged with tags from the current
code that are not (or no longer) in the W3C standard recommendation
(e.g: TYPO3's internal <link> tag).

---
[1]: http://www.w3.org/TR/html5/semantics.html#semantics

Resolves: #69263
Releases: master, 6.2
Change-Id: Id58dcf3470ed06256b9b8f744dd13891757faef1
Reviewed-on: http://review.typo3.org/43995
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[BUGFIX] Support URLs in image tag generation 76/43376/3
Nicole Cordes [Tue, 15 Sep 2015 23:29:37 +0000 (01:29 +0200)]
[BUGFIX] Support URLs in image tag generation

FAL files may return an absolute URL depending on the driver the
storage uses. Currently the absRefPrefix is prepended automatically
to the image source without analyzing the file path. This patch ensures
the prefix is only added for local files.

Resolves: #69861
Releases: master, 6.2
Change-Id: Ida5568372817ac6e840bcc366090fe3e8a925eec
Reviewed-on: http://review.typo3.org/43376
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[TASK] Update static composer class loading 87/43887/2
Helmut Hummel [Wed, 7 Oct 2015 12:38:05 +0000 (14:38 +0200)]
[TASK] Update static composer class loading

The committed composer class loading information has not been
updated for a while. Do so, to add classes that have been added
meanwhile to required TYPO3 extensions to the map and update
class loader code to be current.

Also adapt the .gitignore file to be correct and add a script
to automate this process (so that it can theoretically be done
before a release)

Resolves: #70465
Releases: 6.2
Change-Id: Ife3a9b47a6fbd93e4d10c6e693b597f42a338bc9
Reviewed-on: http://review.typo3.org/43887
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Fix Liskov substitution violation in PackageManager 83/42983/3
Helmut Hummel [Wed, 7 Oct 2015 12:12:05 +0000 (14:12 +0200)]
[BUGFIX] Fix Liskov substitution violation in PackageManager

TYPO3's `PackageManager` class changes the signature of a method
defined in it's parent class. This causes warnings when PHP's strict
mode is enabled. Fix this in the same way, we established compatibility
with the Flow core bootstrap class and establish an alias for the
Flow core class loader.

This brings strict free TYPO3 front end rendering without having
to change the method signature.

When doing so, we can also remove the Flow class loader class from
the class map and the file system.

Change-Id: I29ce35339823126bbba0c951da11122e16b4e052
Fixes: #69476
Releases: 6.2
Reviewed-on: http://review.typo3.org/42983
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Martin Helmich <m.helmich@mittwald.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Flaws in copying a page with localized content elements 06/43906/2
Oliver Hader [Mon, 25 Aug 2014 16:00:24 +0000 (18:00 +0200)]
[BUGFIX] Flaws in copying a page with localized content elements

Copying a page with localized content elements in a workspace
has some flaws. In a workspace a duplicated record will end up
in a new-placeholder and the specific version record.

The tranlation pointer field of the new-placeholder still
contains the unmodified value of the original record, the
specific version record is fine however.

The reason for that is the special handling for cloning a page
in DataHandler. Each record of a particular table is copied in
reverse order. This way, the localization is created earlier
than the record of the default language.

This change is about skipping the direct copyRecord() call for
records that will be processed inside another copyRecord() call
for the record of the default language.

Resolves: #61179
Releases: master, 6.2
Change-Id: I6647b02095343756d3a41b0c0e985b4777429cd8
Reviewed-on: http://review.typo3.org/43906
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[TASK] Enforce optimized composer autoloader 62/43862/2
Helmut Hummel [Tue, 6 Oct 2015 14:34:17 +0000 (16:34 +0200)]
[TASK] Enforce optimized composer autoloader

The optimized autoload generation gives a huge benefit in performance.
Let people participate from this benefit even if they do not know about it.

Add this option in composer.json, so that this step cannot be forgotten when
creating distribution builds.

Resolves: #70436
Releases: master, 6.2
Change-Id: Ia3e1a3209f3c6820f514d2574a3c71cacd4e8501
Reviewed-on: http://review.typo3.org/43862
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Prevent current extension version in update dialog 11/43811/2
Nicole Cordes [Thu, 1 Oct 2015 12:25:17 +0000 (14:25 +0200)]
[BUGFIX] Prevent current extension version in update dialog

If you update an extension, the current version is included in the
confirmation dialog. This might confuse the user as this version is
already available. The patch re-adds the usage of the repository
function to exclude the current used version in the query.

Resolves: #65904
Releases: master, 6.2
Change-Id: I49aa2ba36bbfd7888aa202028dfd9e9c882a8183
Reviewed-on: http://review.typo3.org/43811
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
3 years ago[TASK] Prevent gathering update information on Ter installation 13/43713/2
Nicole Cordes [Thu, 1 Oct 2015 12:32:29 +0000 (14:32 +0200)]
[TASK] Prevent gathering update information on Ter installation

Currently when the extension list from TER is fetched from the database,
all installed extensions are checked for an update. This is because the
TER extension list needs a css class for available extensions but the
wrong method is used to gather the needed information within the
ListController.

Resolves: #70264
Releases: master, 6.2
Change-Id: I99e9bfceb0bf0ed97d0bf26ae927743fd2ca86f4
Reviewed-on: http://review.typo3.org/43713
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Use correct storage when getting public url of processed file 75/43575/2
Nicole Cordes [Tue, 15 Sep 2015 23:42:09 +0000 (01:42 +0200)]
[BUGFIX] Use correct storage when getting public url of processed file

If the processed file object is marked configured to use the original
file we have to ensure the right storage is used when creating the
publicUrl.

Resolves: #69833
Releases: master, 6.2
Change-Id: Iba0b4c7b8ef8b65cceae86ada0a7c7e85f338fdf
Reviewed-on: http://review.typo3.org/43575
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
3 years ago[BUGFIX] Use extension key for ExtensionManagementUtility::siteRelPath 66/43566/2
Nicole Cordes [Fri, 25 Sep 2015 10:30:33 +0000 (12:30 +0200)]
[BUGFIX] Use extension key for ExtensionManagementUtility::siteRelPath

Due to the backport from https://review.typo3.org/41841/ a wrong
extension key for indexed_search is used to get the extension path.

Resolves: #70111
Releases: 6.2
Change-Id: I9abd587fda34059b7f5c8375a45a66b5e8ae066b
Reviewed-on: http://review.typo3.org/43566
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Use proper fieldname to check result in getFirstTimeValueForRecord() 12/43512/2
Georg Ringer [Wed, 23 Sep 2015 04:49:52 +0000 (06:49 +0200)]
[BUGFIX] Use proper fieldname to check result in getFirstTimeValueForRecord()

The method builds a query using "as". Therefore the result needs to be checked
by using the same name.

Change-Id: Idba29d7cc1c962899aacbe239bde1be632995ddd
Resolves: #69875
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/43512
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
3 years agoRevert "[BUGFIX] Draft usergroup access rights are now respected" 88/43188/3
Alexander Opitz [Fri, 11 Sep 2015 09:55:02 +0000 (11:55 +0200)]
Revert "[BUGFIX] Draft usergroup access rights are now respected"

This reverts commit 1c9922353f2ed83bff81af6bb10756422a2da252.
We Revert this for 6.2 as the commit has a regression, if a menu is
build on workspace while a page is hidden in menu. Also this was more
a feature which changes behavior in a branch line.

Reverts: #33436
Resolves: #69642
Releases: 6.2

Change-Id: I948d4d33036b7bff53c44da94f21df3e0c39a37d
Reviewed-on: http://review.typo3.org/43188
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Fix wrong TypoScript variable name in felogin documentation 07/43507/2
Felix Heller [Wed, 23 Sep 2015 15:26:45 +0000 (17:26 +0200)]
[BUGFIX] Fix wrong TypoScript variable name in felogin documentation

Change-Id: Ide28b4195d9e5e0aea481f3809265ece6b72f5b4
Resolves: #70053
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/43507
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[BUGFIX] Delete move placeholders upon record deletion 79/43479/2
Bart Dubelaar [Tue, 7 Aug 2012 12:00:26 +0000 (14:00 +0200)]
[BUGFIX] Delete move placeholders upon record deletion

If a record was moved in a draft workspace and subsequently
removed in the live workspace, then the move placeholder would
remain and show up as an actual record in the backend. To the
end user it appears as if the record was not deleted as one
would now see the move-placeholder.

If the mentioned moved record would be removed instead in the
very same draft workspace, the move-to-pointer was removed
correctly, but the move-placeholder stayed as well.

Resolves: #39383
Releases: master, 6.2
Change-Id: I3b0593332650795539c2d7eac075515dbd981b45
Reviewed-on: http://review.typo3.org/43479
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[TASK] Extend workspaces functional tests concerning move-placeholders 31/43431/2
Oliver Hader [Sat, 19 Sep 2015 09:56:59 +0000 (11:56 +0200)]
[TASK] Extend workspaces functional tests concerning move-placeholders

The "modify" functional tests are extended concerning move-placeholders:
* changeContentSortingAndDeleteMovedRecord
  * in a draft workspace
  * change sorting of element on the same page
  * delete the moved element
* changeContentSortingAndDeleteLiveRecord
  * in a draft workspace
  * change sorting of element on the same page
  * switch to live workspace
  * delete the moved element

The test results reveal problematic states in the database and are used
to proof correct and complete changes of further DataHandler changes in
that regard.

Resolves: #69969
Releases: master, 6.2
Change-Id: I06863ba17e74a698833a665d73269951fed9392e
Reviewed-on: http://review.typo3.org/43431
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[FOLLOWUP][BUGFIX] _languageUid property not set on insert 28/43428/2
Morton Jonuschat [Fri, 18 Sep 2015 19:06:17 +0000 (21:06 +0200)]
[FOLLOWUP][BUGFIX] _languageUid property not set on insert

Remove ::class notation from AddTest.php

Resolves: #69953
Releases: 6.2
Change-Id: I9c6a32677182cd56391230bddb00c0c4668c4fd0
Reviewed-on: http://review.typo3.org/43428
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[BUGFIX] _languageUid property not set on insert 27/43427/2
Marco Huber [Fri, 17 Jul 2015 19:07:54 +0000 (21:07 +0200)]
[BUGFIX] _languageUid property not set on insert

The patch ensures new objects are created with default language only.
Database field and object property are set properly to 0.

Furthermore the language uid is set only if not set before from outside.

Resolves: #65363
Resolves: #65364
Releases: master, 6.2
Change-Id: I57c4834f7e77644620831abeeb2bc2e644f95395
Reviewed-on: http://review.typo3.org/43427
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[TASK] Add functional test cases for IRRE children without default sortby 21/43421/2
Oliver Hader [Sat, 22 Aug 2015 12:40:48 +0000 (14:40 +0200)]
[TASK] Add functional test cases for IRRE children without default sortby

In each, live and draft workspace:
* create a tt_content element
* with a nested 1:n hotel element
* with a nested 1:n offer element
* localize the created tt_content element

The default sortby configuration of the hotel
table is disabled in $TCA.

Change-Id: Iae313f0e64b8affc1134fcd8507171c73ced991c
Resolves: #59112
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/43421
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[BUGFIX] InstallTool: Optimize ALTER TABLE for auto_increment columns 99/43299/2
Morton Jonuschat [Fri, 28 Aug 2015 07:58:31 +0000 (09:58 +0200)]
[BUGFIX] InstallTool: Optimize ALTER TABLE for auto_increment columns

To successfully add a new column with auto_increment enabled to a table
the column needs to be included in a (primary) key. The install tool
handled this in a two step process by ignoring the auto_increment
attribute and separating adding the field and the key into two
statements. This fails on existing tables with data as the column will
include non-uniqued/non-incrementing values after the first statement
leading to failures adding the key.

The proper way to add a columns with the auto_increment attribute is to
combine the ALTER TABLE statement to perform both alterations at the
same time, this patch changes the behavior of the Install Tool to
generate statements accordingly on MySQL.

When running with DBAL enabled the statement will not be altered in any
way to allow the SqlParser to take into account database specific
handling of this case, an example test case is included for PostgreSQL
which handles this case transparently using the SERIAL column type.

Resolves: #69304
Releases: master, 6.2
Change-Id: I211b25b22e122e47d289b9d7f927b5c713cdd138
Reviewed-on: http://review.typo3.org/43299
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
3 years ago[BUGFIX] Correct TYPO3 logo used in icons 66/43266/2
Benjamin Kott [Sun, 13 Sep 2015 11:08:37 +0000 (13:08 +0200)]
[BUGFIX] Correct TYPO3 logo used in icons

Resolves: #68991
Releases: 6.2
Change-Id: If7784567c92eced1dfaecfcb98b232d6ec842fb2
Reviewed-on: http://review.typo3.org/43266
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] Enable color output for unit/functional tests 80/43280/2
Mathias Brodala [Sun, 13 Sep 2015 15:01:25 +0000 (17:01 +0200)]
[TASK] Enable color output for unit/functional tests

Resolves: #69762
Releases: master, 6.2
Change-Id: I6520afb1fc65f77dd12f4f771cce36cbdced3ce9
Reviewed-on: http://review.typo3.org/43280
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
3 years ago[BUGFIX] Fix BackendUtility::selectVersionsOfRecord parameter 60/43160/2
Alexander Opitz [Tue, 18 Aug 2015 17:02:44 +0000 (19:02 +0200)]
[BUGFIX] Fix BackendUtility::selectVersionsOfRecord parameter

The fix in #60249 accidently changed the meaning of the workspace
parameter, so that some lowlevel_cleaner didn't worked correct anymore.
We now add the old ability to find versions over all workspaces.

Resolves: #69135
Releases: master, 6.2
Change-Id: I8999bf2e6487391d41cc7ce80461afb8e813ce97
Reviewed-on: http://review.typo3.org/43160
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[BUGFIX] Wrong marker mentioned in documentation of ext:felogin 59/43159/3
Wouter Wolters [Wed, 9 Sep 2015 16:01:02 +0000 (18:01 +0200)]
[BUGFIX] Wrong marker mentioned in documentation of ext:felogin

A marker is mentioned as example in the documentation, which is wrong.
The example is ###USERNAME### and should be ###FEUSER_USERNAME###

Resolves: #69628
Releases: master,6.2
Change-Id: Ia5994fa45dcee76c8a2778f60869f0288a3fe3af
Reviewed-on: http://review.typo3.org/43159
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] IMG_RESOURCE does not prepend absRefPrefix 57/43157/2
Heiko Kromm [Thu, 3 Sep 2015 19:27:13 +0000 (21:27 +0200)]
[BUGFIX] IMG_RESOURCE does not prepend absRefPrefix

Rendering an imageResource with TypoScript IMG_RESOURCE
does not prepend the absRefPrefix.
This will cause problems loading images when not using config.baseUrl.
If it is not an absolute url we prepend absRefPrefix.

Resolves: #69516
Releases: master, 6.2
Change-Id: Icfca8bfe50cb5e1816cf73783a09d065d299521a
Reviewed-on: http://review.typo3.org/43157
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
3 years ago[BUGFIX] Prevent information disclosure in file list 88/42588/2
Nicole Cordes [Tue, 2 Jun 2015 14:32:52 +0000 (16:32 +0200)]
[BUGFIX] Prevent information disclosure in file list

Currently the doc header title of a folder shows the full path even
if the current folder is inside a mount point. This patch prevents
showing the full path by not disabling the permission check but catch
a thrown exception and return the path inside the mount point.

Resolves: #67245
Releases: master, 6.2
Change-Id: I6e5486e8c6f923decc4016b57ff60a562f189749
Reviewed-on: http://review.typo3.org/42588
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
3 years ago[BUGFIX] DBAL: Fix quoting of single quotes in WHERE values for MSSQL 48/43148/2
Morton Jonuschat [Fri, 21 Aug 2015 08:42:47 +0000 (10:42 +0200)]
[BUGFIX] DBAL: Fix quoting of single quotes in WHERE values for MSSQL

MSSQL escapes single quotes in values by doubling them. When parsing the
WHERE clause DBAL removed the escaping without performing the required
escaping of the values when compiling the query. This is fixed by adding
a special handling of MSSQL in _quoteWhereClause().

Resolves: #27760
Releases: master, 6.2
Change-Id: I9b8f4fa6ab6e47bd44e6998ee3a492468713cbf0
Reviewed-on: http://review.typo3.org/43148
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Catch exceptions during extension update check 46/43146/2
Nicole Cordes [Tue, 28 Jul 2015 14:05:02 +0000 (16:05 +0200)]
[BUGFIX] Catch exceptions during extension update check

For each extension the available update versions are checked. This
also tries to resolve the extension version dependencies according to
the current system. There might be updates which collide and
exceptions are thrown. This patch catches thrown exceptions as the
update check shouldn't break the Extension Manager.

Resolves: #68585
Releases: master, 6.2
Change-Id: Idc1ed32304dc71dbfe722b3f2c32664f9928cb36
Reviewed-on: http://review.typo3.org/43146
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[TASK] Set TYPO3 version to 6.2.16-dev 24/43124/2
TYPO3 Release Team [Tue, 8 Sep 2015 09:08:55 +0000 (11:08 +0200)]
[TASK] Set TYPO3 version to 6.2.16-dev

Change-Id: Iec10a16f466deb17ec9d5b5d7b87e2850a7c6944
Reviewed-on: http://review.typo3.org/43124
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
3 years ago[RELEASE] Release of TYPO3 6.2.15 23/43123/2 6.2.15 TYPO3_6-2-15
TYPO3 Release Team [Tue, 8 Sep 2015 09:07:15 +0000 (11:07 +0200)]
[RELEASE] Release of TYPO3 6.2.15

Change-Id: I16cee63a4ae922bb6e25548c144b52e92d0b159c
Reviewed-on: http://review.typo3.org/43123
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
3 years ago[SECURITY] Fix GeneralUtility::sanitizeLocalUrl to detect foreign schemes 21/43121/2
Nicole Cordes [Tue, 8 Sep 2015 08:57:47 +0000 (10:57 +0200)]
[SECURITY] Fix GeneralUtility::sanitizeLocalUrl to detect foreign schemes

This patch adds a check to be able to recognize arbitrary schemes which
have to be skipped.

Resolves: #68825
Releases: master, 6.2
Security-Bulletin: TYPO3-CORE-SA-2015-009
Change-Id: I9f98c5730f255f9cb391f0d716457b56e5c3c3a3
Reviewed-on: http://review.typo3.org/43121
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[SECURITY] Prevent information disclosure in tests bootstrap 20/43120/2
Nicole Cordes [Tue, 8 Sep 2015 08:56:16 +0000 (10:56 +0200)]
[SECURITY] Prevent information disclosure in tests bootstrap

Both, the UnitTestsBootstrap and FunctionalTestsBootstrap set
display_errors to 1 which shows errors and warnings by default. If you
call those scripts within web context the files can't be loaded and the
error message shows the website root path. The patch adds proper checks
before files are loaded and exits if an error occurs.

Resolves: #67900
Releases: 6.2
Security-Bulletin: TYPO3-CORE-SA-2015-008
Change-Id: I1e294bcd2f6cd7c2a32f54a890ca2d4a869c9fda
Reviewed-on: http://review.typo3.org/43120
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[FOLLOWUP][BUGFIX] Reestablish DB connection in long-running tasks 03/43103/2
Markus Klein [Thu, 27 Aug 2015 17:07:04 +0000 (19:07 +0200)]
[FOLLOWUP][BUGFIX] Reestablish DB connection in long-running tasks

Reconnecting in isConnected() is not necessary as the next query() will
check the status and reconnect properly if required. Using ping() does
not work with mysqlnd - only if mysqli.reconnect=1 is set. Setting this
is bad practice since a ping() would only reconnect but not properly
reinitialize the charset etc.

Thus a check in Install Tool is added to make sure mysqli.reconnect is
set to "0".

Resolves: #69001
Resolves: #69289
Releases: master, 6.2
Change-Id: I3c2cac91e96fdee8bff113f848341856ec51829b
Reviewed-on: http://review.typo3.org/43103
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Remove wrong datasets in sanitizeLocalUrlValidPathsDataProvider 96/43096/2
Nicole Cordes [Mon, 7 Sep 2015 13:29:01 +0000 (15:29 +0200)]
[TASK] Remove wrong datasets in sanitizeLocalUrlValidPathsDataProvider

Within the GeneralUtilityTest::sanitizeLocalUrlValidPathsDataProvider
are still wrong dataset unfortunately. As on Windows systems the
GeneralUtility::getIndpEnv('TYPO3_SITE_URL') results in
http://D:/AbsolutePathToTypo3Installation those test were moved to an
own DataProvider which makes sure the HTTP_HOST and SCRIPT_NAME are set
correctly before calling GeneralUtility::getIndpEnv().

Resolves: #69584
Releases: master, 6.2
Change-Id: I42e5ab3712f82f5cadd51a478769bc5cb184243f
Reviewed-on: http://review.typo3.org/43096
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Cache CategoryRegistry state together with TCA 70/43070/4
Alexander Stehlik [Wed, 2 Sep 2015 21:14:28 +0000 (23:14 +0200)]
[BUGFIX] Cache CategoryRegistry state together with TCA

The CategoryRegistry is stored together with the final TCA in
the cache.

This is needed because the registry is filled during the initial
build of the TCA and not when the TCA is loaded from the cache.

Resolves: #67881
Releases: master, 6.2
Change-Id: Ic7f341a1710cafbc1a1ea150e003d3d7a7b9c458
Reviewed-on: http://review.typo3.org/43070
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
3 years ago[BUGFIX] Prevent search upload folder in write protected storages 61/43061/2
Nicole Cordes [Tue, 25 Aug 2015 10:10:17 +0000 (12:10 +0200)]
[BUGFIX] Prevent search upload folder in write protected storages

If a storage is marked as non-writeable there isn't any possibility to
have an upload folder in there. So this storage should be skipped in the
lookup of the default upload folder of an user.

Resolves: #69303
Releases: master, 6.2
Change-Id: If53b5545a6af6aa1d333d48bb0856a5de070fd2d
Reviewed-on: http://review.typo3.org/43061
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
3 years ago[BUGFIX] BackendUtility::getAjaxUrl() should not be internal 48/43048/2
Francois Suter [Fri, 4 Sep 2015 14:53:43 +0000 (16:53 +0200)]
[BUGFIX] BackendUtility::getAjaxUrl() should not be internal

In some contexts it is necessary to get the URL of an AJAX handler
on the PHP side. Thus method
\TYPO3\CMS\Backend\Utility\BackendUtility::getAjaxUrl()
should not be marked as internal.

Resolves: #69537
Releases: 6.2, master
Change-Id: Ic69a309b2c6fa02c6581cb7a8e8c68807f684b04
Reviewed-on: http://review.typo3.org/43048
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Support packages depending on typo3/cms 47/43047/2
Mathias Brodala [Fri, 20 Mar 2015 14:07:06 +0000 (15:07 +0100)]
[BUGFIX] Support packages depending on typo3/cms

This adds "typo3/cms" to the list of non composer requirements to allow
packages to depend on it (and thus install the core through Composer) and still
be installable in the Extension Manager.

Resolves: #65867
Releases: master, 6.2
Change-Id: I8564f8dff000fa71876c01343411a3155e0c0c92
Reviewed-on: http://review.typo3.org/43047
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
3 years ago[BUGFIX] Enable page tree filter for admin with mountpoints 18/43018/2
Nicole Cordes [Fri, 14 Aug 2015 14:17:45 +0000 (16:17 +0200)]
[BUGFIX] Enable page tree filter for admin with mountpoints

The patch prevents the mountpoint processing during page tree filtering
for admin users. This is necessary because admin users aren't limited
to the mountpoints. Otherwise sites outside the mountpoints aren't
found anymore.

Resolves: #69063
Releases: master, 6.2
Change-Id: Ie55dcc3b05463deaf57ba42c91e229225176be8a
Reviewed-on: http://review.typo3.org/43018
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
3 years agoRevert "[BUGFIX] Fix broken link to security resources page on typo3.org" 91/42991/2
Helmut Hummel [Thu, 3 Sep 2015 07:06:14 +0000 (09:06 +0200)]
Revert "[BUGFIX] Fix broken link to security resources page on typo3.org"

This URL change on typo3.org had bigger impact and was reverted.
Revert this back here as well.

This reverts commit d92f3ef2c8b297069a2edc2b265e281686363f13.

Change-Id: Ic75ed47edcca9bfff3af6595af02bc81fe6a14c0
Reviewed-on: http://review.typo3.org/42991
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
3 years ago[BUGFIX] Streamline Unit Tests for GeneralUtility::sanitizeLocalUrl 88/42988/2
Nicole Cordes [Wed, 2 Sep 2015 13:06:12 +0000 (15:06 +0200)]
[BUGFIX] Streamline Unit Tests for GeneralUtility::sanitizeLocalUrl

Currently the Unit Tests for the function just work by accident. As
HTTP_HOST an absolute path is set which is used to get some other values
to compare the given strings. To add further tests we should streamline
the tests and set/add expectations for host and script_name.

Resolves: #69475
Releases: master, 6.2
Change-Id: If139da7bd22c1ebf2c538cd3412fb0abf56dc668
Reviewed-on: http://review.typo3.org/42988
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
3 years ago[BUGFIX] Abstract XSD generator can handle more than two namespace parts 78/42978/2
Helmut Hummel [Tue, 1 Sep 2015 20:10:56 +0000 (22:10 +0200)]
[BUGFIX] Abstract XSD generator can handle more than two namespace parts

The getTagNameForClass method in the abstract XSD generator class
could not handle class names with more than two namespace parts.

This caused e.g. TYPO3\CMS\Fluid\ViewHelpers\Be\Buttons\CshViewHelper to
not be transformed to "be.buttons.csh", but just "be.", which in turn
caused duplicate id errors in the resulting XSD document.

Make the code aware of more than two namespace parts.

Releases: master, 6.2
Resolves: #69463
Change-Id: I9a6a28b470679e7487f0d83a7ce9f267a1f3ec7f
Reviewed-on: http://review.typo3.org/42978
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
3 years ago[TASK] Do not set application context by default in htaccess 43/42943/2
Harry Glatz [Mon, 31 Aug 2015 13:40:09 +0000 (15:40 +0200)]
[TASK] Do not set application context by default in htaccess

Since the Production context is the default if no context is set
via environment variables, we do not forcefully set
the context in template .htaccess either.

This allows to set the context via webserver configuration
without the need to touch the lines in the .htaccess file.

Resolves: #69434
Releases: master, 6.2
Change-Id: I70915c51479c91c0db22c7637e46cb1c0fae2db4
Reviewed-on: http://review.typo3.org/42943
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
3 years ago[BUGFIX] Use single postProcessor layout, otherwise the global layout 26/42926/4
Ralf Zimmermann [Sat, 29 Aug 2015 14:57:47 +0000 (16:57 +0200)]
[BUGFIX] Use single postProcessor layout, otherwise the global layout

Resolves: #60995
Releases: master, 6.2
Change-Id: Ifcd3dfd9986684f95ab5574a190c4c8b215d0908
Reviewed-on: http://review.typo3.org/42926
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[TASK] Refactor PostProcessorTest to use Prophecy 29/42929/2
Anja Leichsenring [Sun, 30 Aug 2015 12:28:07 +0000 (14:28 +0200)]
[TASK] Refactor PostProcessorTest to use Prophecy

In order to get rid of the mocking of the system under test, the
tests of ext:form PostProcessorTest are refactored to use
Prophecy. This step precedes the addition of other tests for
the class.

Change-Id: I1a2e9c5305c070f291b549965360abcfb8a695d0
Resolves: #69407
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/42929
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[TASK] Remove eval() in ext:form Unit Tests 28/42928/3
Wouter Wolters [Sun, 30 Aug 2015 12:07:59 +0000 (14:07 +0200)]
[TASK] Remove eval() in ext:form Unit Tests

This partly back-ports the changes of issue #67664 to
remove eval() calls in uni tests. This change affects
only the ext:form tests.

Related: #67664
Resolves: #69412
Releases: 6.2
Change-Id: Ie31a3487aa1126d6f43032f8f8242370c3704610
Reviewed-on: http://review.typo3.org/42928
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[BUGFIX] Add icon for the form wizard number spinner elements 25/42925/2
Björn Jacob [Fri, 28 Aug 2015 16:22:45 +0000 (18:22 +0200)]
[BUGFIX] Add icon for the form wizard number spinner elements

Instead of using images/form/trigger.gif as background image for
the form wizard number spinner elements, this patch introduces a new icon
which shows the real functionality of the spinner element (up/down).

Resolves: #69398
Releases: master, 6.2
Change-Id: I608a8e4fee92978a23cedabd1c51800c8a22dfc0
Reviewed-on: http://review.typo3.org/42925
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[BUGFIX] Fatal Error due to class object inconsistencies in ext:form 24/42924/2
Oliver Hader [Sat, 29 Aug 2015 17:15:15 +0000 (19:15 +0200)]
[BUGFIX] Fatal Error due to class object inconsistencies in ext:form

Elements in the form wizard can either be defined by TypoScript or
by using the accordant wizard. Some of these elements don't have a
counterparts in the ExtJS form wizard and thus only work in the
TypoScript mode. In these cases, the missing JSON conversion
objects lead to fatal errors.

Resolves: #69399
Releases: master, 6.2
Change-Id: Ide39afcbdc483dc01d9cdc9165c89c34785f847d
Reviewed-on: http://review.typo3.org/42924
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[FOLLOWUP][TASK] Add unit test for fatal error on null object method call 23/42923/2
Anja Leichsenring [Sat, 29 Aug 2015 15:01:23 +0000 (17:01 +0200)]
[FOLLOWUP][TASK] Add unit test for fatal error on null object method call

some ::class calls were accidently backported and caused the unit tests
to fail.

Change-Id: I9072fccddae7072011ba62c2981cdf2e7d4faa08
Resolves: #69408
Relates: #69405
Releases: 6.2
Reviewed-on: http://review.typo3.org/42923
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[TASK] Add unit test for fatal error on null object method call 22/42922/2
Anja Leichsenring [Sat, 29 Aug 2015 12:27:20 +0000 (14:27 +0200)]
[TASK] Add unit test for fatal error on null object method call

With #45685 a bugfix was merged. Now the corresponding
unit test is added as well.

Change-Id: Id62c4c7a29d2e28847381c18e963cb834e35fa01
Resolves: #69405
Relates: #45685
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/42922
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[BUGFIX] Fix broken link to security resources page on typo3.org 17/42917/2
Wouter Wolters [Fri, 28 Aug 2015 18:44:10 +0000 (20:44 +0200)]
[BUGFIX] Fix broken link to security resources page on typo3.org

Resolves: #69400
Releases: master,6.2
Change-Id: I277aee582c4b9158ded7a2227abd170ad81c96b9
Reviewed-on: http://review.typo3.org/42917
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[BUGFIX] avoid Call to a member function getValue() on a non-object 16/42916/2
Ralf Zimmermann [Thu, 20 Aug 2015 13:30:18 +0000 (15:30 +0200)]
[BUGFIX] avoid Call to a member function getValue() on a non-object

Prevents calling a method of a non-existent object.

If an attribute is not set via Typoscript no object for the attribute
is instantiated. It must be checked if the attribute exists before
calling it.

Resolves: #45685
Releases: 6.2, master
Change-Id: Ia36052060b82d543b22fb9c0da61623f9d09bd07
Reviewed-on: http://review.typo3.org/42916
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[TASK] Use https for links to docs.typo3.org 09/42909/3
Georg Ringer [Fri, 28 Aug 2015 14:38:21 +0000 (16:38 +0200)]
[TASK] Use https for links to docs.typo3.org

As docs.typo3.org switched to https, all links should be updated
as well.

Resolves: #69239
Releases: 6.2

Change-Id: Ie533be93d8541cd2de897334093850fa21992d02
Reviewed-on: http://review.typo3.org/42909
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>