Packages/TYPO3.CMS.git
4 years ago[BUGFIX] IRRE records are listed comma separated 67/30967/3
Thomas Löffler [Fri, 20 Jun 2014 19:15:14 +0000 (21:15 +0200)]
[BUGFIX] IRRE records are listed comma separated

IRRE records with foreign_field instead of MM table
are now listed as a comma separated list instead
of wrongly using the number of records as the UID.

Change-Id: Ib1434561ee823d931cc983e103fb58490ca83719
Resolves: #59671
Releases: 6.3,6.2
Reviewed-on: https://review.typo3.org/30967
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
4 years ago[BUGFIX] Prevent spaces in BE shortcut to be replaced by + char 75/31175/3
Frans Saris [Fri, 27 Jun 2014 19:49:26 +0000 (21:49 +0200)]
[BUGFIX] Prevent spaces in BE shortcut to be replaced by + char

Due to some changes in Prototype.js the serialized form values
get wrongly escaped with the result that all spaces are replaced
by + chars.

This patch changes the used serialization of the form so the value
is correctly posted.

Resolves: #59950
Releases: 6.3, 6.2
Change-Id: I65d89ab741ae77f5bbef9421923b3878f2295570
Reviewed-on: https://review.typo3.org/31175
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Krzysztof Adamczyk
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
4 years ago[BUGFIX] Fix RTE width 54/30954/2
Markus Klein [Fri, 20 Jun 2014 16:58:45 +0000 (18:58 +0200)]
[BUGFIX] Fix RTE width

edit_wideDocument option has been removed with #57295 but it was forgotten
to adjust RTE accordingly.

Wide screens are default now, so we remove the check for this option
also in RTE. Furthermore the settings for small screens are superfluous
too.

Documentation is adjusted as well.

Resolves: #59692
Releases: 6.3, 6.2
Change-Id: I9bb5fc2a892f3de446137856e9fa18317f40b5c1
Reviewed-on: https://review.typo3.org/30954
Reviewed-by: Marc Wöhlken
Tested-by: Marc Wöhlken
Reviewed-by: Frans Saris
Reviewed-by: Marcin Sągol
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
4 years ago[CLEANUP] Extbase reflection classes 44/29444/7
Markus Klein [Sun, 13 Apr 2014 15:11:48 +0000 (17:11 +0200)]
[CLEANUP] Extbase reflection classes

Remove unnessessary full qualified class names.
Cleanup docheaders.

Resolves: #57878
Releases: 6.3
Change-Id: I5bcdb80c27da1698fd1446a001907d83c6845507
Reviewed-on: https://review.typo3.org/29444
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
4 years ago[TASK] Add action selector in toolbar in workspaces menu 58/31158/4
Oliver Hader [Thu, 26 Jun 2014 09:42:45 +0000 (11:42 +0200)]
[TASK] Add action selector in toolbar in workspaces menu

Currently there are two selectors in the bottom toolbar of
the workspace module. One to handle stage changes on selected
elements and one for mass actions (publish, swap, discard) for
the whole workspace. To circumvent this, an additional selector
shall be added for record selections.

Resolves: #59898
Releases: 6.2, 6.3
Change-Id: I5991cc16a65ba5ac473ec380f534379ec925cad3
Reviewed-on: https://review.typo3.org/31158
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
4 years ago[CLEANUP] Update phpdoc for all FormEngine members 19/31019/6
Markus Klein [Sat, 21 Jun 2014 23:17:20 +0000 (01:17 +0200)]
[CLEANUP] Update phpdoc for all FormEngine members

Furthermore ensure the initial values are correct.
All usages of the members have been checked such that no violation can
happen if the initial values have been modified.

This patch contains no change in functionality.

Resolves: #59775
Releases: 6.3, 6.2
Change-Id: I4566849bb930535b9fef8d38dba940d6a6fd86cc
Reviewed-on: https://review.typo3.org/31019
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
4 years ago[CLEANUP] FormEngine: Use getters for global objects 17/31017/6
Markus Klein [Sat, 21 Jun 2014 22:29:21 +0000 (00:29 +0200)]
[CLEANUP] FormEngine: Use getters for global objects

Introduce getters for global objects like TYPO3_DB or LANG.
This patch does not change any functionality.

Resolves: #59775
Releases: 6.3, 6.2
Change-Id: Ia9a4f3adc656927467f2f51207396d9a41befe8c
Reviewed-on: https://review.typo3.org/31017
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Oliver Klee
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
4 years ago[FEATURE] Introduce afterPersistObjetct signal slot 38/31238/4
Nico de Haen [Sun, 29 Jun 2014 22:11:09 +0000 (00:11 +0200)]
[FEATURE] Introduce afterPersistObjetct signal slot

At the moment we only have an afterUpdate signal which
is emitted when an object is updated. But we don't have
a signal which is emitted after persisting an existing
aggregate root, if only sub objects or object storages
belonging to the aggregate root are updated.

Since the aggregate root should "encapsulate" the contained
objects to the outer world, we should provide such a signal,
which is fired if all objects of an aggregate root are persisted.

The same signal is emitted in the persistObject method in
the AbstractBackend class in Flow.

Change-Id: I85b2257b127f73afddbf4a01db156ed30489c42a
Resolves: #59986
Releases: 6.3
Reviewed-on: https://review.typo3.org/31238
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
4 years ago[BUGFIX] Fix PHP warning in BackendUtility::getProcessedValue() 43/31243/2
Markus Klein [Mon, 30 Jun 2014 11:06:42 +0000 (13:06 +0200)]
[BUGFIX] Fix PHP warning in BackendUtility::getProcessedValue()

BackendUtility::getProcessedValue() fails to initialize a variable which
causes a PHP warning on array access.

Fix this by initializing the variable to array properly.

Resolves: #59994
Releases: 6.3, 6.2
Change-Id: I26711b512a9a7fad40000de6f2de6a2b4a81ac75
Reviewed-on: https://review.typo3.org/31243
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
4 years ago[TASK] Remove unused use statements 45/31245/5
Nicole Cordes [Mon, 30 Jun 2014 12:23:24 +0000 (14:23 +0200)]
[TASK] Remove unused use statements

Several classes include unused use statements. This patch removes those
statements or uses them in their code.

Resolves: #59997
Releases: 6.3
Change-Id: I5890a80bcee96976e3c35d967db8c53a9c11b002
Reviewed-on: https://review.typo3.org/31245
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Oliver Klee
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
4 years ago[BUGFIX] Show errors on distribution installation 41/31241/5
Sascha Egerer [Mon, 30 Jun 2014 09:36:00 +0000 (11:36 +0200)]
[BUGFIX] Show errors on distribution installation

When you install a distribution and an error occurred, you get a fluid
error: "Sorry, the requested view was not found."

There is currently no template / view for the action. This patch renders
the error messages as flash messages and redirects to the list view of
distributions where the errors are shown.

Resolves: #59564
Resolves: #59952
Releases: 6.3, 6.2
Change-Id: Ie0e055dfd5620d4e0a08ecf87b2f458e7877ee76
Reviewed-on: https://review.typo3.org/31241
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
4 years ago[BUGFIX] Use correct array structure for EM error messages 40/31240/5
Sascha Egerer [Mon, 30 Jun 2014 09:27:51 +0000 (11:27 +0200)]
[BUGFIX] Use correct array structure for EM error messages

The extension manager stores errors (like exceptions that
are thrown while installing an extension) in an array and
passes them to a fluid template.

The array has to be in a defined structure like
$errorMessages[extension name][i] = array(
»       error code,
»       error message
)

Currently, if an extension is installed from ter and an error occurs
while downloading the extension, the code and text are stored directly
under the extension name and therefore the array is not correctly parsed
by the fluid template.

Resolves: #59991
Releases: 6.3, 6.2
Change-Id: Id330f0af2a99ab99cb8b736332cb8506c857716c
Reviewed-on: https://review.typo3.org/31240
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
4 years ago[TASK] Re-work/simplify copyright header in JS files 64/31164/6
Michael Schams [Fri, 27 Jun 2014 02:18:19 +0000 (12:18 +1000)]
[TASK] Re-work/simplify copyright header in JS files

This patch replaces the copyright/license header in JS files with a
new, simplified one. The new header does not show the year figure, nor
an author name, and refers to the LICENSE.txt file for the full
copyright information. License is: GPL2 or any later version.

Resolves: #59916
Releases: 6.3, 6.2
Change-Id: I312bd9682fc1cf30ec327ba5d17567a3e9609c7d
Reviewed-on: https://review.typo3.org/31164
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
4 years ago[BUGFIX] Let live search use getRecordTitle 97/31197/4
Markus Klein [Sat, 28 Jun 2014 17:03:28 +0000 (19:03 +0200)]
[BUGFIX] Let live search use getRecordTitle

Live search uses the label configuration from TCA to get the title of a
record. An existing TODO note already suggests to use the method for
this from BackendUtility. Do this now.

Resolves: #59893
Resolves: #59957
Releases: 6.3, 6.2
Change-Id: Ic4aaabed47922863602e770b588fb8dacd9386de
Reviewed-on: https://review.typo3.org/31197
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Nicole Cordes
Reviewed-by: Anja Leichsenring
Reviewed-by: Helmut Hummel
Tested-by: Nicole Cordes
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
4 years ago[BUGFIX] Unique IDs for pagetree root nodes 16/28616/3
Alexander Stehlik [Fri, 21 Mar 2014 18:06:33 +0000 (19:06 +0100)]
[BUGFIX] Unique IDs for pagetree root nodes

To make sure that every ID in the pagetree is unique in pagetrees
with a virtual root node (which is used for normal editors) the
page UIDs of the webmounts are set in the mountpoint property of
the tree nodes. This makes sure that all tree node ids are unique.

Resolves: #57163
Releases: 6.3, 6.2
Change-Id: Ia938a9bf4839524d60056d55c0186196dbd11289
Reviewed-on: https://review.typo3.org/28616
Reviewed-by: Markus Klein
Tested-by: Markus Klein
4 years agoRevert "[TASK] Rebuild the calcAge functionality" 36/31236/4
Christian Kuhn [Sun, 29 Jun 2014 21:25:01 +0000 (23:25 +0200)]
Revert "[TASK] Rebuild the calcAge functionality"

This change was considered to need some more work during
mrge post review:

* 6.2 version adds not allowed deprecations to a released branch
* It adds two arbitrary (public) constants CEIL and FLOOR
* Method names need improvement
* Violation of single responsibility
* The static utility class has dependencies
* The patch adds another "always loaded" file to main bootstrap
* Undocumented (minor) breaking changes
* (Minor) code style issues

Reverted: #20016
Releases: 6.3, 6.2

This reverts commit 98c0ff7144a67ce8780a1b1ebe55749b6909e202
Change-Id: I7b07f2176eae78f6000db685c0f54164d5040202
Reviewed-on: https://review.typo3.org/31236
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
4 years ago[TASK] Add extension key to API 33/31233/4
Helmut Hummel [Sun, 29 Jun 2014 18:19:35 +0000 (20:19 +0200)]
[TASK] Add extension key to API

Instead of relying on a "magic" global $_EXTKEY
being set, add a new parameter to API where
this was used beforehand.

Resolves: #59770
Releases: 6.2, 6.3
Change-Id: I531bb6067d79aa42c9c592e88f3564dc7f40b29d
Reviewed-on: https://review.typo3.org/31233
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
4 years ago[CLEANUP] Improve code style of DatabaseRecordList 08/29708/7
Markus Klein [Mon, 28 Apr 2014 10:23:33 +0000 (12:23 +0200)]
[CLEANUP] Improve code style of DatabaseRecordList

* adjust docheaders
* improve readability by introducing linebreaks
* use typesafe comparison where possible
* remove unnessessary full qualified class names

Resolves: #58293
Releases: 6.3
Change-Id: Iae277008d6baeb63304c2fb4a5d057019c5de9fc
Reviewed-on: https://review.typo3.org/29708
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
4 years ago[TASK] Remove TCA building aspect and move code to bootstrap 07/31007/5
Christian Kuhn [Sat, 21 Jun 2014 16:25:04 +0000 (18:25 +0200)]
[TASK] Remove TCA building aspect and move code to bootstrap

The patch moves the slot code that implements the override loading
logic back to the bootstrap but keeps the signal.

Resolves: #59770
Related: #59414
Related: #59468
Releases: 6.3, 6.2
Change-Id: Ib4691eaa94f258ebd96f2609fb267cadc8356090
Reviewed-on: https://review.typo3.org/31007
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Frans Saris
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
4 years ago[TASK] Rebuild the calcAge functionality 35/24635/20
Alexander Opitz [Sat, 12 Oct 2013 14:36:25 +0000 (16:36 +0200)]
[TASK] Rebuild the calcAge functionality

We have two calcAge functions with same functionality and same issues.
So this is moved to a new DateTimeUtility class and deprecated in the
the original classes. Also time functions from GeneralUtility are moved
to the new class.

Following issues are resolved:
* Age calculation does not respect leap years.
* Age calculation may round up so something seams older than it is.
* Between days and years there are months missing, so we get now 2 months
  instead of 60 days.

Resolves: #20016
Releases: 6.3, 6.2
Change-Id: Ie323f30b1fb97b68f89d43605ccda67f219a965a
Reviewed-on: https://review.typo3.org/24635
Reviewed-by: Markus Klein
Tested-by: Markus Klein
4 years ago[CLEANUP] Remove redundant code in Persistence 76/28576/21
Alexander Stehlik [Mon, 24 Mar 2014 10:35:48 +0000 (11:35 +0100)]
[CLEANUP] Remove redundant code in Persistence

The getPlainValue method is consolidated in the DataMapper.

Resolves: #57255
Releases: 6.3
Change-Id: Ic35fd2768a1431f260c99d6faf8ad4e0a1754ea3
Reviewed-on: https://review.typo3.org/28576
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Markus Klein
Tested-by: Markus Klein
4 years ago[BUGFIX] Enable skipped tests by properly creating mocks 28/31228/2
Helmut Hummel [Sun, 29 Jun 2014 14:39:29 +0000 (16:39 +0200)]
[BUGFIX] Enable skipped tests by properly creating mocks

Latest changes in PHP disallow unserialize on
certain internal classes. Since phpunit uses
unserialize to create objects of such classes
when requesting a mock without calling the constructor
these tests failed with a PHP fatal error.

Instead of skipping the tests, we can simply provide
mocked constructor arguments (if required) so that
phpunit can create a mock object by using the new operator
and passing these mocked constructor arguments.

Releases: 6.3, 6.2
Resolves: #59981
Related: #59685
Change-Id: Ibd3b9aee0376a5043e053cffa6c88f7b93c86e18
Reviewed-on: https://review.typo3.org/31228
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
4 years ago[TASK] Improve travis notifications to channels 18/31218/3
Helmut Hummel [Sun, 29 Jun 2014 12:00:15 +0000 (14:00 +0200)]
[TASK] Improve travis notifications to channels

By default travis notifies on each build when
posting to channels (irc, slack)

We can reduce the number of notifications by only
posting successful builds when it previously failed.

Additionally encrypt the API token for posting to slack.

Releases: 6.3, 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I882d34903c972201454e6cc5b9041393e3bd3661
Reviewed-on: https://review.typo3.org/31218
Reviewed-by: Michael Stucki
Tested-by: Michael Stucki
4 years ago[BUGFIX] Create required directories in test bootstrap 16/31216/8
Sebastian Bergmann [Sun, 29 Jun 2014 10:07:05 +0000 (12:07 +0200)]
[BUGFIX] Create required directories in test bootstrap

When running the core unit tests without setting up TYPO3
using the normal installation procedure then the uploads,
typo3temp, and typo3conf/ext directories do not exist.

Resolves: #59977
Releases: 6.3,6.2
Change-Id: Ib6b8ecd480b83cf818f54d865a4ff61fe62d2893
Reviewed-on: https://review.typo3.org/31216
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
4 years ago[CLEANUP] main_rte function of the ElementBrowser 69/28269/8
Tymoteusz Motylewski [Tue, 11 Mar 2014 09:44:26 +0000 (10:44 +0100)]
[CLEANUP] main_rte function of the ElementBrowser

It splits 450 lines function into smaller pieces
and removes some duplicated code in the process.
It also opens a way to further duplicate removal
e.g. the code for selecting current folder.
This patch is not changing functionality,
just moving code around.

* splits main_rte into smaller chunks
* make main_rte method signature be consistent
  between class implementations and usage
* removes ~100 lines of duplicated code
  getPageSelectorHtml and getFileSelectorHtml
  are now inherited in the BrowseLinks
* removed few "@todo Define visibility" for methods
  which are called from outside

Resolves: #56781
Releases: 6.3
Change-Id: I7679017b1e215ea2d4da46fa30314313bc9980c5
Reviewed-on: https://review.typo3.org/28269
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
4 years ago[BUGFIX] Fix insufficient mocking in ContentObjectRenderer 05/31205/2
Markus Klein [Sat, 28 Jun 2014 19:31:38 +0000 (21:31 +0200)]
[BUGFIX] Fix insufficient mocking in ContentObjectRenderer

Resolves: #59967
Releases: 6.3, 6.2
Change-Id: Ie30b8e522f9045c7cd6cbe9c032413c0ad936b1a
Reviewed-on: https://review.typo3.org/31205
Reviewed-by: Markus Klein
Tested-by: Markus Klein
4 years ago[BUGFIX] Gifbuilder: Fix image-mask-functionality 10/30610/5
Stefan Neufeind [Fri, 6 Jun 2014 14:10:26 +0000 (16:10 +0200)]
[BUGFIX] Gifbuilder: Fix image-mask-functionality

Mask-functionality is broken since the
introduction of FAL.

Change-Id: Iff28d9561e10f7581041bcc35bd56dfc972954b3
Resolves: #59392
Releases: 6.3, 6.2, 6.1
Reviewed-on: https://review.typo3.org/30610
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
Reviewed-by: Markus Klein
Tested-by: Markus Klein
4 years ago[TASK] Add a function for clearing the rootline caches 52/30052/8
Oliver Klee [Tue, 13 May 2014 12:44:05 +0000 (14:44 +0200)]
[TASK] Add a function for clearing the rootline caches

The RootlineUtility uses two local caches and one additional cache from
the caching framework. If a unit test uses the RootlineUtility, it needs
a way of purging these caches so it does not change the environment.

Resolves: #58763
Releases: 6.3, 6.2, 6.1
Change-Id: Ia9878b808acfa03f018086829f90b84d4c5e8512
Reviewed-on: https://review.typo3.org/30052
Reviewed-by: Markus Klein
Tested-by: Markus Klein
4 years ago[BUGFIX] BE shortcuts do not show up for editors 72/31172/3
Frans Saris [Fri, 27 Jun 2014 18:16:16 +0000 (20:16 +0200)]
[BUGFIX] BE shortcuts do not show up for editors

Due to some wrong or missing checks the link to create a shortcut
to a create new record form misses the correct name of the
"motherModName" as a result the shortcut links are not rendered
for non-admins. For admins these links do not work if PHP notices
are transformed to exceptions.

Resolves: #59946
Releases: 6.3, 6.2
Change-Id: I9acd74fd5dfefea62badc79e42e380466ce6c497
Reviewed-on: https://review.typo3.org/31172
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Marcin Sągol
4 years ago[TASK] Use stable phpunit 4.1 instead of master 79/31179/2
Christian Kuhn [Sat, 28 Jun 2014 12:01:42 +0000 (14:01 +0200)]
[TASK] Use stable phpunit 4.1 instead of master

We had to update to phpunit "master" recently due to an issue with
phpunit-mock-objects that was not released yet but fixed in master.
The fix was released with phpunit-mock-objects 2.1.5 today, so we
can switch back to a stable combination of those packages.

Resolves: #59958
Related: #59685
Releases: 6.3, 6.2
Change-Id: I92336adef0291239c7dad606002721c91b2991fa
Reviewed-on: https://review.typo3.org/31179
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
4 years ago[BUGFIX] Fix usergroup condition in user TSconfig 14/31114/2
Markus Klein [Tue, 24 Jun 2014 14:18:59 +0000 (16:18 +0200)]
[BUGFIX] Fix usergroup condition in user TSconfig

usergroup conditions in user TSconfig are currently failing as
the list of groups the user is part of, is not yet compiled when
the TSconfig is evaluated.

This can be fixed by moving the group evaluation some lines upwards,
as this does not influence the remaining code.

Resolves: #59813
Releases: 6.3, 6.2, 6.1
Change-Id: Id3189ea5cd31936bdf538e2bb163ecc2d46ed6a0
Reviewed-on: https://review.typo3.org/31114
Reviewed-by: Martin Wiederkehr
Tested-by: Martin Wiederkehr
Reviewed-by: Christoph Buchli
Tested-by: Christoph Buchli
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
4 years ago[TASK] Add more files in gitignore file 83/30683/4
Fabien Udriot [Thu, 12 Jun 2014 08:00:44 +0000 (10:00 +0200)]
[TASK] Add more files in gitignore file

Whenever running the Functional Tests
directly from the Core, the framework requires
some additional folders that can be added
to the gitignore file.

More info about Functional Testing:
http://wiki.typo3.org/Functional_testing

Change-Id: If51851f32ebeda0eb6829dc3f16d87709904824a
Releases: 6.3, 6.2
Resolves: #59514
Reviewed-on: https://review.typo3.org/30683
Reviewed-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
4 years ago[TASK] Update Travis CI notification settings 04/31104/2
Michael Stucki [Tue, 24 Jun 2014 08:27:07 +0000 (10:27 +0200)]
[TASK] Update Travis CI notification settings

Notify on Slack and IRC, remove email notification.

Resolves: #59838
Releases: 6.3, 6.2, 4.5
Change-Id: Ic4dacd5c7b6b4e6e2b8cfa92ae7976b666209747
Reviewed-on: https://review.typo3.org/31104
Reviewed-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
4 years ago[BUGFIX] Fix RewriteRule for context to avoid HTTP 500 28/30328/6
Armin Ruediger Vieweg [Thu, 22 May 2014 14:07:53 +0000 (16:07 +0200)]
[BUGFIX] Fix RewriteRule for context to avoid HTTP 500

The affected rules are those for TYPO3_CONTEXT.
These rules should just set the ENV variable,
but should not touch the URL.
According to apache httpd docs this has to be
indicated by using a dash.

Also unnecessary grouping in the regexp has been
removed.

Resolves: #59037
Releases: 6.3, 6.2
Change-Id: I56cadcfb3cfae0a0ee679c6886cda9f5498fc47c
Reviewed-on: https://review.typo3.org/30328
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Armin Ruediger Vieweg
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
4 years agoRevert "[BUGFIX] Fix loading order for extensions" 97/31097/2
Markus Klein [Tue, 24 Jun 2014 01:10:55 +0000 (03:10 +0200)]
Revert "[BUGFIX] Fix loading order for extensions"

This reverts commit 49b53d491e43f3ad7a4c30dc23e208eb8db04199

The patch has two flaws:
 * Easy: packagePathStack also includes package folder which
         is incompatible to the excludedPaths search
 * Nightmare: Upon uninstalling extensions the PackageManager
         fails due to missing packagePathStack information

Change-Id: Ie026a90bd18ab86c355c17ae387df9249bc6b1c0
Resolves: #59831
Reverts: #59147
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31097
Reviewed-by: Markus Klein
Tested-by: Markus Klein
4 years ago[BUGFIX] Fix a JS error in with TCE select wizard 96/30896/3
Rémy DANIEL [Wed, 18 Jun 2014 15:38:32 +0000 (17:38 +0200)]
[BUGFIX] Fix a JS error in with TCE select wizard

Fixes an exception with decodeURI when an item containing
a % (percent) character is added to a select.
jQuery is now only used to append the option and its label to the DOM.

Resolves: #59655
Releases: 6.3, 6.2
Change-Id: I245f2fbec347b7e149aeea1cb7148591dc47e6f8
Reviewed-on: https://review.typo3.org/30896
Reviewed-by: Tim Lochmüller
Tested-by: Tim Lochmüller
Reviewed-by: Markus Klein
Tested-by: Markus Klein
4 years ago[BUGFIX] FollowUp: Fix signal returns for associated signal arguments 63/31063/4
Marc Bastian Heinrichs [Mon, 23 Jun 2014 07:47:40 +0000 (09:47 +0200)]
[BUGFIX] FollowUp: Fix signal returns for associated signal arguments

Fix broken functional tests. Add a fallback for earlier used associated
returns. Furthermore this patch reintroduces referenced signal arguments
to support old registered slots.

Resolves: #59794
Releases: 6.3, 6.2
Change-Id: Icfe997998476b9bdf77aba280eb87ca42786def8
Reviewed-on: https://review.typo3.org/31063
Reviewed-by: Philipp Gampe
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
4 years ago[BUGFIX] Make Extbase respect sys_language_mode=strict 57/30757/4
Georg Ringer [Mon, 16 Jun 2014 17:40:52 +0000 (19:40 +0200)]
[BUGFIX] Make Extbase respect sys_language_mode=strict

The Extbase query parser currently doesn't respect strict language mode
because it doesn't consider records that are only present in a localized
language version, but not in the default language.

As a consequence, records only present in a localized language version
are not fetched at all while for counting/paging the count of the default
language version is used.

This change adds a check for strict language mode and additional query
parts to solve this issue.

Releases: 6.3, 6.2
Resolves: #47183
Change-Id: I36511b2fd7c91f0bed5110c2cf12c04c8bbca9c9
Reviewed-on: https://review.typo3.org/30757
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Lorenz Ulrich
Tested-by: Lorenz Ulrich
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
4 years ago[TASK] Cleanup EXT:workspaces 09/31009/4
Wouter Wolters [Sat, 21 Jun 2014 17:14:43 +0000 (19:14 +0200)]
[TASK] Cleanup EXT:workspaces

* Update phpDoc where needed
* Import use statements where possible
* Make use of use statements if they are there already

Resolves: #59789
Releases: 6.3
Change-Id: I2c7baa6ac9b3a085b3fed83da559fddfdbf4c950
Reviewed-on: https://review.typo3.org/31009
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
4 years ago[BUGFIX] Fix signal returns for associated signal arguments 44/31044/3
Nicole Cordes [Sun, 22 Jun 2014 10:36:42 +0000 (12:36 +0200)]
[BUGFIX] Fix signal returns for associated signal arguments

The call of the dispatcher functions doesn't allow associated signal
arguments as all arguments are passed as parameter to the slot function.
This patch removes all associated signal arguments and uses numeric
arrays.

Resolves: #59794
Releases: 6.3, 6.2
Change-Id: Ie265c6c7dbf4c2b0972d3436164480bb741e15fa
Reviewed-on: https://review.typo3.org/31044
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
4 years ago[TASK] Re-work/simplify copyright header in PHP files - Part 8 29/31029/2
Michael Schams [Sun, 22 Jun 2014 05:56:21 +0000 (15:56 +1000)]
[TASK] Re-work/simplify copyright header in PHP files - Part 8

This patch replaces the copyright/license header in PHP files with a
new, simplified one. The new header does not show the year figure, nor
an author name, and refers to the LICENSE.txt file for the full
copyright information. License is: GPL2 or any later version.

This is a multi-part commit due to the huge number of changed files.
See issue #59784 for further details.

Resolves: #59784
Releases: 6.3, 6.2
Change-Id: I1eacf9bf4537776e850d091d9d50bc72f8c2b20d
Reviewed-on: https://review.typo3.org/31029
Reviewed-by: Krzysztof Adamczyk
Tested-by: Krzysztof Adamczyk
Reviewed-by: Markus Klein
Tested-by: Markus Klein
4 years ago[TASK] Re-work/simplify copyright header in PHP files - Part 9 30/31030/3
Michael Schams [Sun, 22 Jun 2014 06:08:42 +0000 (16:08 +1000)]
[TASK] Re-work/simplify copyright header in PHP files - Part 9

This patch replaces the copyright/license header in PHP files with a
new, simplified one. The new header does not show the year figure, nor
an author name, and refers to the LICENSE.txt file for the full
copyright information. License is: GPL2 or any later version.

This is a multi-part commit due to the huge number of changed files.
See issue #59785 for further details.

Resolves: #59785
Releases: 6.3, 6.2
Change-Id: If6a4795e7f2841474241d236d8ed33baceee0d2e
Reviewed-on: https://review.typo3.org/31030
Reviewed-by: Markus Klein
Tested-by: Markus Klein
4 years ago[TASK] Re-work/simplify copyright header in PHP files - Part 7 28/31028/2
Michael Schams [Sun, 22 Jun 2014 05:52:40 +0000 (15:52 +1000)]
[TASK] Re-work/simplify copyright header in PHP files - Part 7

This patch replaces the copyright/license header in PHP files with a
new, simplified one. The new header does not show the year figure, nor
an author name, and refers to the LICENSE.txt file for the full
copyright information. License is: GPL2 or any later version.

This is a multi-part commit due to the huge number of changed files.
See issue #59783 for further details.

Resolves: #59783
Releases: 6.3, 6.2
Change-Id: I0e2f68990217f7442abe5b940fd769250c37aec0
Reviewed-on: https://review.typo3.org/31028
Reviewed-by: Krzysztof Adamczyk
Tested-by: Krzysztof Adamczyk
Reviewed-by: Markus Klein
Tested-by: Markus Klein
4 years ago[TASK] Re-work/simplify copyright header in PHP files - Part 6 27/31027/2
Michael Schams [Sun, 22 Jun 2014 05:49:03 +0000 (15:49 +1000)]
[TASK] Re-work/simplify copyright header in PHP files - Part 6

This patch replaces the copyright/license header in PHP files with a
new, simplified one. The new header does not show the year figure, nor
an author name, and refers to the LICENSE.txt file for the full
copyright information. License is: GPL2 or any later version.

This is a multi-part commit due to the huge number of changed files.
See issue #59782 for further details.

Resolves: #59782
Releases: 6.3, 6.2
Change-Id: Idcd11219eb132c8690cfde256950980e9423bafd
Reviewed-on: https://review.typo3.org/31027
Reviewed-by: Krzysztof Adamczyk
Tested-by: Krzysztof Adamczyk
Reviewed-by: Markus Klein
Tested-by: Markus Klein
4 years ago[TASK] Re-work/simplify copyright header in PHP files - Part 5 26/31026/2
Michael Schams [Sun, 22 Jun 2014 05:21:16 +0000 (15:21 +1000)]
[TASK] Re-work/simplify copyright header in PHP files - Part 5

This patch replaces the copyright/license header in PHP files with a
new, simplified one. The new header does not show the year figure, nor
an author name, and refers to the LICENSE.txt file for the full
copyright information. License is: GPL2 or any later version.

This is a multi-part commit due to the huge number of changed files.
See issue #59781 for further details.

Resolves: #59781
Releases: 6.3, 6.2
Change-Id: I7429b8e9c507a4833215750268d1975402679828
Reviewed-on: https://review.typo3.org/31026
Reviewed-by: Krzysztof Adamczyk
Tested-by: Krzysztof Adamczyk
Reviewed-by: Markus Klein
Tested-by: Markus Klein
4 years ago[TASK] Re-work/simplify copyright header in PHP files - Part 4 25/31025/2
Michael Schams [Sun, 22 Jun 2014 05:18:31 +0000 (15:18 +1000)]
[TASK] Re-work/simplify copyright header in PHP files - Part 4

This patch replaces the copyright/license header in PHP files with a
new, simplified one. The new header does not show the year figure, nor
an author name, and refers to the LICENSE.txt file for the full
copyright information. License is: GPL2 or any later version.

This is a multi-part commit due to the huge number of changed files.
See issue #59780 for further details.

Resolves: #59780
Releases: 6.3, 6.2
Change-Id: I00eff31cdff19774527e3b1bb06e29152928414c
Reviewed-on: https://review.typo3.org/31025
Reviewed-by: Krzysztof Adamczyk
Tested-by: Krzysztof Adamczyk
Reviewed-by: Markus Klein
Tested-by: Markus Klein
4 years ago[TASK] Re-work/simplify copyright header in PHP files - Part 3 24/31024/3
Michael Schams [Sun, 22 Jun 2014 05:14:02 +0000 (15:14 +1000)]
[TASK] Re-work/simplify copyright header in PHP files - Part 3

This patch replaces the copyright/license header in PHP files with a
new, simplified one. The new header does not show the year figure, nor
an author name, and refers to the LICENSE.txt file for the full
copyright information. License is: GPL2 or any later version.

This is a multi-part commit due to the huge number of changed files.
See issue #59779 for further details.

Resolves: #59779
Releases: 6.3, 6.2
Change-Id: I30ad23ccfccd86ba9e98a3b46b11836c1628f499
Reviewed-on: https://review.typo3.org/31024
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Krzysztof Adamczyk
Tested-by: Krzysztof Adamczyk
4 years ago[TASK] Re-work/simplify copyright header in PHP files - Part 2 23/31023/2
Michael Schams [Sun, 22 Jun 2014 04:56:28 +0000 (14:56 +1000)]
[TASK] Re-work/simplify copyright header in PHP files - Part 2

This patch replaces the copyright/license header in PHP files with a
new, simplified one. The new header does not show the year figure, nor
an author name, and refers to the LICENSE.txt file for the full
copyright information. License is: GPL2 or any later version.

This is a multi-part commit due to the huge number of changed files.
See issue #59778 for further details.

Resolves: #59778
Releases: 6.3, 6.2
Change-Id: I155df27e66ec103a4f83356adef7dc441585b54a
Reviewed-on: https://review.typo3.org/31023
Reviewed-by: Krzysztof Adamczyk
Tested-by: Krzysztof Adamczyk
Reviewed-by: Markus Klein
Tested-by: Markus Klein
4 years ago[TASK] Re-work/simplify copyright header in PHP files - Part 1 22/31022/2
Michael Schams [Sun, 22 Jun 2014 04:12:59 +0000 (14:12 +1000)]
[TASK] Re-work/simplify copyright header in PHP files - Part 1

This patch replaces the copyright/license header in PHP files with a
new, simplified one. The new header does not show the year figure, nor
an author name, and refers to the LICENSE.txt file for the full
copyright information. License is: GPL2 or any later version.

This is a multi-part commit due to the huge number of changed files.
See issue #59777 for further details.

Resolves: #59777
Releases: 6.2
Change-Id: Idf5ef5a0da53dd052af54d42a115e951bc9d0e91
Reviewed-on: https://review.typo3.org/31022
Reviewed-by: Krzysztof Adamczyk
Tested-by: Krzysztof Adamczyk
Reviewed-by: Markus Klein
Tested-by: Markus Klein
4 years ago[TASK] Merge GPL.txt and LICENSE.txt 09/30709/6
Markus Klein [Sun, 22 Jun 2014 10:55:58 +0000 (12:55 +0200)]
[TASK] Merge GPL.txt and LICENSE.txt

Resolves: #59535
Releases: 6.3, 6.2
Change-Id: Ia3c442ec4d838bd5c3b350a74ced3f90ef971a21
Reviewed-on: https://review.typo3.org/30709
Reviewed-by: Markus Klein
Tested-by: Markus Klein
4 years agoRevert "[BUGFIX] Inaccessible pages on shortcuts/PageNotFound handler" 39/31039/4
Helmut Hummel [Sun, 22 Jun 2014 10:22:43 +0000 (12:22 +0200)]
Revert "[BUGFIX] Inaccessible pages on shortcuts/PageNotFound handler"

This introduced a regression. It turns out that it needs more work
to get all cases covered correctly.

Resolves: #58728
Reverts: #16472
Releases: 6.1, 6.2, 6.3
This reverts commit 9ab3b9b5dd96ae0f955277a8997abb4bd69a66ff

Change-Id: I395e052c1f31adde715f5a25f9d1716c092dd908
Reviewed-on: https://review.typo3.org/31039
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
4 years ago[TASK] Introduce unique signal registration 13/31013/5
Nicole Cordes [Sat, 21 Jun 2014 17:48:50 +0000 (19:48 +0200)]
[TASK] Introduce unique signal registration

Signals should be dispatch in own emit functions for better locating.
This patch moves signals to separate functions and attaches missing
suffixes to existing ones.

Resolves: #59774
Releases: 6.3, 6.2
Change-Id: I7a1411566a78e326f1f870b2d345631e7ca265e0
Reviewed-on: https://review.typo3.org/31013
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
4 years ago[BUGFIX] Fix loading order for extensions 49/30449/7
Markus Klein [Tue, 27 May 2014 15:36:45 +0000 (17:36 +0200)]
[BUGFIX] Fix loading order for extensions

Stick to the documented loading order of extensions.
That means following this order: sysext, global, local, composer

The same extension found in the latter will be loaded instead of
the former. Also adjust the Dependency resolver accordingly for the
edge-case of overwriting sysexts.

Resolves: #59147
Releases: 6.3, 6.2
Change-Id: I50c7849e32b309a28f792340f3ff892e516dadb8
Reviewed-on: https://review.typo3.org/30449
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Markus Klein
Tested-by: Markus Klein
4 years ago[CLEANUP] Clean code in FormEngine 52/30252/4
Sebastian Michaelsen [Wed, 21 May 2014 13:01:58 +0000 (15:01 +0200)]
[CLEANUP] Clean code in FormEngine

\TYPO3\CMS\Backend\Form\FormEngine could use a few cleanups:

* Import some classes to avoid unnecessary fully qualified class names
* Fix some PHPdoc issues
* Slightly adjust some method signatures
  (when 0, 1, or '' were used for boolean information)
* Remove some unused local variables

Resolves: #58995
Releases: 6.3, 6.2
Change-Id: Ic79acf80e75b78f9b8b70c946dd15e5b32996fb2
Reviewed-on: https://review.typo3.org/30252
Reviewed-by: Markus Klein
Tested-by: Markus Klein
4 years ago[BUGFIX] Remove misspelled setting rootlevel for sys_file_collection 10/31010/2
Marc Bastian Heinrichs [Sat, 21 Jun 2014 17:24:56 +0000 (19:24 +0200)]
[BUGFIX] Remove misspelled setting rootlevel for sys_file_collection

The correct setting would have been rootLevel. So it was never
evaluated, remove it.

Resolves: #59773
Releases: 6.3, 6.2, 6.1
Change-Id: I594924caed47c5c911def94524148354790b77b4
Reviewed-on: https://review.typo3.org/31010
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
4 years ago[BUGFIX] Move TCA modification of EXT:form to TCA/Overrides. 51/30651/5
Anja Leichsenring [Tue, 10 Jun 2014 20:10:03 +0000 (22:10 +0200)]
[BUGFIX] Move TCA modification of EXT:form to TCA/Overrides.

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: I789ea89318d76d0c709229139b0f5296042cded7
Resolves: #59466
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/30651
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Sebastian Fischer
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
4 years ago[BUGFIX] Move TCA modification of EXT:t3editor to TCA/Overrides 44/30944/2
Anja Leichsenring [Fri, 20 Jun 2014 15:04:19 +0000 (17:04 +0200)]
[BUGFIX] Move TCA modification of EXT:t3editor to TCA/Overrides

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: I1f92a7b536ffb19d30bb580ea30452fc488cd0f6
Resolves: #59705
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/30944
Reviewed-by: Sebastian Fischer
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
4 years ago[BUGFIX] Move TCA modification of EXT:cms to TCA/Overrides. 48/30648/6
Anja Leichsenring [Tue, 10 Jun 2014 18:52:23 +0000 (20:52 +0200)]
[BUGFIX] Move TCA modification of EXT:cms to TCA/Overrides.

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: Idb1be39c754d5566e52623103477b94887077cdb
Resolves: #59463
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/30648
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Sebastian Fischer
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
4 years ago[TASK] Add a signal after importer init in ImportExportUtility 65/30065/7
Marc Bastian Heinrichs [Sun, 4 May 2014 15:21:02 +0000 (17:21 +0200)]
[TASK] Add a signal after importer init in ImportExportUtility

To be able to modify importer options on importing T3D-files on
extension installation (e.g. for distributions) this patch introduces
a signal in ImportExportUtility.

Resolves: #58782
Releases: 6.3, 6.2
Change-Id: I9a3dec39efe4b8205013614cef1624720aab402a
Reviewed-on: https://review.typo3.org/30065
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
4 years ago[TASK] Add possibility to register a module as navigation 93/30593/4
Helmut Hummel [Thu, 5 Jun 2014 15:00:18 +0000 (17:00 +0200)]
[TASK] Add possibility to register a module as navigation

While implementing CSRF protection for backend modules,
it was forgotten to implement a solution for navigation components
that also could be modules.

Add this possibility now by introducing yet another
configuration option for modules.

Resolves: #58138
Documentation: #59369
Releases: 6.3, 6.2
Change-Id: I6655ad11cbf8a13c7d1182c9635cf2745183fb49
Reviewed-on: https://review.typo3.org/30593
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
4 years ago[TASK] Signal for BackendUtility::getPagesTSconfig() 21/30921/9
Alexander Stehlik [Fri, 20 Jun 2014 11:58:23 +0000 (13:58 +0200)]
[TASK] Signal for BackendUtility::getPagesTSconfig()

A signal is dispatched in BackendUtility::getPagesTSconfig()
before the include lines are calculated.

This enables to supply additional PageTS for each page
programmatically, even in multi-site environments.

Releases: 6.3, 6.2
Resolves: #59703
Change-Id: I1cc1188eebbf6dee769c64a654339837e0cdce59
Reviewed-on: https://review.typo3.org/30921
Reviewed-by: Felix Oertel
Tested-by: Felix Oertel
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
4 years ago[TASK] Create CSS Styled Content TypoScript configuration for 6.3 57/30957/4
Wouter Wolters [Fri, 20 Jun 2014 17:55:53 +0000 (19:55 +0200)]
[TASK] Create CSS Styled Content TypoScript configuration for 6.3

For backwards compatibility we keep versions of the CSS Styled
Content TypoScript configuration files selectable as rendering
template.

The current setup.txt and constants.txt are just copied into
the 6.2 folder. After this change the branches may diverge.

Resolves: #59736
Releases: 6.3
Change-Id: Ic8ec99917917678c6d0e38ca7b4402166ffac115
Reviewed-on: https://review.typo3.org/30957
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
4 years ago[TASK] Clean up NEWS.md for 6.3 59/30959/3
Wouter Wolters [Fri, 20 Jun 2014 18:05:53 +0000 (20:05 +0200)]
[TASK] Clean up NEWS.md for 6.3

Resolves: #59737
Releases: 6.3
Change-Id: I3260bd78ae85af5915c6ef208dc18468b9cc948a
Reviewed-on: https://review.typo3.org/30959
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
4 years ago[TASK] Update all extension versions to 6.3.0 65/30965/2
Robert van Kammen [Fri, 20 Jun 2014 18:54:15 +0000 (20:54 +0200)]
[TASK] Update all extension versions to 6.3.0

Resolves: #59742
Releases: 6.3
Change-Id: Id6c05025873bdbdeebd74585f9bd4093657999e0
Reviewed-on: https://review.typo3.org/30965
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
4 years ago[BUGFIX] getAvailableWorkspaces called statically 62/30962/2
Wouter Wolters [Fri, 20 Jun 2014 18:28:14 +0000 (20:28 +0200)]
[BUGFIX] getAvailableWorkspaces called statically

Use same call to getAvailableWorkspaces as in
checkAccess.

Resolves: #51420
Releases: 6.3, 6.2
Change-Id: Icbea4611d7bd498e25bf658d7f3fa5a74539f479
Reviewed-on: https://review.typo3.org/30962
Reviewed-by: Oliver Klee
Reviewed-by: Robert van Kammen
Tested-by: Robert van Kammen
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
4 years ago[TASK] Remove not maintained ChangeLog files 63/30963/6
Wouter Wolters [Fri, 20 Jun 2014 18:36:14 +0000 (20:36 +0200)]
[TASK] Remove not maintained ChangeLog files

Remove not maintained ChangeLog in

EXT:dbal
EXT:version
EXT:workspaces

Resolves: #59739
Releases: 6.3
Change-Id: I99b48964a529de3bcfa069f2902232418a89bf5b
Reviewed-on: https://review.typo3.org/30963
Reviewed-by: Oliver Klee
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
4 years ago[TASK] Cleanup WorkspaceSelectorToolbarItem 70/30970/3
Wouter Wolters [Fri, 20 Jun 2014 19:46:04 +0000 (21:46 +0200)]
[TASK] Cleanup WorkspaceSelectorToolbarItem

Resolves: #59748
Releases: 6.3
Change-Id: I29ff785404fba56ccff0a5e909c8dd1149c4a9bb
Reviewed-on: https://review.typo3.org/30970
Reviewed-by: Robert van Kammen
Tested-by: Robert van Kammen
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
4 years ago[BUGFIX] Move TCA modification of EXT:openid to TCA/Overrides 10/30910/4
Anja Leichsenring [Fri, 20 Jun 2014 09:46:16 +0000 (11:46 +0200)]
[BUGFIX] Move TCA modification of EXT:openid to TCA/Overrides

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: I7b5240eccde3d49531bb734adf26ee623829dc59
Resolves: #59698
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/30910
Reviewed-by: Olivier Dobberkau
Reviewed-by: Sebastian Fischer
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
4 years ago[BUGFIX] Prevent error message for correct imports of sys_file_metadata 40/30140/5
Marc Bastian Heinrichs [Thu, 15 May 2014 13:02:57 +0000 (15:02 +0200)]
[BUGFIX] Prevent error message for correct imports of sys_file_metadata

If sys_file_metadata records are updated on import, a wrong error message
is logged.

Resolves: #58826
Releases: 6.3, 6.2
Change-Id: I023306a69da9c725d52d076d196bf22178ff1f62
Reviewed-on: https://review.typo3.org/30140
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
4 years ago[BUGFIX] Fix empty globalString LIT condition comparison 59/30559/5
Marc Bastian Heinrichs [Wed, 4 Jun 2014 14:40:53 +0000 (16:40 +0200)]
[BUGFIX] Fix empty globalString LIT condition comparison

An empty "LIT:" condition results in NULL, so the strict compare
doesn't match with the empty string.

Solution is to cast the haystack to string before, like it was
done anyway later in the preg_match.

Releases: 6.3, 6.2, 6.1
Resolves: #59344
Change-Id: I1e4b00e454d921eedd0c03a1767d4ec57c321bd7
Reviewed-on: https://review.typo3.org/30559
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Marc Bastian Heinrichs
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
4 years ago[BUGFIX] Don't ignore file imports in fallback storage 47/30147/4
Marc Bastian Heinrichs [Thu, 15 May 2014 16:22:44 +0000 (18:22 +0200)]
[BUGFIX] Don't ignore file imports in fallback storage

An export could contain sys_file records that are "stored" in the
fallback storage (ID 0). They must not be ignored.

Resolves: #58841
Releases: 6.3, 6.2
Change-Id: I39855810621310831ab1353c5e56f4529a7ac3aa
Reviewed-on: https://review.typo3.org/30147
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
4 years ago[TASK] Improve StringUtility 11/30611/10
Markus Klein [Fri, 6 Jun 2014 16:00:40 +0000 (18:00 +0200)]
[TASK] Improve StringUtility

This patch adds the methods beginsWith() and endsWith().
Furthermore it deprecates the (Core-wise unused) isLastPartOfString()
method, because we slightly change the implementation of it, which is
now part of endsWith().

Resolves: #59132
Resolves: #45499
Releases: 6.3
Change-Id: Ida21a85a3cb724618a490f7eab753978a1bfaa70
Reviewed-on: https://review.typo3.org/30611
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Markus Klein
Tested-by: Markus Klein
4 years ago[BUGFIX] Treat link handler links as internal URLs 80/27680/5
Alexander Stehlik [Tue, 18 Feb 2014 09:55:05 +0000 (10:55 +0100)]
[BUGFIX] Treat link handler links as internal URLs

The RteHtmlParser will now check if a scheme found by parse_url()
matches a configured typolinkLinkHandler. If this is the case the
link will be treated as internal.

Resolves: #49036
Releases: 6.3, 6.2, 6.1
Change-Id: Ie4e6bded7a1c4d0c61e4f1a20bc23115612c1519
Reviewed-on: https://review.typo3.org/27680
Reviewed-by: Markus Klein
Tested-by: Markus Klein
4 years ago[TASK] FollowUp to add support for having files outside the t3d/xml 55/30955/3
Marc Bastian Heinrichs [Fri, 20 Jun 2014 17:06:36 +0000 (19:06 +0200)]
[TASK] FollowUp to add support for having files outside the t3d/xml

Fix functional tests.

Resolves: #57379
Change-Id: Iafbf4e2b7e68dd27b488f20141f34680f57bc9c4
Reviewed-on: https://review.typo3.org/30955
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
4 years ago[TASK] Remove not maintained ChangeLog in EXT:linkvalidator 60/30960/2
Wouter Wolters [Fri, 20 Jun 2014 18:19:23 +0000 (20:19 +0200)]
[TASK] Remove not maintained ChangeLog in EXT:linkvalidator

Resolves: #59738
Releases: 6.3
Change-Id: Idb08c3f7311ae97590495c77d180429baabefcda
Reviewed-on: https://review.typo3.org/30960
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
4 years ago[TASK] Add support for having files outside the t3d/xml in impexp 53/30453/3
Marc Bastian Heinrichs [Tue, 27 May 2014 19:42:42 +0000 (21:42 +0200)]
[TASK] Add support for having files outside the t3d/xml in impexp

Impexp files are blown up from the files that are included as base64.
This patch adds the possibility to have the files separated from the
 t3d/xml export file. They are saved to a folder beside the export file.

Resolves: #57379
Releases: 6.3, 6.2
Change-Id: Ib8bdc4336c64d2eae0e993132a5fce84eb01f766
Reviewed-on: https://review.typo3.org/30453
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
4 years ago[BUGFIX] language condition does not match exact string 20/30920/3
Susanne Moog [Fri, 20 Jun 2014 11:58:35 +0000 (13:58 +0200)]
[BUGFIX] language condition does not match exact string

The documentation for conditions of type "language" states: "The values
must be a straight match with the value of getenv('HTTP_ACCEPT_LANGUAGE')
from PHP." (or you can use wildcards). Exact matches are actually
not working - and the unit test showing the problem was skipped.

Patch adds the feature as documented and adjusts the unit test.

Change-Id: I5691fff41c889476d8149d6f92c26731ad7bb1fd
Resolves: #59707
Releases: 6.3
Reviewed-on: https://review.typo3.org/30920
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
4 years ago[TASK] Remove skipped FAL tests 40/30940/2
Susanne Moog [Fri, 20 Jun 2014 14:37:57 +0000 (16:37 +0200)]
[TASK] Remove skipped FAL tests

FAL includes some tests that are skipped ever since
FAL was merged. Most of them don't even have a
comment as to why and need to be completely rewritten
as the functionality changed.

We should remove these tests for now.

Change-Id: Ib75b4ea104a968019e06937974eaa1846cfe3a8a
Releases: 6.3
Resolves: #59728
Reviewed-on: https://review.typo3.org/30940
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
4 years ago[BUGFIX] Nested flexforms no longer throw exception 90/30590/7
Thomas Christiansen [Thu, 5 Jun 2014 13:33:53 +0000 (15:33 +0200)]
[BUGFIX] Nested flexforms no longer throw exception

This patch prevents nested flexforms from throwing
an exception on saving or opening the record.

Resolves: #59368
Releases: 6.2

Change-Id: Iadeeecc3aef92b8bcc4f7fe4e22882d924f10a50
Reviewed-on: https://review.typo3.org/30590
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
4 years ago[TASK] Raise recommended max nesting level 08/30608/4
Thomas Christiansen [Fri, 6 Jun 2014 13:37:06 +0000 (15:37 +0200)]
[TASK] Raise recommended max nesting level

Raise recommended max nesting level to 400 as
the current value of 250 does not suffice.

Resolves: #59391
Releases: 6.3, 6.2
Change-Id: Ibccb61991809e24baddb21bd46f190cd0b8d907d
Reviewed-on: https://review.typo3.org/30608
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Markus Klein
Tested-by: Markus Klein
4 years ago[TASK] Re-add unit tests for ExtensionCompatibilityTester 15/30915/3
Susanne Moog [Fri, 20 Jun 2014 10:23:21 +0000 (12:23 +0200)]
[TASK] Re-add unit tests for ExtensionCompatibilityTester

The tests for the ExtensionCompatibilityTester are currently skipped.
This patch removes the broken tests and leaves the working ones.

Releases: 6.3
Resolves: #59700

Change-Id: I10a49d0dddf2807bd50944837e31f0105374c8c9
Reviewed-on: https://review.typo3.org/30915
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
4 years ago[BUGFIX] Check for logged in user before showing cookie warning 23/30723/5
Tomita Militaru [Sat, 14 Jun 2014 11:52:38 +0000 (14:52 +0300)]
[BUGFIX] Check for logged in user before showing cookie warning

If a redirect for login error is setup, the warning cookie
message is displayed instead of redirecting.

Resolves: #59493
Releases: 6.3, 6.2
Change-Id: I2f63b6630863ece0704198f247980c4d6c08f65a
Reviewed-on: https://review.typo3.org/30723
Reviewed-by: Oliver Hader
Reviewed-by: Marc Wöhlken
Tested-by: Marc Wöhlken
Reviewed-by: Markus Klein
Tested-by: Markus Klein
4 years ago[BUGFIX] Make Functional tests work on fast machines 96/30696/7
Tymoteusz Motylewski [Thu, 12 Jun 2014 14:02:20 +0000 (16:02 +0200)]
[BUGFIX] Make Functional tests work on fast machines

Adds more entropy to the uniqid() call. So each call inside
foreach loop will generate unique value.
As uniqid() generates values based on current time,
subsequent calls may return the same value on a fast machine.

On Windows it's even worse, as uniqid()
has single-second-resolution out of the box.

Resolves: #59529
Relates: #58602
Releases: 6.3, 6,2
Change-Id: I7476f85961e906905acaca7fd816e37375c9817c
Reviewed-on: https://review.typo3.org/30696
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
4 years ago[TASK] Increase Extension Manager->showConfiguration input field width 04/30904/2
Felix Kopp [Fri, 20 Jun 2014 08:51:18 +0000 (10:51 +0200)]
[TASK] Increase Extension Manager->showConfiguration input field width

Increases the width of string input fields to 300 pixels.

Resolves: #59679
Releases: 6.2, 6.3
Change-Id: Ia415a6cdf81e4f6192a7e3fb93d8f01d8a749c6a
Reviewed-on: https://review.typo3.org/30904
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
4 years ago[BUGFIX] Get unit tests working again 89/30889/4
Markus Klein [Thu, 19 Jun 2014 18:10:15 +0000 (20:10 +0200)]
[BUGFIX] Get unit tests working again

Changed serialize behaviour in PHP triggers funny phpunit issues in
some tests. Switching to phpunit master for now and skipping some
tests makes travis-ci green again and gives us time for detail fixes.

Change-Id: I1c694c0c5dba98b31b9ef7c826fa6614ffa512df
Resolves: #59685
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/30889
Reviewed-by: Christian Mueller
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
4 years ago[BUGFIX] Pass field name variable to flexform DS utility 33/30633/6
Claus Due [Mon, 9 Jun 2014 21:30:37 +0000 (23:30 +0200)]
[BUGFIX] Pass field name variable to flexform DS utility

A field name parameter is not being passed from within
DataHandler when copying a record which has a FlexForm
DF associated with it. This causes dynamic FlexForm DS
definitions to not be able to depend on the field name,
in turn causing the problem that an incorrect DS may be
returned from the DS utility which makes TYPO3 process
the data value incorrectly (for example, not detecting
file fields and processing the values accordingly).

To solve this the $field parameter is passed.

Resolves: #59423
Releases: 6.3, 6.2, 6.1
Change-Id: Icfafd553f76e17ad5db651bb3f5dea52b140dcf7
Reviewed-on: https://review.typo3.org/30633
Reviewed-by: Cedric Ziel
Tested-by: Cedric Ziel
Reviewed-by: Markus Klein
Tested-by: Markus Klein
4 years ago[BUGFIX] Remove warnings in ImportExportController.php 81/29881/3
Nicole Cordes [Mon, 5 May 2014 20:21:49 +0000 (22:21 +0200)]
[BUGFIX] Remove warnings in ImportExportController.php

This patch adds cleanup to prevent warnings when accessing the
import/export module.

Resolves: #58534
Releases: 6.3, 6.2
Change-Id: I1e1afbea07b0c8e8c4bc29d25739882907c79b4b
Reviewed-on: https://review.typo3.org/29881
Reviewed-by: Susanne Moog
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Markus Klein
Tested-by: Markus Klein
4 years ago[FEATURE] Add uid to SysDomainCache 94/28794/3
Henrik Ziegenhain [Tue, 25 Mar 2014 18:11:25 +0000 (19:11 +0100)]
[FEATURE] Add uid to SysDomainCache

If you are building an extension, that outputs
data depending on a selected domain, it is easier
to compare the uid of sys_domain records
than the domainName itself.

Resolves: #57297
Releases: 6.3
Change-Id: Ic1efd3efe043f28ef7737f407d9a200b168d9685
Reviewed-on: https://review.typo3.org/28794
Reviewed-by: Markus Schubath
Tested-by: Markus Schubath
Reviewed-by: Krzysztof Adamczyk
Reviewed-by: Andrea Schmuttermair
Reviewed-by: Markus Klein
Tested-by: Markus Klein
4 years ago[TASK] Extension manager: default sorting for Extensions 35/30735/4
Felix Kopp [Sun, 15 Jun 2014 09:13:17 +0000 (11:13 +0200)]
[TASK] Extension manager: default sorting for Extensions

EM "Get Extension" does not show the awesome extension culture
that lives in the TER. Change sorting basically with the primary goal
to order extensions by update.

Resolves: #59583
Releases: 6.3, 6.2
Change-Id: Ie8aebc13c41427e0603fa5313b794996d01fbc44
Reviewed-on: https://review.typo3.org/30735
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Robert van Kammen
Tested-by: Robert van Kammen
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
4 years ago[TASK] Ensure that cli user is admin on extension install and uninstall 15/30715/4
Marc Bastian Heinrichs [Fri, 13 Jun 2014 14:24:57 +0000 (16:24 +0200)]
[TASK] Ensure that cli user is admin on extension install and uninstall

Extension install and uninstall is an admin task. Calling the belonging
CommandController on cli should ensure, that the user has admin
rights.

This adds API to the CommandController to avoid code duplication
in every controller to achieve this.

Distribution packages could be installed via cli without errors now.

Resolves: #59556
Releases: 6.3, 6.2
Change-Id: Icd1b6bf4379322c8bec07531a15d2171b103e076
Reviewed-on: https://review.typo3.org/30715
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
4 years ago[BUGFIX] Fix RTE file links migration 20/30820/2
Markus Klein [Wed, 18 Jun 2014 15:07:19 +0000 (17:07 +0200)]
[BUGFIX] Fix RTE file links migration

Links in RTE might be stored as <LINK or <link.
Currently the upgrade wizards lacks support for <LINK.
Add this to the regular expression.

Resolves: #51800
Releases: 6.3, 6.2
Change-Id: Ic22983db1144fb1317d6102907c792871e1eeaed
Reviewed-on: https://review.typo3.org/30820
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
4 years ago[BUGFIX] Wrong check for showing folder clickmenu 59/30759/3
Frans Saris [Mon, 16 Jun 2014 19:39:04 +0000 (21:39 +0200)]
[BUGFIX] Wrong check for showing folder clickmenu

This patch fixes a wrong check that prevents the clickmenu
from showing for folders in the filelist.

Resolves: #59568
Releases: 6.3, 6.2
Change-Id: Ic1e8bb28f64717631c4b57bc44221bd1132b876e
Reviewed-on: https://review.typo3.org/30759
Reviewed-by: Markus Klein
Tested-by: Markus Klein
4 years ago[BUGFIX] Typos in t3skin css files 29/30329/6
Markus Klein [Thu, 22 May 2014 14:10:21 +0000 (16:10 +0200)]
[BUGFIX] Typos in t3skin css files

Remove the lines as they have not been valid, nobody will miss them.

Resolves: #57716
Releases: 6.3, 6.2
Change-Id: I70625980ec49f6a8f76d695c4e2eb5d3c1548b36
Reviewed-on: https://review.typo3.org/30329
Reviewed-by: Markus Klein
Tested-by: Markus Klein
4 years ago[BUGFIX] Correctly align datepicker clear input and trigger icon 58/30758/3
Frans Saris [Mon, 16 Jun 2014 19:26:54 +0000 (21:26 +0200)]
[BUGFIX] Correctly align datepicker clear input and trigger icon

This patch fixed the alignment of the clear input icon in the
date input fields and the trigger icon outside the datepicker input
fields.

Resolves: #59615
Releases: 6.3, 6.2
Change-Id: I0943ea0a8c4157d46fc07ca055ac8c1ab67c9a5b
Reviewed-on: https://review.typo3.org/30758
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
4 years ago[TASK] Set TYPO3 version to 6.3-dev 86/30786/2
Oliver Hader [Tue, 17 Jun 2014 16:48:49 +0000 (18:48 +0200)]
[TASK] Set TYPO3 version to 6.3-dev

Releases: 6.3
Change-Id: Ie6aef74f866ac9b93e752a777ce6313126d8a32f
Reviewed-on: https://review.typo3.org/30786
Reviewed-by: Christian Kuhn
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
4 years ago[BUGFIX] Undefined method in extension manager 77/30777/2
Oliver Hader [Tue, 17 Jun 2014 13:35:14 +0000 (15:35 +0200)]
[BUGFIX] Undefined method in extension manager

PHP fatal error due to the invalid call to non-existing method
ExtensionManagementService::resolveDependenciesAndInstall during
upgrading an existing extension to a newer version from TER.

Resolves: #59624
Releases: 6.2
Change-Id: I84ff3685a94625cbc94af1967ac65b61cf9f5e43
Reviewed-on: https://review.typo3.org/30777
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
4 years ago[BUGFIX] Page tree does not visualize move targets 73/30473/2
Oliver Hader [Wed, 28 May 2014 13:40:01 +0000 (15:40 +0200)]
[BUGFIX] Page tree does not visualize move targets

If moving an element to a different page, the page tree only
visualizes the change in the source page, but does not visualize
the target page.

The reason is that the move-pointer is used (t3ver_state=4)
instead of the move-placeholder (t3ver_state=3) in that case.

Resolves: #59114
Releases: 6.2
Change-Id: Iefa01e4c85e9fb753873d03e7638ac592c09a657
Reviewed-on: https://review.typo3.org/30473
Reviewed-by: Wouter Wolters
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
4 years ago[BUGFIX] Define precedence of states in workspace module 67/30467/2
Oliver Hader [Wed, 28 May 2014 11:03:58 +0000 (13:03 +0200)]
[BUGFIX] Define precedence of states in workspace module

The workspace module defines several states:
edited, moved, created, hidden, unhidden, deleted

The states "hidden" and "unhidden" are currently applied
after the action states. This change only uses the hidden
states if a record has been modified.

Resolves: #59118
Releases: 6.2
Change-Id: I95981306d61df38939a47579cb320dd93d51ce5b
Reviewed-on: https://review.typo3.org/30467
Reviewed-by: Wouter Wolters
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
4 years ago[BUGFIX] Preview of moved workspace elements on source page 74/30474/2
Oliver Hader [Wed, 28 May 2014 13:42:21 +0000 (15:42 +0200)]
[BUGFIX] Preview of moved workspace elements on source page

If e.g. a content element gets moved to a different page, the
workspace preview link opens the source page (which does not
contain the element anymore, because it was moved).

Since the elements are shown on the correct page in the
workspace backend module, using the target page in the preview
link for the frontend is just obvious.

Resolves: #59143
Releases: 6.2
Change-Id: Ib84e65766e825cc26a66cbda9ffa8132c3a3ec18
Reviewed-on: https://review.typo3.org/30474
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
4 years agoRevert "[BUGFIX] Session cookie is not recreated on login" 53/30753/6
Helmut Hummel [Mon, 16 Jun 2014 14:36:12 +0000 (16:36 +0200)]
Revert "[BUGFIX] Session cookie is not recreated on login"

This reverts commit 76741dff7b967b88aa1d6e556500a77716c7a97a
(https://review.typo3.org/29626)

This change is not needed any more as the fix done
for #58713 also fixes the issues targeted with this fix.

This should be reverted not only because it is not needed
any more but especially because it "abuses" the property
->newSessionID which should only be set when really
a new ID has been generated and not to force the cookie
to be set again.

Releases: 6.2
Resolves: #59614
Reverts: #57751
Related: #58713
Change-Id: I5324769b0795bcc1b1f1e385c73fd085d7b3f571
Reviewed-on: https://review.typo3.org/30753
Reviewed-by: Markus Klein
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel