Packages/TYPO3.CMS.git
3 years ago[BUGFIX] InstallTool: Optimize ALTER TABLE for auto_increment columns 99/43299/2
Morton Jonuschat [Fri, 28 Aug 2015 07:58:31 +0000 (09:58 +0200)]
[BUGFIX] InstallTool: Optimize ALTER TABLE for auto_increment columns

To successfully add a new column with auto_increment enabled to a table
the column needs to be included in a (primary) key. The install tool
handled this in a two step process by ignoring the auto_increment
attribute and separating adding the field and the key into two
statements. This fails on existing tables with data as the column will
include non-uniqued/non-incrementing values after the first statement
leading to failures adding the key.

The proper way to add a columns with the auto_increment attribute is to
combine the ALTER TABLE statement to perform both alterations at the
same time, this patch changes the behavior of the Install Tool to
generate statements accordingly on MySQL.

When running with DBAL enabled the statement will not be altered in any
way to allow the SqlParser to take into account database specific
handling of this case, an example test case is included for PostgreSQL
which handles this case transparently using the SERIAL column type.

Resolves: #69304
Releases: master, 6.2
Change-Id: I211b25b22e122e47d289b9d7f927b5c713cdd138
Reviewed-on: http://review.typo3.org/43299
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
3 years ago[BUGFIX] Correct TYPO3 logo used in icons 66/43266/2
Benjamin Kott [Sun, 13 Sep 2015 11:08:37 +0000 (13:08 +0200)]
[BUGFIX] Correct TYPO3 logo used in icons

Resolves: #68991
Releases: 6.2
Change-Id: If7784567c92eced1dfaecfcb98b232d6ec842fb2
Reviewed-on: http://review.typo3.org/43266
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] Enable color output for unit/functional tests 80/43280/2
Mathias Brodala [Sun, 13 Sep 2015 15:01:25 +0000 (17:01 +0200)]
[TASK] Enable color output for unit/functional tests

Resolves: #69762
Releases: master, 6.2
Change-Id: I6520afb1fc65f77dd12f4f771cce36cbdced3ce9
Reviewed-on: http://review.typo3.org/43280
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
3 years ago[BUGFIX] Fix BackendUtility::selectVersionsOfRecord parameter 60/43160/2
Alexander Opitz [Tue, 18 Aug 2015 17:02:44 +0000 (19:02 +0200)]
[BUGFIX] Fix BackendUtility::selectVersionsOfRecord parameter

The fix in #60249 accidently changed the meaning of the workspace
parameter, so that some lowlevel_cleaner didn't worked correct anymore.
We now add the old ability to find versions over all workspaces.

Resolves: #69135
Releases: master, 6.2
Change-Id: I8999bf2e6487391d41cc7ce80461afb8e813ce97
Reviewed-on: http://review.typo3.org/43160
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[BUGFIX] Wrong marker mentioned in documentation of ext:felogin 59/43159/3
Wouter Wolters [Wed, 9 Sep 2015 16:01:02 +0000 (18:01 +0200)]
[BUGFIX] Wrong marker mentioned in documentation of ext:felogin

A marker is mentioned as example in the documentation, which is wrong.
The example is ###USERNAME### and should be ###FEUSER_USERNAME###

Resolves: #69628
Releases: master,6.2
Change-Id: Ia5994fa45dcee76c8a2778f60869f0288a3fe3af
Reviewed-on: http://review.typo3.org/43159
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] IMG_RESOURCE does not prepend absRefPrefix 57/43157/2
Heiko Kromm [Thu, 3 Sep 2015 19:27:13 +0000 (21:27 +0200)]
[BUGFIX] IMG_RESOURCE does not prepend absRefPrefix

Rendering an imageResource with TypoScript IMG_RESOURCE
does not prepend the absRefPrefix.
This will cause problems loading images when not using config.baseUrl.
If it is not an absolute url we prepend absRefPrefix.

Resolves: #69516
Releases: master, 6.2
Change-Id: Icfca8bfe50cb5e1816cf73783a09d065d299521a
Reviewed-on: http://review.typo3.org/43157
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
3 years ago[BUGFIX] Prevent information disclosure in file list 88/42588/2
Nicole Cordes [Tue, 2 Jun 2015 14:32:52 +0000 (16:32 +0200)]
[BUGFIX] Prevent information disclosure in file list

Currently the doc header title of a folder shows the full path even
if the current folder is inside a mount point. This patch prevents
showing the full path by not disabling the permission check but catch
a thrown exception and return the path inside the mount point.

Resolves: #67245
Releases: master, 6.2
Change-Id: I6e5486e8c6f923decc4016b57ff60a562f189749
Reviewed-on: http://review.typo3.org/42588
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
3 years ago[BUGFIX] DBAL: Fix quoting of single quotes in WHERE values for MSSQL 48/43148/2
Morton Jonuschat [Fri, 21 Aug 2015 08:42:47 +0000 (10:42 +0200)]
[BUGFIX] DBAL: Fix quoting of single quotes in WHERE values for MSSQL

MSSQL escapes single quotes in values by doubling them. When parsing the
WHERE clause DBAL removed the escaping without performing the required
escaping of the values when compiling the query. This is fixed by adding
a special handling of MSSQL in _quoteWhereClause().

Resolves: #27760
Releases: master, 6.2
Change-Id: I9b8f4fa6ab6e47bd44e6998ee3a492468713cbf0
Reviewed-on: http://review.typo3.org/43148
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Catch exceptions during extension update check 46/43146/2
Nicole Cordes [Tue, 28 Jul 2015 14:05:02 +0000 (16:05 +0200)]
[BUGFIX] Catch exceptions during extension update check

For each extension the available update versions are checked. This
also tries to resolve the extension version dependencies according to
the current system. There might be updates which collide and
exceptions are thrown. This patch catches thrown exceptions as the
update check shouldn't break the Extension Manager.

Resolves: #68585
Releases: master, 6.2
Change-Id: Idc1ed32304dc71dbfe722b3f2c32664f9928cb36
Reviewed-on: http://review.typo3.org/43146
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[TASK] Set TYPO3 version to 6.2.16-dev 24/43124/2
TYPO3 Release Team [Tue, 8 Sep 2015 09:08:55 +0000 (11:08 +0200)]
[TASK] Set TYPO3 version to 6.2.16-dev

Change-Id: Iec10a16f466deb17ec9d5b5d7b87e2850a7c6944
Reviewed-on: http://review.typo3.org/43124
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
3 years ago[RELEASE] Release of TYPO3 6.2.15 23/43123/2 6.2.15 TYPO3_6-2-15
TYPO3 Release Team [Tue, 8 Sep 2015 09:07:15 +0000 (11:07 +0200)]
[RELEASE] Release of TYPO3 6.2.15

Change-Id: I16cee63a4ae922bb6e25548c144b52e92d0b159c
Reviewed-on: http://review.typo3.org/43123
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
3 years ago[SECURITY] Fix GeneralUtility::sanitizeLocalUrl to detect foreign schemes 21/43121/2
Nicole Cordes [Tue, 8 Sep 2015 08:57:47 +0000 (10:57 +0200)]
[SECURITY] Fix GeneralUtility::sanitizeLocalUrl to detect foreign schemes

This patch adds a check to be able to recognize arbitrary schemes which
have to be skipped.

Resolves: #68825
Releases: master, 6.2
Security-Bulletin: TYPO3-CORE-SA-2015-009
Change-Id: I9f98c5730f255f9cb391f0d716457b56e5c3c3a3
Reviewed-on: http://review.typo3.org/43121
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[SECURITY] Prevent information disclosure in tests bootstrap 20/43120/2
Nicole Cordes [Tue, 8 Sep 2015 08:56:16 +0000 (10:56 +0200)]
[SECURITY] Prevent information disclosure in tests bootstrap

Both, the UnitTestsBootstrap and FunctionalTestsBootstrap set
display_errors to 1 which shows errors and warnings by default. If you
call those scripts within web context the files can't be loaded and the
error message shows the website root path. The patch adds proper checks
before files are loaded and exits if an error occurs.

Resolves: #67900
Releases: 6.2
Security-Bulletin: TYPO3-CORE-SA-2015-008
Change-Id: I1e294bcd2f6cd7c2a32f54a890ca2d4a869c9fda
Reviewed-on: http://review.typo3.org/43120
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[FOLLOWUP][BUGFIX] Reestablish DB connection in long-running tasks 03/43103/2
Markus Klein [Thu, 27 Aug 2015 17:07:04 +0000 (19:07 +0200)]
[FOLLOWUP][BUGFIX] Reestablish DB connection in long-running tasks

Reconnecting in isConnected() is not necessary as the next query() will
check the status and reconnect properly if required. Using ping() does
not work with mysqlnd - only if mysqli.reconnect=1 is set. Setting this
is bad practice since a ping() would only reconnect but not properly
reinitialize the charset etc.

Thus a check in Install Tool is added to make sure mysqli.reconnect is
set to "0".

Resolves: #69001
Resolves: #69289
Releases: master, 6.2
Change-Id: I3c2cac91e96fdee8bff113f848341856ec51829b
Reviewed-on: http://review.typo3.org/43103
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Remove wrong datasets in sanitizeLocalUrlValidPathsDataProvider 96/43096/2
Nicole Cordes [Mon, 7 Sep 2015 13:29:01 +0000 (15:29 +0200)]
[TASK] Remove wrong datasets in sanitizeLocalUrlValidPathsDataProvider

Within the GeneralUtilityTest::sanitizeLocalUrlValidPathsDataProvider
are still wrong dataset unfortunately. As on Windows systems the
GeneralUtility::getIndpEnv('TYPO3_SITE_URL') results in
http://D:/AbsolutePathToTypo3Installation those test were moved to an
own DataProvider which makes sure the HTTP_HOST and SCRIPT_NAME are set
correctly before calling GeneralUtility::getIndpEnv().

Resolves: #69584
Releases: master, 6.2
Change-Id: I42e5ab3712f82f5cadd51a478769bc5cb184243f
Reviewed-on: http://review.typo3.org/43096
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Cache CategoryRegistry state together with TCA 70/43070/4
Alexander Stehlik [Wed, 2 Sep 2015 21:14:28 +0000 (23:14 +0200)]
[BUGFIX] Cache CategoryRegistry state together with TCA

The CategoryRegistry is stored together with the final TCA in
the cache.

This is needed because the registry is filled during the initial
build of the TCA and not when the TCA is loaded from the cache.

Resolves: #67881
Releases: master, 6.2
Change-Id: Ic7f341a1710cafbc1a1ea150e003d3d7a7b9c458
Reviewed-on: http://review.typo3.org/43070
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
3 years ago[BUGFIX] Prevent search upload folder in write protected storages 61/43061/2
Nicole Cordes [Tue, 25 Aug 2015 10:10:17 +0000 (12:10 +0200)]
[BUGFIX] Prevent search upload folder in write protected storages

If a storage is marked as non-writeable there isn't any possibility to
have an upload folder in there. So this storage should be skipped in the
lookup of the default upload folder of an user.

Resolves: #69303
Releases: master, 6.2
Change-Id: If53b5545a6af6aa1d333d48bb0856a5de070fd2d
Reviewed-on: http://review.typo3.org/43061
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
3 years ago[BUGFIX] BackendUtility::getAjaxUrl() should not be internal 48/43048/2
Francois Suter [Fri, 4 Sep 2015 14:53:43 +0000 (16:53 +0200)]
[BUGFIX] BackendUtility::getAjaxUrl() should not be internal

In some contexts it is necessary to get the URL of an AJAX handler
on the PHP side. Thus method
\TYPO3\CMS\Backend\Utility\BackendUtility::getAjaxUrl()
should not be marked as internal.

Resolves: #69537
Releases: 6.2, master
Change-Id: Ic69a309b2c6fa02c6581cb7a8e8c68807f684b04
Reviewed-on: http://review.typo3.org/43048
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Support packages depending on typo3/cms 47/43047/2
Mathias Brodala [Fri, 20 Mar 2015 14:07:06 +0000 (15:07 +0100)]
[BUGFIX] Support packages depending on typo3/cms

This adds "typo3/cms" to the list of non composer requirements to allow
packages to depend on it (and thus install the core through Composer) and still
be installable in the Extension Manager.

Resolves: #65867
Releases: master, 6.2
Change-Id: I8564f8dff000fa71876c01343411a3155e0c0c92
Reviewed-on: http://review.typo3.org/43047
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
3 years ago[BUGFIX] Enable page tree filter for admin with mountpoints 18/43018/2
Nicole Cordes [Fri, 14 Aug 2015 14:17:45 +0000 (16:17 +0200)]
[BUGFIX] Enable page tree filter for admin with mountpoints

The patch prevents the mountpoint processing during page tree filtering
for admin users. This is necessary because admin users aren't limited
to the mountpoints. Otherwise sites outside the mountpoints aren't
found anymore.

Resolves: #69063
Releases: master, 6.2
Change-Id: Ie55dcc3b05463deaf57ba42c91e229225176be8a
Reviewed-on: http://review.typo3.org/43018
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
3 years agoRevert "[BUGFIX] Fix broken link to security resources page on typo3.org" 91/42991/2
Helmut Hummel [Thu, 3 Sep 2015 07:06:14 +0000 (09:06 +0200)]
Revert "[BUGFIX] Fix broken link to security resources page on typo3.org"

This URL change on typo3.org had bigger impact and was reverted.
Revert this back here as well.

This reverts commit d92f3ef2c8b297069a2edc2b265e281686363f13.

Change-Id: Ic75ed47edcca9bfff3af6595af02bc81fe6a14c0
Reviewed-on: http://review.typo3.org/42991
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
3 years ago[BUGFIX] Streamline Unit Tests for GeneralUtility::sanitizeLocalUrl 88/42988/2
Nicole Cordes [Wed, 2 Sep 2015 13:06:12 +0000 (15:06 +0200)]
[BUGFIX] Streamline Unit Tests for GeneralUtility::sanitizeLocalUrl

Currently the Unit Tests for the function just work by accident. As
HTTP_HOST an absolute path is set which is used to get some other values
to compare the given strings. To add further tests we should streamline
the tests and set/add expectations for host and script_name.

Resolves: #69475
Releases: master, 6.2
Change-Id: If139da7bd22c1ebf2c538cd3412fb0abf56dc668
Reviewed-on: http://review.typo3.org/42988
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
3 years ago[BUGFIX] Abstract XSD generator can handle more than two namespace parts 78/42978/2
Helmut Hummel [Tue, 1 Sep 2015 20:10:56 +0000 (22:10 +0200)]
[BUGFIX] Abstract XSD generator can handle more than two namespace parts

The getTagNameForClass method in the abstract XSD generator class
could not handle class names with more than two namespace parts.

This caused e.g. TYPO3\CMS\Fluid\ViewHelpers\Be\Buttons\CshViewHelper to
not be transformed to "be.buttons.csh", but just "be.", which in turn
caused duplicate id errors in the resulting XSD document.

Make the code aware of more than two namespace parts.

Releases: master, 6.2
Resolves: #69463
Change-Id: I9a6a28b470679e7487f0d83a7ce9f267a1f3ec7f
Reviewed-on: http://review.typo3.org/42978
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
3 years ago[TASK] Do not set application context by default in htaccess 43/42943/2
Harry Glatz [Mon, 31 Aug 2015 13:40:09 +0000 (15:40 +0200)]
[TASK] Do not set application context by default in htaccess

Since the Production context is the default if no context is set
via environment variables, we do not forcefully set
the context in template .htaccess either.

This allows to set the context via webserver configuration
without the need to touch the lines in the .htaccess file.

Resolves: #69434
Releases: master, 6.2
Change-Id: I70915c51479c91c0db22c7637e46cb1c0fae2db4
Reviewed-on: http://review.typo3.org/42943
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
3 years ago[BUGFIX] Use single postProcessor layout, otherwise the global layout 26/42926/4
Ralf Zimmermann [Sat, 29 Aug 2015 14:57:47 +0000 (16:57 +0200)]
[BUGFIX] Use single postProcessor layout, otherwise the global layout

Resolves: #60995
Releases: master, 6.2
Change-Id: Ifcd3dfd9986684f95ab5574a190c4c8b215d0908
Reviewed-on: http://review.typo3.org/42926
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[TASK] Refactor PostProcessorTest to use Prophecy 29/42929/2
Anja Leichsenring [Sun, 30 Aug 2015 12:28:07 +0000 (14:28 +0200)]
[TASK] Refactor PostProcessorTest to use Prophecy

In order to get rid of the mocking of the system under test, the
tests of ext:form PostProcessorTest are refactored to use
Prophecy. This step precedes the addition of other tests for
the class.

Change-Id: I1a2e9c5305c070f291b549965360abcfb8a695d0
Resolves: #69407
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/42929
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[TASK] Remove eval() in ext:form Unit Tests 28/42928/3
Wouter Wolters [Sun, 30 Aug 2015 12:07:59 +0000 (14:07 +0200)]
[TASK] Remove eval() in ext:form Unit Tests

This partly back-ports the changes of issue #67664 to
remove eval() calls in uni tests. This change affects
only the ext:form tests.

Related: #67664
Resolves: #69412
Releases: 6.2
Change-Id: Ie31a3487aa1126d6f43032f8f8242370c3704610
Reviewed-on: http://review.typo3.org/42928
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[BUGFIX] Add icon for the form wizard number spinner elements 25/42925/2
Björn Jacob [Fri, 28 Aug 2015 16:22:45 +0000 (18:22 +0200)]
[BUGFIX] Add icon for the form wizard number spinner elements

Instead of using images/form/trigger.gif as background image for
the form wizard number spinner elements, this patch introduces a new icon
which shows the real functionality of the spinner element (up/down).

Resolves: #69398
Releases: master, 6.2
Change-Id: I608a8e4fee92978a23cedabd1c51800c8a22dfc0
Reviewed-on: http://review.typo3.org/42925
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[BUGFIX] Fatal Error due to class object inconsistencies in ext:form 24/42924/2
Oliver Hader [Sat, 29 Aug 2015 17:15:15 +0000 (19:15 +0200)]
[BUGFIX] Fatal Error due to class object inconsistencies in ext:form

Elements in the form wizard can either be defined by TypoScript or
by using the accordant wizard. Some of these elements don't have a
counterparts in the ExtJS form wizard and thus only work in the
TypoScript mode. In these cases, the missing JSON conversion
objects lead to fatal errors.

Resolves: #69399
Releases: master, 6.2
Change-Id: Ide39afcbdc483dc01d9cdc9165c89c34785f847d
Reviewed-on: http://review.typo3.org/42924
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[FOLLOWUP][TASK] Add unit test for fatal error on null object method call 23/42923/2
Anja Leichsenring [Sat, 29 Aug 2015 15:01:23 +0000 (17:01 +0200)]
[FOLLOWUP][TASK] Add unit test for fatal error on null object method call

some ::class calls were accidently backported and caused the unit tests
to fail.

Change-Id: I9072fccddae7072011ba62c2981cdf2e7d4faa08
Resolves: #69408
Relates: #69405
Releases: 6.2
Reviewed-on: http://review.typo3.org/42923
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[TASK] Add unit test for fatal error on null object method call 22/42922/2
Anja Leichsenring [Sat, 29 Aug 2015 12:27:20 +0000 (14:27 +0200)]
[TASK] Add unit test for fatal error on null object method call

With #45685 a bugfix was merged. Now the corresponding
unit test is added as well.

Change-Id: Id62c4c7a29d2e28847381c18e963cb834e35fa01
Resolves: #69405
Relates: #45685
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/42922
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[BUGFIX] Fix broken link to security resources page on typo3.org 17/42917/2
Wouter Wolters [Fri, 28 Aug 2015 18:44:10 +0000 (20:44 +0200)]
[BUGFIX] Fix broken link to security resources page on typo3.org

Resolves: #69400
Releases: master,6.2
Change-Id: I277aee582c4b9158ded7a2227abd170ad81c96b9
Reviewed-on: http://review.typo3.org/42917
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[BUGFIX] avoid Call to a member function getValue() on a non-object 16/42916/2
Ralf Zimmermann [Thu, 20 Aug 2015 13:30:18 +0000 (15:30 +0200)]
[BUGFIX] avoid Call to a member function getValue() on a non-object

Prevents calling a method of a non-existent object.

If an attribute is not set via Typoscript no object for the attribute
is instantiated. It must be checked if the attribute exists before
calling it.

Resolves: #45685
Releases: 6.2, master
Change-Id: Ia36052060b82d543b22fb9c0da61623f9d09bd07
Reviewed-on: http://review.typo3.org/42916
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[TASK] Use https for links to docs.typo3.org 09/42909/3
Georg Ringer [Fri, 28 Aug 2015 14:38:21 +0000 (16:38 +0200)]
[TASK] Use https for links to docs.typo3.org

As docs.typo3.org switched to https, all links should be updated
as well.

Resolves: #69239
Releases: 6.2

Change-Id: Ie533be93d8541cd2de897334093850fa21992d02
Reviewed-on: http://review.typo3.org/42909
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Form NumberFields ignore typed values in wizard 11/42911/2
Sebastian Wagner [Thu, 27 Aug 2015 19:37:29 +0000 (21:37 +0200)]
[BUGFIX] Form NumberFields ignore typed values in wizard

"Spinner fields" in EXT:form are an old remake of the HTML5
number in ExtJS. Directly typing a value into that spinner
field is not stored - only by clicking the accordant buttons
to "spinup" or "spindown" the value.

A listener for the blur event handles this task and now allows
to store typed numbers as well. The event handler utilizes the
blur event to update the value - thus, the disabled onBlur
handling has to be disabled as well.
Using the change event did not work out due to ExtJS constraints.

Resolves: #69024
Releases: master, 6.2
Change-Id: I13264019c3edbfb8aa7051a4ae2e3ce91dd5c7f6
Reviewed-on: http://review.typo3.org/42895
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-on: http://review.typo3.org/42911

3 years ago[BUGFIX] IMAGEBUTTON src attribute not working 07/42907/2
Ralf Zimmermann [Thu, 27 Aug 2015 16:58:27 +0000 (18:58 +0200)]
[BUGFIX] IMAGEBUTTON src attribute not working

Render the IMAGEBUTTON "src" attribute as IMG_RESOURCE
but only the IMG_RESOURCE.file property for security reason.

Resolves: #69372
Releases: master, 6.2
Change-Id: Ic7f3eea9a5c43dc5c7254ce0fd7d6f21db445d4f
Reviewed-on: http://review.typo3.org/42907
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[BUGFIX] Form Wizard does not respect backend debug mode 87/42887/2
Oliver Hader [Thu, 27 Aug 2015 11:23:12 +0000 (13:23 +0200)]
[BUGFIX] Form Wizard does not respect backend debug mode

Form Wizard does not respect backend debug mode in
$GLOBALS['TYPO3_CONF_VARS']['BE']['debug']. The hardcoded
compression and concatenation is removed by this change.

Resolves: #69353
Releases: master, 6.2
Change-Id: I78aa7f67a8c813fd0208e77b432829fceeb7aa6b
Reviewed-on: http://review.typo3.org/42887
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[BUGFIX] Always use uc_default after first install 48/42848/2
Jigal van Hemert [Mon, 20 Apr 2015 18:54:54 +0000 (20:54 +0200)]
[BUGFIX] Always use uc_default after first install

If the Install Tool sets the start module on first login to allow the
installation of a distribution the uc_default settings must still be
applied. A special temporary setting by the Install Tool makes it easy
to detect this situation.

Change-Id: I33afcbd80595584767fe70dd972e24b9c43aa763
Resolves: #69138
Releases: 6.2
Reviewed-on: http://review.typo3.org/42848
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Correctly assign workspace for rootline retrieval 67/42867/2
Markus Klein [Tue, 25 Aug 2015 10:55:26 +0000 (12:55 +0200)]
[BUGFIX] Correctly assign workspace for rootline retrieval

Resolves: #69306
Releases: master, 6.2
Change-Id: If59ec36222c1124c2918b39fc014e4c8a2d7bf2f
Reviewed-on: http://review.typo3.org/42867
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] Fix task execution in Scheduler 62/42862/2
Francois Suter [Tue, 25 Aug 2015 08:57:48 +0000 (10:57 +0200)]
[BUGFIX] Fix task execution in Scheduler

Executing a task from the Scheduler is currently broken
in 6.2, due to a wrong backport.

Resolves: #69302
Releases: 6.2
Change-Id: Ib8d2c1d327adc387f262a8f9dcb661671ea98a6a
Reviewed-on: http://review.typo3.org/42862
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[BUGFIX] Replace ###ID### in openCustomUrlInContentFrame correctly 31/42731/5
Christian Seifert [Tue, 18 Aug 2015 20:31:19 +0000 (20:31 +0000)]
[BUGFIX] Replace ###ID### in openCustomUrlInContentFrame correctly

Adding an URL by getModuleUrl including an array having an ID
parameter id=###ID### results in an escaped string.
Instead of "###ID###" the value "%23%23%23ID%23%23%23" is
submitted to the JavaScript function.

This patch fixes the old replacement function.
Now, you can again add click menu items linking to modules and
passing the selected page uid.

Resolves: #69170
Releases: master, 6.2
Change-Id: Ib4c0a1556dd1ed583e8faefe431e2d4eaaf864ad
Reviewed-on: http://review.typo3.org/42731
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Assure a backend domain is set in workspace preview 37/42837/2
Daniel Goerz [Fri, 7 Aug 2015 19:27:44 +0000 (21:27 +0200)]
[BUGFIX] Assure a backend domain is set in workspace preview

Change-Id: Idc17243f8741057ee6ea1746ec6c344aec28d57a
Resolves: #45519
Resolves: #31718
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/42837
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] Don't cut off icons in New Record wizard 36/42836/2
Andreas Fernandez [Fri, 21 Aug 2015 13:05:00 +0000 (15:05 +0200)]
[BUGFIX] Don't cut off icons in New Record wizard

If an icon larger than 16x16 pixels is used for the record icon in TCA,
it gets cutted and only the top left part is displayed. Apply proper
CSS rules to fix this behaviour.

Resolves: #69236
Releases: master, 6.2
Change-Id: I9f7643817f05fd6fba73b7884e70dbed2db84999
Reviewed-on: http://review.typo3.org/42836
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[FOLLOWUP][BUGFIX] Show first tab in Element Wizard as fallback 01/42801/2
Markus Klein [Fri, 21 Aug 2015 07:44:10 +0000 (09:44 +0200)]
[FOLLOWUP][BUGFIX] Show first tab in Element Wizard as fallback

A wrong variable initialization is fixed.

Resolves: #59810
Releases: master, 6.2
Change-Id: Ied65743326e52e7e56e24a19db57ba40f6b4be47
Reviewed-on: http://review.typo3.org/42801
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
3 years ago[BUGFIX] Show first tab in Element Wizard as fallback 99/42799/2
Christian Seifert [Thu, 20 Aug 2015 22:59:29 +0000 (22:59 +0000)]
[BUGFIX] Show first tab in Element Wizard as fallback

Using the extension gridelements it is possible to restrict the
selectable content elements instead of the full menu configured
by TSconfig. At first, you might have 5 menus available and you
click on the last menu tab (maybe the fifth), so the backend
stores 5 as current tab.
Adding content elements within a gridelement, which restricts the
range of selectable CEs, you can only select the first tab (p.e.).
The original code assumes that the fifth tab is still there and
tries to select it.

This patch checks first against the existence of the selected tab.
If there is no "fifth" tab p.e. the index is set to 1.

Resolves: #59810
Releases: master, 6.2
Change-Id: I829489737de4631dfe3362e4fb11909be9315864
Reviewed-on: http://review.typo3.org/42799
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Cache healing for classes loaded via ext_autoload 28/39928/5
Bernhard Kraft [Tue, 2 Jun 2015 14:43:38 +0000 (16:43 +0200)]
[BUGFIX] Cache healing for classes loaded via ext_autoload

Currently classes loaded via an ext_autoload.php will get their cache
generated only after clearing all caches using the install tool "Clear
all caches" button or the red clear cache icon. This patch improves the
situation by taking care of ext_autoload.php files also during normal
processing. There can be edge cases where the classes_cache will not get
properly generated. In such a situation a missing cache entry will cause
"class not found" errors.

There is no performance impact for Production systems (TYPO3_CONTEXT) as
the result of the class lookup will get cached anyways. If a class is
not found via the existing mechanisms or in an ext_autoload.php it will
get cached as "invalid". Of course the class could get loaded by some
other autoload handler afterwards.

Change-Id: Id996139d31f16c6bcb40f286fbf266a87147852d
Resolves: #67246
Releases: 6.2
Reviewed-on: http://review.typo3.org/39928
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] FAL upgrade wizard: take care of files in subfolders 64/42664/2
Josef Glatz [Sun, 16 Aug 2015 18:10:20 +0000 (20:10 +0200)]
[BUGFIX] FAL upgrade wizard: take care of files in subfolders

Enable migrating files from uploads/pics/ subdirectories to FAL.

Change-Id: Ife160dd03633dc1da542cad990be3cd166cc1636
Releases: 6.2
Resolves: #69112
Reviewed-on: http://review.typo3.org/42664
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
3 years ago[BUGFIX] Fix QueryBuilding in IndexSearchRepository 70/42670/2
Marc Neuhaus [Mon, 3 Aug 2015 11:45:57 +0000 (13:45 +0200)]
[BUGFIX] Fix QueryBuilding in IndexSearchRepository

This changeset fixes an issue in the indexSearchRepository that creates
invalid sql queries. Main issue is the missing of several wSelClauses,
that need to be collected, because they are imploded into the query.

Resolves: #67843
Releases: master, 6.2
Change-Id: Ib53b28660acfd92233de748431131f70e69f5125
Reviewed-on: http://review.typo3.org/42219
Reviewed-on: http://review.typo3.org/42670
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Marc Neuhaus <apocalip@gmail.com>
Tested-by: Marc Neuhaus <apocalip@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Log exception as array instead of serialized 36/42736/2
Stephan Großberndt [Tue, 18 Aug 2015 14:54:05 +0000 (16:54 +0200)]
[BUGFIX] Log exception as array instead of serialized

Log exceptions thrown by scheduler tasks as array instead of
serializing the whole exception in order to keep the size down.

Resolves: #69157
Releases: master, 6.2
Change-Id: Ifc6457f3de114779a522baa77443e5019f0dc4c1
Reviewed-on: http://review.typo3.org/42736
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Exclude computed field names on fetching record overlays 58/42158/5
Albrecht Köhnlein [Fri, 31 Jul 2015 08:12:23 +0000 (10:12 +0200)]
[BUGFIX] Exclude computed field names on fetching record overlays

During versioning, the dynamic fields _ORIG_pid and _ORIG_uid are added
to $row, but they do not exist in database and cause an SQL error.

Resolves: #68643
Releases: master, 6.2
Change-Id: I33a56b2071a04b5224821805e60722ce8dd3dd14
Reviewed-on: http://review.typo3.org/42158
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 years ago[BUGFIX] Assure language override without original file 94/42694/5
Stefan Galinski [Wed, 4 Mar 2015 14:50:20 +0000 (15:50 +0100)]
[BUGFIX] Assure language override without original file

The language override of language files is currently broken,
because it only works if a localized language file already
exists inside the extension or l10n directory. This patch assures
that the language override takes place even if no file could
be found in the first place.

Resolves: #65513
Releases: master, 6.2
Change-Id: I9269e60c5788c435b06b820c459fd4f077d066ea
Reviewed-on: http://review.typo3.org/42694
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Extbase: Optional arguments must not throw an Exception 63/42663/2
Anja Leichsenring [Sun, 16 Aug 2015 16:45:32 +0000 (18:45 +0200)]
[BUGFIX] Extbase: Optional arguments must not throw an Exception

Example:
public function barAction(\Vendor\Ext\Domain\Model\Foo $foo = NULL)

If the property mapper receives NULL, 0 or a valid value
the property mapping does not fail. But if the value is
a valid uid (>0) and there is no record with that uid
the whole property mapping fails.

While this is totally valid for required arguments,
optional arguments must be skipped.

Resolves: #55861
Resolves: #55837
Resolves: #62951
Releases: master, 6.2
Change-Id: I4c954bac50be1d34ea09bfc21f8978e9165683d1
Reviewed-on: http://review.typo3.org/42663
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 years ago[BUGFIX] Reestablish DB connection in long-running tasks 65/42665/2
Stefan Neufeind [Wed, 12 Aug 2015 18:31:33 +0000 (20:31 +0200)]
[BUGFIX] Reestablish DB connection in long-running tasks

During a long-running task the connection to the database may be
disconnected, if mysql `wait_timeout` is exceeded. This patch makes
sure the connection is reestablished if there has been a connection
before.

Resolves: #69001
Releases: master, 6.2
Change-Id: I7575ae386ec190d60ddceee146133125083dee41
Reviewed-on: http://review.typo3.org/42665
Reviewed-by: Josef Glatz <jousch@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 years ago[BUGFIX] Prevent error if getimagesize() fails 49/42649/2
Stefan Neufeind [Sat, 15 Aug 2015 16:48:25 +0000 (18:48 +0200)]
[BUGFIX] Prevent error if getimagesize() fails

Upon failure getimagesize() returns FALSE instead of image-dimensions.
Handle that case cleanly.

Change-Id: I8dcd98c842aaa01f572002a6e9c86ea889de6b1b
Resolves: #59528
Releases: 6.2
Reviewed-on: http://review.typo3.org/42649
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Fix dependencies for t3x upload 42/42642/3
Helmut Hummel [Fri, 14 Aug 2015 16:03:02 +0000 (18:03 +0200)]
[BUGFIX] Fix dependencies for t3x upload

When extracting the t3x archive, the EM_CONF data is taken to
create a new ext_emconf.php file.
An already extracted ext_emconf.php file is overwritten in this process.

Since those t3x files are created by TER server and this TER server
does not include the extension constraints in this array,
all constraints are lost in this process.

To fix this, it is needed to use a present ext_emconf.php file
and merge the meta properties with its properties to construct
the final ext_emconf.php.

Resolves: #69070
Releases: master, 6.2
Change-Id: I3997bee05f256a3ff23f0eee516ecf0a323017c3
Reviewed-on: http://review.typo3.org/42642
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[TASK] Properly encode database input in the right place 61/42661/2
Helmut Hummel [Fri, 14 Aug 2015 13:45:15 +0000 (15:45 +0200)]
[TASK] Properly encode database input in the right place

This adds code that prevents potential SQL injections.
The core is not exploitable, as cleaning is done in other code parts.

Resolves: #69061
Releases: master, 6.2
Change-Id: Iba42adc6dd4abd3976b57f1dc84ba6585ea7bbd4
Reviewed-on: http://review.typo3.org/42661
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[BUGFIX] Remove trailing colons from checkbox labels 60/42660/2
Daniel Goerz [Sun, 16 Aug 2015 11:09:17 +0000 (13:09 +0200)]
[BUGFIX] Remove trailing colons from checkbox labels

Change-Id: I4339ad96c4fa8efabd8c99e7de1cdebae3a1d76b
Resolves: #69092
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/42660
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Add encodeURIComponent to search parameter 91/42591/2
Stephan Großberndt [Thu, 13 Aug 2015 16:00:13 +0000 (18:00 +0200)]
[BUGFIX] Add encodeURIComponent to search parameter

Encode search parameter to encode special characters

Resolves: #68400
Releases: master, 6.2
Change-Id: I991fd7c3855dbefd152792eb8888f09b3f22f597
Reviewed-on: http://review.typo3.org/42591
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Illegal string offset 'currentLangId' in DataHandler 41/42641/2
Joerg Kummer [Fri, 14 Aug 2015 13:04:17 +0000 (15:04 +0200)]
[BUGFIX] Illegal string offset 'currentLangId' in DataHandler

Avoid PHP warning on save CE plugin with empty </meta> element in flexform

Resolves: #69056
Releases: master,6.2
Change-Id: Ibbbebe3745b2a8bb793d5cc0b799b98ad69d0223
Reviewed-on: http://review.typo3.org/42641
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[BUGFIX] Fix PHP Warning in updateRefIndexTable() 40/42640/2
Stephan Großberndt [Thu, 13 Aug 2015 17:50:35 +0000 (19:50 +0200)]
[BUGFIX] Fix PHP Warning in updateRefIndexTable()

This patch fixes a PHP Warning occurring if
ReferenceIndex::updateRefIndexTable() is called with a tableName of a
table without a TCA definition.

Resolves: #68503
Releases: master, 6.2
Change-Id: I2fd755703199a4d76ef29082e9306833a18be130
Reviewed-on: http://review.typo3.org/42640
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Retrieve correct fieldname for condition lookup 96/42496/2
Benjamin Serfhos [Tue, 11 Aug 2015 06:36:35 +0000 (08:36 +0200)]
[BUGFIX] Retrieve correct fieldname for condition lookup

DisplayCond for sheets in flexforms should allow extbase
parameters, eg: "settings.data".

Resolves: #68493
Related-to: If5e5c3396972758a022f67606670892327e0d180
Releases: 6.2
Change-Id: I46e36804878f3681bfba973ec1cf831d54df1ead
Reviewed-on: http://review.typo3.org/42496
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Calculations in GIFBUILDER properties using stdWrap fail 39/42639/2
Dan Untenzu [Mon, 21 Oct 2013 12:13:39 +0000 (14:13 +0200)]
[BUGFIX] Calculations in GIFBUILDER properties using stdWrap fail

Unset each existing TypoScript subarray of all properties
with calculations (offset,dimensions,set,…) in GIFBUILDER.
Do this to prevent the double execution of stdWrap,
which would cause those properties to return uncalculated
and therefore wrong values afterwards.

Resolves: #53002
Releases: master, 6.2
Change-Id: Ib9a6ede30988acad25df8fcca811475c19e77b09
Reviewed-on: http://review.typo3.org/42639
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Prevent ResourceDoesNotExistException 94/42594/2
Andre Hähnel [Fri, 9 Jan 2015 13:47:40 +0000 (14:47 +0100)]
[BUGFIX] Prevent ResourceDoesNotExistException

An exception is thrown if the show info popup is opened by sys_file uid
for a file which does not exist anymore in filestorage.

This change marks the file as missing so no exception is thrown in
ElementInformationController but a error message is shown to the user
about the missing file.

Resolves: #64214
Releases: master, 6.2
Change-Id: I460013e21db149760a1b391d9cdbd68b6530d190
Reviewed-on: http://review.typo3.org/42594
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
4 years ago[BUGFIX] EM: Trim whitespace in search field 11/42611/3
Alexander Opitz [Fri, 14 Aug 2015 10:12:29 +0000 (12:12 +0200)]
[BUGFIX] EM: Trim whitespace in search field

Leading and trailing whitespaces are now trimmed before the TER is inquired.

Resolves: #69040
Releases: master, 6.2
Change-Id: Iabb641e276358f76732673efb3a23b13d63ac144
Reviewed-on: http://review.typo3.org/42611
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[BUGFIX] Make editIconsHook work again 89/42589/2
Nicole Cordes [Mon, 13 Jul 2015 09:40:06 +0000 (11:40 +0200)]
[BUGFIX] Make editIconsHook work again

It isn't possible to add icons in filelist extended view easily,
because there is no way to get the current file or folder object nor get
information about it. This patch adds the object to the cells variable
and reset it after hook execution to ensure access to it.

Releases: master, 6.2
Resolves: #67962
Change-Id: I44a4229128bcfdb2ed17900462f50a771ed63fdd
Reviewed-on: http://review.typo3.org/42589
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[BUGFIX] Allow subclasses of \DateTime as entity properties 90/42590/2
Stephan Schuler [Wed, 13 May 2015 13:05:35 +0000 (15:05 +0200)]
[BUGFIX] Allow subclasses of \DateTime as entity properties

When a class "\MyCustomDateTime extends \DateTime", the data mapper
creates "\DateTime" objects instead when mapping database results.
This patch uses the class annotation to resolve the class to create.

Resolves: #66939
Releases: master, 6.2
Change-Id: I45062d4d1a44333016258289ea9e2026d9923f70
Reviewed-on: http://review.typo3.org/42590
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
4 years ago[BUGFIX] Draft usergroup access rights are now respected 53/42553/3
Bart Dubelaar [Fri, 27 Jan 2012 10:28:31 +0000 (11:28 +0100)]
[BUGFIX] Draft usergroup access rights are now respected

Adding usergroup access rights to a page in a draft workspace had no
effect on the preview, the page was still shown in menus. The other way
around didn't work either. Removing access rights would not make the page
available. Previewing wasn't possible at all.

This behavior is fixed. All draft usergroup changes are now respected
when previewing.

Releases: master, 6.2
Resolves: #33436
Change-Id: Ib9a74e98d6ed7457849465fc64685f89ed82fb61
Reviewed-on: http://review.typo3.org/42553
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
4 years ago[BUGFIX] Edits disappear when published twice 92/42592/2
Stefan Rotsch [Fri, 10 Jan 2014 09:34:38 +0000 (10:34 +0100)]
[BUGFIX] Edits disappear when published twice

When accidentally publishing an edit twice, eg. by using multiple
browser tabs, all modifications are reverted and the changes are no
longer visible in the workspace.

In the database, the old workspace version of the record has wsid = 0
and pid = -1 and is thus invisible, but still contains the modified
content.

Resolves: #54924
Releases: master, 6.2
Change-Id: I8805737540f030ae24331d33590b71629c7f3179
Reviewed-on: http://review.typo3.org/42592
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
4 years ago[BUGFIX] Use proper data sets in workspaces tests 96/42596/2
Oliver Hader [Thu, 13 Aug 2015 17:03:11 +0000 (19:03 +0200)]
[BUGFIX] Use proper data sets in workspaces tests

Some field values are not correct in the initial scenario
definition for the workspaces functional tests. The faulty
behavior can only be determined if MySQL is working in
strict mode.

Resolves: #69027
Releases: master, 6.2
Change-Id: I12f1dc8d6fbd479b46749062be5d24075c0f2b6d
Reviewed-on: http://review.typo3.org/42596
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 years ago[BUGFIX] Fix wrong comment in install tool for [HTTP][proxy_host] 93/42593/2
Frank Nägler [Thu, 6 Aug 2015 09:08:11 +0000 (11:08 +0200)]
[BUGFIX] Fix wrong comment in install tool for [HTTP][proxy_host]

Resolves: #62340
Releases: master, 6.2
Change-Id: I20554a255141ba2f49f0632404957eaf320cee7b
Reviewed-on: http://review.typo3.org/42593
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
4 years ago[BUGFIX] Fix faulty move-placeholder processing with workspaces 73/42573/2
Artur Cichosz [Tue, 28 Jul 2015 17:13:18 +0000 (19:13 +0200)]
[BUGFIX] Fix faulty move-placeholder processing with workspaces

Fix a possibly faulty condition based on a comparison of boolean
with integer (TRUE >= 2) which always results in TRUE.
To avoid this, an additional integer test for the first
part of the condition statement has been added.

Resolves: #68494
Releases: master, 6.2
Change-Id: Icf7b55532483e6a315b93c001ddf41f1caf3a7f8
Reviewed-on: http://review.typo3.org/42573
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 years ago[BUGFIX] Catch exceptions for inaccessible storages 17/42017/5
Philipp Gampe [Sun, 1 Feb 2015 10:46:51 +0000 (11:46 +0100)]
[BUGFIX] Catch exceptions for inaccessible storages

A storage might be (temporary or permanently) not available in the
current file system. Then it should be displayed as inaccessible
(offline).
Catch all exceptions while trying to fetch permissions for any related
folders.
Only display paste icons for browsable storages.

Resolves: #64714
Releases: master, 6.2
Change-Id: I803d1d2dad919fefebf9b37c60b40a7a440bc6d5
Reviewed-on: http://review.typo3.org/42017
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Catch exception when linked file is deleted 49/42549/3
Benjamin Mack [Wed, 12 Aug 2015 20:05:47 +0000 (22:05 +0200)]
[BUGFIX] Catch exception when linked file is deleted

If a file is linked in the RTE and the file is deleted afterwards
an exception is thrown thus making it impossible to change
the link.

Instead the popup shows up without selecting anything.

Resolves: #66624
Releases: master, 6.2
Change-Id: Iec985b0202002a2c906b4cee43cd4e27e496d4fb
Reviewed-on: http://review.typo3.org/42549
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 years ago[BUGFIX] Consider placeholders in fixVersioningPid 48/42548/2
Timo Webler [Wed, 11 Sep 2013 13:43:25 +0000 (15:43 +0200)]
[BUGFIX] Consider placeholders in fixVersioningPid

Method fixVersioningPid does not analyze the new location for an element.
Check for a move placeholder to get the new location.
Same behavior as in frontend.
See \TYPO3\CMS\Frontend\Page\PageRepository::fixVersioningPid

Resolves: #51913
Releases: master, 6.2
Change-Id: I08a8eab714ec1530f3c655f0440c98342120e328
Reviewed-on: http://review.typo3.org/42548
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 years ago[BUGFIX] Capability check fails for some storage types 47/42547/2
Benjamin Mack [Wed, 12 Aug 2015 19:37:15 +0000 (21:37 +0200)]
[BUGFIX] Capability check fails for some storage types

The check should only complain if a user wants to mark a storage as
public and the driver does not support that. This commit changes the
check accordingly.

Change-Id: Id5d029dbbb2c99b373af9ff41aa6dd4a40d70764
Releases: master, 6.2
Resolves: #67284
Reviewed-on: http://review.typo3.org/42547
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 years ago[BUGFIX] Set background for disabled input fields 46/39746/4
Andreas Fernandez [Tue, 26 May 2015 14:28:59 +0000 (16:28 +0200)]
[BUGFIX] Set background for disabled input fields

Set a proper background color for disabled input fields.

Resolves: #67145
Releases: 6.2
Change-Id: I4c2e57357ffc882635545b5a5706d9f0f2262ba8
Reviewed-on: http://review.typo3.org/39746
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 years ago[FOLLOWUP][BUGFIX] Provide title label for paste into column 57/42457/2
Anja Leichsenring [Sun, 9 Aug 2015 12:15:29 +0000 (14:15 +0200)]
[FOLLOWUP][BUGFIX] Provide title label for paste into column

Backport introduced a new locallang file that did not belong.

Change-Id: I62bb7610c2366fd593d872c93824853f8b2f192e
Releases: 6.2
Resolves: #68873
Reviewed-on: http://review.typo3.org/42457
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years agoRevert "[BUGFIX] Fix broken functional tests" 56/42456/2
Anja Leichsenring [Sun, 9 Aug 2015 11:59:12 +0000 (13:59 +0200)]
Revert "[BUGFIX] Fix broken functional tests"

the original patch was never backported to 6.2, sorry for the hassle.

This reverts commit e65f253abfa056827766da247347fb102fb2e53a.

Change-Id: I515c4c896c1f258f675531128093e28174f02aaa
Reviewed-on: http://review.typo3.org/42456
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Fix broken functional tests 53/42453/2
Anja Leichsenring [Sun, 9 Aug 2015 10:06:03 +0000 (12:06 +0200)]
[BUGFIX] Fix broken functional tests

Change-Id: I742c16a2689fd7ec89abf3620a618a99f24779a7
Resolves: #68882
Relates: #68871
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/42453
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Provide title label for paste into column 48/42448/2
Daniel Goerz [Sat, 8 Aug 2015 21:39:52 +0000 (23:39 +0200)]
[BUGFIX] Provide title label for paste into column

Change-Id: Ia01c9083cc0eda52725efdec93106e911884f097
Resolves: #68873
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/42448
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Workspace preview links for multiple languages 17/42417/3
Stefan Rotsch [Wed, 22 Jan 2014 12:30:54 +0000 (13:30 +0100)]
[BUGFIX] Workspace preview links for multiple languages

The workspace preview link will only be generated for one language at
a time, so it might require some effort to generate preview links for
multiple languages.

For convenience of editors, preview links will now be generated for
all available translations of a certain page in a batch.

Resolves: #20852
Resolves: #12970
Releases: master, 6.2
Change-Id: I6de6f2c7b741e238fc373f0756bc29f0100a19f0
Reviewed-on: http://review.typo3.org/42417
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Document required MySQL privileges 82/42382/2
Morton Jonuschat [Fri, 7 Aug 2015 13:11:45 +0000 (15:11 +0200)]
[TASK] Document required MySQL privileges

Add the minimum set of privileges required to run TYPO3 CMS to the
INSTALL.md document.

Add a recommendation for the privileges to manage/use views and
stored procedures.

Resolves: #68734
Releases: master, 6.2
Change-Id: I1472c36133e560df72d1a5412129322df0d2cf95
Reviewed-on: http://review.typo3.org/42382
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Skip write access check if core files exist 78/42378/3
Frederic Gaus [Mon, 20 Jul 2015 12:07:27 +0000 (14:07 +0200)]
[BUGFIX] Skip write access check if core files exist

If updating a TYPO3 instance when the core files are
already present, the CoreUpdateService can skip the
write access check.

Resolves: #68386
Releases: master, 6.2
Change-Id: I7af201d98e43799f4066c74443a1815d9b65cbf0
Reviewed-on: http://review.typo3.org/42378
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Remove php warning for RTE classes without name 67/42367/4
Manuel Selbach [Fri, 7 Aug 2015 10:14:56 +0000 (12:14 +0200)]
[BUGFIX] Remove php warning for RTE classes without name

Check if name within the configuration is set
so that no PHP warning: illigal offset will be thrown

Resolves: #68068
Releases: master,6.2
Change-Id: I781fa237aa696e6e9b03714f8e1aca4124589d5f
Reviewed-on: http://review.typo3.org/42367
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Change value from NULL to empty string for link field in test data 35/42335/2
Marc Bastian Heinrichs [Thu, 6 Aug 2015 21:56:31 +0000 (23:56 +0200)]
[BUGFIX] Change value from NULL to empty string for link field in test data

When increasing max length of link fields the definition for db field link in
table sys_file_reference changed to not NOT NULL. This needs to be adapted
also in the impexp functional test data.

Resolves: #68810
Related: #61944
Releases: master,6.2
Change-Id: I3c518ad865037365793a58c73ff9d1ec539410f2
Reviewed-on: http://review.typo3.org/42335
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 years ago[BUGFIX] Clear affected caches on page publishing 08/42308/3
Bart Dubelaar [Tue, 19 Jun 2012 12:54:45 +0000 (14:54 +0200)]
[BUGFIX] Clear affected caches on page publishing

When publishing a page, the treelist cache should be cleared.
This is fixed by adding a condition that checks for a swap action in
the existing class that hooks into DataHandler and listens for updates to
pages to update the treelist cache.

Change-Id: I0c01450efe9507dcef9f74af626a9ebf3cdc7d4c
Resolves: #37952
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/42308
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Typo in neg_foreign_table in DataPreprocessor 89/42289/2
Andreas Wolf [Wed, 5 Aug 2015 18:38:34 +0000 (20:38 +0200)]
[BUGFIX] Typo in neg_foreign_table in DataPreprocessor

Change-Id: I5f281c99c65a6a3a0d0d527bdd5db02853eb078b
Releases: master, 6.2
Resolves: #68769
Related: #36573
Reviewed-on: http://review.typo3.org/42289
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Do not turn TYPO3 Logo upside down on error pages 43/42243/2
Benjamin Mack [Tue, 4 Aug 2015 11:22:38 +0000 (13:22 +0200)]
[BUGFIX] Do not turn TYPO3 Logo upside down on error pages

Resolves: #68718
Releases: master, 6.2
Change-Id: Ie41426bac4a21e53f423e52fd537e037db18ac4f
Reviewed-on: http://review.typo3.org/42243
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Disallow access to vcs directories 52/42152/2
Philipp Gampe [Wed, 29 Jul 2015 15:34:55 +0000 (17:34 +0200)]
[TASK] Disallow access to vcs directories

Access to vcs directories should be denied by default to avoid leaking
information to the outsite that might have been accidentally committed
to a repository.
This does not effect the core as the version information is public by
license, but any repository containing configuration or third party
extensions.

Resolves: #68626
Releases: master,6.2
Change-Id: I4f3cb88e577f56ac71d882c8b11341da46a8b757
Reviewed-on: http://review.typo3.org/42152
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Call fixPermissions after replaceFile 42/42142/2
Frans Saris [Thu, 30 Jul 2015 12:59:53 +0000 (14:59 +0200)]
[BUGFIX] Call fixPermissions after replaceFile

Resolves: #68642
Releases: master, 6.2
Change-Id: Iec6bf8989cae1fafd2cc909635d980c971af656c
Reviewed-on: http://review.typo3.org/42142
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Invalid handling of "mergeIfNotBlank" in backend 21/42121/2
Christian Kuhn [Wed, 29 Jul 2015 21:22:48 +0000 (23:22 +0200)]
[BUGFIX] Invalid handling of "mergeIfNotBlank" in backend

This is a partial backport of #68592 to fix the title part
in the backend for 6.2 as well.

Change-Id: I56fce644416baf5e26c359c1767bb0569b02cbf4
Resolves: #68624
Related: #68592
Releases: 6.2
Reviewed-on: http://review.typo3.org/42121
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Don't use FAL based ImageViewHelper in extension manager 35/42135/2
Frans Saris [Wed, 29 Jul 2015 20:13:07 +0000 (22:13 +0200)]
[BUGFIX] Don't use FAL based ImageViewHelper in extension manager

Resolves: #68636
Releases: master, 6.2
Change-Id: I15c48447d0226518f0bdf8459295a82e49864306
Reviewed-on: http://review.typo3.org/42135
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Rename setLocale() in DateTimeViewHelperTest 13/42113/2
Andreas Fernandez [Wed, 29 Jul 2015 18:07:00 +0000 (20:07 +0200)]
[BUGFIX] Rename setLocale() in DateTimeViewHelperTest

The method setLocale($locale) in the DateTimeViewHelperTest
was implemented to test against several locales. However,
as there is a setLocale() in the parent class from PHPUnit that
does not take any parameter, PHP7 throws a warning as the
subclass does not have the same method signature as the parent
class.

The patch changes the method to be named differently thus,
solving the method signature conflict inside the test.

Resolves: #67092
Releases: 6.2, master
Change-Id: Ia05d90c64a3a8e2fc599935d2435192392e5a667
Reviewed-on: http://review.typo3.org/42113
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[BUGFIX] Fixed permissions of media field in page properties 70/41670/4
Michael Oehlhof [Wed, 1 Jul 2015 19:14:55 +0000 (21:14 +0200)]
[BUGFIX] Fixed permissions of media field in page properties

It was not possible to add media to the page properties if the user has
only the permissions for "page edit" and not for "page content"..

Resolves: #66702
Releases: master, 6.2
Change-Id: I553ee805a0e992d2ea5e00b91e7de733b2e4c94e
Reviewed-on: http://review.typo3.org/41670
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Show pages with "show at any login" in view module 82/41982/2
Daniel Goerz [Sun, 26 Jul 2015 14:08:14 +0000 (16:08 +0200)]
[BUGFIX] Show pages with "show at any login" in view module

Resolves: #67752
Releases: master, 6.2
Change-Id: I9e8e54012bcfb994e508eae0269493d250cc005a
Reviewed-on: http://review.typo3.org/41982
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Invalid links to documentation 66/41966/2
Xavier Perseguers [Sun, 26 Jul 2015 10:15:56 +0000 (12:15 +0200)]
[BUGFIX] Invalid links to documentation

Resolves: #68540
Releases: master, 6.2
Change-Id: I7e66ab53bb4ec67af5a2b4355d0704e329ea3ea7
Reviewed-on: http://review.typo3.org/41966
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
4 years ago[BUGFIX] dbal: Cast field to CHAR for FIND_IN_SET() 42/41842/2
Morton Jonuschat [Thu, 28 May 2015 17:50:47 +0000 (19:50 +0200)]
[BUGFIX] dbal: Cast field to CHAR for FIND_IN_SET()

Implement explicit casting of fields to a character representation.
Most DBMS are stricter in regard to data type checking and emit an
error when trying to use FIND_IN_SET() on non-text field types.

On the DBAL side of things the DBMS specifics are used to define that
an explicit cast is required for FIND_IN_SET() so that a query including
the CAST() statement gets generated.

A PostgreSQL Specific has been added to enable the explicit casting in
conjuction with DBAL. To avoid checking repeatedly if a DBMS has defined
specific requirements a NullSpecific has been implemented that gets used
as a default.

In the DatabaseTreeDataProvider the listFieldQuery() function has been
changed to use an explicit CAST() instead of relying on the implicit
cast done by MySQL when comparing it to an empty string.

The SqlParser has been extended with the support for CAST().

Resolves: #67155
Resolves: #67172
Resolves: #46271
Releases: master, 6.2
Change-Id: Ic77d1700e0fb4e3723c90b34e131dafb456038e0
Reviewed-on: http://review.typo3.org/39779
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-on: http://review.typo3.org/41842

4 years ago[BUGFIX] Use correct extension name for labels in indexed search 41/41841/3
Markus Klein [Wed, 22 Jul 2015 18:01:09 +0000 (20:01 +0200)]
[BUGFIX] Use correct extension name for labels in indexed search

The extbase implementation of the search form must use extensionName
and not extension_key for retrieving translations.
This ensures that translations from the template are taken into account.

Releases: master, 6.2
Resolves: #68430
Change-Id: Ia2265793b4f57c018ffca5ae5af9feb1cbf94803
Reviewed-on: http://review.typo3.org/41841
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Fix image descriptions for renderMethod = table 10/41810/2
Torben Hansen [Thu, 16 Jul 2015 08:12:07 +0000 (10:12 +0200)]
[BUGFIX] Fix image descriptions for renderMethod = table

Image descriptions are not rendered correctly using
renderMethod = table, since only the description of the
last image is rendered when you have multiple images
in a content object..

This patch loads the current image file reference to the
contentObjectRenderer while looping through all images
in order to output the image descriptions.

Resolves: #68153
Releases: master, 6.2
Change-Id: I273fff90a5ab3a35e6422ca74b6d83b298b9b09d
Reviewed-on: http://review.typo3.org/41810
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Use parse_url to determine absolute urls in ImageService 77/41777/5
Frans Saris [Tue, 21 Jul 2015 11:50:22 +0000 (13:50 +0200)]
[BUGFIX] Use parse_url to determine absolute urls in ImageService

Since it is possible to have protocol relative URIs and parse_url
only identifies a hostname once a scheme or scheme relative prefix is
applied, we can check for a hostname here.

Resolves: #68423
Releases: master, 6.2
Change-Id: I3eb51d9b5175657454657bbd7f75cfafa6bd9760
Reviewed-on: http://review.typo3.org/41777
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>