Packages/TYPO3.CMS.git
3 years ago[RELEASE] Release of TYPO3 6.2.17 85/45385/2 6.2.17 TYPO3_6-2-17
TYPO3 Release Team [Mon, 21 Dec 2015 10:58:10 +0000 (11:58 +0100)]
[RELEASE] Release of TYPO3 6.2.17

Change-Id: I3e419c4e96dcee01f7d125801c125e43384b9b83
Reviewed-on: https://review.typo3.org/45385
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
3 years ago[BUGFIX] Prevent Javascript error for Flexform sections 56/45356/5
Oliver Hader [Fri, 18 Dec 2015 15:10:34 +0000 (16:10 +0100)]
[BUGFIX] Prevent Javascript error for Flexform sections

This patch resolves a regression which occurs on deleting
Flexform sections with an RTE.

Resolves: #72322
Releases: 6.2
Change-Id: I620d8701eb8fccb277d0ba58d7c8e3551c463db2
Reviewed-on: https://review.typo3.org/45356
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
3 years ago[!!!][BUGFIX] Severe data-loss on workspaces publishing action 20/45320/4
Oliver Hader [Wed, 16 Dec 2015 18:58:39 +0000 (19:58 +0100)]
[!!!][BUGFIX] Severe data-loss on workspaces publishing action

If pages records in a given scenario are published this causes
a severe data-loss for the whole TYPO3 installation since all
records are deleted. Actually they are marked as deleted, but
that's not less problematic.

The scenario for this in a draft workspace is having reordered
sub-pages (move-placeholder) and a parent-page that is marked
for deletion. On publishing the parent-page, the delete process
iterates over all pages on the root-level due to some essential
missing checks and an implicit type-cast from null to interger
zero (0) on the pages.pid value.

The accordant places are validated now. In addition to that the
possibility to delete everything implicitly from the root-page
is disabled to prevent other programmatic flaws like this.

Resolves: #72273
Releases: master, 6.2
Change-Id: I175f220cc0939124e34713fff07685ba902ad385
Reviewed-on: https://review.typo3.org/45320
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[BUGFIX] DBAL: use correct default value for native connection 40/45340/2
Melanie Kalka [Thu, 17 Dec 2015 16:22:52 +0000 (17:22 +0100)]
[BUGFIX] DBAL: use correct default value for native connection

DBAL uses an empty string for the portnumber parameter
for mysqli real_connect, which results in a PHP warning,
because an integer (or null) is required.

Changing the fallback to null resolves this issue and
results in a working database connection.

Resolves: #72285
Releases: master, 6.2
Change-Id: Ie0e04f3ab04996ab634f99c3d2ab545d4a3b3819
Reviewed-on: https://review.typo3.org/45340
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[TASK] Extend workspace functional tests on placeholder deletion 39/45339/2
Oliver Hader [Thu, 17 Dec 2015 10:47:26 +0000 (11:47 +0100)]
[TASK] Extend workspace functional tests on placeholder deletion

Actions performed in a workspace:
* move existing page below sibling on same level (move-placeholder)
* create new page on parent page (new-placeholder)
* delete the parent page

Attention:
The test assertions reflect the status quo which is faulty and has
to be fixed on a separate bugfix.

Resolves: #72291
Releases: master, 6.2
Change-Id: I85e10569c36a4c669a479434a5ce973d3fb9fe5c
Reviewed-on: https://review.typo3.org/45339
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[BUGFIX] substituteMarkerArrayCached() must accept special chars 36/45336/4
Markus Klein [Thu, 17 Dec 2015 14:44:37 +0000 (15:44 +0100)]
[BUGFIX] substituteMarkerArrayCached() must accept special chars

Add a bunch of unittests and streamline the code as well
by removing a useless preg_match_all() call.
Rename some variables and add comments.

Resolves: #72252
Releases: master, 6.2
Change-Id: I2a31a1c2ab6d83528428693213b922f0e1bc6fe5
Reviewed-on: https://review.typo3.org/45336
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] Missing check before foreach loop 30/45330/2
Oliver Hader [Thu, 17 Dec 2015 10:41:06 +0000 (11:41 +0100)]
[BUGFIX] Missing check before foreach loop

PHP Warning: Invalid argument supplied for foreach()
in typo3/sysext/core/Classes/DataHandling/DataHandler.php line 5285

Resolves: #72289
Releases: master, 6.2
Change-Id: If83dee7261ce3dd6d1fbf3bb81d8f2e53741c4c7
Reviewed-on: https://review.typo3.org/45330
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[BUGFIX] Disclose exceptions on CLI in production context 31/45331/2
Helmut Hummel [Thu, 17 Dec 2015 11:18:09 +0000 (12:18 +0100)]
[BUGFIX] Disclose exceptions on CLI in production context

It is pointless to hide the exception message on CLI
in the production context. On CLI there are privileged
users only anyway and hiding this information from them
leads to wasted hours of debugging.

Output the necessary information also in ProductionExceptionHandler

Resolves: #72265
Releases: master, 6.2
Change-Id: I778b057fc7e170af2a2fcdb1befb2a4400449ce7
Reviewed-on: https://review.typo3.org/45331
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Provide labels for all log types 24/45324/2
Anja Leichsenring [Wed, 16 Dec 2015 19:37:59 +0000 (20:37 +0100)]
[TASK] Provide labels for all log types

Change-Id: Ief05c75376ef8b3b2fc8fa8c3ca52e2efbf24198
Resolves: #72256
Releases: master, 6.2
Reviewed-on: https://review.typo3.org/45324
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 years ago[BUGFIX] Empty row in table content element shows &nbsp; 17/45317/2
Wouter Wolters [Wed, 16 Dec 2015 14:34:44 +0000 (15:34 +0100)]
[BUGFIX] Empty row in table content element shows &nbsp;

When an empty row in a table content element is shown in the
frontend, with htmlSpecialChars set to 1, &nbsp; is shown.
Use a real space instead.

Resolves: #72263
Releases: master,6.2
Change-Id: I60304607caa4fc90451216426f4ed73f01bf75fc
Reviewed-on: https://review.typo3.org/45317
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Set TYPO3 version to 6.2.17-dev 86/45286/2
TYPO3 Release Team [Tue, 15 Dec 2015 10:58:03 +0000 (11:58 +0100)]
[TASK] Set TYPO3 version to 6.2.17-dev

Change-Id: I8d118edb71a7fa83d71ef30c1d0d61f73b7657f7
Reviewed-on: https://review.typo3.org/45286
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
3 years ago[RELEASE] Release of TYPO3 6.2.16 85/45285/2 6.2.16 TYPO3_6-2-16
TYPO3 Release Team [Tue, 15 Dec 2015 10:56:38 +0000 (11:56 +0100)]
[RELEASE] Release of TYPO3 6.2.16

Change-Id: I924bade8d113a0f23a3b27e94980a399dcd68ce6
Reviewed-on: https://review.typo3.org/45285
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
3 years ago[SECURITY] Open shockwave inclusion in flvplayer.swf 74/45274/2
Oliver Hader [Tue, 15 Dec 2015 10:35:59 +0000 (11:35 +0100)]
[SECURITY] Open shockwave inclusion in flvplayer.swf

File inclusion is now protected by an additional signed hash
from the providing server which is validated further in the
Flash Player. In case of mismatching hash values, no external
shockwave file will be loaded.

This feature has been moved to ext:mediace in TYPO3 7 LTS.

Resolves: #59417
Releases: 6.2, 4.5
Security-Commit: 6c4814ce17122b669e209836e6e361958ba07df0
Security-Bulletins: TYPO3-CORE-SA-2015-010, 011, 012, 013, 014, 015
Change-Id: I9cff37b97a101b5da2834e046137c025ecbbebcc
Reviewed-on: https://review.typo3.org/45274
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[SECURITY] Escape caption of media using css_styled_content 73/45273/2
Georg Ringer [Tue, 15 Dec 2015 10:35:47 +0000 (11:35 +0100)]
[SECURITY] Escape caption of media using css_styled_content

The caption must be escaped. As this is only a textarea, the parsefunc
is not needed.

Furthermore, the fields "altText" and "titleText" use htmlspecialchars instead of stripHtml.

Resolves: #41690
Releases: master, 6.2
Security-Commit: 8b11cfd8fba0c68effad41f4fdc07f4b593a62cc
Security-Bulletins: TYPO3-CORE-SA-2015-010, 011, 012, 013, 014, 015
Change-Id: Ia32b37e93cbe3d5f171a7986fb17539d84e99325
Reviewed-on: https://review.typo3.org/45273
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[SECURITY] XSS in search results 72/45272/2
Wouter Wolters [Tue, 15 Dec 2015 10:35:34 +0000 (11:35 +0100)]
[SECURITY] XSS in search results

Page titles are not escaped in getPathFromPageId

Resolves: #23155
Releases: 6.2
Security-Commit: 9f2f01429e4cfd9f705b345a8b3c53dfd0bac63d
Security-Bulletins: TYPO3-CORE-SA-2015-010, 011, 012, 013, 014, 015
Change-Id: I65f106e1b504bf9ac45f869ae97582f0cb24f52a
Reviewed-on: https://review.typo3.org/45272
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[SECURITY] Fix XSS in rtehtmlarea 71/45271/2
Georg Ringer [Tue, 15 Dec 2015 10:35:20 +0000 (11:35 +0100)]
[SECURITY] Fix XSS in rtehtmlarea

The SpellCheckingController needs to quote external parameters.

Resolves: #37399
Releases: master, 6.2
Security-Commit: 9a6fe2c031c850eb4cd357bd3a1f13becd18f48b
Security-Bulletins: TYPO3-CORE-SA-2015-010, 011, 012, 013, 014, 015
Change-Id: I93f43a8ac8ffa28488527fd812c45e64048dfe23
Reviewed-on: https://review.typo3.org/45271
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[SECURITY] Fix XSS in bullet list element 70/45270/2
Georg Ringer [Tue, 15 Dec 2015 10:35:03 +0000 (11:35 +0100)]
[SECURITY] Fix XSS in bullet list element

Replace parsefunc with htmlSpecialChars for the lines of bullet list

Resolves: #71683
Releases: master, 6.2
Security-Commit: 0099f4a51b6d1b994177ab1caa920d6ccf10afe2
Security-Bulletins: TYPO3-CORE-SA-2015-010, 011, 012, 013, 014, 015
Change-Id: I7415c3cabb6412b6c06dae7c7d88bddf52e1d37c
Reviewed-on: https://review.typo3.org/45270
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[SECURITY] Replace parseFunc with htmlspecialchars in element "table" 69/45269/2
Georg Ringer [Tue, 15 Dec 2015 10:34:48 +0000 (11:34 +0100)]
[SECURITY] Replace parseFunc with htmlspecialchars in element "table"

Instead of using the lib.parseFunc htmlspecialchars is used for
the table cell rendering.

Resolves: #25245
Releases: master, 6.2
Security-Commit: 3d64bcca9bf08bbb472d016145fc1e1befc75daf
Security-Bulletins: TYPO3-CORE-SA-2015-010, 011, 012, 013, 014, 015
Change-Id: Ifd285572be52cdceddd72fdac5da01f7c632f2d0
Reviewed-on: https://review.typo3.org/45269
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[SECURITY] XSS in Link Validator 68/45268/2
Georg Ringer [Tue, 15 Dec 2015 10:34:33 +0000 (11:34 +0100)]
[SECURITY] XSS in Link Validator

Properly escape user input when showing broken links
in EXT:linkvalidator

Resolves: #68735
Releases: master,6.2
Security-Commit: 8c9a2eaa768534d8781073889c07e075e1c3c34e
Security-Bulletins: TYPO3-CORE-SA-2015-010, 011, 012, 013, 014, 015
Change-Id: Ic2cf727c4b3c213503254ee79301553eb6739a1a
Reviewed-on: https://review.typo3.org/45268
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[SECURITY] Possible XSS in felogin messages 67/45267/2
Georg Ringer [Tue, 15 Dec 2015 10:34:15 +0000 (11:34 +0100)]
[SECURITY] Possible XSS in felogin messages

Change default TypoScript to encode messages in felogin
with htmlspecialchars.

Fix two occurences of _LOCAL_LANG messages where htmlspecialchars
was missing.

Resolves: #25243
Releases: master, 6.2
Security-Commit: dd8cdadc5ff64ff415035490646e8cf2578ee396
Security-Bulletins: TYPO3-CORE-SA-2015-010, 011, 012, 013, 014, 015
Change-Id: I186f8cb344b9b16f38d11926529a52e7ed4c831d
Reviewed-on: https://review.typo3.org/45267
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[SECURITY] XSS through WS comments 66/45266/2
Wouter Wolters [Tue, 15 Dec 2015 10:34:02 +0000 (11:34 +0100)]
[SECURITY] XSS through WS comments

Resolves: #25227
Releases: master, 6.2
Security-Commit: f87f24a062c9443c571563eb443486190da12fb4
Security-Bulletins: TYPO3-CORE-SA-2015-010, 011, 012, 013, 014, 015
Change-Id: Ia57f5ed9110f6915118387b6315252001e1e44e6
Reviewed-on: https://review.typo3.org/45266
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[SECURITY] Link fields accept inline javascript code 65/45265/2
Oliver Hader [Tue, 15 Dec 2015 10:33:48 +0000 (11:33 +0100)]
[SECURITY] Link fields accept inline javascript code

JavaScript can be submitted for every link field and will be
rendered in the frontend passed through typolink. To circumvent
that, the URI scheme and prefix "javascript:" will be disallowed.

The extension "javascript_handler" allows however to bring back
that insecure behavior since some installations might rely on it.

Resolves: #71698
Releases: master, 6.2
Security-Commit: c9f5b7ced589c2d58a8c6099e5491923ace2e9a7
Security-Bulletins: TYPO3-CORE-SA-2015-010, 011, 012, 013, 014, 015
Change-Id: I5a0bcb990686fa1e768974afe561f6b195906552
Reviewed-on: https://review.typo3.org/45265
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[SECURITY] Fix several XSS issues 64/45264/2
Nicole Cordes [Tue, 15 Dec 2015 10:33:35 +0000 (11:33 +0100)]
[SECURITY] Fix several XSS issues

Resolves: #59150
Releases: master, 6.2
Security-Commit: 897e553b01145fe2867f362aa8025a71bc620961
Security-Bulletins: TYPO3-CORE-SA-2015-010, 011, 012, 013, 014, 015
Change-Id: I16ef6ad6e7146a9963139d2fa419dbc6ed88b774
Reviewed-on: https://review.typo3.org/45264
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[SECURITY] Prevent XSS in TER download dialog 63/45263/2
Nicole Cordes [Tue, 15 Dec 2015 10:33:22 +0000 (11:33 +0100)]
[SECURITY] Prevent XSS in TER download dialog

Due to the json request format during a TER extension installation,
the EM is susceptible to XSS.

Resolves: #71524
Releases: master, 6.2
Security-Commit: f109bf3ef49b88ed8b39e053b285e8f239210136
Security-Bulletins: TYPO3-CORE-SA-2015-010, 011, 012, 013, 014, 015
Change-Id: Ib47ec9f715578871d3c1a67aaca2b99d27a07f8e
Reviewed-on: https://review.typo3.org/45263
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[BUGFIX] Handle content with no markers in substituteMarkerArrayCached 56/45256/2
Markus Klein [Mon, 14 Dec 2015 22:12:47 +0000 (23:12 +0100)]
[BUGFIX] Handle content with no markers in substituteMarkerArrayCached

If the content has no markers at all, the full content
needs to be returned.
Additionally, the result does not need to be cached
if no markers are present.

Resolves: #72224
Releases: master, 6.2
Change-Id: I8fd39ab705eaa2217bba4fd5a069d940e677ea47
Reviewed-on: https://review.typo3.org/45256
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[BUGFIX] Make openid usable on IE 11 57/45257/2
Markus Klein [Mon, 14 Dec 2015 22:54:41 +0000 (23:54 +0100)]
[BUGFIX] Make openid usable on IE 11

Make sure there is no password set.
This might be the case, as the custom placeholder JS will set
the placeholder value as value of the field on IE.

Resolves: #64552
Releases: 6.2
Change-Id: Iac4cf14d85292a5be76ef2f739802ad6d710f1ee
Reviewed-on: https://review.typo3.org/45257
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Track pids of deleted/moved records to clear cache 13/45213/5
Jan Helke [Fri, 11 Dec 2015 13:08:33 +0000 (14:08 +0100)]
[BUGFIX] Track pids of deleted/moved records to clear cache

Clearing caches is done after all operations. The pid can't be read from
the deleted or from the old location of the moved record so an array
remembers these pids for the clear cache operation.

Resolves: #61017
Releases: master, 6.2
Change-Id: I4552d2b9b2a6ea475563fd62a62f29a57fe9df70
Reviewed-on: https://review.typo3.org/45213
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[BUGFIX] Indexed Search: Fix warning for empty search word 22/45222/4
Tymoteusz Motylewski [Sat, 12 Dec 2015 13:41:52 +0000 (14:41 +0100)]
[BUGFIX] Indexed Search: Fix warning for empty search word

The Extbase plugin throws a warning when the search word is empty.
This was already fixed in a bigger change in v7, which can not be
easily backported. This is a simple fix for v6.

Resolves: #69317
Releases: 6.2
Change-Id: I185bca27f9ee7563deb8ae943563915a6e5f0a62
Reviewed-on: https://review.typo3.org/45222
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] travis-ci: PHP 5.6 not allowed_failure anymore 86/45186/2
Christian Kuhn [Tue, 8 Dec 2015 16:30:19 +0000 (17:30 +0100)]
[TASK] travis-ci: PHP 5.6 not allowed_failure anymore

Change-Id: Ide32a6a582ec7dd1671b97b9d11c9b88a56953fd
Resolves: #72112
Related: #66473
Releases: 6.2
Reviewed-on: https://review.typo3.org/45186
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[FOLLOWUP][BUGFIX] ImageViewHelper should catch exceptions 70/45170/3
Andreas Allacher [Mon, 7 Dec 2015 09:57:36 +0000 (10:57 +0100)]
[FOLLOWUP][BUGFIX] ImageViewHelper should catch exceptions

We also need to catch RuntimeException and InvalidArgumentException.
InvalidArgumentException might be thrown if a storage does not exist.
RuntimeException if a file is outside a storage.

Change-Id: I994d8e7ef8b515f23ccc01847cefac0202f14b6f
Releases: master, 6.2
Resolves: #71686
Reviewed-on: https://review.typo3.org/45170
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[BUGFIX] Use strict authMode access check for list_type 67/45167/2
Frank Nägler [Mon, 7 Dec 2015 12:14:34 +0000 (13:14 +0100)]
[BUGFIX] Use strict authMode access check for list_type

Enforcing a strict authMode check is required to make sure
that editors only see those content elements of type CType='list'
which they are allowed to see.

Resolves: #32209
Releases: master, 6.2
Change-Id: I47f92a03a3dacbbf686fd9592ea679a40f3a828b
Reviewed-on: https://review.typo3.org/45167
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
3 years ago[BUGFIX] Live search shows move placeholders in draft workspace 25/44925/2
Alexander Opitz [Tue, 24 Nov 2015 09:28:55 +0000 (10:28 +0100)]
[BUGFIX] Live search shows move placeholders in draft workspace

This patch makes sure that all records that have a t3ver_move_id
other than 0 are ignored.

Resolves: #37896
Releases: master, 6.2
Change-Id: Id0b45ebdc72522f46bc9b51261eeca2e01d48db9
Reviewed-on: https://review.typo3.org/44925
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
3 years ago[BUGFIX] Avoid overly large regex in substituteMarkerArrayCached 32/45132/2
Benni Mack [Fri, 4 Dec 2015 22:54:45 +0000 (23:54 +0100)]
[BUGFIX] Avoid overly large regex in substituteMarkerArrayCached

Fetch the actually used markers from the content and only
generate the replace regex for those.
This avoids problems where 1000 markers may be passed in,
but only 10 are actually used.

Resolves: #44270
Releases: master, 6.2
Change-Id: I05f60960949e945249b045a8ae8e8430f7d8f7e6
Reviewed-on: https://review.typo3.org/45132
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[BUGFIX] Avoid wrong SQL query in fe_login user group redirect 31/45131/2
Frederic Gaus [Mon, 11 May 2015 15:07:11 +0000 (17:07 +0200)]
[BUGFIX] Avoid wrong SQL query in fe_login user group redirect

Ensure that no invalid group data is collected and check
if any group is set at all before running the SQL query.

Change-Id: I5792ff606d60ba5e5a108ed18c2ec91e354f85ff
Resolves: #64966
Releases: master, 6.2
Reviewed-on: https://review.typo3.org/45131
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] Ignore placeholders when copying records 71/45071/4
Oliver Hader [Sat, 31 Oct 2015 19:46:46 +0000 (20:46 +0100)]
[BUGFIX] Ignore placeholders when copying records

Copying records would make placeholders for draft elements visible in the
copy. This is due to the fact that t3ver_state information is removed upon
copy and the records itself are not ignored either. To circumvent that, now
only relevant records are selected for each scope, being live workspace or
any draft workspace. This also means, that new placeholders are copied if
the process has been initiated on a real draft workspace, which does not
happen if the duplication process was triggered in the live workspace.

Resolves: #36946
Resolves: #42075
Releases: master, 6.2
Change-Id: I0952d1a46d1cc02e0ec97f7cbbc9abc700e00c07
Reviewed-on: https://review.typo3.org/45071
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[BUGFIX] Sanity check is missing within MediaContentObject 12/45112/3
Thilo Schumann [Thu, 3 Dec 2015 16:10:29 +0000 (17:10 +0100)]
[BUGFIX] Sanity check is missing within MediaContentObject

Resolves: #67757
Releases: 6.2
Change-Id: I120ce5214ddb46891278adfaaaec19a897e85434
Reviewed-on: https://review.typo3.org/45112
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
3 years ago[BUGFIX] ImageViewHelper should catch exceptions 22/45122/4
Benni Mack [Fri, 4 Dec 2015 08:13:39 +0000 (09:13 +0100)]
[BUGFIX] ImageViewHelper should catch exceptions

The ImageViewHelper should catch the following exceptions:
1.) \UnexpectedValueException:
This can happen if a file has been replaced with a folder.

2.) \TYPO3\CMS\Core\Resource\Exception\ResourceDoesNotExistException
If a file was deleted (or renamed directly in the file system).
Such a scenario should still result in a proper page.

Change-Id: I73fa4c279d779a524c0a10021df56529dde052fc
Releases: master, 6.2
Resolves: #71686
Reviewed-on: https://review.typo3.org/45122
Reviewed-by: Andreas Allacher <andreas.allacher@gmx.at>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Allacher <andreas.allacher@gmx.at>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[BUGFIX] DebuggerUtility: Treat null results of lazy objects correctly 01/45101/2
Morton Jonuschat [Wed, 2 Dec 2015 21:17:47 +0000 (22:17 +0100)]
[BUGFIX] DebuggerUtility: Treat null results of lazy objects correctly

Resolves: #71951
Releases: master, 6.2
Change-Id: I590f1915fad84e09a6e45988d1adf17f61598c46
Reviewed-on: https://review.typo3.org/45101
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[BUGFIX] Create FAL processing folders on upgrade 22/38622/5
Daniel Neugebauer [Fri, 10 Apr 2015 11:21:47 +0000 (13:21 +0200)]
[BUGFIX] Create FAL processing folders on upgrade

The Upgrade Wizard's step to migrate filemounts to FAL storages now
creates all missing processing folders.

This is done implicitely by calling getProcessingFolders() on all
storages, thus not introducing any new code to explicitely perform any
manipulation on the file system. If this is not done during migration
regular API calls may fall into an infinite loop, attempting to re-run
getProcessingFolders() due to isWithinFileMountBoundaries check before
any can be created if ResourceStorage has evaluatePermissions set to
false. See bug #66341 for details.

Resolves: #66341
Releases: 6.2
Change-Id: I5839ffe74439d499594e0e1b93a356aaaaac6aca
Reviewed-on: https://review.typo3.org/38622
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[BUGFIX] Fix serializable object creation with PHP 5.6 22/40522/11
Helmut Hummel [Fri, 17 Apr 2015 15:47:43 +0000 (17:47 +0200)]
[BUGFIX] Fix serializable object creation with PHP 5.6

This makes use of doctrine/instantiator to catch this and many
other PHP issues when instantiating objects without constructor.

Resolves: #66473
Resolves: #66885
Releases: 6.2
Change-Id: Ibeaf94ca8227befc4f5a863dd4b688c54b8fcd4c
Reviewed-on: https://review.typo3.org/40522
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[BUGFIX] Add favicon without scheme 21/44921/3
Morton Jonuschat [Mon, 23 Nov 2015 19:45:30 +0000 (20:45 +0100)]
[BUGFIX] Add favicon without scheme

Remove the scheme when rendering the link to a favicon in order to
avoid mixed content because the cached header of a page is used for
both HTTP and HTTPS.

Resolves: #69665
Releases: master, 6.2
Change-Id: I39d51bcf31a98369645d144f670e4d6200c2402d
Reviewed-on: https://review.typo3.org/44921
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] Empty grid list in frontend workspace preview 05/44305/2
Oliver Hader [Mon, 26 Oct 2015 23:03:36 +0000 (00:03 +0100)]
[BUGFIX] Empty grid list in frontend workspace preview

The grid list of the frontend workspace preview stayed empty due to
several JavaScript issues. First one is a CORS thingy with local
document.domain values being set and for the list IFRAME being set
too late (and thus running into CORS error). Besides that the tabs
component is only available in the backend workspace module and
leads to another error if expected and used in the frontend preview.

Resolves: #66169
Releases: master, 6.2
Change-Id: I5bf3dd7760c9382527d85e6e7e8e0ad5dca81c05
Reviewed-on: https://review.typo3.org/44305
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[TASK] Add possibility to purge workspaces move placeholder 69/45069/2
Oliver Hader [Mon, 30 Nov 2015 17:16:59 +0000 (18:16 +0100)]
[TASK] Add possibility to purge workspaces move placeholder

During resolving references in a workspace context overlays and
delete-placeholder are considered and it's possible to define
whether they are kept or substituted. This mechanism is missing
for move-placeholders as well.

Resolves: #71990
Releases: master, 6.2
Change-Id: Id0a5326c968b5ceaca2af4c092f9907a91797823
Reviewed-on: https://review.typo3.org/45069
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[TASK] Extend regular workspaces DataHandler functional tests 67/45067/3
Oliver Hader [Mon, 30 Nov 2015 15:13:59 +0000 (16:13 +0100)]
[TASK] Extend regular workspaces DataHandler functional tests

The following actions are added:
* delete content and copy either draft or live page
* change content sorting and copy either draft or live page
* move content around and copy either draft or live page

Resolves: #71988
Releases: master, 6.2
Change-Id: I398fc9f0e7f91a9a944c74868d2718fdf19aa9f8
Reviewed-on: https://review.typo3.org/45067
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[TASK] Extend workspaces DataHandler functional tests 64/45064/2
Oliver Hader [Mon, 30 Nov 2015 14:46:09 +0000 (15:46 +0100)]
[TASK] Extend workspaces DataHandler functional tests

Add content element on different page in base scenario.

Resolves: #71986
Releases: master, 6.2
Change-Id: I87f198301fa8090c96a7c2e22eab9ecc59900405
Reviewed-on: https://review.typo3.org/45064
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[TASK] Travis: Disable Xdebug 43/45043/2
Nicole Cordes [Sat, 28 Nov 2015 23:31:25 +0000 (00:31 +0100)]
[TASK] Travis: Disable Xdebug

Resolves: #71947
Releases: master, 6.2
Change-Id: I06ad0771dd87d5186818028b4bea7bd61ee305d9
Reviewed-on: https://review.typo3.org/45043
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] EXT:form - OPTGROUP cannot be a child element of SELECT 92/43492/3
Ralf Zimmermann [Thu, 24 Sep 2015 21:44:37 +0000 (23:44 +0200)]
[BUGFIX] EXT:form - OPTGROUP cannot be a child element of SELECT

Resolves: #69376
Releases: 6.2
Change-Id: I9e77649203466e37067384f7043e7f1a6ce5fa7e
Reviewed-on: https://review.typo3.org/43492
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[BUGFIX] EXT:form - accept-charset in form not working 55/44955/4
Ralf Zimmermann [Thu, 26 Nov 2015 12:44:29 +0000 (13:44 +0100)]
[BUGFIX] EXT:form - accept-charset in form not working

Let the wizard write the correct attribute name "accept-charset"
instead of "acceptcharset". Avoid non existing attribute-class loading
if an attribute name contains non-alphabetic characters.

Resolves: #62713
Releases: 6.2
Change-Id: Iaadf8829b40a39061665dcea529f44ccf2d0a294
Reviewed-on: https://review.typo3.org/44955
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[BUGFIX] Allow reply-to mail header in EXT:form 61/43661/4
Ralf Zimmermann [Thu, 26 Nov 2015 11:28:11 +0000 (12:28 +0100)]
[BUGFIX] Allow reply-to mail header in EXT:form

In EXT:form it was not possible to set a reply-to header in the email
and so the entered mail address was used as "from" which could cause SPF
failures.

The reply-to was there in the old mailform (e.g. TYPO3 4.5) but not in
the new extension which is the successor. That is why this issue handled
as bugfix.

Resolves: #69395
Related: #68771
Releases: 6.2

Change-Id: I1e7b77d3196c4a921d2902f212d03815bb3e0eb9
Reviewed-on: https://review.typo3.org/43661
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[BUGFIX] Assure correct INCLUDE_TYPOSCRIPT with relative paths on subpages 52/44952/2
Daniel Goerz [Thu, 26 Nov 2015 11:41:44 +0000 (12:41 +0100)]
[BUGFIX] Assure correct INCLUDE_TYPOSCRIPT with relative paths on subpages

If a subpage has a template that clears the setup, INCLUDE_TYPOSCRIPT
will not work with relative paths anymore. This patch assures that always
the correct file is included.

Change-Id: I43b524c7c0fde7211ccbfc8481e2bbfd00bb4c0e
Resolves: #71197
Releases: master, 6.2
Reviewed-on: https://review.typo3.org/44952
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
3 years ago[TASK] Disallow multi-line HTTP headers 00/44900/2
Helmut Hummel [Sun, 22 Nov 2015 13:00:52 +0000 (14:00 +0100)]
[TASK] Disallow multi-line HTTP headers

PHP removed the support for this deprecated HTTP specification
in recent versions of PHP, thus we should remove these as well.

Besides that, we add an additional check for newlines
in GeneralUtility::locationHeaderUrl() to prevent potential
issues with Internet Explorer.
These lines can be removed once the minimum PHP requirement
are raised.

Releases: master, 6.2
Resolves: #58816
Change-Id: I38d26affd31913b82a972ac90ebf906a45b92e05
Reviewed-on: https://review.typo3.org/44900
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] Save parents localized uid as child reference 26/44926/2
Nicole Cordes [Wed, 9 Sep 2015 09:29:57 +0000 (11:29 +0200)]
[BUGFIX] Save parents localized uid as child reference

This patch resolves problems with updating translated records which
have a relation to a parent object. The backend expects the localized
uid as parent id but extbase currently saves the original uid. This
leads to wrong relation information within the child record.

Resolves: #69630
Releases: master, 6.2
Change-Id: Ib0af8b5fa13c03e15c4db5cb0ac1a81c8ee568eb
Reviewed-on: https://review.typo3.org/44926
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 years ago[BUGFIX] Position NULL-Checkbox left of TCA input 43/44043/3
Stephan Großberndt [Wed, 14 Oct 2015 08:54:14 +0000 (10:54 +0200)]
[BUGFIX] Position NULL-Checkbox left of TCA input

Positioning of the checkbox to nullify an TCA field is handled by the
FormEngine-Rewrite on master but not on 6.2. This patch positions the
NULL-Checkbox left of TCA input instead of to the far right.

Resolves: #52261
Releases: 6.2
Change-Id: Icc9e3d8d20a0bf728906275fe8041abd2b7446d9
Reviewed-on: https://review.typo3.org/44043
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
3 years ago[BUGFIX] Check webmounts for backend user in workspace preview 97/44897/2
Nicole Cordes [Sun, 22 Nov 2015 12:03:36 +0000 (13:03 +0100)]
[BUGFIX] Check webmounts for backend user in workspace preview

This patch adds a check if the current backend user used for workspace
authentication has access to the current requested page. If the user
doesn't have access the workspace version of that page can't be displayed
and the live version is shown instead.

Resolves: #71734
Releases: master, 6.2
Change-Id: I66b79f9ee36ed3037729dceedd9410ccd85880f4
Reviewed-on: https://review.typo3.org/44897
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
3 years ago[BUGFIX] Prevent deletion of closing bracket via INCLUDE_TYPOSCRIPT 24/44724/2
Andreas Allacher [Sun, 15 Nov 2015 11:45:53 +0000 (12:45 +0100)]
[BUGFIX] Prevent deletion of closing bracket via INCLUDE_TYPOSCRIPT

Due to missing check of the last char being a new line, it is
possible that a closing bracket character is removed by
using INCLUDE_TYPOSCRIPT.
This leads to broken typoscript.
By introducing the missing check this kind of error is prevented.

Change-Id: I92ef213d31c4d62ba797e2741d5a0beaa042c6b3
Resolves: #62280
Releases: master, 6.2
Reviewed-on: https://review.typo3.org/44724
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Andreas Allacher <andreas.allacher@gmx.at>
Reviewed-by: Martin Kutschker <martin.kutschker@ymail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Remove Ter.json template in extension manager 14/44814/2
Nicole Cordes [Thu, 19 Nov 2015 01:06:59 +0000 (02:06 +0100)]
[TASK] Remove Ter.json template in extension manager

The Ter.json template is needed to reload the extension table list
after the extension information was reloaded. As this request is not
useful (e.g. any search parameter stays in the input field, but the
request doesn't filter anything), the template should be removed and
the whole page should be reloaded afterwards.

Resolves: #71669
Releases: master, 6.2
Change-Id: I64158edff282540e7cc9f2597c9579607834aa55
Reviewed-on: https://review.typo3.org/44814
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
3 years ago[BUGFIX] Remove double encoding of fieldset in extension "felogin" 31/44831/2
Martin Kutschker [Fri, 20 Nov 2015 15:23:05 +0000 (16:23 +0100)]
[BUGFIX] Remove double encoding of fieldset in extension "felogin"

Change-Id: Ieaad7bff161fd8927388ab3a3aa7688885fc09fb
Resolves: #71730
Releases: master, 6.2
Reviewed-on: https://review.typo3.org/44831
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Add unit tests for spamProtectEmailAddresses 16/44816/3
Oliver Hader [Fri, 20 Nov 2015 10:58:50 +0000 (11:58 +0100)]
[TASK] Add unit tests for spamProtectEmailAddresses

Adding unit tests for TypoScript config property
spamProtectEmailAddresses and its variations.

Resolves: #71716
Releases: master, 6.2
Change-Id: I368806cdfcdb9c2cc05641892df56f3127190789
Reviewed-on: https://review.typo3.org/44816
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[SECURITY][TASK] Blind more options in the configuration module 09/44809/2
Georg Ringer [Fri, 20 Nov 2015 09:09:03 +0000 (10:09 +0100)]
[SECURITY][TASK] Blind more options in the configuration module

The database credentials should not be shown in the configuration module.

Change-Id: I6037f343d9e6932e1293e463fe513e793e948762
Resolves: #71706
Resolves: #68905
Releases: master, 6.2
Reviewed-on: https://review.typo3.org/44809
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] Fix f:cObject documentation example 49/44749/2
Josef Glatz [Tue, 17 Nov 2015 09:26:45 +0000 (10:26 +0100)]
[BUGFIX] Fix f:cObject documentation example

Fix current value example.

Releases: master, 6.2
Resolves: #71620
Change-Id: Ie82bab5a6767c664951c2e163a08015b5f7e3323
Reviewed-on: https://review.typo3.org/44749
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] Empty array not encoded as empty XML tag 01/44601/5
Andreas Wolf [Sat, 7 Nov 2015 16:04:32 +0000 (17:04 +0100)]
[BUGFIX] Empty array not encoded as empty XML tag

When encoding an empty array, an empty line with indentation was
created. If the <el> tag had a proper type="array" attribute, it could
still be decoded to an array again. If not, it was decoded to a string,
leading to errors e.g. when trying to traverse it.

The fix is to include an empty element now, which will be decoded to
an empty array again then.

Change-Id: Ia78adc1e7e81a943cdbc94f3cfa19b36442c430f
Resolves: #71394
Releases: 6.2, master
Reviewed-on: https://review.typo3.org/44601
Reviewed-by: Daniel Lorenz <forge@extco.de>
Tested-by: Daniel Lorenz <forge@extco.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
3 years ago[BUGFIX] .htaccess created for log folder outside PATH_site 15/44715/2
Andreas Wolf [Sun, 19 Jul 2015 11:29:55 +0000 (13:29 +0200)]
[BUGFIX] .htaccess created for log folder outside PATH_site

Change-Id: I47d38033581a3ac71ee61d9607c708c01fe56743
Resolves: #68368
Releases: master, 6.2
Reviewed-on: https://review.typo3.org/44715
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Steffen Müller <typo3@t3node.com>
Tested-by: Steffen Müller <typo3@t3node.com>
3 years ago[BUGFIX] Fix l10n identifier string in date validator of EXT:form 93/43493/3
Ralf Zimmermann [Wed, 23 Sep 2015 07:40:49 +0000 (09:40 +0200)]
[BUGFIX] Fix l10n identifier string in date validator of EXT:form

Resolves: #69354
Releases: 6.2
Change-Id: Ie99cff4bb300056b57dad0f33412b184d8d3c7d6
Reviewed-on: https://review.typo3.org/43493
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Steffen Müller <typo3@t3node.com>
Tested-by: Steffen Müller <typo3@t3node.com>
3 years ago[BUGFIX] EXT:form - error in mail process if label layout contains label 94/43494/2
Ralf Zimmermann [Wed, 23 Sep 2015 07:45:58 +0000 (09:45 +0200)]
[BUGFIX] EXT:form - error in mail process if label layout contains label

Do not delete the parent dom node if
TYPO3\CMS\Form\View\Mail\Html\Additional\LabelAdditionalElementView
is rendered and the layout definition contains a label tag.

Resolves: #69817
Releases: 6.2
Change-Id: I8f1be9af8d3b2575d83867900b5c75f5ab5b6482
Reviewed-on: https://review.typo3.org/43494
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Steffen Müller <typo3@t3node.com>
Tested-by: Steffen Müller <typo3@t3node.com>
3 years ago[BUGFIX] Handling of uploaded files not within open_basedir 10/44710/2
Morton Jonuschat [Fri, 13 Nov 2015 19:55:54 +0000 (20:55 +0100)]
[BUGFIX] Handling of uploaded files not within open_basedir

When the "upload_tmp_dir" folder is not within the "open_basedir"
an Exception will get thrown when uploading files in the fileadmin.
This patch silences open_basedir() warnings occuring in the file_exists()
check and adds detection of uploaded files as the handling of these with
move_uploaded_file() is not influenced by the open_basedir setting.

Resolves: #69356
Releases: master, 6.2
Change-Id: I649373e8910c2d30f73cbb0e3b56476196c151fd
Reviewed-on: https://review.typo3.org/44710
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[BUGFIX] BackendUtility: Skip rendering thumbnails for anything but files 09/44709/2
Morton Jonuschat [Fri, 13 Nov 2015 19:17:52 +0000 (20:17 +0100)]
[BUGFIX] BackendUtility: Skip rendering thumbnails for anything but files

If the stored value in a group field with type file/file_reference is a
folder the thumbCode() method skips rendering a thumbnail for that
resource. This avoids fatal error as the interface of e.g. a Folder is
different to that of a File, missing the ::isMissing() method.

Resolves: #66045
Releases: master, 6.2
Change-Id: I29b75dec0173cc2423583a9cf42ff56ca81ce7d3
Reviewed-on: https://review.typo3.org/44709
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[BUGFIX] EXT:form - avoid number reduction in currency filter 91/43491/3
Ralf Zimmermann [Wed, 23 Sep 2015 07:29:21 +0000 (09:29 +0200)]
[BUGFIX] EXT:form - avoid number reduction in currency filter

Avoid a number reduction each time the filter is applied.
Preserve the decimal places.

Resolves: #69807
Releases: 6.2
Change-Id: I3d7587ecf65447439bd8b58819805263aa5fa7f8
Reviewed-on: https://review.typo3.org/43491
Reviewed-by: Richard Haeser <richardhaeser@gmail.com>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[TASK] Fix deprecation-message in FormEngine 90/44690/3
Stefan Neufeind [Thu, 12 Nov 2015 11:46:31 +0000 (12:46 +0100)]
[TASK] Fix deprecation-message in FormEngine

Fix a typo. And since there are large changes in 7 LTS already
adjust surrounding deprecation-related comments as well.

Change-Id: I8074bccc65847d8027d8ced711f4ed616346ccf4
Resolves: #71544
Releases: 6.2
Reviewed-on: https://review.typo3.org/44690
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[BUGFIX] Replace old @dontvalidate with @ignorevalidation 73/44373/2
Stefan Neufeind [Thu, 29 Oct 2015 19:07:07 +0000 (20:07 +0100)]
[BUGFIX] Replace old @dontvalidate with @ignorevalidation

@dontvalidate was syntax of the old propertymapper.

Change-Id: I50394d5272118253e4bb738adbed08054a6e1f64
Resolves: #71096
Releases: master, 6.2
Reviewed-on: https://review.typo3.org/44373
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Andreas Bouche <andreas.bouche@flagbit.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Ensure processing folder within another storage is created 85/44685/2
Benjamin Mack [Thu, 12 Nov 2015 06:02:27 +0000 (07:02 +0100)]
[BUGFIX] Ensure processing folder within another storage is created

This patch checks if the processing folder within another storage
exists and ensures it is created if not.

Resolves: #70481
Releases: master, 6.2
Change-Id: Ib6747b5e37a46e6f761912103d1ac5f490bb2a1d
Reviewed-on: https://review.typo3.org/44685
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
3 years agoRevert "[BUGFIX] IMG_RESOURCE does not prepend absRefPrefix" 32/44632/3
Andreas Allacher [Mon, 9 Nov 2015 12:42:03 +0000 (13:42 +0100)]
Revert "[BUGFIX] IMG_RESOURCE does not prepend absRefPrefix"

This reverts commit 119d9607090bf390a1cb299e692b8f2e90fbe399.
Due to this change in various instances the absRefPrefix was appended twice because of this commit.
If one wants to fix the issue one could modify
\TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController::setAbsRefPrefix()
to also e.g. include single quotes.

Releases: master, 6.2
Resolves: #71435
Resolves: #70718
Reverts: #69516
Change-Id: I1a2547df0439aab8c67866b1a2d5ab59dd0ba730
Reviewed-on: https://review.typo3.org/44632
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[BUGFIX] Add img longdescUrl only if available 77/44577/2
Benjamin Mack [Fri, 6 Nov 2015 12:09:06 +0000 (13:09 +0100)]
[BUGFIX] Add img longdescUrl only if available

According to the W3C standard (http://www.w3.org/TR/html-longdesc/#implementation),
longDesc should only be added if the attribute value is not empty.

The change adds an additional check to do so.

Resolves: #70685
Releases: master, 6.2
Change-Id: I4f61e61f04de81f881becee871edcc15d77deecd
Reviewed-on: https://review.typo3.org/44577
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Non-admins cannot use mass actions in a workspace 16/44416/2
Oliver Hader [Fri, 30 Oct 2015 16:20:13 +0000 (17:20 +0100)]
[BUGFIX] Non-admins cannot use mass actions in a workspace

Non-admins cannot use the mass actions "publish", "swap" or
"discard" in a workspace. The reason is, that for non-admins
the mount-page tree is traversed for a given recursion depth
which is not the case for privileged admin users. The default
value for the depth value is zero (0), that's why no pages,
except the mount-points, are processed.

Resolves: #59226
Releases: master, 6.2
Change-Id: I8d1e2032f72fa977cfcaf44978300d36bef9be23
Reviewed-on: https://review.typo3.org/44416
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[TASK] Allow to define multiple DataHandler commands for one element 51/44351/2
Oliver Hader [Thu, 29 Oct 2015 12:35:28 +0000 (13:35 +0100)]
[TASK] Allow to define multiple DataHandler commands for one element

The method DataHandler::process_cmdmap currently allows only one command
to be executed for one element. A command-map like the following is
currently not possible - the second command would be ignored:

[tt_content][13][localize] = 1
[tt_content][13][inlineLocalizeSynchronize] = children:14

Resolves: #71125
Releases: master, 6.2
Change-Id: I473ea0de3789d77cb913ad64a26a666ab73c2a52
Reviewed-on: https://review.typo3.org/44351
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[TASK] Extend functional test cases for copying data 48/44548/2
Oliver Hader [Thu, 5 Nov 2015 11:24:00 +0000 (12:24 +0100)]
[TASK] Extend functional test cases for copying data

The workspaces functional test cases are extended with combined
draft and live actions on copying record data. This task is to
add the tests first. Thus, the assertions contain flaws that
are solved in a separate issue - which can be visualized and
proven then.

Resolves: #71342
Releases: master, 6.2
Change-Id: I85787a410f4e6260528a89491537e243842a405a
Reviewed-on: https://review.typo3.org/44548
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[BUGFIX] t3editor: menu objects: common properties missing 31/44531/3
Andreas Bouche [Mon, 2 Nov 2015 12:27:05 +0000 (13:27 +0100)]
[BUGFIX] t3editor: menu objects: common properties missing

When autocompleting menu objects the common properties are missing

Releases: master, 6.2
Resolves: #67764
Change-Id: Ib54daf26647966f00f7609715c98199e3234c51e
Reviewed-on: https://review.typo3.org/44531
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[TASK] Support EXT: syntax in TCA ctrl iconfile 60/43760/4
Stephan Großberndt [Sat, 3 Oct 2015 15:00:53 +0000 (17:00 +0200)]
[TASK] Support EXT: syntax in TCA ctrl iconfile

Using EXT: in iconfile of TCA ctrl is used as favorite method as of
TYPO3 7.5, using extRelPath() is deprecated. In order to ease the
transformation to EXT: add support for it in TYPO3 6.2.

Resolves: #70283
Releases: 6.2
Change-Id: Ib724c9c561e425769a1d3c93c4960fe663679173
Reviewed-on: https://review.typo3.org/43760
Reviewed-by: Ruud Silvrants <ruudsilvrants@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
3 years ago[TASK] Add possibility to copy pages recursively in functional tests 63/44463/2
Oliver Hader [Sat, 31 Oct 2015 19:29:22 +0000 (20:29 +0100)]
[TASK] Add possibility to copy pages recursively in functional tests

Resolves: #71222
Releases: master, 6.2
Change-Id: I6d73c5556ba48e936d28c0532a57f8bf9d3b6175
Reviewed-on: https://review.typo3.org/44463
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[BUGFIX] EXT:form - HIDDEN element cannot be accessed in form wizard 34/44434/2
Björn Jacob [Fri, 30 Oct 2015 16:10:17 +0000 (17:10 +0100)]
[BUGFIX] EXT:form - HIDDEN element cannot be accessed in form wizard

After creating a HIDDEN element with the help of the form wizard one is
not able to edit the element afterwards. This is due to the fact that
the element is hidden which is kind of correct but does not help the
editor to work target orientied.

This patch adds a dummy element to the HIDDEN element. The dummy
element contains the element's name and has a dotted border.
That way the editor can edit and move a HIDDEN element.

Resolves: #70637
Releases: master, 6.2
Change-Id: I933df4f7a4b01d9246f6bd0981179497c103882b
Reviewed-on: https://review.typo3.org/44434
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Workspace placeholder is not processed with eval-function 02/44402/3
Oliver Hader [Fri, 30 Oct 2015 13:56:57 +0000 (14:56 +0100)]
[BUGFIX] Workspace placeholder is not processed with eval-function

The workspace move-placeholder is not processed with the accordant
eval-function. This leads to scenario that a placeholder is not
persisted at all and produces orphaned or invalid data sets.

Resolves: #71161
Releases: master, 6.2
Change-Id: I60eaaa30399a26a10452f0605ba73476a9d129ef
Reviewed-on: https://review.typo3.org/44402
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[BUGFIX] Add class alias of class loader to alias map 02/44302/3
Helmut Hummel [Mon, 26 Oct 2015 21:16:20 +0000 (22:16 +0100)]
[BUGFIX] Add class alias of class loader to alias map

Instead of hardcoding the class_alias call to alias the Flow
class loader, we must use the class alias API,
which in turn triggers the integrated composer
class loader to properly establish the alias.

This avoids a fatal error in the install tool clear cache action
which calls Bootstrap::initializeClassLoader() twice.

Resolves: #71057
Related: #69476
Releases: 6.2
Change-Id: I83310f9f9668c2ce0cdd07497036b406e94decc7
Reviewed-on: https://review.typo3.org/44302
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Change default label for sys_file_references 47/44347/2
Bernd Wilke [Fri, 5 Jun 2015 07:38:43 +0000 (09:38 +0200)]
[BUGFIX] Change default label for sys_file_references

In the List module you can select additional fields to be displayed.
For fields referencing files only, the uid is shown which does give
no hint to the real referenced file.
This change selects the uid_local field, which selects the filename
from sys_file for display.

Resolves: #67303
Releases: master, 6.2
Change-Id: I8dd301ff8d8d17baa67fafd26892a3eeea46509b
Reviewed-on: https://review.typo3.org/44347
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[BUGFIX] Invalid behaviour with GeneralUtility::trimExplode() 94/44194/2
Xavier Perseguers [Wed, 21 Oct 2015 08:39:58 +0000 (10:39 +0200)]
[BUGFIX] Invalid behaviour with GeneralUtility::trimExplode()

The subject's parts are wrongly trimmed although a limit is specified.
According to the PHP documentation, the values are trimmed for whitespace
in the end, not at the beginning.

Change-Id: Ifb4547b3349be2d31d5ce75b19db77eb6535d5ec
Resolves: #70864
Releases: master, 6.2
Reviewed-on: https://review.typo3.org/44194
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
3 years ago[BUGFIX] Allow log files to be outside PATH_site 42/44142/3
Andreas Wolf [Sun, 18 Oct 2015 16:27:01 +0000 (18:27 +0200)]
[BUGFIX] Allow log files to be outside PATH_site

Change-Id: I81438b2230a9d3d15dca0c15d14bca3736ca12a3
Resolves: #68231
Releases: master, 6.2
Reviewed-on: https://review.typo3.org/44142
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
3 years ago[FOLLOWUP][TASK] Properly encode database input in Typo3DbQueryParser 72/44172/2
Morton Jonuschat [Tue, 20 Oct 2015 06:19:47 +0000 (08:19 +0200)]
[FOLLOWUP][TASK] Properly encode database input in Typo3DbQueryParser

Restore PHP 5.3/5.4 compatibility by replacing usage of ::class syntax.

Resolves: #70632
Releases: 6.2
Change-Id: I41b0973076f6d095c6d4bd387f9e9d6adb38a1e4
Reviewed-on: https://review.typo3.org/44172
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] Properly encode database input in Typo3DbQueryParser 34/44134/2
Helmut Hummel [Mon, 12 Oct 2015 16:35:22 +0000 (18:35 +0200)]
[TASK] Properly encode database input in Typo3DbQueryParser

Resolves: #70632
Releases: 6.2, master
Change-Id: I3ecbc2dd887789866512d4fc4aa7d0913b49fd0d
Reviewed-on: https://review.typo3.org/44134
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
3 years ago[BUGFIX] Child sorting is lost after publishing workspace data 40/43940/2
Oliver Hader [Tue, 23 Sep 2014 17:48:42 +0000 (19:48 +0200)]
[BUGFIX] Child sorting is lost after publishing workspace data

If sorting of IRRE child records is changed in a workspace and
published, the sorting of child records is not published along.

This behaviour could be solved by using proper move placeholders
for IRRE child records as well, but conflicts with the
possibility to define a custom sorting field in the parent
entity of the relation construct. Besides that, sorting
values are not published in any case. That's why a
post-processing of IRRE children is required for sorting.

Resolves: #61750
Releases: master, 6.2
Change-Id: Ia8a0a1766233161d566e67a619ee195d6b0433c9
Reviewed-on: http://review.typo3.org/43940
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[TASK] Extract data overlay handling to common class 10/43910/4
Oliver Hader [Sat, 22 Aug 2015 14:45:38 +0000 (16:45 +0200)]
[TASK] Extract data overlay handling to common class

The data overlay handling of RelationHandler is extracted to
a separate common class. The scope of this object shall be
independent from frontend-only or backend-only constraints.

The new handler resolves version overlays for given IDs of
a database table and applies sorting for the target context.

This is just an intermediate solution to overcome sorting issues
of relations handled in RelationHandler. The goal of DataResolvers
should be to provide independent APIs for OneToMany and ManyToMany
relation resolving in the future as well.

Resolves: #69967
Releases: master, 6.2
Change-Id: I5a7f76a55b4af93aee6270168285fff9486a2e73
Reviewed-on: http://review.typo3.org/43910
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[BUGFIX] Possible silent fatal error with legacy extensions 20/44120/3
Xavier Perseguers [Sat, 17 Oct 2015 07:04:45 +0000 (09:04 +0200)]
[BUGFIX] Possible silent fatal error with legacy extensions

The use of the '@' symbol while including an extension update script
may result into a PHP fatal error being totally muted which in turn
results into a blank screen.

In TYPO3 6.2, this happens when a legacy extension is trying to manually
include class t3lib_SCbase in its update script:

    require_once(PATH_t3lib . 'class.t3lib_scbase.php');

Having a white screen and no log entry makes it really hard to
understand where the error comes from. The Install Tool does not help
either since the check for broken extensions only tries to include
ext_tables.php and ext_localconf.php.

Change-Id: I9078882e10739309ac160f4ac5a0dfcfd49fbba1
Resolves: #70697
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/44120
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
3 years ago[BUGFIX] Add stdWrap support for Partial- and layoutRootPaths 79/41679/6
Anja Leichsenring [Sat, 18 Jul 2015 14:40:26 +0000 (16:40 +0200)]
[BUGFIX] Add stdWrap support for Partial- and layoutRootPaths

The single occurrences layoutRootPath and partialRootPath have
stdWrap support, but not the collection entries of
layoutRootPaths and partialRootPaths. This is added now.

Change-Id: I59d4967ce67b48b53e9bf1052d703c974f1472ca
Resolves: #63380
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/41679
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
3 years ago[FOLLOWUP][BUGFIX] Do not crop inside known html tags 96/43996/2
Benjamin Mack [Sun, 11 Oct 2015 21:16:45 +0000 (23:16 +0200)]
[FOLLOWUP][BUGFIX] Do not crop inside known html tags

Fixed indent spaces to tabs.

This change adds missing tags to the regex used to match html tags.
Furthermore, scripting tags are added, so that they will not be counted
nor split apart.

This list of html tags was extracted from the current W3C html5
standard recommendation at [1] and merged with tags from the current
code that are not (or no longer) in the W3C standard recommendation
(e.g: TYPO3's internal <link> tag).

---
[1]: http://www.w3.org/TR/html5/semantics.html#semantics

Change-Id: Ie1aedecbfd46c82b49f34936a96004af29c63d54
Resolves: #69263
Releases: 6.2
Reviewed-on: http://review.typo3.org/43996
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[BUGFIX] Do not crop inside known html tags 95/43995/2
Benjamin Mack [Sun, 11 Oct 2015 21:09:34 +0000 (23:09 +0200)]
[BUGFIX] Do not crop inside known html tags

This change adds missing tags to the regex used to match html tags.
Furthermore, scripting tags are added, so that they will not be counted
nor split apart.

This list of html tags was extracted from the current W3C html5
standard recommendation at [1] and merged with tags from the current
code that are not (or no longer) in the W3C standard recommendation
(e.g: TYPO3's internal <link> tag).

---
[1]: http://www.w3.org/TR/html5/semantics.html#semantics

Resolves: #69263
Releases: master, 6.2
Change-Id: Id58dcf3470ed06256b9b8f744dd13891757faef1
Reviewed-on: http://review.typo3.org/43995
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[BUGFIX] Support URLs in image tag generation 76/43376/3
Nicole Cordes [Tue, 15 Sep 2015 23:29:37 +0000 (01:29 +0200)]
[BUGFIX] Support URLs in image tag generation

FAL files may return an absolute URL depending on the driver the
storage uses. Currently the absRefPrefix is prepended automatically
to the image source without analyzing the file path. This patch ensures
the prefix is only added for local files.

Resolves: #69861
Releases: master, 6.2
Change-Id: Ida5568372817ac6e840bcc366090fe3e8a925eec
Reviewed-on: http://review.typo3.org/43376
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[TASK] Update static composer class loading 87/43887/2
Helmut Hummel [Wed, 7 Oct 2015 12:38:05 +0000 (14:38 +0200)]
[TASK] Update static composer class loading

The committed composer class loading information has not been
updated for a while. Do so, to add classes that have been added
meanwhile to required TYPO3 extensions to the map and update
class loader code to be current.

Also adapt the .gitignore file to be correct and add a script
to automate this process (so that it can theoretically be done
before a release)

Resolves: #70465
Releases: 6.2
Change-Id: Ife3a9b47a6fbd93e4d10c6e693b597f42a338bc9
Reviewed-on: http://review.typo3.org/43887
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Fix Liskov substitution violation in PackageManager 83/42983/3
Helmut Hummel [Wed, 7 Oct 2015 12:12:05 +0000 (14:12 +0200)]
[BUGFIX] Fix Liskov substitution violation in PackageManager

TYPO3's `PackageManager` class changes the signature of a method
defined in it's parent class. This causes warnings when PHP's strict
mode is enabled. Fix this in the same way, we established compatibility
with the Flow core bootstrap class and establish an alias for the
Flow core class loader.

This brings strict free TYPO3 front end rendering without having
to change the method signature.

When doing so, we can also remove the Flow class loader class from
the class map and the file system.

Change-Id: I29ce35339823126bbba0c951da11122e16b4e052
Fixes: #69476
Releases: 6.2
Reviewed-on: http://review.typo3.org/42983
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Martin Helmich <m.helmich@mittwald.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Flaws in copying a page with localized content elements 06/43906/2
Oliver Hader [Mon, 25 Aug 2014 16:00:24 +0000 (18:00 +0200)]
[BUGFIX] Flaws in copying a page with localized content elements

Copying a page with localized content elements in a workspace
has some flaws. In a workspace a duplicated record will end up
in a new-placeholder and the specific version record.

The tranlation pointer field of the new-placeholder still
contains the unmodified value of the original record, the
specific version record is fine however.

The reason for that is the special handling for cloning a page
in DataHandler. Each record of a particular table is copied in
reverse order. This way, the localization is created earlier
than the record of the default language.

This change is about skipping the direct copyRecord() call for
records that will be processed inside another copyRecord() call
for the record of the default language.

Resolves: #61179
Releases: master, 6.2
Change-Id: I6647b02095343756d3a41b0c0e985b4777429cd8
Reviewed-on: http://review.typo3.org/43906
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[TASK] Enforce optimized composer autoloader 62/43862/2
Helmut Hummel [Tue, 6 Oct 2015 14:34:17 +0000 (16:34 +0200)]
[TASK] Enforce optimized composer autoloader

The optimized autoload generation gives a huge benefit in performance.
Let people participate from this benefit even if they do not know about it.

Add this option in composer.json, so that this step cannot be forgotten when
creating distribution builds.

Resolves: #70436
Releases: master, 6.2
Change-Id: Ia3e1a3209f3c6820f514d2574a3c71cacd4e8501
Reviewed-on: http://review.typo3.org/43862
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Prevent current extension version in update dialog 11/43811/2
Nicole Cordes [Thu, 1 Oct 2015 12:25:17 +0000 (14:25 +0200)]
[BUGFIX] Prevent current extension version in update dialog

If you update an extension, the current version is included in the
confirmation dialog. This might confuse the user as this version is
already available. The patch re-adds the usage of the repository
function to exclude the current used version in the query.

Resolves: #65904
Releases: master, 6.2
Change-Id: I49aa2ba36bbfd7888aa202028dfd9e9c882a8183
Reviewed-on: http://review.typo3.org/43811
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
3 years ago[TASK] Prevent gathering update information on Ter installation 13/43713/2
Nicole Cordes [Thu, 1 Oct 2015 12:32:29 +0000 (14:32 +0200)]
[TASK] Prevent gathering update information on Ter installation

Currently when the extension list from TER is fetched from the database,
all installed extensions are checked for an update. This is because the
TER extension list needs a css class for available extensions but the
wrong method is used to gather the needed information within the
ListController.

Resolves: #70264
Releases: master, 6.2
Change-Id: I99e9bfceb0bf0ed97d0bf26ae927743fd2ca86f4
Reviewed-on: http://review.typo3.org/43713
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Use correct storage when getting public url of processed file 75/43575/2
Nicole Cordes [Tue, 15 Sep 2015 23:42:09 +0000 (01:42 +0200)]
[BUGFIX] Use correct storage when getting public url of processed file

If the processed file object is marked configured to use the original
file we have to ensure the right storage is used when creating the
publicUrl.

Resolves: #69833
Releases: master, 6.2
Change-Id: Iba0b4c7b8ef8b65cceae86ada0a7c7e85f338fdf
Reviewed-on: http://review.typo3.org/43575
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>