Packages/TYPO3.CMS.git
5 months ago[TASK] Use Environment API instead of PATH_site for Cache Backends 61/57161/5
Benni Mack [Sat, 9 Jun 2018 15:58:40 +0000 (17:58 +0200)]
[TASK] Use Environment API instead of PATH_site for Cache Backends

The new Environment API is now used to define hashes or base paths
in cache backend classes.

Resolves: #85200
Releases: master
Change-Id: I08f770bf959274995e7983b800d8a569aee7cd47
Reviewed-on: https://review.typo3.org/57161
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
5 months ago[TASK] Update karma components 76/57176/2
Frank Naegler [Mon, 11 Jun 2018 12:03:29 +0000 (14:03 +0200)]
[TASK] Update karma components

yarn upgrade karma-coverage@1.1.2
yarn upgrade karma-jasmine@1.1.2

Resolves: #85220
Releases: master
Change-Id: I44019f08df4e2ab4f104236c055656f72f4d7015
Reviewed-on: https://review.typo3.org/57176
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[TASK] Repair failing acceptance test 68/57168/2
Anja Leichsenring [Sun, 10 Jun 2018 16:13:37 +0000 (18:13 +0200)]
[TASK] Repair failing acceptance test

The test uses now a method to check on the element that takes the
DOM into consideration, and not the visibility on the interface.

Not the backend changed anything, but the testing methods of
codeception cause this failure. Using the correct testing method
solves the problem.

Resolves: #85208
Releases: master, 8.7
Change-Id: I349a555de2ab04c9f6181e5d71e4602fa9552df3
Reviewed-on: https://review.typo3.org/57168
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 months ago[TASK] Use current request object in Maintenance middleware 02/57202/2
Benni Mack [Tue, 12 Jun 2018 12:26:59 +0000 (14:26 +0200)]
[TASK] Use current request object in Maintenance middleware

The property `$GLOBALS['TYPO3_REQUEST']` is not needed when inside
a middleware, as the current PSR-7 request object is already available.

Resolves: #85242
Releases: master
Change-Id: Ib5062725dd74990c6a6003b6fcd8a82afb158c0b
Reviewed-on: https://review.typo3.org/57202
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[TASK] Update chosen-js 1.8.3 ❯ 1.8.5 77/57177/2
Frank Naegler [Mon, 11 Jun 2018 12:08:15 +0000 (14:08 +0200)]
[TASK] Update chosen-js 1.8.3 ❯ 1.8.5

yarn upgrade chosen-js@1.8.5

Resolves: #85221
Releases: master
Change-Id: Ic97a68ead2145183ef3739584af8556b8a6cc139
Reviewed-on: https://review.typo3.org/57177
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[TASK] Update @types definitions 75/57175/3
Frank Naegler [Mon, 11 Jun 2018 11:57:03 +0000 (13:57 +0200)]
[TASK] Update @types definitions

yarn upgrade @types/bootstrap@3.3.39
yarn upgrade @types/jasmine@2.8.8

Resolves: #85219
Releases: master
Change-Id: I33d30853ca6d631ae262047daf221c978d548c93
Reviewed-on: https://review.typo3.org/57175
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[TASK] Remove mis-usage of TemplateService->fileHash 97/57197/3
Benni Mack [Tue, 12 Jun 2018 09:09:56 +0000 (11:09 +0200)]
[TASK] Remove mis-usage of TemplateService->fileHash

The fileHash property acts as an internal cache for
TemplateService->getFileName() and was misued since TYPO3 6.0 for
FAL-related information of processed images.

As this is a purely runtime-based cache (and internal), the usages here
are dropped.

Resolves: #85235
Releases: master
Change-Id: I96e8630cb8c45be009385aa5eccc01e3875e2d2b
Reviewed-on: https://review.typo3.org/57197
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[TASK] Remove PHP bug workaround in GIFBUILDER 96/57196/3
Benni Mack [Tue, 12 Jun 2018 08:29:25 +0000 (10:29 +0200)]
[TASK] Remove PHP bug workaround in GIFBUILDER

TYPO3 has a bound box calculation workaround due to a PHP bug,
which was fixed in PHP 7.0.12 / 7.1, which can now safely be
removed.

Resolves: #85232
Releases: master
Change-Id: I72e9ea925ae7e91eea244b89a20b1bec2408ca78
Reviewed-on: https://review.typo3.org/57196
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 months ago[BUGFIX] Check in images which are marked as changed without changes 82/57182/4
Frank Naegler [Mon, 11 Jun 2018 12:52:24 +0000 (14:52 +0200)]
[BUGFIX] Check in images which are marked as changed without changes

Looks like a different file encoding of the images results
in marking these icons as changed on OS X.

Resolves: #85240
Releases: master
Change-Id: I37293134347e9aa16fe05671073e74f8621736d3
Reviewed-on: https://review.typo3.org/57182
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
5 months ago[TASK] Change label of Sites Module to "Sites" 99/57199/2
Mathias Schreiber [Tue, 12 Jun 2018 11:07:32 +0000 (13:07 +0200)]
[TASK] Change label of Sites Module to "Sites"

In order to make finding the module more straightforward, its tab label
has been set to “Sites” which should be more intuitive.

Releases: master
Resolves: #85239
Change-Id: I3d6d546f8439e4e107bf932efdc2d41ce65b4c75
Reviewed-on: https://review.typo3.org/57199
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[BUGFIX] Fix comments in various places 95/57195/4
Benni Mack [Tue, 12 Jun 2018 08:21:15 +0000 (10:21 +0200)]
[BUGFIX] Fix comments in various places

There are some places where phpdoc comments and return types are wrong,
(an IDE shows this ASAP to you if you open up the file).

The patch fixes the small glitches.

Resolves: #85231
Releases: master, 8.7
Change-Id: I3550e7631b31144989d09feee79d1c96da3079db
Reviewed-on: https://review.typo3.org/57195
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 months ago[TASK] Deprecate methods in ReflectionService 96/56896/13
Alexander Schnitzler [Wed, 9 May 2018 08:13:29 +0000 (10:13 +0200)]
[TASK] Deprecate methods in ReflectionService

As the ReflectionService class is only a wrapper to call
methods on ClassSchema instances, all wrapper methods
should be deprecated and removed to make space for
a new, superior api.

Releases: master
Resolves: #85004
Change-Id: I7daabe1ab09c1c8a95b2b6dad2227c8859929dc0
Reviewed-on: https://review.typo3.org/56896
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
5 months ago[TASK] Set TYPO3 version to 9.4.0-dev 87/57187/2
Oliver Hader [Mon, 11 Jun 2018 17:16:36 +0000 (19:16 +0200)]
[TASK] Set TYPO3 version to 9.4.0-dev

Change-Id: I0281fd494612837d46966c4cdcbda5ee11c63809
Reviewed-on: https://review.typo3.org/57187
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
5 months ago[RELEASE] Release of TYPO3 9.3.0 86/57186/2 v9.3.0
Oliver Hader [Mon, 11 Jun 2018 17:14:21 +0000 (19:14 +0200)]
[RELEASE] Release of TYPO3 9.3.0

Change-Id: I4adf71f27e40df89bc77825e6771d5b249cf1ffd
Reviewed-on: https://review.typo3.org/57186
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
5 months ago[BUGFIX] Don’t cut urls in link browser 83/57183/3
Frank Naegler [Mon, 11 Jun 2018 13:31:27 +0000 (15:31 +0200)]
[BUGFIX] Don’t cut urls in link browser

Using the second parameter of TBE_EDITOR.rawurlencode cuts the input to
200 characters for any input value. The parameter is rather useless and
its usage can be simply removed to allow URLs with more than 200
characters.

Resolves: #85226
Releases: master, 8.7
Change-Id: I8391488d6fb21ede9280041dd41e3feb7e19dbd1
Reviewed-on: https://review.typo3.org/57183
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
5 months ago[BUGFIX] Remove postcss config for EXT:frontend 81/57181/2
Frank Naegler [Mon, 11 Jun 2018 12:49:01 +0000 (14:49 +0200)]
[BUGFIX] Remove postcss config for EXT:frontend

Since EXT:frontend does not have CSS files anymore, the
postcss config for Grunt is not necessary anymore.

Resolves: #85225
Releases: master
Change-Id: Ibdecf246c2841e383d745dfdfbf7f3a7181be19b
Reviewed-on: https://review.typo3.org/57181
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
5 months ago[BUGFIX] Fix broken ?? checks by adding required brackets 74/57174/4
Frank Naegler [Mon, 11 Jun 2018 09:11:53 +0000 (11:11 +0200)]
[BUGFIX] Fix broken ?? checks by adding required brackets

Resolves: #85213
Related: #84993
Releases: master
Change-Id: Ib8cd46951cb5032a7554042e2d8a7a052102788b
Reviewed-on: https://review.typo3.org/57174
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
5 months ago[TASK] Have EM only evaluate current ext_tables.sql on installation 73/57173/4
Benni Mack [Mon, 11 Jun 2018 06:34:19 +0000 (08:34 +0200)]
[TASK] Have EM only evaluate current ext_tables.sql on installation

The EM changes due to the new automatic DB fields addition for TCA-based
tables come with a small side-effect, namely that all extensions are
now evaluated when doing the SQL create queries.

The introduced changes now only do execute "safe" DB updates, but not
limited to an extension, but for all installed extensions.
Thus, non-safe DB operations are not taken into account for an extension
installation/upgrade anymore.

The patch reverts the changes to the original behaviour, so that a
follow-up patch can introduce the following behaviour:
- Install extension
- Do _safe_ DB updates for the whole system
- Do breaking DB updates for the extensions to be installed/upgraded
- Execute ext_tables_*adt.sql files + imports

Resolves: #85215
Releases: master
Change-Id: Ief1118319eb0afcd586efdff506cf44d00e02fb7
Reviewed-on: https://review.typo3.org/57173
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
5 months ago[TASK] Disallow access to .sqlite files in MS IIS demo config 53/57153/2
Christian Kuhn [Sat, 9 Jun 2018 10:15:31 +0000 (12:15 +0200)]
[TASK] Disallow access to .sqlite files in MS IIS demo config

Resolves: #85190
Related: #85188
Releases: master
Change-Id: Ia77e74753fcca2c13b0e32b2dce186723c457775
Reviewed-on: https://review.typo3.org/57153
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
5 months ago[TASK] Properly reset unit test singletons 69/57169/11
Christian Kuhn [Sun, 10 Jun 2018 17:30:14 +0000 (19:30 +0200)]
[TASK] Properly reset unit test singletons

typo3/testing-framework since version 3.8.0 can reset
singletons created by makeInstance automatically
if $this->$resetSingletonInstances is set to true.

This version additionally checks for left over singletons
in case that property has not been set and lets tests
fail in this case.

composer require --dev typo3/testing-framework:^3.8

As advantage, a manual backup of singleton instances
within tests is not needed anymore.

The patch comes with a set of test case adaptions to
cope with this new situation.

Change-Id: Ib5f278145e385e32d543541872cf5e1f208fad47
Resolves: #85209
Releases: master
Reviewed-on: https://review.typo3.org/57169
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[BUGFIX] Fix generation of create action URLs in backend user module 72/57172/3
Andreas Fernandez [Sun, 10 Jun 2018 19:09:20 +0000 (21:09 +0200)]
[BUGFIX] Fix generation of create action URLs in backend user module

The URLs to the create actions for backend users and backend groups were
built in a strange way which required some quirks to be fully functional.

This patch removes the unnecessary `explodeUrl2Array()` call, which also
renders the `rawurlencode()` obsolete.

Resolves: #85211
Releases: master
Change-Id: I3b8f5864fc398b9a4f8f2c0de5d72a38cb8a471b
Reviewed-on: https://review.typo3.org/57172
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
5 months ago[BUGFIX] Use proper import statement in ErrorController 71/57171/4
Benni Mack [Sun, 10 Jun 2018 19:02:23 +0000 (21:02 +0200)]
[BUGFIX] Use proper import statement in ErrorController

Due to moving a class name the import statement
in ErrorController was wrong.

Resolves: #85210
Related: #85101
Releases: master
Change-Id: I17cd062868ca3d0686218abd469a72cbdd08018b
Reviewed-on: https://review.typo3.org/57171
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
5 months ago[TASK] Move documentation files from master into 9.3 folder 58/57158/8
Anja Leichsenring [Sat, 9 Jun 2018 10:04:41 +0000 (12:04 +0200)]
[TASK] Move documentation files from master into 9.3 folder

Resolves: #85202
Releases: master
Change-Id: I6f61db1d2c29a3b9d4794e33cbaf2c6e634e14c7
Reviewed-on: https://review.typo3.org/57158
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
5 months ago[TASK] Remove static method variables 67/57167/5
Christian Kuhn [Sun, 10 Jun 2018 12:49:01 +0000 (14:49 +0200)]
[TASK] Remove static method variables

Static method variables are even more pita than static class
variables, especially if their state is created from db rows
or path information: It is nearly impossible to get rid of
this state at a later point again, even reflection does not
help here.

The patch abandons all 'static $foo' method variables from
the system, using these strategies:

* Remove some entirely which were used as first level cache
  and only cache-away simple non db related code structures.
* Switch some to use cache framework cache_runtime instead
  which can be evicted easily.
* Use class properties in some cases instead.

Change-Id: Ic699846a2c6ec661ee1124ace50df1aa04a1954b
Resolves: #85206
Releases: master
Reviewed-on: https://review.typo3.org/57167
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
5 months ago[BUGFIX] Documentation: use FQCN in Table Garbage Collection Tasks 66/57166/3
Michael Schams [Sun, 10 Jun 2018 10:01:47 +0000 (20:01 +1000)]
[BUGFIX] Documentation: use FQCN in Table Garbage Collection Tasks

The fully qualified class name of class `TableGarbageCollectionTask`
must be used to configure database tables, which should be cleaned up
(inactive or deleted records removed from the system).

This change replaces `tx_scheduler_TableGarbageCollection` with the
correct class name in the documentation:
\TYPO3\CMS\Scheduler\Task\TableGarbageCollectionTask::class

Releases: master
Resolves: #85205
Change-Id: I13434bf6bc13dd987263605d845f8b59b69e0796
Reviewed-on: https://review.typo3.org/57166
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[TASK] Make Tests/Unit/TypoScript/ notice free 63/57063/7
Jan Helke [Mon, 28 May 2018 11:50:57 +0000 (13:50 +0200)]
[TASK] Make Tests/Unit/TypoScript/ notice free

Releases: master
Resolves: #85092
Change-Id: I29bb5a3d0546d790d9c8d05c52f448ecefbc8564
Reviewed-on: https://review.typo3.org/57063
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[BUGFIX] Fix broken additional fields for garbarge collection task 36/57136/4
Frank Naegler [Thu, 7 Jun 2018 09:41:17 +0000 (11:41 +0200)]
[BUGFIX] Fix broken additional fields for garbarge collection task

The new IpAnonymizationAdditionalFieldProvider introduced the same
JavaScript variable which breaks the garbage collection task.
The JavaScript initialization has been removed and the field provider
simplified.

Resolves: #85068
Releases: master, 8.7, 7.6
Change-Id: Ibb307ee37d6fea33a721373bdc50bbbd3fee1453
Reviewed-on: https://review.typo3.org/57136
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[TASK] Prepare documentation move before release 52/57152/3
Anja Leichsenring [Sat, 9 Jun 2018 09:30:58 +0000 (11:30 +0200)]
[TASK] Prepare documentation move before release

New folder and includes to render the changelog for
the upcomming version.

Change-Id: I0440dcfdaf5541da5e8dbe8b8b681a477951fc14
Resolves: #85202
Releases: master
Reviewed-on: https://review.typo3.org/57152
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
5 months ago[TASK] Move MetaTagManagers of OpenGraph and Twitter to EXT:seo 62/57162/2
Benni Mack [Sat, 9 Jun 2018 18:04:46 +0000 (20:04 +0200)]
[TASK] Move MetaTagManagers of OpenGraph and Twitter to EXT:seo

The new SEO extension handles opengraph and twitter (seo-relevant),
thus do not need to stay in EXT:core, as they are only for sites which
need SEO relevant information to be processed.

Resolves: #85201
Releases: master
Change-Id: Ib0bf503bb939b47747dc32209f78f8e7ce8622c1
Reviewed-on: https://review.typo3.org/57162
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[TASK] Make core/Tests/Unit/Service/ notice free 59/57059/6
Jan Helke [Mon, 28 May 2018 11:38:33 +0000 (13:38 +0200)]
[TASK] Make core/Tests/Unit/Service/ notice free

Releases: master
Resolves: #85088
Change-Id: Ibd443902f6c89e16946d3d8d2cc39a8e2091054e
Reviewed-on: https://review.typo3.org/57059
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[TASK] Make core/Tests/Unit/Configuration notice free 59/56659/8
Jan Helke [Sat, 14 Apr 2018 14:23:35 +0000 (16:23 +0200)]
[TASK] Make core/Tests/Unit/Configuration notice free

Releases: master
Resolves: #84722
Change-Id: I0edb98c7713f5c6520cbbc33e3f85ab1b3f4946f
Reviewed-on: https://review.typo3.org/56659
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[BUGFIX] Remove TypoScript dependency of AdminPanelInitiator 47/57147/3
Susanne Moog [Fri, 8 Jun 2018 08:14:17 +0000 (10:14 +0200)]
[BUGFIX] Remove TypoScript dependency of AdminPanelInitiator

The admin panel initialization is done via middleware before the
TypoScript is fully initialized, therefor it cannot have dependencies
to parsed TypoScript (and it cannot be initialized at a later state
because of cross-dependencies with TSFE).

Before #85104 the checks did not include TypoScript - that state has
been restored and the dependency has been removed.

Resolves: #85193
Releases: master
Change-Id: Ic576b02a68ddc20f52b4b1647b0e38c51e1b7df8
Reviewed-on: https://review.typo3.org/57147
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
5 months ago[TASK] Add functional test for exbase validation caching 07/49307/15
Alexander Stehlik [Sat, 9 Jun 2018 16:50:11 +0000 (18:50 +0200)]
[TASK] Add functional test for exbase validation caching

The tests demonstrate the issue described in the ticket
is not present anymore.

Resolves: #77338
Releases: master
Change-Id: I7002b9754f556f23850fda5026861c742f70bcdc
Reviewed-on: https://review.typo3.org/49307
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[TASK] Make HtmlParserTest notice free 63/56663/8
Jan Helke [Sun, 15 Apr 2018 06:14:02 +0000 (08:14 +0200)]
[TASK] Make HtmlParserTest notice free

Releases: master
Resolves: #84724
Change-Id: I92a7ccbc88463d3fb3925185247331acf2977e40
Reviewed-on: https://review.typo3.org/56663
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[TASK] Make core/Tests/Unit/Configuration/ notice free 65/57065/5
Jan Helke [Mon, 28 May 2018 11:55:01 +0000 (13:55 +0200)]
[TASK] Make core/Tests/Unit/Configuration/ notice free

Releases: master
Resolves: #85094
Change-Id: I7fe8e2dd15fa797eef9b153bf2935187181149ae
Reviewed-on: https://review.typo3.org/57065
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[TASK] Make core/Tests/Unit/Migrations/ notice free 59/56759/2
Jan Helke [Fri, 20 Apr 2018 15:53:37 +0000 (17:53 +0200)]
[TASK] Make core/Tests/Unit/Migrations/ notice free

Releases: master
Resolves: #84816
Change-Id: I3f0bb5ab96743762977177cad1e6f125b9f23c73
Reviewed-on: https://review.typo3.org/56759
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[TASK] Make core/Tests/Unit/Mail/ notice free 51/56751/5
Jan Helke [Fri, 20 Apr 2018 09:56:26 +0000 (11:56 +0200)]
[TASK] Make core/Tests/Unit/Mail/ notice free

Releases: master
Resolves: #84808
Change-Id: Ia520395c0d4cb3a8efd6529a23a0f65d1fa9247a
Reviewed-on: https://review.typo3.org/56751
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[TASK] Make core/Tests/Unit/Resource/Driver/ notice free 69/57069/5
Jan Helke [Mon, 28 May 2018 15:05:54 +0000 (17:05 +0200)]
[TASK] Make core/Tests/Unit/Resource/Driver/ notice free

Releases: master
Resolves: #85098
Change-Id: Id2b5c7efbf2672b4731a9bd4b238a0f4be25cd5c
Reviewed-on: https://review.typo3.org/57069
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[TASK] Make NormalizeCommandTest.php notice free 66/57066/4
Jan Helke [Mon, 28 May 2018 11:56:49 +0000 (13:56 +0200)]
[TASK] Make NormalizeCommandTest.php notice free

Releases: master
Resolves: #85095
Change-Id: Iacfffe50c29a47c197c9887610bc0874007f7eec
Reviewed-on: https://review.typo3.org/57066
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[TASK] Make CategoryRegistryTest.php notice free 55/56655/4
Tymoteusz Motylewski [Thu, 31 May 2018 08:54:39 +0000 (10:54 +0200)]
[TASK] Make CategoryRegistryTest.php notice free

Releases: master
Resolves: #84721
Change-Id: I4aca40a0225a84a5af7925b34fc578f28d78b9bc
Reviewed-on: https://review.typo3.org/56655
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[TASK] Clean up MetaTagManager API 57/57157/10
Benni Mack [Sat, 9 Jun 2018 13:41:43 +0000 (15:41 +0200)]
[TASK] Clean up MetaTagManager API

Both the MetaTagManagerRegistry and the MetaTagManager are
singletons via TYPO3's SingletonInterface, thus, there is no
need for having a getInstance() within the API itself,
nor in any abstract / generic base classes.

Resolves: #85197
Releases: master
Change-Id: I9aa925a1646a4482313dd740ecc3ae45780c9432
Reviewed-on: https://review.typo3.org/57157
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
5 months ago[TASK] Store legacy deprecation file in generic log folder 60/57160/3
Benni Mack [Sat, 9 Jun 2018 15:10:34 +0000 (17:10 +0200)]
[TASK] Store legacy deprecation file in generic log folder

The deprecation log file that was used prior to v9.0, was previously
stored in typo3conf/deprecation_* which is still used for extensions
still using the old API, is now put into var/log/ where all other
log files reside.

For installations using the environment concept with
"$_ENV['TYPO3_PATH_APP']" - e.g. all installations in composer mode -
the file is now created at that place, for installations having
everything in the public web root, the file is now in
"typo3temp/var/log/deprecation_...log".

Resolves: #85198
Releases: master
Change-Id: I0fc23d9fec6cfa45241c041f64333deb90d44950
Reviewed-on: https://review.typo3.org/57160
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[TASK] Remove extra check for pageNotFoundHandling 74/57074/6
Benni Mack [Mon, 28 May 2018 19:53:11 +0000 (21:53 +0200)]
[TASK] Remove extra check for pageNotFoundHandling

This fixes a functional test in EXT:workspaces,
allowing for getting rid of an extra check in the
frontend request workflow.

Resolves: #85199
Releases: master
Change-Id: I642fca3a2873f0fe758164fca3f9261480dbc4da
Reviewed-on: https://review.typo3.org/57074
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[TASK] Store only valid icon markup into local storage 46/57146/2
Frank Naegler [Fri, 8 Jun 2018 08:02:18 +0000 (10:02 +0200)]
[TASK] Store only valid icon markup into local storage

This patch prevent putting invalid data into localStorage in the rare
case that the AJAX call does not provide icon markup.

Resolves: #85184
Releases: master
Change-Id: Icddd88232bf9ac5f77e08ed7fbac475af8b469eb
Reviewed-on: https://review.typo3.org/57146
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[BUGFIX] Ensure dynamically added TCA DB fields are added first 55/57155/4
Benni Mack [Sat, 9 Jun 2018 13:02:46 +0000 (15:02 +0200)]
[BUGFIX] Ensure dynamically added TCA DB fields are added first

The new functionality introduced in #85160 adds TCA control
database fields dynamically.
However, newly created extensions add these fields (except "uid"
which is a primary column) at the end after the content-related
fields.

The patch re-orders the columns to be added to move them to the
very beginning.

Resolves: #85195
Related: #85160
Releases: master
Change-Id: Ibcf77ae3fea41f067dca0f247bef50d00bdd014f
Reviewed-on: https://review.typo3.org/57155
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
5 months ago[TASK] Move new SEO fields to separate system extension 48/57148/17
Richard Haeser [Fri, 8 Jun 2018 09:05:36 +0000 (11:05 +0200)]
[TASK] Move new SEO fields to separate system extension

Move the new SEO fields to EXT:seo and prepare the extension for some
basic SEO features.

Resolves: #85194
Releases: master
Change-Id: I6ec087928080e217ce1824b2e9ad5cf0ca0606c8
Reviewed-on: https://review.typo3.org/57148
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
5 months ago[TASK] Remove FileStreamWrapperTest 54/57154/2
Christian Kuhn [Sat, 9 Jun 2018 11:27:34 +0000 (13:27 +0200)]
[TASK] Remove FileStreamWrapperTest

TYPO3\TestingFramework\Core\FileStreamWrapper belongs to the
testing-framework package. The unit test case has been moved
to it an can be removed from core.

Resolves: #85192
Related: #85096
Releases: master
Change-Id: I4d83f92275e34fdad3eac2550db4d3895b141f36
Reviewed-on: https://review.typo3.org/57154
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
5 months ago[TASK] Add test coverage for RouteDispatcher 95/56095/4
Christian Kuhn [Sun, 11 Mar 2018 09:31:05 +0000 (10:31 +0100)]
[TASK] Add test coverage for RouteDispatcher

The backend route dispatcher with its different controller
incarnations benefits from a basic code coverage.

Resolves: #85191
Related: #84196
Releases: master
Change-Id: I0ff1efae64c41e7fbeba8fb3569c5601cb005669
Reviewed-on: https://review.typo3.org/56095
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[TASK] Exclude tests from Composer packages 91/57091/2
Mathias Brodala [Wed, 30 May 2018 14:29:42 +0000 (16:29 +0200)]
[TASK] Exclude tests from Composer packages

Resolves: #85119
Releases: master, 8.7
Change-Id: If9c00379c1ac671bd6bb622ace47864866c34446
Reviewed-on: https://review.typo3.org/57091
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
5 months ago[TASK] Disallow access to .sqlite files 50/57150/3
Christian Kuhn [Fri, 8 Jun 2018 13:51:56 +0000 (15:51 +0200)]
[TASK] Disallow access to .sqlite files

With an upcoming feature to run TYPO3 on sqlite, the
database may end up within Web folder depending on
system setup. It may later come with additional checks to
prevent a direct database download, but it's a good
step to deny web access to .sqlite files via default
.htaccess already.

Resolves: #85188
Releases: master
Change-Id: Id382082f13fbce750b7cb3db98ddb1bc41b10f1e
Reviewed-on: https://review.typo3.org/57150
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
5 months ago[TASK] Execute functional tests on sqlite db platform 37/57137/17
Christian Kuhn [Thu, 7 Jun 2018 09:50:54 +0000 (11:50 +0200)]
[TASK] Execute functional tests on sqlite db platform

typo3/testing-framework 3.7.0 supports sqlite db platform
for functional tests. The patch updates the dependency and
adds sqlite functional tests in bamboo pre-merge and nightly.

composer update typo3/testing-framework

typo3DatabaseDriver=pdo_sqlite bin/phpunit -c \
 vendor/typo3/testing-framework/Resources/Core/Build/FunctionalTests.xml

There are some know issues already, especially the database
schema analyzer of the install tool behaves weird. However,
this patch is a first step towards sqlite support in the core.

Change-Id: I8e8474dabdf4015a32d3c938adc576fba9b5a5bd
Resolves: #85187
Releases: master
Reviewed-on: https://review.typo3.org/57137
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[BUGFIX] l10n_diffsource field can handle empty string and null value 49/57149/2
Christian Kuhn [Thu, 7 Jun 2018 09:50:54 +0000 (11:50 +0200)]
[BUGFIX] l10n_diffsource field can handle empty string and null value

Depending on DB platform, empty LOB fields can be returned
as NULL value (sqlite) or as empty string (mysql, our postgres
setup, mssql).

The patch adapts a minor detail in DataHandler since isset(null)
is false, but isset('') is true, it uses an array_key_exists()
instead for diff check on transOrigDiffSourceField / l10n_diffsource
field to align these two possible different db return values.

Resolves: #85186
Releases: master
Change-Id: I56c87fa519a0c787515eff403d48ac84e513300d
Reviewed-on: https://review.typo3.org/57149
Reviewed-by: Daniel Siepmann <daniel.siepmann@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Daniel Siepmann <daniel.siepmann@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
5 months ago[TASK] Move property merge behavior 45/57045/2
Ralf Zimmermann [Thu, 24 May 2018 07:13:44 +0000 (09:13 +0200)]
[TASK] Move property merge behavior

Move the property merge behavior from setOptions() into the related
methods (setRenderingOption(), setProperty(), setDefaultValue()).

Releases: master
Resolves: #85072
Change-Id: I1c002aeb8d889af68d6147d5c588709cd89ebf3c
Reviewed-on: https://review.typo3.org/57045
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
5 months ago[BUGFIX] Make styleguide a require-dev dependency 45/57145/3
Christian Kuhn [Fri, 8 Jun 2018 00:07:25 +0000 (02:07 +0200)]
[BUGFIX] Make styleguide a require-dev dependency

typo3/cms-styleguide has accidently been made a
require instead of a require-dev dependency
in composer.json

composer require --dev typo3/cms-styleguide ^9.1

Resolves: #85181
Related: #85180
Releases: master
Change-Id: Id109894e862ce5ac55a5533eccb8e25a9d8a6049
Reviewed-on: https://review.typo3.org/57145
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[TASK] Update typo3/cms-styleguide 44/57144/3
Christian Kuhn [Thu, 7 Jun 2018 23:46:16 +0000 (01:46 +0200)]
[TASK] Update typo3/cms-styleguide

Brings a set of new adaptions to new core functionality.
Uses new core feature 'auto-create db fields' to reduce
ext_tables.sql.

composer require typo3/cms-styleguide ^9.1

Change-Id: I386eec9da50bd3ce7eb5ebb9af8957d3b1c8d9ac
Resolves: #85180
Releases: master
Reviewed-on: https://review.typo3.org/57144
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[TASK] Modernize category collection functional tests 43/57143/5
Christian Kuhn [Thu, 7 Jun 2018 21:15:51 +0000 (23:15 +0200)]
[TASK] Modernize category collection functional tests

Use a dummy extension and .csv imports from the
functional test framework instead of creating
tables and records on the fly.

Resolves: #85179
Releases: master
Change-Id: Ia8f077984e588a2bb142a0e516aad198f914bec9
Reviewed-on: https://review.typo3.org/57143
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 months ago[BUGFIX] Allow global RTE config again by PageTSConfig 38/57138/4
Frank Naegler [Thu, 7 Jun 2018 11:23:53 +0000 (13:23 +0200)]
[BUGFIX] Allow global RTE config again by PageTSConfig

With #85016 the PageTSConfig handling has been changed which
broke overloading RTE config by PageTSConfig.
This patch removes the obsolete 'properties' check to fix the problem.

Resolves: #85173
Related: #85016
Releases: master
Change-Id: I85e6d5d9d656ee578451e54f2e226e37cb101fc6
Reviewed-on: https://review.typo3.org/57138
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 months ago[TASK] Align impexp functional export tests between db engines 41/57141/7
Christian Kuhn [Thu, 7 Jun 2018 17:37:23 +0000 (19:37 +0200)]
[TASK] Align impexp functional export tests between db engines

The ext:impexp related functional export tests compare
with different target .xml file exports depending on
the used db engine. This is ugly and pain to maintain.

The patch aligns last differences between the generated
exports by fixing sorting bugs in fixture db rows and adding
an explicit order by at test preparation stage.
Additionally, a column type bug in irre_tutorial fixture
extension got resolved.

The different .xml export file comparison fixtures per
db engine are then merged into one and the split logic
within tests removed.

Change-Id: I429d5127e09c3e3714edae938cb0bf796b3274fd
Resolves: #85178
Releases: master
Reviewed-on: https://review.typo3.org/57141
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 months ago[TASK] Force string values in impexp exports 40/57140/9
Christian Kuhn [Thu, 7 Jun 2018 13:34:59 +0000 (15:34 +0200)]
[TASK] Force string values in impexp exports

Method BackendUtility::getRecord() returns strings or integer
values for number columns like int / bigint. This detail depends
on the underlying driver, for instance mysqli returns integers
for those fields, while native pdo_mysql and our pdo_pgsql setup
return strings for everything.

This leads to different xml files when exporting records depending
on driver, since GeneralUtility::array2xml() may add type="integer".
That's especially nasty for the functional export tests and is one
reason we have to maintain dedicated xml fixture files per db driver.

During import, the type value does not matter, it needs to be able
to cope with both variants anyway.

The patch now just forces strings for all to-be-exported row values.

Resolves: #85175
Releases: master
Change-Id: Ic132d8abd906b34c59279ce025c0bdd65e954672
Reviewed-on: https://review.typo3.org/57140
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[FEATURE] Auto create management DB fields from TCA ctrl 21/57121/45
Christian Kuhn [Mon, 4 Jun 2018 12:13:23 +0000 (14:13 +0200)]
[FEATURE] Auto create management DB fields from TCA ctrl

Adds a class that auto creates TYPO3 "management" related database
columns and indexes based on TCA 'ctrl' information without having
them specified in ext_tables.sql. The feature .rst file outlines
field details.

Goals:
* Save extension developers time.
* Less copy+paste issues and different general fields definitions.
* Reduce number of boilerplate fields in ext_tables.sql.
* Bring schema of management fields under core control.

Non goals:
* No full substitution of ext_tables.sql by TCA: "Business"
  fields from 'columns' are NOT created automatically. This
  would require further thoughts and code disentangling.
* No new extension API.
* No "migration" approach or similar.

Notable patch details:
* The patch is a revamped version of issue #81234 that has been
  abandoned. As requested in the review of #81234, the code now
  hooks in after ext_tables.sql has been parsed into the doctrine
  schema.
* Field defintions of ext_tables.sql take precedence, auto fields
  are only added if ext_tables.sql does not define a column or index.
  This makes the patch fully backwards compatible.
* No deprecation for obsolete field definitions in ext_tables.sql
  is logged.
* Many core fields are aligned to a central definition and slightly
  change. For instance "uid" is now always an unsigned int.
* Reduce all core's ext_tables.sql files as well as the functional
  testing related ext_tables.sql files down to the business fields
* A relatively huge series of test adaptions: Especially the
  ext:impexp related functionals now create dumps with differently
  sorted fields - This is no problem during import.
* Field t3_origuid of sys_file_reference has never been registered
  in TCA as ['ctrl']['origUid'], is thus unused and removed as obsolete.
* The extension manager no longer applies possible destructive changes,
  it only adds missing columns and tables when loading / updating
  extensions. It however considers *all* ext_tables.sql files, not only
  the one the extension in question provides. See the important .rst
  file for details.

Change-Id: I640a7c7da3b63bac21a71102f253aa2d1bef4391
Resolves: #85160
Related: #81234
Releases: master
Reviewed-on: https://review.typo3.org/57121
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
5 months ago[BUGFIX] Make ckeditor link browser not drop additional link params 09/57009/2
Kevin Ditscheid [Fri, 18 May 2018 14:13:49 +0000 (16:13 +0200)]
[BUGFIX] Make ckeditor link browser not drop additional link params

Fix the link browser to not drop the additional link params if
editing a link with additional link params set.

Resolves: #85040
Releases: master, 8.7
Change-Id: I4c016f701b38e048aa999c4e96365019eae4a237
Reviewed-on: https://review.typo3.org/57009
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
5 months ago[TASK] Raise typo3/testing-framework to 3.6.0 34/57134/3
Christian Kuhn [Wed, 6 Jun 2018 22:14:31 +0000 (00:14 +0200)]
[TASK] Raise typo3/testing-framework to 3.6.0

composer updade typo3/testing-framework

The update brings a couple of cleanups and bug fixes
and an improved functional test case splitter script
now used in bamboo.

Resolves: #85171
Releases: master
Change-Id: I79e30fd4e93e4a1635a74e225d4801dfb1768ad4
Reviewed-on: https://review.typo3.org/57134
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[TASK] Streamline functional data handling tests 33/57133/3
Christian Kuhn [Wed, 6 Jun 2018 20:06:24 +0000 (22:06 +0200)]
[TASK] Streamline functional data handling tests

The various "AbstractActionTestCase" classes of the functional
data handling tests only prepare the scenario, while the extending
Test classes of ext:core and ext:workspaces then call parent and
add assertions.
The abstract test preparations thus must not have @test annotations,
they would be executed as casual tests without asserting anything
useful.
The patch removes those obsolete @test annotations and fixes
another test case that had wrong wrong naming and was not executed
for a while.

Resolves: #85170
Releases: master
Change-Id: Ibf6f9ef99f7eaeaeba1374962112d4a342c36567
Reviewed-on: https://review.typo3.org/57133
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[BUGFIX] Have correct test class namespaces 32/57132/2
Christian Kuhn [Wed, 6 Jun 2018 18:36:00 +0000 (20:36 +0200)]
[BUGFIX] Have correct test class namespaces

phpunit tends to execute test case files even if the
file comes with a broken namespace and can't be autoloaded.

The patch hopefully fixes all test case files that are
positioned in a wrong folder, has an otherwise broken
namespace or is not yet registered as psr-4 require-dev.

Resolves: #85169
Releases: master
Change-Id: Id8da485b14ab65a883dd90e1a11cfd8e74d85780
Reviewed-on: https://review.typo3.org/57132
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 months ago[BUGFIX] Extend ResourceStorage API to check for applied filters 44/56844/3
Nicole Cordes [Thu, 3 May 2018 10:21:59 +0000 (12:21 +0200)]
[BUGFIX] Extend ResourceStorage API to check for applied filters

Currently only the DriverInterface cares about applied filters.
The ResourceStorage received a new API function to validate a file or
folder object against applied filters as well. This ensures proper
validation for objects fetched without driver calls.

Resolves: #84908
Releases: master, 8.7
Change-Id: I5e8d35215c99aacfb330fe0eb8cfd9259b9a4199
Reviewed-on: https://review.typo3.org/56844
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
5 months ago[FEATURE] Render basic SEO meta tags in frontend 17/57117/4
Richard Haeser [Sun, 3 Jun 2018 19:06:19 +0000 (21:06 +0200)]
[FEATURE] Render basic SEO meta tags in frontend

The SEO meta tags that can be set in the page properties, will be
rendered in frontend.

Resolves: #85147
Releases: master
Change-Id: I75e6d8e50b7c8616497ee7075fddcb182551bea4
Reviewed-on: https://review.typo3.org/57117
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
5 months ago[BUGFIX] Add transparent background for tables again 26/57126/2
Andreas Fernandez [Tue, 5 Jun 2018 06:54:45 +0000 (08:54 +0200)]
[BUGFIX] Add transparent background for tables again

Resolves: #85155
Related: #85065
Releases: master
Change-Id: I0a3d89678dc23318db3cc3a3845c9c7fb3931959
Reviewed-on: https://review.typo3.org/57126
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
5 months ago[BUGFIX] Avoid fatal error in scheduler 18/57118/2
Benni Mack [Mon, 4 Jun 2018 06:48:01 +0000 (08:48 +0200)]
[BUGFIX] Avoid fatal error in scheduler

The scheduler object cleans up execution
arrays on instantiation. Due to the PSR-3
refactoring, the logger is instantiated
after the constructor is called - resulting
in a fatal error ("Call to member function info()
on null") when cleaning up the execution array.

The patch manually instantiates a logger if
there isn't one already.

Resolves: #85148
Releases: master
Change-Id: I5ff3a06a2b9d7e511d5d243df545359a48bf84b1
Reviewed-on: https://review.typo3.org/57118
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 months ago[BUGFIX] Fix minor CGL error 23/57123/2
Christian Kuhn [Mon, 4 Jun 2018 13:54:11 +0000 (15:54 +0200)]
[BUGFIX] Fix minor CGL error

A minor CGL error slipped through with a patch that has
been merged based on a +1 from bamboo before the
'declare_equal_normalize' php-cs-fixer rule has been
established.
The change should make the bamboo nightly builds green again.

Resolves: #85152
Related: #84720
Releases: master
Change-Id: Iaaf08d429780a12bf38a2865a5ae696a73cfcffb
Reviewed-on: https://review.typo3.org/57123
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
5 months ago[BUGFIX] Set correct unit test namespaces 22/57122/3
Christian Kuhn [Mon, 4 Jun 2018 12:13:23 +0000 (14:13 +0200)]
[BUGFIX] Set correct unit test namespaces

Fix a series of core unit test classes to correct namespace.

Resolves: #85151
Releases: master
Change-Id: Ibfffae113ba3114acf616e65d48d8b508eee9353
Reviewed-on: https://review.typo3.org/57122
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
5 months ago[BUGFIX] Honor l18n_cfg settings in PageRepository 38/57038/8
Georg Ringer [Tue, 22 May 2018 14:22:35 +0000 (16:22 +0200)]
[BUGFIX] Honor l18n_cfg settings in PageRepository

If a page record is fetched from the database, the PageRepository needs
to care about the l18n_cfg setting for this page.

Resolves: #85063
Releases: master, 8.7
Change-Id: Ib0338a4725a3b569b91f27baa3a59cabee6fe2fb
Reviewed-on: https://review.typo3.org/57038
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
5 months ago[BUGFIX] Correctly define allowedSubProperties of TwitterCardMetaTagManager 99/57099/9
Richard Haeser [Wed, 30 May 2018 20:56:29 +0000 (22:56 +0200)]
[BUGFIX] Correctly define allowedSubProperties of TwitterCardMetaTagManager

The properties within the allowedSubProperties have to be arrays
because the AbstractMetaTagManager checks if the property as a key
exists in the allowSubProperties.

Resolves: #85126
Releases: master
Change-Id: Ie57a77f8d4100e0861958de73faa56d80709daad
Reviewed-on: https://review.typo3.org/57099
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
5 months ago[BUGFIX] Respect showAccessRestrictedPages in MenuProcessor 34/56834/4
Frederik Holz [Wed, 2 May 2018 15:41:09 +0000 (17:41 +0200)]
[BUGFIX] Respect showAccessRestrictedPages in MenuProcessor

Menues provided by MenuProcessor will display restricted
pages, if the configuration value is set to true. This is the
same behavior as known from pure TypoScript provided menues.

Resolves: #82755
Releases: master, 8.7
Change-Id: Idf600f3ce151e2accba828c69dc601e26771686c
Reviewed-on: https://review.typo3.org/56834
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
5 months ago[BUGFIX] Try to translate given help text of select items 89/56689/4
Georg Ringer [Mon, 16 Apr 2018 14:38:16 +0000 (16:38 +0200)]
[BUGFIX] Try to translate given help text of select items

Use the LanguageService for help texts of select items.
This can be tested with the element 'select_checkbox_3' of the
styleguide extension.

Resolves: #78984
Releases: master, 8.7
Change-Id: Idb6e63547ac480b18fcb1ca997d5d07e4bcb4e81
Reviewed-on: https://review.typo3.org/56689
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 months ago[TASK] Improve overall recycler performance 02/56102/11
Andreas Fernandez [Sun, 11 Mar 2018 21:09:06 +0000 (22:09 +0100)]
[TASK] Improve overall recycler performance

To improve the overall performance of the recycler, these things are done:

- Improve how permissions are checked for each record
  Instead of running multiple SQL requests per record, the check now
  instantly stops if the user is either an admin, or has no permission
  to modify a certain table.

- Drop sorting of records by page tree structure
  The records get sorted by the page tree structure, to mime the tree in
  a flat view. However, this feature is rather useless and also
  considered buggy in a huge record set.

Resolves: #84711
Releases: master, 8.7
Change-Id: I0c5177546489ce2a0ba84435fed3879267a5a871
Reviewed-on: https://review.typo3.org/56102
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
5 months ago[TASK] Update Install Tool text 25/56825/5
Tom Warwick [Sun, 29 Apr 2018 13:52:06 +0000 (14:52 +0100)]
[TASK] Update Install Tool text

This commit is intented to improve the language
used in the Install Tool and each of its modules.

[+] Review title,subtitle and description for
each action available and update/amend where required.

Resolves: #84891
Releases: master
Change-Id: I7f71f85ae86c37786870b2c30511673fe28da7c2
Reviewed-on: https://review.typo3.org/56825
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
5 months ago[!!!][TASK] Make all enumerations final 76/56976/8
Mathias Brodala [Wed, 16 May 2018 10:57:56 +0000 (12:57 +0200)]
[!!!][TASK] Make all enumerations final

Code which uses enumerations expects a known set of values, adding
more values by extending these classes leads to undefined behavior.

Since it is now impossible to create a mock of an enumeration also
drop a few Enumeration tests and stick to testing of the public API.

Resolves: #85025
Releases: master
Change-Id: I3d0238c85ae916052dc1aa503f7f8e39c1765ac6
Reviewed-on: https://review.typo3.org/56976
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
5 months ago[BUGFIX] Only list valid forms 08/57108/4
Ralf Zimmermann [Thu, 31 May 2018 20:05:27 +0000 (22:05 +0200)]
[BUGFIX] Only list valid forms

Only list valid forms within the form manger and the form plugin.

Valid forms have an "identifier" and a "type" and the type must be "Form".

Resolves: #85132
Releases: master, 8.7
Change-Id: I2f473925b3edf839d5f965136b6b02030671350a
Reviewed-on: https://review.typo3.org/57108
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <no-reply@typo3.com>
5 months ago[TASK] Move TSFE->getPageShortcut to PageRepository 06/57106/5
Benni Mack [Thu, 31 May 2018 18:40:04 +0000 (20:40 +0200)]
[TASK] Move TSFE->getPageShortcut to PageRepository

The method `getPageShortcut()` which is marked as private is moved to
PageRepository, as it only requires logic and methods from
PageRepository.

Resolves: #85130
Releases: master
Change-Id: I4c7296e085953377e0937b8d1efad0b97d1fb021
Reviewed-on: https://review.typo3.org/57106
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
5 months ago[BUGFIX] Fix method call matcher arguments config 10/57110/2
Mathias Brodala [Fri, 1 Jun 2018 10:31:50 +0000 (12:31 +0200)]
[BUGFIX] Fix method call matcher arguments config

Resolves: #85139
Releases: master
Change-Id: Iadcfdb2bcc5dd0ebf3eeb535171a43c3a54afe47
Reviewed-on: https://review.typo3.org/57110
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
5 months ago[BUGFIX] Fix extension data import on sqlite 03/57103/7
Susanne Moog [Thu, 31 May 2018 11:53:56 +0000 (13:53 +0200)]
[BUGFIX] Fix extension data import on sqlite

Sqlite limits the maximum number of variables
allowed in a query. When importing the extension
list the chunks are too big (> 999 variables).

This has been chunked to enable import on sqlite.

Resolves: #85129
Releases: master
Change-Id: If65476707946f4078a1b1e55128239aed07f6ed8
Reviewed-on: https://review.typo3.org/57103
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
5 months ago[TASK] Deprecate Backend Module Routing methods 48/57048/5
Benni Mack [Fri, 25 May 2018 09:15:29 +0000 (11:15 +0200)]
[TASK] Deprecate Backend Module Routing methods

Since TYPO3 v9.0, all routing in backend is handled unified, thus, the old
methods from historical reasons can be deprecated.

- BackendUtility::getModuleUrl()
- UriBuilder->buildUriFromModule()

Instead of guessing the name to a module route, an "id" for the route (like the path)
can be explictly given.

Resolves: #85113
Releases: master
Change-Id: I8cf2b9dc3a938dd7227dcc972e0782619ede4213
Reviewed-on: https://review.typo3.org/57048
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 months ago[BUGFIX] Correctly resolve RTE preset configuration for link browser 81/56881/7
Tymoteusz Motylewski [Tue, 29 May 2018 22:40:49 +0000 (00:40 +0200)]
[BUGFIX] Correctly resolve RTE preset configuration for link browser

Replaces hardcoded RTE configuration in BrowseLinksController
with one resolved by Formengine when rendering a field.
This takes into account e.g. column overrides.

The RTE configuration preset name is now kept by Formengine in
['processedTca']['columns'][$fieldName]['config']['richtextConfigurationName']

Then it's being passed as parameter P[richtextConfigurationName] from RTE field
to the BrowseinksController

Resolves: #84943
Releases: master, 8.7
Change-Id: Id4f1c350f6eb6dfad4d49ec759a23939bbc45eda
Reviewed-on: https://review.typo3.org/56881
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Tested-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
5 months ago[BUGFIX] Fix inSet implementation for sqlite 07/57107/4
Susanne Moog [Thu, 31 May 2018 19:23:45 +0000 (21:23 +0200)]
[BUGFIX] Fix inSet implementation for sqlite

For SQLite inSet was implemented with a "like" substitution
which had various bugs. That implementation has
now been substituted with an "instr" implementation.

Resolves: #85131
Releases: master
Change-Id: Id4e8f7132800c991e49d4033d2b01f474b6aae3b
Reviewed-on: https://review.typo3.org/57107
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
5 months ago[BUGFIX] Handle access restrictions on recycler search 52/57052/9
Nicole Cordes [Fri, 25 May 2018 12:05:16 +0000 (14:05 +0200)]
[BUGFIX] Handle access restrictions on recycler search

Fetching a parent folder may throws an error if the user hasn't
access to the parent. This exception needs to be caught and the
search for an existing recycler folder needs to be stopped
immediately.

Furthermore the patch removes the comparison with the root level
folder but checks the parent folder doesn't equal the folder itself.

Another loop is fixed by calling moveFile on the correct
ResourceStorge and not the current one.

Resolves: #85079
Related: #81836
Releases: master, 8.7
Change-Id: I51f5e20d7fa7da9b350ac0ca60cab05866a4d337
Reviewed-on: https://review.typo3.org/57052
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
5 months ago[BUGFIX] Statement::rowCount not reliable for SELECT queries 83/50083/10
Susanne Moog [Thu, 31 May 2018 13:43:36 +0000 (15:43 +0200)]
[BUGFIX] Statement::rowCount not reliable for SELECT queries

Concerning the usage of Statement::rowCount() the Doctrine DBAL
documentation states the following:

  Returns the number of rows affected by the last
  DELETE, INSERT, or UPDATE statement
  executed by the corresponding object.

For default configurations using MySQL as platform,
rowCount() is returning the expected
value for SELECT statements as well.
However, on other DBMS this value will be zero
as mentioned in the documentation - for instance
SQLite is a candidate for that.

For retrieving the row count for given criteria, the count()
expression has to be used explicitly.

Resolves: #78129
Releases: master
Change-Id: Id28d72a1a21e8615ec45b63d4aecc100d03a39a3
Reviewed-on: https://review.typo3.org/50083
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
5 months ago[TASK] Deprecate Redirecting UrlHandler Hook Concept 96/57096/3
Tymoteusz Motylewski [Wed, 30 May 2018 21:50:42 +0000 (23:50 +0200)]
[TASK] Deprecate Redirecting UrlHandler Hook Concept

The concept for custom UrlHandlers, introduced in TYPO3 v7 for extracting JumpURL
into a TER extension has been deprecated in favor of PSR-15.

These could be registered via
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['urlProcessing']['urlHandlers']

The methods related to that functionality have been deprecated.
- $TSFE->initializeRedirectUrlHandlers()
- $TSFE->redirectToExternalUrl()

However, the core-internal calls have been marked with a property to ensure
that no deprecation warning is triggered, but the functionality can be kept.

Resolves: #85124
Releases: master
Change-Id: Ie49d7200618d2b8ffdd5394ea9c649c123719b07
Reviewed-on: https://review.typo3.org/57096
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
5 months ago[TASK] Make FileBackendTest.php notice free 54/56654/2
Jan Helke [Sat, 14 Apr 2018 11:17:48 +0000 (13:17 +0200)]
[TASK] Make FileBackendTest.php notice free

Releases: master
Resolves: #84720
Change-Id: If13dfe85fcb41ce3a361fbb184d95c5ddffaf958
Reviewed-on: https://review.typo3.org/56654
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Maroschik <tmaroschik@dfau.de>
Tested-by: Thomas Maroschik <tmaroschik@dfau.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Kay Strobach <typo3@kay-strobach.de>
Tested-by: Kay Strobach <typo3@kay-strobach.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
5 months ago[TASK] Deprecate usages of CharsetConverter in core 97/57097/4
Benni Mack [Wed, 30 May 2018 20:20:56 +0000 (22:20 +0200)]
[TASK] Deprecate usages of CharsetConverter in core

CharsetConverter is still instantiated in some places and not needed at all times.

The following places have CharsetConverter completely removed (as internal property):
- PageRenderer
- SearchController
- Indexer

The AbstractHierarchicalFilesystemDriver's shorthand method getCharsetConversion()
has been deprecated, as drivers should instantiate the CharsetConversion themself.

Indexed Search's Lexer has a public property "csObj" which has been switched to
protected, where a deprecation message will be thrown.

Resolves: #85125
Releases: master
Change-Id: I48fd110ecd25bb6a4225a3d2141edc5fc3b92673
Reviewed-on: https://review.typo3.org/57097
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
5 months ago[BUGFIX] Allow value for CLI command cleanup:versions --action argument 55/57055/3
Simon Gilli [Fri, 25 May 2018 17:48:07 +0000 (19:48 +0200)]
[BUGFIX] Allow value for CLI command cleanup:versions --action argument

Allow the usage of a value for --action argument of the CLI command
cleanup:versions as mentioned in the documentation and the
implementation.

Resolves: #85085
Related: #79109
Related: #82653
Releases: master, 8.7
Change-Id: I6c07303728bcb527b44a6c5bf811870f25398a21
Reviewed-on: https://review.typo3.org/57055
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
5 months ago[FEATURE] Use new TypoScript and TSConfig files extension 83/57083/6
Tymoteusz Motylewski [Tue, 29 May 2018 20:29:56 +0000 (22:29 +0200)]
[FEATURE] Use new TypoScript and TSConfig files extension

It was decided to use .typoscript and .tsconfig
The patch renames the files and adds little BC layer which allows
you to include TypoScript files using old (.txt) file extension.

Resolves: #81686
Releases: master
Change-Id: Id6784e4f573e2e0b060f37d241c07216ac5678e1
Reviewed-on: https://review.typo3.org/57083
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
5 months ago[TASK] Deprecate PageRepository->versioningPreview 47/57047/9
Benni Mack [Fri, 25 May 2018 08:40:05 +0000 (10:40 +0200)]
[TASK] Deprecate PageRepository->versioningPreview

PageRepository has two public properties regarding
fetching records for versioned records:
- versioningPreview (bool)
- versioningWorkspaceId (int)

In order to allow previews of versions, a workspace ID
has to be set - otherwise it fetches live records.

Basically things like: $versioningPreview=false,
$versioningWorkspaceId=3 will make things more confusing.

Instead, versioningPreview is not in use anymore,
and PageRepository solely relies on the parameter
of the workspaceId set.

Resolves: #85078
Releases: master
Change-Id: I70f028854ebc1a83d6d5af18de507284ae89b2ac
Reviewed-on: https://review.typo3.org/57047
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[BUGFIX] Fix indexed search TypoScript settings documentation 89/57089/7
Harry Glatz [Wed, 30 May 2018 10:44:36 +0000 (12:44 +0200)]
[BUGFIX] Fix indexed search TypoScript settings documentation

Releases: master, 8.7
Resolves: #85117
Related: #32030
Change-Id: I6af62c8337865e8a76c2dd8593f5afa38e0c2d26
Reviewed-on: https://review.typo3.org/57089
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
5 months ago[BUGFIX] Remember selected page in fsMod and refactor page selection 76/57076/3
Tymoteusz Motylewski [Mon, 28 May 2018 16:55:29 +0000 (18:55 +0200)]
[BUGFIX] Remember selected page in fsMod and refactor page selection

Currently selected page is remembered in the fsMod js object.
The JS code responsible for handling click on the node text and node
background is refactored. Now both uses node.checked property.

Resolves: #85100
Resolves: #85106
Releases: master
Change-Id: I08768e82a62e942c247d968df707bf64426e1dab
Reviewed-on: https://review.typo3.org/57076
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
5 months ago[TASK] Deprecate T3_ERR_SV_ constants 95/57095/3
Benni Mack [Wed, 30 May 2018 19:26:21 +0000 (21:26 +0200)]
[TASK] Deprecate T3_ERR_SV_ constants

The following constants related to the Services in TYPO3 have been moved into AbstractService
as class constants, effectively moving them in the right context.

- T3_ERR_SV_GENERAL
- T3_ERR_SV_NOT_AVAIL
- T3_ERR_SV_WRONG_SUBTYPE
- T3_ERR_SV_NO_INPUT
- T3_ERR_SV_FILE_NOT_FOUND
- T3_ERR_SV_FILE_READ
- T3_ERR_SV_FILE_WRITE
- T3_ERR_SV_PROG_NOT_FOUND
- T3_ERR_SV_PROG_FAILED

The Extension scanner will detect usages of these constants. The constants will
be removed in TYPO3 v10.

Resolves: #85123
Releases: master
Change-Id: I9df12e51deda77903aff83769d4f2a532b2676fb
Reviewed-on: https://review.typo3.org/57095
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
5 months ago[TASK] Deprecate various functionality in CharsetConverter 94/57094/3
Benni Mack [Wed, 30 May 2018 13:29:38 +0000 (15:29 +0200)]
[TASK] Deprecate various functionality in CharsetConverter

Due to native support and a polyfill for mb_string(), lot of functionality of
CharsetConverter was simplified throughout TYPO3 in the last release
to ensure faster charset conversion.

Many methods and properties within CharsetConverter can be deprecated
now:
- CharsetConverter->synonyms
- CharsetConverter->parse_charset()
- Fourth parameter of CharsetConverter->conv()
- CharsetConverter->convArray()
- CharsetConverter->utf8_to_entities()
- CharsetConverter->entities_to_utf8()
- CharsetConverter->crop()
- CharsetConverter->convCaseFirst()
- CharsetConverter->utf8_char2byte_pos()

Additionally the following public properties have been changed to have a "protected"
visibility, as this only reflects internal state:
- CharsetConverter->noCharByteVal
- CharsetConverter->parsedCharsets
- CharsetConverter->toASCII
- CharsetConverter->twoByteSets
- CharsetConverter->eucBasedSets

Resolves: #85122
Releases: master
Change-Id: Ic67dd1cffa36cd625c844ae82fdca8447a317efe
Reviewed-on: https://review.typo3.org/57094
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[TASK] Add Site Configuration to ConfigurationController 44/56644/5
Simon Gilli [Fri, 13 Apr 2018 01:26:06 +0000 (03:26 +0200)]
[TASK] Add Site Configuration to ConfigurationController

Add the Site Configuration to the ConfigurationController to
simplify debugging and enable its inspection at the backend.

Resolves: #84709
Releases: master
Change-Id: Ib0720f372a2d27873fda9931c8753c7ed6a98750
Reviewed-on: https://review.typo3.org/56644
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
5 months ago[TASK] Deprecate JavaScriptEncoder class 93/57093/2
Benni Mack [Wed, 30 May 2018 17:25:09 +0000 (19:25 +0200)]
[TASK] Deprecate JavaScriptEncoder class

The JavaScriptEncoder class was superseded with GeneralUtility::quoteJSvalue() in TYPO3 6.2
and is not used anymore. It is marked as deprecated.

Resolves: #85120
Releases: master
Change-Id: I13cb97e3ff6bb23d937a5193d392f92eb759ba9d
Reviewed-on: https://review.typo3.org/57093
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[TASK] CharsetConverter: Remove Case Folding 90/57090/2
Benni Mack [Wed, 30 May 2018 12:44:05 +0000 (14:44 +0200)]
[TASK] CharsetConverter: Remove Case Folding

Special Case Folding within CharsetConverter is not used anymore, and can be removed.

The public property $caseFolding used as runtime cache is removed, as it was never possible
to fill it either to have it accessed from the outside.

The SpecialCasing.txt file has no meaning anymore and can be removed.

Resolves: #85118
Releases: master
Change-Id: Ib770fe99a97ac06c4f9c485e960c681ab21c9113
Reviewed-on: https://review.typo3.org/57090
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 months ago[TASK] Change visibility of CharsetConverter init methods 88/57088/3
Benni Mack [Wed, 30 May 2018 09:44:32 +0000 (11:44 +0200)]
[TASK] Change visibility of CharsetConverter init methods

Various CharsetConverter methods are there for initialization conversion,
which are marked as @private and are only used within the class.

The patch switches the method signatures from public to protected.

The following methods are affected:
- initCharset()
- initUnicodeData()
- initCaseFolding()
- initToASCII()

Resolves: #85116
Releases: master
Change-Id: I153123068cbfbf0baee729aab7dc0946913d5d7c
Reviewed-on: https://review.typo3.org/57088
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>