Packages/TYPO3.CMS.git
10 months ago[TASK] Update columns in DocHeader bar 68/60368/4
Koen Wouters [Wed, 3 Apr 2019 18:57:40 +0000 (20:57 +0200)]
[TASK] Update columns in DocHeader bar

Dropdown fields will now stay next to each other for
responsive views.

Resolves: #88065
Releases: master, 9.5
Change-Id: I1990dc87dd69fd6c5470197277dc86c84f6c29de
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60368
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: André Schließer <andy.schliesser@gmail.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: André Schließer <andy.schliesser@gmail.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
10 months ago[TASK] Migrate TYPO3/CMS/Linkvalidator/* to TypeScript 55/60255/3
Frank Naegler [Fri, 15 Mar 2019 09:47:54 +0000 (10:47 +0100)]
[TASK] Migrate TYPO3/CMS/Linkvalidator/* to TypeScript

Resolves: #87920
Releases: master
Change-Id: Ibb3d28e85b6beddfd4bacca8303cca51c46ac6b3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60255
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
10 months ago[BUGFIX] Reenable Page TSconfig setting mod.web_list.hideTranslations 72/60372/3
Jan Helke [Fri, 5 Apr 2019 07:34:53 +0000 (09:34 +0200)]
[BUGFIX] Reenable Page TSconfig setting mod.web_list.hideTranslations

This regression fix reenables the setting mod.web_list.hideTranslations to
enable administrators to hide translations in the list view.
This behaviour is already described under
https://docs.typo3.org/typo3cms/TSconfigReference/PageTsconfig/Mod.html

Resolves: #88084
Releases: master, 9.5
Change-Id: I8bc0ce072a44c78564889325c888eb26fdb23a1c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60372
Tested-by: Sebastian Rosskopf <sebastian.rosskopf@gmx.de>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Raphael Thanner <r.thanner@zeroseven.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Windloff
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Sebastian Rosskopf <sebastian.rosskopf@gmx.de>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Raphael Thanner <r.thanner@zeroseven.de>
Reviewed-by: Daniel Windloff
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
10 months ago[BUGFIX] Refine build architecture 35/60335/9
Andreas Fernandez [Mon, 25 Mar 2019 15:52:34 +0000 (16:52 +0100)]
[BUGFIX] Refine build architecture

TypeScript:
Due to issues with upcoming TypeScript versions, the TypeScript sources
are moved into the Build directory before building JavaScript.

The unused Grunt task `tsdev` has been removed.

Additionally, some type defintions have been installed:

  yarn add --dev \
      @types/bootstrap-slider \
      @types/datatables.net \
      @types/chosen-js

Sass:
The Sass sources have been moved into the common "Sources" directory.
Those source files are moved to have a less cluttered Build directory.

Note: With this patch, all TypeScript files must be placed into
`Build/Sources/TypeScript` to be compiled by tsc again.

Resolves: #88043
Releases: master
Change-Id: I4d3e5f69564c38a35bf083652ea7262f5b85e4f3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60335
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
10 months ago[BUGFIX] Fix null coalesce evalutation in PageLayoutView::getLocalizedPageTitle() 00/60400/2
Andreas Fernandez [Fri, 5 Apr 2019 14:42:53 +0000 (16:42 +0200)]
[BUGFIX] Fix null coalesce evalutation in PageLayoutView::getLocalizedPageTitle()

This commit fixes a usage of the null coalesce operator within a condition.

Resolves: #88092
Related: #84375
Releases: master, 9.5
Change-Id: Ic34fb492e66eb224d0e617405e8ae2be69a16aa4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60400
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: André Schließer <andy.schliesser@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: André Schließer <andy.schliesser@gmail.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
10 months ago[BUGFIX] Deliver detected file type for IM identify 11/60311/7
Benni Mack [Fri, 22 Mar 2019 19:28:20 +0000 (20:28 +0100)]
[BUGFIX] Deliver detected file type for IM identify

Although not used in TYPO3 Core directly, the identify
command by ImageMagick now delivers the file extension
from IM plus the file type identified by IM as well.

This saves some regexp magic, and a foreach() loop,
as the "-format" output delivers proper IM results.

As this functionality is not actually fixing a core
bug, but rather a small improvement and correction
in the identified usage, the change is targeted to master-only.

Resolves: #23348
Releases: master
Change-Id: Ia380ee34dbbef7f9f763ecc088ee0c9b83167ce6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60311
Tested-by: Sebastian Rosskopf <sebastian.rosskopf@gmx.de>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Sebastian Rosskopf <sebastian.rosskopf@gmx.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
10 months ago[BUGFIX] DB check - search query, array handling on operator change 42/60342/3
Henrik Elsner [Tue, 26 Mar 2019 15:04:14 +0000 (16:04 +0100)]
[BUGFIX] DB check - search query, array handling on operator change

Exception is thrown when changing the operator from an array handling one
to a string handling. ("is in list" to "equals")
Also the selection is not set properly after changing.

Resolves: #88010
Releases: master, 9.5

Change-Id: Ibf7f607a51ac92d2c45dbfe16384f71c959e6c1f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60342
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Daniel Windloff
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
10 months ago[TASK] Remove superfluous function calls in page module 99/60399/2
Markus Klein [Fri, 5 Apr 2019 14:23:30 +0000 (16:23 +0200)]
[TASK] Remove superfluous function calls in page module

Resolves: #88091
Releases: master, 9.5
Change-Id: I3261190c1214dece4dce5d208a54af2b14b3aa0e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60399
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
10 months ago[BUGFIX] Use SiteFinder in SearchController for getting all languages 37/60337/4
Georg Ringer [Mon, 25 Mar 2019 20:59:25 +0000 (21:59 +0100)]
[BUGFIX] Use SiteFinder in SearchController for getting all languages

The SiteFinder must be used instead of only fetching all languages from
sys_language.

Resolves: #87999
Releases: master, 9.5
Change-Id: I95432c6221a8ee06d1fbb45a6780b0ec7c80ddf4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60337
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
10 months ago[TASK] Handle configured error level only in error handler 87/59287/9
Christoph Lehmann [Sun, 23 Dec 2018 14:13:33 +0000 (15:13 +0100)]
[TASK] Handle configured error level only in error handler

Currently there is no way to determine the error level of a previously
registered error handler.

The commit helps chaining error handlers and prevents unnecessary extra
work.

Resolves: #87281
Releases: master, 9.5
Change-Id: Ib6cc32eeb4714cae1dd16aa5382683c374615d38
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59287
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
10 months ago[BUGFIX] Use Sitematcher to fetch available languages 38/60338/3
Georg Ringer [Tue, 26 Mar 2019 07:02:44 +0000 (08:02 +0100)]
[BUGFIX] Use Sitematcher to fetch available languages

EXT:viewpage must use the SiteMatcher to get the available languages.

The join functionality has been removed as well to let users view a page
in a fallback language.

Resolves: #88001
Releaes: master, 9.5
Change-Id: Ibd0be7b2d169a7e8fb029905e3221fdd3ee5d69c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60338
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: André Schließer <andy.schliesser@gmail.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: André Schließer <andy.schliesser@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
10 months ago[TASK] Remove limit in be_groups fields 01/60301/2
Guido Schmechel [Wed, 20 Mar 2019 20:54:09 +0000 (21:54 +0100)]
[TASK] Remove limit in be_groups fields

With this change, there are no more restrictions
in TCA within the be_groups.

Resolves: #87967
Releases: master, 9.5
Change-Id: Ifc1cf2b41c15c43dd5a1e314c0cb0a418753455a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60301
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
10 months ago[TASK] Adjust documentation for custom routing enhancer registration 69/60369/3
Kevin Meckl [Wed, 3 Apr 2019 20:38:26 +0000 (22:38 +0200)]
[TASK] Adjust documentation for custom routing enhancer registration

Correct example TYPO3_CONF_VARS configuration for custom route enhancers
registration.

Releases: master, 9.5
Resolves: #88067
Change-Id: I0870498781f496d9c00331af126b96fd77eee70d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60369
Tested-by: Sebastian Rosskopf <sebastian.rosskopf@gmx.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: André Schließer <andy.schliesser@gmail.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Sebastian Rosskopf <sebastian.rosskopf@gmx.de>
Reviewed-by: André Schließer <andy.schliesser@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
10 months ago[BUGFIX] Improved visibility error message in install tool 77/60377/6
Chau kar [Fri, 5 Apr 2019 10:33:46 +0000 (12:33 +0200)]
[BUGFIX] Improved visibility error message in install tool

Removed the absolute positioning of the error page to avoid unexpected
behavior when rendered in an encapsulated component, e.g. panels in the
Install Tool.

Resolves: #88064
Resolves: #87382
Releases: master, 9.5
Change-Id: I5cefeacc0f753ab57c8c1e95dffa39eb55f5950e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60377
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
10 months ago[BUGFIX] Remove hard coded path to LocalConfiguration.php 74/60374/2
Helmut Hummel [Fri, 5 Apr 2019 09:00:00 +0000 (11:00 +0200)]
[BUGFIX] Remove hard coded path to LocalConfiguration.php

Instead of hard coding the path, the ConfigurationManager API
ist now used.

Resolves: #88089
Releases: master, 9.5
Change-Id: I51b6c75583e54f00535538d6afdcb617d86f6079
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60374
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Wolf-Peter Utz <wpu@hotmail.de>
Tested-by: Sebastian Rosskopf <sebastian.rosskopf@gmx.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Wolf-Peter Utz <wpu@hotmail.de>
Reviewed-by: Sebastian Rosskopf <sebastian.rosskopf@gmx.de>
Reviewed-by: Benni Mack <benni@typo3.org>
10 months ago[BUGFIX] Show correct timestamp in file replace dialog 73/60373/4
Manuel Selbach [Fri, 5 Apr 2019 08:34:53 +0000 (10:34 +0200)]
[BUGFIX] Show correct timestamp in file replace dialog

The property lastModifiedDate was remove by some browsers, thus with
this change if will be checked and the proper property is used to
parse the timestamp in the replace dialog.

Resolves: #88081
Releases: master, 9.5, 8.7
Change-Id: I4ae812267ef81c4db5c86d2d6dd814f83bebeb00
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60373
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Felix Herrmann <herrmann@riconet.de>
Tested-by: Wolf-Peter Utz <wpu@hotmail.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Felix Herrmann <herrmann@riconet.de>
Reviewed-by: Wolf-Peter Utz <wpu@hotmail.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
10 months ago[BUGFIX] Avoid PHP notice in DataHandler 48/60348/7
Markus Klein [Wed, 27 Mar 2019 16:12:21 +0000 (17:12 +0100)]
[BUGFIX] Avoid PHP notice in DataHandler

The fifth parameter to Datahandler::insertDB() is used in one place
without properly checking for the existence of the array element.
In general this parameter is only used for imp/exp extension
and works for admins only.

Resolves: #88025
Releases: master, 9.5
Change-Id: Iba5656857b1b16fb601a3c6af424a6477edc6956
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60348
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
10 months ago[TASK] Prepare Frontend Tests for additional site handling tests 63/60363/4
Benni Mack [Wed, 3 Apr 2019 09:55:36 +0000 (11:55 +0200)]
[TASK] Prepare Frontend Tests for additional site handling tests

Some test functionality regarding Site Handling is now sorted out in order
to add more tests.

- SiteConfiguration setup for tests is moved into a separate Trait.
- Code which is also used (in the future) for EXT:core and not
   just frontend is moved to EXT:core
- LocalizedFrontendPages now have a slug field as well.
- Regular Frontend JsonRenderer now also renders values
  from SiteLanguage config + context aspect

Resolves: #88060
Releases: master, 9.5
Change-Id: If859da89e4fcec16e3d1c2abb934eef040d4f386
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60363
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
10 months ago[BUGFIX] Enable preview of hidden page translations 31/60331/4
Daniel Goerz [Mon, 25 Mar 2019 14:23:42 +0000 (15:23 +0100)]
[BUGFIX] Enable preview of hidden page translations

TSFE->determineIdIsHiddenPage() now takes the current site language into
account when fetching the page record. When rendering a page translation
the mehtod does no longer reflect the hidden status of the default
language but the status of the translated page instead.

This enables previewing a hidden page translation even if the language
parent is active.

Resolves: #85471
Releases: master, 9.5
Change-Id: I1b0ead8eaf4c707583e24babbbca49870a31cdaa
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60331
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
10 months ago[BUGFIX] Check if fileObject width is greater than 0, if not use maxWidth 57/60357/2
Riny van Tiggelen [Mon, 1 Apr 2019 16:00:50 +0000 (18:00 +0200)]
[BUGFIX] Check if fileObject width is greater than 0, if not use maxWidth

If you want to use a PDF inside the GalleryProcessor, the mediaWidth is
always 0, because there are no dimensions in the metadata. This fix
will use the maxMediaWidth if the dimension is not greater than 0.

Resolves: #88047
Releases: master, 9.5
Change-Id: I56a2dc2a946385931172c86e54711ba8aa3f6637
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60357
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Koen Wouters <koen.wouters@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Koen Wouters <koen.wouters@maxserv.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
10 months ago[TASK] Documentation links to invalid URL 55/60355/3
Daniel Huf [Mon, 1 Apr 2019 08:51:08 +0000 (10:51 +0200)]
[TASK] Documentation links to invalid URL

The link must be prefixed with www, else the request will just show
an error.

Releases: master, 9.5, 8.7
Resolves: #88044
Change-Id: I2a7e5f34a741e92fdc1174d8be73204c19c197eb
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60355
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
10 months ago[BUGFIX] Use SiteMatcher in TranslationConfigurationProvider 36/60336/2
Georg Ringer [Mon, 25 Mar 2019 20:13:43 +0000 (21:13 +0100)]
[BUGFIX] Use SiteMatcher in TranslationConfigurationProvider

The TranslationConfigurationProvider must use the SiteMatcher
to find the proper languages and must not depend only on fetching
from sys_language.

Resolves: #87942
Releases: master, 9.5
Change-Id: Ib8b8a980d7997effa38a6c2dcfbe8a3e7e3eb1a6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60336
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
10 months ago[TASK] Migrate TYPO3/CMS/Lowlevel/* to TypeScript 57/60257/3
Frank Naegler [Fri, 15 Mar 2019 12:51:06 +0000 (13:51 +0100)]
[TASK] Migrate TYPO3/CMS/Lowlevel/* to TypeScript

Resolves: #87922
Releases: master
Change-Id: I77f1973c656b3b2538a37cd2f4dc2b04358a7198
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60257
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
11 months ago[TASK] Fix Changelog associated with extension scanner for services 40/60340/3
Sybille Peters [Tue, 26 Mar 2019 11:43:02 +0000 (12:43 +0100)]
[TASK] Fix Changelog associated with extension scanner for services

- Use different Changelog entry in extension scanner for
  AbstractAuthenticationService and AuthenticationService
- Add links to Changelog
- Change title in Changelog

Resolves: #88005
Releases: master, 9.5

Change-Id: I6852a7511bda74bee398ef86b8ca59f7d7454e5a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60340
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
11 months ago[BUGFIX] Update ColorPicker to use cleaned minicolors hex value 52/59052/5
Filipe DA COSTA [Fri, 7 Dec 2018 12:20:21 +0000 (13:20 +0100)]
[BUGFIX] Update ColorPicker to use cleaned minicolors hex value

Force ColorPicker to use the formatted/cleaned value jQuery's minicolors
produces instead of just displaying it but still saving the raw value
the user inputs.

Resolves: #87031
Releases: master, 9.5
Change-Id: I49d9f094961137ae50561475d5421f536b705c70
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59052
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Henrik Elsner <helsner@dfau.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Henrik Elsner <helsner@dfau.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
11 months ago[BUGFIX] DB check > Search: Convert `--div--` to optgroup 05/60305/4
Andreas Fernandez [Thu, 21 Mar 2019 16:24:24 +0000 (17:24 +0100)]
[BUGFIX] DB check > Search: Convert `--div--` to optgroup

Querying the database for the placeholder `--div--` is rather pointless,
thus this possibility is removed. Instead, the placeholder is converted
into an optgroup.

Resolves: #87976
Releases: master, 9.5
Change-Id: I60729a3fae1bc37c12612fccf0f8491ad27d8908
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60305
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Henrik Elsner <helsner@dfau.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Henrik Elsner <helsner@dfau.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
11 months ago[DOCS] Fix path of Changelog 39/60339/2
Sybille Peters [Tue, 26 Mar 2019 10:44:19 +0000 (11:44 +0100)]
[DOCS] Fix path of Changelog

Resolves: #88006
Releases: master
Change-Id: I02cacfe4829b975411026acd4bfd0bb700a38153
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60339
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
11 months ago[BUGFIX] Remove setDBinit from tests 12/59012/2
Stefan Neufeind [Sun, 2 Dec 2018 19:00:38 +0000 (20:00 +0100)]
[BUGFIX] Remove setDBinit from tests

Default is utf8 for the database-charset meanwhile.

Resolves: #87052
Releases: master
Change-Id: I4ec21f979a2b3e95ba30e10b94c538cde378b75d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59012
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
11 months ago[TASK] Remove leftover unused code in various PHP classes 20/60320/5
Benni Mack [Sat, 23 Mar 2019 21:49:37 +0000 (22:49 +0100)]
[TASK] Remove leftover unused code in various PHP classes

Due to removal of functionality and code in recent TYPO3 versions,
internal code can now be removed:

- PermissionAjaxController->getBackendUser()
- RteHtmlParser->TS_AtagToAbs (never called)
- PageRenderer->extOnReadyCode property
- SetupModuleController
  - used several properties from the now removed "simulateUser"
     code which is not part of this module anymore.
  - At the same time, various "init" and "main" methods which are now protected are
    reordered to reflect the set up request workflow better.

Resolves: #87991
Releases: master
Change-Id: I197a13ff64b3cb006730d09120d0bd8d5c5c65f0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60320
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
11 months ago[BUGFIX] Use live record uid for preview in workspace 70/55070/8
Christian Weiske [Tue, 26 Jun 2018 19:46:25 +0000 (21:46 +0200)]
[BUGFIX] Use live record uid for preview in workspace

When editing a record in a workspace in the Backend,
the "preview" button needs to use the live record uid
and not the uid of the workspace version.

Change-Id: I690c11e50b6275290175397cc9f28e1532b1d61d
Releases: master, 9.5
Resolves: #81271
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/55070
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
11 months ago[BUGFIX] Resolve and link modified slugs in workspaces properly 55/59955/6
Benni Mack [Sat, 9 Mar 2019 13:36:57 +0000 (14:36 +0100)]
[BUGFIX] Resolve and link modified slugs in workspaces properly

When a page (slug) is modified in a preview workspace,
links to that page need to be changed to the new slug, as the
preview (PageRouter) should evaluate this as well.

1) The PageRouter should include records with "-1"
to find them as well, but then fix the "pid" again to
find the pid of the online version.

2) The PageLink Builder now uses the SiteFinder nstead of SiteMatcher
to detect whether the linked page uid is part of a configured site.
We do not need to create/detect a PseudoSite here, only instances
of Site are of interest.

Resolves: #87871
Releases: master, 9.5
Change-Id: Ifd6add71bec1616049f8c6a50a42bc9f573395e2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59955
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
11 months ago[BUGFIX] Avoid cHash mismatches when previewing workspace changes 27/60327/2
Oliver Hader [Mon, 25 Mar 2019 10:09:40 +0000 (11:09 +0100)]
[BUGFIX] Avoid cHash mismatches when previewing workspace changes

In order to avoid cHash mismatches URL parameter 'ADMCMD_prev' is
not being used for cHash calculation anymore.

Resolves: #87995
Releases: master, 9.5
Change-Id: Ifefefc873478759a15aed786e16b062e28c739f9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60327
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
11 months ago[TASK] Add be_user id to LinkGenerator page-version test context 02/60302/4
Benjamin Franzke [Thu, 21 Mar 2019 08:10:38 +0000 (09:10 +0100)]
[TASK] Add be_user id to LinkGenerator page-version test context

Some of the previous todos were failing because the test context
contained a workspace id, but missed a backend user id.
In that case the workspace id was ignored by the test
framework (see TYPO3\JsonResponse\Middleware\BackendUserMiddleware).

This patch also adapts the SlugLinkGeneratorTest to check link
generation to versioned record both with and without a backend user
authentication.

Releases: master, 9.5
Resolves: #87973
Change-Id: I0a2ec41234963fd8af0ed3adf951f139f1e85215
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60302
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
11 months ago[!!!][TASK] Remove TCA option setToDefaultOnCopy 76/60276/6
Benni Mack [Sat, 16 Mar 2019 23:11:56 +0000 (00:11 +0100)]
[!!!][TASK] Remove TCA option setToDefaultOnCopy

This special setting resets a certain field to its default
value when copying. This option was only there for
resetting some sys_action values to default, which can
easily be achieved by a hook if needed.

The option is removed to reduce the amount of checks and
the amount of available options for edge-cases in TCA, as this
option was not widely used - as identified by the Persistence
Initiative.

Resolves: #87989
Releases: master
Change-Id: Iae05d958ff31f0f0c4618486445baad7e624b73b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60276
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
11 months ago[BUGFIX] Update topbar when switching BE language 21/60321/2
Benni Mack [Sat, 23 Mar 2019 21:53:54 +0000 (22:53 +0100)]
[BUGFIX] Update topbar when switching BE language

If a user switched his language settings in his preference,
the top bar is now also refreshed reflecting the language
change.

Resolves: #18117
Releases: master, 9.5
Change-Id: Ifdcd08c65f12ce1083521e93205964a2f77ca811
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60321
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
11 months ago[BUGFIX] Update SYS_LASTCHANGED for the right language page record 44/58944/6
Wolfgang Klinger [Sat, 24 Nov 2018 17:33:28 +0000 (18:33 +0100)]
[BUGFIX] Update SYS_LASTCHANGED for the right language page record

The register SYS_LASTCHANGED needs to reflect the
value of the translated page as well.

This is now done properly in a separate method.

Releases: master, 9.5
Resolves: #86963
Change-Id: Ieebd4207df03f3064c6e01d392a03ee253311f9b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/58944
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
11 months ago[TASK] Update typo3/testing-framework to 5.0.7 19/60319/2
Oliver Hader [Sat, 23 Mar 2019 21:01:26 +0000 (22:01 +0100)]
[TASK] Update typo3/testing-framework to 5.0.7

composer require --dev typo3/testing-framework:~5.0.7

Resolves: #87990
Releases: master
Change-Id: I15a44b7cc0db267f3e7e004feeee9cbe18061dc6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60319
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
11 months ago[TASK] Remove and streamline HMENU functionality 44/60244/5
Benni Mack [Wed, 13 Mar 2019 20:04:32 +0000 (21:04 +0100)]
[TASK] Remove and streamline HMENU functionality

HMENU was hardened during v9 via deprecations of
GMENU and making most of the properties protected.

Therefore, code can now refactored more easily.

- The method signatures for HMENU / TMENU are
streamlined.
- All leftover "RO" (RollOver) functionality is
removed (Breaking RST is already done but left-over
code was forgotten).
- Several GeneralUtility::inList() checks are replaced
with in_array()
- Some minor strict types for some internal obvious
methods
- use json_encode() instead of serialize()
for cache identifiers
- resolve some very very nested if() statements
- internal methods with "optional arguments" which
are always called with all arguments, are built
in a way that they are now non-optional.

Resolves: #87907
Releases: master
Change-Id: I80536b9b4dbc4609d38476c9ce48532fe71b73d0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60244
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
11 months ago[BUGFIX] Do not overwrite status code of received response 73/59873/3
Helmut Hummel [Tue, 5 Mar 2019 15:11:56 +0000 (16:11 +0100)]
[BUGFIX] Do not overwrite status code of received response

The ErrorController must not modify the received response
from the configured handler, to allow the handler to
change it to a suitable value.

Resolves: #87846
Releases: master, 9.5
Change-Id: I91d3ab0a78d383e5a0c9ee47ea21dc8634ddd3c9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59873
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Benni Mack <benni@typo3.org>
11 months ago[!!!][TASK] Remove support for "selicon_field_path" option 74/60274/8
Benni Mack [Sat, 16 Mar 2019 18:54:17 +0000 (19:54 +0100)]
[!!!][TASK] Remove support for "selicon_field_path" option

The TCA[ctrl][selicon_field_path] option is not necessary
anymore, as support for "internal_type=file" was dropped
for v10.0.

Resolves: #87937
Releases: master
Change-Id: Iae3493c3fe829feb5fff889f274dbab5f0049717
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60274
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Josef Glatz <josefglatz@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Josef Glatz <josefglatz@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
11 months ago[TASK] Allow TCA display conditions with only one element for AND/OR 10/60310/4
Markus Klein [Fri, 22 Mar 2019 14:57:00 +0000 (15:57 +0100)]
[TASK] Allow TCA display conditions with only one element for AND/OR

Resolves: #87986
Releases: master, 9.5
Change-Id: I9ccdbcae0c06a00fcd2904a203d1f3072b6e28ea
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60310
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Josef Glatz <josefglatz@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Reviewed-by: Josef Glatz <josefglatz@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
11 months ago[TASK] Add sql index for error counter in topbar 07/59707/4
Christoph Lehmann [Fri, 15 Feb 2019 13:45:50 +0000 (14:45 +0100)]
[TASK] Add sql index for error counter in topbar

The index reduces the sql query time and thus is a performance improvement.

On a table with 5 million rows the query time is ~ 38s without and less than 0.5s with the index

Resolves: #87723
Releases: master
Change-Id: I53b24ad0d09a2627a77720ec151dea30a14f5011
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59707
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[TASK] Remove @internal from ConnectionPool::resetConnections() 52/60252/7
Bernhard Sirlinger [Thu, 14 Mar 2019 19:52:41 +0000 (20:52 +0100)]
[TASK] Remove @internal from ConnectionPool::resetConnections()

The method ConnectionPool::resetConnections() is no longer annotated as
@internal. This reflects that it is necessary to reset connections in a
scheduler task spawning new child processes. This circumvents errors on
accessing a connection that has already been closed.

Resolves: #87111
Releases: master, 9.5
Change-Id: I3803073491766831e863635031c29a08585e7bf8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60252
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[BUGFIX] Re-enable target attribute for links in menus 92/60292/2
Benni Mack [Sun, 17 Mar 2019 11:10:09 +0000 (12:10 +0100)]
[BUGFIX] Re-enable target attribute for links in menus

The new pagelink builder does not set the lastTypoLinkLD options
which is used in HMENUs. The patch properly sets
the lastTypoLink* properties of ContentObjectRenderer in typolink
again, making target overrides in menus work again.

Resolves: #87130
Releases: master, 9.5
Change-Id: Ia284e546179dfaec8ec8ecb86a36d38f3b81aad8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60292
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[BUGFIX] Respect sorting in section menus 03/60303/3
Georg Ringer [Thu, 21 Mar 2019 10:55:21 +0000 (11:55 +0100)]
[BUGFIX] Respect sorting in section menus

The section menus must respect the sorting of content elements.

Resolves: #87975
Releases: master, 9.5
Change-Id: Ib6e785a74d7267edf5fdb1f310c47709f663ca99
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60303
Tested-by: Josef Glatz <josefglatz@gmail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Josef Glatz <josefglatz@gmail.com>
Reviewed-by: Wolfgang Klinger <wolfgang@wazum.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[BUGFIX] Mark input fields edited by datepicker as changed 00/60300/3
Daniel Goerz [Wed, 20 Mar 2019 15:42:08 +0000 (16:42 +0100)]
[BUGFIX] Mark input fields edited by datepicker as changed

Resolves: #87966
Releases: master, 9.5
Change-Id: Ia693015ece7b0ff3fb9f3d322b9914a1daf67b55
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60300
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
11 months ago[TASK] Harden \TYPO3\CMS\Extbase\Reflection\ClassSchema 77/60277/2
Alexander Schnitzler [Sun, 17 Mar 2019 08:15:18 +0000 (08:15 +0000)]
[TASK] Harden \TYPO3\CMS\Extbase\Reflection\ClassSchema

- Use strict type mode
- Use type hints whereever possible

Releases: master
Resolves: #87940
Change-Id: I3f349d1cbb4ceec408de7e5d18cd1f0fc5cf4c7b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60277
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
11 months ago[BUGFIX] Ensure parse_str method argument is valid for BE shortcuts 39/60239/3
Joerg Kummer [Wed, 13 Mar 2019 16:04:26 +0000 (17:04 +0100)]
[BUGFIX] Ensure parse_str method argument is valid for BE shortcuts

When backend shortcut links get parsed, this change ensures that
parameter for returnUrl get only parsed, if it is set and not empty.

Resolves: #87903
Releases: master, 9.5
Change-Id: Ie8f380e9cdfef4440153f2095797a2dccc577d1c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60239
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
11 months ago[BUGFIX] Add additionalFields to cache identifier in getPageForRootline 63/60263/4
Wolfgang Klinger [Fri, 15 Mar 2019 16:13:20 +0000 (17:13 +0100)]
[BUGFIX] Add additionalFields to cache identifier in getPageForRootline

Otherwise, consecutive calls with additional fields given
will not return them.

Use md5 hash for the additionalFields in getPageForRootline and
BEgetRootLine.

Resolves: #87934
Releases: master, 9.5
Change-Id: I1720870ecb6920b06fa28a6ba8caf0522c50205c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60263
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
11 months ago[BUGFIX] Use renamed folder object in postRename signal 82/59882/3
Susanne Moog [Wed, 6 Mar 2019 12:02:13 +0000 (13:02 +0100)]
[BUGFIX] Use renamed folder object in postRename signal

The documentation states that the `emitPostFolderRename` signal
receives a reference to the renamed folder object. (see
https://docs.typo3.org/typo3cms/CoreApiReference/ApiOverview/Fal/Architecture/Signals.html)

The input of the signal has been adjusted to use the returned renamed
reference instead of the original folder to be renamed.

Resolves: #84539
Releases: master
Change-Id: Iceca142fce3293089b7603e211ba09f24746ca62
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59882
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Benjamin Franzke <bfr@qbus.de>
11 months ago[!!!][TASK] Remove TCA for sys_history 73/60273/4
Benni Mack [Sat, 16 Mar 2019 18:49:20 +0000 (19:49 +0100)]
[!!!][TASK] Remove TCA for sys_history

TCA for sys_history is not necessary at all anymore, and
can be removed.

It was previously used for creating an Extbase Domain Model
for the BELog module created in TYPO3 6.0/6.1.

However, in 9.0 sys_history was decoupled from sys_log,
whereas the Domain Model and the usages for TCA was
not necessary anymore.

The previously "generated" database fields are re-added
manually in ext_tables.sql. The field "pid" which was necessary
for a TCA table is now dropped.

Resolves: #87936
Releases: master
Change-Id: Ia541e9a5c7d85f25b6ff3ceb7e3ee311300762e6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60273
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
11 months ago[TASK] Harden \TYPO3\CMS\Extbase\Persistence\Generic\Mapper\ColumnMap 34/59634/4
Alexander Schnitzler [Mon, 4 Feb 2019 16:32:59 +0000 (17:32 +0100)]
[TASK] Harden \TYPO3\CMS\Extbase\Persistence\Generic\Mapper\ColumnMap

- Use strict type mode
- Use type hints whereever possible

Releases: master
Resolves: #87646
Change-Id: I5f05d7e89074ebcac39beef47e38e392e6c8ca26
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59634
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wolfgang Klinger <wolfgang@wazum.com>
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
11 months ago[TASK] Cleanup TYPO3/CMS/Backend/Notification 56/60256/3
Frank Naegler [Fri, 15 Mar 2019 10:41:33 +0000 (11:41 +0100)]
[TASK] Cleanup TYPO3/CMS/Backend/Notification

Cleanup the Notification.ts file:
- format code
- make optional parameter really optional
- import jquery as everywhere to get correct dependencies

Resolves: #87921
Releases: master
Change-Id: I819f0d7621537415b35a06337f8cd7dc42c5c1a7
Reviewed-on: https://review.typo3.org/c/60256
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
11 months ago[BUGFIX] Show typo3link module in ckeditor if href attribute is empty 68/60268/2
Georg Ringer [Sat, 16 Mar 2019 10:52:37 +0000 (11:52 +0100)]
[BUGFIX] Show typo3link module in ckeditor if href attribute is empty

Override the default link modal if href attribute is empty.

Resolves: #87790
Releases: master, 9.5
Change-Id: I728de276b4c61a47c34e305a7cea4ecbdf0e4bc2
Reviewed-on: https://review.typo3.org/c/60268
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Wolfgang Klinger <wolfgang@wazum.com>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Wolfgang Klinger <wolfgang@wazum.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
11 months ago[TASK] Show flash message if value is changed because unique value is required 73/58873/8
Georg Ringer [Thu, 8 Nov 2018 13:16:04 +0000 (14:16 +0100)]
[TASK] Show flash message if value is changed because unique value is required

If a TCA field is configured to be unique and the value changes
by the DataHandler, the user should be informed about the change.

Resolves: #85409
Releases: master
Change-Id: I133c107534c1568d8a6d869436c9438e7660e91d
Reviewed-on: https://review.typo3.org/c/58873
Reviewed-by: Wolfgang Klinger <wolfgang@wazum.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
11 months ago[BUGFIX] Ensure result is string in __toString of CropVariantCollection 87/59887/2
Susanne Moog [Wed, 6 Mar 2019 17:57:59 +0000 (18:57 +0100)]
[BUGFIX] Ensure result is string in __toString of CropVariantCollection

CropVariantCollection returns output from json_encode in its __toString
method. Json_encode may return false if it fails to properly encode the
given data (mostly when non-UTF8 data is given). To ensure that no
exception is thrown to the user in that case, the __toString method
has been adjusted to return the same result as in the empty variants case.

Resolves: #79823
Releases: master, 9.5
Change-Id: Idfbdbbbd867251c8480a0729412dd6d652f57ee1
Reviewed-on: https://review.typo3.org/c/59887
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
11 months ago[BUGFIX] Prevent empty new form from being closed without confirmation 37/60237/2
Wolfgang Klinger [Wed, 13 Mar 2019 15:23:31 +0000 (16:23 +0100)]
[BUGFIX] Prevent empty new form from being closed without confirmation

Set ‘has-change’ on new empty content element form container
to trigger the confirmation dialog when using ‘Close’.

Resolves: #87890
Releases: master, 9.5
Change-Id: Idc3d8fdca0f865991ee09935f4b75683dffb4d7e
Reviewed-on: https://review.typo3.org/c/60237
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
11 months ago[TASK] Use native idn functionality 34/60234/7
Benni Mack [Wed, 13 Mar 2019 08:13:20 +0000 (09:13 +0100)]
[TASK] Use native idn functionality

It is safe to use idn_to_ascii() these days
due to symfony's polyfill functionality.

This allows us to remove the dependency
"algo26-matthias/idna-convert".

Also, all other places now use the native
idn_to_ascii() call, which could speed up
performance.

The wrapper call GeneralUtility::idnaEncode()
can then safely be deprecated.

used composer command:
  composer remove algo26-matthias/idna-convert

Resolves: #87894
Releases: master
Change-Id: I85aa6f39b8ff5ac171cd73218ed1144a56d9f724
Reviewed-on: https://review.typo3.org/c/60234
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
11 months ago[BUGFIX] Do not send empty scheduler status mails 74/60174/2
Guido Schmechel [Mon, 11 Mar 2019 23:47:13 +0000 (00:47 +0100)]
[BUGFIX] Do not send empty scheduler status mails

Due to a missing initialization, the status providers were not filled
in the status report in the scheduler task. The providers are now
initialized in the constructor and can now always be used.

Resolves: #87555
Releases: master, 9.5
Change-Id: Ia9b02b13061775ce297f6d2881ce8332c9714591
Reviewed-on: https://review.typo3.org/c/60174
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
11 months ago[BUGFIX] Rename PageParameterValidator to PageArgumentValidator 61/60261/2
Markus Klein [Fri, 15 Mar 2019 15:29:19 +0000 (16:29 +0100)]
[BUGFIX] Rename PageParameterValidator to PageArgumentValidator

This patch renames the remaining usages of class PageParameterValidator
to PageArgumentValidator.

Resolves: #87932
Releases: master, 9.5
Change-Id: Ia8d8651b5caddcaa6df846007d37b8ea542e771f
Reviewed-on: https://review.typo3.org/c/60261
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
11 months ago[TASK] Replace bool properties in ClassSchema with a BitSet 26/59626/5
Alexander Schnitzler [Sun, 3 Feb 2019 17:16:57 +0000 (18:16 +0100)]
[TASK] Replace bool properties in ClassSchema with a BitSet

Instead of using multiple properties that hold bool flags,
ClassSchema now holds all flags in a single BitSet property.

This drastically reduces the size of the class schemata cache
file, as a lot of properties no longer need to be serialized.

Releases: master
Resolves: #87631
Change-Id: I12b2d8a2f4e481d55b1f57ce00bfede599b4cb32
Reviewed-on: https://review.typo3.org/c/59626
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
11 months ago[TASK] Extract ValidatorClassNameResolver from ValidatorResolver 52/59952/4
Alexander Schnitzler [Sat, 9 Mar 2019 10:23:14 +0000 (10:23 +0000)]
[TASK] Extract ValidatorClassNameResolver from ValidatorResolver

The ValidatorResolver contained a method for resolving validator
class names. Extbase supports various shorthand notations to
make the life of developers more easy. There are notations like:

- NotEmpty
- TYPO3.CMS.Extbase:NotEmpty
- CustomExtension:ValidatorName

Resolving these notations takes place in a dedicated
ValidatorClassNameResolver class now.

Releases: master
Resolves: #87868
Change-Id: Ib0d57127a0e1dc4ae0536a8e76ca497f6d2bd56d
Reviewed-on: https://review.typo3.org/c/59952
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
11 months ago[TASK] Move language labels to correct extension(s) 92/60092/4
Susanne Moog [Mon, 11 Mar 2019 12:43:45 +0000 (13:43 +0100)]
[TASK] Move language labels to correct extension(s)

The filelist module contained labels solely used in different extensions,
for example "sys_file_storage.*" labels which was only used by the `core` extension.
Those labels have been moved to their corresponding parent extension.

This patch is a prerequisite for making filelist uninstallable and part
one of decoupling the filelist module. For more information see the
Epic.

Related: #87878
Resolves: #87879
Releases: master
Change-Id: I4954f9e8c45866ce34f387ec637b347b0d681bd8
Reviewed-on: https://review.typo3.org/c/60092
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
11 months ago[BUGFIX] Check if field exists when deleting items from `group` field 59/60259/2
Andreas Fernandez [Fri, 15 Mar 2019 13:32:46 +0000 (14:32 +0100)]
[BUGFIX] Check if field exists when deleting items from `group` field

Fields of type `group` don't have a visible counterpart as opposed to
`selectMultipleSideBySide`. Thus, we have to check whether such field
exists before trying to interact with that field.

Resolves: #87925
Related: #87324
Releases: master
Change-Id: Ic8608e065b155949d15ab8d576e30f8d7f8d86db
Reviewed-on: https://review.typo3.org/c/60259
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
11 months ago[DOCS] Update ext:rte_ckeditor manual for > v8 LTS 54/60254/4
Josef Glatz [Thu, 14 Mar 2019 22:53:39 +0000 (23:53 +0100)]
[DOCS] Update ext:rte_ckeditor manual for > v8 LTS

- add info about ext:rtehtmlarea support
- add info about the wordcount plugin and its location
- remove obsolete installation instructions

Resolves: #87918
Releases: master, 9.5
Change-Id: I9ceb9fd4b75ea801c363bed9a3e783eba23ce4bd
Reviewed-on: https://review.typo3.org/c/60254
Reviewed-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
11 months ago[TASK] Remove needless string concatenations 55/60155/5
Georg Ringer [Mon, 11 Mar 2019 16:55:14 +0000 (17:55 +0100)]
[TASK] Remove needless string concatenations

Replace string concatenations like 'abc' . 'def' with 'abcdef'.

Resolves: #87004
Releases: master
Change-Id: I9c1a610e88dd4bd4e617214989a915b1dafda094
Reviewed-on: https://review.typo3.org/c/60155
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
11 months ago[TASK] Move filelist related controllers to filelist 53/60153/9
Susanne Moog [Mon, 11 Mar 2019 15:29:09 +0000 (16:29 +0100)]
[TASK] Move filelist related controllers to filelist

The following controllers have been moved to filelist as they are
part of filelist functionality and not called anywhere else:

- `CreateFolderController`
- `EditFileController`
- `FileUploadController`
- `RenameFileController`
- `ReplaceFileController`

In addition the TypeScript module `RenameFile` has also been moved to
EXT:filelist.

The base file function route `tce_file` has not been changed.

Related: #87878
Resolves: #87882
Releases: master
Change-Id: I160d13dc6ac20de23aa89543c0f6975ad403075e
Reviewed-on: https://review.typo3.org/c/60153
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
11 months ago[TASK] Upgrade ckeditor to 4.11.3 43/60243/2
Andreas Fernandez [Wed, 13 Mar 2019 18:24:44 +0000 (19:24 +0100)]
[TASK] Upgrade ckeditor to 4.11.3

This patch updates ckeditor to the latest version 4.11.3.

Used command:

    yarn upgrade ckeditor

List of changes:
https://github.com/ckeditor/ckeditor-releases/compare/4.11.1...4.11.3

Resolves: #87905
Releases: master, 9.5, 8.7
Change-Id: Iafbde59625de902774997ca0acffc9a92ba36534
Reviewed-on: https://review.typo3.org/c/60243
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
11 months ago[TASK] Migrate TYPO3/CMS/Install/* to TypeScript 09/59709/13
Frank Naegler [Fri, 15 Feb 2019 17:09:36 +0000 (18:09 +0100)]
[TASK] Migrate TYPO3/CMS/Install/* to TypeScript

This patch migrates all install tool JS files to TypeScript.
It also improves the performance by a better caching and
with less request for modules.

Resolves: #87724
Releases: master
Change-Id: I555924008bf19eb4394268acc231eca91d8b16c6
Reviewed-on: https://review.typo3.org/c/59709
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
11 months ago[BUGFIX] Fix broken TS build due to outdated patch 45/60245/3
Andreas Fernandez [Thu, 14 Mar 2019 09:04:46 +0000 (10:04 +0100)]
[BUGFIX] Fix broken TS build due to outdated patch

The patch for issue #87324 was based on outdated tslint configuration,
which causes all TypeScript builds to fail. The build is now fixed
by executing

    cd Build
    ./node_modules/tslint/bin/tslint -c tslint.json --fix --project .

Resolves: #87908
Related: #87324
Releases: master
Change-Id: I1447dd98aba693756f64308c048a5da199a505df
Reviewed-on: https://review.typo3.org/c/60245
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
11 months ago[TASK] Split FormEngine.js 08/58608/22
Andreas Fernandez [Wed, 10 Oct 2018 17:41:02 +0000 (19:41 +0200)]
[TASK] Split FormEngine.js

This patch splits the FormEngine.js into smaller, logically separated
parts. This increases readability and maintainability and has a positive
effect on the client's performance as only the required code is loaded.

Not every aspect of the FormEngine JavaScript is handled here yet, since
other areas, e.g. IRRE, need refactoring as well.

Resolves: #87324
Releases: master
Change-Id: I6704445254a524f8ed3152ab6b0b7105fb97d65a
Reviewed-on: https://review.typo3.org/c/58608
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: André Schließer <andy.schliesser@gmail.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: André Schließer <andy.schliesser@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[!!!][TASK] Harden \TYPO3\CMS\Extbase\Error\Message 97/59597/5
Alexander Schnitzler [Thu, 31 Jan 2019 19:04:47 +0000 (20:04 +0100)]
[!!!][TASK] Harden \TYPO3\CMS\Extbase\Error\Message

- Use strict type mode
- Use type hints whereever possible

Releases: master
Resolves: #87602
Change-Id: Ieb9d9baa84aca6ab93a3468694ef5886bc7ed119
Reviewed-on: https://review.typo3.org/c/59597
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
11 months ago[BUGFIX] Add jquery.clearable to backend page tree filter 72/60172/2
Wolfgang Klinger [Mon, 11 Mar 2019 19:19:39 +0000 (20:19 +0100)]
[BUGFIX] Add jquery.clearable to backend page tree filter

Resolves: #87888
Releases: master, 9.5
Change-Id: Ie21c58f7d7e14285ec4b841324340841cde8cbec
Reviewed-on: https://review.typo3.org/c/60172
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
11 months ago[TASK] Remove loading of FileListLocalisation in FormEngine 12/60112/2
Susanne Moog [Mon, 11 Mar 2019 12:59:48 +0000 (13:59 +0100)]
[TASK] Remove loading of FileListLocalisation in FormEngine

The FileListLocalisation requirejs module has been removed from
FormResultCompiler. The module is used for displaying translation
toggles in the file list module (and only there).

Related: #87878
Resolves: #87880
Releases: master
Change-Id: Ifd94d1d9b594a1b6962760f45fbb4645b2383f78
Reviewed-on: https://review.typo3.org/c/60112
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
11 months ago[BUGFIX] Add field static_page_arguments to group by of query 72/59972/2
Georg Ringer [Sat, 9 Mar 2019 15:37:08 +0000 (16:37 +0100)]
[BUGFIX] Add field static_page_arguments to group by of query

With #86994 a new field has been added to the database table
`index_phash`. This fields needs to be added to the GROUP BY
statement as well.

Resolves: #87855
Releases: master, 9.5
Change-Id: I7b5270434b152e463ccf36886d963017fa6ad548
Reviewed-on: https://review.typo3.org/c/59972
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
11 months ago[BUGFIX] Update core system extension composer.json file 33/60233/2
Benni Mack [Wed, 13 Mar 2019 05:32:42 +0000 (06:32 +0100)]
[BUGFIX] Update core system extension composer.json file

In commit #11292caf2016587f61ab32258e848d24ae5db663
the update of composer.json was forgotten, so this is added
now.

Resolves: #87893
Related: #87090
Related: #87843
Releases: master
Change-Id: Iff0ce9c5272794f5f433a1098faba7db3e7f1ae0
Reviewed-on: https://review.typo3.org/c/60233
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
11 months ago[BUGFIX] Allow umlaut domains for site domain resolving 58/59958/6
Benni Mack [Sat, 9 Mar 2019 14:34:19 +0000 (15:34 +0100)]
[BUGFIX] Allow umlaut domains for site domain resolving

As umlaut domains require to be puny-coded, this needs
to be added into the request context of the SiteMatcher.

A polyfill package "symfony/polyfill-intl-idn" is installed
to ensure that the methods exist at all times. If "ext-intl"
is not available, the polyfill package is used.

Installed via
    composer require symfony/polyfill-intl-idn

Resolves: #87090
Resolves: #87843
Releases: master, 9.5
Change-Id: I209c01953b3a0f2c25b4e1f11ab74ed4bb29f569
Reviewed-on: https://review.typo3.org/c/59958
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
11 months ago[BUGFIX] Include Records with "All Languages" in default language 93/59993/3
Benni Mack [Sat, 9 Mar 2019 18:39:05 +0000 (19:39 +0100)]
[BUGFIX] Include Records with "All Languages" in default language

Records with "All Languages" (sys_language_uid=-1)
aren't shown in TYPO3 v9 anymore of the default
language.

This happened before in TYPO3 v8 and below,
however setting config.sys_language_overlay = 1
triggered the if() condition to jump into the
selection of fetching 0 and -1 records.

As this setting is removed, the check only
applies when overlays are activated, which
is not necessary in language=0.

Resolves: #86972
Resolves: #87749
Resolves: #87093
Releases: master, 9.5
Change-Id: I9308167aede071125df02b848a26283e3f77b759
Reviewed-on: https://review.typo3.org/c/59993
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
11 months ago[TASK] Replace styles.content.get in Install Tool created TS 54/60154/2
Georg Ringer [Mon, 11 Mar 2019 16:20:54 +0000 (17:20 +0100)]
[TASK] Replace styles.content.get in Install Tool created TS

Use cObject CONTENT directly instead of using styles.content.get

Resolves: #87886
Releases: master
Change-Id: I68df06ca1a3aca2b1545efb343c8474c60da228b
Reviewed-on: https://review.typo3.org/c/60154
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
11 months ago[TASK] Add slug field to page-related DataHandler tests 92/59992/3
Benni Mack [Sat, 9 Mar 2019 16:19:59 +0000 (17:19 +0100)]
[TASK] Add slug field to page-related DataHandler tests

In order to ensure SlugHelper's base functionality, DataHandler
Regular test suite.

Once this is in, Workspace-related DataHandler tests are added.

Resolves: #87872
Releases: master, 9.5
Change-Id: I0265b66a4dc310c01bb2a583a76d622201dad78d
Reviewed-on: https://review.typo3.org/c/59992
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
11 months ago[TASK] Replace strings with constants/variables 54/59954/2
Benni Mack [Sat, 9 Mar 2019 12:57:04 +0000 (13:57 +0100)]
[TASK] Replace strings with constants/variables

There are a few places where - instead of hard-coded values,
the proper constants or variables can be used instead.

Resolves: #87870
Releases: master
Change-Id: Ia1053bddefc7627cdc9699360df68ec317898d45
Reviewed-on: https://review.typo3.org/c/59954
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
11 months ago[BUGFIX] Use correct default value for sys_file_storage|is_public 32/60032/2
Georg Ringer [Mon, 11 Mar 2019 06:12:57 +0000 (07:12 +0100)]
[BUGFIX] Use correct default value for sys_file_storage|is_public

Use 1 instead of true as default value.

Resolves: #87873
Releases: master, 9.5, 8.7

Change-Id: I6665ebd5b59336a00ea3019cf30ba5c98123a4f6
Reviewed-on: https://review.typo3.org/c/60032
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
11 months ago[BUGFIX] Pass original DBALException along with SqlErrorException 88/59888/3
Christian Futterlieb [Wed, 6 Mar 2019 17:53:01 +0000 (18:53 +0100)]
[BUGFIX] Pass original DBALException along with SqlErrorException

When a
TYPO3\CMS\Extbase\Persistence\Generic\Storage\Exception\SqlErrorException
is thrown, pass the previous exception as 3rd parameter to the
constructor, to get the real reason for the exception.

Resolves: #87852
Releases: master, 9.5, 8.7
Change-Id: I20d711c0038b51a1d0c12d9a975d8c0da1f510f4
Reviewed-on: https://review.typo3.org/c/59888
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Futterlieb <christian@futterlieb.ch>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
11 months ago[BUGFIX] Fix typos in PHP comments 53/59953/2
Benni Mack [Sat, 9 Mar 2019 12:50:48 +0000 (13:50 +0100)]
[BUGFIX] Fix typos in PHP comments

Resolves: #87869
Releases: master, 9.5
Change-Id: I789b4f28d2895c7e7bc53f0a6e04649f89709c14
Reviewed-on: https://review.typo3.org/c/59953
Tested-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
11 months ago[BUGFIX] GifBuilder returns already generated images 44/59644/14
Markus Klösges [Tue, 5 Feb 2019 12:26:24 +0000 (13:26 +0100)]
[BUGFIX] GifBuilder returns already generated images

When combining image files with gifbuilder, the hash to identify the
resulting file is now stable with respect to the fact whether the
files are cropped or scaled in the current request or already cropped
before. That leads to stable hashes whenever the same images are
processed with the same configuration, and allows reuse as intended.

Also ensure that fileInfo returned from ContentObjectRenderer contains
width and height information as int, when they are returned from
database as that may lead to different serialized representations of the
configuration

Resolves: #44518
Resolves: #86947
Resolves: #87224
Releases: 8.7, 9.5, master
Change-Id: I833585034cacaf5a0ad66ba3ff04ac3920421085
Reviewed-on: https://review.typo3.org/c/59644
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
11 months ago[TASK] Raise typo3/phar-stream-wrapper to v3.1.0 50/59850/5
Oliver Hader [Mon, 4 Mar 2019 20:37:58 +0000 (21:37 +0100)]
[TASK] Raise typo3/phar-stream-wrapper to v3.1.0

composer require typo3/phar-stream-wrapper:^3.1.0

Resolves: #87840
Releases: master, 9.5, 8.7
Change-Id: I16b472081df6813cd80afe06504fe1541f8bd769
Reviewed-on: https://review.typo3.org/c/59850
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
11 months ago[BUGFIX] Ensure Lowercase folders on non-case-sensitive file system 80/59880/3
Susanne Moog [Wed, 6 Mar 2019 11:08:32 +0000 (12:08 +0100)]
[BUGFIX] Ensure Lowercase folders on non-case-sensitive file system

When creating files in a storage configured as not case-sensitive
the file name gets lowercased and TYPO3 works with the lowercased
version everywhere. When creating folders the lowercasing was missing,
resulting in an exception as the expectation still was to have only
lowercased files and folders on non-case-sensitive systems.

Lowercasing for folder creation has been implemented.

Resolves: #85583
Releases: master, 9.5, 8.7
Change-Id: Icd12ea602ceda9de8bc1a44c58f8ebeaef9a8008
Reviewed-on: https://review.typo3.org/c/59880
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
11 months ago[BUGFIX] Access correct event variable in ContextMenu.ts 52/59852/2
Frank Naegler [Mon, 4 Mar 2019 20:49:40 +0000 (21:49 +0100)]
[BUGFIX] Access correct event variable in ContextMenu.ts

Resolves: #87839
Releases: master, 9.5
Change-Id: I9097c4e53c44b3a08eaf82ddc332514d196e1722
Reviewed-on: https://review.typo3.org/c/59852
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
11 months ago[BUGFIX] Add requireJs for Inline JavaScript in file replace view 51/59851/3
Frank Naegler [Mon, 4 Mar 2019 20:46:02 +0000 (21:46 +0100)]
[BUGFIX] Add requireJs for Inline JavaScript in file replace view

Resolves: #87795
Releases: master, 9.5
Change-Id: I6455729515757580b6de7704d0986414ddec0493
Reviewed-on: https://review.typo3.org/c/59851
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
11 months ago[BUGFIX] Remove possibility to exclude width/height in sys_file_metadata 83/59883/3
Susanne Moog [Wed, 6 Mar 2019 12:39:21 +0000 (13:39 +0100)]
[BUGFIX] Remove possibility to exclude width/height in sys_file_metadata

Width and height are readonly fields updated by system image service API.
To ensure the API (for example the crop wizard) works flawlessly for
editors out of the box, width and height are no longer exclude fields.

Bugfix is for master only, as the workaround for earlier versions is
as simple as putting this in TCA overrides:

unset(
    $GLOBALS['TCA']['sys_file_metadata']['columns']['width']['exclude'],
    $GLOBALS['TCA']['sys_file_metadata']['columns']['height']['exclude']
);

Releases: master
Resolves: #81964
Change-Id: I53f6c5353f0a8d629a9d209675a19def2d6c7a60
Reviewed-on: https://review.typo3.org/c/59883
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[TASK] Add code comments that explain the Extbase validation logic 28/59928/2
Alexander Schnitzler [Fri, 8 Mar 2019 20:59:44 +0000 (20:59 +0000)]
[TASK] Add code comments that explain the Extbase validation logic

Releases: master
Resolves: #87866
Change-Id: I55396a865b03df644028287a031854526d3eb445
Reviewed-on: https://review.typo3.org/c/59928
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
11 months ago[BUGFIX] Prevent exception in file list 79/59879/2
Susanne Moog [Wed, 6 Mar 2019 10:36:27 +0000 (11:36 +0100)]
[BUGFIX] Prevent exception in file list

When creating a file with a disallowed file
extension an exception was thrown as on creation
the redirect to edit interface on a non-existing
file was called.

Though the better fix might be to prevent the
request for an invalid file to be sent at all
this fix ensures a working file list module in
a more "surgical" way to allow secure backporting.

Resolves: #87527
Releases: master, 9.5, 8.7
Change-Id: I35a054c05b37c09acab83a7aa9eca89cf9ebf6b9
Reviewed-on: https://review.typo3.org/c/59879
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Benni Mack <benni@typo3.org>
11 months ago[BUGFIX] Fix strict type error in recursive mount point resolving 16/59916/4
Benni Mack [Thu, 7 Mar 2019 21:02:46 +0000 (22:02 +0100)]
[BUGFIX] Fix strict type error in recursive mount point resolving

PageLinkBuilder::populateMountPointMapForPageRecursively() requires
the $id parameter to be an integer, so this is cast properly now.

In addition, one regression is fixed where
"config.MP_mapRootPoints = root" was set, the proper variables
are now used.

Resolves: #87547
Resolves: #87473
Releases: master, 9.5
Change-Id: I899120d301309d768b9e498ad7f4ec96b9618b9d
Reviewed-on: https://review.typo3.org/c/59916
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
11 months ago[BUGFIX] Remove invalid sort link in filelist module 95/59895/3
Susanne Moog [Thu, 7 Mar 2019 10:56:25 +0000 (11:56 +0100)]
[BUGFIX] Remove invalid sort link in filelist module

Sorting in filelist happens via FAL drivers. Those are not capable of
sorting by TYPO3 References. The filelist nevertheless links and passes
the value _REF_ to FAL as sort option resulting in unpredictable results.

The _REF_ sort link has now been removed to avoid confusion.

Resolves: #61618
Releases: master, 9.5
Change-Id: Ie3cd46617cb7bafe0ae6d8c4252e52c11a4c98d7
Reviewed-on: https://review.typo3.org/c/59895
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Benni Mack <benni@typo3.org>
11 months ago[BUGFIX] Prevent various PHP notices 19/59919/2
Markus Klein [Fri, 8 Mar 2019 00:52:41 +0000 (01:52 +0100)]
[BUGFIX] Prevent various PHP notices

Resolves: #87862
Releases: master, 9.5
Change-Id: I7a48f155c031a9213034def7b39905cf9007ec50
Reviewed-on: https://review.typo3.org/c/59919
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
11 months ago[BUGFIX] Catch ExpressionLanguage exception for invalid base variants 01/59901/5
Benni Mack [Thu, 7 Mar 2019 18:44:16 +0000 (19:44 +0100)]
[BUGFIX] Catch ExpressionLanguage exception for invalid base variants

When adding an invalid expression for base variants,
an error is now caught instead of breaking the system.

Resolves: #87859
Releases: master, 9.5
Change-Id: I05bc10cd5f6bea7f9929c67d709cd8a0de908478
Reviewed-on: https://review.typo3.org/c/59901
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
11 months ago[BUGFIX] Use TSConfig defaults for DataHandler 53/58453/5
Guido Schmechel [Sat, 29 Sep 2018 11:49:59 +0000 (13:49 +0200)]
[BUGFIX] Use TSConfig defaults for DataHandler

Now the DataHandler observes the default values set in TsConfig. Example:

TCAdefaults.pages {
    # set page to visible
    hidden = 0
}

Resolves: #59383
Releases: master, 9.5
Change-Id: I51e5d07e4e9a9457135bb9af88868cd52af373d7
Reviewed-on: https://review.typo3.org/c/58453
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
11 months ago[BUGFIX] Do not use named parameter for list of ids in plain data resolver 49/57849/16
Gleb Levitin [Thu, 9 Aug 2018 16:23:52 +0000 (18:23 +0200)]
[BUGFIX] Do not use named parameter for list of ids in plain data resolver

The plain data resolver sorts records by a list of uids.
This list can get very big so the database will fail if the
number of placesholders exceeds its limit.

Resolves: #85797
Releases: master, 9.5
Change-Id: I0b8a623fe00660b8f2c87a83a7e48ba430790d2b
Reviewed-on: https://review.typo3.org/c/57849
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
11 months ago[BUGFIX] Reduce strictness for .pl files in fileDenyPattern 86/59886/5
Oliver Hader [Wed, 6 Mar 2019 16:46:56 +0000 (17:46 +0100)]
[BUGFIX] Reduce strictness for .pl files in fileDenyPattern

Files like "file.pl.txt" cannot be uploaded anymore since ".pl" is
considered as executable Perl file. In multilingual scenarios "pl"
is used as reference for Polish content. Since required modules
mod_perl or mod_cgid are not enabled by default, and limited to
be executable only when invoked in location "/cgi-bin/", now only
files ending with ".pl" (e.g. "file.pl") are denied.

Resolves: #87733
Releases: master, 9.5, 8.7
Change-Id: Ib9a69fd3ec04f51653857d2f7309e30b78932653
Reviewed-on: https://review.typo3.org/c/59886
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wolfgang Klinger <wolfgang@wazum.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
11 months ago[BUGFIX] Do not treat all classes as entities in ClassSchema 06/59806/2
Alexander Schnitzler [Mon, 4 Feb 2019 09:03:08 +0000 (10:03 +0100)]
[BUGFIX] Do not treat all classes as entities in ClassSchema

The ClassSchema class has a property $modelType which indicates
that a class is either an entity or a value object. This property
has a default value that reflected the state of an entity.

This means, that all classes, class schemata are created for are
considered entities which then leads to the execution of further
entity related analysis code, such as looking for specific doc
blocks and/or annotations.

While this isn't an issue functionality wise, it can be in the future.
Also, the superfluous cpu cycles can and should be spared.

Releases: master, 9.5
Resolves: #87632
Change-Id: I15f7688b8bf1ac9486d77a0efc38ccb07a397b30
Reviewed-on: https://review.typo3.org/c/59806
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>