Packages/TYPO3.CMS.git
7 years ago[TASK] Cleanup character after PHP closing tag
Georg Ringer [Fri, 21 Sep 2012 14:38:28 +0000 (16:38 +0200)]
[TASK] Cleanup character after PHP closing tag

Change-Id: Ife256d7497ac72235ba3783bbbe5203b9a66785a
Resolves: #41119
Releases: 6.0
Reviewed-on: http://review.typo3.org/14833
Reviewed-by: Andy Grunwald
Tested-by: Andy Grunwald
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[TASK] Show felogin title in page module
Georg Ringer [Wed, 19 Sep 2012 18:12:48 +0000 (20:12 +0200)]
[TASK] Show felogin title in page module

Currently, the content element in page module is empty.
At least the title of the plugin should be displayed

Change-Id: I2663295139c5c2743351eb256f622660d19d1bed
Resolves: #41076
Releases: 6.0
Reviewed-on: http://review.typo3.org/14739
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[BUGFIX] Wrong exception msg after namespace change
Georg Ringer [Thu, 20 Sep 2012 10:31:33 +0000 (12:31 +0200)]
[BUGFIX] Wrong exception msg after namespace change

The stated interface got a different name and needs to
be changed

Change-Id: Ied9953580dced910b777d49cb465ceb1287b0062
Fixes: #41111
Releases: 6.0
Reviewed-on: http://review.typo3.org/14756
Reviewed-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[BUGFIX] Link to install tool in reports leads to old page
Thomas Löffler [Mon, 17 Sep 2012 18:02:09 +0000 (20:02 +0200)]
[BUGFIX] Link to install tool in reports leads to old page

There is a link to install tool on the reports page which leads
to the old page with the missing button "unlock install tool".

Change-Id: If5b33c379581672dbfd2d1024b0dd485e2281b7c
Resolves: #37067
Releases: 6.0, 4.7, 4.6
Reviewed-on: http://review.typo3.org/14671
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Move code from the system extension cli to core/Classes
Helmut Hummel [Wed, 19 Sep 2012 21:07:28 +0000 (23:07 +0200)]
[TASK] Move code from the system extension cli to core/Classes

Change-Id: Iafb916bc8a5cc74fe284d18a5430350f344e11c2
Resolves: #40949
Releases: 6.0
Reviewed-on: http://review.typo3.org/14746
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Mattias Nilsson
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Provide a file for IDEs to recognize old class names
Helmut Hummel [Thu, 20 Sep 2012 16:32:09 +0000 (18:32 +0200)]
[TASK] Provide a file for IDEs to recognize old class names

As of now an IDE cannot recognize old class names as the
class alias is set up dynamically.

Provide a file with class definitions of old class names
which extend the new one. This file is never included
during a request but just there to add IDE support for
the old class names.

The file is auto generated on the basis of the class mapping.

Change-Id: I5ff4a1cd6a678121621ad027fb6fd63e259e02bd
Resolves: #41128
Releases: 6.0
Reviewed-on: http://review.typo3.org/14777
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[TASK] Rename Core\DataHandler\DataHandler
Christian Kuhn [Thu, 20 Sep 2012 11:46:27 +0000 (13:46 +0200)]
[TASK] Rename Core\DataHandler\DataHandler

Old t3lib_tcemain was renamed to Core\DataHandler\DataHandling, but
should have been Core\DataHandling\DataHandler instead, located
beside the other classes and hook interfaces.
The patch moves the file and corrects all usages, and raises
submodule pointers of workspace and version that already got
the rename patches.

Change-Id: I394849aceebc389d88b0da0f0ff9751a7cc8efc5
Resolves: #41094
Related: #40095
Related: #41095
Related: #41096
Releases: 6.0
Reviewed-on: http://review.typo3.org/14762
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] EXT:saltedpasswords tests
Christian Kuhn [Wed, 19 Sep 2012 20:09:41 +0000 (22:09 +0200)]
[TASK] EXT:saltedpasswords tests

* Minor cleanups and fix for a broken globals backup
* Activate for travis

Change-Id: I0bac617fcff4100dd31bf7ca1ad0aa552a7a4d37
Resolves: #41081
Releases: 6.0
Reviewed-on: http://review.typo3.org/14742
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] EXT:lang unit tests
Christian Kuhn [Wed, 19 Sep 2012 19:32:03 +0000 (21:32 +0200)]
[TASK] EXT:lang unit tests

* Minor test cleanups
* Activate in travis testsuite

Change-Id: I6eccff9a35198479e0932779b261f2ec364e0393
Resolves: #41080
Releases: 6.0
Reviewed-on: http://review.typo3.org/14741
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] EXT:indexed_search tests
Christian Kuhn [Wed, 19 Sep 2012 18:58:17 +0000 (20:58 +0200)]
[TASK] EXT:indexed_search tests

* Fix tests to use fixture mock
* Clean up backups
* Activate in testsuite for travis

Change-Id: I94988d1eaf7d4b7408e7cb08faa3a9a86bf0bd4b
Resolves: #41077
Releases: 6.0
Reviewed-on: http://review.typo3.org/14740
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] EXT:form tests and unicode fix
Christian Kuhn [Wed, 19 Sep 2012 17:45:15 +0000 (19:45 +0200)]
[BUGFIX] EXT:form tests and unicode fix

This cleans up the existing EXT:form tests and
adds them to the travis testsuite.

The two filter test cases fail on systems like debian with
PHP 5.3.3 due to a broken PCRE environment. This issue is
identical to #39123 and the fix is very similar.

Change-Id: I18d806d795a40ff6aed8dbe388a3ddfb91d15fe3
Resolves: #41074
Related: #39123
Related: #35296
Related: #35284
Releases: 6.0
Reviewed-on: http://review.typo3.org/14738
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] EXT:felogin unit tests
Christian Kuhn [Wed, 19 Sep 2012 15:06:25 +0000 (17:06 +0200)]
[TASK] EXT:felogin unit tests

* Rename FrontendLoginControllerTest file
* Use phpunit getAccessibleProxy() instead of own eval()
* Rename some tests and data providers
* Fix some duplicate data provider array keys
* Activate in travis

Change-Id: Ia49a59f8d60212e091e69164b759f62e6d0e257a
Resolves: #41071
Releases: 6.0
Reviewed-on: http://review.typo3.org/14734
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] pi_getLL() alternative language translation fails
Xavier Perseguers [Fri, 31 Aug 2012 10:30:37 +0000 (12:30 +0200)]
[BUGFIX] pi_getLL() alternative language translation fails

The translation fallback introduced with TYPO3 4.6 is not taken
into account by the pi_getLL() method.

Change-Id: I9c60d14e903eba1cc0d19ea8cd3a58f5365abfa1
Fixes: #39850
Releases: 6.0, 4.7, 4.6
Reviewed-on: http://review.typo3.org/13811
Reviewed-by: Markus Klein
Reviewed-by: Laurent Cherpit
Tested-by: Laurent Cherpit
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[TASK] Set TYPO3 version to 6.0-dev
TYPO3 Release Team [Tue, 18 Sep 2012 21:52:03 +0000 (23:52 +0200)]
[TASK] Set TYPO3 version to 6.0-dev

Change-Id: Icb79400c0444c099b27a87b3ad55a1e3dbb8cee8
Reviewed-on: http://review.typo3.org/14722
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
7 years ago[RELEASE] Release of TYPO3 6.0.0beta2
TYPO3 Release Team [Tue, 18 Sep 2012 21:51:51 +0000 (23:51 +0200)]
[RELEASE] Release of TYPO3 6.0.0beta2

Change-Id: I6e9a95589f50deb5df5458761b087f47d441d3c0
Reviewed-on: http://review.typo3.org/14721
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
7 years ago[TASK] Raise submodule pointer
TYPO3 Release Team [Tue, 18 Sep 2012 21:35:28 +0000 (23:35 +0200)]
[TASK] Raise submodule pointer

Change-Id: I0da4ec847376480552d1f51565500030cac4a8fc
Reviewed-on: http://review.typo3.org/14719
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
7 years ago[BUGFIX] Configuration of an extension fails with fatal error
Georg Grossberger [Wed, 12 Sep 2012 12:23:56 +0000 (14:23 +0200)]
[BUGFIX] Configuration of an extension fails with fatal error

The extensionmanager tries to merge the default configuration
with the already saved one. If no configuration has been set yet,
the result of the unserialize operation is a boolean false instead
of an array and that is causing a fatal error when it tries to
merge both configurations with the ArrayUtility::flatten method
This patch adds a check that sets the current configuration
to an empty array if none exists.

Change-Id: Ibbc92e580e94e03452e7a40800374f086488a14b
Resolves: #40864
Releases: 6.0
Reviewed-on: http://review.typo3.org/14548
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Uncaught Exception when accessing "Filelist" module in Windows
Nicole Cordes [Tue, 11 Sep 2012 10:36:40 +0000 (12:36 +0200)]
[BUGFIX] Uncaught Exception when accessing "Filelist" module in Windows

An Exception is thrown when files are found directly in fileadmin folder.
Because of a backslash a false identifier is generated and file cannot be
found anymore.

Change-Id: I6c9e8b56654dfb44ec33f697219b5299883e82c5
Fixes: #39130
Releases: 6.0
Reviewed-on: http://review.typo3.org/14514
Reviewed-by: Oliver Hader
Reviewed-by: Wouter Wolters
Reviewed-by: Simon Schaufelberger
Tested-by: Simon Schaufelberger
Tested-by: Oliver Hader
7 years ago[BUGFIX] Fatal errors for interfaces with PHP version < 5.3.7
Nicole Cordes [Wed, 5 Sep 2012 13:14:00 +0000 (15:14 +0200)]
[BUGFIX] Fatal errors for interfaces with PHP version < 5.3.7

This bugfix rewrites function type hints to match the new ones as long as
PHP versions of OS Venders are not up to date.
Fatal errors are thrown when using an old interface with the new
TYPO3 6.0 beta 1. This only happens with PHP versions below 5.3.7 as
there are some type hinting issues.

Raise the Extbase submodule pointer at the same time to be in line
with the renaming of the Autoloader to ClassLoader.

Change-Id: I87da4bb2ef0420a94d1d155edde500c1aa96894a
Fixes: #40653
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14376
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[BUGFIX] Usage of raw binary characters in SQL Parser
Martin Helmich [Tue, 18 Sep 2012 09:38:53 +0000 (11:38 +0200)]
[BUGFIX] Usage of raw binary characters in SQL Parser

Currently, the SQL Parser uses raw binary characters. In some cases,
this breaks the PHP interpreter. This results in the file
SqlParser.php not being parsed (the PHP interpreter just dumps
"???..." to stdout) and a follow-up fatal error because the class
cannot be found.

This patch replaces the raw binary characters with corresponding
character sequence in double quotes.

Change-Id: I28fb5d0c8401794e8f4bf20e7e2611b4cf7014ae
Fixes: #40932
Relates: #40672
Releases: 6.0
Reviewed-on: http://review.typo3.org/14689
Reviewed-by: Oliver Hader
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[BUGFIX] TS Object "FILES" is not able to handle multiple references
Steffen Ritter [Mon, 3 Sep 2012 10:49:41 +0000 (12:49 +0200)]
[BUGFIX] TS Object "FILES" is not able to handle multiple references

The current implementation is not able to deal with more
than one file-reference (hand over as csv).

According to the documentation and to behave like other
options of the FILES object this should be adapted.

Change-Id: I79227dcabbcc92c355528df0f8ebb7e4f38d1dcb
Fixes: #39955
Releases: 6.0
Reviewed-on: http://review.typo3.org/14307
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[BUGFIX] Switch to List module on root page leads to blank page
Thomas Löffler [Wed, 12 Sep 2012 06:41:50 +0000 (08:41 +0200)]
[BUGFIX] Switch to List module on root page leads to blank page

Reproducable only with admin account. Switch to Page module, go to root
page (id = 0), switch to List module => blank page. Works only on
root page.

Change-Id: I377bf20708631e81d2854645b18a1211889e6409
Releases: 6.0, 4.7, 4.6, 4.5
Resolves: #40781
Reviewed-on: http://review.typo3.org/14490
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[TASK] Remove superfluous parenthesis in sysexts
Arvid Jakobsson [Sun, 16 Sep 2012 19:25:07 +0000 (21:25 +0200)]
[TASK] Remove superfluous parenthesis in sysexts

Removes superfluous parenthesis in sysexts "felogin", "filelist",
"form" and "func".

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: I2e9e0b8e339dae93c0361a6ba36e41beb0f54711
Resolves: #40965
Related: #40095
Reviewed-on: http://review.typo3.org/14624
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[TASK] Remove superfluous parenthesis in sysexts
Arvid Jakobsson [Sun, 16 Sep 2012 19:45:34 +0000 (21:45 +0200)]
[TASK] Remove superfluous parenthesis in sysexts

Removes superfluous parenthesis in sysexts "info_pagetsconfig",
"install", "integrity" and "lang".

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: I367b1bef893de93964b41d900f29e2dfcedb8aaf
Resolves: #40967
Related: #40095
Reviewed-on: http://review.typo3.org/14626
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[TASK] Remove superfluous parenthesis in sysexts
Arvid Jakobsson [Sun, 16 Sep 2012 20:16:11 +0000 (22:16 +0200)]
[TASK] Remove superfluous parenthesis in sysexts

Removes superfluous parenthesis in sysexts "opendocs", "openid",
"perm" and "recordlist".

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: Ibe211f8ff6ba0089ecb086bd645ca55ab6fcc9da
Resolves: #40968
Related: #40095
Reviewed-on: http://review.typo3.org/14627
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[TASK] Remove superfluous parenthesis in sysexts
Arvid Jakobsson [Sun, 16 Sep 2012 20:30:54 +0000 (22:30 +0200)]
[TASK] Remove superfluous parenthesis in sysexts

Removes superfluous parenthesis in sysexts "saltedpasswords",
"scheduler", "setup" and "statictemplates".

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: Ie1e7d052f5d8dfac95d01a70ed750e69cf4bb7f6
Resolves: #40970
Related: #40095
Reviewed-on: http://review.typo3.org/14629
Reviewed-by: Thomas Loeffler
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[TASK] Remove superfluous parenthesis in sysexts
Arvid Jakobsson [Sun, 16 Sep 2012 20:36:02 +0000 (22:36 +0200)]
[TASK] Remove superfluous parenthesis in sysexts

Removes superfluous parenthesis in sysexts "sv", "sys_action",
"sys_note" and "t3editor".

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: Ib4b3541051a30895d6657b6af367f9c6c58dac44
Resolves: #40971
Related: #40095
Reviewed-on: http://review.typo3.org/14630
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[TASK] Remove superfluous parens in sysexts css_styled_content - feedit
Arvid Jakobsson [Sun, 16 Sep 2012 18:34:31 +0000 (20:34 +0200)]
[TASK] Remove superfluous parens in sysexts css_styled_content - feedit

Removes superfluous parenthesis in sysexts "css_styled_content",
"extensionmanager", "extra_page_cm_options" and "feedit".

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: I9ec62d6b2782e349cef447c7a9c87f4a4fbc2585
Resolves: #40964
Related: #40095
Reviewed-on: http://review.typo3.org/14623
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[TASK] Remove superfluous parenthesis in sysexts
Arvid Jakobsson [Sun, 16 Sep 2012 20:37:32 +0000 (22:37 +0200)]
[TASK] Remove superfluous parenthesis in sysexts

Removes superfluous parenthesis in sysexts "t3skin", "taskcenter",
"tsconfig_help" and "tstemplate".

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: I9034b5146aa02651e99ab3651c50d785423e64c2
Resolves: #40972
Related: #40095
Reviewed-on: http://review.typo3.org/14631
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[TASK] Remove superfluous parenthesis in sysexts
Arvid Jakobsson [Sun, 16 Sep 2012 20:40:34 +0000 (22:40 +0200)]
[TASK] Remove superfluous parenthesis in sysexts

Removes superfluous parenthesis in sysexts "tstemplate_analyzer",
"tstemplate_ceditor", "tstemplate_info" and "tstemplate_objbrowser".

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: I7724aa9b38d7db641db4bd75c1a059bf8a71038b
Resolves: #40973
Related: #40095
Reviewed-on: http://review.typo3.org/14632
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[TASK] Remove superfluous parenthesis in sysexts
Arvid Jakobsson [Sun, 16 Sep 2012 20:43:47 +0000 (22:43 +0200)]
[TASK] Remove superfluous parenthesis in sysexts

Removes superfluous parenthesis in sysexts "viewpage",
"wizard_crpages" and "wizard_sortpages".

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: Ib5818e68f9e21164de8e42da73686cf1327410a9
Resolves: #40974
Related: #40095
Reviewed-on: http://review.typo3.org/14633
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[TASK] Remove superfluous parenthesis in folders typo3 and t3lib
Arvid Jakobsson [Sun, 16 Sep 2012 20:50:31 +0000 (22:50 +0200)]
[TASK] Remove superfluous parenthesis in folders typo3 and t3lib

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: I77e999229bf10bc39757f927bb3386eb2df8ec61
Resolves: #40982
Related: #40095
Reviewed-on: http://review.typo3.org/14634
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[TASK] Adapt DriverRegistryTest to the changed behaviour
Steffen Ritter [Mon, 17 Sep 2012 17:43:44 +0000 (19:43 +0200)]
[TASK] Adapt DriverRegistryTest to the changed behaviour

The DriverRegistry does not throw exception anymore, if the
same Driver is registered twice. The Exception only is
thrown if another driver takes the same key.

Change-Id: I16c0aa5bc98d7da90a47615ea675ab655391e1dc
Releases: 6.0
Fixes: 40843
Reviewed-on: http://review.typo3.org/14669
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[TASK] Remove superfluous parenthesis in sysexts
Arvid Jakobsson [Sun, 16 Sep 2012 20:25:22 +0000 (22:25 +0200)]
[TASK] Remove superfluous parenthesis in sysexts

Removes superfluous parenthesis in sysexts "recycler", "reports",
"rsaauth" and "rtehtmlarea".

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: I5786043a52ea50477072c82e039179272e6692ca
Resolves: #40969
Related: #40095
Reviewed-on: http://review.typo3.org/14628
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[BUGFIX] Fatal error is thrown when more drivers are registered
Nicole Cordes [Tue, 11 Sep 2012 22:13:42 +0000 (00:13 +0200)]
[BUGFIX] Fatal error is thrown when more drivers are registered

Due to some extension manager processes when installing a new extension
the DriveRegistry has to support to register the same short name with the
same class name multiple times.

Change-Id: I67e409f532f5736b5a4c0a2e7fb822a579cfaa41
Fixes: #40843
Releases: 6.0
Reviewed-on: http://review.typo3.org/14532
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[TASK] Remove superfluous parenthesis in sysexts
Arvid Jakobsson [Sun, 16 Sep 2012 19:32:49 +0000 (21:32 +0200)]
[TASK] Remove superfluous parenthesis in sysexts

Removes superfluous parenthesis in sysexts "func_wizards", "impexp",
"indexed_search" and "info".

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: Ib367bc98070cb9bf8350b955f5ba7dee1872f607
Resolves: #40966
Related: #40095
Reviewed-on: http://review.typo3.org/14625
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[TASK] Remove superfluous parenthesis in sysexts.
Arvid Jakobsson [Sun, 16 Sep 2012 17:57:05 +0000 (19:57 +0200)]
[TASK] Remove superfluous parenthesis in sysexts.

Removes superfluous parenthesis in sysexts "aboutmodules", "adodb",
"belog" and "beuser".

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: I26f72a6d5e18617a0838e64068817e4fd7c1c90e
Resolves: #40962
Related: #40095
Reviewed-on: http://review.typo3.org/14620
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[TASK] Remove superfluous parenthesis in sysexts.
Arvid Jakobsson [Sun, 16 Sep 2012 18:01:59 +0000 (20:01 +0200)]
[TASK] Remove superfluous parenthesis in sysexts.

Removes superfluous parenthesis in sysexts "cli", "cms",
"context_help" and "cshmanual".

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: I0ff0fc33d3c0733498d5821e77b224db20213705
Resolves: #40963
Related: #40095
Reviewed-on: http://review.typo3.org/14621
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[BUGFIX] Files contents cannot be changed
Andreas Wolf [Sat, 1 Sep 2012 13:35:44 +0000 (15:35 +0200)]
[BUGFIX] Files contents cannot be changed

Setting file contents failed for two reasons:

a) The permissions were incorrectly read from TSconfig and

b) We used a new "update" permission that was not present
   in the default configuration, so without manually setting it,
   a file could never be updated, even by admins.

This commit changes the "update" permission back to "edit", which was
also used in the pre-FAL era.

Change-Id: I408a19257a50868f7978ffac32eefbd410117e2d
Resolves: #37812
Resolves: #39860
Resolves: #39949
Releases: 6.0
Reviewed-on: http://review.typo3.org/14257
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[TASK] Re-enable previously skipped unit tests
Helmut Hummel [Sun, 16 Sep 2012 13:04:52 +0000 (15:04 +0200)]
[TASK] Re-enable previously skipped unit tests

Take the chance to also clean up the test class a bit.

Change-Id: Ib2835aa4dc4c170d327f56dfcde134cf5871867b
Resolves: #40956
Releases: 6.0
Reviewed-on: http://review.typo3.org/14618
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[TASK] Remove superfluous parenthesis in sysext frontend
Arvid Jakobsson [Wed, 12 Sep 2012 22:32:31 +0000 (00:32 +0200)]
[TASK] Remove superfluous parenthesis in sysext frontend

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: I09b90a58a74a219e6957488a7cca7a591c27ff70
Resolves: #40881
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14566
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[TASK] Remove superfluous parenthesis in sysext core
Arvid Jakobsson [Wed, 12 Sep 2012 22:25:43 +0000 (00:25 +0200)]
[TASK] Remove superfluous parenthesis in sysext core

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: I818d55a2f00b549fef8377f1c6766c293edd021c
Resolves: #40880
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14565
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[BUGFIX] Editing page is broken on wrong type
Wouter Wolters [Mon, 27 Aug 2012 19:42:27 +0000 (21:42 +0200)]
[BUGFIX] Editing page is broken on wrong type

Change-Id: If6d3dfcb0fb095063750eaeb85bdb32aef0f417e
Resolves: #40282
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14144
Reviewed-by: Nicole Cordes
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[BUGFIX] Use double quoted strings for control chars
Jigal van Hemert [Fri, 14 Sep 2012 21:22:37 +0000 (23:22 +0200)]
[BUGFIX] Use double quoted strings for control chars

Instead of literal characters in single quoted strings it's better
to use doubled quoted strings for control characters to provide
better compatibility across platforms

Change-Id: Icb9722ad0e729c898d458c085f89d0fdf1f13896
Fixes: #40672
Releases: 6.0
Reviewed-on: http://review.typo3.org/14603
Reviewed-by: Felix Kopp
Tested-by: Felix Kopp
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[BUGFIX] Typehint in AbstractTree refers to non-existant class
Steffen Ritter [Sun, 16 Sep 2012 10:04:18 +0000 (12:04 +0200)]
[BUGFIX] Typehint in AbstractTree refers to non-existant class

Change-Id: I69b9d1c81e1215980d4a40b0383de400b26886d7
Fixes: #40952
Release: 6.0
Reviewed-on: http://review.typo3.org/14615
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[TASK] Remove superfluous parenthesis in sysext backend
Arvid Jakobsson [Wed, 12 Sep 2012 22:13:04 +0000 (00:13 +0200)]
[TASK] Remove superfluous parenthesis in sysext backend

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: I8a30e8689c1c567770d0c03beaa12a0bf29e9b09
Resolves: #40878
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14563
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[BUGFIX] Restore field descriptions in Install Tool
Anja Leichsenring [Sat, 15 Sep 2012 08:16:07 +0000 (10:16 +0200)]
[BUGFIX] Restore field descriptions in Install Tool

In the Install Tool All Configuration part all field descriptions
are missing. This patch removes the additional newline characters
which caused the comments used to render the descriptions being
moved away from their fields.

Change-Id: I0c6db43b6940494405eb794a28a684d1894b046e
Fixes: #40939
Releases: 6.0
Reviewed-on: http://review.typo3.org/14607
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[TASK] Cleanup Unit Tests
Helmut Hummel [Wed, 12 Sep 2012 22:14:10 +0000 (00:14 +0200)]
[TASK] Cleanup Unit Tests

* Skip the IPV6 Test that always fails on darwin/ OSX OS
* Remove the potentially skipped tests concerning t3lib_diff
  since this class is still in use

Change-Id: Iab26c428ff7cf8a8b447d536d820821ed000a8fd
Resolves: #40879
Releases: 6.0
Reviewed-on: http://review.typo3.org/14564
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[TASK] Add unit tests for stdWrap_strftime
Jigal van Hemert [Wed, 12 Sep 2012 19:11:31 +0000 (21:11 +0200)]
[TASK] Add unit tests for stdWrap_strftime

Change-Id: Ic4a640c880a59bf322101efb1ab7fb58bb8ace48
Fixes: #40876
Releases: 6.0
Reviewed-on: http://review.typo3.org/14560
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Clean up some ext:belog details and activate tests in travis
Christian Kuhn [Wed, 12 Sep 2012 14:38:34 +0000 (16:38 +0200)]
[TASK] Clean up some ext:belog details and activate tests in travis

Cleans up ext:belog and activates the test suite:
* Fix some annotations
* Move a test that was put to a wrong location
* Minor CGL and readability changes
* Remove namespace compat layer of new 6.0 classes
* Change module registration and viewhelper to namespace

Change-Id: Ia31b5fcd52b76c40dbc6215c9820fa8c83a8ab86
Resolves: #40871
Related: 6.0
Reviewed-on: http://review.typo3.org/14557
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Cleanup Bootstrap Classes
Helmut Hummel [Wed, 12 Sep 2012 20:10:29 +0000 (22:10 +0200)]
[TASK] Cleanup Bootstrap Classes

The namespace switch removed some linefeeds that
were there to improve readability of the bootstrap.

Add these again and also remove the compatibility
files as these files are new to 6.0 anyway.

Resolves: #40877
Releases: 6.0

Change-Id: I1ed4e7d8710f4feb97a0331b5526336075aa7932
Reviewed-on: http://review.typo3.org/14561
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[TASK] Stabilize scheduler tests and activate in travis
Christian Kuhn [Wed, 12 Sep 2012 12:37:34 +0000 (14:37 +0200)]
[TASK] Stabilize scheduler tests and activate in travis

Next try to add the scheduler tests to the test suites.

The patch applies several changes:

* For some weird reasons PHP does not recognize 'September' as valid
month keyword if the timezone is not Europe/Berlin. The test is removed
since only three letter abbreviations are allowed anyway.

* Make the cron command test system timezone agnostic.
CronCommandTest now explicitly sets the timezone to UTC (GMT) in setUp
and has a backup for tearDown. This is needed because the tests use hard
coded timestamps and the system under test is sensitive for timezones.
This was the main reason for the travis runs to fail in the first place.

* The dataProvider in CronCommandTest do not execute strtotime anymore.
The reason for that is, that the data provider data in phpunit is
executed before setUp and won't get the timezone setting then. The main
data provider is now splitted into two, separating the strtotime()
calculation off from the rest.

Change-Id: Ifb8de929b8e6edb31b24cbf02a9ddaa9dda9ab43
Resolves: #40515
Releases: 6.0
Reviewed-on: http://review.typo3.org/14549
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Wrong icon in db_new tree
Georg Ringer [Wed, 12 Sep 2012 11:03:27 +0000 (13:03 +0200)]
[BUGFIX] Wrong icon in db_new tree

The wrong line icon is used in the wizard of
db_new.php

Change-Id: Ifba1d0270b547e11326ffb1c82a48e8c8838b401
Resolves: #40862
Releases: 6.0
Reviewed-on: http://review.typo3.org/14545
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Improve margin in field select
Georg Ringer [Wed, 12 Sep 2012 09:05:28 +0000 (11:05 +0200)]
[TASK] Improve margin in field select

The margin can be improved.

Change-Id: I5680551fdc7625037d222d627d49a51a49835f26
Resolves: #40858
Releases: 6.0
Reviewed-on: http://review.typo3.org/14536
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Marcus Schwemer
Tested-by: Marcus Schwemer
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Upgrade wizard to fill default EM repository
Georg Ringer [Mon, 10 Sep 2012 21:47:23 +0000 (23:47 +0200)]
[BUGFIX] Upgrade wizard to fill default EM repository

An upgrade wizard is needed to add the default
repository of the EM. Otherwise the EM crashes

Change-Id: I3d254fae0bc1e937fd18b84b42df13d99a1b9ddc
Fixes: #40508
Releases: 6.0
Reviewed-on: http://review.typo3.org/14506
Reviewed-by: Marcus Schwemer
Tested-by: Marcus Schwemer
Reviewed-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Move last files from tests root folder
Christian Kuhn [Tue, 11 Sep 2012 20:50:14 +0000 (22:50 +0200)]
[TASK] Move last files from tests root folder

The patch moves the last files in tests/ to a different location:
* FAL functional StorageTest is moved to ext:core as functional test
* A naming mistake of one of the other FAL tests is fixed
* class.removexssTest.php and class.t3lib_formmailTest.php are moved
to ext:core/Tests/Legacy

Change-Id: I7f627c29f3154d07d40a3e11db3730f763f7ff2f
Resolves: #40841
Releases: 6.0
Reviewed-on: http://review.typo3.org/14530
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Move UnitTests.xml file to EXT:core/Build
Christian Kuhn [Tue, 11 Sep 2012 19:59:43 +0000 (21:59 +0200)]
[TASK] Move UnitTests.xml file to EXT:core/Build

This was decided at the latest release manager meeting:
To get rid of the top level tests/ directory, the UnitTests.xml
file is moved to the core extension to a new folder Build/. This
directory will later be used for other build specific things.

Change-Id: Id541f1e0bab3b1d2891f13697f48ea16e6c86d5e
Resolves: #40837
Releases: 6.0
Reviewed-on: http://review.typo3.org/14528
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Namespace SystemEnvironmentBuilderTest
Christian Kuhn [Tue, 11 Sep 2012 19:49:40 +0000 (21:49 +0200)]
[TASK] Namespace SystemEnvironmentBuilderTest

* Move BaseSetupTest to SystemEnvironmentBuilderTest and namespace it.
* Introduce an AccessibleProxy for the protected methods instead of eval.
* Merge config_defaultTest to SystemEnvironmentBuilderTest

Change-Id: Ie90857962087e235a7f4a8eb53df120624fd8780
Resolves: #40836
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14527
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Make ext:form work with namespaced classnames
Thomas Maroschik [Tue, 28 Aug 2012 23:47:33 +0000 (01:47 +0200)]
[BUGFIX] Make ext:form work with namespaced classnames

Change-Id: I26b501e49d41656eb50996be4d56b4c18f1563ba
Fixes: #40364
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14178
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[TASK] Move fixture files from tests/
Christian Kuhn [Tue, 11 Sep 2012 18:25:53 +0000 (20:25 +0200)]
[TASK] Move fixture files from tests/

There are still some fixture files within the root tests/ directory.
The patch moves them to Fixtures/ folders below the using tests
within the affected core and backend extensions.

Change-Id: Ied23b542a65becac02c9af576728da886552484d
Resolves: #40834
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14525
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years agoBUGFIX] strftime expects parameter 2 to be long, string given
Jigal van Hemert [Fri, 7 Sep 2012 17:50:47 +0000 (19:50 +0200)]
BUGFIX] strftime expects parameter 2 to be long, string given

Any zero length string value is replaced with the current timestamp.
(Just like the default value for the second parameter of
strtime/gmstrftime.)

Change-Id: I7cc43a09f75d21ab8db84c0191fa0c1c5d67ddb0
Fixes: #38717
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/12713
Reviewed-by: Stefan Neufeind
Reviewed-by: Marcus Schwemer
Tested-by: Marcus Schwemer
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[TASK] Add test integrity test
Christian Kuhn [Tue, 11 Sep 2012 17:14:32 +0000 (19:14 +0200)]
[TASK] Add test integrity test

In the past it happened quite often that some test did not take care
of proper backing up globals or other environment settings. This
usually leads to failing tests if they are run afterwards. Those
side effects are often hard to track down and take quite some time
if searching for the one test that breaks the environment.

Therefor, a new "Integrity" test is added to the system that is
executed as the very last test in the list of test suites. It checks
that important things that were messed up in the past are still working.

Currently it checks that the registered singleton instances are still
there, that $GLOBALS['TYPO3_DB'] still has a valid resource link to
the database, and $GLOBALS['typo3CacheManager'] is still a valid
class instance.

If one of this test fails after any merge (especially combined with
travis), it is now obvious that this merge broke the environment, so
the evil test can be found much quicker and the evil merge can be
reverted directly.

Change-Id: I0dc733081ea9ad0c050a7dbcf4d95dd8f819f1bf
Resolves: #40832
Releases: 6.0
Reviewed-on: http://review.typo3.org/14524
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Wrong call to TSFE in FrontendEditing
Steffen Ritter [Fri, 7 Sep 2012 12:10:20 +0000 (14:10 +0200)]
[BUGFIX] Wrong call to TSFE in FrontendEditing

The FrontendEditingController calls TSFE->includeTCA right
before the index_ts.php calls TSFE->getCompressedTCA().

Because of the missing parameter within the
FrontendEditingController, getCompressedTCA wil not be
executed anymore. As an result the TSFE->TCAcachedExtras
are not available when FE-editing is active.

This prevents the a working language overlay, which only
looks to that array, which fields are configured to be
overlayed.

Change-Id: Ib130b11dd76c0b533b9a699a113f03e750ba2516
Fixes: #40733
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/14432
Reviewed-by: Mario Rimann
Tested-by: Mario Rimann
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Georg Ringer
Reviewed-by: Stefan Neufeind
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[TASK] Rebuild language selection list in lang module
Kai Vogel [Sun, 2 Sep 2012 17:42:45 +0000 (19:42 +0200)]
[TASK] Rebuild language selection list in lang module

This patch replaces the language selection field in language module.

Change-Id: I52fd08df4bfd4687c65588cd3e479d08b48d68df
Resolves: #40430
Related: #39963
Releases: 6.0
Reviewed-on: http://review.typo3.org/14293
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Replace module icon in language module
Kai Vogel [Mon, 3 Sep 2012 08:46:18 +0000 (10:46 +0200)]
[TASK] Replace module icon in language module

This patch replaces the icon in extensionmanager and admin tools menu
(module icon) with a more attractive one.
The new icon is from the http://www.famfamfam.com/lab/icons/silk/ silk
icon set, so it is free, credits to famfamfam are already give in
TYPO3 core, and it fits to the rest of the core icons.

Change-Id: Ic379c457b91eb5ba87d56d646a3b76a0909cb021
Resolves: #40546
Related: #39963
Releases: 6.0
Reviewed-on: http://review.typo3.org/14300
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Add labels to log in info module
Georg Ringer [Fri, 17 Aug 2012 04:42:10 +0000 (06:42 +0200)]
[TASK] Add labels to log in info module

Labels improve the usuability, so add them

Change-Id: I7d06f26959eb46cab449a2870942df02917023b0
Resolves: #39874
Releases: 6.0
Reviewed-on: http://review.typo3.org/13831
Reviewed-by: Stefan Neufeind
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Christian Kuhn
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[BUGFIX] Wrong type hint used after namespace changes
Georg Ringer [Tue, 11 Sep 2012 06:06:39 +0000 (08:06 +0200)]
[BUGFIX] Wrong type hint used after namespace changes

One place has been missing while changing all the
class names

Change-Id: I73d5e3f006377ea46079ac9f17f30c817ada7d4a
Resolves: #40795
ReleaseS: 6.0
Reviewed-on: http://review.typo3.org/14508
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[TASK] Activate extensionmanager tests in travis
Christian Kuhn [Mon, 10 Sep 2012 22:17:19 +0000 (00:17 +0200)]
[TASK] Activate extensionmanager tests in travis

After fixing lots of side effects and invalid environment changes
of existing unit tests and updating the introduction package database
and the travis test environment, it finally seems to be possible to
activate the extensionmanager tests for every travis build.
Let's see if this works out now ...

Change-Id: Ic8beb96121df3e8ef8b76b0ff4c2ef7d0daa8dab
Resolves: #40810
Releases: 6.0
Reviewed-on: http://review.typo3.org/14507
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Raise submodule pointer
Christian Kuhn [Mon, 10 Sep 2012 14:12:09 +0000 (16:12 +0200)]
[TASK] Raise submodule pointer

Change-Id: Ic37ed816e8ccce1c976c1e66155ebe77788738bc
Reviewed-on: http://review.typo3.org/14499
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Fix for unit tests to change singletons and reset again
Christian Kuhn [Sun, 9 Sep 2012 23:02:59 +0000 (01:02 +0200)]
[TASK] Fix for unit tests to change singletons and reset again

TYPO3\CMS\Core\Utility\GeneralUtility::setSingletonInstance() is a method
for unit tests to inject singleton mocks for classes that are
instantiated with makeInstance. purgeInstances() can be used to reset all
registered singletons, so makeInstance() creates new objects after that.
purgeInstances() can change the behaviour of tests that are executed
afterwards, because *all* registered singletons are reset. Currently the
helper methods for singletons around makeInstance() are not able to get
the list of registered singletons, and reset them to the previous list.

The patch introduces method getSingletonInstances() that returns a list
of all registered singletons (used in setUp()), and method
resetSingletonInstances() that resets registered singletons to a given
stored list (used in tearDown()). This way it is possible to fiddle in
tests with purgeInstances() without introducing side effects to other
tests.

All unit tests that used purgeInstances() are adapted to take care
of re constitution of changed objects this way.

Change-Id: I19dc869423a537226bb019e227d84b6f74fe9afc
Resolves: #40780
Releases: 6.0
Reviewed-on: http://review.typo3.org/14487
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] L10n PHP parser stores NULL for unknown key
Xavier Perseguers [Wed, 5 Sep 2012 07:06:40 +0000 (09:06 +0200)]
[BUGFIX] L10n PHP parser stores NULL for unknown key

The PHP parser caches NULL instead of an array when the Backend
language is not available for a given extension using PHP array
localization files (e.g., tscobj with German "de").

This leads to PHP warning when reading the labels as NULL cannot
be used in a foreach statement.

Change-Id: I1678674ecfba71e04c9c13aed44dd7f0aa574cbc
Fixes: #40643
Releases: 6.0, 4.7, 4.6
Reviewed-on: http://review.typo3.org/14360
Reviewed-by: Philipp Gampe
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[TASK] Raise submodule pointer: extbase
Christian Kuhn [Sun, 9 Sep 2012 15:56:16 +0000 (17:56 +0200)]
[TASK] Raise submodule pointer: extbase

Change-Id: I61bfb67d9e633ddb25eebf2c82092c67c9ea8970
Releases: 6.0
Reviewed-on: http://review.typo3.org/14480
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Namespace and move t3lib unit tests - 6
Wouter Wolters [Sun, 9 Sep 2012 14:05:13 +0000 (16:05 +0200)]
[TASK] Namespace and move t3lib unit tests - 6

This patch moves most unit tests of the tests/Unit/t3lib/*
directory to the core extension, following the new name scheme.

Change-Id: Ia03bc00ccb256c68684f7243fea77804081cb287
Resolves: #40770
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14475
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Namespace and move t3lib unit tests - 5
Wouter Wolters [Tue, 4 Sep 2012 17:06:49 +0000 (19:06 +0200)]
[TASK] Namespace and move t3lib unit tests - 5

This patch moves most unit tests of the tests/Unit/t3lib/*
directory to the core extension, following the new name scheme.

Change-Id: Ia08a3c0251c577676e3920dc880bb54e1651e5c2
Resolves: #40620
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14339
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Warnings in extensionmanager
Christian Kuhn [Sun, 9 Sep 2012 14:26:33 +0000 (16:26 +0200)]
[BUGFIX] Warnings in extensionmanager

The patch fixes some rather obvious problems in EXT:extensionmanager
to stabilize the tests. Furthermore the extension dependency
calculation did not work due to missing TCA definition.

Change-Id: I8364f603c5d3c104554838e303f156114f047c16
Resolves: #40771
Releases: 6.0
Reviewed-on: http://review.typo3.org/14476
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Warnings in StringUtility
Christian Kuhn [Sat, 8 Sep 2012 20:44:40 +0000 (22:44 +0200)]
[BUGFIX] Warnings in StringUtility

StringUtility::isLastPartOfString does not sanitize the input arguments
enough and throws warnings if calling strlen() for example with arrays.
The patch changes the (new 6.0) method to sanitize the arguments and now
throws Exceptions if they can not be interpreted as string.
The tests are adapted to test for the exception and adds a test with
an object to the data provider.

Change-Id: I497a1478a7804c4bbeddc2d1e340e29d73efa200
Resolves: #40767
Releases: 6.0
Reviewed-on: http://review.typo3.org/14467
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Warning in FAL StorageTest
Christian Kuhn [Sat, 8 Sep 2012 20:35:25 +0000 (22:35 +0200)]
[BUGFIX] Warning in FAL StorageTest

checkFolderPermissionsRespectsFilesystemPermissions throws a warning
that the third argument from the data provider is missing with its first
data set. The third argument is not always needed and set to a sane
default now.

Change-Id: I25d6c21addcefc5bec6d8f3a8adc48bfc0f38481
Resolves: #40766
Releases: 6.0
Reviewed-on: http://review.typo3.org/14465
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] FAL LocalDriverTests throws warnings
Christian Kuhn [Sat, 8 Sep 2012 19:58:52 +0000 (21:58 +0200)]
[BUGFIX] FAL LocalDriverTests throws warnings

finfo() in FAL LocalDriver can not deal with vfs streams and throws
warnings. It is used to fetch the mime type of files.
The patch moves the finfo call to an own method and mocks the methods
in all tests that triggered the warnings.
Additionally, the statReturnsCorrectFileInfo() test is splitted into
four tests and renamed to getLowLevelFileInfoReturnsCorrectFile*. An
additional test is added to test for correct retrieval of mime type
with a prepared dummy file.

Change-Id: Ib3dcd0998dee3d2fa7e0e60eabcf783b712c5fdd
Resolves: #40765
Releases: 6.0
Reviewed-on: http://review.typo3.org/14460
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Load CSH Manual by default
Jigal van Hemert [Sat, 8 Sep 2012 18:15:14 +0000 (20:15 +0200)]
[BUGFIX] Load CSH Manual by default

The cshmanual extension must be loaded by default to make the CSH
popups work.

Change-Id: Iad8d12bc2caac8b24cf14ac14a6c3b6afdab5924
Fixes: #40665
Releases: 6.0
Reviewed-on: http://review.typo3.org/14457
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[BUGFIX] Warning missing argument 3 in t3lib_cacheHashTest
Christian Kuhn [Sat, 8 Sep 2012 14:38:52 +0000 (16:38 +0200)]
[BUGFIX] Warning missing argument 3 in t3lib_cacheHashTest

t3lib_cacheHashTest::cacheHashCalculationWorks() expects three parameters
from the data provider, but the data provider delivers only two. The
third parameter is superfluous and removed with the patch.

Change-Id: I89a651b58522e394130438fe305796e280a947eb
Resolves: #40757
Releases: 6.0
Reviewed-on: http://review.typo3.org/14453
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Split off functional category collection tests
Christian Kuhn [Sat, 8 Sep 2012 13:02:17 +0000 (15:02 +0200)]
[BUGFIX] Split off functional category collection tests

Most CategoryCollectionTests need dummy records and dummy database
tables to work. They do not only test the category collection class
itself, but also the underlying database functionality and queries.
They are functional tests, and moved to the functional section.

Change-Id: I53b04e701ef1475914c7125ab1a6ae6f908d9a3f
Resolves: #40756
Releases: 6.0
Reviewed-on: http://review.typo3.org/14448
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] File upload button is collapsed in Chrome 21
Steffen Gebert [Wed, 15 Aug 2012 11:57:43 +0000 (13:57 +0200)]
[BUGFIX] File upload button is collapsed in Chrome 21

In Chrome 21, the FlashUploader button is collapsed to a few pixels of
height. So it is nearly impossible to hit the button.

Change-Id: Ia287c1c15b086315442a6b9edba1922de21f3501
Releases: 6.0, 4.7, 4.6, 4.5
Resolves: #39659
Reviewed-on: http://review.typo3.org/13789
Reviewed-by: Thomas Scheibitz
Tested-by: Thomas Scheibitz
Reviewed-by: Torben Hansen
Tested-by: Torben Hansen
Reviewed-by: Marcel Wieser
Tested-by: Marcel Wieser
Reviewed-by: Stefan Neufeind
Reviewed-by: Marcus Schwemer
Reviewed-by: Oliver Klee
Reviewed-by: Laurent Cherpit
Tested-by: Laurent Cherpit
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[BUGFIX] Selection of Multiple Collections in CE Uploads
Steffen Ritter [Mon, 3 Sep 2012 08:11:32 +0000 (10:11 +0200)]
[BUGFIX] Selection of Multiple Collections in CE Uploads

Due to a missing TCA-definition it is not possible to
select more than one collection in a content element
of type "uploads".

With adding the missing TCA this works again.

Change-Id: I12907a15fa7efd4e30ff028ccc7aafa77919be8f
Fixes: #40545
Releases: 6.0
Reviewed-on: http://review.typo3.org/14299
Reviewed-by: Mario Rimann
Tested-by: Mario Rimann
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[BUGFIX] sys_file_reference uses filename instead of title
Steffen Ritter [Thu, 6 Sep 2012 13:21:02 +0000 (15:21 +0200)]
[BUGFIX] sys_file_reference uses filename instead of title

When using a file a sys_file_reference entry is created.
The fields of that record are pre-filled with values from
the original file.
The title field of the reference currently does not refer
to the title, but to the file-name.

Change-Id: I632e55312af99e31d6e02b35883131411eb4dced
Fixes: #40675
Releases: 6.0
Reviewed-on: http://review.typo3.org/14416
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[BUGFIX] Sysext impexp compat layer refers to uppercase class folder
Steffen Ritter [Tue, 4 Sep 2012 06:22:42 +0000 (08:22 +0200)]
[BUGFIX] Sysext impexp compat layer refers to uppercase class folder

The auto-generated compat layer for the namespace switch
requires the clickmenu classes within the "Classes" folder
while the reside in "classes". This fails on an system with
case sensitive file system.

Change the reference to the correct folder.

Change-Id: If523418694684b767aeb16298db2a9fb30a443d5
Fixes: #40575
Release: 6.0
Reviewed-on: http://review.typo3.org/14325
Reviewed-by: Anja Leichsenring
Tested-by: Marcel Burkhalter
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[BUGFIX] L10n parser interface is wrongly defined
Xavier Perseguers [Wed, 5 Sep 2012 06:52:55 +0000 (08:52 +0200)]
[BUGFIX] L10n parser interface is wrongly defined

The parsers extending the localization parser interface do not have a
compatible third parameter of method getParsedData() as it is optional
with the 3 implementations (PHP, ll-XML, XLIFF) but is not defined as
this in the interface.

Change-Id: Ifb2f2e9b94c61f53d626aa387513322fa0737c83
Fixes: #40641
Releases: 6.0, 4.7, 4.6
Reviewed-on: http://review.typo3.org/14358
Reviewed-by: Wouter Wolters
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] Take versioned record into account for showHidden flag.
Steffen Ritter [Wed, 5 Sep 2012 06:21:30 +0000 (08:21 +0200)]
[BUGFIX] Take versioned record into account for showHidden flag.

FollowUp to issue #33392 in master - the merged condition
in if always results to true --> every page is considered
as workspace spage. This results in a broken preview
functionality for normal live pages.

Should be integrated in 4.7, 4.6 and 4.5 directly when
backporting the original issue.

Change-Id: Ibe57c575020caf0184ddce54744f52b176027d7a
Fixes: #33392
Releases: 6.0
Reviewed-on: http://review.typo3.org/14357
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[BUGFIX] Hide/Unhide of FileReferences in IRRE does not work
Steffen Ritter [Mon, 3 Sep 2012 14:45:38 +0000 (16:45 +0200)]
[BUGFIX] Hide/Unhide of FileReferences in IRRE does not work

IRRE hide/unhide feature just changes the input of the
hidden field. If the field is not present in the rendered
form, the change is not saved to database.

Therefore add the hidden field of sys_file_references to
the hidden palette.

Change-Id: I46ac1e87c49b995c0b5ec9bf0d454de705c88b68
Fixes: #40564
Releases: 6.0
Reviewed-on: http://review.typo3.org/14317
Tested-by: Marcel Burkhalter
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[BUGFIX] Editing *_users with saltedpasswords active fails
Steffen Ritter [Mon, 3 Sep 2012 13:44:10 +0000 (15:44 +0200)]
[BUGFIX] Editing *_users with saltedpasswords active fails

Since the namespace changes, the custom form-field-
evaluators for passwords shipped by saltedpasswords are
registered using the namespaced classes.

As the registered class name is used by tceForms to build
an internal JS function, the JS is broken due to the fact
that backslashes are not allowed in JS function names.

This patch reverts back to "classic" classnames as eval
identifier.

Change-Id: Ica52c01456be7a8ee2b7988cc9773586852621a6
Fixes: #40561
Releases: 6.0
Reviewed-on: http://review.typo3.org/14315
Reviewed-by: Mario Rimann
Tested-by: Mario Rimann
Tested-by: Marcel Burkhalter
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[BUGFIX] Subject field in FormWizard
Florian Scholz [Tue, 15 May 2012 09:30:42 +0000 (11:30 +0200)]
[BUGFIX] Subject field in FormWizard

Allow setting the subject of an Email
by adding a 3rd input field to the
post processor section of the form tab.

Change-Id: If98fb9de576607a254ba5fcbb72df85584c12037
Releases: 6.0, 4.7, 4.6, 4.5
Resolves: #35787
Reviewed-on: http://review.typo3.org/11245
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[BUGFIX] Uncaught Exception on multi-language site
Martin Helmich [Sat, 25 Aug 2012 10:15:17 +0000 (12:15 +0200)]
[BUGFIX] Uncaught Exception on multi-language site

Change-Id: I62d28c206a43d178ae5ec830126b9e86013de6bc
Resolves: #40168
Releases: 6.0
Reviewed-on: http://review.typo3.org/14066
Tested-by: Mario Rimann
Reviewed-by: Mario Rimann
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[TASK] Fix broken references to exceptions in global namespace
Andreas Wolf [Sun, 2 Sep 2012 16:46:06 +0000 (18:46 +0200)]
[TASK] Fix broken references to exceptions in global namespace

With the introduction of namespaces, the references to SPL exceptions
like InvalidArgumentException were not prepended with a backslash. This
renders these references invalid (the class cannot be found in current
namespace) and leads to warnings in most IDEs.

Change-Id: I361f81ed514788852a851aebbb8677b6f533f79a
Resolves: #40536
Releases: 6.0
Reviewed-on: http://review.typo3.org/14292
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[BUGFIX] Changing file title changes file name
Andreas Wolf [Sat, 1 Sep 2012 16:20:39 +0000 (18:20 +0200)]
[BUGFIX] Changing file title changes file name

The TCA configuration of sys_file allows direct editing of the file
name. As t3lib_TCEmain does not recognize this change as a
filesystem-related change on saving, the file is not renamed on disk.
Instead, the index record is changed, so the file is not recognized
anymore, leading to a reindexing. Because of this, all references to the
old record seem to break.

This commit makes the name field read-only and adds the title field
(which is not present in the TCA at all currently).

Change-Id: Ice110fa7ea0cc335f8b9fa8a57ecc9fe7527de76
Resolves: #39884
Resolves: #36795
Resolves: #39859
Releases: 6.0
Reviewed-on: http://review.typo3.org/14260
Reviewed-by: Mario Rimann
Tested-by: Mario Rimann
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[BUGFIX] FAL FileExtensionFilter raises warning
Christian Kuhn [Sun, 2 Sep 2012 22:51:12 +0000 (00:51 +0200)]
[BUGFIX] FAL FileExtensionFilter raises warning

The FileExtensionFilter filterInlineChildren() raises a warning if
$parameters['values'] is not an array. This is triggered by test
areInlineChildrenFilteredWithInvalidParameters() and is sanitized
with this patch.

Change-Id: Ic18575f041eb9e284dc45190d598927c2c0649c5
Resolves: #40543
Releases: 6.0
Reviewed-on: http://review.typo3.org/14298
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] FAL test mock TYPO3_DB without backup
Christian Kuhn [Sun, 2 Sep 2012 22:08:21 +0000 (00:08 +0200)]
[BUGFIX] FAL test mock TYPO3_DB without backup

Service/IndexerServiceTest mocks $GLOBALS['TYPO3_DB'] without a correct
backup and destroys the database resource handle. The patch takes care
that the mock is created correctly, and the orgininal database handle
is re constituted during tearDown().

Change-Id: Id16d6970d6c0614b593a4bc25b69ee1c17963fbe
Resolves: #40542
Releases: 6.0
Reviewed-on: http://review.typo3.org/14297
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Incomplete mocking in AbstractMenuContentObjectTest
Christian Kuhn [Sun, 2 Sep 2012 21:47:31 +0000 (23:47 +0200)]
[BUGFIX] Incomplete mocking in AbstractMenuContentObjectTest

AbstractMenuContentObjectTest of frontend extension mocks TSFE
(TypoScriptFrontendController) but does not provide all needed
constructor parameters, which raises warnings.
The patch now gives add sane parameters.

Change-Id: I80bc3baa701c5994af9299ba0ba3d79aef12c917
Resolves: #40541
Releases: 6.0
Reviewed-on: http://review.typo3.org/14296
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] LogLevelTest dataProvider not used
Christian Kuhn [Sun, 2 Sep 2012 21:12:02 +0000 (23:12 +0200)]
[BUGFIX] LogLevelTest dataProvider not used

isValidLevelThrowsExceptionOnInvalidLevelIfAskedToDoSo() test throwed a
warning that required input parameter $inputValue was not used. This was
because of a typo @dataprovider -> @dataProvider, so the data provider
was not used at all. Fixing this, one of the tests with the
object \stdClass failed.
This turned out to be an error in the thrown exception in validateLevel
 because the exception is not thrown, if the exception message is
compiled from a string and an object. Therefore, the parameter $level
is now left out in method validateLevel().
As additional cleanup, the MathUtilityTest is moved from t3lib to core
extension, and the rootline test and fixture names are adapted.

Change-Id: If5ec0505abc224ad59cd5dc6cb4b679fc4bc46ba
Fixes: #40540
Releases: 6.0
Reviewed-on: http://review.typo3.org/14295
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Warning in Locker if filepointer is no resource
Christian Kuhn [Sun, 2 Sep 2012 19:58:18 +0000 (21:58 +0200)]
[BUGFIX] Warning in Locker if filepointer is no resource

The 'flock' locking calls flose() without checking if the filepointer
is actually a resource. This leads to warnings, triggered by
releaseDoesNotRemoveFilesNotWithinTypo3TempLocksDirectory().
Solution is to check for a valid resource before calling flock() and
fclose().

Change-Id: I2832f2e4ea3ce2780bd347bbb3bb64fa449ab388
Fixes: #40539
Releases: 6.0
Reviewed-on: http://review.typo3.org/14294
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Warning in ConfigurationManagerTest
Christian Kuhn [Sun, 2 Sep 2012 14:28:47 +0000 (16:28 +0200)]
[BUGFIX] Warning in ConfigurationManagerTest

Fix setLocalConfigurationValueByPathReturnFalseIfPathIsNotValid that
calls setLocalConfigurationValueByPath() without a second value and
raises a warning.
Additionally, the test eval's are formatted again to be easy readable.

Change-Id: Ic667c7d0e7cf7d76bda4ab39b98eee425ac623db
Resolves: #40532
Releases: 6.0
Reviewed-on: http://review.typo3.org/14291
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Warning in RecordCollectionRepositoryTest
Christian Kuhn [Sun, 2 Sep 2012 13:50:40 +0000 (15:50 +0200)]
[BUGFIX] Warning in RecordCollectionRepositoryTest

RecordCollectionRepository calls fullQuoteStr() on DataHandler class. The
class is mocked in the tests, so there is no real database link.
fullQuoteStr() expects the link to be a resource, though. Solution is to
mock this method, too.

Change-Id: Id568f9fcef6a8e07dfe8ee4abce8f60d4cebf152
Resolves: #40529
Releases: 6.0
Reviewed-on: http://review.typo3.org/14290
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn