Packages/TYPO3.CMS.git
2 months ago[TASK] Update phpunit/phpunit to 8.3.3 73/61473/3
Anja Leichsenring [Wed, 7 Aug 2019 14:56:37 +0000 (16:56 +0200)]
[TASK] Update phpunit/phpunit to 8.3.3

commands:

- composer update phpunit/phpunit --with-dependencies
- composer update doctrine/instantiator  phpspec/prophecy
- composer update phpunit/phpunit --with-dependencies

Resolves: #88930
Releases: master
Change-Id: I4e96fd713e655324d67a7e37674bb31396a3b247
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61473
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
2 months ago[BUGFIX] Fallback to empty array if ExportController receives no input 02/61502/2
Andreas Fernandez [Fri, 16 Aug 2019 07:58:30 +0000 (09:58 +0200)]
[BUGFIX] Fallback to empty array if ExportController receives no input

Resolves: #88968
Releases: master
Change-Id: I1cab8a60e5b562376f9ac6bb6836e949bb9b1b50
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61502
Reviewed-by: Josef Glatz <josefglatz@gmail.com>
Reviewed-by: Pascal Querner <pq@paskl.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Pascal Querner <pq@paskl.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[BUGFIX] Incorrect HTTP range specification in Linkvalidator 96/61496/2
Dmitry Dulepov [Wed, 14 Aug 2019 16:35:13 +0000 (19:35 +0300)]
[BUGFIX] Incorrect HTTP range specification in Linkvalidator

Range specifications in HTTP may not include spaces. While many
web servers tolerate them, some return a 416 HTTP error. This
change makes range request from Linkvalidator to follow RFC 7233.

Resolves: #88958
Releases: master, 9.5, 8.7
Change-Id: I06fe31ab9db1a0391853f21ce28cb92be0b5656d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61496
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[BUGFIX] Process t3:// link resources correctly 98/61498/9
Oliver Hader [Wed, 14 Aug 2019 17:33:12 +0000 (19:33 +0200)]
[BUGFIX] Process t3:// link resources correctly

* t3://email?email=oliver@typo3.org (be greedy about missing mailto:)
* t3://file?identifier=1:/logo.png (not implemented since no integer)

Besides that according test cases are added in order to ensure the
basic behavior of link handling in a TypoScript frontend rendering
scenario using t3:// link resources.

Resolves: #88960
Releases: master, 9.5, 8.7
Change-Id: I9a1f47f2eaaacc4368a1ca3e1a4006a8248e654e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61498
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
2 months ago[BUGFIX] Fix typos in PHPDoc, rst file and template 86/61486/3
Oliver Bartsch [Mon, 12 Aug 2019 08:01:33 +0000 (10:01 +0200)]
[BUGFIX] Fix typos in PHPDoc, rst file and template

Fixes following typos:
- Replace 'ite_language' with 'site_language' in SiteTcaInline
- Replace 'langauges' with 'languages' in rst file
- Replace 'sytem' with 'system' in CreateAdmin template

Resolves: #88948
Releases: master, 9.5
Change-Id: Iaca4ad7eb7647508e3de66004c288efe84be4b0b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61486
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Susanne Moog <look@susi.dev>
2 months ago[BUGFIX] Require symfony/finder 4.3 91/61491/3
Andreas Fernandez [Tue, 13 Aug 2019 08:44:53 +0000 (10:44 +0200)]
[BUGFIX] Require symfony/finder 4.3

The bugfix for #88883 makes use of natural sorting via Symfony's Finder
component. Since TYPO3 depends on version 4.1, this won't work since the
feature was introdcuced in version 4.2.

This patch updates symfony/finder to version 4.3.

Executed composer command:

  composer require symfony/finder:^4.3

Resolves: #88953
Related: #88883
Releases: master
Change-Id: Ia4c3b246153d763f640de3dc1deeed6b40c601f4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61491
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
2 months ago[BUGFIX] Use workspace overlays in Record Path 98/60498/2
Benni Mack [Wed, 17 Apr 2019 18:50:49 +0000 (20:50 +0200)]
[BUGFIX] Use workspace overlays in Record Path

When in workspace, the workspaced version of the "bread crumb"
should be shown as rootline / page path in all modules.

Very specifically, the workspace module now shows this properly.

Resolves: #36285
Releases: master, 9.5
Change-Id: I1419ccb781315632eb28e194add4db20d0d76d15
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60498
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
2 months ago[BUGFIX] Increase memory cost of argon2i and force testing mariadb 10.3 83/61483/5
Andreas Fernandez [Fri, 9 Aug 2019 09:11:58 +0000 (11:11 +0200)]
[BUGFIX] Increase memory cost of argon2i and force testing mariadb 10.3

Due to security reasons, PHP's default memory_cost of argon2i has been
increased from 16384 to 65536:

  https://bugs.php.net/bug.php?id=78269

We shouldn't lower the factory default, thus this patch alignes the
hashing implementation.

Furthermore, mariadb 10.4 currently crashes with the functional
tests. The patch forces 10.3 for now to make bamboo green again.

Resolves: #88942
Releases: master, 9.5
Change-Id: I3650a709d92d5807058b628390ced7c1208ec06a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61483
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[BUGFIX] Ensure test environment is bootstrapped for cache backend tests 78/61478/4
Andreas Fernandez [Thu, 8 Aug 2019 11:33:47 +0000 (13:33 +0200)]
[BUGFIX] Ensure test environment is bootstrapped for cache backend tests

The cache backends tests need a bootstrapped test environment, since vital
parts are not booted at all, e.g. the Environment is undefined.

For this reason, the parent `setUp()` method is now called, albeit this
was not required previously.

Resolves: #88937
Releases: master, 9.5
Change-Id: Iaced6421e2042482c35c5b0d7a32eb9fe1a6c895
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61478
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
2 months ago[BUGFIX] Use calling class name for logger initialization 79/61479/3
Anja Leichsenring [Thu, 8 Aug 2019 12:01:28 +0000 (14:01 +0200)]
[BUGFIX] Use calling class name for logger initialization

Static class binding via `static::class` leads to the correct class name
in inherited classes.

Resolves: #88938
Relates: #88775
Relates: #87820
Releases: master, 9.5
Change-Id: I9a866fa26d3e7100d0db694237142f1449c68391
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61479
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[BUGFIX] Make sure the baseVariants are respected 75/61375/4
Guido Schmechel [Fri, 26 Jul 2019 10:17:20 +0000 (12:17 +0200)]
[BUGFIX] Make sure the baseVariants are respected

In the ContentObjectRenderer there is the possibility to get
the Site Configuration. Here a simple array which is read out.

In the case of baseUrl, the baseVariants are now considered
with the possible conditions.

Resolves: #88847
Releases: master, 9.5
Change-Id: I8db7e9264e82d4021ea8fe63b690eb2ec09288e4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61375
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[BUGFIX] Instantiate Logger on cache backend creation 72/61472/5
Anja Leichsenring [Wed, 7 Aug 2019 11:38:15 +0000 (13:38 +0200)]
[BUGFIX] Instantiate Logger on cache backend creation

Cache backends are created via new, not using GU::makeInstance.
So it happened no cache has been initialized, causing errors upon
calls for the logger.
Putting cache creation into the cache backend constructor solves
the problem and makes sure the logger is always available.

Resolves: #88775
Resolves: #87820
Releases: master, 9.5
Change-Id: I4005b812e96c028528f3740c581b8086cfc592f0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61472
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[BUGFIX] Disable autocompletion in installation options 51/61451/2
Andreas Fernandez [Wed, 7 Aug 2019 09:25:00 +0000 (11:25 +0200)]
[BUGFIX] Disable autocompletion in installation options

Since Chrome is really picky about having autocomplete disabled, this
patch sets the autocomplete configuration for password fields to
`new-password` used in "Configure Installation-Wide Options". This is a
proposed workaround mentioned at MDN:

  https://developer.mozilla.org/en-US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion#Preventing_autofilling_with_autocompletenew-password

Resolves: #88832
Resolves: #88851
Releases: master, 9.5
Change-Id: Iddabbb16e91b7ef66f97be1d63e15e96d971441b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61451
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Josef Glatz <josefglatz@gmail.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Josef Glatz <josefglatz@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
2 months ago[TASK] Render only latest three major versions in documentation changelog 49/61449/4
Frank Naegler [Tue, 6 Aug 2019 21:45:27 +0000 (23:45 +0200)]
[TASK] Render only latest three major versions in documentation changelog

The documentation changelog now renders only the docs for the latest
three major versions.

Resolves: #88884
Releases: master
Change-Id: I43ea7d525cbcf32acc6999b75f08669706051282
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61449
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <look@susi.dev>
2 months ago[TASK] Make Redis connectors compatible with PHP redis version 5 77/61277/5
Markus Klein [Fri, 12 Jul 2019 09:14:02 +0000 (11:14 +0200)]
[TASK] Make Redis connectors compatible with PHP redis version 5

Version 5 of phpredis deprecates some methods, which have not been
aligned to the official redis commands.
This patch replaces all calls to use the correct methods.

Resolves: #88701
Releases: master, 9.5, 8.7
Change-Id: Ib8921d31a9df6631a99d70fabc8c32f81bbd0fc4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61277
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
2 months ago[BUGFIX] Mark fields as changed after updating value via ElementBrowser 50/61450/2
Andreas Fernandez [Wed, 7 Aug 2019 09:05:28 +0000 (11:05 +0200)]
[BUGFIX] Mark fields as changed after updating value via ElementBrowser

With this patch, fields are now marked as changed when their value is
updated by using the Element Browser.

Resolves: #88875
Releases: master, 9.5
Change-Id: Ia39d080cfff538100c45561d8492c745c76388e7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61450
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Josef Glatz <josefglatz@gmail.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Josef Glatz <josefglatz@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
2 months ago[BUGFIX] Make redis pconnect calls unique 93/61393/5
Markus Klein [Wed, 31 Jul 2019 00:07:01 +0000 (02:07 +0200)]
[BUGFIX] Make redis pconnect calls unique

By using the persistent_id parameter of the redis->pconnect
method, we ensure that the connection is not shared between
multiple Redis*Backends connecting to the same Redis server.

Omitting the persistent_id causes the same connection to be reused
whenever another Redis*Backend is created, whereby the last
connection selects the database to use for the connection, effectively
causing all Redis*Backends to write to the same database.

The RedisSessionBackend uses the pconnect method by default and
therefore requires this fix in order to distinguish FE and BE
backends correctly, if both are stored within a Redis database.

The pconnect is optional for the cache RedisBackend, but we still
use the database number now for the persistent_id parameter.

Resolves: #88866
Releases: master, 9.5, 8.7
Change-Id: I987c36e89f2ab53fd5177cdc7051811b116bcad0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61393
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
2 months ago[BUGFIX] Adapt registration for crawler 7+ 27/61427/3
Tizian Schmidlin [Sat, 3 Aug 2019 11:49:35 +0000 (13:49 +0200)]
[BUGFIX] Adapt registration for crawler 7+

The way procInstructions are registered changes in the new version
of crawler which will be the first version compatible with TYPO3 9.

Resolves: #88905
Releases: master, 9.5
Change-Id: Ia4701d4a39dacdae2a7816fcea29601a0ec2796a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61427
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[BUGFIX] Show real directory name in flash message after renaming 48/61348/6
Daniel Windloff [Wed, 24 Jul 2019 12:47:57 +0000 (14:47 +0200)]
[BUGFIX] Show real directory name in flash message after renaming

After renaming a directory, the name of the directory after character
replacement is shown in the flash message.

Add a different flash message, if some characters are replaced.

Resolves: #88816
Releases: master, 9.5
Change-Id: I393625c353474d2a06161765a7f4b3c1ca28c0db
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61348
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
2 months ago[BUGFIX] Support multiple order by fields in PageRepository 25/61425/2
Georg Großberger [Sat, 3 Aug 2019 08:10:14 +0000 (10:10 +0200)]
[BUGFIX] Support multiple order by fields in PageRepository

The method PageRepository::getSubpagesForPages allows an arbitrary
number of orderBy fields, though the way it is passed to the
query builder, only the last field is used.

This patch simply changes the DBAL call to ->addOrderBy to ensure
all set order by fields are used, in the order they are defined.

Resolves: #88876
Releases: master, 9.5
Change-Id: I97ad77490ec42cec5e46ec954bf4e2ba694d9eec
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61425
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
2 months ago[BUGFIX] Fix return type of getFileObjectFromCombinedIdentifier 47/61447/5
Oliver Bartsch [Tue, 6 Aug 2019 06:36:26 +0000 (08:36 +0200)]
[BUGFIX] Fix return type of getFileObjectFromCombinedIdentifier

getFileObjectFromCombinedIdentifier of ResourceFactory returns a
\TYPO3\CMS\Core\Resource\File, \TYPO3\CMS\Core\Resource\ProcessedFile
or null.

Resolves: #88924
Releases: master, 9.5
Change-Id: Icc13c6c1729fde6db5646f7a0dce74f953ba122a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61447
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[TASK] Use dependency injection in middlewares 22/61322/5
Benjamin Franzke [Fri, 19 Jul 2019 04:47:46 +0000 (06:47 +0200)]
[TASK] Use dependency injection in middlewares

Use constructor injection for middleware dependencies, moving away
from GeneralUtility::makeInstance based Singleton lookup.
Dependencies which are already configured to be optionally
injectable via constructor arguments (e.g. for unit tests) are
changed to be required constructor arguments. Since the introduction of
symfony dependency injection the fallback to GeneralUtility::makeInstance
is no longer used – therefore it is dropped.

Releases: master
Resolves: #88800
Change-Id: I6dbec2f91fc78c1b06dd179323fb7a4810c13baa
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61322
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
2 months ago[BUGFIX] Fix typo in QueryView 41/61441/2
Oliver Bartsch [Mon, 5 Aug 2019 11:40:20 +0000 (13:40 +0200)]
[BUGFIX] Fix typo in QueryView

This fixes a typo in a variable in QueryView.

Resolves: #88920
Releases: master, 9.5
Change-Id: I59b4034931b3f8837aef6dda0c56e342c3552926
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61441
Tested-by: Stefan P <spo@snk.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Stefan P <spo@snk.de>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[BUGFIX] Correct variable usage in f:uri.action 38/61438/2
Georg Ringer [Sun, 4 Aug 2019 18:32:04 +0000 (20:32 +0200)]
[BUGFIX] Correct variable usage in f:uri.action

Use the correct variables in f:uri.action which have been switched
with #87629.

Resolves: #88915
Releases: master
Change-Id: Icbdc3c7319bf2459a8eed2ca79961204e6d6153c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61438
Tested-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Josef Glatz <josefglatz@gmail.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Reviewed-by: Josef Glatz <josefglatz@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[BUGFIX] Set correct default value for page action callbacks 09/61409/4
Andreas Fernandez [Fri, 2 Aug 2019 20:39:33 +0000 (22:39 +0200)]
[BUGFIX] Set correct default value for page action callbacks

This patch sets the correct default value for page action callbacks passed
for `TYPO3/CMS/Backend/PageActions`. Empty strings are not treated
properly, also the argument of `PageRenderer::loadRequireJsModule` sets
the default value to null.

Resolves: #88649
Related: #88532
Releases: master, 9.5
Change-Id: Ic5ce5eca5c0f2845ff9453e5f8d50de7cd650356
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61409
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
2 months ago[TASK] Update nikic/php-parser to 4.2 35/61435/3
Andreas Fernandez [Sun, 4 Aug 2019 08:13:10 +0000 (10:13 +0200)]
[TASK] Update nikic/php-parser to 4.2

This patch updates nikic/php-parser to version 4.2.2, which brings
better support for PHP 7.3 and adds initial support for PHP 7.4.

Changelog: https://raw.githubusercontent.com/nikic/PHP-Parser/v4.2.2/CHANGELOG.md

Composer command:

  composer require nikic/php-parser:^4.2

Resolves: #88914
Releases: master, 9.5
Change-Id: I6d7feb8851be6e5565cb069fb33c279f916f4667
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61435
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[TASK] Sort php-cs-fixer rules by name 34/61434/4
Andreas Fernandez [Sat, 3 Aug 2019 16:40:45 +0000 (18:40 +0200)]
[TASK] Sort php-cs-fixer rules by name

Resolves: #88911
Releases: master
Change-Id: I310f0fb85cfa40b70ce65274e6e04fc21586ce0b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61434
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <look@susi.dev>
2 months ago[BUGFIX] Pass FrontendUserAuthentication to redirect handling 30/61430/3
Andreas Fernandez [Sat, 3 Aug 2019 13:06:53 +0000 (15:06 +0200)]
[BUGFIX] Pass FrontendUserAuthentication to redirect handling

`$GLOBALS['TSFE']->fe_user` is not available in the RedirectService. This
patch now explicitly passes the `frontend.user` attribute of the current
request to the RedirectService.

Resolves: #88906
Releases: master
Change-Id: Iae876d6a14f29e675295503be3be80008bcccbb1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61430
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[BUGFIX] Prevent ReflectionException when scheduler/reports is unavailable 42/61342/4
Benjamin Franzke [Tue, 23 Jul 2019 12:18:18 +0000 (14:18 +0200)]
[BUGFIX] Prevent ReflectionException when scheduler/reports is unavailable

When symfony/dependency-injection crawls the available classes
a ReflectionException [1] occurs when the base class or interface of an
analyzed class is not available.

This currently happens for scheduler tasks and status reports in composer
mode. The dependency to external base classes/interfaces is missing in the
respective composer.json files and therefore EXT:scheduler and EXT:reports
are not guaranteed to be availble.

Exclude the affected status report and scheduler task classes from
autowiring and autoconfiguration in order to fix this issue.

Note: Dependency injection can still be added for these classes,
but as long as the implicit dependencies to EXT:scheduler and EXT:reports
are not fixed, these classes will need to be wired manually. Example:

  TYPO3\CMS\Reports\Task\SystemStatusUpdateTask:
    autoconfigure: false
    autowire: false
    public: true
    arguments:
      - '@cache.core'

[1] Uncaught ReflectionException:
    Class TYPO3\CMS\Scheduler\Task\AbstractTask not found in
    […]/typo3/sysext/reports/Classes/Task/SystemStatusUpdateTask.php:28

Resolves: #88825
Resolves: #88912
Releases: master
Change-Id: I74113aa87336bbde02b8754639eafc4158dc3717
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61342
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
2 months ago[BUGFIX] Fix tests with phpunit 8.3.2 33/61433/2
Anja Leichsenring [Sat, 3 Aug 2019 16:13:37 +0000 (18:13 +0200)]
[BUGFIX] Fix tests with phpunit 8.3.2

The new minor version of phpunit comes with a (probably) bug in their
mock API that causes errors in reflection and ClassSchema construction.
Also, partial mock with a function that does not exist, will now throw
a warning.

Resolves: #88910
Releases: master
Change-Id: Ic43fc0f72f2f5cab97a7907f4f66ffe82516300b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61433
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 months ago[BUGFIX] Prevent tt_content.table being broken if last field is empty 23/61423/2
Michael Blunck [Fri, 2 Aug 2019 22:47:39 +0000 (00:47 +0200)]
[BUGFIX] Prevent tt_content.table being broken if last field is empty

This only applies to table elements where no text enclosure
is configured.

Resolves: #88418
Releases: master, 9.5
Change-Id: I8ba7cefe0da37fd7987858c1302dac9f3ba2ff10
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61423
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Marco Bresch <marco.bresch@starfinanz.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Marco Bresch <marco.bresch@starfinanz.de>
Reviewed-by: Susanne Moog <look@susi.dev>
2 months ago[BUGFIX] Removes cropping from pagetree title 17/61417/2
Michael Blunck [Fri, 2 Aug 2019 21:02:22 +0000 (23:02 +0200)]
[BUGFIX] Removes cropping from pagetree title

Pagetree uses javascript for search.
Cropping causes issues because not the full title
is searched. As the pagetree is neither scrollable
nor resizable, cropping does not make sense anyway
and is therefor removed.

Resolves: #88700
Releases: master, 9.5
Change-Id: I23bd7d1b46a7c455effa0d0452fb6bbeef8ab8eb
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61417
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Thomas Anders <me@naderio.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Thomas Anders <me@naderio.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 months ago[BUGFIX] Ensure all files in a directory are deleted 08/61408/2
Georg Großberger [Fri, 2 Aug 2019 19:00:58 +0000 (21:00 +0200)]
[BUGFIX] Ensure all files in a directory are deleted

The function readdir may skip files inside a directory when
its content is changed, like a file being deleted. This can
cause not all files inside being deleted

To avoid this, we collect all entries inside a directory and
close the read descriptor before deleting all entries inside.

Resolves: #88524
Releases: master, 9.5
Change-Id: I06168e77dccc41ae60b49abd7644ee3748e85588
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61408
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Marco Bresch <marco.bresch@starfinanz.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Matthias Vogel <typo3@kanti.de>
Reviewed-by: Marc von Schalscha <msa@starfinanz.de>
Reviewed-by: Susanne Moog <look@susi.dev>
2 months ago[BUGFIX] Make sure AdditionalConfiguration is loaded 74/61374/4
Jonas Eberle [Fri, 26 Jul 2019 09:07:13 +0000 (11:07 +0200)]
[BUGFIX] Make sure AdditionalConfiguration is loaded

This loads AdditionalConfiguration.php even if LocalConfiguration.php
could not be loaded.

Before this change, configuration for the install tool could only be
given if a LocalConfiguration was present.

With this change, AdditionalConfiguration (if present) is applied
on top of DefaultConfiguration.

In a FIRST_INSTALL scenario, this enables (among others) the correct
evaluation of a set trustedHostsPattern in AdditionalConfiguration.

Resolves: #88846
Resolves: #86356
Releases: master, 9.5
Change-Id: I6c0e39eb57ce6b28b493f1ae9716b478b643dda9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61374
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Marc von Schalscha <msa@starfinanz.de>
Reviewed-by: Maik Peuser <maik.peuser@verdure.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Randy Fay <randy@randyfay.com>
Tested-by: Maik Peuser <maik.peuser@verdure.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
2 months ago[BUGFIX] Fix PHPDoc of "stdWrap_encodeForJavaScriptValues" 13/61413/2
Felix Heller [Fri, 2 Aug 2019 21:03:21 +0000 (23:03 +0200)]
[BUGFIX] Fix PHPDoc of "stdWrap_encodeForJavaScriptValues"

Resolves: #88900
Releases: master, 9.5
Change-Id: I37e53ddbe634d58bf1dfaf4578ac2c03a1a93d90
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61413
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[BUGFIX] Fix typos in EmailFinisher 14/61414/3
dominikdoerr [Fri, 2 Aug 2019 20:59:09 +0000 (22:59 +0200)]
[BUGFIX] Fix typos in EmailFinisher

This fixes some typos to make the comments more readable.

Resolves: #88584
Releases: master, 9.5
Change-Id: I165a80f2f4d82c1090f4413140c6b584c7b93ecd
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61414
Reviewed-by: Maik Peuser <maik.peuser@verdure.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[BUGFIX] Wrong sorting in documentation changelog 15/61415/2
Pascal Rinker [Fri, 2 Aug 2019 20:46:22 +0000 (22:46 +0200)]
[BUGFIX] Wrong sorting in documentation changelog

Fix the sorting in documentation changelog that orders the versions
currently wrong.

Resolves: #88883
Releases: master
Change-Id: Icb3e67b16c345b0bf7923cb995072c6f28e9d596
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61415
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Roman Schilter <roman.schilter10@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
2 months ago[BUGFIX] Disable localization button after initial click 11/61411/4
Oliver Bartsch [Fri, 2 Aug 2019 21:00:44 +0000 (23:00 +0200)]
[BUGFIX] Disable localization button after initial click

This prevents various errors, caused by clicking the
localization button in the recordlist multiple times.

Resolves: #88731
Releases: master, 9.5
Change-Id: I93499d3892b9897038f8cfbd5f6dab33dc585bb1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61411
Tested-by: Josef Glatz <josefglatz@gmail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Josef Glatz <josefglatz@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[BUGFIX] Fill alternative language keys correctly 56/60356/4
Jan Delius [Mon, 1 Apr 2019 11:24:17 +0000 (13:24 +0200)]
[BUGFIX] Fill alternative language keys correctly

This change adds the language dependencies individually to the array
instead of completely overwriting them as a string. Since the
dependencies are iterated in the core, this function only adds to the
array instead of overwriting the first index.

Resolves: #88045
Releases: master, 9.5
Change-Id: I3101bf8f9873ffa5ceeee3cc9e9ace36858f39a4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60356
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: theline <typo3@theline.capella.uberspace.de>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: theline <typo3@theline.capella.uberspace.de>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
2 months ago[BUGFIX] Discard published drafts of workspaces when not swapping 82/60882/4
Benni Mack [Wed, 5 Jun 2019 18:57:31 +0000 (20:57 +0200)]
[BUGFIX] Discard published drafts of workspaces when not swapping

When a workspace record is published, the "old", then unused record
has the values:
- workspace-id: 0
- online-id: > 0
- pid: -1

This way, it is not possible to actually find out from which workspace
something was published. This only happens when
not swapping (exchanging data) but doing real "publishing"
from a workspace.

What happens is that the database is filled with obsolete "previously
online" records that have no value anymore.

These records are now deleted, thus, the database is kept
clean. Previously only a CLI command allowed to remove
them, however, they are not needed at all, so the CLI command
is for existing projects that use workspaces in non-swapping mode.

Resolves: #88497
Releases: master
Change-Id: I9393c801de5b62484efc7ef82e389dfff6715a78
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60882
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
2 months ago[BUGFIX] Render tags of documentation changelog deferred 01/61401/2
Andreas Fernandez [Fri, 2 Aug 2019 10:11:11 +0000 (12:11 +0200)]
[BUGFIX] Render tags of documentation changelog deferred

Currently, when the changelogs get rendered in the Install Tool, for each
document the tags get rendered in the document itself, which has a huge
negative impact on rendering performance.

This patch changes the rendering to the triggered deferred, when the
document is opened.

Resolves: #88882
Releases: master, 9.5
Change-Id: Ie5be93fb0a8b3d1aa2532b2d1a29c1948778c9d7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61401
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Josef Glatz <josefglatz@gmail.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Josef Glatz <josefglatz@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[BUGFIX] Prevent PHP Warning with TCA selectTree 22/61122/4
Markus Klein [Mon, 24 Jun 2019 16:45:01 +0000 (18:45 +0200)]
[BUGFIX] Prevent PHP Warning with TCA selectTree

Make sure there is actually an 'items' array in the processedTCA
before validating the items.

Resolves: #88624
Releases: master, 9.5, 8.7
Change-Id: I1fb6d47ac017ce6950926387387ad19d8445af74
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61122
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[BUGFIX] Render slug dependent fields in single table view 17/61317/7
Georg Ringer [Thu, 18 Jul 2019 06:35:46 +0000 (08:35 +0200)]
[BUGFIX] Render slug dependent fields in single table view

If only the slug field should be rendered in the record list, all fields
which are required to generate the slug are added as well.

This makes it possible to have a simple mass update option for slug fields.

Resolves: #88156
Releases: master, 9.5
Change-Id: Ie8463691bc715c92668f65170948ad2518520528
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61317
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Josef Glatz <josefglatz@gmail.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Josef Glatz <josefglatz@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[TASK] Deprecate sending mails in ContentObjectRenderer 84/61384/9
Georg Ringer [Mon, 29 Jul 2019 07:10:26 +0000 (09:10 +0200)]
[TASK] Deprecate sending mails in ContentObjectRenderer

The ContentObjectRenderer should not care about sending mails, therefore it has
been marked as deprecated.

Resolves: #88850
Releases: master
Change-Id: Ibbeefe313dd0b306a69d3ff77703fae49f02ae1d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61384
Tested-by: Josef Glatz <josefglatz@gmail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Josef Glatz <josefglatz@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[BUGFIX] Streamline routing redirects to default site language 46/61346/4
Oliver Hader [Wed, 24 Jul 2019 09:30:44 +0000 (11:30 +0200)]
[BUGFIX] Streamline routing redirects to default site language

Calling the frontend with an URL that does not contain a valid base
URI for a configured language resulted in a temporary redirect (307)
to the base URI of the default language. In order to allow detecting
outdated links returning a page not found (404) is used.

Example: https://example.org/en/ is the base URI of a valid language
+ https://example.org/ -> redirects to default language /en/ (307)
+ https://example.org/nothing/ -> responds a page not found  (404)

Releases: master, 9.5
Resolves: #88838
Change-Id: I9a3eeb53da8e0bb92799d8e29404513699411078
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61346
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Chris Müller <typo3@krue.ml>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Chris Müller <typo3@krue.ml>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[TASK] Remove special TSFE handling in FileCollector 50/61350/4
Benni Mack [Thu, 25 Jul 2019 06:12:32 +0000 (08:12 +0200)]
[TASK] Remove special TSFE handling in FileCollector

The FileCollector is e.g. used for resolving
references in the FILES cObject. The check for
TSFE can be removed since the ->getFileReferences
functionality should be used at any time, as the
functionality always handles overlays depending
on the $referenceRecord given.

Resolves: #88859
Releases: master
Change-Id: I500421a12cced80e133b12a0caf6dcf289c6bd9a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61350
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[FEATURE] Add noopener and noreferrer to external target blank links 94/59194/12
Daniel Siepmann [Tue, 18 Dec 2018 13:16:10 +0000 (14:16 +0100)]
[FEATURE] Add noopener and noreferrer to external target blank links

All links processed by TypoLink now will add rel="noopener noreferrer"
if necessary.
They are only added for target="_blank" and external hosts.

Resolves: #78488
Releases: master
Change-Id: I24f6a7756e7905ed641e193aff5d1d94375233c0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59194
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[TASK] Use correct TCA for nav_hide and content_from_pid fiels of pages 91/60891/7
Markus Klein [Thu, 6 Jun 2019 16:01:30 +0000 (18:01 +0200)]
[TASK] Use correct TCA for nav_hide and content_from_pid fiels of pages

'l10n_mode' => 'prefixLangTitle'
does not make sense for checkboxes and group types

Add language sync to those fields, so those can be overwritten in
translations.

Resolves: #88511
Releases: master, 9.5
Change-Id: Ib64b5455139100c113d3ded76e0b140b43542c4d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60891
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
2 months ago[TASK] Optimize UI of language packs management 98/61398/4
Andreas Fernandez [Thu, 1 Aug 2019 16:11:47 +0000 (18:11 +0200)]
[TASK] Optimize UI of language packs management

The UI of the "Manage Language Packs" modal is optimized:

- Buttons are grouped into a `btn-group`
- Language name is rendered next to the buttons
- Space is added between extension icon and title

Resolves: #88885
Releases: master
Change-Id: I728ef22a5983ae7d419f88b7ceffd552ef2a1b33
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61398
Tested-by: Josef Glatz <josefglatz@gmail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Josef Glatz <josefglatz@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[BUGFIX] Mention new TypoScriptService namespace 96/61396/6
linawolf [Wed, 31 Jul 2019 06:40:32 +0000 (06:40 +0000)]
[BUGFIX] Mention new TypoScriptService namespace

This explains where `TypoScriptService` was moved to.

In order to ease the migration the documentation now
mentions the full class name.

Releases: master, 9.5, 8.7
Resolves: #88868
Change-Id: Id83c83e3932fdea6a29127c1de6bee9320fa9110
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61396
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[BUGFIX] Use proper methods of symfony/mime 83/61383/5
Georg Ringer [Mon, 29 Jul 2019 04:33:14 +0000 (06:33 +0200)]
[BUGFIX] Use proper methods of symfony/mime

Fix missing parts after the migration from swiftmailer to symfony/mime

Resolves: #88849
Releases: master
Change-Id: I3d30589cac44ff7d387a49857bb1f7820c580138
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61383
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Josef Glatz <josefglatz@gmail.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Josef Glatz <josefglatz@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[TASK] Organize Install Tool JavaScript modules into directories 97/61397/2
Andreas Fernandez [Thu, 1 Aug 2019 12:48:09 +0000 (14:48 +0200)]
[TASK] Organize Install Tool JavaScript modules into directories

For organizational purposes the Install Tool JavaScript modules are now
grouped into directories matching their parent module.

Resolves: #88880
Releases: master
Change-Id: Ifc9844f6e044e1b1ea6ebd394a433d7bf1ae014e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61397
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <look@susi.dev>
2 months ago[TASK] Deprecate T3_THIS_LOCATION 85/61385/7
Andreas Fernandez [Mon, 29 Jul 2019 15:44:24 +0000 (17:44 +0200)]
[TASK] Deprecate T3_THIS_LOCATION

This patch deprecates the global variable `T3_THIS_LOCATION`. This
variable is mostly used to attach a returnUrl argument to links,
triggered via a redirect on an onclick event.

In most cases this is not necessary anymore, also it's considered bad
practice not to use regular links in an href attribute.

Resolves: #88854
Releases: master
Change-Id: I9d90a59b83b956f0bf1e380a55d6c3a4c2d469b5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61385
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
2 months ago[TASK] Allow longer URL in redirects 81/61381/3
Guido Schmechel [Fri, 26 Jul 2019 16:18:47 +0000 (18:18 +0200)]
[TASK] Allow longer URL in redirects

Extend field length of source_path and target

Resolves: #88336
Releases: master, 9.5
Change-Id: I46c241b5782b0a0b8b2947cf0b063340785aa4fe
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61381
Tested-by: Daniel Windloff
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jonas Eberle <flightvision@googlemail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Windloff
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Jonas Eberle <flightvision@googlemail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
2 months ago[FEATURE] Display Application Context in CLI 82/61382/8
Guido Schmechel [Fri, 26 Jul 2019 16:38:57 +0000 (18:38 +0200)]
[FEATURE] Display Application Context in CLI

The Command Request Handler now displays the
current Application Context when executing the
CLI context.

Resolves: #88318
Releases: master
Change-Id: If8994eee4e08c78f71972524873edfd7f0db07f0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61382
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Jonas Eberle <flightvision@googlemail.com>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Jonas Eberle <flightvision@googlemail.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
2 months ago[BUGFIX] Drop superfluous `returnUrl` argument 91/61391/2
Andreas Fernandez [Tue, 30 Jul 2019 14:07:18 +0000 (16:07 +0200)]
[BUGFIX] Drop superfluous `returnUrl` argument

With #88787 the method `makeReturnUrl()` is used to append the returnUrl
to the links. The method already attaches the `returnUrl` argument, this
patch removes the superfluous arguments.

Resolves: #88864
Related: #88787
Releases: master
Change-Id: I95103a11215e5ec1157a7a239130fdd95996f14a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61391
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[TASK] Deprecate `T3_RETURN_URL` 90/61390/2
Andreas Fernandez [Tue, 30 Jul 2019 12:48:04 +0000 (14:48 +0200)]
[TASK] Deprecate `T3_RETURN_URL`

The global JavaScript variable `T3_RETURN_URL` containing the returnUrl
sent either via GET or POST has been marked as deprecated.

Resolves: #88862
Releases: master
Change-Id: I77e94932ef117428100dcd413380940ff33a9b9a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61390
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
2 months ago[BUGFIX] Clear page cache: show status, prevent multiple clicks 07/61307/5
Daniel Windloff [Tue, 16 Jul 2019 14:24:02 +0000 (16:24 +0200)]
[BUGFIX] Clear page cache: show status, prevent multiple clicks

Replace the clear cache button with a spinner during the AJAX request.
While the request is executed, the button is no clickable due to
addiional properties and classes being set.

Resolves: #88781
Releases: master
Change-Id: I06d53010d8bd5435ac6fc91ea17ecc6378043f14
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61307
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
2 months ago[TASK] Drop JavaScript function `jumpSelf` 88/61388/3
Andreas Fernandez [Mon, 29 Jul 2019 19:15:52 +0000 (21:15 +0200)]
[TASK] Drop JavaScript function `jumpSelf`

The JavaScript function `jumpSelf` is only used to some clipboard actions.
Moving the links to a regular `href` has the same effect, rendering this
very function useless.

Resolves: #88857
Releases: master
Change-Id: I3ef6e9c7bcbeb214cc24286c3bd4e9eb3dd8835f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61388
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Jonas Eberle <flightvision@googlemail.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Jonas Eberle <flightvision@googlemail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[BUGFIX] Use correct matcher for `BackendUtility::editOnClick` 86/61386/2
Andreas Fernandez [Mon, 29 Jul 2019 18:42:45 +0000 (20:42 +0200)]
[BUGFIX] Use correct matcher for `BackendUtility::editOnClick`

Resolves: #88855
Related: #88787
Releases: master
Change-Id: I3578c36fac2a6bb57704d41ccfa60a6dbd4727b9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61386
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[BUGFIX] Explicitly cast variable to string 45/61345/4
Alexander Schnitzler [Wed, 24 Jul 2019 07:51:40 +0000 (09:51 +0200)]
[BUGFIX] Explicitly cast variable to string

Class \TYPO3\CMS\Extbase\Core\Bootstrap calls method
\TYPO3\CMS\Extbase\Mvc\ResponseInterface::shutdown()
which does not declare a strict return type yet.

Thus, it's possible that the returned value is not
of type string which then violates the return type
promise of method handleRequest() of the Bootstrap
class.

Therefore, the return value is explicitly casted
to string.

Releases: master
Resolves: #88829
Change-Id: Ibea2451e87c5c66070e5ce4ed5f30c408b7412cd
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61345
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Armin Vieweg <armin@v.ieweg.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
2 months ago[TASK] Deprecate BackendUtility::editOnClick() 77/61377/6
Andreas Fernandez [Fri, 26 Jul 2019 13:12:50 +0000 (15:12 +0200)]
[TASK] Deprecate BackendUtility::editOnClick()

This patch deprecates BackendUtility::editOnClick() which is used to build
a JavaScript-based redirect to the EditDocumentController for use in an
`onclick` attribute. This approach is not necessary anymore, thus all
links use a real `href` attriute now.

Also, this patch removes the following methods:
- TYPO3\CMS\Backend\View\PageLayoutView::linkWrapTable()
- TYPO3\CMS\Backend\View\PageLayoutView::linkWrapItems()
- TYPO3\CMS\Backend\View\PageLayoutView::newContentElementOnClick()

Reason is that these methods contain code that would need a migration, but
are unused in the whole Core. Since the class is marked as "internal",
it's considered safe to remove them.

Resolves: #88787
Releases: master
Change-Id: I8bd3868287204fc3275a43f938d9aeb9fbb6306d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61377
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Windloff
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Daniel Windloff
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[TASK] Log module: Move "show history" to the actions column 41/61341/3
Daniel Windloff [Tue, 23 Jul 2019 08:37:48 +0000 (10:37 +0200)]
[TASK] Log module: Move "show history" to the actions column

Move the "Show history" link to the actions column.
Add default styling for the button.

Resolves: #88822
Releases: master, 9.5
Change-Id: I9952f1683dda3d0fa2b00da3e6a728838da3e1aa
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61341
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Susanne Moog <look@susi.dev>
2 months ago[BUGFIX] Fix typo in comment and documentation 44/61344/2
Sebastian Klein [Tue, 23 Jul 2019 18:41:58 +0000 (20:41 +0200)]
[BUGFIX] Fix typo in comment and documentation

Replace 'nessesary' with 'necessary'.

Resolves: #88828
Releases: master
Change-Id: Ie755aa8f6d994caa64b30c44a0fb0db1414afe32
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61344
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Susanne Moog <look@susi.dev>
2 months ago[TASK] Set TYPO3 version to 10.1.0-dev 39/61339/6
Oliver Hader [Tue, 23 Jul 2019 09:32:18 +0000 (11:32 +0200)]
[TASK] Set TYPO3 version to 10.1.0-dev

Change-Id: Ic8975554d38eef468af5454152a0200e21eb962d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61339
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
2 months ago[RELEASE] Release of TYPO3 10.0.0 38/61338/2 v10.0.0
Benni Mack [Tue, 23 Jul 2019 07:04:57 +0000 (09:04 +0200)]
[RELEASE] Release of TYPO3 10.0.0

Change-Id: I4b576a1651703f7d404dac7127f9ad373310be58
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61338
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
2 months ago[BUGFIX] Use temporary directory for exporting files 36/61336/3
Benni Mack [Mon, 22 Jul 2019 10:56:34 +0000 (12:56 +0200)]
[BUGFIX] Use temporary directory for exporting files

When adding exports into fileadmin, the files
are stored in a temporary folder, which is located
in typo3temp/var/transient/ - this folder does not
need to be accessed via FAL, as it also adds
some issues when this file is not inside the
document root, for this reason, the code is adapted
to work with the native File System directly, and
when moving to fileadmin/user_upload/_temp_/impexp/
then FAL is used again.

Resolves: #88815
Releases: master, 9.5
Change-Id: I633a5dbda595bef73b7420ad511e03c0f7054972
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61336
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <look@susi.dev>
2 months ago[TASK] Disable autocompletion in Install Tool settings 31/61331/4
Guido Schmechel [Sat, 20 Jul 2019 10:54:13 +0000 (12:54 +0200)]
[TASK] Disable autocompletion in Install Tool settings

To prevent unwanted entries, the autocomplete attribute
in the Install tool is added with the `off` property.

Resolves: #88709
Releases: master, 9.5
Change-Id: I3c0a343fd76170f6cc37e5e87ad9a5d5d9a52fb9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61331
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[TASK] Review v10.0 Changelog 28/61328/9
Anja Leichsenring [Fri, 19 Jul 2019 14:22:45 +0000 (16:22 +0200)]
[TASK] Review v10.0 Changelog

Change-Id: Id4f981b3d6b62601ae4f3c7a56b3153d1884f669
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61328
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Benni Mack <benni@typo3.org>
2 months ago[TASK] Only load extensions compatible with TYPO3 v8 or later 35/61335/2
Benni Mack [Mon, 22 Jul 2019 10:53:40 +0000 (12:53 +0200)]
[TASK] Only load extensions compatible with TYPO3 v8 or later

In order to keep the the extension list in the database small,
the repository data is limited to TYPO3 v8 or later.

Resolves: #88814
Releases: master
Change-Id: I1632e269c748541b7a6b8eca763d2938c29c0509
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61335
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
2 months ago[TASK] Clean up comments about deprecation 34/61334/2
Benni Mack [Mon, 22 Jul 2019 10:51:06 +0000 (12:51 +0200)]
[TASK] Clean up comments about deprecation

This patch adds some sentence dots, and adapts
various places about deprecations of 10.0 which
didn't make into TYPO3 v10.0.

Resolves: #88813
Releases: master
Change-Id: I7f7e7037dd09bc1a1b8857e3dfbba3c315eb5712
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61334
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[BUGFIX] Ensure EventDispatcher is available in installtool container 29/61329/4
Benjamin Franzke [Fri, 19 Jul 2019 14:52:07 +0000 (16:52 +0200)]
[BUGFIX] Ensure EventDispatcher is available in installtool container

The Mailer class used by EnvironmentController::mailTestAction()
requires the EventDispatcher to be available. Provide it by
configuring EventDispatcher and ListenerProvider in a ServiceProvider,
which enables usage from the failsafe install-tool container.

Note: Event listeners that are registered using symfony tags
will still be added to the ServiceProvider instantiated ListenerProvider
in non-failsafe mode. The symfony generated factory will look like:

  $this->services['TYPO3\\CMS\\Core\\EventDispatcher\\ListenerProvider'] =
     $instance =
     \TYPO3\CMS\Core\ServiceProvider::getListenerProvider($this);
  $instance
    ->addListener(
      'TYPO3\\CMS\\Core\\Mail\\Event\\AfterMailerInitializationEvent',
      'TYPO3\\CMS\\Core\\Compatibility\\Slot\\PostInitializeMailer',
      NULL
    );

Resolves: #88806
Releases: master
Change-Id: I4775cc04af3d62ae08c43d762f51af31858cac2d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61329
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[TASK] Remove dependency to TSFE from AdminPanel initialisation 23/61323/8
Susanne Moog [Fri, 19 Jul 2019 10:14:22 +0000 (12:14 +0200)]
[TASK] Remove dependency to TSFE from AdminPanel initialisation

The dependency of AdminPanel initialisation and TSFE has been dissolved.
Furthermore, the AdminPanel initialisation has been better integrated
into the PSR-15 middleware process by providing modules with an option
to manipulate the request object during initialisation.

Resolves: #88807
Releases: master
Change-Id: I9db2d3056d8216e15ff3303a7667ff7a4d8016e3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61323
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
2 months ago[TASK] Show command of console commands in backend 16/61316/7
Georg Ringer [Thu, 18 Jul 2019 03:46:28 +0000 (05:46 +0200)]
[TASK] Show command of console commands in backend

Show the console command and arguments in the backend of symfony commands.

Resolves: #88788
Releases: master, 9.5
Change-Id: Ief0abb4404c14dbfa85eb4acddcb74e796ba0272
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61316
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Sybille Peters <sypets@gmx.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[TASK] Complete list of classes with strict mode 13/61313/3
Alexander Schnitzler [Wed, 17 Jul 2019 17:19:10 +0000 (19:19 +0200)]
[TASK] Complete list of classes with strict mode

This patch adds classes to the ReST file that lists
classes that switched to strict mode during the
development of TYPO3 10.0.

Releases: master
Resolves: #87941
Change-Id: Ieb8a83ef04035c94fd84d3825676cd50a68eb8a0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61313
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
2 months ago[BUGFIX] Properly check install tool password in report 18/61318/4
Mathias Brodala [Thu, 18 Jul 2019 09:05:43 +0000 (11:05 +0200)]
[BUGFIX] Properly check install tool password in report

Also output a report message in case of unsupported hash algorithm.

Resolves: #88794
Releases: master, 9.5
Change-Id: I1ba4efd321f4d2d5bc35b65bb7caac0581fe0a39
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61318
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
2 months ago[BUGFIX] Make files deletable if storage is not browsable 53/61153/3
Markus Klein [Wed, 26 Jun 2019 12:02:23 +0000 (14:02 +0200)]
[BUGFIX] Make files deletable if storage is not browsable

A check is added to abort the search for a recycler folder
if a storage is not browsable.
An editor wouldn't be able to recover the file anyways as
this requires browsing the storage.

Resolves: #88632
Releases: master, 9.5, 8.7
Change-Id: Ie59b53c8b17434bb162de7c52a756d7ea3ceb88d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61153
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Julian Geils <j_geils@web.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
2 months ago[!!!][TASK] Remove POST option from typolink.addQueryString.method 95/61295/12
Oliver Hader [Mon, 15 Jul 2019 09:13:17 +0000 (11:13 +0200)]
[!!!][TASK] Remove POST option from typolink.addQueryString.method

Setting `addQueryString.method` of typolink could be used like shown
below in order to transform HTTP POST parameters into according GET
parameters.

    typolink {
        parameter = 123
        addQueryString = 1
        addQueryString.method = POST
    }

In terms of correctly using HTTP verbs it's bad practise in general
to treat GET and POST equally, besides that documentation already
mentioned potential side-effects like accidentally exposing sensitive
data submitted via POST to proxies or log files.

That's why values POST, GET,POST and POST,GET are not allowed anymore
for `typolink.addQueryString.method`. Maintaining functionality - if
required at all - has to be done using domain specific logic in
according controllers or middleware implementations.

Resolves: #88755
Releases: master
Change-Id: I6ecfdd2ee98251b64093c1a13f9371beea862ddd
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61295
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[TASK] Instantiate Context through dependency injection 74/61274/9
Benjamin Franzke [Thu, 11 Jul 2019 22:43:52 +0000 (00:43 +0200)]
[TASK] Instantiate Context through dependency injection

Context is stateful as Aspects dependent on the (currently dispatched)
request type (frontend/backend/installtool/CLI).
Reqest-dependent arguments can not be injected during service
creation; therefore the Context class is now created without default
aspects and enhanced by the application classes (on demand).

Note: The UserAspect constructor is adapted to use an explicit stdClass
allocation instead of an immutable array casted to an object for the
(fallback) pseudo user. This is to avoid php segmentation faults in
functional tests (and also random unit test runs). The segmentation
faults would be triggered due to the constructor change in the Context
class, which now uses ondemand instead of preemptive Aspect creation.
Background: immutable arrays are stored on stack. The cast to an object
probably didn't relocate this memory to the heap which then causes
segmentations faults when the static memory area (on stack) is exceeded.

Releases: master
Resolves: #88793
Change-Id: Ib165f85b66b34e8025e28ef483260463f1e2c826
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61274
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
3 months ago[BUGFIX] Fix warning in AbstractConfigurationManagerTest 30/61330/2
Benjamin Franzke [Fri, 19 Jul 2019 18:45:40 +0000 (20:45 +0200)]
[BUGFIX] Fix warning in AbstractConfigurationManagerTest

https://review.typo3.org/c/Packages/TYPO3.CMS/+/60834
changed the method getSwitchableControllerActions
to be called getControllerConfiguration. It was forgotten
to update one mock in AbstractConfigurationManagerTest
which caused the test to be skipped with a warning.

Resolves: #88808
Related: #88496
Releases: master
Change-Id: I7624a274db13e16fc2002468b1eee0459713de93
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61330
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
3 months ago[!!!][FEATURE] Introduce PSR-3 Logging 56/61156/16
Markus Klein [Wed, 5 Jun 2019 23:21:19 +0000 (01:21 +0200)]
[!!!][FEATURE] Introduce PSR-3 Logging

TYPO3's Logging Framework (especially LogLevel and LogManager)
are not PSR-3 compatible, as it uses integers as constants
and not strings, as defined in PSR-3's interfaces.

This makes TYPO3 incompatible to use custom loggers,
or to interop with other logging systems.

The patch changes the logging API to depend on PSR-3
interfaces but strives for maximum compatibility.

Resolves: #88799
Releases: master
Change-Id: Ib41840cc87035c2323087877bac07e62c439482e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61156
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
3 months ago[FEATURE] Add TypoScriptAspect to handle TypoScript Context settings 12/61312/7
Susanne Moog [Wed, 17 Jul 2019 16:52:38 +0000 (18:52 +0200)]
[FEATURE] Add TypoScriptAspect to handle TypoScript Context settings

A TypoScriptAspect has been introduced to handle Context depending
TypoScript settings. As a first step, the property `forceTemplateParsing`
has been moved to this aspect and deprecated in both TSFE and
TemplateService.

Additionally, this is another step to resolve the interdependance between
AdminPanel and TSFE.

Resolves: #88792
Releases: master
Change-Id: I77e7548a51534e96ad0656810163267e6c373d3c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61312
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
3 months ago[BUGFIX] Show labels for export buttons 26/61326/2
Frank Naegler [Fri, 19 Jul 2019 11:49:52 +0000 (13:49 +0200)]
[BUGFIX] Show labels for export buttons

This patch enables the labels for the export buttons which are
hard to distinguish in case both appear side by side.

Resolves: #88804
Releases: master, 9.5
Change-Id: Ie9a72823fcc1788ca10ae93f267c408a8da90212
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61326
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Daniel Windloff
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Daniel Windloff
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
3 months ago[BUGFIX] Add missing type casts in ExportController 25/61325/3
Frank Naegler [Fri, 19 Jul 2019 11:35:55 +0000 (13:35 +0200)]
[BUGFIX] Add missing type casts in ExportController

This patch adds a type cast to fix broken export of tables.

Resolves: #88803
Releated: #88662
Releases: master
Change-Id: I9fe725ddadf2a9d63d3c8af8005a453a68dc46cc
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61325
Tested-by: Daniel Windloff
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Daniel Windloff
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
3 months ago[TASK] Adjust php-cs-fixer rules 24/61324/2
Andreas Fernandez [Fri, 19 Jul 2019 11:17:51 +0000 (13:17 +0200)]
[TASK] Adjust php-cs-fixer rules

The php-cs-fixer rules have been adjusted by the following settings:

- no_empty_phpdoc: Remove empty phpdoc blocks without any information
- no_null_property_initialization: Remove initial null value from
  class properties
- modernize_types_casting: Replace old-school `*val()` function calls
  with proper type casts

Resolves: #88802
Releases: master
Change-Id: Id2cfa849553d918e0461bafd09b3960bdf5ff700
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61324
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Daniel Windloff
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
3 months ago[!!!][TASK] DatabaseRecordList: Remove unused code 06/61306/10
Daniel Windloff [Tue, 16 Jul 2019 08:57:25 +0000 (10:57 +0200)]
[!!!][TASK] DatabaseRecordList: Remove unused code

Some properties and methods are not used any more. They can be removed.

Resolves: #88779
Releases: master
Change-Id: I2f3d41803360eee692e9e6ce4b8b1a0cd76f559d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61306
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
3 months ago[FEATURE] Introduce PreviewAspect for handling the preview flag 11/61311/6
Susanne Moog [Wed, 17 Jul 2019 15:37:44 +0000 (17:37 +0200)]
[FEATURE] Introduce PreviewAspect for handling the preview flag

The public internal property of TSFE "fePreview" has been deprecated
in favor of a dedicated aspect handling the frontend preview flag.

As a first step, the frontend preview aspect only contains a boolean
flag holding the current preview state - but it might be extended with
additional information on the preview mode at a later point.

This is also a first step to remove the TSFE dependencies from the
AdminPanel initialisation process.

Resolves: #88791
Releases: master
Change-Id: I2994d69d824b1b107a3a878b87c9dd2f7daf3ed2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61311
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
3 months ago[TASK] Clean up TSFE constructor initialization 89/61289/4
Benni Mack [Sat, 13 Jul 2019 17:03:41 +0000 (19:03 +0200)]
[TASK] Clean up TSFE constructor initialization

Due to e50b1c1acdd5da514a35f837d9b853692bcfa16d
the TypoScriptFrontendController requires four objects
as constructor arguments while keeping maximum
compatibility by fetching fallback information from the
current PSR-7 object or setting data from the legacy arguments.

The constructor is cleaned up with special initialize methods
for readability.

Resolves: #88747
Related: #88717
Releases: master
Change-Id: I734d1184780b8bfdf0e9638aca75c6a4fc0f7e2c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61289
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
3 months ago[!!!][FEATURE] Add IP locking for IPv6 47/52947/29
Alexander Stehlik [Mon, 30 Oct 2017 16:57:16 +0000 (17:57 +0100)]
[!!!][FEATURE] Add IP locking for IPv6

A new IpLocker class replaces the lock functionality in
AbstractUserAuthentication.

The new class is capable of locking to IPv4 and IPv6 addresses.

Resolves: #21638
Releases: master
Change-Id: I0075a9e49690e31c938abf7242c1f088c73bb37d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/52947
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[TASK] Take care of rendering warnings in core Changelog rendering 91/61291/5
Anja Leichsenring [Sat, 13 Jul 2019 20:27:43 +0000 (22:27 +0200)]
[TASK] Take care of rendering warnings in core Changelog rendering

Also, some improvements are made to sentence structure, tenses
and syntax highlightning.

Resolves: #88748
Releases: master, 9.5
Change-Id: I932dabbfc404de7c3dc4f3cef1ccb50c2fd94f72
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61291
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Koen Wouters <koen.wouters@maxserv.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Koen Wouters <koen.wouters@maxserv.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 months ago[TASK] Move Slug Candidate functionality into its own class 50/61050/8
Benni Mack [Mon, 17 Jun 2019 11:08:54 +0000 (13:08 +0200)]
[TASK] Move Slug Candidate functionality into its own class

When Page-based slug handling + routing was introduced,
the initial PageRouter class turned big very quickly.

Especially managing the possible pages that could match
was initially based on the candidates principle that could
be moved / exchanged later-on.

For this to happen the initial step is to move this to a separate
PHP class called "PageSlugCandidateProvider".

As seen in the patch, all calls to the database related
to retrieving pages (DB + PageRepository) are
moved into PageSlugCandidateProvider.

Resolves: #88575
Releases: master
Change-Id: I14b3ebccf439613cc9aa7943d1a44d0892cf04e5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61050
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
3 months ago[BUGFIX] Use proper syntax for RST code-block 09/61309/2
Oliver Hader [Wed, 17 Jul 2019 14:53:35 +0000 (16:53 +0200)]
[BUGFIX] Use proper syntax for RST code-block

codeblock -> code-block

Resolves: #88790
Releases: master, 9.5
Change-Id: I51f30b30ef7344e1b66bd5ed354d3bfe60074a57
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61309
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[!!!][TASK] Replace switchable controller actions terminology 34/60834/8
Alexander Schnitzler [Mon, 15 Jul 2019 13:32:56 +0000 (15:32 +0200)]
[!!!][TASK] Replace switchable controller actions terminology

During the creation of Extbase itself, the configuration of
controllers and their available/callable actions has been called
switchable controller actions. This terminology has later also been
used to configure an alternative controller configuration defined
via typoscript or flexforms. As of today the term "switchable controller
actions" is only used for the latter. The core, however, still uses
this terminology for both the default controller configuration and
the overrides.

To clarify the terminology, the default configuration has been
renamed to just "controller configuration".

Releases: master
Resolves: #88496
Change-Id: I718e2fe03d3560a57b17fc584479aff559d105e8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60834
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[!!!][TASK] Harden \TYPO3\CMS\Extbase\Mvc\Web\Routing\UriBuilder 25/59625/12
Alexander Schnitzler [Mon, 15 Jul 2019 07:38:24 +0000 (09:38 +0200)]
[!!!][TASK] Harden \TYPO3\CMS\Extbase\Mvc\Web\Routing\UriBuilder

- Use strict type mode
- Use type hints whereever possible

Releases: master
Resolves: #87629
Change-Id: I40d79cb6178886a6fc46edaf6c75fa900bf4ffc9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59625
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Susanne Moog <look@susi.dev>
3 months ago[BUGFIX] File can be deleted even if there are references to it 46/60846/3
Dmitry Dulepov [Thu, 30 May 2019 10:49:35 +0000 (13:49 +0300)]
[BUGFIX] File can be deleted even if there are references to it

TYPO3 prevents files from being deleted by the user when there
are references to it in the sys_file_reference table. However
if the file is referenced without using this table, the file is
still deleted without any warnings. An example is a link to the
file in a bodytext of a text content element. Thus it is possible
to accidentally delete a file, which is referenced on the site
in multiple places and create broken links.

This change makes sure that such direct references (without using
sys_file_reference) also prevent the file from being deleted.

Resolves: #88462
Resolves: #77866
Releases: master, 9.5, 8.7
Change-Id: Ib8c45863d75ae430c801173658cf058f850ca982
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60846
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Julian Geils <j_geils@web.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
3 months ago[TASK] Move PageRepository to EXT:core 66/61166/7
Benni Mack [Sat, 13 Jul 2019 14:12:47 +0000 (16:12 +0200)]
[TASK] Move PageRepository to EXT:core

Since Context API was introduced in TYPO3 v9, PageRepository is highly
decoupled from $TSFE->sys_page, and fully works standalone.

It is also used in various places where TSFE is not needed,
or required, but also in places of EXT:core.

Especially parts like RootlineUtility, which depends on PageRepository
very much, cannot live without it.

I propose to move this highly important PHP class into EXT:core,
in order to allow to decouple EXT:frontend even further from
EXT:core.

The FQCN is moved from
- \TYPO3\CMS\Frontend\Page\PageRepository
to
- TYPO3\CMS\Core\Domain\Repository\PageRepository

It can be assumed to use PageRepository for any use-case
and actually reduce usages towards BackendUtility::get...
by using this API more and more.

Further adaptions could be to reduce the logic
within PageRepository and move this into QueryBuilder
and assimilate especially the "versionOL" behavior.

Resolves: #88746
Releases: master
Change-Id: Id8225100ac60bd77fc7e1303efb4c46b741d3415
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61166
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
3 months ago[TASK] Increase length of header_position field 83/61283/2
Guido Schmechel [Fri, 12 Jul 2019 19:08:51 +0000 (21:08 +0200)]
[TASK] Increase length of header_position field

To prevent the truncation of new values via TCEForm,
the field length is increased to 255.

Resolves: #88722
Releases: master, 9.5
Change-Id: I982c20302be216c1819da9efc468f8a7b2be0add
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61283
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
3 months ago[!!!][FEATURE] Omit type=text/javascript in HTML5 script tags 00/61300/5
Benni Mack [Mon, 15 Jul 2019 14:56:39 +0000 (16:56 +0200)]
[!!!][FEATURE] Omit type=text/javascript in HTML5 script tags

HTML5 defines that <script tags do not need "type=text/javascript"
as additional attribute.

TYPO3 Backend is fully HTML5, so all parts can be removed there.

For Frontend, when having config.doctype = html5 (or empty),
then the attributes do not get added anymore as well.

If necessary, for Frontend rendering the attribute can be
added in HTML5 by specifying
includeJS.myfile.type = text/javascript
in TypoScript.

As this modifies Frontend output, it is considered breaking.

Also see W3C specification:
https://www.w3.org/TR/html52/semantics-scripting.html#element-attrdef-script-type

Resolves: #88772
Releases: master
Change-Id: I26ca4361e84cae680eedbf6855e209a6311c33da
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61300
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[FEATURE] Introduce PSR-14-based EventDispatcher as alternative for hooks 03/61303/16
Benni Mack [Mon, 15 Jul 2019 18:31:38 +0000 (20:31 +0200)]
[FEATURE] Introduce PSR-14-based EventDispatcher as alternative for hooks

The new PSR-14 standard for dispatching Events (that is: to extend
a Framework without having to modify a frameworks' code) adds
a EventDispatcher object that can dispatch Event objects to
EventListeners.

In PSR-14 every dispatched event is an object. It uses PHP class names as
identifiers for events. Class hierarchies may be used to group events.

A ListenerProvider object collects available listeners from an extension
and allows to listen and/or modify data provided by the Event object.

The current implementation relies on a custom TYPO3-specific
ListenerProvider that is configured using Symfony's Dependency Injection
tags.

As an example the Mailer-postProcInitialization signal/slot is
replaced by an Event.

This first patch introduces the feature, and does not deprecate
anything yet. The most important part is that new Events
can use this API instead of Hooks in TYPO3 v10.

Short-Term goal is to deprecate SignalSlot dispatcher in TYPO3 v10,
and migrate all signals to the EventDispatcher.

Resolves: #88770
Releases: master
Change-Id: I3649ddb9b9340640199279e6af3c040bffc397fe
Signed-off-by: Benni Mack <benni@typo3.org>
Signed-off-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61303
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
3 months ago[TASK] DatabaseRecordList: Remove collapse a single table via _GP 94/61294/3
Daniel Windloff [Sun, 14 Jul 2019 08:41:36 +0000 (10:41 +0200)]
[TASK] DatabaseRecordList: Remove collapse a single table via _GP

Collapse single tables in multi table view of the DatabaseRecordList
is invoked via javascript and its state is saved via AJAX.
Remove the leftover code, which allows to set the collapse state
via _GP('collapse').

Resolves: #88753
Releases: master
Change-Id: Ibd02364c54563b76caf6e4f36ae9c8853b1d99c6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61294
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>