Packages/TYPO3.CMS.git
7 years ago[BUGFIX] Reduce CGL violations in class.tx_install.php
Roland Waldner [Thu, 17 May 2012 13:40:20 +0000 (15:40 +0200)]
[BUGFIX] Reduce CGL violations in class.tx_install.php

Fix/Reduce CGL violations "FunctionCallArgumentSpacingNoSpaceAfterComma"
in typo3/sysext/install/mod/class.tx_install.php.

There are over 500 violations against this rule. This is fixed/reduced.

Change-Id: Iad13d9b4f2bad80cb7921ae44f46c3723f82cc20
Resolves: #37254
Releases: 6.0
Reviewed-on: http://review.typo3.org/11274
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Reduce CGL violations in class.tslib_fe.php
Roland Waldner [Thu, 17 May 2012 12:29:52 +0000 (14:29 +0200)]
[BUGFIX] Reduce CGL violations in class.tslib_fe.php

Fix/Reduce CGL violations "FunctionCallArgumentSpacingNoSpaceAfterComma"
in class.tslib_fe.php.

There are over 500 violations against this rule. This is fixed/reduced.

Change-Id: Ib4a8d95b99e06e1342a4f5c5a53df5582a9b7d86
Resolves: #37253
Releases: 6.0
Reviewed-on: http://review.typo3.org/11272
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Clean up phpDoc comments in t3lib classes
Wouter Wolters [Thu, 17 May 2012 11:13:35 +0000 (13:13 +0200)]
[TASK] Clean up phpDoc comments in t3lib classes

Clean up phpDoc comments for the following classes:

* t3lib/class.t3lib_parsehtml_proc.php
* t3lib/class.t3lib_positionmap.php
* t3lib/class.t3lib_querygenerator.php
* t3lib/class.t3lib_readmail.php
* t3lib/class.t3lib_recordlist.php
* t3lib/class.t3lib_registry.php
* t3lib/class.t3lib_rteapi.php

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I42a5b48a8eda5d77605a963ba8168d1d4342fa5f
Resolves: #37252
Releases: 6.0
Reviewed-on: http://review.typo3.org/11271
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[FEATURE] Remove invalid/unused FAL TCA config
Ingmar Schlecht [Thu, 17 May 2012 10:46:03 +0000 (12:46 +0200)]
[FEATURE] Remove invalid/unused FAL TCA config

Change-Id: I255e5067c3d2608870e4b35d35faf305af0f6b22
Releases: 6.0
Resolves: #37250
Reviewed-on: http://review.typo3.org/11269
Reviewed-by: Ingmar Schlecht
Tested-by: Ingmar Schlecht
7 years ago[TASK] Clean up phpDoc comments in t3lib classes
Wouter Wolters [Thu, 17 May 2012 00:12:48 +0000 (02:12 +0200)]
[TASK] Clean up phpDoc comments in t3lib classes

Clean up phpDoc comments for the following classes:

* t3lib/class.t3lib_pagerenderer.php
* t3lib/class.t3lib_pagetree.php
* t3lib/class.t3lib_parsehtml.php

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I56ffee774456d7712cf68cbd74652aad1b0f07bb
Resolves: #37242
Releases: 6.0
Reviewed-on: http://review.typo3.org/11265
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] CGL cleanup in bootstrap
Christian Kuhn [Wed, 16 May 2012 19:30:30 +0000 (21:30 +0200)]
[TASK] CGL cleanup in bootstrap

Fix some cgl flaws that slipped through during the bootstrap refactoring.

Change-Id: Id2d122d0afdb3e0e1091a13eeecf62c1c67236f4
Resolves: #37236
Releases: 6.0
Reviewed-on: http://review.typo3.org/11261
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Clean up phpDoc comments in t3lib_page
Wouter Wolters [Wed, 16 May 2012 18:17:49 +0000 (20:17 +0200)]
[TASK] Clean up phpDoc comments in t3lib_page

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: Ibbb16ff84edf3dfae9ca4152b62211f37afb4cda
Resolves: #37235
Releases: 6.0
Reviewed-on: http://review.typo3.org/11256
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Bootstrap: Disentangle cli and install from init.php
Christian Kuhn [Wed, 9 May 2012 19:27:53 +0000 (21:27 +0200)]
[TASK] Bootstrap: Disentangle cli and install from init.php

Extract code from init.php and put it to methods in Bootstrap.php.
Additionally, cli_dispatch and install/index.php do not require
init.php anymore and have a uncoupled bootstrap now.

There is still room for improvement,
this patch is just another intermediate step.

Change-Id: I5c6d84b8acb7760c8a77f192b2b5ba063b417b0d
Resolves: #37130
Releases: 6.0
Reviewed-on: http://review.typo3.org/11153
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[FEATURE] BE preview for non standard SSL port
Bas van de Wiel [Tue, 15 May 2012 17:56:50 +0000 (19:56 +0200)]
[FEATURE] BE preview for non standard SSL port

Make sure port number gets appended when backend
is locked to SSL and port number is set to something
other than the standard 443.

Change-Id: I5fcb04fa0e0b8cbde3f19e9c54366e11d14fdf8e
Fixes: #37076
Releases: 6.0
Reviewed-on: http://review.typo3.org/11225
Reviewed-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Remove old compatibility constructor
Christian Kuhn [Wed, 16 May 2012 09:03:06 +0000 (11:03 +0200)]
[TASK] Remove old compatibility constructor

typo3/class.show_rechis.inc was forgotten
during the cleanup round for 6.0

Change-Id: I1805b0845fa4e9f44ec2ec37cbceb02bcdcd015d
Resolves: #37207
Releases: 6.0
Reviewed-on: http://review.typo3.org/11231
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Remove deprecated class.alt_menu_functions.inc
Christian Kuhn [Wed, 16 May 2012 08:57:43 +0000 (10:57 +0200)]
[TASK] Remove deprecated class.alt_menu_functions.inc

Change-Id: I941fc2dfd028235ee0988d7e96cb374333987ae8
Resolves: #37206
Releases: 6.0
Reviewed-on: http://review.typo3.org/11230
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Fix whitespace in t3lib_befunc
Christian Kuhn [Wed, 16 May 2012 08:41:37 +0000 (10:41 +0200)]
[TASK] Fix whitespace in t3lib_befunc

This made jenkins unhappy with
https://review.typo3.org/#/c/11225/3

Change-Id: I02ae564546eea8982300e2c42b9abe72c463bb51
Resolves: #37205
Releases: 6.0
Reviewed-on: http://review.typo3.org/11229
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Clean up phpDoc comments in t3lib classes
Wouter Wolters [Sun, 13 May 2012 12:10:44 +0000 (14:10 +0200)]
[TASK] Clean up phpDoc comments in t3lib classes

Clean up phpDoc comments for the following classes:

* t3lib/class.t3lib_formmail.php
* t3lib/class.t3lib_frontendedit.php
* t3lib/class.t3lib_iconworks.php
* t3lib/class.t3lib_install.php

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I48a245d96f760c8957bebc8970cbe76446287084
Resolves: #37137
Releases: 6.0
Reviewed-on: http://review.typo3.org/11154
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Clean up phpDoc comments in t3lib classes
Wouter Wolters [Tue, 15 May 2012 21:52:49 +0000 (23:52 +0200)]
[TASK] Clean up phpDoc comments in t3lib classes

Clean up phpDoc comments for the following classes:

* t3lib/class.t3lib_install_sql.php
* t3lib/class.t3lib_loaddbgroup.php
* t3lib/class.t3lib_loadmodules.php
* t3lib/class.t3lib_lock.php
* t3lib/class.t3lib_modsettings.php

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I0465b7d41e492ae4746f0649b676eae4ad2a145a
Resolves: #37202
Releases: 6.0
Reviewed-on: http://review.typo3.org/11228
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Missing bottom margin in the page tree
Stefan Galinski [Fri, 13 Apr 2012 14:01:04 +0000 (16:01 +0200)]
[BUGFIX] Missing bottom margin in the page tree

This fixes the UI issue with the deletion overlay and drag&drop
with nodes at the very bottom of the page tree viewport too.

Change-Id: I5cee23ea9441fcd1910a998547772bc3f2e53fb5
Fixes: #35182
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/10411
Reviewed-by: Philipp Gampe
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
7 years ago[Task] CGL Cleanup LogicalOperatorSpacing*
Stefano Kowalke [Tue, 15 May 2012 10:16:51 +0000 (12:16 +0200)]
[Task] CGL Cleanup LogicalOperatorSpacing*

This is a follow-up to 37142.
It removes the last violation for this topic.

Change-Id: Ia788655833a5ab3778ce0ca16d3105f4a479fd6a
Fixes: #37178
Releases: 6.0
Reviewed-on: http://review.typo3.org/11204
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Re-enable indexed_search $TCA for index_config
Felix Kopp [Fri, 11 May 2012 13:31:48 +0000 (15:31 +0200)]
[BUGFIX] Re-enable indexed_search $TCA for index_config

EXT: indexed_search $TCA for table index_config is only loaded
when EXT: crawler is installed but $TCA must always be included.
Removes condition to limit $TCA inclusion.

Change-Id: I9768ae18c40fa95084fbca54880ffc7b31e1f0a1
Fixes: #32815
Releases: 4.7, 6.0
Reviewed-on: http://review.typo3.org/11145
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[BUGFIX] Wrong label reference for backend_layout
Markus Klein [Mon, 14 May 2012 12:37:08 +0000 (14:37 +0200)]
[BUGFIX] Wrong label reference for backend_layout

tbl_pages.php references non-existing labels.
Actually they have different names.

Change-Id: I9b89fd5dcc7355480e534c2b48130a8461f03ef4
Releases: 6.0, 4.7, 4.6, 4.5
Fixes: #37158
Reviewed-on: http://review.typo3.org/11178
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[BUGFIX] Pagetree doesn't expands to the last saved state
Stefan Galinski [Thu, 10 May 2012 17:51:11 +0000 (19:51 +0200)]
[BUGFIX] Pagetree doesn't expands to the last saved state

Change-Id: I0518d9dd06c7d126dfe5d885e4b2751b7e7462b6
Releases: 6.0, 4.7, 4.6, 4.5
Fixes: #36459
Reviewed-on: http://review.typo3.org/11138
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[BUGFIX] Fix 2 CGL violations in alt_shortcut.php.
Roland Waldner [Sun, 13 May 2012 17:15:32 +0000 (19:15 +0200)]
[BUGFIX] Fix 2 CGL violations in alt_shortcut.php.

on metrics.typo3.org the violations drilldown says
that is 1 violation against
"FunctionCallArgumentSpacingNoSpaceAfterEquals"
and 1 violation against
"FunctionCallArgumentSpacingNoSpaceBeforeEquals":
both in typo3/alt_shortcut.php.

this should be fixed.

after that i guess these 2 coding guidline sniffs
could be activated in the CI-server jobs?

Change-Id: I4ff9d4f57f97e2f502088d8d6026544615331cd6
Fixes: #37139
Releases: 6.0
Reviewed-on: http://review.typo3.org/11157
Reviewed-by: Roland Waldner
Tested-by: Roland Waldner
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[BUGFIX] CGL:ArrayBracketSpacingSpaceBeforeBracket
Roland Waldner [Sun, 13 May 2012 17:39:41 +0000 (19:39 +0200)]
[BUGFIX] CGL:ArrayBracketSpacingSpaceBeforeBracket

on metrics.typo3.org the violations drilldown
says that are 2 violations against
"ArrayBracketSpacingSpaceBeforeBracket" in
tests/Unit/t3lib/utility/
class.t3lib_utility_mailTest.php.

this should be fixed.

after that i guess this coding guidline sniff
could be activated in the CI-server jobs?

Change-Id: I6fb7c6b67611ebac903466b28c7c473b3d36ee51
Fixes: #37141
Releases: 6.0
Reviewed-on: http://review.typo3.org/11159
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[BUGFIX] Fix 4 CGL viol.: LogicalOperatorSpacing*
Roland Waldner [Sun, 13 May 2012 19:19:21 +0000 (21:19 +0200)]
[BUGFIX] Fix 4 CGL viol.: LogicalOperatorSpacing*

on metrics.typo3.org the violations drilldown
says that are some violations against:

LogicalOperatorSpacingNoSpaceBefore (19)
LogicalOperatorSpacingNoSpaceAfter (18)
LogicalOperatorSpacingTooMuchSpaceAfter (17)
LogicalOperatorSpacingTooMuchSpaceBefore (6)

this should be fixed.

after that i guess these coding guidline sniffs
could be activated in the CI-server jobs?

Change-Id: Iffe732fdb94992f814dfaa8e34ccb04d71d8bd7d
Fixes: #37142
Releases: 6.0
Reviewed-on: http://review.typo3.org/11160
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[TASK] Add unittests for t3lib_div::*List functions
Tolleiv Nietsch [Tue, 8 May 2012 23:35:24 +0000 (01:35 +0200)]
[TASK] Add unittests for t3lib_div::*List functions

Some of the most basic functions should be covered with unit tests.

The change creates tests for inList, expandList, rmFromList
and uniqueList.

Change-Id: I0fd1e47d7aec96e950b69b4c44898e55920ff4fd
Resolves: #36968
Releases: 6.0
Reviewed-on: http://review.typo3.org/11089
Reviewed-by: Oliver Klee
Tested-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[FEATURE] Allow camelCased class names in ext_autoload
Christian Kuhn [Fri, 11 May 2012 17:52:04 +0000 (19:52 +0200)]
[FEATURE] Allow camelCased class names in ext_autoload

Remove the hurdle that class names in ext_autoload (the key part of
the returned array) have to be lower cased.

The patch adds two tests, the first one expects that a case sensitive
class name in ext_autoload.php in actually lowercases before it is
written to the autoload cache file. It fails if the autoloader patch
is not applied.
The second tests that camel cased classes can be successfully autoloaded.

Change-Id: I2ccf916d43a288a520f6f89e9002bdc4df2da0b2
Resolves: #37110
Releases: 6.0
Reviewed-on: http://review.typo3.org/11148
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Philipp Gampe
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
7 years ago[FEATURE] Add Progress bar for task progress
Ingo Renner [Wed, 2 May 2012 21:03:45 +0000 (23:03 +0200)]
[FEATURE] Add Progress bar for task progress

Some tasks may want to provide the user with information about how
far progress of their jobs has come.

Currently there is no way to do this in a nice way. The existing
method getAdditionalInformation() does not allow to output HTML.

Fixes: #36802
Releases: 6.0
Change-Id: I86877b3a3ec70e8c6ef5deae7e54442c35afada3
Reviewed-on: http://review.typo3.org/10946
Reviewed-by: Philipp Gampe
Reviewed-by: Nikolas Hagelstein
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[BUGFIX] Page module content element min-width (CSS)
Felix Kopp [Fri, 13 Apr 2012 10:39:36 +0000 (12:39 +0200)]
[BUGFIX] Page module content element min-width (CSS)

Adds min-width to content elements in page backend module
to fix problem with line breaking icons.

Change-Id: Id66622c91433782e0813b6fb20097fa7a0c48793
Fixes: #35962
Releases: 6.0
Reviewed-on: http://review.typo3.org/10390
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Stefan Galinski
Tested-by: Stefan Galinski
7 years ago[Task] Replace space indent into tab indent
Thorsten Kahler [Thu, 10 May 2012 13:45:49 +0000 (15:45 +0200)]
[Task] Replace space indent into tab indent

CGL cleanup: this patch replaces a space indentation in two SQL
statements with tabs.

Change-Id: I88d4461a635fcadb3725a9c5178b439298356374
Resolves: #36871
Related: #37020
Releases: 6.0
Reviewed-on: http://review.typo3.org/11128
Reviewed-by: Thorsten Kahler
Tested-by: Thorsten Kahler
7 years ago[Task] Change whitespaces in indentions into tabs
Stefano Kowalke [Wed, 9 May 2012 20:44:46 +0000 (22:44 +0200)]
[Task] Change whitespaces in indentions into tabs

This is a follow up to #36871.
Some whitespace indentions came back into core.
This patch removes them.

Change-Id: Iabc8eb2fed79ae6de8e8e9e12fcdb7a5bcb65a40
Related: #36871
Resolves: #37020
Releases: 6.0
Reviewed-on: http://review.typo3.org/11120
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Page cache expiry calculation fails
Francois Suter [Wed, 4 Apr 2012 13:21:52 +0000 (15:21 +0200)]
[BUGFIX] Page cache expiry calculation fails

The calculation of the page cache expirationy timestamp based on
property config.cache.xx = table:yy fails in some specific
scenarios, name when there are records having either a start time
in the future but no end time, or an end time in the future
and no start time. Contrary to what is being done so far, calculation
must be performed separately for each time field to avoid
interferences.

Change-Id: I4e4e259083a10f7125760d14ede11ff6a68022fe
Fixes: #35684
Releases: 6.0, 4.7, 4.6
Reviewed-on: http://review.typo3.org/10156
Reviewed-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Xavier Perseguers
Reviewed-by: Francois Suter
Tested-by: Francois Suter
7 years ago[BUGFIX] Regression: SQL error inserting tables for statictemplates
Philipp Gampe [Fri, 9 Mar 2012 14:13:00 +0000 (15:13 +0100)]
[BUGFIX] Regression: SQL error inserting tables for statictemplates

Removing one column was forgotten which results in an SQL error while
inserting the static data.

Change-Id: Ia54b7fc3121f6a50620d64223d610d633b3c76f0
Fixes: #34692
Releases: 4.7,4.8
Reviewed-on: http://review.typo3.org/9516
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Tested-by: Oliver Hader
Reviewed-by: Sebastian Fischer
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years ago[TASK] Refactor t3lib_mail_Mailer and add unit tests
Helmut Hummel [Tue, 8 May 2012 07:40:38 +0000 (09:40 +0200)]
[TASK] Refactor t3lib_mail_Mailer and add unit tests

This change also cleans up some comments and the existing unit test.

Change-Id: Ifb80b7b6f70d06f6531656c579e673a0b0e5ad0b
Resolves: #36942
Releases: 6.0
Reviewed-on: http://review.typo3.org/11068
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[FEATURE] Enable further fields which are used for the suggest wizard
Franz Koch [Wed, 2 May 2012 14:51:53 +0000 (16:51 +0200)]
[FEATURE] Enable further fields which are used for the suggest wizard

Currently the suggest wizard only searches through the label fields
of the records. In some setups other data might be useful to find
records.

The patch adds an configuration option to extend the wizard configuration
to include further fields into the search.

Change-Id: I14e88912a664195467502678eedb3bcdb9e4cf5f
Resolves: #36780
Releases: 6.0
Reviewed-on: http://review.typo3.org/10930
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years ago[TASK] Remove page related icons from docHeader in page/list
Felix Kopp [Fri, 20 Apr 2012 09:58:04 +0000 (11:58 +0200)]
[TASK] Remove page related icons from docHeader in page/list

Removes page action related icons from the docHeader in work area
within page module:

* Create new page
* Move page
* Page history

and within list module:

* Up one level
* Hide/unhide
* Move page

Also removes "New content element" from page, these are added to columns.

Change-Id: I6bf996437e7af6e2149e6962990af2580655eced
Fixes: #34705
Releases: 6.0
Reviewed-on: http://review.typo3.org/10115
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[BUGFIX] CE with "All languages" isn't shown in Page module
Georg Ringer [Fri, 23 Mar 2012 11:12:57 +0000 (12:12 +0100)]
[BUGFIX] CE with "All languages" isn't shown in Page module

The page module should also list the content elements
with language set to "All"

Change-Id: I6d8aaf4829a70b3945508884d9a09cf23d1e4842
Resolves: #24087
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/9840
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Andreas Otto
Tested-by: Andreas Otto
Reviewed-by: Max Roesch
Tested-by: Max Roesch
Tested-by: Klaus Weidenbach
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[BUGFIX] use fileInfo functions instead of mime_content_type
Jigal van Hemert [Tue, 1 May 2012 05:58:57 +0000 (07:58 +0200)]
[BUGFIX] use fileInfo functions instead of mime_content_type

FAL needs mime type info. Use fileInfo functions here and make
fileinfo PHP extension mandatory.

Change-Id: If6fc39d4b42e0264927ecf6918e7deeb7ef9823c
Fixes: #36706
Releases: 6.0
Reviewed-on: http://review.typo3.org/10914
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] Check if user is allowed to paste page to pagetree
Max Roesch [Sat, 14 Apr 2012 17:41:48 +0000 (19:41 +0200)]
[BUGFIX] Check if user is allowed to paste page to pagetree

The user rights have checks for new / edit / delete, but paste was missing
leading to an error. Page actions 'paste into' and 'page after' now checks
if the user has rights for adding new pages to the current page.

Change-Id: Ief80a511d61ba386d667c62263d6f5335d1c87b8
Fixes: #33546
Releases: 4.5, 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/10483
Reviewed-by: Kilian Hann
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Felix Kopp
Tested-by: Felix Kopp
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[BUGFIX] Custom Swift_Transport impossible
Georg Ringer [Mon, 7 May 2012 21:20:38 +0000 (23:20 +0200)]
[BUGFIX] Custom Swift_Transport impossible

Because of using a wrong variable for checking,
it is impossible to use a custom Swift_Transport
implementation.

Change-Id: Id1a337581642414ff8007de06e7d2e7df153cd79
Resolves: #36937
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/11062
Reviewed-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[TASK] Remove unreachable cli code in typo3/init.php
Christian Kuhn [Mon, 7 May 2012 21:06:48 +0000 (23:06 +0200)]
[TASK] Remove unreachable cli code in typo3/init.php

This cli process code at the end of typo3/init.php could never be
reached since valid keys are already checked before and 'status' is
not registered as valid key. This code snipped is dead for a long time
now and did not work for ages. The information was semi useful and
undocumented. It is removed without substitution.

Change-Id: I97db67b18e414ca2b75ae9fcac2a1e892fad2a26
Resolves: #36936
Releases: 6.0
Reviewed-on: http://review.typo3.org/11061
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Remove superfluous LF in install/index.php
Christian Kuhn [Mon, 7 May 2012 20:38:49 +0000 (22:38 +0200)]
[BUGFIX] Remove superfluous LF in install/index.php

The constant refactoring of #36889 introduced a minor issue with
not already defined constants early in install/index.php. The
constant access is not really needed anyway, so it is removed now.

Change-Id: Ic16fbb4106d8773b94bc2c4aa7ecc937e19ab4d2
Related: #36889
Resolves: #36935
Releases: 6.0
Reviewed-on: http://review.typo3.org/11060
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Clean up phpDoc comments in t3lib_foldertree
Wouter Wolters [Mon, 7 May 2012 19:00:15 +0000 (21:00 +0200)]
[TASK] Clean up phpDoc comments in t3lib_foldertree

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I22b49acdb7e45be062719f6f736229ebc16a88ca
Resolves: #36933
Releases: 6.0
Reviewed-on: http://review.typo3.org/11058
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Clean up phpDoc comments in t3lib_flexformtools
Wouter Wolters [Mon, 7 May 2012 18:53:22 +0000 (20:53 +0200)]
[TASK] Clean up phpDoc comments in t3lib_flexformtools

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: If970314ff552ae1b64469ea2ecca2052dc70987e
Resolves: #36932
Releases: 6.0
Reviewed-on: http://review.typo3.org/11057
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Clean up phpDoc comments in t3lib_flashmessagequeue
Wouter Wolters [Mon, 7 May 2012 18:42:12 +0000 (20:42 +0200)]
[TASK] Clean up phpDoc comments in t3lib_flashmessagequeue

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I199f1cf186402c354ca0c2482c006f862409a1de
Resolves: #36931
Releases: 6.0
Reviewed-on: http://review.typo3.org/11056
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Clean up phpDoc comments in t3lib_flashmessage
Wouter Wolters [Mon, 7 May 2012 18:37:50 +0000 (20:37 +0200)]
[TASK] Clean up phpDoc comments in t3lib_flashmessage

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I13b0b178fe06a4a1d331b8365401229a58d07b48
Resolves: #36929
Releases: 6.0
Reviewed-on: http://review.typo3.org/11055
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Clean up phpDoc comments in t3lib_extobjbase
Wouter Wolters [Mon, 7 May 2012 18:34:28 +0000 (20:34 +0200)]
[TASK] Clean up phpDoc comments in t3lib_extobjbase

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: Ie27db5a6601a73459fa07e5a191d6b887a65242e
Resolves: #36928
Releases: 6.0
Reviewed-on: http://review.typo3.org/11054
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Clean up phpDoc comments in t3lib_diff
Wouter Wolters [Sun, 6 May 2012 21:43:12 +0000 (23:43 +0200)]
[TASK] Clean up phpDoc comments in t3lib_diff

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I4399c4c4d2a4eca02e40c46133ee07b6ba3d5348
Resolves: #36902
Releases: 6.0
Reviewed-on: http://review.typo3.org/11042
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Clean up phpDoc comments in t3lib_cs
Wouter Wolters [Sun, 6 May 2012 20:43:36 +0000 (22:43 +0200)]
[TASK] Clean up phpDoc comments in t3lib_cs

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I12ebcbd0014121369c6a93e63dba137774e7c5bb
Resolves: #36897
Releases: 6.0
Reviewed-on: http://review.typo3.org/11040
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Clean up phpDoc comments in t3lib_extmgm
Wouter Wolters [Mon, 7 May 2012 17:04:17 +0000 (19:04 +0200)]
[TASK] Clean up phpDoc comments in t3lib_extmgm

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: Ib685cbbf39d9f025acc222116cf83ed49bf55867
Resolves: #36927
Releases: 6.0
Reviewed-on: http://review.typo3.org/11053
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[!!!][TASK] Bootstrap: Central constants and path handling
Christian Kuhn [Sat, 5 May 2012 14:26:47 +0000 (16:26 +0200)]
[!!!][TASK] Bootstrap: Central constants and path handling

Introduce a class to define main constants and all basic
path evaluations at an early point in bootstrap.

The patch streamlines a lot of the duplicated code for the different
entry points to TYPO3 and moves especially the path handling to a
well documented central location.

Until now, it was documented that is is possible to define own names
for the directories "typo3/", "tslib", "typo3conf/" and "t3lib/".
This never worked without core hacks and was probably never used in
production by anyone for that reason.
This feature is now officially dropped.

Change-Id: Id1ec1082a2572f20500c23357ef5fdbdb05c8498
Resolves: #36889
Releases: 6.0
Reviewed-on: http://review.typo3.org/11030
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Clean up phpDoc comments in t3lib_clipboard
Wouter Wolters [Sun, 6 May 2012 18:53:07 +0000 (20:53 +0200)]
[TASK] Clean up phpDoc comments in t3lib_clipboard

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I599ecfd602da9ebc4a7778eb65701a1b4c6dfba2
Resolves: #36895
Releases: 6.0
Reviewed-on: http://review.typo3.org/11034
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Clean up phpDoc comments in t3lib_befunc
Wouter Wolters [Sun, 6 May 2012 13:24:42 +0000 (15:24 +0200)]
[TASK] Clean up phpDoc comments in t3lib_befunc

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: Iab137d8c601aa543abdd5dcf4aeae55454a77fd4
Resolves: #36886
Releases: 6.0
Reviewed-on: http://review.typo3.org/11028
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Clean up phpDoc comments in t3lib_db
Wouter Wolters [Sun, 6 May 2012 21:29:24 +0000 (23:29 +0200)]
[TASK] Clean up phpDoc comments in t3lib_db

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I8a8b4340a568bde06eaf5bd0de8c654eebdcf8dd
Resolves: #36900
Releases: 6.0
Reviewed-on: http://review.typo3.org/11041
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Clean up phpDoc comments in t3lib_extfilefunc
Wouter Wolters [Mon, 7 May 2012 16:42:15 +0000 (18:42 +0200)]
[TASK] Clean up phpDoc comments in t3lib_extfilefunc

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I9ed6c40c406632546c6376175295449d3f0fc9e2
Resolves: #36926
Releases: 6.0
Reviewed-on: http://review.typo3.org/11052
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[FEATURE] New menu type "Sitemaps of selected pages" in CE "Menu/Sitemap"
Marco Huber [Fri, 13 Apr 2012 09:59:40 +0000 (11:59 +0200)]
[FEATURE] New menu type "Sitemaps of selected pages" in CE "Menu/Sitemap"

In the content element "Menu/Sitemap" it would be nice to be able to select
the root page for the sitemap, because the current menu type "Sitemap"
always uses the tree root. We could enable this with introducing a new
menu type "Sitemaps of selected pages".

Change-Id: Ia71dc2486a173c9c4b0aaf7293639b323dee35dd
Resolves: #35945
Releases: 6.0
Reviewed-on: http://review.typo3.org/10388
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Max Roesch
Tested-by: Max Roesch
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years ago[TASK] Clean up phpDoc comments in t3lib_exec
Wouter Wolters [Sun, 6 May 2012 21:52:26 +0000 (23:52 +0200)]
[TASK] Clean up phpDoc comments in t3lib_exec

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I301aa2ee3d1ddcbe8395c98a6a8edb5ac0221796
Resolves: #36903
Releases: 6.0
Reviewed-on: http://review.typo3.org/11043
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years ago[TASK] Clean up phpDoc comments in t3lib_beuserauth
Wouter Wolters [Sun, 6 May 2012 15:34:55 +0000 (17:34 +0200)]
[TASK] Clean up phpDoc comments in t3lib_beuserauth

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I26a662b3da0e23e63e7e81abcf2844bb8df01fcd
Resolves: #36888
Releases: 6.0
Reviewed-on: http://review.typo3.org/11029
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years ago[BUGFIX] Slider Wizard value not set when used in a flexform
Wouter Wolters [Tue, 27 Mar 2012 17:19:57 +0000 (19:19 +0200)]
[BUGFIX] Slider Wizard value not set when used in a flexform

When the Slider Wizard is used in a flexform the value is given
as XML, which is not handled correctly. When the Slider is used in
a flexform, retrieve the value with t3lib_flexformtools.

Change-Id: Ifeb9f29fe356d062f027f7fba32f912d66743e24
Fixes: #34012
Releases: 4.5,4.6,4.7,6.0
Reviewed-on: http://review.typo3.org/9932
Reviewed-by: Claus Due
Reviewed-by: Arjen Hoekema
Tested-by: Arjen Hoekema
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years ago[!!!][FEATURE] Filename filters: pass additional information
Andreas Wolf [Tue, 24 Apr 2012 12:42:21 +0000 (14:42 +0200)]
[!!!][FEATURE] Filename filters: pass additional information

The file/folder name filter methods now get an additional
parameter, $additionalInformation, that can be filled by
the driver as necessary. It could e.g. contain additional
information fetched from the storage, that might be relevant
for a filter.

This change requires adding this parameter in all filters, so it is
considered a breaking API change. Apart from that, driver authors have
to adjust their driver if they use the dispatch method from
AbstractDriver, as the parameter order changed there.

Change-Id: I24b43cc02c0bf79fb637b51081f65ef3321c5b99
Resolves: #36783
Releases: 6.0
Reviewed-on: http://review.typo3.org/10932
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years ago[TASK] Clean up phpDoc comments in t3lib_cli
Wouter Wolters [Sun, 6 May 2012 18:28:03 +0000 (20:28 +0200)]
[TASK] Clean up phpDoc comments in t3lib_cli

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: Ibbc7a2bfa942c65a48ff9b373b63e7c1c5eb163a
Resolves: #36893
Releases: 6.0
Reviewed-on: http://review.typo3.org/11033
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years ago[TASK] Clean up phpDoc comments in t3lib_browsetree
Wouter Wolters [Sun, 6 May 2012 16:04:44 +0000 (18:04 +0200)]
[TASK] Clean up phpDoc comments in t3lib_browsetree

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I9b21dae460e34700f8a1248d92780fd9c73caa22
Resolves: #36890
Releases: 6.0
Reviewed-on: http://review.typo3.org/11031
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years ago[TASK] Clean up phpDoc comments in t3lib_cache
Wouter Wolters [Sun, 6 May 2012 18:12:02 +0000 (20:12 +0200)]
[TASK] Clean up phpDoc comments in t3lib_cache

* CGLify phpDoc (remove tabs)

Change-Id: Ia3f897c3710ba2628076bb5d62beb0ff52d33406
Resolves: #36892
Releases: 6.0
Reviewed-on: http://review.typo3.org/11032
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years ago[TASK] Replace Space Indent into Tab indent (CGL Cleanup)
Stefano Kowalke [Sat, 5 May 2012 23:00:22 +0000 (01:00 +0200)]
[TASK] Replace Space Indent into Tab indent (CGL Cleanup)

This patch replaces some forgotten and/or
overseen space chars in indention into tab chars.

Change-Id: I1118488ee3e06d5529d741b2811095548ca818a5
Resolves: #36871
Reviewed-on: http://review.typo3.org/11018
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Fix typos in browse_links class
Ingmar Schlecht [Sun, 6 May 2012 05:14:33 +0000 (07:14 +0200)]
[BUGFIX] Fix typos in browse_links class

Change-Id: Ied73a05fcb636153ab205f600b60475d585f7d86
Fixes: #36875
Releases: 6.0
Reviewed-on: http://review.typo3.org/11019
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] FAL broke rendering of image with RECORDS cObj
Susanne Moog [Sat, 5 May 2012 16:02:10 +0000 (18:02 +0200)]
[BUGFIX] FAL broke rendering of image with RECORDS cObj

Due to the backwardsCompatibilityService only
being called in tslib_content_content all other
places related to tslib_content don't work anymore
(especially RECORDS, this is used quite often
both via TypoScript and in TemplaVoila and therefore
has quite some impact).

Patch is to call the backwardsCompatibilityService at
the start of tslib_content to fix the data array for
all content types.

Change-Id: I57d1a86468a7836c7c12ca3e91b233c1671a1b9e
Fixes: #36866
Releases: 6.0
Reviewed-on: http://review.typo3.org/11017
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years ago[FEATURE] Item filters for TCA types "group" and "inline"
Ingmar Schlecht [Thu, 3 May 2012 12:34:50 +0000 (14:34 +0200)]
[FEATURE] Item filters for TCA types "group" and "inline"

Releases: 6.0
Resolves: #36810
Change-Id: Ib8a7c30e19dab9cff72412f7dfe51aa8e94343e4
Reviewed-on: http://review.typo3.org/10953
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years ago[TASK] Remove init code from showpic.php
Christian Kuhn [Sat, 5 May 2012 15:08:46 +0000 (17:08 +0200)]
[TASK] Remove init code from showpic.php

showpic.php is called through eiD for several versions now,
so the initialization code can be removed.

Change-Id: I2f428e8bbf678dde3a20c91adfb536ee61a65aa8
Resolves: #36865
Releases: 6.0
Reviewed-on: http://review.typo3.org/11016
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Move unit tests to tests/Unit folder
Christian Kuhn [Sat, 5 May 2012 14:32:38 +0000 (16:32 +0200)]
[TASK] Move unit tests to tests/Unit folder

FAL introduced first functional tests in a new tests/Functional directory.
Therefore all unit tests are now moved to tests/Unit.

Change-Id: Ied463e171b2dcaecf66cc9f6411de47b95b5bee7
Resolves: #36864
Releases: 6.0
Reviewed-on: http://review.typo3.org/11015
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Clean up and fix unit tests for FAL
Susanne Moog [Fri, 4 May 2012 21:41:43 +0000 (23:41 +0200)]
[TASK] Clean up and fix unit tests for FAL

Clean up and fix the unit tests that got broken with FAL.
Streamline the API (especially the folder part)
according to the tests.

Change-Id: Idfa54ce69d42621293fda2f4fa079fd20425dd75
Resolves: #36858
Releases: 6.0
Reviewed-on: http://review.typo3.org/11011
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[BUGFIX] Fix math test on 32 bit systems
Helmut Hummel [Sat, 5 May 2012 10:03:31 +0000 (12:03 +0200)]
[BUGFIX] Fix math test on 32 bit systems

Change-Id: I02fde86434b0eef5eca1f0a162114669775a558c
Fixes: #36860
Releases: 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/11012
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[TASK] Migrate ext:viewpage to extbase
Felix Kopp [Mon, 16 Apr 2012 22:27:06 +0000 (00:27 +0200)]
[TASK] Migrate ext:viewpage to extbase

Change-Id: I9929cb7f185319d052b13640f4e6e1681e7bda95
Resolves: #36122
Releases: 6.0
Reviewed-on: http://review.typo3.org/10558
Reviewed-by: Ingo Pfennigstorf
Tested-by: Ingo Pfennigstorf
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Clean up phpDoc comments in t3lib_ajax
Wouter Wolters [Fri, 4 May 2012 18:47:37 +0000 (20:47 +0200)]
[TASK] Clean up phpDoc comments in t3lib_ajax

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I5f5a2c0522311a21d9e7faea3a5b71531c5044f2
Resolves: #36855
Releases: 6.0
Reviewed-on: http://review.typo3.org/11009
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Clean up phpDoc comments in t3lib_arraybrowser
Wouter Wolters [Fri, 4 May 2012 19:01:56 +0000 (21:01 +0200)]
[TASK] Clean up phpDoc comments in t3lib_arraybrowser

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I02a2216692b24aba875f8bb6bf3d18f3d02bdcb9
Resolves: #36856
Releases: 6.0
Reviewed-on: http://review.typo3.org/11010
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Clean up phpDoc comments in t3lib_admin
Wouter Wolters [Fri, 4 May 2012 17:32:00 +0000 (19:32 +0200)]
[TASK] Clean up phpDoc comments in t3lib_admin

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)
* CGLify method signatures (the first line of the method)

Change-Id: Ie5c9e6db3834a57ef3501b4eda783851e1fc6937
Resolves: #36852
Releases: 6.0
Reviewed-on: http://review.typo3.org/11006
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Update wizard uses hardcoded fileadmin/ dir
Andreas Wolf [Tue, 24 Apr 2012 13:54:47 +0000 (15:54 +0200)]
[BUGFIX] Update wizard uses hardcoded fileadmin/ dir

The migration wizard for TCEforms always moved files to fileadmin/
instead of taking the configured alternative fileadmin directory into
account.

Change-Id: I3f877a2421833fb8bf3914487147fbb6386e30dc
Fixes: #36781
Related: #36400
Releases: 6.0
Reviewed-on: http://review.typo3.org/10929
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[TASK] Clean up phpDoc comments in t3lib_TStemplate
Sebastian Michaelsen [Thu, 15 Mar 2012 14:48:32 +0000 (15:48 +0100)]
[TASK] Clean up phpDoc comments in t3lib_TStemplate

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)
* CGLify method signatures (the first line of the method)

Change-Id: I718494b6ab141cb6460a1bc71f294fc5830fcb05
Fixes: #34882
Releases: 6.0
Reviewed-on: http://review.typo3.org/9667
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[FEATURE] Add method getUid() to abstract record collection
Ingmar Schlecht [Fri, 4 May 2012 10:35:24 +0000 (12:35 +0200)]
[FEATURE] Add method getUid() to abstract record collection

Change-Id: Id39ff747779fcfeeb5f7b8b4af685cad1f9f05d7
Releases: 6.0
Resolves: #36839
Reviewed-on: http://review.typo3.org/10996
Reviewed-by: Ingmar Schlecht
Tested-by: Ingmar Schlecht
7 years ago[FEATURE] Add method findAll() to record collection repository
Ingmar Schlecht [Fri, 4 May 2012 11:18:40 +0000 (13:18 +0200)]
[FEATURE] Add method findAll() to record collection repository

Change-Id: I44a58bdedc8be3a9be68af7d636f44628d014fce
Resolves: #36835
Releases: 6.0
Reviewed-on: http://review.typo3.org/10994
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[BUGFIX] Wrong query in RecordCollectionRepository
Ingmar Schlecht [Fri, 4 May 2012 11:15:44 +0000 (13:15 +0200)]
[BUGFIX] Wrong query in RecordCollectionRepository

If t3lib_collection_RecordCollectionRepository::queryMultipleRecords()
is called without any argument the SQL statement is wrong since
t3lib_BEfunc::deleteClause() starts with "AND".

Change-Id: I96efb31d142e89968cfcfa66ba6d1fda570b8595
Fixes: #36841
Releases: 6.0, 4.7
Reviewed-on: http://review.typo3.org/10998
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[TASK] Clean up phpDoc comments in class template
Sebastian Michaelsen [Wed, 7 Mar 2012 09:23:00 +0000 (10:23 +0100)]
[TASK] Clean up phpDoc comments in class template

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)
* CGLify method signatures (the first line of the method)
* Corrected a few minor very obvious flaws

Change-Id: Ie474fe9009c73092b7323b06648eb2e988473cd9
Resolves: #34629
Releases: 6.0
Reviewed-on: http://review.typo3.org/9450
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Add trailing slash to PAGEPATH
Felix Kopp [Sat, 24 Mar 2012 17:32:09 +0000 (18:32 +0100)]
[BUGFIX] Add trailing slash to PAGEPATH

With issue #23828 the closing slash for PAGEPATH was removed.
If PAGEPATH in docheader is combined with PAGEINFO, there is now no
visible separation anymore. The patch re-introduces the missing slash.

Change-Id: I6f261179cfcdee7301bc8eaba47d722b973d8017
Resolves: #35216
Releases: 6.0, 4.7
Reviewed-on: http://review.typo3.org/9861
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Remove broken and unused class
Christian Kuhn [Thu, 3 May 2012 21:21:23 +0000 (23:21 +0200)]
[BUGFIX] Remove broken and unused class

typo3/sysext/lowlevel/class.tx_lowlevel_cleaner.php was never
finished since TYPO3 4.0 and die()'s immediately. Remove it.

Change-Id: Id3030d396fac9c261e449c525f7756b569f37d2c
Resolves: #36824
Releases: 6.0
Reviewed-on: http://review.typo3.org/10982
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Remove XCLASS definitions from typo3/
Christian Kuhn [Thu, 3 May 2012 19:48:30 +0000 (21:48 +0200)]
[TASK] Remove XCLASS definitions from typo3/

Remove all XCLASS definitions in typo3/ and all system extension
that are not handled as git submodules.

Change-Id: Ib9e1d8db31f91f5f1453deb694f2441ef41130f2
Resolves: #36821
Related: #31893
Releases: 6.0
Reviewed-on: http://review.typo3.org/10981
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] EM: improve action icons alignment
Francois Suter [Fri, 27 Apr 2012 07:41:21 +0000 (09:41 +0200)]
[BUGFIX] EM: improve action icons alignment

In both extensions list of the new EM (available and import), the
action icons are flush with the top of each table row. Instead
they should be aligned with the extension icon.

Change-Id: I49dd745c3b014af24c6a06b5d68e46418cc77e63
Fixes: #36611
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/10811
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Francois Suter
Tested-by: Francois Suter
7 years ago[FEATURE] Create RTE personal dictionary in default upload folder
Stanislas Rolland [Thu, 3 May 2012 17:26:06 +0000 (13:26 -0400)]
[FEATURE] Create RTE personal dictionary in default upload folder

In FAL-enabled RTE Spell Checker, create personal dictionary in the
backend user's default upload folder.

Change-Id: Ifad2612a5af1f447cc9cc9abdae6c140f3680a8d
Releases: 6.0
Resolves: #36818
Reviewed-on: http://review.typo3.org/10974
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] Adjustments to FAL-enabled RTE image and link dialogues
Stanislas Rolland [Thu, 3 May 2012 16:18:59 +0000 (12:18 -0400)]
[BUGFIX] Adjustments to FAL-enabled RTE image and link dialogues

When no folder is selected, use $BE_USER->getDefaultUploadFolder().
Use the id of the base script so that the same styles are applied to
the window.
When enabled, move the folder creation form to the bottom of the
window.
Honour readonly filemounts.
Slightly increase the default opening width of the image dialogue.

Change-Id: I710e60ffe00125874532137422a4ee461b8850e7
Releases: 6.0
Resolves: #36815
Reviewed-on: http://review.typo3.org/10969
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] EM: misplaced tooltips
Francois Suter [Fri, 27 Apr 2012 07:18:26 +0000 (09:18 +0200)]
[BUGFIX] EM: misplaced tooltips

In the local list of extensions, the tooltips on the first two action
columns are misplaced. Tooltips from the second one override those
from the first one.

Change-Id: I24f02ff8b28a49e4649b7139d7d9ce196a6fceb8
Fixes: #36610
Releases: 6.0, 4.7, 4.6
Reviewed-on: http://review.typo3.org/10810
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Francois Suter
Tested-by: Francois Suter
7 years ago[BUGFIX] Unnecessary warning in css_styled_content (division by zero)
Thomas Layh [Wed, 2 May 2012 14:10:06 +0000 (16:10 +0200)]
[BUGFIX] Unnecessary warning in css_styled_content (division by zero)

If tt_content.image.20.maxW is not set, PHP throws a warning about
division by zero. This is not necessary. After that the variable
$scale is not set. This patch checks if $netW is greater zero and
otherwise the else condition will set $scale to 1.

Change-Id: Icd876b33d543080e486e0184c8af34c9a3831738
Fixes: #36777
Releases: 6.0, 4.7, 4.6
Reviewed-on: http://review.typo3.org/10928
Reviewed-by: Michael Klapper
Tested-by: Michael Klapper
Reviewed-by: Philipp Gampe
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[FEATURE] Use FAL file properties as default image attributes in RTE
Stanislas Rolland [Thu, 3 May 2012 03:03:38 +0000 (23:03 -0400)]
[FEATURE] Use FAL file properties as default image attributes in RTE

Use FAL file properties "name" and "alternative" as default values for
"title" and "alt" img tag attributes when inserting an image into the
RTE content.

Change-Id: If33bfbd26bea5e63e154cd4e042b327eb1e02199
Releases: 6.0
Resolves: #36796
Reviewed-on: http://review.typo3.org/10944
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] Update sys_refindex to reflect img tags in RTE content
Stanislas Rolland [Wed, 2 May 2012 19:38:13 +0000 (15:38 -0400)]
[BUGFIX] Update sys_refindex to reflect img tags in RTE content

Problem: sys_refindex should be updated when an image is inserted or
removed from RTE content
Solution: Add rtehtmlarea_images softref key

Change-Id: I40d504adf3d51e55fd271d01656e9db3f285d7ad
Releases: 6.0
Resolves: #36789
Reviewed-on: http://review.typo3.org/10940
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[FEATURE] Allow t3lib as class prefix
Ingmar Schlecht [Mon, 30 Apr 2012 15:11:41 +0000 (17:11 +0200)]
[FEATURE] Allow t3lib as class prefix

Several parts in the Core require class names to start with
"tx_" or "user_", e.g. for working with user functions in a
particular context. The "t3lib_" prefix is simply missing
here...

Change-Id: I577ce61506f2dacb5805493d29296f1b84b46419
Resolves: #36779
Related: #36726
Releases: 6.0
Reviewed-on: http://review.typo3.org/10901
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[BUGFIX] Wrong TCEForms placeholder in sys_file_references
Ingmar Schlecht [Mon, 30 Apr 2012 13:43:36 +0000 (15:43 +0200)]
[BUGFIX] Wrong TCEForms placeholder in sys_file_references

Due to a wrong TCA configuration, the placeholder feature in
content elements using images just shows the unresolved value
"__row|__foreign|name" instead of the correct title.

Change-Id: I7b574e1fb79a7bed02bb265671847449780ef0f4
Resolves: #36403
Releases: 6.0
Reviewed-on: http://review.typo3.org/10898
Reviewed-by: Ingmar Schlecht
Tested-by: Ingmar Schlecht
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[BUGFIX] Custom HTML tags no longer malformed in IE
Bart Dubelaar [Mon, 19 Mar 2012 14:44:34 +0000 (15:44 +0100)]
[BUGFIX] Custom HTML tags no longer malformed in IE

Custom HTML tags would get malformed while editing in IE.
If a tag is not present in HTML4 and the document mode
of IE is lower than IE9 Standards, then the tag is not
present in the DOM and not parsed correctly.
This is fixed by specifying possible custom tags in TSconfig
and creating dummy instances of the tags before loading
the contents in the DOM, also known as the Shiv trick.

Change-Id: Ie9ee09947a88dd73f92c0330f5d0c15609a7efb3
Fixes: #34786
Releases: 4.5, 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/9743
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] clickenlarge not working on images inserted by FAL-enabled RTE
Stanislas Rolland [Mon, 30 Apr 2012 11:32:36 +0000 (07:32 -0400)]
[BUGFIX] clickenlarge not working on images inserted by FAL-enabled RTE

Solution: Get original file from data-htmlarea-file-uid attribute

Change-Id: I5c4aef33bdcbe7c5badac9173480e33fb627b302
Releases: 6.0
Resolves: #36718
Reviewed-on: http://review.typo3.org/10894
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] Fix old XCLASS deprecation log
Christian Kuhn [Sun, 29 Apr 2012 14:04:16 +0000 (16:04 +0200)]
[BUGFIX] Fix old XCLASS deprecation log

The correct check for the old xclass register usage is to test for array
entry count greater than zero. Furthermore the comments have been improved.

Change-Id: I0ce923c3bb220872dfc6482e963240271408d9ec
Resolves: #36703
Releases: 6.0
Reviewed-on: http://review.typo3.org/10870
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Remove XCLASS inclusion blocks from t3lib
Tolleiv Nietsch [Tue, 17 Apr 2012 08:58:10 +0000 (10:58 +0200)]
[BUGFIX] Remove XCLASS inclusion blocks from t3lib

After #31893 is merged we can remove the XCLASS blocks from the
Core. This patchset removes it from the classes within t3lib.

Besides that it declares t3lib_TimeTrackNull and t3lib_TimeTrack
to be final to make sure that extending them is still denied.

This patchset itself should not be merged before the related patch
for EXT:dbal (#31183) is merged.

Change-Id: I09e5253191972ac4b3b033aeb770758690ea3755
Fixes: #36184
Releases: 6.0
Reviewed-on: http://review.typo3.org/10556
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Clean up XCLASS handling and comments
Christian Kuhn [Sun, 29 Apr 2012 10:45:30 +0000 (12:45 +0200)]
[TASK] Clean up XCLASS handling and comments

Clean up some of the comments of the new XCLASS handling, separate
the deprecation handling to an own method and add a NEWS.txt entry.

Change-Id: I16a828e15c8e3d347b8b331ffb554ac42aa82644
Resolves: #36698
Related: #31893
Releases: 6.0
Reviewed-on: http://review.typo3.org/10865
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Add note on removed noBlur TypoScript option to NEWS.txt
Christian Kuhn [Sat, 28 Apr 2012 17:01:33 +0000 (19:01 +0200)]
[TASK] Add note on removed noBlur TypoScript option to NEWS.txt

Change-Id: I78c3001968f546e04007a191ec963a0721dee025
Related: #35827
Reviewed-on: http://review.typo3.org/10853
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] New task button missing after deleting task
Alexander Jahn [Mon, 23 Apr 2012 07:45:06 +0000 (09:45 +0200)]
[BUGFIX] New task button missing after deleting task

Change-Id: I7b0dd0ef83d8fe62aeaf12849bcf87b00801eacc
Fixes: #36296
Releases: 6.0, 4.7, 4.6
Reviewed-on: http://review.typo3.org/10700
Reviewed-by: Philipp Gampe
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[FEATURE] Remove noBlur code
dkd-egerer Sascha Egerer [Sat, 14 Apr 2012 20:26:52 +0000 (22:26 +0200)]
[FEATURE] Remove noBlur code

remove the old and ugly noBlur javascript stuff in menu rendering

Change-Id: Ifd4ca7bcb11058b0b4610cc9c3aa5f1dd15d8118
Resolves: #35827
Releases: 6.0
Reviewed-on: http://review.typo3.org/10504
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Kilian Hann
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Oliver Klee
Reviewed-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[FEATURE] Use File Abstraction Layer in RTE
TYPO3 FAL Team [Fri, 20 Apr 2012 16:33:15 +0000 (18:33 +0200)]
[FEATURE] Use File Abstraction Layer in RTE

Change-Id: Ifd6c313eeab812b511b8ae9ae893cc399244b590
Resolves: #36387
Releases: 6.0
Reviewed-on: http://review.typo3.org/10656
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[BUGFIX] Remove duplicate domain from FE copyright comment
Tomita Militaru [Fri, 27 Apr 2012 09:31:44 +0000 (12:31 +0300)]
[BUGFIX] Remove duplicate domain from FE copyright comment

Since typo3.com was replaced by typo3.org, current frontend copyright
comment shows duplicate domain in copyright:
TYPO3 is copyright 1998-2012 of Kasper Skaarhoj. Extensions are
copyright of their respective owners. Information and contribution
at http://typo3.org/ and http://typo3.org/

Change-Id: Id0647274974032f20a1b5a050e439ed43213bcdb
Fixes: #36164
Releases: 4.5, 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/10818
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn