Packages/TYPO3.CMS.git
2 months ago[BUGFIX] URL without base runs into a redirect loop 91/59891/5
Marco Kaiser [Wed, 6 Mar 2019 20:32:00 +0000 (21:32 +0100)]
[BUGFIX] URL without base runs into a redirect loop

Calling something like bla.example.com/?id=34&type=2
runs in a endless loop.

The change removes the restrictive redirect.

Change-Id: I0457c48640d6b47a0947ed5115a96cf73cc97d81
Resolves: #88032
Releases: master, 9.5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59891
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
2 months ago[BUGFIX] Repair depth selection in workspace module 95/60495/3
Daniel Goerz [Wed, 17 Apr 2019 17:40:08 +0000 (19:40 +0200)]
[BUGFIX] Repair depth selection in workspace module

This patch fixes a regression introduced with
https://review.typo3.org/#/c/Packages/TYPO3.CMS/+/60492/

Resolves: #43338
Releases: master, 9.5
Change-Id: I3ac8445ec21097531ff1dcb5e33d0ff271332be3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60495
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Sattler <sattler@b13.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Sattler <sattler@b13.de>
Reviewed-by: Achim Fritz <af@achimfritz.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
2 months ago[BUGFIX] Allow to check/uncheck all recipients in Workspace stage dialog 94/60494/2
Benni Mack [Wed, 17 Apr 2019 17:06:02 +0000 (19:06 +0200)]
[BUGFIX] Allow to check/uncheck all recipients in Workspace stage dialog

The stage dialog shows various users relevent in a workspace that
should be notified. However, it is hard for editors (UX wise) to
uncheck / check everybody when a single element should be pushed
into the next stage.

The patch adds two buttons to toggle the checkboxes (check/uncheck all).

Resolves: #59228
Releases: master, 9.5
Change-Id: I2ebbcb7ec2d46b50880f93aefd243ef791300a2e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60494
Tested-by: Daniel Sattler <sattler@b13.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Daniel Sattler <sattler@b13.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
2 months ago[BUGFIX] Store depth selector in workspace module in uc 92/60492/2
Benni Mack [Wed, 17 Apr 2019 16:01:16 +0000 (18:01 +0200)]
[BUGFIX] Store depth selector in workspace module in uc

The depth selector is now stored in the users' UC, so the Persisent
Storage API can now be used easily.

This way, when changing pages, the depth selector value is kept.

Resolves: #43338
Releases: master, 9.5
Change-Id: I8fd49556e24f717cfa1b9e881a603f5adf5ce617
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60492
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Sattler <sattler@b13.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Daniel Sattler <sattler@b13.de>
2 months ago[BUGFIX] Check if language is accessible before uri generation 12/60212/9
Jonas Schwabe [Fri, 8 Mar 2019 14:59:04 +0000 (15:59 +0100)]
[BUGFIX] Check if language is accessible before uri generation

Sites with error handling were not rendering the correct page for
disabled languages because an inaccessible language was used
internally.

Resolves: #87865
Releases: master, 9.5
Change-Id: I8f6219d742c74359e0009085711f5452dc139f40
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60212
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jonas Schwabe <jonas.schwabe@eyeworkers.de>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Jonas Schwabe <jonas.schwabe@eyeworkers.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
2 months ago[BUGFIX] Ensure PageRouter only operates with previous result 74/60474/2
Benni Mack [Mon, 15 Apr 2019 04:52:49 +0000 (06:52 +0200)]
[BUGFIX] Ensure PageRouter only operates with previous result

If no previous result given, an exception should be thrown,
instead of a PHP error.

Resolves: #88133
Releases: master, 9.5
Change-Id: I708e735e664589b0fc8d125a60b9970128b584af
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60474
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Dmitry Dulepov
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Dmitry Dulepov
Reviewed-by: Susanne Moog <look@susi.dev>
2 months ago[TASK] Add missing fe_login hooks to docs 43/60443/6
Stephan Großberndt [Wed, 10 Apr 2019 10:11:12 +0000 (12:11 +0200)]
[TASK] Add missing fe_login hooks to docs

Add the missing documentation of the hooks

 * `password_changed` added in TYPO3 4.3
 * `login_error` added in TYPO3 6.0

Releases: master, 9.5, 8.7
Resolves: #88131
Related: #87726, #29698
Change-Id: I0dc875a399da58e13b15225e173392565c64bb03
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60443
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Julian Geils <j_geils@web.de>
Tested-by: Steffen Frese <steffenf14@gmail.com>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Julian Geils <j_geils@web.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
2 months ago[BUGFIX] Simplify UX in Workspace Module 76/60476/4
Benni Mack [Mon, 15 Apr 2019 11:26:52 +0000 (13:26 +0200)]
[BUGFIX] Simplify UX in Workspace Module

Some minor remarks are changed within the Workspace
Module (ReviewController).

- The preview link in docheader now has a text (makes it readable for newcomers)
- The checkboxes are now in the first column
- The modal box is bigger for increased readability

Resolves: #88151
Releases: master, 9.5
Change-Id: I2bbc581d73b0263d77029c533381c52f527dac42
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60476
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
2 months ago[FEATURE] Add properties changefreq and priority to XML sitemap entries 34/59834/19
Guido Schmechel [Sat, 2 Mar 2019 22:45:38 +0000 (23:45 +0100)]
[FEATURE] Add properties changefreq and priority to XML sitemap entries

The possibility to define the properties changefreq and priority for
XML sitemap entries has been implemented.

Resolves: #87433
Releases: master
Change-Id: I90b8c59ff916110be19aa8e8c888e77f25649bc3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59834
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
2 months ago[BUGFIX] Fix labels and field ordering of workspaces TCA 79/60479/2
Benni Mack [Mon, 15 Apr 2019 13:14:48 +0000 (15:14 +0200)]
[BUGFIX] Fix labels and field ordering of workspaces TCA

Labels regarding sys_workspaces are now in the same file,
and the fields / tabs have been grouped to ensure workspace
admins can work more efficiently with the records.

This way, the functionality is more self-explaining.

Resolves: #88152
Releases: master, 9.5
Change-Id: Ie55eada9956375bf0533affde80a927bcebb3502
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60479
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Achim Fritz <af@achimfritz.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Achim Fritz <af@achimfritz.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
2 months ago[BUGFIX] Apply quality settings for images 64/60464/3
Benni Mack [Sat, 13 Apr 2019 06:25:10 +0000 (08:25 +0200)]
[BUGFIX] Apply quality settings for images

When combining or scaling images, the quality
setting needs to be applied as well.

Resolves: #31664
Releases: master, 9.5
Change-Id: Iab4d7247c1ee51483b9ede705f6c61ba11f37589
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60464
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
2 months ago[BUGFIX] Allow adding content without page edit permissions 72/59872/2
Helmut Hummel [Tue, 5 Mar 2019 15:03:34 +0000 (16:03 +0100)]
[BUGFIX] Allow adding content without page edit permissions

Resolves: #87687
Releases: master, 9.5
Change-Id: I8113f3fa2facf6b21bc19ee1c445265c5ff4f4b4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59872
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
2 months ago[BUGFIX] Fix serialization of loggers 25/60325/2
Helmut Hummel [Mon, 25 Mar 2019 08:01:11 +0000 (09:01 +0100)]
[BUGFIX] Fix serialization of loggers

Only dealing with PHP file resource in writers is not
enough to properly initialize a logger on wakeup.

A logger has to log with a new request IDs and possibly completely new writers
and processors due to configuration changes in the meantime.

Therefore the __sleep and __wakeup methods are removed in the FileWriter
and new methods are added to the logger instance to make sure a
wakeup will have a correctly configured logger instance.

Resolves: #86941
Resolves: #87261
Releases: master, 9.5
Change-Id: Ia36e251404eae2bdf0dfdf52ace7dcf1815ec456
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60325
Tested-by: Ralf Merz <mail@merzilla.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Ralf Merz <mail@merzilla.de>
Reviewed-by: Susanne Moog <look@susi.dev>
2 months ago[BUGFIX] Use finder instance correctly 39/59839/13
Jan Delius [Mon, 4 Mar 2019 12:52:41 +0000 (13:52 +0100)]
[BUGFIX] Use finder instance correctly

Within SiteTcaConfiguration, the $finder is now reused as much as
possible. A new clean instance is used for the individual actions.

Resolves: #87832
Releases: master, 9.5
Change-Id: I34f2d08c51042f2cfe6b4a09ac6152e0b552ab14
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59839
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Rico Drexler <rico.drexler@gmx.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <look@susi.dev>
2 months ago[BUGFIX] Prevent throwing warnings when extract svg image sizes 02/59802/4
Remo Häusler [Mon, 25 Feb 2019 16:02:30 +0000 (17:02 +0100)]
[BUGFIX] Prevent throwing warnings when extract svg image sizes

TYPO3 should silently ignore errors and warnings in svg images.

Resolves: #86428
Releases: master, 9.5, 8.7
Change-Id: I54bb19ac0a6c949a8b150808f52562b73653e739
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59802
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <look@susi.dev>
2 months ago[!!!][TASK] Replace config.persistence.classes typoscript 70/59570/13
Alexander Schnitzler [Sun, 27 Jan 2019 18:48:56 +0000 (19:48 +0100)]
[!!!][TASK] Replace config.persistence.classes typoscript

This patch removes support for the configuration of
persistence related classes via typoscript. This is done
as typoscript is too variable, i.e. the configuration may
change depending on the day, the hour and whatever
possibility typoscript has when it comes to conditions.

The functionality must not vanish completely, but the
configuration should be immutable and predictable at an
early stage of the runtime.

To achieve this, the configuration has to be added to files
like EXT:Configuration/Extbase/Persistence/Classes.php

This patch is considered breaking as the configuration via
typoscript stops working immediately and the configuration
syntax slightly changed.

The easiest way to migrate to the new syntax is to have a
look at configuration files in core extensions.

Releases: master
Resolves: #87623
Change-Id: Id1ceceafd10ec647507bca8078ebf62fe1b02d2a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59570
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <look@susi.dev>
2 months ago[BUGFIX] Use proper TYPO3_CONF_VARS IM option 65/60465/2
Benni Mack [Sat, 13 Apr 2019 06:33:10 +0000 (08:33 +0200)]
[BUGFIX] Use proper TYPO3_CONF_VARS IM option

There is a copy/paste typo in LocalCropScaleMaskHelper,
which was introduced in TYPO3 v8.

The setting $TYPO3_CONF_VARS[GFX][processor_stripColorProfileCommand]
is the correct one.

Resolves: #87548
Releases: master, 9.5
Change-Id: I4f9e4f3f62e1b577a986c96a31d4438da1bc7f74
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60465
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Susanne Moog <look@susi.dev>
2 months ago[TASK] Add tests for SiteBased translations in Extbase records 61/60461/3
Benni Mack [Fri, 12 Apr 2019 23:24:18 +0000 (01:24 +0200)]
[TASK] Add tests for SiteBased translations in Extbase records

As part of using the SiteBased translation model instead of
the legacy TypoScript settings, another test suite is added
which mimics the exact same settings and results as in TypoScript
for Extbase.

Resolves: #88142
Releases: master, 9.5
Change-Id: Ieaa2e0d6cb510e6e00555e848020d89e8e1f5670
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60461
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[TASK] Migrate SelectElementTree to TypeScript 16/60316/4
Andreas Fernandez [Sat, 23 Mar 2019 10:32:52 +0000 (11:32 +0100)]
[TASK] Migrate SelectElementTree to TypeScript

This patch migrates FormEngine's SelectElementTree to TypeScript.
Also, a terrible hack that puts the local tree initialitation callback
into global scope has been removed.

Resolves: #87987
Releases: master
Change-Id: Ib34ae7fe4ac1e197af2183b8890cc72e13a900e9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60316
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Steffen Frese <steffenf14@gmail.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[BUGFIX] Populate href lang URI only if the link is available 50/60350/5
Julian Wundrak [Thu, 28 Mar 2019 20:11:03 +0000 (21:11 +0100)]
[BUGFIX] Populate href lang URI only if the link is available

If there are e.g., records that have no translation, the
HrefLangGenerator outputs the site-base URL. Expected is that the entry
for this page is suppressed.

Change-Id: I6fbd4dd00955906dff13c0e5aceea6804c52dd1b
Resolves: #88032
Releases: master, 9.5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60350
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
2 months ago[BUGFIX] Catch TypeError on inlineCSS files 20/60420/2
Benni Mack [Tue, 9 Apr 2019 02:01:05 +0000 (04:01 +0200)]
[BUGFIX] Catch TypeError on inlineCSS files

If page.includeCSS.myfile.import = 1 is used, but no "media" is set, a TypeError
is thrown, which is now caught and properly checked.

Resolves: #88059
Releases: master, 9.5
Change-Id: I0951688bb9ee779329ebe5c7fad698862d73f6c3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60420
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Julian Geils <j_geils@web.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Julian Geils <j_geils@web.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Benni Mack <benni@typo3.org>
2 months ago[FEATURE] Re-introduce mixed overlay mode for content fallback 67/60367/6
Benni Mack [Wed, 3 Apr 2019 14:29:42 +0000 (16:29 +0200)]
[FEATURE] Re-introduce mixed overlay mode for content fallback

This "feature" solves a lot of issues, but I really wanted to make sure
to cover the generic issues around this topic.

In order to understand this, we need to understand the different
logic when talking about "language fallbacks", but I don't want
to warm up how it was before.

This is how it works:
- fallbackChain: defines which page translation should be checked
when linking or resolving a page in a specific language
- fallbackType: Now that we covered all relevant cases, the naming
could be better, but here we go, it's actually defining the logic for fetching
content.
- fallbackType="strict" -> only show the content that is viable in the target language
  but this is based on "overlays". Fetch all "language=0" records, do overlays
  and remove the ones that have no overlays. However, take the ones that have no
  language parent and render them as well ("includeWithoutDefaultTranlsation")
  This is what we call "do overlays with floating".
  This is recommended to do in most classic translation cases, with different languages
- fallbackType="fallback" -> Do overlays: Fetch all "language=0" records, do overlays
  but KEEP the ones that have no overlays. However, take the ones that have no
  language parent and render them as well ("includeWithoutDefaultTranlsation")
  This is what we call "do overlays in mixed mode".
  Useful if your translation is Swiss-German but your default language is "German"
- fallbackType="free" - Do not do overlays, just fetch all records of the target language
  Could be seen as "free mode" as we do it in TYPO3 Page module.

The new free option is therefore new, also the "fallback" functionality
is actually showing more content than before (thus, different, but maybe we could fix that!)
as we have the "mixed" mode back.
Also the "language fallback" is now possible for any fallbackType.

Now, what's still missing - but out of scope - is actually a way to fetch content
with multiple possibilities for overlaying. I call this "forward language overlays"
however, this is a feature that is theoretically possible but not in v9 anymore.

This patch restores the max. types of use cases back for TYPO3 Core.

The following things that are really gone for good now and won't come back:
- config.sys_language_mode = ignore
- config.sys_language_mode =
- Option includeRecordsWithoutDefaultTranslation (= always enabled) is not needed anymore

Also, there are no ways anymore to use inconsistent multiple TypoScript settings which
do not make sense depending if the translated page does not exist (l18n_cfg)
but still using TypoScript conditions for that.

Resolves: #86762
Resolves: #86712
Releases: master, 9.5
Change-Id: I8b3144410f7d7ed1d705d42f16a46f190275387a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60367
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Nikolaj Wojtkowiak-Pfänder <nwp@dr-bock.com>
Tested-by: Steven Hilgendorff
Tested-by: Ralf Merz <mail@merzilla.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Nikolaj Wojtkowiak-Pfänder <nwp@dr-bock.com>
Reviewed-by: Ralf Merz <mail@merzilla.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[TASK] Add tests for pages.slug in workspaces tests 42/60242/3
Benni Mack [Wed, 13 Mar 2019 17:42:03 +0000 (18:42 +0100)]
[TASK] Add tests for pages.slug in workspaces tests

In order to see the current behaviour in
workspaces when modifying pages, the slug
field is added to the existing "Regular"
DataHandler tests within workspaces.

Resolves: #87904
Releases: master, 9.5
Change-Id: Ie2432fb078f2b04515a24de7b525b1c151186b05
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60242
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
2 months ago[TASK] Migrate TYPO3/CMS/Extensionmanager/* to TypeScript 53/60353/5
Frank Naegler [Fri, 29 Mar 2019 15:59:51 +0000 (16:59 +0100)]
[TASK] Migrate TYPO3/CMS/Extensionmanager/* to TypeScript

Resolves: #88040
Releases: master
Change-Id: I5408c30fef735fe52a4b58bda3fb5b4d3b8e002e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60353
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Steffen Frese <steffenf14@gmail.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[TASK] Migrate TYPO3/CMS/Impexp/* to TypeScript 50/60250/4
Frank Naegler [Thu, 14 Mar 2019 17:46:56 +0000 (18:46 +0100)]
[TASK] Migrate TYPO3/CMS/Impexp/* to TypeScript

Resolves: #87915
Releases: master
Change-Id: I4a7fa727c47b85bfae728f0a1dab0e6e833063ce
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60250
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Steffen Frese <steffenf14@gmail.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[TASK] Migrate TYPO3/CMS/Recycler/* to TypeScript 52/60352/5
Frank Naegler [Fri, 29 Mar 2019 13:04:31 +0000 (14:04 +0100)]
[TASK] Migrate TYPO3/CMS/Recycler/* to TypeScript

Resolves: #88038
Releases: master
Change-Id: I0441df6756bb4950b7875c74eed0e5bfff7625a7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60352
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Steffen Frese <steffenf14@gmail.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[FEATURE] Allow config.cache.all = fe_users:current 19/60419/4
Benni Mack [Tue, 9 Apr 2019 01:52:03 +0000 (03:52 +0200)]
[FEATURE] Allow config.cache.all = fe_users:current

The existing TypoScript functionality config.cache.all = ... allows a list
of tables and PIDs to take into account other records for the current page
caches.

The cache lifetime of page 42 takes starttime and endtime of news records of
page 15 and addresses of page 16 into account:

config.cache.42 = tt_news:15,tt_address:16

A new functionality used with "current" allows to take records of the current page
into account as well.

config.cache.all = fe_users:current

Resolves: #83734
Releases: master
Change-Id: Ib2063cc89e2c1549b7609b77948243e983d14c1b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60419
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Fabien Udriot <fudriot@omic.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
2 months ago[BUGFIX] Do not use LSB in <f:form.select> 36/60436/4
Benni Mack [Wed, 10 Apr 2019 04:20:39 +0000 (06:20 +0200)]
[BUGFIX] Do not use LSB in <f:form.select>

<f:form.select.option> uses the FQDN::class
syntax, so late static binding (LSB) is leading
to side effects when extending <f:form.select>.

Using the self::class syntax in <f:form.select>
solves the issue.

Resolves: #88017
Releases: master, 9.5
Change-Id: Ic060267cdff06856d1aa0f76980124ecfc0967a5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60436
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Benni Mack <benni@typo3.org>
2 months ago[BUGFIX] Use proper path to install cli binary 71/60371/7
Helmut Hummel [Thu, 4 Apr 2019 14:41:05 +0000 (16:41 +0200)]
[BUGFIX] Use proper path to install cli binary

The cli binary path is changed to be located in TYPO3_PATH_WEB
instead of TYPO3_PATH_ROOT.

Releases: 9.5, master
Resolves: #88088
Change-Id: I96587254d121149b58f35b0abb0084a89a31b0c7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60371
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
2 months ago[BUGFIX] Add table name as prefix for language DB selection 30/60430/2
Benni Mack [Tue, 9 Apr 2019 12:42:02 +0000 (14:42 +0200)]
[BUGFIX] Add table name as prefix for language DB selection

When building JOINs with TypoScript of tt_content or
any localized table, using "LEFTJOIN tt_content table2"
the language restriction check is not using a prefix
for the "l10n_parent" field.

The "sys_language_uid" field already has the same prefix
built in the same method.

This error existed in v8 already, but in TYPO3 v9, the
"includeRecordsWithoutDefaultTranslation" option is enabled
by default (via LanguageAspect), therefore it's more
prominent.

Resolves: #87521
Releases: master, 9.5
Change-Id: I1a3ee4f1f84d64a5d56cf63607a7aed83fdd13fc
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60430
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Julian Geils <j_geils@web.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Julian Geils <j_geils@web.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
2 months ago[TASK] Repair examples 24/60424/2
Stefan Frömken [Tue, 9 Apr 2019 08:49:07 +0000 (10:49 +0200)]
[TASK] Repair examples

Releases: master
Resolves: #88117
Change-Id: I5fa5da8f6697a74eda785c4655203f9d63c7b632
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60424
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Steffen Frese <steffenf14@gmail.com>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
2 months ago[BUGFIX] Allow FileInterface for ClickEnlarge ViewHelper 35/60435/2
Benni Mack [Wed, 10 Apr 2019 03:14:07 +0000 (05:14 +0200)]
[BUGFIX] Allow FileInterface for ClickEnlarge ViewHelper

Although the documentation and the internal
code allows File and FileReference, the functionality
requires a FileReference.

FileInterface is more appropriate and $cObj->imageLinkWrap()
can deal with File and FileReference.

Resolves: #82101
Releases: master, 9.5
Change-Id: I37e4f091fe0598509eef050cb811ad7627f16c21
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60435
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Steffen Frese <steffenf14@gmail.com>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
2 months ago[TASK] Move felogin TypoScript and TSconfig 14/60414/5
Jan Stockfisch [Mon, 8 Apr 2019 11:53:52 +0000 (13:53 +0200)]
[TASK] Move felogin TypoScript and TSconfig

Move all TypoScript and TSconfig from ext_localconf into separate files.

Resolves: #88105
Releases: master
Change-Id: I4b04352942f9ecc603c05072ec674340a7d73c25
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60414
Tested-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: Steffen Frese <steffenf14@gmail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
2 months ago[BUGFIX] Use PageTitle API for indexed_search 54/60354/7
Jonas Schwabe [Fri, 29 Mar 2019 16:52:11 +0000 (17:52 +0100)]
[BUGFIX] Use PageTitle API for indexed_search

The value of indexedDocTitle was not updated when a title had been
generated by the PageTitle API. This simply writes the generated
page title to indexedDocTitle so that it can be used in the
indexed hook.

Resolves: #88041
Releases: master, 9.5
Change-Id: I8ac1fd8295447aafa7e175fb09fa11f565442019
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60354
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Richard Haeser <richard@maxserv.com>
2 months ago[BUGFIX] Ensure to properly catch any connection exception 21/60421/2
Benni Mack [Tue, 9 Apr 2019 02:23:44 +0000 (04:23 +0200)]
[BUGFIX] Ensure to properly catch any connection exception

When e.g. a corrupt Database Connection is available
(MySQL down) and no connection is established, the Runtime
Exception should be caught as well.

In addition, the $message is more generic to avoid
any additional output for the end-users.

Resolves: #87993
Releases: master, 9.5
Change-Id: I2495426930d3fab841ff1632d778a945e73b521d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60421
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
2 months ago[TASK] Fix typo in form documentation 23/60423/4
Thorsten Griebenow [Tue, 9 Apr 2019 08:27:51 +0000 (10:27 +0200)]
[TASK] Fix typo in form documentation

Releases: master, 9.5, 8.7
Resolves: #88115
Change-Id: Ia1ab566ef3ebeff69a680b750b8e2ab4e8c9aba6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60423
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
2 months ago[BUGFIX] Fix handling menuConfig of LanguageMenuProcessor 32/60432/2
Daniel Gohlke [Tue, 9 Apr 2019 14:44:58 +0000 (16:44 +0200)]
[BUGFIX] Fix handling menuConfig of LanguageMenuProcessor

Use array_merge instead of union (+=) in order to
correctly handle overriding the menu configuration
of the LanguageMenuProcessor.

Resolves: #88123
Releases: master, 9.5
Change-Id: I1f382c11b2f24c052b97af2b7d62a6e0712e10e9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60432
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
2 months ago[TASK] Update columns in DocHeader bar 68/60368/4
Koen Wouters [Wed, 3 Apr 2019 18:57:40 +0000 (20:57 +0200)]
[TASK] Update columns in DocHeader bar

Dropdown fields will now stay next to each other for
responsive views.

Resolves: #88065
Releases: master, 9.5
Change-Id: I1990dc87dd69fd6c5470197277dc86c84f6c29de
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60368
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: André Schließer <andy.schliesser@gmail.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: André Schließer <andy.schliesser@gmail.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
2 months ago[TASK] Migrate TYPO3/CMS/Linkvalidator/* to TypeScript 55/60255/3
Frank Naegler [Fri, 15 Mar 2019 09:47:54 +0000 (10:47 +0100)]
[TASK] Migrate TYPO3/CMS/Linkvalidator/* to TypeScript

Resolves: #87920
Releases: master
Change-Id: Ibb3d28e85b6beddfd4bacca8303cca51c46ac6b3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60255
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
2 months ago[BUGFIX] Reenable Page TSconfig setting mod.web_list.hideTranslations 72/60372/3
Jan Helke [Fri, 5 Apr 2019 07:34:53 +0000 (09:34 +0200)]
[BUGFIX] Reenable Page TSconfig setting mod.web_list.hideTranslations

This regression fix reenables the setting mod.web_list.hideTranslations to
enable administrators to hide translations in the list view.
This behaviour is already described under
https://docs.typo3.org/typo3cms/TSconfigReference/PageTsconfig/Mod.html

Resolves: #88084
Releases: master, 9.5
Change-Id: I8bc0ce072a44c78564889325c888eb26fdb23a1c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60372
Tested-by: Sebastian Rosskopf <sebastian.rosskopf@gmx.de>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Raphael Thanner <r.thanner@zeroseven.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Windloff
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Sebastian Rosskopf <sebastian.rosskopf@gmx.de>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Raphael Thanner <r.thanner@zeroseven.de>
Reviewed-by: Daniel Windloff
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
2 months ago[BUGFIX] Refine build architecture 35/60335/9
Andreas Fernandez [Mon, 25 Mar 2019 15:52:34 +0000 (16:52 +0100)]
[BUGFIX] Refine build architecture

TypeScript:
Due to issues with upcoming TypeScript versions, the TypeScript sources
are moved into the Build directory before building JavaScript.

The unused Grunt task `tsdev` has been removed.

Additionally, some type defintions have been installed:

  yarn add --dev \
      @types/bootstrap-slider \
      @types/datatables.net \
      @types/chosen-js

Sass:
The Sass sources have been moved into the common "Sources" directory.
Those source files are moved to have a less cluttered Build directory.

Note: With this patch, all TypeScript files must be placed into
`Build/Sources/TypeScript` to be compiled by tsc again.

Resolves: #88043
Releases: master
Change-Id: I4d3e5f69564c38a35bf083652ea7262f5b85e4f3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60335
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[BUGFIX] Fix null coalesce evalutation in PageLayoutView::getLocalizedPageTitle() 00/60400/2
Andreas Fernandez [Fri, 5 Apr 2019 14:42:53 +0000 (16:42 +0200)]
[BUGFIX] Fix null coalesce evalutation in PageLayoutView::getLocalizedPageTitle()

This commit fixes a usage of the null coalesce operator within a condition.

Resolves: #88092
Related: #84375
Releases: master, 9.5
Change-Id: Ic34fb492e66eb224d0e617405e8ae2be69a16aa4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60400
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: André Schließer <andy.schliesser@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: André Schließer <andy.schliesser@gmail.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[BUGFIX] Deliver detected file type for IM identify 11/60311/7
Benni Mack [Fri, 22 Mar 2019 19:28:20 +0000 (20:28 +0100)]
[BUGFIX] Deliver detected file type for IM identify

Although not used in TYPO3 Core directly, the identify
command by ImageMagick now delivers the file extension
from IM plus the file type identified by IM as well.

This saves some regexp magic, and a foreach() loop,
as the "-format" output delivers proper IM results.

As this functionality is not actually fixing a core
bug, but rather a small improvement and correction
in the identified usage, the change is targeted to master-only.

Resolves: #23348
Releases: master
Change-Id: Ia380ee34dbbef7f9f763ecc088ee0c9b83167ce6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60311
Tested-by: Sebastian Rosskopf <sebastian.rosskopf@gmx.de>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Sebastian Rosskopf <sebastian.rosskopf@gmx.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[BUGFIX] DB check - search query, array handling on operator change 42/60342/3
Henrik Elsner [Tue, 26 Mar 2019 15:04:14 +0000 (16:04 +0100)]
[BUGFIX] DB check - search query, array handling on operator change

Exception is thrown when changing the operator from an array handling one
to a string handling. ("is in list" to "equals")
Also the selection is not set properly after changing.

Resolves: #88010
Releases: master, 9.5

Change-Id: Ibf7f607a51ac92d2c45dbfe16384f71c959e6c1f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60342
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Daniel Windloff
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[TASK] Remove superfluous function calls in page module 99/60399/2
Markus Klein [Fri, 5 Apr 2019 14:23:30 +0000 (16:23 +0200)]
[TASK] Remove superfluous function calls in page module

Resolves: #88091
Releases: master, 9.5
Change-Id: I3261190c1214dece4dce5d208a54af2b14b3aa0e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60399
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[BUGFIX] Use SiteFinder in SearchController for getting all languages 37/60337/4
Georg Ringer [Mon, 25 Mar 2019 20:59:25 +0000 (21:59 +0100)]
[BUGFIX] Use SiteFinder in SearchController for getting all languages

The SiteFinder must be used instead of only fetching all languages from
sys_language.

Resolves: #87999
Releases: master, 9.5
Change-Id: I95432c6221a8ee06d1fbb45a6780b0ec7c80ddf4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60337
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[TASK] Handle configured error level only in error handler 87/59287/9
Christoph Lehmann [Sun, 23 Dec 2018 14:13:33 +0000 (15:13 +0100)]
[TASK] Handle configured error level only in error handler

Currently there is no way to determine the error level of a previously
registered error handler.

The commit helps chaining error handlers and prevents unnecessary extra
work.

Resolves: #87281
Releases: master, 9.5
Change-Id: Ib6cc32eeb4714cae1dd16aa5382683c374615d38
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59287
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[BUGFIX] Use Sitematcher to fetch available languages 38/60338/3
Georg Ringer [Tue, 26 Mar 2019 07:02:44 +0000 (08:02 +0100)]
[BUGFIX] Use Sitematcher to fetch available languages

EXT:viewpage must use the SiteMatcher to get the available languages.

The join functionality has been removed as well to let users view a page
in a fallback language.

Resolves: #88001
Releaes: master, 9.5
Change-Id: Ibd0be7b2d169a7e8fb029905e3221fdd3ee5d69c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60338
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: André Schließer <andy.schliesser@gmail.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: André Schließer <andy.schliesser@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[TASK] Remove limit in be_groups fields 01/60301/2
Guido Schmechel [Wed, 20 Mar 2019 20:54:09 +0000 (21:54 +0100)]
[TASK] Remove limit in be_groups fields

With this change, there are no more restrictions
in TCA within the be_groups.

Resolves: #87967
Releases: master, 9.5
Change-Id: Ifc1cf2b41c15c43dd5a1e314c0cb0a418753455a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60301
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[TASK] Adjust documentation for custom routing enhancer registration 69/60369/3
Kevin Meckl [Wed, 3 Apr 2019 20:38:26 +0000 (22:38 +0200)]
[TASK] Adjust documentation for custom routing enhancer registration

Correct example TYPO3_CONF_VARS configuration for custom route enhancers
registration.

Releases: master, 9.5
Resolves: #88067
Change-Id: I0870498781f496d9c00331af126b96fd77eee70d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60369
Tested-by: Sebastian Rosskopf <sebastian.rosskopf@gmx.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: André Schließer <andy.schliesser@gmail.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Sebastian Rosskopf <sebastian.rosskopf@gmx.de>
Reviewed-by: André Schließer <andy.schliesser@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[BUGFIX] Improved visibility error message in install tool 77/60377/6
Chau kar [Fri, 5 Apr 2019 10:33:46 +0000 (12:33 +0200)]
[BUGFIX] Improved visibility error message in install tool

Removed the absolute positioning of the error page to avoid unexpected
behavior when rendered in an encapsulated component, e.g. panels in the
Install Tool.

Resolves: #88064
Resolves: #87382
Releases: master, 9.5
Change-Id: I5cefeacc0f753ab57c8c1e95dffa39eb55f5950e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60377
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[BUGFIX] Remove hard coded path to LocalConfiguration.php 74/60374/2
Helmut Hummel [Fri, 5 Apr 2019 09:00:00 +0000 (11:00 +0200)]
[BUGFIX] Remove hard coded path to LocalConfiguration.php

Instead of hard coding the path, the ConfigurationManager API
ist now used.

Resolves: #88089
Releases: master, 9.5
Change-Id: I51b6c75583e54f00535538d6afdcb617d86f6079
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60374
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Wolf-Peter Utz <wpu@hotmail.de>
Tested-by: Sebastian Rosskopf <sebastian.rosskopf@gmx.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Wolf-Peter Utz <wpu@hotmail.de>
Reviewed-by: Sebastian Rosskopf <sebastian.rosskopf@gmx.de>
Reviewed-by: Benni Mack <benni@typo3.org>
2 months ago[BUGFIX] Show correct timestamp in file replace dialog 73/60373/4
Manuel Selbach [Fri, 5 Apr 2019 08:34:53 +0000 (10:34 +0200)]
[BUGFIX] Show correct timestamp in file replace dialog

The property lastModifiedDate was remove by some browsers, thus with
this change if will be checked and the proper property is used to
parse the timestamp in the replace dialog.

Resolves: #88081
Releases: master, 9.5, 8.7
Change-Id: I4ae812267ef81c4db5c86d2d6dd814f83bebeb00
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60373
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Felix Herrmann <herrmann@riconet.de>
Tested-by: Wolf-Peter Utz <wpu@hotmail.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Felix Herrmann <herrmann@riconet.de>
Reviewed-by: Wolf-Peter Utz <wpu@hotmail.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[BUGFIX] Avoid PHP notice in DataHandler 48/60348/7
Markus Klein [Wed, 27 Mar 2019 16:12:21 +0000 (17:12 +0100)]
[BUGFIX] Avoid PHP notice in DataHandler

The fifth parameter to Datahandler::insertDB() is used in one place
without properly checking for the existence of the array element.
In general this parameter is only used for imp/exp extension
and works for admins only.

Resolves: #88025
Releases: master, 9.5
Change-Id: Iba5656857b1b16fb601a3c6af424a6477edc6956
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60348
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
2 months ago[TASK] Prepare Frontend Tests for additional site handling tests 63/60363/4
Benni Mack [Wed, 3 Apr 2019 09:55:36 +0000 (11:55 +0200)]
[TASK] Prepare Frontend Tests for additional site handling tests

Some test functionality regarding Site Handling is now sorted out in order
to add more tests.

- SiteConfiguration setup for tests is moved into a separate Trait.
- Code which is also used (in the future) for EXT:core and not
   just frontend is moved to EXT:core
- LocalizedFrontendPages now have a slug field as well.
- Regular Frontend JsonRenderer now also renders values
  from SiteLanguage config + context aspect

Resolves: #88060
Releases: master, 9.5
Change-Id: If859da89e4fcec16e3d1c2abb934eef040d4f386
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60363
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[BUGFIX] Enable preview of hidden page translations 31/60331/4
Daniel Goerz [Mon, 25 Mar 2019 14:23:42 +0000 (15:23 +0100)]
[BUGFIX] Enable preview of hidden page translations

TSFE->determineIdIsHiddenPage() now takes the current site language into
account when fetching the page record. When rendering a page translation
the mehtod does no longer reflect the hidden status of the default
language but the status of the translated page instead.

This enables previewing a hidden page translation even if the language
parent is active.

Resolves: #85471
Releases: master, 9.5
Change-Id: I1b0ead8eaf4c707583e24babbbca49870a31cdaa
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60331
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
2 months ago[BUGFIX] Check if fileObject width is greater than 0, if not use maxWidth 57/60357/2
Riny van Tiggelen [Mon, 1 Apr 2019 16:00:50 +0000 (18:00 +0200)]
[BUGFIX] Check if fileObject width is greater than 0, if not use maxWidth

If you want to use a PDF inside the GalleryProcessor, the mediaWidth is
always 0, because there are no dimensions in the metadata. This fix
will use the maxMediaWidth if the dimension is not greater than 0.

Resolves: #88047
Releases: master, 9.5
Change-Id: I56a2dc2a946385931172c86e54711ba8aa3f6637
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60357
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Koen Wouters <koen.wouters@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Koen Wouters <koen.wouters@maxserv.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
2 months ago[TASK] Documentation links to invalid URL 55/60355/3
Daniel Huf [Mon, 1 Apr 2019 08:51:08 +0000 (10:51 +0200)]
[TASK] Documentation links to invalid URL

The link must be prefixed with www, else the request will just show
an error.

Releases: master, 9.5, 8.7
Resolves: #88044
Change-Id: I2a7e5f34a741e92fdc1174d8be73204c19c197eb
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60355
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
2 months ago[BUGFIX] Use SiteMatcher in TranslationConfigurationProvider 36/60336/2
Georg Ringer [Mon, 25 Mar 2019 20:13:43 +0000 (21:13 +0100)]
[BUGFIX] Use SiteMatcher in TranslationConfigurationProvider

The TranslationConfigurationProvider must use the SiteMatcher
to find the proper languages and must not depend only on fetching
from sys_language.

Resolves: #87942
Releases: master, 9.5
Change-Id: Ib8b8a980d7997effa38a6c2dcfbe8a3e7e3eb1a6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60336
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
2 months ago[TASK] Migrate TYPO3/CMS/Lowlevel/* to TypeScript 57/60257/3
Frank Naegler [Fri, 15 Mar 2019 12:51:06 +0000 (13:51 +0100)]
[TASK] Migrate TYPO3/CMS/Lowlevel/* to TypeScript

Resolves: #87922
Releases: master
Change-Id: I77f1973c656b3b2538a37cd2f4dc2b04358a7198
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60257
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[TASK] Fix Changelog associated with extension scanner for services 40/60340/3
Sybille Peters [Tue, 26 Mar 2019 11:43:02 +0000 (12:43 +0100)]
[TASK] Fix Changelog associated with extension scanner for services

- Use different Changelog entry in extension scanner for
  AbstractAuthenticationService and AuthenticationService
- Add links to Changelog
- Change title in Changelog

Resolves: #88005
Releases: master, 9.5

Change-Id: I6852a7511bda74bee398ef86b8ca59f7d7454e5a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60340
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
2 months ago[BUGFIX] Update ColorPicker to use cleaned minicolors hex value 52/59052/5
Filipe DA COSTA [Fri, 7 Dec 2018 12:20:21 +0000 (13:20 +0100)]
[BUGFIX] Update ColorPicker to use cleaned minicolors hex value

Force ColorPicker to use the formatted/cleaned value jQuery's minicolors
produces instead of just displaying it but still saving the raw value
the user inputs.

Resolves: #87031
Releases: master, 9.5
Change-Id: I49d9f094961137ae50561475d5421f536b705c70
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59052
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Henrik Elsner <helsner@dfau.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Henrik Elsner <helsner@dfau.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
2 months ago[BUGFIX] DB check > Search: Convert `--div--` to optgroup 05/60305/4
Andreas Fernandez [Thu, 21 Mar 2019 16:24:24 +0000 (17:24 +0100)]
[BUGFIX] DB check > Search: Convert `--div--` to optgroup

Querying the database for the placeholder `--div--` is rather pointless,
thus this possibility is removed. Instead, the placeholder is converted
into an optgroup.

Resolves: #87976
Releases: master, 9.5
Change-Id: I60729a3fae1bc37c12612fccf0f8491ad27d8908
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60305
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Henrik Elsner <helsner@dfau.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Henrik Elsner <helsner@dfau.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
2 months ago[DOCS] Fix path of Changelog 39/60339/2
Sybille Peters [Tue, 26 Mar 2019 10:44:19 +0000 (11:44 +0100)]
[DOCS] Fix path of Changelog

Resolves: #88006
Releases: master
Change-Id: I02cacfe4829b975411026acd4bfd0bb700a38153
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60339
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
2 months ago[BUGFIX] Remove setDBinit from tests 12/59012/2
Stefan Neufeind [Sun, 2 Dec 2018 19:00:38 +0000 (20:00 +0100)]
[BUGFIX] Remove setDBinit from tests

Default is utf8 for the database-charset meanwhile.

Resolves: #87052
Releases: master
Change-Id: I4ec21f979a2b3e95ba30e10b94c538cde378b75d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59012
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
2 months ago[TASK] Remove leftover unused code in various PHP classes 20/60320/5
Benni Mack [Sat, 23 Mar 2019 21:49:37 +0000 (22:49 +0100)]
[TASK] Remove leftover unused code in various PHP classes

Due to removal of functionality and code in recent TYPO3 versions,
internal code can now be removed:

- PermissionAjaxController->getBackendUser()
- RteHtmlParser->TS_AtagToAbs (never called)
- PageRenderer->extOnReadyCode property
- SetupModuleController
  - used several properties from the now removed "simulateUser"
     code which is not part of this module anymore.
  - At the same time, various "init" and "main" methods which are now protected are
    reordered to reflect the set up request workflow better.

Resolves: #87991
Releases: master
Change-Id: I197a13ff64b3cb006730d09120d0bd8d5c5c65f0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60320
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
2 months ago[BUGFIX] Use live record uid for preview in workspace 70/55070/8
Christian Weiske [Tue, 26 Jun 2018 19:46:25 +0000 (21:46 +0200)]
[BUGFIX] Use live record uid for preview in workspace

When editing a record in a workspace in the Backend,
the "preview" button needs to use the live record uid
and not the uid of the workspace version.

Change-Id: I690c11e50b6275290175397cc9f28e1532b1d61d
Releases: master, 9.5
Resolves: #81271
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/55070
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 months ago[BUGFIX] Resolve and link modified slugs in workspaces properly 55/59955/6
Benni Mack [Sat, 9 Mar 2019 13:36:57 +0000 (14:36 +0100)]
[BUGFIX] Resolve and link modified slugs in workspaces properly

When a page (slug) is modified in a preview workspace,
links to that page need to be changed to the new slug, as the
preview (PageRouter) should evaluate this as well.

1) The PageRouter should include records with "-1"
to find them as well, but then fix the "pid" again to
find the pid of the online version.

2) The PageLink Builder now uses the SiteFinder nstead of SiteMatcher
to detect whether the linked page uid is part of a configured site.
We do not need to create/detect a PseudoSite here, only instances
of Site are of interest.

Resolves: #87871
Releases: master, 9.5
Change-Id: Ifd6add71bec1616049f8c6a50a42bc9f573395e2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59955
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
2 months ago[BUGFIX] Avoid cHash mismatches when previewing workspace changes 27/60327/2
Oliver Hader [Mon, 25 Mar 2019 10:09:40 +0000 (11:09 +0100)]
[BUGFIX] Avoid cHash mismatches when previewing workspace changes

In order to avoid cHash mismatches URL parameter 'ADMCMD_prev' is
not being used for cHash calculation anymore.

Resolves: #87995
Releases: master, 9.5
Change-Id: Ifefefc873478759a15aed786e16b062e28c739f9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60327
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
2 months ago[TASK] Add be_user id to LinkGenerator page-version test context 02/60302/4
Benjamin Franzke [Thu, 21 Mar 2019 08:10:38 +0000 (09:10 +0100)]
[TASK] Add be_user id to LinkGenerator page-version test context

Some of the previous todos were failing because the test context
contained a workspace id, but missed a backend user id.
In that case the workspace id was ignored by the test
framework (see TYPO3\JsonResponse\Middleware\BackendUserMiddleware).

This patch also adapts the SlugLinkGeneratorTest to check link
generation to versioned record both with and without a backend user
authentication.

Releases: master, 9.5
Resolves: #87973
Change-Id: I0a2ec41234963fd8af0ed3adf951f139f1e85215
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60302
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
2 months ago[!!!][TASK] Remove TCA option setToDefaultOnCopy 76/60276/6
Benni Mack [Sat, 16 Mar 2019 23:11:56 +0000 (00:11 +0100)]
[!!!][TASK] Remove TCA option setToDefaultOnCopy

This special setting resets a certain field to its default
value when copying. This option was only there for
resetting some sys_action values to default, which can
easily be achieved by a hook if needed.

The option is removed to reduce the amount of checks and
the amount of available options for edge-cases in TCA, as this
option was not widely used - as identified by the Persistence
Initiative.

Resolves: #87989
Releases: master
Change-Id: Iae05d958ff31f0f0c4618486445baad7e624b73b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60276
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[BUGFIX] Update topbar when switching BE language 21/60321/2
Benni Mack [Sat, 23 Mar 2019 21:53:54 +0000 (22:53 +0100)]
[BUGFIX] Update topbar when switching BE language

If a user switched his language settings in his preference,
the top bar is now also refreshed reflecting the language
change.

Resolves: #18117
Releases: master, 9.5
Change-Id: Ifdcd08c65f12ce1083521e93205964a2f77ca811
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60321
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 months ago[BUGFIX] Update SYS_LASTCHANGED for the right language page record 44/58944/6
Wolfgang Klinger [Sat, 24 Nov 2018 17:33:28 +0000 (18:33 +0100)]
[BUGFIX] Update SYS_LASTCHANGED for the right language page record

The register SYS_LASTCHANGED needs to reflect the
value of the translated page as well.

This is now done properly in a separate method.

Releases: master, 9.5
Resolves: #86963
Change-Id: Ieebd4207df03f3064c6e01d392a03ee253311f9b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/58944
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
2 months ago[TASK] Update typo3/testing-framework to 5.0.7 19/60319/2
Oliver Hader [Sat, 23 Mar 2019 21:01:26 +0000 (22:01 +0100)]
[TASK] Update typo3/testing-framework to 5.0.7

composer require --dev typo3/testing-framework:~5.0.7

Resolves: #87990
Releases: master
Change-Id: I15a44b7cc0db267f3e7e004feeee9cbe18061dc6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60319
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 months ago[TASK] Remove and streamline HMENU functionality 44/60244/5
Benni Mack [Wed, 13 Mar 2019 20:04:32 +0000 (21:04 +0100)]
[TASK] Remove and streamline HMENU functionality

HMENU was hardened during v9 via deprecations of
GMENU and making most of the properties protected.

Therefore, code can now refactored more easily.

- The method signatures for HMENU / TMENU are
streamlined.
- All leftover "RO" (RollOver) functionality is
removed (Breaking RST is already done but left-over
code was forgotten).
- Several GeneralUtility::inList() checks are replaced
with in_array()
- Some minor strict types for some internal obvious
methods
- use json_encode() instead of serialize()
for cache identifiers
- resolve some very very nested if() statements
- internal methods with "optional arguments" which
are always called with all arguments, are built
in a way that they are now non-optional.

Resolves: #87907
Releases: master
Change-Id: I80536b9b4dbc4609d38476c9ce48532fe71b73d0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60244
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
2 months ago[BUGFIX] Do not overwrite status code of received response 73/59873/3
Helmut Hummel [Tue, 5 Mar 2019 15:11:56 +0000 (16:11 +0100)]
[BUGFIX] Do not overwrite status code of received response

The ErrorController must not modify the received response
from the configured handler, to allow the handler to
change it to a suitable value.

Resolves: #87846
Releases: master, 9.5
Change-Id: I91d3ab0a78d383e5a0c9ee47ea21dc8634ddd3c9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59873
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Benni Mack <benni@typo3.org>
2 months ago[!!!][TASK] Remove support for "selicon_field_path" option 74/60274/8
Benni Mack [Sat, 16 Mar 2019 18:54:17 +0000 (19:54 +0100)]
[!!!][TASK] Remove support for "selicon_field_path" option

The TCA[ctrl][selicon_field_path] option is not necessary
anymore, as support for "internal_type=file" was dropped
for v10.0.

Resolves: #87937
Releases: master
Change-Id: Iae3493c3fe829feb5fff889f274dbab5f0049717
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60274
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Josef Glatz <josefglatz@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Josef Glatz <josefglatz@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
2 months ago[TASK] Allow TCA display conditions with only one element for AND/OR 10/60310/4
Markus Klein [Fri, 22 Mar 2019 14:57:00 +0000 (15:57 +0100)]
[TASK] Allow TCA display conditions with only one element for AND/OR

Resolves: #87986
Releases: master, 9.5
Change-Id: I9ccdbcae0c06a00fcd2904a203d1f3072b6e28ea
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60310
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Josef Glatz <josefglatz@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Reviewed-by: Josef Glatz <josefglatz@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
2 months ago[TASK] Add sql index for error counter in topbar 07/59707/4
Christoph Lehmann [Fri, 15 Feb 2019 13:45:50 +0000 (14:45 +0100)]
[TASK] Add sql index for error counter in topbar

The index reduces the sql query time and thus is a performance improvement.

On a table with 5 million rows the query time is ~ 38s without and less than 0.5s with the index

Resolves: #87723
Releases: master
Change-Id: I53b24ad0d09a2627a77720ec151dea30a14f5011
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59707
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
2 months ago[TASK] Remove @internal from ConnectionPool::resetConnections() 52/60252/7
Bernhard Sirlinger [Thu, 14 Mar 2019 19:52:41 +0000 (20:52 +0100)]
[TASK] Remove @internal from ConnectionPool::resetConnections()

The method ConnectionPool::resetConnections() is no longer annotated as
@internal. This reflects that it is necessary to reset connections in a
scheduler task spawning new child processes. This circumvents errors on
accessing a connection that has already been closed.

Resolves: #87111
Releases: master, 9.5
Change-Id: I3803073491766831e863635031c29a08585e7bf8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60252
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 months ago[BUGFIX] Re-enable target attribute for links in menus 92/60292/2
Benni Mack [Sun, 17 Mar 2019 11:10:09 +0000 (12:10 +0100)]
[BUGFIX] Re-enable target attribute for links in menus

The new pagelink builder does not set the lastTypoLinkLD options
which is used in HMENUs. The patch properly sets
the lastTypoLink* properties of ContentObjectRenderer in typolink
again, making target overrides in menus work again.

Resolves: #87130
Releases: master, 9.5
Change-Id: Ia284e546179dfaec8ec8ecb86a36d38f3b81aad8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60292
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
2 months ago[BUGFIX] Respect sorting in section menus 03/60303/3
Georg Ringer [Thu, 21 Mar 2019 10:55:21 +0000 (11:55 +0100)]
[BUGFIX] Respect sorting in section menus

The section menus must respect the sorting of content elements.

Resolves: #87975
Releases: master, 9.5
Change-Id: Ib6e785a74d7267edf5fdb1f310c47709f663ca99
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60303
Tested-by: Josef Glatz <josefglatz@gmail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Josef Glatz <josefglatz@gmail.com>
Reviewed-by: Wolfgang Klinger <wolfgang@wazum.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
2 months ago[BUGFIX] Mark input fields edited by datepicker as changed 00/60300/3
Daniel Goerz [Wed, 20 Mar 2019 15:42:08 +0000 (16:42 +0100)]
[BUGFIX] Mark input fields edited by datepicker as changed

Resolves: #87966
Releases: master, 9.5
Change-Id: Ia693015ece7b0ff3fb9f3d322b9914a1daf67b55
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60300
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
3 months ago[TASK] Harden \TYPO3\CMS\Extbase\Reflection\ClassSchema 77/60277/2
Alexander Schnitzler [Sun, 17 Mar 2019 08:15:18 +0000 (08:15 +0000)]
[TASK] Harden \TYPO3\CMS\Extbase\Reflection\ClassSchema

- Use strict type mode
- Use type hints whereever possible

Releases: master
Resolves: #87940
Change-Id: I3f349d1cbb4ceec408de7e5d18cd1f0fc5cf4c7b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60277
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] Ensure parse_str method argument is valid for BE shortcuts 39/60239/3
Joerg Kummer [Wed, 13 Mar 2019 16:04:26 +0000 (17:04 +0100)]
[BUGFIX] Ensure parse_str method argument is valid for BE shortcuts

When backend shortcut links get parsed, this change ensures that
parameter for returnUrl get only parsed, if it is set and not empty.

Resolves: #87903
Releases: master, 9.5
Change-Id: Ie8f380e9cdfef4440153f2095797a2dccc577d1c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60239
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
3 months ago[BUGFIX] Add additionalFields to cache identifier in getPageForRootline 63/60263/4
Wolfgang Klinger [Fri, 15 Mar 2019 16:13:20 +0000 (17:13 +0100)]
[BUGFIX] Add additionalFields to cache identifier in getPageForRootline

Otherwise, consecutive calls with additional fields given
will not return them.

Use md5 hash for the additionalFields in getPageForRootline and
BEgetRootLine.

Resolves: #87934
Releases: master, 9.5
Change-Id: I1720870ecb6920b06fa28a6ba8caf0522c50205c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60263
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
3 months ago[BUGFIX] Use renamed folder object in postRename signal 82/59882/3
Susanne Moog [Wed, 6 Mar 2019 12:02:13 +0000 (13:02 +0100)]
[BUGFIX] Use renamed folder object in postRename signal

The documentation states that the `emitPostFolderRename` signal
receives a reference to the renamed folder object. (see
https://docs.typo3.org/typo3cms/CoreApiReference/ApiOverview/Fal/Architecture/Signals.html)

The input of the signal has been adjusted to use the returned renamed
reference instead of the original folder to be renamed.

Resolves: #84539
Releases: master
Change-Id: Iceca142fce3293089b7603e211ba09f24746ca62
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59882
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Benjamin Franzke <bfr@qbus.de>
3 months ago[!!!][TASK] Remove TCA for sys_history 73/60273/4
Benni Mack [Sat, 16 Mar 2019 18:49:20 +0000 (19:49 +0100)]
[!!!][TASK] Remove TCA for sys_history

TCA for sys_history is not necessary at all anymore, and
can be removed.

It was previously used for creating an Extbase Domain Model
for the BELog module created in TYPO3 6.0/6.1.

However, in 9.0 sys_history was decoupled from sys_log,
whereas the Domain Model and the usages for TCA was
not necessary anymore.

The previously "generated" database fields are re-added
manually in ext_tables.sql. The field "pid" which was necessary
for a TCA table is now dropped.

Resolves: #87936
Releases: master
Change-Id: Ia541e9a5c7d85f25b6ff3ceb7e3ee311300762e6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60273
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
3 months ago[TASK] Harden \TYPO3\CMS\Extbase\Persistence\Generic\Mapper\ColumnMap 34/59634/4
Alexander Schnitzler [Mon, 4 Feb 2019 16:32:59 +0000 (17:32 +0100)]
[TASK] Harden \TYPO3\CMS\Extbase\Persistence\Generic\Mapper\ColumnMap

- Use strict type mode
- Use type hints whereever possible

Releases: master
Resolves: #87646
Change-Id: I5f05d7e89074ebcac39beef47e38e392e6c8ca26
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59634
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wolfgang Klinger <wolfgang@wazum.com>
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
3 months ago[TASK] Cleanup TYPO3/CMS/Backend/Notification 56/60256/3
Frank Naegler [Fri, 15 Mar 2019 10:41:33 +0000 (11:41 +0100)]
[TASK] Cleanup TYPO3/CMS/Backend/Notification

Cleanup the Notification.ts file:
- format code
- make optional parameter really optional
- import jquery as everywhere to get correct dependencies

Resolves: #87921
Releases: master
Change-Id: I819f0d7621537415b35a06337f8cd7dc42c5c1a7
Reviewed-on: https://review.typo3.org/c/60256
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
3 months ago[BUGFIX] Show typo3link module in ckeditor if href attribute is empty 68/60268/2
Georg Ringer [Sat, 16 Mar 2019 10:52:37 +0000 (11:52 +0100)]
[BUGFIX] Show typo3link module in ckeditor if href attribute is empty

Override the default link modal if href attribute is empty.

Resolves: #87790
Releases: master, 9.5
Change-Id: I728de276b4c61a47c34e305a7cea4ecbdf0e4bc2
Reviewed-on: https://review.typo3.org/c/60268
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Wolfgang Klinger <wolfgang@wazum.com>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Wolfgang Klinger <wolfgang@wazum.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
3 months ago[TASK] Show flash message if value is changed because unique value is required 73/58873/8
Georg Ringer [Thu, 8 Nov 2018 13:16:04 +0000 (14:16 +0100)]
[TASK] Show flash message if value is changed because unique value is required

If a TCA field is configured to be unique and the value changes
by the DataHandler, the user should be informed about the change.

Resolves: #85409
Releases: master
Change-Id: I133c107534c1568d8a6d869436c9438e7660e91d
Reviewed-on: https://review.typo3.org/c/58873
Reviewed-by: Wolfgang Klinger <wolfgang@wazum.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] Ensure result is string in __toString of CropVariantCollection 87/59887/2
Susanne Moog [Wed, 6 Mar 2019 17:57:59 +0000 (18:57 +0100)]
[BUGFIX] Ensure result is string in __toString of CropVariantCollection

CropVariantCollection returns output from json_encode in its __toString
method. Json_encode may return false if it fails to properly encode the
given data (mostly when non-UTF8 data is given). To ensure that no
exception is thrown to the user in that case, the __toString method
has been adjusted to return the same result as in the empty variants case.

Resolves: #79823
Releases: master, 9.5
Change-Id: Idfbdbbbd867251c8480a0729412dd6d652f57ee1
Reviewed-on: https://review.typo3.org/c/59887
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
3 months ago[BUGFIX] Prevent empty new form from being closed without confirmation 37/60237/2
Wolfgang Klinger [Wed, 13 Mar 2019 15:23:31 +0000 (16:23 +0100)]
[BUGFIX] Prevent empty new form from being closed without confirmation

Set ‘has-change’ on new empty content element form container
to trigger the confirmation dialog when using ‘Close’.

Resolves: #87890
Releases: master, 9.5
Change-Id: Idc3d8fdca0f865991ee09935f4b75683dffb4d7e
Reviewed-on: https://review.typo3.org/c/60237
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
3 months ago[TASK] Use native idn functionality 34/60234/7
Benni Mack [Wed, 13 Mar 2019 08:13:20 +0000 (09:13 +0100)]
[TASK] Use native idn functionality

It is safe to use idn_to_ascii() these days
due to symfony's polyfill functionality.

This allows us to remove the dependency
"algo26-matthias/idna-convert".

Also, all other places now use the native
idn_to_ascii() call, which could speed up
performance.

The wrapper call GeneralUtility::idnaEncode()
can then safely be deprecated.

used composer command:
  composer remove algo26-matthias/idna-convert

Resolves: #87894
Releases: master
Change-Id: I85aa6f39b8ff5ac171cd73218ed1144a56d9f724
Reviewed-on: https://review.typo3.org/c/60234
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
3 months ago[BUGFIX] Do not send empty scheduler status mails 74/60174/2
Guido Schmechel [Mon, 11 Mar 2019 23:47:13 +0000 (00:47 +0100)]
[BUGFIX] Do not send empty scheduler status mails

Due to a missing initialization, the status providers were not filled
in the status report in the scheduler task. The providers are now
initialized in the constructor and can now always be used.

Resolves: #87555
Releases: master, 9.5
Change-Id: Ia9b02b13061775ce297f6d2881ce8332c9714591
Reviewed-on: https://review.typo3.org/c/60174
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
3 months ago[BUGFIX] Rename PageParameterValidator to PageArgumentValidator 61/60261/2
Markus Klein [Fri, 15 Mar 2019 15:29:19 +0000 (16:29 +0100)]
[BUGFIX] Rename PageParameterValidator to PageArgumentValidator

This patch renames the remaining usages of class PageParameterValidator
to PageArgumentValidator.

Resolves: #87932
Releases: master, 9.5
Change-Id: Ia8d8651b5caddcaa6df846007d37b8ea542e771f
Reviewed-on: https://review.typo3.org/c/60261
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 months ago[TASK] Replace bool properties in ClassSchema with a BitSet 26/59626/5
Alexander Schnitzler [Sun, 3 Feb 2019 17:16:57 +0000 (18:16 +0100)]
[TASK] Replace bool properties in ClassSchema with a BitSet

Instead of using multiple properties that hold bool flags,
ClassSchema now holds all flags in a single BitSet property.

This drastically reduces the size of the class schemata cache
file, as a lot of properties no longer need to be serialized.

Releases: master
Resolves: #87631
Change-Id: I12b2d8a2f4e481d55b1f57ce00bfede599b4cb32
Reviewed-on: https://review.typo3.org/c/59626
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
3 months ago[TASK] Extract ValidatorClassNameResolver from ValidatorResolver 52/59952/4
Alexander Schnitzler [Sat, 9 Mar 2019 10:23:14 +0000 (10:23 +0000)]
[TASK] Extract ValidatorClassNameResolver from ValidatorResolver

The ValidatorResolver contained a method for resolving validator
class names. Extbase supports various shorthand notations to
make the life of developers more easy. There are notations like:

- NotEmpty
- TYPO3.CMS.Extbase:NotEmpty
- CustomExtension:ValidatorName

Resolving these notations takes place in a dedicated
ValidatorClassNameResolver class now.

Releases: master
Resolves: #87868
Change-Id: Ib0d57127a0e1dc4ae0536a8e76ca497f6d2bd56d
Reviewed-on: https://review.typo3.org/c/59952
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 months ago[TASK] Move language labels to correct extension(s) 92/60092/4
Susanne Moog [Mon, 11 Mar 2019 12:43:45 +0000 (13:43 +0100)]
[TASK] Move language labels to correct extension(s)

The filelist module contained labels solely used in different extensions,
for example "sys_file_storage.*" labels which was only used by the `core` extension.
Those labels have been moved to their corresponding parent extension.

This patch is a prerequisite for making filelist uninstallable and part
one of decoupling the filelist module. For more information see the
Epic.

Related: #87878
Resolves: #87879
Releases: master
Change-Id: I4954f9e8c45866ce34f387ec637b347b0d681bd8
Reviewed-on: https://review.typo3.org/c/60092
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>