Packages/TYPO3.CMS.git
15 months ago[TASK] Provide AcceptanceTest for stand alone install tool 45/61945/12
Anja Leichsenring [Thu, 10 Oct 2019 14:59:29 +0000 (16:59 +0200)]
[TASK] Provide AcceptanceTest for stand alone install tool

A simple test asserting the login and logout mechanics for
the stand alone install tool are functional.
Cards in the maintenance page received basic checks
ensuring no Javascript errors occur.

Additionally, typo3/testing-framework will be raised, so the
new tests gets integrated into the automatic bamboo run.
Used update command:
composer update typo3/testing-framework

Resolves: #89393
Resolves: #89397
Releases: master
Change-Id: I1eb916405dec682fa57ee07794d892b1fc6255ab
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61945
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
15 months ago[TASK] Warn in [SYS][UTF8filesystem] that a valid UTF-8 locale is necessary 94/61894/3
Christian Eßl [Sat, 5 Oct 2019 15:56:43 +0000 (17:56 +0200)]
[TASK] Warn in [SYS][UTF8filesystem] that a valid UTF-8 locale is necessary

Add a small warning in the "Configure Installation-Wide Options" modal
for [SYS][UTF8filesystem], that warns users about the fact, that a valid
UTF-8 compatible locale string is necessary as well, in order to not
produce weird bugs when handling files with special characters.

Resolves: #89351
Releases: master
Change-Id: If5def1660e7d223e0a23204ec129386141900307
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61894
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Julian Geils <j_geils@web.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
15 months ago[BUGFIX] Reset user settings if an invalid selection is stored 58/61958/2
Frank Naegler [Fri, 11 Oct 2019 12:42:27 +0000 (14:42 +0200)]
[BUGFIX] Reset user settings if an invalid selection is stored

In the case that an old setting exists an exception was shown in
the reports module, because makeInstance was called without
a valid class name.
Now the backend user settings for the last selection are removed
and the user is redirected to the overview.

Resolves: #88228
Releases: master, 9.5
Change-Id: I9bd0ad4e04087f5ff7b55adfb169003a7ee42eab
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61958
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
15 months ago[TASK] Adjust composer.json declarations of system extensions 44/61944/2
Oliver Hader [Thu, 10 Oct 2019 14:34:54 +0000 (16:34 +0200)]
[TASK] Adjust composer.json declarations of system extensions

In order to compatible with https://getcomposer.org/doc/04-schema.md
composer.json declarations had to be adjusted and dropped previous
replace statements like this:

"replace": {
    "core": "*"
}

Resolves: #89392
Releases: master, 9.5, 8.7
Change-Id: I4d530fe90551b16c54462a81a457d0bff9f2de8b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61944
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Simon Gilli <typo3@gilbertsoft.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Felix P. <f.pachowsky@neusta.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[BUGFIX] Make Modal.loadUrl working again 35/61935/3
Frank Naegler [Wed, 9 Oct 2019 12:29:16 +0000 (14:29 +0200)]
[BUGFIX] Make Modal.loadUrl working again

With the migration to TypeScript (#82596) a regression was merged.
This patch fix the broken loadUrl method of the Modal module.

Resolves: #89253
Related: #82596
Releases: master, 9.5
Change-Id: Id84a0a2a6299daca819ef0304678a6ab25b5955b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61935
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Kevin Ditscheid <kevinditscheid@gmail.com>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Julian Geils <j_geils@web.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[BUGFIX] Add tests and fix broken MailMessage 08/61908/7
Frank Naegler [Tue, 8 Oct 2019 11:44:13 +0000 (13:44 +0200)]
[BUGFIX] Add tests and fix broken MailMessage

This patch add tests for the MailMessage class and fix broken
functionality since migration to Symfony Mailer.

Resolves: #89083
Related: #88643
Releases: master
Change-Id: Ieb7616aa24cee26505d0e2260a26b56713caebc1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61908
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
15 months ago[BUGFIX] Prevent broken AND where statement in cObj->searchWhere() 92/61892/5
Christian Eßl [Sat, 5 Oct 2019 10:58:32 +0000 (12:58 +0200)]
[BUGFIX] Prevent broken AND where statement in cObj->searchWhere()

If searchWhere() in ContentObjectRenderer is called with search words
that are smaller than 3 characters in length, a broken " AND " where
statement will be returned, that, if put inside a database query, would
lead to a fatal error. In such a case, return an empty string to prevent addWhere call.

Resolves: #87620
Releases: master, 9.5
Change-Id: Ib75b2fe8f20fb5b3c956976ff7aae014d0eb784e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61892
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Julian Geils <j_geils@web.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Julian Geils <j_geils@web.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
15 months ago[BUGFIX] Allow multiple search words for file search 04/61704/2
Markus Klein [Fri, 13 Sep 2019 21:25:56 +0000 (23:25 +0200)]
[BUGFIX] Allow multiple search words for file search

This functionality was removed with the refactoring of
the search API in FAL and is therefore restored.

Resolves: #89168
Releases: master, 9.5
Change-Id: Ic39340c6ec6858355302757adefd1fb94dbc9e47
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61704
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Felix P. <f.pachowsky@neusta.de>
Tested-by: Julian Geils <j_geils@web.de>
Tested-by: Steffen Frese <steffenf14@gmail.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Felix P. <f.pachowsky@neusta.de>
Reviewed-by: Julian Geils <j_geils@web.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
15 months ago[BUGFIX] Fix preprocessing of external URLs in linkvalidator 10/61910/7
Sybille Peters [Tue, 8 Oct 2019 16:49:05 +0000 (18:49 +0200)]
[BUGFIX] Fix preprocessing of external URLs in linkvalidator

Fix the preprocessing of external URLs that was originally
introduced to handle domains with special characters (conversion
to punycode). The previous functionality had the unintended side
effect of truncating some URLs to empty strings and leading to
falsely reported broken links.

Resolves: #89378
Releases: master, 9.5
Change-Id: Ifbca076342fd04d758d2dd1a2ae2f7487751d58c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61910
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Tested-by: Julian Geils <j_geils@web.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Felix P. <f.pachowsky@neusta.de>
Reviewed-by: Julian Geils <j_geils@web.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
15 months ago[BUGFIX] Add missing quotation mark in doc example 42/61942/2
Jörg Kummer [Thu, 10 Oct 2019 13:18:09 +0000 (13:18 +0000)]
[BUGFIX] Add missing quotation mark in doc example

Fix syntax in php example for documented deprecation

Releases: master
Resolves: #89391
Change-Id: I77b7aaf9f717050c672151f35b8287393e5167dc
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61942
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
15 months ago[TASK] Adjust search syntax for suggest wizard 03/61703/3
Markus Klein [Fri, 13 Sep 2019 21:36:16 +0000 (23:36 +0200)]
[TASK] Adjust search syntax for suggest wizard

Use double quotes for exact phrases and space as delimiter
for multiple words/phrases.

Also allow to search for numbers.

Resolves: #89170
Releases: master, 9.5
Change-Id: I5346e8fb54946c5dc4c415507b6c773f0854afbd
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61703
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Steffen Frese <steffenf14@gmail.com>
Tested-by: Felix P. <f.pachowsky@neusta.de>
Tested-by: Julian Geils <j_geils@web.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Felix P. <f.pachowsky@neusta.de>
Reviewed-by: Julian Geils <j_geils@web.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
15 months ago[TASK] Future-proof Fluid template namespace imports 32/61932/3
Claus Due [Wed, 9 Oct 2019 09:32:59 +0000 (11:32 +0200)]
[TASK] Future-proof Fluid template namespace imports

Corrects Fluid templates which use a space around the
equals sign in namespace imports - a notation which
will not be supported with Fluid 3.0. Has no effect on
current Fluid versions so is only a future-proofing fix.

Resolves: #89380
Releases: master, 9.5, 8.7
Change-Id: I800b6b3419cca5ac7cc5b14fa06f62a39a36764b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61932
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Felix P. <f.pachowsky@neusta.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Felix P. <f.pachowsky@neusta.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
15 months ago[TASK] Give better info about no records 02/61902/6
Pascal Querner [Mon, 7 Oct 2019 12:38:42 +0000 (14:38 +0200)]
[TASK] Give better info about no records

This patch adds a better info text when no records of a specific type
don't exist, instead of giving the generic answer "no records exists on
this page" (which may not be true).

Resolves: #88985
Releases: master, 9.5
Change-Id: I780e845a0c224815e710cf8246e407198a1e6cb0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61902
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <look@susi.dev>
15 months ago[BUGFIX] Reload backend module menu after extension configuration change 33/61933/4
Frank Naegler [Wed, 9 Oct 2019 10:15:51 +0000 (12:15 +0200)]
[BUGFIX] Reload backend module menu after extension configuration change

Resolves: #83713
Releases: master, 9.5
Change-Id: I407d179f2354e97c79112c122e46c8f39804ef37
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61933
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <look@susi.dev>
15 months ago[BUGFIX] Add pre access check to install tool 37/61937/5
Frank Naegler [Wed, 9 Oct 2019 14:47:24 +0000 (16:47 +0200)]
[BUGFIX] Add pre access check to install tool

If Install Tool is locked or access is not granted, silent configuration
update is not called.

Resolves: #89385
Releases: master, 9.5
Change-Id: Ib529c2b84c627990d0ec51a5e860f2ea9c6519e8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61937
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
15 months ago[BUGFIX] Set tasks backend:lock & backend:unlock as not schedulable 38/61938/2
Georg Ringer [Thu, 10 Oct 2019 03:19:07 +0000 (05:19 +0200)]
[BUGFIX] Set tasks backend:lock & backend:unlock as not schedulable

The tasks `backend:lock` and `backend:unlock` must only be triggered
by commandline and not via backend as this doesn't make any sense.
Any admin would disable his own account by locking via backend and there
is no chance to unlock it again.

Resolves: #89387
Releases: master, 9.5
Change-Id: Ief460cfc033b555e77869b22b61b05c57a27d1a7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61938
Tested-by: Christian Eßl <indy.essl@gmail.com>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Tested-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Christian Eßl <indy.essl@gmail.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
15 months ago[BUGFIX] Show exception in linkvalidator report 09/61909/2
Sybille Peters [Tue, 8 Oct 2019 16:08:09 +0000 (18:08 +0200)]
[BUGFIX] Show exception in linkvalidator report

For \GuzzleHttp\Exception\RequestException the exception message
is now shown as well (as for the other exceptions). This makes
it easier to interpret the error messages as this exception may
be thrown for a number of reasons, such as not existing domain,
problem with SSL certificate etc.

Resolves: #89376
Releases: master, 9.5
Change-Id: If5cd24e35afdbdede37379fab4055eff84933f48
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61909
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Julian Geils <j_geils@web.de>
Tested-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Tested-by: Steffen Frese <steffenf14@gmail.com>
Tested-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Julian Geils <j_geils@web.de>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Felix P. <f.pachowsky@neusta.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Susanne Moog <look@susi.dev>
15 months ago[BUGFIX] Hide edit link for records the user has no edit permissions for 32/61832/2
Christian Eßl [Wed, 25 Sep 2019 17:18:47 +0000 (19:18 +0200)]
[BUGFIX] Hide edit link for records the user has no edit permissions for

tt_content records that were translated in "free mode" are still visible
to users in the list view, even if they don't have editing permissions
for the language, but should remain non-editable. The edit button in the
control button is correctly removed in this scenario, however the link
on the record title itself was still visible. When clicking this edit
link, the backend editor would see the error "ERROR: Language was not
allowed." This is now solved by removing this link if the editor has no
access to the record.

Resolves: #89261
Releases: master, 9.5, 8.7
Change-Id: I5b2ba9590a56d9120af43a823fb717960c751931
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61832
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Julian Geils <j_geils@web.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Michael Semle <michael.semle@b13.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Julian Geils <j_geils@web.de>
Reviewed-by: Felix P. <f.pachowsky@neusta.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
15 months ago[BUGFIX] Generate unique id for checkboxes in flexform sections 11/61911/3
Georg Ringer [Wed, 9 Oct 2019 01:30:23 +0000 (03:30 +0200)]
[BUGFIX] Generate unique id for checkboxes in flexform sections

Use a checksum of the element's name as additional identifier to generate
an unique id for checkboxes in flexform sections.

Resolves: #89092
Releases: master, 9.5
Change-Id: I57075aba05c8de23cbdacfff3a05b63eb71499c9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61911
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Tested-by: Christian Eßl <indy.essl@gmail.com>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Eßl <indy.essl@gmail.com>
Reviewed-by: Julian Geils <j_geils@web.de>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Armin Vieweg <armin@v.ieweg.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[TASK] Update list of external libraries 95/61895/2
Christian Eßl [Sat, 5 Oct 2019 19:01:08 +0000 (21:01 +0200)]
[TASK] Update list of external libraries

The list of external libraries in the backend is not up to date.
The following changes were made:

- Remove Swiftmailer.
- Add several Symfony packages that have been missing.
- Some of the listed jQuery libraries are not jQuery libraries.

Resolves: #89352
Releases: master
Change-Id: If95d936a64a2ef670a1adb0453a768422f9f9287
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61895
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Steffen Frese <steffenf14@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
15 months ago[BUGFIX] Check for access permissions to record in context menu 33/61833/2
Christian Eßl [Wed, 25 Sep 2019 17:38:56 +0000 (19:38 +0200)]
[BUGFIX] Check for access permissions to record in context menu

When clicking the context menu of a record, only show the edit link if
the editor has all necessary access permissions to this record.

Resolves: #89279
Releases: master, 9.5, 8.7
Change-Id: I856197b377bdb869a3eb6b0989cd827b4554369a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61833
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Michael Semle <michael.semle@b13.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
15 months ago[BUGFIX] Fix "Show" link in the context menu of page translations 87/61887/3
Christian Eßl [Fri, 4 Oct 2019 18:05:28 +0000 (20:05 +0200)]
[BUGFIX] Fix "Show" link in the context menu of page translations

In the list module, when opening the context menu of a
"Page Translation" record, a "Show" link will be shown, which is
supposed to open the page in the frontend with the correct language.
However this link was broken, because the PageProvider class didn't
respect page translations at all.

Resolves: #56351
Releases: master, 9.5
Change-Id: I46800ac912d5a964b236c615099a0537227baf82
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61887
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
15 months ago[BUGFIX] Prevent 500 Internal server error in flexform 05/61905/2
Frank Naegler [Tue, 8 Oct 2019 07:13:40 +0000 (09:13 +0200)]
[BUGFIX] Prevent 500 Internal server error in flexform

Resolves: #89358
Releases: master, 9.5
Change-Id: I0bbffe2a45c5b241338a19033d5cc1181e0f16df
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61905
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Felix P. <f.pachowsky@neusta.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
15 months agoRevert "[BUGFIX] Provide UpgradeWizard for outdated be_users uc settings" 17/61917/2
Daniel Goerz [Tue, 8 Oct 2019 08:00:45 +0000 (10:00 +0200)]
Revert "[BUGFIX] Provide UpgradeWizard for outdated be_users uc settings"

This reverts commit e8b5652d5a2a9c16d628804387dbff32dcb68f5f.

The patch was not ready yet and needs further polishing.

Change-Id: Ief7c57d33f3e4b0c864403460ef1f1b53ca3f5b0
Resolves: #89367
Releases: master
Reverts: #89269
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61917
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
15 months ago[BUGFIX] Provide UpgradeWizard for outdated be_users uc settings 74/61874/3
Christian Eßl [Wed, 2 Oct 2019 19:07:21 +0000 (21:07 +0200)]
[BUGFIX] Provide UpgradeWizard for outdated be_users uc settings

Backend users each have a serialized array of individual user
configuration, called "uc" persisted in the be_users table.
Before TYPO3 9.5, the structure of this configuration could sometimes
contain stdClass objects, which is no longer supported. Logging in as
a backend user with such an outdated "uc" array would then crash several
parts of the TYPO3 backend, because the BackendUserConfiguration class
will try to access an stdClass type configuration like an array.

An UpgradeWizard called "BackendUserConfigurationUpdate" is now
provided, which allows to update any outdated "uc" structure of all
backend users.

Resolves: #89269
Resolves: #89268
Resolves: #86398
Releases: master, 9.5
Change-Id: I57c57e9e745cf5cabdc2f10d645816d3958e2a0d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61874
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
15 months ago[BUGFIX] Reset belog search constraints on memory exhaustion 78/61878/4
Christian Eßl [Thu, 3 Oct 2019 15:03:12 +0000 (17:03 +0200)]
[BUGFIX] Reset belog search constraints on memory exhaustion

If a backend user uses the search in belog with no boundaries or sets a
custom date limit with boundaries that are too wide, the script
execution will experience a "Allowed memory of ... exhausted ..."
fatal error in PHP.

Because the search constraints are saved in the backend users uC
nonetheless, any further effort to access the belog module would result
in a fatal error, thus making it unusable.

This patch makes the belog module detect, if the script execution fails
because of an exhausted memory and reset the search constraints to its
initial values.

Resolves: #89256
Releases: master, 9.5
Change-Id: I08f60399aed3a209cf98f5b33e311d22288e05ce
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61878
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Steffen Frese <steffenf14@gmail.com>
Tested-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Julian Geils <j_geils@web.de>
Tested-by: Felix <f.pachowsky@neusta.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Julian Geils <j_geils@web.de>
Reviewed-by: Felix <f.pachowsky@neusta.de>
15 months agoRevert "[TASK] Keep old value on confirmation modal close" 13/61913/2
Oliver Hader [Mon, 7 Oct 2019 16:21:15 +0000 (18:21 +0200)]
Revert "[TASK] Keep old value on confirmation modal close"

This reverts commit c529deacba10349c588014696c0ac59334e9ac68.

The patch only addressed a single use-case. In favour of a more
generic approach mentioned change has been reverted.

Reverts: #89220
Resolves: #89362
Releases: master, 9.5
Change-Id: I30900d1b80268b263a47ba1c261904f7caa63710
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61913
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
15 months ago[TASK] Show peak memory usage in MB 98/61898/7
Christoph Lehmann [Sun, 6 Oct 2019 21:19:52 +0000 (23:19 +0200)]
[TASK] Show peak memory usage in MB

For better readability, the peak memory usage is now converted to
megabytes.

Resolves: #89354
Releases: master, 9.5
Change-Id: I530a9b80432944a8381853c2489a395814bd3e9f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61898
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Julian Geils <j_geils@web.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Julian Geils <j_geils@web.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
15 months ago[TASK] Replace FrontendCacheInterface 71/61871/4
Christian Fries [Tue, 1 Oct 2019 09:02:11 +0000 (09:02 +0000)]
[TASK] Replace FrontendCacheInterface

Replace inexistent FrontendCacheInterface by FrontendInterface

Releases: master
Resolves: #89321
Change-Id: I961dcbd752b4437d5360c7d0e081920734021e21
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61871
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
15 months ago[BUGFIX] Allow public access to DataHandler $historyRecords info 58/61858/8
Christoph Lehmann [Sun, 29 Sep 2019 16:06:53 +0000 (18:06 +0200)]
[BUGFIX] Allow public access to DataHandler $historyRecords info

DataHandler hooks do not have an concrete view of what really changed.

Releases: master,9.5
Resolves: #89303
Change-Id: I62ceb7a3daa2a5544c5813ae11b4dad98801e35b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61858
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Steffen Frese <steffenf14@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Siepmann <daniel.siepmann@typo3.org>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
15 months ago[BUGFIX] AbstractSubModule implements ContentProviderInterface by default 02/61102/7
Jan Stockfisch [Thu, 20 Jun 2019 17:11:17 +0000 (19:11 +0200)]
[BUGFIX] AbstractSubModule implements ContentProviderInterface by default

Because all submodules must implement the interface anyway, it's now
implemented by default in the AbstractSubModule. Without implementing
an InvalidArgumentException is thrown.

Resolves: #88598
Releases: master,9.5
Change-Id: I72f764a5fca63d85fb501ddcecc27bfc849b63bb
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61102
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Steffen Frese <steffenf14@gmail.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
15 months ago[DOCS] Adjust path to Page TSconfig 57/61857/3
Chris Müller [Sun, 29 Sep 2019 14:47:42 +0000 (16:47 +0200)]
[DOCS] Adjust path to Page TSconfig

Adjust the recommended path to Page TSconfig according to
https://docs.typo3.org/m/typo3/reference-coreapi/master/en-us/ExtensionArchitecture/FilesAndLocations/Index.html#reserved-folders

Resolves: #89302
Releases: master, 9.5
Change-Id: I325cb8fc3ee4c4f45b8462938331e2498f0da3d5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61857
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Daniel Siepmann <daniel.siepmann@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Daniel Siepmann <daniel.siepmann@typo3.org>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
15 months ago[BUGFIX] Add additional headers for checking external links 11/61811/10
Sybille Peters [Wed, 25 Sep 2019 15:51:56 +0000 (17:51 +0200)]
[BUGFIX] Add additional headers for checking external links

This addresses some problems that were reported on checking
external links.

Resolves: #86918
Releases: master, 9.5
Change-Id: I8e84791a4d140e3cec40c012d54077fa84f48aa0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61811
Tested-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Julian Geils <j_geils@web.de>
Tested-by: Steffen Frese <steffenf14@gmail.com>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Julian Geils <j_geils@web.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
15 months ago[BUGFIX] Fix several typos in php comments 45/61845/4
Christian Eßl [Thu, 26 Sep 2019 19:37:36 +0000 (21:37 +0200)]
[BUGFIX] Fix several typos in php comments

Make spelling in TYPO3 great again.

Resolves: #89290
Releases: master
Change-Id: I520840dd0774aa5d658ce6a45811aa6282c9e461
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61845
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
15 months ago[TASK] Use node v12 to build assets 99/61899/3
Andreas Fernandez [Mon, 7 Oct 2019 09:04:59 +0000 (11:04 +0200)]
[TASK] Use node v12 to build assets

The minimum node version is raised to v12. This patch also updates the
upgrade task of runTests.sh to fetch new JS containers.

Resolves: #89357
Releases: master
Change-Id: Icf8a5af0791fffa483f0a970b83ae548f77885e5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61899
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[TASK] Deprecate legacy FormEngine functions 72/61872/10
Andreas Fernandez [Wed, 2 Oct 2019 06:24:58 +0000 (08:24 +0200)]
[TASK] Deprecate legacy FormEngine functions

This patch deprecates the last remaining legacy functions in FormEngine:

- setFormValueOpenBrowser()
- setFormValueFromBrowseWin()
- setHiddenFromList()
- setFormValueManipulate()
- setFormValue_getFObj()

Additionally, a call to the undefined function `group_change` has been
removed.

Resolves: #89331
Releases: master
Change-Id: Ie7419ed0581b92c37afd0614ca78287ffe286016
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61872
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
15 months ago[BUGFIX] Fix TypeScript path in Grunt watcher 82/61882/4
Andreas Fernandez [Fri, 4 Oct 2019 07:38:52 +0000 (09:38 +0200)]
[BUGFIX] Fix TypeScript path in Grunt watcher

Resolves: #89343
Releases: master
Change-Id: I1c14b46923c21bbe8547bc9a40bcabbecef67bb6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61882
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
15 months ago[BUGFIX] Escape url parameters in tree rendering 89/61889/2
Markus Klein [Fri, 4 Oct 2019 22:09:22 +0000 (00:09 +0200)]
[BUGFIX] Escape url parameters in tree rendering

This enables navigation in the Configuration module for tree
nodes having url-sensitive characters in the name, like a hash (#).

Resolves: #89333
Releases: master, 9.5
Change-Id: I7279778914f4165b8c8c6437fe68be1b60f52b79
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61889
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
15 months ago[TASK] Fill original attribute properly 77/61877/2
Georg Ringer [Thu, 3 Oct 2019 07:02:29 +0000 (09:02 +0200)]
[TASK] Fill original attribute properly

The attribute original should be filled with a useful information
instead of dummy value "messages".

This string is also shown in Crowdin and helps users while translating.

Resolves: #89336
Releases: master, 9.5
Change-Id: I35a48083edd35b00f6ec91b3e1c4cb07985c76f9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61877
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[TASK] Add resname attribute to trans-unit tags in XLF files 76/61876/3
Markus Klein [Thu, 3 Oct 2019 06:30:02 +0000 (08:30 +0200)]
[TASK] Add resname attribute to trans-unit tags in XLF files

Crowdin doesn't show the information stored in the attribute "id".
If we want to have that visible, the attribute must be duplicated using
"resname".

find typo3/ -name '*.xlf' -exec sed -i -e \
    '/resname/!s/\(<trans-unit id="\)\([^"]*\)"/\1\2" resname="\2"/' \
    '{}' +

Resolves: #89335
Releases: master, 9.5
Change-Id: I73de72a8bf4a837347a69183088c212d0a958d74
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61876
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[TASK] Fix typo and formatting in documentation for #84545 73/61873/4
Tymoteusz Motylewski [Wed, 2 Oct 2019 08:28:25 +0000 (10:28 +0200)]
[TASK] Fix typo and formatting in documentation for #84545

* Fix typo in folder name.
* Format lists properly.
* Add missing text roles.

Resolves: #89329
Releases: master, 9.5
Change-Id: I0b48404729dca49c4049dfb7b83c5248b887f791
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61873
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[TASK] Add configuration for Crowdin 46/61846/4
Georg Ringer [Thu, 26 Sep 2019 20:26:44 +0000 (22:26 +0200)]
[TASK] Add configuration for Crowdin

Crowdin requires a basic configuration which defines where the
XLIFF files and their translations are located. The configuration is used
by the GitHub integration which is offered by Crowdin itself.
See https://support.crowdin.com/github-integration/ for more information
about that.

Even though the translations will not be pushed back to the GitHub
repository of TYPO3 (as pull requests), the "translation" property is
required as the manual export of translations will use it.

Resolves: #89281
Releases: master, 9.5
Change-Id: I1a5f94b416a0652081976bcdbd9ea7d61fb202dc
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61846
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
15 months ago[TASK] Set TYPO3 version to 10.2.0-dev 70/61870/2
Oliver Hader [Tue, 1 Oct 2019 08:19:41 +0000 (10:19 +0200)]
[TASK] Set TYPO3 version to 10.2.0-dev

Change-Id: I81e89208e45b689b32f5c8df2392e8c2b24b8392
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61870
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[RELEASE] Release of TYPO3 10.1.0 69/61869/2 v10.1.0
Oliver Hader [Tue, 1 Oct 2019 08:18:06 +0000 (10:18 +0200)]
[RELEASE] Release of TYPO3 10.1.0

Change-Id: I6491f0abe1148a2fbea8b37709dd16b071657b35
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61869
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[BUGFIX] Adjust visibility of IRRE controls 68/61868/3
Andreas Fernandez [Tue, 1 Oct 2019 06:42:09 +0000 (08:42 +0200)]
[BUGFIX] Adjust visibility of IRRE controls

Previously, if constraints in an IRRE container were met, the control
container's visibility has been toggled. However, the PHP backend
defines the visibility per control item.

The JavaScript now toggles the visibility per control as well and does
not hide the container anymore.

Resolves: #89319
Releases: master
Change-Id: Ia0a70f98997b714ce8caedf549060601ff91a1d3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61868
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[BUGFIX] Re-implement record deletion via EditDocumentController 65/61865/3
Andreas Fernandez [Mon, 30 Sep 2019 15:35:07 +0000 (17:35 +0200)]
[BUGFIX] Re-implement record deletion via EditDocumentController

The change of #89033 removed the callback for deleting records within
EditDocumentController, resulting in JavaScript errors.

This patch adds the delete action again, directly implemented in the
FormEngine module. The URL to delete the record is pre-built as well,
since any required information is already known.

Resolves: #89315
Related: #89033
Releases: master
Change-Id: I842d0119291b53be3cdc3b2d6373ccd474fc7146
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61865
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[BUGFIX] Streamline site configuration import in distribution packages 64/61864/5
Oliver Hader [Mon, 30 Sep 2019 12:19:19 +0000 (14:19 +0200)]
[BUGFIX] Streamline site configuration import in distribution packages

Site configuration shipped in distribution packages had a couple of flaws
during import process which are tackled with this change:

* existing site configurations for same identifier are not overridden on
  the file system level anymore (according warning is logged)
* site configuration is now updated and mapped to for imported pages,
  which did not work before due to hard-coded rootPageId in config.yaml
  (warning is logged in case root page id cannot be mapped)

Resolves: #89314
Releases: master
Change-Id: I856024afb50186eb9f6cc73ef13f1961c948c784
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61864
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[BUGFIX] Pass SiteFinder to RedirectService instance 66/61866/2
Andreas Fernandez [Mon, 30 Sep 2019 17:22:14 +0000 (19:22 +0200)]
[BUGFIX] Pass SiteFinder to RedirectService instance

The patch for #89317 extended the RedirectService, but didn't adjust all
constructors. In this case, IntegrityService was forgotten and didn't
pass a SiteFinder to the RedirectService.

This patch now passes the SiteFinder instance.

Resolves: #89317
Related: #88877
Releases: master
Change-Id: I1758dc8549cf5f58c7dbaf1475d10288af86316b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61866
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[BUGFIX] Prevent auto-fill in user setup 62/61862/3
Frank Naegler [Mon, 30 Sep 2019 09:29:56 +0000 (11:29 +0200)]
[BUGFIX] Prevent auto-fill in user setup

This patch adds the correct value for autocomplete on password field.

Reference: https://developer.mozilla.org/en-US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion#Preventing_autofilling_with_autocompletenew-password

Resolves: #89310
Releases: master, 9.5, 8.7
Change-Id: Ib1a805ddc5e8da14380d9cf7e5b188a67ed54fea
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61862
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
15 months ago[BUGFIX] Manage Language Packs: Render empty column if language pack is downloaded 37/61837/5
Andreas Fernandez [Thu, 26 Sep 2019 08:06:22 +0000 (10:06 +0200)]
[BUGFIX] Manage Language Packs: Render empty column if language pack is downloaded

If a language pack is available for an extension, the matrix now renders
an empty column to fix wrong positioning of the actual download buttons.

Resolves: #89283
Releases: master, 9.5
Change-Id: I100a0c8f4a4db3ed03f86e2fb71c95ec9448b3bb
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61837
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Richard Haeser <richard@maxserv.com>
15 months ago[BUGFIX] Render correct preview link in page module 13/61713/3
Georg Ringer [Tue, 17 Sep 2019 06:43:55 +0000 (08:43 +0200)]
[BUGFIX] Render correct preview link in page module

If a page is translated and a translation is selected in the columns module of the
page module, the view webpage button must show the translation instead of
the default language.

Resolves: #89184
Releases: master, 9.5
Change-Id: Ib1c21a99a706e298300e355e6675839275361e28
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61713
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
15 months ago[BUGFIX] Load Clearable in system configuration 61/61861/2
Andreas Fernandez [Mon, 30 Sep 2019 09:24:02 +0000 (11:24 +0200)]
[BUGFIX] Load Clearable in system configuration

Resolves: #89309
Related: #89215
Releases: master
Change-Id: I6994039d5c2e7d99224336ecfd66a14b0580feac
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61861
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
15 months ago[TASK] Move changelog files into 10.1 folder 44/61844/10
Anja Leichsenring [Thu, 26 Sep 2019 15:37:54 +0000 (17:37 +0200)]
[TASK] Move changelog files into 10.1 folder

Preparation for TYPO3 10.1 release, all changelog files
are reviewed, adjusted and moved to the corresponding versioning folder

Change-Id: Ibafd4c05b0ec1684da4bfbc21f608916f4a3375d
Releases: master
Resolves: #89289
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61844
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[TASK] Update grunt and friends 07/61807/2
Andreas Fernandez [Wed, 25 Sep 2019 13:31:56 +0000 (15:31 +0200)]
[TASK] Update grunt and friends

This patch updates grunt and plugins to their latest version.

Executed command:

  yarn upgrade --pattern grunt --latest

Resolves: #89270
Releases: master
Change-Id: Ibc830d62115ba369afa15c459e93053985726c29
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61807
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
15 months ago[FEATURE] Auto slug update and redirect creation on slug change 13/61613/50
Frank Naegler [Sat, 28 Sep 2019 13:51:54 +0000 (15:51 +0200)]
[FEATURE] Auto slug update and redirect creation on slug change

If EXT:redirects is installed and a slug is updated by a backend user,
a redirect from the old URL to the new URL will be created.
All sub pages are checked too and the slugs will be updated.

Resolves: #89115
Releases: master
Change-Id: Id0b09cb22681aa6b2704b4f7cbc47d8b747e56d4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61613
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[BUGFIX] Correctly unpack CorrelationId version 56/61856/2
Oliver Hader [Sat, 28 Sep 2019 16:57:51 +0000 (18:57 +0200)]
[BUGFIX] Correctly unpack CorrelationId version

Resolves: #89299
Releases: master
Change-Id: Ib4e63b7baadb604ca77469e66af5bc060f79a8f6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61856
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[TASK] Introduce CorrelationId model 55/61855/4
Oliver Hader [Sat, 28 Sep 2019 13:52:16 +0000 (15:52 +0200)]
[TASK] Introduce CorrelationId model

Resolves: #89298
Releases: master
Change-Id: Icb2d406d8ba3759c8f999966fc68b8e31b046c01
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61855
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[BUGFIX] Ensure correct site is used when redirecting 38/61838/4
Andreas Fernandez [Thu, 26 Sep 2019 09:20:27 +0000 (11:20 +0200)]
[BUGFIX] Ensure correct site is used when redirecting

The RedirectService recives a NullSite instance from the current
request. This patch checks whether the redirect target is a page and
fetches its site configuration to be able to create a proper TSFE
instance.

Also, the TSFE instance now does not fetch any template configuration
anymore as it is rather extraneous for a redirect.

Resolves: #88877
Releases: master
Change-Id: If0463d3ad9e8af47950f001c8646dc8a15b6a02b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61838
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[BUGFIX] Enable link fields with softref url or email 07/61707/5
Lina Wolf [Fri, 13 Sep 2019 19:40:08 +0000 (21:40 +0200)]
[BUGFIX] Enable link fields with softref url or email

Enables checking of links in fields that have softrefs "url" or "email"
in their TCA configuration.

This is achieved by passing parameter that enables the 'subst' part of
the softref to SoftReferenceIndex::findRef

While SoftReferenceIndex::findRef_typolink and findRef_typolink_tag
automatically enable the 'subst' part SoftReferenceIndex::findRef_email
and findRef_url only do so if enabled via configuration.

Resolves: #52912
Releases: master, 9.5, 8.7
Change-Id: I98176d27d129aa0f67a8ad94747d1374873c6e34
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61707
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Sybille Peters <sypets@gmx.de>
Tested-by: Jonas Götze <jonnsn@gmail.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Simon Gilli <typo3@gilbertsoft.org>
Reviewed-by: Jonas Götze <jonnsn@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
15 months ago[BUGFIX] Page preview respects language fallbacks 41/61841/3
Benni Mack [Thu, 26 Sep 2019 11:16:18 +0000 (13:16 +0200)]
[BUGFIX] Page preview respects language fallbacks

When a default language page is hidden, it should also be visible
when a translated page is rendered but not available.

The current "simple" check to only check for a specific language
to find out if a page is hidden, is wrong, as l18n_cfg could be built
in a way that a page translation (language>0) does not exist, but
the default record is actually available.

This change overcomes a long-standing issue that
translations of hidden pages can be previewed.

Resolves: #89130
Releases: master, 9.5
Change-Id: I8bc8f1e55a07b680c7b7b9591ec2936d50840548
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61841
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Tobias Gaertner <tobias.gaertner@benaja-websolutions.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
15 months ago[BUGFIX] Load clearable module in recycler 43/61843/2
Andreas Fernandez [Thu, 26 Sep 2019 13:29:11 +0000 (15:29 +0200)]
[BUGFIX] Load clearable module in recycler

It was forgotten to load the new clearable module in the recycler
module.

Resolves: #89288
Related: #89215
Releases: master
Change-Id: I35f0e7b3d63112faf0c3fcfba7719141673856e6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61843
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
15 months ago[FEATURE] Add support for RecordHistory correlation ids in DataHandler 48/61848/4
Frank Naegler [Fri, 27 Sep 2019 09:25:36 +0000 (11:25 +0200)]
[FEATURE] Add support for RecordHistory correlation ids in DataHandler

Resolves: #89292
Related: #89143
Releases: master
Change-Id: Ie10bcbfca7f43a60b80a2a6634759584043c7cf4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61848
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[BUGFIX] Fix regression due to Doctrine DBAL refactoring 47/61847/2
Benni Mack [Fri, 27 Sep 2019 09:10:18 +0000 (11:10 +0200)]
[BUGFIX] Fix regression due to Doctrine DBAL refactoring

As added in change 6ef46cab02f754d0809daf751ec3385021ab9387
see https://review.typo3.org/c/Packages/TYPO3.CMS/+/49530/, the RelationHandler
works on deleted elements ON ALL OTHER workspaces instead of
the current one, as the SQL query does a "neq", but prior did a "wsid=".

Resolves: #89291
Related: #77565
Releases: master, 9.5, 8.7
Change-Id: Ide82a779f1f4ba3daa064243361b9a370198d958
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61847
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.com>
Reviewed-by: Benni Mack <benni@typo3.org>
15 months agoRevert "[FEATURE] Read site setting file and populate them with the site object" 17/61817/4
Anja Leichsenring [Wed, 25 Sep 2019 16:56:51 +0000 (18:56 +0200)]
Revert "[FEATURE] Read site setting file and populate them with the site object"

This reverts commit 0e70168d7aa74bd7e1f686952db731e239a6e86e.

Reason for revert: postponed to after 10.1

Change-Id: Ib1655e4f31f0fb620943a34f2361806a0fb47e0a
Releases: master
Resolves: #89278
Reverts: #89102
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61817
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
15 months agoRevert "[TASK] Edit Site Settings in Site Module" 16/61816/2
Anja Leichsenring [Wed, 25 Sep 2019 16:54:48 +0000 (18:54 +0200)]
Revert "[TASK] Edit Site Settings in Site Module"

This reverts commit 4989d5af6e37fc9083742c43fed105bb8cd3750e.

Reason for revert: once more after 10.1.
Resolves: #89277
Reverts: #89134
Releases: master

Change-Id: Id9486bf090db83f080c502ffbd36fd5f3c5d2ac4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61816
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
15 months ago[TASK] Move documentation of #86577 into correct folder 39/61839/2
Andreas Fernandez [Thu, 26 Sep 2019 09:43:06 +0000 (11:43 +0200)]
[TASK] Move documentation of #86577 into correct folder

The patch related to #86577 has been merged into v10 and v9, but the
ReST file was created in the wrong directory. This patch moves the file
into `9.5.x`.

Resolves: #89286
Related: #86577
Releases: master, 9.5
Change-Id: Ie4e55331ee4f01bfabe69da95d5f620522a826ce
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61839
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
15 months agoRevert "[TASK] Avoid slow array functions in loops" 15/61815/3
Anja Leichsenring [Wed, 25 Sep 2019 16:37:53 +0000 (18:37 +0200)]
Revert "[TASK] Avoid slow array functions in loops"

This reverts commit e531ddce9a6874e5ad289ae58f6474565dab9218.

Reason for revert: immature merge

Change-Id: Ia31248587537a502ffdfc84761bacd7095999642
Resolves: #89276
Reverts: #89056
Releases: master
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61815
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[TASK] Fix CGL violation in FileList 35/61835/2
Benjamin Franzke [Thu, 26 Sep 2019 04:11:06 +0000 (06:11 +0200)]
[TASK] Fix CGL violation in FileList

https://review.typo3.org/c/Packages/TYPO3.CMS/+/57414 introduced
a CGL violation that was not discovered because the patchset was
pushed on 8th of august and was checked with php-cs-fixer 2.14.1
on bamboo where no violation was found.

In the meantime (between push and merge of the mentioned patch)
https://review.typo3.org/c/Packages/TYPO3.CMS/+/61564 has been
merged, which updates php-cs-fixer to 2.15.2 and contains new
rules.

Releases: master
Resolves: #89282
Related: #57414
Related: #85425
Change-Id: I61d5e6e5dc61b500fe620e59002f296f50f03214
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61835
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
16 months ago[TASK] Update CodeMirror to 5.49.0 08/61808/2
Andreas Fernandez [Wed, 25 Sep 2019 13:39:02 +0000 (15:39 +0200)]
[TASK] Update CodeMirror to 5.49.0

This patch updates CodeMirror to version 5.49.0.

Executed command:

  yarn add --dev codemirror@^5.49.0

Resolves: #89272
Releases: master, 9.5
Change-Id: I59b2808e5c363380628a247147faf4cae2a661fd
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61808
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
16 months ago[FEATURE] Allow additional file processors 88/61088/13
Tim Schreiner [Tue, 18 Jun 2019 17:37:13 +0000 (19:37 +0200)]
[FEATURE] Allow additional file processors

Allow registration of additional file processors.

Resolves: #88602
Releases: master
Change-Id: Iff5594ce07750e557f2dc316f3e8aacd90cf5c81
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61088
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
16 months ago[TASK] Keep old value on confirmation modal close 71/61771/10
Harald Atteneder [Sat, 21 Sep 2019 19:09:14 +0000 (21:09 +0200)]
[TASK] Keep old value on confirmation modal close

When changing the doktype a confirmation modal appears. This patch
reverts the value of the field to the original value after closing the
modal without clicking *OK*.

This works for all selects with 'onChange' => 'reload' and
'renderType' => 'selectSingle'

Resolves: #89220
Releases: master,9.5
Change-Id: I6d479f9180d64e8e4c25e96f52e60dca36863fd9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61771
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
16 months ago[BUGFIX] Provide error messages in install tool mail settings test 02/61802/2
Oliver Hader [Tue, 24 Sep 2019 17:55:29 +0000 (19:55 +0200)]
[BUGFIX] Provide error messages in install tool mail settings test

In order to identify problems with sending out mails, more specific
error messages than "Something went wrong" are used.

Resolves: #89254
Releases: master, 9.5
Change-Id: I61d8b122f7af764cfd5be0b08b27c99cd4fd56e0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61802
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
16 months ago[BUGFIX] Load language labels in RecordProvider 92/61692/6
Andreas Fernandez [Thu, 12 Sep 2019 07:30:46 +0000 (09:30 +0200)]
[BUGFIX] Load language labels in RecordProvider

The generic RecordProvider used for context menus now explicitly loads
the language labels for the modals.

Resolves: #89151
Releases: master, 9.5
Change-Id: If4368f507a0432606298fd5b17b05bf7c665d1d8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61692
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
16 months ago[FEATURE] Add data type in QueryBuilder::set with createNamedParameter 27/61327/4
Manuel Selbach [Fri, 19 Jul 2019 12:24:48 +0000 (14:24 +0200)]
[FEATURE] Add data type in QueryBuilder::set with createNamedParameter

With this change it is possible to define the type of the value if the
createNamedParameter option is set.

Releases: master
Resolves: #88805
Change-Id: I964d8fadf5d3e6512d8585c2bbd84e0b14c9d274
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61327
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Manuel Selbach <manuel_selbach@yahoo.de>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
16 months ago[BUGFIX] Check permissions on copy actions 14/57414/9
Guido Schmechel [Thu, 28 Jun 2018 19:43:16 +0000 (21:43 +0200)]
[BUGFIX] Check permissions on copy actions

No copy link in the context menu or the button
in the file list is displayed, when the user lacks the permission
to copy file or folder.

Resolves: #85425
Releases: master, 9.5
Change-Id: I442d17e04a87eb25a438c2c2e7f22aef70492061
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/57414
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
16 months ago[TASK] Improve loops in TypeScript 53/61653/6
Andreas Fernandez [Tue, 10 Sep 2019 06:41:24 +0000 (08:41 +0200)]
[TASK] Improve loops in TypeScript

This patch improves the loops in TypeScript by using `for (... of ...)`
and incorporating ES7 features as `Object.entries()` and
`Object.values()`.

Resolves: #89262
Releases: master
Change-Id: I4f4300a2e241bcd34494ae0b0d400e589ad702da
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61653
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
16 months ago[TASK] Avoid slow array functions in loops 83/59083/10
Andreas Fernandez [Tue, 11 Dec 2018 08:57:09 +0000 (09:57 +0100)]
[TASK] Avoid slow array functions in loops

This patch moves some array functions used in loops (array_merge,
array_replace) out of their calling loop for performance reasons, where
applicable.

This this achieved by calling the functions via array unpacking ("splat
operator").

See for further reading:
https://github.com/kalessil/phpinspectionsea/blob/master/docs/performance.md#slow-array-function-used-in-loop

Resolves: #89056
Releases: master
Change-Id: Ia21b1909f77879918b84c6fa702f07a41149e83f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59083
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
16 months ago[TASK] Use correct file ending for documentation mention 89/61789/4
Michael Binder [Wed, 25 Sep 2019 08:33:10 +0000 (10:33 +0200)]
[TASK] Use correct file ending for documentation mention

To avoid confusing users, a uniform way of referencing YAML files in
the documentation is used.

Releases: master
Resolves: #89237
Change-Id: Id03be5dbc17a174fafc4c188a298369834ef4a39
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61789
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
16 months ago[TASK] Make infobox for shortcut pages more helpful 10/61710/8
Oliver Bartsch [Mon, 16 Sep 2019 06:28:22 +0000 (08:28 +0200)]
[TASK] Make infobox for shortcut pages more helpful

Add proper information for the user about the target page.

In case the target page doesn't exist or is not accessible
in the frontend, the infobox in the page module now states this out.

Resolves: #89121
Releases: master, 9.5
Change-Id: Ie4d5b208028fa960e34dec64c546a2e5ebb1de05
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61710
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
16 months ago[FEATURE] Introduce Broadcast Messaging 88/61788/6
Oliver Hader [Mon, 23 Sep 2019 18:31:29 +0000 (20:31 +0200)]
[FEATURE] Introduce Broadcast Messaging

This change introduces BroadcastChannel in order to communicate between
frames. Messages are converted to according CustomEvents that can be
handled individually. Event handling happens in the most specific scope
on client side.

A polyfill to support Edge has been installed, executed command:

  yarn add broadcastchannel-polyfill

Resolves: #89244
Releases: master
Change-Id: Iab55bf78ff9324d19d115022464c24eea1b8b78e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61788
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
16 months ago[FEATURE] Toggle page menu visibility via context menu 83/57983/21
Gianluigi Martino [Tue, 21 Aug 2018 11:28:43 +0000 (13:28 +0200)]
[FEATURE] Toggle page menu visibility via context menu

Add a context menu entry to enable or disable the option "Page
enabled in menus".

Resolves: #85918
Releases: master
Change-Id: Ib821846fd78dafee9fc51df6d07148844e613a72
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/57983
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
16 months ago[TASK] Remove left-over clear_all_cache code from TS module controller 04/61804/2
Benjamin Franzke [Wed, 25 Sep 2019 06:50:52 +0000 (08:50 +0200)]
[TASK] Remove left-over clear_all_cache code from TS module controller

The frontend part that issued the GET parameter clear_all_cache=1 was
removed in 2008 with the following commit:
https://github.com/TYPO3/TYPO3.CMS/commit/94fb08233d

The handling of this unused parameter is therefore removed.

Releases: master
Resolves: #89257
Change-Id: I4d248d388fb8efdb11df9eb7fd6d976338fa65d1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61804
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
16 months ago[TASK] Use ESLint as base for linting 84/61784/8
Andreas Fernandez [Mon, 23 Sep 2019 14:20:44 +0000 (16:20 +0200)]
[TASK] Use ESLint as base for linting

TSLint is in a deprecation phase, recommending to migrate to ESLint
instead. This patch removes all TSLint packages and supplies a proper
ESLint configuration.

Also, rule violations are fixed in this patch.

Executed commands:

  yarn add --dev typescript-eslint \
    @typescript-eslint/parser \
    @typescript-eslint/eslint-plugin \
    eslint grunt-eslint

  yarn remove tslint grunt-tslint

  ./node_modules/.bin/eslint -c eslintrc.js --fix --ext .ts \
    ./Sources/TypeScript/

Resolves: #89232
Releases: master
Change-Id: I3bd4a1c30ecc27f8c334951547aff5e9352629da
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61784
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
16 months ago[TASK] Update CSS tooling 00/61800/2
Andreas Fernandez [Tue, 24 Sep 2019 15:33:22 +0000 (17:33 +0200)]
[TASK] Update CSS tooling

This patch updates some CSS tools to the current version and creates new
CSS builds.

Executed commands:

  yarn add --dev node-sass \
    grunt-stylelint@^0.11.0 \
    grunt-sass@^3.1.0 \
    stylefmt@^6.0.0 \
    autoprefixer@^9.6

  yarn upgrade --pattern postcss --latest

This patch also updates the list of supported browsers, raising minimum
iOS version and dropping Internet Explorer completely.

Resolves: #89251
Releases: master
Change-Id: I5e87a94184b2fe76c57b602266bebbc2c43390de
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61800
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
16 months ago[BUGFIX] Render "Admin Tools" icon in Install Tool as inline SVG 98/61798/3
Andreas Fernandez [Tue, 24 Sep 2019 13:31:15 +0000 (15:31 +0200)]
[BUGFIX] Render "Admin Tools" icon in Install Tool as inline SVG

Resolves: #89250
Related: #89206
Releases: master
Change-Id: Ic865c7610f84674e9a3c06a2e01e67e9adb2fc25
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61798
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
16 months ago[BUGFIX] Don't make clearable button tabbable 94/61794/3
Andreas Fernandez [Tue, 24 Sep 2019 12:39:40 +0000 (14:39 +0200)]
[BUGFIX] Don't make clearable button tabbable

The clearable button now has a `tabindex="-1"` attribute to disallow
focussing it via <TAB>.

Resolves: #89248
Related: #89215
Releases: master
Change-Id: I8bd637461d7c1e3b8ff51aa3a588a497787b0185
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61794
Tested-by: Nicole Cordes <typo3@cordes.co>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
16 months ago[TASK] Add scroll-padding to .module-body 70/61770/4
Harald Atteneder [Sat, 21 Sep 2019 16:59:33 +0000 (18:59 +0200)]
[TASK] Add scroll-padding to .module-body

This fixes the small annoyance when expanding an item in the
TypoScript Object Browser and the iframe reloads and scrolls to the
expanded item while the doc-header hides this item. CSS scroll-padding
solves this problem for modern browsers.

Resolves: #89217
Releases: master,9.5
Change-Id: If4b71c7fb6ba003b23cdd79460540f0bf335abb8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61770
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
16 months ago[FEATURE] Add Cache Preset to Maintenance Area Settings 75/61075/5
Benni Mack [Mon, 17 Jun 2019 15:05:27 +0000 (17:05 +0200)]
[FEATURE] Add Cache Preset to Maintenance Area Settings

On various mass hostings, it is sometimes more useful to switch
to file-based caching to speed up performance, as
SSD usages has improved.

In order to help non-experts to set up proper caching for their
most common use-cases, a Preset in the "Maintenance -> Settings"
for Caching has been added.

Resolves: #89229
Releases: master
Change-Id: Icd953937cce36d793b6c16ee518449049fca31df
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61075
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
16 months agoRevert "[FEATURE] PHP API for backend JavaScript notifications" 51/61751/4
Andreas Fernandez [Tue, 24 Sep 2019 10:38:24 +0000 (12:38 +0200)]
Revert "[FEATURE] PHP API for backend JavaScript notifications"

This reverts commit deca7432d45225d1f4c00bd8fd7f05e3d7a0773d.

The PHP API is considered insecure as whole blocks of JavaScript are
manually written into the PageRenderer.

Change-Id: I8cd69cb9238b187ed6d6343548adf03a4c2bb464
Resolves: #89246
Reverts: #89066
Releases: master
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61751
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
16 months agoRevert "[BUGFIX] Generate notification action on rendering" 50/61750/4
Andreas Fernandez [Tue, 24 Sep 2019 10:35:16 +0000 (12:35 +0200)]
Revert "[BUGFIX] Generate notification action on rendering"

This reverts commit 78955a67c7da23c839757b4509f11c637e5e88bb.

The approach uses `eval` that is considered insecure.

Change-Id: I6f6f1b7040dc9ed6b93c115983a2124752ae0327
Resolves: #89247
Reverts: #89173
Releases: master
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61750
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
16 months ago[FEATURE] Show configuration of USER_INT objects in adminpanel 45/61045/4
c.essl [Sun, 16 Jun 2019 09:20:05 +0000 (11:20 +0200)]
[FEATURE] Show configuration of USER_INT objects in adminpanel

Introduces a new panel in the info module of the admin panel which lists
the basic configuration of each USER_INT present on the current page.

Resolves: #88441
Releases: master
Change-Id: Iedc4112c7ff961995d70622beec1c7256f78c1ce
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61045
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
16 months ago[TASK] Remove unused signal/slot in EM site setup 91/61791/2
Benni Mack [Tue, 24 Sep 2019 08:56:44 +0000 (10:56 +0200)]
[TASK] Remove unused signal/slot in EM site setup

A new signal was added with https://review.typo3.org/c/Packages/TYPO3.CMS/+/61554
which has no effect and with the provided information
is not needed. If necessary, a new PSR-14 event should
 be invoked at that place.

The patch removes the signal again.

Resolves: #89242
Related: #89010
Releases: master
Change-Id: I383e39ced7d9b88303aa13a98c48ca5242e82739
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61791
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
16 months ago[FEATURE] Add email address to installation process 89/60889/7
Benni Mack [Thu, 6 Jun 2019 05:42:49 +0000 (07:42 +0200)]
[FEATURE] Add email address to installation process

New installations now ask for the email address as well, so
this can be used later on to e.g. notify the admin if somebody
logged-in (Warning email address).

The same feature is available in the maintenance module of
the Install Tool in the "Create Administrative User" card.

Resolves: #89227
Releases: master
Change-Id: Iafca7043543d5e299fb121d96d9b3b9caa375bc9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60889
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
16 months ago[BUGFIX] Generate valid export url for files in filelist 03/61503/3
Andreas Fernandez [Fri, 16 Aug 2019 08:01:14 +0000 (10:01 +0200)]
[BUGFIX] Generate valid export url for files in filelist

Since FAL is in place, the export url for files generated in the
clipboard is broken as it takes the full file identifier. Previously it
took the physical file path, the code was never adjusted to be
compatible with FAL.

This patch now resolves the file identifier and generates proper
arguments for export.

Resolves: #88969
Releases: master, 9.5, 8.7
Change-Id: I6599114b19b9d173f88db7beefabe39e90520899
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61503
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
16 months ago[TASK] Remove unused property in Extbase DataMapper 90/61790/2
Benni Mack [Tue, 24 Sep 2019 07:42:05 +0000 (09:42 +0200)]
[TASK] Remove unused property in Extbase DataMapper

Extbase's DataMapper added a $pageSelectObject (PageRepository) as property
in 2009 but it was never used due to further abstractions into the DbBackend
of Extbase.

The protected property is unneeded and can safely be removed,
as it is never initialized or used since at least TYPO3 4.5.

Resolves: #89238
Releases: master
Change-Id: I9f88b6421e20f23eeeccd7861082fb169ebbce98
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61790
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
16 months ago[FEATURE] Provide implementation for PSR-18 HTTP Client 67/61567/8
Benjamin Franzke [Tue, 27 Aug 2019 12:49:19 +0000 (14:49 +0200)]
[FEATURE] Provide implementation for PSR-18 HTTP Client

The implementation of the PSR-18 ClientInterface is provided
as an adapter to the existing GuzzleHTTP Client. Therefore
existing configuraton settings will be reused.

As our current Guzzle wrapper (RequestFactory->request)
has support for passing custom guzzle per-request options,
we do not deprecate this method but add the PSR-18 implementation
as a more generic alternative.

Once GuzzleHTTP supports PSR-18 natively we can (and will)
drop our adapter and point to Guzzles native implementation
in our dependency injection configuration.
Therefore, this adapter is marked as internal and extensions
are being instructed to depend on the PSR-18 interfaces
only.

composer require psr/http-client:^1.0

Releases: master
Resolves: #89216
Change-Id: I0f2c81916a2f5e4b40abd6f0b146440ef155cf00
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61567
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
16 months ago[FEATURE] Create sites on page creation 58/61658/20
Andreas Fernandez [Tue, 10 Sep 2019 13:18:25 +0000 (15:18 +0200)]
[FEATURE] Create sites on page creation

A new hook is introduced that creates a site configuration when a new
page on root level is created. This takes effect for pages of type
"default", "link" and "shortcut".

To reduce the likelihood for conflicts, a shortened MD5 hash of the page
id appended to the site identifier.

Resolves: #89142
Releases: master
Change-Id: Ibe2957e3789f2a165e36949ae5fb4fa2a1a572df
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61658
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
16 months ago[TASK] Remove PhantomJS dependencies 87/61787/3
Andreas Fernandez [Mon, 23 Sep 2019 16:56:51 +0000 (18:56 +0200)]
[TASK] Remove PhantomJS dependencies

This patch removes extraneous npm packages. They were
required for PhantomJS and are currently unused.

Executed command:

  yarn remove karma-phantomjs-launcher phantomjs-prebuilt

Resolves: #89233
Releases: master
Change-Id: Ic754873a01a687da6b133702c7a682da349d859a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61787
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
16 months ago[TASK] Add functional tests for linkvalidator 12/61712/12
Sybille Peters [Mon, 16 Sep 2019 16:10:54 +0000 (18:10 +0200)]
[TASK] Add functional tests for linkvalidator

Resolves: #82850
Releases: master, 9.5
Change-Id: I05dc5e83199d58b23a8da6e625d1b9557b5c57a2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61712
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
16 months ago[TASK] Update JavaScript unit test packages 81/61781/3
Andreas Fernandez [Mon, 23 Sep 2019 12:40:44 +0000 (14:40 +0200)]
[TASK] Update JavaScript unit test packages

Executed commands:

  yarn upgrade --pattern jasmine --latest
  yarn upgrade --pattern karma --latest

Resolves: #89228
Releases: master
Change-Id: Id4f32730cbbebe74e07101bb1fed8e420d4a67aa
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61781
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>