Packages/TYPO3.CMS.git
4 months ago[TASK] Migrate TYPO3/CMS/Opendocs/OpendocsMenu to TypeScript 92/59692/4
Frank Naegler [Wed, 13 Feb 2019 10:55:55 +0000 (11:55 +0100)]
[TASK] Migrate TYPO3/CMS/Opendocs/OpendocsMenu to TypeScript

Resolves: #87703
Releases: master
Change-Id: Ie44d5feae31b8c4cf64c621d12a42d6f7e6d574e
Reviewed-on: https://review.typo3.org/c/59692
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Replace IRC with Slack in composer support section 05/59705/2
Tomas Norre Mikkelsen [Fri, 15 Feb 2019 10:25:13 +0000 (11:25 +0100)]
[TASK] Replace IRC with Slack in composer support section

Remove reference to irc as it is not used anymore. Linking
to Slack instead.

Resolves: #87720
Releases: master, 9.5, 8.7
Change-Id: I7dea0d62329e8e361b8ac37a1d18b9f9f8603943
Reviewed-on: https://review.typo3.org/c/59705
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Harden \TYPO3\CMS\Extbase\Object\Container\Container 01/59601/4
Alexander Schnitzler [Thu, 31 Jan 2019 20:17:00 +0000 (21:17 +0100)]
[TASK] Harden \TYPO3\CMS\Extbase\Object\Container\Container

- Use strict type mode
- Use type hints whereever possible

Releases: master
Resolves: #87606
Change-Id: I8dfdb347beca5468da1b8cb2f8a05ec7dbf4418a
Reviewed-on: https://review.typo3.org/c/59601
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Missing quote in declaring the task example 81/59681/2
Phillip Schallmayer [Mon, 11 Feb 2019 14:31:10 +0000 (15:31 +0100)]
[TASK] Missing quote in declaring the task example

The current declaring a task example produces a PHP syntax error because
of a missing quote

Releases: master
Resolves: #87690
Change-Id: Idbff9169488d30d986787e82bf0774e4908f23f5
Reviewed-on: https://review.typo3.org/59681
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] EXT:opendocs - Remove bogus initial document count 08/59708/2
Andreas Fernandez [Fri, 15 Feb 2019 16:15:22 +0000 (17:15 +0100)]
[BUGFIX] EXT:opendocs - Remove bogus initial document count

When the opendocs toolbar item gets initialized, the document count shows
a bogus value as deleted records are not removed from the calculation.

As the documents are loaded deferred since #84412, the correct value gets
in place automatically which renders the initial counting obsolete and is
removed with this patch.

Additonally, a wrong class hint in OpenDocumentController is fixed.

Resolves: #87725
Related: #84412
Releases: master, 9.5
Change-Id: I0684e0950d0f4daf11042d6c078b5598bfb3d4be
Reviewed-on: https://review.typo3.org/59708
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
4 months ago[BUGFIX] Have stdWrap.lang use Site concept 98/59698/4
Benni Mack [Thu, 14 Feb 2019 08:57:33 +0000 (09:57 +0100)]
[BUGFIX] Have stdWrap.lang use Site concept

When building TypoScript like this:

10 = TEXT
10.value = English
10.lang.dk = danish

This does not work currently as it relies on "config.language". This part
has been forgotten while the Site Handling was initially implemented into
the TYPO3 core.

The patch adapts the changes to make use of Site Handling if it is available,
but falls back to the TypoScript options (for PseudoSites).

Resolves: #87712
Releases: master, 9.5
Change-Id: I5e2b97b178e6ccafec1ff7556d41321ea67fb45a
Reviewed-on: https://review.typo3.org/59698
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[DOCS] Document rte_ckeditor 27/59627/11
Sybille Peters [Sun, 3 Feb 2019 20:18:08 +0000 (21:18 +0100)]
[DOCS] Document rte_ckeditor

Resolves: #85461
Releases: master, 9.5, 8.7
Change-Id: I36eef1d24fce233639e2047cc2f09d972ccbe046
Reviewed-on: https://review.typo3.org/59627
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Allow type 'check' in site configuration 83/59683/4
Julian Wundrak [Mon, 11 Feb 2019 20:42:51 +0000 (21:42 +0100)]
[TASK] Allow type 'check' in site configuration

Add check option to site-config tca for something like active or
maintenance mode
Resolves: #87692
Releases: master, 9.5
Change-Id: Idaa09a5929db5bdf177e57c5f78f827047705f91
Reviewed-on: https://review.typo3.org/59683
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: André Schließer <andy.schliesser@gmail.com>
Tested-by: André Schließer <andy.schliesser@gmail.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[BUGFIX] Add missing interface to AdminPanel Cache Module 88/59688/3
Frank Naegler [Wed, 13 Feb 2019 08:32:03 +0000 (09:32 +0100)]
[BUGFIX] Add missing interface to AdminPanel Cache Module

The AdminPanel Cache Module has to implement the
ResourceProviderInterface to load the required JavaScript module.

Resolves: #87701
Releases: master, 9.5
Change-Id: Ib8c440bc5847da64aad480dc98adda7b440f4bf9
Reviewed-on: https://review.typo3.org/59688
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 months ago[BUGFIX] Cast lastMod property to int 82/59682/4
Richard Haeser [Mon, 11 Feb 2019 19:24:39 +0000 (20:24 +0100)]
[BUGFIX] Cast lastMod property to int

To prevent type mismatches when using pdo_mysql as the database driver,
the data for the lastMod field is cast to an integer.

Resolves: #87689
Releases: master, 9.5
Change-Id: I696f62a3b08d464708c9e1ab9edb4c733835f475
Reviewed-on: https://review.typo3.org/59682
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: André Schließer <andy.schliesser@gmail.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[BUGFIX] Simplify if in typolink 85/59685/2
Stefan Froemken [Tue, 12 Feb 2019 15:29:20 +0000 (16:29 +0100)]
[BUGFIX] Simplify if in typolink

Resolves: #87696
Releases: master
Change-Id: I50eb442bc2130ed5a0741ea3f71558257535ff89
Reviewed-on: https://review.typo3.org/59685
Reviewed-by: Pascal Rinker <info@crynton.com>
Tested-by: Pascal Rinker <info@crynton.com>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Raise php-cs-fixer version 77/59677/4
Benni Mack [Mon, 11 Feb 2019 05:36:40 +0000 (06:36 +0100)]
[TASK] Raise php-cs-fixer version

Used
 * composer update friendsofphp/php-cs-fixer --with-all-dependencies

The new php-cs-fixer is compatible with PHP7.3+ and fixes
some more issues configured according to our code style settings.

Resolves: #87684
Releases: master, 9.5
Change-Id: Ibb2150eea173ded11495866aa171dd171aca7efd
Reviewed-on: https://review.typo3.org/59677
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Update doctrine/dbal to ~2.8.0 68/59668/10
Benni Mack [Sun, 30 Sep 2018 23:06:46 +0000 (01:06 +0200)]
[TASK] Update doctrine/dbal to ~2.8.0

doctrine/dbal 2.7.x will reach end of life before core
v9 is out of support. We should upgrade to at least 2.8:

composer req doctrine/dbal:~2.8.0

https://www.doctrine-project.org/2018/07/12/common-2-9-and-dbal-2-8-and-orm-2-6-2.html

Also needs a typo3/testing-framework raise:

composer req --dev typo3/testing-framework:~5.0.5

Needed core changes:
- DBAL does not add "OFFSET 0" if nothing given (test change only)
- SQLite does not need "PRIMARY KEY" if autoincrement is given (in DefaultTcaSchema)

Resolves: #86490
Releases: master, 9.5
Change-Id: I28014d252a57f7f421242e35086c63a0a824ed04
Reviewed-on: https://review.typo3.org/59668
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Keep language reference for children using l10n_mode=exclude 29/59629/8
Oliver Hader [Mon, 4 Feb 2019 12:51:37 +0000 (13:51 +0100)]
[BUGFIX] Keep language reference for children using l10n_mode=exclude

Having 1:n child associations being defined as l10n_mode=exclude on their
parent side, currently leads to deleting and recreating the child entity
(re-synchronization). For composite relations (children can only exist
with their parent - usually accessed through their parent as aggregate
root) this is "okay" in terms of domain-driven design.

However having large data-sets leads to performance impact during the
re-synchronization process.

In the current scenario children processed with l10n_mode=exclude did not
have any pointer to their language origin (due to l10n_parent not being
set). This change copies these children and applies the same values as
used for localizations - without actually invoking the localization
process.

For l10n_mode=exclude children this means, the sys_language_uid and
l10n_parent values are now set - which have been empty before.

Resolves: #87640
Releases: master, 9.5
Change-Id: I3d862f536603b9e49c7a5d3205ccfc2b4e2e9532
Reviewed-on: https://review.typo3.org/59629
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Allow strings in site configuration type "select" 49/59649/2
Georg Ringer [Wed, 6 Feb 2019 07:49:47 +0000 (08:49 +0100)]
[TASK] Allow strings in site configuration type "select"

To allow more usecases for extending the site configuration,
the value of tca type select should only be typecasted
if it looks like an integer.

Resolves: #87663
Releases: master, 9.5
Change-Id: I700bba3ac67ceac9acc8aa473d1b723b4bc34f4f
Reviewed-on: https://review.typo3.org/59649
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Scheduler: Remove label from progress bar 21/59621/2
Thorben Nissen [Sat, 2 Feb 2019 11:55:07 +0000 (12:55 +0100)]
[BUGFIX] Scheduler: Remove label from progress bar

Remove the label `Check/Uncheck all` from the progress bar and show only
the process percentage.

Resolves: #87624
Releases: master, 9.5
Change-Id: Iff6cbb47099747f613d4ea90ab75863454c2669b
Reviewed-on: https://review.typo3.org/59621
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[BUGFIX] Cast fallback language uids to integer 62/59662/7
Andreas Fernandez [Thu, 7 Feb 2019 12:04:05 +0000 (13:04 +0100)]
[BUGFIX] Cast fallback language uids to integer

To prepare a couple of bugfixes regarding the language fallback handling,
the property `SiteLanguage::$fallbackLanguageIds` must be an array of
integer values. The patch ensures that all values are cast to integers.

Resolves: #87673
Releases: master, 9.5
Change-Id: I437a08ce992718f601a612df4cddd9ecac5e1d3a
Reviewed-on: https://review.typo3.org/59662
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 months ago[!!!][TASK] Build strict PSR-15 middlewares 90/59490/6
Benni Mack [Fri, 18 Jan 2019 19:18:37 +0000 (20:18 +0100)]
[!!!][TASK] Build strict PSR-15 middlewares

All PSR-15 middlewares now do not set the
$GLOBALS['TYPO3_REQUEST'] object anymore. Instead,
the RequestHandlers are using them for all
other logic (e.g. GP etc) where the request object
or any other attribute has not been handed in
yet.

It is now safe to say that PSR-7 request/response
objects have to be used within middlewares to
access or manipulate GET/POST data. Also,
the safety net for overriding GET/POST again
is still in place for FE (data = GP:id) in
order for existing TypoScript to work still,
until all other code gets global-free.

There are still places in TYPO3 Core where $TYPO3_REQUEST
is necessary (TypoScriptConditionMatcher, Error Handling)
which are added accordingly.

Resolves: #87661
Releases: master
Change-Id: Ibe499b6fda86ccd3abefcb3c8be294a7cb765d74
Reviewed-on: https://review.typo3.org/59490
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[BUGFIX] Revert Set controller in ExtbasePluginEnhancer" 58/59658/3
Benni Mack [Thu, 7 Feb 2019 08:28:09 +0000 (09:28 +0100)]
[BUGFIX] Revert Set controller in ExtbasePluginEnhancer"

The accepted change adds an ugly side-effect when using
the same controller/action in multiple route variants.

This reverts commit 977ed578d04a3c2094cdad3207b5d9f86322f326.

Resolves: #87668
Reverts: #87337
Releases: master, 9.5

Change-Id: I7167b42cb26538e676256c9d2e36d1ec18f2bd40
Reviewed-on: https://review.typo3.org/59658
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[BUGFIX] Set controller in ExtbasePluginEnhancer 43/59343/2
Guido Schmechel [Sat, 5 Jan 2019 18:34:35 +0000 (19:34 +0100)]
[BUGFIX] Set controller in ExtbasePluginEnhancer

If the controller of a route in a routeEnhancer differs
from the default controller, it will now be used for the
generation of enhancers.

Resolves: #87337
Releases: master, 9.5
Change-Id: Iea3d15bbc99cb17c640e6a4824d3dd42176295d1
Reviewed-on: https://review.typo3.org/59343
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Alexander Grein <alexander.grein@gmail.com>
Tested-by: Alexander Grein <alexander.grein@gmail.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Use proper argument for options in SendEmailCommand 43/59643/2
Georg Ringer [Tue, 5 Feb 2019 12:09:33 +0000 (13:09 +0100)]
[BUGFIX] Use proper argument for options in SendEmailCommand

InputOption::VALUE_REQUIRED must be used instead of InputArgument::REQUIRED.

Resolves: #87648
Releases: master, 9.5
Change-Id: Ifd727ec26af0e1e2237e9ca5ae480b9ed2fd5b6f
Reviewed-on: https://review.typo3.org/59643
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 months ago[TASK] Add language synchronization tests for TCA type inline/CSV 52/59652/2
Oliver Hader [Wed, 6 Feb 2019 13:34:17 +0000 (14:34 +0100)]
[TASK] Add language synchronization tests for TCA type inline/CSV

Adds DataHandler tests that were available for TCA type inline/FF
for inline/CSV as well (initially introduced with issue ##79856).

Resolves: #87666
Releases: master, 9.5, 8.7
Change-Id: I01eadae3fc00a0ba037e1c8ef7e92b6de467266d
Reviewed-on: https://review.typo3.org/59652
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[TASK] Use constructor injection in QueryFactory 31/59631/3
Alexander Schnitzler [Mon, 4 Feb 2019 14:07:45 +0000 (15:07 +0100)]
[TASK] Use constructor injection in QueryFactory

Class QueryFactory does no longer use setter injection but
constructor injection instead.

Releases: master
Resolves: #87642
Change-Id: I5d595ff2c9b5b7e81f5d6380eef1284e0e2d9739
Reviewed-on: https://review.typo3.org/59631
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
4 months ago[TASK] Migrate Redirect Url Validator into own class 48/59648/3
Benni Mack [Tue, 5 Feb 2019 18:50:42 +0000 (19:50 +0100)]
[TASK] Migrate Redirect Url Validator into own class

The logic within EXT:felogin for validating proper redirect/referer
URLs is extracted into a new PHP class, which can now be called
separately.

This is useful for further refactorings within the Controller,
and it lays the foundation to use proper validation in various
places other than Extbase.

Resolves: #87660
Releases: master
Change-Id: I79aab5908bde869b7ee3cf730fbf61d658f2ee88
Reviewed-on: https://review.typo3.org/59648
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[!!!][TASK] Remove obsolete APC Cache Backend 88/59588/11
Josef Glatz [Wed, 30 Jan 2019 11:02:50 +0000 (12:02 +0100)]
[!!!][TASK] Remove obsolete APC Cache Backend

All occurrences of APC (without suffix "u") are removed from the
TYPO3 core since APC is discontinued and does not work with
PHP 7.x.

This changes does not affect the PHP OPcache related area.

Releases: master
Resolves: #87583
Change-Id: Ie724f8343dae9bdc4721d35c6d384c1de51f365e
Reviewed-on: https://review.typo3.org/59588
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Show hidden subgroups of fe_group 40/59640/2
Stephan Großberndt [Mon, 4 Feb 2019 20:04:30 +0000 (21:04 +0100)]
[BUGFIX] Show hidden subgroups of fe_group

When editing a fe_group show its subgroups even if those are set to
hidden in order to avoid losing the subgroup relation on saving the
fe_group.

Resolves: #87649
Releases: master, 9.5
Change-Id: Ic39f32b47327202a848827bd9d6b4935c35edcdd
Reviewed-on: https://review.typo3.org/59640
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
4 months ago[TASK] Avoid runtime reflection calls in ObjectAccess 31/59331/23
Alexander Schnitzler [Fri, 1 Feb 2019 09:45:19 +0000 (10:45 +0100)]
[TASK] Avoid runtime reflection calls in ObjectAccess

ObjectAccess had two kinds of runtime reflection calls:

1) To gather data about object properties and methods
2) To make non public properties accessible

The first one is tackled by using class schema instances
and by using the property accessor of symfony/property-access.

The latter is tackled by deprecating all method arguments
that trigger reflection to make properties accessible. In
the future, gettable/settable properties need to be either
public or have a getter (get*/has*/is*) or setter.

Releases: master
Resolves: #87332
Change-Id: I6ecef81de7aa4cc1244166d683874a1a87ac6bb7
Reviewed-on: https://review.typo3.org/59331
Reviewed-by: André Schließer <andy.schliesser@gmail.com>
Tested-by: André Schließer <andy.schliesser@gmail.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
4 months ago[FEATURE] Use symfony/property-info to gather doc block information 54/59454/21
Alexander Schnitzler [Wed, 16 Jan 2019 12:21:40 +0000 (13:21 +0100)]
[FEATURE] Use symfony/property-info to gather doc block information

This patch introduces the requirement to symfony/property-info
which provides a neat api to extract information about
properties via several different extractors.

The package comes with a PhpDocExtractor, which is kind of
a drop in replacement (functional wise) for the extbase
DocCommentParser which has been removed.

Along with the replacement of the doc block extractor
the package comes with an api to fetch context data that
enables us to resolve non fully qualified class names.

This is now possible:

```
use TYPO3\CMS\Extbase\Persistence\ObjectStorage;
use ExtbaseTeam\BlogExample\Domain\Model\Comment;

class Post
{
    /*
     * @var ObjectStorage<Comment>
     */
    public $comments;
}
```

Important:
This only works in extbase models as the reflection
costs are high and the information is only needed
in this case.

The non fully qualified class name is now also
supported for injection properties, although it is
still recommended to avoid injection properties in
favor of injection methods or constructor injection.

Example:

```
use TYPO3\CMS\Extbase\Annotation as Extbase;
use TYPO3\CMS\Extbase\Configuration\ConfigurationManager;

class Service
{
    /*
     * @Extbase\Inject
     * @var ConfigurationManager
     */
    public $configurationManager;
}
```

Releases: master
Resolves: #87457
Change-Id: I006aeb737b4bb9790fda257e12ba46a105d9b113
Reviewed-on: https://review.typo3.org/59454
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Raise minimum required prophecy version to 1.7.5 20/59620/6
Benjamin Franzke [Sat, 2 Feb 2019 04:55:09 +0000 (05:55 +0100)]
[BUGFIX] Raise minimum required prophecy version to 1.7.5

The recently introduced `object` type declarations for extbase classes
require a minimum version of prophecy 1.7.5. Previous versions trigger
the following error:
  Scalar type declaration 'object' must be unqualified

Prophecy added support for object type declarations in 1.7.4 and
for return type object declarations in 1.7.5.

Therefore we add an explicit dev dependency to prophecy in composer.json
now (previously it was transitively required as ^1.7 by phpunit 7.1).

composer require --no-update --dev phpspec/prophecy:^1.7.5
composer update --lock

Releases: master
Resolves: #87622
Change-Id: Ic35db424d1ea46143839ec3f4bd3c10e39c99b4e
Reviewed-on: https://review.typo3.org/59620
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Reuse entities of overridden classes in persistence session 59/58959/10
Markus Klösges [Tue, 27 Nov 2018 09:41:05 +0000 (10:41 +0100)]
[BUGFIX] Reuse entities of overridden classes in persistence session

When saving and retrieving object from the persistence session,
implementation class names set via \TYPO3\CMS\Extbase\Object\Container
are now respected by storing and retrieving them with that overridden
class name.

Resolves: #77617
Releases: master, 9.5
Change-Id: I887cb164328afe789dc274c92c8f8774b2098a40
Reviewed-on: https://review.typo3.org/58959
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Add support for language -1 to TCA field type slug 29/59029/5
André Schließer [Tue, 4 Dec 2018 16:50:24 +0000 (17:50 +0100)]
[BUGFIX] Add support for language -1 to TCA field type slug

Use default language as fallback for records with sys_language_uid = -1

Resolves: #87067
Releases: master, 9.5
Change-Id: If57d5566b83f4bba79451e8595337ca6c0eb3fc9
Reviewed-on: https://review.typo3.org/59029
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Replace EditRecordViewHelper of EXT:redirects with ModuleLinkViewHelper 84/59584/4
Georg Ringer [Wed, 30 Jan 2019 08:47:01 +0000 (09:47 +0100)]
[TASK] Replace EditRecordViewHelper of EXT:redirects with ModuleLinkViewHelper

Resolves: #87580
Releases: master
Change-Id: I5a384707d0c0ecd9b797ce89dced25f0738942c6
Reviewed-on: https://review.typo3.org/59584
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Ensure type safety for ViewHelper calling ImageService 17/59617/2
Anja Leichsenring [Fri, 1 Feb 2019 17:49:45 +0000 (18:49 +0100)]
[BUGFIX] Ensure type safety for ViewHelper calling ImageService

The ImageService::getImage requires a string as first and a boolean as
third parameter. The ThumbnailViewHelper must respect this requirement.

Resolves: #87621
Relates: #87599
Releases: master
Change-Id: Ib84f88665fd692629efdb54a33ff83263abe6bfe
Reviewed-on: https://review.typo3.org/59617
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Refactor metadata handling in FAL 08/57908/22
Andreas Fernandez [Wed, 15 Aug 2018 07:36:35 +0000 (09:36 +0200)]
[TASK] Refactor metadata handling in FAL

Meta data of files handled by FAL is fetched, created and updated in
various places, which makes it hard to maintain the current code base.

Albeit the method `_getMetaData()` is marked as internal, it has been
marked as deprecated as well, because the method is widely used in the
TYPO3 extension universe.

For this reason, a MetaDataAspect is introduced that takes care of meta
data handling on a low-level basis.

In the same run, FAL's `Indexer` is now responsible for creating or
updating such meta data records, the `ResourceStorage` now only tells
whether auto-extraction is enabled. The meta data extraction, based on
registered extractors implementing the `ExtractorInterface` interface,
has been moved into a separate service class.

Resolves: #85895
Releases: master
Change-Id: Icb929a6226777dcea3868ee5c083cf13ff5a71f6
Reviewed-on: https://review.typo3.org/57908
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Mark scheduler tasks as executed on PHP-level errors 04/59504/2
Andreas Fernandez [Mon, 21 Jan 2019 10:36:51 +0000 (11:36 +0100)]
[BUGFIX] Mark scheduler tasks as executed on PHP-level errors

The scheduler now catches any error implementing the `\Throwable`
interface thrown by a task to be able to mark such task as executed.

Resolves: #87502
Releases: master, 9.5, 8.7
Change-Id: I1f1bebee922c864ce8d7bfc3f0aa6e9434228e98
Reviewed-on: https://review.typo3.org/59504
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Use proper exception messages for Scheduler::fetchTask() 85/59385/6
Stefanos Karasavvidis [Wed, 9 Jan 2019 13:16:51 +0000 (15:16 +0200)]
[BUGFIX] Use proper exception messages for Scheduler::fetchTask()

Use a proper message in case a non existent uid was passed and
correctly handle the case where no task uid was passed and no task
is overdue.

Resolves: #87375
Releases: master, 9.5, 8.7
Change-Id: I69d2798cc185451c889bf37d8a007eacf572c163
Reviewed-on: https://review.typo3.org/59385
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Fix return type of determineSiteScript 95/59395/5
Harald Atteneder [Thu, 10 Jan 2019 10:26:27 +0000 (10:26 +0000)]
[BUGFIX] Fix return type of determineSiteScript

substr returns a boolean instead of an empty string. A typecast fixes
this problem (See http://php.net/manual/de/function.substr.php#90369)

Resolves: #87387
Releases: master, 9.5
Change-Id: I14aa49c18ae028dc27b94bfdbfc3dfb643c18746
Reviewed-on: https://review.typo3.org/59395
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Move FieldControl/EditPopup handling to module 87/58887/6
Andreas Fernandez [Sun, 11 Nov 2018 23:02:14 +0000 (15:02 -0800)]
[TASK] Move FieldControl/EditPopup handling to module

The FieldControl `EditPopup` now uses a dedicated module for its
handling and no longer uses inline `onclick` handlers nor inline
FormEngine calls.

Resolves: #86644
Releases: master
Change-Id: I46e5d3dbfcb4c187afb6cd1c0692b4e728bfaf26
Reviewed-on: https://review.typo3.org/58887
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Harden \TYPO3\CMS\Extbase\Object\ObjectManager 00/59600/4
Johannes Seipelt [Thu, 31 Jan 2019 20:09:23 +0000 (21:09 +0100)]
[TASK] Harden \TYPO3\CMS\Extbase\Object\ObjectManager

- Use strict type mode
- Use type hints whereever possible
- fix test of creating viewhelper instance using object manager

Releases: master
Resolves: #87605
Change-Id: Ia626ae1156dacd7c9ddcfefed9bb03d26ba91404
Reviewed-on: https://review.typo3.org/59600
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Johannes Seipelt <johannes.seipelt@3m5.de>
Reviewed-by: Felix Döring <Felix.Doering@3m5.de>
Reviewed-by: André Schließer <andy.schliesser@gmail.com>
Tested-by: André Schließer <andy.schliesser@gmail.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
4 months ago[FEATURE] Render thumbnails in file list module deferred 46/57646/19
Frank Naegler [Fri, 20 Jul 2018 19:03:47 +0000 (21:03 +0200)]
[FEATURE] Render thumbnails in file list module deferred

This patch adds a new ViewHelper to render thumbnails deferred in
the backend. This increase the performance of the file list.

Resolves: #85607
Related: #85605
Releases: master
Change-Id: Id97876e889605d7d8d3075ee98a4fc34b002f395
Reviewed-on: https://review.typo3.org/57646
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
4 months ago[TASK] Reduce information disclosure of the used TYPO3 version 65/59565/2
Josef Glatz [Thu, 24 Jan 2019 13:15:17 +0000 (14:15 +0100)]
[TASK] Reduce information disclosure of the used TYPO3 version

Reduce information disclosure of the used TYPO3 version by adding
a dynamic 4-digit year in the TYPO3_copyright_year constant.

That makes it more difficult to find out the used TYPO3 version
just by looking at the frontend source code of a website.

Releases: master, 9.5
Resolves: #87543
Change-Id: Ic169548c7111715eecedfce4ced5c8a3564d102a
Reviewed-on: https://review.typo3.org/59565
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: André Schließer <andy.schliesser@gmail.com>
Tested-by: André Schließer <andy.schliesser@gmail.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
4 months ago[BUGFIX] Use real finisher identifier in form element variants 06/59606/2
Ralf Zimmermann [Fri, 1 Feb 2019 12:51:40 +0000 (13:51 +0100)]
[BUGFIX] Use real finisher identifier in form element variants

Use the real finisher identifiers as they are configured in the
form definition instead the finisher implementation class name.
This requires a change of the public AbstractFinisher implementation
which implements the FinisherInterface. The interface is not changed,
as this would be a breaking change. Therefore, the existence of the
new method is checked. If it does not exist in a finisher
implementation, a fallback to the previous behavior happens.

Releases: master, 9.5
Resolves: #87615
Change-Id: I962502f0601845a5f9793751e87c97b3b902caa1
Reviewed-on: https://review.typo3.org/59606
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Update typo3fluid/fluid to 2.6.0 54/59554/7
Gerrit Mohrmann [Wed, 23 Jan 2019 20:43:08 +0000 (21:43 +0100)]
[TASK] Update typo3fluid/fluid to 2.6.0

Fixes missing output in ifAuthenticatedViewHelper after cache clearing
and erroneous replication of field properties to subsequent fields.

composer command used:
composer update typo3fluid/fluid

Resolves: #86930
Resolves: #86890
Resolves: #87430
Resolves: #86910
Resolves: #87586
Releases: master, 9.5
Change-Id: I8d1abd0aa08d7d7399ec23675dcf07d08dbdd2f2
Reviewed-on: https://review.typo3.org/59554
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Jonas Eberle <flightvision@googlemail.com>
Tested-by: Jonas Eberle <flightvision@googlemail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Improve ClassSchema methods api 22/59422/10
Alexander Schnitzler [Sun, 13 Jan 2019 12:46:26 +0000 (13:46 +0100)]
[TASK] Improve ClassSchema methods api

This patch introduces a new Method class to have an
easier and more stable api to get information about class
methods from ClassSchema objects.

The reflection data fetched and stored by/in the ClassSchema
objects is no longer publicly available as an array. Instead,
Method objects are returned for the following calls:

- getMethod
- getMethods
- getInjectMethods

Also it removes the following method:

- getConstructorArguments

The following constants are marked as private:

- ClassSchema::MODELTYPE_ENTITY
- ClassSchema::MODELTYPE_VALUEOBJECT

Releases: master
Resolves: #87427
Change-Id: I38e8a7287896e9303fad1fa8f8f9182895365adc
Reviewed-on: https://review.typo3.org/59422
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: André Schließer <andy.schliesser@gmail.com>
Tested-by: André Schließer <andy.schliesser@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Remove deprecated code from TypoScript condition matchers 91/59491/11
Frank Naegler [Fri, 18 Jan 2019 08:27:09 +0000 (09:27 +0100)]
[TASK] Remove deprecated code from TypoScript condition matchers

Resolves: #87607
Related: #87193
Releases: master
Change-Id: I5c1ce876cd6ad5edeecefce03d7a1e3619f9d54c
Reviewed-on: https://review.typo3.org/59491
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Ensure type safety for ViewHelper calling ImageService 08/59608/2
Anja Leichsenring [Fri, 1 Feb 2019 14:59:36 +0000 (15:59 +0100)]
[BUGFIX] Ensure type safety for ViewHelper calling ImageService

The ImageService::getImage requires a string as first and a boolean as
third parameter. The Image ViewHelpers must respect this requirement.

Resolves: #87619
Relates: #87599
Releases: master
Change-Id: I0d8f57c2bef62dcc6b4d6e6684bbbb1593bff98f
Reviewed-on: https://review.typo3.org/59608
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: André Schließer <andy.schliesser@gmail.com>
Tested-by: André Schließer <andy.schliesser@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[!!!][TASK] Harden \TYPO3\CMS\Extbase\Service\ImageService 94/59594/7
Alexander Schnitzler [Thu, 31 Jan 2019 18:20:58 +0000 (19:20 +0100)]
[!!!][TASK] Harden \TYPO3\CMS\Extbase\Service\ImageService

- Use strict type mode
- Use type hints whereever possible

Releases: master
Resolves: #87599
Change-Id: I8840b7fad16c4fffb7f50973fb97a498e0f683e4
Reviewed-on: https://review.typo3.org/59594
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Harden \TYPO3\CMS\Extbase\Service\EnvironmentService 92/59592/3
Alexander Schnitzler [Thu, 31 Jan 2019 17:26:48 +0000 (18:26 +0100)]
[TASK] Harden \TYPO3\CMS\Extbase\Service\EnvironmentService

- Use strict type mode
- Use type hints whereever possible

Releases: master
Resolves: #87597
Change-Id: Ic4cfb5512f49b3e20fa16c782301b8dcb2ba5dec
Reviewed-on: https://review.typo3.org/59592
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: André Schließer <andy.schliesser@gmail.com>
Tested-by: André Schließer <andy.schliesser@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Felix Döring <Felix.Doering@3m5.de>
Tested-by: Felix Döring <Felix.Doering@3m5.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Harden \TYPO3\CMS\Extbase\Utility\TypeHandlingUtility 96/59596/3
Alexander Schnitzler [Thu, 31 Jan 2019 18:51:41 +0000 (19:51 +0100)]
[TASK] Harden \TYPO3\CMS\Extbase\Utility\TypeHandlingUtility

- Use strict type mode
- Use type hints whereever possible

Releases: master
Resolves: #87601
Change-Id: I087fcb4a87e12ac3d4345a4514dae674b8551460
Reviewed-on: https://review.typo3.org/59596
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Rudy Gnodde <rgn@windinternet.nl>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Harden \TYPO3\CMS\Extbase\Service\CacheService 91/59591/4
Alexander Schnitzler [Thu, 31 Jan 2019 17:22:31 +0000 (18:22 +0100)]
[TASK] Harden \TYPO3\CMS\Extbase\Service\CacheService

- Use strict type mode
- Use type hints whereever possible

Releases: master
Resolves: #87596
Change-Id: I99fe661ff7ee0c29d34c0fde7c5c2c83f0f39201
Reviewed-on: https://review.typo3.org/59591
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[!!!][TASK] Consolidate extbase caches 73/59573/8
Alexander Schnitzler [Mon, 28 Jan 2019 08:51:30 +0000 (09:51 +0100)]
[!!!][TASK] Consolidate extbase caches

The caches of extbase have been consolidated as both of them shared the
same caching frontend. Cache identifiers `extbase_reflection` and
`extbase_datamapfactory_datamap` do no longer exist.

A single cache `extbase` is pre-configured and used for class schemata
and data maps instead.

Releases: master
Resolves: #87558
Change-Id: I4d7ec53cfd1b4900998fa2d01db1d8f2c1730633
Reviewed-on: https://review.typo3.org/59573
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Replace ModuleLinkViewHelper of EXT:scheduler with ModuleLinkViewHelper of... 83/59583/2
Georg Ringer [Wed, 30 Jan 2019 08:25:09 +0000 (09:25 +0100)]
[TASK] Replace ModuleLinkViewHelper of EXT:scheduler with ModuleLinkViewHelper of EXT:backend

Resolves: #87579
Releases: master
Change-Id: I04e8d291a030dac0a0df526e46aa40ba27a24b39
Reviewed-on: https://review.typo3.org/59583
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
4 months ago[TASK] Use shorthand syntax for global variable $LANG consistently 78/59578/3
Benni Mack [Tue, 29 Jan 2019 12:41:58 +0000 (13:41 +0100)]
[TASK] Use shorthand syntax for global variable $LANG consistently

TYPO3 uses $GLOBALS['LANG'] directly in some places, but since
TYPO3 v7, new code started to use a short hand protected method
"getLanguageService" in order to get IDE code completion and better
analysis of code.

This patch replaces all left-over places of $GLOBALS['LANG']
and encapsulates this into a short-hand method to streamline
TYPO3 Core's code base.

Resolves: #87571
Releases: master
Change-Id: Ie15e320713fe65d40552a19e0a517d5739abbb41
Reviewed-on: https://review.typo3.org/59578
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
4 months ago[TASK] Harden \TYPO3\CMS\Extbase\Security\Cryptography\HashService 90/59590/3
Alexander Schnitzler [Thu, 31 Jan 2019 17:18:14 +0000 (18:18 +0100)]
[TASK] Harden \TYPO3\CMS\Extbase\Security\Cryptography\HashService

- Use strict type mode
- Use type hints whereever possible

Releases: master
Resolves: #87595
Change-Id: If59546093176c5a7725725aad8e619de70fd43cd
Reviewed-on: https://review.typo3.org/59590
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Felix Döring <Felix.Doering@3m5.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: André Schließer <andy.schliesser@gmail.com>
Tested-by: André Schließer <andy.schliesser@gmail.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
4 months ago[TASK] Harden \TYPO3\CMS\Extbase\Core\Bootstrap 98/59598/4
Alexander Schnitzler [Thu, 31 Jan 2019 19:54:02 +0000 (20:54 +0100)]
[TASK] Harden \TYPO3\CMS\Extbase\Core\Bootstrap

- Use strict type mode
- Use type hints whereever possible

Releases: master
Resolves: #87603
Change-Id: I3430b59e93133d9b19d6520d3fd7cca83c0fdb49
Reviewed-on: https://review.typo3.org/59598
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[!!!][TASK] Harden \TYPO3\CMS\Extbase\DomainObject\DomainObjectInterface 02/59602/5
Alexander Schnitzler [Thu, 31 Jan 2019 20:41:57 +0000 (21:41 +0100)]
[!!!][TASK] Harden \TYPO3\CMS\Extbase\DomainObject\DomainObjectInterface

- Use strict type mode
- Use type hints whereever possible

Releases: master
Resolves: #87608
Change-Id: I3fc153c68bb29aa85517965c6d4d8414d25af35b
Reviewed-on: https://review.typo3.org/59602
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Use FQCN's when registering plugins/modules 66/59566/11
Alexander Schnitzler [Thu, 24 Jan 2019 18:02:33 +0000 (19:02 +0100)]
[TASK] Use FQCN's when registering plugins/modules

The following methods used controller aliases:

- \TYPO3\CMS\Extbase\Utility\ExtensionUtility::configurePlugin
- \TYPO3\CMS\Extbase\Utility\ExtensionUtility::registerModule

This means, that while configuring plugins or modules, a list
of controllers (and their actions) had to be provided, so they
could be registered as available controllers for said plugin
or module.

The controller name used for the registration, was kind of an
alias for that controller. It was the class name without the
namespace and without the "Controller" suffix. By a certain
convention a proper class name could be derived from that
alias. All this was necessary back then when TYPO3 didn't have
a proper autoloader and when the class location was derived
from the class name. These circumstances do not exist any more
and since it's only important that a controller class exists,
the registration of plugins must now use the fully qualified
controller class name as array key.

The former syntax

   \TYPO3\CMS\Extbase\Utility\ExtensionUtility::configurePlugin(
       'TYPO3.CMS.IndexedSearch',
       'Pi2',
       ['Search' => 'form,search,noTypoScript'],
       ['Search' => 'form,search']
   );

has to be converted to

   \TYPO3\CMS\Extbase\Utility\ExtensionUtility::configurePlugin(
       'IndexedSearch',
       'Pi2',
       [
           \TYPO3\CMS\IndexedSearch\Controller\SearchController::class
               => 'form,search,noTypoScript'
       ],
       [
           \TYPO3\CMS\IndexedSearch\Controller\SearchController::class
               => 'form,search'
       ]
   );

Please note, that not only the controller configuration changed.
The vendor `TYPO3.CMS` in `TYPO3.CMS.IndexedSearch`, must no longer
be set. Instead, the vendor will be evaluated by looking at the
controller namespace.

Releases: master
Resolves: #87550
Change-Id: If47d087836c4345a8180dae3d4e4b8cd384e684c
Reviewed-on: https://review.typo3.org/59566
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[!!!][TASK] Remove view related properties from ActionController 14/59514/6
Alexander Schnitzler [Mon, 21 Jan 2019 16:13:05 +0000 (17:13 +0100)]
[!!!][TASK] Remove view related properties from ActionController

Both properties $namespacesViewObjectNamePattern and
$viewFormatToObjectNameMap of class ActionController
have been removed without replacement.

Both properties provided a functionality to set a
custom view object class during runtime. As this
contradicts the idea of having a defined state per
request by configuring concrete implementations
before runtime, these properties needed to vanish.

While there is no dependency injection with a proper
configuration available, the view object class can
still be defined via property $defaultViewObjectName.

Releases: master
Resolves: #87511
Change-Id: I4b89a9434f71a3cbf38a9ad113ba8233e7f327f9
Reviewed-on: https://review.typo3.org/59514
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Achim Fritz <af@achimfritz.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Remove unused class import statements 59/59359/5
Oliver Hader [Mon, 7 Jan 2019 17:26:16 +0000 (18:26 +0100)]
[TASK] Remove unused class import statements

Resolves: #87589
Releases: master
Change-Id: I69119636e11d116b79fc627a2993a1fa84d7a39c
Reviewed-on: https://review.typo3.org/59359
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[TASK] Remove unused PHP variables 60/59360/6
Oliver Hader [Wed, 30 Jan 2019 16:14:43 +0000 (17:14 +0100)]
[TASK] Remove unused PHP variables

Resolves: #87590
Releases: master
Change-Id: I30af97f075d352792370b363b0b152ead99eacab
Reviewed-on: https://review.typo3.org/59360
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Resolve site correctly in nested site structure 79/59579/3
Benni Mack [Tue, 29 Jan 2019 15:24:24 +0000 (16:24 +0100)]
[BUGFIX] Resolve site correctly in nested site structure

Due to a bug in checking for $result[t3ver_oid] ?? $result[uid]
the uid is never used, but only the t3ver_oid. This value could be empty
and then "0" is used. This means, the page record to be edited
in FormEngine is treated as "NullSite" = Page without Site Configuration.

Resolves: #87572
Releases: master, 9.5
Change-Id: I1c4175f61a9c5df3dd3a392c2f636112cfbdb350
Reviewed-on: https://review.typo3.org/59579
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Increase field name of table sys_file_storage 81/59581/2
Georg Ringer [Wed, 30 Jan 2019 07:12:44 +0000 (08:12 +0100)]
[TASK] Increase field name of table sys_file_storage

Increase the length of the field from 30 to 255 chars to be in
sync with other tables, e.g. sys_file_mounts. 30 is fairly short
for bigger sites and lots of storages.

As this is an admin only field and not too often used, it is ok to backport
that to 9.5 as well.

Resolves: #87576
Releases: master, 9.5
Change-Id: I355b6295a9f813e72e1e66e05dd93419fd2aeaeb
Reviewed-on: https://review.typo3.org/59581
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 months ago[TASK] Remove unused DeleteFileViewHelper 82/59582/2
Georg Ringer [Wed, 30 Jan 2019 08:01:27 +0000 (09:01 +0100)]
[TASK] Remove unused DeleteFileViewHelper

Since #72332 the url to the delete action is built in the controller and
assigned to the view.

Resolves: #87578
Releases: master
Change-Id: I36ea3374a848c48c981718dfc8dc1899dc9c0164
Reviewed-on: https://review.typo3.org/59582
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 months ago[BUGFIX] Use overridden field label in list view 05/59505/6
Georg Ringer [Mon, 21 Jan 2019 10:41:31 +0000 (11:41 +0100)]
[BUGFIX] Use overridden field label in list view

If a label of a table column is overridden by TsConfig
(TCEFORM.<table>.<column>.label), the new value
must also be used in the list view:

- header of the table rendering
- list of "set fields"

Resolves: #87484
Releases: master, 9.5
Change-Id: I8eafd1f2878b571edd1e5a30b28b0d5330b9b5d0
Reviewed-on: https://review.typo3.org/59505
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[!!!][TASK] Drop TBE_TEMPLATE variable 92/59492/6
Benni Mack [Fri, 18 Jan 2019 20:52:19 +0000 (21:52 +0100)]
[!!!][TASK] Drop TBE_TEMPLATE variable

The global variable TBE_TEMPLATE is not
necessary anymore, and is not available anymore.

The change is still ugly, as TBE_TEMPLATE
initializes the PageRenderer object
with necessary information, which should
become built inside PageRenderer for BE. This has been
moved to Backend's RequestHandler where this can be
abstracted further at a later point.

Resolves: #87567
Releases: master
Change-Id: If1cb184740f1e99c0aeca5ae19c85899d56f3f9a
Reviewed-on: https://review.typo3.org/59492
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Use ModuleLinkViewHelper in EXT:sys_note 11/59511/2
Georg Ringer [Mon, 21 Jan 2019 13:16:24 +0000 (14:16 +0100)]
[TASK] Use ModuleLinkViewHelper in EXT:sys_note

Replace custom VH with the one provided by EXT:backend.

Resolves: #87507
Releases: master
Change-Id: I882d7555654a051e7190d7ffd25ff6e903f16ab1
Reviewed-on: https://review.typo3.org/59511
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Use ModuleLinkViewHelper instead of IssueCommandViewHelper 13/59513/2
Georg Ringer [Mon, 21 Jan 2019 14:20:59 +0000 (15:20 +0100)]
[TASK] Use ModuleLinkViewHelper instead of IssueCommandViewHelper

Use the general ModuleLinkViewHelper instead of custom VH.

Resolves: #87509
Releases: master
Change-Id: I7f0d7125d0ee84973bc80599cbc51e44747e2d06
Reviewed-on: https://review.typo3.org/59513
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Add correct description for CType menu_sitemap 71/59571/3
Josef Glatz [Sun, 27 Jan 2019 21:46:03 +0000 (22:46 +0100)]
[BUGFIX] Add correct description for CType menu_sitemap

This patch adds the correct description text for the new
content element wizard of CType "menu_sitemap".

Resolves: #87556
Releases: master, 9.5
Change-Id: Iec0de6887a9a60215a813e03041e4d58af7b297b
Reviewed-on: https://review.typo3.org/59571
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Use PSR-15 middlewares in install tool 41/59541/6
Benjamin Franzke [Tue, 22 Jan 2019 08:26:33 +0000 (09:26 +0100)]
[TASK] Use PSR-15 middlewares in install tool

Remove the old concept of priority-based HTTP request handlers,
and use statically configured PSR-15 middlewares instead.
Tranform the priority based request handlers into a set of
chained middlewares.

In case none of the middlewares handles the request a
NotFoundRequestHandler returns a 404 response
(replacing the previous exception that was thrown in that case).
This scheme of using a 404 handler as "last" request handler is
not new, it is also used in zend expressive (a PSR-15 framework).

The TYPO3 RequestHandlerInterface is marked @internal and was set
to be removed in v9, therefore we drop it now and also remove its
implementation from the frontend and backend request handlers.

Releases: master
Resolves: #87516
Change-Id: Ibbd6a0e6c4ff8aa55b4367c9e4c07e279595dbfb
Reviewed-on: https://review.typo3.org/59541
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[TASK] Add correct description for ext-intl composer.json 74/59574/2
Josef Glatz [Mon, 28 Jan 2019 11:52:03 +0000 (12:52 +0100)]
[TASK] Add correct description for ext-intl composer.json

Releases: master
Resolves: #87559
Change-Id: I74d7ef26017080e45eb129217613ad7c36cd3881
Reviewed-on: https://review.typo3.org/59574
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
4 months ago[!!!][TASK] Remove last marked deprecations 03/59503/6
Benni Mack [Mon, 21 Jan 2019 06:38:28 +0000 (07:38 +0100)]
[!!!][TASK] Remove last marked deprecations

Various deprecated code regarding EXT:form and FormEngine
have been removed.

* IRRE CustomControls without userFunc is not possible anymore.
* TBE_MODULES's configureModuleFunction is removed
* EXT:form type "GridContainer" is removed (use GridRow)
* EXT:form form configuration files must end with .form.yaml.
* EXT:form renderingOptions._isHiddenFormElement and
renderingOptions._isReadOnlyFormElement are removed
* CLI Command "lang:language:update" is now only
available under "language:update"

Resolves: #87514
Releases: master
Change-Id: Idef84daf51f882df23ef227d1777d24b1076dfaf
Reviewed-on: https://review.typo3.org/59503
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[TASK] Improve indexed_search manual 68/58968/6
hasenbalg [Wed, 28 Nov 2018 08:32:13 +0000 (09:32 +0100)]
[TASK] Improve indexed_search manual

Improves indexed search documentation, mentioning activation
and inclusion of a static template.

Releases: master, 9.5
Resolves: #87023
Change-Id: I85e40b768e4020e71a7717d877a6305fb55a00cb
Reviewed-on: https://review.typo3.org/58968
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
4 months ago[TASK] Use constructor injection in configuration managers 46/59446/3
Alexander Schnitzler [Tue, 15 Jan 2019 14:24:57 +0000 (15:24 +0100)]
[TASK] Use constructor injection in configuration managers

The following classes do no longer use setter injection but
constructor injection instead:

- TYPO3\CMS\Extbase\Configuration\AbstractConfigurationManager
- TYPO3\CMS\Extbase\Configuration\BackendConfigurationManager
- TYPO3\CMS\Extbase\Configuration\ConfigurationManager
- TYPO3\CMS\Extbase\Configuration\FrontendConfigurationManager

Releases: master
Resolves: #87448
Change-Id: Ib6df3ab4a286bbe77cdda82d0066495a8dab8b22
Reviewed-on: https://review.typo3.org/59446
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Christian Wolff <chris@wolffc.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Sebastian Fischer <typo3@evoweb.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
4 months ago[TASK] bamboo: db dependency loop needs break condition 67/59567/3
Christian Kuhn [Fri, 25 Jan 2019 11:00:46 +0000 (12:00 +0100)]
[TASK] bamboo: db dependency loop needs break condition

Functional and acceptance tests need a db up and running.
The according container is started as dependency and a
loop delays further execution until the database connected
to its network port. This sometimes goes wrong, for
instance mssql in rare conditions does not come up. This
leads to the loop running "forever", consuming the
executing bamboo agent and the job never finishs.
The patch adds an additional break condition: If db did
not connect to the port after a minute, the job now fails.

Resolves: #87549
Releases: master, 9.5, 8.7
Change-Id: Idc45f57d9cfd2d390cea6bd5319adaf4158340df
Reviewed-on: https://review.typo3.org/59567
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Replace RemoveUserViewHelper with ModuleLinkViewHelper 52/59552/2
Georg Ringer [Wed, 23 Jan 2019 07:47:20 +0000 (08:47 +0100)]
[TASK] Replace RemoveUserViewHelper with ModuleLinkViewHelper

Resolves: #87523
Releases: master
Change-Id: I711ddb140e03e87b38ec06a7814e4b488bc9e9c9
Reviewed-on: https://review.typo3.org/59552
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[SECURITY] Extend file deny pattern 40/59540/2
Oliver Hader [Tue, 22 Jan 2019 08:43:31 +0000 (09:43 +0100)]
[SECURITY] Extend file deny pattern

In order to enhance protection against (possible) executable file
extensions phar, shtml, cgi, pl have been added to the according
file deny pattern.

Releases: master, 9.5, 8.7
Resolves: #87368
Security-Commit: c9f0d00b89768b63df9c77884cf9d19d658fc0fc
Security-Bulletin: TYPO3-CORE-SA-2019-008
Change-Id: I92998a2046b6efb7f31961c20f24c81d00957879
Reviewed-on: https://review.typo3.org/59540
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[SECURITY] Use a fluid template for the ConfirmationFinisher message 39/59539/2
Ralf Zimmermann [Tue, 22 Jan 2019 08:43:24 +0000 (09:43 +0100)]
[SECURITY] Use a fluid template for the ConfirmationFinisher message

The ConfirmationFinisher message is now rendered within a fluid template
to allow styling of the message.
Furthermore, the FormRuntime (and thus all form element values) and the
finisherVariableProvider are available in the template.
Custom variables can be added globally within the form setup or at
form level in the form definition.
By using a fluid template and the associated html escaping, the display
of the ConfirmationFinisher message is protected against XSS / html
injection attacks.

Resolves: #84902
Releases: master, 9.5, 8.7
Security-Commit: a38c63f3f03b1ab267666ca06a3abaead57b8265
Security-Bulletin: TYPO3-CORE-SA-2019-007
Change-Id: Ib6cfef88bef09f72b675909f7022120b32c095df
Reviewed-on: https://review.typo3.org/59539
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[SECURITY] Raise bootstrap 3.4.0 to fix XSS in JS components 38/59538/2
Benni Mack [Tue, 22 Jan 2019 08:43:15 +0000 (09:43 +0100)]
[SECURITY] Raise bootstrap 3.4.0 to fix XSS in JS components

Fixes an XSS issue in Alert, Carousel, Collapse, Dropdown, Modal,
and Tab components.

Executed tasks:
  cd Build
  yarn add bootstrap-sass@^3.4.0 --dev
  yarn exec grunt

Then copying the contents of Build/node_modules/bootstrap-sass/assets/javascripts/bootstrap.min.js
into typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap/bootstrap.js
additionally adding the AMD factory wrapper.

Resolves: #86580
Releases: master, 9.5, 8.7
Security-Commit: f456e3c185b23c51d08a579ceef1082df473b01b
Security-Bulletin: TYPO3-CORE-SA-2019-006
Change-Id: I235a4b5f6865afd9283cd1e692b25d3a572513ba
Reviewed-on: https://review.typo3.org/59538
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[SECURITY] XSS issues in Fluid view helpers 37/59537/2
Andreas Wolf [Tue, 22 Jan 2019 08:43:08 +0000 (09:43 +0100)]
[SECURITY] XSS issues in Fluid view helpers

* HtmlentitiesViewHelper
* UrlencodeViewHelper
* StripTagsViewHelper

Resolves: #85764
Releases: master, 9.5, 8.7
Security-Commit: 37bc147e634d67d521b716f83ca8d925ec57d531
Security-Bulletin: TYPO3-CORE-SA-2019-005
Change-Id: I1d5473b20378217a68e06c792be7f1cf096859fe
Reviewed-on: https://review.typo3.org/59537
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[SECURITY] Prevent possible XSS in install tool 36/59536/2
Frank Naegler [Tue, 22 Jan 2019 08:43:00 +0000 (09:43 +0100)]
[SECURITY] Prevent possible XSS in install tool

Resolves: #86455
Releases: master, 9.5
Security-Commit: 161663d336f7a6c52a87359a1d1ac01037e5c768
Security-Bulletin: TYPO3-CORE-SA-2019-004
Change-Id: Ief21fcf68f14cb756f140b4c709ddb51f447e544
Reviewed-on: https://review.typo3.org/59536
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[SECURITY] Avoid creation of backend users without password 35/59535/2
Benni Mack [Tue, 22 Jan 2019 08:42:53 +0000 (09:42 +0100)]
[SECURITY] Avoid creation of backend users without password

When using FormEngine it is possible to create a Backend User
without setting a password (or username), which could lead to
issues when using third-party authentication providers.

A hook within DataHandler ensures to set a random username
and/or password if the data is handed into DataHandler without
proper data. Besides that new backend users are disabled per
default and have to be enable manually.

Resolves: #80269
Releases: master, 9.5, 8.7
Security-Commit: f8a9edfed26ad48d13564ea99f27e0846671841c
Security-Bulletin: TYPO3-CORE-SA-2019-002
Change-Id: Ic1d84010717e3ac056f447fd373b31bbce8f65c6
Reviewed-on: https://review.typo3.org/59535
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[SECURITY] Avoid disclosing loaded extensions 34/59534/2
Oliver Hader [Tue, 22 Jan 2019 08:42:46 +0000 (09:42 +0100)]
[SECURITY] Avoid disclosing loaded extensions

Inline JavaScript settings for RequireJS and ajaxUrls disclose the
existence of specific extensions in a TYPO3 installation.

In case no backend user is logged in RequireJS settings are fetched
using an according endpoint, ajaxUrls (for backend AJAX routes) are
limited to those that are accessible without having a user session.

Resolves: #83855
Releases: master, 9.5, 8.7
Security-Commit: a9b60d26597449fec46bd26e0b511bc6e423ef24
Security-Bulletin: TYPO3-CORE-SA-2019-001
Change-Id: Ifa4029340e750baaf216fa953bf41b6d06d3138b
Reviewed-on: https://review.typo3.org/59534
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[BUGFIX] Prevent exception in early bootstrap exception handler 07/59507/2
Benjamin Franzke [Mon, 21 Jan 2019 11:57:20 +0000 (12:57 +0100)]
[BUGFIX] Prevent exception in early bootstrap exception handler

ErrorPageController which is used by the ProductionExceptionHandler
must not rely on PackageManager to be available. Rather use
paths derived from Environment::getFrameworkBasePath().

Releases: master, 9.5
Resolves: #87503
Related: #87175
Change-Id: I556b503e06962b338ec11f2e031eb941417d5944
Reviewed-on: https://review.typo3.org/59507
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[BUGFIX] Prevent selection of pagetree loader animation 08/59508/3
Josef Glatz [Mon, 21 Jan 2019 12:23:35 +0000 (13:23 +0100)]
[BUGFIX] Prevent selection of pagetree loader animation

Resolves: #87505
Releases: master, 9.5
Change-Id: I879c4c484f8380a7270bd57c0d54a14ea7c7ad2e
Reviewed-on: https://review.typo3.org/59508
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
4 months ago[TASK] Raise guzzlehttp/psr7 composer dependency 17/59517/2
Oliver Hader [Mon, 21 Jan 2019 19:07:46 +0000 (20:07 +0100)]
[TASK] Raise guzzlehttp/psr7 composer dependency

composer update guzzlehttp/psr7

Resolves: #87512
Releases: master, 9.5, 8.7
Change-Id: Ic3dcef632fd1ac65e09f5d8fb6d631ab211e8c3e
Reviewed-on: https://review.typo3.org/59517
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[TASK] Add hidden field to form definition example 47/59447/4
Sebastian Roßkopf [Tue, 15 Jan 2019 14:45:37 +0000 (15:45 +0100)]
[TASK] Add hidden field to form definition example

Since it is not obvious how to add a "Hidden" field to form definitions
without the visual editor we add an element to the form definition example.

Releases: master
Resolves: #87449
Change-Id: I860a5a17346e405cf1f7b29ea3c6255dda1be044
Reviewed-on: https://review.typo3.org/59447
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
4 months ago[TASK] Make the site's identifier available in TypoScript 06/59506/2
Georg Ringer [Mon, 21 Jan 2019 11:00:07 +0000 (12:00 +0100)]
[TASK] Make the site's identifier available in TypoScript

Since #86422 the configuration of a site is available with TypoScript.
As the identifier itself is not part of the configuration, it can't be retrieved.

Now "site:identifier" will retrieve the identifier as well.

Resolves: #87434
Releases: master, 9.5
Change-Id: Ic5a60e8a033c8fbc45baa19ad6a3fe81ff3b6e0b
Reviewed-on: https://review.typo3.org/59506
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Tested-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Add missing use statement in Core/Bootstrap 09/59509/2
Benjamin Franzke [Mon, 21 Jan 2019 12:21:49 +0000 (13:21 +0100)]
[BUGFIX] Add missing use statement in Core/Bootstrap

Bootstrap::createCache() uses Typo3DatabaseBackend::class
as fallback if no cache backend is configured explicitly.
In that case incorrect class name 'Typo3DatabaseBackend'
would be used without the `use` statement.

Releases: master
Resolves: #87504
Change-Id: I6abd1024d79fb7dad194ab32ae79d0658654c4a5
Reviewed-on: https://review.typo3.org/59509
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[TASK] Extract "taskcenter" and "sys_action" to TER/composer 02/59502/3
Christian Kuhn [Sun, 20 Jan 2019 14:03:30 +0000 (15:03 +0100)]
[TASK] Extract "taskcenter" and "sys_action" to TER/composer

This is the last round of planned extension extractions
from the main core repository.

Both the extensions 'taskcenter' and its add-on extension
'sys_action' did not receive much love over the years. They
are rarely used and their approach is clumsy to say the least.

They are both dropped from main core repository with core v10
now. A fresh approach for a cool new dashboard is in the works
already that may eventually find its way into the core later.

The patch removes both extensions with have been released as
'taskcenter' and 'sys_action' to TER and as
'friendsoftypo3/taskcenter' and 'friendsoftypo3/sys_action'
to composer.

Extension 'impexp' registered a task for the taskcenter which
is now within 'taskcenter' directly.

Resolves: #87499
Releases: master
Change-Id: I86e0292f13247bbd1f2060214f4f6d8e2aefe6c0
Reviewed-on: https://review.typo3.org/59502
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[!!!][TASK] Extract extension feedit to TER/composer 01/59501/3
Christian Kuhn [Sun, 20 Jan 2019 12:00:00 +0000 (13:00 +0100)]
[!!!][TASK] Extract extension feedit to TER/composer

Looking back, extension feedit had a hard life: While
so many parts in the core improved so much over the
years, it never received any similar love.

There have already been multiple attempts to rewrite
a frontend editing approach for TYPO3, for instance with
core 4.5 as the feedit_advanced extension that quickly
died.
There is another editing approach as extension
frontend_editing in the works that may eventually end
up being integrated in the core again.

feedit itself however is so sparse, outdated and not
well working that we now go ahead and drop that extension
from the core, extracting it to github.com/friendsoftypo3.
Maybe some enthusiasts pick the development up again and
make the extension shine and healthy again, without
boundaries of core development.

The patch removes the extension from the core repository,
including some feedit specific code in adminpanel that
has already been merged into the friendsoftypo3 feedit
repository and released as v10.0.0.

The extension is available as friendsoftypo3/feedit via
composer and as name 'feedit' via TER. An upgrade wizard
is in place to fetch it for those who want to use it.

Resolves: #87498
Releases: master
Change-Id: I11a0e91830b47f88fcea9a15459be37bc6dbd3de
Reviewed-on: https://review.typo3.org/59501
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Speed up ReST file reference check 95/59495/4
Christian Kuhn [Sat, 19 Jan 2019 07:25:32 +0000 (08:25 +0100)]
[TASK] Speed up ReST file reference check

There is a test related check for the extension scanner
to verify all referenced ReST files actually exist. It
is active as part of the 'integrity' job in bamboo.
The patch adds a variable to suppress checking the same
ReST file name multiple times if it is referenced in many
matchers. In practice, this speeds up the scanning process
drastically, on my local machine with current master from
more than a minute to less than ten seconds.

Resolves: #87493
Releases: master, 9.5
Change-Id: Iaa19add06ad9eeda9d36e3e204c1a671368b5f29
Reviewed-on: https://review.typo3.org/59495
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Fix minor syntax in Changelog 98/59498/2
Joerg Kummer [Sat, 19 Jan 2019 13:26:40 +0000 (14:26 +0100)]
[TASK] Fix minor syntax in Changelog

Change backslash to slash in file format, where backslash is not visible
in rendered HTML - it is a file path, not a PHP namespace.

Releases: master, 9.5
Resolves: #87495
Change-Id: If749a3cb1faaf9b25e05db7c1c3cbf7a38d0eafc
Reviewed-on: https://review.typo3.org/59498
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Fix minor spelling in Changelog 96/59496/2
Joerg Kummer [Sat, 19 Jan 2019 09:14:24 +0000 (10:14 +0100)]
[TASK] Fix minor spelling in Changelog

Adopt wrong spelling in deprecation Changelog
which is rendered in documentation and extension scanner

Resolves: #87494
Releases: master, 9.5
Change-Id: I4ebea1d5f263762be61b16104b14f66655ddcd4f
Reviewed-on: https://review.typo3.org/59496
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Tested-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[TASK] Fix minor syntax in Changelog 93/59493/5
jokumer [Sat, 19 Jan 2019 00:41:53 +0000 (01:41 +0100)]
[TASK] Fix minor syntax in Changelog

Change backslash to slash in file format, where backslash is not visible
in rendered HTML - it is a file path, not a PHP namespace.

Releases: master, 9.5
Resolves: #87492
Change-Id: I5a26eed78ba49b0c32cc5bfef95f9f587635053c
Reviewed-on: https://review.typo3.org/59493
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[!!!][TASK] Remove deprecated code at various places 75/59475/6
Christian Kuhn [Fri, 18 Jan 2019 10:47:03 +0000 (11:47 +0100)]
[!!!][TASK] Remove deprecated code at various places

The patch pics various smaller places to drop
their deprecated code snippets. Additionally
some comments are changed slightly to better
hint on what needs to be done later in v11.

Resolves: #87476
Releases: master
Change-Id: Ib7fe5e4ca29b1c41dd02806e25484e99ef9a41ba
Reviewed-on: https://review.typo3.org/59475
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[!!!][TASK] Drop extension rsaauth 70/59470/9
Christian Kuhn [Thu, 17 Jan 2019 14:24:49 +0000 (15:24 +0100)]
[!!!][TASK] Drop extension rsaauth

Extension rsaauth that has been marked deprecated in v9 due
to its flaws and is dropped from core v10 with this patch.
People who still think not using https but using the
rsaauth extension approach is a good idea can fetch the
extension from ter using an upgrade wizard or
composer require friendsoftypo3/rsaauth.

Needs a typo3/testing-framework raise since the
acceptance tests still used loginSecurityLevel rsa:
composer require --dev typo3/testing-framework ~5.0.4

Resolves: #87470
Releases: master
Change-Id: Iefdd1c4e4b8725e0968875d4b8cb68103634783c
Reviewed-on: https://review.typo3.org/59470
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[!!!][TASK] Remove EXT/extConf configuration handling 82/59482/4
Christian Kuhn [Fri, 18 Jan 2019 12:43:13 +0000 (13:43 +0100)]
[!!!][TASK] Remove EXT/extConf configuration handling

Resolves: #87482
Releases: master
Change-Id: Id644857a9090ab98efaa4a6bf36ee2ec37e169b0
Reviewed-on: https://review.typo3.org/59482
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[!!!][TASK] Drop handling of M$ prefixed passwords 87/59487/10
Christian Kuhn [Fri, 18 Jan 2019 14:04:34 +0000 (15:04 +0100)]
[!!!][TASK] Drop handling of M$ prefixed passwords

Passwords prefixed with M$ in fe_user or be_user table
are passwords that have been previously stored as simple md5
and have been converted to salted md5 using the saltedpasswords
converter task. That task has been removed in v9 already and
affected only users who did not log in for ages (multiple
core versions), since otherwise their password would have
been upgraded already.
The patch now finally drops the handling of M$ prefixed
passwords. If there are still users like that, they have
to have their password reset by and editor or admin user.

Resolves: #87489
Releases: master
Change-Id: I2d98476e91dd40c60a1084f9b05cf4ce7b9c5829
Reviewed-on: https://review.typo3.org/59487
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Adapt tests concerning fluid viewhelpers 74/59474/6
Anja Leichsenring [Fri, 18 Jan 2019 10:13:34 +0000 (11:13 +0100)]
[BUGFIX] Adapt tests concerning fluid viewhelpers

Since the release of fluid 2.6.0 unit tests fail due to
changed calling sequence. The unit tests use mocked calls
to keep track of internal sequence.
Using the prophecy mock framework gives better control and fixes
the issue for now.

Resolves: #87474
Releases: master, 9.5
Change-Id: I371ae8c7793ae74ecc827696cbbb97c30b3862f8
Reviewed-on: https://review.typo3.org/59474
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[!!!][TASK] Remove deprecated code from extensionmanager 80/59480/2
Christian Kuhn [Fri, 18 Jan 2019 12:02:07 +0000 (13:02 +0100)]
[!!!][TASK] Remove deprecated code from extensionmanager

Resolves: #87480
Releases: master
Change-Id: I9fcb2a9ace87d12f96c8ff3463358349b57841bd
Reviewed-on: https://review.typo3.org/59480
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>