Packages/TYPO3.CMS.git
7 years ago[BUGFIX] Hide the field "Selected Pages" for menu type "Sitemap"
Marco Huber [Fri, 13 Apr 2012 14:35:47 +0000 (16:35 +0200)]
[BUGFIX] Hide the field "Selected Pages" for menu type "Sitemap"

The field "Selected Pages" is never used in the content element
"Menu/Sitemap" with menu type "Sitemap". So it should not be
shown in the backend.

Change-Id: I9464ff29fc9fd9864a404cfb14f0545b3e186366
Fixes: #35944
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/12016
Reviewed-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Galinski
Tested-by: Stefan Galinski
7 years ago[BUGFIX] redirect to referrer when changing password
Jigal van Hemert [Sun, 1 Jan 2012 22:05:47 +0000 (23:05 +0100)]
[BUGFIX] redirect to referrer when changing password

The referrer and referrerDomains redirect options must be ignored after
changing the password, otherwise you would end up on the page where the
change password form was displayed (which shows an error message now).
An extra option to ignore the referrer redirects is introduced for this.

Change-Id: I6daeb685f0656f56797a2cb2decc5982a5cf525c
Fixes: #21943
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/11754
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years agoBUGFIX] Illegal string offset
Jigal van Hemert [Mon, 28 May 2012 20:36:43 +0000 (22:36 +0200)]
BUGFIX] Illegal string offset

Check if parameter is an array before using it as an array in
getPagePath() and getPageInfo()

Change-Id: I96cbdcc5e6677d980100f53a76a74b3cb13e1068
Fixes: #37553
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/11668
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[TASK] Set TYPO3 version to 4.5.17-dev
TYPO3 v4 Release Team [Tue, 22 May 2012 10:00:09 +0000 (12:00 +0200)]
[TASK] Set TYPO3 version to 4.5.17-dev

Change-Id: I1d05a6bdacf125bb31c3cf53e03a6c867b5aead5
Reviewed-on: http://review.typo3.org/11440
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[RELEASE] Release of TYPO3 4.5.16
TYPO3 v4 Release Team [Tue, 22 May 2012 09:59:58 +0000 (11:59 +0200)]
[RELEASE] Release of TYPO3 4.5.16

Change-Id: Ib7f13d1db2f4bee84ac038f8198cbe09051b19e4
Reviewed-on: http://review.typo3.org/11439
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[TASK] Raise submodule pointer
TYPO3 v4 Release Team [Tue, 22 May 2012 09:53:08 +0000 (11:53 +0200)]
[TASK] Raise submodule pointer

Change-Id: Ic4c3b01935c82169ed30195f340359c7b88f25ad
Reviewed-on: http://review.typo3.org/11435
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[BUGFIX] Pagetree: Copying large branches duplicates branch
Steffen Gebert [Sat, 11 Feb 2012 15:52:03 +0000 (16:52 +0100)]
[BUGFIX] Pagetree: Copying large branches duplicates branch

Copying large branches (500+ pages, depending on the server) has a big
problem: The AJAX request is answered too late (after Ext.Direct
timeout), so Ext.Direct will resend the request. This will copy the
branch once again. So the copied branch appears twice after copying.

The whole process fails with a connection timeout error message and the
user has to reload the page tree.

Change-Id: I133566bf12c7511f7e8ef9cb9e6ff8683f07249c
Resolves: #26993
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/11336
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Add a comment for require_once in t3lib_error_ErrorHandler
Oliver Klee [Sun, 20 May 2012 16:03:51 +0000 (18:03 +0200)]
[TASK] Add a comment for require_once in t3lib_error_ErrorHandler

These require_once calls are needed to make the exception classes
available even if the autoloader is not loaded at this point yet.

The comment point this out and (hopefully) keeps people from deleting
the require_once calls as part of some clean up.

Resolves: #37335
Relates: #23444, #36061

Change-Id: Ie226b67f44ea0c3cbd17fa9e52018dbf8d8b58d4
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/11389
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] PHP warning when a language pack does not exist
Xavier Perseguers [Wed, 9 May 2012 07:48:05 +0000 (09:48 +0200)]
[BUGFIX] PHP warning when a language pack does not exist

If PHP warnings are not catched, file_get_contents issues a warning
message whenever a file cannot be retrieved.

Change-Id: Icdf7c767e9672a6ff632a1f98542e2f97c0dcbc7
Fixes: #36976
Releases: 4.5, 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/11356
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[BUGFIX] DB field names exceed max length with 'zzz_deleted'
Tolleiv Nietsch [Sun, 20 May 2012 12:42:47 +0000 (14:42 +0200)]
[BUGFIX] DB field names exceed max length with 'zzz_deleted'

MySQL allows a maximum of 64 characters for column and table names.
When prefixing them with 'zzz_deleted' this limit might be reached
by accident. (e.g. with
'zzz_deleted_tx_powermail_tellAFriendForm_receiverEmailContentField')

The patch avoids the overstepping 64 characters.

At the same time the prefixed and shortened field names are more
likely to have the same name, therefore the names are cut
from the beginning.

Change-Id: I7e377e9fe26894b1c6e6b80b1b787e88b5df6087
Fixes: #33580
Releases: 4.5, 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/11330
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Regression of "better condition in versionOL of t3lib_tstemplate"
Andy Grunwald [Wed, 9 May 2012 08:45:56 +0000 (10:45 +0200)]
[BUGFIX] Regression of "better condition in versionOL of t3lib_tstemplate"

versionOL in t3lib_tstemplate can cause a fatal error for
scripts like eID that run in frontend mode, but without a full
blown frontend environment.

The patch replaces the frontend check with a more specific test
for the required methods.

Change-Id: If7712903b96922ea3da51218d3ed5ff2496168f8
Related: #31139, #25144
Resolves: #36981
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/11097
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[BUGFIX] Properly quote regexp in Install Tool
Jigal van Hemert [Fri, 30 Mar 2012 20:46:39 +0000 (22:46 +0200)]
[BUGFIX] Properly quote regexp in Install Tool

Characters with a special meaning must be properly quoted
if they appear in a regular expression.

Change-Id: I2587acb9d0f61a441be6e13dcaba7b7ca0fc82bc
Releases: 6.0, 4.7, 4.6, 4.5
Resolves: #35410
Reviewed-on: http://review.typo3.org/11326
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Install Tool: Settings added by extensions can be edited
Christian Kuhn [Sun, 20 May 2012 12:05:53 +0000 (14:05 +0200)]
[BUGFIX] Install Tool: Settings added by extensions can be edited

Change-Id: I13f3ec8a1f10029ce2b6e421bcc97be2e1276ca3
Fixes: #25213
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/11324
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Wrong DB fields usage in TCEmain
Felix Nagel [Wed, 16 May 2012 13:11:52 +0000 (15:11 +0200)]
[BUGFIX] Wrong DB fields usage in TCEmain

The fix for issue #35260 introduced a new bug in method
t3lib_TCEmain::getPreviousLocalizedRecordUid() by adding a
field in a query in the wrong place. In particular, this breaks
the localization of tt_content elements used with IRRE.

This patch fixes the problem by separating the list of fields
used for selecting and for sorting.

Change-Id: Idac10ded43e817f22df34e5156b424829d4601c1
Fixes: #37221
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/11292
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Missing bottom margin in the page tree
Stefan Galinski [Fri, 13 Apr 2012 14:01:04 +0000 (16:01 +0200)]
[BUGFIX] Missing bottom margin in the page tree

This fixes the UI issue with the deletion overlay and drag&drop
with nodes at the very bottom of the page tree viewport too.

Change-Id: I5cee23ea9441fcd1910a998547772bc3f2e53fb5
Fixes: #35182
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/11258
Reviewed-by: Stefan Galinski
Tested-by: Stefan Galinski
7 years ago[BUGFIX] Wrong label reference for backend_layout
Markus Klein [Mon, 14 May 2012 12:37:08 +0000 (14:37 +0200)]
[BUGFIX] Wrong label reference for backend_layout

tbl_pages.php references non-existing labels.
Actually they have different names.

Change-Id: I0093979c18278238d0825e8033bdb2ed661c5e9d
Releases: 6.0, 4.7, 4.6, 4.5
Fixes: #37158
Reviewed-on: http://review.typo3.org/11196
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Pagetree doesn't expands to the last saved state
Stefan Galinski [Thu, 10 May 2012 17:51:11 +0000 (19:51 +0200)]
[BUGFIX] Pagetree doesn't expands to the last saved state

Change-Id: I0518d9dd06c7d126dfe5d885e4b2751b7e7462b6
Releases: 6.0, 4.7, 4.6, 4.5
Fixes: #36459
Reviewed-on: http://review.typo3.org/11188
Reviewed-by: Stefan Galinski
Tested-by: Stefan Galinski
7 years ago[BUGFIX] tx_rsaauth_sv1::authUser() gives PHP notice
Xavier Perseguers [Mon, 19 Sep 2011 21:12:00 +0000 (23:12 +0200)]
[BUGFIX] tx_rsaauth_sv1::authUser() gives PHP notice

PHP Runtime Notice: Declaration of tx_rsaauth_sv1::authUser() should
be compatible with that of tx_sv_auth::authUser().

Change-Id: Idbd7ca2b69d3142497b1770088d991901950a852
Fixes: #30057
Releases: 4.5
Reviewed-on: http://review.typo3.org/9799
Reviewed-by: Philipp Gampe
Reviewed-by: Oliver Klee
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[BUGFIX] EM: improve action icons alignment
Francois Suter [Fri, 27 Apr 2012 07:41:21 +0000 (09:41 +0200)]
[BUGFIX] EM: improve action icons alignment

In both extensions list of the new EM (available and import), the
action icons are flush with the top of each table row. Instead
they should be aligned with the extension icon.

Change-Id: Ied1b60b6fe7bf163636b388aded29ea51a420965
Fixes: #36611
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/10977
Reviewed-by: Francois Suter
Tested-by: Francois Suter
7 years ago[BUGFIX] EM: avoid cropping action columns
Francois Suter [Fri, 27 Apr 2012 07:09:51 +0000 (09:09 +0200)]
[BUGFIX] EM: avoid cropping action columns

In some browsers the action icons of the new EM disappear, to be
replaced by an ellipsis (...). This is due to ExtJS using
"text-overflow: ellipsis" and some browsers miscalculating the
width of the column. This text-overflow directive is not necessary
as the icons fit nicely anyway.

Change-Id: I44a59c508dba31a4439302237d055a88463c3f82
Fixes: #30900
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/10879
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[BUGFIX] t3lib_div::getUrl() throws a warning on nonexisting local file
Philipp Gampe [Fri, 20 Apr 2012 18:45:49 +0000 (20:45 +0200)]
[BUGFIX] t3lib_div::getUrl() throws a warning on nonexisting local file

During #35847 the silent operator was removed from file_get_content()
which should not have happend.

Change-Id: Ifb12b5f5b20234f1a218c43d4f3882de16b7f0a0
Related: #35847
Fixes: #36380
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/10868
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] cropHTML with dash in html element
Jakub Cernek [Fri, 10 Jun 2011 20:52:00 +0000 (22:52 +0200)]
[BUGFIX] cropHTML with dash in html element

Allow dash in regular expression of cropHTML function. It is needed
for recognition of W3C non-standard TYPO3 'link' element syntax.
(e.g. <link email@example.org - mail "Open email window">
email@example.org</link>)

Change-Id: I4bc8c5bfd196f80a3ee6d077ac6a760aa349486e
Fixes: #26915
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/10692
Reviewed-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Wrong HTTP protocol in combination with a proxy
Michael Staatz [Fri, 13 Apr 2012 18:46:11 +0000 (20:46 +0200)]
[BUGFIX] Wrong HTTP protocol in combination with a proxy

When a reverse proxy is configured in $TYPO3_CONF_VARS and you call
t3lib_div::getIndpEnv('TYPO3_SSL') it returns the wrong protocol.

You can reproduce this in the following way:
If realUrl has the configuration to take the next higher level in the
page tree in the case of not finding the current page then the protocol
will be changed by the static method t3lib_div::getIndpEnv('TYPO3_SSL')

Change-Id: I6fdf61df8597fb84b822fa840475182643b0b134
Fixes: #36004
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/10685
Reviewed-by: Michael Staatz
Tested-by: Michael Staatz
Reviewed-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Remove duplicate domain from FE copyright comment
Tomita Militaru [Fri, 27 Apr 2012 09:31:44 +0000 (12:31 +0300)]
[BUGFIX] Remove duplicate domain from FE copyright comment

Since typo3.com was replaced by typo3.org, current frontend copyright
comment shows duplicate domain in copyright:
TYPO3 is copyright 1998-2012 of Kasper Skaarhoj. Extensions are
copyright of their respective owners. Information and contribution
at http://typo3.org/ and http://typo3.org/

Change-Id: Id0647274974032f20a1b5a050e439ed43213bcdb
Fixes: #36164
Releases: 4.5, 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/10850
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Show phpinfo() header title
Tomita Militaru [Thu, 26 Apr 2012 16:06:51 +0000 (19:06 +0300)]
[BUGFIX] Show phpinfo() header title

This is a no-brainer, fixes the bug with the title of
phpinfo() in the Install Tool being hidden from CSS.

Change-Id: If33a836a606b9c861cbf897a518bd68ed9118d3f
Fixes: #34686
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/10847
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Hide relations to deleted records
Francois Suter [Tue, 24 Apr 2012 15:46:10 +0000 (17:46 +0200)]
[BUGFIX] Hide relations to deleted records

When displaying a column containing MM-relations in Web > List
view, deleted records will show up, because the MM relations still
exist and the foreign table is not checked for deleted records.

Additionally an empty result in this case should display "N/A"
just like for the other situations.

Change-Id: I71a244929ce69d7fd39c1038cb05d8c8414eb346
Fixes: #21713
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/10814
Reviewed-by: Francois Suter
Tested-by: Francois Suter
7 years ago[BUGFIX] Localize command must preserve type
Francois Suter [Thu, 29 Mar 2012 11:16:42 +0000 (13:16 +0200)]
[BUGFIX] Localize command must preserve type

When the TCEmain command "localize" is used on a table that has
a type attribute, this type is not copied automatically. This
may lead to a discrepancy between the parent record and its
translations. The type must be copied when localizing.

Change-Id: I6432b11253f97dccee48d26de45861c4f3742aa3
Fixes: #35361
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/10705
Reviewed-by: Francois Suter
Tested-by: Francois Suter
7 years ago[BUGFIX] Missing static keyword for addFieldsToUserSettings
Susanne Moog [Sat, 21 Apr 2012 10:14:16 +0000 (12:14 +0200)]
[BUGFIX] Missing static keyword for addFieldsToUserSettings

All t3lib_extMgm methods are meant to be called statically.
The function addFieldsToUserSettings is missing the static keyword.

Change-Id: I7f2a31958daaddb923dcd451a5792ca93a30fdfc
Fixes: #36399
Releases: 4.5,4.6,4.7,6.0
Reviewed-on: http://review.typo3.org/10676
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Pagetree broken due to JavaScript exception
Steffen Ritter [Tue, 18 Oct 2011 11:44:51 +0000 (13:44 +0200)]
[BUGFIX] Pagetree broken due to JavaScript exception

Sometimes (especially with empty DB Mount) the Pagetree is
broken and stops with a JavaScript Exception. This is due to
some problems with the state-restore logic, where the state
of not-yet-rendered nodes is applied.

Change-Id: Ie2a48a02341819c7816461b354cec68306bfa35a
Fixes: #28687
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/10626
Reviewed-by: Kay Strobach
Tested-by: Kay Strobach
Reviewed-by: Jo Hasenau
Tested-by: Jo Hasenau
Reviewed-by: Henrik Ziegenhain
Tested-by: Henrik Ziegenhain
Tested-by: Philipp Kitzberger
Reviewed-by: Stefan Rotsch
Tested-by: Stefan Rotsch
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years ago[BUGFIX] Backend: Fetch correct overlay-version of page inside workspace
Stefan Neufeind [Sun, 26 Feb 2012 23:01:29 +0000 (00:01 +0100)]
[BUGFIX] Backend: Fetch correct overlay-version of page inside workspace

When fetching page-details while using inside a workspace
make sure to fetch the correct overlay.

Change-Id: I4a9b98550a1ca7d032f6bb4382f6e06ae70a9564
Resolves: #27811
Releases: 4.5, 4.6, 4.7, 4.8
Reviewed-on: http://review.typo3.org/9792
Reviewed-by: Stefan Neufeind
Reviewed-by: Timo Webler
Tested-by: Timo Webler
Reviewed-by: Thorsten Kahler
Tested-by: Thorsten Kahler
7 years ago[TASK] Set TYPO3 version to 4.5.16-dev
TYPO3 v4 Release Team [Tue, 17 Apr 2012 09:22:14 +0000 (11:22 +0200)]
[TASK] Set TYPO3 version to 4.5.16-dev

Change-Id: I49e9f85bbcb68be9e10dcf2ecffcc9733d58f00e
Reviewed-on: http://review.typo3.org/10574
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[RELEASE] Release of TYPO3 4.5.15
TYPO3 v4 Release Team [Tue, 17 Apr 2012 09:22:06 +0000 (11:22 +0200)]
[RELEASE] Release of TYPO3 4.5.15

Change-Id: I384bd01320a511cb03235566d4b599e6aee3f084
Reviewed-on: http://review.typo3.org/10573
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[SECURITY] XSS in exception handler
Oliver Klee [Tue, 17 Apr 2012 09:10:46 +0000 (11:10 +0200)]
[SECURITY] XSS in exception handler

Change-Id: Id4c3a2cfeb95f4dbf20a2e50b052b2ab75032211
Releases: 6.0, 4.7, 4.6, 4.5, 4.4
Fixes: #34348
Security-Review: http://review.typo3.org/10312
Security-Commit: 6b2b6590356a4aca7d8cc5dfbdfa3356edee091d
Security-Bulletin: TYPO3-CORE-SA-2012-002
Reviewed-on: http://review.typo3.org/10566
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[TASK] Raise submodule pointer
TYPO3 v4 Release Team [Tue, 17 Apr 2012 09:01:35 +0000 (11:01 +0200)]
[TASK] Raise submodule pointer

Change-Id: I5e16e9b814fc6a9fe0fc2e8c2dccb4b082928ba6
Reviewed-on: http://review.typo3.org/10561
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[BUGFIX] Localisation update doesn't work
Sebastian Fischer [Sat, 14 Apr 2012 10:01:32 +0000 (12:01 +0200)]
[BUGFIX] Localisation update doesn't work

Change-Id: I3353dfa5425fab87186dfbb9174bc71ec0acee86
Fixes: #36027
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/10520
Reviewed-by: Stefan Galinski
Tested-by: Stefan Galinski
7 years ago[TASK] Change hardcoded URL to constant
dkd-egerer Sascha Egerer [Sat, 14 Apr 2012 14:56:30 +0000 (16:56 +0200)]
[TASK] Change hardcoded URL to constant

Change hardcoded typo3.org url to the
constant TYPO3_URL_GENERAL in class.typo3logo.php

Change-Id: Ic56d5c3f1b8cadb408cc3f370526988c21c921e6
Resolves: #34742
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/10479
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Saving Page Tree states issues in large environments
cybercraft [Thu, 12 Apr 2012 15:26:07 +0000 (17:26 +0200)]
[BUGFIX] Saving Page Tree states issues in large environments

Change the way expanded nodes are saved for be_users back to a simple
key/boolean pair and adjust the size of the uc field to fit the needs of
larger page trees.

Change-Id: Ic926080b0dc0e6e24226ab00554091a5f0ffae66
Resolves: #24884
Releases: 4.5
Reviewed-on: http://review.typo3.org/10348
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Galinski
Tested-by: Stefan Galinski
7 years ago[BUGFIX] Fix the unit tests to work with PHPUnit 3.6
Oliver Klee [Fri, 6 Apr 2012 23:54:46 +0000 (01:54 +0200)]
[BUGFIX] Fix the unit tests to work with PHPUnit 3.6

Phpunit 3.6 is no longer able to test for a generic Exception
class. The main part of this patch changes generic Exceptions to
better detailed subclasses to give more information on the error.

Change-Id: I286ae33bfaffec3e347fbb1a67910aeb3afa623e
Fixes: #35202
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/10352
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Results from live search and opendocs can't be opened
Stefan Galinski [Sat, 24 Mar 2012 16:57:20 +0000 (17:57 +0100)]
[BUGFIX] Results from live search and opendocs can't be opened

Change-Id: I79986576fa7e2f7b9a283c49fa3526e2b70b1d7d
Fixes: #34860
Fixes: #33685
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/10344
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Failing test in caching framework memcache backend
Christian Kuhn [Thu, 12 Apr 2012 12:09:20 +0000 (14:09 +0200)]
[BUGFIX] Failing test in caching framework memcache backend

Bugfix #30162 changed the memcache handling to not throw an exception but
insert a sys_log entry instead in case of connection problems. The patch
removes the according unit test that broke with the
change, since the call to the static syslog is untestable.

Change-Id: I5c3f4189b1d1f975a2a0ca51b420c66667264e65
Resolves: #35897
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/10332
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] t3lib_div::getUrl() providing wrong error information
Ingo Renner [Wed, 11 Apr 2012 11:54:57 +0000 (13:54 +0200)]
[BUGFIX] t3lib_div::getUrl() providing wrong error information

When using t3lib_div::getUrl() with lib file/context it uses
file_get_contents() to read a URL. When this fails it tries to provide the
reason for the error but does not return the actual issue.

The error key in the returned array contains the error retrieved by
error_get_last() which does not provide the error that occurred with
file_get_contents(), but with PHP. Usually this is a notice.

The actual error message of file_get_contents() is in the variable
$http_response_header which is available after calling file_get_contents().

See http://de2.php.net/manual/en/reserved.variables.httpresponseheader.php

Change-Id: I8058db5d2a70a6d94b7c3c511e549cccc8079a2c
Fixes: #35847
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/10258
Reviewed-by: Ingo Renner
Tested-by: Ingo Renner
7 years ago[BUGFIX] Enable XClassing of t3lib_install by replacing new
Kay Strobach [Tue, 27 Mar 2012 11:24:54 +0000 (13:24 +0200)]
[BUGFIX] Enable XClassing of t3lib_install by replacing new

This Fix Replaces 3 occurences of new t3lib_install with
t3lib_div::makeInstance('t3lib_install')

Change-Id: Idddd0ad71b79e5cae06d98af07cc96f24a0a5679
Fixes: #35272
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/10238
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] ext_icon.gif for EXT:impexp
Georg Ringer [Wed, 28 Mar 2012 05:37:25 +0000 (07:37 +0200)]
[BUGFIX] ext_icon.gif for EXT:impexp

Every extension needs an icon, impexp too

Change-Id: I942306e4cb31ad35a57df71e54a55919df69e7c2
Fixes: #35257
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/10209
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] missing parameter for implode
Jigal van Hemert [Sun, 8 Apr 2012 06:27:25 +0000 (08:27 +0200)]
[BUGFIX] missing parameter for implode

Use the preferred syntax for implode()

Change-Id: I0103b3947b73050e99fcfb3cdacb14ea2b873d8b
Releases: 6.0, 4.7, 4.6, 4.5
Fixes: #34695
Reviewed-on: http://review.typo3.org/10195
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[BUGFIX] "Allowed excludefields" misses non-tt_content FlexForms
Kai Vogel [Mon, 9 Jan 2012 20:56:27 +0000 (21:56 +0100)]
[BUGFIX] "Allowed excludefields" misses non-tt_content FlexForms

Extend the "Allowed excludefields" in group access lists to also show
FlexForm fields from other tables than tt_content.

Change-Id: Ieedf2d2f960edf5ef84624edd1acdbb33283bf64
Fixes: #31831
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/10144
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[BUGFIX] preg_spliti should be preg_split
Georg Ringer [Thu, 29 Mar 2012 06:12:37 +0000 (08:12 +0200)]
[BUGFIX] preg_spliti should be preg_split

A typo made out of preg_split a preg_spliti which
of course doesn't exist

Change-Id: Iab3ba56f3cc43eb2ecedf5145d3b2783544efea4
Releases: 4.6, 4.5
Fixes: #34625
Reviewed-on: http://review.typo3.org/10079
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[BUGFIX] Creating new pages via drag'n'drop respects page TS
Philipp Kitzberger [Mon, 19 Mar 2012 15:25:25 +0000 (16:25 +0100)]
[BUGFIX] Creating new pages via drag'n'drop respects page TS

When creating a new page node via drag'n'drop shortcuts in pagetree,
the TCAdefaults.pages array from page TsConfig is now being respected.
This allows to preset certain field values for new pages.

Change-Id: I21c2f84951699469b00a745b62d2a95fb114809e
Fixes: #25021
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/9889
Reviewed-by: Stefan Neufeind
Reviewed-by: Philipp Gampe
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[TASK] Set TYPO3 version to 4.5.15-dev
TYPO3 v4 Release Team [Wed, 28 Mar 2012 12:05:14 +0000 (14:05 +0200)]
[TASK] Set TYPO3 version to 4.5.15-dev

Change-Id: I7b5be1cf88681681b86f6cd7a68d9c3ac2fe7e8c
Reviewed-on: http://review.typo3.org/10040
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[RELEASE] Release of TYPO3 4.5.14
TYPO3 v4 Release Team [Wed, 28 Mar 2012 12:05:05 +0000 (14:05 +0200)]
[RELEASE] Release of TYPO3 4.5.14

Change-Id: Id1b0895fb2cbf16099d6c938d1648b820b1899b3
Reviewed-on: http://review.typo3.org/10039
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[SECURITY] Missing escaping for sys_notes
Georg Ringer [Wed, 28 Mar 2012 11:54:38 +0000 (13:54 +0200)]
[SECURITY] Missing escaping for sys_notes

sys_notes misses an escaping in info module, not in page/list module

Change-Id: I8145299dfc35ec1a3a17d32852987c6fd01575c5
Fixes: #22748
Releases: 6.0, 4.7, 4.6, 4.5, 4.4
Security-Commit: a613e5419862827b791505852622e5e010265a97
Security-Bulletin: TYPO3-CORE-SA-2012-001
Reviewed-on: http://review.typo3.org/10011
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[SECURITY] XSS for extension meta data in About module
Oliver Klee [Wed, 28 Mar 2012 11:54:34 +0000 (13:54 +0200)]
[SECURITY] XSS for extension meta data in About module

Change-Id: I139ab25d50f348341cc0feb3ee358337c2500420
Releases: 6.0, 4.7, 4.6, 4.5, 4.4
Fixes: #30969
Security-Commit: 161de99c2dddb19263477b316c437985484bcd38
Security-Bulletin: TYPO3-CORE-SA-2012-001
Reviewed-on: http://review.typo3.org/10010
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[SECURITY] XSS in show item
Christian Kuhn [Wed, 28 Mar 2012 11:54:30 +0000 (13:54 +0200)]
[SECURITY] XSS in show item

Change-Id: I026fb44afac01e61a861d3b3bc8e99c15c1972e8
Fixes: #29397
Security-Commit: e34600be49087e59941b89025da4e1d75e407970
Security-Bulletin: TYPO3-CORE-SA-2012-001
Reviewed-on: http://review.typo3.org/10009
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[SECURITY] Missing escaping in scheduler
Georg Ringer [Wed, 28 Mar 2012 11:54:26 +0000 (13:54 +0200)]
[SECURITY] Missing escaping in scheduler

A proper escaping is missing for field "frequency"
Sanitize submitted uid

Change-Id: I0025d826e65889e84b1733d66ad93d608de5c6f0
Fixes: #24474
Security-Commit: f32c2f4159b641456e6466ae14a14f893d6c2326
Security-Bulletin: TYPO3-CORE-SA-2012-001
Reviewed-on: http://review.typo3.org/10008
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[SECURITY] XSS in BE file list
Christian Kuhn [Wed, 28 Mar 2012 11:54:22 +0000 (13:54 +0200)]
[SECURITY] XSS in BE file list

Change-Id: Ib4bdd5ce29827919deb8560a9e70d5b4dc0de849
Fixes: #30940
Security-Commit: e7e6aa481d16f9d6e5bcd3961d05bf6e3d5dfb5f
Security-Bulletin: TYPO3-CORE-SA-2012-001
Reviewed-on: http://review.typo3.org/10007
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[SECURITY] XSS possibility in RemoveXSS
Andreas Wolf [Wed, 28 Mar 2012 11:54:19 +0000 (13:54 +0200)]
[SECURITY] XSS possibility in RemoveXSS

RemoveXSS fails to properly remove non printable characters, especially
zero-byte (\x00) chars.

Change-Id: If1caf9bda7338bd47203b55e27c5a99bbdfed3b0
Fixes: #30188
Security-Commit: 1ff7a55aefd3d4c1690e3f35760ea5ef30dab9b2
Security-Bulletin: TYPO3-CORE-SA-2012-001
Reviewed-on: http://review.typo3.org/10006
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[!!!][SECURITY] XSS in filelink element
Georg Ringer [Wed, 28 Mar 2012 11:54:15 +0000 (13:54 +0200)]
[!!!][SECURITY] XSS in filelink element

Add escaping to description and file name of file link content element.
Warning: There is no longer HTML possible in description!

Change-Id: I709af9bb05d84c5a61448b2d0b6ec8f8a20e5ec5
Fixes: #25246
Security-Commit: 7873e7e96e9a6261096910c342fefdcfa9b431bb
Security-Bulletin: TYPO3-CORE-SA-2012-001
Reviewed-on: http://review.typo3.org/10005
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[SECURITY] XSS in be_layouts
Georg Ringer [Wed, 28 Mar 2012 11:54:10 +0000 (13:54 +0200)]
[SECURITY] XSS in be_layouts

Some values from the backend layout configuration
are not properly escaped

Change-Id: Ifc5debc16e29d632f21380c1fb2e410e00633fa7
Fixes: #29536
Security-Commit: f686b42d55688dde6b6bc64f75032c56c09aed4c
Security-Bulletin: TYPO3-CORE-SA-2012-001
Reviewed-on: http://review.typo3.org/10004
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[SECURITY] Information disclosure showing DB name
Georg Ringer [Wed, 28 Mar 2012 11:54:06 +0000 (13:54 +0200)]
[SECURITY] Information disclosure showing DB name

By accessing a cli script in the frontend, it is possible
that the DB name is shown.

Change-Id: I123530c4814dd1ac4a3af6d5eaea3df62dc11297
Fixes: #29060
Security-Commit: 1d43d5ccf1f2d1e6ffbe8600795ea8235e8cd6d3
Security-Bulletin: TYPO3-CORE-SA-2012-001
Reviewed-on: http://review.typo3.org/10003
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[TASK] Raise submodule pointer
TYPO3 v4 Release Team [Wed, 28 Mar 2012 11:46:16 +0000 (13:46 +0200)]
[TASK] Raise submodule pointer

Change-Id: I05969b15725e0b4b72101158fc29ec2f14d1da6e
Reviewed-on: http://review.typo3.org/9985
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[BUGFIX] Missing column in t3lib_TCEmain::getPreviousLocalizedRecordUid
Francois Suter [Tue, 27 Mar 2012 07:52:10 +0000 (09:52 +0200)]
[BUGFIX] Missing column in t3lib_TCEmain::getPreviousLocalizedRecordUid

Method t3lib_TCEmain::getPreviousLocalizedRecordUid() checks for the
"closest" localized record. For content elements it does this per
column, but actually fails because the "colPos" field is not among
the available fields. It must be added to the selection.

Change-Id: I9ee37697484a56345c21938515a265e0f47fe801
Fixes: #35260
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/9961
Reviewed-by: Francois Suter
Tested-by: Francois Suter
7 years ago[TASK] Clean-up PHPdoc comments in t3lib_PageRenderer
Kai Vogel [Thu, 22 Mar 2012 19:01:09 +0000 (20:01 +0100)]
[TASK] Clean-up PHPdoc comments in t3lib_PageRenderer

Back-port of clean-up that was introduced with #27694.

Change-Id: I089c9e47ace839722a532e807949f86dde6917ec
Resolves: #35158
Related: #27694
Releases: 4.5
Reviewed-on: http://review.typo3.org/9814
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[BUGFIX] Instance properties are defined statically
Kai Vogel [Thu, 22 Mar 2012 19:06:41 +0000 (20:06 +0100)]
[BUGFIX] Instance properties are defined statically

Instance properties are defined statically in t3lib_PageRenderer

Change-Id: I245d8a73e9abca8ac3bdef141605b91a09c845e0
Resolves: #35159
Related: #27694
Releases: 4.5
Reviewed-on: http://review.typo3.org/9815
Reviewed-by: Philipp Gampe
Reviewed-by: Oliver Klee
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[TASK] Add missing sql_free_result in alt_doc.php
Wouter Wolters [Mon, 19 Mar 2012 20:22:29 +0000 (21:22 +0100)]
[TASK] Add missing sql_free_result in alt_doc.php

Add missing sql_free_result in alt_doc.php to free hanging
records properly.

Change-Id: Ic6317ddc7810daf987c3801c13f4f968c4d317e9
Resolves: #34771
Releases: 4.8, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/9866
Reviewed-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Tooltips for items in groupfields are not moved
Jigal van Hemert [Sun, 25 Mar 2012 06:57:47 +0000 (08:57 +0200)]
[BUGFIX] Tooltips for items in groupfields are not moved

In groupfields the title attribute of options must also be handled
when moving items.

Change-Id: I5ef76f6648a3e62140ef8984dd7a8b1e8de9bcd8
Fixes: #35176
Releases: 6.0, 4.7, 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/9862
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[BUGFIX] Blank page after Save+Close in page settings
Stefan Galinski [Thu, 23 Feb 2012 22:16:56 +0000 (23:16 +0100)]
[BUGFIX] Blank page after Save+Close in page settings

Change-Id: Idd7647e0e1aaee607203f64c421d6ca235920268
Fixes: #33791
Releases: 4.8, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/9830
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years ago[TASK] Code clean-up in t3lib_PageRenderer
Oliver Hader [Thu, 22 Mar 2012 19:38:05 +0000 (20:38 +0100)]
[TASK] Code clean-up in t3lib_PageRenderer

Change-Id: If57379120c688dc284a83ca5689e51332c0f354c
Resolves: #35160
Releases: 4.5, 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/9816
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-on: http://review.typo3.org/9839
Reviewed-by: Oliver Klee
7 years ago[BUGFIX] Non-static methods in t3lib_cache are called statically
Steffen Müller [Thu, 22 Mar 2012 14:28:26 +0000 (15:28 +0100)]
[BUGFIX] Non-static methods in t3lib_cache are called statically

Change-Id: Iaac0b179afc4aeb08452e5fd658ec046deb1cd5a
Releases: 4.5
Fixes: #35148
Reviewed-on: http://review.typo3.org/9798
Reviewed-by: Georg Ringer
Reviewed-by: Oliver Klee
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[BUGFIX] t3lib_div should contain only static methods
Jigal van Hemert [Thu, 22 Mar 2012 06:40:53 +0000 (07:40 +0100)]
[BUGFIX] t3lib_div should contain only static methods

A few methods don't have the static keyword. This leads to PHP notices.

Change-Id: Ie7d328a4789f577552486fcb4bf441e533ee161d
Fixes: #30050
Releases: 4.5
Reviewed-on: http://review.typo3.org/9795
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Philipp Gampe
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years agoRevert "[BUGFIX] showAccessRestrictedPages doesn't replace links to restricted subpages"
Helmut Hummel [Sun, 11 Mar 2012 20:13:41 +0000 (21:13 +0100)]
Revert "[BUGFIX] showAccessRestrictedPages doesn't replace links to restricted subpages"

Commit 3dd43f601820dac0d5009c0b06f1501899253b51 introduced a major
performance overhead and is reverted for now.

Change-Id: I41311fb2769db1b5d45c249f5bdf90aba60220fc
Releases: 4.8, 4.7, 4.6, 4.5
Resolves: #32756
Reviewed-on: http://review.typo3.org/9552
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Fix baseurl handling of IE with RTE htmlArea in FE and realurl
Stanislas Rolland [Fri, 16 Mar 2012 23:50:44 +0000 (19:50 -0400)]
[BUGFIX] Fix baseurl handling of IE with RTE htmlArea in FE and realurl

Problem: IE does not support document.baseURI and document.URL is
incorrect when using realurl.
Solution: Get first base tag and extract href as base for iframe
document.
Note: Thanks to Christoph Niewerth

Change-Id: Ieeb672cab3f49e2476d5eb063453076039348cb2
Resolves: #30847
Releases: 4.5, 4.6,4.7, master
Reviewed-on: http://review.typo3.org/9709
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] Fatal error 't3lib_lock' does not exist
Oliver Hader [Wed, 14 Mar 2012 09:28:12 +0000 (10:28 +0100)]
[BUGFIX] Fatal error 't3lib_lock' does not exist

The PHP fatal error occurs for the following settings:
$TYPO3_CONF_VARS['SYS']['enableDeprecationLog'] is enabled
$TYPO3_CONF_VARS['BE']['forceCharset'] is not "utf-8" (or empty)
$TYPO3_CONF_VARS['SYS']['enableDeprecationLog'] is set to "file"

Change-Id: Ic4815ab40e60b8bb0d18b0f15261cb09c9d44280
Fixes: #34662
Releases: 4.5, 4.6, 4.7, 4.8
Reviewed-on: http://review.typo3.org/9639
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Oliver Klee
Reviewed-by: Sebastian Michaelsen
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[TASK] Set TYPO3 version to 4.5.14-dev
TYPO3 v4 Release Team [Tue, 13 Mar 2012 09:44:15 +0000 (10:44 +0100)]
[TASK] Set TYPO3 version to 4.5.14-dev

Change-Id: I10b99bfa396c9d5198486fc39879e1af629ee8c7
Reviewed-on: http://review.typo3.org/9603
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[RELEASE] Release of TYPO3 4.5.13
TYPO3 v4 Release Team [Tue, 13 Mar 2012 09:44:05 +0000 (10:44 +0100)]
[RELEASE] Release of TYPO3 4.5.13

Change-Id: I211f6a296be2ffc8f2331c424764266ed8b5cc1a
Reviewed-on: http://review.typo3.org/9602
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[TASK] Raise submodule pointer
TYPO3 v4 Release Team [Tue, 13 Mar 2012 09:33:52 +0000 (10:33 +0100)]
[TASK] Raise submodule pointer

Change-Id: I5addf806fa443362eb53482519bc03d587d4f3b2
Reviewed-on: http://review.typo3.org/9600
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[BUGFIX] Mail sending fails with quoted&encoded e-mail addresses
Dmitry Dulepov [Mon, 5 Mar 2012 10:21:18 +0000 (12:21 +0200)]
[BUGFIX] Mail sending fails with quoted&encoded e-mail addresses

Mail sending fails if the name in the e-mail address is quoted
but requires encoding to base64 or quoted-printable. The
t3lib_div::encodeHeader() function encodes the name without
taking quotation into account.

Change-Id: Id421914c221cfa26e5198c936abdc9156406995b
Resolves: #34526
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/9596
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[BUGFIX] RTE in frontend with IE9: Use IE8 standards mode (TYPO3 4.5)
Stanislas Rolland [Thu, 8 Mar 2012 20:41:43 +0000 (15:41 -0500)]
[BUGFIX] RTE in frontend with IE9: Use IE8 standards mode (TYPO3 4.5)

Problem: TYPO3 4.5 uses ExtJS 3.3 which does not fully support IE9.
Solution: When using RTE in FE, add meta tag instructing IE9 to use
IE8 standards mode.

Change-Id: I6f170a00e5e4f6a80449aed6f9f2a6737ed6a108
Resolves: #34100
Releases: 4.5
Reviewed-on: http://review.typo3.org/9506
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Steffen Ritter
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] Better condition in versionOL of t3lib_tstemplate
Mario Rimann [Sun, 11 Mar 2012 11:54:13 +0000 (12:54 +0100)]
[BUGFIX] Better condition in versionOL of t3lib_tstemplate

Changes the condition to determine whether we're in the
frontend or in the backend.

Change-Id: I989359e25c6f05e3075b2a2403a5ba2487b45c90
Related: #25144
Resolves: #31139
Releases: 4.5
Reviewed-on: http://review.typo3.org/7043
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Oliver Klee
Reviewed-by: Markus Klein
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[BUGFIX] No content in workspace preview when using select.selectFields
Tolleiv Nietsch [Mon, 10 Oct 2011 01:32:02 +0000 (03:32 +0200)]
[BUGFIX] No content in workspace preview when using select.selectFields

The TypoScript property select.selectFields does not consider workspaces
in the frontend rendering process.

Taking the results from #29783 into account.

Change-Id: I6b2b68ed03163e9e0d7dd281aafea8af67fec224
Resolves: #17284
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/4950
Reviewed-by: Oliver Hader
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[BUGFIX] t3lib_BEfunc::getViewDomain() returns wrong or no domain
Jaume Prat [Tue, 22 Nov 2011 09:57:14 +0000 (10:57 +0100)]
[BUGFIX] t3lib_BEfunc::getViewDomain() returns wrong or no domain

If the TYPO3 BE host name is not configured as a sys_domain record
t3lib_BEfunc::getViewDomain() will always return TYPO3 BE host name
and not the first domain of the root line of the page which is
being previewed.

Furthermore, if the TYPO3 BE host name is configured as a sys_domain
but the current root line does not contain a valid domain record,
t3lib_BEfunc::getViewDomain() will return only 'http://' ie. no domain.

Change-Id: I12f2fa3aaee785e4577a93a61aad3b136ae03756
Fixes: #30892
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/9317
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[TASK] Invalid SQL and bad code in tslib_fe
Dmitry Dulepov [Tue, 29 Nov 2011 13:21:10 +0000 (15:21 +0200)]
[TASK] Invalid SQL and bad code in tslib_fe

tslibe_fe::determineId() contains invalid SQL statement (using "!=")
and bad code (variable "$idQ", missing check for start/stop dates).

Change-Id: I72a27bf45c209ef07de6c53272dad7ae3b8c382d
Resolves: #32159
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7409
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[BUGFIX] Invalid "unequal"-statement and string-quoting in SQL
Stefan Neufeind [Mon, 19 Dec 2011 13:24:31 +0000 (14:24 +0100)]
[BUGFIX] Invalid "unequal"-statement and string-quoting in SQL

There are multiple "!=" in SQL statements. They should be "<>".
MySQL understands "!=" for the compatibility with early versions
but it is not a standard SQL and should not be used.

Strings should be enclosed in single-quotes. Some systems use
double-quotes to mark identifiers in contrast to literals.

(Added some small fullQuote-calls along the way for
completeness or dropped quotes where uid is clearly just
an intval.)

Change-Id: If183e3451dac4cebb179b4c1f8c2e0ef6d5a6efd
Resolves: #32161
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8901
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[BUGFIX] Livesearch does not find all pages
Udo Leimberger [Mon, 22 Aug 2011 06:19:34 +0000 (08:19 +0200)]
[BUGFIX] Livesearch does not find all pages

If you are a BE user with various mount points (no admin), live search
does not find all pages.

Change-Id: I67e4fa56a8514f19cfbb8f181655c473a375ea5d
Resolves: #29086
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/7112
Reviewed-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[TASK] Raise submodule pointer
TYPO3 v4 Release Team [Mon, 12 Mar 2012 16:06:42 +0000 (17:06 +0100)]
[TASK] Raise submodule pointer

Change-Id: I6e0dfcb3c8266770831bafc6956ff617b92926c3
Reviewed-on: http://review.typo3.org/9576
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[BUGFIX] *IFSUB ignores l18n_cfg field
Stefan Galinski [Fri, 23 Sep 2011 18:55:00 +0000 (20:55 +0200)]
[BUGFIX] *IFSUB ignores l18n_cfg field

The l18n_cfg field is used to prevent the appearance of the default
language record or any alternative language records that haven't a translation
in the menu. At the first glance it seems to work like expected, because the
expected page records are not visible in a configured frontend menu. If we have a
closer look at this part, we will see that the flag is badly ignored for the
"*IFSUB" record states. This causes that a page record which has no visible
subpages is marked with the hasSubmenu flag.

Change-Id: I59cd0fda4e198ea326b7ad9b26add1cb244d2c82
Resolves: #19925
Releases: 4.7, 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/8939
Reviewed-by: Stefan Galinski
Tested-by: Stefan Galinski
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[TASK] Change typo3.com to typo3.org
Jigal van Hemert [Thu, 8 Mar 2012 22:06:09 +0000 (23:06 +0100)]
[TASK] Change typo3.com to typo3.org

As typo3.com will be redirected to typo3.org
all links inside the Core should be replace too

Change-Id: Ide780688bea3c4a3ce8820521014dc005b00464b
Resolves: #34441
Releases: 4.8,4.7,4.6,4.5
Reviewed-on: http://review.typo3.org/9508
Reviewed-by: Sebastian Fischer
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[TASK] EM: make pop-up window use full screen
Francois Suter [Fri, 9 Sep 2011 10:06:02 +0000 (12:06 +0200)]
[TASK] EM: make pop-up window use full screen

The information pop-up window in the Extension Manager is hard-coded
to some reduced size. Make it use the full screen instead, as it is
modal anyway. This provides more space to view all the information.

Change-Id: Id0721ecbd6224acdc26aee753e935324bf3ee430
Resolves: #29585
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/4882
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Francois Suter
Tested-by: Francois Suter
7 years ago[BUGFIX] Unset stdWrap of select.pidInList
Marc Bastian Heinrichs [Fri, 2 Dec 2011 15:23:20 +0000 (16:23 +0100)]
[BUGFIX] Unset stdWrap of select.pidInList

Using stdWrap features on select.pidInList together with slide will
result in an endless loop because the same parentPids are
selected over and over again till the max execution time is reached.

This patch unsets the stdWrap properties after the first run.

Change-Id: Ib5c3bcbb1618026af1769ccc2c7dfb1e86a26477
Fixes: #28526
Releases: 4.4, 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/8944
Reviewed-by: Sebastian Michaelsen
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Sebastian Fischer
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[BUGFIX] Skip t3lib_divTest::fixPermissionsSetsGroup on MacOS
Oliver Klee [Sat, 9 Jul 2011 09:02:21 +0000 (11:02 +0200)]
[BUGFIX] Skip t3lib_divTest::fixPermissionsSetsGroup on MacOS

This test makes use of posix_getegid which on Mac OS always returns -1,
thus making it useless for getting the effective group ID.

Change-Id: I5a1cc6ceb8613aa4186c99f06e696668f3e9dde4
Resolves: #28017
Releases: 4.6, 4.5, 4.4, 4.3
Reviewed-on: http://review.typo3.org/7125
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[BUGFIX] Localization of child records fails when using MM type relations
Oliver Hader [Wed, 23 Mar 2011 18:19:18 +0000 (19:19 +0100)]
[BUGFIX] Localization of child records fails when using MM type relations

Regular MM references are not localized, however if Inline Relational
Record Editing (IRRE) is used here, it would be the expected behaviour.

Unit tests are available in the irre_tutorial:
http://forge.typo3.org/projects/show/extension-irre_tutorial

Change-Id: Ia966787037acdb5311ebdb043cdfbd06967da5b0
Resolves: #25131
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1987
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Tested-by: Philipp Gampe
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[BUGFIX] Warnings in tcemain on iterating over unset columns
Mario Rimann [Thu, 16 Feb 2012 21:30:18 +0000 (22:30 +0100)]
[BUGFIX] Warnings in tcemain on iterating over unset columns

Adds a check if the TCA for the table has a columns setting at all
before iterating over the columns of that table.

Change-Id: I140058926a32d21192320d007852db2f91b1a6d8
Fixes: #32467
Branches: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/9075
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[BUGFIX] Translated mailform should use localized email
Michael Stucki [Sun, 15 Jan 2012 22:09:10 +0000 (23:09 +0100)]
[BUGFIX] Translated mailform should use localized email

In case mailforms are translated the email adress from the
translated record is ignored.

Change-Id: I4cf05157cff40e68ebe35c1c242af711dc0a3497
Fixes: #17061
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8958
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[BUGFIX] process_datamap doesn't handle existing versions by itself
Bart Dubelaar [Wed, 25 Jan 2012 13:14:28 +0000 (14:14 +0100)]
[BUGFIX] process_datamap doesn't handle existing versions by itself

The process_datamap function in TCEmain expects to receive the ids of the
existing offline counterparts of a record whenever operations are performed in a
workspace. This implies that this has taken into account in all places where
the process_datamap function is called. In some cases this is not properly done, see
bug #32780 and related. The process_cmdmap function does handle this transparently,
so it is desirable to have the same behavior in process_datamap.

This fix implements the translation to versioned records for operations on a single record.
Operations with child records (IRRE) still require the versioned id's, no bugs
 are known that would require this behavior to be changed.

Change-Id: I26618f6b2d4f694a7b5b9b14e1c3d0c343a900ce
Fixes: #32780
Releases: 4.5
Reviewed-on: http://review.typo3.org/8688
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[BUGFIX] getSingleField_typeFlex doesn't respect TSconfig settings
Jo Hasenau [Tue, 16 Aug 2011 15:37:28 +0000 (17:37 +0200)]
[BUGFIX] getSingleField_typeFlex doesn't respect TSconfig settings

Change-Id: Icebe8d08c47aa22941b25007c10e55b99018cfea
Resolves: #29019
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/7117
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[BUGFIX] No image generation with PHP-SAFE_MODE (GM/IM)
Jigal van Hemert [Sat, 10 Mar 2012 18:07:10 +0000 (19:07 +0100)]
[BUGFIX] No image generation with PHP-SAFE_MODE (GM/IM)

With safe_mode enabled all imagemagick/graphicsmagick calls will fail.
Solution is to only apply escapeshellarg if it is useful.

Change-Id: Iefeb7c0974440e93710d23a289fe1082a5128b72
Resolves: #24369
Releases: 4.4, 4.5
Reviewed-on: http://review.typo3.org/1448
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[BUGFIX] Send no-cache headers in t3lib_userauth
Alexander Stehlik [Fri, 1 Apr 2011 17:32:21 +0000 (19:32 +0200)]
[BUGFIX] Send no-cache headers in t3lib_userauth

Adjust headers sent by t3lib_userauth to prevent caching, if
Internet Explorer is used when downloading files through PHP.

Change-Id: I94a3f1b7f05e15cef23519f76127114251a3eabc
Fixes: #24125
Releases: 4.4, 4.5, 4.6, 4.7, 4.8
Reviewed-on: http://review.typo3.org/6698
Reviewed-by: Stefan Neufeind
Reviewed-by: Sebastian Fischer
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[BUGFIX] RTE: Inserting a table is broken
Stanislas Rolland [Wed, 7 Mar 2012 17:59:19 +0000 (12:59 -0500)]
[BUGFIX] RTE: Inserting a table is broken

Problem: The error is related to the color border settings.
Solution: HTMLArea.util.Color.colorToHex should return an empty string
rather than null.

Change-Id: I8dfeaca6fd9b2298c4120bdd4e3d4f76be5d3576
Resolves: #34634
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/9466
Reviewed-by: Stefan Neufeind
Reviewed-by: Jan Loderhose
Tested-by: Jan Loderhose
Reviewed-by: Henrik Ziegenhain
Tested-by: Henrik Ziegenhain
Reviewed-by: Benny Schimmer
Tested-by: Benny Schimmer
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] Error when editing a record with additionalPreviewLanguage and an deleted...
Andreas Wolf [Thu, 1 Sep 2011 17:39:38 +0000 (19:39 +0200)]
[BUGFIX] Error when editing a record with additionalPreviewLanguage and an deleted l18n_parent

The behaviour that causes the error (translated elements are not deleted
when deleting parent) is fixed in recent TYPO3 versions; it is better to
do that additional check anyways (for old installations).

Change-Id: I1eb1b5ed731b86285a54c87e82b738a1841f0d72
Resolves: #17910
Releases: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/6210
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years ago[BUGFIX] Images from TER hosters break SSL
Georg Ringer [Fri, 24 Feb 2012 06:19:13 +0000 (07:19 +0100)]
[BUGFIX] Images from TER hosters break SSL

The logos should be fetched in the same context as the backend.
If https is used there, images are now loaded also via https

Change-Id: I8d210facfe89cbdae2ebd1d07da6cb8c51e5bbdb
Fixes: #34203
Releases: 4.8, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/9439
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[BUGFIX] flock() calls in TYPO3 prevent NFS hosting
Dmitry Dulepov [Mon, 21 Nov 2011 14:13:28 +0000 (16:13 +0200)]
[BUGFIX] flock() calls in TYPO3 prevent NFS hosting

flock() happens in several places in TYPO3. This function does
not work properly on NFS shares. t3lib_lock should be used
instead.

Change-Id: I30392bf06c5e20e27e929fb06d77ee9f96978902
Resolves: #31460
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7506
Reviewed-by: Stefan Neufeind
Reviewed-by: Oliver Klee
Reviewed-by: Ivan Dharma Kartolo
Tested-by: Ivan Dharma Kartolo
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[TASK] Update copyright year to 2012
Ernesto Baschny [Wed, 7 Mar 2012 08:21:34 +0000 (09:21 +0100)]
[TASK] Update copyright year to 2012

Change-Id: Iea990864d55d90d5dc5cf0c3a238e7ede3adc75f
Resolves: #34600
Releases: 4.4, 4.5, 4.6, 4.7, 4.8
Reviewed-on: http://review.typo3.org/9442
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny