Packages/TYPO3.CMS.git
3 months ago[BUGFIX] Keep existing validation errors for recursive domain relations 33/58833/3
Markus Klösges [Mon, 16 Apr 2018 08:43:24 +0000 (10:43 +0200)]
[BUGFIX] Keep existing validation errors for recursive domain relations

Do not overwrite already generated validation errors when a property
validator leads to a recursive validate() call to the currently
validated GenericObjectValidator.

Resolves: #84475
Releases: master, 8.7
Change-Id: Ifbdb28ddcf6a8e7f1517801ebcd6634149b2bd5d
Reviewed-on: https://review.typo3.org/58833
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 months ago[BUGFIX] Fix translated file relation with sql_mode=ONLY_FULL_GROUP_BY 26/58826/2
Mathias Brodala [Wed, 31 Oct 2018 16:34:11 +0000 (17:34 +0100)]
[BUGFIX] Fix translated file relation with sql_mode=ONLY_FULL_GROUP_BY

The SQL mode ONLY_FULL_GROUP_BY enforces all fields used in "GROUP BY"
to be present in "SELECT".

See https://dev.mysql.com/doc/refman/8.0/en/sql-mode.html#sqlmode_only_full_group_by

Resolves: #85159
Releases: master, 8.7
Change-Id: Iff7895dd9703557ca0b91613516bdb3391b4d4f6
Reviewed-on: https://review.typo3.org/58826
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 months ago[BUGFIX] Provide effectivePid for flexforms segment 23/58823/2
Patrick Lenk [Tue, 30 Oct 2018 11:20:36 +0000 (12:20 +0100)]
[BUGFIX] Provide effectivePid for flexforms segment

Custom ckeditor config is now loaded in flexforms.

Resolves: #83809
Related: #81748
Releases: master, 8.7
Change-Id: I9c0fe85d81f3e34209cd52afee18594e49020f54
Reviewed-on: https://review.typo3.org/58823
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 months ago[BUGFIX] Adding 3 to "TYPO" 12/58812/2
Mathias Brodala [Wed, 31 Oct 2018 15:41:11 +0000 (16:41 +0100)]
[BUGFIX] Adding 3 to "TYPO"

On other "TYPO3" references the "3" is present but not on this occurence.
Add the "3" to "TYPO" in order to have "TYPO3".

Releases: master, 8.7
Resolves: #86816
Change-Id: I21cfe6b10ca1757645c407014b3acbc41b7d7570
Reviewed-on: https://review.typo3.org/58812
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
3 months ago[TASK] Add PHP 7.3 to bamboo core v8 testing 08/58808/2
Christian Kuhn [Wed, 31 Oct 2018 10:09:57 +0000 (11:09 +0100)]
[TASK] Add PHP 7.3 to bamboo core v8 testing

Change-Id: I84575fb973027c184ac2f9a65d227adc38d57d07
Resolves: #86812
Releases: 8.7
Reviewed-on: https://review.typo3.org/58808
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 months ago[BUGFIX] Execute scheduler tasks ordered by next execution time 06/58806/2
Sascha Egerer [Tue, 30 Oct 2018 09:52:04 +0000 (10:52 +0100)]
[BUGFIX] Execute scheduler tasks ordered by next execution time

When executing scheduler tasks the next execution time of the task
should be used to define the execution order.

Resolves: #86795
Releases: master, 8.7
Change-Id: Id678c74a60491aa3c8be8a33534b71ac37245217
Reviewed-on: https://review.typo3.org/58806
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] Make the "Stop preview" link clickable when previewing a page (workspaces) 16/58316/4
Guillaume Germain [Tue, 18 Sep 2018 14:28:30 +0000 (16:28 +0200)]
[BUGFIX] Make the "Stop preview" link clickable when previewing a page (workspaces)

Resolves: #86298
Releases: 8.7
Change-Id: I95bde368cff46e0fd02251ad673aefdd6b5f2e6d
Reviewed-on: https://review.typo3.org/58316
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 months ago[TASK] Run functional tests without xdebug on bamboo 02/58802/2
Christian Kuhn [Tue, 30 Oct 2018 14:41:54 +0000 (15:41 +0100)]
[TASK] Run functional tests without xdebug on bamboo

With the increased number of functional tests in v9 we
should squeeze out as much performance as possible from
the tests so waiting for bamboo is not so annoying. Not
loading xdebug gives us roughly 10-30% for functionals.

Resolves: #86801
Releases: master, 8.7
Change-Id: Ic7b9dd4dd0c71799ecb7207fc0e7170f98729545
Reviewed-on: https://review.typo3.org/58802
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] Show correct namespace in example block of CommaSeparatedValueProcessor 00/58800/3
Joerg Boesche [Tue, 30 Oct 2018 13:27:29 +0000 (14:27 +0100)]
[BUGFIX] Show correct namespace in example block of CommaSeparatedValueProcessor

Resolves: #86800
Releases: master, 8.7
Change-Id: I243589ee7e619f26e99e27d34c626e848a1ee80a
Reviewed-on: https://review.typo3.org/58800
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
3 months ago[BUGFIX] Update karma 98/58798/3
Andreas Fernandez [Tue, 30 Oct 2018 11:49:07 +0000 (12:49 +0100)]
[BUGFIX] Update karma

karma is used for JavaScript based unit tests. The currently installed
version is aged and doesn't compile on newer systems anymore, thus the
package is updated to a recent version.

Used command:
yarn add karma@^3.1.0 --dev

Resolves: #86798
Releases: master, 8.7
Change-Id: I1cea78cf3759227a2cd09b8560f37121ae580202
Reviewed-on: https://review.typo3.org/58798
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[TASK] Test fully built css in bamboo 91/58791/2
Christian Kuhn [Tue, 30 Oct 2018 08:28:11 +0000 (09:28 +0100)]
[TASK] Test fully built css in bamboo

Extend the "Lint scss ts" bamboo job to also build css
next to js and only after that verify with git status
no file changed. This should prevent outdated css as
recently fixed with #86789.
Additionally switch from npm to direct grunt calls,
to be in sync with runTests.sh and to allow kicking
npm from the docker images entirely.

Change-Id: I5134d43c5f5d524005242eee59aa743b6e49219a
Resolves: #86794
Related: #86789
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/58791
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[TASK] Set TYPO3 version to 8.7.21-dev 93/58793/2
Oliver Hader [Tue, 30 Oct 2018 10:41:02 +0000 (11:41 +0100)]
[TASK] Set TYPO3 version to 8.7.21-dev

Change-Id: I133eea5842cb0fc03d7f0b8b3bbbf6180e971d64
Reviewed-on: https://review.typo3.org/58793
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[RELEASE] Release of TYPO3 8.7.20 92/58792/2 8.7.20 TYPO3_8-7-20 v8.7.20
Oliver Hader [Tue, 30 Oct 2018 10:39:35 +0000 (11:39 +0100)]
[RELEASE] Release of TYPO3 8.7.20

Change-Id: I0ac38a40730cc8fa5766a79a09ff3e6b739054ee
Reviewed-on: https://review.typo3.org/58792
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[BUGFIX] Re-build backend.css 89/58789/3
Christian Kuhn [Tue, 30 Oct 2018 09:37:20 +0000 (10:37 +0100)]
[BUGFIX] Re-build backend.css

v8 is affected by outdated css similar to master.
`# t3-form-structure-panel` vs `#t3-form-structure-panel`
caused by https://review.typo3.org/#/c/55797/

Change-Id: Ied9227d60637e59b57102be240a4d21bf022a74b
Resolves: #86789
Releases: 8.7
Reviewed-on: https://review.typo3.org/58789
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[TASK] Use typo3/phar-stream-wrapper package 77/58777/3
Oliver Hader [Sun, 26 Aug 2018 20:38:59 +0000 (22:38 +0200)]
[TASK] Use typo3/phar-stream-wrapper package

PharStreamWrapper has been released as standalone package under
the MIT license: https://github.com/TYPO3/phar-stream-wrapper

Stream invocation is handled by the new composer package, previous
classes PharStreamWrapper and PharStreamWrapperException have been
removed from the TYPO3 core but are still kept in class alias maps
for compatibility reasons. Since the standalone package is now
independent from TYPO3 constraints, the TYPO3 specific logic to
intercept Phar invocations has been moved to the new class
PharStreamWrapperInterceptor.

`composer require typo3/phar-stream-wrapper:^3.0.1`

Related: #85984
Resolves: #86666
Releases: 8.7, 7.6
Change-Id: I724c4238d1a8184a8c7c908f16d71c06f87244d8
Reviewed-on: https://review.typo3.org/58777
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[BUGFIX] Render correct paging label 80/58780/2
Andreas Fernandez [Mon, 29 Oct 2018 15:29:16 +0000 (16:29 +0100)]
[BUGFIX] Render correct paging label

In case of paging in any record list, the page browser is rendered in top
and on bottom of ther record list.

The upper browser now renders the paging correctly by calculating the
offset of items of the previous page instead of hard-coding a "1".

Resolves: #86787
Releases: master, 8.7
Change-Id: Ib7c8856f248107ea9d17aeabe83a564189f69abf
Reviewed-on: https://review.typo3.org/58780
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] Pass record info when determining defaultUploadFolder in FileBrowser 75/58775/5
Frans Saris [Fri, 31 Aug 2018 08:21:13 +0000 (10:21 +0200)]
[BUGFIX] Pass record info when determining defaultUploadFolder in FileBrowser

The fileBrowser now passes the related pid, table and field to
getDefaultUploadFolder().

Resolves: #86053
Releases: master, 8.7
Change-Id: I954753ee84b4107b37ba45cbd08917f4c4be17d9
Reviewed-on: https://review.typo3.org/58775
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] Add url for linkToTop in css_styled_content 75/57775/3
Joerg Kummer [Thu, 2 Aug 2018 11:17:38 +0000 (13:17 +0200)]
[BUGFIX] Add url for linkToTop in css_styled_content

This adds current URL to the ToTop link when css_styled_content is used.
Fixes broken linkToTop URL's since config.prefixLocalAnchors was removed.
Also compatible with TYPO3 v7 where compatibility6 is installed
and typoscript config.prefixLocalAnchors is configured.

Resolves: #81202
Releases: 8.7, 7.6
Change-Id: Id7b9f1c24575de297d2ca60af686fd6d299343e2
Reviewed-on: https://review.typo3.org/57775
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Richard Vollebregt <richard.vollebregt@maxserv.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] Allow unicode characters in verifyFileNameAgainstDenyPattern 72/58772/2
Pascal Rinker [Mon, 25 Jun 2018 14:43:32 +0000 (16:43 +0200)]
[BUGFIX] Allow unicode characters in verifyFileNameAgainstDenyPattern

Using (valid) unicode characters in
GeneralUtility::verifyFilenameAgainstDenyPattern was not possible due
to a missing unicode modifier when evaluating regular expressions.
The unicode modifier has been added.
Since unicode errors in regular expressions will lead to `false`
results, it is important to perform type-safe checks against `0`.

Resolves: #67061
Releases: master, 8.7
Change-Id: If3eea7129c92b296b85b93a1f1c81a446a2f5f90
Reviewed-on: https://review.typo3.org/58772
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] Pass FlexForm context to USER display condition 70/58770/2
Nicole Cordes [Thu, 27 Sep 2018 14:23:21 +0000 (16:23 +0200)]
[BUGFIX] Pass FlexForm context to USER display condition

If using a user display condition within a FlexForm field,
the passed information is insufficient and information about the
parsed FlexForm is missing.

Resolves: #86403
Releases: master, 8.7
Change-Id: I9917b3f98f7d7eb4fa3370e1cd2e9a9cd0eef627
Reviewed-on: https://review.typo3.org/58770
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] Registration of multiple additional view models 68/58768/2
Ralf Zimmermann [Fri, 31 Aug 2018 17:17:22 +0000 (19:17 +0200)]
[BUGFIX] Registration of multiple additional view models

The form setup properties within "additionalViewModelModules" must be
written as numerical associative arrays to make it possible that
multiple extensions can extend the form editor with javascript modules.

Resolves: #85710
Releases: master, 8.7
Change-Id: Iaddf1bfd6f4df8d0c01e0c18be9cef458d8d2caf
Reviewed-on: https://review.typo3.org/58768
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] Correctly resolve parameter for USER display condition 67/58767/2
Nicole Cordes [Thu, 27 Sep 2018 13:56:11 +0000 (15:56 +0200)]
[BUGFIX] Correctly resolve parameter for USER display condition

According to the documentation there is no limit of the used
additional parameters. However during parameter processing, there
is a limit of 4 parameters applied. This limit needs to be unset
when dealing with a USER display condition.

Resolves: #85274
Releases: master, 8.7
Change-Id: Ieff6d089cbb5540ab1d3b389eb0511ef993b900d
Reviewed-on: https://review.typo3.org/58767
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] BE checkFullLanguagesAccess check all translated records 65/58765/2
Benni Mack [Sun, 28 Oct 2018 14:12:11 +0000 (15:12 +0100)]
[BUGFIX] BE checkFullLanguagesAccess check all translated records

All translated records are checked for language access in the method
checkFullLanguagesAccess of BackendUserAuthentication

Resolves: #86778
Releases: master, 8.7
Change-Id: I9c0101507c741471a8537a92329a9a66b78fa559
Reviewed-on: https://review.typo3.org/58765
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 months ago[TASK] Use different placeholder than ### 63/58763/2
Benni Mack [Sun, 28 Oct 2018 13:38:22 +0000 (14:38 +0100)]
[TASK] Use different placeholder than ###

preg_quote since PHP 7.3.0 also quotes #.
Simply use a different placeholder.

Resolves: #86586
Releases: master, 8.7, 7.6
Change-Id: I8ed9bd39605341a09347e21dd38c9a1824a01ee5
Reviewed-on: https://review.typo3.org/58763
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 months ago[TASK] Fix continue-statement inside a switch-block 61/58761/2
Stefan Neufeind [Sun, 7 Oct 2018 23:37:18 +0000 (01:37 +0200)]
[TASK] Fix continue-statement inside a switch-block

Calling continue inside a switch-block would work just like break.
This is usually not intended and thus triggers a warning since
PHP 7.3.0.

Resolves: #86589
Releases: master, 8.7, 7.6
Change-Id: Ic35998b8a37bd35110b9d3494f1cf258e845097a
Reviewed-on: https://review.typo3.org/58761
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] Keep update button in linkbrowser for RTE CKEditor on edit 60/58760/2
Joerg Kummer [Sat, 27 Oct 2018 18:21:42 +0000 (20:21 +0200)]
[BUGFIX] Keep update button in linkbrowser for RTE CKEditor on edit

This patch moves the current value of the link into the parameter array
for the linkbrowser to keep the value in all linked actions inside the
linkbrowser for the RTE CKEditor.

This keeps the update button in the page linkhandler,
if an existing page link will be edited.

Resolves: #83545
Releases: master, 8.7
Change-Id: Ia9217057e45a5d94668bb5ac2f111198da9a69d1
Reviewed-on: https://review.typo3.org/58760
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] Fix the extbase CoreCommand with lowest requirements 11/58711/3
Oliver Klee [Fri, 26 Oct 2018 13:00:30 +0000 (15:00 +0200)]
[BUGFIX] Fix the extbase CoreCommand with lowest requirements

The extbase CoreCommand class calls a method that was introduced in
symfony/console 3.2. So the CoreCommand class needs to check whether
the method-to-call actually exists before calling it.

This only affects the 8.7 branch as the master/9LTS branch already
requires a higher version of symfony/console, and 7.6 does not have
the class with the corresponding call yet.

Resolves: #86753
Releases: 8.7
Change-Id: I8dad6abd4b07c23b7520726f120a6116227c33a7
Reviewed-on: https://review.typo3.org/58711
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] Process large list of hashes in chunks updating reference index 56/58756/2
Benni Mack [Sun, 28 Oct 2018 12:12:52 +0000 (13:12 +0100)]
[BUGFIX] Process large list of hashes in chunks updating reference index

The list of old hashes by cleaning up the reference index can
be very long. To avoid exceeding query limits like maximum number
of placeholder per query or the max allowed statement length these
large lists are split into chunks of safe length before processing.

Resolves: #85795
Releases: master, 8.7
Change-Id: Iaebc555fe791f9e41f336bcd30d5b6eb149ad4e9
Reviewed-on: https://review.typo3.org/58756
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 months ago[TASK] Performance optimizations for the form manager module 75/58375/4
Ralf Zimmermann [Mon, 27 Aug 2018 23:10:07 +0000 (01:10 +0200)]
[TASK] Performance optimizations for the form manager module

Speeds up the form manager module and the form plugin especially
if there are many forms within the TYPO3 instance.

Resolves: #86000
Releases: master, 8.7
Change-Id: Ic483029e0d1b1955d58e04496f97862c00b6d6a4
Reviewed-on: https://review.typo3.org/58375
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] Correctly resolve parent folder in AbstractHierarchicalFilesystemDriver 57/58757/2
Nicole Cordes [Wed, 13 Jun 2018 10:08:15 +0000 (12:08 +0200)]
[BUGFIX] Correctly resolve parent folder in AbstractHierarchicalFilesystemDriver

This patch ensures that
AbstractHierarchicalFilesystemDriver::getParentFolderIdentifierOfIdentifier
always returns a file identifier using forward slashes. Furthermore
it removes double forward slashes for a root folder identifier.

Resolves: #85249
Releases: master, 8.7
Change-Id: I562eaade7353e5235d4f65725a4159f6c0b71d75
Reviewed-on: https://review.typo3.org/58757
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] Catch Exceptions in RTE with invalid links 55/58755/2
Benni Mack [Sat, 27 Oct 2018 21:35:40 +0000 (23:35 +0200)]
[BUGFIX] Catch Exceptions in RTE with invalid links

Only one area is covered with catching invalid links when setting
an ugly external URL without proper scheme.

The other area is caught now too.

Resolves: #84009
Releases: master, 8.7
Change-Id: Ief7549009b114803daacf39e36528523718a0d36
Reviewed-on: https://review.typo3.org/58755
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 months ago[BUGFIX] Allow more tags when no RTE processing is available 49/58749/2
Benni Mack [Sat, 27 Oct 2018 21:28:41 +0000 (23:28 +0200)]
[BUGFIX] Allow more tags when no RTE processing is available

If somebody has no RTE extension available, there is also no
RTE processing information available, so the default
from RteHtmlParser is used. However, tags like <abbr>
are then not provided by the yaml configuration, so they are
not allowed, and thus - escaped.

The patch adds abbr,acronym and dfn to be allowed all the time.

Resolves: #83424
Releases: master, 8.7
Change-Id: Ifdc0e7f155bef95a7c397584f2cf7b1eab61f6bb
Reviewed-on: https://review.typo3.org/58749
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] Respect saveDocNew TSConfig option 03/58603/2
Susanne Moog [Tue, 9 Oct 2018 14:21:07 +0000 (16:21 +0200)]
[BUGFIX] Respect saveDocNew TSConfig option

For translated tt_content elements the saveDocNew button
was solely dependent on the free vs. connected mode setup.
However, if the button has been hidden via TSConfig
completely it should not magically reappear when editing a
translation in free mode.

(This patch only applies to TYPO3 8 as the buttons
changed for version 9).

Change-Id: I0f74e87acbac127b8bbc09f4fee39c633a3a49f6
Resolves: #85774
Releases: 8.7
Reviewed-on: https://review.typo3.org/58603
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] Adjust headline decoration in documentation file 54/58754/2
Anja [Sun, 28 Oct 2018 09:36:54 +0000 (10:36 +0100)]
[BUGFIX] Adjust headline decoration in documentation file

Change-Id: Ic30290ba8548049b2c053d1e3bfa4beae1615e24
Resolves: #86775
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/58754
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 months ago[TASK] Have LF line endings for .sh scripts in .gitattributes 53/58753/2
Christian Kuhn [Sun, 28 Oct 2018 09:26:04 +0000 (10:26 +0100)]
[TASK] Have LF line endings for .sh scripts in .gitattributes

Resolves: #86774
Releases: master, 8.7
Change-Id: I8b677426c6011a0b3115f83380ae567582dc9c17
Reviewed-on: https://review.typo3.org/58753
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 months ago[BUGFIX] Linkvalidator validates linked content elements 35/58735/3
Patrick Broens [Mon, 16 Jul 2018 13:49:45 +0000 (15:49 +0200)]
[BUGFIX] Linkvalidator validates linked content elements

This patch makes the LinkValidator check typolinks to tt_content
elements like t3://page?uid=x#y by calling InternalLinktype twice, once
for the page as first part of the SoftReferenceIndex and again for the
tt_content element as second part.

Resolves: #85576
Related: #84016
Releases: master, 8.7
Change-Id: I94243e66f5eff38c9a0b0859a85aac48885e38ba
Reviewed-on: https://review.typo3.org/58735
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] EvaluteDisplayCondition should throw proper error message 36/58736/2
Benni Mack [Sat, 29 Sep 2018 23:42:41 +0000 (01:42 +0200)]
[BUGFIX] EvaluteDisplayCondition should throw proper error message

When an extension author writes a display condition in TCA and
by incident uses a wrong format for the displayCondition (see ticket)
the strtoupper fails due to the lack of an associative array
because it's a numeric-key array.

An additional check fixes the issue.

Resolves: #79692
Releases: master, 8.7
Change-Id: I4455bdc908e0be1a373f86680e718e876aa5ddd7
Reviewed-on: https://review.typo3.org/58736
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 months ago[TASK] Streamline EM dependency resolving 39/58739/2
Josef Glatz [Tue, 18 Sep 2018 20:50:20 +0000 (22:50 +0200)]
[TASK] Streamline EM dependency resolving

Adjust the style of the action accordingly and
add a small description to the main header.

Resolves: #86304
Releases: master, 8.7
Change-Id: I37a199d0a9626d4c87354ada7bce662bb089418f
Reviewed-on: https://review.typo3.org/58739
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 months ago[BUGFIX] Allow relative URLs in locationHeaderUrl 32/58732/4
Susanne Moog [Thu, 25 Oct 2018 20:18:45 +0000 (22:18 +0200)]
[BUGFIX] Allow relative URLs in locationHeaderUrl

Resolves: #81720
Releases: master, 8.7
Change-Id: I099c905bf335a13fafa920c2849fd88971dc0e44
Reviewed-on: https://review.typo3.org/58732
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 months ago[BUGFIX] Recover switched items in maxitems=1 selectMultipleSideBySide 29/58729/2
Kevin von Spiczak [Tue, 9 Oct 2018 11:32:37 +0000 (13:32 +0200)]
[BUGFIX] Recover switched items in maxitems=1 selectMultipleSideBySide

Shows and re-enables all the options, that are currently not selected
when using maxitems = 1

Resolves: #86594
Releases: master, 8.7
Change-Id: I1f5e727ec42203981edaaf4b79bb6e201352d296
Reviewed-on: https://review.typo3.org/58729
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] Prevent null value being passed to hash_equals 13/58713/2
Benni Mack [Fri, 26 Oct 2018 13:41:09 +0000 (15:41 +0200)]
[BUGFIX] Prevent null value being passed to hash_equals

The second parameter of hash_equals must be a string but could be a
null value in the FileDumpController. It is ensured now that the
value is always a string.

Resolves: #86599
Releases: master, 8.7
Change-Id: Iaf682b405be6712aa31603521a2d873b4c3bcb89
Reviewed-on: https://review.typo3.org/58713
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] Remove surrounding &nsbp; in the tables with ol or ul in CKEditor 19/58719/2
Benni Mack [Fri, 26 Oct 2018 15:07:42 +0000 (17:07 +0200)]
[BUGFIX] Remove surrounding &nsbp; in the tables with ol or ul in CKEditor

This patch removes generated &nbsp; in tables with ol or ul inside. This
is unintented behaviour, and we can't manually remove them from table.

Also, I moved HTMLparser section into existing nonTypoTagStdWrap

Resolves: #83795
Releases: master, 8.7
Change-Id: I711e4cbab8249fe6f43c8abe6f63183eaac9131f
Reviewed-on: https://review.typo3.org/58719
Reviewed-by: Nicolai Schirawski <ns@t3magic.de>
Tested-by: Nicolai Schirawski <ns@t3magic.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] Avoid exception of renderType selectCheckBox in workspace 14/58714/2
Alexey Atsyn [Fri, 6 Jul 2018 14:03:50 +0000 (19:03 +0500)]
[BUGFIX] Avoid exception of renderType selectCheckBox in workspace

Resolves: #85109
Releases: master, 8.7
Change-Id: I34a269ec2d564a546d4dc2036a97eb1027d2352f
Reviewed-on: https://review.typo3.org/58714
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] CleanerTask processes all FileResource Fields 10/58710/2
Sven Jürgens [Fri, 1 Jun 2018 13:19:32 +0000 (15:19 +0200)]
[BUGFIX] CleanerTask processes all FileResource Fields

By removing an errorous break in a loop, all FileResource Fields are found
and therefor all connected files can be deleted.

Resolves: #85140
Releases: master, 8.7
Change-Id: I0aea4427dd9e74b1a11ab04e8aa235e17ae1a031
Reviewed-on: https://review.typo3.org/58710
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] Register "then"/"else" in IfHasRoleViewHelper again 02/58702/2
Mathias Brodala [Thu, 25 Oct 2018 09:07:58 +0000 (11:07 +0200)]
[BUGFIX] Register "then"/"else" in IfHasRoleViewHelper again

This fixes the usage of "then" and "else" for the inline notation.

Resolves: #86743
Releases: master, 8.7
Change-Id: Ia0a749fedcb3b3d4ffe7f90ac40ab604fd7c340a
Reviewed-on: https://review.typo3.org/58702
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
3 months ago[TASK] Update php-cs-fixer configuration to exclude _generated directory 84/58684/2
Sybille Peters [Wed, 24 Oct 2018 08:21:38 +0000 (10:21 +0200)]
[TASK] Update php-cs-fixer configuration to exclude _generated directory

Resolves: #86730
Releases: master, 8.7
Change-Id: I9e707e6d9c1305baa92b7f2c4c0f83bbeea52daa
Reviewed-on: https://review.typo3.org/58684
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 months ago[BUGFIX] Remove `fbclid` argument from chash calculation 72/58672/3
Andreas Fernandez [Tue, 23 Oct 2018 06:19:27 +0000 (08:19 +0200)]
[BUGFIX] Remove `fbclid` argument from chash calculation

Facebook adds the `fbclid` argument to outbound URLs which triggers a
recalculcation of the cache hash. The argument is now added to the
blacklist for chash parameters.

Resolves: #86715
Releases: master, 8.7, 7.6
Change-Id: I8cd66fdfa2c549c65750d6ef896261cccba4b54d
Reviewed-on: https://review.typo3.org/58672
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 months ago[TASK] Update Build/yarn.lock 64/58664/2
Christian Kuhn [Sat, 20 Oct 2018 13:01:09 +0000 (15:01 +0200)]
[TASK] Update Build/yarn.lock

Younger yarn versions contain sha sums in the lock file.
Adapt the file so testing has current state again.

Change-Id: I356b00845aee7c7a9ec1e20a1466fa9869b588c8
Resolves: #86702
Releases: 8.7
Reviewed-on: https://review.typo3.org/58664
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Enable v8 acceptance testing again 45/58645/31
Christian Kuhn [Tue, 16 Oct 2018 15:26:18 +0000 (17:26 +0200)]
[TASK] Enable v8 acceptance testing again

core master and typo3/testing-framework received lots
of patches to stabilize the acceptance tests while these
tests remained inactive in v8 branch. The patch ports
the meanwhile pretty stable test changes from master
back to v8 and activates ac testing in bamboo as pre-merge
and nightly again.

composer remove enm1989/chromedriver
composer require --dev typo3/testing-framework ~1.3.0

Change-Id: I68294e1304bf8fd0f7f5a2a35199c6728189286a
Resolves: #86677
Releases: 8.7
Reviewed-on: https://review.typo3.org/58645
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Activate bamboo nightly mssql functional tests 43/58643/4
Christian Kuhn [Tue, 16 Oct 2018 12:45:31 +0000 (14:45 +0200)]
[TASK] Activate bamboo nightly mssql functional tests

The functional tests on mssql in 8.7 were disabled for
while. Enable them for the nightly build again.

* bamboo php70 & php71 contain sqlsrv driver again
* docker setup for mssql
* execute mssql nightly functionals, not pre-merge (too slow)
* backport minor test changes in impexp fixtures

Change-Id: Iae5e9602a0141a236e7765be2ff0ddb18aa7bb24
Resolves: #86673
Releases: 8.7
Reviewed-on: https://review.typo3.org/58643
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
4 months ago[BUGFIX] Use correct variable name in OnlineMedia.js 22/58622/2
Tymoteusz Motylewski [Fri, 12 Oct 2018 13:23:41 +0000 (15:23 +0200)]
[BUGFIX] Use correct variable name in OnlineMedia.js

Resolves: #86630
Releases: master, 8.7
Change-Id: I4bce2665ed54cddc3a151445c5863c24ffac6df6
Reviewed-on: https://review.typo3.org/58622
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
4 months ago[BUGFIX] Correct inline foreign_unique with target type="group" handling 22/58422/4
Cyril Janody [Thu, 27 Sep 2018 22:31:10 +0000 (18:31 -0400)]
[BUGFIX] Correct inline foreign_unique with target type="group" handling

Using type="inline" and MM relations having type="group" (instead of
type="select") and foreign_unique defined results in a fatal since
group db relations have been resolved to an array in TcaGroup data
provider already.

Change-Id: I20d138e7622aafb097a11e60014f9e4398bae811
Resolves: #82104
Resolves: #84735
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/58422
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] pages.content_from_pid suggest wizard should not suggest itself 13/58613/2
Josef Glatz [Tue, 9 Oct 2018 03:51:46 +0000 (05:51 +0200)]
[BUGFIX] pages.content_from_pid suggest wizard should not suggest itself

Make it impossible to select the page you are currently
working on within the suggest wizard result set.

In addition, the suggest has been improved to search also in the
following fields of page records:
* nav_title
* alias
* url

Releases: master, 8.7
Resolves: #86600
Related: #54867
Change-Id: Ifce04fc5f01b5585f2320901b56be8b9970d4762
Reviewed-on: https://review.typo3.org/58613
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
4 months ago[BUGFIX] Let FileBrowser render the readable directory path 10/58610/2
Andreas Fernandez [Tue, 9 Oct 2018 12:46:32 +0000 (14:46 +0200)]
[BUGFIX] Let FileBrowser render the readable directory path

The FileBrowser is changed to render the human readable path of a
directory instead of the raw identifier.

Resolves: #86603
Releases: master, 8.7
Change-Id: I437075cfdeb6adaeddd38a55ff6f4fbd5415a351
Reviewed-on: https://review.typo3.org/58610
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[BUGFIX] Do not cache content with different status code than 200 81/58581/2
Markus Klein [Fri, 5 Oct 2018 08:43:05 +0000 (10:43 +0200)]
[BUGFIX] Do not cache content with different status code than 200

Resolves: #83755
Releases: master, 8.7, 7.6
Change-Id: I6e13133f221137c63283ec1575fc405a38668b1a
Reviewed-on: https://review.typo3.org/58581
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 months ago[TASK] Update typo3/class-alias-loader from 1.0.0 to 1.0.1 67/58567/2
Christian Kuhn [Wed, 3 Oct 2018 13:12:59 +0000 (15:12 +0200)]
[TASK] Update typo3/class-alias-loader from 1.0.0 to 1.0.1

Tiny patch level release with cosmetical fixes.

composer update typo3/class-alias-loader

Resolves: #86555
Releases: master, 8.7, 7.6
Change-Id: Ib949e1aa961ea9aede1eeaebd5da9995a2a65bc0
Reviewed-on: https://review.typo3.org/58567
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 months ago[TASK] Sync .rst changes from master down to v8 and v7 41/58541/2
Christian Kuhn [Mon, 1 Oct 2018 19:27:37 +0000 (21:27 +0200)]
[TASK] Sync .rst changes from master down to v8 and v7

Change-Id: I865a2f40fc32902ed002dd67220f16f0b6d20ccf
Resolves: #86528
Releases: 8.7, 7.6
Reviewed-on: https://review.typo3.org/58541
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 months ago[BUGFIX] Ensure Uri->getQuery() always returns a string 38/58538/2
Daniel Goerz [Mon, 1 Oct 2018 14:47:47 +0000 (16:47 +0200)]
[BUGFIX] Ensure Uri->getQuery() always returns a string

As stated in the Interface:
If no query string is present, this method MUST return an empty string.

Resolves: #86520
Releases: master, 8.7
Change-Id: I9869af08c84262443e503c34a2c608fbc5ba4bc2
Reviewed-on: https://review.typo3.org/58538
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 months ago[BUGFIX] Do not trigger tooltip automatically after hide/unhide 09/58509/2
Frank Naegler [Sun, 30 Sep 2018 20:52:35 +0000 (22:52 +0200)]
[BUGFIX] Do not trigger tooltip automatically after hide/unhide

The tooltip is not shown now, when you move the cursor away, while the
spinning icon is active. The new label still updates, if you keep the
cursor the whole time on the button.

Resolves: #85319
Releases: master, 8.7
Change-Id: Id653a9f6d43c1ca1f6a24112edde18b50286843f
Reviewed-on: https://review.typo3.org/58509
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
4 months ago[BUGFIX] Respect mountpoint variable in cObj menu runtime cache 90/58490/2
Sascha Egerer [Wed, 11 Jul 2018 14:59:22 +0000 (16:59 +0200)]
[BUGFIX] Respect mountpoint variable in cObj menu runtime cache

The mountpoint variable must be respected in the key used for the
menu runtime cache. Without that part in the key all links generated
to a mount-point sub-page will link to the first mount target page
in the menu.

Resolves: #80970
Resolves: #62248
Releases: master, 8.7, 7.6
Change-Id: I8ccfebabd515d6da9f78388de51d24603e9fe532
Reviewed-on: https://review.typo3.org/58490
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 months ago[BUGFIX] Remove tooltip over delete button when it's clicked 75/58475/2
Nikita Hovratov [Sat, 29 Sep 2018 20:05:01 +0000 (22:05 +0200)]
[BUGFIX] Remove tooltip over delete button when it's clicked

The tooltip has to be removed at that point, because as soon as any data
is deleted the row disappears and it's not possible to trigger the
mouseout event manually.

Resolves: #81856
Releases: master, 8.7
Change-Id: I2f7388b6a278de9ba19e81ec20ed3ae0052b1698
Reviewed-on: https://review.typo3.org/58475
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
4 months ago[BUGFIX] Resolve correct processed folder when on different storage 52/58452/2
Helmut Hummel [Thu, 27 Sep 2018 09:34:23 +0000 (11:34 +0200)]
[BUGFIX] Resolve correct processed folder when on different storage

During generation of processed files a wrong processed folder
is evaluated when the processed folder resides on a different storage.

We now ensure to ask the correct storage for the processed folder.

Also ensure that correct storage is used for checking file existence
when original file and processed files are on different storages.

Fixes: #86399
Releases: master, 8.7
Change-Id: I254b9a0bf86a156ae135510a4439e87737ec1a29
Reviewed-on: https://review.typo3.org/58452
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 months ago[BUGFIX] Use correct icon for editing query in ActionTask 45/58445/2
Tymoteusz Motylewski [Fri, 28 Sep 2018 13:03:15 +0000 (15:03 +0200)]
[BUGFIX] Use correct icon for editing query in ActionTask

Resolves: #86423
Releases: master, 8.7
Change-Id: I5c1e0f92fe5f9d28eaaf0250677cd3dedcbd6082
Reviewed-on: https://review.typo3.org/58445
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
4 months ago[TASK] Improve styling of infobox in ImageManipulationElement 44/58444/2
Georg Ringer [Fri, 28 Sep 2018 20:29:07 +0000 (22:29 +0200)]
[TASK] Improve styling of infobox in ImageManipulationElement

The cropping element shows an information if no dimensions are known.
The styling of this information is now improved.

Resolves: #86429
Releases: master, 8.7
Change-Id: I28b6e4da560e591a57e6c849488f59ddf5cd5736
Reviewed-on: https://review.typo3.org/58444
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
4 months ago[BUGFIX] Register FileBrowser for file_reference mode 35/58435/4
Christian Kuhn [Fri, 28 Sep 2018 11:42:35 +0000 (13:42 +0200)]
[BUGFIX] Register FileBrowser for file_reference mode

Using the element browser for a type=group, internal_type=file_reference
TCA field leads to an exception due to a missing registration for
this mode. Register the file browser, similar to internal_type=file.

Resolves: #80541
Releases: master, 8.7
Change-Id: I54be7084f10d63ed262e903c296294589521f3df
Reviewed-on: https://review.typo3.org/58435
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
4 months ago[BUGFIX] Respect "disablePrependAtCopy" during translation 33/58433/2
Gianluigi Martino [Fri, 28 Sep 2018 06:40:01 +0000 (08:40 +0200)]
[BUGFIX] Respect "disablePrependAtCopy" during translation

During the translation process the option "disablePrependAtCopy" is not
respected. With this patch the option is respected again for pages and
tt_content.

Resolves: #86293
Releases: master, 8.7
Change-Id: I821f3fed7d3e0637298262c4bd2c11003618f1c5
Reviewed-on: https://review.typo3.org/58433
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
4 months ago[BUGFIX] VimeoRenderer render private links 32/58432/3
Guido Schmechel [Wed, 26 Sep 2018 18:24:31 +0000 (20:24 +0200)]
[BUGFIX] VimeoRenderer render private links

Now it is also possible to add private Vimeo links.

Releases: master, 8.7
Resolves: #83852
Change-Id: Icb425d4aea98a687b91216fefcd69b5fecc1a01e
Reviewed-on: https://review.typo3.org/58432
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 months ago[BUGFIX] pages.shortcut suggest wizard should not suggest itself 28/58428/2
Josef Glatz [Fri, 28 Sep 2018 04:30:53 +0000 (06:30 +0200)]
[BUGFIX] pages.shortcut suggest wizard should not suggest itself

Make it impossible to select the page you are currently
working on within the suggest wizard result set.

Releases: master, 8.7
Resolves: #86412
Related: #54867
Change-Id: Ibeaacf86061f79cc3d75f181466e5caf96657401
Reviewed-on: https://review.typo3.org/58428
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
4 months ago[BUGFIX] Use correct column order in override dialog 90/58390/2
Andreas Fernandez [Tue, 25 Sep 2018 16:27:46 +0000 (18:27 +0200)]
[BUGFIX] Use correct column order in override dialog

Resolves: #86152
Releases: master, 8.7
Change-Id: I677c6d0405b833caf8a62f7f560b2e9b97679b36
Reviewed-on: https://review.typo3.org/58390
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
4 months ago[BUGFIX] Ensure connection can be established multiple times 96/58196/2
Nicole Cordes [Wed, 5 Sep 2018 11:45:02 +0000 (13:45 +0200)]
[BUGFIX] Ensure connection can be established multiple times

This patch ensures a connection can be established multiple times
and is initialized correctly using the init commands on each fresh
connection call.

Resolves: #86154
Releases: master, 8.7
Change-Id: Ief2fb0855715333b124e8315c5f794008a5fb3d5
Reviewed-on: https://review.typo3.org/58196
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
4 months ago[BUGFIX] Prevent closing a record after changes made with „toggle all“ 07/58407/2
Josef Glatz [Tue, 25 Sep 2018 18:20:16 +0000 (20:20 +0200)]
[BUGFIX] Prevent closing a record after changes made with „toggle all“

This patch prevents closing a form without showing the modal
to inform the backend user about unsaved changes if values of
an element with renderType `selectCheckBox` were changed
through a „toggle all“ checkbox.

Resolves: #86377
Releases: master, 8.7
Change-Id: I8a0ffd7ae0104739fdb66a1863e7012c0d30c84e
Reviewed-on: https://review.typo3.org/58407
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
4 months ago[TASK] Use dark sorting icon in filelist module 76/58376/3
Georg Ringer [Fri, 21 Sep 2018 08:56:00 +0000 (10:56 +0200)]
[TASK] Use dark sorting icon in filelist module

Use the dark icons, just as in the list module.

Resolves: #86345
Releases: master, 8.7
Change-Id: Ife258d11a1384076f1333e2c97a1c0a41599202f
Reviewed-on: https://review.typo3.org/58376
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
4 months ago[TASK] Stabilize Extbase tests on PostgreSQL 80/58380/3
Tymoteusz Motylewski [Sun, 23 Sep 2018 18:54:47 +0000 (20:54 +0200)]
[TASK] Stabilize Extbase tests on PostgreSQL

Resolves: #86360
Releases: master, 8.7
Change-Id: I34e6b720a93bd86f863fbf4ae0b5efb6cccdc76d
Reviewed-on: https://review.typo3.org/58380
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Provide more tests for Extbase rendering in languages 57/58357/6
Tymoteusz Motylewski [Fri, 14 Sep 2018 12:05:47 +0000 (14:05 +0200)]
[TASK] Provide more tests for Extbase rendering in languages

Some tests are just documenting current, buggy behavior.
So once bugs are fixed assertions needs to be updated.
See inline comments for details (and list of related issues below).

Resolves: #86327
Related: #45873
Related: #68672
Releases: master
Change-Id: I780f77fa95d3824a2dafd58a1a73df2bb5fac9e4
Reviewed-on: https://review.typo3.org/58357
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
4 months ago[TASK] Extend blog_example with relations 62/58362/7
Tymoteusz Motylewski [Fri, 24 Aug 2018 16:55:29 +0000 (18:55 +0200)]
[TASK] Extend blog_example with relations

* 1:1 inline relation csv (Post->additonalName)
* 1:1 inline relation foreign_field (Post->additonalInfo)
* 1:n inline relation csv (Post->additionalComments)
* n:1 group relation (Post->secondAuthor)

It also makes Person model translatable.

Resolves: #85974
Releases: master, 8.7
Change-Id: I75a8e6c070e9a6bdfba0772b102a13bc94f7556f
Reviewed-on: https://review.typo3.org/58362
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 months ago[BUGFIX] Fetch configuration of FlexForm fields in edit wizard 39/58339/3
Christian Kuhn [Wed, 19 Sep 2018 11:37:49 +0000 (13:37 +0200)]
[BUGFIX] Fetch configuration of FlexForm fields in edit wizard

Supply flex data structure identifier and current path to
editPopup field control to fetch correct TCA config if this
wizard is enabled for select or group fields in flex forms.

Resolves: #78422
Releases: master, 8.7
Change-Id: Ic628824abb36e23935ad9b493a2e401fe8e734c7
Reviewed-on: https://review.typo3.org/58339
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 months ago[TASK] Update styleguide to 8.0.15 47/58347/3
Christian Kuhn [Thu, 20 Sep 2018 09:32:09 +0000 (11:32 +0200)]
[TASK] Update styleguide to 8.0.15

A series of smaller patches have been applied to
v8 maintenance branch of the styleguide extension.

composer require --dev typo3/cms-styleguide:~8.0.15

Change-Id: I67d637d860f68ae90aa295528f5dd3cdbd168aee
Resolves: #86324
Releases: 8.7
Reviewed-on: https://review.typo3.org/58347
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[BUGFIX] Handle formEngine add wizard select in flex forms 38/58338/2
Christian Kuhn [Wed, 19 Sep 2018 10:27:58 +0000 (12:27 +0200)]
[BUGFIX] Handle formEngine add wizard select in flex forms

addRecord fieldControl fails for type=select fields
in flex forms in AddController since existing values
are not resolved to an array structure as it is done
for type=group fields. Handle that case.

Resolves: #86313
Related: #82049
Releases: master, 8.7
Change-Id: I59e6cb1c11adf1ac7ebaf0293daad24aa1fd01b4
Reviewed-on: https://review.typo3.org/58338
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[BUGFIX] Add missing language file for ContextMenu 18/58318/2
Stefan Froemken [Tue, 4 Sep 2018 15:01:29 +0000 (17:01 +0200)]
[BUGFIX] Add missing language file for ContextMenu

Confirmation Modal shows buttons with translated button labels now, if
you try to delete a page from page-tree.

Resolves: #79879
Releases: master, 8.7
Change-Id: Iff2ed8205bdcc54b48ba301035cd0aac9c2de826
Reviewed-on: https://review.typo3.org/58318
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[BUGFIX] Fix casting in GalleryProcessing data processor 17/58317/2
Thomas [Tue, 18 Sep 2018 09:41:29 +0000 (11:41 +0200)]
[BUGFIX] Fix casting in GalleryProcessing data processor

Removing the integer casting, so that the cropVariant can also be a string identifier.

Resolves: #86294
Releases: master, 8.7
Change-Id: Id4a80a7b879ddb8539e8cf4b47eeff1fc111029e
Reviewed-on: https://review.typo3.org/58317
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[BUGFIX] Omit checkbox for unselectable tree items 06/58306/2
Sebastian Michaelsen [Thu, 13 Sep 2018 09:49:42 +0000 (11:49 +0200)]
[BUGFIX] Omit checkbox for unselectable tree items

TCA select fields with renderType = 'selectTree' have the option
treeConfig.appearance.nonSelectableLevels, which doesn't seem
to work anymore since TYPO3 v7. The items are correctly flagged
with node.selectable = false in PHP but the JavaScript doesn't
check for that property.

Resolves: #84708
Releases: master, 8.7
Change-Id: Iefe98e1c9fd316f05c27ad1230d63236a7069bf1
Reviewed-on: https://review.typo3.org/58306
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[TASK] Add functional tests for copying a record into another language 47/58247/5
Oliver Hader [Mon, 10 Sep 2018 14:40:21 +0000 (16:40 +0200)]
[TASK] Add functional tests for copying a record into another language

The expected behavior is that the copied record is not synchronized
when modifying the language parent record (since it is not in connected
mode).

Resolves: #86215
Releases: master, 8.7
Change-Id: Ibf58dd6daf877b172aea5c31ead8ea1277834bfc
Reviewed-on: https://review.typo3.org/58247
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
5 months ago[BUGFIX] Use 403 header instead of 401 header 44/58244/2
Markus Klein [Wed, 27 Jun 2018 17:00:12 +0000 (19:00 +0200)]
[BUGFIX] Use 403 header instead of 401 header

The usage of a 401 header must be accompanied by a valid
www-authenticate header, which does not support form-based logins.

Resolves: #85411
Releases: master, 8.7
Change-Id: I71062c58a7d846214f1fec41e78cce4ae72955f3
Reviewed-on: https://review.typo3.org/58244
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
5 months ago[BUGFIX] Trim search value in live search 94/58194/3
Georg Ringer [Wed, 5 Sep 2018 08:49:09 +0000 (10:49 +0200)]
[BUGFIX] Trim search value in live search

The query parameter of the live search should be trimmed.
The same behaviour is already used in the regular search in the list module which is
available in the live search by clicking on the button "show all".

Resolves: #86149
Releases: master, 8.7
Change-Id: I3ec2ac03f67fa8c0daaa11aaf3e4351d05949b83
Reviewed-on: https://review.typo3.org/58194
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 months ago[BUGFIX] Prevent crash in DatabaseIntegrityCheck 21/58221/2
Anja [Fri, 7 Sep 2018 15:31:05 +0000 (17:31 +0200)]
[BUGFIX] Prevent crash in DatabaseIntegrityCheck

If a relation field (select / group) does not exist in db for
whatever reason, System -> DB check -> Database relations
crashes.

Resolves: #86167
Releases: master, 8.7
Change-Id: Id6a502d56b985f6410f40a1f547fe7b923e9d982
Reviewed-on: https://review.typo3.org/58221
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[BUGFIX] Template module must respect workspaces 75/58175/2
Andreas Fernandez [Mon, 3 Sep 2018 21:50:12 +0000 (23:50 +0200)]
[BUGFIX] Template module must respect workspaces

The template module now respects the workspace constraint of the current
backend user and the stored sys_template records.

Resolves: #86131
Releases: master, 8.7
Change-Id: I0463844c4222957aede4b4ca749a3368cb399f81
Reviewed-on: https://review.typo3.org/58175
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[TASK] Wrap error UnknownElement with proper HTML 76/58176/2
Georg Ringer [Tue, 4 Sep 2018 05:41:27 +0000 (07:41 +0200)]
[TASK] Wrap error UnknownElement with proper HTML

Show the error with a proper markup. Also hightlight type and
render type as code.

Resolves: #86133
Releases: master, 8.7
Change-Id: I79323aaff834c47e6ff875f8a584b2c88f42c51d
Reviewed-on: https://review.typo3.org/58176
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[TASK] Synchronize 8.x master .rst files to v8 70/58170/2
Christian Kuhn [Mon, 3 Sep 2018 21:37:16 +0000 (23:37 +0200)]
[TASK] Synchronize 8.x master .rst files to v8

Change-Id: If6d70777c95aad50c6edd455795db2cc379b26c1
Resolves: #86129
Releases: 8.7
Reviewed-on: https://review.typo3.org/58170
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[TASK] Synchronize 7.x master .rst files to v8 and v7 68/58168/2
Christian Kuhn [Mon, 3 Sep 2018 21:34:57 +0000 (23:34 +0200)]
[TASK] Synchronize 7.x master .rst files to v8 and v7

Change-Id: Ic76264a855a4731a5e90be954b55b0dd6a449c92
Resolves: #86130
Releases: 8.7, 7.6
Reviewed-on: https://review.typo3.org/58168
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[BUGFIX] Only unlock records in BE user log off functionality 48/58148/3
Benni Mack [Mon, 3 Sep 2018 16:53:04 +0000 (18:53 +0200)]
[BUGFIX] Only unlock records in BE user log off functionality

The database table `sys_lockedrecords` should only be cleared via
the BackendUtility when a Backend user is logging off. Currently, this
is also called for Frontend Users, which actually removes everything
from the currently logged-in backend users with the same uid.

As this is very bad code design on many levels (lockRecords for
unlocking, no context for the authentication user object etc), this
should be encapsulated within the BackendUser object directly anyway.

For further abstractions, this could also be a hook or something else,
to be even cleaner.

Resolves: #86113
Releases: master, 8.7
Change-Id: I44d91064edb6ec9ef4c148e48b67bdf22da38869
Reviewed-on: https://review.typo3.org/58148
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
5 months ago[BUGFIX] Resolve workspace records for template module overview 64/58164/2
Oliver Hader [Tue, 21 Aug 2018 10:45:20 +0000 (12:45 +0200)]
[BUGFIX] Resolve workspace records for template module overview

BackendWorkspaceRestriction automatically resolves specific records
already for a given workspace. In most cases this seems to be fine to
omit the usual workspace overlay processing. However, especially when
dealing with references and page tree assignments, it just contains
wrong information.

For instance all workspace versions have the `pid` column set to -1
which of course cannot be resolved as valid page then.

Resolves: #85917
Releases: master, 8.7
Change-Id: Ibe20037b25770bea8f58d1a8bba785ca43ac26cb
Reviewed-on: https://review.typo3.org/58164
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[BUGFIX] Use runtime cache for getIndpEnv() for results which are NULL 06/58006/4
Michael Stucki [Thu, 23 Aug 2018 13:43:49 +0000 (15:43 +0200)]
[BUGFIX] Use runtime cache for getIndpEnv() for results which are NULL

isset() returns FALSE if a cached result is NULL.
Use array_key_exists() instead.

Resolves: #85946
Related: #69173
Releases: master, 8.7
Change-Id: I32bf695f7778213bacc51ed569250466685f1dac
Reviewed-on: https://review.typo3.org/58006
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[BUGFIX] Detect current ImageMagick Version 7 for Windows. 73/57973/3
Michael Kersten [Sat, 4 Aug 2018 12:10:55 +0000 (14:10 +0200)]
[BUGFIX] Detect current ImageMagick Version 7 for Windows.

Try to use magick.exe if executable does not exists.

ImageMagick Version 7 for Windows does not use the executables for
identify, convert and combine/composite anymore. Instead the executable
magick.exe is used.

Resolves: #80909
Releases: master, 8.7
Change-Id: I83de3b0c1faac2aac582edfe51008d6288cb45b0
Reviewed-on: https://review.typo3.org/57973
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[TASK] typo3/testing-framework now flushes runtime caches 15/58115/3
Michael Stucki [Thu, 23 Aug 2018 14:40:50 +0000 (16:40 +0200)]
[TASK] typo3/testing-framework now flushes runtime caches

Unit test tearDown() now always calls
GeneralUtility::flushInternalRuntimeCaches() so most explicit
calls in unit tests can be removed.

composer update typo3/testing-framework

Resolves: #85948
Related: #85946
Releases: master, 8.7
Change-Id: I798047a06c3265404383540cacbd40d9719e7bfe
Reviewed-on: https://review.typo3.org/58115
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[TASK] Single slashes for classes in form docs 12/58112/2
Simon Schaufelberger [Thu, 30 Aug 2018 13:09:10 +0000 (15:09 +0200)]
[TASK] Single slashes for classes in form docs

Use single backslash in code block

Releases: master, 8.7
Resolves: #86039
Change-Id: I9d7755c3f0183f4be47fe227a28ac8e186de60f4
Reviewed-on: https://review.typo3.org/58112
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[BUGFIX] Fix paste button in page module with mode "languages" 76/58076/2
Manuel Selbach [Mon, 20 Aug 2018 17:55:37 +0000 (19:55 +0200)]
[BUGFIX] Fix paste button in page module with mode "languages"

A content element can once again be pasted directly at a specific
position with the help of the paste button when in the "languages" mode.

Releases: master, 8.7
Resolves: #85911
Change-Id: I08e48361b45c4cffaf83c4b7b92f70303ab8babf
Reviewed-on: https://review.typo3.org/58076
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
5 months ago[TASK] Mention table and record uid in DataHandler localize command log 72/58072/2
Tymoteusz Motylewski [Wed, 29 Aug 2018 15:49:24 +0000 (17:49 +0200)]
[TASK] Mention table and record uid in DataHandler localize command log

Resolves: #86029
Releases: master, 8.7
Change-Id: I75c5bf23537a987fbe16c9a6fb2464a853d12135
Reviewed-on: https://review.typo3.org/58072
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
5 months ago[BUGFIX] Use namespaced class name for blog_example fe_users subclass 53/58053/2
Tymoteusz Motylewski [Mon, 27 Aug 2018 19:23:17 +0000 (21:23 +0200)]
[BUGFIX] Use namespaced class name for blog_example fe_users subclass

The last place which was missed when porting the extension to namespaces,
is now fixed.

Also slash sign has to be escaped in SQL.

Resolves: #85999
Releases: master, 8.7
Change-Id: I844b59b209ef1434298575b57fc7dc861ecab643
Reviewed-on: https://review.typo3.org/58053
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
5 months ago[TASK] Fix typo and add example for requireCHashArgumentForActionArguments 04/58004/2
andypa [Thu, 23 Aug 2018 11:20:25 +0000 (13:20 +0200)]
[TASK] Fix typo and add example for requireCHashArgumentForActionArguments

Fixed a typo and added an example for EXT:indexed_search.

Releases: master, 8.7
Resolves: #85942
Change-Id: Iffcecd753843733ef96c9e41da808a47b943405e
Reviewed-on: https://review.typo3.org/58004
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
5 months ago[BUGFIX] Throw exception in case FileWriter's logFile is invalid 36/58036/2
Oliver Hader [Fri, 24 Aug 2018 16:23:19 +0000 (18:23 +0200)]
[BUGFIX] Throw exception in case FileWriter's logFile is invalid

GeneralUtility::getFileAbsFileName($logFile) never results in `null`,
but in some empty string in case the $logFile is invalid.

Resolves: #85973
Releases: master, 8.7
Change-Id: I2890bbf172c8f540dd2fa2775a9479d5c644b172
Reviewed-on: https://review.typo3.org/58036
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>