Packages/TYPO3.CMS.git
22 months ago[BUGFIX] Allow to send multiple HTTP headers with the same name 00/60800/2
Markus Poerschke [Thu, 23 May 2019 07:22:19 +0000 (09:22 +0200)]
[BUGFIX] Allow to send multiple HTTP headers with the same name

HTTP allows to send multiple headers with the same name.
Espacially this is needed for the "Set-Cookie" header to send more than
one cookie at the same response.

Resolves: #88420
Releases: master, 9.5
Change-Id: I4fd3573424e2ebf954cc5ebd043bd710226897fa
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60800
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
22 months ago[BUGFIX] Allow leading zeros in croncommand 70/60770/8
Tomas Norre Mikkelsen [Thu, 16 May 2019 15:05:41 +0000 (17:05 +0200)]
[BUGFIX] Allow leading zeros in croncommand

The Scheduler system extension requires a valid cron command or
seconds between scheduler runs.

With this commit, the Scheduler now allows "15 2 * * *" as well as
"15 02 * * *". The latter one was not accepted till now.

The "02" for the hours or minutes are valid cron times,
and therefore it should also be allowed in the Scheduler.

Resolves: #88371
Releases: master, 9.5
Change-Id: I2ed3d6c4cf445bf0692726c49b5c9207af2e9628
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60770
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Susanne Moog <look@susi.dev>
22 months ago[TASK] Deprecate top.openUrlInWindow 10/60810/2
Andreas Fernandez [Fri, 24 May 2019 12:03:09 +0000 (14:03 +0200)]
[TASK] Deprecate top.openUrlInWindow

The global JavaScript function `top.openUrlInWindow()` has been marked as
deprecated. This method was used to open links in a full size popup.

Resolves: #88433
Releases: master
Change-Id: Ia2bfafff2a3144a3a7fac5356e6cb26085fd182d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60810
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
22 months ago[TASK] Delete unused ColorPicker.js file 09/60809/3
Frank Naegler [Fri, 24 May 2019 11:37:05 +0000 (13:37 +0200)]
[TASK] Delete unused ColorPicker.js file

The js module „TYPO3/CMS/Backend/Wizard/Colorpicker“ is not used
anymore. The PHP code was removed with #80913.
This leftover will now get deleted.

Resolves: #85401
Related: #80913
Change-Id: I07da7ac84ee88a36e87ac537ce83464c4d3ebf16
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60809
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <look@susi.dev>
22 months ago[TASK] Harden \TYPO3\CMS\Extbase\Service\ExtensionService 93/59593/7
Alexander Schnitzler [Thu, 31 Jan 2019 17:44:10 +0000 (18:44 +0100)]
[TASK] Harden \TYPO3\CMS\Extbase\Service\ExtensionService

- Use strict type mode
- Use type hints whereever possible
- Use strict type comparison for in_array

Releases: master
Resolves: #87598
Change-Id: I639fbe1edd291af1a183171d59b0bf42988a0613
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59593
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
22 months ago[TASK] Deprecate `top.rawurlencode` and `top.str_replace` 05/60805/5
Andreas Fernandez [Fri, 24 May 2019 09:27:07 +0000 (11:27 +0200)]
[TASK] Deprecate `top.rawurlencode` and `top.str_replace`

The global JavaScript functions `top.rawurlencode()` and
`top.str_replace()` were introduced in 2009 and have been marked as
deprecated now. The code is not required and some special handling used
in these functions may get achieved with native JavaScript functions.

Resolves: #88428
Releases: master
Change-Id: Ie2c2fd42da89b00e3c9a0137231b16c2cbd21396
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60805
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
22 months ago[BUGFIX] Require `jquery` before using it when rendering ckeditor 06/60806/4
Andreas Fernandez [Fri, 24 May 2019 09:51:45 +0000 (11:51 +0200)]
[BUGFIX] Require `jquery` before using it when rendering ckeditor

In rare cases it might occur that jquery is not available on ckeditor
initialization, but it's used already. Interesting is that jquery
is explicitly required two lines later.

The code is now changed to require jquery before using its document.ready()
handling.

Resolves: #88429
Releases: master, 9.5, 8.7
Change-Id: I52d5a381f6415dc7680acb5d23138858dc4e96a6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60806
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
22 months ago[!!!][TASK] Remove config.defaultGetVars 99/60799/4
Benni Mack [Wed, 22 May 2019 19:24:16 +0000 (21:24 +0200)]
[!!!][TASK] Remove config.defaultGetVars

The TypoScript option config.defaultGetVars is not
evaluated anymore, as this conflicts with TypoScript
logic itself:

After TypoScript parsing and condition evaluation in
a Frontend Request, config.defaultGetVars is set,
this would effectively mean that TypoScript
parsing should be re-done in order to meet new
possible matches in Conditions.

As this logic is flawed and should now easily be
handled via a custom middleware (previously this was
helpful for setting e.g. L=0 for default pages
with RealURL), it is now removed from Core.

Resolves: #88419
Releases: master
Change-Id: Ic286c96f71953062d7649d71abb72f8f0f20f1a9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60799
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <look@susi.dev>
22 months ago[!!!][TASK] Remove jsfunc.evalfield.js 92/60792/4
Andreas Fernandez [Tue, 21 May 2019 20:52:58 +0000 (22:52 +0200)]
[!!!][TASK] Remove jsfunc.evalfield.js

The file `jsfunc.evalfield.js` responsible for form value evaluation and
validation has been removed. This job is now done by
`TYPO3/CMS/Backend/FormEngineValidation` since TYPO3 7.4.

Resolves: #88427
Releases: master
Change-Id: Ib366ccbc5795b9c428743f52098c0a6fbca47735
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60792
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
22 months ago[!!!][TASK] Refactor client-side IRRE 24/59324/42
Andreas Fernandez [Thu, 3 Jan 2019 21:10:48 +0000 (22:10 +0100)]
[!!!][TASK] Refactor client-side IRRE

This patch refactors the IRRE handling on client side, the JavaScript
land has been rewritten to have a better structure and do less repeating
on-the-fly calculations. Each IRRE container is represented by a
independent instance of InlineControlContainer.

Most of the internally used `scriptCall` directives have been removed.
Currently, `scriptCall` can't get removed completely, as further
refactorings in different areas are required.

All of the "external" communication via `inline.foobar()` has been
replaced by a event-driven approach. This also affects ElementBrowser
windows, those use a minimalistic API based on postMessage.

Some code that was never evaluated in ElementBrowser is considered dead
and has been removed regarding inserting multiple items.

A new sorting library has been added in order to replace jqueryui piece
by piece.

Executed command:

    yarn add --dev sortablejs

On PHP side, some code has been removed as well since the rewritten client
code is event-based and doesn't depend on external calls anymore.

Resolves: #88182
Releases: master
Change-Id: I4176483d2882cef49fbaddb5e2e1914c1f76c908
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59324
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
22 months ago[TASK] Typo in "validate" 88/60788/2
Stefan Frömken [Tue, 21 May 2019 13:17:09 +0000 (15:17 +0200)]
[TASK] Typo in "validate"

Releases: master
Resolves: #88409
Change-Id: Iff722b6b6f4206e4912fd2d2f7bc8e55d860133f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60788
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Josef Glatz <josefglatz@gmail.com>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Josef Glatz <josefglatz@gmail.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Susanne Moog <look@susi.dev>
22 months ago[TASK] Migrate TYPO3/CMS/Filelist/* to TypeScript 30/60730/4
Frank Naegler [Fri, 10 May 2019 22:03:21 +0000 (00:03 +0200)]
[TASK] Migrate TYPO3/CMS/Filelist/* to TypeScript

This commit also removes superfluous code and streamlines the search
template.

Resolves: #88333
Releases: master
Change-Id: Id6761796dd8e774497223fe7de6f811b4610e245
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60730
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <look@susi.dev>
22 months ago[TASK] Add information on how to create custom workspaces 72/60772/6
GeraSchneider [Fri, 17 May 2019 06:57:06 +0000 (08:57 +0200)]
[TASK] Add information on how to create custom workspaces

The documentation had no information where to create custom workspaces in the backend.
That information has been added.

Releases: master, 9.5
Resolves: #88378
Change-Id: I8bd6d7ad2ac291e3576b89d39f9698ce16a5572c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60772
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Josef Glatz <josefglatz@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Josef Glatz <josefglatz@gmail.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
22 months ago[TASK] Optimize tests for request function in expression language 15/60315/3
Frank Naegler [Fri, 22 Mar 2019 23:05:50 +0000 (00:05 +0100)]
[TASK] Optimize tests for request function in expression language

Resolves: #88345
Releases: master
Change-Id: I1da8e97558b0a4697db8aae6b1a098e2628fa519
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60315
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
22 months ago[!!!][TASK] Remove TBE_EDITOR.typo3form 91/60791/3
Andreas Fernandez [Tue, 21 May 2019 20:49:30 +0000 (22:49 +0200)]
[!!!][TASK] Remove TBE_EDITOR.typo3form

This patch removes the TBE_EDITOR.typo3form object, which is unused for
a long time now. This "API" was used to either get or set values of
form fields in a very old iteration of the FormEngine.

Resolves: #88411
Releases: master
Change-Id: If7d6e1d13c89944383d06c42d63f2f3a3b40d999
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60791
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
22 months ago[!!!][TASK] Deprecate useCacheHash/noCacheHash 74/60774/6
Benni Mack [Fri, 17 May 2019 11:11:54 +0000 (13:11 +0200)]
[!!!][TASK] Deprecate useCacheHash/noCacheHash

Having Site Handling in place, the option "useCacheHash"
rendered useless as it is added by TYPO3 Core automatically
when necessary with SiteHandling.

Any Fluid Arguments haven't been deprecated as this
was part of the the legacy functionality. Now the options
are still available, but trigger a deprecation message
that the option is superfluous and should be removed.

Calling typolink.useCacheHash will now trigger a
deprecation message.

Resolves: #88406
Releases: master
Change-Id: I2243a335188c3466b8f8f59e8d3e417f13bf854d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60774
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
22 months ago[BUGFIX] Respect argument showLabel in AbstractButtonViewHelper 89/60789/2
Georg Ringer [Tue, 21 May 2019 17:32:39 +0000 (19:32 +0200)]
[BUGFIX] Respect argument showLabel in AbstractButtonViewHelper

The argument `showLabel` must be used while creating a button.

Resolves: #88408
Releases: master, 9.5
Change-Id: I5bfcc25d03aac9da6ca11b651658749bf25d7bf1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60789
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Josef Glatz <josefglatz@gmail.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Josef Glatz <josefglatz@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
22 months ago[BUGFIX] Remove superflous parameter that blocks the test 78/60778/2
Anja Leichsenring [Sat, 18 May 2019 12:21:40 +0000 (14:21 +0200)]
[BUGFIX] Remove superflous parameter that blocks the test

assertNotNull takes only one parameter, but due to a left over
from former refactoring, it got two, and the first one
was a static string. So the test actually did not test
what it was supposed to test.

Resolves: #88387
Relates: #87764
Releases: master
Change-Id: Ib39d4eb623f7b079a5a4a6159ffc7520ac70642b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60778
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
22 months ago[!!!][TASK] Remove deprecated code from ConditionMatcher 86/60786/3
Frank Naegler [Mon, 20 May 2019 19:24:28 +0000 (21:24 +0200)]
[!!!][TASK] Remove deprecated code from ConditionMatcher

The following methods changed from protected to private:

ConditionMatcher->determinePageId()
ConditionMatcher->getPageIdByRecord()

Resolves: #88407
Related: #87193
Releases: master
Change-Id: Iea9789aeb7f74ed3dad55ee81245b7ebb5806fde
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60786
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Josef Glatz <josefglatz@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
22 months ago[!!!][TASK] Remove legacy "pageNotFound_handling" options 53/60453/15
Benni Mack [Fri, 12 Apr 2019 00:39:46 +0000 (02:39 +0200)]
[!!!][TASK] Remove legacy "pageNotFound_handling" options

With the introduction of site handling, the old "pageNotFound_handling"
mechanisms can be removed. If a site configuration hasn't configured
a error handler, a 404/403/500 response with the default error
renderer is now returned. Making PageNotFoundExceptions rendering
the frontend very seldom.

The following options are removed:
- $TYPO3_CONF_VARS[FE][pageNotFound_handling]
- $TYPO3_CONF_VARS[FE][pageNotFound_handling_statheader]
- $TYPO3_CONF_VARS[FE][pageNotFound_handling_accessdeniedheader]
- $TYPO3_CONF_VARS[FE][pageUnavailable_handling]
- $TYPO3_CONF_VARS[FE][pageUnavailable_handling_statheader]

Tests have been adopted to check against status code / message
rather than on the exceptions (not) thrown (anymore).

In addition, a JsonResponse is now returned if JSON
was requested, instead of the regular HTML content.

Resolves: #88376
Releases: master
Change-Id: I6be57fadaa0ddf83039fbdcc9186ef93d5a51158
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60453
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
22 months ago[TASK] Update typo3/testing-framework, phpunit and codeception 79/60779/7
Anja Leichsenring [Sat, 18 May 2019 12:36:27 +0000 (14:36 +0200)]
[TASK] Update typo3/testing-framework, phpunit and codeception

commands:
composer update typo3/testing-framework
composer require --dev codeception/codeception:^3
composer update codeception/codeception --with-dependencies

Leads to:
typo3/testing-framework 5.0.9
codeception/codeception: 3.0.0
phpunit/phpunit: 8.1.5

Resolves: #88388
Releases: master, 9.5
Change-Id: Ic394bdf21025705534a6f7b74ca78e155dba6a39
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60779
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
22 months ago[BUGFIX] Use VersionState constants instead of numbers 80/60780/2
Benni Mack [Mon, 20 May 2019 08:32:29 +0000 (10:32 +0200)]
[BUGFIX] Use VersionState constants instead of numbers

A few places still use t3ver_state instead of the available
constants in VersionState. To increase
the semantics of the used code, the constants are used
instead.

Resolves: #88395
Releases: master, 9.5
Change-Id: I3c2927c2d4c8814d581f06f84de8f4c85d6226a1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60780
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
23 months ago[!!!][TASK] Streamline caching framework caches 61/59661/7
Benni Mack [Thu, 7 Feb 2019 10:10:58 +0000 (11:10 +0100)]
[!!!][TASK] Streamline caching framework caches

Due to some heavy history on the caching framework, all
Database caches start with "cf_cache_", which is optimized
so they are only called e.g. "cache_pagesection" in the database tables.

In addition, the prefix "cache_" (in e.g. "cache_core") is unnecessary,
and also there due to legacy reasons, reading $this->getCache('cache_runtime')
seems very illogical.

The following caches have been renamed:
- cache_core => core
- cache_hash => hash
- cache_pages => pages
- cache_pagesection => pagesection
- cache_runtime => runtime
- cache_rootline => rootline
- cache_imagesizes => imagesizes

Old identifiers can still be called within PHP,
but the caching framework throws a deprecation message
on setting up such a cache.

A silent upgrade wizard will update one's LocalConfiguration
to use the new naming scheme.

The result is a cleaner, more readable and more streamlined
code base (we have caches like "extbase" or "assets" where
there is no prefix) and database structure.

The patch is breaking due to the change in the database tables.

Resolves: #88366
Releases: master
Change-Id: I13dcdb0d1bf78f0899615e850856de081b715358
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59661
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
23 months ago[!!!][TASK] Remove Pseudo-Site Handling 66/59366/47
Benni Mack [Mon, 7 Jan 2019 20:37:20 +0000 (21:37 +0100)]
[!!!][TASK] Remove Pseudo-Site Handling

This change removes the compatibility layer of Site Handling,
called "PseudoSite" handling.

Any TypoScript-related Language properties are removed.
- config.sys_language_uid
- config.sys_language_mode
- config.sys_language_overlay
- config.locale_all
- config.language
- config.typolinkEnableLinksAcrossDomains
- typolink.useCacheHash

The hook
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_tstemplate.php']['linkData-PostProc']
is removed.

In addition, all tests related to PseudoSite and linking
without SiteHandling are removed, linking to pages without
a site will not be linked anymore.

Adding `useCacheHash` to typolink triggers a
"this does not do anything anymore" deprecation message.

Further related removals (old "pageNotFound" handling
and "useCacheHash" in all viewhelpers), are removed
separately.

Resolves: #88363
Releases: master
Change-Id: I14f2f854e69c98df7fab8b14f92f1ec2440a15a0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59366
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
23 months ago[BUGFIX] Ensure correct initialization of selectTree value 15/60415/3
Nicole Cordes [Mon, 8 Apr 2019 16:27:08 +0000 (18:27 +0200)]
[BUGFIX] Ensure correct initialization of selectTree value

This patch provides the current set database value in a hidden field as
early as the whole select tree JavaScript is provided. This prevents
data loss if the current record is saved before the select tree was loaded.

Resolves: #86954
Releases: master, 9.5, 8.7
Change-Id: I467b2a52d34b806713cd201a8a2a4f9bb8e92c71
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60415
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
23 months ago[!!!][TASK] Remove database field "t3ver_id" 59/60459/3
Benni Mack [Fri, 12 Apr 2019 19:12:22 +0000 (21:12 +0200)]
[!!!][TASK] Remove database field "t3ver_id"

The database field "t3ver_id" which is managed by TYPO3 to store the
number of the version for a specific version is not in use anymore,
as this was related to the non-workspace managed versioning concept.

This linear versioning concept was removed, so the database field is
not needed anymore.

It is recommended for all extensions with TYPO3 v10.0+ compat only
to remove this field.

Resolves: #88143
Releases: master
Change-Id: I283e8e2ba2d755dcc8b2054e2439f9fef5462511
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60459
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Achim Fritz <af@achimfritz.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
23 months ago[TASK] Upgrade typo3/phar-stream-wrapper to v3.1.2 54/60754/3
Oliver Hader [Tue, 14 May 2019 22:18:53 +0000 (00:18 +0200)]
[TASK] Upgrade typo3/phar-stream-wrapper to v3.1.2

https://github.com/TYPO3/phar-stream-wrapper/releases/tag/v3.1.2

* #34: Normalize resolved Windows path to Unix-style
* #42: Avoid analysing non-phar files on alias resolving
* #40: Add Windows tests using AppVeyor
* #33: Add alternative mime-type resolving (without ext-fileinfo)

composer require typo3/phar-stream-wrapper:^3.1.2

Resolves: #88354
Releases: master, 9.5, 8.7
Change-Id: I4560881006a6f9c48761161f0b96b78f02c0659d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60754
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
23 months ago[TASK] Switch functional tests to site handling 57/60757/4
Benni Mack [Wed, 15 May 2019 08:01:26 +0000 (10:01 +0200)]
[TASK] Switch functional tests to site handling

All functional tests that run a frontend subrequest
should be tested against Site Handling, as the
PseudoSite Handling is about to removed.

This patch is actually a precursor to make sure
that all tests work with site handling now.

The AbstractDataHandlerActionTestCase adds
e site configuration on each setUp(). This
way, all DataHandler-related tests are running
with a Site configuration of three languages.

In addition, when "localizing" something,
a translated page needs to exist, so most
DataHandler related changes add this functionality.

For some DataHandler tests, the SiteConfiguration
is adapted to define the previous behavior
built in TypoScript.

One addition in PageResolver is made:
If an GET / POST &id query parameter is given,
and it is not accessible, it will fail now.

Resolves: #88357
Releases: master
Change-Id: I3dafec3382d8c6797f32b3acde2763dacd13e0f3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60757
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
23 months ago[BUGFIX] Fix record preview 58/60758/4
Daniel Dorndorf [Wed, 15 May 2019 08:24:33 +0000 (10:24 +0200)]
[BUGFIX] Fix record preview

A wrong evaluation of the null coalesce
assignment (?? is evaluted and && later-on),
the if() condition was always true for
any previews of records with versioning
enabled.

The Backend API is used instead.

Resolves: #88356
Releases: master, 9.5
Change-Id: I89ba14bd99bbeb17637b64d99a8d6de265a6e7c4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60758
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
23 months ago[BUGFIX] Avoid realpath resolving in PharStreamWrapperInterceptor 39/60739/2
Oliver Hader [Mon, 13 May 2019 08:39:33 +0000 (10:39 +0200)]
[BUGFIX] Avoid realpath resolving in PharStreamWrapperInterceptor

Given that e.g. public/typo3conf/ext/my_extension is symlinked to
packages/my_extension, PharStreamWrapper denies invocation since
realpath is resolved.

For the specific PharStreamWrapperInterceptor it is okay to avoid
realpath resolving.

Resolves: #88340
Releases: master, 9.5, 8.7
Change-Id: I46b7100547dd0e40d1d4d76a71047ef977d8ce63
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60739
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: tomalo.stuttgart <loeffler@spooner-web.de>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: tomalo.stuttgart <loeffler@spooner-web.de>
Reviewed-by: Rudy Gnodde <rgn@windinternet.nl>
Reviewed-by: Kevin Meckl <kevin.meckl@zdrei.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
23 months ago[TASK] Prepare core tests for phpunit v8 32/60732/7
Anja Leichsenring [Sat, 11 May 2019 18:07:52 +0000 (20:07 +0200)]
[TASK] Prepare core tests for phpunit v8

Resolves: #88335
Releases: master, 9.5
Change-Id: I40569702c9cec50aa9150c666488c7a71c28b47b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60732
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
23 months ago[TASK] Remove unused variable 31/60731/5
Susanne Moog [Sat, 11 May 2019 15:04:39 +0000 (17:04 +0200)]
[TASK] Remove unused variable

Resolves: #88334
Releases: master, 9.5
Change-Id: I380c0aa3dd63ab6d1a8587138e0ff33df6941ca4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60731
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jonas Eberle <flightvision@googlemail.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Jonas Eberle <flightvision@googlemail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
23 months ago[BUGFIX] Remove non existing source map reference 36/60736/2
Frank Naegler [Mon, 13 May 2019 07:44:41 +0000 (09:44 +0200)]
[BUGFIX] Remove non existing source map reference

Resolves: #86804
Releases: master, 9.5, 8.7
Change-Id: I81332dd5d5ede768f4ca90bac9d4d3a611f91d2e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60736
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
23 months ago[BUGFIX] Ignore PATH_INFO in NormalizedParams scriptName calculation 19/60719/8
Benjamin Franzke [Thu, 9 May 2019 10:22:58 +0000 (12:22 +0200)]
[BUGFIX] Ignore PATH_INFO in NormalizedParams scriptName calculation

When NormalizedParams was introduced, the code that was refactored from
GeneralUtility:getIndpEnv did not take into account that PATH_INFO
could be set, but be empty. (which happens with the Debian 9 NGINX
default configuration which uses `fastcgi_split_path_info` and set's
`fastcgi_param PATH_INFO` even if it's empty).

Now, the fallback to PATH_INFO has been introduced with
the initial revision of TYPO3 and isn't needed at all nowadays,
it's actually wrong, as a REQUEST_URI to /index.php/foo/bar
would incorrectly be interpreted as $scriptName == "/foo/bar".

This patch additionally replaces PATH_INFO with SCRIPT_NAME in
test cases where this variable is actually wrong (we assume test cases
have been modeled to match (old) code, instead of reality here):

 * ProxyPass does not result in PATH_INFO being set,
   it's SCRIPT_NAME here.
 * PATH_INFO is not set for regular request
   to /typo3/index.php

Resolves: #88304
Releases: master, 9.5
Change-Id: I501ad3bc10b0988385906a1fe9cb668c5e3696b6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60719
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benny Schimmer <b.schimmer@saint-elmos.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benny Schimmer <b.schimmer@saint-elmos.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
23 months ago[BUGFIX] Properly initialize image property of FrontendUser 26/60726/4
Dennis Grün [Thu, 9 May 2019 10:00:48 +0000 (12:00 +0200)]
[BUGFIX] Properly initialize image property of FrontendUser

Resolves: #88315
Releases: master, 9.5
Change-Id: I76f75986b39ff15bd2d57ab94ec290a509381275
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60726
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Daniel Haupt <dh@schiffel.it>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Josef Glatz <josefglatz@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Haupt <dh@schiffel.it>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Josef Glatz <josefglatz@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[TASK] Migrate TYPO3/CMS/RteCkeditor/* to TypeScript 60/60260/4
Frank Naegler [Fri, 15 Mar 2019 13:45:10 +0000 (14:45 +0100)]
[TASK] Migrate TYPO3/CMS/RteCkeditor/* to TypeScript

Resolves: #87924
Releases: master
Change-Id: I50332d97fbbfa9b04f1a2d8de761aabe84b3c367
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60260
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Josef Glatz <josefglatz@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Josef Glatz <josefglatz@gmail.com>
23 months ago[BUGFIX] Ensure correct value for JsonResponse in InstallerController 66/60466/3
Guido Schmechel [Sat, 13 Apr 2019 18:37:07 +0000 (20:37 +0200)]
[BUGFIX] Ensure correct value for JsonResponse in InstallerController

Set the correct status value for the JsonResponse returned in case no
database is selected.
Additionally, a typo in the key `success` itself is fixed.

Resolves: #88066
Releases: master, 9.5
Change-Id: I3153f6cabc878b270fe48983cbdedb8ed918d566
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60466
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
23 months ago[TASK] Unify spelling for TSconfig 45/60345/3
Sybille Peters [Tue, 26 Mar 2019 21:01:34 +0000 (22:01 +0100)]
[TASK] Unify spelling for TSconfig

Resolves: #87647
Releases: master
Change-Id: I4f2a9db50481c12f84682ebe0147b962c8d8438d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60345
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
23 months ago[BUGFIX] Migrate "Revert selection" of SelectCheckboxElement 28/60728/4
Andreas Fernandez [Fri, 10 May 2019 08:38:07 +0000 (10:38 +0200)]
[BUGFIX] Migrate "Revert selection" of SelectCheckboxElement

With #87324 parts of the FormEngine have been split into smaller,
maintainable parts. However, `SelectCheckboxElement` brings it's own
"Revert selection" implementation that has nothing in common with the
"Reset selection" field control used for select boxes.

The code is now rewritten to handle the revert on its own. Additionally,
another inline `onclick` handler was removed.

Resolves: #88314
Related: #87324
Releases: master
Change-Id: Ifca1b67a960a8caab8145f2a7d5c8301918819fa
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60728
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
23 months ago[TASK] Slim down .editorconfig file 53/60653/4
Andreas Fernandez [Sat, 4 May 2019 12:04:51 +0000 (14:04 +0200)]
[TASK] Slim down .editorconfig file

This patch aims to reduce the size of the .editorconfig file used by IDEs
to get rid of duplicated configuration (indent_style), obsolete
configuration (bower.json) and merge related configuration (scss, css).

Resolves: #88271
Releases: master
Change-Id: I5a34536858b0cea5e4eb5a1f9fc7ca566aa144e0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60653
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
23 months ago[BUGFIX] Fix querying form element when clicking "Install" button 72/60572/2
Andreas Fernandez [Fri, 26 Apr 2019 12:35:50 +0000 (14:35 +0200)]
[BUGFIX] Fix querying form element when clicking "Install" button

Resolves: #88226
Related: #88040
Releases: master
Change-Id: Ie8726b689362119a3d4d087582b3be2cb2b86e4b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60572
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
23 months ago[BUGFIX] Make php-intl work with older ICU versions 10/60710/3
Benni Mack [Tue, 7 May 2019 13:08:00 +0000 (15:08 +0200)]
[BUGFIX] Make php-intl work with older ICU versions

On old OS with ICU < 4.6, the constant INTL_IDNA_VARIANT_UTS46
is not available, even if php-intl is installed.

Therefore, a wrapper is created in HttpUtility to check
if the constant is available, then uses INTL_IDNA_VARIANT_UTS46
otherwise the 2003 version of the HttpUtility.

Also see the section about INTL_IDNA_VARIANT_UTS46 within
https://www.php.net/manual/en/intl.constants.php

Resolves: #87953
Releases: master, 9.5
Change-Id: I594c0ffd9afa115de595b0c027bf2474c3abfafb
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60710
Reviewed-by: Sven Juergens <typo3@blue-side.de>
Reviewed-by: Kevin Meckl <kevin.meckl@zdrei.com>
Reviewed-by: Timo Poppinga <timo.poppinga@zdrei.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Timo Poppinga <timo.poppinga@zdrei.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
23 months ago[SECURITY] Enclose file type scope when invoking ImageMagick 05/60705/2
Oliver Hader [Tue, 7 May 2019 09:44:50 +0000 (11:44 +0200)]
[SECURITY] Enclose file type scope when invoking ImageMagick

In order to enclose and avoid type guessing done by ImageMagick based
on mime-type and internal file content checks, new value object class
ImageMagickFile has been introduced as guard for those invocations.

Resolves: #87588
Releases: master, 9.5, 8.7
Security-Commit: d4f18684b2b2078b51cc7e93abdb251ea846984a
Security-Bulletin: TYPO3-CORE-SA-2019-012
Change-Id: I9a2dd74e8548530d7bc83bd18af2f4f0a8212019
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60705
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
23 months ago[SECURITY] Destroy sessions on password change 04/60704/2
Frank Naegler [Tue, 7 May 2019 09:44:26 +0000 (11:44 +0200)]
[SECURITY] Destroy sessions on password change

On DataHandler update or when updating a users
password via EXT:felogin, all existing
sessions are destroyed except for the current
session.

Resolves: #87298
Releases: master, 9.5, 8.7
Security-Commit: df7c0dbcf73be20e5ae9d4cf03b82c8326c9fccc
Security-Bulletin: TYPO3-CORE-SA-2019-011
Change-Id: Iff673d2ab774dde0f116c4bc9040d40374492a7a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60704
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
23 months ago[SECURITY] Avoid logging sensitive information during authentication 03/60703/2
Helmut Hummel [Tue, 7 May 2019 09:44:05 +0000 (11:44 +0200)]
[SECURITY] Avoid logging sensitive information during authentication

In order to avoid logging sensitive information during authentication
using the logging framework, according log level DEBUG is used.

Resolves: #88230
Releases: master, 9.5
Security-Commit: 625428b6364308f9f07f331bd176110d01e6c2f2
Security-Bulletin: TYPO3-CORE-SA-2019-010
Change-Id: I3e19afad6937515e0f6e1ab0a1c6d7004d182b79
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60703
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
23 months ago[SECURITY] Hide items in page tree a user does not have access to 01/60701/2
Oliver Hader [Tue, 7 May 2019 09:43:45 +0000 (11:43 +0200)]
[SECURITY] Hide items in page tree a user does not have access to

Due to a pass-by-reference error pages a user does not have access
to were still visible in the page tree.

Resolves: #87676
Releases: master, 9.5
Security-Commit: 5d2c69c00554ec64ea020ec803f593ae772fa367
Security-Bulletin: TYPO3-CORE-SA-2019-009
Change-Id: Ic8ba91b596e1589860bc28b746e551ac6bc47588
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60701
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
23 months ago[BUGFIX] Fix RST rendering in Documentation file 94/60694/3
Benni Mack [Tue, 7 May 2019 09:30:37 +0000 (11:30 +0200)]
[BUGFIX] Fix RST rendering in Documentation file

Due to some encoding issue, documentation
of the new feature for slug TCA hooks
is broken.

The patch adapts the RST file.

Resolves: #88289
Related: #88198
Releases: master, 9.5
Change-Id: I8e9027aba14678d678751246380833fce8a0e07b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60694
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
23 months ago[SECURITY] Raise Fluid Standalone dependency 93/60693/3
Benni Mack [Tue, 7 May 2019 08:18:10 +0000 (10:18 +0200)]
[SECURITY] Raise Fluid Standalone dependency

Raise Fluid Standalone dependency to the next stable version
which fixes an important XSS issue when escaping
ternary operators.

Used composer command:
  composer req typo3fluid/fluid:^2.6.1 --prefer-lowest

Resolves: #88288
Releases: master, 9.5, 8.7
Security-Bulletin: TYPO3-CORE-SA-2019-013
Change-Id: I04f32d8d01f893bc26ff21aa0c079c85e9db85b9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60693
Reviewed-by: Claus Due <claus@phpmind.net>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[BUGFIX] Avoid showing password on MacBook touch bar in backend forms 78/60678/3
Oliver Hader [Wed, 4 Apr 2018 10:15:38 +0000 (12:15 +0200)]
[BUGFIX] Avoid showing password on MacBook touch bar in backend forms

The auto suggest feature of MacBook's touch bar shows information of
just entered passwords when editing a record containing a password
field in backend forms. The behavior only occurs when Safari is used
as client and touch bar word completion is activated.

Resolves: #88286
Releases: master, 9.5, 8.7
Change-Id: I588a6edcfc34c403dc9f042adbeca2c711512228
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60678
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
23 months ago[BUGFIX] Do not apply stdWrap on USER_INT 63/60463/3
Benni Mack [Sat, 13 Apr 2019 06:15:44 +0000 (08:15 +0200)]
[BUGFIX] Do not apply stdWrap on USER_INT

When converting a USER to USER_INT ContentObject
the stdWrap is now executed only once instead
of multiple times.

Resolves: #61441
Releases: master, 9.5
Change-Id: Ia36dfffeb3721acc244a74fc559030e94439d10d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60463
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
23 months ago[FEATURE] API to search for files including meta data based on folder 85/58985/38
Helmut Hummel [Thu, 29 Nov 2018 17:49:04 +0000 (18:49 +0100)]
[FEATURE] API to search for files including meta data based on folder

Instead of globally selecting all files with matching
meta data, we now base each search on the selected folder.

To do so, search is now completely based on the persisted
files in sys_file (and their corresponding meta data
in sys_file_metadata).

Additionally we properly evaluate search fields from TCA
so that we now search in all fields defined for sys_file
and sys_file_metadata table.

To achieve that, a new capability "CAPABILITY_HIERARCHICAL_IDENTIFIERS"
is introduced, which drivers can set, that build identifiers
that reflect the directory structure.
For such drivers, the search can be optimized by using
like queries on identifiers, instead of recursively traversing folders,
which can be an expensive operation especially for drivers
handling a remote file system.

Resolves: #87610
Releases: master, 9.5
Change-Id: Ia132465437827b2fdb56004eb73348ce4a05b336
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/58985
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
23 months ago[BUGFIX] Respect uniqueInSite when moving records 34/60534/10
Benni Mack [Wed, 24 Apr 2019 19:54:33 +0000 (21:54 +0200)]
[BUGFIX] Respect uniqueInSite when moving records

When a page is moved from one site to another site
(two pagetrees with different sites), currently a duplicate
slug is possible. This should never happen, so the same
logic as for "uniqueInPid" is applied when moving records.

Resolves: #87884
Releases: master, 9.5
Change-Id: I9a2d5756958e09fa89fbbc384d03c0503b70bf8c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60534
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
23 months ago[BUGFIX] Do not remove page cache for redirects issued by plugins 18/60518/3
Helmut Hummel [Fri, 19 Apr 2019 13:27:17 +0000 (15:27 +0200)]
[BUGFIX] Do not remove page cache for redirects issued by plugins

This reverts commit 3139b5608c87e7a5c2a49aa48cc683654db71e39.
"[BUGFIX] Do not cache content with different status code than 200"

At the same time we convert a plugin action to uncached,
in case a redirect is issued.

Resolves: #88178
Releases: 8.7, 9.5, master
Change-Id: Icaa8038d1fa4bf1c74dfb505c2b8fc97963ca4be
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60518
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
23 months ago[TASK] Add functional tests for hreflang tag generation 35/60635/5
Richard Haeser [Tue, 30 Apr 2019 19:41:29 +0000 (21:41 +0200)]
[TASK] Add functional tests for hreflang tag generation

To make sure rendering of hreflang tags will not change unexpectedly,
some functional tests are added.

Resolves: #88251
Related: #88140
Releases: master, 9.5
Change-Id: Idd8bc846e4bd57eb5335fe4795dcb233849eb4e8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60635
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jonas Eberle <flightvision@googlemail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
23 months ago[TASK] Upgrade and streamline typo3/phar-stream-wrapper to v3.1.1 73/60673/2
Oliver Hader [Sun, 5 May 2019 18:05:38 +0000 (20:05 +0200)]
[TASK] Upgrade and streamline typo3/phar-stream-wrapper to v3.1.1

Phar Stream Wrapper has been upgraded to version 3.1.1 in order to
solve performance and alias resolving issues. The interceptor has
been streamlined further.

composer require typo3/phar-stream-wrapper:^3.1.1

Resolves: #88277
Releases: master, 9.5, 8.7
Change-Id: Id6b08557ab507ef66e54d1f39992272fe4791405
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60673
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
23 months ago[BUGFIX] Remove non-breaking-space after list element in contenttable 84/59784/9
Patrick Lenk [Fri, 22 Feb 2019 13:34:00 +0000 (14:34 +0100)]
[BUGFIX] Remove non-breaking-space after list element in contenttable

The &nbsp; for HTMLtableCells in parseFunc_RTE has been removed.
Empty cells still contain the non-breaking space.

Resolves: #87771
Releases: master
Change-Id: Ic95a215f07597954cebffc7aff73dd15dcce986b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59784
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
23 months ago[TASK] bamboo plan for security pre-merge tests 48/60648/3
Christian Kuhn [Tue, 30 Apr 2019 10:37:39 +0000 (12:37 +0200)]
[TASK] bamboo plan for security pre-merge tests

Change-Id: Ic1e1d0f8fd1a128e542e7cada389d681ac41e10f
Resolves: #88265
Releases: master, 9.5, 8.7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60648
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <look@susi.dev>
23 months ago[BUGFIX] Allow TypoScript conditions to access PageArguments 37/60637/2
Benni Mack [Tue, 30 Apr 2019 20:35:59 +0000 (22:35 +0200)]
[BUGFIX] Allow TypoScript conditions to access PageArguments

In order to access resolved route parts by enhancers,
the TypoScript RequestWrapper should allow to access
the PageArguments object.

This way, it is easier to migrate existing conditions like

[globalVar = GP:singlepartner > 0]

to

[request.getPageArguments().get('singlepartner') > 0]

Resolves: #88252
Releases: master, 9.5
Change-Id: I6abed5badac342c88d2b40d38ecf1ea632f321d7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60637
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
23 months ago[BUGFIX] Do not open EditDocumentController in modal 27/60627/5
Andreas Fernandez [Mon, 29 Apr 2019 20:31:11 +0000 (22:31 +0200)]
[BUGFIX] Do not open EditDocumentController in modal

If `mod.web_layout.disableNewContentElementWizard=1` is set, the
"New Content Element" wizard is skipped and EditDocumentController's
FormEngine is called directly.

In that case, the modal must not get opened as this doesn't work in
combination with FormEngine.

Resolves: #88075
Releases: master, 9.5
Change-Id: Idada95f426496b49131463ec1d0e8462df163e70
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60627
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
23 months ago[BUGFIX] Support concurrent requests without 503 responses 07/60307/7
Benjamin Franzke [Fri, 22 Mar 2019 08:18:35 +0000 (09:18 +0100)]
[BUGFIX] Support concurrent requests without 503 responses

Instead of offloading the work to wait for the final page content,
concurrent requests now wait for the real page content to be
rendered (and deliver the content from cache once ready) instead
of sending a 503 response code and the famous "Page is being
generated" message.

The logic to wait for the rendered page (lock and wait) is already
there thanks to the page locking, but was deliberately circumvented
by the temporary page cache content before to get rid of waiting
requests in high-load situations.

This approach to simply skip the temporary cache and wait for the
renderer to finish has been tested using the skip_page_is_being_generated
extension in wild for 3 years (for TYPO3 v6, v7, v8 and v9).

Note: In case the increased number of waiting requests has a negative
impact on sites with high server load, a additional proxy cache should be
considered in front of the server to make sure clients are served a valid
response without waiting until new content is ready.

The motivation for this change:
The 503 status code together with the "Page is being generated message"
does not only occur for slow or high traffic sites. It will be displayed
even for two concurrent requests, no matter how fast the page rendered
or how low the current traffic is.
The requests only need to (nearly) arrive at the same time. This can
easily be reproduced using two parallel curl requests:
for i in {1..2}; do curl -sv https://doma.in/foo |& grep '^< HTTP'& done
There would be one "503 Service unavailable" response when /foo has not
yet been rendered to the cache before.

An explanation for the releaseLock('pagesection') addition in
TSFE::getFromCache(): This has been added as the pagesection lock – which
is acquired in TemplateService::start() – was implicitly released in
setPageCacheContent() before. Now this would block concurrent rendering
for pages with $_GET-aware plugins, therefore we release the pagesection
lock early, after the pagesection cache has been generated.

Releases: master, 9.5, 8.7
Resolves: #87980
Change-Id: I034f410335b3035c5863b26e3e689ca29b5f3f80
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60307
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
23 months ago[BUGFIX] Make sure a twitter:card metatag is rendered 47/60647/3
Richard Haeser [Fri, 3 May 2019 08:51:54 +0000 (10:51 +0200)]
[BUGFIX] Make sure a twitter:card metatag is rendered

To get a valid Twitter card, you need to specify the type of card
by setting the twitter:card metatag. The value of this metatag is
now set to summary by default. If this value need to be changed, you
can use the MetaTag API and set the twitter:card property with the
replace option enabled.

Resolves: #88258
Releases: master, 9.5
Change-Id: Iaeaafb2408102c2844623155611cffffa8919d43
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60647
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
23 months ago[BUGFIX] Check correct setting on extension upload 25/60625/2
Andreas Fernandez [Mon, 29 Apr 2019 19:49:10 +0000 (21:49 +0200)]
[BUGFIX] Check correct setting on extension upload

With #82368, the Configuration API is used in the Extension Manager to
check specific configuration.

However, for automatic extension installation the wrong setting was
checked. This patch now uses the correct setting, fixing an issue with
extensions not getting installed after upload.

Resolves: #87818
Related: #82368
Releases: master, 9.5
Change-Id: If18e96c4c17d06723805b4dd6c8807adabe19966
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60625
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
23 months ago[BUGFIX] Remove duplicated types of `AbstractFileFolder::$originalResource` 49/60649/2
Andreas Fernandez [Fri, 3 May 2019 14:56:06 +0000 (16:56 +0200)]
[BUGFIX] Remove duplicated types of `AbstractFileFolder::$originalResource`

Technically, it's sufficient to annotate $originalResource as type of
ResourceInterface because all other annotated types implement the
interface anyway.

This also bypasses an issue with the rewritten ClassSchema, as it can't
handle multiple annotated types of a property and fails do determine a
class type.

Resolves: #88268
Releases: master, 9.5
Change-Id: I641d3771eef39128df9ba7a51db2ebc2e0dd67a0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60649
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
23 months ago[BUGFIX] Allow Extbase FileReference in ImageService 67/60567/2
Susanne Moog [Fri, 26 Apr 2019 10:35:28 +0000 (12:35 +0200)]
[BUGFIX] Allow Extbase FileReference in ImageService

While hardening the ImageService it was restricted to core's
FileReference instead of also allowing extbase FileReferences - the
code for converting them is still there but not reachable anymore due
to the restrictive type hint.

Resolves: #88221
Releases: master
Change-Id: Id6c2ef70182f33cd28d13b4ffba7a8796548ff25
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60567
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
23 months ago[BUGFIX] Avoid raising a warning in SimpleLockStrategyTest 40/60640/2
Anja Leichsenring [Thu, 2 May 2019 06:57:45 +0000 (08:57 +0200)]
[BUGFIX] Avoid raising a warning in SimpleLockStrategyTest

The touch command raises a PHP WARNING if the test file can not be
created, but the next line would already skip the test if this
happens.
So the warning is useless and gets silenced.

Resolves: #88255
Releases: master, 9.5, 8.7
Change-Id: Id9685b6e7da8665609fa7df7f25867ab4d19a6a9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60640
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
23 months ago[BUGFIX] Unhide page translations by default 32/60632/3
Benni Mack [Tue, 30 Apr 2019 10:20:03 +0000 (12:20 +0200)]
[BUGFIX] Unhide page translations by default

In TYPO3 v8, new page translations within pages_language_overlay
were visible by default when using plain DataHandler.

In TYPO3 v9, due to the merge into "pages" for translations,
the default value for "hidden" is used. Every new page translation
is now hidden by default - this is a different behavior.

Tests had to be modified to make this work again. However,
the change now removes the "hacks" within the tests,
and adds the functionality to take-over the "hidden" flag
from the default record.

For future TYPO3 major versions, the hidden field could be migrated
into a "allowLanguageSynchronization" once the Context API
is used throughout Core properly.

Resolves: #88248
Releases: master, 9.5
Change-Id: I2a684a0d4225451c3fbfc0021c09935c1224aaca
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60632
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
23 months ago[BUGFIX] Only show records from current language in XML Sitemap 29/60629/2
Richard Haeser [Mon, 29 Apr 2019 20:51:30 +0000 (22:51 +0200)]
[BUGFIX] Only show records from current language in XML Sitemap

When generating the XML sitemap for records, the language of the
records will be checked. Only records from the current language or
all languages are added to the XML sitemap.

Resolves: #87912
Resolves: #87841
Releases: master, 9.5
Change-Id: Ibc2bc847840ff7ae6d34aa0b0b40fbe163ce2b78
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60629
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Soren Malling <soren@meteko.dk>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Soren Malling <soren@meteko.dk>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
23 months ago[FEATURE] Add custom generator options via hook 18/60418/5
Benni Mack [Tue, 9 Apr 2019 01:29:22 +0000 (03:29 +0200)]
[FEATURE] Add custom generator options via hook

In order to allow custom functionality like "Skip pages of type XYZ", a new
hook is added to the SlugHelper which can be added via

$GLOBALS['TCA']['pages']['columns']['slug']['config']['generatorOptions']['postModifiers']

The userFunc needs to return the new / modified $slug which is then put through the
sanitize() method.

TYPO3 Core does not provide custom functionality so this hook allows
to build everything a custom installation or extension wants to hook in.

Resolves: #88198
Releases: master, 9.5
Change-Id: Iad548da69ba001c696afd7d7f834d4950318c029
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60418
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <look@susi.dev>
23 months ago[BUGFIX] Have RecordState support versioning 00/60500/4
Benni Mack [Wed, 17 Apr 2019 19:36:47 +0000 (21:36 +0200)]
[BUGFIX] Have RecordState support versioning

In the initial implementation a "versioning" state was missing
in the record state for TYPO3 v9.5.

If now an editor edits an existing root page (pid=0) in a workspace,
this results in a fatal error when accessing DataHandler.

The patch adds the versionized functionality.

Resolves: #88167
Resolves: #87949
Releases: master, 9.5
Change-Id: I0c69518ecd20aafc5481eea482832c020c01f662
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60500
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Achim Fritz <af@achimfritz.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Achim Fritz <af@achimfritz.de>
Reviewed-by: Susanne Moog <look@susi.dev>
23 months ago[BUGFIX] Use correct ViewHelper argument description 20/60620/3
Jan Delius [Mon, 29 Apr 2019 15:16:22 +0000 (17:16 +0200)]
[BUGFIX] Use correct ViewHelper argument description

Resolves: #88246
Releases: master, 9.5, 8.7
Change-Id: Iad8558cbe22caaefd659fef1681452a962b5cdf7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60620
Tested-by: Rico Drexler <rico.drexler@gmx.de>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Josef Glatz <josefglatz@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Rico Drexler <rico.drexler@gmx.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Josef Glatz <josefglatz@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
23 months ago[BUGFIX] Invoke delete command via AJAX 21/60621/3
Andreas Fernandez [Mon, 29 Apr 2019 16:42:43 +0000 (18:42 +0200)]
[BUGFIX] Invoke delete command via AJAX

The delete command triggered by the page tree's context menu was invoked
by loading a URL in the module iframe which caused timing issues due to
subsequent requests.

This patch invokes an AJAX call instead to deleted pages.

Resolves: #87416
Releases: master, 9.5
Change-Id: I457df1a21e703f98f6b1a182f6165f60cfd13b21
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60621
Tested-by: Josef Glatz <josefglatz@gmail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Josef Glatz <josefglatz@gmail.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
23 months ago[BUGFIX] Let Install Tool use core's bootstrap 65/60565/3
Andreas Fernandez [Fri, 26 Apr 2019 08:40:41 +0000 (10:40 +0200)]
[BUGFIX] Let Install Tool use core's bootstrap

The Install Tool ships bootstrap on its own, which doesn't make much sense
right now, since other components get used from EXT:core as well.

For now, the separated bootstrap gets removed and the one of EXT:core is
used instead.

Resolves: #88219
Related: #88213
Releases: master, 9.5, 8.7
Change-Id: I53425f56a44fa9782d7f3776175ac08bc746e5ab
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60565
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Benni Mack <benni@typo3.org>
23 months ago[BUGFIX] Check existence of properties before usage 68/60568/8
Susanne Moog [Fri, 26 Apr 2019 10:49:34 +0000 (12:49 +0200)]
[BUGFIX] Check existence of properties before usage

The ImageViewHelper uses properties 'title' and 'alternative' from file
without checking whether they exist or not. This results in an
exception for example with freshly uploaded files.

Releases: master
Resolves: #88222
Change-Id: I2b251e5f885bd00119a958e6bc2275c7e672336f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60568
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Willi Wehmeier <wwwehmeier@gmail.com>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
23 months ago[FEATURE] Double click in structure tree changes label 82/60582/10
Dominik Merkel [Sat, 27 Apr 2019 07:50:15 +0000 (09:50 +0200)]
[FEATURE] Double click in structure tree changes label

A new convenience function has been integrated which allows the user to
change the label of an element within the structure tree.

Releases: master
Resolves: #84757
Change-Id: I7095dfbec8731714ceb2a73bb62b58aaa3cb8957
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60582
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
23 months ago[FEATURE] Send plaintext and HTML multipart mails 11/60611/13
Mathias Brodala [Sun, 28 Apr 2019 10:52:12 +0000 (12:52 +0200)]
[FEATURE] Send plaintext and HTML multipart mails

Now by default, mails sent with the EmailFinisher contain both a
plaintext and an HTML part. The latter can be controlled with the
new "addHtmlPart" option which is enabled by default.

The former "format" option is removed from the backend UI and
migrated to the new "addHtmlPart" option.

Resolves: #87200
Releases: master
Change-Id: Id0a58e8cfee07926a555d0d921fed8b41832cb77
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60611
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
23 months ago[FEATURE] Allow multiple recipients in email finisher 44/60544/37
Mathias Brodala [Thu, 25 Apr 2019 13:36:31 +0000 (15:36 +0200)]
[FEATURE] Allow multiple recipients in email finisher

Also deprecate the single recipients options
in favor of their list successors.

Resolves: #80420
Releases: master
Change-Id: I5bad6da8809bd362110025296564e3eff0df70a4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60544
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
23 months ago[TASK] Document property "elementDescription" 09/60609/4
Björn Jacob [Sun, 28 Apr 2019 09:25:38 +0000 (11:25 +0200)]
[TASK] Document property "elementDescription"

The property "elementDescription" has been documented for both the
backend (form editor) and the frontend of the form framework.

In addition, some minor contextual and spelling problems have been
fixed.

Resolves: #84229
Releases: master, 9.5
Change-Id: Ifc9039b3dc434a20783d8d67b5d6efcd1eed113e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60609
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
23 months ago[TASK] Move backend translations into Database.xlf 08/60608/3
Ralf Zimmermann [Sun, 28 Apr 2019 09:26:19 +0000 (11:26 +0200)]
[TASK] Move backend translations into Database.xlf

Resolves: #88239
Releases: master, 9.5
Change-Id: I09df1600304e4f0cff6d4cab6f45b0c966525a3c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60608
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Dominik Merkel <merkel.dominik@googlemail.com>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Dominik Merkel <merkel.dominik@googlemail.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Susanne Moog <look@susi.dev>
23 months ago[!!!][TASK] Use multiple translation files by default 93/60593/11
Mathias Brodala [Sat, 27 Apr 2019 13:51:14 +0000 (15:51 +0200)]
[!!!][TASK] Use multiple translation files by default

Resolves: #87009
Releases: master
Change-Id: I533ccf9959f0e9e3a485a3317af8befc8befeb98
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60593
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
23 months ago[BUGFIX] Fix structure of generated finisher FlexForm fields 07/60607/2
Mathias Brodala [Sat, 27 Apr 2019 21:57:25 +0000 (23:57 +0200)]
[BUGFIX] Fix structure of generated finisher FlexForm fields

A valid FlexForm field must have a "TCEforms" wrapper around
the field configuration as can be seen in the FlexFormTools
class.

Resolves: #88013
Releases: master
Change-Id: I986f4fdf6f32c7174b3967f75729bc1122d4fdbd
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60607
Tested-by: Dominik Merkel <merkel.dominik@googlemail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Dominik Merkel <merkel.dominik@googlemail.com>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
23 months ago[TASK] Avoid pointless finisher override checkbox 70/60570/8
Michael Waack [Fri, 26 Apr 2019 11:54:15 +0000 (13:54 +0200)]
[TASK] Avoid pointless finisher override checkbox

The form plugin now only renders the checkbox for overriding
the finishers if finishers are available at all. Also finishers
without options are ignored.

Resolves: #84774
Releases: master
Change-Id: I1165d054340457fdd219024f28b877a21458b603
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60570
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Dominik Merkel <merkel.dominik@googlemail.com>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Dominik Merkel <merkel.dominik@googlemail.com>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
23 months ago[TASK] Display max file size hint 95/60595/6
Susanne Moog [Sat, 27 Apr 2019 14:27:56 +0000 (16:27 +0200)]
[TASK] Display max file size hint

When configuring a form with a file size validator it can be helpful to
know what the servers' max upload capabilities are. As it may make sense
to set bigger values and then contact a server admin to adjust the
server settings, we do not want to restrict the input field. Instead,
a hint with the current configuration has been added to inform the
editor / integrator of the current limitations.

Resolves: #88055
Releases: master
Change-Id: Iaae73f8df87f47484e29a810c7531a117e35a286
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60595
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Dominik Merkel <merkel.dominik@googlemail.com>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
23 months ago[BUGFIX] Add arguments to the MimeTypeValidator error object 01/60601/2
Ralf Zimmermann [Sat, 27 Apr 2019 18:13:13 +0000 (20:13 +0200)]
[BUGFIX] Add arguments to the MimeTypeValidator error object

Enriches the ext:form MimeTypeValidator error object with the mime type
of the validated file.

Resolves: #88236
Releases: master, 9.5
Change-Id: Ie2ec6950c58841f4f942e38acf4a36a9b8b9635c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60601
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
23 months ago[BUGFIX] Use form specific flexform sheets within the frontend 48/60548/12
Ralf Zimmermann [Thu, 25 Apr 2019 15:11:23 +0000 (17:11 +0200)]
[BUGFIX] Use form specific flexform sheets within the frontend

Use contextual flexform sheets to identify ext:form finisher overrides
within the frontend.

Resolves: #88011
Releases: master, 9.5
Change-Id: I0a21deed29419281478f358ff61986d65b26dd0e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60548
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Susanne Moog <look@susi.dev>
23 months ago[TASK] Document variants of form framework 00/60600/3
Björn Jacob [Sat, 27 Apr 2019 17:14:57 +0000 (19:14 +0200)]
[TASK] Document variants of form framework

In addition, a couple of valuable examples have
been added.

Resolves: #84135
Releases: master, 9.5
Change-Id: I4de1570c990d190b4293b536b3bcdfc6e9cb8f82
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60600
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
23 months ago[BUGFIX] Add guard clause to preFileAdd form hook 96/60596/2
Susanne Moog [Sat, 27 Apr 2019 14:51:27 +0000 (16:51 +0200)]
[BUGFIX] Add guard clause to preFileAdd form hook

With the security fix in #f3445f964 checks on EXT:form file handling
were added to ensure secure form definition files. These checks are
based on FAL hooks. One of these - preFileAdd - contains checks based
on the content of the file to add, to do that, the file content is
fetched via file_get_contents. Due to a missing guard this was executed
for all file add operations instead of only for form definitions
resulting in performance loss and high memory usage. The check has
now been implemented.

Resolves: #88235
Releases: master, 9.5
Change-Id: Ie685df3d67d6ee58b1cd08f18acab1208a487ce7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60596
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Dominik Merkel <merkel.dominik@googlemail.com>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Dominik Merkel <merkel.dominik@googlemail.com>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
23 months ago[BUGFIX] Catch form errors and display speaking error message 98/60598/3
Susanne Moog [Sat, 27 Apr 2019 16:20:05 +0000 (18:20 +0200)]
[BUGFIX] Catch form errors and display speaking error message

When having a broken form configuration, the formEditor is not able
to load because of JavaScript errors. These errors are not fixable for
an editor as they most likely happen because of admins/integrators
changing and breaking the form. Instead of displaying a loading
indicator without a hint on the error that happened, a top level
catch displaying a flash message has now been implemented.

Resolves: #84595
Releases: master, 9.5
Change-Id: I44cf49d8e344629bc1a3250eade6267c7debdf00
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60598
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
23 months ago[TASK] Add clarification for link.editRecord ViewHelper 71/60571/3
Sybille Peters [Fri, 26 Apr 2019 12:06:40 +0000 (14:06 +0200)]
[TASK] Add clarification for link.editRecord ViewHelper

Resolves: #88223
Releases: master, 9.5
Change-Id: Ib6d13fcbfa4de1c0e28b6af95a26ec9fc90c4387
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60571
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
23 months ago[BUGFIX] Change finisher override display behavior 77/60577/10
Ralf Zimmermann [Fri, 26 Apr 2019 14:37:48 +0000 (16:37 +0200)]
[BUGFIX] Change finisher override display behavior

Show all possible finisher options which can be overridden within the
form plugin even if if they are not part of a form definition.

Resolves: #86635
Resolves: #85033
Releases: master, 9.5
Change-Id: Ie5ce8e2fb97e2c3fde92cbcb405d77818d1c7bda
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60577
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Susanne Moog <look@susi.dev>
23 months ago[BUGFIX] Add missing translation of validator 90/60590/2
Björn Jacob [Sat, 27 Apr 2019 12:48:21 +0000 (14:48 +0200)]
[BUGFIX] Add missing translation of validator

The missing translations of the validator "Number
of submitted values" have been added.

Resolves: #88234
Releases: master, 9.5
Change-Id: I97c8865ff2ff5a46d6d5dd598143781c5fb6d7d3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60590
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
23 months ago[BUGFIX] Add id to confirmation finisher template 88/60588/5
Dominik Merkel [Sat, 27 Apr 2019 11:57:16 +0000 (13:57 +0200)]
[BUGFIX] Add id to confirmation finisher template

Releases: master, 9.5
Resolves: #87198
Change-Id: I91b8b2f0d161ef89ba4896b063685ef2e2c8544d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60588
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
23 months ago[BUGFIX] Pass error arguments to translator 49/60549/10
Michael Waack [Thu, 25 Apr 2019 15:46:23 +0000 (17:46 +0200)]
[BUGFIX] Pass error arguments to translator

Resolves: #88022
Releases: master, 9.5
Change-Id: I7d86f8061d71357307d939d4c4359e9da1b2c68a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60549
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Dominik Merkel <merkel.dominik@googlemail.com>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Dominik Merkel <merkel.dominik@googlemail.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
23 months ago[TASK] Document validators of form framework 54/60554/8
Björn Jacob [Thu, 25 Apr 2019 19:09:03 +0000 (21:09 +0200)]
[TASK] Document validators of form framework

Furthermore, move some documentation around
regarding finishers and validators to have
the information at one central place.

In addition, fix a PHP comment regarding the
MimeType validator.

Resolves: #88212
Releases: master, 9.5
Change-Id: Ifa437294c05d3f9dba16f8bb17ac88a43796595b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60554
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
23 months ago[BUGFIX] Show "FlashMessage" finisher output 76/60576/4
Michael Waack [Fri, 26 Apr 2019 14:10:59 +0000 (16:10 +0200)]
[BUGFIX] Show "FlashMessage" finisher output

Resolves: #84699
Releases: master, 9.5
Change-Id: I2733556eae95db5f44867323cd217c4b3ea0127c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60576
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
23 months ago[BUGFIX] Fix docs of FlashMessage finisher 85/60585/2
Björn Jacob [Sat, 27 Apr 2019 08:41:28 +0000 (10:41 +0200)]
[BUGFIX] Fix docs of FlashMessage finisher

The property "options.messageCode" is mandatory. The
docs have been adapted accordingly.

Resolves: #88231
Releases: master, 9.5
Change-Id: I7617c3e54aaba046434daac5a6c01f45bac32e03
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60585
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
23 months ago[BUGFIX] Fluid viewhelper f:format.date() uses timestamp from context aspect 54/60454/9
Benni Mack [Tue, 9 Apr 2019 01:52:03 +0000 (03:52 +0200)]
[BUGFIX] Fluid viewhelper f:format.date() uses timestamp from context aspect

Use timestamp from context runtime instead of use time() in
viewhelper calls to prevent different dates in rendering process.

Resolves: #87935
Releases: master, 9.5
Change-Id: I8d4f2a231746a9a4cdc280c710ae07d9499e3d3e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60454
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
23 months ago[BUGFIX] Fix header levels for ViewHelper class comments 69/60569/2
Sybille Peters [Fri, 26 Apr 2019 11:55:30 +0000 (13:55 +0200)]
[BUGFIX] Fix header levels for ViewHelper class comments

Resolves: #88225
Releases: master, 9.5
Change-Id: I58166253bb451c829fe778379d8ada7644d63749
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60569
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
23 months ago[BUGFIX] Make AdvancedPassword confirmation error translatable 73/60573/4
Michael Waack [Fri, 26 Apr 2019 12:55:44 +0000 (14:55 +0200)]
[BUGFIX] Make AdvancedPassword confirmation error translatable

Resolves: #87722
Releases: master, 9.5
Change-Id: Icabb810a67a900ff0632256d36fb05b888912f83
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60573
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
23 months ago[BUGFIX] Render content element in ConfirmationFinisher 59/60559/4
Michael Waack [Fri, 26 Apr 2019 07:16:31 +0000 (09:16 +0200)]
[BUGFIX] Render content element in ConfirmationFinisher

Resolves: #87875
Releases: master
Change-Id: If093b8c0fa842060dcf64a984b426a8205095fe8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60559
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
23 months ago[TASK] Add editor tutorial for photo contest form 75/60575/3
Susanne Moog [Fri, 26 Apr 2019 13:43:02 +0000 (15:43 +0200)]
[TASK] Add editor tutorial for photo contest form

Add an editor tutorial to form docs for creating
photo contests to demonstrate the usage of

- image upload
- static text
- summary pages
- email to receiver finisher
- redirect finisher

Related: #82340
Resolves: #88217
Releases: master
Change-Id: I9bc0e7006a9a33ade9d9b051560843940bc4453e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60575
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>