Packages/TYPO3.CMS.git
7 years ago[SECURITY] XSS possibility in RemoveXSS
Andreas Wolf [Wed, 28 Mar 2012 11:54:19 +0000 (13:54 +0200)]
[SECURITY] XSS possibility in RemoveXSS

RemoveXSS fails to properly remove non printable characters, especially
zero-byte (\x00) chars.

Change-Id: If1caf9bda7338bd47203b55e27c5a99bbdfed3b0
Fixes: #30188
Security-Commit: 1ff7a55aefd3d4c1690e3f35760ea5ef30dab9b2
Security-Bulletin: TYPO3-CORE-SA-2012-001
Reviewed-on: http://review.typo3.org/10006
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[!!!][SECURITY] XSS in filelink element
Georg Ringer [Wed, 28 Mar 2012 11:54:15 +0000 (13:54 +0200)]
[!!!][SECURITY] XSS in filelink element

Add escaping to description and file name of file link content element.
Warning: There is no longer HTML possible in description!

Change-Id: I709af9bb05d84c5a61448b2d0b6ec8f8a20e5ec5
Fixes: #25246
Security-Commit: 7873e7e96e9a6261096910c342fefdcfa9b431bb
Security-Bulletin: TYPO3-CORE-SA-2012-001
Reviewed-on: http://review.typo3.org/10005
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[SECURITY] XSS in be_layouts
Georg Ringer [Wed, 28 Mar 2012 11:54:10 +0000 (13:54 +0200)]
[SECURITY] XSS in be_layouts

Some values from the backend layout configuration
are not properly escaped

Change-Id: Ifc5debc16e29d632f21380c1fb2e410e00633fa7
Fixes: #29536
Security-Commit: f686b42d55688dde6b6bc64f75032c56c09aed4c
Security-Bulletin: TYPO3-CORE-SA-2012-001
Reviewed-on: http://review.typo3.org/10004
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[SECURITY] Information disclosure showing DB name
Georg Ringer [Wed, 28 Mar 2012 11:54:06 +0000 (13:54 +0200)]
[SECURITY] Information disclosure showing DB name

By accessing a cli script in the frontend, it is possible
that the DB name is shown.

Change-Id: I123530c4814dd1ac4a3af6d5eaea3df62dc11297
Fixes: #29060
Security-Commit: 1d43d5ccf1f2d1e6ffbe8600795ea8235e8cd6d3
Security-Bulletin: TYPO3-CORE-SA-2012-001
Reviewed-on: http://review.typo3.org/10003
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[TASK] Raise submodule pointer
TYPO3 v4 Release Team [Wed, 28 Mar 2012 11:46:16 +0000 (13:46 +0200)]
[TASK] Raise submodule pointer

Change-Id: I05969b15725e0b4b72101158fc29ec2f14d1da6e
Reviewed-on: http://review.typo3.org/9985
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[BUGFIX] Missing column in t3lib_TCEmain::getPreviousLocalizedRecordUid
Francois Suter [Tue, 27 Mar 2012 07:52:10 +0000 (09:52 +0200)]
[BUGFIX] Missing column in t3lib_TCEmain::getPreviousLocalizedRecordUid

Method t3lib_TCEmain::getPreviousLocalizedRecordUid() checks for the
"closest" localized record. For content elements it does this per
column, but actually fails because the "colPos" field is not among
the available fields. It must be added to the selection.

Change-Id: I9ee37697484a56345c21938515a265e0f47fe801
Fixes: #35260
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/9961
Reviewed-by: Francois Suter
Tested-by: Francois Suter
7 years ago[TASK] Clean-up PHPdoc comments in t3lib_PageRenderer
Kai Vogel [Thu, 22 Mar 2012 19:01:09 +0000 (20:01 +0100)]
[TASK] Clean-up PHPdoc comments in t3lib_PageRenderer

Back-port of clean-up that was introduced with #27694.

Change-Id: I089c9e47ace839722a532e807949f86dde6917ec
Resolves: #35158
Related: #27694
Releases: 4.5
Reviewed-on: http://review.typo3.org/9814
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[BUGFIX] Instance properties are defined statically
Kai Vogel [Thu, 22 Mar 2012 19:06:41 +0000 (20:06 +0100)]
[BUGFIX] Instance properties are defined statically

Instance properties are defined statically in t3lib_PageRenderer

Change-Id: I245d8a73e9abca8ac3bdef141605b91a09c845e0
Resolves: #35159
Related: #27694
Releases: 4.5
Reviewed-on: http://review.typo3.org/9815
Reviewed-by: Philipp Gampe
Reviewed-by: Oliver Klee
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[TASK] Add missing sql_free_result in alt_doc.php
Wouter Wolters [Mon, 19 Mar 2012 20:22:29 +0000 (21:22 +0100)]
[TASK] Add missing sql_free_result in alt_doc.php

Add missing sql_free_result in alt_doc.php to free hanging
records properly.

Change-Id: Ic6317ddc7810daf987c3801c13f4f968c4d317e9
Resolves: #34771
Releases: 4.8, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/9866
Reviewed-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Tooltips for items in groupfields are not moved
Jigal van Hemert [Sun, 25 Mar 2012 06:57:47 +0000 (08:57 +0200)]
[BUGFIX] Tooltips for items in groupfields are not moved

In groupfields the title attribute of options must also be handled
when moving items.

Change-Id: I5ef76f6648a3e62140ef8984dd7a8b1e8de9bcd8
Fixes: #35176
Releases: 6.0, 4.7, 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/9862
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[BUGFIX] Blank page after Save+Close in page settings
Stefan Galinski [Thu, 23 Feb 2012 22:16:56 +0000 (23:16 +0100)]
[BUGFIX] Blank page after Save+Close in page settings

Change-Id: Idd7647e0e1aaee607203f64c421d6ca235920268
Fixes: #33791
Releases: 4.8, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/9830
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years ago[TASK] Code clean-up in t3lib_PageRenderer
Oliver Hader [Thu, 22 Mar 2012 19:38:05 +0000 (20:38 +0100)]
[TASK] Code clean-up in t3lib_PageRenderer

Change-Id: If57379120c688dc284a83ca5689e51332c0f354c
Resolves: #35160
Releases: 4.5, 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/9816
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-on: http://review.typo3.org/9839
Reviewed-by: Oliver Klee
7 years ago[BUGFIX] Non-static methods in t3lib_cache are called statically
Steffen Müller [Thu, 22 Mar 2012 14:28:26 +0000 (15:28 +0100)]
[BUGFIX] Non-static methods in t3lib_cache are called statically

Change-Id: Iaac0b179afc4aeb08452e5fd658ec046deb1cd5a
Releases: 4.5
Fixes: #35148
Reviewed-on: http://review.typo3.org/9798
Reviewed-by: Georg Ringer
Reviewed-by: Oliver Klee
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[BUGFIX] t3lib_div should contain only static methods
Jigal van Hemert [Thu, 22 Mar 2012 06:40:53 +0000 (07:40 +0100)]
[BUGFIX] t3lib_div should contain only static methods

A few methods don't have the static keyword. This leads to PHP notices.

Change-Id: Ie7d328a4789f577552486fcb4bf441e533ee161d
Fixes: #30050
Releases: 4.5
Reviewed-on: http://review.typo3.org/9795
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Philipp Gampe
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years agoRevert "[BUGFIX] showAccessRestrictedPages doesn't replace links to restricted subpages"
Helmut Hummel [Sun, 11 Mar 2012 20:13:41 +0000 (21:13 +0100)]
Revert "[BUGFIX] showAccessRestrictedPages doesn't replace links to restricted subpages"

Commit 3dd43f601820dac0d5009c0b06f1501899253b51 introduced a major
performance overhead and is reverted for now.

Change-Id: I41311fb2769db1b5d45c249f5bdf90aba60220fc
Releases: 4.8, 4.7, 4.6, 4.5
Resolves: #32756
Reviewed-on: http://review.typo3.org/9552
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Fix baseurl handling of IE with RTE htmlArea in FE and realurl
Stanislas Rolland [Fri, 16 Mar 2012 23:50:44 +0000 (19:50 -0400)]
[BUGFIX] Fix baseurl handling of IE with RTE htmlArea in FE and realurl

Problem: IE does not support document.baseURI and document.URL is
incorrect when using realurl.
Solution: Get first base tag and extract href as base for iframe
document.
Note: Thanks to Christoph Niewerth

Change-Id: Ieeb672cab3f49e2476d5eb063453076039348cb2
Resolves: #30847
Releases: 4.5, 4.6,4.7, master
Reviewed-on: http://review.typo3.org/9709
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] Fatal error 't3lib_lock' does not exist
Oliver Hader [Wed, 14 Mar 2012 09:28:12 +0000 (10:28 +0100)]
[BUGFIX] Fatal error 't3lib_lock' does not exist

The PHP fatal error occurs for the following settings:
$TYPO3_CONF_VARS['SYS']['enableDeprecationLog'] is enabled
$TYPO3_CONF_VARS['BE']['forceCharset'] is not "utf-8" (or empty)
$TYPO3_CONF_VARS['SYS']['enableDeprecationLog'] is set to "file"

Change-Id: Ic4815ab40e60b8bb0d18b0f15261cb09c9d44280
Fixes: #34662
Releases: 4.5, 4.6, 4.7, 4.8
Reviewed-on: http://review.typo3.org/9639
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Oliver Klee
Reviewed-by: Sebastian Michaelsen
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[TASK] Set TYPO3 version to 4.5.14-dev
TYPO3 v4 Release Team [Tue, 13 Mar 2012 09:44:15 +0000 (10:44 +0100)]
[TASK] Set TYPO3 version to 4.5.14-dev

Change-Id: I10b99bfa396c9d5198486fc39879e1af629ee8c7
Reviewed-on: http://review.typo3.org/9603
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[RELEASE] Release of TYPO3 4.5.13
TYPO3 v4 Release Team [Tue, 13 Mar 2012 09:44:05 +0000 (10:44 +0100)]
[RELEASE] Release of TYPO3 4.5.13

Change-Id: I211f6a296be2ffc8f2331c424764266ed8b5cc1a
Reviewed-on: http://review.typo3.org/9602
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[TASK] Raise submodule pointer
TYPO3 v4 Release Team [Tue, 13 Mar 2012 09:33:52 +0000 (10:33 +0100)]
[TASK] Raise submodule pointer

Change-Id: I5addf806fa443362eb53482519bc03d587d4f3b2
Reviewed-on: http://review.typo3.org/9600
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[BUGFIX] Mail sending fails with quoted&encoded e-mail addresses
Dmitry Dulepov [Mon, 5 Mar 2012 10:21:18 +0000 (12:21 +0200)]
[BUGFIX] Mail sending fails with quoted&encoded e-mail addresses

Mail sending fails if the name in the e-mail address is quoted
but requires encoding to base64 or quoted-printable. The
t3lib_div::encodeHeader() function encodes the name without
taking quotation into account.

Change-Id: Id421914c221cfa26e5198c936abdc9156406995b
Resolves: #34526
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/9596
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[BUGFIX] RTE in frontend with IE9: Use IE8 standards mode (TYPO3 4.5)
Stanislas Rolland [Thu, 8 Mar 2012 20:41:43 +0000 (15:41 -0500)]
[BUGFIX] RTE in frontend with IE9: Use IE8 standards mode (TYPO3 4.5)

Problem: TYPO3 4.5 uses ExtJS 3.3 which does not fully support IE9.
Solution: When using RTE in FE, add meta tag instructing IE9 to use
IE8 standards mode.

Change-Id: I6f170a00e5e4f6a80449aed6f9f2a6737ed6a108
Resolves: #34100
Releases: 4.5
Reviewed-on: http://review.typo3.org/9506
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Steffen Ritter
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] Better condition in versionOL of t3lib_tstemplate
Mario Rimann [Sun, 11 Mar 2012 11:54:13 +0000 (12:54 +0100)]
[BUGFIX] Better condition in versionOL of t3lib_tstemplate

Changes the condition to determine whether we're in the
frontend or in the backend.

Change-Id: I989359e25c6f05e3075b2a2403a5ba2487b45c90
Related: #25144
Resolves: #31139
Releases: 4.5
Reviewed-on: http://review.typo3.org/7043
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Oliver Klee
Reviewed-by: Markus Klein
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[BUGFIX] No content in workspace preview when using select.selectFields
Tolleiv Nietsch [Mon, 10 Oct 2011 01:32:02 +0000 (03:32 +0200)]
[BUGFIX] No content in workspace preview when using select.selectFields

The TypoScript property select.selectFields does not consider workspaces
in the frontend rendering process.

Taking the results from #29783 into account.

Change-Id: I6b2b68ed03163e9e0d7dd281aafea8af67fec224
Resolves: #17284
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/4950
Reviewed-by: Oliver Hader
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[BUGFIX] t3lib_BEfunc::getViewDomain() returns wrong or no domain
Jaume Prat [Tue, 22 Nov 2011 09:57:14 +0000 (10:57 +0100)]
[BUGFIX] t3lib_BEfunc::getViewDomain() returns wrong or no domain

If the TYPO3 BE host name is not configured as a sys_domain record
t3lib_BEfunc::getViewDomain() will always return TYPO3 BE host name
and not the first domain of the root line of the page which is
being previewed.

Furthermore, if the TYPO3 BE host name is configured as a sys_domain
but the current root line does not contain a valid domain record,
t3lib_BEfunc::getViewDomain() will return only 'http://' ie. no domain.

Change-Id: I12f2fa3aaee785e4577a93a61aad3b136ae03756
Fixes: #30892
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/9317
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[TASK] Invalid SQL and bad code in tslib_fe
Dmitry Dulepov [Tue, 29 Nov 2011 13:21:10 +0000 (15:21 +0200)]
[TASK] Invalid SQL and bad code in tslib_fe

tslibe_fe::determineId() contains invalid SQL statement (using "!=")
and bad code (variable "$idQ", missing check for start/stop dates).

Change-Id: I72a27bf45c209ef07de6c53272dad7ae3b8c382d
Resolves: #32159
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7409
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[BUGFIX] Invalid "unequal"-statement and string-quoting in SQL
Stefan Neufeind [Mon, 19 Dec 2011 13:24:31 +0000 (14:24 +0100)]
[BUGFIX] Invalid "unequal"-statement and string-quoting in SQL

There are multiple "!=" in SQL statements. They should be "<>".
MySQL understands "!=" for the compatibility with early versions
but it is not a standard SQL and should not be used.

Strings should be enclosed in single-quotes. Some systems use
double-quotes to mark identifiers in contrast to literals.

(Added some small fullQuote-calls along the way for
completeness or dropped quotes where uid is clearly just
an intval.)

Change-Id: If183e3451dac4cebb179b4c1f8c2e0ef6d5a6efd
Resolves: #32161
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8901
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[BUGFIX] Livesearch does not find all pages
Udo Leimberger [Mon, 22 Aug 2011 06:19:34 +0000 (08:19 +0200)]
[BUGFIX] Livesearch does not find all pages

If you are a BE user with various mount points (no admin), live search
does not find all pages.

Change-Id: I67e4fa56a8514f19cfbb8f181655c473a375ea5d
Resolves: #29086
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/7112
Reviewed-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[TASK] Raise submodule pointer
TYPO3 v4 Release Team [Mon, 12 Mar 2012 16:06:42 +0000 (17:06 +0100)]
[TASK] Raise submodule pointer

Change-Id: I6e0dfcb3c8266770831bafc6956ff617b92926c3
Reviewed-on: http://review.typo3.org/9576
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[BUGFIX] *IFSUB ignores l18n_cfg field
Stefan Galinski [Fri, 23 Sep 2011 18:55:00 +0000 (20:55 +0200)]
[BUGFIX] *IFSUB ignores l18n_cfg field

The l18n_cfg field is used to prevent the appearance of the default
language record or any alternative language records that haven't a translation
in the menu. At the first glance it seems to work like expected, because the
expected page records are not visible in a configured frontend menu. If we have a
closer look at this part, we will see that the flag is badly ignored for the
"*IFSUB" record states. This causes that a page record which has no visible
subpages is marked with the hasSubmenu flag.

Change-Id: I59cd0fda4e198ea326b7ad9b26add1cb244d2c82
Resolves: #19925
Releases: 4.7, 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/8939
Reviewed-by: Stefan Galinski
Tested-by: Stefan Galinski
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[TASK] Change typo3.com to typo3.org
Jigal van Hemert [Thu, 8 Mar 2012 22:06:09 +0000 (23:06 +0100)]
[TASK] Change typo3.com to typo3.org

As typo3.com will be redirected to typo3.org
all links inside the Core should be replace too

Change-Id: Ide780688bea3c4a3ce8820521014dc005b00464b
Resolves: #34441
Releases: 4.8,4.7,4.6,4.5
Reviewed-on: http://review.typo3.org/9508
Reviewed-by: Sebastian Fischer
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[TASK] EM: make pop-up window use full screen
Francois Suter [Fri, 9 Sep 2011 10:06:02 +0000 (12:06 +0200)]
[TASK] EM: make pop-up window use full screen

The information pop-up window in the Extension Manager is hard-coded
to some reduced size. Make it use the full screen instead, as it is
modal anyway. This provides more space to view all the information.

Change-Id: Id0721ecbd6224acdc26aee753e935324bf3ee430
Resolves: #29585
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/4882
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Francois Suter
Tested-by: Francois Suter
7 years ago[BUGFIX] Unset stdWrap of select.pidInList
Marc Bastian Heinrichs [Fri, 2 Dec 2011 15:23:20 +0000 (16:23 +0100)]
[BUGFIX] Unset stdWrap of select.pidInList

Using stdWrap features on select.pidInList together with slide will
result in an endless loop because the same parentPids are
selected over and over again till the max execution time is reached.

This patch unsets the stdWrap properties after the first run.

Change-Id: Ib5c3bcbb1618026af1769ccc2c7dfb1e86a26477
Fixes: #28526
Releases: 4.4, 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/8944
Reviewed-by: Sebastian Michaelsen
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Sebastian Fischer
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[BUGFIX] Skip t3lib_divTest::fixPermissionsSetsGroup on MacOS
Oliver Klee [Sat, 9 Jul 2011 09:02:21 +0000 (11:02 +0200)]
[BUGFIX] Skip t3lib_divTest::fixPermissionsSetsGroup on MacOS

This test makes use of posix_getegid which on Mac OS always returns -1,
thus making it useless for getting the effective group ID.

Change-Id: I5a1cc6ceb8613aa4186c99f06e696668f3e9dde4
Resolves: #28017
Releases: 4.6, 4.5, 4.4, 4.3
Reviewed-on: http://review.typo3.org/7125
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[BUGFIX] Localization of child records fails when using MM type relations
Oliver Hader [Wed, 23 Mar 2011 18:19:18 +0000 (19:19 +0100)]
[BUGFIX] Localization of child records fails when using MM type relations

Regular MM references are not localized, however if Inline Relational
Record Editing (IRRE) is used here, it would be the expected behaviour.

Unit tests are available in the irre_tutorial:
http://forge.typo3.org/projects/show/extension-irre_tutorial

Change-Id: Ia966787037acdb5311ebdb043cdfbd06967da5b0
Resolves: #25131
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1987
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Tested-by: Philipp Gampe
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[BUGFIX] Warnings in tcemain on iterating over unset columns
Mario Rimann [Thu, 16 Feb 2012 21:30:18 +0000 (22:30 +0100)]
[BUGFIX] Warnings in tcemain on iterating over unset columns

Adds a check if the TCA for the table has a columns setting at all
before iterating over the columns of that table.

Change-Id: I140058926a32d21192320d007852db2f91b1a6d8
Fixes: #32467
Branches: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/9075
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[BUGFIX] Translated mailform should use localized email
Michael Stucki [Sun, 15 Jan 2012 22:09:10 +0000 (23:09 +0100)]
[BUGFIX] Translated mailform should use localized email

In case mailforms are translated the email adress from the
translated record is ignored.

Change-Id: I4cf05157cff40e68ebe35c1c242af711dc0a3497
Fixes: #17061
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8958
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[BUGFIX] process_datamap doesn't handle existing versions by itself
Bart Dubelaar [Wed, 25 Jan 2012 13:14:28 +0000 (14:14 +0100)]
[BUGFIX] process_datamap doesn't handle existing versions by itself

The process_datamap function in TCEmain expects to receive the ids of the
existing offline counterparts of a record whenever operations are performed in a
workspace. This implies that this has taken into account in all places where
the process_datamap function is called. In some cases this is not properly done, see
bug #32780 and related. The process_cmdmap function does handle this transparently,
so it is desirable to have the same behavior in process_datamap.

This fix implements the translation to versioned records for operations on a single record.
Operations with child records (IRRE) still require the versioned id's, no bugs
 are known that would require this behavior to be changed.

Change-Id: I26618f6b2d4f694a7b5b9b14e1c3d0c343a900ce
Fixes: #32780
Releases: 4.5
Reviewed-on: http://review.typo3.org/8688
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[BUGFIX] getSingleField_typeFlex doesn't respect TSconfig settings
Jo Hasenau [Tue, 16 Aug 2011 15:37:28 +0000 (17:37 +0200)]
[BUGFIX] getSingleField_typeFlex doesn't respect TSconfig settings

Change-Id: Icebe8d08c47aa22941b25007c10e55b99018cfea
Resolves: #29019
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/7117
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[BUGFIX] No image generation with PHP-SAFE_MODE (GM/IM)
Jigal van Hemert [Sat, 10 Mar 2012 18:07:10 +0000 (19:07 +0100)]
[BUGFIX] No image generation with PHP-SAFE_MODE (GM/IM)

With safe_mode enabled all imagemagick/graphicsmagick calls will fail.
Solution is to only apply escapeshellarg if it is useful.

Change-Id: Iefeb7c0974440e93710d23a289fe1082a5128b72
Resolves: #24369
Releases: 4.4, 4.5
Reviewed-on: http://review.typo3.org/1448
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[BUGFIX] Send no-cache headers in t3lib_userauth
Alexander Stehlik [Fri, 1 Apr 2011 17:32:21 +0000 (19:32 +0200)]
[BUGFIX] Send no-cache headers in t3lib_userauth

Adjust headers sent by t3lib_userauth to prevent caching, if
Internet Explorer is used when downloading files through PHP.

Change-Id: I94a3f1b7f05e15cef23519f76127114251a3eabc
Fixes: #24125
Releases: 4.4, 4.5, 4.6, 4.7, 4.8
Reviewed-on: http://review.typo3.org/6698
Reviewed-by: Stefan Neufeind
Reviewed-by: Sebastian Fischer
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[BUGFIX] RTE: Inserting a table is broken
Stanislas Rolland [Wed, 7 Mar 2012 17:59:19 +0000 (12:59 -0500)]
[BUGFIX] RTE: Inserting a table is broken

Problem: The error is related to the color border settings.
Solution: HTMLArea.util.Color.colorToHex should return an empty string
rather than null.

Change-Id: I8dfeaca6fd9b2298c4120bdd4e3d4f76be5d3576
Resolves: #34634
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/9466
Reviewed-by: Stefan Neufeind
Reviewed-by: Jan Loderhose
Tested-by: Jan Loderhose
Reviewed-by: Henrik Ziegenhain
Tested-by: Henrik Ziegenhain
Reviewed-by: Benny Schimmer
Tested-by: Benny Schimmer
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] Error when editing a record with additionalPreviewLanguage and an deleted...
Andreas Wolf [Thu, 1 Sep 2011 17:39:38 +0000 (19:39 +0200)]
[BUGFIX] Error when editing a record with additionalPreviewLanguage and an deleted l18n_parent

The behaviour that causes the error (translated elements are not deleted
when deleting parent) is fixed in recent TYPO3 versions; it is better to
do that additional check anyways (for old installations).

Change-Id: I1eb1b5ed731b86285a54c87e82b738a1841f0d72
Resolves: #17910
Releases: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/6210
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years ago[BUGFIX] Images from TER hosters break SSL
Georg Ringer [Fri, 24 Feb 2012 06:19:13 +0000 (07:19 +0100)]
[BUGFIX] Images from TER hosters break SSL

The logos should be fetched in the same context as the backend.
If https is used there, images are now loaded also via https

Change-Id: I8d210facfe89cbdae2ebd1d07da6cb8c51e5bbdb
Fixes: #34203
Releases: 4.8, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/9439
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[BUGFIX] flock() calls in TYPO3 prevent NFS hosting
Dmitry Dulepov [Mon, 21 Nov 2011 14:13:28 +0000 (16:13 +0200)]
[BUGFIX] flock() calls in TYPO3 prevent NFS hosting

flock() happens in several places in TYPO3. This function does
not work properly on NFS shares. t3lib_lock should be used
instead.

Change-Id: I30392bf06c5e20e27e929fb06d77ee9f96978902
Resolves: #31460
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7506
Reviewed-by: Stefan Neufeind
Reviewed-by: Oliver Klee
Reviewed-by: Ivan Dharma Kartolo
Tested-by: Ivan Dharma Kartolo
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[TASK] Update copyright year to 2012
Ernesto Baschny [Wed, 7 Mar 2012 08:21:34 +0000 (09:21 +0100)]
[TASK] Update copyright year to 2012

Change-Id: Iea990864d55d90d5dc5cf0c3a238e7ede3adc75f
Resolves: #34600
Releases: 4.4, 4.5, 4.6, 4.7, 4.8
Reviewed-on: http://review.typo3.org/9442
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
7 years ago[BUGFIX] cmpIPv4: prevent E_NOTICE, cleanup compare, testcases
Stefan Neufeind [Mon, 6 Jun 2011 00:17:33 +0000 (02:17 +0200)]
[BUGFIX] cmpIPv4: prevent E_NOTICE, cleanup compare, testcases

Cleanup for an E_NOTICE on exploding the bitmask.
Replaced (correct working, but "unreadable") strcmp().
Add testcases.

Change-Id: I99c7007e11cd3c9740ab6acfd770dd2ea8cd1545
Resolves: #27230
Releases: 4.3, 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/7129
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years ago[TASK] Set TYPO3 version to 4.5.13-dev
TYPO3 v4 Release Team [Tue, 6 Mar 2012 10:28:05 +0000 (11:28 +0100)]
[TASK] Set TYPO3 version to 4.5.13-dev

Change-Id: I36e0e20fbd2d9053463d9e49b06e4f092596aa51
Reviewed-on: http://review.typo3.org/9416
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[RELEASE] Release of TYPO3 4.5.12
TYPO3 v4 Release Team [Tue, 6 Mar 2012 10:27:57 +0000 (11:27 +0100)]
[RELEASE] Release of TYPO3 4.5.12

Change-Id: I949425736173f9fa0a2e32bbbbc4e4c7bbcec353
Reviewed-on: http://review.typo3.org/9415
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[TASK] Raise submodule pointer
TYPO3 v4 Release Team [Tue, 6 Mar 2012 10:14:34 +0000 (11:14 +0100)]
[TASK] Raise submodule pointer

Change-Id: I817493e7bbf022eaef75f19b6c4c8ec8d1d49af7
Reviewed-on: http://review.typo3.org/9411
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[BUGFIX] Media element does not recognize short YouTube links
Robert Heel [Tue, 17 Jan 2012 13:57:35 +0000 (14:57 +0100)]
[BUGFIX] Media element does not recognize short YouTube links

Change-Id: I97a0071aec31b6d45ee4a164bb0dc2ffafacd03c
Fixes: #33089
Releases: 4.8, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/9406
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] Add the title and increase width of the multiple select boxes
Thomas Layh [Sat, 18 Feb 2012 19:15:38 +0000 (20:15 +0100)]
[BUGFIX] Add the title and increase width of the multiple select boxes

The db, file and select boxes are too narrow. This makes it hard
to to impossible to read long entries.
Increase the width of those fields and add a title to each entry
in order to allow the user to see the full entry on hover.
Also add a parameter to the javascript function that takes care of the
selection of entries to support the new title attribute.

Change-Id: Ib03d45ac5884a6e5e91b9990043e1046ce69406e
Fixes: #32732
Releases: 4.7,4.6,4.5
Reviewed-on: http://review.typo3.org/8979
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Thomas Layh
Tested-by: Thomas Layh
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[BUGFIX] Misleading error with empty USER_INT
Philipp Gampe [Mon, 13 Feb 2012 17:50:22 +0000 (18:50 +0100)]
[BUGFIX] Misleading error with empty USER_INT

Just skip rendering of a USER_INT which does not have any properties.

Change-Id: Id8c863470a86bd59bfb2b83d7fdfd5579f79015b
Fixes: #23347, #30623
Releases: 4.5,4.6,4.7,4.8
Reviewed-on: http://review.typo3.org/9395
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[BUGFIX] tslib_pibase: Outdated PHPDoc comment for pi_loadLL()
Stefan Rotsch [Fri, 13 Jan 2012 07:57:46 +0000 (08:57 +0100)]
[BUGFIX] tslib_pibase: Outdated PHPDoc comment for pi_loadLL()

The PHPDoc comment for function pi_loadLL() still refers to a
"locallang.php" file, but other file extensions are now in use

Change-Id: I2b7a49e922bd94467c0054537f2c5e0172b8c9f4
Fixes: #33160
Releases: 4.8, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/9392
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years ago[TASK] Remove typo3/logomenu.php
Christian Kuhn [Wed, 29 Feb 2012 22:55:41 +0000 (23:55 +0100)]
[TASK] Remove typo3/logomenu.php

typo3/logomenu.php contains class SC_logomenu that extends t3lib_topmenubase.
But t3lib_topmenubase does not exist anymore since TYPO3 4.2, so SC_logomenu
is broken.

Change-Id: I7e353c936c677b31462806fa1dc157d95795f81b
Resolves: #34427
Releases: 4.8, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/9314
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Raise submodule pointer
TYPO3 v4 Release Team [Tue, 28 Feb 2012 21:19:43 +0000 (22:19 +0100)]
[TASK] Raise submodule pointer

Change-Id: Ib6c1e7b5131f432bdf88e9b010500596da265666
Reviewed-on: http://review.typo3.org/9282
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[BUGFIX] PHP Warning when moving a record
Xavier Perseguers [Mon, 27 Feb 2012 16:45:07 +0000 (17:45 +0100)]
[BUGFIX] PHP Warning when moving a record

Call to t3lib_TCEmain::moveL10nOverlayRecords() misses 4th parameter.

Change-Id: I5e0814497791fd904df809b5c19171f3e5d2936a
Fixes: #34135
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/9259
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] EM: make update window modal
Francois Suter [Fri, 9 Sep 2011 12:30:45 +0000 (14:30 +0200)]
[BUGFIX] EM: make update window modal

The UPDATE! script pop-up window in the new Extension Manager is hard-coded
to some reduced size and is not modal. This makes it possible to open
it several times, which might cause conflicts. Make it model to prevent
this situation.

Change-Id: Icd8c353c96b91155b6b3bb3bfbf161d33d9b8626
Resolves: #29593
Releases: 4.5
Reviewed-on: http://review.typo3.org/4891
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Francois Suter
Tested-by: Francois Suter
7 years ago[BUGFIX] Content rendering: Definition lists in RTE are wrapped in p
Tolleiv Nietsch [Fri, 17 Feb 2012 09:00:16 +0000 (10:00 +0100)]
[BUGFIX] Content rendering: Definition lists in RTE are wrapped in p

Definition lists entered in the RTE are wrapped in paragraph tags when
rendered in the frontend. This is not valid HTML.

Solution: Add dl and dd to lib.parseFunc_RTE.externalBlocks and
process them recursively like div. Add dt to
nonTypoTagStdWrap.encapsLines.encapsTagList

Change-Id: I5f5693ad6aabc18a947ecaa35f232ef7d1bf892e
Resolves: #25083
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/9078
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years ago[BUGFIX] Don't save form protection error messages in session
Helmut Hummel [Sun, 25 Sep 2011 14:52:53 +0000 (16:52 +0200)]
[BUGFIX] Don't save form protection error messages in session

Do not persist flash messages in the session if we are in an Ajax context
because then the flash message is rendered out of context the next time
the flash message queue is flushed.

Change-Id: Ifbe579d5507a677d859dcd4365cea0134b1804e0
Resolves: #30272
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/9111
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[BUGFIX] TCE: error message if no label has been set in TCA
Mario Rimann [Tue, 29 Nov 2011 21:46:51 +0000 (22:46 +0100)]
[BUGFIX] TCE: error message if no label has been set in TCA

Avoids an invalid SQL query if no label column is specified by the
TCA for a certain table.

Change-Id: I3de10414fa73b910de350bc6a6aa65491b74d48f
Fixes: #17947
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/9107
Reviewed-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] getAllowedItems called with one parameter too much
Stefan Neufeind [Fri, 17 Feb 2012 09:47:35 +0000 (10:47 +0100)]
[BUGFIX] getAllowedItems called with one parameter too much

getAllowedItems() is called with two parameters. However
the second one is not in the function-definition and not used.

Change-Id: I69cd3c4362c36adc3e6f1e2bc1ae1ba7bfb38c77
Fixes: #34030
Releases: 4.4, 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/9087
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] Scheduler BE module fails to load due to autoloader issues
Tolleiv Nietsch [Wed, 8 Feb 2012 07:51:13 +0000 (08:51 +0100)]
[BUGFIX] Scheduler BE module fails to load due to autoloader issues

When displaying a list of tasks, scheduler unserializes exceptions.
If the exception class is not known to the autoloader, PHP will
return an instance of _PHP_Incomplete_Class. This instance is
tested for to prevent a fatal error.

Change-Id: Ifc8c90787ada60af6b5892f67dc7adf6d90e916d
Resolves: #33116
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8897
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Additional unit tests for t3lib_div::mkdir and mkdir_deep
Loek Hilgersom [Thu, 8 Dec 2011 01:02:57 +0000 (02:02 +0100)]
[TASK] Additional unit tests for t3lib_div::mkdir and mkdir_deep

Added tests check if permissions and group ownership gets correctly
set when creating directories, also when a whole path is created
with mkdir_deep. These tests are created specifically for
https://review.typo3.org/7022
Omitted checks for thrown exceptions (not part of 4.5)

Change-Id: I19003d043729d6b3f8647b5175996e998843bb55
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8756
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[BUGFIX] htmlArea RTE: Target of localized string may be empty
Stanislas Rolland [Mon, 13 Feb 2012 19:40:34 +0000 (14:40 -0500)]
[BUGFIX] htmlArea RTE: Target of localized string may be empty

Solution: Do not allow an empty localized string to overrule the
default string.

Change-Id: I5b270b7b2888f5ff5d087ed2b65c9e5a55f17f30
Fixes: #33897
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/9017
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] htmlArea RTE: Default skin inconsistent with ExtJS xtheme-blue
Stanislas Rolland [Mon, 13 Feb 2012 16:56:40 +0000 (11:56 -0500)]
[BUGFIX] htmlArea RTE: Default skin inconsistent with ExtJS xtheme-blue

The default RTE skin, used as default skin in FE, has colors
inconsistent with ExtJS skin xtheme-blue which is loaded by default
in FE.

Change-Id: I8c1714c133f503a7ebc4b9af0ccd7f09709e90ef
Fixes: #33889
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/9012
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX][t3editor] (De-)Activating does not work in Chrome
Steffen Gebert [Fri, 10 Feb 2012 21:48:00 +0000 (22:48 +0100)]
[BUGFIX][t3editor] (De-)Activating does not work in Chrome

The checkbox "Deactivate t3editor" does not work in modern Chrome
versions (e.g. 18). It works in Firefox, but didn't even work while
integrating the code into TYPO3 in Chrome.

Prototype recognizes it as Webkit and thus does not disable/enable it,
which was a pretty weird implementation, which is now removed.

Change-Id: I9660af7c754d25b1321c329e9d67f80ba6d71db8
Fixes: #33515
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/9011
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
7 years ago[BUGFIX] Sorting of localized records is wrong after copying
Stanislas Rolland [Wed, 19 Oct 2011 16:15:50 +0000 (12:15 -0400)]
[BUGFIX] Sorting of localized records is wrong after copying

Solution: When copying a record in original language, if a localized
record of the destination record exists for language A, then the
localized record of the copied record, if it exists for language A,
should be inserted after the localized record, in language A, of the
destination record.
The same applies when moving a record in original language.
Similar situation arises when a new localization record is created.

Note: Backport from 4.7

Change-Id: I45464837e4685efbcf4671a6135a631d0c40d068
Resolves: #30469
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/8679
Reviewed-by: Stefan Neufeind
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[BUGFIX] Sporadic memcache error on server load
Dmitry Dulepov [Thu, 6 Oct 2011 14:00:54 +0000 (17:00 +0300)]
[BUGFIX] Sporadic memcache error on server load

Memcache server sometimes closes connection under heavy load. In
such cases TYPO3 shows error messages in Frontend when setting
the value to cache fails. This should not happen because it is
not such a error that should cause server down times. Change the
exception to a warning in sys_log instead. Admins can see the
error and work on it.

Change-Id: I3d461ef2517d8d10a161c1a1404931543681bb97
Fixes: #30162
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/5600
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Oliver Klee
Reviewed-by: Wouter Wolters
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[BUGFIX] IRRE translation links shouldn't be shown if no parent
Georg Ringer [Fri, 25 Nov 2011 06:45:13 +0000 (07:45 +0100)]
[BUGFIX] IRRE translation links shouldn't be shown if no parent

IRRE provides some links like "localize records" or "synchronize with
original language" which is great but those links should not be
shown if a record got no parent record

Change-Id: I4ea318abd0580fa79bce0b2dd98316027f7ddc57
Fixes: #32073
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8899
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[BUGFIX] Confusing error message in reports module
Markus Klein [Sun, 18 Dec 2011 04:48:51 +0000 (22:48 -0600)]
[BUGFIX] Confusing error message in reports module

The saltedpasswords status report shows "INSECURE" warnings
although the configuration is totally fine.

Change-Id: I58c5487ea589e38c58cf39511960ecfb91ffed59
Fixes: #32650
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8895
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[BUGFIX] Resetting of input field to default when having a range fails
Philipp Kitzberger [Wed, 28 Dec 2011 10:28:01 +0000 (11:28 +0100)]
[BUGFIX] Resetting of input field to default when having a range fails

When trying to reset a endtime (datetime or date) having a range (like tt_news
articles) the lower range limit will be stored instead of the default value.

Change-Id: I183b5ffa385e9d218f4942a57abd4e6a01e194fb
Fixes: #28298
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8960
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years ago[BUGFIX] IRRE: Selected items remain in selector with foreign_unique
Stanislas Rolland [Wed, 8 Feb 2012 05:15:32 +0000 (00:15 -0500)]
[BUGFIX] IRRE: Selected items remain in selector with foreign_unique

Problem: When an inline field is defined as unique (foreign_unique
is set), selected items are removed neither from the inline record
selector, nor from the children record selectors.

Solution: Remove the used records from all selectors. Also, when
updating and collapseAll is set, remove records already used from
the child record after its ajax-retrieval/expansion.

Change-Id: I56ea89380c431af148216836da8913db76dc095e
Fixes: #21102
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/8956
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] RTE: Removing div from formatblock selector may not workspaces
Stanislas Rolland [Thu, 9 Feb 2012 05:11:28 +0000 (00:11 -0500)]
[BUGFIX] RTE: Removing div from formatblock selector may not workspaces

Problem: RTE.default.buttons.formatblock.removeItems = div is not
honoured when indent/outdent is configured.
Solution: Honour the removal/restriction even when indent/outdent is
configured.

Fixes: #33457
Releases: 4.5, 4.6, 4.7

Change-Id: I2f2b43d8e5d74a6598667a3b79d6894acdff96f9
Reviewed-on: http://review.typo3.org/8921
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] htmlArea RTE: CSS class names are lowercase in WebKit
Stanislas Rolland [Sat, 21 Jan 2012 06:24:39 +0000 (01:24 -0500)]
[BUGFIX] htmlArea RTE: CSS class names are lowercase in WebKit

Problem: See https://bugs.webkit.org/show_bug.cgi?id=55619
Solution: Add doctype to the iframe source

Change-Id: Iec721ee4e6eef990327f1398e02acdd35e89d689
Resolves: #32408
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/8623
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[BUGFIX] saltedpasswords update task only updates 42 records
Mario Rimann [Sun, 4 Dec 2011 19:29:08 +0000 (20:29 +0100)]
[BUGFIX] saltedpasswords update task only updates 42 records

The scheduler task to convert the fe_user and be_user passwords
to salted passwords took only 42 records per run. Now it should
take 250 per run. This will lead to an approx. run-time of about
50s (given 2 * 100ms * 250 records)

Change-Id: I1f37fd978984d6c6e4e06ad76b057575f916438b
Resolves: #31252
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8925
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years ago[BUGFIX] Bookmarks to pages don't work
Stefan Galinski [Fri, 3 Feb 2012 17:22:49 +0000 (18:22 +0100)]
[BUGFIX] Bookmarks to pages don't work

Change-Id: I25fce6d672ffe890d494222ed4ea8a2500c5bfac
Fixes: #30352
Releases: 4.7. 4.6, 4.5
Reviewed-on: http://review.typo3.org/8830
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Galinski
Tested-by: Stefan Galinski
7 years ago[TASK] Disable compression for inlineJs in Backend
Steffen Gebert [Tue, 9 Aug 2011 19:51:32 +0000 (21:51 +0200)]
[TASK] Disable compression for inlineJs in Backend

JSMin is a major performance nightmare and no network connection can be
as slow as it would justify to spend so much time to execute JSmin
several times for each and every backend request.

As long as we have no fast replacement in core available, disable
compression for all JS snippets added with
t3lib_PageRenderer::addJsInlineCode in the Backend.

JSMin's share of execution time was about 20-25% of the page generation
time, for almost empty backend pages even ~50%.

Change-Id: Iabbd092a349dec6e84c40b7b7c750bc718168d85
Resolves: #29498
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/7201
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Sebastian Fischer
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Oliver Klee
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[BUGFIX] Prevent duplicate stdWrap for media content
Alexander Stehlik [Thu, 9 Jun 2011 22:17:14 +0000 (00:17 +0200)]
[BUGFIX] Prevent duplicate stdWrap for media content

All the standard renderers handle stdWrap themselves, so the general stdWrap
handling should be moved to the customMediaRenderer block to prevent duplicate
calls to stdWrap.

Change-Id: I4a8214d789721b68a0f9e5f55e4a27fc91a0e7cf
Fixes: #25277
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/7121
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[BUGFIX] Release locked records during logout
Tolleiv Nietsch [Sat, 4 Feb 2012 08:08:34 +0000 (09:08 +0100)]
[BUGFIX] Release locked records during logout

The sys_lockedrecords tables isn't cleared during the users logout.

Change-Id: I789cf1736a1b00760b54f8efddaffd633b47f4f5
Fixes: #20211
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8884
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years ago[BUGFIX] Prevent compression of scripts that use ajax.php
Steffen Kamper [Tue, 11 Oct 2011 12:49:08 +0000 (14:49 +0200)]
[BUGFIX] Prevent compression of scripts that use ajax.php

When registering ajax calls, a pseudo JS file is registered within the
pageRenderer with a source like 'ajax.php?parameters'.

As it does not make sense to compress or concatenate those pseudo JS files,
the pageRenderer should ensure they are properly included.

Change-Id: I386663b9ea77426ea3d8e804eac0f3c8ca72cd7a
Fixes: #24274
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8881
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] "Show page" does not use a proper URL scheme
Dmitry Dulepov [Mon, 21 Nov 2011 12:16:35 +0000 (14:16 +0200)]
[BUGFIX] "Show page" does not use a proper URL scheme

"Show page" context menu and Web>View do not use proper scheme if
that is set in the page properties. They always use the scheme of
the Backend.

Change-Id: I3e700ecee13e0fb47317170dd2388cce627601fb
Fixes: #31959
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7412
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
7 years ago[TASK] Reports module uses internal data of salted passwords
Dmitry Dulepov [Mon, 28 Nov 2011 12:12:39 +0000 (14:12 +0200)]
[TASK] Reports module uses internal data of salted passwords

Reports module changes from issue #30695 introduced a check
for the saltedpasswords extension and a report about users,
whose passwords are not protected by the saltedpasswords.
That check queries database directly and uses internal
knowledge of saltedpasswords about marking the password
with certain characters. This can break reports module
if saltedpasswords adds a new scheme to salt passwords.
Only saltedpasswords should know about those prefixes.
Other extensions should use the API of saltedpasswords
to query the information.

Change-Id: I335697612d9f58935320261278054fc1863871f4
Resolves: #32136
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7408
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
7 years ago[BUGFIX] RTE: Some toolbar elements may not be correctly initialized
Stanislas Rolland [Mon, 6 Feb 2012 02:23:33 +0000 (21:23 -0500)]
[BUGFIX] RTE: Some toolbar elements may not be correctly initialized

This change is a follow-up to previous change which could cause JS
error when language dropdown is not configured in the toolbar.

Change-Id: I6c0edf8ba6869aa2f7ff36edb862015de46e57eb
Resolves: #33637
Releases: 4.5
Reviewed-on: http://review.typo3.org/8856
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] Encoding error in TCEforms inline JavaScript
Manuel Stofer [Wed, 1 Feb 2012 09:17:02 +0000 (10:17 +0100)]
[BUGFIX] Encoding error in TCEforms inline JavaScript

JavaScript encoding is broken, when the link browser is used to add a
new item and sections are used.

Change-Id: Id366d078841a3decd0256f98df497956a494ecb8
Fixes: #32422
Related: #29067
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8790
Reviewed-by: Simon Tuck
Tested-by: Simon Tuck
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
7 years ago[BUGFIX] t3lib_div::validPathStr() fails on certain file names
Dmitry Dulepov [Fri, 2 Dec 2011 15:22:56 +0000 (17:22 +0200)]
[BUGFIX] t3lib_div::validPathStr() fails on certain file names

Function t3lib_div::validPathStr() fails on file names with Unicode
characters. Adding 'u' modifier to the regular expression solves
the problem.

Change-Id: I99ebe784145eb3f2265eb7beb7dd58ac851c29ff
Resolves: #32046
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7796
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
7 years ago[BUGFIX] htmlArea RTE: Changing the text color to black does not work
Stanislas Rolland [Sat, 21 Jan 2012 02:31:32 +0000 (21:31 -0500)]
[BUGFIX] htmlArea RTE: Changing the text color to black does not work

Solution: Fix colorToHex conversion utility

Change-Id: I5c7f44f4255e0e52a8540a58f95eec3443ac9085
Resolves: #32877
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/8622
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] htmlArea RTE: Firefox may report error when setting a color
Stanislas Rolland [Fri, 3 Feb 2012 00:36:20 +0000 (19:36 -0500)]
[BUGFIX] htmlArea RTE: Firefox may report error when setting a color

Problem: The color does get assigned, but Firefox reports a JS error.
Solution: The RTE may incorrectly detach the selection range.

Change-Id: Ief034d8d97894c44160487f353523bf83f688c7c
Resolves: #33644
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/8817
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] RTE Text indicator does not work in Firefox in TYPO3 4.5
Stanislas Rolland [Thu, 2 Feb 2012 21:35:37 +0000 (16:35 -0500)]
[BUGFIX] RTE Text indicator does not work in Firefox in TYPO3 4.5

Solution: Backport logic from master (4.7).

Change-Id: Idf129efb55bc12ec8c2fe17ef931c0027ae08c69
Fixes: #33642
Releases: 4.5
Reviewed-on: http://review.typo3.org/8816
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] RTE: Some toolbar elements may not be correctly initialized
Stanislas Rolland [Thu, 2 Feb 2012 18:05:33 +0000 (13:05 -0500)]
[BUGFIX] RTE: Some toolbar elements may not be correctly initialized

The language and font dropdowns need to initialized after their data
stores are loaded.

Change-Id: If34a6c03628ce277e4fa567fb34b0db8bcc428b4
Resolves: #33637
Releases: 4.5
Reviewed-on: http://review.typo3.org/8815
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] Context menu of page translation doesn't work in languages view
Andreas Wolf [Mon, 29 Aug 2011 10:18:17 +0000 (12:18 +0200)]
[BUGFIX] Context menu of page translation doesn't work in languages view

For a page with translations, the clickmenu is not shown for these
translations in the page module, view "languages". This comes from a
missing table name in the clickmenu link generation call.

Change-Id: I6a66e0f1e21be072455ecab094d0cfc17c0e5802
Resolves: #27052
Releases: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/4662
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Galinski
Tested-by: Stefan Galinski
7 years agoRevert "[BUGFIX] Scheduler BE module fails to load due to autoloader issues"
Christian Kuhn [Sat, 28 Jan 2012 19:21:07 +0000 (20:21 +0100)]
Revert "[BUGFIX] Scheduler BE module fails to load due to autoloader issues"

The patch has an unwanted side-effect: It sometimes throws a php warning "Function spl_autoload_call() hasn't defined the class it was called for".
Reverted for now.

This reverts commit 33c8647966c919e2357701a4baaaef68738dfc91

Change-Id: If4cb4dc9e59dbdafe934d05c60bd92a14b55bde9
Reviewed-on: http://review.typo3.org/8755
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Reports module shows unnecessary info text
Markus Klein [Thu, 15 Dec 2011 01:49:26 +0000 (19:49 -0600)]
[BUGFIX] Reports module shows unnecessary info text

Do not show saltedpasswords info text in reports module
unless problems have been detected.

Change-Id: I4e3aeffe6bde09cea2a77193cf52672b0b71fa6b
Fixes: #32580
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8752
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Scheduler BE module fails to load due to autoloader issues
Dmitry Dulepov [Wed, 11 Jan 2012 12:15:00 +0000 (14:15 +0200)]
[BUGFIX] Scheduler BE module fails to load due to autoloader issues

When displaying a list of tasks, scheduler unserializes exceptions.
By default, unserialize() does not call autoloader to load classes
and it is possible that the exception class will not be loaded. In
such case scheduler BE module will fail with a PHP fatal error
when the scheduler will try to use a _PHP_Incomplete_Class.

The fix makes sure that autoloader is called during unserialize().
However this still may fail, so the scheduler now checks that the
exception is loaded properly before trying to use it.

Change-Id: I12188324ad133752a0c0eb77c4905ed1854197b7
Resolves: #33116
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8748
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Broken datepicker on unsaved flexform sections
Stefan Rotsch [Tue, 24 Jan 2012 10:41:55 +0000 (11:41 +0100)]
[BUGFIX] Broken datepicker on unsaved flexform sections

The onClick event for opening the datepicker is attached to the
datepicker icons only once on page load. There currently is no update
method which adds the onClick event to new sections, so the datepicker
icons are without function until the form is saved.

Related to this, IDs of input fields are not unique when adding more than
one new section before saving. They have to be randomized when inserting a
new section in order to make the datepicker work properly.

This patch implements an update() method in tceforms.js which is called
every time a new section is added to a flexform. The IDs of tceforms
date/datetime fields get randomized by adding a timestamp when adding a
new section.

Fixes: #23843
Releases: 4.7, 4.6, 4.5
Change-Id: Id64144f41804e64b245b68f0135e1b6e8c1bab4c
Reviewed-on: http://review.typo3.org/8746
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] TYPO3 prompts to select position when there are no pages
Dmitry Dulepov [Sat, 14 Jan 2012 10:43:01 +0000 (11:43 +0100)]
[BUGFIX] TYPO3 prompts to select position when there are no pages

When adding the very first page to the page tree, TYPO3 asks to
select a position and offers a weird looking selector (see the
attachment in the bug report). Instead, it should proceed
straight to the page properties window (or redirect to it).

Change-Id: I395e500d377879ebd206ad0e6042876f5a86f118
Resolves: #32111
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7802
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Unlimited memory limit handling in system status report
Mario Rimann [Fri, 2 Dec 2011 21:10:25 +0000 (22:10 +0100)]
[BUGFIX] Unlimited memory limit handling in system status report

According to the documentation, "-1" is a valid setting for PHP's
memory_limit and means "unlimited". So far this value has caused
the system status report to report this value as an error.

Change-Id: I2fbdbf8b9e39dd0425253f5487b869bc81f52e27
Fixes: #32231
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7793
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[BUGFIX] Warnings in BE when using "Find filename"
Dmitry Dulepov [Wed, 23 Nov 2011 13:14:58 +0000 (15:14 +0200)]
[BUGFIX] Warnings in BE when using "Find filename"

When using "Tools">"DB Check">"Find filename" with a slash
character (for example, "</title>"), there are warnings about
wrong regular expression in the Backend and nothing is found.

Change-Id: Ia8ebd218a6de5ead49301d0d082a6cbae0be1d93
Resolves: #21591
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8639
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] spriteManager for Clear RTE Cache icon
Felix Kopp [Sat, 31 Dec 2011 13:58:06 +0000 (14:58 +0100)]
[BUGFIX] spriteManager for Clear RTE Cache icon

RTE hooks into the clear cache menu to allow clearing RTE cache.
Changes the icon integration from iconWorks to spriteManager.
Solves styling issue caused by too small icon.

Change-Id: I60a5bbd045f05075be81eaab6603c02ab2653952
Resolves: #32892
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/8744
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Improve debugTrail() to better handle includes
Markus Klein [Wed, 26 Oct 2011 00:28:04 +0000 (19:28 -0500)]
[TASK] Improve debugTrail() to better handle includes

The deprecation log lacks specific and necessary information about
include and require calls, which makes it hard to actually follow
a stack trace.

Add special treatment of this sort of functions and display additional
path information.

Change-Id: I0510082ad8668b0d552f65969bbec95f37365770
Resolves: #31300
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7795
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert