Packages/TYPO3.CMS.git
3 years ago[BUGFIX] Show language flags in page module again 12/47412/2
Gianluigi Martino [Sun, 27 Mar 2016 22:29:27 +0000 (00:29 +0200)]
[BUGFIX] Show language flags in page module again

Additionally this patch moves the initialization of TSconfig to an
earlier execution point to have all needed data collected.

Change-Id: I57ab201bae6ffc8acca3ddcc536b3efd09434054
Resolves: #75129
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/47412
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
3 years ago[BUGFIX] Use proper quotation in phpdoc of ExtensionManagementUtility::addService() 00/47400/2
Andreas Fernandez [Mon, 28 Mar 2016 16:02:16 +0000 (18:02 +0200)]
[BUGFIX] Use proper quotation in phpdoc of ExtensionManagementUtility::addService()

The patch fixes the quotation in the description of the parameters
``$serviceType`` and ``$serviceKey``.
This ensures a correct rendering by Doxygen.

Resolves: #75283
Releases: master, 7.6, 6.2
Change-Id: Ic7d91c1c108465b50f7637667ff6f3a8b451eb26
Reviewed-on: https://review.typo3.org/47396
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
(cherry picked from commit 2d5e0a4bc6460e02d38957ed2ab7527e223c26f3)
Reviewed-on: https://review.typo3.org/47400

3 years ago[BUGFIX] Fix typo in BooleanNode exception message 98/47398/2
Sascha Egerer [Tue, 29 Mar 2016 09:46:10 +0000 (11:46 +0200)]
[BUGFIX] Fix typo in BooleanNode exception message

Change-Id: I792f5534780675278cbd7d540c96b60568b2647e
Resolves: #75287
Releases: 7.6, 6.2
Reviewed-on: https://review.typo3.org/47398
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Add reference count to delete message 85/47385/2
Gianluigi Martino [Sat, 19 Mar 2016 06:49:56 +0000 (07:49 +0100)]
[BUGFIX] Add reference count to delete message

If you delete a file or folder by using the clickmenu, a confirmation
message without reference count is shown. To streamline the confirmation
message with the one from FileList, the reference count is added with
this patch.

Resolves: #75156
Releases: master, 7.6, 6.2
Change-Id: I84fe8c853199cdb4e0ff422cdb5fc327e4bdc683
Reviewed-on: https://review.typo3.org/47385
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[BUGFIX] FormEngine: Exception on inline/section in flex container 79/47379/2
Christian Kuhn [Wed, 23 Mar 2016 15:18:41 +0000 (16:18 +0100)]
[BUGFIX] FormEngine: Exception on inline/section in flex container

Nesting flex form sections or inline within section containers is
not supported. To not let developers run into hard to track issues
the patch adds an exception to detect these cases.

Additionally, GroupElement contains a preparation that is done by
TcaGroup data provider already, so this part is cleaned up along
the way since this is unreachable code if FormEngine is used without
nested sections.

Change-Id: I2af9140ad0fe1d60d85439bd5598775904b70e52
Resolves: #73125
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/47379
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Use `modTSconfig` for default language label, if set 74/47374/2
Andreas Fernandez [Wed, 23 Mar 2016 18:06:28 +0000 (19:06 +0100)]
[BUGFIX] Use `modTSconfig` for default language label, if set

Due to a wrong assignment, modSharedTSconfig is always used
to set the default language label in PageLayoutController, even if
modTSconfig is set.

modTSconfig is now used if possible.

Resolves: #75242
Releases: master, 7.6, 6.2
Change-Id: I517c03f02ffc8d05ed74a865517ee775e1542bfe
Reviewed-on: https://review.typo3.org/47374
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] Use DocHeader buttons in PermissionController 72/47372/2
Andreas Fernandez [Fri, 11 Mar 2016 08:45:54 +0000 (09:45 +0100)]
[TASK] Use DocHeader buttons in PermissionController

The save / abort buttons in the edit view of the permission controller are
replaced by DocHeader buttons to ensure are more consistent UI.

Change-Id: Ic035f2bd1f5063a8d0b52310b1f011078f7e6c25
Resolves: #68378
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/47372
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Break word without spaces in SystemInformation toolbar item 67/47367/2
Wouter Wolters [Tue, 22 Mar 2016 21:38:13 +0000 (22:38 +0100)]
[BUGFIX] Break word without spaces in SystemInformation toolbar item

When dealing with a PHP version like "7.0.4-6+deb.sury.org~trusty+5"
the text overflow the box. Put a word-wrap: break-word; on the dd-tag.

Resolves: #75234
Releases: master,7.6
Change-Id: I0df5f13bfd2d66e8c85eb28f06c248bdca93a182
Reviewed-on: https://review.typo3.org/47367
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[BUGFIX] BackendUtility::dateTimeAge must return correct values 65/47365/2
Georg Ringer [Wed, 23 Mar 2016 05:08:56 +0000 (06:08 +0100)]
[BUGFIX] BackendUtility::dateTimeAge must return correct values

If the 3rd parameter is set to 'date', the age must be returned as
date without any time information.

Resolves: #75235
Releases: master, 7.6
Change-Id: I7ebf76dc635f7dbca42c6486c585eb140832e6c4
Reviewed-on: https://review.typo3.org/47364
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
(cherry picked from commit 5c46ba68ad79034a5daf678b4a41a5882dcbaf60)
Reviewed-on: https://review.typo3.org/47365

3 years ago[BUGFIX] Set correct record information for SaveAndNew 50/47350/2
Nicole Cordes [Mon, 7 Mar 2016 20:02:43 +0000 (21:02 +0100)]
[BUGFIX] Set correct record information for SaveAndNew

This patch ensures the correct record information for saving and
inserting a new record even in a workspace.

Resolves: #70542
Releases: master, 7.6
Change-Id: I3b88b08a55600f8c7bc5e2c2f05444624181db83
Reviewed-on: https://review.typo3.org/47350
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[BUGFIX] Show button 'add image' after delete inline fails 48/47348/2
Frank Naegler [Mon, 21 Mar 2016 10:29:59 +0000 (11:29 +0100)]
[BUGFIX] Show button 'add image' after delete inline fails

Fix handling of inline records in JavaScript. Prevent wrong count of elements
by adding a trimExplode function intead of usage native split function.

Resolves: #72379
Releases: master, 7.6
Change-Id: Id6cde49eb6179ddc3d5b0ef796a0a6883dfa747e
Reviewed-on: https://review.typo3.org/47348
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Use APCu instead of APC for Caching 44/47344/2
Benni Mack [Thu, 3 Mar 2016 20:11:24 +0000 (21:11 +0100)]
[BUGFIX] Use APCu instead of APC for Caching

PHP 5.5 does not support APC anymore, but instead uses
APCu for everything that is in the userland.

Our code should be adapted to use APCu instead, since
TYPO3 CMS 7 LTS requires PHP 5.5+.

However, there are some edge cases where APCu is available
as APC, so the existing APC code is kept.

Resolves: #63291
Releases: master, 7.6
Change-Id: Ica6bac270b54e5a645d37679e5663479ef36f394
Reviewed-on: https://review.typo3.org/47344
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[BUGFIX] Ensure correct order of @-rules in CSS 36/47336/2
Andreas Fernandez [Mon, 14 Mar 2016 13:39:51 +0000 (14:39 +0100)]
[BUGFIX] Ensure correct order of @-rules in CSS

The ResourceCompressor must ensure the correct order of
@-rules, which is:
1. charset
2. namespace
3. import

If the concatenated CSS contains multiple @charset rules, only
the first one is taken into account.

Change-Id: I8c912874d486eac16505884e68a04b0bba400611
Resolves: #55690
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/47336
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[BUGFIX] Remove competing injects from WidgetRequestHandler 25/47325/2
Alexander Jahn [Wed, 9 Mar 2016 11:12:38 +0000 (12:12 +0100)]
[BUGFIX] Remove competing injects from WidgetRequestHandler

Removing @injects introduced explicit injectFunctions
into WidgetRequestHandler.
These functions were named after the object they inject.
This resulted in two methods injecting different objects into the same
property and in the end the parent class' function reverted the local
implementation.

Change-Id: I345d04f150fe6413ffc67c159c43cdda7e979e7b
Resolves: #74536
Related: #73018
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/47325
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
3 years ago[TASK] Stop animation if click again 24/47324/2
Markus Sommer [Fri, 18 Mar 2016 07:54:34 +0000 (08:54 +0100)]
[TASK] Stop animation if click again

Stop the toggle animation an the module headline
first before a new animation is started

Resolves: #75179
Releases: master, 7.6
Change-Id: I1dc683ba7740a0a939d699e6d3c01b154583a00a
Reviewed-on: https://review.typo3.org/47324
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[BUGFIX] Highlight changes of translation diff in FormEngine again 17/47317/2
Frank Naegler [Mon, 14 Mar 2016 15:33:10 +0000 (16:33 +0100)]
[BUGFIX] Highlight changes of translation diff in FormEngine again

The difference between translation changes of records are now
highlighted again in FormEngine.

Resolves: #73501
Releases: master, 7.6
Change-Id: I88f4a67c5392cf9ddca4410ddb07d57439a26b3a
Reviewed-on: https://review.typo3.org/47317
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
3 years ago[BUGFIX] Enable URLs with spaces in the RTE 16/47316/2
Marco Huber [Thu, 25 Feb 2016 15:04:54 +0000 (16:04 +0100)]
[BUGFIX] Enable URLs with spaces in the RTE

To enable links with spaces and other special chars the service class to
build the correctly escaped <link> tag is used.

Resolves: #73675
Releases: master,7.6
Change-Id: I530cb7569372d2da12d0015e820b458c8299f435
Reviewed-on: https://review.typo3.org/47316
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
3 years ago[BUGFIX] Make preview of translated pages possible 15/47315/2
Heiko Hardt [Mon, 14 Mar 2016 21:45:30 +0000 (22:45 +0100)]
[BUGFIX] Make preview of translated pages possible

This fix solves the problem that hidden page translations not are not
reviewable if logged in and "Show hidden pages" in admin panel is
enabled.

Treat records of "pages_language_overlay" as pages to make use of
the showHiddenPage flag.

Resolves: #75116
Releases: master, 7.6
Change-Id: I083ee3a90230b6c97eb20def93c9e96bfe31c4cb
Reviewed-on: https://review.typo3.org/47315
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[BUGFIX] Ignore root level restriction on new record 14/47314/2
Benjamin Serfhos [Wed, 16 Mar 2016 14:16:05 +0000 (15:16 +0100)]
[BUGFIX] Ignore root level restriction on new record

When TCA [ctrl][security][ignoreRootLevelRestriction] is enabled, the
root level should be ignored on creation too.

Resolves: #75147
Releases: master,7.6
Change-Id: I55414696838a256d967d410cf523edc031ebe952
Reviewed-on: https://review.typo3.org/47314
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[BUGFIX] Set page title for record list 11/47311/2
Christian Weiske [Thu, 28 Jan 2016 10:39:13 +0000 (11:39 +0100)]
[BUGFIX] Set page title for record list

Resolves: #72981
Releases: master, 7.6

Change-Id: I75deb2dd8808c0dccfe30b90b2459937b40dbd7c
Reviewed-on: https://review.typo3.org/47311
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[BUGFIX] Ensure correct sorting when using the localization wizard 99/47299/2
Andreas Fernandez [Tue, 15 Mar 2016 08:08:04 +0000 (09:08 +0100)]
[BUGFIX] Ensure correct sorting when using the localization wizard

Change-Id: I920cab82f1e9304be6c718b33c1a8ce13c745e17
Resolves: #73617
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/47264
Reviewed-on: https://review.typo3.org/47299
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[BUGFIX] Correctly determine previously used language in localization wizard 98/47298/2
Andreas Fernandez [Tue, 15 Mar 2016 10:56:12 +0000 (11:56 +0100)]
[BUGFIX] Correctly determine previously used language in localization wizard

If a column in a certain language has already content, the origin
language of that content is used now for further translation processes.

Change-Id: Ib6e1206adc6ccfd5b1e4816b9eb6562f8fc0e0ef
Resolves: #75126
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/47298
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[BUGFIX] Add missing parameters to getFiles 96/47296/2
Susanne Moog [Wed, 16 Mar 2016 14:07:50 +0000 (15:07 +0100)]
[BUGFIX] Add missing parameters to getFiles

InaccessibleFolder extends Folder and the definition of its methods
should therefor be compatible to each other.

Resolves: #73712
Releases: master, 7.6
Change-Id: I3798841a7349ac7b615238328c26d540cf938d34
Reviewed-on: https://review.typo3.org/47296
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[BUGFIX] Correct output of "Rollback-Preview" 93/47293/2
Gianluigi Martino [Tue, 15 Mar 2016 21:42:09 +0000 (22:42 +0100)]
[BUGFIX] Correct output of "Rollback-Preview"

Output in "Rollback-Preview" is wrong.
Preview text float over the "Rollback single field" button.

Change-Id: I49c236b15bb62129b5c3a4c5741d0572676e00f1
Resolves: #75137
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/47293
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[BUGFIX] Add reserved area for loading indicator within modules 37/47237/2
Michael Oehlhof [Wed, 9 Dec 2015 23:17:46 +0000 (00:17 +0100)]
[BUGFIX] Add reserved area for loading indicator within modules

The DocHeader has now a reserved area for the nprogress loading
indicator for use within modules. The area has a fixed position to
ensure visibility in every case.

The code of the Recycler and Extension manager have been adjusted
to use that element for the progress bar.

Resolves: #71509
Releases: master, 7.6
Change-Id: I07cacf61a1634357d4da0fe292ea22ba34a6100e
Reviewed-on: https://review.typo3.org/47237
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[BUGFIX] Don't redirect when you click on "save and view" 36/47236/2
Marco Huber [Fri, 11 Mar 2016 14:24:53 +0000 (15:24 +0100)]
[BUGFIX] Don't redirect when you click on "save and view"

Some more page types which should be opened directly and not
redirect to the rootpage if you click on "Save and view".

Resolves: #75020
Related: #66370
Releases: master, 7.6
Change-Id: I278a917c69565e8fe1e175901df01c4cccf9ef98
Reviewed-on: https://review.typo3.org/47236
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[BUGFIX] Suggest wizard in FlexForms for new records 35/47235/2
Nicole Cordes [Sat, 12 Mar 2016 11:47:04 +0000 (12:47 +0100)]
[BUGFIX] Suggest wizard in FlexForms for new records

Within new records the suggest wizard doesn't work in FlexForm fields.
Due to unexpected incoming data the field configuration can't be fetched.
This patch ensures sanitized data before fetching FlexForms field
configuration.

Resolves: #73864
Releases: master, 7.6
Change-Id: I7e9a72c2aa6d1efed943845aa2198ce153b75fb8
Reviewed-on: https://review.typo3.org/47235
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
3 years ago[BUGFIX] Fix invalid placeholder in exception message 33/47233/2
Markus Klein [Sun, 13 Mar 2016 16:23:36 +0000 (17:23 +0100)]
[BUGFIX] Fix invalid placeholder in exception message

The message of the ContentRenderingException must use %s
as correct placeholder.

Resolves: #75035
Releases: master, 7.6
Change-Id: Ie78997ead81fc308a4002cffca8dfa0a99b50ac2
Reviewed-on: https://review.typo3.org/47233
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] Store rtehtmlarea_spellchecker in correct route configuration 06/47206/2
Andreas Fernandez [Fri, 11 Mar 2016 17:19:03 +0000 (18:19 +0100)]
[BUGFIX] Store rtehtmlarea_spellchecker in correct route configuration

The RTE route "rtehtmlarea_spellchecker" is an AJAX route, therefore it must
be stored in AjaxRoutes.php.

Change-Id: Ief55ef5e17a72187491d63915e29934e45d5a985
Resolves: #75024
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/47206
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[BUGFIX] Make SingleTasks toggleable from scheduler list view 90/47190/2
Andreas Fernandez [Fri, 19 Feb 2016 11:18:33 +0000 (12:18 +0100)]
[BUGFIX] Make SingleTasks toggleable from scheduler list view

The toggle button for tasks does not work for single tasks. This patch
enables the functionality and registers a single task for execution on
next scheduler run when enabled.

Additionally class constants are introduced for the two available types.

Change-Id: I91c7b24bf141ef6735b3fd38e2859d63634d507e
Resolves: #64708
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/47190
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[TASK] Add unit tests for TYPO3SEARCH markers 89/47189/2
Tymoteusz Motylewski [Thu, 10 Mar 2016 13:44:22 +0000 (14:44 +0100)]
[TASK] Add unit tests for TYPO3SEARCH markers

Add two unit tests for Indexer, covering content extraction
from between TYPO3SEARCH_begin and TYPO3SEARCH_end markers.

Add note to documentation that it's possible to have multiple
TYPO3SEARCH marker pairs.

Resolves: #74815
Releases: master, 7.6, 6.2
Change-Id: I37c67dfc055dc30698831eef6d0231d929fef957
Reviewed-on: https://review.typo3.org/47189
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[BUGFIX] Initialize T3editor properly 88/47188/2
Andreas Fernandez [Mon, 15 Feb 2016 17:35:21 +0000 (18:35 +0100)]
[BUGFIX] Initialize T3editor properly

If a T3editor is instantiated on-the-fly, it is not initialized properly.
Add a callback to the ``Form/Element/T3editorElement`` class and mark
editor instances as initialized to prevent double initialization.

Change-Id: I8c6b692eb2c132180ed0d122b35515276df5acd9
Resolves: #73425
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/47188
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[BUGFIX] Add button styling to clipInsert button 87/47187/2
Andreas Fernandez [Thu, 10 Mar 2016 12:29:33 +0000 (13:29 +0100)]
[BUGFIX] Add button styling to clipInsert button

The button for inserting items from clipboard to a multiselect field has
a proper styling now.

Change-Id: I2360507fb0daedc57e0e1b3a5442af790529039e
Resolves: #74813
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/47187
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[BUGFIX] Check access to cshmanual module 79/47179/2
Marco Huber [Fri, 29 Jan 2016 15:29:57 +0000 (16:29 +0100)]
[BUGFIX] Check access to cshmanual module

Don't render the "more" link in the help popup if the user has no
access to the cshmanual module.

Resolves: #73013
Related: #73009
Releases: master, 7.6
Change-Id: I5b236c08fd505c1f405a3fc0e459c1ac21fbeb84
Reviewed-on: https://review.typo3.org/47179
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[BUGFIX] Unset default link if set with values from other link handler 78/47178/2
Tim Jungebluth [Wed, 9 Mar 2016 20:21:03 +0000 (21:21 +0100)]
[BUGFIX] Unset default link if set with values from other link handler

Change-Id: I49a19d9ca4e08cea927f5541accfade09320210d
Resolves: #74586
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/47178
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] Load XML files of t3editor properly 76/47176/2
Andreas Fernandez [Thu, 10 Mar 2016 13:10:12 +0000 (14:10 +0100)]
[BUGFIX] Load XML files of t3editor properly

Since the XEE security fix (I26701fc2ffb5aed7ccbd96c168aef571d012091e),
the XML files in the t3editor are not loaded anymore. Change the way how
the files are loaded to fix the issue.

Change-Id: I26c622e47ee0f791b998886837f4443f5bddf11b
Resolves: #74508
Releases: master, 7.6, 6.2
Reviewed-on: https://review.typo3.org/47176
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[FOLLOWUP][BUGFIX] Do not scroll on top using actions on multipleSideBySide 56/47156/2
Markus Klein [Tue, 8 Mar 2016 14:50:24 +0000 (15:50 +0100)]
[FOLLOWUP][BUGFIX] Do not scroll on top using actions on multipleSideBySide

Resolves: #72973
Releases: 7.6
Change-Id: Ic75532358600a6e61c9080ffec55e46756989dc6
Reviewed-on: https://review.typo3.org/47156
Reviewed-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Tested-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[BUGFIX] Add urldecode for the forgotHash in FrontendLoginController 54/46454/5
Zsolt Molnar [Wed, 3 Feb 2016 10:48:26 +0000 (12:48 +0200)]
[BUGFIX] Add urldecode for the forgotHash in FrontendLoginController

Resolves: #73060
Releases: master, 7.6
Change-Id: Iffb0db26b591b26ed4c2bf78aa50c8bf1addec2b
Reviewed-on: https://review.typo3.org/46454
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
3 years ago[BUGFIX] Workspace page previews collide with generated preview links 32/47132/2
Oliver Hader [Mon, 14 Dec 2015 21:53:55 +0000 (22:53 +0100)]
[BUGFIX] Workspace page previews collide with generated preview links

Workspace page previews collide with that configuration that might have
been set by using a preview link containing a ADMCMD_prev command. The
keyword "IGNORE" is introduced to actually ignore these configurations
when viewing a page from the workspace module.

Resolves: #72225
Releases: master, 7.6, 6.2
Change-Id: I6a73e860a76308028f0a3b1bcd182e41082adcd6
Reviewed-on: https://review.typo3.org/47132
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[TASK] EXT:form - add unitTests for class TypoScriptToJsonConverter 30/47130/3
Sebastian Wagner [Sat, 5 Mar 2016 21:29:57 +0000 (22:29 +0100)]
[TASK] EXT:form - add unitTests for class TypoScriptToJsonConverter

This patch introduces a first test case for TypoScriptToJsonConverter
of EXT:form. The test case asserts that a protected method internally
triggers adding elements to a given and mocked parent element in the
nested form hierarchy.

Resolves: #74337
Releases: master, 7.6
Change-Id: I191ba8fe41a5829e23303447f86303ae8c6dd081
Reviewed-on: https://review.typo3.org/47130
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
3 years ago[BUGFIX] Fix date conversion of neg timestamps 17/47117/2
Daniel Maier [Sat, 5 Mar 2016 18:57:21 +0000 (19:57 +0100)]
[BUGFIX] Fix date conversion of neg timestamps

Date conversion of TCA fields with eval "date" or "datetime" is now also
handled correctly for dates before 1970, thus having a negative
timestamp. Timezone offset is now also applied for those negative
timestamps, in order to prevent erroneous data for dates before 1970.

Resolves: #73871
Releases: master, 7.6
Change-Id: I4de9911dec3de720992da137fe8afcb3ecbfdad7
Reviewed-on: https://review.typo3.org/47115
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
(cherry picked from commit 7090d9b67735ba10ca3d2e024cb376b991e26366)
Reviewed-on: https://review.typo3.org/47117

3 years ago[BUGFIX] DataHandler: Use the updated field to determine record type 25/47125/2
Hannes Lau [Fri, 22 Jan 2016 17:51:20 +0000 (18:51 +0100)]
[BUGFIX] DataHandler: Use the updated field to determine record type

Use the new, updated field values of the current record, to determine
its type value. This allows to pick the correct RTE configuration
for new records with non-default types.

Fixes: #72898
Releases: master, 7.6
Change-Id: If519a9c9357034977ede40d7b709a7d83a3e92c8
Reviewed-on: https://review.typo3.org/46162
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Reviewed-by: Eugen Lang <laeu1011+gerrit@gmail.com>
Tested-by: Eugen Lang <laeu1011+gerrit@gmail.com>
Tested-by: Jonas Götze <jonnsn@gmail.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
(cherry picked from commit 1dab32babef3a841d4281bed6874cc810a3c36bf)
Reviewed-on: https://review.typo3.org/47125

3 years ago[BUGFIX] LocalImageProcessor cannot reuse remote files 27/47127/2
Andreas Wolf [Fri, 26 Feb 2016 09:46:39 +0000 (10:46 +0100)]
[BUGFIX] LocalImageProcessor cannot reuse remote files

The LocalImageProcessor had a check for the storage type, to only do a
check for existing files on local storages, as it needed to fetch an
existing file from the storage to get metadata from it.

This check is now replaced by a proper usage of the FAL API: Fetch the
generated file for local (read-only) processing, which in case of a
local storage means the file is not moved at all. Then, the image
metadata can be extracted from the local file and the file index record
of the processed file can be updated accordingly.

Change-Id: I9fca326fe1d1743cd53a0a85c674ff81e5a051b9
Releases: master, 7.6
Resolves: #67126
Reviewed-on: https://review.typo3.org/47127
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[BUGFIX] Apply image cropping to click-enlarged images 26/47126/2
Oliver Hader [Sat, 5 Mar 2016 23:26:42 +0000 (00:26 +0100)]
[BUGFIX] Apply image cropping to click-enlarged images

Image cropping is not applied to click-enlarged images, neither if
using the lightbox-mode nor the regular mode using tx_cms_showpic.
Cropping is applied in these scenarios as well with transporting
the accordant crop value of the current image being processed.

Resolves: #72798
Releases: master, 7.6
Change-Id: I3e07fc447ac8a35cbe4fbb43bac9adb9bb7ed506
Reviewed-on: https://review.typo3.org/47126
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[BUGFIX] Set correct max-height for RTE 23/47123/2
Marius David Wieschollek [Sat, 5 Mar 2016 21:18:12 +0000 (22:18 +0100)]
[BUGFIX] Set correct max-height for RTE

Also fixes the spelling mistake in the label of the related Backend User Settings Option

Resolves: #74336
Releases: master, 7.6
Change-Id: I21d00fd2de901eb03111581626c7efc4dec23647
Reviewed-on: https://review.typo3.org/47123
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 years ago[BUGFIX] Absolute URIs get prefixed with absRefPrefix in typolink 18/47118/2
Oliver Hader [Wed, 20 Jan 2016 18:18:24 +0000 (19:18 +0100)]
[BUGFIX] Absolute URIs get prefixed with absRefPrefix in typolink

An absolute URI (e.g. "/folder/someFile.png") gets prefixed with
absRefPrefix (e.g. "/") which results in "//folder/someFile.png",
which is a schema-less URI notation and thus "folder" is
interpreted as hostname.

Resolves: #72846
Releases: master, 7.6
Change-Id: Ic49c0a24a17f754c6c89186e6041b9857eb967b1
Reviewed-on: https://review.typo3.org/47118
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 years ago[TASK] Copy is missing in pagetree context menu without edit permissions 19/47119/2
Gianluigi Martino [Thu, 25 Feb 2016 13:47:38 +0000 (14:47 +0100)]
[TASK] Copy is missing in pagetree context menu without edit permissions

Show copy option in pagetree context menu also without edit permission

Change-Id: Icefaa7ef775fa5eb23652e00fe7643ae863c0e19
Resolves: #73470
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/47119
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
3 years ago[BUGFIX] Fix slide function of cObject 16/47116/2
Jo Hasenau [Fri, 4 Mar 2016 21:06:28 +0000 (22:06 +0100)]
[BUGFIX] Fix slide function of cObject

Move variable value association to correct position.

Resolves: #69941
Releases: master, 7.6
Change-Id: I8bca6203f4e994a86b11f5d3be54b83e7dfdd73c
Reviewed-on: https://review.typo3.org/47116
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[BUGFIX] Check if selected page is available before loading BE module 14/47114/2
Michael Oehlhof [Mon, 23 Nov 2015 23:14:07 +0000 (00:14 +0100)]
[BUGFIX] Check if selected page is available before loading BE module

If a formerly selected page (in page tree) is not available anymore
(e.g. deleted), any access to a backend module will now check
this condition and will avoid an error.
An empty module will be displayed in such a case.

Resolves: #66449
Releases: master, 7.6
Change-Id: I4caf6abf715af2009705caf126f2614ae5cde9ed
Reviewed-on: https://review.typo3.org/47114
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 years ago[BUGFIX] Ensure t3d compatibility for supported TYPO3 version 90/47090/2
Nicole Cordes [Fri, 4 Mar 2016 09:33:48 +0000 (10:33 +0100)]
[BUGFIX] Ensure t3d compatibility for supported TYPO3 version

This patch fixes an issue with unclean t3d export due to string to array
conversion. This is important to be able to import a t3d files which was
exported with 7.6 and above even in 6.2. This is needed as we do not
have any chance to see which TYPO3 version was used for the export.

Resolves: #74127
Releases: master, 7.6, 6.2
Change-Id: I6ba7b825241c2ca439c485aaf597b019b7ac8997
Reviewed-on: https://review.typo3.org/47090
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
3 years ago[BUGFIX] Show the copy option in the page browser contextual menu 81/46481/4
Anja Leichsenring [Sat, 5 Mar 2016 17:34:35 +0000 (18:34 +0100)]
[BUGFIX] Show the copy option in the page browser contextual menu

Resolves: #33147
Releases: master, 7.6
Change-Id: I98c696eb58c759f6c50dbaf111556b86cffe0e93
Reviewed-on: https://review.typo3.org/46481
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 years ago[BUGFIX] Reinsert ommitted vars for ternary operators 09/47109/2
Jo Hasenau [Sat, 5 Mar 2016 16:55:38 +0000 (17:55 +0100)]
[BUGFIX] Reinsert ommitted vars for ternary operators

When the check is done with multiple variables omitting the first part
of a ternary operator just inserts the boolean result of the check
but not the variable

Change-Id: If683770435995cac079fb2fd42344ba1cc15a08f
Resolves: #70242
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/47109
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Denied file extensions still shown in upload forms 04/47104/2
Marco Huber [Tue, 19 Jan 2016 09:54:54 +0000 (10:54 +0100)]
[BUGFIX] Denied file extensions still shown in upload forms

The list of denied file extensions does not contain a dot, but our
fileDenyPattern by default starts with a dot. Therefore, although a
check is performed, the file extensions will still be displayed even
though uploading files with the extension is forbidden by
fileDenyPattern.

This commit adds the dot before the extension when performing the
check, effectively hiding forbidden extensions.

Resolves: #72803
Releases: master, 7.6
Change-Id: I2ec3d02e096b46309932604a53ea4c416ba9812a
Reviewed-on: https://review.typo3.org/46072
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
(cherry picked from commit 08011314eb18c111804d1d7fd74a47174ecc7a9d)
Reviewed-on: https://review.typo3.org/47104

3 years ago[BUGFIX] Allow images for HtmlArea in demo mode 98/47098/2
Benni Mack [Sat, 5 Mar 2016 10:27:39 +0000 (11:27 +0100)]
[BUGFIX] Allow images for HtmlArea in demo mode

PageTSconfig was only included in Typical and Advanced
mode resulting in an exception when adding images in
the RTE with Demo mode enabled (via Extension Manager).

Resolves: #74314
Releases: master, 7.6
Change-Id: Ieaffc7faa5cca1f910d1b00fd87e4ae4585889d6
Reviewed-on: https://review.typo3.org/47098
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[BUGFIX] Only show preview of non-hidden images 87/47087/2
Gianluigi Martino [Tue, 16 Feb 2016 22:19:08 +0000 (23:19 +0100)]
[BUGFIX] Only show preview of non-hidden images

Don't show preview of hidden images in backend e.g.
page module.

Change-Id: I11fbfdbdf9767066dbb3380b543d79c239e6c4a2
Resolves: #73481
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/47087
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[BUGFIX] Incompatible declaration of PreviewController::initializeView 86/47086/2
Andreas Fernandez [Wed, 2 Mar 2016 09:37:12 +0000 (10:37 +0100)]
[BUGFIX] Incompatible declaration of PreviewController::initializeView

The declaration of PreviewController::initializeView is changed to be
functional with PHP 7.

Change-Id: I4b59600aa3d98dec6440551f4228c9aad6fd6714
Resolves: #73866
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/47086
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[TASK] EXT:form - Optimize preview in page module 85/47085/2
Björn Jacob [Fri, 4 Mar 2016 20:01:20 +0000 (21:01 +0100)]
[TASK] EXT:form - Optimize preview in page module

This patchset optimizes the preview of a form
elements in the page module. The output of the bodytext
field has been removed. Instead, the ctype is shown.
This avoids the useless display of TypoScript in the
preview.

Resolves: #28403
Releases: master, 7.6
Change-Id: I09a18e6b8a782a50a2ea7570b41fe2abc10df835
Reviewed-on: https://review.typo3.org/47085
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Avoid memory leak during file searches 78/47078/2
Alexander Schnitzler [Sat, 30 Jan 2016 13:10:11 +0000 (14:10 +0100)]
[BUGFIX] Avoid memory leak during file searches

During the file search in the file module the search result
is only limited to possibly matching folders. That itself
decreases the search over all files in a storage but it
still does not prevent memory leaks, where the result
of possible folders contain a decent amount of files.

Example:
fileadmin has a total of 10.000 files.
fileadmin has a subfolder called foo
fileadmin/foo holds a subset of 1000 files.
fileadmin/foo holds the file bar

A search for bar asks the database for all folders that contain
files with the matching identifier bar. As a result, only the
folder fileadmin/foo is returned which already excludes 9000
possible files.

Still, the resultset contains 1000 files, whoose name is
compared php-wise with the search string. During that
foreach loop each a file object with a decent memory
footprint will be created. This easily exceeds the
available memory limit.

Resolves: #73032
Releases: master, 7.6
Change-Id: Icf46e05274c671db344797d207afefc029c5fb5b
Reviewed-on: https://review.typo3.org/47078
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] EXT:form Validation of email 75/47075/2
Florian Mast [Fri, 4 Mar 2016 14:53:07 +0000 (15:53 +0100)]
[BUGFIX] EXT:form Validation of email

Validation of email should respect empty value

Resolves: #54534
Releases: master,7.6
Change-Id: I40c865b42fe7960dd7ab85f710df1045cd04adf0
Reviewed-on: https://review.typo3.org/47075
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
3 years ago[TASK] Use new confirmation dialog for ClickMenu 72/47072/2
Frank Naegler [Fri, 4 Mar 2016 14:29:30 +0000 (15:29 +0100)]
[TASK] Use new confirmation dialog for ClickMenu

Resolves: #72617
Releases: master, 7.6
Change-Id: I0cf662d55303504d094426dbb82943d437035044
Reviewed-on: https://review.typo3.org/47072
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Adjust UserAgent checks in RTE to detect Edge correctly 71/47071/2
Benjamin Kott [Fri, 4 Mar 2016 10:27:02 +0000 (11:27 +0100)]
[BUGFIX] Adjust UserAgent checks in RTE to detect Edge correctly

Resolves: #70373
Releases: master, 7.6, 6.2
Change-Id: I8cb505a051ecfbc0f423d32cbc121545cec35bf4
Reviewed-on: https://review.typo3.org/47071
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 years ago[BUGFIX] Keep selected page active after save & close 70/47070/2
Gianluigi Martino [Thu, 3 Mar 2016 21:32:01 +0000 (22:32 +0100)]
[BUGFIX] Keep selected page active after save & close

Keep the currently selected page active when editing the page properties
of another page as non-admin user.

Change-Id: Iad438ad7e20ab8d818286053557ade26542d8216
Reviewed-on: https://review.typo3.org/47070
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
3 years ago[BUGFIX] Solves PHP warning in FileAllowedTypesValidator 57/46457/4
Florian Mast [Fri, 4 Mar 2016 11:44:02 +0000 (12:44 +0100)]
[BUGFIX] Solves PHP warning in FileAllowedTypesValidator

Resolves: #72890
Resolves: #73618
Releases: master, 7.6
Change-Id: Ida8a9ace681b93d1d66b0e06c893a83e549f8411
Reviewed-on: https://review.typo3.org/46457
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] Remove fileinfo as dependency in SystemEnvironment/Check 69/47069/2
Timo Schmidt [Fri, 4 Mar 2016 15:08:22 +0000 (16:08 +0100)]
[TASK] Remove fileinfo as dependency in SystemEnvironment/Check

Currenty 'fileinfo' is listed as required php extension in
SystemEnvironment/Check but it is currently not really required
and prevents from installing TYPO3 on Systems where it is not
present (e.g. Mircosoft Azure Cloud)

The class is currently only used once in the core in
"TYPO3\CMS\Core\Type\File\FileInfo" and only when it exists,
so it is not really a hard dependency.

Also grepping on an installation folder does not find any match
where \finfo is really required.

Resolves: #74177
Releases: master, 7.6
Change-Id: I125cd3e8d0eb6f208641375ea71b89917284f8b3
Reviewed-on: https://review.typo3.org/47069
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
3 years ago[TASK] Replace confirm in FileList->linkClipboardHeaderIcon 67/47067/2
Frank Naegler [Fri, 4 Mar 2016 14:41:51 +0000 (15:41 +0100)]
[TASK] Replace confirm in FileList->linkClipboardHeaderIcon

Resolves: #74178
Releases: master, 7.6
Change-Id: Iaa077ae648375e94abce90923d876128b19a3db7
Reviewed-on: https://review.typo3.org/47067
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] EXT:form - Fix CHECKBOXGROUP and RADIOGROUP in form wizard 66/47066/2
Andreas Häfner [Tue, 22 Dec 2015 16:23:05 +0000 (17:23 +0100)]
[BUGFIX] EXT:form - Fix CHECKBOXGROUP and RADIOGROUP in form wizard

Fixes a JS error, which appeared when adding a CHECKBOXGROUP or
RADIOGROUP within the form wizard.

Furthermore it applies "text" instead of "data" which was already
changed for TEXTAREA and OPTION elements (as discussed in #69369).

Resolves: #72316
Releases: master, 7.6
Change-Id: I758ad36530ea29ca5469e510367fdedde34c5bd6
Reviewed-on: https://review.typo3.org/47066
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Declare ``items`` for each RTE instance 65/47065/2
Florian Busch [Tue, 1 Mar 2016 13:04:59 +0000 (14:04 +0100)]
[BUGFIX] Declare ``items`` for each RTE instance

The variable ``items`` was declared in a prototype instance and thus
shared between all RTE instances. Declare the variable in its own
instance instead.

Change-Id: Ia6f8b5dffb19121ed8995afcc2124b0084be5f7a
Resolves: #68392
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/47065
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Avoid error message on unlimited upload_max_filesize 61/47061/2
Andreas Bouche [Thu, 3 Mar 2016 21:33:36 +0000 (22:33 +0100)]
[BUGFIX] Avoid error message on unlimited upload_max_filesize

Resolves: #73214
Releases: master, 7.6
Change-Id: I9496964ffd9daeb2c330f022c876f6aceacced1c
Reviewed-on: https://review.typo3.org/47061
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[TASK] Add json as composer dependency 57/47057/2
Tymoteusz Motylewski [Fri, 4 Mar 2016 14:49:14 +0000 (15:49 +0100)]
[TASK] Add json as composer dependency

PHP extension json is now listed as dependency
 in composer.json. Extension mysqli is added to
 "suggest" section.

Resolves: #74005
Releases: master, 7.6
Change-Id: Iae0f388a4b10a24e98c392f878381d753971acdb
Reviewed-on: https://review.typo3.org/47057
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 years ago[FOLLOWUP][TASK] EXT:form - Update and optimize documentation 53/47053/3
Björn Jacob [Fri, 4 Mar 2016 14:28:40 +0000 (15:28 +0100)]
[FOLLOWUP][TASK] EXT:form - Update and optimize documentation

This patchset changes some meta settings regarding the
documented version.

Resolves: #69346
Releases: 7.6
Change-Id: I4d4ab146277f83fca321967fd93df861c7d7ef32
Reviewed-on: https://review.typo3.org/47053
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 years ago[TASK] Add backend routes to configuration module 55/47055/2
Frank Naegler [Fri, 4 Mar 2016 12:57:04 +0000 (13:57 +0100)]
[TASK] Add backend routes to configuration module

This patch add the backend routes to the configuration module, to show all
current active backend routes.

Resolves: #74164
Releases: master, 7.6
Change-Id: I5c191d1d8dc8b002ea1a66a33b6628f7eec9994c
Reviewed-on: https://review.typo3.org/47055
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 years ago[BUGFIX] Allow overriding of Backend Routes 49/47049/2
Benni Mack [Thu, 3 Mar 2016 11:47:11 +0000 (12:47 +0100)]
[BUGFIX] Allow overriding of Backend Routes

Adding backend routes from Configuration/Backend/Routes.php is
done via "+=" operator which does not allow to override routes with
the same name. This is however a wanted behaviour - allowing extensions
to override core routes.

The patch changes the "+=" operator to a simple array_merge() call
to allow to change existing routes.

Resolves: #74004
Releases: master, 7.6
Change-Id: I7caf1ab5a91f849b4789ea352c20af6239470f2f
Reviewed-on: https://review.typo3.org/47049
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[TASK] Remove usage of Clipboard->confirmMsg() 47/47047/2
Frank Naegler [Mon, 29 Feb 2016 12:06:38 +0000 (13:06 +0100)]
[TASK] Remove usage of Clipboard->confirmMsg()

Resolves: #73743
Releases: master, 7.6
Change-Id: I212cb9eedbe82cb4e346823ba041a63e601ad670
Reviewed-on: https://review.typo3.org/47047
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] Change APC cache preset condition 43/47043/2
Thorsten Bringewatt [Tue, 24 Nov 2015 13:13:18 +0000 (14:13 +0100)]
[TASK] Change APC cache preset condition

This commit removes the check for minimum total apc cache size.
It should be enough to check for at least 5 MB free memory.

Change-Id: Ia8f6d2aaf9030c303534f7c27f2c73479aa4632a
Resolves: #71802
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/47043
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[BUGFIX] Check whether contentElementCache for language and colPos is valid 38/47038/2
Andreas Fernandez [Fri, 26 Feb 2016 20:13:17 +0000 (21:13 +0100)]
[BUGFIX] Check whether contentElementCache for language and colPos is valid

It may happen that ``$this->contentElementCache[$lP][$colPos]`` is either not
an array nor null. Wrap the foreach loop with an if condition to catch possible
errors.

Change-Id: I6394ff0eef28a490a54f54d172c601fa9768eb20
Resolves: #73670
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/47038
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[TASK] EXT:form - Update and optimize documentation 36/47036/2
Björn Jacob [Sat, 23 Jan 2016 16:16:07 +0000 (17:16 +0100)]
[TASK] EXT:form - Update and optimize documentation

The documentation of EXT:form is outdated. The whole documentation has
been proof read and revised. Furthermore, the document has experienced
a huge structural change. The long pages have been split into smaller
parts.

A lot of content was duplicated. Following the DRY principle, the
descriptions of functions/ attributes etc. are now documented at a
central place and references are used.

Resolves: #69346
Releases: master,7.6,6.2
Change-Id: I45ddcf2f93c94f2982ac5fdecd5a942fad2eef21
Reviewed-on: https://review.typo3.org/47036
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
3 years ago[BUGFIX] Fix 'Transfer selection to clipboard' button 35/47035/2
Jan Helke [Thu, 3 Mar 2016 23:23:11 +0000 (00:23 +0100)]
[BUGFIX] Fix 'Transfer selection to clipboard' button

This patch reintroduces the onclick event if the function call has no
warning. This fixes the error with the not working 'Transfer selection
to clipboard' button in the list view, if the user enables every clipboard
but the normal.

Resolves: #74122
Releases: master, 7.6
Change-Id: Iaf133951fa6278778bb468eca601185844f19130
Reviewed-on: https://review.typo3.org/47035
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Inline record in Flexform can attach new record 34/47034/2
Nicole Cordes [Fri, 29 Jan 2016 10:36:17 +0000 (11:36 +0100)]
[BUGFIX] Inline record in Flexform can attach new record

If you click the "create new element" button on an inline record within
a FlexForm field, the passed data information contains the id after
which the new element should be inserted. Currently this id isn't
respected while receiving the configuration from the given data. This
patch adds code to respect a possible given id and allows to fetch
configuration for that element as well.

Resolves: #73004
Releases: master, 7.6
Change-Id: I70263d3ff4a8641b1a8280574521e0671c34a333
Reviewed-on: https://review.typo3.org/47034
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
3 years ago[TASK] Add info about Apache version when using mod_filter 20/47020/2
Eric Chavaillaz [Fri, 22 Jan 2016 10:55:23 +0000 (11:55 +0100)]
[TASK] Add info about Apache version when using mod_filter

Since mod_filter is available since Apache 2.3.7 we need to check for
the apache version in the htaccess file.
Older versions of apache will work as well, even though they do not need
to check for the existence of mod_filter.

A comment is added to inform older Apache versions.

Resolves: #72886
Releases: master, 7.6, 6.2
Change-Id: Ia4905c992b52b2bd540ece0a1c1866aeacf6de85
Reviewed-on: https://review.typo3.org/47020
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[BUGFIX] Do not scroll on top using actions on multipleSideBySide 14/47014/2
Andreas Fernandez [Mon, 29 Feb 2016 08:07:40 +0000 (09:07 +0100)]
[BUGFIX] Do not scroll on top using actions on multipleSideBySide

This patch prevents scrolling to top when using the actions buttons
in multipleSideBySide elements.

Change-Id: I0841b3f75afca8596725fc6c9e4621eaeeafc641
Resolves: #72973
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/47014
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[BUGFIX] Drag&Drop sorting respects AuthMode 95/46995/2
ajahn [Thu, 18 Feb 2016 11:10:29 +0000 (12:10 +0100)]
[BUGFIX] Drag&Drop sorting respects AuthMode

If an editor is not allowed to edit content elements with a specific
CType (e.g. HTML), drag&drop sorting was still active. Sorting seemed to
work without an error but was blocked in DataHandler due to missing
permissions.
This fix introduces the missing check to deactivate sorting in this case.

Change-Id: Ib40b1e2a2fbbd4694fbb69ed7cda4a2180e15f14
Resolves: #73539
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/46995
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[BUGFIX] Disable 'SwitchUser' link if user is already in su mode 83/46983/2
Markus Hoelzle [Tue, 1 Mar 2016 11:29:35 +0000 (12:29 +0100)]
[BUGFIX] Disable 'SwitchUser' link if user is already in su mode

If you switch the user although you are in the su mode,
and you switch back you are the user from the su mode.

Resolves: #73797
Releases: master, 7.6
Change-Id: Idc10d6afbead80f79f4b51f49a4c52eab7c23456
Reviewed-on: https://review.typo3.org/46983
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Allow OnlineMedia Renderers to override via Fluid 76/46976/2
Benni Mack [Tue, 16 Feb 2016 13:35:44 +0000 (14:35 +0100)]
[BUGFIX] Allow OnlineMedia Renderers to override via Fluid

When using the Online Media (Youtube / Vimeo) then the autoplay
option is always taken from the FileReference, overriding
the option that might be set via Fluid.

A check if the option hasn't been set yet makes the overriding
order clearer.

Resolves: #73484
Releases: master, 7.6
Change-Id: I3fb57c88383445062f5beabd8d8287ff772974d3
Reviewed-on: https://review.typo3.org/46976
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] Replace confirm on delete icon in list module table 69/46969/2
Frank Naegler [Mon, 29 Feb 2016 10:31:38 +0000 (11:31 +0100)]
[TASK] Replace confirm on delete icon in list module table

This patch replaces the old JavaScript confirm dialog on the delete button
in list module tables.

Resolves: #73737
Releases: master, 7.6
Change-Id: Ie4a0c25111a04217069793653b9eac16fce2a778
Reviewed-on: https://review.typo3.org/46969
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Improve accessibiity-check of index page in HMENU 'browse' 24/46924/2
Markus Hoelzle [Tue, 16 Feb 2016 14:13:30 +0000 (15:13 +0100)]
[BUGFIX] Improve accessibiity-check of index page in  HMENU 'browse'

The special HMENU 'browse' should check whether the page is
really accessible to avoid sql errors.

Resolves: #73493
Releases: master, 7.6
Change-Id: I5b2d49a094b6495a72d9ce055f6f98c799a9419c
Reviewed-on: https://review.typo3.org/46924
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[FOLLOWUP][BUGFIX] Switch-User feature uses wrong user id for logging 20/46920/2
Christian Kuhn [Fri, 26 Feb 2016 16:20:47 +0000 (17:20 +0100)]
[FOLLOWUP][BUGFIX] Switch-User feature uses wrong user id for logging

For master, the username partial is inlined to the main template to
suppress a whitespace issue with fluid.
For 7.6, the inlining went wrong and a variable change is applied.

Change-Id: Ibe3626b581d0203307be1347e6708bc15cb3db9d
Resolves: 71580
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/46920
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[BUGFIX] Remove deprecated call in InlineRecordContainer 17/46917/2
Frank Naegler [Fri, 26 Feb 2016 15:55:49 +0000 (16:55 +0100)]
[BUGFIX] Remove deprecated call in InlineRecordContainer

This patch removes the usage of the deprecated FlashMessage->render
method and add a custom markup instead.

Resolves: #73703
Releases: master, 7.6
Change-Id: I1c84aa0c353a26fdc62d7d16fca5cdfc22326156
Reviewed-on: https://review.typo3.org/46917
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Sys actions: Removed call to deprecated method render() 15/46915/2
Michael Oehlhof [Sun, 21 Feb 2016 17:28:40 +0000 (18:28 +0100)]
[BUGFIX] Sys actions: Removed call to deprecated method render()

Call of FlashMessage->render() was replaced with appropriate code if

getTask
* the action is not found
* the action had no type defined

viewNewBackendUser
* the action configuration is not finished
* the user has been created

viewSqlQuery
* query is empty (not built)
* query is not configured
* required sysext lowlevel is not installed

viewRecordList
* the action configuration is not finished
* not enough rights to access the list view or the page

Resolves: #73587
Releases: master, 7.6
Change-Id: I9140d337cc52d1be7974771d3929f727266a9cc6
Reviewed-on: https://review.typo3.org/46915
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Removed call to render() after getFlashMessageForMissingFile 14/46914/2
Michael Oehlhof [Sun, 3 Jan 2016 01:30:51 +0000 (02:30 +0100)]
[BUGFIX] Removed call to render() after getFlashMessageForMissingFile

Replace calls to deprecated method render() and to the function
getFlashMessageForMissingFile() with appropriate html code.

Resolves: #72508
Releases: master, 7.6
Change-Id: I90846f8349726e88dfa6aa77ab595fe28280e81b
Reviewed-on: https://review.typo3.org/46914
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Switch-User feature uses wrong user id for logging 89/45489/4
Oliver Hader [Tue, 29 Dec 2015 14:07:12 +0000 (15:07 +0100)]
[BUGFIX] Switch-User feature uses wrong user id for logging

Issue #17643 introduced logging for a simulated backend user
(switch-user) and thus logs by using the original admin user.

This is a regression in PageLayoutController::renderQuickEdit
since the used backend user id is different to the persisted
one. Besides that, all actions are performed with the permissions
of the simulated user - thus, logging with a different user seems
to wrong. The sys_log.log_data field (array) is used to transport
the information of the original (admin) user.

This change reverts the initial change of issue #17643 and adds
the initial intention of that issue as addition to the persisted
data in sys_log.log_data. All affected components are adjusted as
well to visualize that a user has been simulated (log view, record
history and lowlevel_cleaner syslog command).

Resolves: #71580
Releases: master, 7.6
Change-Id: If12df60563afd1f0746d43e62f824b20f139df8c
Reviewed-on: https://review.typo3.org/45489
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[BUGFIX] Scheduler: Removed call to deprecated method render() 09/46909/2
Michael Oehlhof [Thu, 25 Feb 2016 22:01:45 +0000 (23:01 +0100)]
[BUGFIX] Scheduler: Removed call to deprecated method render()

Call of FlashMessage->render() when configuring a task with the class
"File Abstraction Layer: Extract metadata in storage" for the
"Registered extractors" was replaced with appropriate code.

Resolves: #73685
Releases: master, 7.6
Change-Id: I1265ad845c2e951c9a5a242f74fa336a26645a88
Reviewed-on: https://review.typo3.org/46909
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Module recordlist: Removed call to deprecated method render() 08/46908/2
Michael Oehlhof [Wed, 24 Feb 2016 23:15:30 +0000 (00:15 +0100)]
[BUGFIX] Module recordlist: Removed call to deprecated method render()

Call of FlashMessage->render() was replaced with appropriate code if
a temporary mount point is set in DatabaseBrowser and PageLinkHandler.

Resolves: #73661
Releases: master, 7.6
Change-Id: If11b9b1a6447807ff9e567b2288c198fa0eea961
Reviewed-on: https://review.typo3.org/46908
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[TASK] Use button instead of question mark for CSH in QuickEdit 07/46907/2
Daniel Goerz [Tue, 23 Feb 2016 08:44:38 +0000 (09:44 +0100)]
[TASK] Use button instead of question mark for CSH in QuickEdit

Change-Id: Ieba334b767e25c586b78dfcbe48ee1e56742596c
Resolves: #73615
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/46907
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Field pageIdSelector in RTE link popup is visible when enabled 03/46903/2
Franz Kugelmann [Wed, 3 Feb 2016 13:53:55 +0000 (14:53 +0100)]
[BUGFIX] Field pageIdSelector in RTE link popup is visible when enabled

When pageIdSelector is configured to be enabled,
a new key is added to $fieldDefinitions.
But it has no effect as long as this key is not set additionally in
$this->linkAttributes.
This patch adds this missing piece.

Resolves: #73090
Releases: master, 7.6
Change-Id: I86f83bc3292144e06c7fcc179469c715c80dcb16
Reviewed-on: https://review.typo3.org/46903
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[BUGFIX] Set selected CSS class on image in RTE 92/46892/2
Markus Klein [Wed, 24 Feb 2016 20:09:55 +0000 (21:09 +0100)]
[BUGFIX] Set selected CSS class on image in RTE

Fix a copy&paste error in the javascript to set the selected class
on the image.

Resolves: #73657
Releases: master, 7.6
Change-Id: I8b7e3580185221f98d16c8fd48fe9f9fc21cfd52
Reviewed-on: https://review.typo3.org/46892
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Stage buttons shown in frontend without user being repsonsible 91/46891/2
Oliver Hader [Thu, 11 Feb 2016 15:12:35 +0000 (16:12 +0100)]
[BUGFIX] Stage buttons shown in frontend without user being repsonsible

The workspace preview in the frontend shows the buttons to the previous
and next stage if the user is not responsible for the current stage.
Clicking the button does not forward the records to the names stage
however - this is caught by DataHandlerHook in EXT:version.

Resolves: #73243
Releases: master, 7.6, 6.2
Change-Id: I233629cb393d5786048ab7ead39cd3316780b488
Reviewed-on: https://review.typo3.org/46891
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[BUGFIX] PageLinkHandler: Fix wrong function casing of sL() call 86/46886/2
Markus Klein [Thu, 25 Feb 2016 06:35:58 +0000 (07:35 +0100)]
[BUGFIX] PageLinkHandler: Fix wrong function casing of sL() call

Resolves: #73662
Releases: master, 7.6
Change-Id: I46561ecfa2186c1b065acbffe154f375b823e839
Reviewed-on: https://review.typo3.org/46886
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] Remove css_styled_content as part of the factory default 79/46879/2
Wouter Wolters [Tue, 23 Feb 2016 18:42:09 +0000 (19:42 +0100)]
[BUGFIX] Remove css_styled_content as part of the factory default

Resolves: #73558
Releases: master, 7.6
Change-Id: Iaf7bdf486a0b0229233181cca8b4c7ef68bf9bbc
Reviewed-on: https://review.typo3.org/46879
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[TASK] Check if user have permission to cut records 76/46876/2
Gianluigi Martino [Fri, 19 Feb 2016 12:01:51 +0000 (13:01 +0100)]
[TASK] Check if user have permission to cut records

Only show cut icons when the user has write-permissions on the
specific record.

Change-Id: I0d5a1153faf448f9c1c6c0948f2cdf8f78cab8f6
Resolves: #73564, #73472
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/46876
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Use proper URL for file list of returnUrl in file_upload 72/46872/2
Benni Mack [Tue, 16 Feb 2016 19:58:36 +0000 (20:58 +0100)]
[BUGFIX] Use proper URL for file list of returnUrl in file_upload

When the file upload controller is called (which is almost
impossible to call these days) and no return URL is given
(which is again almost impossible), then the URL is invalid.

The patch uses the proper getModuleUrl() call which is
sufficient.

Resolves: #73506
Releases: master, 7.6
Change-Id: I49830e84cb10c14ccb84ea932927898899e58e70
Reviewed-on: https://review.typo3.org/46872
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>