Packages/TYPO3.CMS.git
47 hours ago[TASK] Update Bootstrap to 5.0.1 master
Andreas Fernandez [Fri, 14 May 2021 09:34:32 +0000 (11:34 +0200)]
[TASK] Update Bootstrap to 5.0.1

Executed command:

  yarn add "bootstrap@^5.0.1"

Also, some minor coding issues were solved that popped up
with the update.

Resolves: #94138
Releases: master
Change-Id: Ie80eff09efba43cfb9ae60862cb2167b0bc3f12f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69146
Tested-by: core-ci <typo3@b13.com>
Tested-by: Richard Haeser <richard@richardhaeser.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Richard Haeser <richard@richardhaeser.com>
Reviewed-by: Benni Mack <benni@typo3.org>
2 days ago[BUGFIX] Resolve PHP 8 issues in acceptance tests
Larry Garfield [Mon, 3 May 2021 22:21:49 +0000 (17:21 -0500)]
[BUGFIX] Resolve PHP 8 issues in acceptance tests

PHP 8 promotes a lot of notices (previously ignored) to warnings.
That means they can no longer be ignored.

Resolves: #94057
Releases: master
Change-Id: I37de1b7e8e31eb2be78b8e90af015bc88e121791
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69012
Tested-by: core-ci <typo3@b13.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Benni Mack <benni@typo3.org>
2 days ago[TASK] Switch behavior of ArrayUtility::arrayDiffAssocRecursive()
Andreas Fernandez [Thu, 13 May 2021 14:48:46 +0000 (16:48 +0200)]
[TASK] Switch behavior of ArrayUtility::arrayDiffAssocRecursive()

Despite its name, the method `ArrayUtility::arrayDiffAssocRecursive()`
mimics the behavior of `array_diff_key()` and not of
`array_diff_assoc()`.

The method has been adjusted to act like `array_diff_assoc()`. As this is
considered being a breaking change, the behavior must be enabled
explicitly by passing a 3rd parameter `$useArrayDiffAssocBehavior` being
true. If the argument is either omitted or false, the old behavior is kept
but a deprecation warning will be thrown.

Resolves: #94137
Releases: master, 10.4
Change-Id: I3cfa9581596ca4114bce4daca461187e9b87fe99
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69143
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Richard Haeser <richard@richardhaeser.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Richard Haeser <richard@richardhaeser.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 days ago[BUGFIX] Make label clickable in "Dependencies could not be resolved" dialog
Andreas Fernandez [Fri, 14 May 2021 09:48:39 +0000 (11:48 +0200)]
[BUGFIX] Make label clickable in "Dependencies could not be resolved" dialog

Resolves: #94139
Releases: master
Change-Id: I645c03ae9ddb411dae7ef6b55a8e3fde479785c0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69148
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Richard Haeser <richard@richardhaeser.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Richard Haeser <richard@richardhaeser.com>
2 days ago[BUGFIX] Respect icon size defined by tree
Benni Mack [Fri, 14 May 2021 10:01:36 +0000 (12:01 +0200)]
[BUGFIX] Respect icon size defined by tree

The SVG Tree now builds a SVG-in-SVG element around all
icons (icon + overlay) to ensure the sizes are consistent
and can be positioned properly.

This fixes the issue that possible custom icons have
a different size.

Resolves: #86280
Releases: master
Change-Id: Icf39e74c398d149a9216a64551bdeb250ed2bf00
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69147
Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 days ago[BUGFIX] Fix Typo3DbQueryParserTest for custom php timezones
Benjamin Franzke [Thu, 13 May 2021 08:19:39 +0000 (10:19 +0200)]
[BUGFIX] Fix Typo3DbQueryParserTest for custom php timezones

The test setup used to initialize the DateAspect from a string,
that means the local php timezone has been taken into account,
and test verficiation fails with date offsets if the local
timezone is not UTC.

Adapt to initialize from a unix timestamp, as this ensures
the local timezone has no effect on the test. Note that the
real application does the same, as the DateAspect in initialized
from the timestamp in GLOBALS['EXEC_TIME'].

Releases: master, 10.4, 9.5
Resolves: #94135
Change-Id: I0494ac3e1911f34a3a79c3063caaabad1c0027b7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69141
Tested-by: core-ci <typo3@b13.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
3 days ago[TASK] Migrate SiteInlineActions to TypeScript
Oliver Bartsch [Wed, 12 May 2021 22:18:30 +0000 (00:18 +0200)]
[TASK] Migrate SiteInlineActions to TypeScript

Resolves: #94133
Releases: master
Change-Id: I2101f3acc5c32c45efa3a8330bb7b6aa1d9716ce
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69138
Tested-by: core-ci <typo3@b13.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
3 days ago[TASK] Implement ValuePicker as custom web component
Andreas Fernandez [Tue, 11 May 2021 15:33:11 +0000 (17:33 +0200)]
[TASK] Implement ValuePicker as custom web component

TCA's value picker uses a lot inline JavaScript for its
picker handling, therefore, the handling has been moved
into a dedicated web component.

As a side-effect a bug in TextElement and InputTextElement
is fixed. Both elements previously used exactly the opposite
insert mode.

Resolves: #94112
Releases: master
Change-Id: Ib3a1f9697477cab4b9a00c606fcd0bd6524450b5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69108
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
3 days ago[BUGFIX] Ensure UriBuilder always contains a cObj
Benni Mack [Wed, 12 May 2021 14:20:52 +0000 (16:20 +0200)]
[BUGFIX] Ensure UriBuilder always contains a cObj

When UriBuilder is used outside of an initialized ExtbaseAction
and not within StandaloneView, the cObj is not properly initialized
inside Extbase's UriBuilder

Resolves: #91625
Releases: master, 10.4
Change-Id: I850257f0a5d47d3ec18e7eb791894c90258394f7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69132
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
4 days ago[BUGFIX] Harden RootlineUtility::enrichWithRelationFields
Oliver Klee [Mon, 19 Apr 2021 20:13:26 +0000 (22:13 +0200)]
[BUGFIX] Harden RootlineUtility::enrichWithRelationFields

In some rare cases (e.g., for some Console commands),
RootlineUtility::enrichWithRelationFields might be run without
any TCA, which leads to a crash. This is now avoided.

Resolves: #93949
Releases: master, 10.4
Change-Id: I7725b99341f55aa20279abccb35a79e4fb574409
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68802
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
4 days ago[TASK] Remove objectManager from various Extbase places
Benni Mack [Mon, 10 May 2021 20:00:41 +0000 (22:00 +0200)]
[TASK] Remove objectManager from various Extbase places

This change adapts certain areas within EXT:extbase
Persistence to avoid ObjectManager and rely on constructor
DI and GeneralUtility::makeInstance() where it's not
easily possible to switch to DI yet.

Resolves: #94111
Releases: master
Change-Id: I731d5b8f791bd34410aa3bf86bc7dc4e6098fa20
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69101
Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
4 days ago[BUGFIX] Fix phpstan errors from TypesAssignedToPropertiesRule
Alexander Schnitzler [Wed, 5 May 2021 14:17:54 +0000 (16:17 +0200)]
[BUGFIX] Fix phpstan errors from TypesAssignedToPropertiesRule

in

* EXT:workspaces
* EXT:tstemplate
* EXT:setup
* EXT:scheduler
* EXT:recycler
* EXT:lowlevel
* EXT:linkvalidator
* EXT:install
* EXT:info

Releases: master
Resolves: #94121
Change-Id: Idb153afd9763cd9c3238be68d2290bde68e88b35
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69038
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
4 days ago[TASK] Remove Extbase's BackendRequestHandler
Benni Mack [Wed, 12 May 2021 07:45:25 +0000 (09:45 +0200)]
[TASK] Remove Extbase's BackendRequestHandler

This change removes the internal BackendRequestHandler
of Extbase as TYPO3 Backend modules are now dispatched
directly via Extbase's Bootstrap.

This takes away one layer of indirection for Backend modules
which are built with Extbase.

Resolves: #94118
Releases: master
Change-Id: I5c1b323c75363521f49c93f16976f866961fcddf
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69111
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Benni Mack <benni@typo3.org>
4 days ago[TASK] Only persist on POST requests in EditDocumentController
Benni Mack [Tue, 6 Apr 2021 19:51:55 +0000 (21:51 +0200)]
[TASK] Only persist on POST requests in EditDocumentController

This change ensures that writing to EditDocumentController
only happens for POST requests, as EditDocumentController
currently takes care of rendering the form AND saving
a record via DataHandler.

Resolves: #94114
Releases: master
Change-Id: If6dc8930d0fa0cb2ed5d1165d6a42d9639013556
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68714
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
4 days ago[BUGFIX] Fix InputLinkElement to be visible again
Nikita Hovratov [Fri, 7 May 2021 11:47:00 +0000 (13:47 +0200)]
[BUGFIX] Fix InputLinkElement to be visible again

Since the bootstrap v5 update, the inputLinkElement is styled with flex
form instead of display table. This became a problem, because this broke
the appearance of the explanation toggling.

The initial idea to hide the complete clearable wrap didn't work
properly as it is loaded dynamically and it's not ensured it exists
when trying to hide it.

To circumvent this problem, the styling is now done with some extra css.
Additionally the wrong form-control class is removed from the clearable
wrap and the styling is now also moved to own css.

Resolves: #93941
Releases: master
Change-Id: I0bb0d1cf26ed40dd3c87a58e08cc39e449b96c0d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69064
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Benni Mack <benni@typo3.org>
4 days ago[TASK] Dashboard: Adjust toolbar items look
Daniel Windloff [Sun, 16 Aug 2020 06:36:50 +0000 (08:36 +0200)]
[TASK] Dashboard: Adjust toolbar items look

Use the standard layout for toolbar items to make recurring elements
look the same in the various core modules.

Resolves: #92018
Releases: master
Change-Id: I2c34d0e977652bd247c0dd983308385cdf865042
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65341
Tested-by: Richard Haeser <richard@richardhaeser.com>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Richard Haeser <richard@richardhaeser.com>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
4 days ago[BUGFIX] Normalize slug before converting Unicode characters to ascii
Dmitry Dulepov [Wed, 17 Mar 2021 12:09:51 +0000 (15:09 +0300)]
[BUGFIX] Normalize slug before converting Unicode characters to ascii

This change adds a normalization for slug source before converting it
to ascii. This helps to avoid issues with various ways to encode the
same Unicode characters.

Used command:
   composer req symfony/polyfill-intl-normalizer

Resolves: #93764
Releases: master, 10.4
Change-Id: I9982fafd9c34c69bb6ca47ee8242f504b9974121
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68492
Tested-by: core-ci <typo3@b13.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 days ago[BUGFIX] Allow to disable allowed aspect ratios
Daniel Dorndorf [Fri, 2 Apr 2021 10:59:08 +0000 (12:59 +0200)]
[BUGFIX] Allow to disable allowed aspect ratios

When overriding aspect ratios via TCA overrides,
one can also now disable allowed aspect ratios in cropVariants.

Resolves: #93854
Releases: master, 10.4
Change-Id: I10f5ac16ce6bb6ca776e483c525ee6e4268e5e8d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68670
Tested-by: Richard Haeser <richard@richardhaeser.com>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Richard Haeser <richard@richardhaeser.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 days ago[FEATURE] Add Shona (sn) as supported language
Benni Mack [Tue, 4 May 2021 12:55:27 +0000 (14:55 +0200)]
[FEATURE] Add Shona (sn) as supported language

Shona is a Bantu language of the Shona people of Zimbabwe.
It is one of the most widely spoken Bantu languages.

Also see https://en.wikipedia.org/wiki/Shona_language

This change adds support for Shona to be selected as TYPO3 Language
and to connect to TYPO3 Localizations (XLF files, Site Configuration)
by default.

Resolves: #93114
Releases: master
Change-Id: Id25823fc5021d9cc3480fb57627fe3cfcfbcb614
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68987
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
4 days ago[BUGFIX] Only return translation count message for a non-zero count
Andreas Fernandez [Fri, 7 May 2021 13:26:44 +0000 (15:26 +0200)]
[BUGFIX] Only return translation count message for a non-zero count

With #93979, `BackendUtility::translationCount()` was changed and always
returned the message "This record has X translation(s) [...]!" even if
there are no translated records at all.

This patch initializes `$count` as 0 and changes the message handling as
similar as in `BackendUtility::referenceCount()`.

Resolves: #94091
Related: #93979
Releases: master
Change-Id: I43dfa860d1c278a239bd88e83feddf239b8b01a8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69066
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
4 days ago[BUGFIX] Avoid SQL error for scheduler task on PostgreSQL
Stephan Großberndt [Mon, 10 May 2021 12:21:33 +0000 (14:21 +0200)]
[BUGFIX] Avoid SQL error for scheduler task on PostgreSQL

This patch makes sure tx_scheduler_task.task_group contains an integer
in order to avoid a SQL error when saving the task which in turn may
lead to an endless fetch-and-save loop.

Resolves: #94102
Releases: master, 10.4
Change-Id: Ie81d2c3a7eb193f4fd1ed59c34fe2de9fad023f4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69097
Tested-by: core-ci <typo3@b13.com>
Tested-by: Simon Gilli <typo3@gilbertsoft.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Simon Gilli <typo3@gilbertsoft.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
4 days ago[TASK] Streamline backend UriBuilder dependency injection
Benjamin Franzke [Thu, 6 May 2021 11:35:34 +0000 (13:35 +0200)]
[TASK] Streamline backend UriBuilder dependency injection

The Router dependency should not be optional and rather always be
injected, and in reality it always was, as the nullable fallback
to GeneralUtility::makeInstance was only used in unit tests.

The UriBuilder factory is now provided via the backend
service provider. That is because it became an ondemand
dependency for the backend request handler in #93674.
We now properly inject it via constructor which makes it
a lowlevel service (a service that needs to defined via
service provider to be available when TYPO3 has not yet
been installed).

Releases: master
Resolves: #94083
Change-Id: I75b39cdae8c41d1ce38860c50713d749bbe8e348
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69056
Tested-by: core-ci <typo3@b13.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Richard Haeser <richard@richardhaeser.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
4 days ago[BUGFIX] Delay error handler registration
Benjamin Franzke [Tue, 12 Jan 2021 22:05:10 +0000 (23:05 +0100)]
[BUGFIX] Delay error handler registration

The ErrorHandler is not be fully configured (missing logger) by the
time the object is constructed, but the error handler is registered
at that point. As errors may happen during construction of dependencies
(again the logger) of the ErrorHandler, the error handler registration
needs to be delayed in order to avoid usage of the error handler while
dependencies are still being created. This may happen in case an
exception occurs during creation of the ErrorHandler's logger instances.

Resolves: #93279
Releases: master, 10.4, 9.5
Change-Id: I0ded490c35e61120e055f853accb10e16080ea1a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67440
Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 days ago[BUGFIX] Use forgot message from FlexForm
mabolek [Fri, 7 May 2021 10:02:45 +0000 (12:02 +0200)]
[BUGFIX] Use forgot message from FlexForm

The password recovery page was not displaying custom messages from the
plugin FlexForm. This is fixed by using the RenderLabelOrMessage
partial, rather than the f:translate ViewHelper.

Resolves: #94087
Releases: master, 10.4
Change-Id: Ic8efe0820a52ced6613acf8860490ed6e6df8b94
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69063
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: core-ci <typo3@b13.com>
4 days ago[BUGFIX] ElementInformationController: Always show records meta info
Daniel Windloff [Sun, 13 Sep 2020 08:49:10 +0000 (10:49 +0200)]
[BUGFIX] ElementInformationController: Always show records meta info

Use the TCA to get the field names of the meta info.
Add the folder name as a title, if folder information are shown.

Releases: master, 10.4
Resolves: #92299
Change-Id: I4247518efd61c806821fcb7400830eb1175766e2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65710
Tested-by: core-ci <typo3@b13.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 days ago[TASK] Align configuration module search bar
Oliver Bartsch [Tue, 4 May 2021 20:43:46 +0000 (22:43 +0200)]
[TASK] Align configuration module search bar

As a follow up of #94042, the search bar in
the configuration module is now also aligned
with the rest of the backend. The regular
expression checkbox is therefore moved into
a dropdown, according to the recordlist.

Since browsers nowadays add their own clearable
functionality to type=search fields, it's sufficient
to just register an event for it. Especially because
initialization of our custom clearable functionality
would otherwise lead to duplicated clear icons.

Resolves: #94101
Releated: #94042
Releases: master
Change-Id: I019d1de724d87a9ab074aec062c39295d9e41670
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69023
Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
4 days ago[BUGFIX] Call `TBE_EDITOR.fieldChanged()` again
Andreas Fernandez [Tue, 11 May 2021 15:40:20 +0000 (17:40 +0200)]
[BUGFIX] Call `TBE_EDITOR.fieldChanged()` again

With #93975 the calls to `TBE_EDITOR.fieldChanged()` as onchange handlers
have been removed which was an accidental breaking change.
This patch adds the necessary calls again, which may lead to false
deprecation warnings in the browser's console.

Resolves: #94108
Related: #93975
Releases: master
Change-Id: Ifbae4adb0ff8b931bbdb3fe4d08c14c5aa30f81f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69107
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
5 days ago[TASK] Update to Lit v2-rc2
Benjamin Franzke [Sat, 8 May 2021 15:10:19 +0000 (17:10 +0200)]
[TASK] Update to Lit v2-rc2

Executed commands:

 cd Build/
 yarn upgrade lit@^2.0.0-rc.2 lit-html@^2.0.0-rc.3 lit-element@^3.0.0-rc.2
 grunt rollup

Resolves: #94096
Releases: master
Change-Id: Iddea7dbe03ca911eda1be5a758d6e8ab910843ea
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69095
Tested-by: core-ci <typo3@b13.com>
Tested-by: Richard Haeser <richard@richardhaeser.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Richard Haeser <richard@richardhaeser.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
5 days ago[TASK] Avoid ObjectManager->get() in EXT:backend
Oliver Bartsch [Mon, 10 May 2021 19:33:39 +0000 (21:33 +0200)]
[TASK] Avoid ObjectManager->get() in EXT:backend

Resolves: #94107
Related: #90803
Releases: master
Change-Id: Iccb0eab82275feb250180ae6674c5b9d2a176fd4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69100
Tested-by: core-ci <typo3@b13.com>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
5 days ago[BUGFIX] Keep unmapped ?type parameter when using PageTypeDecorator
Benni Mack [Mon, 3 May 2021 19:20:46 +0000 (21:20 +0200)]
[BUGFIX] Keep unmapped ?type parameter when using PageTypeDecorator

This change keeps the type parameter (e.g. ?type=13) even
if PageTypeDecorator is used when building URLs but "13" is not
part of the map in the site configuration.

A test is added in order to make sure this functionality
will not break (again), see
https://review.typo3.org/c/Packages/TYPO3.CMS/+/62383
for the original fix without tests.

Resolves: #87104
Related: #87817
Related: #88836
Releases: master, 10.4, 9.5
Change-Id: Ic7f82bfa9f28f971162e1af1b557188f61446462
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68978
Tested-by: core-ci <typo3@b13.com>
Tested-by: Henrik Elsner <helsner@dfau.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Henrik Elsner <helsner@dfau.de>
Reviewed-by: Rémy DANIEL <dogawaf@no-log.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Benni Mack <benni@typo3.org>
6 days ago[TASK] Remove unused key "name" in TBE_STYLES
Nikita Hovratov [Thu, 6 May 2021 21:06:08 +0000 (23:06 +0200)]
[TASK] Remove unused key "name" in TBE_STYLES

There is no usage of the key "name" in
$GLOBALS['TBE_STYLES']['skins']['backend'].

Even in earlier versions of TYPO3 no usage can be found in the code.

Resolves: #94085
Releases: master
Change-Id: Idfb027da21459f0693d8a66829493e78c81f81d7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69059
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
6 days ago[BUGFIX] Do not render unassigned label in info module
Oliver Bartsch [Mon, 10 May 2021 09:45:20 +0000 (11:45 +0200)]
[BUGFIX] Do not render unassigned label in info module

Since #94042, the Localization overview in the
info module is equipped with proper labels. These
labels should however not be rendered, in case the
corresponding menu does not exist, e.g. on pages
without available languages.

Resolves: #94099
Related: #94042
Releases: master
Change-Id: I1d3ab9db22e3d850aefc012b3daac1923661e936
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69096
Tested-by: core-ci <typo3@b13.com>
Tested-by: Richard Haeser <richard@richardhaeser.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Richard Haeser <richard@richardhaeser.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
6 days ago[BUGFIX] Do not override disabled user settings
Alexander Stehlik [Wed, 5 May 2021 18:08:54 +0000 (20:08 +0200)]
[BUGFIX] Do not override disabled user settings

When the realName or email field of a user is disabled
by TSconfig, the current values will remain when saving.

Resolves: #94075
Releases: master, 10.4
Change-Id: Idfa4ba9f0d558575b9d3fcccd33784513e54d016
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69053
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Richard Haeser <richard@richardhaeser.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Richard Haeser <richard@richardhaeser.com>
6 days ago[DOCS] Reference to function for better usage does not exist
Marc Bastian Heinrichs [Sat, 8 May 2021 12:42:19 +0000 (14:42 +0200)]
[DOCS] Reference to function for better usage does not exist

Function getScriptPath is not implemented. PHPDoc block of function
getPathInfo points to getScriptName.

Resolves: #94095
Releases: master, 10.4, 9.5
Change-Id: I6329cff8ace4a3b5562e6d2d568dbed6d69c0ae5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69094
Tested-by: core-ci <typo3@b13.com>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Richard Haeser <richard@richardhaeser.com>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Richard Haeser <richard@richardhaeser.com>
6 days ago[TASK] Activate AppendedArrayItemTypeRule phpstan rule
Alexander Schnitzler [Wed, 5 May 2021 12:36:03 +0000 (14:36 +0200)]
[TASK] Activate AppendedArrayItemTypeRule phpstan rule

Releases: master
Resolves: #94073
Change-Id: I2a17bfd5d9cf4fce0915e466dd48e266dc6485b7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69035
Tested-by: core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
8 days ago[TASK] Reduce ObjectManager usages within ConfigurationManager
Benni Mack [Fri, 7 May 2021 08:44:31 +0000 (10:44 +0200)]
[TASK] Reduce ObjectManager usages within ConfigurationManager

This change removes any objectManager usages within Configuration
Manager.

Resolves: #94093
Releases: master
Change-Id: I24e272e86b28856e19ae86e68735963b9340724c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69062
Tested-by: core-ci <typo3@b13.com>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
8 days ago[TASK] Remove usages of call_user_func() and call_user_func_array()
Larry Garfield [Tue, 4 May 2021 17:03:19 +0000 (12:03 -0500)]
[TASK] Remove usages of call_user_func() and call_user_func_array()

Using direct calls and variadics is slightly faster, and usually cleaner to read.

I left in the instant-call call_user_func() instances in the entry point files, as
that's only a single call and is arguably at least no worse than (function() {})().

Resolves: #94060
Releases: master
Change-Id: I95988feadf8522d8d936a273608e0ef2d5ce75b5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69017
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: crell <larry@garfieldtech.com>
Reviewed-by: Benni Mack <benni@typo3.org>
9 days ago[TASK] Update to Twitter Bootstrap 5.0.0
Benjamin Franzke [Fri, 7 May 2021 12:19:25 +0000 (14:19 +0200)]
[TASK] Update to Twitter Bootstrap 5.0.0

This change updates the Twitter Bootstrap
dependency to version 5.0.0

See https://blog.getbootstrap.com/2021/05/05/bootstrap-5/
for more details.

Used commands:
> cd Build
> yarn upgrade bootstrap@^5.0.0 @types/bootstrap@^5.0.13
> grunt build

Resolves: #94089
Releases: master
Change-Id: I10cca03662049c354a01ef9ce98ef3840b0443bb
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69065
Tested-by: core-ci <typo3@b13.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
9 days ago[BUGFIX] FormEngine: Support description in BackendLayoutWizardElement
Christian Kuhn [Thu, 6 May 2021 13:01:10 +0000 (15:01 +0200)]
[BUGFIX] FormEngine: Support description in BackendLayoutWizardElement

Have TCA 'description' field for renderType=belayoutwizard.
See styleguide elements basic -> text -> text_20 before/after.

Resolves: #94079
Releases: master, 10.4
Change-Id: I18d8001904e97384b15d825253919465f90c4a06
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69057
Tested-by: core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
9 days ago[BUGFIX] Re-Allow Extbase Reflection for self
Benni Mack [Thu, 6 May 2021 07:43:12 +0000 (09:43 +0200)]
[BUGFIX] Re-Allow Extbase Reflection for self

Due to a bug in #94001 the Extbase Reflection of
"self" did not work anymore.

Resolves: #94076
Releases: master, 10.4
Change-Id: I3658d8175661621a493ac15d19238b4f0d60eb64
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69054
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: crell <larry@garfieldtech.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
10 days ago[FEATURE] Add Symfony mailer DSN configuration option to install tool
Markus Hoelzle [Sat, 6 Mar 2021 09:36:26 +0000 (10:36 +0100)]
[FEATURE] Add Symfony mailer DSN configuration option to install tool

The install tool has now the possibility to configure
the Symfony mailer with DSN.

The DSN setting was already implemented but with a not
consistent configuration option and was never documented.

Resolves: #93668
Releases: master
Change-Id: I12428aad0c41af74471f25efe3462632866c29a7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68197
Tested-by: core-ci <typo3@b13.com>
Tested-by: Simon Gilli <typo3@gilbertsoft.org>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Simon Gilli <typo3@gilbertsoft.org>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
10 days ago[TASK] Remove goToModule() inline JavaScript invocations
Oliver Hader [Tue, 4 May 2021 16:25:50 +0000 (18:25 +0200)]
[TASK] Remove goToModule() inline JavaScript invocations

This change reduces the amount of inline JavaScript and transforms
`goToModule()` invocations in the TYPO3 backend user interface to use
`ActionDispatcher`'s `TYPO3.ModuleMenu.showModule` handling.

Resolves: #94058
Releases: master
Change-Id: I0411100ae6ec9c5d9493c00fb4efd80b4858ee0e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69015
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Benni Mack <benni@typo3.org>
10 days ago[TASK] Reduce Extbase usages in EXT:seo
Benni Mack [Fri, 30 Apr 2021 18:56:17 +0000 (20:56 +0200)]
[TASK] Reduce Extbase usages in EXT:seo

Language and Site objects can be retrieved from TSFE
in HrefLangGenerator as well as TypoScript plugin
configuration in XmlSitemapRenderer.

Resolves: #94069
Releases: master
Change-Id: Ia9984b02cb2f8edc1a7bf2c3e103b10bc8d157fd
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68931
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
10 days ago[BUGFIX] Log DataHandler errors instead of FlashMessage
Benni Mack [Thu, 29 Apr 2021 19:40:56 +0000 (21:40 +0200)]
[BUGFIX] Log DataHandler errors instead of FlashMessage

DataHandler should log instead of creating FlashMessages
since FlashMessages fail in CLI context. Method
->printLogErrorMessages() turns DataHandler logs
into FlashMessages already and is used in appropriate
contexts like EditDocumentController and friends.

Resolves: #93549
Releases: master, 10.4
Change-Id: I0a39204cfced5be5513cfc2f58452ffb8a15942e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68921
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
10 days ago[TASK] Streamline EXT:belog filter
Christian Kuhn [Wed, 5 May 2021 12:38:25 +0000 (14:38 +0200)]
[TASK] Streamline EXT:belog filter

To be more consistent with the backend user and redirects
module, the filter section of the backend log module is
streamlined.
The clumsy time range drop down is replaced, the 'user defined'
time selection via date pickers is always shown instead.
The hard to understand 'group by page' when called from
within info module having a depth > 0 is dropped, since a
similar information can be achieved more naturally using
the page tree selection.
The filter drop-downs don't reload automatically anymore
to be in-line with other modules, 'set' is renamed to
'Filter' and a 'Reset' button is added.

Resolves: #94072
Releases: master
Change-Id: Ia0a2229bc8f37a717a0e10a39e7337d67a32456c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69036
Tested-by: core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
10 days ago[TASK] Slim down TBE_EDITOR
Andreas Fernandez [Tue, 4 May 2021 20:03:24 +0000 (22:03 +0200)]
[TASK] Slim down TBE_EDITOR

TBE_EDITOR is a precursor of the current FormEngine with a lot of unused
legacy code. Most of its functions were used in an internal scope and
were not meant to be public API, thus everything that has no use at the
current time of writing this commit has been removed.

Resolves: #94065
Releases: master
Change-Id: If9099734e80b3f458065047555860775e7e02c89
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69021
Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
10 days ago[TASK] Avoid GeneralUtility::_GET() in EXT:indexed_search
Oliver Bartsch [Wed, 5 May 2021 12:06:57 +0000 (14:06 +0200)]
[TASK] Avoid GeneralUtility::_GET() in EXT:indexed_search

The AdministrationController in EXT:indexed_search is based
on the extbase framework. As this provides a specific request
object, there is no need to use GeneralUtility::_GET() for
fetching plugin related arguments.

However, since the extbase specific request object does not
provide non-plugin related arguments (those without the plugin
prefix), we currently have to fetch them from the global PSR-7
request. This will vanish as soon as extbase does also use the
PSR-7 implementation.

Resolves: #94071
Releases: master
Change-Id: Ib5bd533b2a2bb9283dda11e0a796f3dfd629458f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69034
Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
11 days ago[BUGFIX] Fix insufficient color contrast of reset button
Oliver Bartsch [Wed, 5 May 2021 11:18:45 +0000 (13:18 +0200)]
[BUGFIX] Fix insufficient color contrast of reset button

Since #94046, the reset buttons, used in the EXT:beuser and
EXT:redirects modules, have an insufficient color contrast and
are therefore changed to `btn-link`, restoring the previous
display.

Resolves: #94070
Related: #94046
Releases: master
Change-Id: I115174b5ccff513064c7cea1266fbd6be22cfb58
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69032
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
11 days ago[BUGFIX] Return correct source record for relations
Nicole Cordes [Mon, 27 Aug 2018 14:17:38 +0000 (16:17 +0200)]
[BUGFIX] Return correct source record for relations

This change addresses a flaw when resolving ancestor ids of 1:n
relationships - resolving `l10n_source` pointer always was `0`.

Besides that now only non-empty `l10n_parent` or `l10n_source` are
returned as integer. Otherwise `null` is returned and signals that
a corresponding ancestor could not be resolved at all.

Scenario `localizeParentContentChainLanguageSynchronizationSource` of
`DataHandling\IRRE\ForeignField\Modify\ActionTest` was given already,
however `l10n_source` fields were missing in their TCA.

Resolves: #86141
Releases: master, 10.4, 9.5
Change-Id: Ia0e3d9accd5c1998f4fd971861262c158cc8f838
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/58049
Tested-by: core-ci <typo3@b13.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
11 days ago[BUGFIX] Remove wrong margin in belog module filter
Oliver Bartsch [Tue, 4 May 2021 22:12:22 +0000 (00:12 +0200)]
[BUGFIX] Remove wrong margin in belog module filter

Resolves: #94068
Relates: #94020
Releases: master
Change-Id: I0b727c1af5e4f3b7617ea1e0e5975ccfdb69adcc
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69027
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
11 days ago[TASK] Raise typo3/testing-framework to ^6.8.2
Christian Kuhn [Tue, 4 May 2021 20:54:30 +0000 (22:54 +0200)]
[TASK] Raise typo3/testing-framework to ^6.8.2

Brings a bugfix to be more strict comparing
CSV fixtures with DB rows.

composer req --dev typo3/testing-framework:^6.8.2

Resolves: #94066
Releases: master, 10.4
Change-Id: Ie21e85cdb29af0da02d6c8081a3fc842289cc09c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69024
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
11 days ago[BUGFIX] Avoid overwriting goToModule in top frame
Benjamin Franzke [Fri, 30 Apr 2021 13:55:39 +0000 (15:55 +0200)]
[BUGFIX] Avoid overwriting goToModule in top frame

In case the TYPO3 backend is loaded inside the content frame,
which is a result of a programming error, the inner backend
overwrites state of the outer one, making the backend
unusable because references to javascript singletons
are mixed between outer and inner frame.

Releases: master
Resolves: #94062
Change-Id: Ia3b75d949ec94ebdce317208e87917206769de48
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68930
Tested-by: core-ci <typo3@b13.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
11 days ago[TASK] Remove duplicate css for the btn class
Nikita Hovratov [Mon, 3 May 2021 19:24:21 +0000 (21:24 +0200)]
[TASK] Remove duplicate css for the btn class

This removes all parts in the button component which are exactly the
same as in bootstrap.

Resolves: #94046
Releases: master
Change-Id: Ie3efb386a4e2cce970fc46155c6ae3b8b9acc82a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68979
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
11 days ago[TASK] Merge functional test stages for nightly run
Anja Leichsenring [Tue, 4 May 2021 19:34:33 +0000 (21:34 +0200)]
[TASK] Merge functional test stages for nightly run

There is no valid reason anymore to separate functional
test stages into 2 runs, so they get merged again.

Resolves: #94064
Releases: master, 10.4
Change-Id: I02385b2332b62ac9f637442b2500b214bd66b357
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69019
Tested-by: core-ci <typo3@b13.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
11 days ago[TASK] gitlab-ci: PHP 8.0 unit test nightlies min/max
Christian Kuhn [Tue, 4 May 2021 18:01:42 +0000 (20:01 +0200)]
[TASK] gitlab-ci: PHP 8.0 unit test nightlies min/max

Needs a phpdocumentor/type-resolver raise:
composer req phpdocumentor/type-resolver:^1.4

Change-Id: Iffecb88d34a4c04816eff5543611192fcc3b8296
Resolves: #94063
Releases: master
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69018
Tested-by: core-ci <typo3@b13.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
11 days ago[TASK] Center text in infobox vertically
Nikita Hovratov [Tue, 27 Apr 2021 18:50:23 +0000 (20:50 +0200)]
[TASK] Center text in infobox vertically

In case an infobox has an icon but no title and the text is just one
line, the text is now vertically centered.

Also remove the css property "vertical-align: middle" as it has no
effect anymore.

Resolves: #93998
Releases: master
Change-Id: I58c75fb6c7004101a9598307ac8385a023fd2426
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68890
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
11 days ago[TASK] Enable phpstan parameter checkPhpDocMethodSignatures
Daniel Goerz [Tue, 4 May 2021 16:41:24 +0000 (18:41 +0200)]
[TASK] Enable phpstan parameter checkPhpDocMethodSignatures

Resolves: #94059
Releases: master
Change-Id: I9687dddef9889d79359e64987e8886a305d3149f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69016
Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
11 days ago[TASK] gitlab-ci: PHP 8.0 functional nightlies with mariadb 10.5
Christian Kuhn [Tue, 4 May 2021 15:41:43 +0000 (17:41 +0200)]
[TASK] gitlab-ci: PHP 8.0 functional nightlies with mariadb 10.5

Next to pre-merge test suite, nightlies now especially run
the composer min/max functionals with PHP8. Using mariadb
10.5 to cover another DBMS variant.

Needs a friendsoftypo3/phpstan-typo3 raise:
composer require --dev friendsoftypo3/phpstan-typo3:^0.7.0

Change-Id: Iea86496e32a586b20d4d6eeb6db84ec5a06d0767
Resolves: #94061
Releases: master
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68991
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
11 days ago[TASK] Streamline namespaces in felogin
Benjamin Franzke [Mon, 3 May 2021 10:55:01 +0000 (12:55 +0200)]
[TASK] Streamline namespaces in felogin

The namespace of "felogin" was partially changed to
\TYPO3\CMS\FrontendLogin with #84262, but was kept
with \TYPO3\CMS\FeLogin for backwards compatibility
in some places.

Now that deprecated functionality has been
removed, the code is streamlined to use the
new FrontendLogin namespace solely.

Resolves: #94041
Related: #84262
Releases: master
Change-Id: Ie315d413b6b81a1be3f6c6574e103c61d172be3b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68974
Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
11 days ago[TASK] Add support for PHP-CS-Fixer 3.0
Benni Mack [Tue, 4 May 2021 13:28:18 +0000 (15:28 +0200)]
[TASK] Add support for PHP-CS-Fixer 3.0

This change raises the dev dependency PHP-CS-Fixer
to 2.19 (forward-compatible to 3.0) and 3.0,
allowing to run PHP-CS-Fixer with PHP8.

This change adapts the config file to use
the latest syntax. Using PSR-12 will be
handled in a separate followup.

Used composer commands:
- composer req friendsofphp/php-cs-fixer:"^2.19 || ^3.0" --dev
- composer req friendsofphp/php-cs-fixer:"^2.19 || ^3.0" -d typo3/sysext/core --dev --no-update

Resolves: #94053
Releases: master, 10.4
Change-Id: I47d4ca1b09728599782883fb4958908446fd7cfe
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68989
Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Benni Mack <benni@typo3.org>
12 days ago[BUGFIX] Remove deprecated reflection API usage
Larry Garfield [Tue, 27 Apr 2021 22:45:28 +0000 (17:45 -0500)]
[BUGFIX] Remove deprecated reflection API usage

PHP 8 deprecated a number of very old bits of the Reflection API. This
patch updates ClassSchema to use the newer equivalents.

Also fixes some unrelated PHP 8.0 errors around undefined value handling.

Resolves: #94001
Releases: master, 10.4
Change-Id: Id235fa830894e9a2dc6465444ec2c6808f18c3aa
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68898
Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
12 days ago[BUGFIX] Use grid-gutter-width variable for margin
Nikita Hovratov [Mon, 3 May 2021 18:36:44 +0000 (20:36 +0200)]
[BUGFIX] Use grid-gutter-width variable for margin

This fixes the alignment of the rows in the doc header and
the size of horizontal lines in dropdowns.

Replace the hardcoded 15px margin with the bootstrap grid-gutter-width
variable. The row margin override for .module-docheader-bar can be
removed completely.

Resolves: #94044
Releases: master
Change-Id: Iefa02fed9c00a31676d296e86e1bc75049810795
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68976
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Benni Mack <benni@typo3.org>
12 days ago[BUGFIX] Type check extbase parameter for array
Remo Häusler [Mon, 17 Aug 2020 09:57:37 +0000 (11:57 +0200)]
[BUGFIX] Type check extbase parameter for array

If an argument on a plugin namespace is not an array,
Extbase failed hard with an type error exception.

Resolves: #91040
Releases: master, 10.4, 9.5
Change-Id: Ib613081aeb99232f1254a431fec57f15bb88b1c0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65351
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Oliver Bartsch <bo@cedev.de>
12 days ago[BUGFIX] Multiple languages in the update command
Guido Schmechel [Sun, 10 Jan 2021 16:00:01 +0000 (17:00 +0100)]
[BUGFIX] Multiple languages in the update command

If a TYPO3 integrator creates the scheduler command
language:update and defines multiple languages,
e.g. de fr pt, then this is now interpreted.

Releases: master, 10.4
Resolves: #91876
Change-Id: Ia7639f322e5f693aa59f83dacf908b15f2d265ad
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67394
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Richard Haeser <richard@richardhaeser.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Richard Haeser <richard@richardhaeser.com>
12 days ago[BUGFIX] Ensure MountPoint parameter contains valid characters
Benni Mack [Mon, 3 May 2021 18:39:42 +0000 (20:39 +0200)]
[BUGFIX] Ensure MountPoint parameter contains valid characters

When using ?MP=12-13,345-673 some could also add a
letter or a "/" symbol in the GET parameter, effectively
showing a 503 instead of 404 page. This change ensures
that $TSFE->MP only contains numbers, commas or dashes.

Resolves: #94045
Releases: master, 10.4
Change-Id: I9d47153495701eb36bd9eb0c9936c0956b075560
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68977
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Nikita Hovratov <nikita.h@live.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Nikita Hovratov <nikita.h@live.de>
Reviewed-by: Benni Mack <benni@typo3.org>
12 days ago[TASK] Unify backend filter styling
Oliver Bartsch [Thu, 29 Apr 2021 23:38:32 +0000 (01:38 +0200)]
[TASK] Unify backend filter styling

Improves the overall look and feel of the filters in
various backend modules, thanks to the new bootstrap v5
grid. We can therefore now rely on flex-form instead of
float technology. By using the `g-X` gutter classes and
the `align-items-X` arrangement classes, we ensure the
positioning and spacing is the same in each module.

This allows to effectively remove the `form-inline-spaced`
class since this can easily be done with flex-form
and the mentioned classes in bootstrap v5.

Adjustments done:

* Use of flex-form to align and position form fields
* Add missing labels and unify arrangement
* Adjust size and position of form components
* Unify select field size
* Unify search field display
* Unify submit and reset button styles

Resolves: #94042
Resolves: #94026
Releases: master
Change-Id: Iae95a3e90179c6708ce6e1f0f272f267b6cae645
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68926
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Nikita Hovratov <nikita.h@live.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Nikita Hovratov <nikita.h@live.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
12 days ago[TASK] Set TYPO3 version to 11.3.0-dev
Oliver Hader [Tue, 4 May 2021 08:44:46 +0000 (10:44 +0200)]
[TASK] Set TYPO3 version to 11.3.0-dev

Change-Id: Ib8345499805813806ead6c0068fb0db6834b8f34
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68984
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
12 days ago[RELEASE] Release of TYPO3 11.2.0 v11.2.0
Benni Mack [Tue, 4 May 2021 07:37:42 +0000 (09:37 +0200)]
[RELEASE] Release of TYPO3 11.2.0

Change-Id: If9e35910fbf5556a93557ae17c2f3dba23748080
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68982
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
12 days ago[BUGFIX] Make LanguagePackCommand schedulable
Guido Schmechel [Mon, 3 May 2021 21:30:18 +0000 (23:30 +0200)]
[BUGFIX] Make LanguagePackCommand schedulable

Due to a regression the LanguagePackCommand wasn't schedulable.
The command registration is now extended to re-add the flag.

Releases: master
Resolves: #94048
Related: #93174
Change-Id: I61c315229472a733be4e1d28c42d23be7fba0fb9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68981
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
12 days ago[BUGFIX] Keep session object in sync with session storage values
Markus Klein [Tue, 9 Mar 2021 17:11:45 +0000 (18:11 +0100)]
[BUGFIX] Keep session object in sync with session storage values

Ensure that changes done to session records in the respective backends
are updated by building a new session object, so
specifically the ses_tstamp value is updated.

Besides that, set the ipLock information on the session object instead
of the deduced session record making consecutive session updates
idempotent.

Resolves: #93421
Resolves: #93386
Releases: master
Change-Id: I9715c82bb147348d8bc7526b29c790bc59ac8a0e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67637
Tested-by: core-ci <typo3@b13.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Laurent Foulloy <yolf.typo3@orange.fr>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
12 days ago[TASK] Move Changelog files into 11.2 folder for upcoming release
Anja Leichsenring [Sat, 1 May 2021 19:37:29 +0000 (21:37 +0200)]
[TASK] Move Changelog files into 11.2 folder for upcoming release

Resolves: #94038
Releases: master
Change-Id: Iff2a240929531c69fcd4f833efb3f673b7737405
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68961
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
12 days ago[BUGFIX] Fix MultiStepWizard functionality
Nikita Hovratov [Sat, 1 May 2021 18:15:20 +0000 (20:15 +0200)]
[BUGFIX] Fix MultiStepWizard functionality

The MultiStepWizard has some obvious programming errors, which
surprisingly didn't cause any problems in TYPO3 v10. It was built
primarily with the multi step wizard of the form module in mind. This
fact reflects on some parts of the code.

As the direct commits to the module didn't change anything dramatically
it's reasonable to conclude the bootstrap v5 update revealed the flaws.

Most notably all 4 slides are now visible in the progress bar. Before
only 3 slides were visible (Step 3 was overridden with finish).

This patch fixes the prev and next logic to work properly with any size
of slides in a clear and understandable way.

Other notable changes:
- The missing progress bar titles in the form module multi step wizard
are added.
- The jQuery slideUp and slideDown of the buttons when going back to
the first step are removed as it serves no meaningful purpose.
- The hard coded forceSelection change when switching to first slide
(=true) and last slide (=false) is removed.

Resolves: #94037
Releases: master
Change-Id: I4f70dd30b3caf29a71491a69b18c6753666ccef4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68960
Tested-by: core-ci <typo3@b13.com>
Tested-by: Jonas Eberle <flightvision@googlemail.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
12 days ago[BUGFIX] Use Address::create instead of new
Simon Gilli [Tue, 27 Apr 2021 18:07:57 +0000 (20:07 +0200)]
[BUGFIX] Use Address::create instead of new

The usage of Address::create instead of a plain new ensures
compatibility with all Symfony releases. Since Symfony 5.2.6 the
behavior was changed to always return email addresses properly
quoted but this change broke our Mailer.

Resolves: #93843
Related: #93831
Releases: master, 10.4
Change-Id: Ia8d35c220be0ba46cf75dec51585158760fad26d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68888
Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
13 days ago[BUGFIX] Remove hardcoded click title mode
Benni Mack [Mon, 3 May 2021 08:30:56 +0000 (10:30 +0200)]
[BUGFIX] Remove hardcoded click title mode

With the change https://review.typo3.org/c/Packages/TYPO3.CMS/+/66237
an accidental hard-coded clickTitleMode got added,
which changes the default behavior.

This change reverts the hard-coded setting.

Resolves: #94040
Related: #92652
Releases: master
Change-Id: I10c9db85ba0aab831d0aaf7d5c6e514b3c2bb7c8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68972
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
13 days ago[BUGFIX] Handle workspace overlays in AbstractItemProvider
Oliver Bartsch [Thu, 29 Apr 2021 22:28:07 +0000 (00:28 +0200)]
[BUGFIX] Handle workspace overlays in AbstractItemProvider

The AbstractItemProvider method for fetching records
from `foreign_table`, e.g. used in selectSingle types,
missed proper workspace handling and therefore listed
the same record (online and offline) multiple times.

This is now fixed by adding the WorkspaceRestriction,
and applying proper overlay handling (e.g. removing
delete placeholder and move pointers).

Resolves: #90392
Releases: master, 10.4
Change-Id: Idd6ee40c7422f3b234afc2025b248f1c18a9cf98
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68925
Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
13 days ago[TASK] Use correct html element for actions in RecordList
Georg Ringer [Wed, 21 Oct 2020 15:33:23 +0000 (17:33 +0200)]
[TASK] Use correct html element for actions in RecordList

Differentiate between tags 'a' and 'button' in the record list.
An a-tag opens a page, a button triggers an action.

Additionally the change includes 3 accessibility related issues:

Implement browser "tooltips" (ie title attributes) on a-tags
and button-tags as Bootstrap tooltips.

Add aria-haspopup="dialog" on buttons that open a Bootstrap modal
which are implemented as ARIA role dialog.

Remove attribute role="group" from elements without accessible name.

Resolves: #92652
Releases: master
Change-Id: I685c7713edc4a4dfc6568c59c3e921ce951d26f9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66237
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
2 weeks ago[BUGFIX] Fix csh popover position
Nikita Hovratov [Sun, 2 May 2021 00:38:44 +0000 (02:38 +0200)]
[BUGFIX] Fix csh popover position

This fixes the popover position after clicking on a csh link.

Side note:
The popover loads in two steps: First it shows a "loading ..." text and
when the content is fetched the popover must be updated. Before it was
achieved by hiding and then immediately showing the popover again. This
doesn't quite work with bootstrap v5 anymore. The popover is stuck in
the middle of the process before the positioning applies.

New method: Use the "setContent" method of the bootstrap popover
instance. This method is not documented, but it can be used.
Nevertheless we should keep an eye on that, as it's not public API.

Resolves: #93984
Resolves: #93152
Releases: master
Change-Id: If96028bd70bead243af1937cd2f87afed3b61c5f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68962
Tested-by: core-ci <typo3@b13.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 weeks ago[BUGFIX] Prevent currentSubScript re-assignment for secondary modules
Benjamin Franzke [Sat, 1 May 2021 17:18:00 +0000 (19:18 +0200)]
[BUGFIX] Prevent currentSubScript re-assignment for secondary modules

With the history-synchronization introduced in #93988,
window.currentSubScript has been unconditionally overwritten
after loading a new module in the content frame.
This causes an empty currentSubScript string to be stored
for secondary modules (modules not linked in the module menu),
and results in subsequent faults, when currentSubScript
is used to open a different page with the current module context.

Releases: master
Resolves: #94036
Related: #93988
Change-Id: Id957e72da5eb39437f35d19469dcdbd8a36c2b7e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68959
Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
2 weeks ago[DOCS] Add documentation for system extension adminpanel
flicstar [Thu, 29 Apr 2021 06:16:35 +0000 (16:16 +1000)]
[DOCS] Add documentation for system extension adminpanel

This change should allow users to:
*  Discover the extension via docs.typo3.org
*  Allow different target groups like administrator,
   integrator and editor to get an idea about the feature
   set and how to use the extension.

Resolves: #93260
Releases: master, 10.4
Change-Id: I90a8f356231cc49baf3c8fbedd9625300827c094
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68908
Tested-by: Daniel Siepmann <coding@daniel-siepmann.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Nikita Hovratov <nikita.h@live.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Daniel Siepmann <coding@daniel-siepmann.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Nikita Hovratov <nikita.h@live.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
2 weeks ago[TASK] Remove unused properties from EditDocumentController
Christian Kuhn [Wed, 28 Apr 2021 20:34:10 +0000 (22:34 +0200)]
[TASK] Remove unused properties from EditDocumentController

The values "_serialNumber", "_scrollPosition", "viewId_addParams"
are hidden form fields that are relics from TYPO3 Core v3.x,
long unused and obsolete.

Same goes for "uc" which just parks an incoming value (where
the FormEngineUtility::updateInlineView() can also be moved
inside the EditDocumentController), and unused values such as
"newC".

Resolves: #94009
Releases: master
Change-Id: I049a3f2b656affaa7860ad2ca4a9746438739881
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68902
Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
2 weeks ago[BUGFIX] Streamline CSS after Bootstrap 5 update
Benni Mack [Fri, 30 Apr 2021 19:56:29 +0000 (21:56 +0200)]
[BUGFIX] Streamline CSS after Bootstrap 5 update

Some very old code is removed in CSS definitions back from TYPO3 v7 (where
we had <img> tags).

In addition, some more Bootstrap 5 adaptions are made from the
initial update to increase contrast.

Resolves: #93179
Releases: master
Change-Id: If303c5a891e3b833f448fce65259c2751a4f7124
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68952
Tested-by: core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
2 weeks ago[TASK] gitlab-ci: Drop notify stage
Christian Kuhn [Sat, 1 May 2021 14:40:58 +0000 (16:40 +0200)]
[TASK] gitlab-ci: Drop notify stage

gerrit voting and slack nightly reporting is now done
with a gitlab webhook instead of a CI stage.

Change-Id: I6498c41229cb3b6a9178d2a91dbbfbb657034cce
Resolves: #94035
Releases: master, 10.4, 9.5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68956
Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
2 weeks ago[TASK] Introduce composer manifest checks
Jochen Roth [Thu, 15 Apr 2021 15:04:11 +0000 (17:04 +0200)]
[TASK] Introduce composer manifest checks

The extension manager now provides a new module,
which allows an integrator to display all available
extensions with composer deficits, like missing
composer.json or missing extension-key.

The new module informs about the deficit and
automatically generates a valid composer.json.
proposal. In case no composer.json exists, the
corresponding ext_emconf is sent to a new TER
endpoint (https://extensions.typo3.org/composerize).
This endpoint then generates a new composer.json
proposal by resolving all dependencies.

Furthermore, a new report is added to EXT:reports
which also informs about such extensions by directly
linking to the new EM module.

This helps especially in non-composer-mode installations
to ease the upgrade path for future TYPO3 versions which
(hopefully) will rely on composer.json only for e.g.
PackageStates.php.

Resolves: #93931
Releases: master, 10.4
Change-Id: I1230363d5d03e03bff39e7070faf4e331532a292
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68778
Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Jochen <rothjochen@gmail.com>
2 weeks ago[FEATURE] Add decoding attribute to images
Chris Müller [Mon, 12 Apr 2021 17:56:43 +0000 (19:56 +0200)]
[FEATURE] Add decoding attribute to images

This change adds the decoding attribute to images. For better rendering
performance the default value is set to "async" (which decodes images
in content elements asynchronously from the main rendering thread).

See also: https://html.spec.whatwg.org/multipage/images.html#decoding-images

Resolves: #93908
Releases: master
Change-Id: I6e8f3985b9ab60de5cf203c36295be29eb6e876c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68764
Tested-by: core-ci <typo3@b13.com>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Benni Mack <benni@typo3.org>
2 weeks ago[BUGFIX] Apply TCAdefaults to DataHandler if FormEngine was not used before
Benni Mack [Thu, 29 Apr 2021 18:25:03 +0000 (20:25 +0200)]
[BUGFIX] Apply TCAdefaults to DataHandler if FormEngine was not used before

If TCAdefaults.pages.categories = 4 is used in userTSconfig, and a new
page is created via Drag&Drop or via "Create Multiple New Pages" via
ClickMenu, TCAdefaults are now added to the incomingFieldArray and
not just the fieldArray.

This is also great for translations (using "Just Localized"(tm) technology),
where the defaults are respected as well now.

Resolves: #92146
Resolves: #77847
Related: #89211
Releases: master, 10.4
Change-Id: I87a2f2d486831f9bda9a979c4ff99d4e8b2ada2f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68918
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Benni Mack <benni@typo3.org>
2 weeks ago[TASK] Deprecate Extbase EnvironmentService
Alexander Schnitzler [Tue, 6 Oct 2020 15:13:10 +0000 (17:13 +0200)]
[TASK] Deprecate Extbase EnvironmentService

EnvironmentService is an API class for constant TYPO3_MODE,
which has been deprecated with v11. Core API class
ApplicationType can be used instead, which obsoletes
EnvironmentService.
The code adapts usages and deprecates EnvironmentService.

Releases: master
Resolves: #92494
Related: #92947
Change-Id: Id6f818a8f312e735904d79e7b372fe70db97c9a1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66060
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
2 weeks ago[TASK] gitlab-ci: Reduce job timeout
Christian Kuhn [Sat, 1 May 2021 08:10:39 +0000 (10:10 +0200)]
[TASK] gitlab-ci: Reduce job timeout

Jobs are sometimes stuck, for instance when they run
into infinite loops. With the default job timeout of
one hour and a default retry, it takes two hours until
those report negative.
Jobs are usually done in less than 15 minutes. We now
set the timeout to generous 30 minutes, a pipeline with
a stuck job will thus report after one hour, latest.

Resolves: #94033
Related: #94001
Releases: master, 10.4, 9.5
Change-Id: I80c26783f5ff0a5900c849d84f57c77e22ca4f63
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68954
Tested-by: core-ci <typo3@b13.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
2 weeks ago[FEATURE] Introduce backend module web component router
Benjamin Franzke [Sat, 6 Mar 2021 14:41:09 +0000 (15:41 +0100)]
[FEATURE] Introduce backend module web component router

A custom Lit-based web componenent router is added which
reflects module URLs into the browser adress bar and
at the same time prepares for native web components to
be used as future iframe module alternatives.

Such modules will be implemented as JavaScript modules,
that provide an implementation for a custom HTML Web
Component. The first of such components (added within
this change) is a wrapper component for traditional
iframe-based backend modules.

Module state changes are advertised via DOM events and
propagated to the browser address bar, browser title,
and the module menu.

Adress bar updates
==================

The module URL to address bar synchronisation enables sharable
module deeplinks to be copied from the browser address bar.
Whenever a component advertises a state change (e.g.
iframe change), a sharable deep link is generated and
shown in the browser adressbar.

Technical preparation for the required deeplinking has been
added with #93674.

History Management
==================

Browser history state is managed via the iframe
history context of the content module frame
(that is unlike other modern Single Page Applications
which use history.pushState and history.replaceState).

This approach required some synchronisation work, but there are
technical limitations that prevent a combination of iframe history
updates in combination for newer API like history.pushState.
(The limitation is: state added by history.pushState is skipped
by iframe history handling).

The advantage of this compromise is: All "traditional" modules will
preserve their state handling as before, no breaking/behavioral
changes for iframe-based modules.

Routing
=======

The router uses two parameters to perform routing:
 * module – Module name as defined in ext_tables.php
 * endpoint – (json) api to be used by the component (= module URL)
The module attribute is used to perform the actual routing
to the respective backend module component, while the endpoint
attribute serves as API to parse/fetch the state of the module.

A named slot is used to switch between the available module components.
That means only one of the routers childNodes will be visible at a
time, while all modules are actively attached to the DOM.
State is therefore preserved when switching between modules
and the iframe is always kept active, allowing to act as history
state-container (as described in "History Management").

Example of two modules that are attached to the DOM, where
only <typo3-configuration-module> is visible as the <slot>
in the shadow root puts a reference to this childNode:

<typo3-backend-module-router module="system_config" endpoint="…">
  #shadow-root
    <slot name="TYPO3/CMS/Lowlevel/ConfigurationModule"></slot>
  <typo3-iframe-module endpoint="…"
    slot="TYPO3/CMS/Backend/Module/Iframe"></…>
  <typo3-configuration-module endpoint="…"
    slot="TYPO3/CMS/Lowlevel/ConfigurationModule"></…>
</typo3-backend-module-router>

Note: The "TYPO3/CMS/Lowlevel/ConfigurationModule" component is not
yet part of this commit, and only serves as an example (will be
implemented later on). The slot name is resolved from
the module key.

Out of scope for this patch (will follow later)
===============================================

 * Link based routing interception via data-module tag for anchor tags.
   To be added as an additional convenience API on top of the
   router module and endpoint attribute (current API).
 * Convenience components for module layout
 * Integration into shortcut handler
 * Install-tool URLs do not reflect into addressbar right now
   Install-tool modules are redirected, therefore url updates can not
   be mapped as backend URLs right now
   Solution will probably be to integrate the install tool
   components as web component into the backend.

Resolves: #93988
Related: #93674
Releases: master
Change-Id: I682e89649b597c8c74b6a0a8f198f6bcf5bbc347
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67464
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
2 weeks ago[TASK] Simplify ext:beuser moduleData handling
Christian Kuhn [Thu, 29 Apr 2021 22:09:41 +0000 (00:09 +0200)]
[TASK] Simplify ext:beuser moduleData handling

* Store an array in uc instead of serialized objects
* PHP 7.4 strictness in some classes
* Simplified inheritance chain
* Drop a service class of little use by merging
  calls to controller
* Avoid another ObjectManager->get() call
* Minor bugfix that a shortcut to 'compare users'
  is not reflected in module menu drop down
* Minor cosmetics

Change-Id: I73bd2f884573807a819e4ae0d68c93897641b0f1
Resolves: #94025
Releases: master
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68924
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2 weeks ago[BUGFIX] Add active class to correct element in EXT:workspaces
Oliver Bartsch [Fri, 30 Apr 2021 00:35:37 +0000 (02:35 +0200)]
[BUGFIX] Add active class to correct element in EXT:workspaces

The tablist inside the element information modal
in the workspaces module did not longer set the
active state on the correct tab item.

This is due to a change in bootstrap 5, since an
active tab is highlighted by setting the `active`
class on the tab item link (`nav-link`) instead of
the tab item (`nav-item`) itself.

This is fixed by adding the `active` class to the
correct element again.

Further reference:
https://getbootstrap.com/docs/5.0/components/navs-tabs

Resolves: #94028
Related: #93119
Releases: master
Change-Id: I21ee8ede69876feef047c6303c4fbe890f898a65
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68928
Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
2 weeks ago[BUGFIX] Resolve WS overlays in Extbase JOIN queries properly
Benni Mack [Thu, 29 Apr 2021 15:52:33 +0000 (17:52 +0200)]
[BUGFIX] Resolve WS overlays in Extbase JOIN queries properly

When having JOINs in SQL selects, which typically happens
when a MM property is resolved via Extbase's ORM, versionOL()
threw an SQL error because versionOL() also queried "uid_local"
which did not exist in e.g. sys_category.

This change splits up the massive "overlayLanguageAndWorkspace()"
method into smaller chunks and takes a different route when
doing workspace overlays for JOINs. By re-fetching the main tables'
record, all known fields can be identified via array_key_intersect()
and then chunked together again with the JOINed information
via array_replace().

The added tests show that the assertion for MM relations now work
(if the fix is not applied, the included tests fail due to a SQL error in tests),
but deliver a wrong result, which will be fixed with
https://review.typo3.org/c/Packages/TYPO3.CMS/+/68913

Resolves: #81208
Resolves: #93484
Releases: master, 10.4
Change-Id: Iaba70be0cf5b7a36ab13380940286628ac976f9a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68915
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Nikita Hovratov <nikita.h@live.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Ralf Merz <mail@merzilla.de>
Reviewed-by: Benni Mack <benni@typo3.org>
2 weeks ago[TASK] Remove clearable related wrap from MFA providers
Oliver Bartsch [Fri, 30 Apr 2021 00:04:18 +0000 (02:04 +0200)]
[TASK] Remove clearable related wrap from MFA providers

The input field of both, TOTP and recovery codes,
was wrapped into a container having `form-control`
and `form-control-clearable` classes set.

Those classes have no effect, since they belong to
the clearable functionality of TYPO3 and will be added
automatically on initialization. Since MFA does not use
this functionality, the container is removed.

Resolves: #94027
Releases: master
Change-Id: I563fd55629f002df3617306a52da20c379cfcd75
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68927
Tested-by: core-ci <typo3@b13.com>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Benni Mack <benni@typo3.org>
2 weeks ago[TASK] Pin fluid standalone dependency to ^2.6.10
Benni Mack [Thu, 29 Apr 2021 18:46:45 +0000 (20:46 +0200)]
[TASK] Pin fluid standalone dependency to ^2.6.10

Various parts of TYPO3 Core are not ready yet
to be used with Fluid Engine 3.0-dev, which
people might accidentally install.

This change sets the fluid dependency back to
^2.6.10

Used commands:

- composer req "typo3fluid/fluid:^2.6.10"
- composer req "typo3fluid/fluid:^2.6.10" -d typo3/sysext/adminpanel --no-update
- composer req "typo3fluid/fluid:^2.6.10" -d typo3/sysext/core --no-update
- composer req "typo3fluid/fluid:^2.6.10" -d typo3/sysext/fluid --no-update
- composer req "typo3fluid/fluid:^2.6.10" -d typo3/sysext/redirects --no-update

Resolves: #91850
Releases: master, 10.4
Change-Id: If46475fd3fdbca3ce23a652a253c0ac28d9a6149
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68919
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
2 weeks ago[DOCS] form: Add {__currentTimestamp} to ApiReference
Markus Klein [Thu, 29 Apr 2021 19:32:41 +0000 (21:32 +0200)]
[DOCS] form: Add {__currentTimestamp} to ApiReference

Add a usage of {__currentTimestamp} to the example in
the ApiReference.

The feature has been added at a later point and is only mentioned
in the concepts, but never in the reference.

Resolves: #94023
Releases: master, 10.4
Change-Id: I4e1568343a8fa56e41f6549b4beae292523b8754
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68920
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
2 weeks ago[BUGFIX] Fix InvalidEnumerationValueException in workspaces
Oliver Bartsch [Thu, 29 Apr 2021 19:55:34 +0000 (21:55 +0200)]
[BUGFIX] Fix InvalidEnumerationValueException in workspaces

Since there is no guard clause, dealing with
non workspace aware records, it's possible
that `t3ver_state` is not set at this point.

To prevent the InvalidEnumerationValueException
on processing the value, the null coalescing operator,
together with a proper typecast is now used.

Resolves: #94024
Releases: master, 10.4
Change-Id: I7cb420dfd887e34a89bd7042ae5c407171907eba
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68922
Tested-by: core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
2 weeks ago[TASK] Avoid ObjectManager->get() in ext:irre_tutorial
Christian Kuhn [Thu, 29 Apr 2021 15:19:44 +0000 (17:19 +0200)]
[TASK] Avoid ObjectManager->get() in ext:irre_tutorial

Releases: master
Resolves: #94022
Related: #90803
Change-Id: If030a4cb6a1015e618f0968dab693ccd4c54640f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68914
Tested-by: core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
2 weeks ago[BUGFIX] Respect default values in TcaGroup
Maik Schneider [Thu, 14 Jan 2021 13:21:39 +0000 (14:21 +0100)]
[BUGFIX] Respect default values in TcaGroup

RelationHandler cannot handle vanilla uids, pass 0 instead to correctly parse defVals for MM-relations in TCA type=group

Resolves: #93289
Releases: master, 10.4, 9.5
Change-Id: I5258bbc5ef164fc9ed2d14ed1062b54e1f9eec92
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67447
Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Maik Schneider <schneider.maik@me.com>
Tested-by: Richard Haeser <richard@richardhaeser.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Maik Schneider <schneider.maik@me.com>
Reviewed-by: Richard Haeser <richard@richardhaeser.com>
2 weeks ago[BUGFIX] Fix and clean up EXT:belog module
Oliver Bartsch [Thu, 29 Apr 2021 13:18:15 +0000 (15:18 +0200)]
[BUGFIX] Fix and clean up EXT:belog module

Fixes
=====

* Fix DateTimePicker by adding the correct format
  as required since updating to flatpickr in #91606
* Restore clearable functionality of DateTime fields
  by adding a new TypeScript Module, which properly
  initializes those fields.
* Unify size of form fields again and fix position
  of the submit button and the `groupByPage` checkbox
* Add bootstrap v5 compatible markup to the `groupByPage`
  checkbox

Cleanup
=======

* Unify UX by using the `actions-calendar` icons,
  like FormEngine does, instead of font awesome.
* Add type annotations and return types, where possible
* Avoid usage of ObjectManager->get()

Resolves: #94020
Releases: master
Change-Id: I5ae684871c7ba5003d6c873604a2ca81067f7f27
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68912
Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
2 weeks ago[TASK] Add ContainerInterface->get() to dynamicReturnTypeMeta.json
Christian Kuhn [Thu, 29 Apr 2021 11:30:47 +0000 (13:30 +0200)]
[TASK] Add ContainerInterface->get() to dynamicReturnTypeMeta.json

Even though ContainerInterface->get() can return 'mixed', it
returns 'object|null' with our symfony DI based implementation.
To help IDE's object resolving, dynamicReturnTypeMeta.json now
declares an instance of the first argument is returned.

Resolves: #94016
Releases: master, 10.4
Change-Id: I67904feb86c4dc421f2038d9352795ce73f062d1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68909
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
2 weeks ago[BUGFIX] Use proper implementation class for PagePositionMap
Benni Mack [Wed, 28 Apr 2021 10:00:14 +0000 (12:00 +0200)]
[BUGFIX] Use proper implementation class for PagePositionMap

The PagePositionMap uses the ElementBrowserPageTreeView
which is a specific implementation for the Element Browser (now unused).

However, the PageTreeView is the correct implementation,
as this is also used in all subclasses of PagePositionMap,
handling links properly for moving records or creating new records / pages.

Resolves: #94006
Releases: master
Change-Id: I1b7de4827732afb201c8bb0ee0a16112df27948e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68900
Tested-by: core-ci <typo3@b13.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>